WebKit-https.git
7 years agoAdd Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.
wangxianzhu@chromium.org [Thu, 26 Apr 2012 17:52:29 +0000 (17:52 +0000)]
Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.

Not reviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] webaudio/audioparam-exponentialRampToValueAtTime.html is occasionally...
dglazkov@chromium.org [Thu, 26 Apr 2012 17:01:00 +0000 (17:01 +0000)]
[Chromium] webaudio/audioparam-exponentialRampToValueAtTime.html is occasionally crashing
https://bugs.webkit.org/show_bug.cgi?id=84972

* platform/chromium/test_expectations.txt: Marked as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlaceholder view is immediately removed from hosting window upon entering full screen.
jer.noble@apple.com [Thu, 26 Apr 2012 16:52:13 +0000 (16:52 +0000)]
Placeholder view is immediately removed from hosting window upon entering full screen.
https://bugs.webkit.org/show_bug.cgi?id=84916

Reviewed by Darin Adler.

Correct a mistake added in r114567.  When swapping view for otherView, add otherView and
remove view (rather than adding otherView and removing otherView).

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController _swapView:with:]):

Source/WebKit2:

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _swapView:with:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Implement the "Disable JavaScript" option in the settings dialog
apavlov@chromium.org [Thu, 26 Apr 2012 16:44:46 +0000 (16:44 +0000)]
Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=84946

Source/WebCore:

Based on user actions in the Inspector frontend, InspectorPageAgent invokes Settings::setScriptEnabled()
for the associated page to switch the script execution therein.

Reviewed by Yury Semikhatsky.

Test: inspector/debugger/disable-script.html

* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
(WebCore):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
* inspector/InspectorPageAgent.h:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype.get _updateScriptDisabledCheckbox):
(WebInspector.SettingsScreen.prototype._javaScriptDisabledChanged):
* inspector/front-end/inspector.js:

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/debugger/disable-script-expected.txt: Added.
* inspector/debugger/disable-script.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
carlosgc@webkit.org [Thu, 26 Apr 2012 16:19:41 +0000 (16:19 +0000)]
[GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
https://bugs.webkit.org/show_bug.cgi?id=84957

Reviewed by Martin Robinson.

* Scripts/run-gtk-tests:
(TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
TestNewFirstVisuallyNonEmptyLayoutForImages.
* TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
toplevel window containing the web view to make sure events are
received.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[cairo] CairoGraphicsContext fillRect (with Color) overrides composite operator
commit-queue@webkit.org [Thu, 26 Apr 2012 16:13:41 +0000 (16:13 +0000)]
[cairo] CairoGraphicsContext fillRect (with Color) overrides composite operator
https://bugs.webkit.org/show_bug.cgi?id=84848

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-26
Reviewed by Martin Robinson.

Source/WebCore:

FillRectWithColor used to be called fillRectSourceOver before r89314
where this operator still made sense. The way this function is used
these days doesn't expect the composite operator to be overridden anymore.

No new tests, covered by existing tests, e.g.
svg/filters/feDropShadow.svg

* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::fillRectWithColor):

LayoutTests:

Unskipping and baselining feDropShadow test,
now works because of composite operator fix.
Fixed png baseline result for drop shadow test on GTK.

* platform/efl/svg/filters/feDropShadow-expected.png: Added.
* platform/efl/svg/filters/feDropShadow-expected.txt: Added.
* platform/efl/test_expectations.txt:
* platform/gtk/svg/filters/feDropShadow-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix additive by animations for most SMIL list types
zimmermann@webkit.org [Thu, 26 Apr 2012 15:51:58 +0000 (15:51 +0000)]
Fix additive by animations for most SMIL list types
https://bugs.webkit.org/show_bug.cgi?id=84968

Reviewed by Antti Koivisto.

Source/WebCore:

Unify SMIL list animation code, to correctly respect the underlying from value for by-animations.
Add lots of new tests covering by-animations for all primitives (except AnimatedPath/TransformList).
AnimatedTransformList is not working correctly yet, and will be covered in a follow-up patch.
AnimatdPath by-animations are complex, and thus also handled in another follow-up patch.

Tests: svg/animations/additive-type-by-animation.html
       svg/animations/length-list-animation-expected.svg
       svg/animations/length-list-animation.svg
       svg/animations/svglength-additive-by-1.html
       svg/animations/svglength-additive-by-2.html
       svg/animations/svglength-additive-by-3.html
       svg/animations/svglength-additive-by-4.html
       svg/animations/svglength-additive-by-5.html
       svg/animations/svglength-additive-by-6.html
       svg/animations/svglength-additive-from-by-1.html
       svg/animations/svglength-additive-from-by-2.html
       svg/animations/svglength-additive-from-by-3.html
       svg/animations/svglength-additive-from-by-4.html

* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):
* svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::adjustFromToListValues):

LayoutTests:

Add lots of new tests covering SMIL by-animations on all primitives.

* svg/animations/additive-type-by-animation-expected.txt: Added.
* svg/animations/additive-type-by-animation.html: Added.
* svg/animations/length-list-animation-expected.svg: Added.
* svg/animations/length-list-animation.svg: Added.
* svg/animations/non-additive-type-by-animation-expected.txt:
* svg/animations/resources/additive-type-by-animation.svg: Added.
* svg/animations/resources/non-additive-type-by-animation.svg:
* svg/animations/resources/svglength-additive-by-1.svg: Added.
* svg/animations/resources/svglength-additive-by-2.svg: Added.
* svg/animations/resources/svglength-additive-by-3.svg: Added.
* svg/animations/resources/svglength-additive-by-4.svg: Added.
* svg/animations/resources/svglength-additive-by-5.svg: Added.
* svg/animations/resources/svglength-additive-by-6.svg: Added.
* svg/animations/resources/svglength-additive-from-by-1.svg: Added.
* svg/animations/resources/svglength-additive-from-by-2.svg: Added.
* svg/animations/resources/svglength-additive-from-by-3.svg: Added.
* svg/animations/resources/svglength-additive-from-by-4.svg: Added.
* svg/animations/script-tests/additive-type-by-animation.js: Added.
(checkBaseVal):
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/non-additive-type-by-animation.js:
(sample):
* svg/animations/script-tests/svglength-additive-by-1.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
* svg/animations/script-tests/svglength-additive-by-2.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
* svg/animations/script-tests/svglength-additive-by-3.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/script-tests/svglength-additive-by-4.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/script-tests/svglength-additive-by-5.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/script-tests/svglength-additive-by-6.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/script-tests/svglength-additive-from-by-1.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
* svg/animations/script-tests/svglength-additive-from-by-2.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/script-tests/svglength-additive-from-by-3.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/script-tests/svglength-additive-from-by-4.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/svglength-additive-by-1-expected.txt: Added.
* svg/animations/svglength-additive-by-1.html: Added.
* svg/animations/svglength-additive-by-2-expected.txt: Added.
* svg/animations/svglength-additive-by-2.html: Added.
* svg/animations/svglength-additive-by-3-expected.txt: Added.
* svg/animations/svglength-additive-by-3.html: Added.
* svg/animations/svglength-additive-by-4-expected.txt: Added.
* svg/animations/svglength-additive-by-4.html: Added.
* svg/animations/svglength-additive-by-5-expected.txt: Added.
* svg/animations/svglength-additive-by-5.html: Added.
* svg/animations/svglength-additive-by-6-expected.txt: Added.
* svg/animations/svglength-additive-by-6.html: Added.
* svg/animations/svglength-additive-from-by-1-expected.txt: Added.
* svg/animations/svglength-additive-from-by-1.html: Added.
* svg/animations/svglength-additive-from-by-2-expected.txt: Added.
* svg/animations/svglength-additive-from-by-2.html: Added.
* svg/animations/svglength-additive-from-by-3-expected.txt: Added.
* svg/animations/svglength-additive-from-by-3.html: Added.
* svg/animations/svglength-additive-from-by-4-expected.txt: Added.
* svg/animations/svglength-additive-from-by-4.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd copy constructor to CSSSelector
antti@apple.com [Thu, 26 Apr 2012 15:43:45 +0000 (15:43 +0000)]
Add copy constructor to CSSSelector
https://bugs.webkit.org/show_bug.cgi?id=84956

Reviewed by Anders Carlsson.

To copy CSSSelectorLists correctly CSSSelector needs a copy constructor.

This will be needed to implement stylesheet caching. The code is not used yet.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::createRareData):
* css/CSSSelector.h:
(CSSSelector):
(WebCore::CSSSelector::RareData::create):
(RareData):

    Refcount RareData to make copying easier. This has no significant memory impact, rare data is rare.

(WebCore::CSSSelector::CSSSelector):
(WebCore):
(WebCore::CSSSelector::~CSSSelector):
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):

    Use copy constructor instead of memcpy (which doesn't work).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix the build with DRAG_SUPPORT disabled.
rakuco@webkit.org [Thu, 26 Apr 2012 15:15:43 +0000 (15:15 +0000)]
[EFL] Fix the build with DRAG_SUPPORT disabled.
https://bugs.webkit.org/show_bug.cgi?id=84963

Reviewed by Antonio Gomes.

No new tests, build system-related change.

EventHandlerEfl.cpp always assumed DRAG_SUPPORT was enabled and lacked
the proper #if ENABLED() checks for some member variables and methods
conditionally defined in EventHandler.h.

* page/efl/EventHandlerEfl.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove stackTrace property from requestWillBeSent - it is already...
pfeldman@chromium.org [Thu, 26 Apr 2012 15:14:27 +0000 (15:14 +0000)]
Web Inspector: remove stackTrace property from requestWillBeSent - it is already a part of the initiator.
https://bugs.webkit.org/show_bug.cgi?id=84964

Reviewed by Yury Semikhatsky.

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSVG FEConvolveMatrix does not check for invalid property values
schenney@chromium.org [Thu, 26 Apr 2012 15:06:01 +0000 (15:06 +0000)]
SVG FEConvolveMatrix does not check for invalid property values
https://bugs.webkit.org/show_bug.cgi?id=84363

Reviewed by Dirk Schulze.

Source/WebCore:

Adding code to check for valid input values on SVG feConvolveMatrix properties.
And adding some of the first effective error reporting for SVG elements.

Tests: svg/filters/feConvolveMatrix-invalid-targetX-expected.svg
       svg/filters/feConvolveMatrix-invalid-targetX.svg
       svg/filters/feConvolveMatrix-invalid-targetY-expected.svg
       svg/filters/feConvolveMatrix-invalid-targetY.svg
       svg/filters/feConvolveMatrix-negative-kernelUnitLengthX-expected.svg
       svg/filters/feConvolveMatrix-negative-kernelUnitLengthX.svg
       svg/filters/feConvolveMatrix-negative-kernelUnitLengthY-expected.svg
       svg/filters/feConvolveMatrix-negative-kernelUnitLengthY.svg
       svg/filters/feConvolveMatrix-negative-orderX-expected.svg
       svg/filters/feConvolveMatrix-negative-orderX.svg
       svg/filters/feConvolveMatrix-negative-orderY-expected.svg
       svg/filters/feConvolveMatrix-negative-orderY.svg
       svg/filters/feConvolveMatrix-non-integral-order-expected.svg
       svg/filters/feConvolveMatrix-non-integral-order.svg
       svg/filters/feConvolveMatrix-zero-divisor-expected.svg
       svg/filters/feConvolveMatrix-zero-divisor.svg

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::setKernelSize):
(WebCore::FEConvolveMatrix::setDivisor):
(WebCore::FEConvolveMatrix::setKernelUnitLength):
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::parseAttribute):
(WebCore::SVGFEConvolveMatrixElement::build):

LayoutTests:

Adding code to check for valid input values on SVG feConvolveMatrix properties.

* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/efl/svg/filters/feConvolveFilter-y-bounds-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/gtk/svg/custom/convolution-crash-expected.txt:
* platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/mac/svg/custom/convolution-crash-expected.txt:
* platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/qt/svg/custom/convolution-crash-expected.txt:
* platform/qt/svg/filters/feConvolveFilter-y-bounds-expected.txt:
* svg/filters/feConvolveMatrix-invalid-targetX-expected.svg: Added.
* svg/filters/feConvolveMatrix-invalid-targetX.svg: Added.
* svg/filters/feConvolveMatrix-invalid-targetY-expected.svg: Added.
* svg/filters/feConvolveMatrix-invalid-targetY.svg: Added.
* svg/filters/feConvolveMatrix-negative-kernelUnitLengthX-expected.svg: Added.
* svg/filters/feConvolveMatrix-negative-kernelUnitLengthX.svg: Added.
* svg/filters/feConvolveMatrix-negative-kernelUnitLengthY-expected.svg: Added.
* svg/filters/feConvolveMatrix-negative-kernelUnitLengthY.svg: Added.
* svg/filters/feConvolveMatrix-negative-orderX-expected.svg: Added.
* svg/filters/feConvolveMatrix-negative-orderX.svg: Added.
* svg/filters/feConvolveMatrix-negative-orderY-expected.svg: Added.
* svg/filters/feConvolveMatrix-negative-orderY.svg: Added.
* svg/filters/feConvolveMatrix-non-integral-order-expected.svg: Added.
* svg/filters/feConvolveMatrix-non-integral-order.svg: Added.
* svg/filters/feConvolveMatrix-zero-divisor-expected.svg: Added.
* svg/filters/feConvolveMatrix-zero-divisor.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add bug numbers to skipped tests.
carlosgc@webkit.org [Thu, 26 Apr 2012 15:01:04 +0000 (15:01 +0000)]
Unreviewed. Add bug numbers to skipped tests.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Build and run TestWebKitAPI WebKit2 unit tests
carlosgc@webkit.org [Thu, 26 Apr 2012 14:47:39 +0000 (14:47 +0000)]
[GTK] Build and run TestWebKitAPI WebKit2 unit tests
https://bugs.webkit.org/show_bug.cgi?id=84446

Reviewed by Philippe Normand.

Source/ThirdParty:

* gtest/GNUmakefile.am: Do not build libgtestmain anymmore since
all tests use now a custom main to make sure WTF threads are
initialized.

Source/WebKit2:

* UIProcess/API/C/WKNativeEvent.h: Define WKNativeEventPtr as
GdkEvent for the GTK+ port.

Tools:

* Scripts/run-gtk-tests:
(TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
containing tests. Unskip FunctionalTest.RefCountedStorage, since
we are now using a custom main that initializes WTF threading.
(TestRunner._setup_testing_environment): Set environment variables
required to run WebKit2 tests.
* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/JavaScriptTest.cpp: Use
JavaScriptCore/JSContextRef.h instead of
JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
unconditionally.
* TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and
PlatformWindow for GTK.
* TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove
unneded header that breaks the build of GTK port.
* TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use
JavaScriptCore/JSContextRef.h instead of
JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
unconditionally.
* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST): Add expected values for GTK+ port.
* TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:
(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.
(TestWebKitAPI::Util::checkTestFinished):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):
(TestWebKitAPI::Util::isKeyDown):
* TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::doKeyStroke):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::doMouseButtonEvent):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
* TestWebKitAPI/gtk/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
carlosgc@webkit.org [Thu, 26 Apr 2012 14:45:10 +0000 (14:45 +0000)]
[GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
https://bugs.webkit.org/show_bug.cgi?id=84695

Reviewed by Philippe Normand.

It also adds a command line option to be able to pass a custom
timeout value, instead of hard-coding it. The default timeout is 10
seconds if no other value is passed to the script.

* Scripts/run-gtk-tests:
(TestTimeout): Exception raised when a test times out.
(TestRunner._get_child_pid_from_test_output): Helper function to
get the pid of the running test from gtester output.
(TestRunner._kill_process): Helper funtion ot kill a process
ignoring exceptions if the process is already died.
(TestRunner._run_test_command): Run the test command raising
TestTimeout exception if the test doesn't finish before the given
timeout in seconds.
(TestRunner._run_test_command.alarm_handler): Alarm handler that
raises TestTimeout exception.
(TestRunner._run_test_glib): Use _run_test_command() to run the test.
(TestRunner._run_test_google): Ditto.
(TestRunner.run_tests): Add current test to the list of timed out
test if TestTimeout exception is raised. Show the list of timed
out test at the end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove WebKit1 specific conversion of touch-events to WebKit1.
commit-queue@webkit.org [Thu, 26 Apr 2012 14:30:17 +0000 (14:30 +0000)]
Move WebKit1 specific conversion of touch-events to WebKit1.
https://bugs.webkit.org/show_bug.cgi?id=84951

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No change in functionality. No new tests.

* Target.pri:
* platform/PlatformTouchEvent.h:
(PlatformTouchEvent):
* platform/PlatformTouchPoint.h:
(PlatformTouchPoint):
* platform/qt/PlatformTouchEventQt.cpp: Removed.
* platform/qt/PlatformTouchPointQt.cpp: Removed.

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::touchEvent):
* WebCoreSupport/WebEventConversion.cpp:
(WebKitPlatformTouchEvent):
(WebKitPlatformTouchPoint):
(WebCore::WebKitPlatformTouchEvent::WebKitPlatformTouchEvent):
(WebCore::WebKitPlatformTouchPoint::WebKitPlatformTouchPoint):
(WebCore::convertTouchEvent):
* WebCoreSupport/WebEventConversion.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Tap highlight should have a delay not to interfere with panning
abecsi@webkit.org [Thu, 26 Apr 2012 14:11:44 +0000 (14:11 +0000)]
[Qt][WK2] Tap highlight should have a delay not to interfere with panning
https://bugs.webkit.org/show_bug.cgi?id=84948

Reviewed by Kenneth Rohde Christiansen.

Start the tap highlight animation after a slight delay so that pan
gestures do not result in flashing highlight rects which slow down
flicking, especially during continuous pan gestures.

* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::highlightTimeout):
(WebKit):
(WebKit::QtTapGestureRecognizer::reset):
(WebKit::QtTapGestureRecognizer::timerEvent):
* UIProcess/qt/QtTapGestureRecognizer.h:
(QtTapGestureRecognizer):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake it possible to use accelerated compositing for page overlay fading
commit-queue@webkit.org [Thu, 26 Apr 2012 14:06:39 +0000 (14:06 +0000)]
Make it possible to use accelerated compositing for page overlay fading
https://bugs.webkit.org/show_bug.cgi?id=82336

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-04-26
Reviewed by Noam Rosenthal.

Page overlay fading will use AC where possible.  Otherwise, it will
fall back to the previous method of redrawing each frame in the animation.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setPageOverlayOpacity):
(DrawingArea):
(WebKit::DrawingArea::pageOverlayShouldApplyFadeWhenPainting):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setPageOverlayOpacity):
(WebKit):
(WebKit::DrawingAreaImpl::pageOverlayShouldApplyFadeWhenPainting):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setPageOverlayOpacity):
(WebKit::LayerTreeHost::pageOverlayShouldApplyFadeWhenPainting):
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::PageOverlay):
(WebKit::PageOverlay::setPage):
(WebKit::PageOverlay::fadeAnimationTimerFired):
* WebProcess/WebPage/PageOverlay.h:
* WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::drawRect):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setPageOverlayOpacity):
(WebKit):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
(WebKit::LayerTreeHostQt::pageOverlayShouldApplyFadeWhenPainting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Unskip media tests that were already fixed in r113178
commit-queue@webkit.org [Thu, 26 Apr 2012 14:05:42 +0000 (14:05 +0000)]
[EFL][DRT] Unskip media tests that were already fixed in r113178
https://bugs.webkit.org/show_bug.cgi?id=84947

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-26

* platform/efl/Skipped: Removed a group of media tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] A quick fix to the previous patch r115245.
commit-queue@webkit.org [Thu, 26 Apr 2012 13:55:31 +0000 (13:55 +0000)]
[BlackBerry] A quick fix to the previous patch r115245.
https://bugs.webkit.org/show_bug.cgi?id=84862

Patch by Yong Li <yoli@rim.com> on 2012-04-26
Reviewed by Antonio Gomes.

Fix an obvious bug in previous patch: DeferredTaskLoadManualScript
was using a wrong flag.

* Api/WebPage.cpp:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntr...
commit-queue@webkit.org [Thu, 26 Apr 2012 13:43:08 +0000 (13:43 +0000)]
[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=83880

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-26
Reviewed by Antonio Gomes.

Tools:

Add missing implementation addOriginAccessWhitelistEntry and
removeOriginAccessWhitelistEntry to EFL's LayoutTestController
in order to unskip tests which rely on this.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):

LayoutTests:

Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
and removeOriginAccessWhitelistEntry implementation.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] WebGL support ewk_view setting
commit-queue@webkit.org [Thu, 26 Apr 2012 13:34:04 +0000 (13:34 +0000)]
[EFL] WebGL support ewk_view setting
https://bugs.webkit.org/show_bug.cgi?id=84534

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-04-26
Reviewed by Antonio Gomes.

Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_webgl_get):
(ewk_view_setting_enable_webgl_set):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShare code used to animate numbers types between all animators
zimmermann@webkit.org [Thu, 26 Apr 2012 13:14:34 +0000 (13:14 +0000)]
Share code used to animate numbers types between all animators
https://bugs.webkit.org/show_bug.cgi?id=84945

Reviewed by Antti Koivisto.

Refactor animateAdditiveNumber() from SVGAnimatedNumberAnimator into SVGAnimationElement,
to reuse it for all primitives. Converted most primitives to use the new code. Lists, paths,
colors are still todo.

Doesn't affect any tests.

* svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
* svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
* svg/SVGAnimatedInteger.h:
(SVGAnimatedIntegerAnimator):
* svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumber.h:
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumberOptionalNumber.h:
* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):
* svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::animateAdditiveNumber):
(SVGAnimationElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] r115300 broke the Qt build on Mac OS X.
ahf@0x90.dk [Thu, 26 Apr 2012 11:52:15 +0000 (11:52 +0000)]
[Qt] r115300 broke the Qt build on Mac OS X.

This patch adds guards around the createPluginContainer and
windowedPluginGeometryDidChange member functions in WebPageProxy.

Unreviewed build fix.

* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CRASH] WebViewImpl::setZoomLevel when emulating device metrics
apavlov@chromium.org [Thu, 26 Apr 2012 11:51:59 +0000 (11:51 +0000)]
Web Inspector: [CRASH] WebViewImpl::setZoomLevel when emulating device metrics
https://bugs.webkit.org/show_bug.cgi?id=84938

Check for the presence of a live Frame/FrameView before invoking methods that depend on them.

Reviewed by Yury Semikhatsky.

* src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::restore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForgotten build fix after r115227.
rniwa@webkit.org [Thu, 26 Apr 2012 11:45:15 +0000 (11:45 +0000)]
Forgotten build fix after r115227.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::get4Values):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add downloads support to MiniBrowser
carlosgc@webkit.org [Thu, 26 Apr 2012 11:01:19 +0000 (11:01 +0000)]
[GTK] Add downloads support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=73662

Reviewed by Philippe Normand.

* MiniBrowser/gtk/BrowserDownloadsBar.c: Added.
(browserDownloadsBarChildRemoved): Close the downloads bar if
there aren't active downloads.
(browserDownloadsBarResponse): Destroy the downloads bar when
closed.
(browser_downloads_bar_init):
(browser_downloads_bar_class_init):
(browser_downloads_bar_new): Create a new downloads bar.
(actionButtonClicked): Cancel the download if cancel button was
clicked, or open the downloaded file if the download finished.
(browserDownloadFinalize):
(browser_download_init):
(browser_download_class_init):
(downloadReceivedResponse): Update download message using the
response URI.
(remainingTime): Helper function to get human readable remaining
time.
(downloadProgress): Update downloads progress.
(downloadReceivedData):
(downloadFinished): Update download message and turn download
button into open.
(downloadFailed): Show error message or destroy the download UI if
it was cancelled.
(browserDownloadNew): Create a new download widget for the given
WebKitDownload.
(browser_downloads_bar_add_download): Add download widget to the
downloads bar.
* MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
* MiniBrowser/gtk/BrowserWindow.c:
(downloadStarted): Create a download widget and add it to the
downloads bar when a new download is started.
(browserWindowConstructed): Connect to
WebKitWebContext::download-started signal.
* MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WebKit2] Initial windowed plugins implementation
carlosgc@webkit.org [Thu, 26 Apr 2012 10:58:03 +0000 (10:58 +0000)]
[GTK][WebKit2] Initial windowed plugins implementation
https://bugs.webkit.org/show_bug.cgi?id=61065

Reviewed by Philippe Normand.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::createPluginContainer):
(WebKit::PluginControllerProxy::windowedPluginGeometryDidChange):
* PluginProcess/PluginControllerProxy.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerAdd): Implement GtkContainer::add().
(webkitWebViewBaseContainerRemove): Implement GtkContainer::remove().
(webkitWebViewBaseContainerForall): Implement GtkContainer::forall().
(webkitWebViewBaseChildMoveResize): Set a new geometry for a child widget.
(webkitWebViewBaseChildAllocate): Allocate a child widget.
(resizeWebKitWebViewBaseFromAllocation): Allocate child widgets.
(webkit_web_view_base_class_init):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add webkitWebViewBaseSizeAllocate().
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Add createPluginContainer
and windowedPluginGeometryDidChange messages.
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::pluginWindowMap):
(WebKit::pluginContainerPlugRemoved): Remove the socket from the
hash map when its plug is removed.
(WebKit::WebPageProxy::createPluginContainer): Create a GtkSocket
as container widget for windowed plugins.
(WebKit::WebPageProxy::windowedPluginGeometryDidChange): Call
webkitWebViewBaseSizeAllocate() to update the plugin widget
geometry.
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::createPluginContainer):
(WebKit::WebPageProxy::windowedPluginGeometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::socketPlugRemovedCallback): Return TRUE to avoid the
socket to be destroyed, since we need to reuse it.
(WebKit::NetscapePlugin::platformPostInitializeWindowed): Ask the
ui process to create a plugin container.
(WebKit::NetscapePlugin::platformPostInitializeWindowless):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformGeometryDidChange): For windowed
plugins notify the ui process that the plugin geometry has
changed.
(WebKit::NetscapePlugin::platformPaint): Do nothing for windowed
plugins, the caller already calls callSetWindow().
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::createPluginContainer):
(WebKit::PluginProxy::windowedPluginGeometryDidChange):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginProxy.messages.in:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::createPluginContainer):
(WebKit::PluginView::windowedPluginGeometryDidChange):
* WebProcess/Plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp/tests/security/cross-frame-access-put.html is failing
commit-queue@webkit.org [Thu, 26 Apr 2012 10:27:44 +0000 (10:27 +0000)]
http/tests/security/cross-frame-access-put.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82751

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-26
Reviewed by Kentaro Hara.

* http/tests/security/cross-frame-access-put-expected.txt: Correct
expected value for window.frameElement. It is now 'null' instead of
'undefined' when shouldAllowAccessToNode() check fails, since bug
80205 fix.
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Removed.
It is now identifical to the global expectation.
* platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed. Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skip unit test failing in debug bot.
carlosgc@webkit.org [Thu, 26 Apr 2012 08:32:10 +0000 (08:32 +0000)]
Unreviewed. Skip unit test failing in debug bot.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when collecting svg symbol element in named flow.
mihnea@adobe.com [Thu, 26 Apr 2012 07:59:09 +0000 (07:59 +0000)]
Crash when collecting svg symbol element in named flow.
https://bugs.webkit.org/show_bug.cgi?id=84493

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/symbol-in-named-flow-crash.svg

* dom/Element.cpp:
(WebCore::Element::~Element):
Add an assert that an element that was collected into a named flow was already removed at this point
(when the document is not in the process of destruction)
(WebCore::Element::unregisterNamedFlowContentNode):
Created a new function for unregistering a content node. In the future, this function may be used for
content nodes from shadow dom.
(WebCore::Element::detach):
* dom/Element.h:
(Element):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
Prevent elements that are part of shadow dom to be collected into a named flow.

LayoutTests:

* fast/regions/symbol-in-named-flow-crash-expected.txt: Added.
* fast/regions/symbol-in-named-flow-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShare code used to animate discrete types between all animators
zimmermann@webkit.org [Thu, 26 Apr 2012 07:52:42 +0000 (07:52 +0000)]
Share code used to animate discrete types between all animators
https://bugs.webkit.org/show_bug.cgi?id=84853

Reviewed by Andreas Kling.

Source/WebCore:

Share by-animation handling for non-additive types in a central method in SVGAnimatedTypeAnimator,
to be reusable by SVGAnimatedBoolean/Enumeration/PreserveAspectRatio/String. Add a new test covering
these animations have no effect.

Test: svg/animations/non-additive-type-by-animation.html

* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::isAdditive):
* svg/SVGAnimateElement.h:
(SVGAnimateElement):
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues):
* svg/SVGAnimatedBoolean.cpp:
(WebCore::isTrueString):
(WebCore::SVGAnimatedBooleanAnimator::constructFromString):
(WebCore::SVGAnimatedBooleanAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):
* svg/SVGAnimatedEnumeration.cpp:
(WebCore::SVGAnimatedEnumerationAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):
* svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
* svg/SVGAnimationElement.h:
(SVGAnimationElement):
(WebCore::SVGAnimationElement::animateDiscreteType):

LayoutTests:

Add tests covering by-animation on non-additive types, which should have no effect.

* svg/animations/non-additive-type-by-animation-expected.txt: Added.
* svg/animations/non-additive-type-by-animation.html: Added.
* svg/animations/resources/non-additive-type-by-animation.svg: Added.
* svg/animations/script-tests/non-additive-type-by-animation.js: Added.
(sample):
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrashTracer: [USER] 157 crashes in WebProcess at com.apple.WebCore: WebCore::Accessib...
cfleizach@apple.com [Thu, 26 Apr 2012 07:37:19 +0000 (07:37 +0000)]
CrashTracer: [USER] 157 crashes in WebProcess at com.apple.WebCore: WebCore::AccessibilityRenderObject::isAttachment const + 29
https://bugs.webkit.org/show_bug.cgi?id=84463

Reviewed by Darin Adler.

Source/WebCore:

Accessibility was not being enabled when WK2 was asking only for the focused UI element.

No layout test could be written because the WKTestRunner mechanism works differently when asking for this.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::rootObjectForFrame):

Source/WebKit2:

* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] "resource,request,willsend" signal needs to provide more information
commit-queue@webkit.org [Thu, 26 Apr 2012 07:09:31 +0000 (07:09 +0000)]
[EFL][DRT] "resource,request,willsend" signal needs to provide more information
https://bugs.webkit.org/show_bug.cgi?id=84670

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-26
Reviewed by Andreas Kling.

Source/WebKit/efl:

The "resource,request,willsend" signal now provides more information
about the network request as well as information about the possible
redirect response. This extra information will be needed to support
LayoutTestController's dumpResourceLoadCallbacks() in EFL's
DumpRenderTree.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
* ewk/ewk_frame.cpp:
(ewk_frame_request_will_send):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.h:

Tools:

Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
passed with the "resource,request,willsend" signal and dump
information about the network request and the possible network
response if LayoutTestController's dumpResourceLoadCallbacks() returns
true.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(pathSuitableForTestResult):
(urlSuitableForTestResult):
(descriptionSuitableForTestResult):
(DumpRenderTreeChrome::onWillSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
ossy@webkit.org [Thu, 26 Apr 2012 07:02:30 +0000 (07:02 +0000)]
[Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
http://trac.webkit.org/changeset/113703
https://bugs.webkit.org/show_bug.cgi?id=83024

Tools:

* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* Tools.pro:
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/functions.prf:

LayoutTests:

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTeach LayoutTestHelper to correctly restore the color profile when it's a factory...
mjs@apple.com [Thu, 26 Apr 2012 06:27:07 +0000 (06:27 +0000)]
Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
https://bugs.webkit.org/show_bug.cgi?id=84931

Reviewed by Filip Pizlo.

* DumpRenderTree/mac/LayoutTestHelper.m:
(installLayoutTestColorProfile): Account for the possibility of the default
profile being a factory profile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove guarded virtual methods from WebFilterOperation API
danakj@chromium.org [Thu, 26 Apr 2012 05:44:22 +0000 (05:44 +0000)]
[chromium] Remove guarded virtual methods from WebFilterOperation API
https://bugs.webkit.org/show_bug.cgi?id=84926

Reviewed by James Robinson.

Source/Platform:

We remove the virtual methods from the WebFilterOperation class,
and use an enum in the base class to distinguish which subclass
the object is. Then WebFilterOperations can access the correct
subclass to get the filter operation's data and construct a
WebCore::FilterOperation to store internally.

* chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::WebFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):

Source/WebCore:

* WebCore.gypi:
* platform/chromium/support/WebFilterOperation.cpp: Removed.
* platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::append):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a version of StringImpl::find() without offset
benjamin@webkit.org [Thu, 26 Apr 2012 05:27:52 +0000 (05:27 +0000)]
Add a version of StringImpl::find() without offset
https://bugs.webkit.org/show_bug.cgi?id=83968

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Add support for the new StringImpl::find() to UString.

Change stringProtoFuncIndexOf() to specifically take advatage of the feature.
This gives a 12% gains on a distribution of strings between 30 and 100 characters.

* runtime/StringPrototype.cpp:
(JSC::substituteBackreferences):
(JSC::stringProtoFuncIndexOf):
* runtime/UString.h:
(UString):
(JSC::UString::find):

Source/WebCore:

Reviewed by Sam Weinig.

Remove the zero offset of the find() functions on strings.

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
* platform/network/ResourceResponseBase.cpp:
(WebCore::trimToNextSeparator):
(WebCore::parseCacheHeader):

Source/WebKit2:

Update the symbols files.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

Source/WTF:

Reviewed by Sam Weinig.

This patch add a version of StringImpl::find() without offset, Instead of using the default
value for the index.

By not having the index, we can skip a couple of branches and a few instructions. This gives
significant gains when the strings are short-ish.

The case of empty string is moved below (matchLength == 1) since it is a less common operation.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
(WTF):
* wtf/text/StringImpl.h:
(StringImpl):
* wtf/text/WTFString.h:
(String):
(WTF::String::find):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Blackberry] add a new function in BackingStore
commit-queue@webkit.org [Thu, 26 Apr 2012 05:17:44 +0000 (05:17 +0000)]
[Blackberry] add a new function in BackingStore
https://bugs.webkit.org/show_bug.cgi?id=84818

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-04-25
Reviewed by Antonio Gomes.

Adding two functions in BackingStorePrivate and
BackingStore, which could render out webpage contents
into BlackBerry::Platform::Graphics::Drawable.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStore::drawContents):
* Api/BackingStore.h:
* Api/BackingStore_p.h:
(BackingStorePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore shouldn't call collectAllGarbage directly
mhahnenberg@apple.com [Thu, 26 Apr 2012 05:08:06 +0000 (05:08 +0000)]
WebCore shouldn't call collectAllGarbage directly
https://bugs.webkit.org/show_bug.cgi?id=84897

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Exported symbol
for reportAbanondedObjectGraph so WebCore can use it.
* heap/Heap.h: Ditto.

Source/WebCore:

No new tests.

Currently, GCController calls Heap::collectAllGarbage directly, which leads
to an overload of collections as the timer in GCController and the timer in
GCActivityCallback compete for collection time and fire independently. As a
result, we end up doing almost 600 full collections during an in-browser run
of SunSpider, or 20 full collections on a single load of TechCrunch.

We can do better by preventing WebCore from calling collectAllGarbage directly
and instead going through Heap::reportAbandonedObjectGraph, since that is what
WebCore is trying to do--notify the Heap that a lot of garbage may have just
been generated when we left a page.

* WebCore.exp.in:
* bindings/js/GCController.cpp: Removed all timer stuff.
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon): Changed to call Heap::reportAbandonedObjectGraph.
(WebCore::GCController::garbageCollectNow): Changed to still directly call collectAllGarbage.
We will deprecate this function soon hopefully.
* bindings/js/GCController.h: Removed timer stuff.
(GCController):
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectGarbage): Changed to call garbageCollectSoon.

Source/WebKit2:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose): Changed to call garbageCollectSoon. This is the
function that causes us to do so much collection on page navigation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/js/random-array-gc-stress times out in debug mode
mhahnenberg@apple.com [Thu, 26 Apr 2012 05:07:31 +0000 (05:07 +0000)]
fast/js/random-array-gc-stress times out in debug mode
https://bugs.webkit.org/show_bug.cgi?id=84821

Reviewed by Geoffrey Garen.

* fast/js/script-tests/random-array-gc-stress.js: Trying a lower number of iterations
to make the slow bots happy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115240.
ossy@webkit.org [Thu, 26 Apr 2012 04:57:07 +0000 (04:57 +0000)]
Unreviewed, rolling out r115240.
http://trac.webkit.org/changeset/115240
https://bugs.webkit.org/show_bug.cgi?id=84928

It broke everything (Requested by Ossy_HOME on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-25

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver):
(GtkDriver._start):
(GtkDriver._start.x_filter):
(GtkDriver.stop):
(GtkPort._driver_class):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] REGRESSION(112286) Compositor initialization blocks for program compilatio...
commit-queue@webkit.org [Thu, 26 Apr 2012 04:50:28 +0000 (04:50 +0000)]
[chromium] REGRESSION(112286) Compositor initialization blocks for program compilation / linking
https://bugs.webkit.org/show_bug.cgi?id=84822

Patch by James Robinson <jamesr@chromium.org> on 2012-04-25
Reviewed by Adrienne Walker.

Source/WebCore:

r112286 introduced a subtle regression in the chromium compositor startup sequence - by querying the texture
copy program's uniform location at the end of LayerRendererChromium::initialize(), the compositor's thread was
blocked until the service side compiled _all_ eagerly initialized shaders. The intent of the way the compositor
programs are created is that a set of commonly-used programs are sent to the service side, but no blocking calls
are made until after we go through the first paint (with the hope that the service side will complete the
compilation by then).

Fixed by moving program initialization (which also grabs uniform locations) until the first actual use of the
copier. It may be worth deferring the program initialization completely if it's not used very often.

Added unit test in LayerRendererChromiumTests to make sure LRC initialization does not make any
synchronous calls (like getUniformLocation()).

* platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):

Source/WebKit/chromium:

Add a test that makes sure we don't make blocking calls during LayerRendererChromium initialization.

* tests/LayerRendererChromiumTest.cpp:
(ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::finish):
(ForbidSynchronousCallContext::getActiveAttrib):
(ForbidSynchronousCallContext::getActiveUniform):
(ForbidSynchronousCallContext::getAttachedShaders):
(ForbidSynchronousCallContext::getAttribLocation):
(ForbidSynchronousCallContext::getBooleanv):
(ForbidSynchronousCallContext::getBufferParameteriv):
(ForbidSynchronousCallContext::getContextAttributes):
(ForbidSynchronousCallContext::getError):
(ForbidSynchronousCallContext::getFloatv):
(ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Authenticated proxy isn't working.
commit-queue@webkit.org [Thu, 26 Apr 2012 04:03:27 +0000 (04:03 +0000)]
[BlackBerry] Authenticated proxy isn't working.
https://bugs.webkit.org/show_bug.cgi?id=84579

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-25
Reviewed by Antonio Gomes.

We should try to get username and password from WiFi advanced configuration first
when 407 is received.

No new tests. This is covered by existing http tests when proxy's username and password
are configured for WiFi.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline *.png pixel test files after bug 84649 fix
commit-queue@webkit.org [Thu, 26 Apr 2012 02:26:05 +0000 (02:26 +0000)]
Rebaseline *.png pixel test files after bug 84649 fix
https://bugs.webkit.org/show_bug.cgi?id=84905

Patch by David Barton <dbarton@mathscribe.com> on 2012-04-25
Reviewed by Beth Dakin.

* platform/mac/mathml/presentation/fenced-expected.png:
* platform/mac/mathml/presentation/fenced-mi-expected.png:
* platform/mac/mathml/presentation/mo-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/over-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-expected.png:
* platform/mac/mathml/presentation/sub-expected.png:
* platform/mac/mathml/presentation/subsup-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: implement cursor.advance()
commit-queue@webkit.org [Thu, 26 Apr 2012 02:23:34 +0000 (02:23 +0000)]
IndexedDB: implement cursor.advance()
https://bugs.webkit.org/show_bug.cgi?id=84174

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.

Source/WebCore:

Implement IDBCursor.advance() to spec.

Test: storage/indexeddb/cursor-advance.html

* Modules/indexeddb/IDBBackingStore.h:
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
(WebCore):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::advance):
(WebCore):
(WebCore::IDBCursorBackendImpl::advanceInternal):
* Modules/indexeddb/IDBCursorBackendImpl.h:
(IDBCursorBackendImpl):
* Modules/indexeddb/IDBCursorBackendInterface.h:
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):

Source/WebKit/chromium:

Hook up chromium IPC to IDBCursor.advance().

* src/IDBCursorBackendProxy.cpp:
(WebKit::IDBCursorBackendProxy::advance):
(WebKit):
* src/IDBCursorBackendProxy.h:
(IDBCursorBackendProxy):
* src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::advance):

LayoutTests:

Tests for cursor.advance().

* storage/indexeddb/cursor-advance-expected.txt: Added.
* storage/indexeddb/cursor-advance.html: Added.
* storage/indexeddb/resources/cursor-advance.js: Added.
(test):
(openSuccess):
(createAndPopulateObjectStore):
(makeAdvanceTest.continueToTest):
(makeAdvanceTest.request.onerror):
(makeAdvanceTest):
(mkCursor):
(runTest):
(testAll):
(testSimple):
(testContinueThenAdvance):
(testAdvanceMultiple):
(testAdvanceToEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Hold video provider lock from willDraw to didDraw
enne@google.com [Thu, 26 Apr 2012 02:06:41 +0000 (02:06 +0000)]
[chromium] Hold video provider lock from willDraw to didDraw
https://bugs.webkit.org/show_bug.cgi?id=84805

Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Input Range element expects mouse events
charles.wei@torchmobile.com.cn [Thu, 26 Apr 2012 02:02:41 +0000 (02:02 +0000)]
[BlackBerry] Input Range element expects mouse events
https://bugs.webkit.org/show_bug.cgi?id=84571

Reviewed by Antonio Gomes.

This just cleans up the code a bit to make it less code and more readable.
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::shouldConvertTouchToMouse):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::spellCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115262.
hclam@chromium.org [Thu, 26 Apr 2012 01:56:00 +0000 (01:56 +0000)]
Unreviewed, rolling out r115262.
http://trac.webkit.org/changeset/115262
https://bugs.webkit.org/show_bug.cgi?id=84631

r115262 is causing link error in WebKit Win Builder (dbg)

* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):
* public/WebIDBKeyPath.h:
(WebKit):
(WebIDBKeyPath):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
(WebKit::WebIDBObjectStore::createIndex):
* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
* src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::keyPath):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::keyPath):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBIndexImpl.cpp:
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
* src/WebIDBKeyPath.cpp:
(WebKit::WebIDBKeyPath::create):
(WebKit::WebIDBKeyPath::assign):
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
(WebKit::WebIDBObjectStoreImpl::createIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches
enne@google.com [Thu, 26 Apr 2012 01:48:08 +0000 (01:48 +0000)]
[chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches
https://bugs.webkit.org/show_bug.cgi?id=84812

Reviewed by James Robinson.

Source/WebCore:

Because some layers lock/unlock resources, it needs to be guaranteed
that if willDraw is called on a layer then didDraw will also be called
on that layer before another willDraw or before layer destruction. Add
asserts to make sure that this is the case.

willDraw is called via CCLayerTreeHostImpl::prepareToDraw ->
calculateRenderPasses. didDraw was previously called in
CCLayerTreeHostImpl::drawLayers. Sometimes drawLayers was being
skipped by the caller of these functions based on what prepareToDraw
returned (causing didDraw to not be called). Fix this by having an
explicit step to call didDraw on all layers. This new didDrawAllLayers
function must be called if and only if prepareToDraw is called.

Tested by existing tests via new asserts in CCLayerImpl.

* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
(WebCore::CCLayerImpl::willDraw):
(WebCore):
(WebCore::CCLayerImpl::didDraw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::willDraw):
(WebCore::CCScrollbarLayerImpl::didDraw):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::willDraw):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::didDraw):

Source/WebKit/chromium:

Update all tests to call CCLayerTreeHostImpl::didDrawAllLayers if they
call CCLayerTreeHostImpl::prepareToDraw.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame):
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalendar Picker: Resize to minimal size to fit the content
tkent@chromium.org [Thu, 26 Apr 2012 01:26:05 +0000 (01:26 +0000)]
Calendar Picker: Resize to minimal size to fit the content
https://bugs.webkit.org/show_bug.cgi?id=84826

Reviewed by Hajime Morita.

.:

* ManualTests/forms/calendar-picker.html:
Sync with the size specified in CalendarPickerElement.cpp.

Source/WebCore:

Using fixed-size popup isn't nice. The calender picker popup size should
be minimal.

The minimal size depends on font settings, localized labels, and
localized formats. So we put visible objects on a transparent element,
calculate minimal size, resize the popup, then show the objects.

* Resources/calendarPicker.css:
(body): Don't use purple. It was for debugging purpose.
The body is visible for a short period becuse we use transparent element.
(#main):
 - Add nowrap to avoid text wrapping.
 - Add wider width to avoid wrapping.
 - Add opacity to hide incomplete layout.
(.year-month-upper): Don't set flexible box yet.
(.month-selector-box): Fix incorrect display value.
(.days-area):
Don't set table-layout:fixed and width:100% in order that it has the
minimal width.

* Resources/calendarPicker.js:
(initialize): Make a new functio to resize.
(fixWindowSize):
Compute the required width from the right edge of the next year button,
the maximum cell width, and so on.  Then, set CSS properties to have
correct layout.
(YearMonthController.prototype.attachTo):
Set min-width property for a long year-month string.
(YearMonthController.prototype._showPopup):
Center the _monthPopup vertically.

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):
Specify small size for the initial size. It's better than showing a
large window then shrink the size.
* page/PagePopupClient.h:
(PagePopupClient): Remove a false comment. We should support resize*().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115260.
hclam@chromium.org [Thu, 26 Apr 2012 01:18:31 +0000 (01:18 +0000)]
Unreviewed, rolling out r115260.
http://trac.webkit.org/changeset/115260
https://bugs.webkit.org/show_bug.cgi?id=84467

r115260 is crashing a list of IndexDB tests, revert.

Source/WebCore:

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
* platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
* platform/leveldb/LevelDBTransaction.h:
(TransactionIterator):

LayoutTests:

* storage/indexeddb/cursor-added-bug-expected.txt: Removed.
* storage/indexeddb/cursor-added-bug.html: Removed.
* storage/indexeddb/resources/cursor-added-bug.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Web Timing] Add a vendor-prefixed Performance Timeline API
simonjam@chromium.org [Thu, 26 Apr 2012 01:17:36 +0000 (01:17 +0000)]
[Web Timing] Add a vendor-prefixed Performance Timeline API
https://bugs.webkit.org/show_bug.cgi?id=80350

As described here: http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html

The API is there and should be correct, but it isn't particularly useful,
because nothing is populated. Upcoming changes will add Navigation Timing
and Resource Timing.

Reviewed by Tony Gentilcore.

No new tests. Functionality is disabled on all platforms.

* CMakeLists.txt: Added PerformanceEntry* files.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* page/Performance.cpp:
(WebCore::Performance::webkitGetEntries): Added.
(WebCore::Performance::webkitGetEntriesByType): Added.
(WebCore::Performance::webkitGetEntriesByName): Added.
* page/Performance.h:
(Performance):
* page/Performance.idl:
* page/PerformanceEntry.cpp: Added.
(WebCore):
(WebCore::PerformanceEntry::PerformanceEntry):
(WebCore::PerformanceEntry::name):
(WebCore::PerformanceEntry::entryType):
(WebCore::PerformanceEntry::startTime):
(WebCore::PerformanceEntry::duration):
* page/PerformanceEntry.h: Added.
(WebCore):
(PerformanceEntry):
* page/PerformanceEntry.idl: Added.
* page/PerformanceEntryList.cpp: Added.
(WebCore):
(WebCore::PerformanceEntryList::PerformanceEntryList):
(WebCore::PerformanceEntryList::~PerformanceEntryList):
(WebCore::PerformanceEntryList::length):
(WebCore::PerformanceEntryList::item):
(WebCore::PerformanceEntryList::append):
* page/PerformanceEntryList.h: Added.
(WebCore):
(PerformanceEntryList):
(WebCore::PerformanceEntryList::create):
* page/PerformanceEntryList.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary timeouts (and closures) from content-element-in-* tests.
dglazkov@chromium.org [Thu, 26 Apr 2012 01:16:38 +0000 (01:16 +0000)]
Remove unnecessary timeouts (and closures) from content-element-in-* tests.
https://bugs.webkit.org/show_bug.cgi?id=84896

These tests don't need any of them. Not sure how they got there in the first place. Oh wait. I reviewed this code. /me hands head in shame.

Reviewed by Ojan Vafai.

* fast/dom/shadow/content-element-in-media-element.html: Removed the timeout and extra closures.
* fast/dom/shadow/content-element-in-meter-element.html: Ditto.
* fast/dom/shadow/content-element-in-progress-element.html: Ditto.
* fast/dom/shadow/content-element-in-select-element.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIterating a HashMap<String, X> involves a string equality comparison to check for...
darin@apple.com [Thu, 26 Apr 2012 01:13:06 +0000 (01:13 +0000)]
Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524

Reviewed by Antti Koivisto.

* wtf/HashMap.h: Added a struct template, HashMapValueTraits, that derives from
PairHashTraits, adds an isEmptyValue function that looks only at the key, not
the mapped value, in the hash table value, and uses the isHashTraitsEmptyValue
function template to check if the key is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=84913
bdakin@apple.com [Thu, 26 Apr 2012 01:11:42 +0000 (01:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=84913
WebKit 1: Initialize deviceScaleFactor on creation of the WebView
-and corresponding-
<rdar://problem/11322716>

Reviewed by Darin Adler.

Before this patch, we weren't setting the deviceScaleFactor until
viewDidMoveToWindow which is quite late for background tabs. setHostWindow will
happen early on though. For applications that don't use host windows, also set it
from _initWithFrame.
* WebView/WebView.mm:
(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
(-[WebView setHostWindow:]):
(-[WebView _deviceScaleFactor]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=84909
bdakin@apple.com [Thu, 26 Apr 2012 01:07:35 +0000 (01:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=84909
Background tabs are fuzzy until repaint when deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11312064>

Rubber-stamped by Darin Adler.

Re-order the parameters of paintBitmapContext to match paintImage.
* Platform/cg/CGUtilities.cpp:
(WebKit::paintBitmapContext):
* Platform/cg/CGUtilities.h:
(WebKit):
* UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::paint):
(WebKit::BackingStore::backingStoreContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove convertJSMethodNameToObjc() to be a utility function of ObjcClass
benjamin@webkit.org [Thu, 26 Apr 2012 01:06:24 +0000 (01:06 +0000)]
Move convertJSMethodNameToObjc() to be a utility function of ObjcClass
https://bugs.webkit.org/show_bug.cgi?id=84915

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-25
Reviewed by Darin Adler.

The function convertJSMethodNameToObjc() is only useful for ObjcClass::methodsNamed().

This patch moves the function from objc_utility.mm to be a static function in objc_class.mm.
It aims at simplifying the code for future changes of ObjcClass.

* bridge/objc/objc_class.mm:
(Bindings):
(JSC::Bindings::convertJSMethodNameToObjc):
* bridge/objc/objc_utility.h:
* bridge/objc/objc_utility.mm:
(Bindings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] change DRT's "DRT" output to match the other ports
dpranke@chromium.org [Thu, 26 Apr 2012 01:03:53 +0000 (01:03 +0000)]
[chromium] change DRT's "DRT" output to match the other ports
https://bugs.webkit.org/show_bug.cgi?id=84904

Reviewed by Kent Tamura.

Since we run Chromium's DRT in --test-shell mode, the
non-test-shell output has never been really beaten on to make
sure it's right. This fixes a few issues and will be tested
with upcoming NRWT changes that'll land in a separate patch.
In particular we should never output framing text like "\n"
or "#EOF" outside of something outside of TestEventPrinter,
and we weren't handling audio output properly at all.

* DumpRenderTree/chromium/TestEventPrinter.cpp:
(DRTPrinter):
(TestShellPrinter):
(DRTPrinter::handleTextFooter):
(DRTPrinter::handleAudioFooter):
(DRTPrinter::handleTestFooter):
(TestShellPrinter::handleAudioFooter):
* DumpRenderTree/chromium/TestEventPrinter.h:
(TestEventPrinter):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Sort Xcode project file.
tkent@chromium.org [Thu, 26 Apr 2012 01:03:08 +0000 (01:03 +0000)]
Unreviewed. Sort Xcode project file.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=84909
bdakin@apple.com [Thu, 26 Apr 2012 00:46:26 +0000 (00:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=84909
Background tabs are fuzzy until repaint when deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11312064>

Reviewed by Darin Adler.

BackingStoreMac paints into a Bitmap instead of a CGLayer when there is no
containing window. That bitmap is used for the initial paint when a background tab
first comes to he foreground, so it needs to be HiDPI-aware.

paintBitmapContext() now takes a scale factor that it passes along to paintImage
rather than hardcoding a scale factor of 1 for paintImage.
* Platform/cg/CGUtilities.cpp:
(WebKit::paintBitmapContext):
* Platform/cg/CGUtilities.h:
(WebKit):

When these functions fall into the bitmap case, they need to adopt the device
scale factor, which means they need to scale in size by the scale factor, and also
scale their context.
* UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::paint):
(WebKit::BackingStore::backingStoreContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style...
achicu@adobe.com [Thu, 26 Apr 2012 00:29:41 +0000 (00:29 +0000)]
[Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style.html is failing
https://bugs.webkit.org/show_bug.cgi?id=84067

Reviewed by Ryosuke Niwa.

All the CSS filters/shaders script tests expected to have a document.styleSheets.item(0) that they could change.
The script-tests add a <link> that references a CSS file from a different parent folder, so the script
has no access to the actual rules anymore. Updated all the tests to use createElement("style")
and get the styleSheet by using el.sheet instead of assuming that there's one style already created.

* css3/filters/script-tests/custom-filter-property-computed-style.js:
* css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
(testInvalidFilterRule):
* css3/filters/script-tests/effect-custom-disabled.js:
(testInvalidFilterRule):
* css3/filters/script-tests/filter-property-computed-style.js:
(testComputedFilterRule):
* css3/filters/script-tests/filter-property-parsing-invalid.js:
(testInvalidFilterRule):
* css3/filters/script-tests/filter-property-parsing.js:
(testFilterRule):
* css3/filters/script-tests/filter-property.js:
* platform/chromium/test_expectations.txt: Removed reference to this bug.
* platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed. This is not necessary anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement object-literal constructor for the Intent object.
commit-queue@webkit.org [Thu, 26 Apr 2012 00:28:47 +0000 (00:28 +0000)]
Implement object-literal constructor for the Intent object.
https://bugs.webkit.org/show_bug.cgi?id=84220

Patch by Greg Billock <gbillock@google.com> on 2012-04-25
Reviewed by Kentaro Hara.

The use of the custom constructor will hopefully be temporary, as we plan
to convert to just using the object literal constructor, which can then use codegen.
See spec: http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html

Added support for the service and extras parameters in the Intent
object to support the speced members in the object literal constructor.

Added supporting accessor to Dictionary to retrieve a sub-Dictionary,
and a utility to ScriptValue to serialize with ports.

Test: webintents/web-intent-obj-constructor.html

(WebCore):
* Modules/intents/Intent.cpp:
(WebCore::Intent::create):
(WebCore::Intent::Intent):
(WebCore::Intent::service):
(WebCore):
(WebCore::Intent::extras):
* Modules/intents/Intent.h:
(WebCore):
(Intent):
* Modules/intents/Intent.idl:
* WebCore.gypi:
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
* bindings/v8/Dictionary.h:
(Dictionary):
* bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore):
* bindings/v8/ScriptValue.h:
(WTF):
(WebCore):
(ScriptValue):
* bindings/v8/custom/V8IntentConstructor.cpp: Added.
(WebCore):
(WebCore::V8Intent::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS Shaders: Use u_texture instead of s_texture. It was updated in the spec
achicu@adobe.com [Thu, 26 Apr 2012 00:26:03 +0000 (00:26 +0000)]
CSS Shaders: Use u_texture instead of s_texture. It was updated in the spec
https://bugs.webkit.org/show_bug.cgi?id=82618

Source/WebCore:

Reviewed by Dean Jackson.

Changed the uniform name passed to the CSS Shaders from s_texture to u_texture.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html

No new tests, just updating existing ones.

* platform/graphics/filters/CustomFilterShader.cpp:
(WebCore::CustomFilterShader::defaultFragmentShaderString):
(WebCore::CustomFilterShader::initializeParameterLocations):

LayoutTests:

Reviewed by Dean Jackson.

Changed the uniform name passed to the CSS Shaders from s_texture to u_texture.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html

* css3/filters/resources/color-add.fs:
* css3/filters/resources/color-offset-parameters.fs:
* css3/filters/resources/color-offset.fs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API
jsbell@chromium.org [Thu, 26 Apr 2012 00:07:34 +0000 (00:07 +0000)]
[Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=84631

Reviewed by James Robinson.

WebIDBKeyPath was previously a utility class for parsing key paths into components,
but the API exposed key paths only as nullable strings. To support array-type keypaths,
WebIDBKeyPath becomes a value class with type flags. For landing, several legacy methods
are retained but will be cleaned up after all callers have been updated, tracked as
the bug: http://webkit.org/b/84207

* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBIndex::keyPathString): Comment change.
* public/WebIDBKeyPath.h:
(WebKit::WebIDBKeyPath::create): Overload added for creating array-type key paths.
(WebKit::WebIDBKeyPath::array): Accessor for array-type key paths.
(WebKit::WebIDBKeyPath::operator const WebString ): Temporary, for compatibility.
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBObjectStore::keyPathString): Comment change.
(WebKit::WebIDBObjectStore::createIndex): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.
* public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport): WebIDBKeyPath overloads for these methods added, delegate to WebString version until implementers are updated.
(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
* src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::keyPath): Returns the string version until WebCore is updated.
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::keyPath): Returns the string version until WebCore is updated.
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl): Add createObjectStore overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::keyPath): Implements the new WebIDBKeyPath return type.
(WebKit):
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl): Implements the new WebIDBKeyPath return type.
* src/WebIDBKeyPath.cpp:
(WebKit::WebIDBKeyPath::create): Support null key path types.
(WebKit::WebIDBKeyPath::createNull): New API.
(WebKit):
(WebKit::WebIDBKeyPath::isValid): New API.
(WebKit::WebIDBKeyPath::type): New API.
(WebKit::WebIDBKeyPath::string): New API (value accessor).
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::assign): This API will be removed.
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Ensure it is non-null - only used in copy constructor which guards against this.
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::keyPath): Implement the new WebIDBKeyPath return type.
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl): Add createIndex overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: cursor does not correctly iterate over keys added and removed during iteration
commit-queue@webkit.org [Wed, 25 Apr 2012 23:52:12 +0000 (23:52 +0000)]
IndexedDB: cursor does not correctly iterate over keys added and removed during iteration
https://bugs.webkit.org/show_bug.cgi?id=84467

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.

Source/WebCore:

Ensure that the iterator over the tree of cached adds/removes always points at
the current key, or if the db iterator is current, the next key:

- When refreshing the tree iterator after a mutation, always seek unless the
tree iterator is current.

- When handing conflicts and delete markers, only advance the tree iterator as
far as the db iterator.

Remove the expensive (and now redundant) logic that issued a get() to check
whether an item had been deleted.

Test: storage/indexeddb/cursor-added-bug.html

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
* platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):

LayoutTests:

New test for keys added in reverse order during cursor iteration.

* storage/indexeddb/cursor-added-bug-expected.txt: Added.
* storage/indexeddb/cursor-added-bug.html: Added.
* storage/indexeddb/resources/cursor-added-bug.js: Added.
(test):
(openSuccess):
(setVersionSuccess):
(openCursor):
(cursorSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: Adding Alec Flett as a contributor (non-committer).
jsbell@chromium.org [Wed, 25 Apr 2012 23:39:26 +0000 (23:39 +0000)]
Unreviewed: Adding Alec Flett as a contributor (non-committer).

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark myself as a reviewer.
inferno@chromium.org [Wed, 25 Apr 2012 23:30:39 +0000 (23:30 +0000)]
Mark myself as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=84902

Reviewed by Dimitri Glazkov.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix build with STYLE_SCOPED enabled.
antti@apple.com [Wed, 25 Apr 2012 23:07:54 +0000 (23:07 +0000)]
Try to fix build with STYLE_SCOPED enabled.

Not reviewed.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::determineScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: support openCursor(IDBKey)
commit-queue@webkit.org [Wed, 25 Apr 2012 23:05:29 +0000 (23:05 +0000)]
IndexedDB: support openCursor(IDBKey)
https://bugs.webkit.org/show_bug.cgi?id=84652

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.

Source/WebCore:

Add signatures for openCursor/openKeyCursor(IDBKey).

Test: storage/indexeddb/opencursor-key.html

* Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(IDBIndex):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
(WebCore):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl:

LayoutTests:

Augment existing tests, and add new tests to support
IDBKey parameter to openCursor/openKeyCursor. Note that this removes
a test that was previously using dictionary-style parameters,
which have been temporarily broken due to IDL limitations.

* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/opencursor-key-expected.txt: Added.
* storage/indexeddb/opencursor-key.html: Added.
* storage/indexeddb/resources/cursor-delete.js:
(openCursor):
* storage/indexeddb/resources/open-cursor.js:
(emptyCursorWithKeySuccess):
(openEmptyCursorWithKey):
(cursorWithKeySuccess):
(openCursorWithKey):
(emptyCursorSuccess):
(openEmptyCursor):
(cursorSuccess):
* storage/indexeddb/resources/opencursor-key.js: Added.
(test):
(openSuccess):
(createAndPopulateObjectStore):
(createIndexes):
(testAll):
(testObjectStore.request.onsuccess):
(testObjectStore):
(testIndex.request.onsuccess):
(testIndex):
(testIndexWithKey.request.onsuccess):
(testIndexWithKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInclude <sys/param.h>, needed for sysctl() on OpenBSD/NetBSD
rakuco@webkit.org [Wed, 25 Apr 2012 23:02:18 +0000 (23:02 +0000)]
Include <sys/param.h>, needed for sysctl() on OpenBSD/NetBSD
https://bugs.webkit.org/show_bug.cgi?id=82585

Patch by Landry Breuil <landry@openbsd.org> on 2012-04-25
Reviewed by Zoltan Herczeg.

* wtf/NumberOfCores.cpp: include <sys/param.h> on the BSDs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBiolab disaster crashes on ToT
oliver@apple.com [Wed, 25 Apr 2012 23:01:08 +0000 (23:01 +0000)]
Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898

Reviewed by Filip Pizlo.

Whoops, committed without saving reviewer requested change.

* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBiolab disaster crashes on ToT
oliver@apple.com [Wed, 25 Apr 2012 22:58:08 +0000 (22:58 +0000)]
Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898

Reviewed by Filip Pizlo.

I recently added an assertion to the Interpreter to catch incorrect
updates of topCallFrame.  This caused a bunch of sites (including biolab
disaster) to crash as we were not correctly handling callee registers
of inlined functions, leading to a mismatch.

I could not actually make this trigger directly, although it does trigger
already on some of the GTK and QT bots.

* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium[ Remove a flaky expectation for a test that's been consistently passing.
dglazkov@chromium.org [Wed, 25 Apr 2012 22:52:41 +0000 (22:52 +0000)]
[Chromium[ Remove a flaky expectation for a test that's been consistently passing.

* platform/chromium/test_expectations.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove owner node pointer from StyleSheetInternal
antti@apple.com [Wed, 25 Apr 2012 22:42:47 +0000 (22:42 +0000)]
Remove owner node pointer from StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=84882

Reviewed by Andread Kling.

To make sharing between multiple nodes possible StyleSheetInternal should not have a Node pointer.

- Make StyleSheetInternal constructor take CSSParserContext instead of Node*
- Move owner node pointer to CSSStyleSheet. CSSStyleSheet now acts as a client for StyleSheetInternal.

This gets us closer to being able to cache stylesheet data structures.

* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):

    Setup CSSParserContext.
    Remove FIXME about updateBaseURL(). It is no longer possible to change URL of StyleSheetInternal.

* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
* css/CSSParserMode.h:
(CSSParserContext):

    Expand CSSParserContext constructors.

* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* css/CSSStyleSheet.cpp:

    User stylesheets went back to being CSSStyleSheets. Adapt to that.

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore):
(WebCore::StyleSheetInternal::checkLoaded):
(WebCore::StyleSheetInternal::startLoadingDynamicSheet):
(WebCore::StyleSheetInternal::rootStyleSheet):
(WebCore::StyleSheetInternal::singleOwnerNode):
(WebCore::StyleSheetInternal::singleOwnerDocument):
(WebCore::StyleSheetInternal::styleSheetChanged):

    The owner node is now located through CSSStyleSheet. Only one client is supported atm.

(WebCore::StyleSheetInternal::registerClient):
(WebCore::StyleSheetInternal::unregisterClient):

    Register CSSStyleSheets.

(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::ownerDocument):
* css/CSSStyleSheet.h:
(WebCore::StyleSheetInternal::create):
(WebCore::StyleSheetInternal::createInline):
(StyleSheetInternal):
(WebCore::CSSStyleSheet::create):
(CSSStyleSheet):

    Moved m_ownerNode.
    Changed constructors
    Removed setFinalURL().

* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
* dom/Document.cpp:
(WebCore::Document::updateBaseURL):

    Instead of setFinalURL, construct a new StyleSheetInternal if the base url ever changes.

(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::elementSheet):
* dom/Document.h:
(Document):
(WebCore::Document::documentUserSheets):

    Adapt to the new interface.
    Turned user stylesheets CSSStyleSheets so they can find the owner node.

* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
* inspector/InspectorCSSAgent.cpp:
(WebCore::SelectorProfile::startSelector):
(WebCore::InspectorCSSAgent::bindStyleSheet):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::ownerDocument):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix uninitialized variable warnings in PasteboardMac.mm after 115145
adamk@chromium.org [Wed, 25 Apr 2012 22:33:10 +0000 (22:33 +0000)]
Fix uninitialized variable warnings in PasteboardMac.mm after 115145
https://bugs.webkit.org/show_bug.cgi?id=84879

Reviewed by Enrica Casucci.

* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getDataSelection): Initialize attributedString to nil.
(WebCore::Pasteboard::writeSelectionForTypes): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
kbr@google.com [Wed, 25 Apr 2012 22:12:49 +0000 (22:12 +0000)]
Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
https://bugs.webkit.org/show_bug.cgi?id=83655

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionToAbbreviatedString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC):
(JSC::isActionableIntMutableArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::getByVal):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/JSByteArray.cpp: Removed.
* runtime/JSByteArray.h: Removed.
* runtime/JSGlobalData.cpp:

Source/WebCore:

Removed last few references to ByteArray, replacing with
Uint8ClampedArray as necessary, and deleted now-obsolete
CanvasPixelArray, ByteArray and JSByteArray. Removed code from
JavaScriptCore special-casing ByteArray.

No new tests. Did full layout test run on Mac OS; no regressions
seen from this change.

* CMakeLists.txt:
* DerivedSources.pri:
* ForwardingHeaders/runtime/JSByteArray.h: Removed.
* GNUmakefile.list.am:
* PlatformBlackBerry.cmake:
* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8Binding.h:
(WebCore::isHostObject):
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::typeCallback):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::isJSUint8ClampedArray):
(Bindings):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
* html/canvas/CanvasPixelArray.cpp: Removed.
* html/canvas/CanvasPixelArray.h: Removed.
* html/canvas/CanvasPixelArray.idl: Removed.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
* platform/graphics/filters/FEConvolveMatrix.h:
* rendering/svg/RenderSVGResourceMasker.cpp:

Source/WTF:

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/ByteArray.cpp: Removed.
* wtf/ByteArray.h: Removed.
* wtf/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectations update.
hclam@chromium.org [Wed, 25 Apr 2012 21:36:42 +0000 (21:36 +0000)]
Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84890

Rebaseline chromium-mac test expectation for media/audio-repaint.html after r115235.

* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
hclam@chromium.org [Wed, 25 Apr 2012 21:30:52 +0000 (21:30 +0000)]
Unreviewed build fix.

Build fix for compilation failure due to r115243.

* platform/graphics/chromium/LayerChromium.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Possible JS re-entrancy caused by UI events.
commit-queue@webkit.org [Wed, 25 Apr 2012 21:22:53 +0000 (21:22 +0000)]
[BlackBerry] Possible JS re-entrancy caused by UI events.
https://bugs.webkit.org/show_bug.cgi?id=84862

Patch by Yong Li <yoli@rim.com> on 2012-04-25
Reviewed by Antonio Gomes.

1. block UI events when running in nested event loop
2. defer some tasks we still want to perform when it is safe to do,
   with cached data.
3. deferred task can be cancelled by clearing the flag. duplicate tasks
   is not a problem because they share same flag and data.
4. move deferred manual script from FrameLoaderClientBlackBerry to WebPagePrivate
   and make it a deferred task

* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
(BlackBerry::WebKit::WebPagePrivate::willDeferLoading):
(BlackBerry::WebKit::WebPagePrivate::didResumeLoading):
(BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
(BlackBerry::WebKit::WebPage::setInputSelection):
(BlackBerry::WebKit::WebPage::popupListClosed):
(BlackBerry::WebKit::WebPage::setDateTimeInput):
(BlackBerry::WebKit::WebPage::setColorInput):
(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPage::touchEventCancel):
(BlackBerry::WebKit::WebPage::touchEventCancelAndClearFocusedNode):
(BlackBerry::WebKit::WebPage::keyEvent):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::setComposingText):
(BlackBerry::WebKit::WebPage::commitText):
(BlackBerry::WebKit::WebPage::selectionCancelled):
(BlackBerry::WebKit::WebPage::cutSelectedText):
(BlackBerry::WebKit::WebPage::insertText):
(BlackBerry::WebKit::WebPage::clearCurrentInputField):
(BlackBerry::WebKit::WebPage::cut):
(BlackBerry::WebKit::WebPage::paste):
(BlackBerry::WebKit::WebPage::setSelection):
(BlackBerry::WebKit::WebPage::setCaretPosition):
(BlackBerry::WebKit::WebPage::selectAtPoint):
(BlackBerry::WebKit::WebPage::setFocused):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
(DeferredTaskBase):
(BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::perform):
(BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::DeferredTaskBase):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::~FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::willDeferLoading):
(WebCore::FrameLoaderClientBlackBerry::didResumeLoading):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r115227. Return null string when the string builder is empty
rniwa@webkit.org [Wed, 25 Apr 2012 21:15:39 +0000 (21:15 +0000)]
Build fix after r115227. Return null string when the string builder is empty
to match the old behavior.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::borderPropertyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add support for animation finished events.
commit-queue@webkit.org [Wed, 25 Apr 2012 21:13:33 +0000 (21:13 +0000)]
[chromium] Add support for animation finished events.
https://bugs.webkit.org/show_bug.cgi?id=84454

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-25
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestAnimationFinishedEvents

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::notifyAnimationFinished):
(WebCore):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::notifyAnimationStarted):
(WebCore::LayerChromium::notifyAnimationFinished):
(WebCore):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromium):
* platform/graphics/chromium/cc/CCAnimationEvents.h:
(WebCore::CCAnimationEvent::CCAnimationEvent):
(CCAnimationEvent):
(WebCore):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::animate):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationController::purgeFinishedAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationController):
* platform/graphics/chromium/cc/CCLayerAnimationDelegate.h:
(CCLayerAnimationDelegate):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):

Source/WebKit/chromium:

* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::notifyAnimationFinished):
(WTF::TEST_F):
(WTF):
(CCLayerTreeHostTestAnimationFinishedEvents):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::CCLayerTreeHostTestAnimationFinishedEvents):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::beginTest):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::notifyAnimationFinished):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::afterTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: REGRESSION (r110494): Dragging images from Safari to Finder results...
enrica@apple.com [Wed, 25 Apr 2012 20:59:28 +0000 (20:59 +0000)]
Source/WebCore: REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
https://bugs.webkit.org/show_bug.cgi?id=84878
<rdar://problem/11155407>

In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
of the communication between the UI process and the WebProcess.
We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
gets changed which affects the promised file types.

Reviewed by Alexey Proskuryakov.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag): Reset m_mouseDownMayStartDrag to false to
avoid attempting to start another drag.

Source/WebKit2: REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
https://bugs.webkit.org/show_bug.cgi?id=84878
<rdar://problem/11155407>

In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
of the communication between the UI process and the WebProcess.
We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
gets changed which affects the promised file types.
The fix for the problem is in WebCore and we can now remove the guard on _setDragImage.

Reviewed by Alexey Proskuryakov.

* UIProcess/API/mac/WKView.mm:
(-[WKView mouseDown:]):
(-[WKView _setDragImage:at:linkDrag:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused Attribute constructor.
kling@webkit.org [Wed, 25 Apr 2012 20:40:38 +0000 (20:40 +0000)]
Remove unused Attribute constructor.

Semi-knowingly rubber-stamped by Antti Koivisto.

* dom/Attribute.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][NRWT] Run each DRT in it's own xvfb
kkristof@inf.u-szeged.hu [Wed, 25 Apr 2012 20:34:26 +0000 (20:34 +0000)]
[Qt][NRWT] Run each DRT in it's own xvfb
https://bugs.webkit.org/show_bug.cgi?id=77335

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._driver_class):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
(XvfbDriver):
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline chromium test results after bug 72796 is fixed
schenney@chromium.org [Wed, 25 Apr 2012 20:04:45 +0000 (20:04 +0000)]
Rebaseline chromium test results after bug 72796 is fixed
https://bugs.webkit.org/show_bug.cgi?id=84731

Unreviewed Chromikum expectations update.

Text baselines changed now that this bug has been fixed.

* platform/chromium-linux-x86/svg/custom/use-clipped-hit-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/use-modify-target-symbol-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/chromium-linux/svg/custom/use-clipped-hit-expected.txt: Added.
* platform/chromium-linux/svg/custom/use-modify-target-symbol-expected.txt: Added.
* platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/chromium-mac-leopard/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Removed.
* platform/chromium-mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/chromium-win-vista/svg/custom/use-clipped-hit-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/use-modify-target-symbol-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/use-clipped-hit-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/use-modify-target-symbol-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
* platform/chromium-win/svg/carto.net/button-expected.txt:
* platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
* platform/chromium-win/svg/carto.net/slider-expected.txt:
* platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
* platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/chromium-win/svg/custom/use-on-g-containing-symbol-expected.txt:
* platform/chromium-win/svg/custom/use-on-symbol-expected.txt:
* platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse the same results for fast/html/details-marker-style.html on all mac bots.
kling@webkit.org [Wed, 25 Apr 2012 19:55:44 +0000 (19:55 +0000)]
Use the same results for fast/html/details-marker-style.html on all mac bots.

* platform/mac/fast/html/details-marker-style-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/fast/html/details-marker-style-expected.png.
* platform/mac/fast/html/details-marker-style-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/fast/html/details-marker-style-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp://bellard.org/jslinux/ triggers an assertion failure in the DFG JIT
fpizlo@apple.com [Wed, 25 Apr 2012 19:53:28 +0000 (19:53 +0000)]
bellard.org/jslinux/ triggers an assertion failure in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=84815
<rdar://problem/11319514>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

LayoutTests:

Rubber stamped by Gavin Barraclough.

* fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt: Added.
* fast/js/dfg-uint32-to-number-on-captured-variable.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-uint32-to-number-on-captured-variable.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Crash in CachedRawResource::didAddClient() due to missing protector.
japhet@chromium.org [Wed, 25 Apr 2012 19:31:42 +0000 (19:31 +0000)]
Source/WebCore: Crash in CachedRawResource::didAddClient() due to missing protector.
https://bugs.webkit.org/show_bug.cgi?id=83632

Reviewed by Eric Seidel.

Test: http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html

* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83632.

Reviewed by Eric Seidel.

* http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-04-25 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 25 Apr 2012 19:26:50 +0000 (19:26 +0000)]
2012-04-25  Andrew Scherkus  <scherkus@chromium.org>

        Rebaseline Chromium media layout tests due to r114957.

        * platform/chromium-linux-x86/media/video-empty-source-expected.txt:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Removed.
        * platform/chromium-linux/media/video-empty-source-expected.txt:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.txt:
        * platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
        * platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt:
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium-mac/media/audio-controls-rendering-expected.txt:
        * platform/chromium-mac/media/audio-repaint-expected.txt:
        * platform/chromium-mac/media/controls-after-reload-expected.txt:
        * platform/chromium-mac/media/controls-strict-expected.txt:
        * platform/chromium-mac/media/controls-styling-expected.txt:
        * platform/chromium-mac/media/controls-without-preload-expected.txt:
        * platform/chromium-mac/media/media-controls-clone-expected.txt:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-mac/media/video-controls-rendering-expected.txt:
        * platform/chromium-mac/media/video-display-toggle-expected.txt:
        * platform/chromium-mac/media/video-empty-source-expected.txt:
        * platform/chromium-mac/media/video-no-audio-expected.txt:
        * platform/chromium-mac/media/video-playing-and-pause-expected.txt:
        * platform/chromium-mac/media/video-volume-slider-expected.txt:
        * platform/chromium-mac/media/video-zoom-controls-expected.txt:
        * platform/chromium-win-vista/media/video-empty-source-expected.txt:
        * platform/chromium-win-xp/media/video-empty-source-expected.txt:
        * platform/chromium-win/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/media/audio-controls-rendering-expected.txt:
        * platform/chromium-win/media/audio-repaint-expected.txt:
        * platform/chromium-win/media/controls-after-reload-expected.txt:
        * platform/chromium-win/media/controls-strict-expected.txt:
        * platform/chromium-win/media/controls-styling-expected.txt:
        * platform/chromium-win/media/controls-without-preload-expected.txt:
        * platform/chromium-win/media/media-controls-clone-expected.txt:
        * platform/chromium-win/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-win/media/video-controls-rendering-expected.txt:
        * platform/chromium-win/media/video-display-toggle-expected.txt:
        * platform/chromium-win/media/video-empty-source-expected.txt:
        * platform/chromium-win/media/video-no-audio-expected.txt:
        * platform/chromium-win/media/video-playing-and-pause-expected.txt:
        * platform/chromium-win/media/video-volume-slider-expected.txt:
        * platform/chromium-win/media/video-zoom-controls-expected.txt:
        * platform/chromium/test_expectations.txt:
        * platform/qt/media/audio-repaint-expected.txt: Renamed from LayoutTests/media/audio-repaint-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to SerializedScriptValue::deserialize()
haraken@chromium.org [Wed, 25 Apr 2012 18:57:29 +0000 (18:57 +0000)]
[V8] Pass Isolate to SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=84758

Reviewed by Nate Chapin.

The objective is to pass Isolate around. This patch passes
Isolate to SerializedScriptValue::deserialize().

No tests. No change in behavior.

* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to SerializedScriptValue::create() in custom bindings
haraken@chromium.org [Wed, 25 Apr 2012 18:38:48 +0000 (18:38 +0000)]
[V8] Pass Isolate to SerializedScriptValue::create() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=84757

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to SerializedScriptValue::create()
in custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectations update.
hclam@chromium.org [Wed, 25 Apr 2012 18:21:16 +0000 (18:21 +0000)]
Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84877

Mark a failing test after changes in r115227.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm
haraken@chromium.org [Wed, 25 Apr 2012 18:14:12 +0000 (18:14 +0000)]
[V8] Pass Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=84753

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to SerializedScriptValue::create()
in CodeGeneratorV8.pm.

Tests: bindings/scripts/test/TestObj.idl
       bindings/scripts/test/TestSerializedScriptValueInterface.idl

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateParametersCheck):
(JSValueToNative):

* bindings/scripts/test/V8/V8TestObj.cpp: Updated run-bindings-tests results.
(WebCore::TestObjV8Internal::intSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::serializedValueCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115222.
commit-queue@webkit.org [Wed, 25 Apr 2012 18:12:07 +0000 (18:12 +0000)]
Unreviewed, rolling out r115222.
http://trac.webkit.org/changeset/115222
https://bugs.webkit.org/show_bug.cgi?id=84874

Caused test regressions on the EFL build (Requested by rakuco
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-25

Tools:

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):

LayoutTests:

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add m_isolate to SerializedScriptValue::Writer
haraken@chromium.org [Wed, 25 Apr 2012 18:07:34 +0000 (18:07 +0000)]
[V8] Add m_isolate to SerializedScriptValue::Writer
and SerializedScriptValue::Reader
https://bugs.webkit.org/show_bug.cgi?id=84739

Reviewed by Nate Chapin.

This is the second step to pass Isolate around
in SerializedScriptValue. This patch adds m_isolate to
SerializedScriptValue::Writer and SerializedScriptValue::Reader,
so that they can use the isolate around. The fix is safe since
Writer and Reader are guaranteed to be used by one Isolate.

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
* bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make the Isolate* parameter non-optional in setDOMException()
haraken@chromium.org [Wed, 25 Apr 2012 17:58:19 +0000 (17:58 +0000)]
[V8] Make the Isolate* parameter non-optional in setDOMException()
https://bugs.webkit.org/show_bug.cgi?id=84736

Reviewed by Nate Chapin.

Now all setDOMException() callers pass Isolate* to setDOMException().
This patch makes the Isolate* parameter non-optional.

No tests. No change in behavior.

* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r112177): listStyleType CSS property gets converted into listStyle
rniwa@webkit.org [Wed, 25 Apr 2012 17:44:29 +0000 (17:44 +0000)]
REGRESSION(r112177): listStyleType CSS property gets converted into listStyle
https://bugs.webkit.org/show_bug.cgi?id=83026

Reviewed by Darin Adler.

Source/WebCore:

Fixed the bug by not using shorthand notations when some values are missing.

However, we still want to return a value when shorthand border property is explicitly
requested so extract borderPropertyValue with a flag to support both behaviors.

* css/StylePropertySet.cpp:
(WebCore::borderPropertyValue): Extracted from getPropertyValue.
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::get4Values): Don't return values when priority don't match.
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue): Don't return null string for initial values
to disambiguate missing values and "initial" in getPropertyValue. Also check propriety.
(WebCore::StylePropertySet::asText): Support emitting border-width, border-style, and
border-color when border doesn't work but the former properties do.

LayoutTests:

Added test cases to cssText-shorthand.html and rebaselined some tests.

* fast/css/cssText-shorthand-expected.txt:
* fast/css/cssText-shorthand.html: Added more test cases.
* fast/css/remove-shorthand-expected.txt: Correctly adds both border-width and border-style
when border-color is missing.
* printing/page-rule-css-text-expected.txt: Correctly uses border-width instead of border.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Do not clobber synchronized start times.
commit-queue@webkit.org [Wed, 25 Apr 2012 17:32:24 +0000 (17:32 +0000)]
[chromium] Do not clobber synchronized start times.
https://bugs.webkit.org/show_bug.cgi?id=84605

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-25
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerAnimationControllerTest.doNotClobberStartTimes

(WebCore):
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
(WebCore::CCActiveAnimation::hasSetStartTime):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):

Source/WebKit/chromium:

* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests):
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: REGRESSION (r100311): YummySoup app crashes when trying to print
japhet@chromium.org [Wed, 25 Apr 2012 17:12:20 +0000 (17:12 +0000)]
Source/WebCore: REGRESSION (r100311): YummySoup app crashes when trying to print
https://bugs.webkit.org/show_bug.cgi?id=83918

Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/cancel-during-failure-crash.html

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFail): Set m_calledDidFinishLoad when calling
   didFailToLoad() to prevent it from getting called twice if we cancel
   re-entrantly.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83918.

Reviewed by Alexey Proskuryakov.

* http/tests/cache/cancel-during-failure-crash-expected.txt: Added.
* http/tests/cache/cancel-during-failure-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntr...
commit-queue@webkit.org [Wed, 25 Apr 2012 17:04:04 +0000 (17:04 +0000)]
[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=83880

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-25
Reviewed by Antonio Gomes.

Tools:

Add missing implementation addOriginAccessWhitelistEntry and
removeOriginAccessWhitelistEntry to EFL's LayoutTestController
in order to unskip tests which rely on this.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):

LayoutTests:

Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
and removeOriginAccessWhitelistEntry implementation.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115222 268f45cc-cd09-0410-ab3c-d52691b4dbfc