WebKit-https.git
7 years agoPerfTestRunner.run should take an object
rniwa@webkit.org [Fri, 28 Sep 2012 00:26:14 +0000 (00:26 +0000)]
PerfTestRunner.run should take an object
https://bugs.webkit.org/show_bug.cgi?id=97743

Reviewed by Kentaro Hara.

Rename PerfTestRunner.run to PerfTestRunner.measureTime and make it take an object instead of
5 arguments. Also get rid of PerfTestRunner._loopsPerRun since it's no longer used (it's always 1).

* CSS/StyleSheetInsert.html:
* DOM/resources/dom-perf.js:
* Layout/floats_100_100.html:
* Layout/floats_100_100_nested.html:
* Layout/floats_20_100.html:
* Layout/floats_20_100_nested.html:
* Layout/floats_2_100.html:
* Layout/floats_2_100_nested.html:
* Layout/floats_50_100.html:
* Layout/floats_50_100_nested.html:
* Parser/html-parser.html:
* Parser/html5-full-render.html:
* SVG/SvgCubics.html:
* SVG/SvgHitTesting.html:
* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] FontHarfBuzz.cpp should not use drawTextOnPath().
bashi@chromium.org [Fri, 28 Sep 2012 00:13:34 +0000 (00:13 +0000)]
[Chromium] FontHarfBuzz.cpp should not use drawTextOnPath().
https://bugs.webkit.org/show_bug.cgi?id=97676

Reviewed by Tony Chang.

Use drawPosText() if possible for vertical text.
Use drawTextOnPath() only if the font doesn't have vhea/vmtx table.

No new tests. No change in behavior on LayoutTests.
Confirmed improvement in vertical text positioning using ipafont and Skia r5677.

* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::drawVerticalTextWithBrokenIdeographs): Added.
(WebCore):
(WebCore::Font::drawGlyphs): Draw vertical text by drawPosText() in a similar manner of FontSkia.cpp.
(WebCore::Font::drawComplexText): Disable setVerticalText(). Complex path doesn't support it now.
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint): Call setVertialText().
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph): Disable setVerticalText() if the font doesn't have vertical metrics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r129806.
jsbell@chromium.org [Fri, 28 Sep 2012 00:07:11 +0000 (00:07 +0000)]
Unreviewed, rolling out r129806.
http://trac.webkit.org/changeset/129806
https://bugs.webkit.org/show_bug.cgi?id=97831

Broke windows build due to missing header (Requested by jsbell
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-27

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/chromium: Remove unused methods from Chromium WebKit API.
commit-queue@webkit.org [Fri, 28 Sep 2012 00:05:04 +0000 (00:05 +0000)]
Source/WebKit/chromium: Remove unused methods from Chromium WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=95254

Patch by Nasko Oskov <nasko@chromium.org> on 2012-09-27
Reviewed by Adam Barth.

Removing methods, which are no longer in use.

* public/WebFrame.h:
* public/WebFrameClient.h:
(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):

Tools: Move DumpRenderTree to use newer version of the name method of
WebFrame and the willCheckAndDispatchMessageEvent method of WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=95254

Patch by Nasko Oskov <nasko@chromium.org> on 2012-09-27
Reviewed by Adam Barth.

The WebFrame name() method is removed and replaced by better named
uniqueName() method, so DRT needs to be updated to use this new version.
Also the willCheckAndDispatchMessageEvent in WebFrameClient gained
one more parameter, which had to be added in DRT.

* DumpRenderTree/chromium/TestShell.cpp:
(dumpFramesAsText):
(dumpFramesAsPrintedText):
(dumpFrameScrollPosition):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::unableToImplementPolicyWithError):
(WebViewHost::willCheckAndDispatchMessageEvent):
(WebViewHost::printFrameDescription):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelete test that no longer exists.
ojan@chromium.org [Fri, 28 Sep 2012 00:02:32 +0000 (00:02 +0000)]
Delete test that no longer exists.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the clang pragmas to disable warnings in Noncopyable.h
andersca@apple.com [Thu, 27 Sep 2012 23:57:06 +0000 (23:57 +0000)]
Remove the clang pragmas to disable warnings in Noncopyable.h
https://bugs.webkit.org/show_bug.cgi?id=97826

Reviewed by Beth Dakin.

Warnings about C++11 extensions are already disabled project-wide now so there's no need
to keep these pragmas.

* wtf/Noncopyable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
rniwa@webkit.org [Thu, 27 Sep 2012 23:39:09 +0000 (23:39 +0000)]
PerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
https://bugs.webkit.org/show_bug.cgi?id=97741

Reviewed by Antti Koivisto.

Reset the content in the iframe in each run so that the runtime from each run follows a normal distribution.
We can cleanup this code once my patch to replace the argument list of run by an object is landed.

* CSS/StyleSheetInsert.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Minor appearance tweaks after r129813.
rniwa@webkit.org [Thu, 27 Sep 2012 23:35:44 +0000 (23:35 +0000)]
Unreviewed. Minor appearance tweaks after r129813.

* resources/results-template.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
lforschler@apple.com [Thu, 27 Sep 2012 23:30:55 +0000 (23:30 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r129186): Pressing enter at the end of a line deletes the line
leviw@chromium.org [Thu, 27 Sep 2012 23:25:05 +0000 (23:25 +0000)]
REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763

Reviewed by Ryosuke Niwa.

r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.

This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).

* rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoResults page should warn about time-dependent distributions
rniwa@webkit.org [Thu, 27 Sep 2012 23:23:53 +0000 (23:23 +0000)]
Results page should warn about time-dependent distributions
https://bugs.webkit.org/show_bug.cgi?id=97818

Reviewed by Ojan Vafai.

Add a simple linear regression analysis on results page to detect time-dependent distributions.
We add a warning sign (inline SVG) when the regression gave us a slope of at least 0.01 and a R^2 of at least 0.6.
Also added time-series graphs per run under the bar graphs so that humans can manually inspect them.

A nice follow up would be to add some normality test (e.g. Shapiro-Wilk) to detect bi-modal distributions
but we probably need to restructure the code to run it asynchronously since normality tests are slow.

* resources/results-template.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=97823
bdakin@apple.com [Thu, 27 Sep 2012 22:37:45 +0000 (22:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=97823
Need to bump the WKBundlePageLoaderClient version after the addition of didLayout

Reviewed by Brady Eidson.

Bump the version.
* Shared/APIClientTraits.cpp:
(WebKit):
* Shared/APIClientTraits.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Split up setVersion and deleteDatabase sequencing tests
jsbell@chromium.org [Thu, 27 Sep 2012 22:33:53 +0000 (22:33 +0000)]
IndexedDB: Split up setVersion and deleteDatabase sequencing tests
https://bugs.webkit.org/show_bug.cgi?id=97482

Reviewed by Tony Chang.

Final chapter in the trilogy of webkit.org/b/97051 and webkit.org/b/97368 -
split up some complex multi-part tests so they are easier to understand and manage.
- Split open-close-setversion -> setversion-*
- Split factory-deletedatabase-interactions -> deletedatabase-*

* storage/indexeddb/deletedatabase-blocked-expected.txt: Added.
* storage/indexeddb/deletedatabase-blocked.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt: Added.
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
* storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt: Added.
* storage/indexeddb/deletedatabase-delayed-by-versionchange.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
* storage/indexeddb/deletedatabase-not-blocked-expected.txt: Added.
* storage/indexeddb/deletedatabase-not-blocked.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Removed.
* storage/indexeddb/open-close-version-expected.txt: Removed.
* storage/indexeddb/resources/deletedatabase-blocked.js: Added.
* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js: Added.
* storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js: Added.
* storage/indexeddb/resources/deletedatabase-not-blocked.js: Added.
* storage/indexeddb/resources/factory-deletedatabase-interactions.js: Removed.
* storage/indexeddb/resources/open-close-version.js: Removed.
* storage/indexeddb/resources/setversion-blocked-by-versionchange-close-in-blocked.js: Added.
* storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js: Added.
* storage/indexeddb/resources/setversion-blocked.js: Added.
* storage/indexeddb/resources/setversion-blocks-open.js: Added.
* storage/indexeddb/resources/setversion-blocks-setversion.js: Added.
* storage/indexeddb/resources/setversion-not-blocked.js: Added.
* storage/indexeddb/setversion-blocked-by-versionchange-close-expected.txt: Added.
* storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked-expected.txt: Added.
* storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
* storage/indexeddb/setversion-blocked-by-versionchange-close.html: Renamed from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
* storage/indexeddb/setversion-blocked-expected.txt: Added.
* storage/indexeddb/setversion-blocked.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
* storage/indexeddb/setversion-blocks-open-expected.txt: Added.
* storage/indexeddb/setversion-blocks-open.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
* storage/indexeddb/setversion-blocks-setversion-expected.txt: Added.
* storage/indexeddb/setversion-blocks-setversion.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
* storage/indexeddb/setversion-not-blocked-expected.txt: Added.
* storage/indexeddb/setversion-not-blocked.html: Renamed from LayoutTests/storage/indexeddb/open-close-version.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorequestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerCl...
commit-queue@webkit.org [Thu, 27 Sep 2012 22:25:36 +0000 (22:25 +0000)]
requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
https://bugs.webkit.org/show_bug.cgi?id=95360

Patch by Andrew Lo <anlo@rim.com> on 2012-09-27
Reviewed by Simon Fraser.

Source/WebCore:

DisplayRefreshMonitorManager::ensureMonitorForClient currently only adds the DisplayRefreshMonitorClient
to the appropriate DisplayRefreshMonitor when a new monitor is created.
It should also do so when it finds an existing monitor.

Test: fast/animation/request-animation-frame-iframe2.html

* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):

LayoutTests:

Add a new test which does requestAnimationFrame in both a sub-frame and
main-frame, and checks that both were executed.

* fast/animation/request-animation-frame-iframe2-expected.txt: Added.
* fast/animation/request-animation-frame-iframe2.html: Added.
* fast/animation/script-tests/request-animation-frame-subframe.html:
    Remove element parameter from window.webkitRequestAnimationFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium debug build fix.
arv@chromium.org [Thu, 27 Sep 2012 22:15:24 +0000 (22:15 +0000)]
Unreviewed Chromium debug build fix.

Two fixes makes one breakage

http://trac.webkit.org/changeset/129785
http://trac.webkit.org/changeset/129798

* bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Optimize encodeString/decodeString
jsbell@chromium.org [Thu, 27 Sep 2012 22:03:50 +0000 (22:03 +0000)]
IndexedDB: Optimize encodeString/decodeString
https://bugs.webkit.org/show_bug.cgi?id=97794

Reviewed by Tony Chang.

Optimize string encoding/decoding, which showed up as a CPU hot spot during profiling.
The backing store uses big-endian ordering of 16-bit code unit strings, so a memcopy
isn't sufficient, but the code used StringBuilder::append() character-by-character
and custom byte-swapping which was slow.

Ran a test w/ DumpRenderTree (to avoid multiprocess overhead) taking a 10k character string
and putting it 20k times and getting it 20k times. On my test box, mean time before the
patch was 8.2s, mean time after the patch was 4.6s.

Tested by Chromium's webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*String*'

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd webkit_unit_tests to the flakiness dashboard
abarth@webkit.org [Thu, 27 Sep 2012 22:01:17 +0000 (22:01 +0000)]
Add webkit_unit_tests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=97814

Patch by Julie Parent <jparent@chromium.org> on 2012-09-27
Reviewed by Dirk Pranke.

webkit_unit_tests run on the same bots as test_shell_tests.

* TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Perftest] PerfTestRunner exception when using nested git checkouts
fmalita@chromium.org [Thu, 27 Sep 2012 21:55:47 +0000 (21:55 +0000)]
[Perftest] PerfTestRunner exception when using nested git checkouts
https://bugs.webkit.org/show_bug.cgi?id=97796

Reviewed by Ryosuke Niwa.

In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
instantiate per-repository SCM objects when collecting revision information.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix 32-bit build.
andersca@apple.com [Thu, 27 Sep 2012 21:54:20 +0000 (21:54 +0000)]
Fix 32-bit build.

* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _initWithPath:]):
Add back the architecture check that i accidentally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
commit-queue@webkit.org [Thu, 27 Sep 2012 21:44:01 +0000 (21:44 +0000)]
[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
https://bugs.webkit.org/show_bug.cgi?id=97805

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-27
Reviewed by Alexey Proskuryakov.

Add support for handling a string as modifier argument to keyDown().
This support has already been added to other ports, so implementing
this on Mac too, to be consistent with the other ports.

* DumpRenderTree/mac/EventSendingController.mm:
(modifierFlags):
(buildModifierFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove support for CFM plug-ins in WebKit1
andersca@apple.com [Thu, 27 Sep 2012 21:36:36 +0000 (21:36 +0000)]
Remove support for CFM plug-ins in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=97822

Reviewed by Mark Rowe.

I'm pretty sure that CFM style plug-ins haven't been used for the last ten years or so,
so it's safe to remove them (especially since they're PPC only).

* Plugins/WebNetscapePluginPackage.h:
* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage closeResourceFile:]):
(-[WebNetscapePluginPackage _initWithPath:]):
(-[WebNetscapePluginPackage _tryLoad]):
(-[WebNetscapePluginPackage _unloadWithShutdown:]):
* Plugins/WebPluginDatabase.mm:
(PluginPackageCandidates::PluginPackageCandidates):
(PluginPackageCandidates::update):
(PluginPackageCandidates::bestCandidate):
(PluginPackageCandidates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoplatform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky...
ojan@chromium.org [Thu, 27 Sep 2012 21:33:27 +0000 (21:33 +0000)]
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky on Mac debug
and is passing on all the other bots.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
pilgrim@chromium.org [Thu, 27 Sep 2012 21:25:48 +0000 (21:25 +0000)]
[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97817

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore):
(WebCore::ScrollbarThemeChromiumMac::paint):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:
* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix issue with ClassList which was hitting an assert in debug mode
arv@chromium.org [Thu, 27 Sep 2012 21:03:47 +0000 (21:03 +0000)]
Fix issue with ClassList which was hitting an assert in debug mode
https://bugs.webkit.org/show_bug.cgi?id=97820

Reviewed by Ojan Vafai.

http://trac.webkit.org/changeset/129779 hit asserts in debug mode when trying to use fastGetAttribute on an SVG element.

No new tests. No change in behavior.

* bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):
* html/ClassList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskip a couple of passing tests.
rakuco@webkit.org [Thu, 27 Sep 2012 20:59:57 +0000 (20:59 +0000)]
[EFL] Unskip a couple of passing tests.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRewrite multithreaded filter job dispatching
pdr@google.com [Thu, 27 Sep 2012 20:49:30 +0000 (20:49 +0000)]
Rewrite multithreaded filter job dispatching
https://bugs.webkit.org/show_bug.cgi?id=97500

Reviewed by Dean Jackson.

Source/WebCore:

This patch solves the problem of splitting up images into subregions for multithreaded
filters. This fixes the way we partition the image array into equal-sized chunks.
If we have an array of length N and want to split it into K chunks, we calculate:
  int jobSize = N / K; // integer division, so this is floored
  int jobSizeExtra = N % K; // modulus produces the remainder
We then split the array into jobSizeExtra number of jobs with size jobSize + 1
and (K - jobSizeExtra) number of jobs with size jobSize. This pattern
is used in each of the 5 filters in this patch.

This patch primarily fixes an error in FEMorphology::platformApply where
the image array was partitioned into (1 + (N / K)) pieces with the last job
taking the remainder. Unfortunately, this can cause overruns in the 2nd-to-last job.
Consider N = 2373 and K = 64 jobs. Job 0 would take indices 0...38, job 1 would take
38...76, etc. Unfortunately the 62nd job takes 2356...2394 which overruns.

To prevent similar issues elsewhere this patch updates all of the filters
to use the same pattern as FEMorphology.

Test: svg/filters/feMorphology-crash.html

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::platformApplySoftware):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApply):

    Some special care is taken for Gaussian Blur because there is an
    extraHeight parameter for sampling outside the image's dimensions.
    This means we use the same partitioning algorithm but add
    extraHeight padding on the lower and upper bounds.

* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::platformApplySoftware):

LayoutTests:

Add test that shows the morphology filter no longer crashes.
Note: this is only reliably reproducable when run with libgmalloc.

* svg/filters/feMorphology-crash-expected.txt: Added.
* svg/filters/feMorphology-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium expectations update.
schenney@chromium.org [Thu, 27 Sep 2012 20:26:02 +0000 (20:26 +0000)]
Unreviewed Chromium expectations update.

Flakey compositing tests and another flakey dom/shadow test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoefl wk2 bots weren't looking at platform/wk2/TestExpectations
dpranke@chromium.org [Thu, 27 Sep 2012 20:21:29 +0000 (20:21 +0000)]
efl wk2 bots weren't looking at platform/wk2/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97815

Unreviewed, build fix.

Should clean up this logic later so that we're just using the
implementation in base ...

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._search_paths):
(EflPort.expectations_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium expectations update.
schenney@chromium.org [Thu, 27 Sep 2012 19:57:38 +0000 (19:57 +0000)]
Unreviewed Chromium expectations update.

Marking fast/dom/shadow/base-in-shadow-tree.html as timeout flakey.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move UNIX-specific theme functions out of PlatformSupport
pilgrim@chromium.org [Thu, 27 Sep 2012 19:48:58 +0000 (19:48 +0000)]
[Chromium] Move UNIX-specific theme functions out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96516

Reviewed by Adam Barth.

Call WebThemeEngine functions and use WebThemeEngine enums
directly from the new Platform/ directly; remove all
intermediate functions and enums and conversion functions from
PlatformSupport.
Part of a refactoring series; see tracking bug 82948.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::getWebThemeState):
(WebCore):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
commit-queue@webkit.org [Thu, 27 Sep 2012 19:44:29 +0000 (19:44 +0000)]
[Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
https://bugs.webkit.org/show_bug.cgi?id=97745

Patch by Helder Correia <helder.correia@nokia.com> on 2012-09-27
Reviewed by Martin Robinson.

In LayerTreeCoordinator::adoptImageBackingStore(), there is a
PLATFORM(QT) code path to check for identical images, but nothing is
done for Cairo, which results in the occurrence of avoidable resource
allocations.

The issue happens in e.g. http://www.webkit.org/blog-files/leaves/,
where there are many leaves flying around while they're produced out of
only four bitmaps.

This patch uses pointers to cairo_surface_t's as the key to the hashmap
that caches bitmaps. This can be safely done since we own the references.
We artificially increment the surface references in adoptImageBackingStore()
and decrement them in releaseImageBackingStore().

* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop using dispatch_get_current_queue
andersca@apple.com [Thu, 27 Sep 2012 19:33:57 +0000 (19:33 +0000)]
Stop using dispatch_get_current_queue
https://bugs.webkit.org/show_bug.cgi?id=97806
<rdar://problem/12379094>

Reviewed by Mark Rowe.

* Platform/mac/WorkQueueMac.cpp:
(WorkQueueAndFunction::WorkQueueAndFunction):
(WorkQueueAndFunction):
(WorkQueue::executeFunction):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
Keep track of the associated work queue so we can get it in WorkQueue::executeFunction.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::setUpTerminationNotificationHandler):
We don't care about which queue the termination notification is delivered on since we only want to call
waitpid on the child pid so we can just use a global queue.

* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]):
Use dispatch_get_main_queue here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] IconDatabase: Add a way to notify when icon data is available
mario@webkit.org [Thu, 27 Sep 2012 19:24:13 +0000 (19:24 +0000)]
[WK2] IconDatabase: Add a way to notify when icon data is available
https://bugs.webkit.org/show_bug.cgi?id=63945

Rubber stamped by Anders Carlsson.

Update version of WKIconDatabaseClient and API traits.

* Shared/APIClientTraits.cpp:
(WebKit):
* Shared/APIClientTraits.h:
* UIProcess/API/C/WKIconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomerge Skipped file entries into TestExpectations, remove Skipped files
dpranke@chromium.org [Thu, 27 Sep 2012 19:24:09 +0000 (19:24 +0000)]
merge Skipped file entries into TestExpectations, remove Skipped files
https://bugs.webkit.org/show_bug.cgi?id=97750

Reviewed by Ojan Vafai.

Now that old-run-webkit-tests will skip any tests listed in
TestExpectations files, there is no need to have both Skipped
files and TestExpectations files. This change merges all of the
entries in the Skipped files into the TestExpectations files and
removes the Skipped files.

Subsequent changes will remove support for Skipped files from
both new-run-webkit-tests and old-run-webkit-tests to
complete the project.

* platform/efl/Skipped: Removed.
* platform/efl/TestExpectations:
* platform/mac-lion/Skipped: Removed.
* platform/mac-lion/TestExpectations:
* platform/mac-snowleopard/Skipped: Removed.
* platform/mac-snowleopard/TestExpectations:
* platform/mac-wk2/Skipped: Removed.
* platform/mac-wk2/TestExpectations:
* platform/mac/Skipped: Removed.
* platform/mac/TestExpectations:
* platform/qt-4.8/Skipped: Removed.
* platform/qt-4.8/TestExpectations:
* platform/qt-5.0-wk1/Skipped: Removed.
* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk2/Skipped: Removed.
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0/Skipped: Removed.
* platform/qt-5.0/TestExpectations:
* platform/qt-arm/Skipped: Removed.
* platform/qt-arm/TestExpectations:
* platform/qt-linux/Skipped: Removed.
* platform/qt-mac/Skipped: Removed.
* platform/qt-mac/TestExpectations:
* platform/qt-win/Skipped: Removed.
* platform/qt/Skipped: Removed.
* platform/qt/TestExpectations:
* platform/win-wk2/Skipped: Removed.
* platform/win-wk2/TestExpectations:
* platform/win-xp/Skipped: Removed.
* platform/win-xp/TestExpectations:
* platform/win/Skipped: Removed.
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations: Renamed from LayoutTests/platform/wincairo/Skipped.
* platform/wk2/Skipped: Removed.
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Rename RenderStyle::wrapShapeInside/Outside to shapeInside/Outside
commit-queue@webkit.org [Thu, 27 Sep 2012 19:23:40 +0000 (19:23 +0000)]
[CSS Exclusions] Rename RenderStyle::wrapShapeInside/Outside to shapeInside/Outside
https://bugs.webkit.org/show_bug.cgi?id=97707

Patch by Bear Travis <betravis@adobe.com> on 2012-09-27
Reviewed by Antti Koivisto.

The exclusions specification has renamed wrap-shape-inside and wrap-shape-outside
to shape-inside and shape-outside. We should rename the getter/setter functions
in RenderStyle, and update the derived variable and function names accordingly.
For more information, see: http://dev.w3.org/csswg/css3-exclusions/#declaring-shapes

Covered by existing tests. No new functionality.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::StyleBuilder::StyleBuilder):
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::exclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::removeExclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::computeShapeSize):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::exclusionShapeInsideInfo):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoApplicationCacheStorage does not optimally handle 8 bit strings
msaboff@apple.com [Thu, 27 Sep 2012 19:04:59 +0000 (19:04 +0000)]
ApplicationCacheStorage does not optimally handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=97733

Reviewed by Alexey Proskuryakov.

Added 8 bit string paths.

No functional change, therefore no new tests.

* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::urlHostHash):
(WebCore::ApplicationCacheStorage::store):
(WebCore::parseHeader):
(WebCore::parseHeaders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium debug build fix.
schenney@chromium.org [Thu, 27 Sep 2012 19:03:31 +0000 (19:03 +0000)]
Unreviewed Chromium debug build fix.

ASSERT contains an inequality of unmatched types. A cast should do the trick.

* bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: make warning about missing BUG identifiers per-port configurable
dpranke@chromium.org [Thu, 27 Sep 2012 19:00:15 +0000 (19:00 +0000)]
webkitpy: make warning about missing BUG identifiers per-port configurable
https://bugs.webkit.org/show_bug.cgi?id=97751

Reviewed by Ojan Vafai.

Prior to this change linting TestExpectations files (checking their style)
would raise warnings if lines were missing a BUG modifier, even
though such a modifier is actually optional in the syntax. As we
migrate the entries over from the Skipped files, these warnings
will generate a lot of noise, and it's not yet clear that we
actually want to require the modifiers on all ports.

So, this change makes this per-port configurable so that they
will generate warnings in the Chromium TestExpectations and not
anywhere else.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_modifiers):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(MiscTests.test_parse_warning):
(SemanticTests.test_missing_bugid):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.warn_if_bug_missing_in_test_expectations):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.warn_if_bug_missing_in_test_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Push more fonts for layout tests to match chromium-linux
wangxianzhu@chromium.org [Thu, 27 Sep 2012 18:47:43 +0000 (18:47 +0000)]
[Chromium-Android] Push more fonts for layout tests to match chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=97746

Tools:

Reviewed by Dirk Pranke.

* DumpRenderTree/chromium/android_fallback_fonts.xml: Added the new fonts into fallback list. Removed the Android system fallback font DroidSansFallback.ttf.
* Scripts/webkitpy/layout_tests/port/builders.py: Add chromium-android to pass style check.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.check_build): Added check for md5sum and forwarder utilities to give better error message when they are missing.
(ChromiumAndroidPort.check_sys_deps): Allow host font files to come from one of multiple directories.
(ChromiumAndroidPort._path_to_md5sum):
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):

LayoutTests:

Some original rebaselines will be unnecessary after this change.
Checked some rebaselines of chromium-android under fast/text,
but there should be more. Leave them to gardening.

Reviewed by Dirk Pranke.

* platform/chromium-android/TestExpectations: Enabled some skipped tests because now we have the fonts.
* platform/chromium-android/fast/text/complex-text-opacity-expected.txt: Removed. No more need rebaselining.
* platform/chromium-android/fast/text/international/hindi-spacing-expected.txt: Removed. No more need rebaselining.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test
kbalazs@webkit.org [Thu, 27 Sep 2012 18:41:39 +0000 (18:41 +0000)]
[Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test
https://bugs.webkit.org/show_bug.cgi?id=97561

Reviewed by Noam Rosenthal.

Make sure we always send the very first RenderNextFrame message.
Before r128980 it was working accidentally because in the common
case the web process sent a DeleteCompositingLayer message at some
point before the forced repaint would time out and we was sending
the first RenderNextFrame when reacting to that.

* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setActive): Set the LayerTreeRenderer to active
as well. In the QQuickWebView case it is handled by the QtWebPageSGNode.
(QRawWebView::layerTreeRenderer): Added a convenience getter
for the LayerTreeRenderer.
(QRawWebView::paint):
* UIProcess/API/qt/raw/qrawwebview_p.h:
(WebKit):
* UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:
(tst_qrawwebview::tst_qrawwebview): Added a call to addQtWebProcessToPath
to make my and the follower users of this test easier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify and clarify MutationObserverRegistration interface and usage
adamk@chromium.org [Thu, 27 Sep 2012 18:35:13 +0000 (18:35 +0000)]
Simplify and clarify MutationObserverRegistration interface and usage
https://bugs.webkit.org/show_bug.cgi?id=97742

Reviewed by Ojan Vafai.

Minor cleanups in MutationObserverRegistration: make const methods explicitly const,
use C++ templates to avoid duplicating logic, improve usage of raw pointers vs PassRefPtr,
remove the declaration of a no-longer-existing method.

No change in behavior.

* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Take a raw pointer because we don't always ref the node.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom): Make this a const method.
* dom/MutationObserverRegistration.h:
(MutationObserverRegistration): Removed declaration of non-existent caseInsensitiveAttributeFilter method.
(WebCore::MutationObserverRegistration::hasTransientRegistrations): const method.
(WebCore::MutationObserverRegistration::isSubtree): Remove superfluous "inline" keyword.
(WebCore::MutationObserverRegistration::observer): const method.
* dom/Node.cpp:
(WebCore):
(WebCore::collectMatchingObserversForMutation): Add a templatized function to reduce duplicated code.
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver): Take a raw pointer because we don't always ref the observer.
* dom/Node.h:
(Node): Remove old method, replaced by templatized static function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up HasTrivialConstructor/Destructor
mhahnenberg@apple.com [Thu, 27 Sep 2012 18:30:40 +0000 (18:30 +0000)]
Clean up HasTrivialConstructor/Destructor
https://bugs.webkit.org/show_bug.cgi?id=97754

Reviewed by Darin Adler.

Cleaned up HasTrivialConstructor and HasTrivialDestructor by defining them in terms of
other type traits we have. Also moved some ifdefs and comments to make things more clear.

* wtf/TypeTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDOM4: Add support for rest parameters to DOMTokenList
arv@chromium.org [Thu, 27 Sep 2012 18:05:28 +0000 (18:05 +0000)]
DOM4: Add support for rest parameters to DOMTokenList
https://bugs.webkit.org/show_bug.cgi?id=97335

Reviewed by Ojan Vafai.

This adds support for rest paramaters to DOMTokenList add and remove.
http://dom.spec.whatwg.org/#domtokenlist

The code generator has been updated to understand variadic methods.
When a method has a rest parameter the remaining arguments are collected
into a WTF::Vector.

DOMTokenList, DOMSettableTokenList and ClassList were restructured a bit to
allow code to be shared better.

Source/WebCore:

Updated existing tests and includes new binding tests.

* bindings/js/JSDOMBinding.h:
(WebCore::toNativeArray):
(WebCore):
(WebCore::toNativeArguments): Similar to toNativeArray but extracts the arguments instead.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateArgumentsCountCheck): Updated to treat rest paramaters as optional.
(GenerateParametersCheck): Generate code for rest params.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionParametersCheck): Updated to treat rest paramaters as optional.
(GenerateArgumentsCountCheck): Ditto.
(GenerateParametersCheck):  Generate code for rest params.
* bindings/scripts/IDLParser.pm:
(parseOptionalOrRequiredArgument):
* bindings/scripts/IDLStructure.pm:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::variadicStringMethod):
(WebDOMTestObj::variadicDoubleMethod):
(WebDOMTestObj::variadicNodeMethod):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_variadic_string_method):
(webkit_dom_test_obj_variadic_double_method):
(webkit_dom_test_obj_variadic_node_method):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj variadicStringMethod:tail:]):
(-[DOMTestObj variadicDoubleMethod:tail:]):
(-[DOMTestObj variadicNodeMethod:tail:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
* bindings/v8/V8Binding.h:
(WebCore::toNativeArray):
(WebCore):
(WebCore::toNativeArguments): Similar to toNativeArray but extracts the arguments instead.
* html/ClassList.cpp:
(WebCore::ClassList::ClassList):
* html/ClassList.h:
(WebCore):
(ClassList):
* html/DOMSettableTokenList.cpp:
(WebCore::DOMSettableTokenList::containsInternal):
(WebCore::DOMSettableTokenList::add):
(WebCore::DOMSettableTokenList::addInternal):
(WebCore::DOMSettableTokenList::remove):
(WebCore::DOMSettableTokenList::removeInternal):
(WebCore::DOMSettableTokenList::setValue):
* html/DOMSettableTokenList.h:
(DOMSettableTokenList):
* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::validateTokens):
(WebCore):
(WebCore::DOMTokenList::contains): Moved implementation to base class to allow code sharing.
(WebCore::DOMTokenList::add): Ditto.
(WebCore::DOMTokenList::remove): Ditto.
(WebCore::DOMTokenList::toggle): Ditto.
(WebCore::DOMTokenList::addInternal): Ditto.
(WebCore::DOMTokenList::removeInternal): Ditto.
(WebCore::DOMTokenList::addToken): Ditto.
(WebCore::DOMTokenList::addTokens):
(WebCore::DOMTokenList::removeToken): Ditto.
(WebCore::DOMTokenList::removeTokens):
* html/DOMTokenList.h:
(DOMTokenList):
(WebCore::DOMTokenList::toString):
* html/DOMTokenList.idl:

LayoutTests:

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
(element.classList.add):
(createElement):
(shouldBeEqualToString):
(element.classList.remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline more test directories for Android.
peter@chromium.org [Thu, 27 Sep 2012 17:52:27 +0000 (17:52 +0000)]
[Chromium] Rebaseline more test directories for Android.

Unreviewed rebaselining.

Same as previous commits. Most changes are caused by the scrollbar, text selection
color and quality differences in image quality, causing minor (but acceptable)
differences. More information is available in bug 96398.

* platform/chromium-android/svg/: 71 new results.
* platform/chromium-android/tables/: 250 new results.
* platform/chromium-android/transforms/: 5 new results.
* platform/chromium-android/transitions/: 1 new result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline several test directories for Android/.
peter@chromium.org [Thu, 27 Sep 2012 17:38:34 +0000 (17:38 +0000)]
[Chromium] Rebaseline several test directories for Android/.

Unreviewed rebaselining.

Most of these changes were caused by our different scrollbars and minor
positioning issues, and therefore are safe to rebase. With Xianzhu's
patch in the tree that adds additional fonts, more pass there as well.
Actual failures include more form items. Bugs will be filed.

* platform/chromium-android/animations/: 4 new results.
* platform/chromium-android/compositing/: 72 new results.
* platform/chromium-android/css2.1/: 52 new results.
* platform/chromium-android/css3/: 5 new results.
* platform/chromium-android/editing/: 46 new results.
* platform/chromium-android/fast/: 42 new results.
* platform/chromium-android/fonts/: 12 new results.
* platform/chromium-android/http/: 5 new results.
* platform/chromium-android/ietestcenter/: 4 new results.
* platform/chromium-android/platform/: 13 new results.
* platform/chromium-android/printing/: 2 new results.
* platform/chromium-android/scrollbars/: 2 new results.
* platform/chromium-android/svg/: 4 new results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago332kB below DocumentEventQueue::create() on Membuster3.
kling@webkit.org [Thu, 27 Sep 2012 17:23:11 +0000 (17:23 +0000)]
332kB below DocumentEventQueue::create() on Membuster3.
<http://webkit.org/b/97712>

Reviewed by Anders Carlsson.

Give DocumentEventQueue::m_queuedEvents an inline capacity of 16 (the default is 256.)
312kB progression on Membuster3.

* dom/DocumentEventQueue.h:
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::pendingEventTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar...
vsevik@chromium.org [Thu, 27 Sep 2012 17:09:38 +0000 (17:09 +0000)]
Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=97783

Reviewed by Pavel Feldman.

BreakpointSidebarPane now explicitly adds all breakpoints that are available at the moment of its creation.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix usage of COMPILER() macros
paroga@webkit.org [Thu, 27 Sep 2012 17:09:02 +0000 (17:09 +0000)]
Fix usage of COMPILER() macros
https://bugs.webkit.org/show_bug.cgi?id=97642

Reviewed by Geoffrey Garen.

Add COMPILER(GCC) around compiler specific code and remove it from generic code.
This allows us to implement the DFG code for other compilers to in a next step.

* dfg/DFGOperations.cpp:
* jit/HostCallReturnValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago3.20MB below FunctionParameters::create() on Membuster3.
kling@webkit.org [Thu, 27 Sep 2012 17:04:40 +0000 (17:04 +0000)]
3.20MB below FunctionParameters::create() on Membuster3.
<http://webkit.org/b/97730>

Reviewed by Anders Carlsson.

Figure out the exact space needed for parameter identifiers and use reserveInitialCapacity().
Reduces memory consumption on Membuster3 by ~1.60 MB.

* parser/Nodes.cpp:
(JSC::FunctionParameters::FunctionParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPage overlays are not updated when WebView is resized
caseq@chromium.org [Thu, 27 Sep 2012 17:01:58 +0000 (17:01 +0000)]
Page overlays are not updated when WebView is resized
https://bugs.webkit.org/show_bug.cgi?id=97789

Reviewed by Vsevolod Vlasov.

Invalidate page overlays when view is resized.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::sendResizeEventAndRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDropping JSC references from InspectorInstrumentation.h by including 'ScriptState.h'
mkwst@chromium.org [Thu, 27 Sep 2012 16:58:22 +0000 (16:58 +0000)]
Dropping JSC references from InspectorInstrumentation.h by including 'ScriptState.h'
https://bugs.webkit.org/show_bug.cgi?id=97759

Reviewed by Adam Barth.

InspectorInstrumentation.h includes two '#if USE(JSC)' blocks, which
I've been reliably informed should not appear in WebCore[1]. This patch
drops both blocks, and includes 'ScriptState.h' instead, which should
have the same practical effect.

There's no functional change, so this should be covered by existing tests.

[1]: https://bugs.webkit.org/show_bug.cgi?id=94433#c55

* inspector/InspectorInstrumentation.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 27 Sep 2012 16:22:47 +0000 (16:22 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-27

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused regular expressions from IDLStructure.pm
arv@chromium.org [Thu, 27 Sep 2012 16:06:48 +0000 (16:06 +0000)]
Remove unused regular expressions from IDLStructure.pm
https://bugs.webkit.org/show_bug.cgi?id=97790

Reviewed by Kentaro Hara.

After http://trac.webkit.org/changeset/129723 these regular expressions are no longer used.

No new tests, run-binding-tests generates the same output.

* bindings/scripts/IDLStructure.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/profiler/apply.html fails with LLInt on 32 bit
ossy@webkit.org [Thu, 27 Sep 2012 15:54:06 +0000 (15:54 +0000)]
[Qt] fast/profiler/apply.html fails with LLInt on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=97791

Unreviewed gardening, skip the new failing test to paint the bots green.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium expectations
schenney@chromium.org [Thu, 27 Sep 2012 15:42:02 +0000 (15:42 +0000)]
Unreviewed Chromium expectations

Expectations that were lagging at the last rebaseline.

* platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/date: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/date: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2][WTR] Unskip two jQuery test cases.
commit-queue@webkit.org [Thu, 27 Sep 2012 15:26:23 +0000 (15:26 +0000)]
[EFL][WK2][WTR] Unskip two jQuery test cases.
https://bugs.webkit.org/show_bug.cgi?id=97787

Unreviewed EFL gardening.

'jquery/data.html' and 'jquery/offset.html' cases seem to be passed consistently now.

For more information, BUG 81606 resolved some jQuery test cases
that need several seconds to finish its running by extending timeout value like WK1.

Seemingly, mentioned two cases took around 5 seconds for each on my laptop
and it would had been flaky in different hardware condition before BUG 81606.

Therefore, this patch unskipped those cases from TestExpections.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-27

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Process touch events using mouse and multi events of Evas.
commit-queue@webkit.org [Thu, 27 Sep 2012 15:08:14 +0000 (15:08 +0000)]
[EFL][WK2] Process touch events using mouse and multi events of Evas.
https://bugs.webkit.org/show_bug.cgi?id=96906

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Provide default behavior for processing touch events in the ewk_view if
application wants to use it.
We can to process touch events using mouse and multi events because the
Evas creates mouse events for first touch and multi events for second and
third touch. It can be modified when Evas starts to support event type
for touch events.

* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_feed_touch_event_using_touch_point_list_of_evas):
(_ewk_view_on_touch_down):
(_ewk_view_on_touch_up):
(_ewk_view_on_touch_move):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
(EWK2UnitTest):
(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
(EWK2UnitTest::EWK2UnitTestBase::mouseMove):
(EWK2UnitTest::EWK2UnitTestBase::multiDown):
(EWK2UnitTest::EWK2UnitTestBase::multiUp):
(EWK2UnitTest::EWK2UnitTestBase::multiMove):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Enhance MediaConstraints to make it easier to get the constraint...
tommyw@google.com [Thu, 27 Sep 2012 14:56:53 +0000 (14:56 +0000)]
MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
https://bugs.webkit.org/show_bug.cgi?id=97559

Reviewed by Adam Barth.

Source/Platform:

Refactored to mimic the new MediaConstraints api.

* chromium/public/WebMediaConstraints.h:
(WebCore):
(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebMediaConstraint):
(WebKit):
(WebMediaConstraints):

Source/WebCore:

Instead of just returning the names, return a pair of name and value.

Existing tests cover this patch.

* Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::initialize):
(WebCore::MediaConstraintsImpl::getMandatoryConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraintValue):
* Modules/mediastream/MediaConstraintsImpl.h:
(MediaConstraintsImpl):
* platform/chromium/support/WebMediaConstraints.cpp:
(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebKit):
(WebKit::WebMediaConstraints::getMandatoryConstraints):
(WebKit::WebMediaConstraints::getOptionalConstraints):
* platform/mediastream/MediaConstraints.h:
(WebCore::MediaConstraint::MediaConstraint):
(MediaConstraint):
(WebCore):
(MediaConstraints):

Tools:

Refactoring for the new WebMediaConstraints api.

* DumpRenderTree/chromium/MockConstraints.cpp:
(MockConstraints::verify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium expectations
schenney@chromium.org [Thu, 27 Sep 2012 13:51:04 +0000 (13:51 +0000)]
Unreviewed Chromium expectations

Cleanup after a night of building. I think some of these failures are
due to premature rebaselining earlier.

* platform/chromium-linux-x86/fast/forms/placeholder-position-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
* platform/chromium-linux-x86/platform/chromium/fast/forms/date: Added.
* platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
* platform/chromium-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
* platform/chromium-linux/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-linux/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-linux/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-linux/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/date: Added.
* platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/3d-corners-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-permanently-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-twice-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/render-surface-alpha-blending-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win-xp/fast/text/line-breaks-expected.txt:
* platform/chromium-win-xp/platform/chromium/compositing/3d-corners-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/layout-width-change-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/tiny-layer-rotated-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/video-frame-size-change-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/date: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/date: Added.
* platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/js/eval-cross-window-expected.txt: Replaced.
* platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Replaced.
* platform/chromium/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
* platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
* platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: move visited and countObjectSize methods implementation into...
loislo@chromium.org [Thu, 27 Sep 2012 13:45:57 +0000 (13:45 +0000)]
Web Inspector: NMI: move visited and countObjectSize methods implementation into separate class.
https://bugs.webkit.org/show_bug.cgi?id=97461

Reviewed by Yury Semikhatsky.

These methods and the data collected by them need to be used in the instrumentation code for other components.
As example when we are visiting bitmaps we need to visit platform specific objects.
These objects will be instrumented with help of component's own instrumentation code
but we have to keep the single set of visited objects and the map of counters.

Source/WebCore:

* inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::countObjectSize):
(WebCore):
(WebCore::MemoryInstrumentationClientImpl::visited):
(WebCore::MemoryInstrumentationImpl::selfSize):
* inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationClientImpl::MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::selfSize):
(MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::visitedObjects):
(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(InstrumentationTestHelper):
(WebCore::InstrumentationTestHelper::InstrumentationTestHelper):
(WebCore::InstrumentationTestHelper::addRootObject):
(WebCore::InstrumentationTestHelper::reportedSizeForAllTypes):
(WebCore::InstrumentationTestHelper::visitedObjects):
(WebCore::InstrumentationTestHelper::totalSize):
(WebCore):
(WebCore::TEST):

Source/WTF:

* wtf/MemoryInstrumentation.h:
(MemoryInstrumentationClient):
(WTF::MemoryInstrumentationClient::~MemoryInstrumentationClient):
(WTF):
(WTF::MemoryInstrumentation::MemoryInstrumentation):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::countObjectSize):
(WTF::MemoryInstrumentation::visited):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Rename MockConstraints::verify to verifyConstraints
tommyw@google.com [Thu, 27 Sep 2012 13:44:06 +0000 (13:44 +0000)]
MediaStream API: Rename MockConstraints::verify to verifyConstraints
https://bugs.webkit.org/show_bug.cgi?id=97779

Reviewed by Csaba Osztrogonác.

The Mac OS X sdk has a macro called verify :/

* DumpRenderTree/chromium/MockConstraints.cpp:
(MockConstraints::verifyConstraints):
* DumpRenderTree/chromium/MockConstraints.h:
(MockConstraints):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::initialize):
* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebUserMediaClientMock::requestUserMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable the LLInt on Linux
ossy@webkit.org [Thu, 27 Sep 2012 13:28:34 +0000 (13:28 +0000)]
[Qt] Enable the LLInt on Linux
https://bugs.webkit.org/show_bug.cgi?id=95749

Patch by Csaba Osztrogonác  <ossy@webkit.org>, Tor Arne Vestbø <vestbo@webkit.org> on 2012-09-27
Reviewed by Simon Hausmann.

Source/JavaScriptCore:

* DerivedSources.pri:
* JavaScriptCore.pro:
* LLIntOffsetsExtractor.pro: Added.
* Target.pri:

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Remove unnecessary header files from CMakeLists.txt
commit-queue@webkit.org [Thu, 27 Sep 2012 13:17:18 +0000 (13:17 +0000)]
[CMAKE] Remove unnecessary header files from CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=97771

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-27
Reviewed by Kentaro Hara.

Remove the header files which are added in the source file list.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add callback functions for WKPageFindClient
commit-queue@webkit.org [Thu, 27 Sep 2012 13:00:12 +0000 (13:00 +0000)]
[EFL][WK2] Add callback functions for WKPageFindClient
https://bugs.webkit.org/show_bug.cgi?id=97431

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-27
Reviewed by Laszlo Gombos.

Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions.
The unit test for didFindString() and didFailToFindString() have beend added. The unit test for
didCountStringMatches() needs a API which wraps the WKPageCountStringMatches but it is not exists yet.
Additionaly, I changed the 'unsinged int' to 'unsigned' in the parameter type and removed unnecessary
type conversion.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_text_find):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_find_client.cpp:
(didFindString):
(didFailToFindString):
(didCountStringMatches):
(ewk_view_find_client_attach):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(onTextFound):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, re-landing r129633 with the proper order of calls.
caseq@chromium.org [Thu, 27 Sep 2012 12:53:56 +0000 (12:53 +0000)]
Unreviewed, re-landing r129633 with the proper order of calls.
https://bugs.webkit.org/show_bug.cgi?id=97659

* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unskip now passing test.
kadam@inf.u-szeged.hu [Thu, 27 Sep 2012 12:21:00 +0000 (12:21 +0000)]
[Qt] Unreviewed gardening. Unskip now passing test.
https://bugs.webkit.org/show_bug.cgi?id=71896.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r129633.
caseq@chromium.org [Thu, 27 Sep 2012 12:15:52 +0000 (12:15 +0000)]
Unreviewed, rolling out r129633.
http://trac.webkit.org/changeset/129633
https://bugs.webkit.org/show_bug.cgi?id=97659

Breaks inspector overlay in non-composited mode

* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscre...
commit-queue@webkit.org [Thu, 27 Sep 2012 11:46:03 +0000 (11:46 +0000)]
[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
https://bugs.webkit.org/show_bug.cgi?id=97770

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Some CSS rules were duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css
for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget
to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline
display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in
sync with what is in mediaControlsEfl.css.

We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to
fullscreen mode, that is to say, the hiding of some controls.

No new tests, no behavior change for layout tests.

* css/mediaControlsEflFullscreen.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Open resource dialog should assume implicit wildcard in the beginning...
vsevik@chromium.org [Thu, 27 Sep 2012 11:39:58 +0000 (11:39 +0000)]
Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
https://bugs.webkit.org/show_bug.cgi?id=97768

Reviewed by Pavel Feldman.

Source/WebCore:

Open resource dialog now assumes implicit wildcard in the beginning of the query.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):

LayoutTests:

* inspector/filtered-item-selection-dialog-filtering-expected.txt:
* inspector/filtered-item-selection-dialog-filtering.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][CMAKE] Default theme files are outdated in PlatformEfl.cmake
commit-queue@webkit.org [Thu, 27 Sep 2012 11:22:49 +0000 (11:22 +0000)]
[EFL][CMAKE] Default theme files are outdated in PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=97769

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Update Default theme files in PlatformEfl.cmake so that
changes to those files are properly picked up by CMake
when building incrementally.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: do not use InspectorInstrumentation::hasFrontends() check when collect...
pfeldman@chromium.org [Thu, 27 Sep 2012 11:18:23 +0000 (11:18 +0000)]
Web Inspector: do not use InspectorInstrumentation::hasFrontends() check when collecting stacks
https://bugs.webkit.org/show_bug.cgi?id=96730

Reviewed by Vsevolod Vlasov.

- Introduced InspectorInstrumentation::console|timeline|runtime|canvasAgentEnabled
- Using it all over the place instead of the hasFrontend (the latter is now only used once to guard hot path)
- Introduced explicit "enabled" state of the console and runtime agents

* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::instrumentFunctionCall):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForConsole):
* bindings/js/ScriptCallStackFactory.h:
(WebCore):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallWith):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForConsole):
* bindings/v8/ScriptCallStackFactory.h:
(WebCore):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunctionWithInstrumentation):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore):
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::clearFrontend):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
(WebCore::InspectorConsoleAgent::enabled):
(InspectorConsoleAgent):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
* inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::enabled):
(WebCore::InspectorRuntimeAgent::enable):
(WebCore::InspectorRuntimeAgent::disable):
(InspectorRuntimeAgent):
* inspector/PageRuntimeAgent.cpp:
(PageRuntimeAgentState):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::didClearWindowObject):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
* inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
* inspector/WorkerRuntimeAgent.cpp:
* inspector/WorkerRuntimeAgent.h:
* inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype._didLoadCachedResources):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnify event handling of middle mouse button.
commit-queue@webkit.org [Thu, 27 Sep 2012 11:12:11 +0000 (11:12 +0000)]
Unify event handling of middle mouse button.
https://bugs.webkit.org/show_bug.cgi?id=97690

Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-09-27
Reviewed by Tony Chang.

Source/WebCore:

Implement a unified version of middle mouse button press that can be shared between
all the ports with X11 support.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handlePasteGlobalSelection):
* page/EventHandler.h:
(EventHandler):

Source/WebKit/chromium:

Remove port specific handling of middle mouse button press.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseUp):

Source/WebKit/gtk:

Remove port specific handling of middle mouse button press.

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::supportsGlobalSelection):
* WebCoreSupport/EditorClientGtk.h:
(EditorClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_button_press_event):

Source/WebKit/qt:

Remove port specific handling of middle mouse button press.

* Api/qwebpage.cpp:
(QWebPagePrivate::mouseReleaseEvent):
* Api/qwebpage_p.h:
(QWebPagePrivate):

Source/WebKit2:

Remove Qt and GTK port specific handling of middle mouse button press.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit):
* WebProcess/WebPage/qt/WebPageQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Update getUserMedia to match the latest specification
tommyw@google.com [Thu, 27 Sep 2012 11:07:12 +0000 (11:07 +0000)]
MediaStream API: Update getUserMedia to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=97540

Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebMediaConstraints.h:
(WebMediaConstraints):

Source/WebCore:

http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

Existing tests expanded to cover the new change.

* Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::create):
(WebCore):
* Modules/mediastream/MediaConstraintsImpl.h:
(MediaConstraintsImpl):
* Modules/mediastream/NavigatorMediaStream.cpp:
(WebCore::NavigatorMediaStream::webkitGetUserMedia):
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::parseOptions):
(WebCore):
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::audioConstraints):
(WebCore::UserMediaRequest::videoConstraints):
* Modules/mediastream/UserMediaRequest.h:
(WebCore):
(UserMediaRequest):
* platform/chromium/support/WebMediaConstraints.cpp:
(WebKit::WebMediaConstraints::WebMediaConstraints):
(WebKit):

Source/WebKit/chromium:

http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

* public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
* src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):

Tools:

http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

* public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
* src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):

LayoutTests:

Expanding tests to cover the new getUserMedia behaviour.

* fast/mediastream/getusermedia-expected.txt:
* fast/mediastream/getusermedia.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed inspector front-end closure compilation fix.
vsevik@chromium.org [Thu, 27 Sep 2012 10:37:56 +0000 (10:37 +0000)]
Unreviewed inspector front-end closure compilation fix.

* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unskip a test again after r129712.
ossy@webkit.org [Thu, 27 Sep 2012 10:05:10 +0000 (10:05 +0000)]
[Qt] Unreviewed gardening. Unskip a test again after r129712.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCollectingRules and QueryingRules modes of SelectorChecker miss some complex selector...
apavlov@chromium.org [Thu, 27 Sep 2012 09:55:52 +0000 (09:55 +0000)]
CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=78595

Reviewed by Antti Koivisto.

Source/WebCore:

Do not use the same dynamicPseudo reference when recursively invoking checkSelector() for non-SubSelector selectors.

Test: fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Use new NOPSEUDO dynamic pseudoId values
for each non-SubSelector selector further in the tag history.

LayoutTests:

The original issue mentioned failures on selectors like ".foo.moo > .bar:before", while things worked fine for ".foo > .bar:before".
The test checks 2 and 3 selector levels for all conventional non-SubSelector relations (Child, Descendant, DirectAdjacent, IndirectAdjacent),
each selector in all levels but the last one containing a SubSelector relation.

* fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html: Added.
* fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] No way to exit video fullscreen mode once entered
commit-queue@webkit.org [Thu, 27 Sep 2012 09:44:05 +0000 (09:44 +0000)]
[EFL] No way to exit video fullscreen mode once entered
https://bugs.webkit.org/show_bug.cgi?id=97631

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Show fullscreen media control in fullscreen so that
we now have a way to exit fullscreen mode.

No new tests, no behavior change for layout tests.

* css/mediaControlsEflFullscreen.css:
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):

Source/WebKit/efl:

Fix default theme so that we have 2 fullscreen buttons, one
to enter fullscreen mode and another to exit it.

New icon by Alexander Shalamov.

* DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Added.
* DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Added.
* DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
* DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed inspector test unskipped on qt, expectations updated.
vsevik@chromium.org [Thu, 27 Sep 2012 09:40:54 +0000 (09:40 +0000)]
Unreviewed inspector test unskipped on qt, expectations updated.

* http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Injected bundle API implementation should use toWTFString()
commit-queue@webkit.org [Thu, 27 Sep 2012 09:32:32 +0000 (09:32 +0000)]
[WK2] Injected bundle API implementation should use toWTFString()
https://bugs.webkit.org/show_bug.cgi?id=97766

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Injected bundle API implementation should call toWTFString() rather than convert
WKStringRef and WKURLRef to their impls and then call string() method directly.
The rational for that are both safety (toWTFString checks the given pointer) and
code readability.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePostMessage):
(WKBundlePostSynchronousMessage):
(WKBundleOverrideBoolPreferenceForTestRunner):
(WKBundleAddOriginAccessWhitelistEntry):
(WKBundleRemoveOriginAccessWhitelistEntry):
(WKBundleClearApplicationCacheForOrigin):
(WKBundleGetAppCacheUsageForOrigin):
(WKBundleSetApplicationCacheOriginQuota):
(WKBundleResetApplicationCacheOriginQuota):
(WKBundlePageNumberForElementById):
(WKBundleSetUserStyleSheetLocation):
(WKBundleSetWebNotificationPermission):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFramePauseAnimationOnElementWithId):
(WKBundleFramePauseTransitionOnElementWithId):
(WKBundleFrameAllowsFollowingLink):
(WKBundleFrameCopySuggestedFilenameForResourceWithURL):
(WKBundleFrameCopyMIMETypeForResourceWithURL):
(WKBundleFrameSetTextDirection):
* WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorEvaluateScriptForTest):
* WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:
(WKBundleIntentCreate):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageExecuteEditingCommand):
(WKBundlePageIsEditingCommandEnabled):
(WKBundlePageHasLocalDataForURL):
(WKBundlePageFindString):
(WKBundlePageSetComposition):
(WKBundlePageConfirmCompositionWithText):
(WKBundlePageCanShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] IconDatabase: Add a way to notify when icon data is available
mario@webkit.org [Thu, 27 Sep 2012 09:24:59 +0000 (09:24 +0000)]
[WK2] IconDatabase: Add a way to notify when icon data is available
https://bugs.webkit.org/show_bug.cgi?id=63945

Reviewed by Anders Carlsson.

Provide new API to notify the API layer when icon data is
available, and use it from the implementation layer when needed,
that is, either when the data has been loaded from the network or
imported from disk.

Added new callback to WKIconDatabaseClient API.

* UIProcess/API/C/WKIconDatabase.h: Added new callback.
* UIProcess/WebIconDatabaseClient.cpp:
(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL):
Implementation of the new callback at this level in the UI
process, by using its implementation in the API layer if present.
* UIProcess/WebIconDatabaseClient.h:
(WebIconDatabaseClient): Added new callback.

Implemented WebFrameLoaderClient::dispatchDidReceiveIcon, so we
get notified in the UI process when loading a new icon.

* UIProcess/WebIconDatabase.messages.in: Added new message to
notify the UI process: DidReceiveIconForPageURL.
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::notifyIconDataReadyForPageURL): New
private helper function to notify the API layer both that new icon
data is ready and that the icon has changed.
(WebKit::WebIconDatabase::didReceiveIconForPageURL):
Implementation of the new message added, by calling
notifyIconDataReadyForPageURL() to notify the API layer.
(WebKit::WebIconDatabase::didImportIconDataForPageURL): Call
notifyIconDataReadyForPageURL() from here as well.
* UIProcess/WebIconDatabase.h: Added new prototypes.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon): Send a
message to the UI process telling a new icon has been received.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip fast/dom/Geolocation to make LayoutTests faster
commit-queue@webkit.org [Thu, 27 Sep 2012 08:57:30 +0000 (08:57 +0000)]
[EFL] Skip fast/dom/Geolocation to make LayoutTests faster
https://bugs.webkit.org/show_bug.cgi?id=97765

Unreviewed EFL gardening.

Skip fast/dom/Geolocation for EFL port instead of marking
them with "Failure" expectation. This makes running
LayoutTests much faster.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-27

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskip http/tests/security/xss-eval.html again.
rakuco@webkit.org [Thu, 27 Sep 2012 08:36:42 +0000 (08:36 +0000)]
[EFL] Unskip http/tests/security/xss-eval.html again.

Fix was re-landed in r129712.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditEleme...
yosin@chromium.org [Thu, 27 Sep 2012 08:22:03 +0000 (08:22 +0000)]
[Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing
https://bugs.webkit.org/show_bug.cgi?id=97756

Reviewed by Kent Tamura.

This patch changes class hierarchy of BaseMultipleFieldsDateAndTimeInputType
to inherit from DateTimeEditElement::EditControlOwner rather than
containing an instance of DateTimeEditElement::EditControlOwner for
saving memory, although one pointer, and one memory fetch on using
HTMLInputElement.

Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests. This patch doesn't change behavior.

* html/BaseMultipleFieldsDateAndTimeInputType.cpp: DateTimeEditElement::EditControlOwner::DateTimeformatDateTimeFieldsState was removed. We no longer need to redirection. Each date/time input type classe implements it.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::didBlurFromControl): Moved from DateTimeEditControlOwnerImpl and removed reference of m_dateTimeInputType.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::didFocusOnControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): Changed to pass BaseMultipleFieldsDateAndTimeInputType instead of DateTimeEditControlOwnerImpl.
* html/BaseMultipleFieldsDateAndTimeInputType.h: Changed base class to have DateTImeEditElement::EditControlOwner.
(BaseMultipleFieldsDateAndTimeInputType): Removed DateTimeEditControlOwnerImpl class and member variable m_dateTimeEditControlOwner.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSuggestionPicker should support rtl
keishi@webkit.org [Thu, 27 Sep 2012 08:17:24 +0000 (08:17 +0000)]
SuggestionPicker should support rtl
https://bugs.webkit.org/show_bug.cgi?id=97555

Reviewed by Kent Tamura.

.:

* ManualTests/forms/calendar-picker.html: Added tests for Arabic with datalist.

Source/WebCore:

Add support for rtl to SuggestionPicker. We add another parameter
because text direction for the calendar picker should depend on the UI
language but the text direction for suggestion picker should depend on
the input element style.

Test: platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html

* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype._layout):
* Resources/pagepopups/pickerCommon.css:
(.rtl): Added so we can change styles when in rtl mode.
* Resources/pagepopups/suggestionPicker.css:
(.suggestion-list-entry .label):
(.rtl .suggestion-list-entry .label): Change float direction to left.
* Resources/pagepopups/suggestionPicker.js:
(SuggestionPicker.prototype._layout):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup): Set isAnchorElementRTL to true if the input element is rtl.
* platform/DateTimeChooser.h:
(DateTimeChooserParameters): Added isAnchorElementRTL.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.txt: Added.
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFollow-up to r129723 to once more allow parsing of scoped names in IDL files.
mrowe@apple.com [Thu, 27 Sep 2012 08:13:15 +0000 (08:13 +0000)]
Follow-up to r129723 to once more allow parsing of scoped names in IDL files.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-09-27
Reviewed by Kentaro Hara.

This functionality was supported by the old IDL parser but was lost in the rewrite of the parser
in r129723. It is being reinstated to unbreak clients that currently depend on it, but will likely
be removed in the future once those clients have a chance to adopt an approach that more closely
follows the WebIDL syntax.

* bindings/scripts/IDLParser.pm:
(parseDefinition):
(parseInheritance):
(parseImplementsStatement):
(parseExtendedAttribute):
(parseExtendedAttribute2):
(parseExtendedAttributeRest2):
(parseExtendedAttributeRest3):
(parseScopedNameListNoComma):
(parseNonAnyType):
(parseExceptionList):
(parseDefinitionOld):
(parseScopedName):
(parseAbsoluteScopedName):
(parseRelativeScopedName):
(parseScopedNameParts):
(parseScopedNameList):
(parseScopedNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Fix build with static JavaScriptCore library
paroga@webkit.org [Thu, 27 Sep 2012 08:12:05 +0000 (08:12 +0000)]
[CMake] Fix build with static JavaScriptCore library

* shell/CMakeLists.txt: Define STATICALLY_LINKED_WITH_JavaScriptCore if
                        JavaScriptCore_LIBRARY_TYPE is set to STATIC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] fast/layers/video-layer.html needs rebaselining after r129687
commit-queue@webkit.org [Thu, 27 Sep 2012 08:11:50 +0000 (08:11 +0000)]
[EFL] fast/layers/video-layer.html needs rebaselining after r129687
https://bugs.webkit.org/show_bug.cgi?id=97764

Unreviewed EFL gardening.

Rebaseline fast/layers/video-layer.html due to r129687. The volume
button is no longer shown for that test.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-27

* platform/efl/fast/layers/video-layer-expected.png:
* platform/efl/fast/layers/video-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: expose debug memory instrumentation debug data through the protocol
yurys@chromium.org [Thu, 27 Sep 2012 07:57:49 +0000 (07:57 +0000)]
Web Inspector: expose debug memory instrumentation debug data through the protocol
https://bugs.webkit.org/show_bug.cgi?id=97683

Reviewed by Pavel Feldman.

Memory.getProcessMemoryDistribution command now returns number of instrumented
objects that were found and the number of the objects that were counted by
the instrumentation but were not actually allocated by the memory allocator.
These numbers are only added to the response if embedder provides access to the
set of all live heap objects. These numbers are intended to be used for testing
memory instrumentation.

* inspector/InspectorMemoryAgent.cpp:
(WebCore::collectDomTreeInfo):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkCountedObject):
* inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):
(WebCore::MemoryInstrumentationImpl::totalCountedObjects):
(WebCore::MemoryInstrumentationImpl::totalObjectsNotInAllocatedSet):
(MemoryInstrumentationImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions]Refactor RenderFlowThread::contentLogical(Width/Height/Left)OfFirstRegion
mihnea@adobe.com [Thu, 27 Sep 2012 07:53:07 +0000 (07:53 +0000)]
[CSSRegions]Refactor RenderFlowThread::contentLogical(Width/Height/Left)OfFirstRegion
https://bugs.webkit.org/show_bug.cgi?id=97577

Reviewed by Andreas Kling.

RenderFlowThread methods contentLogicalWidthOfFirstRegion, contentLogicalHeightOfFirstRegion, contentLogicalLeftOfFirstRegion
were using code to get the first valid region associated with the flow. We can use RenderFlowThread::firstRegion() method instead.

No new tests as this is just refactoring of existing code, the change is covered by existing regions tests.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WINCE] Enable JIT by default
paroga@webkit.org [Thu, 27 Sep 2012 07:30:06 +0000 (07:30 +0000)]
[WINCE] Enable JIT by default

* Source/cmake/OptionsWinCE.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for !USE(ICU_UNICODE) after r129662.
paroga@webkit.org [Thu, 27 Sep 2012 07:25:13 +0000 (07:25 +0000)]
Build fix for !USE(ICU_UNICODE) after r129662.

Convert LChar to UChar so we can call the existing function until the
other TextBreakIterator implemenations provide an overload for LChar.

* platform/text/TextBreakIterator.cpp:
(WebCore):
(WebCore::acquireLineBreakIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Allow denormal floats in ARM VFP
commit-queue@webkit.org [Thu, 27 Sep 2012 07:01:07 +0000 (07:01 +0000)]
[BlackBerry] Allow denormal floats in ARM VFP
https://bugs.webkit.org/show_bug.cgi?id=97008

Patch by Cosmin Truta <ctruta@rim.com> on 2012-09-26
Reviewed by Filip Pizlo.
Reviewed internally by Yong Li.

Cleared the Flush-to-Zero flag in the ARM FPSCR register on QNX.

* wtf/ThreadingPthreads.cpp:
(WTF::enableIEEE754Denormal): Added.
(WTF::initializeThreading):
(WTF::initializeCurrentThreadInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Move multiple fields related functions to BaseDateAndTimeInputType from TimeI...
yosin@chromium.org [Thu, 27 Sep 2012 06:43:17 +0000 (06:43 +0000)]
[Forms] Move multiple fields related functions to BaseDateAndTimeInputType from TimeInputType
https://bugs.webkit.org/show_bug.cgi?id=97521

Reviewed by Kent Tamura.

This patch introduces new class BaseMultipleFieldsDateAndTimeInputType
for sharing code among multiple fields date/time input UI.

Member functions in BaseMultipleFieldsDateAndTimeInputType are moved
from TimeInputType. BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
were copied from TimeInputType.{cpp,h} by r129721.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests. This patch doesn't change behavior.

* WebCore.gypi: Changed to have html/BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType): Exposed setMillisecondToDateComponents as protected for BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState().
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::DateTimeEditControlOwnerImpl): Moved from TimeInputType::DateTimeEditControlOwnerImpl.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::~DateTimeEditControlOwnerImpl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::didBlurFromControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::didFocusOnControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Moved from TimeInputType::DateTimeEditControlOwnerImpl and changed to call formatDateTimeFieldsState() in BaseMultipleFieldsDateAndTimeInputTypeInputType class.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::hasCustomFocusLogic): Moved from TimeInputType.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerDisabled): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerReadOnly): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::blur): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::forwardEvent): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::minOrMaxAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isTextField): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::saveFormControlState): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldUseInputMethod): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::stepAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Moved from TimeInputType and changed to call setupLayoutParameters() to set date/time format by each input type.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Added.
(DateTimeEditControlOwnerImpl): Moved from TimeInputType.
* html/TimeInputType.cpp: Moved multiple fields UI related functions to BaseMultipleFieldsDateAndTimeInputType.
(WebCore::TimeInputType::TimeInputType): Changed base class name to BaseTimeInput.
(WebCore::TimeInputType::formatDateTimeFieldsState): Moved from TimeINput::DateTImeEditControlOwnerImpl class.
(WebCore::TimeInputType::setupLayoutParameters): Added for set time format.
* html/TimeInputType.h:
(TimeInputType): Chaned base class to BaseTimeInput which is alias of BaseDateAndTimeInputType or BaseMultipleFieldsDateAndTimeInputType.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Adding localization texts for multiple fields date/time input UI
yosin@chromium.org [Thu, 27 Sep 2012 05:47:00 +0000 (05:47 +0000)]
[Forms] Adding localization texts for multiple fields date/time input UI
https://bugs.webkit.org/show_bug.cgi?id=97633

Reviewed by Kent Tamura.

Source/Platform:

This patch adds localized string enum fields for getting localized
strings used in multiple fields date/time input UI.

* chromium/public/WebLocalizedString.h: Added PlaceholderForDayOfMonthField,
PlaceholderForMonthField, PlaceholderForYearField, MonthFormatInLDML,
and WeekFormatInLDML.

Source/WebCore:

This patch adds function declarations for getting localized strings
used in multiple fields date/time input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

New functions are:
 - placeholderForDayOfMonthField()
    It returns localized placeholder text, e.g. "dd", for date field
    used in multiple fields "date", "datetime", and "datetime-local"
    input UI instead "--".

- placeholderForfMonthField()
    It returns localized placeholder text, e.g. "mm", for month field
    used in multiple fields "date", "datetime", and "datetime-local"
    input UI instead "--".

- placeholderForYearField()
    It returns localized placeholder text, e.g. "yyyy", for year field
    used in multiple fields "date", "datetime", and "datetime-local"
    input UI instead "----".

- monthFormatInLDML()
    It returns month and year format in LDML, Unicode technical
    standard 35, Locale Data Markup Language, e.g. "MM-yyyyy" for
    "month" input type.

- monthFormatInLDML()
    It returns week and year format in LDML, e.g. "WW-yyyyy" for
    "week" input type.

No new tests. This patch doesn't change behavior.

* platform/LocalizedStrings.h:
(WebCore): Added declarations of placeholderForDayOfMonthField(), placeholderForMonthField(),
placeholderForYearField(), monthFormatInLDML() and weekFormatInLDML().

Source/WebKit/chromium:

This patch adds functions for getting localized strings used in
multiple fields date/time input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

These functions will be used by DateInputType, DateTimeInputType,
DateTimeLocalInputType, MonthInputTypee, and WeekInputType.

* src/LocalizedStrings.cpp:
(WebCore::placeholderForDayOfMonthField): Added.
(WebCore::placeholderForMonthField): Added.
(WebCore::placeholderForYearField): Added.
(WebCore::monthFormatInLDML): Added.
(WebCore::weekFormatInLDML): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Remove an unused member variable m_program in FECustomFilter.h
commit-queue@webkit.org [Thu, 27 Sep 2012 05:45:49 +0000 (05:45 +0000)]
[CSS Shaders] Remove an unused member variable m_program in FECustomFilter.h
https://bugs.webkit.org/show_bug.cgi?id=97755

Patch by Huang Dongsung <luxtella@company100.net> on 2012-09-26
Reviewed by Kentaro Hara.

No new tests. This patch doesn't change behavior.

* platform/graphics/filters/FECustomFilter.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd tests for datalist UI for input type date
keishi@webkit.org [Thu, 27 Sep 2012 04:27:39 +0000 (04:27 +0000)]
Add tests for datalist UI for input type date
https://bugs.webkit.org/show_bug.cgi?id=97551

Reviewed by Kent Tamura.

Adding tests for datalist UI for input type date.

* platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
* platform/chromium/TestExpectations: Mark as image failure for date-suggestion-picker-appearance.html
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html: Added.
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html: Added.
* platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html: Added.
* platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations-expected.txt: Added.
* platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Update my e-mail address.
gyuyoung.kim@samsung.com [Thu, 27 Sep 2012 04:13:49 +0000 (04:13 +0000)]
Unreviewed. Update my e-mail address.

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-26

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after 129707.
kov@webkit.org [Thu, 27 Sep 2012 03:15:04 +0000 (03:15 +0000)]
Unreviewed build fix after 129707.

* webkit/webkitwebview.cpp:
(webkit_web_view_forward_context_menu_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove IDL extended attributes to the location specified in WebIDL
haraken@chromium.org [Thu, 27 Sep 2012 02:11:13 +0000 (02:11 +0000)]
Move IDL extended attributes to the location specified in WebIDL
https://bugs.webkit.org/show_bug.cgi?id=26398

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-09
Reviewed by Kentaro Hara.

Recreated a new IDLParser based on the WebIDL spec:
http://dev.w3.org/2006/webapi/WebIDL/

Firstly merges two grammars (editors draft and WebKit current IDL) and
generates IDL parser by using python script. The generated parser is
modified to generate the same outputs as the previous IDLParser.pm.
The new IDLParser.pm can parse both WebIDL grammar.

No new tests. Tested by comparing with sources generated by
the previous IDLParser.pm.

* bindings/scripts/IDLParser.pm:
(new):
(assertTokenValue):
(assertTokenType):
(assertUnexpectedToken):
(Parse):
A method to start parsing a IDL file. Arguments and return values are
the same as the previous IDLParser.pm's Parse method.
(nextToken):
Implemented to see a next token, because of LL(1).
(getToken):
Returns current token, and update next and current token.
(getTokenInternal):
According to the regular expressions defined in WebIDL spec, extracts
one new token from a text string. The order of the regular expressions
to be tested is important, i.e. "0." should be considered as a float
token, but if firstly checks the integer regular expression, "0." is
considered as "0" and ".".
(parseDefinition):
(parseCallbackOrInterface):
(parseCallbackRestOrInterface):
(parseInterface):
(parsePartial):
(parsePartialDefinition):
(parsePartialInterface):
(parseInterfaceMember):
(parseDictionary):
(parseDictionaryMember):
(parsePartialDictionary):
(parseDefaultValue):
(parseException):
(parseExceptionMembers):
(parseEnum):
(parseEnumValueList):
(parseCallbackRest):
(parseTypedef):
(parseImplementsStatement):
(parseConst):
(parseConstValue):
(parseBooleanLiteral):
(parseFloatLiteral):
(parseAttributeOrOperationOrIterator):
(parseSerializer):
(parseSerializationPattern):
(parseQualifier):
(parseAttributeOrOperationRest):
(parseAttribute):
(parseAttributeRest):
(parseOperationOrIterator):
(parseSpecialOperation):
(parseSpecial):
(parseOperationOrIteratorRest):
(parseIteratorRest):
(parseOptionalIteratorInterfaceOrObject):
(parseOperationRest):
(parseArguments):
(parseArgument):
(parseOptionalOrRequiredArgument):
(parseArgumentName):
(parseExceptionMember):
(parseExceptionField):
(parseExtendedAttributeList):
(parseExtendedAttribute):
(parseExtendedAttributeRest2):
(parseArgumentNameKeyword):
(parseType):
(parseSingleType):
(parseUnionType):
(parseNonAnyType):
(parsePrimitiveType):
(parseUnrestrictedFloatType):
(parseFloatType):
(parseUnsignedIntegerType):
(parseNull):
(parseGet):
(parseInheritsGetter):
(parseSetGetRaises):
(parseGetRaises2):
(parseSetRaises):
(parseSetRaises3):
(parseDefinitionOld):
(parseModule):
(parseInterfaceOld):
(parseInterfaceMemberOld):
(parseDictionaryOld):
(parseDictionaryMemberOld):
(parseExceptionOld):
(parseEnumOld):
(parseAttributeOrOperationOrIteratorOld):
(parseAttributeOrOperationRestOld):
(parseAttributeOld):
(parseIn):
(parseOptionalSemicolon):
(applyMemberList):
(applyExtendedAttributeList):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::longAttr):
(WebDOMTestObj::setLongAttr):
(WebDOMTestObj::voidMethodWithArgs):
(WebDOMTestObj::longMethod):
(WebDOMTestObj::longMethodWithArgs):
(WebDOMTestObj::objMethodWithArgs):
(WebDOMTestObj::convert1):
(WebDOMTestObj::convert2):
(WebDOMTestObj::convert3):
(WebDOMTestObj::convert4):
(WebDOMTestObj::convert5):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_long_method):
(webkit_dom_test_obj_long_method_with_args):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert3):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
(webkit_dom_test_obj_get_long_attr):
(webkit_dom_test_obj_set_long_attr):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjLongAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethod):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj longAttr]):
(-[DOMTestObj setLongAttr:]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj longMethod]):
(-[DOMTestObj longMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj convert1:]):
(-[DOMTestObj convert2:]):
(-[DOMTestObj convert3:]):
(-[DOMTestObj convert4:]):
(-[DOMTestObj convert5:]):
* bindings/scripts/test/TestObj.idl:
Removed the line which has only "JSC, V8".
Added argument to convert1, ... convert5.
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::longAttrAttrGetter):
(WebCore::TestObjV8Internal::longAttrAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
* Modules/webaudio/AudioBufferSourceNode.idl:
As only restricted extended attribute syntax is supported, modify the
idl from [...] [...] to [..., ...].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix XPCServices symlink to not be to an absolute path
weinig@apple.com [Thu, 27 Sep 2012 01:43:00 +0000 (01:43 +0000)]
Fix XPCServices symlink to not be to an absolute path
in the build products directory.

Reviewed by Dan Bernstein.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129722 268f45cc-cd09-0410-ab3c-d52691b4dbfc