WebKit-https.git
9 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:21:34 +0000 (08:21 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Update IMAGE results to show test progression (yay!).

        * platform/chromium-linux/fast/text/drawBidiText-expected.checksum:
        * platform/chromium-linux/fast/text/drawBidiText-expected.png:
        * platform/chromium-mac/fast/text/drawBidiText-expected.checksum: Added.
        * platform/chromium-mac/fast/text/drawBidiText-expected.png: Added.
        * platform/chromium-win-xp/fast/text/drawBidiText-expected.checksum: Added.
        * platform/chromium-win-xp/fast/text/drawBidiText-expected.png: Added.
        * platform/chromium-win/fast/text/drawBidiText-expected.checksum:
        * platform/chromium-win/fast/text/drawBidiText-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:14:19 +0000 (08:14 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add Windows baselines.

        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:10:01 +0000 (08:10 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add platform-specific baselines for listbox-bidi-align.

        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt: Added.
        * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 07:59:16 +0000 (07:59 +0000)]
2011-03-29  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=57256

        Fix crash on misaligned reads on Solaris 10/Sparc

        * wtf/text/AtomicString.cpp:
        (WTF::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 29 Mar 2011 07:37:30 +0000 (07:37 +0000)]
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WKPageGetSourceForFrame and WKPageGetContentsAsString should throw an error in case of a race with page loading
        https://bugs.webkit.org/show_bug.cgi?id=57305
        <rdar://problem/8738060>, <rdar://problem/8780168>

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Clear m_loadDependentStringCallbackIDs
        (WebKit::WebPageProxy::getSourceForFrame): track the callback as load dependent
        (WebKit::WebPageProxy::getContentsAsString): ditto
        (WebKit::WebPageProxy::clearLoadDependentCallbacks): Invalidate all load dependent callbacks
        (WebKit::WebPageProxy::didCommitLoadForFrame): Call clearLoadDependentCallbacks
        (WebKit::WebPageProxy::didFailLoadForFrame): ditto
        (WebKit::WebPageProxy::stringCallback): Remove callback from load dependent set if appropriate
        (WebKit::WebPageProxy::processDidCrash): Clear m_loadDependentStringCallbackIDs
        * UIProcess/WebPageProxy.h: Add m_loadDependentStringCallbackIDs hash set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-29 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 29 Mar 2011 07:30:52 +0000 (07:30 +0000)]
2011-03-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Remove unnecessary ewk_view_viewport_attributes_set() invocation
        https://bugs.webkit.org/show_bug.cgi?id=57222

        WebCore sends viewport signal whenever viewport is changed by Page::updateViewportArguments().
        Thus, we don't need to call ewk_view_viewport_attributes_set() with dummy viewport data
        anymore.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-29 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 07:20:19 +0000 (07:20 +0000)]
2011-03-29  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Adler.

        removeAllInDirectory() layout test helper method can call successCallback twice
        https://bugs.webkit.org/show_bug.cgi?id=57136

        Fixed to only call successCallback once, thereby avoiding
        flakiness in tests which use this function
        (see http://crbug.com/77442).

        * fast/filesystem/resources/fs-test-util.js:
        (removeAllInDirectory):
        * http/tests/filesystem/resources/fs-test-util.js:
        (removeAllInDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 07:14:10 +0000 (07:14 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add Chromium test expectation for http/tests/uri/username-with-no-hostname.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:59:19 +0000 (06:59 +0000)]
2011-03-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82198.
        http://trac.webkit.org/changeset/82198
        https://bugs.webkit.org/show_bug.cgi?id=57304

        Broke Chromium Win build. (Requested by dave_levin on
        #webkit).

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 06:45:16 +0000 (06:45 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, fix Chromium test results and expectations.

        * platform/chromium-mac-leopard/fast/block/positioning/047-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/047-expected.png: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Ofri Wolfus <ofri@google.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:42:30 +0000 (06:42 +0000)]
2011-03-28  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        * fast/forms/listbox-bidi-align.html: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.
        * platform/mac/fast/text/drawBidiText-expected.checksum: Updated.
        * platform/mac/fast/text/drawBidiText-expected.png: Updated.
2011-03-28  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        Test: fast/forms/listbox-bidi-align.html

        * rendering/RenderListBox.cpp:
        (WebCore::itemOffsetForAlignment):
        (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:32:36 +0000 (06:32 +0000)]
2011-03-28  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Benjamin Poulain.

        [Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
        https://bugs.webkit.org/show_bug.cgi?id=57142

        TextureMapperMediaLayer is a better name here because both video and plugins use this layer.
        Remove ENABLE(VIDEO) guard.

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
        (WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
        * platform/graphics/texmap/TextureMapperNode.h:
        * platform/graphics/texmap/TextureMapperPlatformLayer.h:
        (WebCore::TextureMapperMediaLayer::layerType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Thomas Klausner <tk@giga.or.at>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:20:08 +0000 (06:20 +0000)]
2011-03-28  Thomas Klausner  <tk@giga.or.at>

        Reviewed by David Levin.

        png-1.5 fixes
        https://bugs.webkit.org/show_bug.cgi?id=54406

        Fix compilation with png-1.5: struct members were hidden, and
        a new API to terminate data processing was added (especially for
        WebKit).

        Compilation fixes, so no new tests.

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:18:18 +0000 (06:18 +0000)]
2011-03-28  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Adam Barth.

        Replace fprintf(stderr, ...) with LOG_ERROR
        https://bugs.webkit.org/show_bug.cgi?id=57216

        LOG_ERROR is a better choice here.

        * bridge/jni/v8/JavaClassV8.cpp:
        (JavaClass::JavaClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Andrew Foster <andrewf@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:56:08 +0000 (05:56 +0000)]
2011-03-28  Andrew Foster  <andrewf@chromium.org>

        Reviewed by Ojan Vafai.

        webkit-patch should be more intelligent about whether a bug applies to a patch
        Create a new function, parse_bug_id_from_changelog() which determines
        that a bug is related to a patch by parsing the output generated from
        prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
        the description of a patch.
        https://bugs.webkit.org/show_bug.cgi?id=56989

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/net/bugzilla/__init__.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
        * Scripts/webkitpy/style/checkers/changelog.py:
        * Scripts/webkitpy/tool/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:53:57 +0000 (05:53 +0000)]
2011-03-28  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)
        https://bugs.webkit.org/show_bug.cgi?id=56602

        Added new methods to interface while keeping the old ones to keep
        chromium working until it is also patched.

        * public/WebDevToolsAgent.h:
        * public/WebURLLoaderClient.h:
        (WebKit::WebURLLoaderClient::didReceiveData):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::didReceiveData):
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 29 Mar 2011 05:41:07 +0000 (05:41 +0000)]
2011-03-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add a new JavaValue to type to represent a Java value in the Java bridge
        https://bugs.webkit.org/show_bug.cgi?id=57022

        This change introduces a new JavaValue type and uses it in place of jvalue
        in the conversions to and from JavaNPObject used in the V8 Java bridge.

        Refactoring only, no new tests.

        * WebCore.gypi:
        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::javaTypeFromClassName):
        (JSC::Bindings::signatureFromJavaType):
        (JSC::Bindings::getJNIField):
        (JSC::Bindings::callJNIMethod):
        * bridge/jni/JavaType.h:
        * bridge/jni/v8/JNIUtilityPrivate.cpp:
        (JSC::Bindings::convertNPVariantToJavaValue):
        (JSC::Bindings::convertJavaValueToNPVariant):
        (JSC::Bindings::jvalueToJavaValue):
        (JSC::Bindings::javaValueToJvalue):
        * bridge/jni/v8/JNIUtilityPrivate.h:
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        (JSC::Bindings::JavaNPObjectInvoke):
        (JSC::Bindings::JavaNPObjectGetProperty):
        * bridge/jni/v8/JavaValueV8.h: Added.
        (JSC::Bindings::JavaValue::JavaValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 05:29:03 +0000 (05:29 +0000)]
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Use String instead of CString as return value of openTemporaryFile
        https://bugs.webkit.org/show_bug.cgi?id=55332

        We usually store all paths as UTF-16. Do this for temporary files too.

        * WebCore.exp.in
        * platform/FileSystem.h:
        * platform/android/FileSystemAndroid.cpp:
        * platform/brew/FileSystemBrew.cpp:
        * platform/efl/FileSystemEfl.cpp:
        * platform/gtk/FileSystemGtk.cpp:
        * platform/haiku/FileSystemHaiku.cpp:
        * platform/mac/FileSystemMac.mm:
        * platform/qt/FileSystemQt.cpp:
        * platform/win/FileSystemWin.cpp:
        * platform/wince/FileSystemWinCE.cpp:
        * platform/wx/FileSystemWx.cpp:
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::destroyStream):
        * plugins/PluginStream.h:
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Use String instead of CString as return value of openTemporaryFile
        https://bugs.webkit.org/show_bug.cgi?id=55332

        * Shared/WebMemorySampler.cpp:
        (WebKit::WebMemorySampler::initializeTempLogFile):
        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
        (WebKit::NetscapePluginStream::stop):
        * WebProcess/Plugins/Netscape/NetscapePluginStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 05:28:10 +0000 (05:28 +0000)]
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Remove unused DOMCreateInstance files
        https://bugs.webkit.org/show_bug.cgi?id=57193

        * DOMCreateInstance.cpp: Removed.
        * DOMCreateInstance.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Jeff Johnson <opendarwin@lapcatsoftware.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:08:40 +0000 (05:08 +0000)]
2011-03-28  Jeff Johnson  <opendarwin@lapcatsoftware.com>

        Reviewed by Pavel Feldman.

        Web Inspector: empty, non-functional window
        https://bugs.webkit.org/show_bug.cgi?id=56354

        Check whether DOM local storage is enabled
        before attempting to access window.localStorage.

        No new tests.

        * inspector/front-end/Settings.js:
        (WebInspector.Settings.prototype.findSettingForAllProjects):
        (WebInspector.Settings.prototype._get):
        (WebInspector.Settings.prototype._set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 04:57:49 +0000 (04:57 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Clean up Chromium test expectations for plugins/embed-prefers-plugins-for-images.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix test results that were accidentally committed with a wrong
mjs@apple.com [Tue, 29 Mar 2011 04:47:44 +0000 (04:47 +0000)]
Fix test results that were accidentally committed with a wrong
result due to a temporary wrong code change.

* http/tests/uri/username-with-no-hostname-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoplugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
aestes@apple.com [Tue, 29 Mar 2011 04:36:28 +0000 (04:36 +0000)]
plugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/chromium/test_expectations.txt: Skip the test.
* platform/gtk/Skipped: Ditto.
* platform/qt/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake embed-prefers-plugins-for-images.html pass on all Apple platforms.
aestes@apple.com [Tue, 29 Mar 2011 03:47:53 +0000 (03:47 +0000)]
Make embed-prefers-plugins-for-images.html pass on all Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/mac-snowleopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/win/Skipped:
* plugins/embed-prefers-plugins-for-images-expected.txt:
* plugins/embed-prefers-plugins-for-images.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert accidentally commited change.
mjs@apple.com [Tue, 29 Mar 2011 03:04:51 +0000 (03:04 +0000)]
Revert accidentally commited change.

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
bdakin@apple.com [Tue, 29 Mar 2011 02:39:33 +0000 (02:39 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
Horizontal scroller stops appearing after going Forward
-and corresponding-
<rdar://problem/9026946>

Reviewed by Darin Adler.

This patch rolls out revision 79053 and fixes the same bug in a  better way.

New function resetScrollbarsAndClearContentsSize() calls resetScrollbars() and then
sets the contents size to 0. This is called when a document is going into the page
cache.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

Roll-out of 79053.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 29 Mar 2011 02:36:16 +0000 (02:36 +0000)]
2011-03-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix style sharing with :any and sibling selectors
        https://bugs.webkit.org/show_bug.cgi?id=57211

        Also tests sibling selector style sharing in general since
        no existing tests seem to cover that codepath.

        * fast/css/sibling-selectors-expected.txt: Added.
        * fast/css/sibling-selectors.html: Added.
2011-03-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix style sharing with :any and sibling selectors
        https://bugs.webkit.org/show_bug.cgi?id=57211

        Test: fast/css/sibling-selectors.html

        * css/CSSStyleSelector.cpp:
        (WebCore::collectFeaturesFromList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 29 Mar 2011 02:30:37 +0000 (02:30 +0000)]
2011-03-27  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix :-webkit-any(:last-child)
        https://bugs.webkit.org/show_bug.cgi?id=57207

        * fast/css/pseudo-any.html:
2011-03-27  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix :-webkit-any(:last-child)
        https://bugs.webkit.org/show_bug.cgi?id=57207

        We were passing the wrong arguments to checkSelector. Also, we were not
        passing through the encounteredLink bool.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck in failing results for embed-prefers-plugins-for-images-expected.txt in Mac...
aestes@apple.com [Tue, 29 Mar 2011 01:45:03 +0000 (01:45 +0000)]
Check in failing results for embed-prefers-plugins-for-images-expected.txt in Mac WK2 mode.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/mac-wk2/plugins: Added.
* platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 29 Mar 2011 01:26:47 +0000 (01:26 +0000)]
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
        https://bugs.webkit.org/show_bug.cgi?id=57291

        * platform/KURL.cpp:
        (WebCore::KURL::parse): Instead of considering URLs with
        credentials but no host invalid, consider them to have a host
        ending in @ (which fails down the line)/
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
        https://bugs.webkit.org/show_bug.cgi?id=57291

        * http/tests/uri/username-with-no-hostname.html: Adjusted test to be more tolerant
        of exactly how the image load fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 29 Mar 2011 01:10:49 +0000 (01:10 +0000)]
2011-03-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix some problems of the appearance of form validation message bubble.
        https://bugs.webkit.org/show_bug.cgi?id=57208

        No new tests. Validation message bubble appearance is not testable
        because it depends on a timer.

        * css/html.css:
        (::-webkit-validation-bubble):
        (::-webkit-validation-bubble-message):
        (::-webkit-validation-bubble-arrow):
        (::-webkit-validation-bubble-arrow-clipper):
          - Explicitly set margin, padding, and color.
          - Make the shadow darker.
          - Make the background color darker.
          - Make opacity larger.
          - Make the border color lighter.
          - Add inset shadows
          - Change the implementation of an arrow.
            Stop making a right triangle by the border trick.
            Use -webkit-transform instead.
          - Make min-width workable by changing display property of
            -webkit-validation-bubble to "inline-block".
        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::buildBubbleTree):
          Change the node structure. Before this change, -webkit-validation-bubble
          had three DIVs inside. After this change, it has two DIVs;
          -webkit-validation-bubble-arrow-clipper and
          -webkit-validation-bubble-message, and
          -webkit-validation-bubble-arrow-clipper contains
          -webkit-validation-bubble-arrow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Tue, 29 Mar 2011 01:06:40 +0000 (01:06 +0000)]
2011-03-28  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Adele Peterson.

        Updating small batch of gradient expected results files
        https://bugs.webkit.org/show_bug.cgi?id=57117

        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: http/tests/inspector/console-resource-errors.html failing on WebKit2.
jberlin@webkit.org [Tue, 29 Mar 2011 00:41:56 +0000 (00:41 +0000)]
REGRESSION: http/tests/inspector/console-resource-errors.html failing on WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=56539

Unreviewed, remove the platform-specific failing results to get the bots green.
The test appears to be working in WebKit after r82106 and r82017.

* platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Vincent Scheib <scheib@chromium.org>
scheib@chromium.org [Tue, 29 Mar 2011 00:33:29 +0000 (00:33 +0000)]
2011-03-28  Vincent Scheib  <scheib@chromium.org>

        Chromium test expectation for r82159

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: Can't enter pasted with context or Edit menu text in search or address...
enrica@apple.com [Tue, 29 Mar 2011 00:15:05 +0000 (00:15 +0000)]
REGRESSION: Can't enter pasted with context or Edit menu text in search or address field in the browser.
https://bugs.webkit.org/show_bug.cgi?id=57275
<rdar://problem/8246691>

Reviewed by Sam Weinig.

We need to classify cut and paste actions as user typing actions even when
the action is triggered by a context menu selection to
allow the propagation of the textDidChangeInTextField event.

* editing/EditorCommand.cpp:
The following methods have been modified to properly set up
the UserTypingGestureAction when the command source is the
menu or a key binding sequence.
(WebCore::executeCut):
(WebCore::executePaste):
(WebCore::executePasteAndMatchStyle):
(WebCore::executePasteAsPlainText):
(WebCore::executeDelete):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Changed to
call execute command instead of referring to the specific method in
the editor class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd another test that depends on EventSender to the mac-wk2 Skipped file.
jberlin@webkit.org [Mon, 28 Mar 2011 23:53:48 +0000 (23:53 +0000)]
Add another test that depends on EventSender to the mac-wk2 Skipped file.

* platform/mac-wk2/Skipped:
Add fast/events/onchange-text-form-field.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 28 Mar 2011 23:49:05 +0000 (23:49 +0000)]
2011-03-28  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] have DRT write the png checksum into a png comment
        https://bugs.webkit.org/show_bug.cgi?id=57255

        * DEPS: Pull in version of chromium with comment writing
2011-03-28  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] have DRT write the png checksum into a png comment
        https://bugs.webkit.org/show_bug.cgi?id=57255

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::dumpImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 28 Mar 2011 23:39:16 +0000 (23:39 +0000)]
2011-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        instanceof Array test fails when using iframes
        https://bugs.webkit.org/show_bug.cgi?id=17250

        Add test cases for correct behaviour

        * fast/js/js-constructors-use-correct-global-expected.txt: Added.
        * fast/js/js-constructors-use-correct-global.html: Added.
        * fast/js/resources/js-constructors-use-correct-global.js: Added.
2011-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        instanceof Array test fails when using iframes
        https://bugs.webkit.org/show_bug.cgi?id=17250

        This is a problem with all built in constructors, the use of
        lexicalGlobalObject rather than the constructors own
        global object reference means that a builtin will always use
        the prototype from the lexical global object rather than that
        of the constructors origin.

        * API/JSObjectRef.cpp:
        (JSObjectMakeFunction):
        (JSObjectMakeRegExp):
        * JavaScriptCore.exp:
        * runtime/ArrayConstructor.cpp:
        (JSC::constructArrayWithSizeQuirk):
        * runtime/BooleanConstructor.cpp:
        (JSC::constructBoolean):
        (JSC::constructBooleanFromImmediateBoolean):
        * runtime/BooleanConstructor.h:
        * runtime/DateConstructor.cpp:
        (JSC::constructDate):
        * runtime/DateInstance.cpp:
        * runtime/DateInstance.h:
        * runtime/ErrorConstructor.cpp:
        (JSC::constructWithErrorConstructor):
        (JSC::callErrorConstructor):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructWithFunctionConstructor):
        (JSC::callFunctionConstructor):
        (JSC::constructFunction):
        * runtime/FunctionConstructor.h:
        * runtime/JSCell.cpp:
        (JSC::JSCell::getOwnPropertySlot):
        (JSC::JSCell::put):
        (JSC::JSCell::deleteProperty):
        (JSC::JSCell::toThisObject):
        (JSC::JSCell::toObject):
        * runtime/JSCell.h:
        (JSC::JSCell::JSValue::toObject):
        * runtime/JSNotAnObject.cpp:
        (JSC::JSNotAnObject::toObject):
        * runtime/JSNotAnObject.h:
        * runtime/JSObject.cpp:
        (JSC::JSObject::toObject):
        * runtime/JSObject.h:
        * runtime/JSString.cpp:
        (JSC::StringObject::create):
        (JSC::JSString::toObject):
        (JSC::JSString::toThisObject):
        * runtime/JSString.h:
        * runtime/JSValue.cpp:
        (JSC::JSValue::toObjectSlowCase):
        (JSC::JSValue::toThisObjectSlowCase):
        (JSC::JSValue::synthesizeObject):
        * runtime/JSValue.h:
        * runtime/NumberConstructor.cpp:
        (JSC::constructWithNumberConstructor):
        * runtime/NumberObject.cpp:
        (JSC::constructNumber):
        * runtime/NumberObject.h:
        * runtime/ObjectConstructor.cpp:
        (JSC::constructObject):
        (JSC::constructWithObjectConstructor):
        (JSC::callObjectConstructor):
        * runtime/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        (JSC::constructWithRegExpConstructor):
        (JSC::callRegExpConstructor):
        * runtime/RegExpConstructor.h:
        * runtime/StringConstructor.cpp:
        (JSC::constructWithStringConstructor):
        * runtime/StringObject.h:
2011-03-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        instanceof Array test fails when using iframes
        https://bugs.webkit.org/show_bug.cgi?id=17250

        Up date for new toObject api

        * UserObjectImp.cpp:
        (UserObjectImp::toPrimitive):
        (UserObjectImp::toBoolean):
        (UserObjectImp::toNumber):
        (UserObjectImp::toString):
2011-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        instanceof Array test fails when using iframes
        https://bugs.webkit.org/show_bug.cgi?id=17250

        Update for new function and date apis

        Test: fast/js/js-constructors-use-correct-global.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::jsDateOrNull):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::initializeJSFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoving Qt stub, since it doesn't use the same header as the others.
adele@apple.com [Mon, 28 Mar 2011 23:24:14 +0000 (23:24 +0000)]
Removing Qt stub, since it doesn't use the same header as the others.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is
bdakin@apple.com [Mon, 28 Mar 2011 23:15:20 +0000 (23:15 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is
changed via delegate method, the page needs a full relayout and repaint
-and corresponding-
<rdar://problem/9059129>

Reviewed by Darin Adler.

Call into WebKitSystemInterface to associate the new painter with the existing
painter controller. Reset the scrollbar frame rects to the new thickness -- normally
this only happens when a scrollbar is created, so we have to reset the thickness
here to pick up the new theme thickness. Finally, force a full relayout and style
recall with setNeedsRecalcStyleInAllFrames()
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):

setNeedsRecalcStyleInAllFrames() used to be a static method in Settings.cpp. This
patch moves it to be a member function on Page so that it can be called from
FrameView when the scrollbar style changes.
* page/FrameView.cpp:
(WebCore::FrameView::setNeedsRecalcStyleInAllFrames):
* page/FrameView.h:
* page/Page.cpp:
(WebCore::Page::setNeedsRecalcStyleInAllFrames):
* page/Page.h:
* page/Settings.cpp:
(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::setMinimumFontSize):
(WebCore::Settings::setMinimumLogicalFontSize):
(WebCore::Settings::setDefaultFontSize):
(WebCore::Settings::setDefaultFixedFontSize):
(WebCore::Settings::setTextAreasAreResizable):
(WebCore::Settings::setAuthorAndUserStylesEnabled):
(WebCore::Settings::setFontRenderingMode):
(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setShowDebugBorders):
(WebCore::Settings::setShowRepaintCounter):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setNeedsRecalcStyleInAllFrames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 28 Mar 2011 23:11:45 +0000 (23:11 +0000)]
2011-03-28  Dirk Pranke  <dpranke@chromium.org>

        RS=Tony Chang.

        r81977 moved FontPlatformData.h from
        WebCore/platform/graphics/cocoa to platform/graphics. This
        change updates the chromium build accordingly.

        https://bugs.webkit.org/show_bug.cgi?id=57281

        * platform/graphics/chromium/CrossProcessFontLoading.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Vincent Scheib <scheib@chromium.org>
scheib@chromium.org [Mon, 28 Mar 2011 22:56:56 +0000 (22:56 +0000)]
2011-03-28  Vincent Scheib  <scheib@chromium.org>

        Chromium rebaseline for r82144.

        * platform/chromium-linux/fast/block/positioning/058-expected.checksum:
        * platform/chromium-linux/fast/block/positioning/058-expected.png:
        * platform/chromium-win/fast/block/positioning/052-expected.txt:
        * platform/chromium-win/fast/block/positioning/058-expected.checksum:
        * platform/chromium-win/fast/block/positioning/058-expected.png:
        * platform/chromium-win/fast/block/positioning/058-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded a few more stubs.
adele@apple.com [Mon, 28 Mar 2011 22:43:24 +0000 (22:43 +0000)]
Added a few more stubs.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::hasGrammarMarker):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::hasGrammarMarker):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::hasGrammarMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
jer.noble@apple.com [Mon, 28 Mar 2011 22:31:14 +0000 (22:31 +0000)]
MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=57249

Reviewed by Darin Adler.

Source/WebCore:

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

LayoutTests:

* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
adele@apple.com [Mon, 28 Mar 2011 22:22:33 +0000 (22:22 +0000)]
Build fix.

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):

Tools:

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::hasGrammarMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 28 Mar 2011 22:07:50 +0000 (22:07 +0000)]
2011-03-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        http streams don't always display video with AVFoundation backend
        https://bugs.webkit.org/show_bug.cgi?id=57203

        No new tests, we don't currently have tests for http live streams. Changes verified manually.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::MediaPlayer): Initialize m_shouldPrepareToRender.
        (WebCore::MediaPlayer::loadWithNextMediaEngine): Call prepareForRendering on new engine
            if m_shouldPrepareToRender is set.
        (WebCore::MediaPlayer::prepareForRendering): Set m_shouldPrepareToRender.
        * platform/graphics/MediaPlayer.h:

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup): Don't return true until
            m_isAllowedToRender has been set.
        (WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering): Always call setUpVideoRendering,
            it has logic to figure out when setup is required.
        (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Call setUpVideoRendering when we aren't
            using the preferred rendering mode because if we get a file's metadata between the
            time supportsAcceleratedRendering() and paint() are called, we will allocate a software
            renderer even when we prefer a layer backed renderer.
        (WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Return "unknown" until we have metadata.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use itemKVOProperties() instead of
            an explicit list of key path names.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): metadataKeyNames renamed
            to assetMetadataKeyNames, return an NSArray instead of a CFArrayRef since that is what the
            callers need.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Return the duration of the
            player item, not the asset, because AVAsset.duration always returns an indefinite time
            for all streaming files.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): metadataKeyNames renamed
            to assetMetadataKeyNames.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Do nothing until
            metadata is available.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Split size calculation logic off
            into sizeChanged().
        (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): New. Use AVPlayerItem.presentationSize
            until tracks is non-NULL so we have a size as early as possible.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::assetMetadataKeyNames): Renamed from metadataKeyNames.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::itemKVOProperties): New, return an array of
            KVO observable properties.
        (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Respond to
            presentationSize change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago../WebKit/chromium: Build fix.
adele@apple.com [Mon, 28 Mar 2011 22:04:18 +0000 (22:04 +0000)]
../WebKit/chromium: Build fix.

* src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.

../WebKit/win: Build fix.

* WebFrame.cpp: (WebFrame::hasSpellingMarker):
Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Mar 2011 22:01:58 +0000 (22:01 +0000)]
2011-03-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Search field focus ring is missing
        https://bugs.webkit.org/show_bug.cgi?id=57270
        <rdar://problem/8765555>

        Add an _automaticFocusRingDisabled method which returns YES.

        * platform/mac/ThemeMac.mm:
        (-[WebCoreFlippedView _automaticFocusRingDisabled]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 28 Mar 2011 22:00:48 +0000 (22:00 +0000)]
2011-03-28  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION [r78794-r79249] Allocation of memory is slow when number of active objects is large
        https://bugs.webkit.org/show_bug.cgi?id=56823

        Partial fix for most of the problem. (TOT still shows a regression, though.)

        * runtime/Heap.cpp:
        (JSC::Heap::reportExtraMemoryCostSlowCase): Use highWaterMark(), instead of
        capacity(), since capacity() is O(n) relative to the size of the heap.

        In limited circumstances, capacity() is also worse than highWaterMark()
        for measuring extra cost relative to heap size, since capacity() only
        measures the *current* capacity of the heap, but the heap will grow if
        necessary to attain highWaterMark().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck in failing results for embed-prefers-plugins-for-images.html on Leopard.
aestes@apple.com [Mon, 28 Mar 2011 21:53:55 +0000 (21:53 +0000)]
Check in failing results for embed-prefers-plugins-for-images.html on Leopard.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 28 Mar 2011 21:49:53 +0000 (21:49 +0000)]
2011-03-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Move more events to EventDispatcher.
        https://bugs.webkit.org/show_bug.cgi?id=57247

        No functional changes, covered by existing tests.

        * dom/EventDispatcher.cpp:
        (WebCore::eventTargetRespectingSVGTargetRules): Made a static function,
            since it's not used anywhere outside of the EventDispatcher.
        (WebCore::EventDispatcher::dispatchScopedEvent): Moved from Node.cpp.
        (WebCore::EventDispatcher::dispatchKeyEvent): Ditto.
        (WebCore::EventDispatcher::dispatchWheelEvent): Ditto.
        (WebCore::EventDispatcher::dispatchEvent): Changed to use eventTargetRespectingSVGTargetRules
            as a static function.
        * dom/EventDispatcher.h: Updated decls.
        * dom/Node.cpp:
        (WebCore::Node::dispatchScopedEvent): Replaced with calling EventDispatcher.
        (WebCore::Node::dispatchKeyEvent): Ditto.
        (WebCore::Node::dispatchWheelEvent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar...
adele@apple.com [Mon, 28 Mar 2011 21:48:28 +0000 (21:48 +0000)]
Source/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

Test: editing/spelling/grammar.html

* WebCore.exp.in: Add symbol for new selectionStartHasMarkerFor method.
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Every use of paragraph is specific to spelling or grammar,
 so to avoid confusion, we should explicitly use spellingParagraph or grammarParagraph.  In the case of this bug,
 when we're consider ambiguous boundary characters (characters that could indicate word boundaries, but are used
 in the middle of words too, like apostrophes), we should use the use the spellingParagraph since the spellingParagraph
 is the only one operated on when this information is used.
 (WebCore::Editor::selectionStartHasMarkerFor): Changed from selectionStartHasSpellingMarkerFor so it can check for grammar as well as spelling.
* editing/Editor.h:

Source/WebKit/mac: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

* WebView/WebFrame.mm:
(-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
(-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
* WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.

Tools: Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

* DumpRenderTree/LayoutTestController.cpp:
(hasGrammarMarkerCallback): Added.
(LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
* DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.

LayoutTests: Test for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

* editing/spelling/grammar-expected.txt: Added.
* editing/spelling/grammar.html: Added.
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements
mitz@apple.com [Mon, 28 Mar 2011 21:32:42 +0000 (21:32 +0000)]
<rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements
https://bugs.webkit.org/show_bug.cgi?id=48983

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/paginated-layer-crash.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintPaginatedChildLayer): Bring the logic for finding pagintating layers
into sync with updatePagination() after r68069.
(WebCore::RenderLayer::hitTestPaginatedChildLayer): Ditto.

LayoutTests:

* fast/multicol/paginated-layer-crash-expected.txt: Added.
* fast/multicol/paginated-layer-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Downloads started with DownloadCFNet::start never start
bweinstein@apple.com [Mon, 28 Mar 2011 21:32:25 +0000 (21:32 +0000)]
WebKit2: Downloads started with DownloadCFNet::start never start
https://bugs.webkit.org/show_bug.cgi?id=57268

Reviewed by Jon Honeycutt.

* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::start): Call CFURLDownloadStart on the download we create.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Vincent Scheib <scheib@chromium.org>
scheib@chromium.org [Mon, 28 Mar 2011 21:28:52 +0000 (21:28 +0000)]
2011-03-28  Vincent Scheib  <scheib@chromium.org>

        Chromium rebaseline for r82123.

        * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
        * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
        * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
        * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
ossy@webkit.org [Mon, 28 Mar 2011 21:23:09 +0000 (21:23 +0000)]
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Benjamin Poulain.

Trivial typo fix after r82082.

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Mon, 28 Mar 2011 21:00:06 +0000 (21:00 +0000)]
Fix Windows build.

* Shared/ShareableBitmap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Mar 2011 20:58:09 +0000 (20:58 +0000)]
2011-03-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Beep when pressing a menu key equivalent when a plug-in has focus
        https://bugs.webkit.org/show_bug.cgi?id=57264
        <rdar://problem/8935597>

        We don't want the WKTextInputWindowController inputContext to be involved in interpretKeyEvents.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView inputContext]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 28 Mar 2011 20:53:20 +0000 (20:53 +0000)]
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler' .

        URLSs with non-empty username but empty hostname treat first path segment as hostname, potentially enabling XSS
        https://bugs.webkit.org/show_bug.cgi?id=57220

        Test: http/tests/uri/username-with-no-hostname.html

        * platform/KURL.cpp:
        (WebCore::hostPortIsEmptyButUserPassIsNot):
        (WebCore::KURL::parse):
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler' .

        URLSs with non-empty username but empty hostname are allowed to load
        https://bugs.webkit.org/show_bug.cgi?id=57220

        * http/tests/uri/username-with-no-hostname-expected.txt: Added.
        * http/tests/uri/username-with-no-hostname.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Mar 2011 20:45:58 +0000 (20:45 +0000)]
2011-03-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        CGImageRefs must hold a strong reference to underlying data
        https://bugs.webkit.org/show_bug.cgi?id=57263
        <rdar://problem/9146179>

        Make paintBitmapContext use CGBitmapContextCreateImage, which creates a copy-on-write copy
        of the bitmap data. Also, add ShareableBitmap::makeCGImageCopy which does the same thing, and
        ShareableBitmap::makeCGImage in the cases where we know that the ShareableBitmap data will never change.

        * Platform/cg/CGUtilities.cpp:
        (WebKit::paintImage):
        Factor image painting code out into a separate function.

        (WebKit::paintBitmapContext):
        Call paintImage.

        * Shared/API/c/cg/WKImageCG.cpp:
        (WKImagemakeCGImage):
        Use ShareableBitmap::makeCGImageCopy.

        * Shared/ShareableBitmap.h:
        * Shared/cg/ShareableBitmapCG.cpp:
        (WebKit::ShareableBitmap::createGraphicsContext):
        (WebKit::ShareableBitmap::paint):
        (WebKit::ShareableBitmap::makeCGImageCopy):
        (WebKit::ShareableBitmap::makeCGImage):
        (WebKit::ShareableBitmap::releaseBitmapContextData):
        (WebKit::ShareableBitmap::releaseDataProviderData):
        Add makeCGImage and makeCGImageCopy.

        * Shared/cg/WebCoreArgumentCodersCG.cpp:
        (CoreIPC::createImage):
        Use ShareableBitmap::makeCGImage.

        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::setDragImage):
        Use ShareableBitmap::makeCGImage and plug a CGImageRef leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Build fix.
ap@apple.com [Mon, 28 Mar 2011 20:34:24 +0000 (20:34 +0000)]
    Build fix.

        * UIProcess/API/mac/WKView.mm: (-[WKView keyDown:]): It's not "event" in this function, it's
        "theEvent".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate progressing layout tests on SL.
hyatt@apple.com [Mon, 28 Mar 2011 20:32:23 +0000 (20:32 +0000)]
Update progressing layout tests on SL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 28 Mar 2011 20:19:11 +0000 (20:19 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=57260
        Clean up text input code a little

WebKit/mac:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::handleKeyboardEvent):
        (WebEditorClient::handleInputMethodKeydown):
        * WebView/WebHTMLViewInternal.h:
        Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
        anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
        and also possibly saves resulting commands for later execution.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
        return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
        WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
        handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
        because the first call resulted in no saved commands, becasue it's confusing and apparently
        useless (I couldn't find any broken behavior).
        (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
        (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
        (-[WebHTMLView doCommandBySelector:]): Ditto.
        (-[WebHTMLView insertText:]): Ditto.

        * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
        method on WebView.

WebKit2:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView doCommandBySelector:]): This NSTextInput protocol method lacked a LOG() call.
        (-[WKView keyDown:]): Added (possibly useless) event protection to match performKeyEquivalent:
        and also WebKit1.

        * WebProcess/WebPage/mac/WebPageMac.mm: Removed an obsolete comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Mar 2011 20:16:06 +0000 (20:16 +0000)]
2011-03-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        script-src should block inline event handlers
        https://bugs.webkit.org/show_bug.cgi?id=57212

        I considered wrapping this into the canExecute check, but that approach
        would require passing that function a bunch of context information to
        behave correctly once we add support for the "options" directive that
        re-enables these features.

        Test: http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html

        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::initializeJSFunction):
            - This function was a mess.  I couldn't resist cleaning it up a
              bunch.  Notice that we ASSERT at the beginning of the function
              that scriptExecutionContext is a document and that both ways of
              getting the global object are the same when document->frame() is
              non-zero because the document must be active and there is a
              one-to-one relation between Frames and active Documents.
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::prepareListenerObject):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
        * page/ContentSecurityPolicy.h:
2011-03-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        script-src should block inline event handlers
        https://bugs.webkit.org/show_bug.cgi?id=57212

        * http/tests/security/contentSecurityPolicy/resources/event-handler.pl: Added.
        * http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Mon, 28 Mar 2011 20:09:21 +0000 (20:09 +0000)]
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        ResourceError::certificate() should return a PCCERT_CONTEXT
        https://bugs.webkit.org/show_bug.cgi?id=57262

        * platform/network/cf/ResourceError.h: certificate() now returns a PCCERT_CONTEXT.
        * platform/network/cf/ResourceErrorCF.cpp:
        (WebCore::ResourceError::certificate): Added.
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        ResourceError::certificate() should return a PCCERT_CONTEXT
        https://bugs.webkit.org/show_bug.cgi?id=57262

        * Shared/win/PlatformCertificateInfo.cpp:
        (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Don't assert if no PCCERT_CONTEXT is specified.
        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::encodeResourceError): Removed unneeded code now that ResourceError::certificate() returns a PCCERT_CONTEXT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Mon, 28 Mar 2011 20:03:53 +0000 (20:03 +0000)]
2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        Add myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57221, memory corruption/crashes when positio...
hyatt@apple.com [Mon, 28 Mar 2011 19:44:19 +0000 (19:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57221, memory corruption/crashes when positioned objects
occur at the end of a line.

Reviewed by Simon Fraser and Darin Adler.

The old code and new code for dealing with a trailing space object midpoint manipulated a raw
array instead of the Vector. Otherwise this corruption would have been caught prior to check-in.

I have patched the code to only go through the Vector and to make it handle the case that led to
the corruption. Trailing positioned objects can occur both prior to and following the trailing space
object's midpoint, so we have to be prepared to deal with both cases.

This is already tested by fast/block/positioning/052.html, and that test now properly progresses
like the other positioning tests did.

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

* platform/mac/fast/block/positioning/052-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Mar 2011 19:41:36 +0000 (19:41 +0000)]
2011-03-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Mar 2011 19:32:19 +0000 (19:32 +0000)]
2011-03-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
        https://bugs.webkit.org/show_bug.cgi?id=52629

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
        QWebPage::repaintRequested() use a Qt::QueuedConnection.

        * tests/qwebpage/tst_qwebpage.cpp:
        (RepaintRequestedRenderer::RepaintRequestedRenderer):
        (RepaintRequestedRenderer::onRepaintRequested):
        (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
        QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
        doesn't cause recursive signal emissions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 28 Mar 2011 19:10:52 +0000 (19:10 +0000)]
2011-03-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
        to link against WebKit.framework for now.

        * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused CFErrorRef.
jeffm@apple.com [Mon, 28 Mar 2011 18:28:01 +0000 (18:28 +0000)]
Remove unused CFErrorRef.

Rubber-stamped by Adam Roben.

* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceError): Remove unused CFErrorRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r82130): It made all tests crash (Requested by Ossy on #webkit).
oliver@apple.com [Mon, 28 Mar 2011 18:25:52 +0000 (18:25 +0000)]
REGRESSION(r82130): It made all tests crash (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=57251

Build fix, had remnant of another patch in r82130

* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdChainList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Andrei Popescu <andreip@google.com>
andreip@google.com [Mon, 28 Mar 2011 18:17:08 +0000 (18:17 +0000)]
2011-03-28  Andrei Popescu  <andreip@google.com>

        Reviewed by Steve Block.

        V8IDBKeyCustom.cpp does not compile with INDEXED_DATABASE disabled
        https://bugs.webkit.org/show_bug.cgi?id=57100

        Close the ENABLE guard and the namespace in the right order.

        No new tests, just cleanup.

        * bindings/v8/custom/V8IDBAnyCustom.cpp:
        * bindings/v8/custom/V8IDBKeyCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Mon, 28 Mar 2011 18:16:18 +0000 (18:16 +0000)]
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Include certificate when sending a WebCore::ResourceError to UI process on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57195

        Rename wkGetSSLPeerCertificateData() to wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*, and
        implement wkGetSSLPeerCertificateData() to return a CFDataRef.  Add wkSetSSLPeerCertificateData() so
        WebCore::ResourceError can set the certificate in the user info dictionary.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Include certificate when sending a WebCore::ResourceError to UI process on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57195

        Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.

        * WebError.cpp:
        (WebError::sslPeerCertificate):
        * WebURLResponse.cpp:
        (WebURLResponse::sslPeerCertificate):
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Include certificate when sending a WebCore::ResourceError to UI process on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57195

        Add support for tracking the certificate in WebCore::ResourceError.

        * platform/network/ResourceErrorBase.cpp:
        (WebCore::ResourceErrorBase::copy): Call platformCopy() to copy platform-specific fields.
        * platform/network/ResourceErrorBase.h:
        (WebCore::ResourceErrorBase::platformCopy): Added.
        * platform/network/cf/ResourceError.h: Added constructor that takes certificate data, shadowed platformCopy, added m_certificate.
        (WebCore::ResourceError::certificate): Added.
        * platform/network/cf/ResourceErrorCF.cpp:
        (WebCore::ResourceError::ResourceError): Added constructor that takes certificate data.
        (WebCore::ResourceError::platformLazyInit): Read any certificate from the userInfo dictionary.
        (WebCore::ResourceError::platformCopy): Copy m_certificate.
        (WebCore::ResourceError::cfError): Add any certificate data to the userInfo dictionary in the CFErrorRef.
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Include certificate when sending a WebCore::ResourceError to UI process on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57195

        Add support for sending the certificate with the WebCore::ResourceError.

        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::encodeResourceError): Encode certificate data.
        (CoreIPC::deallocCertContext): Added.
        (CoreIPC::createCertContextDeallocator): Added.
        (CoreIPC::copyCert): Added.
        (CoreIPC::decodeResourceError): Decode certificate data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd an extra newline to the end of the generated Inspector.idl file so that it does not
jberlin@webkit.org [Mon, 28 Mar 2011 17:57:30 +0000 (17:57 +0000)]
Add an extra newline to the end of the generated Inspector.idl file so that it does not
trigger the Windows "no newline at at end of file" warning.

Rubber-stamped by Adam Roben.

* inspector/generate-inspector-idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 17:49:41 +0000 (17:49 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, added new GTK+ test expectations.

        * platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added.
        * platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.png: Added.
        * platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added.
        * platform/gtk/fast/block/positioning/trailing-space-test-expected.checksum: Added.
        * platform/gtk/fast/block/positioning/trailing-space-test-expected.png: Added.
        * platform/gtk/fast/block/positioning/trailing-space-test-expected.txt: Added.
        * platform/gtk/fast/blockflow/fallback-orientation-expected.checksum: Added.
        * platform/gtk/fast/blockflow/fallback-orientation-expected.png: Added.
        * platform/gtk/fast/blockflow/fallback-orientation-expected.txt: Added.
        * platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.checksum: Added.
        * platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
        * platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
        * platform/gtk/svg/text/text-path-middle-align-expected.checksum: Added.
        * platform/gtk/svg/text/text-path-middle-align-expected.png: Added.
        * platform/gtk/svg/text/text-path-middle-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildfix after r82125.
ossy@webkit.org [Mon, 28 Mar 2011 17:46:10 +0000 (17:46 +0000)]
Buildfix after r82125.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

* platform/graphics/qt/MediaPlayerPrivateQt.cpp: Convert all char* to QString explicitly.
(WebCore::MediaPlayerPrivateQt::getSupportedTypes):
(WebCore::MediaPlayerPrivateQt::commitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Mar 2011 17:29:44 +0000 (17:29 +0000)]
2011-03-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fixed chromium build.

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgent::shouldInterruptForMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Mon, 28 Mar 2011 17:19:52 +0000 (17:19 +0000)]
2011-03-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82099.
        http://trac.webkit.org/changeset/82099
        https://bugs.webkit.org/show_bug.cgi?id=57245

        Breaks live edits tests on chromium. (Requested by pfeldman on
        #webkit).

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrameDelegate.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Mar 2011 17:16:52 +0000 (17:16 +0000)]
2011-03-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up and rename debugger domain functions.
        https://bugs.webkit.org/show_bug.cgi?id=57240

        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
        (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        (WebCore::InspectorDebuggerAgent::failedToParseSource):
        (WebCore::InspectorDebuggerAgent::didPause):
        (WebCore::InspectorDebuggerAgent::didContinue):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
        (WebInspector.DebuggerModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.paused):
        (WebInspector.DebuggerDispatcher.prototype.resumed):
        (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
        (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
        (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
        * inspector/front-end/inspector.js:
        (WebInspector.didCreateWorker):
        (WebInspector.didDestroyWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-27 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 28 Mar 2011 17:14:57 +0000 (17:14 +0000)]
2011-03-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Add additional immediate types to allow us to distinguish the source of a JIT immediate
        https://bugs.webkit.org/show_bug.cgi?id=57190

        Allow us to distinguish whether a JIT immediate is a value that we
        control (TrustedImm32 and TrustedImmPtr) vs. ones that can be controlled
        or influenced by code we are compiling.  Currently we do nothing with this
        information -- this change is large and mechanical but would obscure any
        logic changes that we would have made.

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
        (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
        (JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
        (JSC::AbstractMacroAssembler::Imm32::Imm32):
        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::pop):
        (JSC::MacroAssembler::poke):
        (JSC::MacroAssembler::branchPtr):
        (JSC::MacroAssembler::branch32):
        (JSC::MacroAssembler::addPtr):
        (JSC::MacroAssembler::andPtr):
        (JSC::MacroAssembler::orPtr):
        (JSC::MacroAssembler::subPtr):
        (JSC::MacroAssembler::xorPtr):
        (JSC::MacroAssembler::setPtr):
        (JSC::MacroAssembler::storePtr):
        (JSC::MacroAssembler::branchTestPtr):
        (JSC::MacroAssembler::branchSubPtr):
        (JSC::MacroAssembler::branchTest8):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::add32):
        (JSC::MacroAssemblerARM::and32):
        (JSC::MacroAssemblerARM::lshift32):
        (JSC::MacroAssemblerARM::mul32):
        (JSC::MacroAssemblerARM::or32):
        (JSC::MacroAssemblerARM::rshift32):
        (JSC::MacroAssemblerARM::urshift32):
        (JSC::MacroAssemblerARM::sub32):
        (JSC::MacroAssemblerARM::xor32):
        (JSC::MacroAssemblerARM::store32):
        (JSC::MacroAssemblerARM::push):
        (JSC::MacroAssemblerARM::move):
        (JSC::MacroAssemblerARM::branch8):
        (JSC::MacroAssemblerARM::branch32):
        (JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerARM::branch16):
        (JSC::MacroAssemblerARM::branchTest8):
        (JSC::MacroAssemblerARM::branchTest32):
        (JSC::MacroAssemblerARM::branchAdd32):
        (JSC::MacroAssemblerARM::branchMul32):
        (JSC::MacroAssemblerARM::branchSub32):
        (JSC::MacroAssemblerARM::set32Compare32):
        (JSC::MacroAssemblerARM::set8Compare32):
        (JSC::MacroAssemblerARM::set32Test32):
        (JSC::MacroAssemblerARM::set32Test8):
        (JSC::MacroAssemblerARM::moveWithPatch):
        (JSC::MacroAssemblerARM::branchPtrWithPatch):
        (JSC::MacroAssemblerARM::storePtrWithPatch):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::add32):
        (JSC::MacroAssemblerARMv7::and32):
        (JSC::MacroAssemblerARMv7::lshift32):
        (JSC::MacroAssemblerARMv7::mul32):
        (JSC::MacroAssemblerARMv7::or32):
        (JSC::MacroAssemblerARMv7::rshift32):
        (JSC::MacroAssemblerARMv7::urshift32):
        (JSC::MacroAssemblerARMv7::sub32):
        (JSC::MacroAssemblerARMv7::xor32):
        (JSC::MacroAssemblerARMv7::load32):
        (JSC::MacroAssemblerARMv7::load32WithAddressOffsetPatch):
        (JSC::MacroAssemblerARMv7::load16):
        (JSC::MacroAssemblerARMv7::store32WithAddressOffsetPatch):
        (JSC::MacroAssemblerARMv7::store32):
        (JSC::MacroAssemblerARMv7::loadDouble):
        (JSC::MacroAssemblerARMv7::storeDouble):
        (JSC::MacroAssemblerARMv7::push):
        (JSC::MacroAssemblerARMv7::move):
        (JSC::MacroAssemblerARMv7::compare32):
        (JSC::MacroAssemblerARMv7::test32):
        (JSC::MacroAssemblerARMv7::branch32):
        (JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerARMv7::branch16):
        (JSC::MacroAssemblerARMv7::branch8):
        (JSC::MacroAssemblerARMv7::branchTest32):
        (JSC::MacroAssemblerARMv7::branchTest8):
        (JSC::MacroAssemblerARMv7::branchAdd32):
        (JSC::MacroAssemblerARMv7::branchMul32):
        (JSC::MacroAssemblerARMv7::branchSub32):
        (JSC::MacroAssemblerARMv7::nearCall):
        (JSC::MacroAssemblerARMv7::call):
        (JSC::MacroAssemblerARMv7::set32Compare32):
        (JSC::MacroAssemblerARMv7::set8Compare32):
        (JSC::MacroAssemblerARMv7::set32Test32):
        (JSC::MacroAssemblerARMv7::set32Test8):
        (JSC::MacroAssemblerARMv7::moveWithPatch):
        (JSC::MacroAssemblerARMv7::branchPtrWithPatch):
        (JSC::MacroAssemblerARMv7::storePtrWithPatch):
        (JSC::MacroAssemblerARMv7::tailRecursiveCall):
        (JSC::MacroAssemblerARMv7::makeJump):
        (JSC::MacroAssemblerARMv7::makeBranch):
        (JSC::MacroAssemblerARMv7::setupArmAddress):
        (JSC::MacroAssemblerARMv7::makeBaseIndexBase):
        (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::add32):
        (JSC::MacroAssemblerMIPS::and32):
        (JSC::MacroAssemblerMIPS::lshift32):
        (JSC::MacroAssemblerMIPS::mul32):
        (JSC::MacroAssemblerMIPS::or32):
        (JSC::MacroAssemblerMIPS::rshift32):
        (JSC::MacroAssemblerMIPS::urshift32):
        (JSC::MacroAssemblerMIPS::sub32):
        (JSC::MacroAssemblerMIPS::xor32):
        (JSC::MacroAssemblerMIPS::load32):
        (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch):
        (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch):
        (JSC::MacroAssemblerMIPS::store32):
        (JSC::MacroAssemblerMIPS::push):
        (JSC::MacroAssemblerMIPS::move):
        (JSC::MacroAssemblerMIPS::branch8):
        (JSC::MacroAssemblerMIPS::branch32):
        (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerMIPS::branch16):
        (JSC::MacroAssemblerMIPS::branchTest32):
        (JSC::MacroAssemblerMIPS::branchTest8):
        (JSC::MacroAssemblerMIPS::branchAdd32):
        (JSC::MacroAssemblerMIPS::branchMul32):
        (JSC::MacroAssemblerMIPS::branchSub32):
        (JSC::MacroAssemblerMIPS::set8Compare32):
        (JSC::MacroAssemblerMIPS::set32Compare32):
        (JSC::MacroAssemblerMIPS::set32Test8):
        (JSC::MacroAssemblerMIPS::set32Test32):
        (JSC::MacroAssemblerMIPS::moveWithPatch):
        (JSC::MacroAssemblerMIPS::branchPtrWithPatch):
        (JSC::MacroAssemblerMIPS::storePtrWithPatch):
        (JSC::MacroAssemblerMIPS::tailRecursiveCall):
        (JSC::MacroAssemblerMIPS::loadDouble):
        (JSC::MacroAssemblerMIPS::storeDouble):
        (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::add32):
        (JSC::MacroAssemblerX86::addWithCarry32):
        (JSC::MacroAssemblerX86::and32):
        (JSC::MacroAssemblerX86::or32):
        (JSC::MacroAssemblerX86::sub32):
        (JSC::MacroAssemblerX86::store32):
        (JSC::MacroAssemblerX86::branch32):
        (JSC::MacroAssemblerX86::moveWithPatch):
        (JSC::MacroAssemblerX86::branchPtrWithPatch):
        (JSC::MacroAssemblerX86::storePtrWithPatch):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::add32):
        (JSC::MacroAssemblerX86Common::and32):
        (JSC::MacroAssemblerX86Common::lshift32):
        (JSC::MacroAssemblerX86Common::mul32):
        (JSC::MacroAssemblerX86Common::or32):
        (JSC::MacroAssemblerX86Common::rshift32):
        (JSC::MacroAssemblerX86Common::urshift32):
        (JSC::MacroAssemblerX86Common::sub32):
        (JSC::MacroAssemblerX86Common::xor32):
        (JSC::MacroAssemblerX86Common::store32):
        (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
        (JSC::MacroAssemblerX86Common::push):
        (JSC::MacroAssemblerX86Common::move):
        (JSC::MacroAssemblerX86Common::branch8):
        (JSC::MacroAssemblerX86Common::branch32):
        (JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerX86Common::branch16):
        (JSC::MacroAssemblerX86Common::branchTest32):
        (JSC::MacroAssemblerX86Common::branchTest8):
        (JSC::MacroAssemblerX86Common::branchAdd32):
        (JSC::MacroAssemblerX86Common::branchMul32):
        (JSC::MacroAssemblerX86Common::branchSub32):
        (JSC::MacroAssemblerX86Common::set8Compare32):
        (JSC::MacroAssemblerX86Common::set32Compare32):
        (JSC::MacroAssemblerX86Common::set32Test8):
        (JSC::MacroAssemblerX86Common::set32Test32):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::add32):
        (JSC::MacroAssemblerX86_64::and32):
        (JSC::MacroAssemblerX86_64::or32):
        (JSC::MacroAssemblerX86_64::sub32):
        (JSC::MacroAssemblerX86_64::loadDouble):
        (JSC::MacroAssemblerX86_64::addDouble):
        (JSC::MacroAssemblerX86_64::convertInt32ToDouble):
        (JSC::MacroAssemblerX86_64::store32):
        (JSC::MacroAssemblerX86_64::call):
        (JSC::MacroAssemblerX86_64::tailRecursiveCall):
        (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
        (JSC::MacroAssemblerX86_64::addPtr):
        (JSC::MacroAssemblerX86_64::andPtr):
        (JSC::MacroAssemblerX86_64::orPtr):
        (JSC::MacroAssemblerX86_64::subPtr):
        (JSC::MacroAssemblerX86_64::xorPtr):
        (JSC::MacroAssemblerX86_64::storePtr):
        (JSC::MacroAssemblerX86_64::setPtr):
        (JSC::MacroAssemblerX86_64::branchPtr):
        (JSC::MacroAssemblerX86_64::branchTestPtr):
        (JSC::MacroAssemblerX86_64::branchSubPtr):
        (JSC::MacroAssemblerX86_64::moveWithPatch):
        (JSC::MacroAssemblerX86_64::branchPtrWithPatch):
        (JSC::MacroAssemblerX86_64::storePtrWithPatch):
        (JSC::MacroAssemblerX86_64::branchTest8):
        * dfg/DFGJITCodeGenerator.h:
        (JSC::DFG::JITCodeGenerator::callOperation):
        * dfg/DFGJITCompiler.cpp:
        (JSC::DFG::JITCompiler::jitAssertIsInt32):
        (JSC::DFG::JITCompiler::emitCount):
        * dfg/DFGJITCompiler.h:
        (JSC::DFG::JITCompiler::emitPutImmediateToCallFrameHeader):
        * dfg/DFGNonSpeculativeJIT.cpp:
        (JSC::DFG::NonSpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::fillSpeculateCell):
        (JSC::DFG::SpeculativeJIT::compile):
        * jit/JIT.cpp:
        (JSC::JIT::emitTimeoutCheck):
        (JSC::JIT::privateCompile):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::emit_op_urshift):
        (JSC::JIT::emitSlow_op_urshift):
        (JSC::JIT::emit_op_post_inc):
        (JSC::JIT::emit_op_post_dec):
        (JSC::JIT::emit_op_pre_inc):
        (JSC::JIT::emit_op_pre_dec):
        (JSC::JIT::emit_op_mod):
        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emit_op_negate):
        (JSC::JIT::emit_op_jnless):
        (JSC::JIT::emit_op_jless):
        (JSC::JIT::emit_op_jlesseq):
        (JSC::JIT::emit_op_lshift):
        (JSC::JIT::emitRightShift):
        (JSC::JIT::emitRightShiftSlowCase):
        (JSC::JIT::emit_op_bitand):
        (JSC::JIT::emit_op_bitor):
        (JSC::JIT::emit_op_bitxor):
        (JSC::JIT::emit_op_bitnot):
        (JSC::JIT::emit_op_post_inc):
        (JSC::JIT::emit_op_post_dec):
        (JSC::JIT::emitSlow_op_post_dec):
        (JSC::JIT::emit_op_pre_inc):
        (JSC::JIT::emit_op_pre_dec):
        (JSC::JIT::emit_op_add):
        (JSC::JIT::emitAdd32Constant):
        (JSC::JIT::emit_op_sub):
        (JSC::JIT::emitSub32Constant):
        (JSC::JIT::emitBinaryDoubleOp):
        (JSC::JIT::emit_op_mul):
        (JSC::JIT::emitSlow_op_mul):
        (JSC::JIT::emit_op_div):
        (JSC::JIT::emit_op_mod):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::emit_op_ret_object_or_this):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitPutCellToCallFrameHeader):
        (JSC::JIT::emitPutIntToCallFrameHeader):
        (JSC::JIT::emitPutImmediateToCallFrameHeader):
        (JSC::JIT::emitLoadCharacterString):
        (JSC::JIT::restoreArgumentReferenceForTrampoline):
        (JSC::JIT::checkStructure):
        (JSC::JIT::setSamplingFlag):
        (JSC::JIT::clearSamplingFlag):
        (JSC::JIT::emitCount):
        (JSC::JIT::sampleInstruction):
        (JSC::JIT::sampleCodeBlock):
        (JSC::JIT::emitStoreInt32):
        (JSC::JIT::emitStoreCell):
        (JSC::JIT::emitStoreBool):
        (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
        (JSC::JIT::emitInitRegister):
        (JSC::JIT::emitJumpIfJSCell):
        (JSC::JIT::emitJumpIfNotJSCell):
        (JSC::JIT::emitJumpIfImmediateInteger):
        (JSC::JIT::emitJumpIfNotImmediateInteger):
        (JSC::JIT::emitFastArithDeTagImmediate):
        (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
        (JSC::JIT::emitFastArithReTagImmediate):
        (JSC::JIT::emitTagAsBoolImmediate):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_check_has_instance):
        (JSC::JIT::emit_op_instanceof):
        (JSC::JIT::emit_op_ret_object_or_this):
        (JSC::JIT::emit_op_resolve):
        (JSC::JIT::emit_op_to_primitive):
        (JSC::JIT::emit_op_resolve_base):
        (JSC::JIT::emit_op_ensure_property_exists):
        (JSC::JIT::emit_op_resolve_skip):
        (JSC::JIT::emit_op_resolve_global):
        (JSC::JIT::emitSlow_op_resolve_global):
        (JSC::JIT::emit_op_not):
        (JSC::JIT::emit_op_jfalse):
        (JSC::JIT::emit_op_jeq_null):
        (JSC::JIT::emit_op_jneq_null):
        (JSC::JIT::emit_op_jneq_ptr):
        (JSC::JIT::emit_op_jsr):
        (JSC::JIT::emit_op_resolve_with_base):
        (JSC::JIT::emit_op_new_func_exp):
        (JSC::JIT::emit_op_jtrue):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_to_jsnumber):
        (JSC::JIT::emit_op_push_new_scope):
        (JSC::JIT::emit_op_catch):
        (JSC::JIT::emit_op_eq_null):
        (JSC::JIT::emit_op_neq_null):
        (JSC::JIT::emit_op_init_lazy_reg):
        (JSC::JIT::emit_op_convert_this):
        (JSC::JIT::emit_op_convert_this_strict):
        (JSC::JIT::emitSlow_op_not):
        (JSC::JIT::emitSlow_op_neq):
        (JSC::JIT::emit_op_get_arguments_length):
        (JSC::JIT::emitSlow_op_get_arguments_length):
        (JSC::JIT::emit_op_get_argument_by_val):
        (JSC::JIT::emitSlow_op_resolve_global_dynamic):
        (JSC::JIT::emit_op_new_regexp):
        (JSC::JIT::emit_op_load_varargs):
        (JSC::JIT::emitSlow_op_load_varargs):
        (JSC::JIT::emit_op_new_func):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_loop_if_lesseq):
        (JSC::JIT::emit_op_check_has_instance):
        (JSC::JIT::emit_op_instanceof):
        (JSC::JIT::emit_op_get_scoped_var):
        (JSC::JIT::emit_op_put_scoped_var):
        (JSC::JIT::emit_op_tear_off_activation):
        (JSC::JIT::emit_op_tear_off_arguments):
        (JSC::JIT::emit_op_resolve):
        (JSC::JIT::emit_op_to_primitive):
        (JSC::JIT::emit_op_resolve_base):
        (JSC::JIT::emit_op_ensure_property_exists):
        (JSC::JIT::emit_op_resolve_skip):
        (JSC::JIT::emit_op_resolve_global):
        (JSC::JIT::emitSlow_op_resolve_global):
        (JSC::JIT::emit_op_not):
        (JSC::JIT::emit_op_jfalse):
        (JSC::JIT::emit_op_jtrue):
        (JSC::JIT::emit_op_jeq_null):
        (JSC::JIT::emit_op_jneq_null):
        (JSC::JIT::emit_op_jneq_ptr):
        (JSC::JIT::emit_op_jsr):
        (JSC::JIT::emit_op_eq):
        (JSC::JIT::emitSlow_op_eq):
        (JSC::JIT::emit_op_neq):
        (JSC::JIT::emitSlow_op_neq):
        (JSC::JIT::compileOpStrictEq):
        (JSC::JIT::emit_op_eq_null):
        (JSC::JIT::emit_op_neq_null):
        (JSC::JIT::emit_op_resolve_with_base):
        (JSC::JIT::emit_op_new_func_exp):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_to_jsnumber):
        (JSC::JIT::emit_op_push_new_scope):
        (JSC::JIT::emit_op_catch):
        (JSC::JIT::emit_op_create_activation):
        (JSC::JIT::emit_op_create_arguments):
        (JSC::JIT::emit_op_convert_this):
        (JSC::JIT::emit_op_convert_this_strict):
        (JSC::JIT::emit_op_get_arguments_length):
        (JSC::JIT::emitSlow_op_get_arguments_length):
        (JSC::JIT::emit_op_get_argument_by_val):
        (JSC::JIT::softModulo):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::stringGetByValStubGenerator):
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emitSlow_op_get_by_val):
        (JSC::JIT::emit_op_get_by_pname):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::emit_op_put_by_index):
        (JSC::JIT::emit_op_put_getter):
        (JSC::JIT::emit_op_put_setter):
        (JSC::JIT::emit_op_del_by_id):
        (JSC::JIT::emit_op_get_by_id):
        (JSC::JIT::emit_op_put_by_id):
        (JSC::JIT::emit_op_method_check):
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::compileGetByIdSlowCase):
        (JSC::JIT::emitSlow_op_put_by_id):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_put_getter):
        (JSC::JIT::emit_op_put_setter):
        (JSC::JIT::emit_op_del_by_id):
        (JSC::JIT::emit_op_get_by_id):
        (JSC::JIT::emit_op_put_by_id):
        (JSC::JIT::emit_op_method_check):
        (JSC::JIT::stringGetByValStubGenerator):
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emitSlow_op_get_by_val):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::compileGetByIdSlowCase):
        (JSC::JIT::emitSlow_op_put_by_id):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        (JSC::JIT::emit_op_get_by_pname):
        * jit/JITStubCall.h:
        (JSC::JITStubCall::addArgument):
        * jit/JITStubs.cpp:
        (JSC::getPolymorphicAccessStructureListSlot):
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
        (JSC::JSInterfaceJIT::emitLoadInt32):
        (JSC::JSInterfaceJIT::emitLoadDouble):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::SpecializedThunkJIT):
        (JSC::SpecializedThunkJIT::loadJSStringArgument):
        (JSC::SpecializedThunkJIT::tagReturnAsInt32):
        (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
        * jit/ThunkGenerators.cpp:
        (JSC::charToString):
        (JSC::powThunkGenerator):
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::matchCharacterClass):
        (JSC::Yarr::YarrGenerator::storeToFrame):
        (JSC::Yarr::YarrGenerator::storeToFrameWithPatch):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterSingle):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
        (JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
        (JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
        (JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
        (JSC::Yarr::YarrGenerator::generateDisjunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows 7 Release Tests] editing/spelling/spelling-backspace-between-lines.html...
jberlin@webkit.org [Mon, 28 Mar 2011 17:10:30 +0000 (17:10 +0000)]
[Windows 7 Release Tests] editing/spelling/spelling-backspace-between-lines.html fails.
https://bugs.webkit.org/show_bug.cgi?id=57243

Rubber-stamped by Adam Roben.

* platform/win/Skipped:
Remove the two tests that were removed in r71392.
Also, remove spelling-backspace-between-lines.html because it is not flakey and the
layoutTestController method is implemented on Windows, it just fails with this test.

* platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/57239> Use forward class declaration instead of including header
ddkilzer@apple.com [Mon, 28 Mar 2011 17:07:44 +0000 (17:07 +0000)]
<webkit.org/b/57239> Use forward class declaration instead of including header

Reviewed by Dan Bernstein.

Adding a "using namespace WebCore;" statement in a header may
cause issues when <WebCore/Length.h> is included before
<CoreText/CoreText.h>.

Length.h defines the LengthType enum with a 'Fixed' value.
CoreText.h includes MacTypes.h, which has a
"typedef SInt32 Fixed;" statement, and then CoreText.h includes
other headers that also use 'Fixed', but expect the typedef to
be defined, not the enum.  If another header includes
"using namespace WebCore;" before CoreText.h, the
following compiler errors result (paths abbreviated):

    CoreText.framework/Headers/SFNTLayoutTypes.h:689: error: reference to 'Fixed' is ambiguous
    MacTypes.h:184: error: candidates are: typedef SInt32 Fixed
    Length.h:37: error:                 WebCore::LengthType WebCore::Fixed
    SFNTLayoutTypes.h:689: error: 'Fixed' does not name a type

* platform/mac/HTMLConverter.h: Use forward declaration of
DocumentLoader class instead of including header.  Remove the
unused "using namespace WebCore;" statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-26 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 28 Mar 2011 17:01:21 +0000 (17:01 +0000)]
2011-03-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Introduce EventDispatcher, the new common way to fire events.
        https://bugs.webkit.org/show_bug.cgi?id=57168

        The goal here is two-fold:
        1) reduce the need to randomly sprinkle guards around the dispatch code
        by creating a well-scoped abstraction for dispatching events.
        2) create a place where fiddly event-related things like creating event
        contexts for ancestors can be done lazily.

        Additionally, with all the free-standing static functions, this code was
        just begging to come out of Node.cpp.

        The first step is a near-mechanical extraction of mouse-related events
        from Node.cpp to EventDispatcher. For now, the call sites are just
        replaced with invoking EventDispatcher. Later, we can remove these methods
        from Node.

        Refactoring, no functional changes.

        * Android.mk: Added EventDispatcher to build system.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * dom/DOMAllInOne.cpp: Ditto.
        * dom/EventDispatcher.cpp: Added.
        * dom/EventDispatcher.h: Added.
        * dom/Node.cpp:
        (WebCore::Node::dispatchScopedEvent): Replaced to use EventDispatcher.
        (WebCore::Node::dispatchEvent): Ditto.
        (WebCore::Node::dispatchMouseEvent): Ditto.
        (WebCore::Node::dispatchSimulatedClick): Ditto.
        * dom/Node.h: Updated decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows 7 Release Tests] fast/blockflow/fallback-orientation.html failing since
jberlin@webkit.org [Mon, 28 Mar 2011 16:37:50 +0000 (16:37 +0000)]
[Windows 7 Release Tests] fast/blockflow/fallback-orientation.html failing since
introduction in r82056.
https://bugs.webkit.org/show_bug.cgi?id=57238

Unreviewed, add expected failing results, since vertical text is not yet implemented on
Windows, to get the bots green.

* platform/win/fast/blockflow/fallback-orientation-expected.checksum: Added.
* platform/win/fast/blockflow/fallback-orientation-expected.png: Added.
* platform/win/fast/blockflow/fallback-orientation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Mon, 28 Mar 2011 16:29:08 +0000 (16:29 +0000)]
2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
        https://bugs.webkit.org/show_bug.cgi?id=57087

        Enable QT_ASCII_CAST_WARNINGS by default in webkit.pri to catch the errors early on.

        * Source/WebKit.pri:
2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
        https://bugs.webkit.org/show_bug.cgi?id=57087

        * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
        * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
        since they are applications, not libraries.
2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
        https://bugs.webkit.org/show_bug.cgi?id=57087

        Disable QT_ASCII_CAST_WARNINGS for applications.

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/ImageDiff.pro:
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
        * MiniBrowser/qt/MiniBrowser.pro:
        * QtTestBrowser/QtTestBrowser.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 16:24:02 +0000 (16:24 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fullscreen tests failing after r82084
        https://bugs.webkit.org/show_bug.cgi?id=57219

        Unskipped some fullscreen tests passing now.

        * platform/gtk/Skipped:
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fullscreen tests failing after r82084
        https://bugs.webkit.org/show_bug.cgi?id=57219

        Added the withKeyboard parameter to supportsFullScreenForElement
        method in ChromeClient. Fullscreen will be disabled for keyboard
        access by default.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::supportsFullScreenForElement):
        * WebCoreSupport/ChromeClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing...
mitz@apple.com [Mon, 28 Mar 2011 16:17:07 +0000 (16:17 +0000)]
<rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing modes
https://bugs.webkit.org/show_bug.cgi?id=57197

Reviewed by Maciej Stachowiak.

Source/WebCore:

Tests: fast/repaint/overflow-flipped-writing-mode-block.html
       fast/repaint/overflow-flipped-writing-mode-table.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint): Flip the overflow rect before testing for intersection
with the damage rect.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint): Made the intersection check more like the one in
RenderBlock::paint().

LayoutTests:

* fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
* fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
* fast/repaint/overflow-flipped-writing-mode-block-expected.txt: Added.
* fast/repaint/overflow-flipped-writing-mode-block.html: Added.
* fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
* fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
* fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
* fast/repaint/overflow-flipped-writing-mode-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 15:58:40 +0000 (15:58 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, rebaseline GTK+ test results.

        * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
        * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
        * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Mon, 28 Mar 2011 15:56:11 +0000 (15:56 +0000)]
2011-03-28  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        move directionOfEnclosingBlock() to be global so that it could be reused.
        https://bugs.webkit.org/show_bug.cgi?id=57233.

        Provide global function directionOfEnclosingBlock(Node*) so that it could be
        reused in SelectionController and other functionalities that need enclosing
        block's direcionality, such as moving caret by word in visual order.

        No new functionality, so no new tests.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::directionOfEnclosingBlock):
        * editing/htmlediting.cpp:
        (WebCore::directionOfEnclosingBlock):
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet eol-style to native on more files. I noticed the last check-in had an entire...
darin@apple.com [Mon, 28 Mar 2011 15:48:11 +0000 (15:48 +0000)]
Set eol-style to native on more files. I noticed the last check-in had an entire file
changing because of an EOL style change, and setting this property prevents that from
happening in future. We may want to do this systematically for more of WebKit later.

* AccessibleBase.cpp: Added property svn:eol-style.
* AccessibleBase.h: Added property svn:eol-style.
* AccessibleDocument.cpp: Added property svn:eol-style.
* AccessibleDocument.h: Added property svn:eol-style.
* AccessibleImage.cpp: Added property svn:eol-style.
* AccessibleImage.h: Added property svn:eol-style.
* COMVariantSetter.h: Added property svn:eol-style.
* FullscreenVideoController.cpp: Added property svn:eol-style.
* FullscreenVideoController.h: Added property svn:eol-style.
* WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
* WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
* WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
* WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
* WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
* WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
* WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
* WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
* WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
* WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/navigation/changing-frame-hierarchy-in-onload.html flakey on Snow Leopard
jberlin@webkit.org [Mon, 28 Mar 2011 15:47:49 +0000 (15:47 +0000)]
http/tests/navigation/changing-frame-hierarchy-in-onload.html flakey on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=57236

Unreviewed, skip the flakey test in order to get the bots green.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 14:43:33 +0000 (14:43 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, update pixel test expectations after r82105.

        * platform/gtk/fast/css/text-align-expected.checksum:
        * platform/gtk/fast/css/text-align-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
commit-queue@webkit.org [Mon, 28 Mar 2011 14:39:59 +0000 (14:39 +0000)]
2011-03-28  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Benjamin Poulain.

        [Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails
        https://bugs.webkit.org/show_bug.cgi?id=56825

        Fixes for context attribute handling:
        - Initialize depth and stencil buffer depending on whether they
        are enabled in context attributes.
        - Always enable depth buffer when stencil buffer is enabled.
        - Disable stencil buffer on OpenGL ES 2.0
        - Cleaned up clutter code from initialization. Made code paths
        more sane.
        - Clear mask is now set correctly in reshape().

        Tests: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3DInternal::isValid):
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::reshape):
        (WebCore::GraphicsContext3DInternal::paint):
        (WebCore::GraphicsContext3DInternal::getProcAddress):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        (WebCore::GraphicsContext3D::reshape):
        (WebCore::GraphicsContext3D::bindFramebuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Mar 2011 14:34:40 +0000 (14:34 +0000)]
2011-03-28  Ryosuke Niwa  <rniwa@webkit.org>

        [Chromium] [Mac Leopard] Update test expectations after r82105.

        * platform/chromium-linux/fast/css/text-align-expected.checksum:
        * platform/chromium-linux/fast/css/text-align-expected.png:
        * platform/chromium-win/fast/css/text-align-expected.checksum:
        * platform/chromium-win/fast/css/text-align-expected.png:
        * platform/chromium-win/fast/css/text-align-expected.txt:
        * platform/mac-leopard/fast/css/text-align-expected.checksum:
        * platform/mac-leopard/fast/css/text-align-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 28 Mar 2011 14:33:07 +0000 (14:33 +0000)]
2011-03-28  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt] QtWebKit does not link with --3d-canvas using MinGW
        https://bugs.webkit.org/show_bug.cgi?id=57225

        * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove WebKitSystemInterface_debug.lib, it hasn't been used for a few months now.
jeffm@apple.com [Mon, 28 Mar 2011 14:21:45 +0000 (14:21 +0000)]
Remove WebKitSystemInterface_debug.lib, it hasn't been used for a few months now.

Rubber-stamped by Adam Roben.

* win/lib/WebKitSystemInterface_debug.lib: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
ossy@webkit.org [Mon, 28 Mar 2011 14:12:29 +0000 (14:12 +0000)]
REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
https://bugs.webkit.org/show_bug.cgi?id=57183

Reviewed by Andreas Kling.

Windows buildfix after r82065.

* Api/DerivedSources.pro: Readding escaping on Windows platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Mar 2011 14:10:17 +0000 (14:10 +0000)]
2011-03-28  Ryosuke Niwa  <rniwa@webkit.org>

        [GTK] Update text expectations after r82105.

        * platform/gtk/fast/css/text-align-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Mar 2011 13:44:10 +0000 (13:44 +0000)]
2011-03-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: rename network domain events from didHappenSomething to somethingHappened.
        https://bugs.webkit.org/show_bug.cgi?id=57226

        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::willSendRequest):
        (WebCore::InspectorResourceAgent::markResourceAsCached):
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        (WebCore::InspectorResourceAgent::didReceiveContentLength):
        (WebCore::InspectorResourceAgent::didFinishLoading):
        (WebCore::InspectorResourceAgent::didFailLoading):
        (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
        (WebCore::InspectorResourceAgent::setInitialContent):
        (WebCore::InspectorResourceAgent::didCommitLoad):
        (WebCore::InspectorResourceAgent::frameDetachedFromParent):
        (WebCore::InspectorResourceAgent::didCreateWebSocket):
        (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorResourceAgent::didCloseWebSocket):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
        (WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
        (WebInspector.NetworkDispatcher.prototype.responseReceived):
        (WebInspector.NetworkDispatcher.prototype.dataReceived):
        (WebInspector.NetworkDispatcher.prototype.loadingFinished):
        (WebInspector.NetworkDispatcher.prototype.loadingFailed):
        (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
        (WebInspector.NetworkDispatcher.prototype.frameDetached):
        (WebInspector.NetworkDispatcher.prototype.initialContentSet):
        (WebInspector.NetworkDispatcher.prototype.frameNavigated):
        (WebInspector.NetworkDispatcher.prototype.webSocketCreated):
        (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
        (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
        (WebInspector.NetworkDispatcher.prototype.webSocketClosed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82111 268f45cc-cd09-0410-ab3c-d52691b4dbfc