WebKit-https.git
9 years ago2011-02-10 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Thu, 10 Feb 2011 13:39:13 +0000 (13:39 +0000)]
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * Source/cmake/WebKitFS.cmake:
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * Android.mk:
        * Android.v8.wtf.mk:
        * CMakeLists.txt:
        * DerivedSources.make:
        * DerivedSources.pro:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.order:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * pcre/AUTHORS: Removed.
        * pcre/COPYING: Removed.
        * pcre/dftables: Removed.
        * pcre/pcre.h: Removed.
        * pcre/pcre.pri: Removed.
        * pcre/pcre_compile.cpp: Removed.
        * pcre/pcre_exec.cpp: Removed.
        * pcre/pcre_internal.h: Removed.
        * pcre/pcre_tables.cpp: Removed.
        * pcre/pcre_ucp_searchfuncs.cpp: Removed.
        * pcre/pcre_xclass.cpp: Removed.
        * pcre/ucpinternal.h: Removed.
        * pcre/ucptable.cpp: Removed.
        * wscript:
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * ForwardingHeaders/pcre/pcre.h: Removed.
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * WebKit2.pro:
2011-02-10  Peter Varga  <pvarga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Remove PCRE source from trunk
        https://bugs.webkit.org/show_bug.cgi?id=54188

        * wx/build/settings.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Thu, 10 Feb 2011 13:37:26 +0000 (13:37 +0000)]
2011-02-10  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left
        https://bugs.webkit.org/show_bug.cgi?id=54098

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype._updatePanelOffsets):
        (WebInspector.TextViewer.prototype._syncScroll):
        (WebInspector.TextViewer.prototype._syncDecorationsForLine):
        (WebInspector.TextEditorChunkedPanel.prototype._totalHeight):
        (WebInspector.TextEditorChunkedPanel.prototype.resize):
        (WebInspector.TextEditorGutterPanel):
        (WebInspector.TextEditorGutterChunk.prototype.set expanded):
        (WebInspector.TextEditorGutterChunk.prototype.get height):
        (WebInspector.TextEditorMainChunk.prototype.get height):
        * inspector/front-end/textViewer.css:
        (.webkit-line-content):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 13:24:46 +0000 (13:24 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing fast/text/midword-break-after-breakable-char.html on
        GTK

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 10 Feb 2011 13:15:24 +0000 (13:15 +0000)]
2011-02-10  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Add randomValuesFromOS for OS(WINDOWS)
        https://bugs.webkit.org/show_bug.cgi?id=54155

        Use CryptGenRandom for generating cryptographically secure random numbers.
        This will work on WinCE and MinGW too.

        * config.h:
        * wtf/OSRandomSource.cpp:
        (WTF::randomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Thu, 10 Feb 2011 13:06:05 +0000 (13:06 +0000)]
2011-02-10  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Jeremy Orlow.

        [chromium] add WebIDBObjectStore::clear method

        https://bugs.webkit.org/show_bug.cgi?id=54149

        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::put):
        (WebKit::WebIDBObjectStore::deleteFunction):
        (WebKit::WebIDBObjectStore::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 12:59:43 +0000 (12:59 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing fast/text/capitalize-boundaries.html on
        GTK

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 10 Feb 2011 12:52:48 +0000 (12:52 +0000)]
2011-02-10  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style should be able to figure out function modifiers and return type.
        https://bugs.webkit.org/show_bug.cgi?id=54124

        * Scripts/webkitpy/style/checkers/cpp.py:
        (_rfind_in_lines): A way to search backwards in lines.
        (_FunctionState.modifiers_and_return_type):
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 takano takumi <takano@apple.com>
commit-queue@webkit.org [Thu, 10 Feb 2011 12:48:20 +0000 (12:48 +0000)]
2011-02-10  takano takumi  <takano@apple.com>

        Reviewed by Dan Bernstein.

        A full-width character rotated leftward 90 degrees in text-combine
        https://bugs.webkit.org/show_bug.cgi?id=54169

        Added a test for this bug to existing text-combine test.

        * fast/text/international/text-combine-image-test.html:
        * platform/mac/fast/text/international/text-combine-image-test-expected.checksum:
        * platform/mac/fast/text/international/text-combine-image-test-expected.png:
        * platform/mac/fast/text/international/text-combine-image-test-expected.txt:
2011-02-10  takano takumi  <takano@apple.com>

        Reviewed by Dan Bernstein.

        A full-width character rotated leftward 90 degrees in text-combine
        https://bugs.webkit.org/show_bug.cgi?id=54169

        * rendering/RenderCombineText.cpp:
        (WebCore::RenderCombineText::combineText):
        - Fixed by resetting font's orientation to horizontal when we decided to make combined text.
        Otherwise the text will be unexpectedly rotated in showGlyphsWithAdvances() in FontMac.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Jarred Nicholls <jarred@sencha.com>
commit-queue@webkit.org [Thu, 10 Feb 2011 12:46:26 +0000 (12:46 +0000)]
2011-02-10  Jarred Nicholls  <jarred@sencha.com>

        Reviewed by Adam Barth.

        REGRESSION(r78149): Return value of read() shouldn't be ignored.
        https://bugs.webkit.org/show_bug.cgi?id=54167

        stdio read should have its return value handled. Build error in gcc 4.4.5.

        * wtf/OSRandomSource.cpp:
        (WTF::randomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Thu, 10 Feb 2011 12:42:43 +0000 (12:42 +0000)]
2011-02-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=50306
        <rdar://problem/8976152> REGRESSION: WebChromeClient::shouldReplaceWithGeneratedFileForUpload()
        uses an initialized result value (breaks form submission with clang-built WebKit)

        No new test, because I can't reproduce the observable effect with my gcc build.

        * platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Restore an
        empty path check - an empty path was causing an exception in Foundation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTurn on the new drawing area on Windows
aroben@apple.com [Thu, 10 Feb 2011 12:41:15 +0000 (12:41 +0000)]
Turn on the new drawing area on Windows

Fixes <http://webkit.org/b/53805> <rdar://problem/8960666> WebKit2 on Windows should use
DrawingAreaProxyImpl

Reviewed by Darin Adler.

* UIProcess/win/WebView.cpp:
(WebKit::useNewDrawingArea): Return true!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHook up WM_PRINT to the new drawing area
aroben@apple.com [Thu, 10 Feb 2011 12:40:47 +0000 (12:40 +0000)]
Hook up WM_PRINT to the new drawing area

Fixes <http://webkit.org/b/54145> <rdar://problem/8979559> WM_PRINT doesn't work with new
drawing area (assertion failure in DrawingAreaProxyImpl in Debug builds)

Reviewed by Darin Adler.

Source/WebKit2:

* UIProcess/win/WebView.cpp:
(WebKit::WebView::paint): Added. Code came from onPaintEvent.

(WebKit::WebView::onPaintEvent):
(WebKit::WebView::onPrintClientEvent):
Changed to call paint.

* UIProcess/win/WebView.h: Added paint. Also separated message handler functions into their
own paragraph.

Tools:

Test that WM_PRINT doesn't trigger an assertion

* TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Added.
(TestWebKitAPI::TEST): Send a WM_PRINT message to a WKView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNotice when the backing store goes away after DidSetSize
aroben@apple.com [Thu, 10 Feb 2011 12:40:09 +0000 (12:40 +0000)]
Notice when the backing store goes away after DidSetSize

Fixes <http://webkit.org/b/54142> <rdar://problem/8979365> Crash in
DrawingAreaProxyImpl::paint when WKView paints after being resized while hidden

Reviewed by Darin Adler.

Source/WebKit2:

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint): Null-check m_backingStore after waiting for
DidSetSize, as m_backingStore can go away when we receive that message. This is the bug fix.
Also moved the accelerated compositing check inside the block where we wait for DidSetSize.
If we didn't wait for DidSetSize, we already know that we're not in accelerated compositing
mode (and asserted so earlier in this function).

Tools:

Test that having a WKView paint after being resized while hidden doesn't cause a crash

* TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
(TestWebKitAPI::TEST): Force the WKView to paint after resizing it while hidden.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDecode a null SharedMemory::Handle correctly on Windows
aroben@apple.com [Thu, 10 Feb 2011 12:39:33 +0000 (12:39 +0000)]
Decode a null SharedMemory::Handle correctly on Windows

Fixes <http://webkit.org/b/54141> <rdar://problem/8979195> WKView draws at wrong size,
performs badly if is resized while hidden (assertion fails in
BackingStore::incorporateUpdate in Debug builds)

Reviewed by Darin Adler.

Source/WebKit2:

* Platform/win/SharedMemoryWin.cpp:
(WebKit::getDuplicatedHandle): Added. Code came from decode. The only changes were to
null-check sourceHandle (this is the bug fix) and to assert when ::DuplicateHandle fails
(which would have caught the bug earlier).
(WebKit::SharedMemory::Handle::decode): Changed to use getDuplicatedHandle.

Tools:

Add a test that resizes a WKView while it's hidden

* TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Hook up our didFinishLoadForFrame callback.
(TestWebKitAPI::flushMessages): Load a URL and wait for the load to complete. This ensures
that all pending messages have been handled by the UI and web process.
(TestWebKitAPI::timerCallback): Kill the timer and record that it fired.
(TestWebKitAPI::runForDuration): Set a timer and run the run loop until it fires.
(TestWebKitAPI::waitForBackingStoreUpdate): Wait for half a second to give the web process a
chance to display, then flush all pending messages.
(TestWebKitAPI::TEST): Resize the WKView while it's hidden, then show it again and wait for
the backing store to update. This triggers the assertion from bug 54141.

* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::resizeTo): Implemented.

* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't invalidate outside of the WebPage's bounds
aroben@apple.com [Thu, 10 Feb 2011 12:38:14 +0000 (12:38 +0000)]
Don't invalidate outside of the WebPage's bounds

Fixes <http://webkit.org/b/54123> <rdar://problem/8978383> Assertion failure in
BackingStore::BackingStore if a new WebPage becomes active before receiving a size

Reviewed by Darin Adler.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay): Intersect the dirty rect with our bounds before
doing anything else.
(WebKit::DrawingAreaImpl::display): Added an assertion to help catch the bad case a little
earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 10 Feb 2011 12:36:37 +0000 (12:36 +0000)]
2011-02-09  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Network & Resource panels make multiple requests for images with no content
        https://bugs.webkit.org/show_bug.cgi?id=54085

        - Added success parameter to resourceContent
        - NetworkManager.requestContent() now returns empty for zero-length resources, null for errors

        * inspector/Inspector.idl:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::resourceData):
        (WebCore::InspectorResourceAgent::resourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype.requestContent):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.requestContent):
        (WebInspector.Resource.prototype._contentURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 10 Feb 2011 12:26:58 +0000 (12:26 +0000)]
2011-02-10  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename randomValuesFromOS to cryptographicallyRandomValuesFromOS
        https://bugs.webkit.org/show_bug.cgi?id=54156

        randomValuesFromOS generates random numbers of cryptographic quality.
        Make this clear by adding "cryptographically" to the function name.

        * wtf/CryptographicallyRandomNumber.cpp:
        (WTF::ARC4Stream::ARC4RandomNumberGenerator::stir):
        * wtf/OSRandomSource.cpp:
        (WTF::cryptographicallyRandomValuesFromOS):
        * wtf/OSRandomSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Thu, 10 Feb 2011 12:23:48 +0000 (12:23 +0000)]
2011-02-10  Renata Hodovan  <reni@webkit.org>

        Reviewed by Dirk Schulze.

        Move the light source implementations into their own files.
        https://bugs.webkit.org/show_bug.cgi?id=53996

        Splitting LightSource.cpp into 3 files.

        No new tests are added since this is a refactoring.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/filters/DistantLightSource.cpp: Added.
        (WebCore::DistantLightSource::initPaintingData):
        (WebCore::DistantLightSource::updatePaintingData):
        (WebCore::DistantLightSource::setAzimuth):
        (WebCore::DistantLightSource::setElevation):
        (WebCore::DistantLightSource::externalRepresentation):
        * platform/graphics/filters/LightSource.cpp:
        * platform/graphics/filters/PointLightSource.cpp: Added.
        (WebCore::PointLightSource::initPaintingData):
        (WebCore::PointLightSource::updatePaintingData):
        (WebCore::PointLightSource::setX):
        (WebCore::PointLightSource::setY):
        (WebCore::PointLightSource::setZ):
        (WebCore::operator<<):
        (WebCore::PointLightSource::externalRepresentation):
        * platform/graphics/filters/SpotLightSource.cpp: Added.
        (WebCore::SpotLightSource::initPaintingData):
        (WebCore::SpotLightSource::updatePaintingData):
        (WebCore::SpotLightSource::setX):
        (WebCore::SpotLightSource::setY):
        (WebCore::SpotLightSource::setZ):
        (WebCore::SpotLightSource::setPointsAtX):
        (WebCore::SpotLightSource::setPointsAtY):
        (WebCore::SpotLightSource::setPointsAtZ):
        (WebCore::SpotLightSource::setSpecularExponent):
        (WebCore::SpotLightSource::setLimitingConeAngle):
        (WebCore::operator<<):
        (WebCore::SpotLightSource::externalRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Avi Drissman <avi@google.com>
commit-queue@webkit.org [Thu, 10 Feb 2011 12:07:10 +0000 (12:07 +0000)]
2011-02-10  Avi Drissman  <avi@google.com>

        Reviewed by Darin Fisher.

        <option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
        https://bugs.webkit.org/show_bug.cgi?id=50969

        Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::updateFromElement):
        * platform/chromium/PopupMenuChromium.h:
2011-02-10  Avi Drissman  <avi@google.com>

        Reviewed by Darin Fisher.

        <option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
        https://bugs.webkit.org/show_bug.cgi?id=50969

        Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.

        * public/WebMenuItemInfo.h:
        * public/WebPopupMenuInfo.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::getPopupMenuInfo):
        * src/ExternalPopupMenu.cpp:
        (WebKit::ExternalPopupMenu::getPopupMenuInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 kasthuri <kasthuri.n-s@nokia.com>
commit-queue@webkit.org [Thu, 10 Feb 2011 11:58:00 +0000 (11:58 +0000)]
2011-02-10  kasthuri  <kasthuri.n-s@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] QWebFrame::setHtml doesn't emit loadFinished signal
        https://bugs.webkit.org/show_bug.cgi?id=38634

        QWebView->page()->mainFrame()->setHtml(html) is always emitting
        the loadFinished() signal for all types of html files.
        But the proposed test content was trying to catch the signal after
        calling setHtml() api and becuase of this the emitted signal for a
        simple html page is never caught as its emitted before even the connect
        call was successful.

        updated the tst_QWebFrame::setHtml() in tst_qwebframe.cpp to check for
        signal using the QSignalSpy.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 11:54:51 +0000 (11:54 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing fast/replaced/border-radius-clip.html on GTK

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Feb 2011 11:39:59 +0000 (11:39 +0000)]
2011-02-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        LayoutTests/svg cleanup
        https://bugs.webkit.org/show_bug.cgi?id=54184

        Regenerate result with a 64bit SL machine.. a pity that we have diffs there.

        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Feb 2011 11:11:43 +0000 (11:11 +0000)]
2011-02-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        LayoutTests/svg cleanup
        https://bugs.webkit.org/show_bug.cgi?id=54184

        Update mac-leopard/qt baselines after r78182.

        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
        * platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
        * platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 11:06:27 +0000 (11:06 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, updated svg GTK baselines after r78182.

        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
        * platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Thu, 10 Feb 2011 11:02:06 +0000 (11:02 +0000)]
2011-02-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Update the semantics of put()
        https://bugs.webkit.org/show_bug.cgi?id=54102

        Update test to reflect the new semantics.

        * storage/indexeddb/objectstore-autoincrement-expected.txt:
        * storage/indexeddb/objectstore-autoincrement.html:
2011-02-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Update the semantics of put()
        https://bugs.webkit.org/show_bug.cgi?id=54102

        Update the semantics of put: For object stores with auto increment,
        it should be allowed to provide an explicit key, or an in-line key,
        overriding the key generator mechanism.

        This reflects the spec changes suggested here:
        http://www.w3.org/Bugs/Public/show_bug.cgi?id=11976

        Extracting key-selection logic into its own function
        to make it a bit easier on the eyes.

        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::selectKeyForPut):
        (WebCore::IDBObjectStoreBackendImpl::putInternal):
        * storage/IDBObjectStoreBackendImpl.h:
        (WebCore::IDBObjectStoreBackendImpl::resetAutoIncrementKeyCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 10:51:36 +0000 (10:51 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK build fix after roll out of r78157...

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 10 Feb 2011 10:49:11 +0000 (10:49 +0000)]
2011-02-10  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r78157.
        http://trac.webkit.org/changeset/78157
        https://bugs.webkit.org/show_bug.cgi?id=54150

        Fails on a bunch of bots

        * plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Removed.
        * plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Removed.
2011-02-10  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r78157.
        http://trac.webkit.org/changeset/78157
        https://bugs.webkit.org/show_bug.cgi?id=54150

        Fails on a bunch of bots

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::~PluginView):
        (WebKit::PluginView::evaluate):
2011-02-10  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r78157.
        http://trac.webkit.org/changeset/78157
        https://bugs.webkit.org/show_bug.cgi?id=54150

        Fails on a bunch of bots

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Removed.
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 10 Feb 2011 10:44:57 +0000 (10:44 +0000)]
2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test
        https://bugs.webkit.org/show_bug.cgi?id=54185

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=54103
antti@apple.com [Thu, 10 Feb 2011 10:43:13 +0000 (10:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=54103
Implement fast path for matching simple selectors

Reviewed by Darin Adler.

Implement a fast path for single and descendant selectors consisting
of id, class and tag selectors only.

Selectors like this are marked on style selector initialization. When
encountered during style matching they are resolved using a fast path.

Since selectors like this are very common this speeds up style matching
quite a bit (up to 50% on some sites according to Shark).

* css/CSSStyleSelector.cpp:
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasTopSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::selectorTagMatches):
(WebCore::isFastCheckableSelector):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::RuleData):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Feb 2011 10:25:55 +0000 (10:25 +0000)]
2011-02-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Maciej Stachowiak.

        LayoutTests/svg cleanup
        https://bugs.webkit.org/show_bug.cgi?id=54184

        Fix wrong xlink:hrefs in dozens of SVG testcases. SVGFreeSans.svg is now used in more places.
        Remove unnecessary xml-stylesheet declarations, and unneeded text css attributes in some places.

        Updated pixel test results for the affected testcases.

        * platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.checksum:
        * platform/mac/svg/batik/filters/feTile-expected.png:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum:
        * platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
        * platform/mac/svg/css/mask-with-shadow-expected.checksum:
        * platform/mac/svg/css/mask-with-shadow-expected.png:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.checksum:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/mac/svg/text/text-tref-01-b-expected.checksum:
        * platform/mac/svg/text/text-tref-01-b-expected.png:
        * platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
        * platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
        * svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg:
        * svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg:
        * svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg:
        * svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg:
        * svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg:
        * svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg:
        * svg/W3C-SVG-1.1-SE/types-dom-01-b.svg:
        * svg/W3C-SVG-1.1-SE/types-dom-02-f.svg:
        * svg/W3C-SVG-1.1-SE/types-dom-03-b.svg:
        * svg/W3C-SVG-1.1-SE/types-dom-04-b.svg:
        * svg/W3C-SVG-1.1-SE/types-dom-05-b.svg:
        * svg/W3C-SVG-1.1-SE/types-dom-06-f.svg:
        * svg/W3C-SVG-1.1-SE/types-dom-07-f.svg:
        * svg/W3C-SVG-1.1/filters-light-04-f.svg:
        * svg/W3C-SVG-1.1/filters-turb-02-f.svg:
        * svg/W3C-SVG-1.1/resources/interact-order-02-b-targ.svg:
        * svg/W3C-SVG-1.1/resources/interact-order-03-b-targ.svg:
        * svg/W3C-SVG-1.1/resources/linkingToc-t.svg:
        * svg/batik/filters/feTile.svg:
        * svg/css/circle-in-mask-with-shadow.svg:
        * svg/css/mask-with-shadow.svg:
        * svg/custom/image-clipped-hit.svg:
        * svg/foreignObject/text-tref-02-b.svg:
        * svg/hixie/cascade/002.css: Removed.
        * svg/text/text-tref-01-b.svg:
        * svg/transforms/animated-path-inside-transformed-html.xhtml:
        * svg/zoom/page/zoom-mask-with-percentages.svg:
        * svg/zoom/page/zoom-zoom-coords.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 10:04:43 +0000 (10:04 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed GTK build fix.

        Adding
        Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp
        in the build, fixing the
        plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html
        test.

        * GNUmakefile.am:

2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, typo fix.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 10 Feb 2011 09:29:38 +0000 (09:29 +0000)]
2011-02-10  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing test.

        * platform/gtk/Skipped: Skip fast/events/focusingUnloadedFrame.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Thu, 10 Feb 2011 09:03:30 +0000 (09:03 +0000)]
2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Add support in DRT to log "accessibility events"
        https://bugs.webkit.org/show_bug.cgi?id=54116

        Added a way to log accessibility related events, in a
        platform-dependant way.

        Add new function to AccessibilityController.

        * DumpRenderTree/AccessibilityController.h:
        * DumpRenderTree/AccessibilityController.cpp:
        (logAccessibilityEventsCallback): New callback.
        (AccessibilityController::getJSClass): Added new function.
        (AccessibilityController::resetToConsistentState): Initialized
        calling setLogAccessibilityEvents(false).

        Provided implementation for the GTK port.

        * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
        (accessibility_event_listener): Common listener for logging
        information about all the signals emitted by any AtkObject.
        (AccessibilityController::setLogAccessibilityEvents): Add or
        remove listeners for signals, as specified by the parameter.

        Provide dummy implementations for mac and win ports.

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::setLogAccessibilityEvents):
        * DumpRenderTree/win/AccessibilityControllerWin.cpp:
        (AccessibilityController::setLogAccessibilityEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 10 Feb 2011 09:00:40 +0000 (09:00 +0000)]
2011-02-10  Shinichiro Hamaji  <hamaji@chromium.org>

        Chromium expectations update.

        fast/box-shadow/shadow-buffer-partial.html is failing.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 10 Feb 2011 08:09:30 +0000 (08:09 +0000)]
2011-02-09  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Kent Tamura.

        Skip newly added test that depends on unimplemented DRT functionality
        https://bugs.webkit.org/show_bug.cgi?id=54172

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8805364> Malloc zone enumeration code should be safe in the face...
mrowe@apple.com [Thu, 10 Feb 2011 07:13:19 +0000 (07:13 +0000)]
<rdar://problem/8805364> Malloc zone enumeration code should be safe in the face of errors from the memory reader.

Reviewed by Sam Weinig.

* wtf/FastMalloc.cpp:
(WTF::PageHeapAllocator::recordAdministrativeRegions): Use the new helper function to walk the linked list safely.
(WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMallocStats::PageMapFreeObjectFinder::visit): Bail out if the span could not be read.
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit): Ditto.
* wtf/MallocZoneSupport.h:
(WTF::RemoteMemoryReader::operator()): Remove an assert that is not valid.
(WTF::RemoteMemoryReader::nextEntryInLinkedList): Add a helper function for retrieving the next entry in
a linked list. It maps a failed read of the remote memory in to a null pointer, which all callers can
handle gracefully.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Thu, 10 Feb 2011 05:31:16 +0000 (05:31 +0000)]
2011-02-09  Hayato Ito  <hayato@chromium.org>

        Reviewed by Tony Chang.

        [NRWT] Remove encoding parameters where we can assume data can be
        written in binary mode.

        https://bugs.webkit.org/show_bug.cgi?id=54066

        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 54164 - Optimize global_var accesses on JSVALUE64
barraclough@apple.com [Thu, 10 Feb 2011 05:21:33 +0000 (05:21 +0000)]
Bug 54164 - Optimize global_var accesses on JSVALUE64

Reviewed by Sam Weinig.

Directly embed the pointer to d->registers, optimize out the load
from the variable object, as we do already in JSVALUE32_64.

This is a ~1.5% win on sunspidey.

* jit/JIT.cpp:
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 10 Feb 2011 05:15:48 +0000 (05:15 +0000)]
2011-02-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r77101) box-shadow sometimes renders incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=54160

        Fix an issue when ShadowBlur had a cached image buffer
        that was larger than that of the current shadow being drawn,
        and the current shadow was partially clipped out.

        In that situation endShadowLayer() would clip to the image
        buffer, using the size of the buffer (as it must), but failed
        to take into account the fact that we'd only cleared and painted
        into a smaller section of the buffer. So we need to additionally
        constrain the clip to cover only the valid part of the buffer.

        Test: fast/box-shadow/shadow-buffer-partial.html

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::endShadowLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 10 Feb 2011 03:37:39 +0000 (03:37 +0000)]
2011-02-09  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; removed Windows port's expected result for r78104.

        * platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8977051> CrashTracer: 8 crashes
bdakin@apple.com [Thu, 10 Feb 2011 03:07:29 +0000 (03:07 +0000)]
Fix for <rdar://problem/8977051> CrashTracer: 8 crashes
in WebProcess at com.apple.WebCore:
-[ScrollbarPartAnimation setCurrentProgress:] + 364

Reviewed by Maciej Stachowiak.

The ScrollbarPartAnimation must be sent by reference!
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed up ChangeLog after my last commit
ggaren@apple.com [Thu, 10 Feb 2011 02:21:51 +0000 (02:21 +0000)]
Fixed up ChangeLog after my last commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Adam Barth <abarth@webkit.org>
ggaren@apple.com [Thu, 10 Feb 2011 02:20:04 +0000 (02:20 +0000)]
2011-02-09  Adam Barth  <abarth@webkit.org>

        Another attempt to fix the Qt Windows build.

        * config.h:
        * wtf/OSRandomSource.cpp:
        (WTF::randomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 10 Feb 2011 02:14:49 +0000 (02:14 +0000)]
2011-02-09  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
        https://bugs.webkit.org/show_bug.cgi?id=54053

        The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
        RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
        the position variable "s" is not null.

        Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
        and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.

        Test: fast/forms/file-input-hit-test.html

        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::toNormalizedRange):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::positionForPoint):
        * rendering/RenderFileUploadControl.h:
2011-02-09  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
        https://bugs.webkit.org/show_bug.cgi?id=54053

        Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
        upload control.

        * fast/forms/file-input-hit-test-expected.txt: Added.
        * fast/forms/file-input-hit-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOverlay scrollbars crash used with a RenderListBox.
weinig@apple.com [Thu, 10 Feb 2011 01:55:52 +0000 (01:55 +0000)]
Overlay scrollbars crash used with a RenderListBox.

Reviewed by Beth Dakin.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):
(WebCore::RenderListBox::setHasVerticalScrollbar):
* rendering/RenderListBox.h:
Implement enough of the ScrollableArea interface to get things generally
working.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a typo in WebSecurityOrigin::protocol.
bweinstein@apple.com [Thu, 10 Feb 2011 01:28:36 +0000 (01:28 +0000)]
Fix a typo in WebSecurityOrigin::protocol.

Rubber-stamped by Sam Weinig.

* Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::protocol): This should return the protocol, not the domain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 01:26:54 +0000 (01:26 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFile uploads do not work within the sandbox
weinig@apple.com [Thu, 10 Feb 2011 01:17:35 +0000 (01:17 +0000)]
File uploads do not work within the sandbox
<rdar://problem/8950518>
https://bugs.webkit.org/show_bug.cgi?id=54154

Reviewed by Darin Adler.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::extendSandboxForFileFromOpenPanel):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8966868> ScrollbarPainterDelegate
bdakin@apple.com [Thu, 10 Feb 2011 00:28:50 +0000 (00:28 +0000)]
Fix for <rdar://problem/8966868> ScrollbarPainterDelegate
must return a layer if layer-backed to avoid crashing

Reviewed by Simon Fraser.

New virtual function scrollbarWillRenderIntoCompositingLayer()
on ScrollableArea.
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarWillRenderIntoCompositingLayer):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollbarWillRenderIntoCompositingLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollbarWillRenderIntoCompositingLayer):
* rendering/RenderListBox.h:

Clean up unnecessary method declarations and call
scrollbarWillRenderIntoCompositingLayer() to deterine if
we need to return a layer.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate layer]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 10 Feb 2011 00:24:58 +0000 (00:24 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=54148
        <rdar://problem/8973887> REGRESSION (WebKit2): Opening two print dialogs causes havoc

        * UIProcess/API/mac/WKPrintingView.h: Moved _isForcingPreviewUpdate into a static variable,
        because dispatching a notification affects all WKPrintingViews at once.
        * UIProcess/API/mac/WKPrintingView.mm:
        (-[WKPrintingView _updatePreview]): Updated for new variable name.
        (-[WKPrintingView knowsPageRange:]): Don't break if the method is called twice in a row
        (we already had this logic when printing from separate thread, but not for preview).
        (-[WKPrintingView drawRect:]): Changed all LOG messages to have view object address for
        easier matching.
        (-[WKPrintingView rectForPage:]): Ditto.
        (-[WKPrintingView beginDocument]): Ditto.
        (-[WKPrintingView endDocument]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Feb 2011 00:24:28 +0000 (00:24 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline a few tests which differ on the bots. Skip a test which is
        timing out intermittently.

        * platform/gtk/Skipped: Skip a test timing out.
        * platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
        * platform/gtk/fast/dom/52776-expected.txt:
        * platform/gtk/fast/text/stroking-decorations-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 10 Feb 2011 00:09:34 +0000 (00:09 +0000)]
2011-02-09  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt multiprocessing: minor cleanup prior to implementing the new worker

        This patch renames AbstractManager to ManagerConnection and
        changes some argument names to be more consistent between
        manager_worker_broker and message_broker. It also fixes a couple
        of typos in message_broker. These changes will be tested by code
        introduced in the next patch.

        https://bugs.webkit.org/show_bug.cgi?id=54067

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Feb 2011 23:53:43 +0000 (23:53 +0000)]
2011-02-09  Adam Barth  <abarth@webkit.org>

        Another attempt to fix the Qt Windows build.

        * config.h:
        * wtf/OSRandomSource.cpp:
        (WTF::randomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 9 Feb 2011 23:47:01 +0000 (23:47 +0000)]
2011-02-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Repro crash with Sony Google TV ad at Gizmodo
        https://bugs.webkit.org/show_bug.cgi?id=54150

        Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::~PluginView):
        Null out m_pluginElement here so we'll catch crashes earlier.

        (WebKit::PluginView::evaluate):
        Add a plug-in protector.
2011-02-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Repro crash with Sony Google TV ad at Gizmodo
        https://bugs.webkit.org/show_bug.cgi?id=54150
        <rdar://problem/8782346>

        Add test.

        * plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Added.
        * plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Added.
2011-02-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Repro crash with Sony Google TV ad at Gizmodo
        https://bugs.webkit.org/show_bug.cgi?id=54150
        <rdar://problem/8782346>

        Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added.
        (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream):
        (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy):
        (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Feb 2011 23:35:48 +0000 (23:35 +0000)]
2011-02-09  Adam Barth  <abarth@webkit.org>

        Attempt to fix the Qt Windows build.

        * wtf/OSRandomSource.cpp:
        (WTF::randomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 23:25:16 +0000 (23:25 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Clean up the skipped list a bit and unskip a few tests which are passing.

        * platform/gtk/Skipped: Clean up the skipped list.
        * platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
        * platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Wed, 9 Feb 2011 23:13:27 +0000 (23:13 +0000)]
2011-02-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        Replace static_cast<HTMLElement*> with toHTMLElement
        https://bugs.webkit.org/show_bug.cgi?id=54117

        No new tests since no new functionality was introduced.

        * accessibility/AccessibilityListBox.cpp:
        (WebCore::AccessibilityListBox::addChildren):
        * accessibility/AccessibilityMenuListPopup.cpp:
        (WebCore::AccessibilityMenuListPopup::addChildren):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::accessibleNameForNode):
        (WebCore::AccessibilityRenderObject::accessibilityDescription):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_name):
        (webkit_accessible_get_description):
        * bindings/gobject/WebKitDOMBinding.cpp:
        (WebKit::createWrapper):
        (WebKit::kit):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::toJSNewlyCreated):
        * bindings/js/JSHTMLFrameSetElementCustom.cpp:
        (WebCore::JSHTMLFrameSetElement::nameGetter):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapperInline):
        * bindings/v8/custom/V8ElementCustom.cpp:
        (WebCore::toV8):
        * dom/Document.cpp:
        (WebCore::Document::body):
        * dom/Element.cpp:
        (WebCore::Element::deprecatedCreateContextualFragment):
        * dom/Range.cpp:
        (WebCore::Range::createContextualFragment):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
        (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
        (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
        (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
        (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::shouldSplitTextElement):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        * editing/DeleteButtonController.cpp:
        (WebCore::enclosingDeletableElement):
        (WebCore::DeleteButtonController::show):
        * editing/Editor.cpp:
        (WebCore::Editor::setBaseWritingDirection):
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::mergeWithNeighboringLists):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
        (WebCore::ReplaceSelectionCommand::handleStyleSpans):
        (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
        * editing/SelectionController.cpp:
        (WebCore::scanForForm):
        (WebCore::SelectionController::currentForm):
        * editing/htmlediting.cpp:
        (WebCore::enclosingList):
        (WebCore::enclosingListChild):
        (WebCore::embeddedSublist):
        (WebCore::appendedSublist):
        * editing/markup.cpp:
        (WebCore::StyledMarkupAccumulator::appendElement):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::checkForNameMatch):
        (WebCore::HTMLCollection::updateNameCache):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setOuterHTML):
        (WebCore::HTMLElement::shadowAncestorOwnerForm):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formElementIndex):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setOption):
        (WebCore::HTMLSelectElement::setLength):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getOuterHTML):
        (WebCore::InspectorDOMAgent::setOuterHTML):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseMoveEvent):
        * rendering/RenderMeter.cpp:
        (WebCore::RenderMeter::createPart):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createSubtreeIfNeeded):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Feb 2011 23:11:56 +0000 (23:11 +0000)]
2011-02-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add WTF::cryptographicallyRandomNumber
        https://bugs.webkit.org/show_bug.cgi?id=54083

        Introduce a cryptographically strong random number generator to WTF.
        The random number generator is based on arc4random as found in:

        http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/crypt/arc4random.c?rev=1.22

        I've changed to source to WebKit style and abstracted the operating
        system interaction to OSRandomSource.  We'll use this functionality to
        expose a cryptographically strong random number generator to
        JavaScript.

        * Android.mk:
        * Android.v8.wtf.mk:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * config.h:
        * wtf/CMakeLists.txt:
        * wtf/CryptographicallyRandomNumber.cpp: Added.
        (WTF::initMutexIfNeeded):
        (WTF::init):
        (WTF::addRandomData):
        (WTF::stir):
        (WTF::stirIfNeeded):
        (WTF::getByte):
        (WTF::getWord):
        (WTF::cryptographicallyRandomNumber):
        (WTF::cryptographicallyRandomValues):
        * wtf/CryptographicallyRandomNumber.h: Added.
        * wtf/OSRandomSource.cpp: Added.
        (WTF::randomValuesFromOS):
        * wtf/OSRandomSource.h: Added.
        * wtf/wtf.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Mike Reed <reed@google.com>
commit-queue@webkit.org [Wed, 9 Feb 2011 23:10:31 +0000 (23:10 +0000)]
2011-02-09  Mike Reed  <reed@google.com>

        Reviewed by Kenneth Russell.

        Use Skia's device->readPixels() when its bitmap claims to have no pixels, as this
        handles the case when the device is backed by the GPU.
        Patch developed by bsalomon@google.com

        No new tests. Existing canvas tests suffice
        e.g. LayoutTests/canvas/philip/...

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::getImageData):
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::putImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Feb 2011 23:07:45 +0000 (23:07 +0000)]
2011-02-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        document.close shouldn't affect non-script-created parsers
        https://bugs.webkit.org/show_bug.cgi?id=53689

        Tests for various cases involving document.open/write/close.  Not all
        of them are related to this patch, but they were helpful to me in
        working through this patch, so I've added them in case they're useful
        in the future.

        * fast/frames/document-write-in-iframe-onload-3-expected.txt: Added.
        * fast/frames/document-write-in-iframe-onload-3.html: Added.
        * fast/parser/iframe-onload-document-close-with-external-script-2-expected.txt: Added.
        * fast/parser/iframe-onload-document-close-with-external-script-2.html: Added.
        * fast/parser/iframe-onload-document-close-with-external-script-3-expected.txt: Added.
        * fast/parser/iframe-onload-document-close-with-external-script-3.html: Added.
        * fast/parser/iframe-onload-document-close-with-external-script-expected.txt: Added.
        * fast/parser/iframe-onload-document-close-with-external-script.html: Added.
        * fast/parser/setTimeout-open-expected.txt: Added.
        * fast/parser/setTimeout-open.html: Added.
2011-02-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        document.close shouldn't affect non-script-created parsers
        https://bugs.webkit.org/show_bug.cgi?id=53689

        Tests: fast/frames/document-write-in-iframe-onload-3.html
               fast/parser/iframe-onload-document-close-with-external-script-2.html
               fast/parser/iframe-onload-document-close-with-external-script-3.html
               fast/parser/iframe-onload-document-close-with-external-script.html
               fast/parser/setTimeout-open.html

        Move our implementation of document.close closer to the spec by
        introducing the notion of a script-created parser.  This area of our
        code is somewhat hairy.  It might take a few more iterations before we
        fully come up to spec.

        * dom/Document.cpp:
        (WebCore::Document::setContent):
        (WebCore::Document::open):
        (WebCore::Document::cancelParsing):
        (WebCore::Document::close):
            - Over time, this method should converge to the spec.
        (WebCore::Document::explicitClose):
            - I'm not in love with this name.  Somehow we want to differentiate
              between Document closing itself and the document.close DOM
              method.
        (WebCore::Document::removePendingSheet):
        * dom/Document.h:
        * dom/ScriptableDocumentParser.cpp:
        (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
        * dom/ScriptableDocumentParser.h:
        (WebCore::ScriptableDocumentParser::setWasCreatedByScript):
        (WebCore::ScriptableDocumentParser::wasCreatedByScript):
            - General nonsense to keep track of whether the parser was created
              by script.
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::hasInsertionPoint):
            - I'm not sure whether this part of the change is 100% correct.  I
              think our notion of the EOF character might be subtly different
              from the notion in the spec.
        * html/parser/HTMLInputStream.h:
        (WebCore::HTMLInputStream::hasInsertionPoint):
            - Remove FIXME because we're fixing that!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 23:03:19 +0000 (23:03 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Import the last set of GTK+ baselines in the fast directory.

        * platform/gtk/Skipped: Unskip test which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGoogle Maps says it has horizontal scrollbars when it doesn't
weinig@apple.com [Wed, 9 Feb 2011 23:02:47 +0000 (23:02 +0000)]
Google Maps says it has horizontal scrollbars when it doesn't
<rdar://problem/8978005>

Reviewed by Maciej Stachowiak.

We were updating the main frame's scrollbar state for changes to
frames other than the main frame.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::WebChromeClient):
Change to bail out early if we are not looking at the main frame. Also
fix some silly typos and rename the variables to be more specific.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 David Holloway <dhollowa@chromium.org>
commit-queue@webkit.org [Wed, 9 Feb 2011 22:53:22 +0000 (22:53 +0000)]
2011-02-09  David Holloway  <dhollowa@chromium.org>

        Reviewed by Darin Fisher.

        Removes deprecated interface WebAutoFillClient::didAcceptAutocompleteSuggestion().  This interface has been replaced by the more general WebAutoFillClient::didAcceptAutoFillSuggestion() method.
        https://bugs.webkit.org/show_bug.cgi?id=54125

        * public/WebAutoFillClient.h:
        * src/EditorClientImpl.cpp:
        * src/EditorClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 9 Feb 2011 22:41:06 +0000 (22:41 +0000)]
2011-02-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        [Chromium] Issue 72387: Integer bounds crash in LayerTilerChromium::resizeLayer
        https://bugs.webkit.org/show_bug.cgi?id=54132

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::resizeLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 22:40:38 +0000 (22:40 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Continue importing new GTK+ results for tests in the fast directory.

        * platform/gtk/Skipped: Unskip test which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Wed, 9 Feb 2011 22:36:22 +0000 (22:36 +0000)]
2011-02-09  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Darin Fisher.

        Export WebInputElement::defaultMaxLength as a function rather than a constant.
        Needed because the order of initialization of static constants
        is not guaranteed across compilation units.
        https://bugs.webkit.org/show_bug.cgi?id=54056

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::defaultMaxLength): Now a static function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Wed, 9 Feb 2011 22:25:07 +0000 (22:25 +0000)]
Unreviewed.

Remove unnecessary Qt specific expected results after r78104.

* platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Removed.
* platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Removed.
* platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Xiyuan Xia <xiyuan@chromium.org>
commit-queue@webkit.org [Wed, 9 Feb 2011 22:23:44 +0000 (22:23 +0000)]
2011-02-09  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Use #f7f7f7 for select popup background on chromium/linux
        https://bugs.webkit.org/show_bug.cgi?id=54115

        No new tests since no behavior change.

        * css/themeChromiumLinux.css:
        (select[size="1"] option):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 9 Feb 2011 22:16:44 +0000 (22:16 +0000)]
2011-02-09  Robert Hogan  <robert@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] REGRESSION (r73535): tst_QWebPage fails
        https://bugs.webkit.org/show_bug.cgi?id=51331

        Since r73535 a ContextMenu is only created when a context menu
        event is received, so QWebPage::updatePositionDependentActions()
        can't depend on one being there if it is called directly by
        the client. QtWebKit itself only ever calls updatePositionDependentActions()
        when a context menu event has been received.

        Update tst_QWebPage:contextMenuCrash to create a context menu.
        Add tst_QWebPage:updatePositionDependentActionsCrash to test for this crash.

        There doesn't seem to be a good reason for creating a context menu if
        clients call QWebPage::updatePositionDependentActions() when no
        context menu event has ever been received.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::createContextMenu):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::contextMenuCrash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 22:13:34 +0000 (22:13 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 22:04:39 +0000 (22:04 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 22:02:14 +0000 (22:02 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Continue importing new GTK+ results for tests in the fast directory.

        * platform/gtk/Skipped: Unskip test which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Feb 2011 21:53:57 +0000 (21:53 +0000)]
2011-02-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console
        https://bugs.webkit.org/show_bug.cgi?id=41187

        Wire up a basic HTML parse error message.  There's a lot of room for
        improvement in this area, but this is a start.

        No tests!  See https://bugs.webkit.org/show_bug.cgi?id=54134

        * html/parser/HTMLDocumentParser.h:
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::parseError):
        * html/parser/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Ivan Krstić <ike@apple.com>
ike@apple.com [Wed, 9 Feb 2011 21:36:15 +0000 (21:36 +0000)]
2011-02-09  Ivan Krstić  <ike@apple.com>

        Reviewed by Sam Weinig.

        Allow read-only access to mouse preferences from sandboxed WebProcess.
        <rdar://problem/8975279>

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 21:23:11 +0000 (21:23 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 21:15:16 +0000 (21:15 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Continue importing new GTK+ results for tests in the fast directory.
        Skip some tests that are obvious failures.

        * platform/gtk/Skipped: Unskip test with results. Classify failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
sfalken@apple.com [Wed, 9 Feb 2011 20:59:59 +0000 (20:59 +0000)]
Build fix.

* win/MainWin.cpp:
(wWinMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 20:50:15 +0000 (20:50 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
        * platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png: Added.
        * platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
        * platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png: Added.
        * platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the build.
ggaren@apple.com [Wed, 9 Feb 2011 20:22:37 +0000 (20:22 +0000)]
Try to fix the build.

* wtf/Bitmap.h: Include string.h for memset. Not sure why this started
failing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Feb 2011 20:15:30 +0000 (20:15 +0000)]
2011-02-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Steve Block.

        Move Android.mk into Source
        https://bugs.webkit.org/show_bug.cgi?id=53751

        A somewhat blind attempt to move Android.mk into the Source directory.
        I'm sure I've goofed this up in some way.  The Android folks have
        kindly volunteered to fix this up once they merge past this revision.

        * Android.mk: Removed.
        * Source/Android.mk: Copied from Android.mk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Sailesh Agrawal <sail@chromium.org>
commit-queue@webkit.org [Wed, 9 Feb 2011 20:15:07 +0000 (20:15 +0000)]
2011-02-09  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Tony Chang.

        Search/replace references to gfx/* with ui/gfx/*

        * public/WebPoint.h:
        * public/WebRect.h:
        * public/WebSize.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 9 Feb 2011 20:09:45 +0000 (20:09 +0000)]
2011-02-09  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        A tiny bit of encapsulation for MarkedBlock: made its heap data member private
        https://bugs.webkit.org/show_bug.cgi?id=54129

        * runtime/MarkedBlock.h:
        (JSC::MarkedBlock::isCellAligned):
        (JSC::MarkedBlock::MarkedBlock):
        (JSC::MarkedBlock::heap): Made the heap data member private, and provided
        a constructor and an accessor.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocateBlock):
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::heap): Use the constructor and accessor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Wed, 9 Feb 2011 20:08:45 +0000 (20:08 +0000)]
2011-02-09  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        VisibleSelection::setWithoutValidation() should allow caret selection.
        https://bugs.webkit.org/show_bug.cgi?id=53943

        Fixed the new test introduced in the previous patch for the same bug. Previous test isn't platform independent, and fails on all platforms other than Mac OS X with WebKit 1.

        * editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt:
        * editing/undo/undo-paste-when-caret-is-not-in-range.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Wed, 9 Feb 2011 20:06:32 +0000 (20:06 +0000)]
2011-02-09  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kenneth Russell.

        [Chromium] Issue 58536: Fix Layout Test canvas/philip/tests/2d.imageData.put.alpha.html with --accelerated-2d-canvas.
        https://bugs.webkit.org/show_bug.cgi?id=53757

          This fix is for 2d.imageData.put.alpha.html with --accelerated-2d-canvas. No new tests.

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::putUnmultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software.
        (WebCore::ImageBuffer::putPremultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 9 Feb 2011 20:03:00 +0000 (20:03 +0000)]
2011-02-09  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Fix scaling and thread safety of FFTFrameFFTW
        https://bugs.webkit.org/show_bug.cgi?id=54045

        No new tests since audio API is not yet implemented.

        * platform/audio/FFTFrame.h:
        * platform/audio/fftw/FFTFrameFFTW.cpp:
        (WebCore::FFTFrame::FFTFrame):
        (WebCore::FFTFrame::doFFT):
        (WebCore::FFTFrame::doInverseFFT):
        (WebCore::FFTFrame::initialize):
        (WebCore::FFTFrame::cleanup):
        (WebCore::FFTFrame::realData):
        (WebCore::FFTFrame::imagData):
        (WebCore::FFTFrame::fftwPlanForSize):
        * platform/audio/mac/FFTFrameMac.cpp:
        (WebCore::FFTFrame::initialize):
        * platform/audio/mkl/FFTFrameMKL.cpp:
        (WebCore::FFTFrame::initialize):
        * webaudio/AudioContext.cpp:
        (WebCore::AudioContext::AudioContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 9 Feb 2011 19:54:22 +0000 (19:54 +0000)]
2011-02-09  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style: The error message about NULL should be more clear for comments.
        https://bugs.webkit.org/show_bug.cgi?id=53786

        * Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: accessibilityShouldUseUniqueId doesn't need to be in the core AX object
cfleizach@apple.com [Wed, 9 Feb 2011 19:49:24 +0000 (19:49 +0000)]
AX: accessibilityShouldUseUniqueId doesn't need to be in the core AX object
https://bugs.webkit.org/show_bug.cgi?id=54126

Reviewed by Darin Adler.

This is a Mac-only accessibility API concept and doesn't belong in the core AX object.

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::node):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 19:48:26 +0000 (19:48 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Continue importing new GTK+ results for tests in the fast directory.
        Skip some tests that are obvious failures.

        * platform/gtk/Skipped: Unskip some tests that now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Nebojsa Ciric <cira@chromium.org>
commit-queue@webkit.org [Wed, 9 Feb 2011 19:43:37 +0000 (19:43 +0000)]
2011-02-09  Nebojsa Ciric  <cira@chromium.org>

        Reviewed by Darin Fisher.

        Implements Locale object of JavaScript internationalization API proposal, as an
        v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
        and in this patch we just provide flags, tests and build rules for chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=49414

        * fast/js/i18n-bindings-locale-expected.txt: Added.
        * fast/js/i18n-bindings-locale.html: Added.
        * fast/js/script-tests/i18n-bindings-locale.js: Added.
        (reportResult):
        (localeTests.this.defaultLocale):
        (localeTests.this.baseLocale):
        (localeTests.this.languageScriptLocale):
        (localeTests.this.languageScriptRegionLocale):
        (localeTests.this.languageScriptRegionExtensionLocale):
        (localeTests.this.languageScriptRegionDashUExtensionLocale):
        (localeTests.this.availableLocales):
        (localeTests.this.maximizedLocale):
        (localeTests.this.maximizedLocaleWithExtension):
        (localeTests.this.minimizedLocale):
        (localeTests.this.minimizedLocaleWithExtension):
        (localeTests.this.displayForBaseLocale):
        (localeTests.this.displayInSameLocale):
        (localeTests.this.displayInDifferentLocale):
        (localeTests.this.displayInCyrillicScript):
        (localeTests.this.displayInHebrewScript):
        (localeTests):
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-02-09  Nebojsa Ciric  <cira@chromium.org>

        Reviewed by Darin Fisher.

        Implements Locale object of JavaScript internationalization API proposal, as an
        v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
        and in this patch we just provide flags, tests and build rules for chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=49414

        Test: fast/js/i18n-bindings-locale.html

        * WebCore.gyp/WebCore.gyp:
        * bindings/generic/RuntimeEnabledFeatures.cpp:
        (WebCore::RuntimeEnabledFeatures::experimentalI18NAPIEnabled):
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::setExperimentalI18NAPIEnabled):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::createNewContext):
2011-02-09  Nebojsa Ciric  <cira@chromium.org>

        Reviewed by Darin Fisher.

        Implements Locale object of JavaScript internationalization API proposal, as an
        v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
        and in this patch we just provide flags, tests and build rules for chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=49414

        * features.gypi:
        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableExperimentalI18NAPI):
        (WebKit::WebRuntimeFeatures::isExperimentalI18NAPIEnabled):
2011-02-09  Nebojsa Ciric  <cira@chromium.org>

        Reviewed by Darin Fisher.

        Implements Locale object of JavaScript internationalization API proposal, as an
        v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
        and in this patch we just provide flags, tests and build rules for chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=49414

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 19:35:58 +0000 (19:35 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, fix a bug in test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 9 Feb 2011 19:23:06 +0000 (19:23 +0000)]
2011-02-09  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        Rebaseline for chromium-mac after r77952.
        Added chromium-mac baseline due to fallback sequence.

        * platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 19:19:09 +0000 (19:19 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Wed, 9 Feb 2011 19:06:20 +0000 (19:06 +0000)]
2011-02-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Martin Robinson.

        frames/flattening/iframe-flattening-crash.html fails on GTK.
        https://bugs.webkit.org/show_bug.cgi?id=54106

        Modify the test to be more consistent with other frame flattening tests.

        * fast/frames/flattening/iframe-flattening-crash.html:
        * fast/frames/flattening/resources/iframe-flattening-crash.html: Removed.
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd failing Windows expected results for tests that were added recently and have...
bweinstein@apple.com [Wed, 9 Feb 2011 18:50:46 +0000 (18:50 +0000)]
Add failing Windows expected results for tests that were added recently and have failed since
they were added.

https://bugs.webkit.org/show_bug.cgi?id=54120 tracks editing/undo/undo-paste-when-caret-is-not-in-range.html
https://bugs.webkit.org/show_bug.cgi?id=54122 tracks plugins/invalidate_rect.html

* platform/win/editing/undo: Added.
* platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
* platform/win/plugins/invalidate_rect-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 18:41:54 +0000 (18:41 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 18:38:37 +0000 (18:38 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Add more results for many tests in the fast directory missing results.

        * platform/gtk/Skipped: Unskip more tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 9 Feb 2011 18:03:38 +0000 (18:03 +0000)]
2011-02-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
        https://bugs.webkit.org/show_bug.cgi?id=52065

        * fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.
2011-02-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
        https://bugs.webkit.org/show_bug.cgi?id=52065

        * dom/Node.cpp:
        (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost
            boundary of shadow DOM.
        (WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 18:03:03 +0000 (18:03 +0000)]
2011-02-09  Martin Robinson  <mrobinson@igalia.com>

        Add more results for many tests in the fast directory missing results.

        * platform/gtk/Skipped: Unskip tests that now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 18:00:30 +0000 (18:00 +0000)]
2011-02-09  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla ...
alex@webkit.org [Wed, 9 Feb 2011 17:52:04 +0000 (17:52 +0000)]
2011-02-09  Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>

        Reviewed by Martin Robinson.

        [GTK] Implement Module class for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=48510

        * GNUmakefile.am:
        * Platform/Module.h: Added GModule handle for GTK port.
        * Platform/gtk/ModuleGtk.cpp: Initial code using GModule calls.
        (WebKit::Module::load):
        (WebKit::Module::unload):
        (WebKit::Module::platformFunctionPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78074 268f45cc-cd09-0410-ab3c-d52691b4dbfc