WebKit-https.git
9 years ago2011-01-14 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 15 Jan 2011 01:22:58 +0000 (01:22 +0000)]
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
        https://bugs.webkit.org/show_bug.cgi?id=52493

        Add a few tests for continue to cover the cases where continue
        isn't syntactically valid.

        * fast/js/js-continue-break-restrictions-expected.txt: Added.
        * fast/js/js-continue-break-restrictions.html: Added.
        * fast/js/script-tests/js-continue-break-restrictions.js: Added.
2011-01-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
        https://bugs.webkit.org/show_bug.cgi?id=52493

        This patch reworks handling of break, continue and label statements
        to correctly handle all the valid and invalid cases.  Previously certain
        errors would be missed by the parser in strict mode, but the bytecode
        generator needed to handle those cases for non-strict code so nothing
        failed, it simply became non-standard behaviour.

        Now that we treat break and continue errors as early faults in non-strict
        mode as well that safety net has been removed so the parser bugs result in
        crashes at codegen time.

        * parser/JSParser.cpp:
        (JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo):
        (JSC::JSParser::next):
        (JSC::JSParser::nextTokenIsColon):
        (JSC::JSParser::continueIsValid):
            Continue is only valid in loops so we can't use breakIsValid()
        (JSC::JSParser::pushLabel):
            We now track whether the label is for a loop (and is therefore a
            valid target for continue.
        (JSC::JSParser::popLabel):
        (JSC::JSParser::getLabel):
            Replace hasLabel with getLabel so that we can validate the target
            when parsing continue statements.
        (JSC::JSParser::Scope::continueIsValid):
        (JSC::JSParser::Scope::pushLabel):
        (JSC::JSParser::Scope::getLabel):
        (JSC::JSParser::JSParser):
        (JSC::JSParser::parseBreakStatement):
        (JSC::JSParser::parseContinueStatement):
        (JSC::LabelInfo::LabelInfo):
        (JSC::JSParser::parseExpressionOrLabelStatement):
            Consecutive labels now get handled iteratively so that we can determine
            whether they're valid targets for continue.
        * parser/Lexer.cpp:
        (JSC::Lexer::nextTokenIsColon):
        * parser/Lexer.h:
        (JSC::Lexer::setOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidat...
mitz@apple.com [Sat, 15 Jan 2011 01:20:45 +0000 (01:20 +0000)]
Source/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]

Reviewed by Simon Fraser.

* WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
RenderWidget::resumeWidgetHierarchyUpdates().
* manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
are disabled. When this assertion was added, this condition was a subset of the “calling out to
plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
change now suspends widget hierarchy updates even at times where plug-in code is expected to be
called, which invalidates the assertion.

WebKit/mac: WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]

Reviewed by Simon Fraser.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
that the NSView tree doesn’t change from under AppKit as it traverses it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ahmad Sharif <asharif.tools@gmail.com>
commit-queue@webkit.org [Sat, 15 Jan 2011 01:19:57 +0000 (01:19 +0000)]
2011-01-14  Ahmad Sharif  <asharif.tools@gmail.com>

        Reviewed by Darin Fisher.

        When inlining is performed, the progress variable is
        declared as uninitialized.
        https://bugs.webkit.org/show_bug.cgi?id=51084

        * WebCore: Copied from WebCore.
        * WebCore/page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::animate):
        (WebCore::KeyframeAnimation::getAnimatedStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 15 Jan 2011 01:18:58 +0000 (01:18 +0000)]
2011-01-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=52499

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::shouldPaintBoundsRect):
        Port code from -[WebView _mustDrawUnionedRect:singleRects:count:].

        (WebKit::DrawingAreaImpl::display):
        If shouldPaintBoundsRect returns true, clear the rects vector and append the bounds rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 01:17:16 +0000 (01:17 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * rendering/style/StyleRareInheritedData.cpp:
        * rendering/style/StyleRareNonInheritedData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Sat, 15 Jan 2011 01:15:05 +0000 (01:15 +0000)]
2011-01-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix expanded lines in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52498

        Fixes them to work now that we have wrapper divs.
        Also fixes the long-standing bug that the line numbers
        were incorrect sometimes.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 01:08:11 +0000 (01:08 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * rendering/style/RenderStyle.cpp:
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * ewk/ewk_view.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Sat, 15 Jan 2011 01:02:18 +0000 (01:02 +0000)]
2011-01-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        put remove lines to the left of add lines in sidebyside view
        https://bugs.webkit.org/show_bug.cgi?id=52458

        Also, sneaking in a fix to make long lines with no whitespace wrap.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 01:00:21 +0000 (01:00 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * editing/EditorCommand.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 00:55:15 +0000 (00:55 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * editing/ApplyStyleCommand.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 00:44:33 +0000 (00:44 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 15 Jan 2011 00:42:13 +0000 (00:42 +0000)]
2011-01-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        Fix a few things in the WebKit2 skipped list
        https://bugs.webkit.org/show_bug.cgi?id=52484

        * platform/mac-wk2/Skipped: Add/remove some tests to the WK2 skipped list.
        * editing/style/stylewithcss-without-selection.html: Fix this test to avoid
        referencing an undefined variable in the failure case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 00:35:26 +0000 (00:35 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Fix Qt build after r75837
        https://bugs.webkit.org/show_bug.cgi?id=52494

        * rendering/InlineFlowBox.h:
        * rendering/RenderBoxModelObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 15 Jan 2011 00:29:29 +0000 (00:29 +0000)]
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
        https://bugs.webkit.org/show_bug.cgi?id=45186

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::scheduleScavenger): Added missing this pointer to CreateTimerQueueTimer().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 15 Jan 2011 00:28:51 +0000 (00:28 +0000)]
2011-01-14  Mihai Parparita  <mihaip@chromium.org>

        Update the svg/ pixel expectations for the chromium-mac port.

        For the pixel tests that currently fail on Snow Leopard, this moves the
        current pixel results to platform/chromium-mac-leopard and adds new
        results to platform/chromium-mac.

        List of files omitted due to length but composed entirely of moves from
        platform/chromium-mac to platform/chromium-mac-leopard and newly added
        files in platform/chromium-mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 15 Jan 2011 00:27:07 +0000 (00:27 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by David Levin.

        Do some forward declaration in RenderStyle.h
        https://bugs.webkit.org/show_bug.cgi?id=52453

        No new tests because no new functionality.

        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSStyleSelector.cpp:
        * editing/Editor.cpp:
        * page/EventHandler.cpp:
        * rendering/EllipsisBox.cpp:
        * rendering/InlineBox.cpp:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderEmbeddedObject.cpp:
        * rendering/RenderFieldset.cpp:
        * rendering/RenderFileUploadControl.cpp:
        * rendering/RenderFrameSet.cpp:
        * rendering/RenderHTMLCanvas.cpp:
        * rendering/RenderImageResource.cpp:
        * rendering/RenderInputSpeech.cpp:
        * rendering/RenderLayer.h:
        * rendering/RenderLineBoxList.cpp:
        * rendering/RenderListBox.cpp:
        * rendering/RenderMediaControlsChromium.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderObjectChildList.cpp:
        * rendering/RenderProgress.cpp:
        * rendering/RenderScrollbarPart.cpp:
        * rendering/RenderTable.cpp:
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableRow.cpp:
        * rendering/RenderTableSection.cpp:
        * rendering/RenderTheme.cpp:
        * rendering/RenderThemeChromiumSkia.cpp:
        * rendering/RenderThemeChromiumWin.cpp:
        * rendering/RootInlineBox.cpp:
        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:
        * rendering/style/StyleRareInheritedData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Sat, 15 Jan 2011 00:19:27 +0000 (00:19 +0000)]
2011-01-14  Jochen Eisinger  <jochen@chromium.org>

        Unreviewed, roll chromium deps to r71432.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 15 Jan 2011 00:16:47 +0000 (00:16 +0000)]
2011-01-14  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
        BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52481

        Removed instantiation of legacy editing positions.
        Calls to Position::Position are replaced by calls to Position's convenience functions.

        Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
        they instantiate right positions for text nodes.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::setSelectedTextRange):
        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance):
        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::inputText):
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
        (WebCore::CompositeEditCommand::moveParagraphs):
        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
        (WebCore::CompositeEditCommand::splitTreeToNode):
        * editing/DeleteButtonController.cpp:
        (WebCore::enclosingDeletableElement):
        * editing/htmlediting.h:
        (WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of
        positionBeforeNode for a text node.
        (WebCore::lastPositionInOrAfterNode): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Fri, 14 Jan 2011 23:46:58 +0000 (23:46 +0000)]
2011-01-14  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        Shadow is not drawn when filling a path with a gradient
        https://bugs.webkit.org/show_bug.cgi?id=51982

        This happens in CG and is related to bug 51869, this time to be fixed
        in GraphicsContext::fillPath(const Path& path). We need to draw the
        gradient clipped to the path on a CGLayer first, and then draw the
        layer on the GraphicsContext.

        * fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Added.
        * fast/canvas/canvas-fillPath-gradient-shadow.html: Added.
        * fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Added.
        * platform/chromium/test_expectations.txt: Skipping new test since it fails.
        * platform/qt/Skipped: Ditto.
2011-01-14  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        Shadow is not drawn when filling a path with a gradient
        https://bugs.webkit.org/show_bug.cgi?id=51982

        This happens in CG and is related to bug 51869, this time to be fixed
        in GraphicsContext::fillPath(const Path& path). We need to draw the
        gradient clipped to the path on a CGLayer first, and then draw the
        layer on the GraphicsContext.

        Test: fast/canvas/canvas-fillPath-gradient-shadow.html

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 14 Jan 2011 23:45:17 +0000 (23:45 +0000)]
2011-01-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        Layer syncing should go through the compositor
        https://bugs.webkit.org/show_bug.cgi?id=52486

        Rather than have FrameView go directly to GraphicsLayer to
        sync pending changes, route the call through RenderLayerCompositor.

        Add a FIXME about an existing issue with flushing and subframes.

        No behavior change, so no tests.

        * page/FrameView.cpp:
        (WebCore::FrameView::syncCompositingStateForThisFrame):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::notifySyncRequired):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::scheduleLayerFlush):
        (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
        * rendering/RenderLayerCompositor.h:
        (WebCore::RenderLayerCompositor::notifySyncRequired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 14 Jan 2011 23:37:14 +0000 (23:37 +0000)]
2011-01-14  Ojan Vafai  <ojan@chromium.org>

        Fix bad merge in r75816.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 14 Jan 2011 23:36:39 +0000 (23:36 +0000)]
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
        https://bugs.webkit.org/show_bug.cgi?id=45186

        r75819 accidentally changed the initial state of the scavenge timer.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::initializeScavenger): Changed initial state of m_scavengingSuspended to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/7793902> Artifacts when scrolling
bdakin@apple.com [Fri, 14 Jan 2011 23:35:20 +0000 (23:35 +0000)]
Fix for <rdar://problem/7793902> Artifacts when scrolling
page in Safari while page is loading

Reviewed by Mark Rowe.

Call setDrawsBackground:YES on the scrollView in
dispatchDidFirstLayout() rather than waiting until
frameLoadCompleted(). Also suspend scrolling elasticity
between provisionalLoadStarted() and dispatchDidFirstLayout()
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 14 Jan 2011 23:04:40 +0000 (23:04 +0000)]
2011-01-14  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for the chromium-mac port.

        For the pixel tests that currently fail on Snow Leopard, this moves the
        current pixel results to platform/chromium-mac-leopard and adds new
        results to platform/chromium-mac.

        List of files omitted due to length but composed entirely of moves from
        platform/chromium-mac to platform/chromium-mac-leopard and newly added
        files in platform/chromium-mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 14 Jan 2011 22:57:51 +0000 (22:57 +0000)]
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed Windows Release build fix.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::scavengerTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShouldLoadResourceForFrame should use strings, not URLs.
bweinstein@apple.com [Fri, 14 Jan 2011 22:57:10 +0000 (22:57 +0000)]
ShouldLoadResourceForFrame should use strings, not URLs.
https://bugs.webkit.org/show_bug.cgi?id=52476

Reviewed by Geoff Garen.

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Pass resourceURL as a string instead of
    a URL, and rename from subresourceURL to resourceURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 14 Jan 2011 22:49:09 +0000 (22:49 +0000)]
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed Windows Release build fix.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::scavengerTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Fri, 14 Jan 2011 22:45:22 +0000 (22:45 +0000)]
2011-01-14  Steve Lacey  <sjl@chromium.org>

        Reviewed by Simon Fraser.

        Update media/video-zoom-controls.html to set the video source before initializing the test.
        https://bugs.webkit.org/show_bug.cgi?id=52461

        * media/video-zoom-controls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 14 Jan 2011 22:40:17 +0000 (22:40 +0000)]
2011-01-14  Abhishek Arya  <inferno@chromium.org>

        Reviewed by David Hyatt.

        Fix parent block calculation when trying to find top most node
        containing "this" float.
        https://bugs.webkit.org/show_bug.cgi?id=51711

        Replace use of containingBlock and traverse the parents directly
        to check for float existence. containingBlock can skip parents and
        jump to the RenderView directly which will cause floats to not get
        cleared from intermediate parents.

        Test: fast/block/float/floats-not-cleared-crash.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
2011-01-14  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash due to uncleared floats in parent nodes.
        https://bugs.webkit.org/show_bug.cgi?id=51711

        * fast/block/float/floats-not-cleared-crash-expected.txt: Added.
        * fast/block/float/floats-not-cleared-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8711576> The web process should be able to read resources...
andersca@apple.com [Fri, 14 Jan 2011 22:39:30 +0000 (22:39 +0000)]
Fix for <rdar://problem/8711576> The web process should be able to read resources from the UI process.

Reviewed by Sam Weinig.

Based on a patch by Ivan Krstić. This also makes the NSURLCache path a sandbox parameter.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the uiProcessBundleResourcePath member variable.

* Shared/WebProcessCreationParameters.h:
Add uiProcessBundleResourcePath member variable.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Set the uiProcessBundleResourcePath member variable.

* WebProcess/com.apple.WebProcess.sb:
Allow read-only access to UI_PROCESS_BUNDLE_RESOURCE_DIR and all subdirectories.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
When initializing the sandbox, pass UI_PROCESS_BUNDLE_RESOURCE_DIR.

(WebKit::WebProcess::platformInitializeWebProcess):
Remove the code that would consume a sandbox extension for the url cache path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r75660): compositing/reflections/load-video-in-reflection.html crashes...
jberlin@webkit.org [Fri, 14 Jan 2011 22:32:53 +0000 (22:32 +0000)]
REGRESSION (r75660): compositing/reflections/load-video-in-reflection.html crashes on Windows 7
https://bugs.webkit.org/show_bug.cgi?id=52397

Unskipping tests that no longer fail on Windows 7 Release. Unreviewed.

* platform/win/Skipped:
Un-skip compositing/reflections/load-video-in-reflection.html, which appears to be fixed by
http://trac.webkit.org/changeset/75807

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ericu@chromium.org [me] to the committers file.
ericu@chromium.org [Fri, 14 Jan 2011 22:27:12 +0000 (22:27 +0000)]
Add ericu@chromium.org [me] to the committers file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 14 Jan 2011 22:21:58 +0000 (22:21 +0000)]
2011-01-14  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
        https://bugs.webkit.org/show_bug.cgi?id=45186

        Use CreateTimerQueueTimer() to start periodicScavenge() and stop it with DeleteTimerQueueTimer().

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::initializeScavenger):
        (WTF::TCMalloc_PageHeap::isScavengerSuspended):
        (WTF::TCMalloc_PageHeap::scheduleScavenger):
        (WTF::TCMalloc_PageHeap::rescheduleScavenger):
        (WTF::TCMalloc_PageHeap::suspendScavenger):
        (WTF::scavengerTimerFired):
        (WTF::TCMalloc_PageHeap::periodicScavenge):
        (WTF::TCMalloc_PageHeap::signalScavenger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 14 Jan 2011 22:15:06 +0000 (22:15 +0000)]
2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by David Levin.

        Add Tony Gentilcore as a reviewer
        https://bugs.webkit.org/show_bug.cgi?id=52480

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 14 Jan 2011 22:13:36 +0000 (22:13 +0000)]
2011-01-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        improve line selection with fast drags
        https://bugs.webkit.org/show_bug.cgi?id=52477

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 14 Jan 2011 22:00:55 +0000 (22:00 +0000)]
2011-01-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        tweak line selection in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52462

        -Improve handling of data-comment-base-line code to deal with
        lines that have multiple values.
        -Make it so that if you click on the line immediately above
        a line that has a comment it will add a new comment instead of
        adding lines to the following comment. If the last selected line
        overlaps existing comment lines though they will still get
        added to the existing comment.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Fri, 14 Jan 2011 21:59:45 +0000 (21:59 +0000)]
2011-01-14  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
        https://bugs.webkit.org/show_bug.cgi?id=42237

        Remove Chromium-specific implementation from WebCore.

        No tests added; this refactor should be covered by existing history-exercising tests.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * history/BackForwardListChromium.cpp: Removed.
        * history/BackForwardListImpl.h:
2011-01-14  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
        https://bugs.webkit.org/show_bug.cgi?id=42237

        Replace Chromium-specific BackForwardListClient in WebCore with a Chromium impl
        of the BackForwardList interface.

        * WebKit.gyp:
        * src/BackForwardListChromium.cpp: Copied from WebKit/chromium/src/BackForwardListClientImpl.cpp.
        (WebKit::BackForwardListChromium::create):
        (WebKit::BackForwardListChromium::BackForwardListChromium):
        (WebKit::BackForwardListChromium::~BackForwardListChromium):
        (WebKit::BackForwardListChromium::addItem):
        (WebKit::BackForwardListChromium::goToItem):
        (WebKit::BackForwardListChromium::itemAtIndex):
        (WebKit::BackForwardListChromium::backListCount):
        (WebKit::BackForwardListChromium::forwardListCount):
        (WebKit::BackForwardListChromium::isActive):
        (WebKit::BackForwardListChromium::close):
        * src/BackForwardListChromium.h: Copied from WebKit/chromium/src/BackForwardListClientImpl.h.
        * src/BackForwardListClientImpl.cpp: Removed.
        * src/BackForwardListClientImpl.h: Removed.
        * src/FrameLoaderClientImpl.cpp:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::loadHistoryItem):
        (WebKit::WebFrameImpl::currentHistoryItem):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDelay initializing the sandbox until we get the InitializeWebProcess message.
andersca@apple.com [Fri, 14 Jan 2011 21:51:53 +0000 (21:51 +0000)]
Delay initializing the sandbox until we get the InitializeWebProcess message.

Reviewed by Sam Weinig.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 14 Jan 2011 21:30:09 +0000 (21:30 +0000)]
2011-01-14  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style: _FunctionState should keep track of where the function name starts.
        https://bugs.webkit.org/show_bug.cgi?id=52454

        * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
        _FunctionState and logic for setting it correctly.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Konstantin Tokarev <annulen@yandex.ru>
commit-queue@webkit.org [Fri, 14 Jan 2011 20:43:49 +0000 (20:43 +0000)]
2011-01-14  Konstantin Tokarev  <annulen@yandex.ru>

        Reviewed by Laszlo Gombos.

        [Qt] Fixed compilation when QT_NO_SHORTCUT is defined
        https://bugs.webkit.org/show_bug.cgi?id=52460

        This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt
        configuration.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent): Added QT_NO_SHORTCUT guards

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-12 Satish Sampath <satish@chromium.org>
satish@chromium.org [Fri, 14 Jan 2011 20:39:09 +0000 (20:39 +0000)]
2011-01-12  Satish Sampath  <satish@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix a crash when accessing speech input from script.
        https://bugs.webkit.org/show_bug.cgi?id=52325

        Added a layout test to check enabling/disabling speech input from script.

        * fast/speech/speech-input-scripting-expected.txt: Added.
        * fast/speech/speech-input-scripting.html: Added.
2011-01-12  Satish Sampath  <satish@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix a crash when accessing speech input from script.
        https://bugs.webkit.org/show_bug.cgi?id=52325

        Test: fast/speech/speech-input-scripting.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
        * rendering/RenderTextControlSingleLine.cpp: Remove unused code.
        * rendering/RenderTextControlSingleLine.h:
        * rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after.
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
        (WebCore::InputFieldSpeechButtonElement::detach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 14 Jan 2011 20:35:01 +0000 (20:35 +0000)]
2011-01-14  Abhishek Arya  <inferno@chromium.org>

        Reviewed by David Hyatt.

        Prevent merging of anonymous blocks if one of them is already getting
        destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52402

        Test: fast/block/merge-anonymous-block-remove-child-crash2.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false.
        (WebCore::RenderBlock::destroy): set m_beingDestroyed to true.
        (WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed.
        (WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.
2011-01-14  Abhishek Arya  <inferno@chromium.org>

        Reviewed by David Hyatt.

        Tests that we do not crash when trying to merge anonymous blocks, one of which
        is already getting destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52402

        * fast/block/merge-anonymous-block-remove-child-crash2-expected.txt: Added.
        * fast/block/merge-anonymous-block-remove-child-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 14 Jan 2011 20:30:45 +0000 (20:30 +0000)]
2011-01-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Roben.

        fix bugs going back and forth between unified and sidebyside
        https://bugs.webkit.org/show_bug.cgi?id=52470

        Now that we're appending DOM nodes directly, we only want to
        get the first ".text" element in the subtree. In the cases
        where there are multiple, their contents are the same.

        Also, when making side-by-side expansion lines, we need to
        clone the contents so we have a second copy to append to the DOM.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 14 Jan 2011 20:27:53 +0000 (20:27 +0000)]
2011-01-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Follow up to r75791: fix missing dispatch.
        https://bugs.webkit.org/show_bug.cgi?id=52442

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 14 Jan 2011 20:01:24 +0000 (20:01 +0000)]
2011-01-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        Issues with contentsScale in GraphicsLayerCA
        https://bugs.webkit.org/show_bug.cgi?id=52463

        Fix various issues with the recent contentsScale changes:

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1.
        (WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay()
        if the layer draws content, otherwise we'll create backing store for empty layers.
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale
        on the new (tiled or untiled) layer.
        (WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 14 Jan 2011 19:50:47 +0000 (19:50 +0000)]
2011-01-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Align import/export directives
        https://bugs.webkit.org/show_bug.cgi?id=52208

        * API/JSBase.h: Align import/export directives with
        WebKit2/Shared/API/c/WKBase.h
2011-01-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Align import/export directives
        https://bugs.webkit.org/show_bug.cgi?id=52208

        * Shared/API/c/WKBase.h: Align import/export directives with
        JavaScriptCore/API/JSBase.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 14 Jan 2011 19:16:53 +0000 (19:16 +0000)]
2011-01-14  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] WebKit API: Add a function for form interactive validation setting
        https://bugs.webkit.org/show_bug.cgi?id=52430

        * public/WebSettings.h: Add a pure setInteractiveFormValidationEnabled().
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setInteractiveFormValidationEnabled): Implemented.
        * src/WebSettingsImpl.h: Add a declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 14 Jan 2011 18:54:52 +0000 (18:54 +0000)]
2011-01-14  Simon Fraser  <simon.fraser@apple.com>

        Let Xcode have it's way with the project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 14 Jan 2011 18:53:12 +0000 (18:53 +0000)]
2011-01-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Refactor some FrameView::syncCompositingState code
        https://bugs.webkit.org/show_bug.cgi?id=52459

        Refactor some code in FrameView related to synchronizing
        compositing layer state.

        * page/FrameView.cpp:
        (WebCore::FrameView::syncCompositingStateForThisFrame):
        (WebCore::FrameView::syncCompositingStateRecursive):
        (WebCore::FrameView::paintContents):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 14 Jan 2011 18:38:25 +0000 (18:38 +0000)]
2011-01-14  Tony Chang  <tony@chromium.org>

        Unreviewed, updating baselines.

        [chromium] rebaseline vertical tests on linux
        https://bugs.webkit.org/show_bug.cgi?id=52457

        After updating fonts.conf, these tests are now passing.

        * platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
        * platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
        * platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
        * platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
        * platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.checksum:
        * platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
        * platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
        * platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
        * platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
        * platform/chromium-linux/svg/batik/text/verticalText-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Fri, 14 Jan 2011 18:30:16 +0000 (18:30 +0000)]
2011-01-14  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
        https://bugs.webkit.org/show_bug.cgi?id=30179

        * plugins/symbian/PluginViewSymbian.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Vincent Scheib <scheib@chromium.org>
commit-queue@webkit.org [Fri, 14 Jan 2011 18:09:10 +0000 (18:09 +0000)]
2011-01-14  Vincent Scheib  <scheib@chromium.org>

        Reviewed by David Levin.

        Add support to DumpRenderTree to use the GPU rather than software renderer
        https://bugs.webkit.org/show_bug.cgi?id=52333

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2011-01-14  Vincent Scheib  <scheib@chromium.org>

        Reviewed by David Levin.

        Add support to DumpRenderTree to use the GPU rather than software renderer
        https://bugs.webkit.org/show_bug.cgi?id=52333

        * DEPS: Moved forward to take required support from webkit_support.h
        * WebKit.gyp: DumpRenderTree depends on Angle on windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 14 Jan 2011 17:35:48 +0000 (17:35 +0000)]
2011-01-14  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] update fonts.conf to fix 6 linux tests in drt
        https://bugs.webkit.org/show_bug.cgi?id=52411

        * platform/chromium/test_expectations.txt:
2011-01-14  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] update fonts.conf to fix 6 linux tests in drt
        https://bugs.webkit.org/show_bug.cgi?id=52411

        * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
            chromium's src/webkit/tools/test_shell/resources/fonts.conf

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Philippe Normand <pnormand@igalia.com>
carlosgc@webkit.org [Fri, 14 Jan 2011 17:27:45 +0000 (17:27 +0000)]
2011-01-14  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add volume slider to media player
        https://bugs.webkit.org/show_bug.cgi?id=51532

        * platform/gtk/Skipped:
        * platform/gtk/media/audio-controls-rendering-expected.txt:
        * platform/gtk/media/controls-after-reload-expected.txt:
        * platform/gtk/media/controls-strict-expected.txt:
        * platform/gtk/media/controls-styling-expected.txt:
        * platform/gtk/media/video-controls-rendering-expected.txt:
        * platform/gtk/media/video-display-toggle-expected.txt:
        * platform/gtk/media/video-empty-source-expected.txt:
        * platform/gtk/media/video-no-audio-expected.txt:
        * platform/gtk/media/video-volume-slider-expected.txt: Added.
2011-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add volume slider to media player
        https://bugs.webkit.org/show_bug.cgi?id=51532

        * css/mediaControlsGtk.css:
        (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
        (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
        (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
        (WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
        (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
        (WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
        * platform/gtk/RenderThemeGtk.h:
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::paintSliderTrack):
        (WebCore::RenderThemeGtk::paintSliderThumb):
        (WebCore::RenderThemeGtk::adjustSliderThumbSize):
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::paintSliderTrack):
        (WebCore::RenderThemeGtk::paintSliderThumb):
        (WebCore::RenderThemeGtk::adjustSliderThumbSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Joone Hur <joone.hur@collabora.co.uk>
commit-queue@webkit.org [Fri, 14 Jan 2011 17:03:45 +0000 (17:03 +0000)]
2011-01-14  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by David Levin.

        [GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52434

        No new tests. This code will be tested when an implementation
        of beginDragWithFiles is complete.

        * platform/gtk/FileSystemGtk.cpp:
        (WebCore::filenameToString): Use GOwnPtr instead of gchar pointer.
        (WebCore::fileSystemRepresentation): Ditto.
        (WebCore::filenameForDisplay): Ditto.
        (WebCore::pathGetFileName): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 14 Jan 2011 16:02:51 +0000 (16:02 +0000)]
2011-01-14  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Incorrect backtracking for nested alternatives
        https://bugs.webkit.org/show_bug.cgi?id=52387

        Added tests to verfiy backtracking of alternatives following
        parenthesis.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:
2011-01-14  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Incorrect backtracking for nested alternatives
        https://bugs.webkit.org/show_bug.cgi?id=52387

        In the process of propigating a datalabel it wasn't getting connected
        to a destination when the destination was an indirect jump.  Added
        code to recognize a direct backtrack destination that was an indirect
        jump and added mechanism to associate DataLabelPtrs with indirect
        jump entries.
        Removed dead method
        BacktrackDestination::linkDataLabelToHereIfExists()

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry):
        (JSC::Yarr::YarrGenerator::IndirectJumpEntry::addDataLabel):
        (JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry):
        (JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable):
        Changes to link indirect jumps with DataLabelPtr's.
        (JSC::Yarr::YarrGenerator::BacktrackDestination::clearSubDataLabelPtr):
        (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
        Updated to handle immediate linking of indirect jumps to
        DataLabelPtr.
        (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): Changed to
        reflect updated linkDataLabelToBacktrackIfExists().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 14 Jan 2011 15:58:16 +0000 (15:58 +0000)]
2011-01-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
        https://bugs.webkit.org/show_bug.cgi?id=52215

        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.prototype.populateLabelElement):
        * inspector/front-end/Script.js:
        (WebInspector.Script.prototype.get linesCount):
        (WebInspector.Script.prototype.sourceLine):
        (WebInspector.Script.prototype.sourceLine.didRequestSource):
        (WebInspector.Script.prototype.set source):
        (WebInspector.Script.prototype.requestSource.didGetScriptSource):
        (WebInspector.Script.prototype.requestSource):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource):
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._addBreakpoint):
        * inspector/front-end/utilities.js:
        (String.prototype.findAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 14 Jan 2011 15:49:20 +0000 (15:49 +0000)]
2011-01-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide script column offset to frontend.
        https://bugs.webkit.org/show_bug.cgi?id=52377

        * parser/SourceCode.h:
        (JSC::SourceCode::SourceCode):
        (JSC::SourceCode::firstColumn):
2011-01-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide script column offset to frontend.
        https://bugs.webkit.org/show_bug.cgi?id=52377

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        * bindings/js/ScriptSourceCode.h:
        (WebCore::ScriptSourceCode::ScriptSourceCode):
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        * inspector/Inspector.idl:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/ScriptDebugListener.h:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.parsedScriptSource):
        * inspector/front-end/Script.js:
        (WebInspector.Script):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 14 Jan 2011 15:28:48 +0000 (15:28 +0000)]
2011-01-14  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed one line fix for console-xhr-logging test.

        The problem was introduced at r75788.

        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 14 Jan 2011 14:57:21 +0000 (14:57 +0000)]
2011-01-13  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract console related functionality into InspectorConsoleAgent
        https://bugs.webkit.org/show_bug.cgi?id=52282

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::~ConsoleMessage):
        * inspector/ConsoleMessage.h:
        * inspector/Inspector.idl:
        * inspector/InspectorConsoleAgent.cpp: Added.
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        (WebCore::InspectorConsoleAgent::reset):
        (WebCore::InspectorConsoleAgent::setFrontend):
        (WebCore::InspectorConsoleAgent::addMessageToConsole):
        (WebCore::InspectorConsoleAgent::startTiming):
        (WebCore::InspectorConsoleAgent::stopTiming):
        (WebCore::InspectorConsoleAgent::count):
        (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorConsoleAgent::didReceiveResponse):
        (WebCore::InspectorConsoleAgent::didFailLoading):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h: Added.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::didCommitLoad):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::consoleAgent):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didFailLoadingImpl):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::addMessageToConsole):
        (WebCore::InspectorInstrumentation::count):
        (WebCore::InspectorInstrumentation::startTiming):
        (WebCore::InspectorInstrumentation::stopTiming):
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
        * inspector/InspectorInstrumentation.h:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
        (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView):
        (WebInspector.ConsoleView.prototype.addConsoleMessage):
        (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount):
        (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
        * inspector/front-end/inspector.js:
        * page/Console.cpp:
        (WebCore::Console::addMessage):
        (WebCore::Console::count):
        (WebCore::Console::profile):
        (WebCore::Console::time):
        (WebCore::Console::timeEnd):
        (WebCore::Console::group):
        (WebCore::Console::groupCollapsed):
        (WebCore::Console::groupEnd):
        * page/Console.h:
        * page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 14 Jan 2011 14:50:43 +0000 (14:50 +0000)]
2011-01-14  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: do not use this as protocol message
        dispatcher in models / agents.
        https://bugs.webkit.org/show_bug.cgi?id=52442

        Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
        There should be a clear way to tell whether method is being called
        from within front-end or by the backend.

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
2011-01-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not use this as protocol message
        dispatcher in models / agents.
        https://bugs.webkit.org/show_bug.cgi?id=52442

        Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
        There should be a clear way to tell whether method is being called
        from within front-end or by the backend.

        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent):
        (WebInspector.DOMAgent.prototype.nodeForId):
        (WebInspector.DOMAgent.prototype._bindNodes):
        (WebInspector.DOMAgent.prototype._removeBreakpoints):
        (WebInspector.DOMDispatcher):
        (WebInspector.DOMDispatcher.prototype.setDocument):
        (WebInspector.DOMDispatcher.prototype.attributesUpdated):
        (WebInspector.DOMDispatcher.prototype.characterDataModified):
        (WebInspector.DOMDispatcher.prototype.setChildNodes):
        (WebInspector.DOMDispatcher.prototype.setDetachedRoot):
        (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
        (WebInspector.DOMDispatcher.prototype.childNodeInserted):
        (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
        (WebInspector.DOMDispatcher.prototype.didCommitLoad):
        (WebInspector.ApplicationCacheDispatcher):
        (WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync):
        (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
        (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
        * inspector/front-end/DOMStorage.js:
        (WebInspector.DOMStorageDispatcher):
        (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
        (WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage):
        (WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
        * inspector/front-end/Database.js:
        (WebInspector.Database.prototype.executeSql):
        (WebInspector.DatabaseDispatcher):
        (WebInspector.DatabaseDispatcher.prototype.addDatabase):
        (WebInspector.DatabaseDispatcher.prototype.selectDatabase):
        (WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
        (WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype._pausedScript):
        (WebInspector.DebuggerModel.prototype._resumedScript):
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
        (WebInspector.DebuggerDispatcher):
        (WebInspector.DebuggerDispatcher.prototype.pausedScript):
        (WebInspector.DebuggerDispatcher.prototype.resumedScript):
        (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
        * inspector/front-end/FileSystemView.js:
        (WebInspector.FileSystemDispatcher):
        (WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync):
        (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath):
        (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError):
        (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype._addProfileHeader):
        (WebInspector.ProfilesPanel.prototype._removeProfileHeader):
        (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._setRecordingProfile):
        (WebInspector.ProfilerDispatcher):
        (WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled):
        (WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled):
        (WebInspector.ProfilerDispatcher.prototype.resetProfiles):
        (WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
        (WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk):
        (WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot):
        (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
        (WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted):
        (WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped):
        (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
        (WebInspector.TimelineDispatcher):
        (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted):
        (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped):
        (WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][V8] Unreviewed buildfix after r75788.
ossy@webkit.org [Fri, 14 Jan 2011 14:25:14 +0000 (14:25 +0000)]
[Qt][V8] Unreviewed buildfix after r75788.

* inspector/InspectorBrowserDebuggerAgent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 14 Jan 2011 13:31:09 +0000 (13:31 +0000)]
2011-01-14  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed test fix.
        Filter out /favicon.ico from page resources list to avoid test expectations mismatch on GTK.

        * http/tests/inspector/extensions-resources-redirect.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 14 Jan 2011 12:54:12 +0000 (12:54 +0000)]
2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
        We have some methods of Debugger which are related to DOM.
        Lets extract these methods to BrowserDebugger agent.

        http://bugs.webkit.org/show_bug.cgi?id=52294

        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
        (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
        (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
        * inspector/InspectorBrowserDebuggerAgent.h: Added.
        (WebCore::InspectorBrowserDebuggerAgent::create):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::restoreStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 14 Jan 2011 12:33:22 +0000 (12:33 +0000)]
2011-01-14  Eric Seidel  <eric@webkit.org>

        Original patch from Peter Gal  <galpater@inf.u-szeged.hu>

        Reviewed by Adam Barth.

        Fix when running Tools/Scripts/check-webkit-style without arguments.
        https://bugs.webkit.org/show_bug.cgi?id=52261#c16

        * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 14 Jan 2011 12:25:39 +0000 (12:25 +0000)]
2011-01-14  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: redirected resources not handled properly in Network panel
        https://bugs.webkit.org/show_bug.cgi?id=52292

        * inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
        * inspector/InspectorInstrumentation.cpp: Ditto.
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
        * inspector/InspectorResourceAgent.cpp: Ditto.
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        * inspector/InspectorResourceAgent.h: Ditto.
        * inspector/InspectorInstrumentation.cpp: Ditto.
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
        * inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
        * inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource
        (WebInspector.ConsoleMessage.prototype._formatMessage):
        * inspector/front-end/ExtensionServer.js: Ditto.
        (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
        (WebInspector.ExtensionServer.prototype._onGetResourceContent):
        * inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map
        (WebInspector.HARLog.prototype.build):
        (WebInspector.HARLog.prototype._convertResource):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource.
        (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
        (WebInspector.NetworkManager.prototype.willSendRequest):
        (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
        (WebInspector.NetworkManager.prototype.setInitialContent):
        (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
        (WebInspector.NetworkManager.prototype.didCreateWebSocket):
        (WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel
        (WebInspector.NetworkManager.prototype._appendRedirect):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype.get resources):
        (WebInspector.NetworkPanel.prototype.resourceById):
        (WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added.
        (WebInspector.NetworkPanel.prototype.refreshResource): ditto.
        (WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
        * inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation.
        (WebInspector.ResourceTreeModel.prototype._clearResources):
        (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
        (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
        (WebInspector.ResourceTreeModel.prototype.createResource):
        * inspector/front-end/inspector.js:
        (WebInspector.resourceById):

2011-01-14  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: redirected resources not handled properly in Network panel
        Added test for redirected resource presence in HAR
        Changed test to request entire HAR log, not multiple HAR entries.
        https://bugs.webkit.org/show_bug.cgi?id=52292

        * http/tests/inspector/extensions-resources-redirect-expected.txt:
        * http/tests/inspector/extensions-resources-redirect.html:
        * http/tests/inspector/resource-har-conversion.html:
        * inspector/extensions-resources.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Fri, 14 Jan 2011 10:48:01 +0000 (10:48 +0000)]
2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75783.
        http://trac.webkit.org/changeset/75783
        https://bugs.webkit.org/show_bug.cgi?id=52439

        a bit strange but the same patch have broken mac builds at
        linking stage. (Requested by loislo2 on #webkit).

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
        * inspector/InspectorBrowserDebuggerAgent.h: Removed.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::restoreStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        (WebCore::InspectorController::setEventListenerBreakpoint):
        (WebCore::InspectorController::removeEventListenerBreakpoint):
        (WebCore::InspectorController::hasEventListenerBreakpoint):
        (WebCore::InspectorController::setXHRBreakpoint):
        (WebCore::InspectorController::removeXHRBreakpoint):
        (WebCore::InspectorController::hasXHRBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::setDOMBreakpoint):
        (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
        (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
        (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
        (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
        (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        (WebCore::InspectorDOMAgent::hasBreakpoint):
        (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Finnur Thorarinsson <finnur.webkit@gmail.com>
commit-queue@webkit.org [Fri, 14 Jan 2011 10:24:51 +0000 (10:24 +0000)]
2011-01-14  Finnur Thorarinsson  <finnur.webkit@gmail.com>

        Reviewed by Ojan Vafai.

        Address some user-select-none issues better in our Find in page scoping
        function.

        The scoping function is in part based on Editor::countMatchesForText
        (formerly Frame::markAllMatchesForText), but was rewritten with
        asychronous search and interruptability in mind. At the time the
        function was written, countMatchesForText didn't work well with
        user-select-none style but that has now changed. While
        investigating http://crbug.com/68494 I noticed WebKit had fixed this
        very problem in the countMatchesForText and I believe we should make
        the same changes in our platform code. Therefore, this changelist
        adopts the same approach by integrating:
        https://bugs.webkit.org/show_bug.cgi?id=33508
        (r53142: handling user-select-none better) and
        https://bugs.webkit.org/show_bug.cgi?id=51623
        (r74886: handling match within textfield better).
        For more details see those changelists.

        This changelist, however, is tracked here:
        https://bugs.webkit.org/show_bug.cgi?id=52367

        The original changelists did not come with layout tests, but I'm adding
        a test on the Chromium side for this.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::scopeStringMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 14 Jan 2011 10:22:07 +0000 (10:22 +0000)]
2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
        We have some methods of Debugger which are related to DOM.
        Lets extract these methods to BrowserDebugger agent.

        http://bugs.webkit.org/show_bug.cgi?id=52294

        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
        (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
        (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
        * inspector/InspectorBrowserDebuggerAgent.h: Added.
        (WebCore::InspectorBrowserDebuggerAgent::create):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::restoreStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 14 Jan 2011 10:05:12 +0000 (10:05 +0000)]
2011-01-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: gtk build fix (2).

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Fri, 14 Jan 2011 10:02:37 +0000 (10:02 +0000)]
2011-01-04  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by David Levin.

        Store the tempdir object in a variable so it doesn't get deleted too early.
        https://bugs.webkit.org/show_bug.cgi?id=51875

        * Scripts/update-webkit-auxiliary-libs:
        * Scripts/update-webkit-support-libs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 14 Jan 2011 09:59:55 +0000 (09:59 +0000)]
2011-01-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: gtk build fix.

        * webkit/webkitwebinspector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 14 Jan 2011 09:52:38 +0000 (09:52 +0000)]
2011-01-14  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Make it work in python 2.5.

        webkit-patch suggest-reviewers dies when ChangeLogs are missing
        https://bugs.webkit.org/show_bug.cgi?id=49158

        * Scripts/webkitpy/common/checkout/api_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 14 Jan 2011 09:47:45 +0000 (09:47 +0000)]
2011-01-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: build fix.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 14 Jan 2011 09:28:52 +0000 (09:28 +0000)]
2011-01-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extract InspectorSettings from InspectorState,
        simplify it.
        https://bugs.webkit.org/show_bug.cgi?id=52429

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/InspectorClient.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::inspectorStartsAttached):
        (WebCore::InspectorController::setInspectorStartsAttached):
        (WebCore::InspectorController::setInspectorAttachedHeight):
        (WebCore::InspectorController::inspectorAttachedHeight):
        (WebCore::InspectorController::setMonitoringXHREnabled):
        (WebCore::InspectorController::restoreDebugger):
        (WebCore::InspectorController::restoreProfiler):
        (WebCore::InspectorController::ensureSettingsLoaded):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        * inspector/InspectorController.h:
        * inspector/InspectorSettings.cpp: Added.
        (WebCore::InspectorSettings::InspectorSettings):
        (WebCore::InspectorSettings::getBoolean):
        (WebCore::InspectorSettings::setBoolean):
        (WebCore::InspectorSettings::getLong):
        (WebCore::InspectorSettings::setLong):
        (WebCore::InspectorSettings::registerBoolean):
        (WebCore::InspectorSettings::registerLong):
        * inspector/InspectorSettings.h: Added.
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        (WebCore::InspectorState::setValue):
        (WebCore::InspectorState::setObject):
        (WebCore::InspectorState::registerBoolean):
        (WebCore::InspectorState::registerString):
        (WebCore::InspectorState::registerLong):
        (WebCore::InspectorState::registerObject):
        (WebCore::InspectorState::Property::create):
        * inspector/InspectorState.h:
        (WebCore::InspectorState::setBoolean):
        (WebCore::InspectorState::setString):
        (WebCore::InspectorState::setLong):

2011-01-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extract InspectorSettings from InspectorState,
        simplify it.
        https://bugs.webkit.org/show_bug.cgi?id=52429

        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Fri, 14 Jan 2011 09:21:05 +0000 (09:21 +0000)]
2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75774.
        http://trac.webkit.org/changeset/75774
        https://bugs.webkit.org/show_bug.cgi?id=52431

        gtk builds were broken (Requested by loislo2 on #webkit).

        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
        * inspector/InspectorBrowserDebuggerAgent.h: Removed.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::restoreStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        (WebCore::InspectorController::setEventListenerBreakpoint):
        (WebCore::InspectorController::removeEventListenerBreakpoint):
        (WebCore::InspectorController::hasEventListenerBreakpoint):
        (WebCore::InspectorController::setXHRBreakpoint):
        (WebCore::InspectorController::removeXHRBreakpoint):
        (WebCore::InspectorController::hasXHRBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::setDOMBreakpoint):
        (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
        (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
        (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
        (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
        (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        (WebCore::InspectorDOMAgent::hasBreakpoint):
        (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75774.
        http://trac.webkit.org/changeset/75774
        https://bugs.webkit.org/show_bug.cgi?id=52431

        gtk builds were broken (Requested by loislo2 on #webkit).

        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocheck-webkit-style: _FunctionState should detect pure functions.
levin@chromium.org [Fri, 14 Jan 2011 08:56:14 +0000 (08:56 +0000)]
check-webkit-style: _FunctionState should detect pure functions.
https://bugs.webkit.org/show_bug.cgi?id=52428

Reviewed by Shinichiro Hamaji.

* Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
is a pure virtual function.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
virtual functions are correctly detected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 14 Jan 2011 08:21:11 +0000 (08:21 +0000)]
2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
        We have some methods of Debugger which are related to DOM.
        Lets extract these methods to BrowserDebugger agent.

        http://bugs.webkit.org/show_bug.cgi?id=52294

        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
        (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
        (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
        * inspector/InspectorBrowserDebuggerAgent.h: Added.
        (WebCore::InspectorBrowserDebuggerAgent::create):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::restoreStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Just small fix for problem with check-webkit-style.
        It just didn't work for this patch.
        Old code can't concatenate a list of strings with None.

        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-14 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Fri, 14 Jan 2011 08:14:45 +0000 (08:14 +0000)]
2011-01-14  Hayato Ito  <hayato@chromium.org>

        Unreviewed chromium expectations update.

        Exclude http/tests/loading/cross-origin-XHR-willLoadRequest.html (added in r75768)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 14 Jan 2011 06:58:16 +0000 (06:58 +0000)]
2011-01-13  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style: _FunctionState should use Position to know where items are.
        https://bugs.webkit.org/show_bug.cgi?id=52424

        * Scripts/webkitpy/style/checkers/cpp.py:
        (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
        (detect_functions): Changed to pass Position's to _FunctionState.begin and
        did some minor clean-up.
        (*): Other changes are simply about converting to use the Position's in_FunctionState
        instead of line numbers.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
        to verify the positions stored in _FunctionState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Fri, 14 Jan 2011 06:58:00 +0000 (06:58 +0000)]
2011-01-13  Hayato Ito  <hayato@chromium.org>

        Unreviewed, build fix.

        Fix Skipped lists in r75768.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement form validation message UI
tkent@chromium.org [Fri, 14 Jan 2011 06:21:51 +0000 (06:21 +0000)]
Implement form validation message UI
https://bugs.webkit.org/show_bug.cgi?id=48980

Reviewed by Dimitri Glazkov.

* Add four internal pseudo selectors:
  - -webkit-validation-bubble
  - -webkit-validation-bubble-message
  - -webkit-validation-bubble-top-outer-arrow
  - -webkit-validation-bubble-top-inner-arrow

* Implement ValidationMessage functions
  Show the message for <the number of characters> / 20.0 seconds.

No new tests because the feature is disabled by default for now and the
new behavior is strongly timing-dependent.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
  Do not share a style with elements with different shadowPseudoId().
* css/html.css: Define appearance for the internal selectors.
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-top-outer-arrow):
(::-webkit-validation-bubble-top-inner-arrow):
* dom/Node.cpp:
(WebCore::Node::createRendererIfNeeded):
  Allow to add shadow renderers even if canHaveChildren() returns false.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::detach):
  Remove m_validationMessage immediately because we can't use
  hideVisibleValidationMessage(), which calls a ValidationMessage function later.
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
  - Don't create ValidationMessage if the message is empty.
  - Remove the check for message equality.
(WebCore::HTMLFormControlElement::hideVisibleValidationMessage):
  Don't remove m_validationMessage immediately. We shouldn't make the
  element needsLayout() state in this context.
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::~ValidationMessage):
  hideMessage() -> deleteBubbleTree() renaming.
(WebCore::ValidationMessage::setMessage): Implemented.
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
  Added. This updates the validation message and starts the timer to hide it.
(WebCore::ElementWithPseudoId):
  Added to help implementations of styled shadow nodes.
(WebCore::ValidationMessage::buildBubbleTree): Added.
(WebCore::ValidationMessage::requestToHideMessage): Added.
(WebCore::ValidationMessage::deleteBubbleTree):
  Renamed from hideMessage(), and implemented.
* html/ValidationMessage.h: Add declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 14 Jan 2011 05:40:18 +0000 (05:40 +0000)]
2011-01-13  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        webkit-patch suggest-reviewers dies when ChangeLogs are missing
        https://bugs.webkit.org/show_bug.cgi?id=49158

        This is not the most elegant, but it is a very safe fix to this bug.
        One advantage of catching ScriptError like this instead of adding a
        new added_or_modified_files or fixing all changed_files callers
        to use a more specific change_files variant, is that we catch
        all kinds of ScriptErrors which might cause our (non-essential)
        suggest-reviewers code to fail out.  This should make passing
        --suggest-reviewers to webkit-patch upload much more robust
        and may even make it possible for us to make it default.

        The root of the problem here is that SCM.changed_files includes
        deleted ChangeLog paths (from moves, etc) which then when we ask
        SVN/Git for the contents of the file at that revision, the command
        errors out and Executive.run_command raises a ScriptError.

        In the future we might fix this differently by making all current
        callers of chagned_files use a more specific method for requesting
        what types of changes they're interested in (adds, modifies, deletes, etc.)

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/api_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendReque...
mitz@apple.com [Fri, 14 Jan 2011 05:19:49 +0000 (05:19 +0000)]
<rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
https://bugs.webkit.org/show_bug.cgi?id=52419

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/loading/cross-origin-XHR-willLoadRequest.html

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Complete r74453 by ensuring that m_request is only set after
willSendRequest(). Otherwise, willSendRequest() ends up calling into
ThreadableDocumentRequest::willSendRequest(), which cancels the request.

Tools:

Allow to further control the behavior of the willSendRequest delegate callback by making it
set a different URL in the new request.

* DumpRenderTree/LayoutTestController.cpp:
(addURLToRedirectCallback): Added.
(LayoutTestController::staticFunctions): Added addURLToRedirect.
(LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
(LayoutTestController::redirectionDestinationForURL): Added this getter.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
change the URL in the new request to the redirect destination.

LayoutTests:

* http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt: Added.
* http/tests/loading/cross-origin-XHR-willLoadRequest.html: Added.
* platform/gtk/Skipped: Skip the new test.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon’t try to compile InjectedScriptSource.js into WebCore.
mitz@apple.com [Fri, 14 Jan 2011 04:19:48 +0000 (04:19 +0000)]
Don’t try to compile InjectedScriptSource.js into WebCore.

Reviewed by Mark Rowe.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/5469576> Use __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 if available.
darin@apple.com [Fri, 14 Jan 2011 02:52:53 +0000 (02:52 +0000)]
<rdar://problem/5469576> Use __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 if available.

Reviewed by Geoff Garen.

* DerivedSources.make: Create a header file, HeaderDetection.h, that tells
us whether pthread_machdep.h is available.
* wtf/FastMalloc.cpp: If __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 is available, then
don't do the pthread_getspecific_function_pointer trick.
(WTF::setThreadHeap): Ditto, but set thread-specific data.
(WTF::TCMalloc_ThreadCache::GetThreadHeap): Ditto, but get rather than set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 14 Jan 2011 02:24:00 +0000 (02:24 +0000)]
2011-01-13  Justin Schuh  <jschuh@chromium.org>

        Unreviewed chromium expectations update.

        Several text layout tests failing on linux after r75756

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 14 Jan 2011 02:11:48 +0000 (02:11 +0000)]
2011-01-13  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r75740.
        http://trac.webkit.org/changeset/75740

        This led to GTK+ redness

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Robert Hogan <robert@webkit.org>
robert@webkit.org [Fri, 14 Jan 2011 02:07:50 +0000 (02:07 +0000)]
2011-01-13  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Unskip http/tests/security/originHeader/origin-header-for-empty.html
        https://bugs.webkit.org/show_bug.cgi?id=52389

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 14 Jan 2011 01:58:38 +0000 (01:58 +0000)]
2011-01-13  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed chromium expectations update.

        Add Chromium Snow Leopard expectations. These need to go into a new
        chromium-mac-snowleopard directory, since these tests do not have
        chromium-mac expectations, but currently pass on Leopard.

        The differences are due to bug 52335 (which explains why we can't use
        the regular mac port Snow Leopard baselines).

        * platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.png: Added.
        * platform/chromium-mac-snowleopard/css1/box_properties/float-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css1/box_properties/float-expected.png: Added.
        * platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 14 Jan 2011 01:56:51 +0000 (01:56 +0000)]
2011-01-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Mihai Parparita.

        webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
        https://bugs.webkit.org/show_bug.cgi?id=52416

        Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
        UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data

        I also added FIXMEs about the changed_files returning deleted files problem
        which is causing the other most common exception for suggest-reviewers
        (and is probably breaking sheriff-bots blame detection).

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/api_unittest.py:
        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 14 Jan 2011 01:51:57 +0000 (01:51 +0000)]
2011-01-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        results archives from commit-queue are too large to upload
        https://bugs.webkit.org/show_bug.cgi?id=52405

        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Fri, 14 Jan 2011 01:31:35 +0000 (01:31 +0000)]
2011-01-13  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Mihai Parparita.

        [chromium] Fix minor type in plugin printing
        https://bugs.webkit.org/show_bug.cgi?id=52410

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::printBegin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe pageScaleFactor() should be saved/restored along with the scroll position
mthole@apple.com [Fri, 14 Jan 2011 01:16:42 +0000 (01:16 +0000)]
The pageScaleFactor() should be saved/restored along with the scroll position
https://bugs.webkit.org/show_bug.cgi?id=52406
<rdar://problem/8714412>

Reviewed by Darin Adler and Brady Eidson.

* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem): Initialize m_pageScaleFactor.
(WebCore::HistoryItem::pageScaleFactor): Added getter.
(WebCore::HistoryItem::setPageScaleFactor): Added setter.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Encode m_pageScaleFactor.
(WebCore::HistoryItem::decodeBackForwardTree): Decode m_pageScaleFactor.
* history/HistoryItem.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem): Save the page scale factor...
(WebCore::HistoryController::restoreScrollPositionAndViewState): ...and restore it here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 14 Jan 2011 01:15:46 +0000 (01:15 +0000)]
2011-01-13  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed chromium expectations update.

        Categorize remaining scrollbar-related failures. 6 are due to bug 52414
        (small remaining difference between mac and chromium-mac scrollbars).
        fast/text/international/thai-line-breaks.html just needed a baseline
        update (done for both Leopard and Snow Leopard).

        * platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.png: Added.
        * platform/chromium-mac/fast/text/international/thai-line-breaks-expected.checksum: Added.
        * platform/chromium-mac/fast/text/international/thai-line-breaks-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Evan Martin <evan@chromium.org>
evan@chromium.org [Fri, 14 Jan 2011 00:48:53 +0000 (00:48 +0000)]
2011-01-13  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] drop backwards iteration in Linux complex text code
        https://bugs.webkit.org/show_bug.cgi?id=52403

        ComplexTextController previously supported iterating through the text in
        both directions, but this resulted in duplicate code for each path.
        Instead, by being more careful about flipping signs where appropriate,
        we can refactor the code into one code path.

        No tests, just a refactoring; should be covered by existing tests.

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::ComplexTextController):
        (WebCore::ComplexTextController::reset):
        (WebCore::ComplexTextController::nextScriptRun):
        * platform/graphics/chromium/ComplexTextControllerLinux.h:
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::selectionRectForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 14 Jan 2011 00:39:52 +0000 (00:39 +0000)]
2011-01-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        simplify keyboard handling in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52407

        Now that we have DiffBlock containers, the only things that are
        focusable are previousComment nodes and DiffBlock containers
        that contain add/remove lines.

        Also, this means we show the focus border around the entire diff
        instead of just the first line.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 14 Jan 2011 00:14:46 +0000 (00:14 +0000)]
2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Flip input[type=range] to use the new shadow DOM model.
        https://bugs.webkit.org/show_bug.cgi?id=52317

        This is a straight-up flip, minimal change to the logic, which will be
        refactored in a follow-up patch.

        Covered by existing tests.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
            host or parent node to find parent.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
            shadow DOM subtree.
        * html/InputType.cpp:
        (WebCore::InputType::createShadowSubtree): Added empty decl.
        (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
            shadow subtree.
        * html/InputType.h: Added defs.
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
            slider thumb.
        * html/RangeInputType.h: Adde def.
        * html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
            to handle cascading appearance.
        (WebCore::RenderSliderThumb::RenderSliderThumb): Added.
        (WebCore::RenderSliderThumb::layout): Moved here the logic from
            RenderSlider::createThumbStyle.
        (WebCore::SliderThumbElement::createRenderer): Added virtual method to
            create RenderSliderThumb instance.
        (WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
            as base class.
        (WebCore::SliderThumbElement::detach): Ditto.
        * html/shadow/SliderThumbElement.h:
        (WebCore::SliderThumbElement::SliderThumbElement): Ditto.
        (WebCore::SliderThumbElement::create): Ditto.
        (WebCore::toSliderThumbElement): Added a casting helper.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
            since the whole method is hand-rolled.
        (WebCore::MediaControlInputElement::updateStyle): Ditto.
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
        (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
        (WebCore::RenderSlider::layout): Ditto.
        (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
            SliderThumbElement.
        (WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
        (WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
        (WebCore::RenderSlider::setValueForPosition): Ditto.
        (WebCore::RenderSlider::positionForOffset): Ditto.
        (WebCore::RenderSlider::currentPosition): Ditto.
        (WebCore::RenderSlider::trackSize): Ditto.
        (WebCore::RenderSlider::forwardEvent): Ditto.
        (WebCore::RenderSlider::inDragMode): Ditto.
        * rendering/RenderSlider.h: Added def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 13 Jan 2011 23:55:26 +0000 (23:55 +0000)]
2011-01-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename RGBA32Buffer to ImageFrame
        https://bugs.webkit.org/show_bug.cgi?id=52363

        Update references to the new name.

        * src/WebImageDecoder.cpp:
        (WebKit::WebImageDecoder::isFrameCompleteAtIndex):
        (WebKit::WebImageDecoder::getFrameAtIndex):
2011-01-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename RGBA32Buffer to ImageFrame
        https://bugs.webkit.org/show_bug.cgi?id=52363

        RGBA32Buffer is a terrible misnomer.  ImageFrame is vastly
        more accurate.  More cleanup to come.

        * WebCore.pro:
        * platform/graphics/ImageSource.cpp:
        (WebCore::ImageSource::createFrameAtIndex):
        (WebCore::ImageSource::frameDurationAtIndex):
        (WebCore::ImageSource::frameIsCompleteAtIndex):
        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::frameBufferAtIndex):
        (WebCore::ImageDecoderQt::internalReadImage):
        (WebCore::ImageDecoderQt::internalHandleCurrentImage):
        * platform/graphics/qt/ImageDecoderQt.h:
        * platform/graphics/wince/ImageWinCE.cpp:
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageFrame::ImageFrame):
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clear):
        (WebCore::ImageFrame::zeroFill):
        (WebCore::ImageFrame::copyReferenceToBitmapData):
        (WebCore::ImageFrame::copyBitmapData):
        (WebCore::ImageFrame::setSize):
        (WebCore::ImageFrame::hasAlpha):
        (WebCore::ImageFrame::setHasAlpha):
        (WebCore::ImageFrame::setColorProfile):
        (WebCore::ImageFrame::setStatus):
        (WebCore::ImageFrame::width):
        (WebCore::ImageFrame::height):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageFrame::ImageFrame):
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::frameBufferAtIndex):
        (WebCore::BMPImageDecoder::decode):
        * platform/image-decoders/bmp/BMPImageDecoder.h:
        * platform/image-decoders/bmp/BMPImageReader.cpp:
        (WebCore::BMPImageReader::decodeBMP):
        * platform/image-decoders/bmp/BMPImageReader.h:
        (WebCore::BMPImageReader::setBuffer):
        * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/cg/ImageDecoderCG.cpp:
        (WebCore::getPtrAsPixelData):
        (WebCore::ImageFrame::copyReferenceToBitmapData):
        (WebCore::ImageFrame::copyBitmapData):
        (WebCore::ImageFrame::setSize):
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::frameBufferAtIndex):
        (WebCore::GIFImageDecoder::clearFrameBufferCache):
        (WebCore::GIFImageDecoder::haveDecodedRow):
        (WebCore::GIFImageDecoder::frameComplete):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/gif/GIFImageReader.cpp:
        (GIFImageReader::read):
        * platform/image-decoders/gif/GIFImageReader.h:
        (GIFFrameReader::GIFFrameReader):
        * platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::frameBufferAtIndex):
        (WebCore::ICOImageDecoder::decode):
        * platform/image-decoders/ico/ICOImageDecoder.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::frameBufferAtIndex):
        (WebCore::JPEGImageDecoder::outputScanlines):
        (WebCore::JPEGImageDecoder::jpegComplete):
        (WebCore::JPEGImageDecoder::decode):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::frameBufferAtIndex):
        (WebCore::PNGImageDecoder::rowAvailable):
        (WebCore::PNGImageDecoder::pngComplete):
        * platform/image-decoders/png/PNGImageDecoder.h:
        (WebCore::PNGImageDecoder::isComplete):
        * platform/image-decoders/qt/ImageFrameQt.cpp: Copied from Source/WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp.
        (WebCore::ImageFrame::ImageFrame):
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clear):
        (WebCore::ImageFrame::zeroFill):
        (WebCore::ImageFrame::copyBitmapData):
        (WebCore::ImageFrame::setSize):
        (WebCore::ImageFrame::asNewNativeImage):
        (WebCore::ImageFrame::hasAlpha):
        (WebCore::ImageFrame::setHasAlpha):
        (WebCore::ImageFrame::setColorProfile):
        (WebCore::ImageFrame::setStatus):
        (WebCore::ImageFrame::setPixmap):
        (WebCore::ImageFrame::width):
        (WebCore::ImageFrame::height):
        * platform/image-decoders/qt/RGBA32BufferQt.cpp: Removed.
        * platform/image-decoders/skia/ImageDecoderSkia.cpp:
        (WebCore::ImageFrame::ImageFrame):
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clear):
        (WebCore::ImageFrame::zeroFill):
        (WebCore::ImageFrame::copyBitmapData):
        (WebCore::ImageFrame::setSize):
        (WebCore::ImageFrame::asNewNativeImage):
        (WebCore::ImageFrame::hasAlpha):
        (WebCore::ImageFrame::setHasAlpha):
        (WebCore::ImageFrame::setColorProfile):
        (WebCore::ImageFrame::setStatus):
        (WebCore::ImageFrame::width):
        (WebCore::ImageFrame::height):
        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::frameBufferAtIndex):
        (WebCore::WEBPImageDecoder::decode):
        * platform/image-decoders/webp/WEBPImageDecoder.h:
        * platform/image-decoders/wx/ImageDecoderWx.cpp:
        (WebCore::ImageFrame::asNewNativeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-13 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 13 Jan 2011 23:52:42 +0000 (23:52 +0000)]
2011-01-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        add container divs for diff blocks
        https://bugs.webkit.org/show_bug.cgi?id=52400

        This will help simplify a lot of code in code-review.js
        and make side-by-side diffs better (i.e. put removed lines
        to the left of corresponding added lines).

        Also, allow for running the JS from a local file. Now you can modify code-review.js
        to point to a local file and then run:
        ruby prettify.rb < foo.diff > foo.html

        foo.html will load a dummy code review matching foo.diff.

        Before structure:
        Line
        Line remove
        Line add
        Line add
        Line

        After structure:
        DiffBlock
          DiffBlockPart shared
            Line shared
        DiffBlock
          DiffBlockPart remove
            Line remove
          DiffBlockPart add
            Line add
            Line add
        DiffBlock
          DiffBlockPart shared
            Line shared

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75747 268f45cc-cd09-0410-ab3c-d52691b4dbfc