WebKit-https.git
9 years ago2010-04-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 27 Apr 2010 12:05:49 +0000 (12:05 +0000)]
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed.  Disable quota-tracking in Chromium
        until Dumi can take a look.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 27 Apr 2010 11:18:59 +0000 (11:18 +0000)]
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed build fix.

        Revert 58274 and 58269 (WebSQLDatabase changes)
        https://bugs.webkit.org/show_bug.cgi?id=38191

        * storage/quota-tracking-expected.txt:
        * storage/quota-tracking.html:
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed build fix.

        Revert 58274 and 58269 (WebSQLDatabase changes)
        https://bugs.webkit.org/show_bug.cgi?id=38191

        Chromium bots are hitting ASSERTS when running layout tests.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::maximumSize):
        (WebCore::SQLiteDatabase::freeSpaceSize):
        * platform/sql/SQLiteDatabase.h:
        * platform/sql/SQLiteStatement.cpp:
        (WebCore::SQLiteStatement::prepare):
        * storage/Database.cpp:
        (WebCore::Database::performOpenAndVerify):
        * storage/Database.h:
        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::postflightAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 27 Apr 2010 10:54:45 +0000 (10:54 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, fix build breakage by reverting r58299.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        * fast/css/parsing-page-rule-expected.txt: Removed.
        * fast/css/parsing-page-rule.html: Removed.
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, fix build breakage by reverting r58299.

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::clearProperties):
        * css/CSSParser.h:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 27 Apr 2010 09:53:27 +0000 (09:53 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        WebCore::CSSSelector::RareData::parseNth doesn't check whether the search for '-' in the argument was successful.
        This results in incorrect parsing.
        For example, '3n' is parsed as if it were '3n-3'. The code has been working OK just accidentally.

        https://bugs.webkit.org/show_bug.cgi?id=37787

        No new tests are added because the original behavior is accidentally OK.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::RareData::parseNth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 27 Apr 2010 09:35:16 +0000 (09:35 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Hyatt.

        Enhance CSS parser for Paged Media (Iteration 1)

        In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
        The contents of the methods should be implemented by other changes.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        * fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
        * fast/css/parsing-page-rule.html: Added.
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Hyatt.

        Enhance CSS parser for Paged Media (Iteration 1)

        In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
        The contents of the methods should be implemented by other changes.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        Test: fast/css/parsing-page-rule.html

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::lex):
        (WebCore::CSSParser::text):
        (WebCore::CSSParser::createPageRule):
        (WebCore::CSSParser::createMarginAtRule):
        (WebCore::CSSParser::startDeclarationsForMarginBox):
        (WebCore::CSSParser::endDeclarationsForMarginBox):
        * css/CSSParser.h:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 09:12:18 +0000 (09:12 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove custom bindings for TreeWalker
        https://bugs.webkit.org/show_bug.cgi?id=38182

        This custom code is just CallWith=ScriptState.

        * WebCore.gypi:
        * bindings/js/JSTreeWalkerCustom.cpp:
        (WebCore::JSTreeWalker::markChildren):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/TestObj.idl:
        * bindings/v8/custom/V8TreeWalkerCustom.cpp: Removed.
        * dom/TreeWalker.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 09:10:12 +0000 (09:10 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
        https://bugs.webkit.org/show_bug.cgi?id=38186

        Unfortunately, we don't have a good way of testing this change because
        our test coverage of the scm.py API is poor...

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 08:02:36 +0000 (08:02 +0000)]
2010-04-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Move code out of GenerateImplementation to make it more smaller
        https://bugs.webkit.org/show_bug.cgi?id=38176

        * bindings/scripts/CodeGeneratorJS.pm:
         - Move some code into a new GenerateAttributesHashTable method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 07:15:44 +0000 (07:15 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add CallWith=DynamicFrame to CodeGenerator
        https://bugs.webkit.org/show_bug.cgi?id=38174

        I've only used this in one instance, but this is infrastructure that I
        think will help remove a bunch of custom bindings code.  Also, added a
        few tests of tricky argument cases.

        * bindings/js/JSHTMLFormElementCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_with_dynamic_frame):
        (webkit_dom_test_obj_with_dynamic_frame_and_arg):
        (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg):
        (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture):
        (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj withDynamicFrame]):
        (-[DOMTestObj withDynamicFrameAndArg:]):
        (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
        (-[DOMTestObj withDynamicFrameAndUserGesture:]):
        (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::withDynamicFrameCallback):
        (WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
        (WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
        (WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
        (WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
        (WebCore::):
        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        * html/HTMLFormElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Tue, 27 Apr 2010 06:28:38 +0000 (06:28 +0000)]
2010-04-26  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Prepare to making WebThemeEngine cross-platform
        https://bugs.webkit.org/show_bug.cgi?id=38077

        * WebKit.gyp:
        * public/WebThemeEngine.h: Added.
        * public/win/WebThemeEngine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 06:19:44 +0000 (06:19 +0000)]
2010-04-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove unused code from text_diff.py
        https://bugs.webkit.org/show_bug.cgi?id=38170

        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
         - Remove is_render_tree_dump which appears unused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 27 Apr 2010 06:10:33 +0000 (06:10 +0000)]
2010-04-26  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Crash after calling window.print() on a window object that has been closed.
        https://bugs.webkit.org/show_bug.cgi?id=38148

        It is unfortunately not possible to write a layout test for this as the
        crash occurs in an API that is only called by Chrome while showing a
        print dialog.

        * src/WebViewImpl.cpp:
        (WebKit::WebView::willEnterModalLoop):
        (WebKit::WebView::didExitModalLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 05:56:32 +0000 (05:56 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch pretty-diff is broken
        https://bugs.webkit.org/show_bug.cgi?id=38172

        We need to register for these options because they're used when we look
        up the diff.

        * Scripts/webkitpy/tool/steps/confirmdiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 05:30:58 +0000 (05:30 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Update comment to better reflect reality.

        * bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 05:01:44 +0000 (05:01 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add ObjC and GObject to run-bindings-test
        https://bugs.webkit.org/show_bug.cgi?id=38168

        Added expected results.

        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Added.
        (WebKit::kit):
        (webkit_dom_test_obj_void_method):
        (webkit_dom_test_obj_void_method_with_args):
        (webkit_dom_test_obj_int_method):
        (webkit_dom_test_obj_int_method_with_args):
        (webkit_dom_test_obj_obj_method):
        (webkit_dom_test_obj_obj_method_with_args):
        (webkit_dom_test_obj_method_with_exception):
        (webkit_dom_test_obj_method_with_optional_arg):
        (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
        (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
        (webkit_dom_test_obj_get_read_only_int_attr):
        (webkit_dom_test_obj_get_read_only_string_attr):
        (webkit_dom_test_obj_get_read_only_test_obj_attr):
        (webkit_dom_test_obj_get_int_attr):
        (webkit_dom_test_obj_set_int_attr):
        (webkit_dom_test_obj_get_string_attr):
        (webkit_dom_test_obj_set_string_attr):
        (webkit_dom_test_obj_get_test_obj_attr):
        (webkit_dom_test_obj_set_test_obj_attr):
        (webkit_dom_test_obj_get_attr_with_exception):
        (webkit_dom_test_obj_set_attr_with_exception):
        (webkit_dom_test_obj_get_attr_with_setter_exception):
        (webkit_dom_test_obj_set_attr_with_setter_exception):
        (webkit_dom_test_obj_get_attr_with_getter_exception):
        (webkit_dom_test_obj_set_attr_with_getter_exception):
        (WebKit::wrapTestObj):
        (WebKit::core):
        (webkit_dom_test_obj_finalize):
        (webkit_dom_test_obj_set_property):
        (webkit_dom_test_obj_get_property):
        (webkit_dom_test_obj_class_init):
        (webkit_dom_test_obj_init):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: Added.
        * bindings/scripts/test/ObjC/DOMTestObj.h: Added.
        * bindings/scripts/test/ObjC/DOMTestObj.mm: Added.
        (-[DOMTestObj dealloc]):
        (-[DOMTestObj finalize]):
        (-[DOMTestObj readOnlyIntAttr]):
        (-[DOMTestObj readOnlyStringAttr]):
        (-[DOMTestObj readOnlyTestObjAttr]):
        (-[DOMTestObj intAttr]):
        (-[DOMTestObj setIntAttr:]):
        (-[DOMTestObj stringAttr]):
        (-[DOMTestObj setStringAttr:]):
        (-[DOMTestObj testObjAttr]):
        (-[DOMTestObj setTestObjAttr:]):
        (-[DOMTestObj attrWithException]):
        (-[DOMTestObj setAttrWithException:]):
        (-[DOMTestObj attrWithSetterException]):
        (-[DOMTestObj setAttrWithSetterException:]):
        (-[DOMTestObj attrWithGetterException]):
        (-[DOMTestObj setAttrWithGetterException:]):
        (-[DOMTestObj customAttr]):
        (-[DOMTestObj setCustomAttr:]):
        (-[DOMTestObj voidMethod]):
        (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj intMethod]):
        (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj objMethod]):
        (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj methodWithException]):
        (-[DOMTestObj customMethod]):
        (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj methodWithOptionalArg:]):
        (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
        (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
        (core):
        (kit):
        * bindings/scripts/test/ObjC/DOMTestObjInternal.h: Added.
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add ObjC and GObject to run-bindings-test
        https://bugs.webkit.org/show_bug.cgi?id=38168

        * Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 04:49:45 +0000 (04:49 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add testing infrastructure for JSC bindings generator
        https://bugs.webkit.org/show_bug.cgi?id=38167

        This required moving the test files around a bit more.

        * bindings/scripts/test/JS/JSTestObj.cpp: Added.
        (WebCore::):
        (WebCore::JSTestObjConstructor::JSTestObjConstructor):
        (WebCore::JSTestObjConstructor::classInfo):
        (WebCore::JSTestObjConstructor::createStructure):
        (WebCore::JSTestObjConstructor::getOwnPropertySlot):
        (WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
        (WebCore::JSTestObjPrototype::self):
        (WebCore::JSTestObjPrototype::getOwnPropertySlot):
        (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
        (WebCore::JSTestObj::JSTestObj):
        (WebCore::JSTestObj::~JSTestObj):
        (WebCore::JSTestObj::createPrototype):
        (WebCore::JSTestObj::getOwnPropertySlot):
        (WebCore::JSTestObj::getOwnPropertyDescriptor):
        (WebCore::jsTestObjReadOnlyIntAttr):
        (WebCore::jsTestObjReadOnlyStringAttr):
        (WebCore::jsTestObjReadOnlyTestObjAttr):
        (WebCore::jsTestObjIntAttr):
        (WebCore::jsTestObjStringAttr):
        (WebCore::jsTestObjTestObjAttr):
        (WebCore::jsTestObjAttrWithException):
        (WebCore::jsTestObjAttrWithSetterException):
        (WebCore::jsTestObjAttrWithGetterException):
        (WebCore::jsTestObjCustomAttr):
        (WebCore::jsTestObjConstructor):
        (WebCore::JSTestObj::put):
        (WebCore::setJSTestObjIntAttr):
        (WebCore::setJSTestObjStringAttr):
        (WebCore::setJSTestObjTestObjAttr):
        (WebCore::setJSTestObjAttrWithException):
        (WebCore::setJSTestObjAttrWithSetterException):
        (WebCore::setJSTestObjAttrWithGetterException):
        (WebCore::setJSTestObjCustomAttr):
        (WebCore::JSTestObj::getConstructor):
        (WebCore::jsTestObjPrototypeFunctionVoidMethod):
        (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionIntMethod):
        (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionObjMethod):
        (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodWithException):
        (WebCore::jsTestObjPrototypeFunctionCustomMethod):
        (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
        (WebCore::toJS):
        (WebCore::toTestObj):
        * bindings/scripts/test/JS/JSTestObj.h: Added.
        (WebCore::JSTestObj::classInfo):
        (WebCore::JSTestObj::createStructure):
        (WebCore::JSTestObj::impl):
        (WebCore::JSTestObjPrototype::classInfo):
        (WebCore::JSTestObjPrototype::createStructure):
        (WebCore::JSTestObjPrototype::JSTestObjPrototype):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp.
        (WebCore::):
        (WebCore::TestObjInternal::V8_USE):
        (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter):
        (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter):
        (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
        (WebCore::TestObjInternal::intAttrAttrGetter):
        (WebCore::TestObjInternal::intAttrAttrSetter):
        (WebCore::TestObjInternal::stringAttrAttrGetter):
        (WebCore::TestObjInternal::stringAttrAttrSetter):
        (WebCore::TestObjInternal::testObjAttrAttrGetter):
        (WebCore::TestObjInternal::testObjAttrAttrSetter):
        (WebCore::TestObjInternal::attrWithExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithExceptionAttrSetter):
        (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter):
        (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
        (WebCore::TestObjInternal::voidMethodCallback):
        (WebCore::TestObjInternal::voidMethodWithArgsCallback):
        (WebCore::TestObjInternal::intMethodCallback):
        (WebCore::TestObjInternal::intMethodWithArgsCallback):
        (WebCore::TestObjInternal::objMethodCallback):
        (WebCore::TestObjInternal::objMethodWithArgsCallback):
        (WebCore::TestObjInternal::methodWithExceptionCallback):
        (WebCore::TestObjInternal::methodWithOptionalArgCallback):
        (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
        (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
        (WebCore::TestObjInternal::overloadedMethod1Callback):
        (WebCore::TestObjInternal::overloadedMethod2Callback):
        (WebCore::TestObjInternal::overloadedMethod3Callback):
        (WebCore::TestObjInternal::overloadedMethod4Callback):
        (WebCore::TestObjInternal::overloadedMethodCallback):
        (WebCore::ConfigureV8TestObjTemplate):
        (WebCore::V8TestObj::GetRawTemplate):
        (WebCore::V8TestObj::GetTemplate):
        (WebCore::V8TestObj::toNative):
        (WebCore::V8TestObj::HasInstance):
        (WebCore::V8TestObj::wrap):
        (WebCore::toV8):
        (WebCore::V8TestObj::derefObject):
        * bindings/scripts/test/V8/V8TestObj.h: Renamed from WebCore/bindings/scripts/test/V8TestObj.h.
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add testing infrastructure for JSC bindings generator
        https://bugs.webkit.org/show_bug.cgi?id=38167

        Add support for testing more than one bindings.  Also, converted the
        script to PEP8 style.

        * Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix windows
oliver@apple.com [Tue, 27 Apr 2010 04:39:48 +0000 (04:39 +0000)]
Fix windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 27 Apr 2010 04:22:46 +0000 (04:22 +0000)]
2010-04-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Need to support more efficient dispatch of lightweight builtins
        https://bugs.webkit.org/show_bug.cgi?id=38155

        The problem with calling lightweight builtins is that marshalling
        the call from the nitro calling convention to the system calling
        convention is very expensive relative to the cost of the actually
        evaluating the function.  To work around this problem this patch
        adds the ability to define a custom thunk for a builtin.

        This allows us to use high performance custom implementations of
        the common and sensible versions of simple builtins.  This patch
        includes a simple (use of which is currently hardcoded) thunk for
        charCodeAt.

        This adds a JSInterfaceJIT subclass called SpecializedThunkJIT
        that has helper functions to remove (or at least reduce) the need
        to have separate thunk implementations for each JSValue encoding.

        * GNUmakefile.am:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
          Many project file updates

        * create_hash_table:
          Add thunk generation callbacks to the hash tables, currently
          we hardcode the script to only support charCodeAt

        * jit/JITStubCall.h:
        * jit/JITStubs.cpp:
        (JSC::JITThunks::~JITThunks):
        (JSC::JITThunks::specializedThunk):
        * jit/JITStubs.h:
        * jit/SpecializedThunkJIT.h: Added.
        (JSC::SpecializedThunkJIT::SpecializedThunkJIT):
        (JSC::SpecializedThunkJIT::loadCellArgument):
        (JSC::SpecializedThunkJIT::loadJSStringArgument):
        (JSC::SpecializedThunkJIT::loadInt32Argument):
        (JSC::SpecializedThunkJIT::appendFailure):
        (JSC::SpecializedThunkJIT::returnInt32):
        (JSC::SpecializedThunkJIT::finalize):
        (JSC::SpecializedThunkJIT::argumentToVirtualRegister):
        (JSC::SpecializedThunkJIT::tagReturnAsInt32):
        * jit/ThunkGenerators.cpp: Added.
        (JSC::ThunkHelpers::stringImplDataOffset):
        (JSC::ThunkHelpers::jsStringLengthOffset):
        (JSC::ThunkHelpers::jsStringValueOffset):
        (JSC::charCodeAtThunkGenerator):
        * jit/ThunkGenerators.h: Added.
        * runtime/Executable.h:
        (JSC::NativeExecutable::NativeExecutable):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):
        * runtime/JSFunction.h:
        * runtime/JSGlobalData.h:
        (JSC::JSGlobalData::getThunk):
        * runtime/JSString.h:
        (JSC::):
        * runtime/JSValue.h:
          Protect some of the JSVALUE32 and JSVALUE32_64 only constants
          and function behind appropriate USE() guards to make it harder
          to use the wrong flags for the target build.
        * runtime/Lookup.cpp:
        (JSC::HashTable::createTable):
        (JSC::setUpStaticFunctionSlot):
        * runtime/Lookup.h:
        (JSC::HashEntry::initialize):
        (JSC::HashEntry::generator):
        (JSC::HashEntry::):
          Make the lookup tables use a specialized thunkGenerator
          if present
        * wtf/text/StringImpl.h:
2010-04-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Need to support more efficient dispatch of lightweight builtins
        https://bugs.webkit.org/show_bug.cgi?id=38155

        Update bindings generation to include new thunk generator field
        in the property map hash tables.

        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 04:21:33 +0000 (04:21 +0000)]
2010-04-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Refactor results.html generation out into a new method and test it
        https://bugs.webkit.org/show_bug.cgi?id=38164

        Hopefully this results in no change in functionality.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix
oliver@apple.com [Tue, 27 Apr 2010 04:12:43 +0000 (04:12 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 27 Apr 2010 03:45:47 +0000 (03:45 +0000)]
2010-04-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Factor some basic JS interface logic out of JIT and into a superclass
        https://bugs.webkit.org/show_bug.cgi?id=38163

        Create JSInterfaceJIT to hold some common low level functions for
        interacting with the JS RegisterFile.  Doing this separately from
        https://bugs.webkit.org/show_bug.cgi?id=38155 to ease reviewing.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * jit/JIT.h:
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
        * jit/JSInterfaceJIT.h: Added.
        (JSC::JSInterfaceJIT::emitLoadJSCell):
        (JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
        (JSC::JSInterfaceJIT::emitLoadInt32):
        (JSC::JSInterfaceJIT::tagFor):
        (JSC::JSInterfaceJIT::payloadFor):
        (JSC::JSInterfaceJIT::addressFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 03:36:06 +0000 (03:36 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r58265.
        http://trac.webkit.org/changeset/58265
        https://bugs.webkit.org/show_bug.cgi?id=38021

        This change prevents me from uploading patches.  It also breaks sheriff-bot.

        * Scripts/webkitpy/tool/steps/options.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 03:35:13 +0000 (03:35 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move bindings test directory into the scripts directory
        https://bugs.webkit.org/show_bug.cgi?id=38161

        This test is really of the bindings scripts not of the bindings
        themselves.  By moving the files into the scripts directory, we'll be
        able to test JSC as well.

        * bindings/scripts/test/TestObj.idl: Renamed from WebCore/bindings/v8/test/TestObj.idl.
        * bindings/scripts/test/V8TestObj.cpp: Renamed from WebCore/bindings/v8/test/V8TestObj.cpp.
        (WebCore::):
        (WebCore::TestObjInternal::V8_USE):
        (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter):
        (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter):
        (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
        (WebCore::TestObjInternal::intAttrAttrGetter):
        (WebCore::TestObjInternal::intAttrAttrSetter):
        (WebCore::TestObjInternal::stringAttrAttrGetter):
        (WebCore::TestObjInternal::stringAttrAttrSetter):
        (WebCore::TestObjInternal::testObjAttrAttrGetter):
        (WebCore::TestObjInternal::testObjAttrAttrSetter):
        (WebCore::TestObjInternal::attrWithExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithExceptionAttrSetter):
        (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter):
        (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
        (WebCore::TestObjInternal::voidMethodCallback):
        (WebCore::TestObjInternal::voidMethodWithArgsCallback):
        (WebCore::TestObjInternal::intMethodCallback):
        (WebCore::TestObjInternal::intMethodWithArgsCallback):
        (WebCore::TestObjInternal::objMethodCallback):
        (WebCore::TestObjInternal::objMethodWithArgsCallback):
        (WebCore::TestObjInternal::methodWithExceptionCallback):
        (WebCore::TestObjInternal::methodWithOptionalArgCallback):
        (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
        (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
        (WebCore::TestObjInternal::overloadedMethod1Callback):
        (WebCore::TestObjInternal::overloadedMethod2Callback):
        (WebCore::TestObjInternal::overloadedMethod3Callback):
        (WebCore::TestObjInternal::overloadedMethod4Callback):
        (WebCore::TestObjInternal::overloadedMethodCallback):
        (WebCore::ConfigureV8TestObjTemplate):
        (WebCore::V8TestObj::GetRawTemplate):
        (WebCore::V8TestObj::GetTemplate):
        (WebCore::V8TestObj::toNative):
        (WebCore::V8TestObj::HasInstance):
        (WebCore::V8TestObj::wrap):
        (WebCore::toV8):
        (WebCore::V8TestObj::derefObject):
        * bindings/scripts/test/V8TestObj.h: Renamed from WebCore/bindings/v8/test/V8TestObj.h.
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move bindings test directory into the scripts directory
        https://bugs.webkit.org/show_bug.cgi?id=38161

        Change script to point to the new location of these data files.

        * Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Daniel Cheng <dcheng@chromium.org>
eric@webkit.org [Tue, 27 Apr 2010 03:07:38 +0000 (03:07 +0000)]
2010-04-26  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Jian Li.

        [chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs.
        https://bugs.webkit.org/show_bug.cgi?id=38159

        No new tests.

        * platform/chromium/ChromiumDataObject.h:
        (WebCore::ChromiumDataObject::setURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 02:33:04 +0000 (02:33 +0000)]
2010-04-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
        https://bugs.webkit.org/show_bug.cgi?id=37987

        Rolled out:
        http://trac.webkit.org/changeset/58062
        http://trac.webkit.org/changeset/58060
        http://trac.webkit.org/changeset/58059
        http://trac.webkit.org/changeset/58055
        http://trac.webkit.org/changeset/58054
        and parts of:
        http://trac.webkit.org/changeset/58050

        I also wrote some new comments and a tiny amount of new
        code to help make ChromiumDriver.run_test easier to read.

        In order to unit-test my new code, I had to change ChromiumDriver
        to not automatically start itself when created.  That ended up
        being a lot of plumbing, but is hopefully easier to understand now.

        There are no tests for the (restored) wdiff code.  wdiff does not
        exist on all systems, so for now we will assume it worked since
        it is just old code being reverted.

         * Scripts/webkitpy/layout_tests/driver_test.py:
          - Use create_driver instead of start_driver, and be sure to call .stop()
         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
          - Use create_driver instead of start_driver
         * Scripts/webkitpy/layout_tests/port/base.py:
          - Added a comment to explain that diffs are binary files.
          - Various patch reverts relating to wdiff
          - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
          - Made _command_wrapper use shlex.split to get rid of the FIXME.
         * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
          - test the new _command_wrapper
         * Scripts/webkitpy/layout_tests/port/chromium.py:
         - Use _command_wrapper to get rid of a bunch of ugly code.
         - Make __init__ stop auto-starting.
         - Rename create_driver to start_driver.
         - Added _write_command_and_read_line to make it possible to
           put a FIXME next to read_line() w/o having to put it in two places.
         - Moved test_shell command building into _test_shell_command and tested it.
         - Fix comments to say test_shell since ChromiumDriver is test_shell only.
         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
          - Test the new test_shell_command method.
         * Scripts/webkitpy/layout_tests/port/dryrun.py:
          - Rename create_driver to start_driver.
         * Scripts/webkitpy/layout_tests/port/test.py:
          - Rename create_driver to start_driver.
         * Scripts/webkitpy/layout_tests/port/webkit.py:
          - Rename create_driver to start_driver.
          - Treat output as binary arrays.
         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
          - Treat diff files as binary.
         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
          - Treat diff files as binary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 02:22:29 +0000 (02:22 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Mark run-bindings-tests executable so we can execute it.

        * Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 27 Apr 2010 02:12:59 +0000 (02:12 +0000)]
2010-04-26  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, Chromium test expectation change.

        To keep up with the change that turned on HTML5 DB AUTO_VACUUM.
        https://bugs.webkit.org/show_bug.cgi?id=36251

        * platform/chromium-mac/storage/quota-tracking-expected.txt: Removed.
        * platform/chromium-win/storage/quota-tracking-expected.txt: Removed.
        * platform/chromium/storage/quota-tracking-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Daniel Cheng <dcheng@chromium.org>
eric@webkit.org [Tue, 27 Apr 2010 01:32:44 +0000 (01:32 +0000)]
2010-04-26  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Jian Li.

        [Chromium] Don't make file paths available in text/uri-list when dragging files.
        https://bugs.webkit.org/show_bug.cgi?id=25882

        Test will be checked in with WebCore/platform/mac fix.

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::getData):
        (WebCore::ClipboardChromium::types):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 27 Apr 2010 01:26:55 +0000 (01:26 +0000)]
2010-04-26  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] build-webkit --chromium should build release by default
        https://bugs.webkit.org/show_bug.cgi?id=38028

        * Scripts/build-dumprendertree: Also should build release by default
        * Scripts/build-webkit: Make sure to pass command line args through
        * Scripts/webkitdirs.pm: Build the right configuration

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, fixing the build breakage introduced by r58269.
dumi@chromium.org [Tue, 27 Apr 2010 00:37:21 +0000 (00:37 +0000)]
Unreviewed, fixing the build breakage introduced by r58269.

Turning on AUTO_VACUUM has increased the amount of space used by databases.

* storage/quota-tracking-expected.txt:
* storage/quota-tracking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 27 Apr 2010 00:09:58 +0000 (00:09 +0000)]
2010-04-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r57292): 1.5% page load speed regression from visited link information leak fix
        https://bugs.webkit.org/show_bug.cgi?id=38131

        I did a number of separate optimizations which speed up style
        resolution enough to more than make up for the regression. This
        measures as a total PLT speedup of somewhere between 1.5% and
        3.7%.

        Optimizations done:
        - Cache determineLinkState results, to avoid the need to repeatedly compute
        the visited link hash for the same element. This directly addresses much
        of the slowdown, since all elements get their style computed twice now.
        - Added a fast way to get the length of a CSSMutableStyleDeclaration, and use
        in CSSStyleSelector::matchRulesForList, since it was hot there.
        - Hoist some loop invariant code that's not detected by the compiler out of the
        main loop in matchRulesForList
        - inline CSSStyleSelector::initElement and locateSharedStyle,
        since there is only one call site in each case
        - Inline the common non-line fast case of determineLinkState, and split the rest into
        out-of-line determineLinkStateSlowCase.
        - Added inline versions of the functions called by
        visitedLinkHash (the version called by determineLinkState).

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::length): Implemented in terms of new
        inline nonvirtual mutableLength().
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::mutableLength): Added new nonvirtual
        inline way to get the length if you know you have a mutable style decl.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::init): Clear cached link state.
        (WebCore::CSSStyleSelector::matchRulesForList): hoist some code out of the main
        loop and get style decl length more efficiently.
        (WebCore::CSSStyleSelector::initElement): inline (only one call site)
        (WebCore::CSSStyleSelector::SelectorChecker::determineLinkState): Inline fast
        case, call slow case.
        (WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase): Split
        most of the above function into this slow case helper.
        (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the cache-enabled
        way to get the current link state.
        (WebCore::CSSStyleSelector::locateSharedStyle): inline
        (WebCore::CSSStyleSelector::styleForElement): Use the cache-enabled way
        to get the current link state.
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::currentElementLinkState): inline way to
        get link state for the current element; manages the cache
        * platform/LinkHash.cpp:
        (WebCore::visitedLinkHashInline): inline version of below function
        (WebCore::visitedLinkHash): call the inline version
        (WebCore::visitedURLInline): inline version of below function
        (WebCore::visitedURL): call the inline version
        (WebCore::visitedURL): call inline versions of above two functions

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove last use of WEB_THREAD.
weinig@apple.com [Mon, 26 Apr 2010 23:30:47 +0000 (23:30 +0000)]
Remove last use of WEB_THREAD.

Reviewed by Alexey Proskuryakov.

* platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCScheduleDeallocateOnMainThread): This can always use
isMainThread().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTurn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases, and
dumi@chromium.org [Mon, 26 Apr 2010 22:58:26 +0000 (22:58 +0000)]
Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases, and
vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, adding a guard against a bug
that was fixed in SQLite only starting with version 3.6.16.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=36251

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
* platform/sql/SQLiteDatabase.h:
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):
* storage/Database.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Tiger build.
weinig@apple.com [Mon, 26 Apr 2010 22:45:27 +0000 (22:45 +0000)]
Fix Tiger build.

* wtf/mac/MainThreadMac.mm:
(WTF::isMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/7766413>
ggaren@apple.com [Mon, 26 Apr 2010 22:44:48 +0000 (22:44 +0000)]
<rdar://problem/7766413>

Reviewed by Sam Weinig.

Fixed a crash seen when using the JavaScriptCore API with WebKit.

No layout test because DumpRenderTree doesn't use the JavaScriptCore API
in this way.

JavaScriptCore:

* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::setGlobalObject):
(JSC::RegisterFile::clearGlobalObject):
(JSC::RegisterFile::globalObject):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile): Use WeakGCPtr for managing m_globalObject,
since it's a weak pointer. (We never noticed this error before because,
in WebKit, global objects always have a self-reference in a global variable,
so marking the register file's global variables would keep m_globalObject
alive. In the JavaScriptCore API, you can allocate a global object with
no self-reference.)

* runtime/JSActivation.h: Removed unneeded #include.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject): Don't use ==, since a weak
pointer is 0 when the object it points to runs its destructor.

* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::clear): Changed to return a bool indicating whether the
clear actually happened.
(JSC::WeakGCPtr::assign): Changed to forbid assignment of 0 as a shorthand
for calling clear(). A client should never clear by assigning 0, since
clear() should be conditional on whether the object doing the clearing
is still pointed to by the weak pointer. (Otherwise, a zombie object might
clear a pointer to a new, valid object.)

WebCore:

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener): Don't assign 0 to a WeakGCPtr.
JavaScriptCore no longer allows this.

* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper): No need to initialize a WeakGCPtr
to 0, or ASSERT a non-0 value before assigning to a WeakGCPtr -- both are
default behaviors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38097
weinig@apple.com [Mon, 26 Apr 2010 22:38:55 +0000 (22:38 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
Disentangle initializing the main thread from initializing threading

Reviewed by Maciej Stachowiak.

JavaScriptCore:

This is the first step in getting rid of the WEB_THREAD #define and
paving the way to allowing mac both WebKit and WebKit2 to use the same
WebCore.

* JavaScriptCore.exp: Export initializeMainThread and initializeMainThreadToProcessMainThread.
* JavaScriptCore.xcodeproj/project.pbxproj: Sort files.

* wtf/MainThread.cpp:
(WTF::mainThreadInitializationMutex):
(WTF::mainThreadFunctionQueueMutex):
(WTF::initializeMainThread):
(WTF::deprecatedInitializeMainThread):
* wtf/MainThread.h:
Added Mac only initializeMainThreadToProcessMainThread which sets up callOnMainThread
and isMainThead calls to assume that WebCore's main thread is also the
process's main thread. Since it is possible that both initializeMainThread
and initializeMainThreadToProcessMainThread could be called, the first one called
wins (either will work).

* wtf/Threading.h: Moved to top of file.

* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Remove call to initializeMainThread.
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading): Ditto.
* wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeThreading): Ditto.

* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThread):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::isMainThread):
Add runtime switch between the old behavior of using the system's main
thread and a stored pointer to the main thread. Tiger always uses the
system's main thread.

* wtf/qt/ThreadingQt.cpp:
(WTF::initializeThreading): Remove call to initializeMainThread.
* wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform): Add call to initializeCurrentThreadInternal
removed from initializeThreading.

WebCore:

* WebCore.xcodeproj/project.pbxproj: Sort files.

* accessibility/mac/AccessibilityObjectWrapper.mm: Remove unnessary
+initialize method. The AccessibilityObjectWrapper has no data members
that need to be derefed, so it does not need to be finalized on the main
thread.

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject initialize]): Add call to initializeMainThreadToProcessMainThread.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.
* platform/mac/SharedBufferMac.mm:
(+[WebCoreSharedBufferData initialize]): Add call to initializeMainThreadToProcessMainThread.

WebKit/chromium:

* src/WebKit.cpp:
(WebKit::initialize): Add call to initializeMainThread.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl): Ditto.

WebKit/gtk:

* webkit/webkitprivate.cpp:
(webkit_init): Add call to initializeMainThread.

WebKit/mac:

Calls initializeMainThreadToProcessMainThread since there is no way to ensure
that the initialize method will be called on the main thread.

* Carbon/CarbonWindowAdapter.mm:
(+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread.
* History/WebBackForwardList.mm:
(+[WebBackForwardList initialize]): Ditto.
* History/WebHistoryItem.mm:
(+[WebHistoryItem initialize]): Ditto.
* Misc/WebElementDictionary.mm:
(+[WebElementDictionary initialize]): Ditto.
* Misc/WebIconDatabase.mm:
(+[WebIconDatabase initialize]): Ditto.
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(+[WebHostedNetscapePluginView initialize]): Ditto.
* Plugins/WebBaseNetscapePluginView.mm:
(+[WebBaseNetscapePluginView initialize]): Ditto.
* Plugins/WebBasePluginPackage.mm:
(+[WebBasePluginPackage initialize]): Ditto.
* Plugins/WebNetscapePluginView.mm:
(+[WebNetscapePluginView initialize]): Ditto.
* WebCoreSupport/WebEditorClient.mm:
(+[WebEditCommand initialize]): Ditto.
* WebCoreSupport/WebFrameLoaderClient.mm:
(+[WebFramePolicyListener initialize]): Ditto.
* WebView/WebArchive.mm:
(+[WebArchivePrivate initialize]): Ditto.
* WebView/WebDataSource.mm:
(+[WebDataSourcePrivate initialize]): Ditto.
* WebView/WebHTMLView.mm:
(+[WebHTMLViewPrivate initialize]): Ditto.
(+[WebHTMLView initialize]): Ditto.
* WebView/WebResource.mm:
(+[WebResourcePrivate initialize]): Ditto.
* WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]): Ditto.
* WebView/WebView.mm:
* WebView/WebViewData.mm: Ditto.
(+[WebViewPrivate initialize]): Ditto.

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Add call to initializeMainThread.

WebKit/win:

* WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.
* WebView.cpp:
(WebView::WebView): Ditto.

WebKit/wx:

* WebView.cpp:
(wxWebView::Create): Add call to initializeMainThread.

WebKit2:

* UIProcess/Launcher/mac/WebProcessLauncher.mm:
(WebKit::webThreadBody): Add call to initializeMainThread.
* UIProcess/Launcher/win/WebProcessLauncher.cpp:
(WebKit::webThreadBody): Ditto.
* WebProcess/Launching/mac/WebProcessMain.mm:
(main): Ditto.
* WebProcess/win/WebProcessMain.cpp:
(WebKit::WebProcessMain): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 26 Apr 2010 21:52:40 +0000 (21:52 +0000)]
2010-04-26  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        complete rietveld bugzilla integration
        https://bugs.webkit.org/show_bug.cgi?id=38021

        Makes --fancy-review the default. All this means is that the patch will
        be uploaded to rietveld in addition to bugs.webkit.org.

        * Scripts/webkitpy/tool/steps/options.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Yongjun Zhang <yongjun_zhang@apple.com>
eric@webkit.org [Mon, 26 Apr 2010 21:43:52 +0000 (21:43 +0000)]
2010-04-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=38128
        Don't add empty credential to CredentialStorage.

        An empty credential is currently regarded as a invalid login because it means a missing value in
        protectionSpaceToCredentialMap.  This change makes it consistent with current WebCore's behavior
        by ignoring empty credentials.

        No new tests added since this only affects credential entered by user from credential dialog,
        which is not testable in DRT.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::receivedCredential):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFor check-webkit-style, renamed the style/processors/ directory
cjerdonek@webkit.org [Mon, 26 Apr 2010 21:01:47 +0000 (21:01 +0000)]
For check-webkit-style, renamed the style/processors/ directory
to style/checkers/.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=38122

* Scripts/webkitpy/style/checker.py:
  - Updated import statements.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated import statements.

* Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
* Scripts/webkitpy/style/processors: Removed.
* Scripts/webkitpy/style/processors/__init__.py: Removed.
* Scripts/webkitpy/style/processors/common.py: Removed.
* Scripts/webkitpy/style/processors/common_unittest.py: Removed.
* Scripts/webkitpy/style/processors/cpp.py: Removed.
* Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
* Scripts/webkitpy/style/processors/python.py: Removed.
* Scripts/webkitpy/style/processors/python_unittest.py: Removed.
* Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
* Scripts/webkitpy/style/processors/text.py: Removed.
* Scripts/webkitpy/style/processors/text_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 26 Apr 2010 19:26:23 +0000 (19:26 +0000)]
2010-04-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Clean-up WebCore.pro after now that JavaScriptCore is built separately
        https://bugs.webkit.org/show_bug.cgi?id=38123

        HAVE_STDINT_H, and HAVE_PTHREAD_NP_H no longer needs to be defined
        for QtWebKit  as JavaScriptCore is built separately. These defines are only
        used  by JavaScriptCore and for JavaScriptCore these are already
        properly defined in JavaScriptCore/config.h.

        No new tests, no new functionality.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 26 Apr 2010 17:48:19 +0000 (17:48 +0000)]
2010-04-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        Include git commits in the diff for webkit-patch upload/land.
        https://bugs.webkit.org/show_bug.cgi?id=36394

        Adds --squash, --no-squash and --git-commit.

        --git-commit will use a specific local commit for land/upload.
        If a commit-range is specified, then that range is treated as
        a single squashed commit.

        --squash will squash all local changes including working copy changes
        into a single patch.

        --no-squash is the legacy behavior (upload only considers the working copy,
        land commits the working copy and then each local commit separately to SVN)

        If neither is specified, then an informative error is raised if there is
        more than one local commit or when there are local commit(s) and working
        copy changes.

        If the webkit-patch.squash git config parameter is set, then
        that will be respected instead of raising an error.

        * Scripts/check-webkit-style:
        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/api_unittest.py:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/style/optparser.py:
        --git-since is removed and --git-commit no longer implies commit_id..
        Instead, it treats that individual commit, but also supports commit ranges
        (e.g. commit_id..) as arguments.
        * Scripts/webkitpy/style/optparser_unittest.py:
        * Scripts/webkitpy/style_references.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
        * Scripts/webkitpy/tool/steps/checkstyle.py:
        * Scripts/webkitpy/tool/steps/commit.py:
        * Scripts/webkitpy/tool/steps/options.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
        * Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Roman Gershman <romange@google.com>
evan@chromium.org [Mon, 26 Apr 2010 17:03:18 +0000 (17:03 +0000)]
2010-04-26  Roman Gershman  <romange@google.com>

        Reviewed by Adam Barth.

        [Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
        The following manual test checks for desired behavior.

        https://bugs.webkit.org/show_bug.cgi?id=37977

        * manual-tests/chromium/suggestions-popup-font-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Roman Gershman <romange@google.com>
evan@chromium.org [Mon, 26 Apr 2010 16:56:42 +0000 (16:56 +0000)]
2010-04-26  Roman Gershman  <romange@google.com>

        Reviewed by Adam Barth.

        [Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.

        https://bugs.webkit.org/show_bug.cgi?id=37977

        * src/SuggestionsPopupMenuClient.cpp:
        (WebKit::SuggestionsPopupMenuClient::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Mon, 26 Apr 2010 16:21:43 +0000 (16:21 +0000)]
2010-04-26  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        View modes names in CSSValueKeywords.in
        https://bugs.webkit.org/show_bug.cgi?id=38125

        View mode names has changed in previous patch but CSSValueKeywords.in file was
        not updated.

        * css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix compilation with RVCT 4
hausmann@webkit.org [Mon, 26 Apr 2010 15:10:48 +0000 (15:10 +0000)]
[Qt] Fix compilation with RVCT 4
https://bugs.webkit.org/show_bug.cgi?id=37727

Reviewed by Kenneth Rohde Christiansen.

Swap extern and declspec to fix visibility of symbol imported from QtGui.

* page/qt/EventHandlerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Ruben Van Boxem <vanboxem.ruben@gmail.com>
eric@webkit.org [Mon, 26 Apr 2010 14:58:02 +0000 (14:58 +0000)]
2010-04-26  Ruben Van Boxem  <vanboxem.ruben@gmail.com>

        Reviewed by Adam Roben.

        Fixes for Win64 compilation under gcc (mingw-w64)

        *  WebCore/bridge/npapi.h: for win64 compatibility, mirroring mozilla-central, see Mozilla bug 560298
        *  WebCore/platform/Arena.h: uword is used to cast from pointers here. unsigned long is 32-bit on Windows (but 64-bit on mac), and too small to hold a pointer. uintptr_t is 32-bit on 32-bit systems (mac, linux and windows) and 64-bit on all 64-bit systems
        *  WebCore/platform/graphics/transforms/TransformationMatrix.h: let mingw-w64/w32 use MSVC codepath
        *  WebCore/platform/text/TextStream.cpp: let mingw-w64 use MSVC codepath
        *  WebCore/platform/text/TextStream.h: let mingw-w64 use MSVC codepath
        *  WebCore/plugins/PluginView.cpp: fix pointer casts on WIN64 and let mingw-w64 use MSVC codepath
        *  WebCore/plugins/win/PluginViewWin.cpp: fix pointer casts on WIN64

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix the include header <qstring.h> -> <QtCore/qstring.h>
hausmann@webkit.org [Mon, 26 Apr 2010 14:54:04 +0000 (14:54 +0000)]
[Qt] Fix the include header <qstring.h> -> <QtCore/qstring.h>

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-04-26
Reviewed by Simon Hausmann.

The module/header.h style inclusion removes the need to have -I$QTDIR/include/depending-module
in the include search path for the application.

* Api/qwebkitversion.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] HTTP pipelining efficiency increase
hausmann@webkit.org [Mon, 26 Apr 2010 14:33:22 +0000 (14:33 +0000)]
[Qt] HTTP pipelining efficiency increase
https://bugs.webkit.org/show_bug.cgi?id=38062

Patch by Markus Goetz <Markus.Goetz@nokia.com> on 2010-04-26
Reviewed by Simon Hausmann.

Increase number of network requests that are fed into
QNetworkAccessManager.

* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 26 Apr 2010 13:56:15 +0000 (13:56 +0000)]
2010-04-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium Dev Tools: brush up images.

        https://bugs.webkit.org/show_bug.cgi?id=38124

        * WebKit.gypi:
        * src/js/DevTools.js:
        (WebInspector.setToolbarColors):
        * src/js/Images/segmentChromium.png:
        * src/js/Images/segmentChromium2.png: Removed.
        * src/js/Images/segmentHoverChromium2.png: Removed.
        * src/js/Images/segmentSelectedChromium2.png: Removed.
        * src/js/Images/statusbarBackgroundChromium.png:
        * src/js/Images/statusbarBackgroundChromium2.png: Removed.
        * src/js/Images/statusbarBottomBackgroundChromium.png:
        * src/js/Images/statusbarButtonsChromium.png:
        * src/js/Images/statusbarMenuButtonChromium.png:
        * src/js/Images/statusbarMenuButtonChromium2.png: Removed.
        * src/js/devTools.css:
        (.section > .header):
        (.console-group-messages .section > .header):
        (#resources-filter):
        (.crumbs .crumb):
        (.crumbs .crumb.end):
        (.crumbs .crumb.selected):
        (.crumbs .crumb.selected:hover):
        (.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
        (.crumbs .crumb:hover):
        (.crumbs .crumb.dimmed:hover):
        (.crumbs .crumb.end:hover):
        (body.drawer-visible #main-status-bar):
        (.status-bar):
        (button.status-bar-item):
        (select.status-bar-item:active):
        (#drawer):
        (select.status-bar-item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Mon, 26 Apr 2010 13:37:37 +0000 (13:37 +0000)]
2010-04-26  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: undefined shows up on inspector.
        https://bugs.webkit.org/show_bug.cgi?id=38120

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.hide):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.set visible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Mon, 26 Apr 2010 13:01:39 +0000 (13:01 +0000)]
2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Deleted the StyleChecker-related classes that are no longer
        being used.

        https://bugs.webkit.org/show_bug.cgi?id=38118

        * Scripts/webkitpy/style/checker.py:
          - Deleted the DeprecatedStyleChecker class.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase,
            StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Bruno Schmidt <bruno.schmidt@gmail.com>
eric@webkit.org [Mon, 26 Apr 2010 12:47:34 +0000 (12:47 +0000)]
2010-04-26  Bruno Schmidt  <bruno.schmidt@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Exposing an QVariantMap containing QObjectStar to Javascript
        causes Segmentation Fault
        https://bugs.webkit.org/show_bug.cgi?id=34729

        If an QVariantMap containing QObjectStar is added to the to QtWebkit
        Javascript, it's use causes Segmentation Fault.
        It happens because, in the case QMetaType::QVariantMap, the "root"
        object that is inside of a PassRefPtr is passed recursively inside a
        loop to recover the content of the map, but the PassRefPtr semantics
        prohibit its use inside a loop, so the "root" object mus be passed
        using the method "PassRefPtr::get" in order to keep the current
        reference.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::convertQVariantToValue): change to root.get()
2010-04-26  Bruno Schmidt  <bruno.schmidt@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Exposing an QVariantMap containing QObjectStar to Javascript
        causes Segmentation Fault
        https://bugs.webkit.org/show_bug.cgi?id=34729

        If an QVariantMap containing QObjectStar is added to the to QtWebkit
        Javascript, it's use causes Segmentation Fault.
        It happens because, in the case QMetaType::QVariantMap, the "root"
        object that is inside of a PassRefPtr is passed recursively inside a
        loop to recover the content of the map, but the PassRefPtr semantics
        prohibit its use inside a loop, so the "root" object mus be passed
        using the method "PassRefPtr::get" in order to keep the current
        reference.

        * tests/qwebframe/tst_qwebframe.cpp:
        (MyQObject::MyQObject): new property variantMapProperty
        (MyQObject::variantMapProperty): read variantMapProperty
        (MyQObject::setVariantMapProperty): write variantMapProperty

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Mon, 26 Apr 2010 12:28:28 +0000 (12:28 +0000)]
2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Changed the StyleChecker class to use the new TextFileReader class.

        https://bugs.webkit.org/show_bug.cgi?id=37066

        This revision separates the code responsible for reading and iterating
        over text files from the rest of check-webkit-style.

        * Scripts/check-webkit-style:
          - Changed the script to use the new StyleProcessor and
            TextFileReader classes instead of the StyleChecker class.

        * Scripts/webkitpy/style/checker.py:
          - Added a FIXME to rename many of uses of the word "processor" to
            "checker".  We did this to clarify the difference between
            ProcessorBase instances passed to the TextFileReader and
            classes that process and check lines for style.
          - Added a FIXME to remove FileType.NONE as a possible return value
            of ProcessorDispatcher._file_type().  This will better consolidate
            the logic of which files should be skipped.
          - Added a FIXME to delete the StyleChecker class.
          - Added the StyleProcessor class which implements ProcessorBase.
            This class is responsible for processing lines to check style
            (but not for reading files).  For each file, this class creates
            creates both a carriage-return checker and a format-specific
            style checker (e.g. one of C++, Python, etc).
          - Updated the PatchChecker class to use a TextFileReader instance
            instead of a StyleChecker.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
            tests of the StyleProcessor class.
          - Added the StyleProcessor_CodeCoverageTest to test the
            StyleProcessor class with more complete code coverage.
            Unlike the StyleProcessor_EndToEndTest class, this class makes
            heavy use of mock parameters.
          - Added FIXME's to delete the unit test classes that are no
            longer needed.
          - Updated the PatchCheckerTest class to use a MockTextFileReader
            instead of a MockStyleChecker.

        * Scripts/webkitpy/style/filereader.py:
          - Updated the TextFileReader class to use the preferred logic
            of checking file existence at the beginning of the process_file()
            method instead of in the except block, per
            https://bugs.webkit.org/show_bug.cgi?id=37122

        * Scripts/webkitpy/style/filereader_unittest.py:
          - In the TextFileReaderTest class:
            - Moved the test_process_file__should_not_process() method.
            - Added a test_process_file__file_stdin() method to test
              the file path "-".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Mon, 26 Apr 2010 12:28:15 +0000 (12:28 +0000)]
2010-04-26  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Fix a memory leak in the QScriptString.

        QScriptStringPrivate's constructor shouldn't call JSStringRetain as
        QScriptConverter implicitly pass a JSStringRef ownership.

        [Qt] QScriptStringPrivate c'tor problem
        https://bugs.webkit.org/show_bug.cgi?id=38110

        * qt/api/qscriptstring_p.h:
        (QScriptStringPrivate::QScriptStringPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 26 Apr 2010 11:36:46 +0000 (11:36 +0000)]
2010-04-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Render clip in summary bar using "arc", not "quadraticCurveTo".

        https://bugs.webkit.org/show_bug.cgi?id=38107

        * inspector/front-end/SummaryBar.js:
        (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill):
        (WebInspector.SummaryBar.prototype._drawSummaryGraph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Mon, 26 Apr 2010 11:32:09 +0000 (11:32 +0000)]
2010-04-26  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Fix compilation against Qt 4.7

        Some QtMultimedia things have been moved into QtMediaServices
        https://bugs.webkit.org/show_bug.cgi?id=38111

        * WebCore.pro:
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivate::supportsType):
        (WebCore::MediaPlayerPrivate::totalBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Mon, 26 Apr 2010 11:23:02 +0000 (11:23 +0000)]
2010-04-26  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Add expected results after r58228
        https://bugs.webkit.org/show_bug.cgi?id=38098

        * platform/qt/Skipped:
        * platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
        * platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
        * platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoc
jorlow@chromium.org [Mon, 26 Apr 2010 11:01:59 +0000 (11:01 +0000)]
c

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Zoltan Herczeg <zherczeg@webkit.org>
eric@webkit.org [Mon, 26 Apr 2010 10:05:10 +0000 (10:05 +0000)]
2010-04-26  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Dirk Schulze.

        Call setStrokeStyle in applyStrokeStyleToContext
        https://bugs.webkit.org/show_bug.cgi?id=37849

        Not all platforms set the stroke style to solid if they
        get an empty line dash array. Some just ignore the operation.

        * rendering/SVGRenderSupport.cpp:
        (WebCore::applyStrokeStyleToContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 26 Apr 2010 09:35:00 +0000 (09:35 +0000)]
2010-04-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Aggregated stats of time spent in children records should be visible
        in the popup panel of parent record. Crash in pushGCEventRecord also was fixed.
        https://bugs.webkit.org/show_bug.cgi?id=37820

        * English.lproj/localizedStrings.js:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::pushGCEventRecords):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.prototype._createRootRecord):
        (WebInspector.TimelinePanel.prototype._showPopover):
        (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
        (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
        (WebInspector.TimelineRecordGraphRow):
        (WebInspector.TimelineRecordGraphRow.prototype.update):
        (WebInspector.TimelinePanel.FormattedRecord):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
        * inspector/front-end/inspector.css:
        (.timeline-graph-bar.with-children):
        (.timeline-graph-bar.cpu):
        (.timeline-aggregated-category):
        (.timeline-loading):
        (.timeline-scripting):
        (.timeline-rendering):
        (.popover .timeline-aggregated-category.timeline-loading):
        (.timeline-details-title):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 26 Apr 2010 08:23:47 +0000 (08:23 +0000)]
2010-04-26  Tony Chang  <tony@chromium.org>

        Not reviewed, removing duplicate expectations.

        [chromium] Check and rebaseline SVG test expectations for Chromium
        https://bugs.webkit.org/show_bug.cgi?id=38106

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Roll out r58237 and r58238 because of Chromium/Linux build break.
tkent@chromium.org [Mon, 26 Apr 2010 08:23:15 +0000 (08:23 +0000)]
Unreviewed. Roll out r58237 and r58238 because of Chromium/Linux build break.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Mon, 26 Apr 2010 08:02:47 +0000 (08:02 +0000)]
2010-04-26  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, Chromium test expectation change.

        Change SVG test expectations for Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=38106

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewd. Chromium build fix for r58237.
tkent@chromium.org [Mon, 26 Apr 2010 07:56:32 +0000 (07:56 +0000)]
    Unreviewd.  Chromium build fix for r58237.

        * DEPS: Add third_party/mesa

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-26 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 26 Apr 2010 07:33:41 +0000 (07:33 +0000)]
2010-04-26  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Enable Windows project generation
        https://bugs.webkit.org/show_bug.cgi?id=38103

        - Bump the Chromium revision to r45515 to have GYP r818, which fixes
          a Windows project generation bug.
        - Avoid platform.system(), which causes a crash with python.exe in
          depot_tools. Use sys.platform instead.
        - Process DumpRenderTree.gyp on all platforms.

        * DEPS:
        * gyp_webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 26 Apr 2010 07:07:15 +0000 (07:07 +0000)]
2010-04-25  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        WebKit crashes with deeply nested divs.
        https://bugs.webkit.org/show_bug.cgi?id=18282

        Add a test for deeply nested <span> elements like block-nesting-cap.html.

        * fast/parser/element-nesting-cap-expected.txt: Added.
        * fast/parser/element-nesting-cap.html: Added.
        * fast/parser/script-tests/element-nesting-cap.js: Added.
2010-04-25  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        WebKit crashes with deeply nested divs
        https://bugs.webkit.org/show_bug.cgi?id=18282

        The HTML parser caps a tree depth by MAX_DOM_TREE_DEPTH defined in
        TreeDepthLimit.h. This is performance-efficient, but does not work for
        DOM operations such as Node.appendChild().

        Test: fast/parser/element-nesting-cap.html

        * dom/Node.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::pushCurrentNode):
        * html/HTMLParser.cpp:

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/TreeDepthLimit.h:
          Added. Define MAX_DOM_TREE_DEPTH. The default value is 5000.
        * dom/XMLTokenizer.cpp: Use maxDOMTreeDepth.
        (WebCore::XMLTokenizer::pushCurrentNode):
        * html/HTMLParser.cpp:
          Introduce m_treeDepth, which counts the depth of the tree.
          Unlike m_blocksInStack, it contains the number of non-block nodes.
        (WebCore::HTMLParser::HTMLParser):
        (WebCore::HTMLParser::reset):
        (WebCore::HTMLParser::limitDepth):
          Renamed from limitBlockDepth. Add check for m_nodeDepth.
        (WebCore::HTMLParser::insertNodeAfterLimitDepth):
          Renamed from insertNodeAfterLimitBlockDepth.
        (WebCore::HTMLParser::parseToken):
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        (WebCore::HTMLParser::pushBlock):
        (WebCore::HTMLParser::popOneBlockCommon):
        (WebCore::HTMLParser::freeBlock):
        * html/HTMLParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Mon, 26 Apr 2010 06:49:26 +0000 (06:49 +0000)]
2010-04-25  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, Chromium test expectation change.

        Rebaseline test expectation for Chromium.
        The following tests pass for Chromium.

        https://bugs.webkit.org/show_bug.cgi?id=38083

        * platform/chromium/fast/js/ToNumber-expected.txt: Added.
        * platform/chromium/fast/js/parseFloat-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 26 Apr 2010 06:45:20 +0000 (06:45 +0000)]
2010-04-25  Tony Chang  <tony@chromium.org>

        Not reviewed, trying to get the chromium bots green.
        Adding image diffs to pixel tests.

        REGRESSION(r58191): Caret moved a pixel, pixel tests failing
        https://bugs.webkit.org/show_bug.cgi?id=38104

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 26 Apr 2010 06:12:49 +0000 (06:12 +0000)]
2010-04-25  Tony Chang  <tony@chromium.org>

        Not reviewed, trying to get the chromium bots
        green.

        https://bugs.webkit.org/show_bug.cgi?id=38099
        Rebaseline a new test and add another new test to the
        expected fail list on windows and linux.

        * platform/chromium-linux/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
        * platform/chromium-linux/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
        * platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
        * platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
        * platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Mon, 26 Apr 2010 05:56:49 +0000 (05:56 +0000)]
2010-04-25  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, Chromium test expectation change.

        editing/inserting/caret-position.html is expected to fail for Chromium.
        This is because TextInputController::firstRectForCharacterRange is unimplemented for Chromium.

        https://bugs.webkit.org/show_bug.cgi?id=38100

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Sun, 25 Apr 2010 22:03:59 +0000 (22:03 +0000)]
Reviewed by Kevin Ollivier.

Update focus handling code to match current approaches used by other platforms,
and fix focus handling for corner cases such as when a mouse down pops up a dialog.

https://bugs.webkit.org/show_bug.cgi?id=38086

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sun, 25 Apr 2010 16:16:58 +0000 (16:16 +0000)]
2010-04-25  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Simon Hausmann.

        [Qt] layoutTestController.counterValueForElementById crashes for a nonexistent ID
        https://bugs.webkit.org/show_bug.cgi?id=34573

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::counterValueForElementById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 Andrey Kosyakov <caseq@chromium.org>
abarth@webkit.org [Sun, 25 Apr 2010 15:46:58 +0000 (15:46 +0000)]
2010-04-25  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Adam Barth.

        Added tests for pages event handlers being called with
        page context when an event is dispatched from an isolated
        world.
        https://bugs.webkit.org/show_bug.cgi?id=37947

        * http/tests/security/isolatedWorld/dispatchEvent-expected.txt: Added.
        * http/tests/security/isolatedWorld/dispatchEvent.html: Added.
2010-04-25  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Adam Barth.

        Get context properly when event handler was created on
        the main world.
        https://bugs.webkit.org/show_bug.cgi?id=37947

        Test: http/tests/security/isolatedWorld/dispatchEvent.html

        * bindings/v8/WorldContextHandle.cpp:
        (WebCore::WorldContextHandle::adjustedContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 yael aharon <yael.aharon@nokia.com>
eric@webkit.org [Sun, 25 Apr 2010 13:52:18 +0000 (13:52 +0000)]
2010-04-25  yael aharon  <yael.aharon@nokia.com>

        Reviewed by Adele Peterson.

        Allow styling of HTMLProgressElement.
        https://bugs.webkit.org/show_bug.cgi?id=37901

        Added a test for changing the -webkit-appearance statically and dynamically.

        * fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/fast/dom/HTMLProgressElement: Added.
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-04-25  yael aharon  <yael.aharon@nokia.com>

        Reviewed by Adele Peterson.

        Allow styling of HTMLProgressElement.
        https://bugs.webkit.org/show_bug.cgi?id=37901

        Added a new pseudo element to represent the value portion of the progress element.
        Web developers can style this pseudo element separate from the rest of the progress element.

        Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        * css/CSSValueKeywords.in:
        * platform/ThemeTypes.h:
        * rendering/RenderProgress.cpp:
        (WebCore::ProgressValueElement::isShadowNode):
        (WebCore::ProgressValueElement::shadowParentNode):
        (WebCore::ProgressValueElement::ProgressValueElement):
        (WebCore::RenderProgress::RenderProgress):
        (WebCore::RenderProgress::~RenderProgress):
        (WebCore::RenderProgress::layout):
        (WebCore::RenderProgress::styleDidChange):
        (WebCore::RenderProgress::updateFromElement):
        (WebCore::RenderProgress::updateValuePartState):
        (WebCore::RenderProgress::createStyleForValuePart):
        (WebCore::RenderProgress::updateAnimationState):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isControlStyled):
        * rendering/RenderProgress.h:
        * rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-25 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Sun, 25 Apr 2010 11:37:44 +0000 (11:37 +0000)]
2010-04-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: inspector client shouldn't check if it can be opened
        docked if it is already in that state.

        https://bugs.webkit.org/show_bug.cgi?id=37946

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorFrontendClient::WebInspectorFrontendClient):
        (WebInspectorFrontendClient::showWindowWithoutNotifications):
        * WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Sun, 25 Apr 2010 06:44:12 +0000 (06:44 +0000)]
2010-04-24  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Sam Weinig.

        Typo in Geolocation code causes crashes when updates are stopped
        https://bugs.webkit.org/show_bug.cgi?id=38089
        <rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation

        * WebCoreSupport/WebGeolocationControllerClient.cpp:
        (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix log message.
darin@apple.com [Sun, 25 Apr 2010 05:06:13 +0000 (05:06 +0000)]
Fix log message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 25 Apr 2010 05:00:38 +0000 (05:00 +0000)]
2010-04-24  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
        https://bugs.webkit.org/show_bug.cgi?id=38083
        rdar://problem/7901044

        Tests: fast/js/ToNumber.html
               fast/js/parseFloat.html

        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::parseInt): Added a FIXME comment about a problem I noticed.
        (JSC::parseFloat): Added a FIXME comment about a problem I noticed;
        covered by test cases in the test I added.
        * runtime/UString.cpp:
        (JSC::UString::toDouble): Added FIXME comments about two problem I
        noticed; covered by test cases in the tests I added. Added a return
        statement so we don't crash when illegal UTF-16 sequences are present.
2010-04-24  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
        https://bugs.webkit.org/show_bug.cgi?id=38083
        rdar://problem/7901044

        * fast/js/parseFloat-expected.txt: Added.
        * fast/js/parseFloat.html: Added.
        * fast/js/script-tests/parseFloat.js: Added.

        * fast/js/ToNumber-expected.txt: Added.
        * fast/js/ToNumber.html: Added.
        * fast/js/script-tests/ToNumber.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd platform-specific results for Mac after r58222.
mitz@apple.com [Sun, 25 Apr 2010 00:47:31 +0000 (00:47 +0000)]
Add platform-specific results for Mac after r58222.

* platform/mac/compositing/iframes: Added.
* platform/mac/compositing/iframes/composited-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't propagate compositing out of iframes on Mac
mitz@apple.com [Sat, 24 Apr 2010 23:59:37 +0000 (23:59 +0000)]
Don't propagate compositing out of iframes on Mac
https://bugs.webkit.org/show_bug.cgi?id=38072

Patch by Simon Fraser <simon.fraser@apple.com> on 2010-04-24
Reviewed by Dan Bernstein.

Propagating compositing out of iframes caused too many regressions on Mac,
so only do it for other platforms that may need to hook compositing layers
together across iframe boundaries.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME...
mitz@apple.com [Sat, 24 Apr 2010 21:54:08 +0000 (21:54 +0000)]
<rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types
https://bugs.webkit.org/show_bug.cgi?id=38085

Reviewed by Darin Adler.

WebView was calling -_webView in a few places where it should have just used itself. It never
makes sense for WebView to call -_webView on itself, and these calls look like they were copied
from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different,
useful meaning.

* WebView/WebView.mm:
(-[WebView drawSingleRect:]): Replaced [self _webView] with self.
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences]
with _private->preferences.
(-[WebView _canShowMIMEType:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Sat, 24 Apr 2010 17:53:24 +0000 (17:53 +0000)]
2010-04-24  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

        Former implementation attempted to use AtomicString(HashTableDeletedValue)
        however those values cannot be used that way: one cannot construct
        QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
        in the table, for example.
        https://bugs.webkit.org/show_bug.cgi?id=37722

        * wtf/RefPtr.h: expose hash table deleted value
2010-04-24  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

        Former implementation attempted to use AtomicString(HashTableDeletedValue)
        however those values cannot be used that way: one cannot construct
        QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
        in the table, for example.
        https://bugs.webkit.org/show_bug.cgi?id=37722

        * dom/QualifiedName.cpp:
        (WebCore::QualifiedName::deref): check that hash table deleted values never derefed
        * dom/QualifiedName.h:
        (WebCore::QualifiedName::QualifiedName): add a constructor to create hash table deleted values
        (WebCore::QualifiedName::isHashTableDeletedValue): add a check if given instance is hash table deleted value
        (WTF::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoprotocolHostAndPortEquals host check makes a wrong assumption
jchaffraix@webkit.org [Sat, 24 Apr 2010 16:40:49 +0000 (16:40 +0000)]
protocolHostAndPortEquals host check makes a wrong assumption
https://bugs.webkit.org/show_bug.cgi?id=37777

Reviewed by Alexey Proskuryakov.

WebCore:

The host check assumed that both host started at the same position. This is true
if both URL are the same but sometimes one has credential and the other does not.
In this case, the method would compare invalid positions.

Test: http/tests/appcache/credential-url.html

* platform/KURL.cpp:
(WebCore::protocolHostAndPortAreEqual):
* platform/KURLGoogle.cpp:
(WebCore::protocolHostAndPortAreEqual):
Fix the host check to take both URL's credential into account.

LayoutTests:

Add a check that the URL with credential matches the current URL.

* http/tests/appcache/credential-url-expected.txt: Added.
* http/tests/appcache/credential-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add more support for textInputController
robert@webkit.org [Sat, 24 Apr 2010 14:43:28 +0000 (14:43 +0000)]
[Qt] Add more support for textInputController

2010-04-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add more support for textInputController

        Add support for selectedRange(), setMarkedText(), insertText(),
        and firstRectForCharacterRange().

        Unskip tests:

        fast/forms/input-maxlength-ime-preedit.html
        fast/forms/input-maxlength-ime-completed.html
        fast/text/international/thai-cursor-position.html
        fast/events/ime-composition-events-001.html
        editing/selection/5825350-1.html
        editing/selection/5825350-2.html
        editing/selection/mixed-editability-10.html

        https://bugs.webkit.org/show_bug.cgi?id=35702

        * platform/qt/Skipped:

2010-04-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add more support for textInputController

        Add support for selectedRange(), setMarkedText(), insertText(),
        and firstRectForCharacterRange().

        Unskip tests:

        fast/forms/input-maxlength-ime-preedit.html
        fast/forms/input-maxlength-ime-completed.html
        fast/text/international/thai-cursor-position.html
        fast/events/ime-composition-events-001.html
        editing/selection/5825350-1.html
        editing/selection/5825350-2.html
        editing/selection/mixed-editability-10.html

        https://bugs.webkit.org/show_bug.cgi?id=35702

        * DumpRenderTree/qt/TextInputControllerQt.cpp:
        (TextInputController::setMarkedText):
        (TextInputController::insertText):
        (TextInputController::selectedRange):
        (TextInputController::firstRectForCharacterRange):
        * DumpRenderTree/qt/TextInputControllerQt.h:

2010-04-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add more support for textInputController

        Add support for selectedRange(), setMarkedText(), insertText(),
        and firstRectForCharacterRange().

        https://bugs.webkit.org/show_bug.cgi?id=35702

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::selectedRange):
        (DumpRenderTreeSupportQt::firstRectForCharacterRange):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 13:48:33 +0000 (13:48 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Attempt to turn the last core builder green again (not related anymore to my previous SVG checkins :-)
        Skip http/tests/media/video-play-stall-seek.html on Windows as well (just like it has been done for Mac in r58107).
        Bug https://bugs.webkit.org/show_bug.cgi?id=38000 describes the problem, and says it's ok to skip the test.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 13:37:47 +0000 (13:37 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add new results for all SVG tests that were missing on Gtk/Qt (since a while, just took the opportunity to add them now)

        * platform/gtk/svg/custom/broken-internal-references-expected.txt: Added.
        * platform/gtk/svg/custom/clip-path-id-changes-expected.txt: Added.
        * platform/qt/svg/custom/broken-internal-references-expected.txt: Added.
        * platform/qt/svg/custom/clip-path-id-changes-expected.txt: Added.
        * platform/qt/svg/custom/mask-on-multiple-objects-expected.txt: Added.
        * platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
        * platform/qt/svg/filters/feColorMatrix-values-expected.txt: Added.
        * platform/qt/svg/filters/filter-clip-expected.txt: Added.
        * platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
        * platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 13:01:26 +0000 (13:01 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update Qt SVG results, and a weird fast/xpath change (newline added).

        * fast/xpath/namespace-vs-predicate-expected.txt:
        * platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/qt/svg/css/mask-with-shadow-expected.txt:
        * platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
        * platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
        * platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
        * platform/qt/svg/custom/pattern-skew-transformed-expected.txt:
        * platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
        * platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
        * platform/qt/svg/filters/feTile-expected.txt:
        * platform/qt/svg/text/selection-background-color-expected.txt:
        * platform/qt/svg/text/selection-styles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 12:47:00 +0000 (12:47 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix linkage on several bots (no idea, why it worked in a from-scratch rebuild on Leopard on my machine!) -> include NodeRenderStyle.h
        Having to include NodeRenderStyle.h just to pull in the renderStyle() is a crazy concept, but I see what it tries to avoid (including RenderObject.h in Node.h)

        * rendering/SVGRenderSupport.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 12:35:44 +0000 (12:35 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix release builds, wrap resourceMode assertion in NDEBUG blocks, use UNUSED_PARAM() otherwhise.

        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyResource):
        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::applyResource):
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 11:42:46 +0000 (11:42 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGPaintServer needs to be converted to the new RenderSVGResource* system
        https://bugs.webkit.org/show_bug.cgi?id=37986

        Huge speedup for SVG painting using paint servers (gradient/patterns). Cache underlying
        WebCore::Gradient/Pattern datastructures, do not rebuild them on every painting. This marks
        the finish of the SVGResource -> RenderSVGResource transition.

        Outline of same key changes:
        - RenderSVGResource is an abstract base class now, and the previous class is now named RenderSVGResourceContainer
          All resources except RenderSVGResourceSolidColor now inherit from RenderSVGResourceContainer, as they are all
          associated with a SVG*Element class. RenderSVGResourceSolidColor inherits from RenderSVGResource, and is not
          associated with any SVG*Element class. RenderSVGResourceSolidColor is not a render tree object, despite its name.
          The reason for that is consistency with all other painting resources.
        - RenderSVGResourceSolidColor does not live in the render tree, and exists only as static object, which is shared
          and always used when filling/stroking with solid colors - just like the old SVGPaintServerSolid.
        - RenderSVGResourceGradient/RenderSVGResourcePattern now store the underlying WebCore::Gradient/Pattern object
          instead of rebuilding it everytime we're asked to paint -> this is the main difference with the old concept, leading
          to much faster speed.
        - SVGResource has vanished. All resources (clipper/filter/marker/masker/gradient/pattern) now share the same codepaths
          to handle updates and client invalidation - which is a huge benefit, and makes the code easier to understand.

        * Android.mk: Remove svg/graphics/SVGResource*, svg/graphics/SVGPaintServer.h from build.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/graphics/Gradient.cpp: Add addColorStop() method taking a ColorStop const-reference.
        (WebCore::Gradient::addColorStop):
        * platform/graphics/Gradient.h: Ditto.
        * platform/graphics/TextRun.h: Rename SVGPaintServer to RenderSVGResource
        (WebCore::TextRun::TextRun):
        (WebCore::TextRun::activePaintingResource): Renamed from activePaintServer.
        (WebCore::TextRun::setActivePaintingResource): Renamed from setActivePaintServer.
        * platform/graphics/win/GraphicsContextWin.cpp: Remove references to SVGResourceImage, which was removed a long time ago.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::toRenderSVGResourceContainer): Renamed from toRenderSVGResource().
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isSVGGradientStop): Added.
        (WebCore::RenderObject::isSVGResourceContainer): Renamed from isSVGResource().
        * rendering/RenderPath.cpp: Utilize RenderSVGResource::fill/strokePaintingResource to request paint servers, instead of SVGPaintServer.
        (WebCore::RenderPath::fillContains): Adapt to new concept.
        (WebCore::RenderPath::strokeContains): Ditto.
        (WebCore::fillAndStrokePath): Ditto.
        (WebCore::RenderPath::paint): Ditto.
        * rendering/RenderSVGGradientStop.cpp:
        (WebCore::RenderSVGGradientStop::styleDidChange): Ditto.
        * rendering/RenderSVGGradientStop.h: Fixed indention.
        * rendering/RenderSVGResource.cpp: Refactored old SVGPaintServer code to request fill/stroke painting resources, splitted up in several methods to aid readability.
        (WebCore::registerPendingResource):
        (WebCore::adjustColorForPseudoRules):
        (WebCore::RenderSVGResource::fillPaintingResource):
        (WebCore::RenderSVGResource::strokePaintingResource):
        (WebCore::RenderSVGResource::sharedSolidPaintingResource):
        (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation):
        * rendering/RenderSVGResource.h: Make RenderSVGResource an abstract base class, see above for the reasoning.
        (WebCore::RenderSVGResource::RenderSVGResource):
        (WebCore::RenderSVGResource::~RenderSVGResource):
        (WebCore::RenderSVGResource::postApplyResource):
        * rendering/RenderSVGResourceClipper.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
        (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper):
        (WebCore::RenderSVGResourceClipper::invalidateClient):
        (WebCore::RenderSVGResourceClipper::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters)
        (WebCore::RenderSVGResourceClipper::applyClippingToContext):
        * rendering/RenderSVGResourceClipper.h:
        * rendering/RenderSVGResourceContainer.h: Added. Renamed from RenderSVGResource. Now inherits from RenderSVGHiddenContainer and RenderSVGResource.
        (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
        (WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer):
        (WebCore::RenderSVGResourceContainer::idChanged):
        (WebCore::RenderSVGResourceContainer::isSVGResourceContainer):
        (WebCore::RenderSVGResourceContainer::drawsContents):
        (WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer):
        (WebCore::getRenderSVGResourceContainerById):
        (WebCore::getRenderSVGResourceById):
        * rendering/RenderSVGResourceFilter.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
        (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
        (WebCore::RenderSVGResourceFilter::invalidateClient):
        (WebCore::RenderSVGResourceFilter::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters)
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/RenderSVGResourceFilter.h:
        * rendering/RenderSVGResourceGradient.cpp: Moved from SVGPaintServerGradient, cleaned up and refactored.
        (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
        (WebCore::RenderSVGResourceGradient::~RenderSVGResourceGradient):
        (WebCore::RenderSVGResourceGradient::invalidateClients):
        (WebCore::RenderSVGResourceGradient::invalidateClient):
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourceGradient.h:
        (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
        * rendering/RenderSVGResourceLinearGradient.cpp: Moved from SVGPaintServerLinearGradient, cleaned up and refactored.
        (WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient):
        (WebCore::RenderSVGResourceLinearGradient::~RenderSVGResourceLinearGradient):
        (WebCore::RenderSVGResourceLinearGradient::buildGradient):
        * rendering/RenderSVGResourceLinearGradient.h:
        (WebCore::RenderSVGResourceLinearGradient::renderName):
        (WebCore::RenderSVGResourceLinearGradient::resourceType):
        * rendering/RenderSVGResourceMarker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
        (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker):
        (WebCore::RenderSVGResourceMarker::invalidateClient):
        * rendering/RenderSVGResourceMarker.h:
        (WebCore::RenderSVGResourceMarker::applyResource):
        * rendering/RenderSVGResourceMasker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
        (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
        (WebCore::RenderSVGResourceMasker::invalidateClient):
        (WebCore::RenderSVGResourceMasker::applyResource):
        * rendering/RenderSVGResourceMasker.h:
        (WebCore::MaskerData::MaskerData):
        * rendering/RenderSVGResourcePattern.cpp: Moved from SVGPaintServerPattern, cleaned up and refactored.
        (WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):
        (WebCore::RenderSVGResourcePattern::~RenderSVGResourcePattern):
        (WebCore::RenderSVGResourcePattern::invalidateClients):
        (WebCore::RenderSVGResourcePattern::invalidateClient):
        (WebCore::RenderSVGResourcePattern::applyResource):
        (WebCore::RenderSVGResourcePattern::postApplyResource):
        (WebCore::calculatePatternBoundaries):
        (WebCore::RenderSVGResourcePattern::calculatePatternBoundariesIncludingOverflow):
        (WebCore::RenderSVGResourcePattern::createTileImage):
        (WebCore::RenderSVGResourcePattern::buildPattern):
        * rendering/RenderSVGResourcePattern.h:
        (WebCore::RenderSVGResourcePattern::renderName):
        (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
        (WebCore::RenderSVGResourcePattern::resourceType):
        * rendering/RenderSVGResourceRadialGradient.cpp: Moved from SVGPaintServerRadialGradient, cleaned up and refactored.
        (WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient):
        (WebCore::RenderSVGResourceRadialGradient::~RenderSVGResourceRadialGradient):
        (WebCore::RenderSVGResourceRadialGradient::buildGradient):
        * rendering/RenderSVGResourceRadialGradient.h:
        (WebCore::RenderSVGResourceRadialGradient::renderName):
        (WebCore::RenderSVGResourceRadialGradient::resourceType):
        * rendering/RenderSVGResourceSolidColor.cpp: Moved from SVGPaintServerSolid, cleaned up and refactored.
        (WebCore::RenderSVGResourceSolidColor::RenderSVGResourceSolidColor):
        (WebCore::RenderSVGResourceSolidColor::~RenderSVGResourceSolidColor):
        (WebCore::RenderSVGResourceSolidColor::applyResource):
        (WebCore::RenderSVGResourceSolidColor::postApplyResource):
        * rendering/RenderSVGResourceSolidColor.h:
        (WebCore::RenderSVGResourceSolidColor::invalidateClients):
        (WebCore::RenderSVGResourceSolidColor::invalidateClient):
        (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
        (WebCore::RenderSVGResourceSolidColor::resourceType):
        (WebCore::RenderSVGResourceSolidColor::color):
        (WebCore::RenderSVGResourceSolidColor::setColor):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::paint): Early exit if painting is disabled.
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write): Add RenderSVGGradientStop dumping.
        (WebCore::externalRepresentation): Remove SVGResource dumping.
        * rendering/SVGInlineTextBox.cpp: Adapt to SVGPaintServer changes (paint server request).
        (WebCore::SVGInlineTextBox::paintCharacters):
        (WebCore::SVGInlineTextBox::paintDecoration):
        * rendering/SVGInlineTextBox.h: Ditto.
        (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
        * rendering/SVGRenderSupport.cpp: Ditto.
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        (WebCore::invalidatePaintingResource):
        (WebCore::deregisterFromResources):
        (WebCore::dashArrayFromRenderingStyle): Moved here from SVGPaintServer.
        (WebCore::applyStrokeStyleToContext): Ditto.
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp: Add new gradient/pattern dumping code. Stops are now properly dumped as well!
        (WebCore::operator<<):
        (WebCore::writeSVGPaintingResource):
        (WebCore::writeStyle):
        (WebCore::boundingBoxModeString):
        (WebCore::writeCommonGradientProperties):
        (WebCore::writeSVGResourceContainer):
        (WebCore::writeSVGGradientStop):
        * rendering/SVGRenderTreeAsText.h:
        * rendering/SVGRootInlineBox.cpp: Adapt to SVGPaintServer changes (paint server request).
        (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
        (WebCore::SVGRootInlineBoxPaintWalker::~SVGRootInlineBoxPaintWalker):
        (WebCore::SVGRootInlineBoxPaintWalker::teardownFillPaintServer):
        (WebCore::SVGRootInlineBoxPaintWalker::teardownStrokePaintServer):
        (WebCore::SVGRootInlineBoxPaintWalker::setupBackground):
        (WebCore::SVGRootInlineBoxPaintWalker::setupFill):
        (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection):
        (WebCore::SVGRootInlineBoxPaintWalker::setupStroke):
        (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection):
        (WebCore::SVGRootInlineBoxPaintWalker::setupForeground):
        (WebCore::SVGRootInlineBoxPaintWalker::activePaintingResource):
        (WebCore::SVGRootInlineBoxPaintWalker::paintChunk):
        * svg/GradientAttributes.h: Remove SVGGradientStop, use Gradient::ColorStop vector. Cleanup.
        (WebCore::GradientAttributes::stops):
        (WebCore::GradientAttributes::setStops):
        * svg/LinearGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
        * svg/PatternAttributes.h: Add missing includes and class forwards.
        * svg/RadialGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
        * svg/SVGClipPathElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
        (WebCore::SVGClipPathElement::svgAttributeChanged):
        (WebCore::SVGClipPathElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        * svg/SVGClipPathElement.h:
        * svg/SVGDocumentExtensions.cpp: Change HashMaps to hash AtomicStrings instead of Strings. Rename RenderSVGResource to RenderSVGResourceContainer.
        (WebCore::SVGDocumentExtensions::addResource):
        (WebCore::SVGDocumentExtensions::removeResource):
        (WebCore::SVGDocumentExtensions::resourceById):
        (WebCore::SVGDocumentExtensions::addPendingResource):
        * svg/SVGDocumentExtensions.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::insertedIntoDocument): Remove reference to SVGResource::invalidateClients(), handled differently now.
        (WebCore::SVGElement::updateAnimatedSVGAttribute): Change assertion, that is incorrect now.
        * svg/SVGElement.h: Make updateAnimatedSVGAttribute() public.
        * svg/SVGFont.cpp: Adapt to SVGPaintServer changes (paint server request).
        (WebCore::Font::drawTextUsingSVGFont):
        * svg/SVGGElement.cpp: If style()->display() is NONE, create a RenderSVGHiddenContainer, removing hacks in SVGStopElement for pservers-grad-19-b.svg (yes, SVG is crazy.)
        (WebCore::SVGGElement::createRenderer):
        * svg/SVGGElement.h: Remove childrenChanged() method which _always_ called renderer->setNeedsLayout(true), which is completly wrong and unnecessary.
        (WebCore::SVGGElement::rendererIsNeeded): Always return true.
        * svg/SVGGradientElement.cpp: Adapt to new RenderSVGResourceGradient code.
        (WebCore::SVGGradientElement::svgAttributeChanged):
        (WebCore::SVGGradientElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        (WebCore::SVGGradientElement::buildStops):
        * svg/SVGGradientElement.h:
        * svg/SVGLinearGradientElement.cpp: Adapt to new RenderSVGResourceLinearGradient code.
        (WebCore::SVGLinearGradientElement::svgAttributeChanged):
        (WebCore::SVGLinearGradientElement::createRenderer):
        (WebCore::SVGLinearGradientElement::collectGradientProperties):
        (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
        * svg/SVGLinearGradientElement.h:
        * svg/SVGMarkerElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
        (WebCore::SVGMarkerElement::svgAttributeChanged):
        (WebCore::SVGMarkerElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        (WebCore::SVGMarkerElement::setOrientToAuto):
        (WebCore::SVGMarkerElement::setOrientToAngle):
        * svg/SVGMaskElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
        (WebCore::SVGMaskElement::svgAttributeChanged):
        (WebCore::SVGMaskElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        * svg/SVGPatternElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
        (WebCore::SVGPatternElement::svgAttributeChanged):
        (WebCore::SVGPatternElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        (WebCore::SVGPatternElement::createRenderer):
        * svg/SVGPatternElement.h:
        * svg/SVGPolyElement.h: Remove unneded rendererIsNeeded() override.
        * svg/SVGRadialGradientElement.cpp: Adapt to new RenderSVGResourceRadialGradient code.
        (WebCore::SVGRadialGradientElement::svgAttributeChanged):
        (WebCore::SVGRadialGradientElement::createRenderer):
        (WebCore::SVGRadialGradientElement::collectGradientProperties):
        (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
        * svg/SVGRadialGradientElement.h:
        * svg/SVGStopElement.cpp: Clean up code, moved stop color calculation from SVGGradientElement to here, where it belongs.
        (WebCore::SVGStopElement::parseMappedAttribute):
        (WebCore::SVGStopElement::stopColorIncludingOpacity):
        * svg/SVGStopElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::~SVGStyledElement):
        (WebCore::SVGStyledElement::svgAttributeChanged): Only invalidateResourcesInAncestorChain()/deregisterFromResources() when we're not parsing.
        (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain): Early exit if we find a parent resources, there is no resource nesting.
        (WebCore::SVGStyledElement::invalidateResourceClients): Renamed from invalidateCanvasResources()
        (WebCore::SVGStyledElement::childrenChanged): Only invalidate SVGElementInstances when !changedByParser is set.
        * svg/SVGStyledElement.h: Remove canvasResource() logic, remove detach() method.
        * svg/SVGTextPathElement.h:
        * svg/graphics/SVGPaintServer.h: Removed.
        * svg/graphics/SVGResource.cpp: Removed.
        * svg/graphics/SVGResource.h: Removed.
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGPaintServer needs to be converted to the new RenderSVGResource* system
        https://bugs.webkit.org/show_bug.cgi?id=37986

        Rebaseline SVG tests, after the RenderSVGResource transition.

        NOTE: This WILL affect _any_ platform with custom svg results for tests using gradients/patterns.
              That means I have to wait for the bot results, and update them ASAP. Therefore landing out
              of california business hours and on the weekend - please stay tuned I'll fix any breakages soon.
              (Except for chromium whose test results are not available on build.webkit.org, sorry.)

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/batik/masking/maskRegions-expected.txt:
        * platform/mac/svg/batik/paints/gradientLimit-expected.txt:
        * platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
        * platform/mac/svg/batik/paints/patternRegionA-expected.txt:
        * platform/mac/svg/batik/paints/patternRegions-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect2-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/textProperties-expected.txt:
        * platform/mac/svg/carto.net/colourpicker-expected.txt:
        * platform/mac/svg/carto.net/tabgroup-expected.txt:
        * platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/mac/svg/css/mask-with-shadow-expected.txt:
        * platform/mac/svg/custom/broken-internal-references-expected.txt:
        * platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
        * platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
        * platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
        * platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/mac/svg/custom/fill-fallback-expected.txt:
        * platform/mac/svg/custom/gradient-add-stops-expected.txt:
        * platform/mac/svg/custom/gradient-attr-update-expected.txt:
        * platform/mac/svg/custom/gradient-cycle-detection-expected.txt:
        * platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
        * platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
        * platform/mac/svg/custom/gradient-stop-corner-cases-expected.txt:
        * platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
        * platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
        * platform/mac/svg/custom/gradient-stroke-width-expected.png:
        * platform/mac/svg/custom/gradient-stroke-width-expected.txt:
        * platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
        * platform/mac/svg/custom/group-opacity-expected.txt:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-gradient-creation-expected.txt:
        * platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
        * platform/mac/svg/custom/js-update-gradient-expected.checksum:
        * platform/mac/svg/custom/js-update-gradient-expected.png:
        * platform/mac/svg/custom/js-update-gradient-expected.txt:
        * platform/mac/svg/custom/js-update-pattern-child-expected.txt:
        * platform/mac/svg/custom/js-update-pattern-expected.txt:
        * platform/mac/svg/custom/js-update-stop-expected.txt:
        * platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
        * platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
        * platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
        * platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
        * platform/mac/svg/custom/pattern-in-defs-expected.txt:
        * platform/mac/svg/custom/pattern-rotate-expected.txt:
        * platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
        * platform/mac/svg/custom/pattern-skew-transformed-expected.txt:
        * platform/mac/svg/custom/pattern-with-transformation-expected.txt:
        * platform/mac/svg/custom/pattern-y-offset-expected.txt:
        * platform/mac/svg/custom/resource-client-removal-expected.txt:
        * platform/mac/svg/custom/stroke-fallback-expected.txt:
        * platform/mac/svg/custom/stroked-pattern-expected.txt:
        * platform/mac/svg/custom/text-gradient-no-content-expected.txt:
        * platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
        * platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-expected.txt:
        * platform/mac/svg/filters/feDisplacementMap-expected.txt:
        * platform/mac/svg/filters/feTile-expected.txt:
        * platform/mac/svg/filters/filterRes-expected.txt:
        * platform/mac/svg/hixie/error/003-expected.txt:
        * platform/mac/svg/hixie/perf/005-expected.txt:
        * platform/mac/svg/hixie/perf/006-expected.txt:
        * platform/mac/svg/text/selection-background-color-expected.txt:
        * platform/mac/svg/text/selection-styles-expected.txt:
        * platform/mac/svg/text/text-gradient-positioning-expected.txt:
        * platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
        * platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
        * platform/win/svg/custom/broken-internal-references-expected.txt:
        * svg/custom/gradient-with-1d-boundingbox-expected.txt:
        * svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 10:29:00 +0000 (10:29 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add win specific result for svg/custom/broken-internal-references.svg
        It's a bad idea that textPath dumps FLT_MAX when it's not shown - that should be fixed, but it's not related to Moritas testcase.

        * platform/win/svg/custom/broken-internal-references-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 24 Apr 2010 07:03:24 +0000 (07:03 +0000)]
2010-04-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        check-webkit-style complains about non-utf8 data in layout test result
        https://bugs.webkit.org/show_bug.cgi?id=38027

        The problem was we were assuming patch files/diff output as utf-8.
        Turns out they're not.  We have to treat them as binary data because
        a single patch may have multiple text files in it with conflicting encodings!

        * Scripts/webkitpy/common/checkout/api.py:
         - contents_at_revision returns a byte array, so decode it to unicode
           before passing it to parse_latest_entry_from_file
        * Scripts/webkitpy/common/checkout/api_unittest.py:
         - Update our mock mock_contents_at_revision to match the encoding
           semantics of the real one.
        * Scripts/webkitpy/common/checkout/scm.py:
         - Be careful not to decode output which may contain file contents
           (like diff, cat or show) as the encoding for that content is unknown.
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
         - Update our tests to use both latin1 and utf-8 encoded data.
        * Scripts/webkitpy/common/net/bugzilla.py:
         - _fill_attachment_form should not assume unicode data.  Callers
           may wish to attach other types of files to bugs.
        * Scripts/webkitpy/common/prettypatch.py:
         - Diffs are byte arrays, deal with them as such.
        * Scripts/webkitpy/common/prettypatch_unittest.py:
         - Test to make sure we handle diffs with multiple conflicting encodings.
        * Scripts/webkitpy/common/system/executive_unittest.py:
         - Make sure that our unicode support does not break our
           byte array input support for run_command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Sat, 24 Apr 2010 05:17:18 +0000 (05:17 +0000)]
2010-04-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Add isGLES2Compliant to GraphicsContext3D: make the method const.
        https://bugs.webkit.org/show_bug.cgi?id=37872

        * platform/graphics/GraphicsContext3D.h: Make isGLES2Compliant() const.
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
        (WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Add isGLES2Compliant to GraphicsContext3D: make the method const.
        https://bugs.webkit.org/show_bug.cgi?id=37872

        * src/GraphicsContext3D.cpp: Make isGLES2Compliant() const.
        (WebCore::GraphicsContext3DInternal::isGLES2Compliant):
        (WebCore::GraphicsContext3D::isGLES2Compliant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Ben Murdoch <benm@google.com>
eric@webkit.org [Sat, 24 Apr 2010 03:36:47 +0000 (03:36 +0000)]
2010-04-23  Ben Murdoch  <benm@google.com>

        Reviewed by Jeremy Orlow.

        [Android] The touchmove delta used in basic-single-touch-events.html is too small for Android
        https://bugs.webkit.org/show_bug.cgi?id=38056

        * fast/events/touch/basic-single-touch-events-expected.txt:
            - update the test expected output
        * fast/events/touch/script-tests/basic-single-touch-events.js:
        (verifyTouch): update test expectation with new coordinates.
        (singleTouchSequence): increase the touch move delta.
        (touchTargets): Start the touch at a different point to
                 singleTouchSequence to make examining behavior easier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Qi Zhang <qi.2.zhang@nokia.com>
eric@webkit.org [Sat, 24 Apr 2010 03:27:37 +0000 (03:27 +0000)]
2010-04-23  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
        https://bugs.webkit.org/show_bug.cgi?id=37276

        pointInPath.html passed because the expected.txt expect it fail, it is wrong.

        * platform/qt/fast/canvas/pointInPath-expected.txt: Removed.
2010-04-23  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
        https://bugs.webkit.org/show_bug.cgi?id=37276

        QPainterPath::contains doesn't count the point on the bound.

        * platform/graphics/qt/PathQt.cpp:
        (WebCore::isPointOnPathBorder):
        (WebCore::Path::contains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38060
weinig@apple.com [Sat, 24 Apr 2010 01:07:37 +0000 (01:07 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
Split up Threading.h

Reviewed by David Levin.

JavaScriptCore:

Move bits for of Threading.h into 3 new files.
- Atomics.h for atomic operations.
- ThreadSafeShared.h for the ThreadSafeShared class.
- ThreadingPrimitives.h for the primitives and platform types.

Basic threading operations (creation, etc.) remain in Threading.h.

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Atomics.h: Copied from wtf/Threading.h.
* wtf/ThreadSafeShared.h: Copied from wtf/Threading.h.
* wtf/Threading.h:
* wtf/ThreadingPrimitives.h: Copied from wtf/Threading.h.

JavaScriptGlue:

Add necessary forwarding headers.

* ForwardingHeaders/wtf/Atomics.h: Added.
* ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
* ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

WebCore:

Add necessary forwarding headers.

* ForwardingHeaders/wtf/Atomics.h: Added.
* ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
* ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

WebKitTools:

Add necessary forwarding headers.

* DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
* DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
* DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Rafael Weinstein <rafaelw@grafaelw.sfo.corp.google.com>
eric@webkit.org [Sat, 24 Apr 2010 01:05:02 +0000 (01:05 +0000)]
2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>

        Reviewed by Darin Fisher.

        This patch adds a vector of additionalFeatures to WindowFeatures
        and populates it with any feature strings that evaluate to "yes"
        and aren't directly observed in WindowFeatures. This allows
        clients to capture experimental window features.

        https://bugs.webkit.org/show_bug.cgi?id=38013

        * page/WindowFeatures.cpp:
        (WebCore::WindowFeatures::setWindowFeature):
        * page/WindowFeatures.h:
2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>

        Reviewed by Darin Fisher.

        This patch adds a WebWindowFeatures binding struct for the
        chromium client in anticipation of a follow-on patch which will
        pass it to WebViewClient::createWindow.

        https://bugs.webkit.org/show_bug.cgi?id=38013

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h: Added.
        (WebKit::WebWindowFeatures::WebWindowFeatures):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Sat, 24 Apr 2010 00:54:14 +0000 (00:54 +0000)]
2010-04-23  Xiaomei Ji  <xji@chromium.org>

        No need to review.

        Add xji as committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 24 Apr 2010 00:48:57 +0000 (00:48 +0000)]
2010-04-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        ASSERT(willBeComposited == needsToBeComposited(layer)); on gmail.com
        https://bugs.webkit.org/show_bug.cgi?id=38066

        When a layer goes into compositing mode because it has a negative z-index child that is going
        into compositing mode, then set willBeComposited to true. Also add another assertion to catch
        any other cases where the state of willBeComposited is mismanaged.

        Test: compositing/composited-negative-zindex-child.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::computeCompositingRequirements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 24 Apr 2010 00:48:51 +0000 (00:48 +0000)]
2010-04-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        <rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint

        When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
        NPPrint with a GWorldPtr, since Flash prefers the CGContext path.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58202 268f45cc-cd09-0410-ab3c-d52691b4dbfc