WebKit-https.git
12 years ago2008-03-26 Timothy Hatcher <timothy@apple.com>
timothy@apple.com [Thu, 27 Mar 2008 07:12:14 +0000 (07:12 +0000)]
2008-03-26  Timothy Hatcher  <timothy@apple.com>

        Rename some Inspector files to facilitate the up-coming UI refresh changes.

        http://bugs.webkit.org/show_bug.cgi?id=17773

        Rubber-stamped by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj:
        * page/inspector/Console.js: Copied from page/inspector/ConsolePanel.js.
        * page/inspector/ConsolePanel.js: Removed.
        * page/inspector/DocumentPanel.js: Removed.
        * page/inspector/ElementsPanel.js: Copied from page/inspector/DocumentPanel.js.
        * page/inspector/FontPanel.js: Removed.
        * page/inspector/FontView.js: Copied from page/inspector/FontPanel.js.
        * page/inspector/ImagePanel.js: Removed.
        * page/inspector/ImageView.js: Copied from page/inspector/ImagePanel.js.
        * page/inspector/NetworkPanel.js: Removed.
        * page/inspector/ResourcePanel.js: Removed.
        * page/inspector/ResourceView.js: Copied from page/inspector/ResourcePanel.js.
        * page/inspector/ResourcesPanel.js: Copied from page/inspector/NetworkPanel.js.
        * page/inspector/SourcePanel.js: Removed.
        * page/inspector/SourceView.js: Copied from page/inspector/SourcePanel.js.
        * page/inspector/WebKit.qrc:
        * page/inspector/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 27 Mar 2008 06:44:56 +0000 (06:44 +0000)]
2008-03-26  Steve Falkenburg  <sfalken@apple.com>

        Enable LTCG on css, dom files in WebCore

        Reviewed by Stephanie.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago 2008-03-26 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 27 Mar 2008 06:24:35 +0000 (06:24 +0000)]
 2008-03-26  Stephanie Lewis  <slewis@apple.com>

         Fix Windows Build

         * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeculative GTK build fix.
mrowe@apple.com [Thu, 27 Mar 2008 06:01:31 +0000 (06:01 +0000)]
Speculative GTK build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 27 Mar 2008 05:16:44 +0000 (05:16 +0000)]
2008-03-26  Brady Eidson  <beidson@apple.com>

        Build fix - accidentally checked in this change which was work in progress

        * DOM/WebDOMOperations.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMac build fix.
mrowe@apple.com [Thu, 27 Mar 2008 04:59:06 +0000 (04:59 +0000)]
Mac build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 27 Mar 2008 04:36:04 +0000 (04:36 +0000)]
2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        More screenshots for teh blog.

        * blog-files/acid3-full-rendering-pass.png: Added.
        * blog-files/acid3-rendering-reference.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 27 Mar 2008 04:33:45 +0000 (04:33 +0000)]
2008-03-26  Sam Weinig  <sam@webkit.org>

        Try and fix Gtk+ again.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Thu, 27 Mar 2008 04:13:47 +0000 (04:13 +0000)]
    Reviewed by Dave Hyatt.

        - fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren()
        on the new node.
        (WebCore::HTMLParser::handleError): Ditto.
        (WebCore::HTMLParser::reopenResidualStyleTags): Ditto.
        (WebCore::HTMLParser::pushBlock): Removed incorrect call to
        beginParsingChildren() on the current node.
        * manual-tests/applet-finish-parsing-children.html: Added.
        * manual-tests/resources/DrawMessage.class: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 27 Mar 2008 04:08:17 +0000 (04:08 +0000)]
WebCore:

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        When we create a WebArchive, we walk every node from some starting point, asking each node
        along the way "What are your subresource URLs?"

        That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
        WebCore::Node

        * WebCore.base.exp:

        * dom/Node.cpp:
        (WebCore::Node::getSubresourceURLs):
        (WebCore::Node::getSubresourceAttributeStrings):  Virtual and empty.  Subclasses of Node that have
          subresources will override it.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
        * dom/ProcessingInstruction.h:
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
        * html/HTMLBodyElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
        * html/HTMLEmbedElement.h:
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
        * html/HTMLImageElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
        * html/HTMLInputElement.h:
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
        * html/HTMLLinkElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
        * html/HTMLObjectElement.h:
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
        * html/HTMLParamElement.h:
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
        * html/HTMLScriptElement.h:
        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
        * html/HTMLTableCellElement.h:
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
        * html/HTMLTableElement.h:
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
        * svg/SVGCursorElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
        * svg/SVGFEImageElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::getSubresourceAttributeStrings):
        * svg/SVGImageElement.h:
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
        * svg/SVGScriptElement.h:

WebKit/mac:

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        When we create a WebArchive, we walk every node from some starting point, asking each node
        along the way "What are your subresource URLs?"

        That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
        WebCore::Node

        * DOM/WebDOMOperations.mm:
        (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
          calling into individual WebCore::Node implementations
        * DOM/WebDOMOperationsPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Thu, 27 Mar 2008 04:02:07 +0000 (04:02 +0000)]
    Reviewed by Dave Hyatt.

        - maintain subpixel-antialiasing when drawing text with a simple shadow

        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawComplexText): If the shadow has a zero blur radius,
        draw the shadow by drawing the text at an offset instead of relying on
        Core Graphics shadows.
        (WebCore::Font::drawGlyphs): Ditto.
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 27 Mar 2008 03:58:19 +0000 (03:58 +0000)]
WebCore:

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        Part of the continued push to move WebArchive-related code down to WebCore, this
        moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

        * WebCore.base.exp:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists
          Otherwise, fallback to an ArchiveResource from the current Archive if any.  Otherwise, return null
        * loader/DocumentLoader.h:

        * loader/archive/ArchiveResource.cpp:
        (WebCore::ArchiveResource::create):
        (WebCore::ArchiveResource::ArchiveResource):
        * loader/archive/ArchiveResource.h:

WebKit/mac:

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        Part of the continued push to move WebArchive-related code down to WebCore, this
        moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader

        * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
          has now been ported down to WebCore
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 27 Mar 2008 03:54:46 +0000 (03:54 +0000)]
2008-03-26  Sam Weinig  <sam@webkit.org>

        Fix Gtk+ build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate FEATURE_DEFINES to be consistent with the other locations in which it is defined.
mrowe@apple.com [Thu, 27 Mar 2008 03:48:29 +0000 (03:48 +0000)]
Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.

Rubber-stamped by Brady Eidson.

* Configurations/JavaScriptCore.xcconfig:
* Configurations/WebCore.xcconfig:
* Configurations/WebKit.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
pewtermoose@webkit.org [Thu, 27 Mar 2008 03:43:30 +0000 (03:43 +0000)]
WebCore:

2008-03-26  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Add necessary files and build commands to vcproj files to
        build a Curl-based Windows WebKit.  For details, see
        http://bugs.webkit.org/show_bug.cgi?id=17985

        * WebCore.vcproj/WebCore.vcproj:

WebKit/win:

2008-03-26  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Add necessary files and build commands to vcproj files to
        build a Curl-based Windows WebKit.  For details, see
        http://bugs.webkit.org/show_bug.cgi?id=17985

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Record JS exceptions triggered by the Inspector's use of JSC
aroben@apple.com [Thu, 27 Mar 2008 03:38:35 +0000 (03:38 +0000)]
    Record JS exceptions triggered by the Inspector's use of JSC

        We now dump all exceptions returned from JavaScriptCore into the
        Inspector's console.

        The HANDLE_EXCEPTION macro records the line on which the exception was
        returned. It calls a new private handleException method on
        InspectorController.

        Reviewed by Kevin McCullough.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::callSimpleFunction): Made this be a
        member of InspectorController so that it can call handleException.
        (WebCore::addSourceToFrame): Pass the exception pointer on to inner
        JSC calls, and check it after those calls return.
        (WebCore::getResourceDocumentNode): Ditto.
        (WebCore::search): Ditto. Also changed the name/type of an existing
        exception variable to ExceptionCode ec.
        (WebCore::databaseTableNames): Ditto.
        (WebCore::moveByUnrestricted): Ditto.
        (WebCore::InspectorController::~InspectorController): Check for and
        record exceptions as we call JSC.
        (WebCore::InspectorController::focusNode): Ditto.
        (WebCore::InspectorController::scriptObjectReady): Ditto.
        (WebCore::addHeaders): Added an exception parameter.
        (WebCore::scriptObjectForRequest): Ditto.
        (WebCore::scriptObjectForResponse): Ditto.
        (WebCore::InspectorController::addScriptResource): Check for and
        record exceptions as we call JSC.
        (WebCore::InspectorController::addAndUpdateScriptResource): Ditto.
        (WebCore::InspectorController::removeScriptResource): Ditto. Also
        moved the call to setScriptObject to before the JSC calls so that it
        will always be called even if we return early if JSC throws an
        exception.
        (WebCore::InspectorController::updateScriptResourceRequest): Check for
        and record exceptions as we call JSC.
        (WebCore::InspectorController::updateScriptResourceResponse): Ditto.
        (WebCore::InspectorController::updateScriptResource): Ditto.
        (WebCore::InspectorController::addDatabaseScriptResource): Ditto.
        (WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
        Also moved the call to setScriptObject to before the JSC calls so that
        it will always be called even if we return early if JSC throws an
        exception.
        (WebCore::InspectorController::addScriptConsoleMessage): Check for and
        record exceptions as we call JSC.
        (WebCore::InspectorController::handleException): Added.
        * page/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 18060: Assertion failure (JSLock not held) beneath JSCallbackObject...
aroben@apple.com [Thu, 27 Mar 2008 03:35:40 +0000 (03:35 +0000)]
    Fix Bug 18060: Assertion failure (JSLock not held) beneath JSCallbackObject<Base>::toString

        <http://bugs.webkit.org/show_bug.cgi?id=18060>

        Reviewed by Geoff Garen.

        Bug fix:

        * API/JSCallbackObjectFunctions.h:
        (KJS::JSCallbackObject<Base>::toString): Make the DropAllLocks
        instance only be in scope while calling convertToType.

        Test:

        * API/testapi.c:
        (MyObject_convertToType): Implement type conversion to string.
        * API/testapi.js: Add a test for type conversion to string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 27 Mar 2008 03:14:08 +0000 (03:14 +0000)]
2008-03-26  Darin Adler  <darin@apple.com>

        Rubber stamped by Maciej.

        - removed a couple log messages in error cases that are handled internally

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decode): Removed the LOG_ERROR.
        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::decode): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix after r31322
aroben@apple.com [Thu, 27 Mar 2008 03:11:30 +0000 (03:11 +0000)]
    Windows build fix after r31322

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h: Updated.
        * win/lib/WebKitSystemInterface.lib: Updated.
        * win/lib/WebKitSystemInterface_debug.lib: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 27 Mar 2008 02:56:16 +0000 (02:56 +0000)]
2008-03-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        * page/Location.idl: Don't enumerate toString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 27 Mar 2008 02:53:20 +0000 (02:53 +0000)]
2008-03-26  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Adam Roben.

        Update test result.

        * fast/dom/Window/window-special-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 27 Mar 2008 02:45:42 +0000 (02:45 +0000)]
2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Screenshot for blog post.

        * blog-files/acid3-100.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRelease build fix.
mrowe@apple.com [Thu, 27 Mar 2008 02:41:16 +0000 (02:41 +0000)]
Release build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Thu, 27 Mar 2008 02:34:47 +0000 (02:34 +0000)]
    Windows build fix

        * kjs/array_instance.cpp: Touched this.
        * wtf/HashFunctions.h:
        (WTF::intHash): Added 8- and 16-bit versions of intHash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mjs@apple.com [Thu, 27 Mar 2008 02:34:14 +0000 (02:34 +0000)]
WebCore:

2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Hyatt and Adam.

        Coded by me and Darin.

        - SVG kerning support (horizontal kerning only for now since we don't do vertical text layout right yet)

        Acid3 100/100

        * DerivedSources.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/Font.cpp:
        (WebCore::Font::floatWidth):
        (WebCore::Font::isSVGFont):
        * platform/graphics/Font.h:
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::calculateGlyphWidth):
        (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
        * rendering/SVGInlineTextBox.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::cummulatedWidthOrHeightOfTextChunk):
        (WebCore::SVGRootInlineBox::buildLayoutInformation):
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
        * rendering/SVGRootInlineBox.h:
        (WebCore::LastGlyphInfo::LastGlyphInfo):
        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):
        (WebCore::Font::svgFont):
        (WebCore::floatWidthOfSubStringUsingSVGFont):
        (WebCore::Font::floatWidthUsingSVGFont):
        (WebCore::Font::drawTextUsingSVGFont):
        (WebCore::Font::selectionRectForTextUsingSVGFont):
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::invalidateGlyphCache):
        (WebCore::SVGFontElement::ensureGlyphCache):
        (WebCore::parseUnicodeRange):
        (WebCore::parseUnicodeRangeList):
        (WebCore::stringMatchesUnicodeRange):
        (WebCore::matches):
        (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
        * svg/SVGFontElement.h:
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::insertedIntoDocument):
        (WebCore::SVGGlyphElement::removedFromDocument):
        * svg/SVGHKernElement.cpp: Added.
        (WebCore::SVGHKernElement::SVGHKernElement):
        (WebCore::SVGHKernElement::~SVGHKernElement):
        (WebCore::SVGHKernElement::insertedIntoDocument):
        (WebCore::SVGHKernElement::removedFromDocument):
        (WebCore::SVGHKernElement::buildHorizontalKerningPair):
        * svg/SVGHKernElement.h: Added.
        (WebCore::SVGHorizontalKerningPair::SVGHorizontalKerningPair):
        (WebCore::SVGHKernElement::rendererIsNeeded):
        * svg/SVGHKernElement.idl: Added.
        * svg/SVGTextContentElement.cpp:
        (WebCore::cummulatedCharacterRangeLength):
        (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
        * svg/svgtags.in:

LayoutTests:

2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Hyatt and Adam.

        - new test case and test fixes for SVG text kerning

        * svg/text/kerning.svg: Added.
        * platform/mac/svg/text/kerning-expected.txt: Added.

        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 27 Mar 2008 02:21:49 +0000 (02:21 +0000)]
2008-03-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Autogenerate JSLocation.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Add files.

        * DerivedSources.make: Add Location, remove JSLocation.lut.h
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
        (WebCore::JSDOMWindowBase::getValueProperty):
        (WebCore::JSDOMWindowBase::put):
        (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
        (WebCore::JSDOMWindowBase::disconnectFrame):
        * bindings/js/JSDOMWindowBase.h:
        Remove manuel management of the Location object.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::mark): Add marking of JSLocation.
        (WebCore::JSDOMWindow::setLocation): Add custom setLocation as we only want to do this when
        safe and we need to keep Dashboard quirks.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        Fetch the location object using the normal toJS route.

        * bindings/js/JSLocation.cpp: Removed.
        * bindings/js/JSLocation.h: Removed.
        * bindings/js/JSLocationCustom.cpp: Added.
        (WebCore::JSLocation::customGetOwnPropertySlot):
        (WebCore::JSLocation::customPut):
        (WebCore::JSLocation::deleteProperty):
        (WebCore::JSLocation::customGetPropertyNames):
        (WebCore::navigateIfAllowed):
        (WebCore::JSLocation::setHref):
        (WebCore::JSLocation::setProtocol):
        (WebCore::JSLocation::setHost):
        (WebCore::JSLocation::setHostname):
        (WebCore::JSLocation::setPort):
        (WebCore::JSLocation::setPathname):
        (WebCore::JSLocation::setSearch):
        (WebCore::JSLocation::setHash):
        (WebCore::JSLocation::replace):
        (WebCore::JSLocation::reload):
        (WebCore::JSLocation::assign):
        (WebCore::JSLocation::toString):
        Setter and Functions need custom implementations as they rely on the dynamic
        global object for determining the behavior of the navigation.

        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::restore):
        (WebCore::CachedPage::clear):
        * history/CachedPage.h:
        Removed all the special casing for location as it should be treated like all
        the other objects hanging off the window.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::clear):
        (WebCore::DOMWindow::location):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalLocation):
        * page/DOMWindow.idl:
        Add Location accessor and pointer getter for marking.

        * page/Location.cpp: Added.
        (WebCore::Location::Location):
        (WebCore::Location::disconnectFrame):
        (WebCore::Location::url):
        (WebCore::Location::href):
        (WebCore::Location::protocol):
        (WebCore::Location::host):
        (WebCore::Location::hostname):
        (WebCore::Location::port):
        (WebCore::Location::pathname):
        (WebCore::Location::search):
        (WebCore::Location::hash):
        (WebCore::Location::toString):
        * page/Location.h: Added.
        (WebCore::Location::create):
        (WebCore::Location::frame):
        * page/Location.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd layout test results for altGlyph.
hyatt@apple.com [Thu, 27 Mar 2008 01:53:34 +0000 (01:53 +0000)]
Add layout test results for altGlyph.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd layout test for altGlyph.
hyatt@apple.com [Thu, 27 Mar 2008 01:53:16 +0000 (01:53 +0000)]
Add layout test for altGlyph.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 27 Mar 2008 01:52:55 +0000 (01:52 +0000)]
2008-03-26  David Hyatt  <hyatt@apple.com>

        Add support for the rendering and measurement of the <altGlyph> element in SVG.  This patch brings
        is half of what's needed to reach 100/100 on Acid3 and pass the test.  Maciej has coded up the other half. :)

        Reviewed by mjs

        Added svg/custom/altGlyph.svg

        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
        (WebCore::SVGAltGlyphElement::glyphElement):
        * svg/SVGAltGlyphElement.h:
        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::insertedIntoDocument):
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::insertedIntoDocument):
        (WebCore::SVGGlyphElement::removedFromDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTurn on SVG animation on Windows
aroben@apple.com [Thu, 27 Mar 2008 01:43:54 +0000 (01:43 +0000)]
Turn on SVG animation on Windows

JavaScriptCore:

        Force JSC headers to be copied by touching a file

        * kjs/array_instance.cpp:
        (KJS::ArrayInstance::getPropertyNames):

WebCore:

        Turn on SVG animation on Windows

        Also touched some files to force things to rebuild/regenerate.

        * WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
        * WebCore.vcproj/build-generated-files.sh: Ditto.
        * bindings/scripts/CodeGenerator.pm: Touched.
        * config.h: Touched.
        * svg/svgtags.in: Touched.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Thu, 27 Mar 2008 01:10:15 +0000 (01:10 +0000)]
2008-03-26  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Harrison.

        <rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution

        * editing/markup.cpp:
        (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n"
        with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>".
        Don't enclose paragraphs in clones of the context's enclosing block if that block is the
        html or body element.  Currently no way to test [DOMHTMLElement createFragmentFromText:].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix after r31324
aroben@apple.com [Thu, 27 Mar 2008 00:58:22 +0000 (00:58 +0000)]
    Windows build fix after r31324

        Written with Darin.

        Added HashTable plumbing to support using wchar_t as a key type.

        * wtf/HashFunctions.h:
        * wtf/HashTraits.h:
        (WTF::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
antti@apple.com [Thu, 27 Mar 2008 00:21:17 +0000 (00:21 +0000)]
WebCore:

2008-03-26  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        http://bugs.webkit.org/show_bug.cgi?id=17077
        Bug 17077: SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76)

        - enable SVG animation support.
        - basic implementation of beginElement()/endElement().

        Animation definitely will need more work than this, but it is a start!

        * Configurations/WebCore.xcconfig:
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::SVGAnimationElement):
        (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
        (WebCore::SVGAnimationElement::beginElement):
        (WebCore::SVGAnimationElement::beginElementAt):
        (WebCore::SVGAnimationElement::endElement):
        (WebCore::SVGAnimationElement::endElementAt):
        * svg/SVGAnimationElement.h:

WebKitTools:

2008-03-26  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Enable SVG animation support by default.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 26 Mar 2008 23:34:36 +0000 (23:34 +0000)]
2008-03-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by David Hyatt.

        Make the Ahem font antialias correctly on Acid3 on Tiger.

        * WebCore.Tiger.exp:
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

2008-03-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by David Hyatt.

        Make the Ahem font antialias correctly on Acid3 on Tiger.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceTiger.a:

2008-03-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by David Hyatt.

        Make the Ahem font antialias correctly on Acid3 on Tiger.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to fix the Qt build.
hausmann@webkit.org [Wed, 26 Mar 2008 23:02:30 +0000 (23:02 +0000)]
Attempt to fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Wed, 26 Mar 2008 22:56:16 +0000 (22:56 +0000)]
2008-03-26  Stephanie Lewis  <slewis@apple.com>

        Not Reviewed.

        Move storage tests to Skipped list since they hang 80% of the time.  See <rdar://problem/5787763>.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Wed, 26 Mar 2008 20:53:07 +0000 (20:53 +0000)]
2008-03-26  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        - fix http://bugs.webkit.org/show_bug.cgi?id=18104
          REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): When deciding to ditch
        old clean lines (due to changed or newly-added floats), keep the
        reference to those lines so they can be properly deleted in the end,
        and use a separate flag to signal that no matching should be attempted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeculative Windows build fix.
mrowe@apple.com [Wed, 26 Mar 2008 20:21:40 +0000 (20:21 +0000)]
Speculative Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 26 Mar 2008 19:59:32 +0000 (19:59 +0000)]
2008-03-25  Steve Falkenburg  <sfalken@apple.com>

        Turn on link-time-codegen in html and rendering related files.

        Reviewed by Oliver.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 26 Mar 2008 19:26:26 +0000 (19:26 +0000)]
2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - JSC part of fix for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
        http://bugs.webkit.org/show_bug.cgi?id=18118

        * wtf/HashFunctions.h:
        (WTF::):
        * wtf/HashTraits.h:
        (WTF::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mjs@apple.com [Wed, 26 Mar 2008 19:22:01 +0000 (19:22 +0000)]
WebCore:

2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - fixed "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
        http://bugs.webkit.org/show_bug.cgi?id=18118

        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::SVGFontElement):
        (WebCore::SVGFontElement::addGlyphToCache):
        (WebCore::SVGFontElement::removeGlyphFromCache):
        (WebCore::SVGFontElement::ensureGlyphCache):
        (WebCore::SVGFontElement::getGlyphIdentifiersForString):
        * svg/SVGFontElement.h:
        * svg/SVGGlyphElement.h:
        (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
        * svg/SVGGlyphMap.h: Added. New radix tree based glyph map.
        (WebCore::GlyphMapNode::GlyphMapNode):
        (WebCore::SVGGlyphMap::SVGGlyphMap):
        (WebCore::SVGGlyphMap::add):
        (WebCore::SVGGlyphMap::compareGlyphPriority):
        (WebCore::SVGGlyphMap::get):
        (WebCore::SVGGlyphMap::clear):

LayoutTests:

2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - test updates for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
        http://bugs.webkit.org/show_bug.cgi?id=18118

        These test cases were already checking for this exact bug and now
        render correctly.

        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 26 Mar 2008 19:12:52 +0000 (19:12 +0000)]
2008-03-26  David Hyatt  <hyatt@apple.com>

        Fix build bustage on Tiger.  Tiger will not have the bug fix.

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 26 Mar 2008 19:01:31 +0000 (19:01 +0000)]
2008-03-26  David Hyatt  <hyatt@apple.com>

        Make the Ahem font antialias correctly on Acid3.

        Reviewed by Dan

        * platform/graphics/SimpleFontData.h:
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Mac build.
mrowe@apple.com [Wed, 26 Mar 2008 18:04:29 +0000 (18:04 +0000)]
Fix the Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements properties
aroben@apple.com [Wed, 26 Mar 2008 17:49:32 +0000 (17:49 +0000)]
    Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements properties

        <http://bugs.webkit.org/show_bug.cgi?id=17768>

        We were throwing an exception from Object.describe because of some
        undefined variables.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (Object.describe): Reinstate the type1 and type2 variables that were
        removed in r30146. They're still used when formatting a function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Wed, 26 Mar 2008 17:44:59 +0000 (17:44 +0000)]
    Reviewed by Darin.

        Cache C string identifiers by address, not value, assuming that C strings can only
        be literals.

        1% speedup on Acid3 test 26.

        * kjs/identifier.cpp:
        (KJS::literalIdentifierTable):
        (KJS::Identifier::add):
        Added a new table to cache UString::Reps created from C strings by address. Elements are
        never removed from this cache, as only predefined identifiers can get there.

        * kjs/identifier.h:
        (KJS::Identifier::Identifier): Added a warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Maciej.
ap@webkit.org [Wed, 26 Mar 2008 17:29:00 +0000 (17:29 +0000)]
    Rubber-stamped by Maciej.

        An assertion was failing in function-toString-object-literals.html when parsing 1e-500.
        The condition existed before, and got uncovered by turning compiled-out dtoa checks into
        ASSERTs.

        The assertion was verifying that the caller wasn't constructing a Bigint from 0.
        This might have had some reason behind it originally, but I couldn't find any,
        and this doesn't look like a reasonable requirement.

        * kjs/dtoa.cpp: (d2b): Removed the assertion (two copies in different code paths).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by darin.
eric@webkit.org [Wed, 26 Mar 2008 17:27:59 +0000 (17:27 +0000)]
    Reviewed by darin.

        Forgot to add braces darin asked for during review.

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by darin.
eric@webkit.org [Wed, 26 Mar 2008 17:19:07 +0000 (17:19 +0000)]
    Reviewed by darin.

        Fix, makes us pass Test 70
        XML documents should be strict about encoding checks
        http://bugs.webkit.org/show_bug.cgi?id=17079

        Test: fast/encoding/invalid-xml.html

        * WebCore.base.exp:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::write):
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::ensureSVGFontData):
        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::TextResourceDecoder):
        (WebCore::TextResourceDecoder::decode):
        * loader/TextResourceDecoder.h:
        * platform/text/TextCodec.h:
        (WebCore::TextCodec::decode):
        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decodeToBuffer):
        (WebCore::ErrorCallbackSetter::ErrorCallbackSetter):
        (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
        (WebCore::TextCodecICU::decode):
        * platform/text/TextCodecICU.h:
        * platform/text/TextCodecLatin1.cpp:
        * platform/text/TextCodecLatin1.h:
        * platform/text/TextCodecUTF16.cpp:
        * platform/text/TextCodecUTF16.h:
        * platform/text/TextCodecUserDefined.cpp:
        * platform/text/TextCodecUserDefined.h:
        * platform/text/TextDecoder.cpp:
        (WebCore::TextDecoder::checkForBOM):
        * platform/text/TextDecoder.h:
        (WebCore::TextDecoder::decode):
        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::decode):
        * platform/text/TextEncoding.h:
        (WebCore::TextEncoding::decode):
        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::decode):
        * platform/text/mac/TextCodecMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Antti Koivisto <antti@apple.com>
antti@apple.com [Wed, 26 Mar 2008 16:59:07 +0000 (16:59 +0000)]
2008-03-26  Antti Koivisto  <antti@apple.com>

        Reviewed by Adam.

        Add ElementTimeControl interface to SVGAnimationElement.
        Passes Acid3 test 75.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * svg/ElementTimeControl.h: Added.
        (WebCore::ElementTimeControl::~ElementTimeControl):
        * svg/ElementTimeControl.idl: Added.
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::beginElement):
        (WebCore::SVGAnimationElement::beginElementAt):
        (WebCore::SVGAnimationElement::endElement):
        (WebCore::SVGAnimationElement::endElementAt):
        * svg/SVGAnimationElement.h:
        * svg/SVGAnimationElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-26 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 26 Mar 2008 16:22:09 +0000 (16:22 +0000)]
2008-03-26  Kevin McCullough  <kmccullough@apple.com>

        - LayoutTest fix.  Null check.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 26 Mar 2008 14:33:07 +0000 (14:33 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17994
          REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
        - fix http://bugs.webkit.org/show_bug.cgi?id=18063
          REGRESSION (r31250): Small bug that just cropped up in WebKit r31275

        Tests: fast/repaint/subtree-root-clip.html
               fast/repaint/subtree-root-clip-2.html
               fast/repaint/subtree-root-clip-3.html

        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState): Changed to not set an initial clip.
        Since the root is clipping, there is no need to set a clip, and setting
        the clip based on the container was wrong because often the root was
        not included in the container's overflow rect because it had its own
        layer.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition): Removed code that added table
        cell's extra top offset only in the slow (recursive) code path.
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::absolutePosition): Added code to add the
        extra top offset in both code paths.

LayoutTests:

        Reviewed by Darin Adler.

        - tests for http://bugs.webkit.org/show_bug.cgi?id=17994
          REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
        - and http://bugs.webkit.org/show_bug.cgi?id=18063
          REGRESSION (r31250): Small bug that just cropped up in WebKit r31275

        * fast/repaint/subtree-root-clip-2.html: Added.
        * fast/repaint/subtree-root-clip-3.html: Added.
        * fast/repaint/subtree-root-clip.html: Added.
        * platform/mac/fast/repaint/subtree-root-clip-2-expected.checksum: Added.
        * platform/mac/fast/repaint/subtree-root-clip-2-expected.png: Added.
        * platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Added.
        * platform/mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
        * platform/mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
        * platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Added.
        * platform/mac/fast/repaint/subtree-root-clip-expected.checksum: Added.
        * platform/mac/fast/repaint/subtree-root-clip-expected.png: Added.
        * platform/mac/fast/repaint/subtree-root-clip-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build.
hausmann@webkit.org [Wed, 26 Mar 2008 13:00:01 +0000 (13:00 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog
mjs@apple.com [Wed, 26 Mar 2008 10:18:45 +0000 (10:18 +0000)]
Fixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mjs@apple.com [Wed, 26 Mar 2008 10:10:08 +0000 (10:10 +0000)]
WebCore:

2008-03-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Maciej.

        - fixed "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"
        http://bugs.webkit.org/show_bug.cgi?id=18046

        * platform/graphics/Font.cpp:
        (WebCore::Font::floatWidth): Allow expressing a run that has extra "context" characters beyond the end,
        and reporting of how many characters were actually consumed, to support multichar glyphs in SVG fonts.
        * platform/graphics/Font.h:
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::calculateGlyphWidth): Pass along extra chars in argument and chars consumed out
        argument.
        (WebCore::SVGInlineTextBox::calculateGlyphHeight): Pass along extra chars in argument.
        (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Add boilerplate; may not handle multichar glyphs
        right but I don't know what effects this would have.
        * rendering/SVGInlineTextBox.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::cummulatedWidthOrHeightOfTextChunk): Add boilerplate; may not handle multichar glyphs right
        but again I am not sure what effect this would have.
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Account for multichar glyphs - let glyph
        selection consider extra chars, and account for the fact that a glyph may have consumed multiple chars.
        * rendering/SVGRootInlineBox.h:
        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk): This is the place where glyph selection happens, so this is where
        we accout for multichar glyphs (both looking at extra chars past the end of the run, and reporting how
        many chars were consumed).
        (WebCore::floatWidthOfSubStringUsingSVGFont): Pass aforementioned info through the layers.
        (WebCore::Font::floatWidthUsingSVGFont): ditto
        (WebCore::Font::drawTextUsingSVGFont): ditto
        (WebCore::Font::selectionRectForTextUsingSVGFont): ditto
        * svg/SVGTextContentElement.cpp:
        (WebCore::cummulatedCharacterRangeLength): ditto
        (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): ditto

LayoutTests:

2008-03-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Maciej.

        - test case and new results for "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"
        http://bugs.webkit.org/show_bug.cgi?id=18046

        * svg/text/multichar-glyph.svg: Added. New test case for both rendering and getStartPositionOfChar
        access of multichar glyphs.
        * platform/mac/svg/text/multichar-glyph-expected.txt: Added.

        The following test results changed, all appear to be improvements.

        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
        * platform/mac/svg/text/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/text/text-text-06-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Wed, 26 Mar 2008 06:46:54 +0000 (06:46 +0000)]
WebCore:

2008-03-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Oliver.

        Fix for <rdar://problem/5811826> CSSValueList::item() does not
        range-check index

        Check bounds before accessing the item to avoid a crash.
        itemWithoutBoundsCheck() is still inlined and not bounds-checked to
        avoid slowing down our internal callers of item().
        * css/CSSValueList.cpp:
        (WebCore::CSSValueList::item):
        * css/CSSValueList.h:
        (WebCore::CSSValueList::itemWithoutBoundsCheck):

        Call itemWithoutBoundsCheck() to avoid slowing down these internal
        callers.
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::applyCounterList):
        (WebCore::CSSStyleSelector::applyProperty):
        * css/MediaQueryEvaluator.cpp:
        (WebCore::parseAspectRatio):
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::rebuildFontFace):
        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::dashArrayFromRenderingStyle):

LayoutTests:

2008-03-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Oliver.

        Test for <rdar://problem/5811826> CSSValueList::item() does not
        range-check index

        * fast/css/resources/bikes.bmp: Added.
        * fast/css/value-list-out-of-bounds-crash.html: Added.
        * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
        * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
        * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Wed, 26 Mar 2008 04:24:05 +0000 (04:24 +0000)]
    Windows build fix

        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        Add $(WebKitLibrariesDir)\include to the include path so we can find
        stdint.h there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Antti Koivisto <antti@apple.com>
antti@apple.com [Wed, 26 Mar 2008 03:41:56 +0000 (03:41 +0000)]
2008-03-25  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Fix http://bugs.webkit.org/show_bug.cgi?id=18082
        REGRESSION (r31287): GMail does not work if user stylesheet is set

        Oops, my cache refactoring patch was missing these rather essential lines for
        user stylesheets. They would get reloaded repeatedly.

        * loader/Cache.cpp:
        (WebCore::Cache::requestUserCSSStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempted build fix
aroben@apple.com [Wed, 26 Mar 2008 02:14:55 +0000 (02:14 +0000)]
    Attempted build fix

        * WebKit.vcproj/WebKit.sln: Make testapi build after most other
        projects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrect ChangeLog.
pewtermoose@webkit.org [Wed, 26 Mar 2008 01:35:53 +0000 (01:35 +0000)]
Correct ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Wed, 26 Mar 2008 01:32:44 +0000 (01:32 +0000)]
2008-03-25  Matt Lilek  <webkit@mattlilek.com>

        Rubber stamped by Adam

        Roll out r30300 since it causes assertion failures on page load.
        See http://bugs.webkit.org/show_bug.cgi?id=18093

        * page/InspectorController.cpp:
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Wed, 26 Mar 2008 01:07:58 +0000 (01:07 +0000)]
WebCore:

2008-03-25  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17252
          Acid3 test removing Nodes during NodeIterator walk fails (affects Acid3 test 2)

        Test: traversal/acid3-test-2.html

        * bindings/js/JSNodeIteratorCustom.cpp:
        (WebCore::JSNodeIterator::nextNode): Update since result is PassRefPtr.
        (WebCore::JSNodeIterator::previousNode): Ditto.
        * dom/NodeIterator.cpp:
        (WebCore::NodeIterator::nextNode): Changed result to PassRefPtr. Added code to
        track both the current candidate (which needs to move along to the next node
        if current node is deleted) and the current provisional result (passed to acceptNode,
        and needs to be returned even if it's deleted).
        (WebCore::NodeIterator::previousNode): Ditto.
        (WebCore::NodeIterator::nodeWillBeRemoved): Call updateForNodeRemoval for
        m_candidateNode as well as m_referenceNode.
        * dom/NodeIterator.h: Use PassRefPtr for return values.

LayoutTests:

2008-03-25  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17252
          Acid3 test removing Nodes during NodeIterator walk fails (affects Acid3 test 2)

        * traversal/acid3-test-2-expected.txt: Added.
        * traversal/acid3-test-2.html: Added.
        * traversal/resources/acid3-test-2.js: Added.
        * traversal/resources/exception-forwarding.js: Removed bogus extra line of code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 26 Mar 2008 00:29:30 +0000 (00:29 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Add the ability to transform a CString into a SharedBuffer to avoid copying data
        This is valuable to avoid copying a block of data for an upcoming patch

        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::adoptVector):
        * platform/SharedBuffer.h:

        * platform/text/CString.cpp:
        (WebCore::CString::releaseBuffer):
        * platform/text/CString.h:
        (WebCore::CStringBuffer::releaseBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 23:46:27 +0000 (23:46 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Attempt to fix .bkl build systems after recent archive additions

        * webcore-base.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 25 Mar 2008 23:43:29 +0000 (23:43 +0000)]
2008-03-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        - Cleaned up the needless use of RefPtrs, which we may someday no longer use for
        InspectorResources.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 25 Mar 2008 23:40:38 +0000 (23:40 +0000)]
2008-03-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        - Added a null check

        * xml/XMLHttpRequest.cpp: Null check
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 25 Mar 2008 23:32:01 +0000 (23:32 +0000)]
2008-03-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        -<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
        -<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
        -<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
        - XMLHttpRequestResources now identify themselves to the inspector which caches the data related to
        the request since no one else caches it.  However this is just the plumbing and the Inspector's UI
        has not been changed to show XHR resources yet.

        * page/InspectorController.cpp: Add ability to set XHR data on an InspectorResource.
        (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
        (WebCore::XMLHttpRequestResource::data):
        (WebCore::XMLHttpRequestResource::encoding):
        (WebCore::InspectorResource::): Add new type.
        (WebCore::InspectorResource::~InspectorResource): No longer virtual since we are not using inheritance.
        (WebCore::InspectorResource::type): Ditto.
        (WebCore::InspectorResource::setXMLHttpRequestResource):
        (WebCore::InspectorResource::isXHR):
        (WebCore::InspectorResource::xmlHttpRequestData):
        (WebCore::InspectorResource::xmlHttpRequestEncoding):
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::addSourceToFrame):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        * page/InspectorController.h: Add accessor for setting the XHR data.
        * page/inspector/Resource.js: Keep the XHR resource types in sync with the Inspector Controller.
        * xml/XMLHttpRequest.cpp: Give the InspectorController the XHR information to cache.
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Bug 18077: Integrate testapi.c into the Windows build
aroben@apple.com [Tue, 25 Mar 2008 23:23:45 +0000 (23:23 +0000)]
Fix Bug 18077: Integrate testapi.c into the Windows build

JavaScriptCore:

        Fix Bug 18077: Integrate testapi.c into the Windows build

        <http://bugs.webkit.org/show_bug.cgi?id=18077>

        Reviewed by Steve Falkenburg.

        * JavaScriptCore.vcproj/testapi/testapi.vcproj: Added.

WebCore:

        Add an UnusedParam.h forwarding header for use by testapi

        Reviewed by Steve Falkenburg.

        * ForwardingHeaders/wtf/UnusedParam.h: Added.

WebKit/win:

        Fix Bug 18077: Integrate testapi.c into the Windows build

        <http://bugs.webkit.org/show_bug.cgi?id=18077>

        Reviewed by Steve Falkenburg.

        * WebKit.vcproj/WebKit.sln: Added testapi.vcproj to the solution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make testapi.c compile under MSVC
aroben@apple.com [Tue, 25 Mar 2008 23:23:31 +0000 (23:23 +0000)]
     Make testapi.c compile under MSVC

         Currently you must compile testapi.c as C++ code since MSVC does not
         support many C features that GCC does.

         Reviewed by Steve Falkenburg.

         * API/testapi.c:
         (nan): Added an implementation of this for MSVC.
         (assertEqualsAsUTF8String): Use malloc instead of dynamically-sized
         stack arrays.
         (assertEqualsAsCharactersPtr): Ditto.
         (print_callAsFunction): Ditto.
         (main): Ditto, and explicitly cast from UniChar* to JSChar*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Stop using JavaScriptCore's custom stdbool.h and stdint.h on Windows
aroben@apple.com [Tue, 25 Mar 2008 23:23:17 +0000 (23:23 +0000)]
     Stop using JavaScriptCore's custom stdbool.h and stdint.h on Windows

         We can't remove the os-win32 directory yet because other ports (at
         least wx) are still relying on it.

         Reviewed by Steve Falkenburg.

         * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
           - Made all the include paths match the one for the Debug
             configuration (these got out of sync in r30797)
           - Removed os-win32 from the include path
           - Removed os-win32 from the directories we copy to $WebKitOutputDir.
           - Removed stdint.h from the project
         * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
         Delete the files that we may have previously copied from the os-win32
         directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 23:00:44 +0000 (23:00 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Beth Dakin

        Remove entirely unused internal method

        * WebView/WebArchiver.h:
        * WebView/WebArchiver.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Tue, 25 Mar 2008 22:37:14 +0000 (22:37 +0000)]
WebCore:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        <rdar://problem/5819308> - View Source is empty when view webarchives

        * WebCore.base.exp:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setParsedArchiveData):
        (WebCore::DocumentLoader::parsedArchiveData):
        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
          in the DocumentLoader

WebKit/mac:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        <rdar://problem/5819308> - View Source is empty when view webarchives

        * WebCore.base.exp:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setParsedArchiveData):
        (WebCore::DocumentLoader::parsedArchiveData):
        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
          in the DocumentLoader

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
mitz@apple.com [Tue, 25 Mar 2008 22:17:45 +0000 (22:17 +0000)]
    Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17933
          Reopen All Windows From Last Session causes crash

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
        check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 21:57:00 +0000 (21:57 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Jon Honeycutt's rubberstamp

        Fix a leak with the new WebArchive setup

        * WebView/WebArchive.mm:
        (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
eric@webkit.org [Tue, 25 Mar 2008 21:28:56 +0000 (21:28 +0000)]
    Reviewed by Oliver.

        Speculative crash fix for Acid3 crasher.
        I couldn't figure out how to make a test case for this?
        Suggestions welcome.

        * css/CSSFontSelector.cpp: null check document->renderer()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix.
ap@webkit.org [Tue, 25 Mar 2008 20:29:30 +0000 (20:29 +0000)]
    Windows build fix.

        * kjs/dtoa.cpp: Include stdint.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Darin.
ap@webkit.org [Tue, 25 Mar 2008 19:43:15 +0000 (19:43 +0000)]
    Rubber-stamped by Darin.

        Cleanup dtoa.cpp style.

        * kjs/dtoa.cpp:
        (Bigint::Balloc):
        (Bigint::Bfree):
        (Bigint::multadd):
        (Bigint::s2b):
        (Bigint::hi0bits):
        (Bigint::lo0bits):
        (Bigint::i2b):
        (Bigint::mult):
        (Bigint::pow5mult):
        (Bigint::lshift):
        (Bigint::cmp):
        (Bigint::diff):
        (Bigint::ulp):
        (Bigint::b2d):
        (Bigint::d2b):
        (Bigint::ratio):
        (Bigint::):
        (Bigint::match):
        (Bigint::hexnan):
        (Bigint::kjs_strtod):
        (Bigint::quorem):
        (Bigint::rv_alloc):
        (Bigint::nrv_alloc):
        (Bigint::kjs_freedtoa):
        (Bigint::kjs_dtoa):
        * kjs/dtoa.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 25 Mar 2008 19:21:00 +0000 (19:21 +0000)]
2008-03-25  Antti Koivisto  <antti@apple.com>

        Reviewed by Geoff Garen.

        Some memory cache cleanups:
        - Separate CachedResource loading from construction, initiate load using a separate load() method.
        - Add special case function to Cache for loading user stylesheets. This allows removal
          of a bunch of parameters from several methods and CachedResource constructors.
        - Construct CachedResources with m_inCache set to false which is quite a bit more logical as they
          are not yet in the cache at that point.
        - Pass encoding around as const String& instead of const String*.

        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::image):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::updateFromElement):
        * loader/Cache.cpp:
        (WebCore::createResource):
        (WebCore::Cache::requestResource):
        (WebCore::Cache::requestUserCSSStyleSheet):
        (WebCore::Cache::remove):
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::CachedFont):
        (WebCore::CachedFont::load):
        (WebCore::CachedFont::ref):
        * loader/CachedFont.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::load):
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::CachedResource::~CachedResource):
        (WebCore::CachedResource::load):
        * loader/CachedResource.h:
        (WebCore::CachedResource::load):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        (WebCore::CachedXBLDocument::CachedXBLDocument):
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestImage):
        (WebCore::DocLoader::requestFont):
        (WebCore::DocLoader::requestCSSStyleSheet):
        (WebCore::DocLoader::requestUserCSSStyleSheet):
        (WebCore::DocLoader::requestScript):
        (WebCore::DocLoader::requestXSLStyleSheet):
        (WebCore::DocLoader::requestXBLDocument):
        (WebCore::DocLoader::requestResource):
        (WebCore::DocLoader::preload):
        * loader/DocLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 19:12:33 +0000 (19:12 +0000)]
2008-03-25  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - avoid converting UString to String and then later to AtomicString

        1% speedup on Acid3 test 26

        This is inefficient for the case where there's already an AtomicString.
        By first creating and destroying a String we waste time.

        * bindings/scripts/CodeGeneratorJS.pm: Use const UString& for string
        arguments rather than using String; this uses the object as it's produced
        from toString rather than creating a new temporary object that might not
        be of the right type. The type conversion happens at the callsite instead.
        Also eliminate the ability to use the type AtomicString from IDL.

        * dom/KeyboardEvent.idl: AtomicString -> DOMString.
        * dom/MouseEvent.idl: Ditto.
        * dom/MutationEvent.idl: Ditto.
        * dom/UIEvent.idl: Ditto.
        * svg/SVGStyleElement.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 18:05:19 +0000 (18:05 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Build fix for non-CoreFoundation platforms

        * loader/archive/ArchiveFactory.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 18:00:51 +0000 (18:00 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Removed the concept of "pending archive resources" and the "archive resources delivery timer"
        from WebFrameLoaderClient, as those concepts have been pushed into WebCore

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::WebFrameLoaderClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Tue, 25 Mar 2008 17:44:39 +0000 (17:44 +0000)]
WebCore:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * loader/FrameLoaderClient.h:
        * svg/graphics/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError):
        (WebCore::SVGEmptyFrameLoaderClient::finishedLoading):

WebKit/gtk:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:

WebKit/qt:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        * WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebFrame.cpp:
        * WebFrame.h:

WebKit/wx:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebKitSupport/FrameLoaderClientWx.cpp:
        * WebKitSupport/FrameLoaderClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 17:29:25 +0000 (17:29 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Release build fix

        * WebView/WebArchive.mm:
        (-[WebArchive subresources]):
        (-[WebArchive subframeArchives]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Tue, 25 Mar 2008 17:11:16 +0000 (17:11 +0000)]
WebCore:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/4516169> - Support WebArchives on Windows
        And pave the way for many future WebArchive bug fixes and enhancements

        This patch accomplishes two main goals:
        1 - Consolidates much of the spread out WebKitMac archive code into one place in WebCore.  This allows for cleaner refactoring
            in the future as well as adding more archive formats with ease.
        2 - Hooks up WebArchive support on Windows.  Safari-style .webarchive files are nothing more than property lists readable by
            CoreFoundation.  While there are still some outstanding issues, including an NSKeyedArchiver chunk of data for the
            ResourceResponse for each resource, this patch manually parses through the property list on CoreFoundation platforms and
            gets many archives loading on Windows

        My goal for this first cut was zero behavior change.  As such, I went for a direct port of the WebKitMac code.  There will be
        opportunities for redesign and refactoring as followups.

        * WebCore.base.exp:

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ported from WebKitMac, WebDataSource
        (WebCore::DocumentLoader::addAllArchiveResources):
        (WebCore::DocumentLoader::addArchiveResource):
        (WebCore::DocumentLoader::archiveResourceForURL):
        (WebCore::DocumentLoader::popArchiveForSubframe):
        (WebCore::DocumentLoader::clearArchiveResources):
        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp: Moved WebFrameLoaderClient and WebFrame code down into their more appropriate FrameLoader home
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::setDefersLoading):
        (WebCore::FrameLoader::deliverArchivedResourcesAfterDelay):
        (WebCore::FrameLoader::archiveResourceDeliveryTimerFired):
        (WebCore::FrameLoader::loadURLIntoChildFrame):
        (WebCore::FrameLoader::loadArchive):
        (WebCore::FrameLoader::scheduleArchiveLoad):
        (WebCore::FrameLoader::stopAllLoaders):
        (WebCore::FrameLoader::cancelPendingArchiveLoad):
        (WebCore::FrameLoader::isArchiveLoadPending):
        (WebCore::FrameLoader::finishedLoadingDocument):
        * loader/FrameLoader.h:

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load):

        * loader/archive/Archive.h: Generic "Archive of web resources" class that is only useful when subclassed.
            Contains a MainResource, subresources, and Archives for subframes
        (WebCore::Archive::mainResource):
        (WebCore::Archive::subresources):
        (WebCore::Archive::subframeArchives):
        (WebCore::Archive::setMainResource):
        (WebCore::Archive::addSubresource):
        (WebCore::Archive::addSubframeArchive):

        * loader/archive/ArchiveFactory.cpp: A class that will take raw archive data and the MIMEtype, and create the
            appropriate Archive class for it.  Additionally it handles registering the known MIMEtypes for all known archive formats
        (WebCore::archiveFactoryCreate):
        (WebCore::archiveMIMETypes):
        (WebCore::ArchiveFactory::isArchiveMimeType):
        (WebCore::ArchiveFactory::create):
        (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
        * loader/archive/ArchiveFactory.h:

        * loader/archive/ArchiveResource.cpp: Analog to "WebResource" in WebKitMac.  Contains the data and other important
            attributes of an archived resource
        (WebCore::ArchiveResource::create):
        (WebCore::ArchiveResource::ArchiveResource):
        (WebCore::ArchiveResource::response):
        * loader/archive/ArchiveResource.h:
        (WebCore::ArchiveResource::data):
        (WebCore::ArchiveResource::url):
        (WebCore::ArchiveResource::mimeType):
        (WebCore::ArchiveResource::textEncoding):
        (WebCore::ArchiveResource::frameName):
        (WebCore::ArchiveResource::ignoreWhenUnarchiving):
        (WebCore::ArchiveResource::shouldIgnoreWhenUnarchiving):

        * loader/archive/ArchiveResourceCollection.cpp: Analog of "WebUnarchivingState" in WebKitMac.  Contains a hash of
            all the resources for every frame in an archive, and contains the archives for each subframe needed to load a multi-frame archive
        (WebCore::ArchiveResourceCollection::ArchiveResourceCollection):
        (WebCore::ArchiveResourceCollection::addAllResources):
        (WebCore::ArchiveResourceCollection::addResource):
        (WebCore::ArchiveResourceCollection::archiveResourceForURL):
        (WebCore::ArchiveResourceCollection::popSubframeArchive):
        * loader/archive/ArchiveResourceCollection.h:

        * loader/archive/cf/LegacyWebArchive.cpp: Subclass of Archive specifically for Webkit's Objective-C based ".webarchive" format.
            Mostly a collection of static methods involved in parsing and serializing a WebKit-style .webarchive.  Is mostly supported
            for any CF platform.
        (WebCore::createPropertyListRepresentationFromResource):
        (WebCore::createPropertyListRep):
        (WebCore::createResourceResponseFromPropertyListData):
        (WebCore::createResource):
        (WebCore::LegacyWebArchive::create):
        (WebCore::LegacyWebArchive::LegacyWebArchive):
        (WebCore::LegacyWebArchive::init):
        (WebCore::LegacyWebArchive::extract):
        (WebCore::LegacyWebArchive::rawDataRepresentation):
        (WebCore::createResourceResponseFromMacArchivedData):
        (WebCore::propertyListDataFromResourceResponse):
        * loader/archive/cf/LegacyWebArchive.h:
        * loader/archive/cf/LegacyWebArchiveMac.mm:
        (WebCore::createResourceResponseFromMacArchivedData):
        (WebCore::propertyListDataFromResourceResponse):

        * platform/network/mac/ResourceRequest.h:
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::applyWebArchiveHackForMail): Tweak the resource request for Mac clients when loading WebArchives

WebKit:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/4516169> - Support WebArchives on Windows

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/4516169> - Support WebArchives on Windows
        And paves the way for many future WebArchive bug fixes and enhancements

        This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains
        1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
         * WebArchive <-> LegacyWebArchive
         * WebResource <-> ArchiveResource
         * WebUnarchivingState <-> ArchiveResourceCollection

        The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
        and now exist in WebCore

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
        (WebFrameLoaderClient::finalSetupForReplace):
        (WebFrameLoaderClient::setDefersLoading):
        (WebFrameLoaderClient::willUseArchive):
        (WebFrameLoaderClient::isArchiveLoadPending):
        (WebFrameLoaderClient::cancelPendingArchiveLoad):
        (WebFrameLoaderClient::clearArchivedResources):
        (WebFrameLoaderClient::createFrame):

        * WebView/WebArchive.mm:
        (+[WebArchivePrivate initialize]):
        (-[WebArchivePrivate init]):
        (-[WebArchivePrivate initWithCoreArchive:]):
        (-[WebArchivePrivate coreArchive]):
        (-[WebArchivePrivate setCoreArchive:]):
        (-[WebArchivePrivate dealloc]):
        (-[WebArchivePrivate finalize]):
        (-[WebArchive init]):
        (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
        (-[WebArchive initWithData:]):
        (-[WebArchive initWithCoder:]):
        (-[WebArchive encodeWithCoder:]):
        (-[WebArchive mainResource]):
        (-[WebArchive subresources]):
        (-[WebArchive subframeArchives]):
        (-[WebArchive data]):
        (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
        (-[WebArchive WebCore::]):
        * WebView/WebArchiveInternal.h: Added.

        * WebView/WebDataSource.mm:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _addSubframeArchives:]):
        (-[WebDataSource _documentFragmentWithArchive:]):
        (-[WebDataSource subresourceForURL:]):
        (-[WebDataSource addSubresource:]):
        * WebView/WebDataSourceInternal.h:

        * WebView/WebFrame.mm:
        (-[WebFrame loadArchive:]):
        * WebView/WebFrameInternal.h:

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):

        * WebView/WebResource.mm:
        (+[WebResourcePrivate initialize]):
        (-[WebResourcePrivate init]):
        (-[WebResourcePrivate initWithCoreResource:]):
        (-[WebResourcePrivate dealloc]):
        (-[WebResourcePrivate finalize]):
        (-[WebResource initWithCoder:]):
        (-[WebResource encodeWithCoder:]):
        (-[WebResource data]):
        (-[WebResource URL]):
        (-[WebResource MIMEType]):
        (-[WebResource textEncodingName]):
        (-[WebResource frameName]):
        (-[WebResource _initWithCoreResource:WebCore::]):
        (-[WebResource WebCore::]):
        (-[WebResource _ignoreWhenUnarchiving]):
        (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
        (-[WebResource _fileWrapperRepresentation]):
        (-[WebResource _response]):
        (-[WebResource _stringValue]):
        * WebView/WebResourceInternal.h: Added.
        * WebView/WebResourcePrivate.h:

        * WebView/WebUnarchivingState.h: Removed.
        * WebView/WebUnarchivingState.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 16:09:45 +0000 (16:09 +0000)]
2008-03-25  Darin Adler  <darin@apple.com>

        Suggested by Adam.

        * Interfaces/WebKit.idl: Touch this file to make the Interface project rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-25 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 25 Mar 2008 07:33:34 +0000 (07:33 +0000)]
2008-03-25  David Hyatt  <hyatt@apple.com>

        Cut and paste error in the zoom code.  A width() should have been a height().  Regression tests caught this.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::innerHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark.
eric@webkit.org [Tue, 25 Mar 2008 06:56:56 +0000 (06:56 +0000)]
    Reviewed by Mark.

        Clean up SVG features message to be less confusing.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 05:02:24 +0000 (05:02 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        - try to fix broken Wx build

        * platform/wx/TemporaryLinkStubs.cpp:
        (GraphicsContext::setPlatformShadow):
        (GraphicsContext::clearPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 18030: REGRESSION(r31236): Space bar fails to scroll down page
oliver@apple.com [Tue, 25 Mar 2008 04:35:30 +0000 (04:35 +0000)]
Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
<http://bugs.webkit.org/show_bug.cgi?id=18030>

Reviewed by Mark Rowe

Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
<http://bugs.webkit.org/show_bug.cgi?id=18057>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 04:30:00 +0000 (04:30 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - use AtomicString more consistently for attribute values

        1% speedup on Acid3 test 26

        * dom/Element.cpp:
        (WebCore::Element::setAttribute): Changed value argument to AtomicString.
        Also fixed call to lower() to only be done if the name isn't already lowercase.
        Also took out one unneeded condition in a cascade of if statements.
        (WebCore::Element::createAttribute): Ditto.
        (WebCore::Element::setAttributeNS): Ditto.
        * dom/Element.h: Ditto.
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::createAttribute): Ditto.
        * dom/StyledElement.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 04:28:37 +0000 (04:28 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - get rid of extra level of function call in toJS functions for Node

        0.6% speedup on Acid3 test 26

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::toJS): Take a raw pointer, not a PassRefPtr, like other toJS functions.

        * bindings/scripts/CodeGeneratorJS.pm: Add an inlined toJS for EventTargetNode*
        to avoid ambiguity that otherwise exists between the toJS for EventTarget* and
        for Node*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 25 Mar 2008 03:43:57 +0000 (03:43 +0000)]
2008-03-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Add EventSender.zoomPageIn/zoomPageOut support to DRT.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/mac/EventSendingController.mm:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (-[EventSendingController zoomPageIn]):
        (-[EventSendingController zoomPageOut]):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/win/EventSender.cpp:
        (textZoomInCallback):
        (textZoomOutCallback):
        (zoomPageInCallback):
        (zoomPageOutCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 03:39:56 +0000 (03:39 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - convert a JavaScript immediate number to a string more efficiently

        2% speedup of Acid3 test 26

        * kjs/JSImmediate.cpp:
        (KJS::JSImmediate::toString): Take advantage of the fact that all immediate
        numbers are integers, and use the faster UString function for formatting integers
        instead of the slower one that works for floating point. I think this is a leftover
        from when immediate numbers were floating point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 03:26:02 +0000 (03:26 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Hyatt.

        - add fast path to isValidName that does not use advanced Unicode functions

        2% speedup on Acid3 test 26

        * dom/Document.cpp:
        (WebCore::isValidNameNonASCII): Added. Contains the old isValidName function.
        (WebCore::isValidNameASCII): Added. Contains a simpler function that returns
        true for most valid names that are also all ASCII.
        (WebCore::Document::isValidName): Changed to call both of the above functions.
        The common case is that isValidNameASCII returns true so isValidNameNonASCII
        is never called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 25 Mar 2008 02:39:31 +0000 (02:39 +0000)]
2008-03-24  David Hyatt  <hyatt@apple.com>

        Fix for bug 18052, window properties need to respect zoom factor.

        Reviewed by Beth

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::innerHeight):
        (WebCore::DOMWindow::innerWidth):
        (WebCore::DOMWindow::scrollX):
        (WebCore::DOMWindow::scrollY):
        (WebCore::DOMWindow::scrollTo):
        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::performPostLayoutTasks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
weinig@apple.com [Tue, 25 Mar 2008 02:26:24 +0000 (02:26 +0000)]
JavaScriptCore:

2008-03-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=18048
        The "thisObject" parameter to JSEvaluateScript is not used properly

        Making passing a thisObject to JSEvaluateScript actually set the thisObject of the created
        ExecState.

        * API/testapi.c:
        (main): Add tests for setting the thisObject when calling JSEvaluateScript.

        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState): Assign the thisObject to m_thisValue and remove the comment.

WebCore:

2008-03-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=18048
        The "thisObject" parameter to JSEvaluateScript is not used properly

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::evaluate): No need to pass a thisObject since we want the global object to be used.
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::eval): To avoid any change to this function, don't pass a thisObject to keep the same
        behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 01:19:00 +0000 (01:19 +0000)]
2008-03-24  Brady Eidson  <beidson@apple.com>

        Made new layout test files executable, as needed for the tests to not fail!

        * http/tests/navigation/resources/reload-subframe-content.pl: Added.
        * http/tests/navigation/resources/reload-subframe.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/mac:
beidson@apple.com [Tue, 25 Mar 2008 00:37:58 +0000 (00:37 +0000)]
WebKit/mac:

2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej, landed by Brady

        Bug 3580: iFrames Appear to be Cached
        <http://bugs.webkit.org/show_bug.cgi?id=3580>

        Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
        <http://bugs.webkit.org/show_bug.cgi?id=15486>

        Bug 15554: Reload causes <object> to use old data
        <http://bugs.webkit.org/show_bug.cgi?id=15554>

        If a page is reloaded, a child frame's URL can not be taken from a history item.

        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):

LayoutTests:

2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej, landed by Brady

        Tests for the following bugs:

        Bug 3580: iFrames Appear to be Cached
        <http://bugs.webkit.org/show_bug.cgi?id=3580>

        Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
        <http://bugs.webkit.org/show_bug.cgi?id=15486>

        Bug 15554: Reload causes <object> to use old data
        <http://bugs.webkit.org/show_bug.cgi?id=15554>

        * http/tests/navigation/reload-subframe-frame-expected.txt: Added.
        * http/tests/navigation/reload-subframe-frame.html: Added.
        * http/tests/navigation/reload-subframe-iframe-expected.txt: Added.
        * http/tests/navigation/reload-subframe-iframe.html: Added.
        * http/tests/navigation/reload-subframe-object-expected.txt: Added.
        * http/tests/navigation/reload-subframe-object.html: Added.
        * http/tests/navigation/resources/reload-subframe-content.pl: Added.
        * http/tests/navigation/resources/reload-subframe.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 24 Mar 2008 23:19:42 +0000 (23:19 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Beth.

        - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
        * WebView/WebDataSource.mm:
        (-[WebDataSource _URL]): Ditto.
        (-[WebDataSource unreachableURL]): Ditto.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

        * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
        * History/WebHistory.mm:
        * Misc/WebElementDictionary.mm:
        * Misc/WebNSAttributedStringExtras.mm:
        Remove unneeded imports of KURL.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Mon, 24 Mar 2008 22:59:20 +0000 (22:59 +0000)]
WebCore:

2008-03-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin's rubberstamp

        Land a load of empty files for upcoming work to make sure I'm not breaking any platform's build

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * loader/archive: Added.
        * loader/archive/Archive.h: Added.
        * loader/archive/ArchiveFactory.cpp: Added.
        * loader/archive/ArchiveFactory.h: Added.
        * loader/archive/ArchiveResource.cpp: Added.
        * loader/archive/ArchiveResource.h: Added.
        * loader/archive/ArchiveResourceCollection.cpp: Added.
        * loader/archive/ArchiveResourceCollection.h: Added.
        * loader/archive/cf: Added.
        * loader/archive/cf/LegacyWebArchive.cpp: Added.
        * loader/archive/cf/LegacyWebArchive.h: Added.
        * loader/archive/cf/LegacyWebArchiveMac.mm: Added.

WebKit:

2008-03-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin's rubberstamp

        Rename a .m to .mm

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-03-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin's rubberstamp

        Rename this file for upcoming work.

        * WebView/WebArchive.m: Removed.
        * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31258 268f45cc-cd09-0410-ab3c-d52691b4dbfc