WebKit-https.git
11 years agoWebKit:
andersca@apple.com [Tue, 20 Jan 2009 19:33:48 +0000 (19:33 +0000)]
WebKit:

2009-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add ProxyInstance files.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add and implement GetScriptableNPObject.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetScriptableNPObjectReply):
        Create a new reply struct and set it as the current reply.

        (WKPCEvaluate):
        Get rid of an unused variable.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::GetScriptableNPObjectReply::GetScriptableNPObjectReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Call _WKPHGetScriptableNPObject and wait for a reply.

        * Plugins/Hosted/ProxyInstance.h: Added.
        * Plugins/Hosted/ProxyInstance.mm: Added.
        Add empty files.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]):
        Call NetscapePluginInstanceProxy::createBindingsInstance.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 20 Jan 2009 18:38:58 +0000 (18:38 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferences): Add back the initialization to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
darin@apple.com [Tue, 20 Jan 2009 18:25:30 +0000 (18:25 +0000)]
JavaScriptCore:

2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 23352: Turn on more compiler warnings in the Mac build
        https://bugs.webkit.org/show_bug.cgi?id=23352

        First patch: Fix some simple cases of various warnings.

        * pcre/pcre_compile.cpp:
        (jsRegExpCompile): Use const_cast to change const-ness.

        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferences): Remove unneeded initialization and
        use UChar instead of unsigned short for UTF-16 values.

        * wtf/dtoa.cpp:
        (WTF::strtod): Use const_cast to change const-ness.

WebCore:

2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 23352: Turn on more compiler warnings in the Mac build
        https://bugs.webkit.org/show_bug.cgi?id=23352

        First patch: Fix some simple cases of various warnings.

        * platform/DeprecatedPtrListImpl.cpp:
        (WebCore::DeprecatedPtrListImpl::insert): Use const_cast to change const-ness.
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::containsCharacters): Ditto.

        * platform/text/PlatformString.h: Overload for short and unsigned short to avoid
        ambiguity leading to warnings.
        * platform/text/String.cpp:
        (WebCore::String::number): Implemented overloads.

        * platform/text/TextStream.cpp:
        (WebCore::TextStream::operator<<): Overload for bool to avoid ambiguity leading
        to warnings.
        * platform/text/TextStream.h: Ditto.

        * rendering/InlineFlowBox.h: Fix declaration that was specifying the wrong type.

        * svg/graphics/filters/cg/WKLinearTransferFilter.m: Fix stray characters after
        #endif that should be a comment instead.
        * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Ditto.

        * xml/XPathPath.h: Remove unneeded redundant declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for WML enabled builds, not reviewed.
zimmermann@webkit.org [Tue, 20 Jan 2009 17:44:15 +0000 (17:44 +0000)]
Build fix for WML enabled builds, not reviewed.
Fix unused variable warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for WML enabled builds, not reviewed.
zimmermann@webkit.org [Tue, 20 Jan 2009 17:23:24 +0000 (17:23 +0000)]
Build fix for WML enabled builds, not reviewed.
Rename 'continuation' to 'virtualContinuation'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWhoops, remove runtime/ByteArray references from .pri and .scons builds, update .bkl
oliver@apple.com [Tue, 20 Jan 2009 17:04:35 +0000 (17:04 +0000)]
Whoops, remove runtime/ByteArray references from .pri and .scons builds, update .bkl

Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove runtime/ByteArray to wtf/ByteArray
oliver@apple.com [Tue, 20 Jan 2009 16:57:04 +0000 (16:57 +0000)]
Move runtime/ByteArray to wtf/ByteArray

RS=Dan Bernstein

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 20 Jan 2009 16:06:11 +0000 (16:06 +0000)]
2009-01-20  Darin Fisher  <darin@chromium.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=23391
        Upstream plugins/chromium/

        * plugins/chromium: Added.
        * plugins/chromium/PluginDataChromium.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Friedemann Kleint <Friedemann.Kleint@nokia.com>
hausmann@webkit.org [Tue, 20 Jan 2009 12:26:09 +0000 (12:26 +0000)]
2009-01-20  Friedemann Kleint  <Friedemann.Kleint@nokia.com>

        Reviewed by Simon Hausmann.

        Fix spelling error in QWebPage

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Windows release build.
sfalken@apple.com [Tue, 20 Jan 2009 07:01:07 +0000 (07:01 +0000)]
    Fix Windows release build.
        Move SVG files into all-in-one file for Windows build.

        * WebCore.vcproj/WebCore.vcproj:
        * svg/SVGAllInOne.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Jan 2009 03:31:37 +0000 (03:31 +0000)]
2009-01-19  Simon Fraser  <simon.fraser@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=18078

        New testcases for transitions of shorthand properties.

        * transitions/shorthand-border-transitions-expected.txt: Added.
        * transitions/shorthand-border-transitions.html: Added.
        * transitions/shorthand-transitions-expected.txt: Added.
        * transitions/shorthand-transitions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Partial build fix.
sfalken@apple.com [Tue, 20 Jan 2009 03:14:13 +0000 (03:14 +0000)]
    Partial build fix.
        Move new derived sources into all-in-one DerivedSources.cpp

        * DerivedSources.cpp:
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 20 Jan 2009 02:34:04 +0000 (02:34 +0000)]
2009-01-19  Sam Weinig  <sam@webkit.org>

        * Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 20 Jan 2009 01:29:02 +0000 (01:29 +0000)]
2009-01-19  Sam Weinig  <sam@webkit.org>

        Fix Qt build.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::mark):
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::valueRealType):
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::QtRuntimeConnectionMethod::call):
        (JSC::Bindings::QtConnectionObject::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 20 Jan 2009 01:15:45 +0000 (01:15 +0000)]
2009-01-19  Sam Weinig  <sam@webkit.org>

        Fix wx build.

        * plugins/PluginView.cpp:
        (WebCore::getString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
weinig@apple.com [Tue, 20 Jan 2009 00:54:18 +0000 (00:54 +0000)]
JavaScriptCore:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * API/JSCallbackFunction.cpp:
        (JSC::JSCallbackFunction::call):
        * API/JSCallbackObjectFunctions.h:
        (JSC::::call):
        (JSC::::toNumber):
        (JSC::::toString):
        * API/JSObjectRef.cpp:
        (JSObjectSetPrototype):
        * API/JSValueRef.cpp:
        (JSValueGetType):
        (JSValueIsUndefined):
        (JSValueIsNull):
        (JSValueIsBoolean):
        (JSValueIsNumber):
        (JSValueIsString):
        (JSValueIsObject):
        (JSValueIsObjectOfClass):
        (JSValueToBoolean):
        (JSValueToNumber):
        (JSValueToStringCopy):
        (JSValueToObject):
        * bytecode/CodeBlock.cpp:
        (JSC::valueToSourceString):
        (JSC::CodeBlock::mark):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::isKnownNotImmediate):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitEqualityOp):
        (JSC::keyForImmediateSwitch):
        * interpreter/Interpreter.cpp:
        (JSC::jsLess):
        (JSC::jsLessEq):
        (JSC::jsAddSlowCase):
        (JSC::jsAdd):
        (JSC::jsTypeStringForValue):
        (JSC::jsIsObjectType):
        (JSC::jsIsFunctionType):
        (JSC::isNotObject):
        (JSC::Interpreter::callEval):
        (JSC::Interpreter::throwException):
        (JSC::cachePrototypeChain):
        (JSC::Interpreter::tryCachePutByID):
        (JSC::countPrototypeChainEntriesAndCheckForProxies):
        (JSC::Interpreter::tryCacheGetByID):
        (JSC::Interpreter::privateExecute):
        (JSC::Interpreter::tryCTICachePutByID):
        (JSC::Interpreter::tryCTICacheGetByID):
        (JSC::Interpreter::cti_op_convert_this):
        (JSC::Interpreter::cti_op_add):
        (JSC::Interpreter::cti_op_pre_inc):
        (JSC::Interpreter::cti_op_put_by_id_generic):
        (JSC::Interpreter::cti_op_get_by_id_generic):
        (JSC::Interpreter::cti_op_put_by_id):
        (JSC::Interpreter::cti_op_put_by_id_second):
        (JSC::Interpreter::cti_op_put_by_id_fail):
        (JSC::Interpreter::cti_op_get_by_id):
        (JSC::Interpreter::cti_op_get_by_id_second):
        (JSC::Interpreter::cti_op_get_by_id_self_fail):
        (JSC::Interpreter::cti_op_get_by_id_proto_list):
        (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
        (JSC::Interpreter::cti_op_get_by_id_proto_fail):
        (JSC::Interpreter::cti_op_get_by_id_array_fail):
        (JSC::Interpreter::cti_op_get_by_id_string_fail):
        (JSC::Interpreter::cti_op_instanceof):
        (JSC::Interpreter::cti_op_del_by_id):
        (JSC::Interpreter::cti_op_mul):
        (JSC::Interpreter::cti_op_call_JSFunction):
        (JSC::Interpreter::cti_op_call_NotJSFunction):
        (JSC::Interpreter::cti_op_construct_JSConstruct):
        (JSC::Interpreter::cti_op_construct_NotJSConstruct):
        (JSC::Interpreter::cti_op_get_by_val):
        (JSC::Interpreter::cti_op_get_by_val_byte_array):
        (JSC::Interpreter::cti_op_sub):
        (JSC::Interpreter::cti_op_put_by_val):
        (JSC::Interpreter::cti_op_put_by_val_array):
        (JSC::Interpreter::cti_op_put_by_val_byte_array):
        (JSC::Interpreter::cti_op_loop_if_true):
        (JSC::Interpreter::cti_op_negate):
        (JSC::Interpreter::cti_op_div):
        (JSC::Interpreter::cti_op_pre_dec):
        (JSC::Interpreter::cti_op_not):
        (JSC::Interpreter::cti_op_jtrue):
        (JSC::Interpreter::cti_op_post_inc):
        (JSC::Interpreter::cti_op_lshift):
        (JSC::Interpreter::cti_op_bitand):
        (JSC::Interpreter::cti_op_rshift):
        (JSC::Interpreter::cti_op_bitnot):
        (JSC::Interpreter::cti_op_mod):
        (JSC::Interpreter::cti_op_post_dec):
        (JSC::Interpreter::cti_op_urshift):
        (JSC::Interpreter::cti_op_bitxor):
        (JSC::Interpreter::cti_op_bitor):
        (JSC::Interpreter::cti_op_push_scope):
        (JSC::Interpreter::cti_op_is_undefined):
        (JSC::Interpreter::cti_op_is_boolean):
        (JSC::Interpreter::cti_op_is_number):
        (JSC::Interpreter::cti_op_to_jsnumber):
        (JSC::Interpreter::cti_op_in):
        (JSC::Interpreter::cti_op_put_by_index):
        (JSC::Interpreter::cti_op_switch_imm):
        (JSC::Interpreter::cti_op_switch_char):
        (JSC::Interpreter::cti_op_switch_string):
        (JSC::Interpreter::cti_op_del_by_val):
        (JSC::Interpreter::cti_op_put_getter):
        (JSC::Interpreter::cti_op_put_setter):
        (JSC::Interpreter::cti_op_new_error):
        * interpreter/Interpreter.h:
        (JSC::Interpreter::isJSArray):
        (JSC::Interpreter::isJSString):
        (JSC::Interpreter::isJSByteArray):
        * interpreter/Register.h:
        (JSC::Register::marked):
        (JSC::Register::mark):
        * jit/JITInlineMethods.h:
        (JSC::JIT::getConstantOperandImmediateInt):
        (JSC::JIT::isOperandConstantImmediateInt):
        * jsc.cpp:
        (functionPrint):
        (functionDebug):
        (functionRun):
        (functionLoad):
        (runWithScripts):
        (runInteractive):
        * parser/Nodes.cpp:
        (JSC::processClauseList):
        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::addParentForConsoleStart):
        * profiler/Profiler.cpp:
        (JSC::Profiler::createCallIdentifier):
        * runtime/ArrayConstructor.cpp:
        (JSC::constructArrayWithSizeQuirk):
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncToString):
        (JSC::arrayProtoFuncToLocaleString):
        (JSC::arrayProtoFuncJoin):
        (JSC::arrayProtoFuncConcat):
        (JSC::arrayProtoFuncPop):
        (JSC::arrayProtoFuncPush):
        (JSC::arrayProtoFuncReverse):
        (JSC::arrayProtoFuncShift):
        (JSC::arrayProtoFuncSlice):
        (JSC::arrayProtoFuncSort):
        (JSC::arrayProtoFuncSplice):
        (JSC::arrayProtoFuncUnShift):
        (JSC::arrayProtoFuncFilter):
        (JSC::arrayProtoFuncMap):
        (JSC::arrayProtoFuncEvery):
        (JSC::arrayProtoFuncForEach):
        (JSC::arrayProtoFuncSome):
        (JSC::arrayProtoFuncIndexOf):
        (JSC::arrayProtoFuncLastIndexOf):
        * runtime/BooleanConstructor.cpp:
        (JSC::constructBoolean):
        (JSC::callBooleanConstructor):
        * runtime/BooleanPrototype.cpp:
        (JSC::booleanProtoFuncToString):
        (JSC::booleanProtoFuncValueOf):
        * runtime/Collector.cpp:
        (JSC::Heap::protect):
        (JSC::Heap::unprotect):
        (JSC::Heap::heap):
        (JSC::Heap::collect):
        (JSC::typeName):
        * runtime/Completion.cpp:
        (JSC::evaluate):
        * runtime/DateConstructor.cpp:
        (JSC::constructDate):
        (JSC::dateParse):
        (JSC::dateUTC):
        * runtime/DateInstance.h:
        (JSC::DateInstance::internalNumber):
        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):
        (JSC::fillStructuresUsingTimeArgs):
        (JSC::fillStructuresUsingDateArgs):
        (JSC::dateProtoFuncToString):
        (JSC::dateProtoFuncToUTCString):
        (JSC::dateProtoFuncToDateString):
        (JSC::dateProtoFuncToTimeString):
        (JSC::dateProtoFuncToLocaleString):
        (JSC::dateProtoFuncToLocaleDateString):
        (JSC::dateProtoFuncToLocaleTimeString):
        (JSC::dateProtoFuncGetTime):
        (JSC::dateProtoFuncGetFullYear):
        (JSC::dateProtoFuncGetUTCFullYear):
        (JSC::dateProtoFuncToGMTString):
        (JSC::dateProtoFuncGetMonth):
        (JSC::dateProtoFuncGetUTCMonth):
        (JSC::dateProtoFuncGetDate):
        (JSC::dateProtoFuncGetUTCDate):
        (JSC::dateProtoFuncGetDay):
        (JSC::dateProtoFuncGetUTCDay):
        (JSC::dateProtoFuncGetHours):
        (JSC::dateProtoFuncGetUTCHours):
        (JSC::dateProtoFuncGetMinutes):
        (JSC::dateProtoFuncGetUTCMinutes):
        (JSC::dateProtoFuncGetSeconds):
        (JSC::dateProtoFuncGetUTCSeconds):
        (JSC::dateProtoFuncGetMilliSeconds):
        (JSC::dateProtoFuncGetUTCMilliseconds):
        (JSC::dateProtoFuncGetTimezoneOffset):
        (JSC::dateProtoFuncSetTime):
        (JSC::setNewValueFromTimeArgs):
        (JSC::setNewValueFromDateArgs):
        (JSC::dateProtoFuncSetYear):
        (JSC::dateProtoFuncGetYear):
        * runtime/ErrorConstructor.cpp:
        (JSC::constructError):
        * runtime/ErrorPrototype.cpp:
        (JSC::errorProtoFuncToString):
        * runtime/ExceptionHelpers.cpp:
        (JSC::createError):
        (JSC::createErrorMessage):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * runtime/FunctionPrototype.cpp:
        (JSC::functionProtoFuncToString):
        (JSC::functionProtoFuncApply):
        (JSC::functionProtoFuncCall):
        * runtime/GetterSetter.cpp:
        (JSC::GetterSetter::toObject):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::getOwnPropertySlot):
        * runtime/JSArray.cpp:
        (JSC::JSArray::put):
        (JSC::JSArray::mark):
        (JSC::JSArray::sort):
        (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
        (JSC::JSArray::compactForSorting):
        * runtime/JSByteArray.h:
        (JSC::JSByteArray::setIndex):
        * runtime/JSCell.h:
        (JSC::asCell):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::call):
        (JSC::JSFunction::construct):
        * runtime/JSGlobalObject.cpp:
        (JSC::markIfNeeded):
        (JSC::lastInPrototypeChain):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::encode):
        (JSC::decode):
        (JSC::globalFuncEval):
        (JSC::globalFuncParseInt):
        (JSC::globalFuncParseFloat):
        (JSC::globalFuncIsNaN):
        (JSC::globalFuncIsFinite):
        (JSC::globalFuncEscape):
        (JSC::globalFuncUnescape):
        (JSC::globalFuncJSCPrint):
        * runtime/JSImmediate.cpp:
        (JSC::JSImmediate::toThisObject):
        (JSC::JSImmediate::toObject):
        (JSC::JSImmediate::prototype):
        (JSC::JSImmediate::toString):
        * runtime/JSImmediate.h:
        * runtime/JSObject.cpp:
        (JSC::JSObject::mark):
        (JSC::JSObject::put):
        (JSC::callDefaultValueFunction):
        (JSC::JSObject::getPrimitiveNumber):
        (JSC::JSObject::defineGetter):
        (JSC::JSObject::defineSetter):
        (JSC::JSObject::lookupGetter):
        (JSC::JSObject::lookupSetter):
        (JSC::JSObject::hasInstance):
        (JSC::JSObject::toNumber):
        (JSC::JSObject::toString):
        * runtime/JSObject.h:
        (JSC::JSObject::JSObject):
        (JSC::JSObject::inlineGetOwnPropertySlot):
        (JSC::JSObject::getOwnPropertySlotForWrite):
        (JSC::JSObject::getPropertySlot):
        (JSC::JSValuePtr::get):
        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::create):
        * runtime/JSString.cpp:
        (JSC::JSString::getOwnPropertySlot):
        * runtime/JSValue.h:
        * runtime/JSWrapperObject.cpp:
        (JSC::JSWrapperObject::mark):
        * runtime/JSWrapperObject.h:
        (JSC::JSWrapperObject::setInternalValue):
        * runtime/MathObject.cpp:
        (JSC::mathProtoFuncAbs):
        (JSC::mathProtoFuncACos):
        (JSC::mathProtoFuncASin):
        (JSC::mathProtoFuncATan):
        (JSC::mathProtoFuncATan2):
        (JSC::mathProtoFuncCeil):
        (JSC::mathProtoFuncCos):
        (JSC::mathProtoFuncExp):
        (JSC::mathProtoFuncFloor):
        (JSC::mathProtoFuncLog):
        (JSC::mathProtoFuncMax):
        (JSC::mathProtoFuncMin):
        (JSC::mathProtoFuncPow):
        (JSC::mathProtoFuncRound):
        (JSC::mathProtoFuncSin):
        (JSC::mathProtoFuncSqrt):
        (JSC::mathProtoFuncTan):
        * runtime/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::NativeErrorConstructor):
        (JSC::NativeErrorConstructor::construct):
        * runtime/NumberConstructor.cpp:
        (JSC::constructWithNumberConstructor):
        (JSC::callNumberConstructor):
        * runtime/NumberPrototype.cpp:
        (JSC::numberProtoFuncToString):
        (JSC::numberProtoFuncToLocaleString):
        (JSC::numberProtoFuncValueOf):
        (JSC::numberProtoFuncToFixed):
        (JSC::numberProtoFuncToExponential):
        (JSC::numberProtoFuncToPrecision):
        * runtime/ObjectConstructor.cpp:
        (JSC::constructObject):
        * runtime/ObjectPrototype.cpp:
        (JSC::objectProtoFuncValueOf):
        (JSC::objectProtoFuncHasOwnProperty):
        (JSC::objectProtoFuncIsPrototypeOf):
        (JSC::objectProtoFuncDefineGetter):
        (JSC::objectProtoFuncDefineSetter):
        (JSC::objectProtoFuncLookupGetter):
        (JSC::objectProtoFuncLookupSetter):
        (JSC::objectProtoFuncPropertyIsEnumerable):
        (JSC::objectProtoFuncToLocaleString):
        (JSC::objectProtoFuncToString):
        * runtime/Operations.h:
        (JSC::JSValuePtr::equalSlowCaseInline):
        (JSC::JSValuePtr::strictEqual):
        (JSC::JSValuePtr::strictEqualSlowCaseInline):
        * runtime/Protect.h:
        (JSC::gcProtect):
        (JSC::gcUnprotect):
        * runtime/RegExpConstructor.cpp:
        (JSC::setRegExpConstructorInput):
        (JSC::setRegExpConstructorMultiline):
        (JSC::constructRegExp):
        * runtime/RegExpObject.cpp:
        (JSC::setRegExpObjectLastIndex):
        (JSC::RegExpObject::match):
        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncTest):
        (JSC::regExpProtoFuncExec):
        (JSC::regExpProtoFuncCompile):
        (JSC::regExpProtoFuncToString):
        * runtime/StringConstructor.cpp:
        (JSC::stringFromCharCodeSlowCase):
        (JSC::stringFromCharCode):
        (JSC::constructWithStringConstructor):
        (JSC::callStringConstructor):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):
        (JSC::stringProtoFuncToString):
        (JSC::stringProtoFuncCharAt):
        (JSC::stringProtoFuncCharCodeAt):
        (JSC::stringProtoFuncConcat):
        (JSC::stringProtoFuncIndexOf):
        (JSC::stringProtoFuncLastIndexOf):
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
        (JSC::stringProtoFuncSlice):
        (JSC::stringProtoFuncSplit):
        (JSC::stringProtoFuncSubstr):
        (JSC::stringProtoFuncSubstring):
        (JSC::stringProtoFuncToLowerCase):
        (JSC::stringProtoFuncToUpperCase):
        (JSC::stringProtoFuncLocaleCompare):
        (JSC::stringProtoFuncBig):
        (JSC::stringProtoFuncSmall):
        (JSC::stringProtoFuncBlink):
        (JSC::stringProtoFuncBold):
        (JSC::stringProtoFuncFixed):
        (JSC::stringProtoFuncItalics):
        (JSC::stringProtoFuncStrike):
        (JSC::stringProtoFuncSub):
        (JSC::stringProtoFuncSup):
        (JSC::stringProtoFuncFontcolor):
        (JSC::stringProtoFuncFontsize):
        (JSC::stringProtoFuncAnchor):
        (JSC::stringProtoFuncLink):
        * runtime/Structure.cpp:
        (JSC::Structure::Structure):
        (JSC::Structure::getEnumerablePropertyNames):
        (JSC::Structure::createCachedPrototypeChain):
        * runtime/Structure.h:
        (JSC::Structure::mark):
        * runtime/StructureChain.cpp:
        (JSC::StructureChain::StructureChain):

JavaScriptGlue:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * JSUtils.cpp:
        (KJSValueToJSObject):
        (KJSValueToCFTypeInternal):
        * JSValueWrapper.cpp:
        (JSValueWrapper::JSObjectCopyPropertyNames):
        (JSValueWrapper::JSObjectCopyProperty):
        (JSValueWrapper::JSObjectSetProperty):
        (JSValueWrapper::JSObjectCallFunction):
        (JSValueWrapper::JSObjectMark):
        * UserObjectImp.cpp:
        (UserObjectImp::getOwnPropertySlot):

WebCore:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toHTMLCanvasStyle):
        (WebCore::JSCanvasRenderingContext2D::setFillColor):
        (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
        (WebCore::JSCanvasRenderingContext2D::strokeRect):
        (WebCore::JSCanvasRenderingContext2D::drawImage):
        (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
        (WebCore::JSCanvasRenderingContext2D::setShadow):
        (WebCore::JSCanvasRenderingContext2D::createPattern):
        (WebCore::JSCanvasRenderingContext2D::putImageData):
        (WebCore::JSCanvasRenderingContext2D::fillText):
        (WebCore::JSCanvasRenderingContext2D::strokeText):
        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::clearData):
        (WebCore::JSClipboard::getData):
        (WebCore::JSClipboard::setData):
        (WebCore::JSClipboard::setDragImage):
        * bindings/js/JSCustomPositionCallback.cpp:
        (WebCore::JSCustomPositionCallback::handleEvent):
        * bindings/js/JSCustomPositionErrorCallback.cpp:
        (WebCore::JSCustomPositionErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        (WebCore::JSCustomSQLStatementCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        (WebCore::JSCustomSQLTransactionCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::JSCustomVoidCallback::handleEvent):
        (WebCore::toVoidCallback):
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::create):
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::hasItem):
        (WebCore::JSDOMApplicationCache::add):
        (WebCore::JSDOMApplicationCache::remove):
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::valueToStringWithNullCheck):
        (WebCore::valueToStringWithUndefinedOrNullCheck):
        (WebCore::reportException):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::findJSEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
        (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
        * bindings/js/JSDOMStringListCustom.cpp:
        (WebCore::JSDOMStringList::item):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::getOwnPropertySlot):
        (windowProtoFuncOpen):
        (WebCore::toJSDOMWindow):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation):
        (WebCore::JSDOMWindow::postMessage):
        (WebCore::setTimeoutOrInterval):
        (WebCore::JSDOMWindow::clearTimeout):
        (WebCore::JSDOMWindow::clearInterval):
        (WebCore::JSDOMWindow::atob):
        (WebCore::JSDOMWindow::btoa):
        (WebCore::JSDOMWindow::addEventListener):
        (WebCore::JSDOMWindow::removeEventListener):
        (WebCore::toDOMWindow):
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::setLocation):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::setAttribute):
        (WebCore::JSElement::setAttributeNS):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/JSEventTargetNodeCustom.cpp:
        (WebCore::JSEventTargetNode::addEventListener):
        (WebCore::JSEventTargetNode::removeEventListener):
        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::createPositionOptions):
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::callHTMLCollection):
        (WebCore::JSHTMLCollection::canGetItemsForName):
        (WebCore::JSHTMLCollection::item):
        (WebCore::JSHTMLCollection::namedItem):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::open):
        (WebCore::writeHelper):
        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
        (WebCore::JSHTMLOptionsCollection::setLength):
        (WebCore::JSHTMLOptionsCollection::add):
        * bindings/js/JSHTMLSelectElementCustom.cpp:
        (WebCore::JSHTMLSelectElement::remove):
        (WebCore::selectIndexSetter):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::constructImage):
        * bindings/js/JSInspectedObjectWrapper.cpp:
        (WebCore::JSInspectedObjectWrapper::wrap):
        (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
        * bindings/js/JSInspectorCallbackWrapper.cpp:
        (WebCore::JSInspectorCallbackWrapper::wrap):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::evaluate):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::setHref):
        (WebCore::JSLocation::setProtocol):
        (WebCore::JSLocation::setHost):
        (WebCore::JSLocation::setHostname):
        (WebCore::JSLocation::setPort):
        (WebCore::JSLocation::setPathname):
        (WebCore::JSLocation::setSearch):
        (WebCore::JSLocation::setHash):
        (WebCore::JSLocation::replace):
        (WebCore::JSLocation::assign):
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::mark):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::startConversation):
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::mark):
        (WebCore::JSNodeFilterCondition::acceptNode):
        * bindings/js/JSNodeFilterCondition.h:
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::toNodeFilter):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::callNodeList):
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::constructHTMLOptionElement):
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::asWrapper):
        (WebCore::JSQuarantinedObjectWrapper::construct):
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        (WebCore::JSSQLResultSetRowList::item):
        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        (WebCore::JSSVGElementInstance::removeEventListener):
        * bindings/js/JSSVGLengthCustom.cpp:
        (WebCore::JSSVGLength::convertToSpecifiedUnits):
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::translate):
        (WebCore::JSSVGMatrix::scale):
        (WebCore::JSSVGMatrix::scaleNonUniform):
        (WebCore::JSSVGMatrix::rotate):
        (WebCore::JSSVGMatrix::rotateFromVector):
        (WebCore::JSSVGMatrix::skewX):
        (WebCore::JSSVGMatrix::skewY):
        * bindings/js/JSSVGPathSegListCustom.cpp:
        (WebCore::JSSVGPathSegList::getItem):
        (WebCore::JSSVGPathSegList::insertItemBefore):
        (WebCore::JSSVGPathSegList::replaceItem):
        (WebCore::JSSVGPathSegList::removeItem):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::JSSVGPointList::getItem):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::removeItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::JSSVGTransformList::getItem):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::removeItem):
        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::deleteProperty):
        (WebCore::JSStorage::customPut):
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::constructWebKitCSSMatrix):
        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::constructWorker):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        * bindings/js/JSWorkerCustom.cpp:
        (WebCore::JSWorker::addEventListener):
        (WebCore::JSWorker::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::open):
        (WebCore::JSXMLHttpRequest::setRequestHeader):
        (WebCore::JSXMLHttpRequest::send):
        (WebCore::JSXMLHttpRequest::getResponseHeader):
        (WebCore::JSXMLHttpRequest::overrideMimeType):
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/js/JSXSLTProcessorCustom.cpp:
        (WebCore::JSXSLTProcessor::importStylesheet):
        (WebCore::JSXSLTProcessor::transformToFragment):
        (WebCore::JSXSLTProcessor::transformToDocument):
        (WebCore::JSXSLTProcessor::setParameter):
        (WebCore::JSXSLTProcessor::getParameter):
        (WebCore::JSXSLTProcessor::removeParameter):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::executeFunctionInContext):
        * bindings/js/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::initialize):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::createScriptObjectForPluginElement):
        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::getString):
        (WebCore::ScriptValue::isNull):
        (WebCore::ScriptValue::isUndefined):
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:
        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        (_NPN_HasMethod):
        (_NPN_Construct):
        * bridge/c/c_utility.cpp:
        (JSC::Bindings::convertValueToNPVariant):
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::call):
        (JavaJSObject::convertValueToJObject):
        * bridge/jni/jni_runtime.cpp:
        (JavaField::dispatchValueFromInstance):
        (JavaField::valueFromInstance):
        (JavaField::dispatchSetValueToInstance):
        (JavaField::setValueToInstance):
        * bridge/jni/jni_utility.cpp:
        (JSC::Bindings::convertArrayInstanceToJavaArray):
        (JSC::Bindings::convertValueToJValue):
        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::callObjCFallbackObject):
        * bridge/objc/objc_utility.mm:
        (JSC::Bindings::convertValueToObjcValue):
        * bridge/runtime_method.cpp:
        (JSC::callRuntimeMethod):
        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::getOwnPropertySlot):
        (JSC::callRuntimeConstructor):

WebKit/mac:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::hasMethod):
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * WebView/WebView.mm:
        (aeDescFromJSValue):

WebKit/win:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * WebScriptCallFrame.cpp:
        (WebScriptCallFrame::jsValueToString):
        * WebView.cpp:
        (WebView::stringByEvaluatingJavaScriptFromString):

WebKit/wx:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * WebFrame.cpp:
        (wxWebFrame::RunScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 20 Jan 2009 00:33:38 +0000 (00:33 +0000)]
2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make Evaluate an asynchronous method that has a reply method.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Gustavo Noronha Silva <gns@gnome.org>
christian@webkit.org [Tue, 20 Jan 2009 00:27:18 +0000 (00:27 +0000)]
2009-01-20  Gustavo Noronha Silva  <gns@gnome.org>

         Reviewed by Mark Rowe.

         https://bugs.webkit.org/show_bug.cgi?id=23419
         removal of FramePrivate.h breaks GTK+'s make dist

         * GNUmakefile.am: No longer mention FramePrivate.h in our build,
         since it was removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Alexander V. Butenko <alex@digiqube.com>
christian@webkit.org [Tue, 20 Jan 2009 00:16:08 +0000 (00:16 +0000)]
2009-01-20  Alexander V. Butenko  <alex@digiqube.com>

        Reviewed by Holger Freyther.

        http://bugs.webkit.org/show_bug.cgi?id=23116
        [GTK] Fix crash due a callback called from GIO after the
        destruction of the ResourceHandle

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::cancel): Only call didFinishLoading if
        'client' is set, otherwise cancelling a load could lead to a crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
darin@apple.com [Mon, 19 Jan 2009 23:33:54 +0000 (23:33 +0000)]
JavaScriptCore:

2009-01-19  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
        <https://bugs.webkit.org/show_bug.cgi?id=23409>
        <rdar://problem/6505723>

        Test: fast/js/string-replace-3.html

        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure
        how this ever worked.

LayoutTests:

2009-01-19  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
        <https://bugs.webkit.org/show_bug.cgi?id=23409>
        <rdar://problem/6505723>

        * fast/js/resources/string-replace-3.js:
        * fast/js/string-replace-3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChangeLog typo fix.
simon.fraser@apple.com [Mon, 19 Jan 2009 23:22:10 +0000 (23:22 +0000)]
ChangeLog typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 19 Jan 2009 23:20:57 +0000 (23:20 +0000)]
2009-01-19  Simon Fraser  <simon.fraser@apple.com>

        Build fix: remove duplicate entries in the Xcode project, and
        sort the project with ort-Xcode-project-file .

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 19 Jan 2009 22:23:34 +0000 (22:23 +0000)]
2009-01-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=18078

        Support animations and transitions of shorthand properties by creating
        PropertyWrappers that simply wrap a vector of atomci wrappers, and implement
        equal() and blend(). Build that collection of shorthand wrappers using the
        shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
        shorthand wrappers during 'all' transitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoActually add the new header.
oliver@apple.com [Mon, 19 Jan 2009 22:16:43 +0000 (22:16 +0000)]
Actually add the new header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 David Levin <levin@chromium.org>
oliver@apple.com [Mon, 19 Jan 2009 22:09:21 +0000 (22:09 +0000)]
2009-01-19  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=22720

        Provide a generic class to handle the pattern of task callbacks across worker/parent threads.  It
        only works for methods that need 6 parameters but similar classes could be added as needed for
        other numbers of parameters.

        Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.

        Use these methods and others to remove document() from XMLHttpRequest in a few more places.

        No observable change in behavior, so no test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 19 Jan 2009 21:43:26 +0000 (21:43 +0000)]
2009-01-19  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Tim Hatcher

        Fix long standing typo.

        * History/WebBackForwardList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add links to some recommended Visual Studio hotfixes
aroben@apple.com [Mon, 19 Jan 2009 20:55:40 +0000 (20:55 +0000)]
    Add links to some recommended Visual Studio hotfixes

        Reviewed by Dave Hyatt.

        * building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update test results for https://bugs.webkit.org/show_bug.cgi?id=23417.
ap@webkit.org [Mon, 19 Jan 2009 20:51:58 +0000 (20:51 +0000)]
    Update test results for https://bugs.webkit.org/show_bug.cgi?id=23417.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23422: AX: AXLinks should expose access key information
cfleizach@apple.com [Mon, 19 Jan 2009 20:31:59 +0000 (20:31 +0000)]
Bug 23422: AX: AXLinks should expose access key information
https://bugs.webkit.org/show_bug.cgi?id=23422

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
ap@webkit.org [Mon, 19 Jan 2009 19:15:10 +0000 (19:15 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=23417
        Implement application cache obsolete state

        Test: http/tests/appcache/remove-cache.html

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::mark):
        * dom/EventNames.h:
        * loader/appcache/DOMApplicationCache.h:
        (WebCore::DOMApplicationCache::Status):
        (WebCore::DOMApplicationCache::setOnobsolete):
        (WebCore::DOMApplicationCache::onobsolete):
        * loader/appcache/DOMApplicationCache.idl:
        Added "obsolete" event and status.

        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer
        any need to track what the newest cache was during teardown.
        (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing
        confusion with cache group lifecycle status.
        (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete.
        (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does
        not belong to an obsolete group.
        (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto.
        (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen
        via a JS swapCache() call, not only when the loader is destroyed.
        (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer.
        (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is
        a caller responsibility, because this method is also used when loading caches from disk.
        (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and
        inform cache storage, so that it could be removed.
        (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did
        was call cacheUpdateFailed().
        (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure
        handing.
        (WebCore::ApplicationCacheGroup::didFail): Ditto.
        (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound()
        method for 404 and 410 responses.
        (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed()
        directly, instead of the removed didFailToLoadManifest().
        (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm.
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage
        after update successfully finishes (moved from setNewestCache()).
        (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using
        an explicitly passed pointer, without the need to save it during teardown.

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader):
        Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.

        * loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated
        some comments.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not
        obsolete.
        (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
        (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete
        groups, as they cannot be in storage.
        (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage
        completely, so that a new one could replace it, if necessary.
        (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions.
        (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.

        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state.
        (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the
        application was removed server-side.
        (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.

        * loader/appcache/DOMApplicationCache.h:
        (WebCore::DOMApplicationCache::Status):
        (WebCore::DOMApplicationCache::setOnobsolete):
        (WebCore::DOMApplicationCache::onobsolete):
        Added support for OBSOLETE state and obsolete event.

        * loader/appcache/DOMApplicationCache.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 19 Jan 2009 19:05:20 +0000 (19:05 +0000)]
2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Allow plug-in views to return an instance directly.

        * bindings/js/ScriptControllerMac.mm:
        (WebCore::ScriptController::createScriptInstanceForWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23399: AX: some buttons don't expose AXPress as an action
cfleizach@apple.com [Mon, 19 Jan 2009 18:18:37 +0000 (18:18 +0000)]
Bug 23399: AX: some buttons don't expose AXPress as an action
https://bugs.webkit.org/show_bug.cgi?id=23399

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
aroben@apple.com [Mon, 19 Jan 2009 16:28:19 +0000 (16:28 +0000)]
Windows build fix

WebCore:

        Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into
        $WebKitOutputDir so that WebKit can access them.

        * html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild
        and header copy.

WebKit/win:

        Windows build fix

        * DOMCoreClasses.cpp: Replaced "using namespace WebCore" with
        individual using directives for each type we need from that namespace,
        to avoid conflicts between DOMObject and WebCore::DOMObject.
        (DOMElement::font): Added a now-needed WebCore::.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Mon, 19 Jan 2009 15:40:24 +0000 (15:40 +0000)]
2009-01-19  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        http://www.qtsoftware.com/developer/task-tracker/index_html?id=211228&method=entry

        [Qt] Show focus rect when a button gets the focus for the first time.
        This is important at least for Windows style.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::applyTheme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 19 Jan 2009 13:39:03 +0000 (13:39 +0000)]
2009-01-19  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Fix calling of onkeypress event handlers on input elements when pressing enter
        and other text insertion commands in the Qt port.

        Similar to the win and mac ports don't execute text inserting editor
        commands on RawKeyDown but continue processing the event first in
        WebCore, i.e. also get a keypress event sent. If unhandled it will
        come back to EditorClientQt::handleKeyboardEvent later and we execute
        it then.

        This also fixes search by pressing enter on www.trafikanten.no.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Mon, 19 Jan 2009 13:00:08 +0000 (13:00 +0000)]
2009-01-19  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        [Qt] Build fix after r39971.

        * platform/qt/LoggingQt.cpp:
        (WebCore::InitializeLoggingChannelsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the build!
mrowe@apple.com [Mon, 19 Jan 2009 08:45:05 +0000 (08:45 +0000)]
Fix the build!

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 19 Jan 2009 07:15:12 +0000 (07:15 +0000)]
2009-01-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
        Remove FramePrivate

        Minor PLT speedup.

        * WebCore.base.exp:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/FrameLoader.cpp:
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::~Frame):
        (WebCore::Frame::init):
        (WebCore::Frame::loader):
        (WebCore::Frame::view):
        (WebCore::Frame::setView):
        (WebCore::Frame::script):
        (WebCore::Frame::document):
        (WebCore::Frame::setDocument):
        (WebCore::Frame::settings):
        (WebCore::Frame::selection):
        (WebCore::Frame::editor):
        (WebCore::Frame::selectionGranularity):
        (WebCore::Frame::setSelectionGranularity):
        (WebCore::Frame::dragCaretController):
        (WebCore::Frame::animation):
        (WebCore::Frame::mark):
        (WebCore::Frame::setMark):
        (WebCore::Frame::setCaretVisible):
        (WebCore::Frame::clearCaretRectIfNeeded):
        (WebCore::Frame::selectionLayoutChanged):
        (WebCore::Frame::caretBlinkTimerFired):
        (WebCore::Frame::paintCaret):
        (WebCore::Frame::paintDragCaret):
        (WebCore::Frame::zoomFactor):
        (WebCore::Frame::isZoomFactorTextOnly):
        (WebCore::Frame::shouldApplyTextZoom):
        (WebCore::Frame::shouldApplyPageZoom):
        (WebCore::Frame::setZoomFactor):
        (WebCore::Frame::setPrinting):
        (WebCore::Frame::setJSStatusBarText):
        (WebCore::Frame::setJSDefaultStatusBarText):
        (WebCore::Frame::jsStatusBarText):
        (WebCore::Frame::jsDefaultStatusBarText):
        (WebCore::Frame::setNeedsReapplyStyles):
        (WebCore::Frame::needsReapplyStyles):
        (WebCore::Frame::reapplyStyles):
        (WebCore::Frame::isContentEditable):
        (WebCore::Frame::updateSecureKeyboardEntryIfActive):
        (WebCore::Frame::typingStyle):
        (WebCore::Frame::setTypingStyle):
        (WebCore::Frame::clearTypingStyle):
        (WebCore::Frame::computeAndSetTypingStyle):
        (WebCore::Frame::selectionComputedStyle):
        (WebCore::Frame::applyEditingStyleToBodyElement):
        (WebCore::Frame::removeEditingStyleFromBodyElement):
        (WebCore::Frame::keepAlive):
        (WebCore::Frame::cancelAllKeepAlive):
        (WebCore::Frame::clearDOMWindow):
        (WebCore::Frame::ownerElement):
        (WebCore::Frame::ownerRenderer):
        (WebCore::Frame::isDisconnected):
        (WebCore::Frame::setIsDisconnected):
        (WebCore::Frame::excludeFromTextSearch):
        (WebCore::Frame::setExcludeFromTextSearch):
        (WebCore::Frame::selectionBounds):
        (WebCore::Frame::selectionTextRects):
        (WebCore::Frame::isFrameSet):
        (WebCore::Frame::currentForm):
        (WebCore::Frame::forceLayout):
        (WebCore::Frame::sendScrollEvent):
        (WebCore::Frame::clearTimers):
        (WebCore::Frame::styleForSelectionStart):
        (WebCore::Frame::inViewSourceMode):
        (WebCore::Frame::setInViewSourceMode):
        (WebCore::Frame::markAllMatchesForText):
        (WebCore::Frame::markedTextMatchesAreHighlighted):
        (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
        (WebCore::Frame::tree):
        (WebCore::Frame::setDOMWindow):
        (WebCore::Frame::domWindow):
        (WebCore::Frame::clearFormerDOMWindow):
        (WebCore::Frame::page):
        (WebCore::Frame::eventHandler):
        (WebCore::Frame::pageDestroyed):
        (WebCore::Frame::disconnectOwnerElement):
        (WebCore::Frame::documentAtPoint):
        * page/Frame.h:
        * page/FramePrivate.h: Removed.
        * page/FrameTree.h:
        * page/chromium/FrameChromium.cpp:
        * page/mac/FrameMac.mm:
        (WebCore::Frame::imageFromRect):
        (WebCore::Frame::selectionImage):
        (WebCore::Frame::snapshotDragImage):
        (WebCore::Frame::nodeImage):
        (WebCore::Frame::setUserStyleSheetLocation):
        (WebCore::Frame::setUserStyleSheet):
        * page/qt/FrameQt.cpp:
        (WebCore::Frame::setUserStyleSheetLocation):
        (WebCore::Frame::setUserStyleSheet):
        * page/win/FrameCGWin.cpp:
        (WebCore::Frame::nodeImage):
        * page/win/FrameWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=23414>.
mrowe@apple.com [Mon, 19 Jan 2009 02:31:36 +0000 (02:31 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=23414>.
Bug 23414: Reproducible crash accessing View menu with plugins disabled

Reviewed by Anders Carlsson.

* WebView/WebFrame.mm:
(-[WebFrame _canProvideDocumentSource]): Null-check the PluginData before using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sun, 18 Jan 2009 17:14:19 +0000 (17:14 +0000)]
2009-01-17  Eric Carlson  <eric.carlson@apple.com>

        Build fix for !ENABLE(VIDEO) following r40016.

        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::mouseEventIsInThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix.
sfalken@apple.com [Sun, 18 Jan 2009 04:30:18 +0000 (04:30 +0000)]
    Build fix.

        * WebCoreSupport/WebDragClient.cpp:
        (WebDragClient::createDragImageForLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
sfalken@apple.com [Sun, 18 Jan 2009 04:15:26 +0000 (04:15 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 18 Jan 2009 03:08:43 +0000 (03:08 +0000)]
2009-01-17  David Hyatt  <hyatt@apple.com>

        Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin.  isTextNode()
        on Node is now non-virtual and just checks a bit that is set at construction time by Text.

        Reviewed by Sam Weinig

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::CharacterData):
        * dom/CharacterData.h:
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::EventTargetNode):
        * dom/EventTargetNode.h:
        * dom/Node.cpp:
        (WebCore::Node::Node):
        * dom/Node.h:
        (WebCore::Node::isTextNode):
        (WebCore::Node::isAttributeNode):
        * dom/Text.cpp:
        (WebCore::Text::Text):
        * dom/Text.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix failing CSS Selector layout test. Don't test first-letter in a text test, since...
hyatt@apple.com [Sat, 17 Jan 2009 22:20:57 +0000 (22:20 +0000)]
Fix failing CSS Selector layout test.  Don't test first-letter in a text test, since that causes some of the selector text to be lost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Sat, 17 Jan 2009 21:38:38 +0000 (21:38 +0000)]
WebCore:

2009-01-17  David Hyatt  <hyatt@apple.com>

        Change how backslashAsCurrencySymbol() works.  Instead of forcing call sites to do the direct
        replacement themselves, the exact transformation is instead done by the encoding (indirectly through
        a method on Document).

        These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
        a slight speedup, and also allow encodings to do future alterations to displayed string content without
        having to patch call sites again.

        Reviewed by Oliver Hunt

        * WebCore.base.exp:
        * dom/Document.cpp:
        * dom/Document.h:
        (WebCore::Document::displayStringModifiedByEncoding):
        (WebCore::Document::displayBufferModifiedByEncoding):
        * editing/Editor.cpp:
        (WebCore::Editor::addToKillRing):
        * editing/TextIterator.cpp:
        (WebCore::plainTextToMallocAllocatedBuffer):
        (WebCore::plainText):
        * editing/TextIterator.h:
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::groupLabelText):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::text):
        * loader/DocumentLoader.cpp:
        (WebCore::canonicalizedTitle):
        * page/Chrome.cpp:
        (WebCore::displayString):
        (WebCore::Chrome::runJavaScriptAlert):
        (WebCore::Chrome::runJavaScriptConfirm):
        (WebCore::Chrome::runJavaScriptPrompt):
        (WebCore::Chrome::setStatusbarText):
        * page/Frame.cpp:
        (WebCore::Frame::shouldClose):
        * page/Frame.h:
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection):
        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::encode):
        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::TextEncoding):
        * platform/text/TextEncoding.h:
        (WebCore::TextEncoding::displayString):
        (WebCore::TextEncoding::displayBuffer):
        * rendering/HitTestResult.cpp:
        (WebCore::displayString):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText):
        (WebCore::RenderText::setTextInternal):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setInnerTextValue):
        (WebCore::RenderTextControl::finishText):

WebKit/mac:

2009-01-17  David Hyatt  <hyatt@apple.com>

        Eliminate dependencies on "backslashAsCurrencySymbol()" from WebKit, and make sure these alterations
        are done in WebCore instead.

        Reviewed by Oliver Hunt

        * WebView/WebFrame.mm:
        (-[WebFrame _selectedString]):
        (-[WebFrame _stringForRange:]):

WebKit/win:

2009-01-17  David Hyatt  <hyatt@apple.com>

        Eliminate dependencies on backslashAsCurrencySymbol from WebKit.

        Reviewed by Oliver Hunt

        * WebFrame.cpp:
        (WebFrame::selectedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sat, 17 Jan 2009 17:18:15 +0000 (17:18 +0000)]
2009-01-17  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson

        Complete <rdar://problem/6293969>

        * DerivedSources.make: include mediaControlsQT.css for Mac build.

        * WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart,
        CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
        * css/CSSSelector.h:
        (WebCore::CSSSelector::): Ditto.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):  include new media
        controller element styles

        * css/CSSValueKeywords.in: add keywords for new media time display controls

        * css/mediaControls.css: adjust css for new control elements

        * css/mediaControlsQT.css: Added.

        * platform/ThemeTypes.h:
        (WebCore::): add media time display controls to ControlPart

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added
        (WebCore::MediaTextDisplayElement::attachToParent): Added
        (WebCore::MediaTextDisplayElement::update): Added
        (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added
        (WebCore::MediaControlInputElement::MediaControlInputElement): Added
        (WebCore::MediaControlInputElement::hitTest): Added
        (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when
        dragging the thumb
        * rendering/MediaControlElements.h:
        (WebCore::): Add MediaTextDisplayElement

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::createTimelineContainer): Added
        (WebCore::RenderMedia::createTimeline): Parent is now the timeline container
        (WebCore::RenderMedia::createCurrentTimeDisplay): Added
        (WebCore::RenderMedia::createTimeRemainingDisplay): Added
        (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update
        timer when the time display elements are not visible
        (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes
        (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not
        visible. Display time remaining as well as current time.
        (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when
        visibility changes
        (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
        as we can't assume that all controls are rectangular
        * rendering/RenderMedia.h: Updated

        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call
        element hitTest() method instead of assuming it is rectangular
        * rendering/RenderSlider.h: make mouseEventIsInThumb virtual

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::paint): Deal with time display and timeline container
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::paintMediaTimelineContainer): Updated
        (WebCore::RenderTheme::paintMediaCurrentTime): Added
        (WebCore::RenderTheme::paintMediaTimeRemaining): Added

        * rendering/RenderThemeMac.h: Updated
        * rendering/RenderThemeMac.mm:
        (WebCore::):
        (WebCore::mediaControllerTheme):
        (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb
        size when appropriate
        (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function
        (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
        (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
        (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
        (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
        (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
        (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
        (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added
        (WebCore::RenderThemeMac::paintMediaCurrentTime): Added
        (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added
        (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added
        (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
        * rendering/style/RenderStyle.h: Updated
        (WebCore::):

2009-01-17  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson

        Complete <rdar://problem/6293969>

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Remove UseSharedMediaUI

2009-01-17  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson

        <rdar://problem/6293969>
        Update media controls rendering results for new controls CSS.

        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/media/video-display-toggle-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 09:36:51 +0000 (09:36 +0000)]
2009-01-17  David Hyatt  <hyatt@apple.com>

        Inline a few methods in FrameView for speed.

        Reviewed by Oliver Hunt

        * page/FrameView.cpp:
        * page/FrameView.h:
        (WebCore::FrameView::layoutCount):
        (WebCore::FrameView::needsFullRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 09:27:37 +0000 (09:27 +0000)]
2009-01-17  David Hyatt  <hyatt@apple.com>

        Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot().  Split off
        the code that fetches and caches the document element into a separate function and inline the part that
        does the null check and the return of the already-cached element.

        Reviewed by Oliver Hunt

        * dom/Document.cpp:
        (WebCore::Document::cacheDocumentElement):
        * dom/Document.h:
        (WebCore::Document::documentElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 09:11:53 +0000 (09:11 +0000)]
2009-01-17  David Hyatt  <hyatt@apple.com>

        Minor tweaks to RenderBox::styleChange to speed it up.

        Reviewed by Oliver Hunt

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::styleDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 08:41:43 +0000 (08:41 +0000)]
2009-01-17  David Hyatt  <hyatt@apple.com>

        Inline FrameLoader::client().

        Reviewed by Oliver Hunt

        * WebCore.base.exp:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::client):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoisNull() should be size().isEmpty(). Duh.
hyatt@apple.com [Sat, 17 Jan 2009 08:30:02 +0000 (08:30 +0000)]
isNull() should be size().isEmpty(). Duh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 08:27:02 +0000 (08:27 +0000)]
2009-01-17  David Hyatt  <hyatt@apple.com>

        Inline some Image methods for speed.  Fix CachedImage's addClient method to just use isNull rather
        than needlessly creating a rect.

        Reviewed by Oliver Hunt

        * loader/CachedImage.cpp:
        (WebCore::CachedImage::addClient):
        * platform/graphics/Image.cpp:
        * platform/graphics/Image.h:
        (WebCore::Image::isNull):
        (WebCore::Image::rect):
        (WebCore::Image::width):
        (WebCore::Image::height):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 08:17:01 +0000 (08:17 +0000)]
2009-01-17  David Hyatt  <hyatt@apple.com>

        Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.

        Reviewed by Oliver Hunt

        * css/CSSParserValues.cpp:
        (WebCore::CSSParserValueList::addValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 08:04:46 +0000 (08:04 +0000)]
2009-01-17  David Hyatt  <hyatt@apple.com>

        Inline Document::inPageCache(), since - because of animation code - it is now called every time
        styles change on any element and so is now super-hot.

        Reviewed by Oliver Hunt

        * dom/Document.cpp:
        * dom/Document.h:
        (WebCore::Document::inPageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 07:17:22 +0000 (07:17 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Take Font out of the GraphicsContext.  Fonts are moderately expensive to both compare and to assign to.
        The Font's presence in the GraphicsContext was making save/restore more expensive than it needed to be,
        and was also causing expensive comparison checks to be made before doing alterations of the Font in the
        GraphicsContext.

        A font must now be passed as a parameter to all text drawing functions.

        Reviewed by Oliver Hunt

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setFont):
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawText):
        (WebCore::GraphicsContext::drawBidiText):
        (WebCore::GraphicsContext::drawHighlightForText):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContextPrivate.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        * rendering/InlineTextBox.cpp:
        (WebCore::paintTextWithShadows):
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintCompositionBackground):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::paintDocumentMarkers):
        * rendering/InlineTextBox.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemForeground):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::paintCharacters):
        (WebCore::SVGInlineTextBox::paintSelection):
        * rendering/SVGInlineTextBox.h:
        * svg/SVGFont.cpp:
        (WebCore::Font::drawTextUsingSVGFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 06:54:35 +0000 (06:54 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Fix a regression from the virtualContinuation()/continuation() split where I accidentally changed
        two if statements.

        Reviewed by Oliver Hunt

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::absoluteRects):
        (WebCore::RenderObject::absoluteQuads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 17 Jan 2009 06:36:22 +0000 (06:36 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Fix a regression from my before/after optimization.  Make sure the <q> element puts the document
        into a mode where it will respect before/after rules, since <q> implicitly uses such rules.

        Make sure view source mode documents also turn on before/after rules, since they are used there also.

        Reviewed by Oliver Hunt

        * html/HTMLElementFactory.cpp:
        (WebCore::quoteConstructor):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Sat, 17 Jan 2009 04:57:56 +0000 (04:57 +0000)]
2009-01-16  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        On x86-64 jit, cache JSImmedate::TagMask & JSImmedate::TagTypeNumber in
        registers, save reloading them every time they're used.

        Draws x86-64 jit performance close to that of i386 jit.

        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::subPtr):
        (JSC::MacroAssembler::jnzPtr):
        (JSC::MacroAssembler::jzPtr):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileBinaryArithOpSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitJumpIfJSCell):
        (JSC::JIT::emitJumpIfNotJSCell):
        (JSC::JIT::emitJumpIfImmediateNumber):
        (JSC::JIT::emitJumpIfNotImmediateNumber):
        (JSC::JIT::emitJumpIfImmediateInteger):
        (JSC::JIT::emitJumpIfNotImmediateInteger):
        (JSC::JIT::emitFastArithIntToImmNoCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23397: AXURL is not reported for <INPUT type="image"> elements
cfleizach@apple.com [Sat, 17 Jan 2009 01:47:25 +0000 (01:47 +0000)]
Bug 23397: AXURL is not reported for <INPUT type="image"> elements
https://bugs.webkit.org/show_bug.cgi?id=23397

The AXURL of a <INPUT type="image"> element should be the URL of the image

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Adele Peterson <adele@apple.com>
adele@apple.com [Sat, 17 Jan 2009 01:14:27 +0000 (01:14 +0000)]
2009-01-16  Adele Peterson  <adele@apple.com>

        Windows build fix.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::logCanCachePageDecision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6502511> Safari crashes if it's running while the desktop...
sfalken@apple.com [Sat, 17 Jan 2009 00:50:28 +0000 (00:50 +0000)]
    <rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.

        This was caused by mismatched ENABLE definitions across WebCore and WebKit.

        Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
        In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
        to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
        Our Windows ENABLE flags now match Mac.

        Reviewed by Adele Peterson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago40,000!
mrowe@apple.com [Sat, 17 Jan 2009 00:47:16 +0000 (00:47 +0000)]
40,000!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Gabor Loki <loki@inf.u-szeged.hu>
mrowe@apple.com [Sat, 17 Jan 2009 00:47:07 +0000 (00:47 +0000)]
2009-01-16  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        * Scripts/webkitdirs.pm: Added '--makeargs' parameter which can pass additional
        parameters to make command in QMake projects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Sat, 17 Jan 2009 00:39:01 +0000 (00:39 +0000)]
2009-01-16  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Add support to x86-64 JIT for inline double precision arithmetic ops.
        +5/6% on x86-64, JIT enabled, sunspider.

        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::addPtr):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::movq_rr):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArith_op_pre_inc):
        (JSC::JIT::compileBinaryArithOp):
        (JSC::JIT::compileBinaryArithOpSlowCase):
        (JSC::JIT::compileFastArith_op_add):
        (JSC::JIT::compileFastArithSlow_op_add):
        (JSC::JIT::compileFastArith_op_mul):
        (JSC::JIT::compileFastArithSlow_op_mul):
        (JSC::JIT::compileFastArith_op_sub):
        (JSC::JIT::compileFastArithSlow_op_sub):
        * parser/ResultType.h:
        (JSC::ResultType::isReusable):
        (JSC::ResultType::isInt32):
        (JSC::ResultType::definitelyIsNumber):
        (JSC::ResultType::mightBeNumber):
        (JSC::ResultType::isNotNumber):
        (JSC::ResultType::unknownType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Sat, 17 Jan 2009 00:30:05 +0000 (00:30 +0000)]
    Reviewed by Justin Garcia.

        Make surroundNodeRangeWithElement call insertNodeBefore implicitly
        Make insertNodeBefore take PassRefPtr
        Clean up the use of PassRefPtr vs. raw pointers a few places in the editing code.
        https://bugs.webkit.org/show_bug.cgi?id=23389

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
        (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        * editing/ApplyStyleCommand.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::insertTab):
        * editing/ModifySelectionListLevel.cpp:
        (WebCore::IncreaseSelectionListLevelCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::removeNodePreservingChildren):
        (WebCore::ReplacementFragment::insertNodeBefore):
        (WebCore::ReplacementFragment::removeInterchangeNodes):
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::insertNodeAfterAndUpdateNodesInserted):
        (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
        (WebCore::ReplaceSelectionCommand::insertNodeBeforeAndUpdateNodesInserted):
        * editing/ReplaceSelectionCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23393: TextField has AXTitle and AXTitleUIElement
cfleizach@apple.com [Sat, 17 Jan 2009 00:15:47 +0000 (00:15 +0000)]
Bug 23393: TextField has AXTitle and AXTitleUIElement
https://bugs.webkit.org/show_bug.cgi?id=23393

A control that only has a label can have an AXTitle and an AXTitleUIElement.
It should only have the AXTitleUIElement

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoThe correct build fix for all platforms.
treat@webkit.org [Fri, 16 Jan 2009 23:48:57 +0000 (23:48 +0000)]
The correct build fix for all platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Qt build.
treat@webkit.org [Fri, 16 Jan 2009 23:39:00 +0000 (23:39 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 16 Jan 2009 23:34:46 +0000 (23:34 +0000)]
2009-01-16  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Fixes for SamplingTool.

        https://bugs.webkit.org/show_bug.cgi?id=23390

        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::storePtr):
        * bytecode/SamplingTool.cpp:
        (JSC::SamplingTool::run):
        (JSC::SamplingTool::dump):
        * bytecode/SamplingTool.h:
        (JSC::SamplingTool::encodeSample):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompile):
        * jit/JIT.h:
        (JSC::JIT::samplingToolTrackCodeBlock):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitCTICall_internal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 23:28:31 +0000 (23:28 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Add a new flag (similar to first-line and first-letter) to Document to track whether any before/after rules
        are being used.  If not, don't waste time probing for those pseudo element styles.

        Reviewed by Sam Weinig

        * css/CSSGrammar.y:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::usesBeforeAfterRules):
        (WebCore::Document::setUsesBeforeAfterRules):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::styleDidChange):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::styleDidChange):
        (WebCore::RenderInline::addChildToFlow):
        (WebCore::RenderInline::splitInlines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Dmitry Titov <dimich@chromium.org>
alp@webkit.org [Fri, 16 Jan 2009 23:26:26 +0000 (23:26 +0000)]
2009-01-16  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=23394
        Remove unnecessary calls to setDeferringTimers().

        Use of this function was obsoleted by better handling of EINTR.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::downloadTimerCallback): removed setDeferringTimers calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 23:14:02 +0000 (23:14 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Fix badness with the cursor CSS property.  For all links and form controls, resetting to a value of auto
        was resulting in the creation of a cursor list.  clearCursorList was creating a new list rather than just
        nulling out the pointer.  Since addCursor already lazily recreates the list, in the case of simple cursor types,
        the clear method was wastefully creating a completely unnecessary list for all of these elements.

        Also optimized the setting of simple cursor values to not alter the RenderStyle's cursor setting if it is already
        set to the same value.  Since this is the common case, it prevents a fault and copy of StyleInheritedData for
        all links and form controls.

        This is a PLT speedup.

        Reviewed by Oliver Hunt

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::clearCursorList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 16 Jan 2009 22:50:35 +0000 (22:50 +0000)]
2009-01-16  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23384
        PLATFORM(CHROMIUM) needs to delegate BackForwardList.cpp methods to the embedder

        * history/BackForwardList.h:
        (WebCore::BackForwardListClient::~BackForwardListClient):
        (WebCore::BackForwardList::setClient):
        * history/BackForwardListChromium.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Kevin Decker and Adam Roben.
mitz@apple.com [Fri, 16 Jan 2009 22:34:23 +0000 (22:34 +0000)]
    Reviewed by Kevin Decker and Adam Roben.

        - fix a regression that resulted in a crash when plug-ins were
          disabled.

        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget): Added a null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 22:23:41 +0000 (22:23 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Split continuation() into virtual and non-virtual versions so that the non-virtual version can
        be used whereever possible.  Eventually the virtual method can be eliminated completely.

        Reviewed by Sam Weinig and Oliver Hunt

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::anchorElement):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
        (WebCore::InlineFlowBox::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
        * rendering/RenderFlow.h:
        (WebCore::RenderFlow::virtualContinuation):
        (WebCore::RenderFlow::continuation):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::positionForCoordinates):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::absoluteRects):
        (WebCore::RenderObject::absoluteQuads):
        (WebCore::RenderObject::addFocusRingRects):
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
        (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
        (WebCore::RenderObject::handleDynamicFloatPositionChange):
        (WebCore::RenderObject::hoverAncestor):
        (WebCore::RenderObject::updateDragState):
        (WebCore::RenderObject::updateHitTestResult):
        (WebCore::RenderObject::getTextDecorationColors):
        (WebCore::RenderObject::adjustRectForOutlineAndShadow):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::virtualContinuation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Alexey Proskuryakov.
eric@webkit.org [Fri, 16 Jan 2009 21:53:20 +0000 (21:53 +0000)]
    Reviewed by Alexey Proskuryakov.

        Add toggle-styles test for editing.
        https://bugs.webkit.org/show_bug.cgi?id=23366

        This test demonstrates at least these 3 editing bugs:
        https://bugs.webkit.org/show_bug.cgi?id=17733
        https://bugs.webkit.org/show_bug.cgi?id=20215
        https://bugs.webkit.org/show_bug.cgi?id=22810

        * editing/execCommand/resources/toggle-styles.js: Added.
        * editing/execCommand/toggle-styles-expected.txt: Added.
        * editing/execCommand/toggle-styles.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 21:52:25 +0000 (21:52 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Inline the methods of Font for obtaining metrics such as ascent, descent and line spacing.

        Reviewed by ggaren

        * platform/graphics/Font.cpp:
        * platform/graphics/Font.h:
        (WebCore::Font::width):
        (WebCore::Font::ascent):
        (WebCore::Font::descent):
        (WebCore::Font::lineSpacing):
        (WebCore::Font::lineGap):
        (WebCore::Font::xHeight):
        (WebCore::Font::unitsPerEm):
        (WebCore::Font::spaceWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ggaren@apple.com [Fri, 16 Jan 2009 21:51:38 +0000 (21:51 +0000)]
JavaScriptCore:

2009-01-16  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed <rdar://problem/6452301> REGRESSION: Latest WebKit nightlies
        turn "c" into "" when stripping \\c_ character

        * wrec/WRECParser.cpp:
        (JSC::WREC::Parser::consumeEscape): Mimic a Firefox quirk when parsing
        control escapes inside character classes.

LayoutTests:

2009-01-16  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Added tests for <rdar://problem/6452301> REGRESSION: Latest WebKit
        nightlies turn "c" into "" when stripping \\c_ character

        * fast/regex/malformed-escapes-expected.txt:
        * fast/regex/resources/malformed-escapes.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 16 Jan 2009 21:48:30 +0000 (21:48 +0000)]
2009-01-16  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23388
        Remove FrameViewPrivate

        Removes an indirection and is a small speedup on PLT.

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::~FrameView):
        (WebCore::FrameView::reset):
        (WebCore::FrameView::resetScrollbars):
        (WebCore::FrameView::init):
        (WebCore::FrameView::clear):
        (WebCore::FrameView::didFirstLayout):
        (WebCore::FrameView::initScrollbars):
        (WebCore::FrameView::updateDefaultScrollbarState):
        (WebCore::FrameView::setCanHaveScrollbars):
        (WebCore::FrameView::applyOverflowToViewport):
        (WebCore::FrameView::layoutCount):
        (WebCore::FrameView::needsFullRepaint):
        (WebCore::FrameView::layoutRoot):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::setMediaType):
        (WebCore::FrameView::mediaType):
        (WebCore::FrameView::useSlowRepaints):
        (WebCore::FrameView::setUseSlowRepaints):
        (WebCore::FrameView::addSlowRepaintObject):
        (WebCore::FrameView::removeSlowRepaintObject):
        (WebCore::FrameView::scrollRectIntoViewRecursively):
        (WebCore::FrameView::setScrollPosition):
        (WebCore::FrameView::repaintContentRectangle):
        (WebCore::FrameView::beginDeferredRepaints):
        (WebCore::FrameView::endDeferredRepaints):
        (WebCore::FrameView::scheduleRelayout):
        (WebCore::FrameView::scheduleRelayoutOfSubtree):
        (WebCore::FrameView::layoutPending):
        (WebCore::FrameView::needsLayout):
        (WebCore::FrameView::unscheduleRelayout):
        (WebCore::FrameView::isTransparent):
        (WebCore::FrameView::setTransparent):
        (WebCore::FrameView::baseBackgroundColor):
        (WebCore::FrameView::setBaseBackgroundColor):
        (WebCore::FrameView::shouldUpdateWhileOffscreen):
        (WebCore::FrameView::setShouldUpdateWhileOffscreen):
        (WebCore::FrameView::scheduleEvent):
        (WebCore::FrameView::pauseScheduledEvents):
        (WebCore::FrameView::resumeScheduledEvents):
        (WebCore::FrameView::performPostLayoutTasks):
        (WebCore::FrameView::updateOverflowStatus):
        (WebCore::FrameView::dispatchScheduledEvents):
        (WebCore::FrameView::wasScrolledByUser):
        (WebCore::FrameView::setWasScrolledByUser):
        (WebCore::FrameView::paintContents):
        (WebCore::FrameView::setPaintRestriction):
        (WebCore::FrameView::isPainting):
        (WebCore::FrameView::setNodeToDraw):
        * page/FrameView.h:
        (WebCore::FrameView::setIsVisuallyNonEmpty): Inline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-14 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Fri, 16 Jan 2009 21:37:33 +0000 (21:37 +0000)]
2009-01-14  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 23237: Some HTML constructors in HTMLElementFactory needs
        an HTMLFormElement argument

        - Added 'constructorNeedsFormElement' parameter to make_names.pl to account
          for HTML form elements.

        - Added the new information to HTMLTagNames.in.

        * dom/make_names.pl:
        * html/HTMLTagNames.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 21:25:58 +0000 (21:25 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Eliminate a bunch of save/restore pairs from commonly used GraphicsContext methods.  The most common reason
        for needing save/restore in the line-drawing methods was antialiasing, so this has now been made part of
        the cross-platform graphics state.  By being able to query for the current antialiasing setting, antialiasing
        can be temporarily changed and then restored back to the real value without needing to do a save/restore.

        The line drawing code also set the fill color to the stroke color and relied on save/restore to prevent
        a permanent mutation of the fill color in the CGContext.   The new code just restores the fill color back
        to its original value without doing the much more expensive save/restore.

        Reviewed by Oliver Hunt

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setShouldAntialias):
        (WebCore::GraphicsContext::shouldAntialias):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContextPrivate.h:
        (WebCore::GraphicsContextState::GraphicsContextState):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::setPlatformShouldAntialias):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::drawLineForText):
        (WebCore::GraphicsContext::setPlatformShouldAntialias):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::setPlatformShouldAntialias):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformShouldAntialias):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::setPlatformShouldAntialias):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 Jan 2009 21:01:43 +0000 (21:01 +0000)]
2009-01-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Clean up the bridge code and get rid of Field::name() and Method::name().

        * bridge/c/c_instance.cpp:
        (JSC::Bindings::CInstance::invokeMethod):
        * bridge/c/c_runtime.cpp:
        * bridge/c/c_runtime.h:
        (JSC::Bindings::CField::identifier):
        (JSC::Bindings::CMethod::identifier):
        * bridge/jni/jni_class.cpp:
        (JavaClass::JavaClass):
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/jni_runtime.cpp:
        (JavaField::valueFromInstance):
        (JavaField::setValueToInstance):
        (JavaMethod::methodID):
        * bridge/jni/jni_runtime.h:
        (JSC::Bindings::JavaField::name):
        (JSC::Bindings::JavaMethod::name):
        * bridge/objc/objc_class.mm:
        (JSC::Bindings::ObjcClass::methodsNamed):
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        * bridge/objc/objc_runtime.h:
        (JSC::Bindings::ObjcMethod::isFallbackMethod):
        (JSC::Bindings::ObjcMethod::selector):
        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::ObjcMethod::ObjcMethod):
        (JSC::Bindings::ObjcMethod::getMethodSignature):
        (JSC::Bindings::ObjcField::ObjcField):
        (JSC::Bindings::ObjcField::valueFromInstance):
        (JSC::Bindings::ObjcField::setValueToInstance):
        (JSC::Bindings::callObjCFallbackObject):
        * bridge/runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 20:54:22 +0000 (20:54 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Optimize RenderText::styleDidChange.  Don't call the base class, which does extra meaningless work.
        Instead just do the one check we need to do (for a diff of layout) and mark dirty as appropriate.
        Clean up the base class method also to just bail early if no m_parent is set instead of repeatedly checking
        for the existence of m_parent in each if clause.

        Reviewed by Darin Adler

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleDidChange):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::styleDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23387: AX hierarchy is incorrect when iframes are present
cfleizach@apple.com [Fri, 16 Jan 2009 20:52:32 +0000 (20:52 +0000)]
Bug 23387: AX hierarchy is incorrect when iframes are present
https://bugs.webkit.org/show_bug.cgi?id=23387

AX hierarchy is incorrect when iframes are present

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Jeremy Moskovich <jeremy@chromium.org>
dglazkov@chromium.org [Fri, 16 Jan 2009 20:49:49 +0000 (20:49 +0000)]
2009-01-16  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=16001
        Re-land layout test which didn't land as part of r39785
        Move pixel results to platforms directory.

        * editing/selection/extend-selection-bidi.html: Added.
        * platform/mac/editing/selection/extend-selection-bidi-expected.checksum: Renamed from LayoutTests/editing/selection/extend-selection-bidi-expected.checksum.
        * platform/mac/editing/selection/extend-selection-bidi-expected.png: Renamed from LayoutTests/editing/selection/extend-selection-bidi-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 Jan 2009 20:44:46 +0000 (20:44 +0000)]
2009-01-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Set the count to the right number of elements.

        * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
        (testEnumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 16 Jan 2009 18:54:09 +0000 (18:54 +0000)]
2009-01-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/3541409> - Split up some back/forward cache decision making and add detailed logging to
        better understand what the common disqualifiers are.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePageContainingThisFrame):
        (WebCore::FrameLoader::canCachePage): Split off what will be per-frame decision making into canCacheSubframe.
        (WebCore::FrameLoader::logCanCachePageDecision): Detailed logging about why a page may not be considered for
          the back/forward cache.
        (WebCore::FrameLoader::logCanCacheFrameDecision): Same detailed logging on the per-frame basis.
        (WebCore::FrameLoader::commitProvisionalLoad): Move the m_client->canCachePage() call into canCachePageContainingThisFrame().
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
cmarrin@apple.com [Fri, 16 Jan 2009 18:27:18 +0000 (18:27 +0000)]
    Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
        This was happening because I was calling setChanged() from inside updateRendering()
        which causes an infinite loop. I fixed this by deferring the setChanged to the next
        run loop iteration. That made it not infinite loop, but it still retriggers the
        transition forever. The problem is that there is both an 'all' and specific transition
        on 'opacity'. This tickled a bug in AnimationController which causes the opacity
        transition to get constantly cancelled and then retriggered. The problem is that
        the specific opacity transition has a duration of 0. I got rid of the logic to
        flush out 0 duration transitions and it is no longer constantly triggered. The
        logic to flush them was just an optimization, and you really need to keep them
        around to make the logic to override earlier animations by later ones work. And there is
        very little overhead in this case anyway, so the optimization was not that useful.

        I made a LayoutTest from the original testcase which tests both the infinite
        loop and constantly triggering animation cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23385: crash at com.apple.WebCore • WebCore::HTMLAnchorElement::isKeyboardFocusable
cfleizach@apple.com [Fri, 16 Jan 2009 18:06:24 +0000 (18:06 +0000)]
Bug 23385: crash at com.apple.WebCore • WebCore::HTMLAnchorElement::isKeyboardFocusable
https://bugs.webkit.org/show_bug.cgi?id=23385

Option-tabbing on page with image map links causes crash

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 17:13:18 +0000 (17:13 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Increase popup focus delay time to a sensible 500 ms.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Thiago Macieira <thiago.macieira@nokia.com>
ariya@webkit.org [Fri, 16 Jan 2009 15:44:41 +0000 (15:44 +0000)]
2009-01-16  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fixes QString and 8-bit mix fixes.

        Details:  Make sure we use QLatin1String where appropriate (and don't
        use QString when not necessary)

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::create):
        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/qt/FileSystemQt.cpp:
        (WebCore::openTemporaryFile):
        * platform/qt/LoggingQt.cpp:
        (WebCore::InitializeLoggingChannelsIfNecessary):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
        * plugins/qt/PluginDataQt.cpp:
        (WebCore::PluginData::initPlugins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Fri, 16 Jan 2009 15:27:31 +0000 (15:27 +0000)]
    Windows build fix

        * wrec/WRECParser.cpp:
        (JSC::WREC::Parser::parseParentheses): Removed unreachable code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 15:16:34 +0000 (15:16 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=22452

        When plugins are disabled, plugin data should not be available for
        the page. This ensures that navigator.plugins would not see the
        additional MIME types supported by the plugins.

        * page/Page.cpp:
        (WebCore::Page::pluginData):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::shouldUsePlugin):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):

2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Adam Roben.

        [Qt] Prevent crash if plugin data is NULL.

        * WebCoreSupport/FrameLoaderClientQt.cpp: NULL check.
        (WebCore::FrameLoaderClientQt::objectContentType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug...
cmarrin@apple.com [Fri, 16 Jan 2009 15:09:17 +0000 (15:09 +0000)]
    Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug.cgi?id=21421.
        Also fixed the test case to work on ppc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 11:02:22 +0000 (11:02 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Per-line cursor movement tests depend on platform-specific font
        metrics. Remove them to avoid test failures on different platforms.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::cursorMovements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 10:12:45 +0000 (10:12 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        http://www.qtsoftware.com/developer/task-tracker/index_html?id=219344&method=entry

        [Qt] API documentation for QWebPage::WebAction enum.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 10:00:31 +0000 (10:00 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Another attempt at fixing the Qt build.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::getInstance):

        * Api/qwebframe.cpp:
        (QWebFrame::addToJavaScriptWindowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 08:35:06 +0000 (08:35 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Fix for 1.85% PLT regression.  Since asking if a frame is "complete" actually aggressively decodes
        the frame, we add an optimization when advancing animations.  If we have received all of the animated
        image's data, then obviously we can go ahead and advance safely.  This prevents the first draw of an image
        from decoding two frames' worth of data in the case where all of the image's data has been received.

        While this fixes the cached case, there could in fact be a regression on the uncached PLT from this change
        as well.  It's not immediately clear how that regression would be fixed, though, and it would likely be
        a much smaller percentage of that overall uncached time.

        Reviewed by Dan Bernstein

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::startAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ggaren@apple.com [Fri, 16 Jan 2009 08:01:44 +0000 (08:01 +0000)]
JavaScriptCore:

2009-01-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed <rdar://problem/6471394> REGRESSION (r39164): Discarding quantifier
        on assertion gives incorrect result (23075)

        https://bugs.webkit.org/show_bug.cgi?id=23075

        * pcre/pcre_compile.cpp:
        (compileBranch): Throw away an assertion if it's followed by a quantifier
        with a 0 minimum, to match SpiderMonkey, v8, and the ECMA spec.

        * wrec/WRECParser.cpp:
        (JSC::WREC::Parser::parseParentheses): Fall back on PCRE for the rare
        case of an assertion with a quantifier with a 0 minimum, since we
        don't handle quantified subexpressions yet, and in this special case,
        we can't just throw away the quantifier.

LayoutTests:

2009-01-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Added a test for <rdar://problem/6471394> REGRESSION (r39164): Discarding
        quantifier on assertion gives incorrect result (23075)

        * fast/regex/quantified-assertions-expected.txt:
        * fast/regex/resources/quantified-assertions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
ap@webkit.org [Fri, 16 Jan 2009 07:44:19 +0000 (07:44 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=23349
        Don't store obsolete caches in disk storage

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::load):
        (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache):
        * loader/ResourceLoader.h:
        Don't maintain m_wasLoadedFromApplicationCache, which was never used.

        * loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
        Assert that only implicit and dynamic resources can be added after the cache has been fully
        loaded and stored to disk database.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't remove non-newest caches from disk
        database, as this is now done whenever the cache becomes obsolete.
        (WebCore::ApplicationCacheGroup::setNewestCache): Remove an obsolete cache from disk storage.

        * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
        A cache group that has never been saved should not be remembered in m_cacheHostSet. Changed
        the check to no longer rely on savedNewestCachePointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39962 268f45cc-cd09-0410-ab3c-d52691b4dbfc