WebKit-https.git
7 years agoCleanup: Move js for treemap and aggregate_results into own js files.
jparent@chromium.org [Mon, 18 Mar 2013 21:43:19 +0000 (21:43 +0000)]
Cleanup: Move js for treemap and aggregate_results into own js files.
https://bugs.webkit.org/show_bug.cgi?id=112618

Reviewed by Dirk Pranke.

No functional changes, just moving the code into separate js file
rather than inlined in the html, so we can test it, make it more
modular, etc.  Other dashboard types are already done this way.

* TestResultServer/static-dashboards/aggregate_results.html:
* TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
(generatePage):
(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):
(chartHTML):
(filteredValues):
(chart):
(htmlForRevisionRows):
(wrapHTMLInTable):
(htmlForSummaryTable):
(valuesPerExpectation):
(htmlForTestType):
(htmlForTableRow):
(extendedEncode):
* TestResultServer/static-dashboards/treemap.html:
* TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
(humanReadableTime):
(convertToWebTreemapFormat):
(reverseSortByAverage):
(generatePage):
(focusPath):
(.switch.return):
(handleQueryParameterChange):
(extractName):
(fullName):
(handleFocus.):
(handleFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Marked flaky tests, removed obsolete
kbr@google.com [Mon, 18 Mar 2013 21:35:51 +0000 (21:35 +0000)]
Unreviewed gardening. Marked flaky tests, removed obsolete
expectations, and fixed flaky test fast/innerHTML/innerHTML-iframe.html .
https://bugs.webkit.org/show_bug.cgi?id=97816
https://bugs.webkit.org/show_bug.cgi?id=112306
https://bugs.webkit.org/show_bug.cgi?id=112621

* fast/innerHTML/innerHTML-iframe.html:
* platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
* platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
* platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
zandobersek@gmail.com [Mon, 18 Mar 2013 21:30:00 +0000 (21:30 +0000)]
[webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=112622

Reviewed by Dirk Pranke.

* Scripts/webkitpy/tool/steps/haslanded_unittest.py:
(HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using...
zandobersek@gmail.com [Mon, 18 Mar 2013 21:28:46 +0000 (21:28 +0000)]
[NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=112619

Reviewed by Dirk Pranke.

When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
directory and then fall back to the generic LayoutTests/platform/gtk directory.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
Port._webkit_baseline_path method.
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
(GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
that are expected based on the builder name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Get build working under VS2010.
bfulgham@webkit.org [Mon, 18 Mar 2013 21:28:42 +0000 (21:28 +0000)]
[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add build targets for
Debug_WinCairo and Release_WinCairo using CFLite.
* JavaScriptCore.vcxproj/JavaScriptCoreCFLite.props: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreDebugCFLite.props: Added.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
Add Debug_WinCairo and Release_WinCairo build targets to
make sure headers are copied to proper build folder.
* JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj: Ditto.
* JavaScriptCore.vcxproj/JavaScriptCoreReleaseCFLite.props: Added.
* JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
Add Debug_WinCairo and Release_WinCairo build targets to
make sure headers are copied to proper build folder.
* JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
Ditto.
* JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
Ditto.
* JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Ditto.
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj: Ditto.
* JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip some tests on Windows.
simon.fraser@apple.com [Mon, 18 Mar 2013 21:16:36 +0000 (21:16 +0000)]
Skip some tests on Windows.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Get build working under VS2010.
bfulgham@webkit.org [Mon, 18 Mar 2013 21:09:53 +0000 (21:09 +0000)]
[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

* WTF.vcxproj/WTF.vcxproj: Add Debug_WinCairo and Release_WinCairo
targets so headers get copied to appropriate build folder.
* WTF.vcxproj/WTFGenerated.vcxproj: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Build WinCairo port under VS2010
bfulgham@webkit.org [Mon, 18 Mar 2013 21:08:43 +0000 (21:08 +0000)]
[WinCairo] Build WinCairo port under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

* WebKit.vcxproj/WebKit.sln: Add Debug_WinCairo and Release_WinCairo
build targets. No other changes in this patch.
* WebKit.vcxproj/FeatureDefinesCairo.props: Add parallel property
sheet for WinCairo version of build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERTION FAILED: !NoEventDispatchAssertion::isEventDispatchForbidden()
simon.fraser@apple.com [Mon, 18 Mar 2013 20:57:49 +0000 (20:57 +0000)]
ASSERTION FAILED: !NoEventDispatchAssertion::isEventDispatchForbidden()
https://bugs.webkit.org/show_bug.cgi?id=112620

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp/tests/navigation/navigation-redirect-schedule-crash.html asserts sometimes
simon.fraser@apple.com [Mon, 18 Mar 2013 20:57:43 +0000 (20:57 +0000)]
http/tests/navigation/navigation-redirect-schedule-crash.html asserts sometimes
https://bugs.webkit.org/show_bug.cgi?id=112617

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix GridTrackSize::operator==
hans@chromium.org [Mon, 18 Mar 2013 20:56:06 +0000 (20:56 +0000)]
Fix GridTrackSize::operator==
https://bugs.webkit.org/show_bug.cgi?id=112501

Reviewed by Eric Seidel.

Source/WebCore:

There was a missing "other." in the function.

This was found by experimenting with a potential new Clang warning.

Test: fast/css-grid-layout/grid-dynamic-updates-relayout.html

* rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::operator==):

LayoutTests:

Add a test to check that style changes cause relayout correctly.

* fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt: Added.
* fast/css-grid-layout/grid-dynamic-updates-relayout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on...
alecflett@chromium.org [Mon, 18 Mar 2013 20:48:44 +0000 (20:48 +0000)]
Inspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on Win7 following r133855
https://bugs.webkit.org/show_bug.cgi?id=101618

Deactivate transactions created by the inspector, before
they are reactivated by IndexedDB. This puts transactions
in an identical state as when they are created by scripts.

Reviewed by Vsevolod Vlasov.

Test: http/tests/inspector/indexeddb/database-data.html

* inspector/InspectorIndexedDBAgent.cpp: Make transactions inactive upon leaving the inspector code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow blocking of application cache in third-party contexts
jpfau@apple.com [Mon, 18 Mar 2013 20:45:28 +0000 (20:45 +0000)]
Allow blocking of application cache in third-party contexts
https://bugs.webkit.org/show_bug.cgi?id=112288

Reviewed by Adam Barth.

Source/WebCore:

Return early if we can't access the application cache due to security
restrictions.

Tests: http/tests/security/cross-origin-appcache-allowed.html
       http/tests/security/cross-origin-appcache.html
       http/tests/security/same-origin-appcache-blocked.html

* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessApplicationCache):

LayoutTests:

* http/tests/security/cross-origin-appcache-allowed-expected.txt: Added.
* http/tests/security/cross-origin-appcache-allowed.html: Added.
* http/tests/security/cross-origin-appcache-expected.txt: Added.
* http/tests/security/cross-origin-appcache.html: Added.
* http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html: Added.
* http/tests/security/resources/cross-origin-iframe-for-appcache.html: Added.
* http/tests/security/resources/manifest-for-appcache-allowed.manifest: Added.
* http/tests/security/resources/manifest-for-appcache-blocked.manifest: Added.
* http/tests/security/resources/manifest-for-appcache.manifest: Added.
* http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html: Added.
* http/tests/security/same-origin-appcache-blocked-expected.txt: Added.
* http/tests/security/same-origin-appcache-blocked.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoplugins/plugin-clip-subframe.html is flakey
simon.fraser@apple.com [Mon, 18 Mar 2013 20:37:54 +0000 (20:37 +0000)]
plugins/plugin-clip-subframe.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112616

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Script should know nothing about disabled source mappings.
vsevik@chromium.org [Mon, 18 Mar 2013 20:27:50 +0000 (20:27 +0000)]
Web Inspector: Script should know nothing about disabled source mappings.
https://bugs.webkit.org/show_bug.cgi?id=112580

Reviewed by Pavel Feldman.

Source/WebCore:

ResourceScriptMapping handles diverged uiSourceCodes internally now.

Tested in inspector/debugger/live-edit-breakpoints.html already.

* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasMergedToVM):
(WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVM):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.rawLocationToUILocation):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
pilgrim@chromium.org [Mon, 18 Mar 2013 20:26:25 +0000 (20:26 +0000)]
[Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
https://bugs.webkit.org/show_bug.cgi?id=112571

Reviewed by Adam Barth.

Source/Platform:

New top-level enum (not tied to WebFileSystem class) will allow
easier refactoring of filesystem methods within the Platform/
directory. (All changes are behind an #ifdef so we can sync
required changes in embedders.)

* chromium/public/WebFileSystemType.h: new file
(WebKit):

* Platform.gypi:
* chromium/public/WebFileSystem.h:
* chromium/public/WebFileSystemType.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit):

Source/WebKit/chromium:

Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)

* public/WebCommonWorkerClient.h:
(WebCommonWorkerClient):
(WebKit::WebCommonWorkerClient::openFileSystem):
* public/WebFrame.h:
(WebFrame):
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):
* src/LocalFileSystemChromium.cpp:
(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):
* src/WebFrameImpl.cpp:
(WebKit):
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebWorkerClientImpl.cpp:
(WebKit):
(WebKit::WebWorkerClientImpl::openFileSystem):
* src/WebWorkerClientImpl.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:
(WorkerFileSystemCallbacksBridge):

Tools:

Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::openFileSystem):
(WebViewHost::deleteFileSystem):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate MessagePort terminology to match HTML5
ap@apple.com [Mon, 18 Mar 2013 20:25:46 +0000 (20:25 +0000)]
Update MessagePort terminology to match HTML5
https://bugs.webkit.org/show_bug.cgi?id=112611

Reviewed by Anders Carlsson.

Transferable objects are "neutered" when transfered. Cloning is a different operation.

* dom/MessagePort.cpp:
(WebCore::MessagePort::disentanglePorts):
* dom/MessagePort.h:
(WebCore::MessagePort::isEntangled):
(WebCore::MessagePort::isNeutered):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAppleWin VS2010 build fix.
roger_fong@apple.com [Mon, 18 Mar 2013 20:23:39 +0000 (20:23 +0000)]
AppleWin VS2010 build fix.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother asserting test.
simon.fraser@apple.com [Mon, 18 Mar 2013 20:23:26 +0000 (20:23 +0000)]
Another asserting test.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark a couple of asserty tests as such.
simon.fraser@apple.com [Mon, 18 Mar 2013 20:18:17 +0000 (20:18 +0000)]
Mark a couple of asserty tests as such.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup: Move timeline_exporer js out of html file into js.
jparent@chromium.org [Mon, 18 Mar 2013 19:56:13 +0000 (19:56 +0000)]
Cleanup: Move timeline_exporer js out of html file into js.
https://bugs.webkit.org/show_bug.cgi?id=112188

Reviewed by Dirk Pranke.

Moves the javascript out of the html file and into a new js file.
This follows the format of flakiness_dashboard.{html|js}.

Also moves code from dashboard_base that is used only by this one
dashboard, and makes it private to the dashboard.

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/timeline_explorer.html:
* TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
(generatePage):
(initCurrentBuilderTestResults):
(shouldShowWebKitRevisionsOnly):
(updateTimelineForBuilder.):
(updateTimelineForBuilder):
(selectBuild):
(updateBuildIndicator):
(.addRow):
(.addNumberRow):
(.inspectorNode.getElementsByTagName.0.onclick):
(.inspectorNode.getElementsByTagName.1.onclick):
(.inspectorNode.getElementsByTagName.2.onclick):
(updateBuildInspector):
(showResultsDelta):
(decompressResults.addFlakyDelta):
(decompressResults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Added expectation for failing test.
kbr@google.com [Mon, 18 Mar 2013 19:45:38 +0000 (19:45 +0000)]
Unreviewed gardening. Added expectation for failing test.
https://bugs.webkit.org/show_bug.cgi?id=112610

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css3-text] Add rendering support for -webkit-text-underline-position
commit-queue@webkit.org [Mon, 18 Mar 2013 19:43:22 +0000 (19:43 +0000)]
[css3-text] Add rendering support for -webkit-text-underline-position
https://bugs.webkit.org/show_bug.cgi?id=102795

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-18
Reviewed by Levi Weintraub.

Source/WebCore:

This patch implements rendering support for values [ auto | alphabetic | under ]
of CSS3 property text-underline-position. We don't fully match the specification
as we don't support [ left | right ] and this is left for another implementation
as the rendering will need to be added.

Tests: fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html
       fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html
       fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html
       fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html
       fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeMaxLogicalTop): Added method to compute maximal logical top among all chidren of
this InlineTextBox.
* rendering/InlineFlowBox.h:
(InlineFlowBox):
* rendering/InlineTextBox.cpp:
(WebCore::computeUnderlineOffset): Added method to compute offset for text-underline-position property.
(WebCore::InlineTextBox::paintDecoration): Paint decoration at position calculated using computeUnderlineOffset().
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Call method to compute maximal logical top among all
children of this RootInlineBox.
* rendering/RootInlineBox.h:
(RootInlineBox):
(WebCore::RootInlineBox::maxLogicalTop): Added getter for m_maxLogicalTop class member.
* rendering/style/RenderStyle.h: Added the usual getter / setter / initial methods for text-underline-position
property

LayoutTests:

Added text-underline-position tests for 'text-underline-position' CSS3
property, with 'webkit' prefix.

* fast/css3-text/css3-text-decoration/text-underline-position/style.css: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.txt: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.txt: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.txt: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.txt: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html: Added.
* fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html: Added.
* platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.png: Added.
* platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png: Added.
* platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.png: Added.
* platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.png: Added.
* platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert old flexbox uses in html.css to new flexbox (non-<select>)
commit-queue@webkit.org [Mon, 18 Mar 2013 19:32:40 +0000 (19:32 +0000)]
Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-18
Reviewed by Ojan Vafai.

No new tests (No change in behaviour)

* css/html.css:
(input::-webkit-clear-button):
Missed this one in the original patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAudioBasicProcessorNode need to check for deferred updating of output channels
james.wei@intel.com [Mon, 18 Mar 2013 19:26:14 +0000 (19:26 +0000)]
AudioBasicProcessorNode need to check for deferred updating of output channels
https://bugs.webkit.org/show_bug.cgi?id=112544

There can in rare cases be a slight delay before the output
bus is updated to the new number of channels because of tryLocks() in the
context's updating system but the processor already updated to the new
number of channels, so need to check the channel number before processing.

Reviewed by Chris Rogers.

* Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::process):
* Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::process):
* platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):
* platform/audio/AudioDSPKernelProcessor.h:
(WebCore::AudioDSPKernelProcessor::numberOfChannels):
(AudioDSPKernelProcessor):
* platform/audio/AudioProcessor.h:
(WebCore::AudioProcessor::AudioProcessor):
(AudioProcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r145272.
dpranke@chromium.org [Mon, 18 Mar 2013 19:20:58 +0000 (19:20 +0000)]
Unreviewed, rolling out r145272.
http://trac.webkit.org/changeset/145272
https://bugs.webkit.org/show_bug.cgi?id=111884

Turns out the ASAN build is still broken; possibly there's
something still setting LD_LIBRARY_PATH, or possibly there's
something else wrong. In the meantime, we need it to work again.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPotentially unsafe register allocations in DFG code generation
msaboff@apple.com [Mon, 18 Mar 2013 19:11:47 +0000 (19:11 +0000)]
Potentially unsafe register allocations in DFG code generation
https://bugs.webkit.org/show_bug.cgi?id=112477

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Moved allocation of temporary GPRs to be before any generated branches in the functions below.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):

LayoutTests:

New tests added to verify proper operation of
SpeculativeJIT::compileObjectToObjectOrOtherEquality,
SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality
and SpeculativeJIT::compileObjectOrOtherLogicalNot.

* fast/js/dfg-compare-final-object-to-final-object-or-other-expected.txt: Added.
* fast/js/dfg-compare-final-object-to-final-object-or-other.html: Added.
* fast/js/dfg-logical-not-final-object-or-other-expected.txt: Added.
* fast/js/dfg-logical-not-final-object-or-other.html: Added.
* fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Added.
* fast/js/dfg-peephole-compare-final-object-to-final-object-or-other.html: Added.
* fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Added.
* fast/js/script-tests/dfg-logical-not-final-object-or-other.js: Added.
* fast/js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Fix StyleGridData::operator==
jchaffraix@webkit.org [Mon, 18 Mar 2013 19:04:37 +0000 (19:04 +0000)]
[CSS Grid Layout] Fix StyleGridData::operator==
https://bugs.webkit.org/show_bug.cgi?id=112574

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-update.html

* rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
Fixed a bad comparison that would make us ignore grid-auto-flow changes.

LayoutTests:

* fast/css-grid-layout/grid-auto-flow-update-expected.txt: Added.
* fast/css-grid-layout/grid-auto-flow-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo on Windows following r145849 that was causing DRT to crash 100% of the time.
roger_fong@apple.com [Mon, 18 Mar 2013 18:55:58 +0000 (18:55 +0000)]
Fix typo on Windows following r145849 that was causing DRT to crash 100% of the time.

* WebView.cpp:
(WebView::setSmartInsertDeleteEnabled):
(WebView::setSelectTrailingWhitespaceEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Marked flaky tests.
kbr@google.com [Mon, 18 Mar 2013 18:52:59 +0000 (18:52 +0000)]
Unreviewed gardening. Marked flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=112598
https://bugs.webkit.org/show_bug.cgi?id=112601
https://bugs.webkit.org/show_bug.cgi?id=112603

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac build fix after http://trac.webkit.org/changeset/146088
beidson@apple.com [Mon, 18 Mar 2013 18:41:33 +0000 (18:41 +0000)]
Mac build fix after trac.webkit.org/changeset/146088

* NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::platformDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[HTMLTemplateElement] parseError check in processTemplateEndTag should use hasTagName...
rafaelw@chromium.org [Mon, 18 Mar 2013 18:39:36 +0000 (18:39 +0000)]
[HTMLTemplateElement] parseError check in processTemplateEndTag should use hasTagName, not hasLocalName
https://bugs.webkit.org/show_bug.cgi?id=112591

Reviewed by Adam Barth.

No tests needed, change is unobservable.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodelete-stale-build-files is too aggressive
rniwa@webkit.org [Mon, 18 Mar 2013 18:34:14 +0000 (18:34 +0000)]
delete-stale-build-files is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=112595

Reviewed by Tim Horton.

It appears that whitelisting file extensions to keep is not a good idea.
Blacklist files to delete instead, and only delete .o files for now.
We can add more file extensions as needed.

* BuildSlaveSupport/delete-stale-build-files:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
commit-queue@webkit.org [Mon, 18 Mar 2013 18:33:34 +0000 (18:33 +0000)]
[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Fix missing brace.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Compositor is applying scroll offset using 'programmatic' API
jknotten@chromium.org [Mon, 18 Mar 2013 18:32:00 +0000 (18:32 +0000)]
[Chromium] Compositor is applying scroll offset using 'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712

Reviewed by James Robinson.

Ensure that the compositor uses non-programmatic APIs to scroll and
scale.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::updateMainFrameScrollPosition):
(WebKit):
(WebKit::WebViewImpl::applyScrollAndScale):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebFrameTest.cpp:
* tests/WebViewTest.cpp:
* tests/data/long_scroll.html: Added.
* tests/data/short_scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add Proximity Detector.
commit-queue@webkit.org [Mon, 18 Mar 2013 18:29:42 +0000 (18:29 +0000)]
[BlackBerry] Add Proximity Detector.
https://bugs.webkit.org/show_bug.cgi?id=112278

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Fix variable names so they actually match the function
declarations.

Fix call to rectForPoint(), which was moved from HitTestResult to
HitTestLocation in r117091 and r126859.

* WebKitSupport/ProximityDetector.cpp:
(BlackBerry::WebKit::ProximityDetector::findBestPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG string conversions and allocations should be inlined
fpizlo@apple.com [Mon, 18 Mar 2013 18:09:22 +0000 (18:09 +0000)]
DFG string conversions and allocations should be inlined
https://bugs.webkit.org/show_bug.cgi?id=112376

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

This turns new String(), String(), String.prototype.valueOf(), and
String.prototype.toString() into intrinsics. It gives the DFG the ability to handle
conversions from StringObject to JSString and vice-versa, and also gives it the
ability to handle cases where a variable may be either a StringObject or a JSString.
To do this, I added StringObject to value profiling (and removed the stale
distinction between Myarguments and Foreignarguments). I also cleaned up ToPrimitive
handling, using some of the new functionality but also taking advantage of the
existence of Identity(String:@a).

This is a 2% SunSpider speed-up. Also there are some speed-ups on V8v7 and Kraken.
On microbenchmarks that stress new String() this is a 14x speed-up.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::hasExitSite):
(JSC):
* bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::hasExitSite):
(DFG):
* bytecode/DFGExitProfile.h:
(ExitProfile):
(JSC::DFG::ExitProfile::hasExitSite):
* bytecode/ExitKind.cpp:
(JSC::exitKindToString):
* bytecode/ExitKind.h:
* bytecode/SpeculatedType.cpp:
(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromClassInfo):
* bytecode/SpeculatedType.h:
(JSC):
(JSC::isStringObjectSpeculation):
(JSC::isStringOrStringObjectSpeculation):
* create_hash_table:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::filterEdgeByUse):
* dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(DFG):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
* dfg/DFGEdge.h:
(JSC::DFG::Edge::shift):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(FixupPhase):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::hasGlobalExitSite):
(Graph):
(JSC::DFG::Graph::hasExitSite):
(JSC::DFG::Graph::clobbersWorld):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToToString):
(Node):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::shouldSpeculateStringObject):
(JSC::DFG::Node::shouldSpeculateStringOrStringObject):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(DFG):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
(JSC::DFG::SpeculativeJIT::speculate):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGUseKind.cpp:
(WTF::printInternal):
* dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
* interpreter/CallFrame.h:
(JSC::ExecState::regExpPrototypeTable):
* runtime/CommonIdentifiers.h:
* runtime/Intrinsic.h:
* runtime/JSDestructibleObject.h:
(JSDestructibleObject):
(JSC::JSDestructibleObject::classInfoOffset):
* runtime/JSGlobalData.cpp:
(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSObject.cpp:
* runtime/JSObject.h:
(JSC):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::allocationSize):
(JSWrapperObject):
(JSC::JSWrapperObject::internalValueOffset):
(JSC::JSWrapperObject::internalValueCellOffset):
* runtime/StringPrototype.cpp:
(JSC):
(JSC::StringPrototype::finishCreation):
(JSC::StringPrototype::create):
* runtime/StringPrototype.h:
(StringPrototype):

LayoutTests:

Reviewed by Geoffrey Garen.

* fast/js/dfg-to-string-bad-toString-expected.txt: Added.
* fast/js/dfg-to-string-bad-toString.html: Added.
* fast/js/dfg-to-string-bad-valueOf-expected.txt: Added.
* fast/js/dfg-to-string-bad-valueOf.html: Added.
* fast/js/dfg-to-string-int-expected.txt: Added.
* fast/js/dfg-to-string-int-or-string-expected.txt: Added.
* fast/js/dfg-to-string-int-or-string.html: Added.
* fast/js/dfg-to-string-int.html: Added.
* fast/js/dfg-to-string-side-effect-clobbers-toString-expected.txt: Added.
* fast/js/dfg-to-string-side-effect-clobbers-toString.html: Added.
* fast/js/dfg-to-string-side-effect-expected.txt: Added.
* fast/js/dfg-to-string-side-effect.html: Added.
* fast/js/dfg-to-string-toString-becomes-bad-expected.txt: Added.
* fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype-expected.txt: Added.
* fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.html: Added.
* fast/js/dfg-to-string-toString-becomes-bad.html: Added.
* fast/js/dfg-to-string-toString-in-string-expected.txt: Added.
* fast/js/dfg-to-string-toString-in-string.html: Added.
* fast/js/dfg-to-string-valueOf-becomes-bad-expected.txt: Added.
* fast/js/dfg-to-string-valueOf-becomes-bad.html: Added.
* fast/js/dfg-to-string-valueOf-in-string-expected.txt: Added.
* fast/js/dfg-to-string-valueOf-in-string.html: Added.
* fast/js/jsc-test-list:
* fast/js/regress/script-tests/string-concat-object.js: Added.
(foo):
* fast/js/regress/script-tests/string-concat-pair-object.js: Added.
(foo):
* fast/js/regress/script-tests/string-concat-pair-simple.js: Added.
(foo):
* fast/js/regress/script-tests/string-concat-simple.js: Added.
(foo):
* fast/js/regress/script-tests/string-cons-repeat.js: Added.
(foo):
* fast/js/regress/script-tests/string-cons-tower.js: Added.
(foo):
* fast/js/regress/string-concat-object-expected.txt: Added.
* fast/js/regress/string-concat-object.html: Added.
* fast/js/regress/string-concat-pair-object-expected.txt: Added.
* fast/js/regress/string-concat-pair-object.html: Added.
* fast/js/regress/string-concat-pair-simple-expected.txt: Added.
* fast/js/regress/string-concat-pair-simple.html: Added.
* fast/js/regress/string-concat-simple-expected.txt: Added.
* fast/js/regress/string-concat-simple.html: Added.
* fast/js/regress/string-cons-repeat-expected.txt: Added.
* fast/js/regress/string-cons-repeat.html: Added.
* fast/js/regress/string-cons-tower-expected.txt: Added.
* fast/js/regress/string-cons-tower.html: Added.
* fast/js/script-tests/dfg-to-string-bad-toString.js: Added.
(String.prototype.toString):
(foo):
* fast/js/script-tests/dfg-to-string-bad-valueOf.js: Added.
(String.prototype.valueOf):
(foo):
* fast/js/script-tests/dfg-to-string-int-or-string.js: Added.
(foo):
* fast/js/script-tests/dfg-to-string-int.js: Added.
(foo):
* fast/js/script-tests/dfg-to-string-side-effect-clobbers-toString.js: Added.
(foo):
* fast/js/script-tests/dfg-to-string-side-effect.js: Added.
(foo):
* fast/js/script-tests/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.js: Added.
(foo):
(.String.prototype.toString):
* fast/js/script-tests/dfg-to-string-toString-becomes-bad.js: Added.
(foo):
(.String.prototype.toString):
* fast/js/script-tests/dfg-to-string-toString-in-string.js: Added.
(foo):
(.argument.toString):
* fast/js/script-tests/dfg-to-string-valueOf-becomes-bad.js: Added.
(foo):
(.String.prototype.valueOf):
* fast/js/script-tests/dfg-to-string-valueOf-in-string.js: Added.
(foo):
(.argument.valueOf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNetworkProcess should send vm_copied, mmap'ed memory to WebProcesses when a
beidson@apple.com [Mon, 18 Mar 2013 18:05:26 +0000 (18:05 +0000)]
NetworkProcess should send vm_copied, mmap'ed memory to WebProcesses when a
resource is already in the disk cache.
<rdar://problem/13414153> and https://bugs.webkit.org/show_bug.cgi?id=112387

Reviewed by Geoff Garen.

Source/WebCore:

No new tests (No change in behavior).

* WebCore.exp.in:

Add a CFURLRequestRef accessor even in the mac NSURL-based loader:
* platform/network/cf/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::cfURLRequest):

Source/WebKit2:

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::didReceiveResponse): After notifying about the response,
  call platformDidReceiveResponse.
* NetworkProcess/NetworkResourceLoader.h:

* NetworkProcess/mac/NetworkResourceLoaderMac.mm: Added.
(WebKit::NetworkResourceLoader::platformDidReceiveResponse): Attempt to pull a filesystem
  mmap'ed buffer from the CFNetwork cache and - if it exists - abort the traditional load
  and send that to the WebProcess instead.
(WebKit::NetworkResourceLoader:: fileBackedResourceMinimumSize): For now, use the VM page size.

* NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcess): Set the threshold for what
  should be backed by a file on disk instead of stored in the database.

Change SharedMemory to do a vm_copy if a previously existing buffer is being passed in:
* Platform/SharedMemory.h:
* Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::createWithVMCopy):

* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::shareableResourceDeallocate):
(WebKit::createShareableResourceDeallocator):
(WebKit::WebResourceLoader::didReceiveResource): Create a special CFDataRef whose buffer is
  backed by a ShareableResource to send to the ResourceLoader in one chunk.

* Shared/ShareableResource.h: Fix some comments.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOnly add wordspacing when kerning to actual word ends
dino@apple.com [Mon, 18 Mar 2013 18:01:05 +0000 (18:01 +0000)]
Only add wordspacing when kerning to actual word ends
https://bugs.webkit.org/show_bug.cgi?id=112507
<rdar://problem/12945869>

Reviewed by Enrica Casucci.

Source/WebCore:

When measuring text, we currently include any word spacing in
the result (it's removed later). When kerning is active, we
were adding the word spacing to every wordMeasurement instance
whether or not it is a separate word. For example, a nested
<span> element would get a wordMeasurement, even though it
should not always get word spacing.

Test: fast/text/word-space-with-kerning-3.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun): Test if the current character
referenced by the wordMeasurement is a space character, and add word
spacing only then.

LayoutTests:

* fast/text/word-space-with-kerning-3-expected.html: Added.
* fast/text/word-space-with-kerning-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Default background color of listboxes should be white
tony@chromium.org [Mon, 18 Mar 2013 17:57:49 +0000 (17:57 +0000)]
[chromium] Default background color of listboxes should be white
https://bugs.webkit.org/show_bug.cgi?id=112480

Reviewed by Ojan Vafai.

Source/WebCore:

I think it was an accident that list boxes got the grey background color as a
side effect of trying to get the button styling. In the default GTK+ theme on
Ubuntu, list boxes get a white background. Win and OS X also use white as the
default color.

No new tests, covered by existing pixel tests.

* css/themeChromiumLinux.css:
Narrow the CSS rule that overrides the background color specified in html.css.
We only want to use the button color when a select is using button styling.

LayoutTests:

Update pixel results with list boxes.

* platform/chromium-linux/fast/css/text-transform-select-expected.png:
* platform/chromium-linux/fast/css/text-transform-select-expected.txt:
* platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.png:
* platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.txt:
* platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
* platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt:
* platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
* platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-linux/fast/forms/hidden-listbox-expected.txt:
* platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
* platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt:
* platform/chromium-linux/fast/forms/listbox-clip-expected.png:
* platform/chromium-linux/fast/forms/listbox-clip-expected.txt:
* platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.png:
* platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.txt:
* platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.png:
* platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
* platform/chromium-linux/fast/forms/listbox-width-change-expected.png:
* platform/chromium-linux/fast/forms/listbox-width-change-expected.txt:
* platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
* platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
* platform/chromium-linux/fast/forms/select-block-background-expected.png:
* platform/chromium-linux/fast/forms/select-block-background-expected.txt:
* platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
* platform/chromium-linux/fast/forms/select-change-listbox-size-expected.txt:
* platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.png:
* platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.txt:
* platform/chromium-linux/fast/forms/select-initial-position-expected.png:
* platform/chromium-linux/fast/forms/select-initial-position-expected.txt:
* platform/chromium-linux/fast/forms/select-item-background-clip-expected.png:
* platform/chromium-linux/fast/forms/select-item-background-clip-expected.txt:
* platform/chromium-linux/fast/forms/select-list-box-with-height-expected.png:
* platform/chromium-linux/fast/forms/select-list-box-with-height-expected.txt:
* platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.png:
* platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt:
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt:
* platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png:
* platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt:
* platform/chromium-linux/fast/repaint/select-option-background-color-expected.png:
* platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt:
* platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
* platform/chromium-linux/fast/text/drawBidiText-expected.png:
* platform/chromium-linux/fast/text/drawBidiText-expected.txt:
* platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.png:
* platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.txt:
* platform/chromium-linux/fast/text/international/bidi-listbox-expected.png:
* platform/chromium-linux/fast/text/international/bidi-listbox-expected.txt:
* platform/chromium-linux/fast/text/updateNewFont-expected.png:
* platform/chromium-linux/fast/text/updateNewFont-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146079.
kbr@google.com [Mon, 18 Mar 2013 17:53:52 +0000 (17:53 +0000)]
Unreviewed, rolling out r146079.
http://trac.webkit.org/changeset/146079
https://bugs.webkit.org/show_bug.cgi?id=112594

many timeline tests failed. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] The <select> element on Android should also switch to new-flexbox
peter@chromium.org [Mon, 18 Mar 2013 17:49:52 +0000 (17:49 +0000)]
[Chromium] The <select> element on Android should also switch to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112559

Reviewed by Ojan Vafai.

Following r145959, also update themeChromiumAndroid.css to use the new
flexible box CSS properties. Covered by existing tests.

* css/themeChromiumAndroid.css:
(select[size][multiple]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Assertion faulire in SVGAnimatedPath.
reni@webkit.org [Mon, 18 Mar 2013 17:38:16 +0000 (17:38 +0000)]
Source/WebCore: Assertion faulire in SVGAnimatedPath.
https://bugs.webkit.org/show_bug.cgi?id=106428

Reviewed by Allan Sandfeld Jensen.

The asserts are too restricted. The size must be greater or equal to 1.

Test: svg/animations/animated-path-via-use-debug-crash.svg

* svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):

LayoutTests: Assertion faulire in SVGAnimatedPath
https://bugs.webkit.org/show_bug.cgi?id=106428

Reviewed by Allan Sandfeld Jensen.

* svg/animations/animated-path-via-use-debug-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Some tests intermittently asserts in SharedBuffer::releasePurgeableBuffer()
simon.fraser@apple.com [Mon, 18 Mar 2013 17:34:37 +0000 (17:34 +0000)]
[Mac] Some tests intermittently asserts in SharedBuffer::releasePurgeableBuffer()
https://bugs.webkit.org/show_bug.cgi?id=105986

Source/WebCore:

Reviewed by Brady Eidson.

A ResourceBuffer's SharedBuffer can be vended out to other clients,
for example Images, so there's no guarantee that when the
ResourceBuffer only has one ref its SharedBuffer will also have just one.
When this assumption was broken, SharedBuffer::releasePurgeableBuffer()
would assert.

Ideally SharedBuffer would be entirely encapsulated by ResourceBuffer to
avoid this problem, but ResourceBuffer can't be used by code in platform/.

Fix by having ResourceBuffer::createPurgeableBuffer() refuse to make
a purgeable buffer if the sharedBuffer has more than one ref.

Tested by existing tests.

* loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::createPurgeableBuffer):

LayoutTests:

Reviewed by Brady Eidson.

Remove expected Crashes for tests which should be fixed by this change.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable accessibility notifications after each test
simon.fraser@apple.com [Mon, 18 Mar 2013 17:28:55 +0000 (17:28 +0000)]
Disable accessibility notifications after each test
https://bugs.webkit.org/show_bug.cgi?id=112579

Reviewed by Tim Horton.

In WebKitTestRunner, if any tests triggered accessibility notifications,
the global notification handler would thereafter be active, and fire
notifications for all subsequent tests.

Fix by implementing AccessibilityController::resetToConsistentState() for
Mac, and using it to clear the global notification handler.

* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
(WTR::AccessibilityController::removeNotificationListener): Explicitly call
-stopObserving so that unregistering the observer doesn't rely on object lifetimes
(e.g. because of -autorelease).
(WTR::AccessibilityController::logAccessibilityEvents): Stub.
(WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
if there is one.
* WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
Add -stopObserving
* WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
(-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
(-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
center.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added new test expectations after r146072.
kbr@google.com [Mon, 18 Mar 2013 17:28:51 +0000 (17:28 +0000)]
Unreviewed. Added new test expectations after r146072.
https://bugs.webkit.org/show_bug.cgi?id=112562

* platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPan...
loislo@chromium.org [Mon, 18 Mar 2013 17:16:48 +0000 (17:16 +0000)]
Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid.
https://bugs.webkit.org/show_bug.cgi?id=112584

Reviewed by Pavel Feldman.

It is the first path in the set.
The end goal is to extract OverviewGrid with window selectors
into a separate class in separate file and reuse it in CPU FlameChart.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.prototype.get grid):
(WebInspector.OverviewGrid.prototype.get clientWidth):
(WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.updateDividers):
(WebInspector.OverviewGrid.prototype.addEventDividers):
(WebInspector.OverviewGrid.prototype.removeEventDividers):
(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.reset):
(WebInspector.OverviewGrid.prototype.get windowLeft):
(WebInspector.OverviewGrid.prototype.get windowRight):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
danakj@chromium.org [Mon, 18 Mar 2013 17:14:57 +0000 (17:14 +0000)]
[chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
https://bugs.webkit.org/show_bug.cgi?id=112392

Reviewed by James Robinson.

Removes the command line flag option from DRT.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate test expectations.
antonm@chromium.org [Mon, 18 Mar 2013 17:03:56 +0000 (17:03 +0000)]
Update test expectations.

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Fix code wrapping WKPageGroupRef
mikhail.pozdnyakov@intel.com [Mon, 18 Mar 2013 17:01:51 +0000 (17:01 +0000)]
[WK2][EFL] Fix code wrapping WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=112364

Reviewed by Alexey Proskuryakov.

The patch fixes following problems in EWK2 WKPageGroupRef wrapping
code: firstly it makes sure that there is only one EwkPageGroup
instance per WKPageGroup instance, secondly it allows web page to
to use the default page group (which is implicitly created inside
web context).

* UIProcess/API/C/efl/WKView.cpp:
(createWKView):

    Now may pass '0' page group as a WebView creation argument so
    that the default page group is used.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::createEvasObject):
* UIProcess/API/efl/EwkView.h:
(EwkView):

    Web view should be created before page group, so they are rearranged
    inside class declaration.

* UIProcess/API/efl/ewk_page_group.cpp:
(pageGroupMap):

    A map to track corresponding EwkPageGroup and WKPageGroup
    instances.

(EwkPageGroup::findOrCreateWrapper):

    Returns the same EwkPageGroup instance for the same WKPageGroup
    instance.

(EwkPageGroup::create):
(EwkPageGroup::EwkPageGroup):

    Now there is only one constructor accepting WKPageGroupRef.

(EwkPageGroup::~EwkPageGroup):
* UIProcess/API/efl/ewk_page_group_private.h:
(EwkPageGroup):
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Crash when accessing onclick attribute of document from XMLHttpRequest
abarth@webkit.org [Mon, 18 Mar 2013 16:56:58 +0000 (16:56 +0000)]
[V8] Crash when accessing onclick attribute of document from XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=112585

Reviewed by Eric Seidel.

Source/WebCore:

This ASSERT was bogus. The frame can be 0 for frameless documents, like
those created by XMLHttpRequest. When there is no frame, we act as if
JavaScript was disabled, which it is.

Test: fast/events/xhr-onclick-crash.html

* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

* fast/events/resources/onclick.html: Added.
* fast/events/xhr-onclick-crash-expected.txt: Added.
* fast/events/xhr-onclick-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Specifying polygonal -webkit-shape-inside value can crash browser...
hmuller@adobe.com [Mon, 18 Mar 2013 16:54:04 +0000 (16:54 +0000)]
[CSS Exclusions] Specifying polygonal -webkit-shape-inside value can crash browser (debug mode)
https://bugs.webkit.org/show_bug.cgi?id=112157

Reviewed by David Hyatt.

Source/WebCore:

Corrected the code which maps exclusion segments to pairs of InlineIterators. We now handle the
cases where the end of the line occurs within an exclusion segment or when it occurs before
the last exclusion segment has been reached. This can occur when a non-convex polygonal shape-inside
breaks a line up into two segments, but the shape-inside element's content only fills (or partially
fills) the first exclusion shape segment.

Tests: fast/exclusions/shape-inside/shape-inside-partial-fill-001.html
       fast/exclusions/shape-inside/shape-inside-partial-fill-002.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

Added tests with a polygonal shape-inside exclusion shape, where multiple shape
segments exist on one line, but the line's text either partially or completely
fills only the first exclusion shape segment.

* fast/exclusions/shape-inside/shape-inside-partial-fill-001-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-partial-fill-001.html: Added.
* fast/exclusions/shape-inside/shape-inside-partial-fill-002-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-partial-fill-002.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange RenderTableCell to use pixelSnappedSize when painting
eae@chromium.org [Mon, 18 Mar 2013 16:16:20 +0000 (16:16 +0000)]
Change RenderTableCell to use pixelSnappedSize when painting
https://bugs.webkit.org/show_bug.cgi?id=112562

Reviewed by Eric Seidel.

Source/WebCore:

Change the paining code in RenderTableCell to use the pixel snapped size
to ensure consistent rounding given that the location was rounded during
layout.

It is currently constructing a paint rect by taking the rounded location
and the precise size and then pixel snapping it. This causes the size to
be rounded incorrectly. By instead using the pixel snapped size the
rounding problem can be avoided.

Test: fast/sub-pixel/table-cell-background.html

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):

LayoutTests:

Add test for painting of cell backgrounds on a sub-pixel boundary.

* fast/sub-pixel/table-cell-background-expected.html: Added.
* fast/sub-pixel/table-cell-background.html: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoObjectPrototype properties should be eagerly created rather than lazily via static...
fpizlo@apple.com [Mon, 18 Mar 2013 16:16:05 +0000 (16:16 +0000)]
ObjectPrototype properties should be eagerly created rather than lazily via static tables
https://bugs.webkit.org/show_bug.cgi?id=112539

Reviewed by Oliver Hunt.

This is the first part of https://bugs.webkit.org/show_bug.cgi?id=112233. Rolling this
in first since it's the less-likely-to-be-broken part.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* interpreter/CallFrame.h:
(JSC::ExecState::objectConstructorTable):
* runtime/CommonIdentifiers.h:
* runtime/JSGlobalData.cpp:
(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunction):
(JSC):
* runtime/JSObject.h:
(JSObject):
(JSC):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/ObjectPrototype.cpp:
(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::create):
* runtime/ObjectPrototype.h:
(ObjectPrototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccess settings.defaultVideoPosterURL
commit-queue@webkit.org [Mon, 18 Mar 2013 16:13:33 +0000 (16:13 +0000)]
Access settings.defaultVideoPosterURL
https://bugs.webkit.org/show_bug.cgi?id=112378

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Dimitri Glazkov.

The defaultVideoPosterURL setting has been added in
https://bugs.webkit.org/show_bug.cgi?id=110263,
this added methods to access it in Chromium.
The settings will be used by Android WebView API
WebChromeClient.getDefaultVideoPoster()

* public/WebSettings.h: add setDefaultVideoPosterURL
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDefaultVideoPosterURL): set defaultVideoPosterURL
* src/WebSettingsImpl.h: add setDefaultVideoPosterURL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNeed to use const String in HTMLVideoElement::posterImageURL
commit-queue@webkit.org [Mon, 18 Mar 2013 16:12:00 +0000 (16:12 +0000)]
Need to use const String in HTMLVideoElement::posterImageURL
https://bugs.webkit.org/show_bug.cgi?id=112317

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Andreas Kling.

No behavioral changes.

This is the followup of https://bugs.webkit.org/show_bug.cgi?id=110263
Need to use String instead of const AtomicString& which means we will do an extra hash lookup

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::posterImageURL): Change to use String for url

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 18 Mar 2013 15:49:50 +0000 (15:49 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Remove
editing/pasteboard/paste-4035648-fix.html from the skipped list after
r144999.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] plugins/plugin-clip-subframe.html is failing
zandobersek@gmail.com [Mon, 18 Mar 2013 15:33:13 +0000 (15:33 +0000)]
[GTK] plugins/plugin-clip-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112570

Reviewed by Martin Robinson.

Tools:

* GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.

LayoutTests:

* platform/gtk-wk2/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.
* platform/gtk/TestExpectations: Removing the failure expectation.
* platform/gtk/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Settings] Register "?" shortcut.
eustas@chromium.org [Mon, 18 Mar 2013 15:11:12 +0000 (15:11 +0000)]
Web Inspector: [Settings] Register "?" shortcut.
https://bugs.webkit.org/show_bug.cgi?id=112545

Reviewed by Vsevolod Vlasov.

F1 and "?" (show shortcuts page) are not mentioned on shortcuts page.

* English.lproj/localizedStrings.js: Added string.
* inspector/front-end/inspector.js: Registered F1 / "?" shortcut.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
commit-queue@webkit.org [Mon, 18 Mar 2013 14:27:22 +0000 (14:27 +0000)]
Add USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
https://bugs.webkit.org/show_bug.cgi?id=112004

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Check if platform strategies is enabled before using it, falling
back to StorageNamespaceImpl if it isn't.

* storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::localStorageNamespace):
(WebCore::StorageNamespace::sessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: TabbedEditorContainer does not restore last shown file on reload somet...
vsevik@chromium.org [Mon, 18 Mar 2013 14:13:00 +0000 (14:13 +0000)]
Web Inspector: TabbedEditorContainer does not restore last shown file on reload sometimes.
https://bugs.webkit.org/show_bug.cgi?id=112561

Reviewed by Alexander Pavlov.

* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
commit-queue@webkit.org [Mon, 18 Mar 2013 13:43:48 +0000 (13:43 +0000)]
[BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
https://bugs.webkit.org/show_bug.cgi?id=112556

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

This changed in r145849 and broke the BlackBerry build.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Exports leveldb symbols
kov@webkit.org [Mon, 18 Mar 2013 13:19:50 +0000 (13:19 +0000)]
[GTK] Exports leveldb symbols
https://bugs.webkit.org/show_bug.cgi?id=112526

Reviewed by Carlos Garcia Campos.

* Source/autotools/symbols.filter: make leveldb symbols local.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Detach overlays from page when compositor is detached
anilsson@rim.com [Mon, 18 Mar 2013 13:05:16 +0000 (13:05 +0000)]
[BlackBerry] Detach overlays from page when compositor is detached
https://bugs.webkit.org/show_bug.cgi?id=112424

Reviewed by Rob Buis.

PR 309160

Source/WebCore:

Expose a method to retrieve a compositing thread layer's client.

No change in behavior, no new tests.

* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::client):

Source/WebKit/blackberry:

If not detached properly, the overlays would have a dangling pointer to
the page.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
* Api/WebOverlay_p.h:
(BlackBerry::WebKit::WebOverlayPrivate::setClient):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlay):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlayDestroyed):
(WebOverlayPrivateCompositingThread):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
* Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::detachOverlays):
(WebPageCompositorPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
eustas@chromium.org [Mon, 18 Mar 2013 12:52:47 +0000 (12:52 +0000)]
Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
https://bugs.webkit.org/show_bug.cgi?id=112402

Reviewed by Alexander Pavlov.

When user creates new items or renames existing one some existing item
may be overriden. If value is changed, then frontend will receive
notification and update record appropriately.

If item value hasn't been changed, then no notification comes.
But UI still expect / rely on this notification.

With this patch the "no notification" scenario is fixed:
duplicate items are removed.

Another scenario is when update notification comes when we started
editing value (after entering / renaming key). In this case
selected node should not be changed to leave user in editing mode.

* inspector/front-end/DOMStorageItemsView.js:
Added workarounds for "no notification" and "useless notification".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up RenderFrameSet::nodeAtPoint
allan.jensen@digia.com [Mon, 18 Mar 2013 11:59:18 +0000 (11:59 +0000)]
Clean up RenderFrameSet::nodeAtPoint
https://bugs.webkit.org/show_bug.cgi?id=112450

Reviewed by Eric Seidel.

Remove handling of resizing framesets from RenderFrameSet::nodeAtPoint.
The code has been incorrect since a mistake in r18333 (December 2006),
but has been dead code since r17770 (November 2006) where the then new
EventHandler started taking care of routing events to resizing FrameSets.

Since this was the only special feature of RenderFrameSet::nodeAtPoint,
the method has been removed.

* rendering/RenderFrameSet.cpp:
* rendering/RenderFrameSet.h:
(RenderFrameSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe 'formnovalidate' attribute doesn't work correctly on button elements with child...
commit-queue@webkit.org [Mon, 18 Mar 2013 11:48:57 +0000 (11:48 +0000)]
The 'formnovalidate' attribute doesn't work correctly on button elements with child elements
https://bugs.webkit.org/show_bug.cgi?id=112541

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-18
Reviewed by Kent Tamura.

Source/WebCore:

Fix a bug where formnovalidate attribute of <button> is not honored
if the target of the click event is an element nested within the button.

Test: fast/forms/interactive-validation-formnovalidate-child.html

* html/HTMLFormElement.cpp:
(WebCore::submitElementFromEvent): Looks for the nearest FormControlElement ancestor of the event target.

LayoutTests:

* fast/forms/interactive-validation-formnovalidate-child-expected.txt: Added.
* fast/forms/interactive-validation-formnovalidate-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL rebaseline after r146050.
gyuyoung.kim@samsung.com [Mon, 18 Mar 2013 11:36:51 +0000 (11:36 +0000)]
Unreviewed EFL rebaseline after r146050.

* platform/efl/fast/css/input-search-padding-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-input-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/control-restrict-line-height-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/placeholder-position-expected.txt:
* platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/efl/fast/forms/search-styled-expected.txt:
* platform/efl/fast/forms/search-vertical-alignment-expected.txt:
* platform/efl/fast/forms/searchfield-heights-expected.txt:
* platform/efl/fast/repaint/search-field-cancel-expected.txt:
* platform/efl/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd touch support to the calendar picker
keishi@webkit.org [Mon, 18 Mar 2013 11:02:27 +0000 (11:02 +0000)]
Add touch support to the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=112256

Reviewed by Kent Tamura.

Source/WebCore:

This patch increases the hit target sizes for touch and adds touch event
support to the scroll view, scroll bar and navigation button.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html
       platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html
       platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html

* Resources/pagepopups/calendarPicker.js:
(hasInaccuratePointingDevice):
(Animator): Super class for TransitionAnimator and FlingGestureAnimator.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame):
(TransitionAnimator): Same as the old Animator. Transition from one value to another.
(TransitionAnimator.prototype.setFrom):
(TransitionAnimator.prototype.start):
(TransitionAnimator.prototype.stop):
(TransitionAnimator.prototype.setTo):
(TransitionAnimator.prototype.onAnimationFrame):
(FlingGestureAnimator):Animates the fling scroll.
(FlingGestureAnimator.prototype._valueAtTime): Returns the value at the given time.
(FlingGestureAnimator.prototype._velocityAtTime): Returns the value change velocity at the given time.
(FlingGestureAnimator.prototype._timeAtVelocity): Returns the time when the value is changing at the given velocity.
(FlingGestureAnimator.prototype.start):
(FlingGestureAnimator.prototype.onAnimationFrame):
(ScrollView): Added support for touch gesture scrolling.
(ScrollView.prototype.onTouchStart):
(ScrollView.prototype.onWindowTouchMove):
(ScrollView.prototype.onWindowTouchEnd):
(ScrollView.prototype.onFlingGestureAnimatorStep):
(ScrollView.prototype.scrollTo):
(ScrubbyScrollBar): Added support for touch.
(ScrubbyScrollBar.prototype.onTouchStart):
(ScrubbyScrollBar.prototype.onWindowTouchMove):
(ScrubbyScrollBar.prototype.onWindowTouchEnd):
(ScrubbyScrollBar.prototype._setThumbPositionFromEventPosition): Accept MouseEvent or Touch.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(YearListCell):
(YearListView):
(YearListView.prototype.onTouchStart):
(YearListView.prototype._animateRow):
(CalendarNavigationButton): Add touch support for long press.
(CalendarNavigationButton.prototype.onTouchStart):
(CalendarNavigationButton.prototype.onWindowTouchEnd):
(CalendarNavigationButton.prototype.onMouseDown):
(CalendarNavigationButton.prototype.onWindowMouseUp):
(CalendarTableView): Disable touch gesture scrolling in the calendar table.

LayoutTests:

* platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html: Added.
* platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html: Added.
* platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(hoverOverMonthPopupButton):
(clickMonthPopupButton): Use hoverOverMonthPopupButton.
* platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
commit-queue@webkit.org [Mon, 18 Mar 2013 10:52:20 +0000 (10:52 +0000)]
[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
https://bugs.webkit.org/show_bug.cgi?id=112547

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Carlos Garcia Campos.

* WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::absoluteRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Cancel mark on search field is not displayed
gyuyoung.kim@samsung.com [Mon, 18 Mar 2013 10:13:19 +0000 (10:13 +0000)]
[EFL] Cancel mark on search field is not displayed
https://bugs.webkit.org/show_bug.cgi?id=94880

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

adjustSearchFieldCancelButtonStyle() doesn't set style width and height for search cancel button.
So, the button isn't showing up in search input field. Besides the button size should be scaled based
on the font size as chromium, qt, and blackberry ports.

Tests: fast/forms/search-cancel-button-style-sharing.html
       fast/forms/search-rtl.html

* platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):

LayoutTests:

Rebaseline expected results related to search cancel button.

* platform/efl-wk1/TestExpectations: These tests don't work with WK1 pixel test yet.
* platform/efl/TestExpectations:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/efl/fast/forms/search-rtl-expected.png:
* platform/efl/fast/forms/search-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Timeline affects the performace even if was switched...
yurys@chromium.org [Mon, 18 Mar 2013 09:40:23 +0000 (09:40 +0000)]
Web Inspector: Native Memory Timeline affects the performace even if was switched off.
https://bugs.webkit.org/show_bug.cgi?id=112428

Reviewed by Pavel Feldman.

Source/WebCore:

Whether to include DOM counters and native memory statistics is now
configured using Timeline.start parameters instead of sending separate
commands Timeline.setIncludeDomCounters and Timeline.setIncludeNativeMemoryStatistics.

* inspector/Inspector.json:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/DOMCountersGraph.js:
(WebInspector.DOMCountersGraph):
* inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryGraph):
* inspector/front-end/TimelineManager.js:
(WebInspector.TimelineManager.prototype.start):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.startRecord):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

LayoutTests:

* http/tests/inspector/timeline-test.js: chaned Timeline.start parameters
to match previous behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Exception in timeline DOMCounters
yurys@chromium.org [Mon, 18 Mar 2013 09:32:08 +0000 (09:32 +0000)]
Web Inspector: Exception in timeline DOMCounters
https://bugs.webkit.org/show_bug.cgi?id=112427

Reviewed by Pavel Feldman.

Do not update marker on DOM counters graph if the graphs haven't been
drawn yet.

* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediastream.ended should return true when all tracks were removed.
li.yin@intel.com [Mon, 18 Mar 2013 09:28:08 +0000 (09:28 +0000)]
Mediastream.ended should return true when all tracks were removed.
https://bugs.webkit.org/show_bug.cgi?id=112528

Reviewed by Kentaro Hara.

Source/WebCore:

Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-ended
When all tracks have been removed, it should return true as well as all the tracks
were ended.

Test: fast/mediastream/MediaStream-add-remove-tracks.html

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::removeTrack):

LayoutTests:

* fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
* fast/mediastream/MediaStream-add-remove-tracks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make number of stack frames to capture in Timeline a setting
caseq@chromium.org [Mon, 18 Mar 2013 09:21:59 +0000 (09:21 +0000)]
Web Inspector: make number of stack frames to capture in Timeline a setting
https://bugs.webkit.org/show_bug.cgi?id=110619

Reviewed by Pavel Feldman.

- factor out creation of input type="text" control for better reuse;
- add timelineLimitStackFramesFlag & timelineStackFramesToCapture settings;

* English.lproj/localizedStrings.js: add "Frames to capture" and "Limit number of captured JS stack frames"
* inspector/front-end/Settings.js: add 2 settings;
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js: UI for the setting;
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _createCSSAutoReloadControls.validateReloadTimeout):
* inspector/front-end/TimelineModel.js: pass the setting value to back-end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Mon, 18 Mar 2013 08:52:00 +0000 (08:52 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146035.
commit-queue@webkit.org [Mon, 18 Mar 2013 08:37:49 +0000 (08:37 +0000)]
Unreviewed, rolling out r146035.
http://trac.webkit.org/changeset/146035
https://bugs.webkit.org/show_bug.cgi?id=112540

fails to build on Windows: singned/unsigned mismatch at ln. 53
of html\HTMLSelectElementWin.cpp (Requested by antonm on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18

* WebCore.gypi:
* html/HTMLSelectElement.cpp:
(WebCore):
* html/HTMLSelectElementWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146033.
haraken@chromium.org [Mon, 18 Mar 2013 08:33:30 +0000 (08:33 +0000)]
Unreviewed, rolling out r146033.
http://trac.webkit.org/changeset/146033
https://bugs.webkit.org/show_bug.cgi?id=112521

web audio tests are broken

Source/WebCore:

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/AudioScheduledSourceNode.h:
* Modules/webaudio/ScriptProcessorNode.idl:

LayoutTests:

* webaudio/javascriptaudionode-expected.txt:
* webaudio/javascriptaudionode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate test expectations.
antonm@chromium.org [Mon, 18 Mar 2013 08:17:05 +0000 (08:17 +0000)]
Update test expectations.

Unreviewed gardening.

* platform/chromium-win/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoA placeholder renderer should not be taken to imply the existence of a text renderer...
dominicc@chromium.org [Mon, 18 Mar 2013 08:01:57 +0000 (08:01 +0000)]
A placeholder renderer should not be taken to imply the existence of a text renderer in single line text controls
https://bugs.webkit.org/show_bug.cgi?id=112410

Reviewed by Tony Chang.

Source/WebCore:

The assumption that if a text control had a placeholder renderer
then it also had a text renderer is not valid. If
::-webkit-textfield-decoration-controller is set to display: none;
a single line text control's decoration container renderer and
hence text renderer are not created. This change handles this
corner case where a text control has a placeholder renderer but
not a text renderer.

Tests: fast/forms/search/search-hide-decoration-container-crash.html (Updated)

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::fixPlaceholderRenderer):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):

LayoutTests:

Update search-hide-decoration-container-crash.html to exercise
non-null placeholder renderers and null text renderers.

Cases where neither are rendered already get coverage in
search-scroll-hidden-decoration-container-crash.html and
search-autoscroll-hidden-decoration-container-crash.html.

* fast/forms/search/search-hide-decoration-container-crash.html:
* fast/forms/search/search-hide-decoration-container-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow] offsetParent should never return nodes in user agent Shadow DOM to script
dominicc@chromium.org [Mon, 18 Mar 2013 07:55:30 +0000 (07:55 +0000)]
[Shadow] offsetParent should never return nodes in user agent Shadow DOM to script
https://bugs.webkit.org/show_bug.cgi?id=112530

Reviewed by Elliott Sprehn.

Source/WebCore:

Test: fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html

* dom/Element.cpp:
(WebCore::Element::bindingsOffsetParent): Filter nodes in UA shadows.
* dom/Element.h:
(Element): Add bindingsOffsetParent.
* dom/Element.idl: bindingsOffsetParent is the implementation of offsetParent.

LayoutTests:

* fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt: Added.
* fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport Windows HTMLSelectElement keystrokes on Chromium win
dmazzoni@google.com [Mon, 18 Mar 2013 06:25:47 +0000 (06:25 +0000)]
Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460

Reviewed by Kent Tamura.

Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).

* WebCore.gypi:
    Add html/HTMLSelectElementWin.cpp.
* html/HTMLSelectElement.cpp:
    Don't compile generic platformHandleKeydownEvent on
    Chromium win.
* html/HTMLSelectElementWin.cpp:
    Only compile platformHandleKeydownEvent on Windows.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark some more tests as flakey, or asserting in debug.
simon.fraser@apple.com [Mon, 18 Mar 2013 05:54:52 +0000 (05:54 +0000)]
Mark some more tests as flakey, or asserting in debug.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScriptProcessorNode is garbage collected while still active if unreachable
commit-queue@webkit.org [Mon, 18 Mar 2013 05:51:43 +0000 (05:51 +0000)]
ScriptProcessorNode is garbage collected while still active if unreachable
https://bugs.webkit.org/show_bug.cgi?id=112521

Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-17
Reviewed by Kentaro Hara.

Source/WebCore:

Fix for issue where ScriptProcessorNodes (and AudioNode js wrappers generally)
would be garbage collected before their time.  Made AudioNode an ActiveDOMElement
marked pending if there are any open audio connections.

Test: webaudio/javascriptaudionode.html

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::hasPendingActivity): it's pending (and thus not GCed)
if it has open audio connections.
* Modules/webaudio/AudioNode.h: AudioNode is now an ActiveDOMElement
* Modules/webaudio/AudioScheduledSourceNode.h: added a using declaration
to avoid function name hiding.
* Modules/webaudio/ScriptProcessorNode.idl: AudioNode is an ActiveDOMElement

LayoutTests:

* webaudio/javascriptaudionode-expected.txt:
* webaudio/javascriptaudionode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoINPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should...
commit-queue@webkit.org [Mon, 18 Mar 2013 05:26:10 +0000 (05:26 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=112527

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-17
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the minute, second, and millisecond field
respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable these fields when there is only single possible value.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
       fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Add fields for min/max of minute/second/millisecond.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set min/max for the fields.
(WebCore::DateTimeEditBuilder::visitField): Pass min/max parameters to the field constructors.
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled): Does not disable if minute, second, millisecond fields are all disabled, because we need at least one editable field.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled): Disables if min, max, and value are equal.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled): Ditto.
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled): Ditto.
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
* html/shadow/DateTimeFieldElements.h:
(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement): Add minimum/maximum parameters.
(DateTimeMinuteFieldElement): Add minimum/maximum parameters.
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement): Add minimum/maximum parameters.
(DateTimeWeekFieldElement):
(DateTimeYearFieldElement):
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue): Use hard-limit value instead of m_range.maximum, because millisecond field with max<100 will be displayed in two digits otherwise.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Changed to have hard limits as a data member.

LayoutTests:

* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove unused WebNode::hasEventListeners API
abarth@webkit.org [Mon, 18 Mar 2013 03:28:29 +0000 (03:28 +0000)]
[Chromium] Remove unused WebNode::hasEventListeners API
https://bugs.webkit.org/show_bug.cgi?id=112529

Reviewed by James Robinson.

This API no longer has any callers and can be removed.

* public/WebNode.h:
* src/WebNode.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEncapsulate PlatformMessagePortChannel a little better yet
ap@apple.com [Mon, 18 Mar 2013 02:21:26 +0000 (02:21 +0000)]
Encapsulate PlatformMessagePortChannel a little better yet
https://bugs.webkit.org/show_bug.cgi?id=112479

Reviewed by Sam Weinig.

* dom/MessagePortChannel.h: We no longer expose PlatformMessagePortChannel in
public functions in cross-platform code.

* dom/default/PlatformMessagePortChannel.cpp:
(WebCore::MessagePortChannel::createChannel): Tweaked the factory method to avoid
using the old create() function.
(WebCore::MessagePortChannel::~MessagePortChannel): Removed an unhelpful comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoINPUT_MULTIPLE_FIELDS_UI: Don't update shadow tree by updating any attribute
tkent@chromium.org [Mon, 18 Mar 2013 00:38:09 +0000 (00:38 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Don't update shadow tree by updating any attribute
https://bugs.webkit.org/show_bug.cgi?id=111990

Reviewed by Hajime Morrita.

Source/WebCore:

Bug detail:
Typing '1' then '1' into an hour field doesn't set the field to
'11' if an attribute is updated during these two keyboard inputs
because we always re-construct a shadow DOM tree by updating any
attributes and a shadow node records keyboard input state.

How to fix:
We should not re-construct a shadow DOM tree by updating
unaffected attributes. For example, we should re-construct it by
updating 'min' attribute, but we should not by updating 'class'
attribute.
We have InputType::updateInnerTextValue call in parseAttribute for
text field input types. The multiple fields input types
re-construct shadow DOM tree in updateInnerTextValue. The
updateInnerTextValue call is unnecessary for the multiple fields
input types, and we should call it when it is necessary. So, we
add InputType::attributeChange and text field input types call
updateInnerTextValue in it, and other input types don't.
Also, multiple fields input types need to call
updateInnerTextValue by 'value' attribute change. We add
InputType::valueAttributeChanged.

Tests: Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html. The
value attribute change behavior is covered by
time-multiple-fields-change-layout-by-value.html and
time-multiple-fields-spinbutton-change-and-input-events.html.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- Add a valueAttributeChanged call.
- Calls InputType::attributeChanged
* html/InputType.cpp:
(WebCore::InputType::attributeChanged): Added an empty implementation.
(WebCore::InputType::valueAttributeChanged): Ditto.
* html/InputType.h:
(InputType): Declare attributeChanged and valueAttributeChanged.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attributeChanged):
Added. Always call updateInnerTextValue.
* html/TextFieldInputType.h:
(TextFieldInputType): Declare attributeChanged.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::valueAttributeChanged):
Added. Re-construct shadow DOM tree if the input has no dirty value.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare valueAttributeChanged.

LayoutTests:

* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[HTMLTemplateElement] prevent </template> from matching "template" in a non-HTML...
rafaelw@chromium.org [Sun, 17 Mar 2013 23:58:31 +0000 (23:58 +0000)]
[HTMLTemplateElement] prevent </template> from matching "template" in a non-HTML tags on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=112487

Reviewed by Adam Barth.

Source/WebCore:

When processing an end template tag, the parser now pops until a "template" tag is parsed, but now ensures that
the "template" it pops is in the HTML namespace.

Tests added to the html5lib test suite.

* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::popUntil):
(WebCore):
(WebCore::HTMLElementStack::popUntilPopped):
* html/parser/HTMLElementStack.h:
(HTMLElementStack):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):

LayoutTests:

* html5lib/resources/template.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/frames/flattening/frameset-flattening-subframesets.html is flakey
simon.fraser@apple.com [Sun, 17 Mar 2013 23:06:12 +0000 (23:06 +0000)]
fast/frames/flattening/frameset-flattening-subframesets.html is flakey

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd tests for calendar picker month popup
keishi@webkit.org [Sun, 17 Mar 2013 21:40:38 +0000 (21:40 +0000)]
Add tests for calendar picker month popup
https://bugs.webkit.org/show_bug.cgi?id=112107

Adding tests to check if mouse and keyboard operations work on the month popup.

Reviewed by Kent Tamura.

* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
* platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
* platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(clickMonthPopupButton): Clicks the month popup button to open the month popup.
(clickYearListCell): Clicks the year list cell for the given year to reveal the month buttons.
(hoverOverMonthButton): Moves the mouse over to the month button for the given month.
(clickMonthButton): Clicks the month button for the given month.
(checkYearListViewScrollOffset): Checks the year list view scroll offset and returns the difference from the last time it was called.
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLegacy CSS vendor prefixes should only work for Dashboard
abarth@webkit.org [Sun, 17 Mar 2013 21:39:31 +0000 (21:39 +0000)]
Legacy CSS vendor prefixes should only work for Dashboard
https://bugs.webkit.org/show_bug.cgi?id=111890

Reviewed by Eric Seidel.

Source/WebCore:

Our experience with the Chromium port is that these legacy CSS vendor
prefixes (-apple- and -khtml-) are not needed for web compatibility.
There is reason to believe, however, that they are needed for
compatibility with Mac OS X Dashboard widgets.

This patch makes the code for these legacy CSS vendor prefixes
enabled at runtime and only enables them when running in Dashboard
compatibility mode. This is the first step towards the plan outlined in
https://lists.webkit.org/pipermail/webkit-dev/2013-March/024085.html.

This patch also removes support for ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
from the V8 bindings because V8 is never used with Dashboard.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
* css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiers):

Source/WebKit/mac:

Enable legacy CSS vendor prefixes when we've been asked to turn on
Dashboard compatibility mode.

* WebView/WebView.mm:
(-[WebView _setDashboardBehavior:to:]):

LayoutTests:

* inspector/styles/vendor-prefixes-expected.txt:
    - Update results to show our new behavior now that -apple- and
      -khtml- are not supported.
* platform/mac/TestExpectations:
    - Skip a test that is testing that we support -apple- prefixes.
* platform/mac/fast/css/dashboard-region-parser.html:
    - Update test to use -webkit- rather than -apple-.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/frames/sandboxed-iframe-navigation-allowed.html sometimes
simon.fraser@apple.com [Sun, 17 Mar 2013 20:54:09 +0000 (20:54 +0000)]
fast/frames/sandboxed-iframe-navigation-allowed.html sometimes
asserts in debug.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBUILD FIX (r145592): AutodrainedPool.h moved to WTF
ddkilzer@apple.com [Sun, 17 Mar 2013 20:09:09 +0000 (20:09 +0000)]
BUILD FIX (r145592): AutodrainedPool.h moved to WTF
<http://webkit.org/b/112171>

Fixes the following build failure:

    Source/WebCore/platform/audio/mac/AudioBusMac.mm:32:9: fatal error: 'AutodrainedPool.h' file not found
    #import "AutodrainedPool.h"
            ^
    1 error generated.

* platform/audio/mac/AudioBusMac.mm: Fix include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Sun, 17 Mar 2013 18:40:14 +0000 (18:40 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for the two reftests added in r145982, failing due to disabled subpixel layout.
Triaging/enhancing failure expectations for spellcheck tests after r145940.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd reload button (and F5 accelerator) to the GtkLauncher toolbar
commit-queue@webkit.org [Sun, 17 Mar 2013 18:11:49 +0000 (18:11 +0000)]
Add reload button (and F5 accelerator) to the GtkLauncher toolbar
https://bugs.webkit.org/show_bug.cgi?id=112442

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

* GtkLauncher/main.c:
(reloadCb):
(createToolbar):
(createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fix and improve dist hooks for translations
kov@webkit.org [Sun, 17 Mar 2013 18:10:25 +0000 (18:10 +0000)]
[GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519

Reviewed by Carlos Garcia Campos.

Source/WebCore:

* GNUmakefile.am: move translation-related rules and lists to the po directory's
GNUmakefile.am.

Source/WebCore/platform/gtk/po:

* GNUmakefile.am: move dist-related rules here; also move translation-related files
to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.

Source/WebKit/gtk:

* GNUmakefile.am: removed left-over translation files from EXTRA_DIST

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=97124
simon.fraser@apple.com [Sun, 17 Mar 2013 17:22:42 +0000 (17:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=97124
Mark a couple of WK2 tests as possibly asserting in debug.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove font-family applying code to StyleBuilder
eae@chromium.org [Sun, 17 Mar 2013 17:14:33 +0000 (17:14 +0000)]
Move font-family applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=112441

Reviewed by Allan Sandfeld Jensen.

Many of the font related properties were moved to StyleBuilder in r87362
two years ago. Move font-family as well so that all font properties are
handled the same way.

No new tests, no change in functionality.

* css/StyleBuilder.cpp:
(ApplyPropertyFontFamily):
(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontFamily::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Add ApplyPropertyFontFamily for CSSPropertyFontFamily.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Remove CSSPropertyFontFamily from the giant switch statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove the zoom filter operation ifdef
danakj@chromium.org [Sun, 17 Mar 2013 17:12:41 +0000 (17:12 +0000)]
[chromium] Remove the zoom filter operation ifdef
https://bugs.webkit.org/show_bug.cgi?id=112390

Reviewed by Darin Fisher.

This ifdef is not needed once the change that introduced it is
rolled into chromium, and the chromium side guards on the ifdef
are removed. Then it just does nothing and should be deleted.

* chromium/public/WebFilterOperation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146013 268f45cc-cd09-0410-ab3c-d52691b4dbfc