WebKit-https.git
11 years ago2009-02-28 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 1 Mar 2009 15:28:41 +0000 (15:28 +0000)]
2009-02-28 Gustavo Noronha Silva <gns@gnome.org>

        Reviewed by Holger Freyther.

        Add a GTK+-only option to enable GNOME Keyring when building.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 1 Mar 2009 06:21:22 +0000 (06:21 +0000)]
2009-02-28  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=24076

        Refactor gtk lib detection and put it in builtDylibPathForName

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 1 Mar 2009 05:28:31 +0000 (05:28 +0000)]
2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24261
        Fix V8 custom binding scrubbing error.

        Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
        Test: traversal/exception-forwarding.html
        TesT: traversal/stay-within-root.html

        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        * bindings/v8/custom/V8NodeIteratorCustom.cpp:
        (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
        * bindings/v8/custom/V8TreeWalkerCustom.cpp:
        (WebCore::toV8): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 1 Mar 2009 04:27:50 +0000 (04:27 +0000)]
2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24261
        Fix V8 custom binding scrubbing error.

        Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        (WebCore::cssPropertyName):  Remove dubious checks, left over from
            incomplete conversion of parameter from pointer to pass-by-ref.
        (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
        (WebCore::NAMED_PROPERTY_SETTER): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - correct a color profile mismatch in expected pixel results
mitz@apple.com [Sun, 1 Mar 2009 02:47:50 +0000 (02:47 +0000)]
    - correct a color profile mismatch in expected pixel results

        * platform/mac/fast/gradients/background-clipped-expected.checksum:
        * platform/mac/fast/gradients/background-clipped-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a ref to the ResourceHandle in startHttp so we can keep it
christian@webkit.org [Sat, 28 Feb 2009 20:29:50 +0000 (20:29 +0000)]
Add a ref to the ResourceHandle in startHttp so we can keep it
alive untill all callbacks have been executed, and unref it when
soup tells us it's done with the SoupMessage (in
finishedCallback). Fixes a number of crashes when calling
didReceiveData whould crash because of the handle dying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUse the new webkit_web_view_load_uri to open URIs.
christian@webkit.org [Sat, 28 Feb 2009 20:12:57 +0000 (20:12 +0000)]
Use the new webkit_web_view_load_uri to open URIs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a
christian@webkit.org [Sat, 28 Feb 2009 20:04:25 +0000 (20:04 +0000)]
* webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a
locale path is passed for compatibility, since we used to support that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>
kov@webkit.org [Sat, 28 Feb 2009 14:43:19 +0000 (14:43 +0000)]
2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24226
        [SOUP] HTTP status text is never set

        Set HTTP status text to SoupMessage reason_phrase.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - fix malformed project file
mitz@apple.com [Sat, 28 Feb 2009 10:01:20 +0000 (10:01 +0000)]
    - fix malformed project file

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 28 Feb 2009 09:44:45 +0000 (09:44 +0000)]
WebCore:

        Reviewed by Oliver Hunt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=23848
          <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de

        Test: fast/layers/inline-dirty-z-order-lists.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
        layer's and its stacking context's z-order lists when the layer's
        z-index or visibility change from here...
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
        it will apply to RenderInline too.

LayoutTests:

        Reviewed by Oliver Hunt.

        - test for https://bugs.webkit.org/show_bug.cgi?id=23848
          <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de

        * fast/layers/inline-dirty-z-order-lists.html: Added.
        * platform/mac/fast/layers/inline-dirty-z-order-lists-expected.checksum: Added.
        * platform/mac/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
        * platform/mac/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Sat, 28 Feb 2009 08:45:43 +0000 (08:45 +0000)]
2009-02-27  Alice Liu  <alice.liu@apple.com>

        Fix <rdar://problem/6531265> REGRESSION (r39185): adding ".jpeg"
        extension to images that already have .jpg extension

        Reviewed by Oliver Hunt.

        * WebView/WebHTMLView.mm:
        (-[NSString matchesExtensionEquivalent:]):
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        Relax the check for the proper extension to allow for known
        equivalents, special-cased in matchesExtensionEquivalent function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Hyatt.
ap@webkit.org [Sat, 28 Feb 2009 08:06:32 +0000 (08:06 +0000)]
    Reviewed by David Hyatt.

        Don't include TextResourceDecoder.h in Document.h

        This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
        when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sat, 28 Feb 2009 03:44:42 +0000 (03:44 +0000)]
2009-02-27  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed build fix. Adding the WebKit/gtk/webkitmarshal.list
        file to EXTRA_DIST to fix make dist.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sat, 28 Feb 2009 02:21:11 +0000 (02:21 +0000)]
2009-02-27  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by David Hyatt.

        Automatically ignore empty requests to avoid crashing. This fixes
        the crash in fast/loader/empty-embed-src-attribute.html.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
levin@chromium.org [Sat, 28 Feb 2009 01:28:46 +0000 (01:28 +0000)]
WebCore:

2009-02-27  Matt Pennig  <pennig@apple.com>

        Reviewed by David Hyatt.

        Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
        "Fixed elements have 0 as an offsetLeft property"

        Code also brings offsetLeft/Top in full conformance with the spec.
        Added two tests, one for fixed-position elements, and one for <html>.

        Tests: fast/dom/Element/fixed-position-offset-parent.html
               fast/dom/Element/offsetLeft-offsetTop-html.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::offsetLeft):
        (WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

2009-02-27  Matt Pennig  <pennig@apple.com>

        Reviewed by David Hyatt.

        Added two tests:
            1. Tests offsetParent, offsetLeft and offsetTop on fixed-position elements.
            2. Tests offsetLeft and offsetTop on static and positioned <html> elements.

        * fast/dom/Element/fixed-position-offset-parent-expected.txt: Added.
        * fast/dom/Element/fixed-position-offset-parent.html: Added.
        * fast/dom/Element/offsetLeft-offsetTop-html-expected.txt: Added.
        * fast/dom/Element/offsetLeft-offsetTop-html.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Dean Jackson <dino@apple.com>
dino@apple.com [Sat, 28 Feb 2009 01:13:07 +0000 (01:13 +0000)]
2009-02-27  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser

        Pixel tests for previous commit
        https://bugs.webkit.org/show_bug.cgi?id=24252

        * platform/mac/transforms/no_transform_hit_testing-expected.checksum: Added.
        * platform/mac/transforms/no_transform_hit_testing-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoForgot -expected file from last commit :(
dino@apple.com [Sat, 28 Feb 2009 01:07:31 +0000 (01:07 +0000)]
Forgot -expected file from last commit :(

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Dean Jackson <dino@apple.com>
dino@apple.com [Sat, 28 Feb 2009 01:05:54 +0000 (01:05 +0000)]
2009-02-27  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        renderer()->hasTransform() returns true for elements
        with perspective, but no transform, so test for transform
        when hit testing. This fixes ASSERT from
        https://bugs.webkit.org/show_bug.cgi?id=24252

        Test: transforms/no_transform_hit_testing.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 28 Feb 2009 00:01:19 +0000 (00:01 +0000)]
2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        Fix scrubbing error -- a reversed condition.

        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Jian Li <jianli@chromium.org>
levin@chromium.org [Fri, 27 Feb 2009 23:29:30 +0000 (23:29 +0000)]
2009-02-27  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add confirmMessageFromWorkerObject to WorkerObjectProxy.
        https://bugs.webkit.org/show_bug.cgi?id=24152

        * workers/WorkerMessagingProxy.cpp:
        (WebCore::MessageWorkerContextTask::performTask):
        (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
        * workers/WorkerMessagingProxy.h:
        * workers/WorkerObjectProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 Feb 2009 22:46:25 +0000 (22:46 +0000)]
2009-02-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
        because it leads to assertion failures in the Mac port.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::mayFillWithSolidColor):
        * platform/graphics/Image.h:
        (WebCore::Image::mayFillWithSolidColor):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 Feb 2009 22:37:22 +0000 (22:37 +0000)]
2009-02-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        <rdar://problem/6631436>
        CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::addValueToArray + 55

        Port the NPN_Evaluate code over from WebCore instead of using the frame loader.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove mysterious @ sign to fix Windows build.
abarth@webkit.org [Fri, 27 Feb 2009 22:24:40 +0000 (22:24 +0000)]
Remove mysterious @ sign to fix Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt to fix Windows build.
abarth@webkit.org [Fri, 27 Feb 2009 22:15:53 +0000 (22:15 +0000)]
Attempt to fix Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 Feb 2009 21:58:34 +0000 (21:58 +0000)]
2009-02-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        WebKit side of <rdar://problem/6626814>.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvokeDefault):
        Make InvokeDefault async.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::addValueToArray):
        Handle passing NPObjects back to the plug-in host.

        * Plugins/Hosted/ProxyInstance.h:
        (WebKit::ProxyInstance::objectID):
        Add objectID getter.

        * Plugins/Hosted/WebKitPluginClient.defs:
        Make InvokeDefault a simpleroutine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixes an exception by null checking the WebResource before adding it to
timothy@apple.com [Fri, 27 Feb 2009 21:53:33 +0000 (21:53 +0000)]
    Fixes an exception by null checking the WebResource before adding it to
        the subresources array.

        <rdar://problem/5950769> Bug in [WebDataSource subresources] can throw an exception

        Reviewed by Geoff Garen and Anders Carlsson.

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresources]): Null check the WebResource before adding it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Adds a workaround for Automator creating a WebView from a secondary thread.
timothy@apple.com [Fri, 27 Feb 2009 21:01:02 +0000 (21:01 +0000)]
    Adds a workaround for Automator creating a WebView from a secondary thread.

        <rdar://problem/6631951> REGRESSION (Safari 4 Beta): Automator crash on
        secondary thread beneath -[WebView initWithFrame:frameName:groupName:]

        Reviewed by Geoff Garen.

        * WebView/WebView.mm:
        (needsWebViewInitThreadWorkaround): Check for com.apple.Automator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
abarth@webkit.org [Fri, 27 Feb 2009 20:52:55 +0000 (20:52 +0000)]
WebCore:

2009-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20249

        Add a preference to allow universal access from local URLs to mitigate
        some attacks.  Some clients still want to allow this access, so we
        expose this as a preference.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
        * page/Settings.h:
        (WebCore::Settings::allowUniversalAccessFromFileUrls):

WebKit/mac:

2009-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a preference to reduce the power of file:// URLs.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences allowUniversalAccessFromFileUrls]):
        (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a preference to reduce the power of file:// URLs.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::allowUniversalAccessFromFileUrls):
        (WebPreferences::setAllowUniversalAccessFromFileUrls):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 27 Feb 2009 20:47:04 +0000 (20:47 +0000)]
2009-02-27  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24229
        If an image has no alpha channel there is no reason to use SourceOver.

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 27 Feb 2009 20:42:51 +0000 (20:42 +0000)]
2009-02-27  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Eric Seidel and Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24227
        Ensure that the checkForSolidColor() optimization is correctly triggered
        for all cases of drawPattern.  Currently, the optimization was not triggered
        when the check had not been previously performed via a request for the
        image's NativeImagePtr.

        Implement the Qt version of the checkForSolidColor() method.  Combined with
        the bug fix this reduces the time it takes to draw a repeating background
        of a 1x1 image from ~50msecs to ~0msecs on my machine.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::mayFillWithSolidColor):
        * platform/graphics/Image.h:
        (WebCore::Image::mayFillWithSolidColor):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 27 Feb 2009 20:35:04 +0000 (20:35 +0000)]
2009-02-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Zack Rusin.

        Added support for gradients and pattern on Fonts for Qt.

        [Qt] gradients and patterns for FontQt
        https://bugs.webkit.org/show_bug.cgi?id=24243

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::drawComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 27 Feb 2009 20:02:43 +0000 (20:02 +0000)]
2009-02-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        https://bugs.webkit.org/show_bug.cgi?id=24242

        setCursor(), and resetCursorRects() on Tiger, were using global, not local
        coordinates for elementAtPoint:

        * WebView/WebHTMLView.mm:
        (resetCursorRects):
        (setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 27 Feb 2009 19:50:14 +0000 (19:50 +0000)]
2009-02-27  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24213: Web Worker: Worker4 test: onmessage will never be called
        <https://bugs.webkit.org/show_bug.cgi?id=24213>

        * fast/workers/worker-terminate-expected.txt:
        * fast/workers/worker-terminate.html:
        Added a log entry to the onmessage handler for worker4 to make it visible that
        the handler was called and removed the terminate call that happened outside of onmessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Jian Li <jianli@chromium.org>
levin@chromium.org [Fri, 27 Feb 2009 19:50:03 +0000 (19:50 +0000)]
2009-02-27  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
        https://bugs.webkit.org/show_bug.cgi?id=24113

        * workers/WorkerMessagingProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCommit a missing file.
timothy@apple.com [Fri, 27 Feb 2009 19:29:24 +0000 (19:29 +0000)]
Commit a missing file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added a refresh button to storage views.
timothy@apple.com [Fri, 27 Feb 2009 18:56:06 +0000 (18:56 +0000)]
    Added a refresh button to storage views.

        https://bugs.webkit.org/show_bug.cgi?id=24040

        Reviewed by Timothy Hatcher.

        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView):
        (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
        (WebInspector.DOMStorageItemsView.prototype.update):
        (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
        * inspector/front-end/DatabaseTableView.js:
        (WebInspector.DatabaseTableView):
        (WebInspector.DatabaseTableView.prototype.get statusBarItems):
        (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel):
        (WebInspector.DatabasesPanel.prototype.get statusBarItems):
        (WebInspector.DatabasesPanel.prototype.reset):
        (WebInspector.DatabasesPanel.prototype.showDatabase):
        (WebInspector.DatabasesPanel.prototype.showDOMStorage):
        (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added support for editing/deleting localStorage and sessionStorage items
timothy@apple.com [Fri, 27 Feb 2009 18:28:37 +0000 (18:28 +0000)]
    Added support for editing/deleting localStorage and sessionStorage items
        directly from Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=23866.

        Reviewed by Timothy Hatcher.

        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/DOMStorageDataGrid.js: Added.
        (WebInspector.DOMStorageDataGrid):
        (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
        (WebInspector.DOMStorageDataGrid.prototype._startEditing):
        (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
        (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
        (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView):
        (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
        (WebInspector.DOMStorageItemsView.prototype.hide):
        (WebInspector.DOMStorageItemsView.prototype.update):
        (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel):
        (WebInspector.DatabasesPanel.prototype.get statusBarItems):
        (WebInspector.DatabasesPanel.prototype.reset):
        (WebInspector.DatabasesPanel.prototype.showDOMStorage):
        (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
        (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Windows transparency for the Chromium port. Implement a helper
brettw@chromium.org [Fri, 27 Feb 2009 17:42:21 +0000 (17:42 +0000)]
Fix Windows transparency for the Chromium port. Implement a helper
class for handling transparency on Windows. It allows semitransparent
ClearType and semitransparent form controls by making new layers in the
background.

It also replaces the "ThemeHelper" which allows better
scaling and transforms on Windows form controls. In addition to the
functionality that the ThemeHelper did, but additionally handles the
antialiasing properly so that the form controls aren't composited on a
white square.

https://bugs.webkit.org/show_bug.cgi?id=24101

Reviewed by Eric Seidel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 27 Feb 2009 16:23:38 +0000 (16:23 +0000)]
2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24211
        Add ScheduledAction for V8.

        * bindings/v8/ScheduledAction.cpp: Added.
        (WebCore::ScheduledAction::ScheduledAction):
        (WebCore::ScheduledAction::~ScheduledAction):
        (WebCore::ScheduledAction::execute):
        * bindings/v8/ScheduledAction.h: Added.
        (WebCore::ScheduledAction::ScheduledAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Zack Rusin <zack@kde.org>
treat@webkit.org [Fri, 27 Feb 2009 14:59:26 +0000 (14:59 +0000)]
2009-02-27  Zack Rusin  <zack@kde.org>

        Reviewed by Nikolas Zimmermann.

        Qt: be more reasonable about scrolled lines

        cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
        match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
        irritating. so lets scroll vertically by the Qt set number of lines * Qt default
        single step scroll

        * platform/qt/WheelEventQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Xan Lopez <xan@gnome.org>
jmalonzo@webkit.org [Fri, 27 Feb 2009 11:30:07 +0000 (11:30 +0000)]
2009-02-27  Xan Lopez  <xan@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24221
        [GTK] Do not emit load-finished when being disposed

        webkit_web_view_stop_load() is called from dispose() on
        WebKitWebView. This eventually calls postProgressFinishedNotification
        in FrameLoaderClientGtk, which emits load-finished. Add
        a 'disposing' flag to WebView that we can check here, so
        we avoid emitting signals on objects on their way to be
        destroyed.  This fixes a bunch of critical warnings when
        closing a loading WebView.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::postProgressFinishedNotification):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-27 Xan Lopez <xan@gnome.org>
jmalonzo@webkit.org [Fri, 27 Feb 2009 11:18:21 +0000 (11:18 +0000)]
2009-02-27  Xan Lopez  <xan@gnome.org>

        Rubber-stamped by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24222
        [GTK] Remove checks for old glib versions

        libsoup, which is a hard dependency, needs at least glib 2.15.3,
        so remove all glib checks for versions older than that.

        * platform/gtk/ContextMenuGtk.cpp:
        (WebCore::ContextMenu::ContextMenu):
        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::ContextMenuItem::setSubMenu):
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::show):
        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::retainPlatformWidget):
        * platform/network/soup/ResourceHandleSoup.cpp:

WebKit/gtk:

2009-02-27  Xan Lopez  <xan@gnome.org>

        Rubber-stamped by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24222
        [GTK] Remove checks for old glib versions

        libsoup, which is a hard dependency, needs at least glib 2.15.3,
        so remove all glib checks for versions older than that.

        * webkit/webkitwebview.cpp:

WebKitTools:

2009-02-27  Xan Lopez  <xan@gnome.org>

        Rubber-stamped by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24222
        [GTK] Remove checks for old glib versions

        libsoup, which is a hard dependency, needs at least glib 2.15.3,
        so remove all glib checks for versions older than that.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setWaitToDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 27 Feb 2009 08:20:15 +0000 (08:20 +0000)]
2009-02-26  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        Added support for Gradients and Patterns on filled or stroked Fonts
        in Cairo. I also added support for globalAlpha on FontCairo.

        [CAIRO] SVG/Canvas fonts miss gradients/pattern support
        https://bugs.webkit.org/show_bug.cgi?id=18617

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 27 Feb 2009 04:00:58 +0000 (04:00 +0000)]
2009-02-26  Adele Peterson  <adele@apple.com>

        Reviewed by Alice Liu.

        Make the success/failure of this test more obvious.

        * editing/selection/designmode-no-caret.html:
        * platform/mac/editing/selection/designmode-no-caret-expected.checksum:
        * platform/mac/editing/selection/designmode-no-caret-expected.png:
        * platform/mac/editing/selection/designmode-no-caret-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Fri, 27 Feb 2009 03:32:17 +0000 (03:32 +0000)]
JavaScriptCore:

2009-02-26  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Fix bug #23614.  Switches on double precision values were incorrectly
        truncating the scrutinee value.  E.g.:

            switch (1.1) { case 1: print("FAIL"); }

        Was resulting in FAIL.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_op_switch_imm):

LayoutTests:

2009-02-26  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Geoff Garen.

        Layout test for bug #23614.

        * fast/js/resources/switch-behaviour.js:
        * fast/js/switch-behaviour-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/mac:
adele@apple.com [Fri, 27 Feb 2009 01:15:38 +0000 (01:15 +0000)]
WebKit/mac:

2009-02-26  Adele Peterson  <adele@apple.com>

        Reviewed by Geoff Garen.

        Fix for <rdar://problem/6618166>
        https://bugs.webkit.org/show_bug.cgi?id=24216
        (REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

        During a series of firstResponder changes, at some point while the WebHTMLView was losing first responder status,
        we incorrectly marked the page as active, and then when the WebHTMLView became first responder again, setActive did nothing.
        This change restores behavior from before r36919 to check if the WebHTMLView is in the middle of losing first responder when calling setActive.

        In addition to updating editing/selection/designmode-no-caret.html results, I also made sure the test cases that were
        fixed in r36919 and r38570 are still fixed.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView resignFirstResponder]): Keep track if we're in the process of resigning first responder.
        (-[WebHTMLView _isResigningFirstResponder]): Added.
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]): Don't set the page to be active
        if the document view is currently resigning first responder.

LayoutTests:

2009-02-26  Adele Peterson  <adele@apple.com>

        Reviewed by Geoff Garen.

        Updating results for <rdar://problem/6618166>
        https://bugs.webkit.org/show_bug.cgi?id=24216
        (REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

        We changed these results shortly after r36919, but the original result is actually correct.
        The test's text indicates that we expect a caret to be placed in this case.

        * platform/mac/editing/selection/designmode-no-caret-expected.checksum:
        * platform/mac/editing/selection/designmode-no-caret-expected.png:
        * platform/mac/editing/selection/designmode-no-caret-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 27 Feb 2009 01:09:43 +0000 (01:09 +0000)]
2009-02-26  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Integer Immediate representation need not be canonical in x86 JIT code.
        On x86-64 we already have loosened the requirement that the int immediate
        representation in canonical, we should bring x86 into line.

        This patch is a minor (~0.5%) improvement on sunspider & v8-tests, and
        should reduce memory footoprint (reduces JIT code size).

        * jit/JIT.cpp:
        (JSC::JIT::compileOpStrictEq):
        (JSC::JIT::privateCompileSlowCases):
        * jit/JIT.h:
        (JSC::JIT::emitJumpIfImmediateNumber):
        (JSC::JIT::emitJumpIfNotImmediateNumber):
        * jit/JITArithmetic.cpp:
        (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
        (JSC::JIT::compileBinaryArithOp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Stephen White <senorblanco@chromium.org>
darin@chromium.org [Fri, 27 Feb 2009 00:20:01 +0000 (00:20 +0000)]
2009-02-26  Stephen White  <senorblanco@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23957

        Fix for SVG gradient and pattern text for Chromium/skia.
        Added accessors for the fill and stroke gradients to
        GraphicsContext.  Changed the paintSkiaText function to take a
        GraphicsContext, so we can check for gradients/patterns.
        Changed the skiaDrawText function to set the SkPaint shader
        correctly, and to scale up the gradient shader matrix to
        encompass the entire text string.  Also offset each glyph
        separately, rather than transforming the canvas, so that the
        gradient/pattern stays fixed relative to the text origin.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::getFillGradient):
        (WebCore::GraphicsContext::getStrokeGradient):
        (WebCore::GraphicsContext::getFillPattern):
        (WebCore::GraphicsContext::getStrokePattern):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/UniscribeHelper.cpp:
        (WebCore::UniscribeHelper::draw):
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleTextDrawing):
        (WebCore::skiaDrawText):
        (WebCore::paintSkiaText):
        * platform/graphics/skia/SkiaFontWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix ChangeLog entry
dglazkov@chromium.org [Thu, 26 Feb 2009 23:29:17 +0000 (23:29 +0000)]
Fix ChangeLog entry

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 26 Feb 2009 23:27:20 +0000 (23:27 +0000)]
2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        http://codereview.chromium.org/27217
        Add custom V8 bindings for Navigator, Clipboard, Document, and Node.

        * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8DocumentCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        * bindings/v8/custom/V8NodeCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 26 Feb 2009 23:00:47 +0000 (23:00 +0000)]
2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed build fix for building with GNOME Keyring enabled.

        * platform/network/soup/webkit-soup-auth-dialog.c:
        (show_auth_dialog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Xan Lopez <xan@gnome.org>
kov@webkit.org [Thu, 26 Feb 2009 22:45:13 +0000 (22:45 +0000)]
2009-02-26  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=16947
        [GTK] Missing HTTP Auth challenge

        Add HTTP authentication dialog with optional GNOME Keyring
        storage.

        * GNUmakefile.am:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::currentToplevelCallback):
        (WebCore::ResourceHandle::startHttp):
        (WebCore::ResourceHandle::start):
        * platform/network/soup/webkit-soup-auth-dialog.c: Added.
        (webkit_soup_auth_dialog_class_init):
        (webkit_soup_auth_dialog_init):
        (webkit_soup_auth_dialog_session_feature_init):
        (free_authData):
        (set_password_callback):
        (response_callback):
        (show_auth_dialog):
        (find_password_callback):
        (session_authenticate):
        (attach):
        * platform/network/soup/webkit-soup-auth-dialog.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 26 Feb 2009 21:11:50 +0000 (21:11 +0000)]
2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>

        Reviewed by Dave Hyatt.

        After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
        svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
        started failing because Ojan's new code was now *correctly* calling through to
        SVG asking for the closest text offset in the last line box, instead of
        just returning the offset at the end of the last line box when clicking below a box.

        But!  The SVG code was wrong, in that it returned the character offset of the last
        character when you asked for a character offset after the end of the box, instead
        it should return the offset *after* the last character.  This patch fixes
        that behavior by reordering the last two clauses in svgCharacterHitsPosition.

        The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
        to document what's wrong.  I've also cleaned up the code a bit so it's clearer
        what it is doing (which also makes more obvious what's wrong with it).

        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::positionForCoordinates):
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
        (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
        (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
        (WebCore::SVGInlineTextBox::closestCharacterToPosition):
        (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 26 Feb 2009 20:40:00 +0000 (20:40 +0000)]
2009-02-26  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        Minor cleanup of ChromiumBridge:
        Removing unused matchesMIMEType method and s/Javascript/JavaScript/

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/MimeTypeRegistryChromium.cpp:
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 26 Feb 2009 20:36:47 +0000 (20:36 +0000)]
WebCore:

2009-02-26  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig

        Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
        the line-height below the descent.

        Added fast/inline/vertical-align-text-bottom.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::verticalPosition):

LayoutTests:

2009-02-26  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig

        Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
        the line-height below the descent.

        * fast/inline/vertical-align-text-bottom.html: Added.
        * platform/mac/fast/inline/vertical-align-text-bottom-expected.checksum: Added.
        * platform/mac/fast/inline/vertical-align-text-bottom-expected.png: Added.
        * platform/mac/fast/inline/vertical-align-text-bottom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 26 Feb 2009 20:11:32 +0000 (20:11 +0000)]
2009-02-26  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
        ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
        just to implement this three methods to support SVG Masking now.

        Make SVG Masking platform aware
        https://bugs.webkit.org/show_bug.cgi?id=19243

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * svg/graphics/SVGResourceMasker.cpp:
        (WebCore::SVGResourceMasker::applyMask):
        * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
        * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
        * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
        * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
        * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.

        LayoutTests:
        Corrected some tests after the new SVG Masking implementation for Mac.

        Make SVG Masking platform aware
        https://bugs.webkit.org/show_bug.cgi?id=19243

        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
        * svg/custom/mask-excessive-malloc.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Thu, 26 Feb 2009 20:09:50 +0000 (20:09 +0000)]
2009-02-26  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.

        Test: http/tests/misc/slow-preload-cancel.html

        https://bugs.webkit.org/show_bug.cgi?id=24133
        Clear all pending preloads in the DocLoader object when we decide to
        cancel its all requests.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::clearPendingPreloads):
        * loader/DocLoader.h:
        * loader/loader.cpp:
        (WebCore::Loader::cancelRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 26 Feb 2009 20:07:39 +0000 (20:07 +0000)]
2009-02-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Fix <rdar://problem/6623697>.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::print):
        Ask the plug-in host to print, create a CGImage of the returned bytes and draw
        the image into the passed in context.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView drawRect:]):
        When printing, call NetscapePluginInstanceProxy::print.

        * Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 26 Feb 2009 19:43:12 +0000 (19:43 +0000)]
2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24182
        Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.

        * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
        (WebCore::toV8):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
        (WebCore::toV8):
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 26 Feb 2009 19:40:36 +0000 (19:40 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23500
        KURL::parse() incorrectly compares its result to original string

        * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Ojan Vafai <ojan@chromium.org>
dglazkov@chromium.org [Thu, 26 Feb 2009 19:35:41 +0000 (19:35 +0000)]
2009-02-26  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Kevin McCullough.

        Manual test for inspector node highlighting.

        * manual-tests/inspector/highlight-nodes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-16 Anantanarayanan Iyengar <ananta@chromium.org>
darin@chromium.org [Thu, 26 Feb 2009 19:32:49 +0000 (19:32 +0000)]
2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=23973
        ScrollView::scrollContents can be invoked during view shutdown.  In
        this scenario the FrameView::hostWindow method can return NULL, which
        indicates that the frame/page is being destroyed. This causes a crash
        when we try to dereference a NULL hostWindow pointer.  Fix is to add a
        NULL check for this.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Thu, 26 Feb 2009 19:11:12 +0000 (19:11 +0000)]
WebCore:

2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24003
        Fix a crash caused by unsafe type conversion.

        Test: fast/block/positioning/absolute-in-inline-rtl-4.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):

LayoutTests:

2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24003
        Fix a crash caused by unsafe type conversion.

        * fast/block/positioning/absolute-in-inline-rtl-4-expected.txt: Added.
        * fast/block/positioning/absolute-in-inline-rtl-4.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Ojan Vafai <ojan@chromium.org>
dglazkov@chromium.org [Thu, 26 Feb 2009 18:59:13 +0000 (18:59 +0000)]
2009-02-26  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=24202
        Have drawNodeHighlight clip instead of clearing. This makes it work for
        both Safari and Chromium since Chromium draws the inspector highlighting
        in the same buffer as the page.

        * inspector/InspectorController.cpp:
        (WebCore::quadToPath):
        (WebCore::drawOutlinedQuad):
        (WebCore::drawOutlinedQuadWithClip):
        (WebCore::drawHighlightForBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 26 Feb 2009 18:45:25 +0000 (18:45 +0000)]
WebCore:

2009-02-26  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein & Darin Adler

        Make sure the border/padding are properly omitted at the start of an inline that is a continuation.

        Added fast/inline/inline-continuation-borders.html

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):

LayoutTests:

2009-02-26  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein & Darin Adler

        Make sure the border/padding are properly omitted at the start of an inline that is a continuation.

        * fast/inline/inline-continuation-borders.html: Added.
        * platform/mac/fast/inline/inline-continuation-borders-expected.checksum: Added.
        * platform/mac/fast/inline/inline-continuation-borders-expected.png: Added.
        * platform/mac/fast/inline/inline-continuation-borders-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 26 Feb 2009 18:30:49 +0000 (18:30 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24024
        REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
        archiving a submission to about:blank

        I don't know how to make an automated test for this bug.

        * History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
        * WebHistory.cpp: (WebHistory::visitedURL):
        Account for the fact that HTTP method may be non-empty for non-HTTP requests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 26 Feb 2009 18:21:47 +0000 (18:21 +0000)]
2009-02-26  Simon Fraser  <simon.fraser@apple.com>

        Build fix, no review.

        Try to fix the wx build after r41218.

        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 26 Feb 2009 18:19:41 +0000 (18:19 +0000)]
2009-02-25  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Fisher.

        Add test that custom DOM properties survive garbage collection.
        https://bugs.webkit.org/show_bug.cgi?id=24142

        * fast/dom/Window/customized-property-survives-gc-expected.txt: Added.
        * fast/dom/Window/customized-property-survives-gc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 26 Feb 2009 18:17:38 +0000 (18:17 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19527
        ASSERTION FAILED: containerA && containerB

        Test: fast/dom/Range/bug-19527.html

        * dom/Range.cpp:
        (WebCore::Range::isPointInRange):
        (WebCore::Range::comparePoint):
        Bring the behavior in line with current Firefox, making it impossible for these methods
        to pass a null container to compareBoundaryPoints().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Carol Szabo <carol.szabo@nokia.com>
zecke@webkit.org [Thu, 26 Feb 2009 17:08:43 +0000 (17:08 +0000)]
2009-02-26  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24099
        ARM Compiler Warnings in pcre_exec.cpp

        * pcre/pcre_exec.cpp:
        (match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Thu, 26 Feb 2009 16:48:58 +0000 (16:48 +0000)]
2009-02-26  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=16947
        [GTK] Missing HTTP Auth challenge

        Take marshallers to be built from a manually maintained list
        instead of grepping the sources.

        It's much faster, especially so now that we want to add
        marshallers from WebCore too. A system to only take into account
        the modified files when generating the marshallers from sources
        could be hacked, but I think it's overkill considering how rarely
        a new marshaller is added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the ChangeLog s/frame/content.
zecke@webkit.org [Thu, 26 Feb 2009 16:40:41 +0000 (16:40 +0000)]
Fix the ChangeLog s/frame/content.

I should have read more about the bug history and should have
done the substitution before landing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Thu, 26 Feb 2009 16:33:04 +0000 (16:33 +0000)]
2009-02-26  Xan Lopez  <xan@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24193
        [GTK] Checkbuttons not activated with space

        Do not swallow key events with GtkIMContext for non-editable
        frames (FIXME: I don't think frame is the right name here).

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::handleInputMethodKeydown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Thu, 26 Feb 2009 16:27:02 +0000 (16:27 +0000)]
2009-02-26  Xan Lopez  <xan@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24103
        [GTK] Use correct return value for WebView button-release handler

        We are returning whatever the core code tells us it did, but this
        does not play well with the GTK+ model. GTK+ in general expects it
        will see a button-release if it saw a button-press and no
        motion/leave/etc events in between. EventHandler.cpp will, in some
        cases, not handle press but handle release, confusing the parent
        container of the WebView.

        As a workaround return always FALSE for button-release (this is
        the same than the Windows port does).

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Thu, 26 Feb 2009 16:21:27 +0000 (16:21 +0000)]
2009-02-26  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=17585
        [gtk] get|set encoding api

        Add functions to get and set a custom encoding an a view.

        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_set_custom_encoding):
        (webkit_web_view_get_custom_encoding):
        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake font-variant:small-caps work properly (bug #20358)
zecke@webkit.org [Thu, 26 Feb 2009 16:14:48 +0000 (16:14 +0000)]
Make font-variant:small-caps work properly (bug #20358)

Set the computed size of the small caps font data rather than the specified size
so that the small-caps text is rendered smaller

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Benjamin Meyer <benjamin.meyer@torchmobile.com>
treat@webkit.org [Thu, 26 Feb 2009 14:13:47 +0000 (14:13 +0000)]
2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=24062
        QNetworkCookieJar expects the url and not the policy url.  Sending the
        policy url will cause QNetworkCookieJar to behave incorrectly.  One
        example would be a cookie that does not have a path or domain.
        QNetworkCookieJar will use the url it is given to fill in default values.
        This allows setting cookies on the url of the main frame from an iFrame
        when the cookie should be set on the url of the iFrame.

        Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do

        * platform/qt/CookieJarQt.cpp:
        (WebCore::setCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-26 Charles Wei <charles.wei@torchmobile.com.cn>
staikos@webkit.org [Thu, 26 Feb 2009 11:09:29 +0000 (11:09 +0000)]
2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos.

        make WebKit/Qt compile with SVG disabled

        * WebCore.pro:
        * platform/graphics/qt/FontPlatformDataQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 26 Feb 2009 07:04:31 +0000 (07:04 +0000)]
2009-02-25  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Gavin Barraclough.

        Bug 24086: Regression (r40993): WebKit crashes after logging in to lists.zenbe
        <https://bugs.webkit.org/show_bug.cgi?id=24086>
        <rdar://problem/6625111>

        The numeric sort optimization in r40993 generated bytecode for a function
        without generating JIT code. This breaks an assumption in some parts of
        the JIT's function calling logic that the presence of a CodeBlock implies
        the existence of JIT code.

        In order to fix this, we simply generate JIT code whenever we check whether
        a function is a numeric sort function. This only incurs an additional cost
        in the case when the function is a numeric sort function, in which case it
        is not expensive to generate JIT code for it.

        JavaScriptCore:

        * runtime/ArrayPrototype.cpp:
        (JSC::isNumericCompareFunction):

        LayoutTests:

        * fast/js/resources/sort-no-jit-code-crash.js: Added.
        * fast/js/sort-no-jit-code-crash-expected.txt: Added.
        * fast/js/sort-no-jit-code-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 26 Feb 2009 04:31:47 +0000 (04:31 +0000)]
2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed build fix. Add WebCore/workers to the list of paths
        searched by the bindings generator perl script.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 26 Feb 2009 03:45:16 +0000 (03:45 +0000)]
2009-02-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Add canvas to the list of RenderObjects that can mark a page as
        visually not empty.

        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 26 Feb 2009 02:19:17 +0000 (02:19 +0000)]
2009-02-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dave Hyatt.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
        as RenderMedia with controls always has a layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 26 Feb 2009 02:12:53 +0000 (02:12 +0000)]
2009-02-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Fix spew about a WebView being deallocated while key value observers are
        still registered with it by making sure that we always stop observing
        _isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dumpRenderTree):
        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        (-[DumpRenderTreeWindow close]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 26 Feb 2009 01:24:26 +0000 (01:24 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        - fix https://bugs.webkit.org/show_bug.cgi?id=24130
          <rdar://problem/6618196> Paint very slow when horizontally resizing

        Test: fast/gradients/background-clipped.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
        destination rectangle passed to drawTiledImage() with the dirty
        rectangle. This makes it more likely for the destination rect to be
        contained in a single tile rect, which results in a faster code path
        being taken down the road (just drawing a single tile instead of
        tiling).

LayoutTests:

        Reviewed by Simon Fraser.

        - test for https://bugs.webkit.org/show_bug.cgi?id=24130
          <rdar://problem/6618196> Paint very slow when horizontally resizing

        * fast/gradients/background-clipped.html: Added.
        * platform/mac/fast/gradients/background-clipped-expected.checksum: Added.
        * platform/mac/fast/gradients/background-clipped-expected.png: Added.
        * platform/mac/fast/gradients/background-clipped-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Ojan Vafai <ojan@chromium.org>
eric@webkit.org [Thu, 26 Feb 2009 00:35:20 +0000 (00:35 +0000)]
2009-02-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Fix test regressions from positionForCoordinates patch.
        https://bugs.webkit.org/show_bug.cgi?id=24148

        * rendering/RenderBlock.cpp:
        (WebCore::positionForPointWithInlineChildren):
        Remove ASSERT that placeholder text codepath is hitting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccess...
cfleizach@apple.com [Thu, 26 Feb 2009 00:27:38 +0000 (00:27 +0000)]
Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
https://bugs.webkit.org/show_bug.cgi?id=24143

When an AX object is marked dirty, do not create AX elements while going up the parent chain.
Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
Make sure the AXObjectWrapper's have an object before calling them
In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 26 Feb 2009 00:16:56 +0000 (00:16 +0000)]
2009-02-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Geoff Garen.

        Re-working of <rdar://problem/6487249> repro crash in
        WebCore::CSSParser::parseFillImage copying entire contents of this
        page
        -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

        Fixes a bunch of layout test failures I caused!

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseBorderImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 25 Feb 2009 23:59:06 +0000 (23:59 +0000)]
2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24174
        Add more V8 custom bindings.

        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
        (WebCore::hasCSSPropertyNamePrefix):
        (WebCore::cssPropertyName):
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::NAMED_PROPERTY_SETTER):
        * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
        (WebCore::INDEXED_PROPERTY_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8EventCustom.cpp: Added.
        (WebCore::ACCESSOR_SETTER):
        (WebCore::ACCESSOR_GETTER):
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
        (WebCore::NAMED_PROPERTY_DELETER):
        (WebCore::NAMED_PROPERTY_SETTER):
        (WebCore::NAMED_PROPERTY_GETTER):
        * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
        (WebCore::NAMED_PROPERTY_GETTER):
        * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
        (WebCore::INDEXED_PROPERTY_GETTER):
        (WebCore::NAMED_PROPERTY_GETTER):
        * bindings/v8/custom/V8NodeListCustom.cpp: Added.
        (WebCore::NAMED_PROPERTY_GETTER):
        * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
        (WebCore::NAMED_PROPERTY_GETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Scott Violet <sky@google.com>
dglazkov@chromium.org [Wed, 25 Feb 2009 23:52:29 +0000 (23:52 +0000)]
2009-02-25  Scott Violet  <sky@google.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24171
        Provides a RenderTheme method for getting the scroll bar size and
        changes RenderListBox to use it. RenderTheme returns a size of regular,
        and Mac's override to return small. Changes ScrollbarThemeChromium to
        use the scrollbarsize of the scrollbar when getting the size
        instead of passing in no-args.

        * platform/chromium/ScrollbarThemeChromium.cpp:
        (WebCore::ScrollbarThemeChromium::trackRect):
        (WebCore::ScrollbarThemeChromium::buttonSize):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::createScrollbar):
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::scrollbarControlSizeForPart):
        * rendering/RenderThemeChromiumMac.h:
        (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
        * rendering/RenderThemeMac.h:
        (WebCore::RenderThemeMac::scrollbarControlSizeForPart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ggaren@apple.com [Wed, 25 Feb 2009 23:44:07 +0000 (23:44 +0000)]
JavaScriptCore:

2009-02-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Fixed <rdar://problem/6611174> REGRESSION (r36701): Unable to select
        messages on hotmail (24052)

        The bug was that for-in enumeration used a cached prototype chain without
        validating that it was up-to-date.

        This led me to refactor prototype chain caching so it was easier to work
        with and harder to get wrong.

        After a bit of inlining, this patch is performance-neutral on SunSpider
        and the v8 benchmarks.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::tryCachePutByID):
        (JSC::Interpreter::tryCacheGetByID):
        * jit/JITStubs.cpp:
        (JSC::JITStubs::tryCachePutByID):
        (JSC::JITStubs::tryCacheGetByID):
        (JSC::JITStubs::cti_op_get_by_id_proto_list): Use the new refactored goodness. See
        lines beginning with "-" and smile.

        * runtime/JSGlobalObject.h:
        (JSC::Structure::prototypeForLookup): A shout out to const.

        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::next): We can use a pointer comparison to
        see if our cached structure chain is equal to the object's structure chain,
        since in the case of a cache hit, we share references to the same structure
        chain.

        * runtime/Operations.h:
        (JSC::countPrototypeChainEntriesAndCheckForProxies): Use the new refactored
        goodness.

        * runtime/PropertyNameArray.h:
        (JSC::PropertyNameArray::PropertyNameArray):
        (JSC::PropertyNameArray::setShouldCache):
        (JSC::PropertyNameArray::shouldCache): Renamed "cacheable" to "shouldCache"
        to communicate that the client is specifying a recommendation, not a
        capability.

        * runtime/Structure.cpp:
        (JSC::Structure::Structure): No need to initialize a RefPtr.
        (JSC::Structure::getEnumerablePropertyNames): Moved some code into helper
        functions.

        (JSC::Structure::prototypeChain): New centralized accessor for a prototype
        chain. Revalidates on every access, since the objects in the prototype
        chain may have mutated.

        (JSC::Structure::isValid): Helper function for revalidating a cached
        prototype chain.

        (JSC::Structure::getEnumerableNamesFromPropertyTable):
        (JSC::Structure::getEnumerableNamesFromClassInfoTable): Factored out of
        getEnumerablePropertyNames.

        * runtime/Structure.h:

        * runtime/StructureChain.cpp:
        (JSC::StructureChain::StructureChain):
        * runtime/StructureChain.h:
        (JSC::StructureChain::create): No need for structureChainsAreEqual, since
        we use pointer equality now. Refactored StructureChain to make a little
        more sense and eliminate special cases for null prototypes.

LayoutTests:

2009-02-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Added a test for <rdar://problem/6611174> REGRESSION (r36701): Unable to
        select messages on hotmail (24052)

        * fast/js/for-in-cached-expected.txt: Added.
        * fast/js/for-in-cached.html: Added.
        * fast/js/resources/for-in-cached.js: Added.
        (forIn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Wed, 25 Feb 2009 22:58:33 +0000 (22:58 +0000)]
WebCore:

2009-02-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6487249> repro crash in
        WebCore::CSSParser::parseFillImage copying entire contents of this
        page
        -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Null-check m_styleSheet

LayoutTests:

2009-02-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/6487249> repro crash in
        WebCore::CSSParser::parseFillImage copying entire contents of this
        page
        -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

        * editing/pasteboard/copy-crash-with-extraneous-attribute-expected.txt: Added.
        * editing/pasteboard/copy-crash-with-extraneous-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Wed, 25 Feb 2009 21:37:33 +0000 (21:37 +0000)]
2009-02-25  Adam Treat  <adam.treat@torchmobile.com>

        Fix the Qt build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Feb 2009 20:59:18 +0000 (20:59 +0000)]
2009-02-25  Simon Fraser  <simon.fraser@apple.com>

        Build fix with ACCELERATED_COMPOSITING turned on.

        I missed a spot in my last commit in renaming to
        _stoppedAcceleratedCompositingForFrame:

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView close]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Wed, 25 Feb 2009 20:45:17 +0000 (20:45 +0000)]
2009-02-25  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Alexey Proskuryakov.

        Do not queue the calls to 'DumpRenderTree::dump()' as this can result
        in more than one call as a test that calls 'notifyDone()' can then be
        subsequently fully loaded and initiate a second dump.  Also make sure
        to stop any existing page load that is happening before running the next
        test.  Combined this serves to produce 217 more passing tests for the
        Qt port or roughly 5% at this point.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 25 Feb 2009 20:39:59 +0000 (20:39 +0000)]
2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Not reviewed.

        Add files to the build per r41218.
        Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp

        * GNUmakefile.am:
        * page/DOMWindow.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Wed, 25 Feb 2009 20:29:45 +0000 (20:29 +0000)]
2009-02-25  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24043
        When faced with URLs with unsupported protocol on Gtk port,
        report the error through an idle function and return true, so
        a proper resource handle is created.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::reportUnknownProtocolError):
        (WebCore::ResourceHandle::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix.
sfalken@apple.com [Wed, 25 Feb 2009 20:22:34 +0000 (20:22 +0000)]
    Windows build fix.
        Use struct to forward declare ResourceRequest.

        * history/HistoryItem.h:
        * inspector/InspectorController.h:
        * loader/DocumentThreadableLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        * loader/ThreadableLoader.h:
        * loader/WorkerThreadableLoader.h:
        * platform/CrossThreadCopier.h:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/ResourceRequestBase.h:
        * platform/network/cf/ResourceRequestCFNet.h:
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Feb 2009 20:12:24 +0000 (20:12 +0000)]
2009-02-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23854

        Make an observable property, _isUsingAcceleratedCompositing, on
        WebView that DumpRenderTree can use to specialize behavior.

        This is implemented via a count of Frames that are using
        accelerated compositing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Andreia Gaita <shana@jitted.com>
alp@webkit.org [Wed, 25 Feb 2009 19:56:20 +0000 (19:56 +0000)]
2009-02-25  Andreia Gaita  <shana@jitted.com>

        Reviewed by Alp Toker.

        Update Win def files with recent JavaScriptCore API additions.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_Cairo.def:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41223 268f45cc-cd09-0410-ab3c-d52691b4dbfc