WebKit-https.git
7 years agoCookieJar uses Document class, which is a layering violation
ap@apple.com [Fri, 9 Nov 2012 18:08:04 +0000 (18:08 +0000)]
CookieJar uses Document class, which is a layering violation
https://bugs.webkit.org/show_bug.cgi?id=101621

Reviewed by Brady Eidson.

Source/WebCore:

Split CookieJar in two parts, one that takes a Document, and another that is a pure
platform one, using NetworkingContext to access the correct platform storage.

* GNUmakefile.list.am:
* PlatformBlackBerry.cmake:
* Target.pri:
* WebCore.gypi:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Updated.

* loader/CookieJar.cpp: Added.
(WebCore::networkingContext):
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
* loader/CookieJar.h: Copied from Source/WebCore/platform/CookieJar.h.
This is an adaptor for pure platform implementations. Clients continue to use the
old interface unchanged.

* platform/blackberry/CookieJarBlackBerry.cpp: Removed.
* loader/blackberry/CookieJarBlackBerry.cpp: Copied from Source/WebCore/platform/blackberry/CookieJarBlackBerry.cpp.
* platform/network/chromium/CookieJarChromium.cpp: Removed.
* loader/chromium/CookieJarChromium.cpp: Copied from Source/WebCore/platform/network/chromium/CookieJarChromium.cpp.
These platforms do not have a pure platform implementation yet, so they just keep
to use original implementations. Since the code is not in platform/ any more, the
violation is resolved for Chromium and Blackberry, too.

* platform/CookieJar.h: Removed.
* platform/network/PlatformCookieJar.h: Copied from Source/WebCore/platform/CookieJar.h.
The platform interface is now more uniform - all functions take a NetworkingContext
instead of hardcoding which cookie storage to use in some cases.
Renamed functions that are only useful for document.cookie implementation to look
less generic.

* platform/mac/CookieJar.mm: Removed.
* platform/network/mac/CookieJarMac.mm: Copied from Source/WebCore/platform/mac/CookieJar.mm.
(WebCore::cookiesForDOM): This now takes a context instead of Document, and also
takes a firstParty URL (unused on Mac, but used on some other platforms).
(WebCore::cookieRequestHeaderFieldValue): Get cookie storage from context (and
use shared one if context is null).
(WebCore::setCookiesFromDOM): Ditto.
(WebCore::cookiesEnabled): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.
(WebCore::getHostnamesWithCookies): Ditto. This used to only support default storage,
but its cleaner to have a uniform interface.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

* platform/network/cf/CookieJarCFNet.cpp:
Same changes as on Mac.

* platform/network/curl/CookieJarCurl.cpp:
Updated for new interface. Implementation is largely a dummy one.

* platform/qt/CookieJarQt.h: Removed.
* platform/network/qt/CookieJarQt.h: Copied from Source/WebCore/platform/qt/CookieJarQt.h.
Moved to a common location, most cookie files were in network/ already.

* platform/qt/CookieJarQt.cpp: Removed.
* platform/network/qt/CookieJarQt.cpp: Copied from Source/WebCore/platform/qt/CookieJarQt.cpp.
(WebCore::setCookiesFromDOM): Use context's or shared cooke jar as appropriate.
(WebCore::cookiesForDOM): Ditto.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::cookiesEnabled): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.
(WebCore::getHostnamesWithCookies): Back-end implementation can only handle shared
jar here, assert that argument does not request another one.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForContext):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForContext):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated for new function signatures, and use the same cross-platform logic for
choosing a cookie jar.

* platform/network/soup/CookieJarSoup.h: Don't include unnecessary CooieJar.h.

* platform/network/win/CookieJarWin.cpp:
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated for new function signatures.

Source/WebKit2:

* UIProcess/API/C/WKAPICast.h: Don't include CookieJar.h, its completely unnecessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArrayPrototype should start out with a blank indexing type
fpizlo@apple.com [Fri, 9 Nov 2012 18:04:01 +0000 (18:04 +0000)]
ArrayPrototype should start out with a blank indexing type
https://bugs.webkit.org/show_bug.cgi?id=101719

Reviewed by Mark Hahnenberg.

This allows us to track if the array prototype ever ends up with indexed
properties.

* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::ArrayPrototype):
* runtime/ArrayPrototype.h:
(ArrayPrototype):
(JSC::ArrayPrototype::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMarkStackArray should use the BlockAllocator instead of the MarkStackSegmentAllocator
mhahnenberg@apple.com [Fri, 9 Nov 2012 17:58:19 +0000 (17:58 +0000)]
MarkStackArray should use the BlockAllocator instead of the MarkStackSegmentAllocator
https://bugs.webkit.org/show_bug.cgi?id=101642

Reviewed by Filip Pizlo.

MarkStackSegmentAllocator is like a miniature version of the BlockAllocator. Now that the BlockAllocator has support
for a variety of block sizes, we should get rid of the MarkStackSegmentAllocator in favor of the BlockAllocator.

* heap/BlockAllocator.h: Add new specializations of regionSetFor for the new MarkStackSegments.
(JSC):
(JSC::MarkStackSegment):
* heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
* heap/GCThreadSharedData.h:
(GCThreadSharedData):
* heap/MarkStack.cpp:
(JSC::MarkStackArray::MarkStackArray): We now have a doubly linked list of MarkStackSegments, so we need to refactor
all the places that used the old custom tail/previous logic.
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::refill):
(JSC::MarkStackArray::donateSomeCellsTo): Refactor to use the new linked list.
(JSC::MarkStackArray::stealSomeCellsFrom): Ditto.
* heap/MarkStack.h:
(JSC):
(MarkStackSegment):
(JSC::MarkStackSegment::MarkStackSegment):
(JSC::MarkStackSegment::sizeFromCapacity):
(MarkStackArray):
* heap/MarkStackInlines.h:
(JSC::MarkStackSegment::create):
(JSC):
(JSC::MarkStackArray::postIncTop):
(JSC::MarkStackArray::preDecTop):
(JSC::MarkStackArray::setTopForFullSegment):
(JSC::MarkStackArray::setTopForEmptySegment):
(JSC::MarkStackArray::top):
(JSC::MarkStackArray::validatePrevious):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStackArray::size):
* heap/SlotVisitor.cpp:
(JSC::SlotVisitor::SlotVisitor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Give the view a size in TestWebKitAPI
commit-queue@webkit.org [Fri, 9 Nov 2012 17:51:38 +0000 (17:51 +0000)]
[EFL] Give the view a size in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=101770

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-09
Reviewed by Laszlo Gombos.

2 tests are currently failing, because they expect us to paint, but we don't paint if the view size is empty.

* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI):
(TestWebKitAPI::PlatformWebView::resizeTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css] Text decoration's "blink" not valid when CSS3_TEXT is enabled
bruno.abinader@basyskom.com [Fri, 9 Nov 2012 17:22:38 +0000 (17:22 +0000)]
[css] Text decoration's "blink" not valid when CSS3_TEXT is enabled
https://bugs.webkit.org/show_bug.cgi?id=101750

Reviewed by Ojan Vafai.

Source/WebCore:

This patch fixes an issue regarding "blink" value, which is valid for CSS 2.1
"text-decoration" property, but recently have its parser function modified by
the addition of CSS3 "-webkit-text-decoration-line" property.

The 'fast/css/getComputedStyle/getComputedStyle-text-decoration.html'
layout test is updated with all possible value combinations.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseTextDecoration): Added 'blink' value to list
if accepted.

LayoutTests:

This patch updates the "text-decoration" computed style layout tests to
handle a larger variety of value combinations.

* fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt:
* fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening - rebaseline a handful of image tests for chromium...
jsbell@chromium.org [Fri, 9 Nov 2012 17:16:30 +0000 (17:16 +0000)]
[Chromium] Unreviewed gardening - rebaseline a handful of image tests for chromium-mac-lion.

* platform/chromium-mac-lion/platform/chromium/compositing/layout-width-change-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/core/backgrounds-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-11-09 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 9 Nov 2012 17:09:06 +0000 (17:09 +0000)]
2012-11-09  Xan Lopez  <xlopez@igalia.com>

        [GTK] Do not use 'ls' to list IDL files in EXTRA_DIST
        https://bugs.webkit.org/show_bug.cgi?id=101581

        Reviewed by Martin Robinson.

        Use normal GNU Make wildcards instead of 'ls' to list files in
        EXTRA_DIST, it's safer and more straightforward.

        * GNUmakefile.am: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134068.
rakuco@webkit.org [Fri, 9 Nov 2012 16:55:33 +0000 (16:55 +0000)]
Unreviewed, rolling out r134068.
http://trac.webkit.org/changeset/134068
https://bugs.webkit.org/show_bug.cgi?id=101766

Caused crashes on the bots. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Bump the jhbuild Cairo version to 1.12.8
zandobersek@gmail.com [Fri, 9 Nov 2012 16:20:58 +0000 (16:20 +0000)]
[GTK] Bump the jhbuild Cairo version to 1.12.8
https://bugs.webkit.org/show_bug.cgi?id=101721

Bump the Cairo version in Jhbuild moduleset to 1.12.8. This version
should fix multiple failures in canvas tests and also contains
fixes for X-related crashes that occurred from the 1.12.4 version onwards.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] r133953 broke the ARM_TRADITIONAL build
ossy@webkit.org [Fri, 9 Nov 2012 16:02:52 +0000 (16:02 +0000)]
[Qt] r133953 broke the ARM_TRADITIONAL build
https://bugs.webkit.org/show_bug.cgi?id=101706

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-09
Reviewed by Csaba Osztrogonác.

Fix for both hardfp and softfp.

* dfg/DFGCCallHelpers.h:
(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNeed to clear exception in JSDictionary that might have been caused by previous opera...
charles.wei@torchmobile.com.cn [Fri, 9 Nov 2012 15:56:58 +0000 (15:56 +0000)]
Need to clear exception in JSDictionary that might have been caused by previous operation.
https://bugs.webkit.org/show_bug.cgi?id=96614

Reviewed by George Staikos.

IndexedDB IDBDatabase::createObjectStore supports both String type of KeyPath and
String Array type of KeyPath. It will first try to get the keyPath as a String Array,
if fails, it will try to get KeyPath as a String, from the Dictionary. The first get
will leave the internal ExecState of Dictionary in exception state. We need to clear
the exception state before the 2nd query, otherwise the second query will also fail.

No new tests. The existing test case LayoutTests/storage/indexeddb/tutorial.html should
now work with this patch.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::getWithUndefinedOrNullCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
rakuco@webkit.org [Fri, 9 Nov 2012 15:49:46 +0000 (15:49 +0000)]
[WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
https://bugs.webkit.org/show_bug.cgi?id=101759

Reviewed by Kenneth Rohde Christiansen.

* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Improve
the check for an empty repaintRect -- we need to check if the
WKArrayRef has any items. `if (repaintRect)' will return true
regardless of whether the array is empty or not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove obsolete tokenizer settings
staikos@webkit.org [Fri, 9 Nov 2012 15:32:17 +0000 (15:32 +0000)]
[BlackBerry] Remove obsolete tokenizer settings
https://bugs.webkit.org/show_bug.cgi?id=101689

Reviewed by Yong Li.

These tokenizer settings are obsolete and should not be here.  Remove them.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Stop watchlist from triggering QtBuildSystem rule on DerivedSources
vestbo@webkit.org [Fri, 9 Nov 2012 15:23:49 +0000 (15:23 +0000)]
[Qt] Stop watchlist from triggering QtBuildSystem rule on DerivedSources

Having DerivedSources.pri in the watchlist regexp was creating too much
noise.

Reviewed by Ossy.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rebaseline svg tests after 99870
commit-queue@webkit.org [Fri, 9 Nov 2012 15:18:04 +0000 (15:18 +0000)]
[EFL] Rebaseline svg tests after 99870
https://bugs.webkit.org/show_bug.cgi?id=101756

Unreviewed svg baseline after https://bugs.webkit.org/show_bug.cgi?id=99870.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-09

* platform/efl/TestExpectations:
* platform/efl/svg/custom/pattern-scaling-expected.png: Added.
* platform/efl/svg/custom/pattern-scaling-expected.txt: Added.
* platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rebaseline fast/table/025-expected
commit-queue@webkit.org [Fri, 9 Nov 2012 14:58:56 +0000 (14:58 +0000)]
[EFL] Rebaseline fast/table/025-expected
https://bugs.webkit.org/show_bug.cgi?id=101752

Unreviewed rebaseline after https://bugs.webkit.org/show_bug.cgi?id=11645.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-09

* platform/efl/TestExpectations:
* platform/efl/fast/table/025-expected.png:
* platform/efl/fast/table/025-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134051.
ossy@webkit.org [Fri, 9 Nov 2012 14:51:34 +0000 (14:51 +0000)]
Unreviewed, rolling out r134051.
http://trac.webkit.org/changeset/134051
https://bugs.webkit.org/show_bug.cgi?id=101757

It didn't fix the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unmark now passing tests
jocelyn.turcotte@digia.com [Fri, 9 Nov 2012 14:42:37 +0000 (14:42 +0000)]
[Qt] Unmark now passing tests
https://bugs.webkit.org/show_bug.cgi?id=65531

Reviewed by Csaba Osztrogonác.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::viewModes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWinCairo build fails to link
commit-queue@webkit.org [Fri, 9 Nov 2012 14:36:55 +0000 (14:36 +0000)]
WinCairo build fails to link
https://bugs.webkit.org/show_bug.cgi?id=101739

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-11-09
Reviewed by Kentaro Hara.

* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy/layouttests integration test fails if high shards/processes environment...
dominik.rottsches@intel.com [Fri, 9 Nov 2012 14:28:37 +0000 (14:28 +0000)]
webkitpy/layouttests integration test fails if high shards/processes environment variables are used
https://bugs.webkit.org/show_bug.cgi?id=101455

Reviewed by Dirk Pranke.

Updating test to disregard WEBKIT_TEST_MAX_LOCKED_SHARDS environment variable.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_max_locked_shards):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Force a repaint before tracking repaint rects.
rakuco@webkit.org [Fri, 9 Nov 2012 14:25:47 +0000 (14:25 +0000)]
[EFL][DRT] Force a repaint before tracking repaint rects.
https://bugs.webkit.org/show_bug.cgi?id=101743

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::forceLayout): Added.
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Do like other ports and force a repaint before we start tracking
repaints so that the pixel results generated look more in line
with what's expected.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(displayWebView): Call DRTSupport::forceLayout() before start
tracking repaints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMonth/week picker should submit month/week string
keishi@webkit.org [Fri, 9 Nov 2012 14:22:37 +0000 (14:22 +0000)]
Month/week picker should submit month/week string
https://bugs.webkit.org/show_bug.cgi?id=101744

Reviewed by Kent Tamura.

Month/week picker should submit month/week string and not yyyy-mm-dd.

No new tests. Test will be added in Bug 101555 and Bug 101556.

* Resources/pagepopups/calendarPicker.js:
(DaysTable.prototype._handleDayClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable -Werror for the EFL port
commit-queue@webkit.org [Fri, 9 Nov 2012 14:03:14 +0000 (14:03 +0000)]
[EFL] Enable -Werror for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=98715

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-09
Reviewed by Gyuyoung Kim.

Treat all warnings as errors, except the existing warnings in the
current code base ("unused-parameter", "sign-compare" and "switch").

Thanks for Raphael Kubo da Costa for the extra help.

* Source/CMakeLists.txt: Enable warnings as error for all libraries
(except WebKit and WebKit2) for the EFL port.
Other cmake-based ports are welcome to join.

* Source/cmake/WebKitHelpers.cmake: Treat warnings as errors by
default for cmake-based ports when ENABLE_WERROR is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] REGRESSION (r134043): API tests crashes
rakuco@webkit.org [Fri, 9 Nov 2012 13:52:42 +0000 (13:52 +0000)]
[EFL][WK2] REGRESSION (r134043): API tests crashes
https://bugs.webkit.org/show_bug.cgi?id=101742

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Do not assert on PassRefPtr<WebContext> after it becomes 0.

* UIProcess/efl/BatteryProvider.cpp:
(BatteryProvider::BatteryProvider):
* UIProcess/efl/NetworkInfoProvider.cpp:
(NetworkInfoProvider::NetworkInfoProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the `svn:executable' property from a few test files.
rakuco@webkit.org [Fri, 9 Nov 2012 13:42:35 +0000 (13:42 +0000)]
Remove the `svn:executable' property from a few test files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPixel tests need rebaseline https://bugs.webkit.org/show_bug.cgi?id=99323
kbalazs@webkit.org [Fri, 9 Nov 2012 13:15:06 +0000 (13:15 +0000)]
Pixel tests need rebaseline https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel rebaseline.

Rebaseline some tests, add missing expectations.

* platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png: Added.
* platform/qt-5.0-wk2/fast/backgrounds/transformed-body-background-expected.png: Added.
* platform/qt-5.0-wk2/fast/backgrounds/transformed-body-html-background-expected.png: Added.
* platform/qt-5.0-wk2/fast/backgrounds/transformed-html-body-background-expected.png: Added.
* platform/qt-5.0-wk2/fast/css-generated-content/before-with-first-letter-expected.png: Added.
* platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2c-expected.png: Added.
* platform/qt-5.0-wk2/svg/text/text-rescale-expected.png: Added.
* platform/qt/css3/filters/effect-reference-ordering-hw-actual.png: Added.
* platform/qt/fast/images/png-suite/test-actual.png: Added.
* platform/qt/svg/as-image/image-respects-pageScaleFactor-change-actual.png: Added.
* platform/qt/svg/as-object/embedded-svg-size-changes-actual.png: Added.
* platform/qt/svg/as-object/nested-embedded-svg-size-changes-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-dom-height-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-dom-width-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-dom-x-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-dom-y-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-dom-height-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-dom-width-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-dom-x-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-dom-y-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-dom-height-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-dom-width-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-dom-x-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-dom-y-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTRefElement-dom-href-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-dx-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-dy-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-transform-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-x-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-dom-y-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGUseElement-dom-href1-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGUseElement-dom-href2-attr-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-actual.png: Added.
* platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-actual.png: Added.
* platform/qt/svg/filters/subRegion-one-effect-actual.png: Added.
* platform/qt/svg/filters/subRegion-two-effects-actual.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: wrong output for empty object {}
pfeldman@chromium.org [Fri, 9 Nov 2012 13:05:13 +0000 (13:05 +0000)]
Web Inspector: wrong output for empty object {}
https://bugs.webkit.org/show_bug.cgi?id=101356

Reviewed by Vsevolod Vlasov.

Changed preview formatting to iterate over enumerable properties only + visit the prototypes.

Source/WebCore:

* inspector/InjectedScriptSource.js:
(.):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):

LayoutTests:

* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api-inspect-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home...
commit-queue@webkit.org [Fri, 9 Nov 2012 12:54:35 +0000 (12:54 +0000)]
[BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home, end key
https://bugs.webkit.org/show_bug.cgi?id=100937

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-11-09
Reviewed by Rob Buis.

1. Translate these keys to their corresponding BlackBerry key code.
2. Break down a KeyChar event to a KeyDown/KeyUp pair. This is required
because we only handle scrolling on a KeyDown event in WebPage::keyEvent()
, and internally a KeyChar event is interpreted as a KeyDown event + a
KeyUp event in InputHandler::handleKeyboardInput().

Tests fixed:
1. editing/input/scroll-viewport-page-up-down.html
2. editing/selection/move-begin-end.html
3. fast/forms/select-popup-pagekeys.html

* DumpRenderTree/blackberry/EventSender.cpp:
(keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] r133953 broke the ARM_TRADITIONAL build
commit-queue@webkit.org [Fri, 9 Nov 2012 12:41:27 +0000 (12:41 +0000)]
[Qt] r133953 broke the ARM_TRADITIONAL build
https://bugs.webkit.org/show_bug.cgi?id=101706

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-09
Reviewed by Csaba Osztrogonác.

Fix the ARM_TRADITIONAL build after r133953

* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix annotations in page popup files
keishi@webkit.org [Fri, 9 Nov 2012 12:28:58 +0000 (12:28 +0000)]
Fix annotations in page popup files
https://bugs.webkit.org/show_bug.cgi?id=101736

Reviewed by Kent Tamura.

Add @constructor where needed. Replacing /* with /** for annotations.

No new tests. No behavior change.

* Resources/pagepopups/calendarPicker.js:
* Resources/pagepopups/pickerCommon.js:
* Resources/pagepopups/suggestionPicker.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2][AC] Random crashes in layout tests on the bot
rakuco@webkit.org [Fri, 9 Nov 2012 12:23:45 +0000 (12:23 +0000)]
[EFL][WK2][AC] Random crashes in layout tests on the bot
https://bugs.webkit.org/show_bug.cgi?id=101687

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Speculative fix for a crash on the bot.
If didCommitLoad() is called before the view size was set, we will
try to paint an empty area, and that will crash.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Remove a backing store of GraphicsLayer when the layer is far...
commit-queue@webkit.org [Fri, 9 Nov 2012 12:13:25 +0000 (12:13 +0000)]
Coordinated Graphics: Remove a backing store of GraphicsLayer when the layer is far from the viewport.
https://bugs.webkit.org/show_bug.cgi?id=101656

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore computes cover and keep rects to create, keep or remove tiles
smartly, but currently TiledBackingStore expects a contents rect is big enough
to cover the visibleRect. However, when CoordinatedGraphicsLayer uses TBS, it
is usually wrong expectation.

We must compute cover and keep rects using the visibleRect, instead of
the rect intersecting the visibleRect with m_rect, because TBS can be
used as a backing store of GraphicsLayer and the visible rect usually
does not intersect with m_rect.
In the below case, the intersecting rect is an empty.

 +---------------+
 |               |
 |   m_rect      |
 |       +-------|-----------------------+
 |       | HERE  |  cover or keep        |
 +---------------+      rect             |
         |         +---------+           |
         |         | visible |           |
         |         |  rect   |           |
         |         +---------+           |
         |                               |
         |                               |
         +-------------------------------+

We must create or keep the tiles in the HERE region. Currently in the
case, we do not create or keep tiles on the HERE region. Moreover, in
the case, we early return, which means we don't remove any tiles. It
causes to waste heap and video memory.

This patch changes TiledBackingStore to manage tiles smartly for
Coordinated Graphics.

Changing cache policy is not testable in layout tests.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Refactor TestExpectations file
commit-queue@webkit.org [Fri, 9 Nov 2012 12:08:06 +0000 (12:08 +0000)]
[EFL] Refactor TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=101738

Unreviewed, EFL gardening.

Remove duplicated definitions.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-09

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix undefined variable in Week constructor for calendar picker
keishi@webkit.org [Fri, 9 Nov 2012 11:39:06 +0000 (11:39 +0000)]
Fix undefined variable in Week constructor for calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101734

Reviewed by Kent Tamura.

Closer compiler found an undefined variable in the Week constructor.

No new tests. This code isn't used.

* Resources/pagepopups/calendarPicker.js:
(Week): Used wrong variable name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: render canvas log as a grid.
pfeldman@chromium.org [Fri, 9 Nov 2012 11:33:58 +0000 (11:33 +0000)]
Web Inspector: render canvas log as a grid.
https://bugs.webkit.org/show_bug.cgi?id=101732

Reviewed by Vsevolod Vlasov.

* English.lproj/localizedStrings.js:
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._onSelectTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileHeader.prototype.traceLogId):
(WebInspector.CanvasLogGrid):
(WebInspector.CanvasLogGrid.prototype._didReceiveTraceLog):
(WebInspector.CanvasLogGrid.prototype._createCallNode):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.createCell):
* inspector/front-end/canvasProfiler.css:
(#canvas-replay-image-container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r107593) Crash in ContextMenuController::addInspectElementItem()
allan.jensen@digia.com [Fri, 9 Nov 2012 11:28:00 +0000 (11:28 +0000)]
Regression(r107593) Crash in ContextMenuController::addInspectElementItem()
https://bugs.webkit.org/show_bug.cgi?id=101595

Reviewed by Simon Hausmann.

If the contextMenu is a null pointer treat it as empty, appendItem will later
create it if necessary.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::addInspectElementItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Make classes for client use WebContext instead of WKContext
commit-queue@webkit.org [Fri, 9 Nov 2012 11:25:24 +0000 (11:25 +0000)]
[EFL][WK2] Make classes for client use WebContext instead of WKContext
https://bugs.webkit.org/show_bug.cgi?id=101564

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

EwkContext class has been refactored to use WebContext instead of WKContext in r133844,
so this patch makes client classes use WebContext

* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
* UIProcess/efl/BatteryProvider.cpp:
(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::didChangeBatteryStatus):
* UIProcess/efl/BatteryProvider.h:
(BatteryProvider):
* UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
* UIProcess/efl/ContextHistoryClientEfl.h:
(WebKit::ContextHistoryClientEfl::create):
(ContextHistoryClientEfl):
* UIProcess/efl/NetworkInfoProvider.cpp:
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):
* UIProcess/efl/NetworkInfoProvider.h:
(NetworkInfoProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Fix build warning in test_ewk2_context.cpp: [-Wwrite-strings]
commit-queue@webkit.org [Fri, 9 Nov 2012 11:12:14 +0000 (11:12 +0000)]
[EFL][WK2] Fix build warning in test_ewk2_context.cpp: [-Wwrite-strings]
https://bugs.webkit.org/show_bug.cgi?id=101666

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Use constant character pointer to fix [-Wwrite-strings] warning.

* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add support for custom cursors
commit-queue@webkit.org [Fri, 9 Nov 2012 11:06:14 +0000 (11:06 +0000)]
[EFL][WK2] Add support for custom cursors
https://bugs.webkit.org/show_bug.cgi?id=101723

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add getEvasObject() virtual method to Image class and
provide implementation for BitmapImage.

No new tests, no behavior change.

* platform/efl/CursorEfl.cpp:
(WebCore::cursorString):
* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/Image.h:
(Image):
(WebCore::Image::getEvasObject):
* platform/graphics/efl/ImageEfl.cpp:
(WebCore::BitmapImage::getEvasObject):
(WebCore):

Source/WebKit2:

EwkViewImpl::setCursor() now properly handles custom
cursors.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::setCursor):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB should use mostly ScriptWrappable DOM objects
abarth@webkit.org [Fri, 9 Nov 2012 10:33:06 +0000 (10:33 +0000)]
IndexedDB should use mostly ScriptWrappable DOM objects
https://bugs.webkit.org/show_bug.cgi?id=101694

Reviewed by Kentaro Hara.

These object always have JavaScript wrappers, so we should store the
wrappers inline to use less memory and be faster.

* Modules/indexeddb/IDBAny.h:
* Modules/indexeddb/IDBCursor.h:
* Modules/indexeddb/IDBDatabase.h:
* Modules/indexeddb/IDBFactory.h:
* Modules/indexeddb/IDBIndex.h:
* Modules/indexeddb/IDBKey.h:
* Modules/indexeddb/IDBKeyRange.h:
* Modules/indexeddb/IDBObjectStore.h:
* Modules/indexeddb/IDBRequest.h:
* Modules/indexeddb/IDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip failing test perf/accessibility-title-ui-element.html
dominik.rottsches@intel.com [Fri, 9 Nov 2012 10:10:37 +0000 (10:10 +0000)]
[EFL] Skip failing test perf/accessibility-title-ui-element.html
https://bugs.webkit.org/show_bug.cgi?id=101728

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update baselines for failing svg tests
dominik.rottsches@intel.com [Fri, 9 Nov 2012 10:09:16 +0000 (10:09 +0000)]
[EFL] Update baselines for failing svg tests
https://bugs.webkit.org/show_bug.cgi?id=101726

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09

* platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
* platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
* platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
* platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
* platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
* platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.png:
* platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
* platform/efl/svg/text/bidi-tspans-expected.png:
* platform/efl/svg/text/bidi-tspans-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add meaningful error message when request content was evicted from...
vsevik@chromium.org [Fri, 9 Nov 2012 10:06:43 +0000 (10:06 +0000)]
Web Inspector: Add meaningful error message when request content was evicted from inspector cache.
https://bugs.webkit.org/show_bug.cgi?id=101578

Reviewed by Yury Semikhatsky.

Added specific error message when request content was evicted from inspector cache.
Replaced purge with evict in fields/methods names.

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::getResponseBody):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::evictContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::isContentEvicted):
(ResourceData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't use RenderTextControlSingleLine for date/time input types without the multiple...
tkent@chromium.org [Fri, 9 Nov 2012 10:03:11 +0000 (10:03 +0000)]
Don't use RenderTextControlSingleLine for date/time input types without the multiple-fields UI
https://bugs.webkit.org/show_bug.cgi?id=101722

Reviewed by Hajime Morita.

Because the date/time input types are not textfields, we should not use
RenderTextControlSingleLine, and don't need to create shadow trees for
RenderTextControlSingleLine.

No new tests. Covered by fast/forms/*/*-appearance-*.html.

* css/html.css:
(input[type="date"]):
It has menulist appeanrace by default, and should be a flexible box to
center the inner text. 10em width is almost same as the default width of
text fields.
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-date-and-time-value):
Added. A style for the inner text block.
* html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::createRenderer):
Don't create RenderTextControlSingleLine.
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
Skip TextFieldInputType::updateInnerTextValue.
(WebCore::BaseChooserOnlyDateAndTimeInputType::forwardEvent):
Skip TextFieldInputType::forwardEvent.
(WebCore::BaseChooserOnlyDateAndTimeInputType::createShadowSubtree):
Just add one element to the shadow root.
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateAppearance):
Sets a localized value to the inner text block.
(WebCore::BaseChooserOnlyDateAndTimeInputType::setValue):
Calls updateAppearance if the value is updated.
* html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType): Declare updateAppearance,
createRenderer, updateInnerTextValue, forwardEvent, createShadowSubtree,
and setValue.
* html/BaseDateAndTimeInputType.h:
(WebCore): Add a FIXME comment.
(BaseDateAndTimeInputType):
Make visibleValue protected. It is used by BaseChooserOnlyDateAndTimeInputType.
* html/TextFieldInputType.h:
(TextFieldInputType):
Make setValue protected. It is used by BaseChooserOnlyDateAndTimeInputType.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Clarify meaning of different urls in protocol.
vsevik@chromium.org [Fri, 9 Nov 2012 09:59:57 +0000 (09:59 +0000)]
Web Inspector: Clarify meaning of different urls in protocol.
https://bugs.webkit.org/show_bug.cgi?id=101582

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMonth picker should select the current month when navigating while keeping selection...
keishi@webkit.org [Fri, 9 Nov 2012 09:58:08 +0000 (09:58 +0000)]
Month picker should select the current month when navigating while keeping selection position.
https://bugs.webkit.org/show_bug.cgi?id=101724

Reviewed by Kent Tamura.

Month picker needs to behave differently because selection won't be in the same position when changing current month.

No new tests. Test will be added in Bug 101556.

* Resources/pagepopups/calendarPicker.js:
(DaysTable.prototype.navigateToMonth): Date/Week picker should keep selection position for first selected date node.
(DaysTable.prototype._startMoveInAnimation): Moving shared code to separate function.
(MonthPickerDaysTable.prototype.navigateToMonth): Month picker should just select the month.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix heap snapshots counted several times by NMI
commit-queue@webkit.org [Fri, 9 Nov 2012 09:50:57 +0000 (09:50 +0000)]
Web Inspector: Fix heap snapshots counted several times by NMI
https://bugs.webkit.org/show_bug.cgi?id=101085

The fix moves snapshots size counting to V8PerIsolateData class. As long
as it has one instance per isolate its reportMemoryUsage should be
called once per isolate.

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-09
Reviewed by Yury Semikhatsky.

Source/WebCore:

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):

Source/WTF:

* wtf/MemoryInstrumentation.h:
(WTF::MemoryClassInfo::addPrivateBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed prospective Qt/Windows build bot fix:
hausmann@webkit.org [Fri, 9 Nov 2012 09:47:47 +0000 (09:47 +0000)]
Unreviewed prospective Qt/Windows build bot fix:

Make determination of qmake mkspec work with older versions of Qt that
still create a "mkspecs/default" directory.

* Scripts/webkitdirs.pm:
(qtMakeCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: split SplitView into SplitView and SidebarView
pfeldman@chromium.org [Fri, 9 Nov 2012 09:22:32 +0000 (09:22 +0000)]
Web Inspector: split SplitView into SplitView and SidebarView
https://bugs.webkit.org/show_bug.cgi?id=101612

Reviewed by Vsevolod Vlasov.

Currently, SplitView is rather a sidebar view. I'm extracting the reusable split component from it.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
* inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.CounterUI):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype.setSidebarWidth):
(WebInspector.MemoryStatistics.prototype.visible):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.hide):
* inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._innerHideNavigatorOverlay):
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.createSidebarView):
(WebInspector.Panel.prototype.createSidebarViewWithTree):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
* inspector/front-end/ResourcesPanel.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/SidebarView.js: Added.
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._hasLeftSidebar):
(WebInspector.SidebarView.prototype.get mainElement):
(WebInspector.SidebarView.prototype.get sidebarElement):
(WebInspector.SidebarView.prototype._innerSetSidebarPosition):
(WebInspector.SidebarView.prototype.setMinimalSidebarWidth):
(WebInspector.SidebarView.prototype.setMinimalMainWidthPercent):
(WebInspector.SidebarView.prototype.setSidebarWidth):
(WebInspector.SidebarView.prototype.sidebarWidth):
(WebInspector.SidebarView.prototype.onResize):
(WebInspector.SidebarView.prototype.applyConstraints):
(WebInspector.SidebarView.prototype.hideMainElement):
(WebInspector.SidebarView.prototype.showMainElement):
(WebInspector.SidebarView.prototype.hideSidebarElement):
(WebInspector.SidebarView.prototype.showSidebarElement):
(WebInspector.SidebarView.prototype.elementsToRestoreScrollPositionsFor):
* inspector/front-end/SplitView.js:
(WebInspector.SplitView):
(WebInspector.SplitView.prototype.firstElement):
(WebInspector.SplitView.prototype.secondElement):
(WebInspector.SplitView.prototype.setChangeFirstOnResize):
(WebInspector.SplitView.prototype.resizerElement):
(WebInspector.SplitView.prototype.showOnlyFirst):
(WebInspector.SplitView.prototype.showOnlySecond):
(WebInspector.SplitView.prototype._showOnly):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):
(WebInspector.SplitView.prototype.showBoth):
(WebInspector.SplitView.prototype.setResizable):
(WebInspector.SplitView.prototype.setSplitOffset):
(WebInspector.SplitView.prototype.splitOffset):
(WebInspector.SplitView.prototype._innerSetSplitOffset):
(WebInspector.SplitView.prototype._startResizerDragging):
* inspector/front-end/TimelinePanel.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/splitView.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Ctrl+A in the network panel should select resource content, not the...
commit-queue@webkit.org [Fri, 9 Nov 2012 09:20:01 +0000 (09:20 +0000)]
Web Inspector: Ctrl+A in the network panel should select resource content, not the entire panel
https://bugs.webkit.org/show_bug.cgi?id=101591

Patch by Andrey Lushnikov <lushnikov@google.com> on 2012-11-09
Reviewed by Vsevolod Vlasov.

Intercept Ctrl+A event in DefaultTextEditor to select resource content

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._registerShortcuts): Added Ctrl+A
(WebInspector.DefaultTextEditor.prototype._handleKeyDown): Intercept Ctrl+A even for readonly fields
(WebInspector.TextEditorMainPanel.prototype.handleSelectAll):
* inspector/front-end/KeyboardShortcut.js: Added SelectAll constant for Ctrl+A combination

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Main world should have one DOMDataStore
commit-queue@webkit.org [Fri, 9 Nov 2012 09:11:12 +0000 (09:11 +0000)]
[V8] Main world should have one DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101470

Patch by Dan Carney <dcarney@google.com> on 2012-11-09
Reviewed by Kentaro Hara.

The main world DOMWrapperWorld held onto a DOMDataStore that should
never be used, as there is a static one optimized for speed in
DOMDataStore.

No new tests. No change in functionality.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):
* bindings/v8/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::isolatedWorldDomDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Navigating around NMI snapshot grid with keys breaks the grid
commit-queue@webkit.org [Fri, 9 Nov 2012 09:01:04 +0000 (09:01 +0000)]
Web Inspector: Navigating around NMI snapshot grid with keys breaks the grid
https://bugs.webkit.org/show_bug.cgi?id=101611

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-09
Reviewed by Yury Semikhatsky.

Keys navigation cause populate message sent to the node. The node should
not react on populate messages but the first one.

* inspector/front-end/NativeMemorySnapshotView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Introduce a WebTestProxy to override methods in WebViewClient for layout...
jochen@chromium.org [Fri, 9 Nov 2012 09:00:52 +0000 (09:00 +0000)]
[chromium] Introduce a WebTestProxy to override methods in WebViewClient for layout tests
https://bugs.webkit.org/show_bug.cgi?id=101452

Reviewed by Adam Barth.

The WebTestProxy is template, so it can derive from an implementation
of the WebViewClient interface. That way, WebTestProxy can hook into
individual methods of the WebViewClient and forward all the rest to the
actual implementation.

To demonstrate how I want to use this, I moved the
postAccessibilityNotification method from WebViewHost to WebTestProxy.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Added.
(WebKit):
(WebTestRunner):
(WebTestProxyBase):
(WebTestProxy):
(WebTestRunner::WebTestProxy::WebTestProxy):
(WebTestRunner::WebTestProxy::~WebTestProxy):
(WebTestRunner::WebTestProxy::postAccessibilityNotification):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Added.
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setInterfaces):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::doPostAccessibilityNotification):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::createNewWindow):
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] css3/flexbox/multiline-justify-content.html doesn't crash
commit-queue@webkit.org [Fri, 9 Nov 2012 08:54:16 +0000 (08:54 +0000)]
[EFL] css3/flexbox/multiline-justify-content.html doesn't crash
https://bugs.webkit.org/show_bug.cgi?id=101717

Unreviewed, EFL gardening.

css3/flexbox/multiline-justify-content.html doesn't crash and can be passed.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-09

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix the LLINT build from ARMv7 platform
ossy@webkit.org [Fri, 9 Nov 2012 08:40:10 +0000 (08:40 +0000)]
[Qt] Fix the LLINT build from ARMv7 platform
https://bugs.webkit.org/show_bug.cgi?id=101712

Reviewed by Simon Hausmann.

Enable generating of LLIntAssembly.h on ARM platforms.

* DerivedSources.pri:
* JavaScriptCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build with MSVC fails to use nmake instead of make
hausmann@webkit.org [Fri, 9 Nov 2012 08:36:30 +0000 (08:36 +0000)]
[Qt] Build with MSVC fails to use nmake instead of make
https://bugs.webkit.org/show_bug.cgi?id=98645

Reviewed by Tor Arne Vestbø.

Don't rely on the "default" mkspec but instead query the target
mkspec variable from qmake to find the right qmake.conf.

* Scripts/webkitdirs.pm:
(qtMakeCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Timeline: "Send Request" events are shown out of order.
commit-queue@webkit.org [Fri, 9 Nov 2012 07:45:52 +0000 (07:45 +0000)]
Web Inspector: Timeline: "Send Request" events are shown out of order.
https://bugs.webkit.org/show_bug.cgi?id=101544

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-08
Reviewed by Yury Semikhatsky.

Solution: replace obsolete out-of-order record pushing with frontend
record reparenting.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest): Replaced
direct record pushing with standard appendRecord invokation.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
Made "Send Request" records top-level if gluing is on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134010.
commit-queue@webkit.org [Fri, 9 Nov 2012 07:41:19 +0000 (07:41 +0000)]
Unreviewed, rolling out r134010.
http://trac.webkit.org/changeset/134010
https://bugs.webkit.org/show_bug.cgi?id=101716

Broke the chromium windows build. (Requested by noel_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

Source/WebCore:

* Modules/indexeddb/IDBAny.cpp:
* Modules/indexeddb/IDBCallbacks.h:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::getObjectStoreId):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(WebCore):
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBObjectStoreMetadata::containsIndex):
(WebCore::IDBDatabaseMetadata::findObjectStore):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::containsObjectStore):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::getIndexId):
(WebCore::IDBObjectStoreBackendImpl::getIndexIds):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
(WebCore):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

* src/IDBCallbacksProxy.cpp:
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::transaction):
(WebKit):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::deleteObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::transaction):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::deleteIndex):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
* src/WebIDBTransactionImpl.cpp:
(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):
* src/WebIDBTransactionImpl.h:
* tests/IDBRequestTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add a method to the TextCheckerEnchant class to check whether any dictionary...
g.czajkowski@samsung.com [Fri, 9 Nov 2012 07:34:07 +0000 (07:34 +0000)]
[EFL] Add a method to the TextCheckerEnchant class to check whether any dictionary is loaded
https://bugs.webkit.org/show_bug.cgi?id=101570

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Expose a new method to check whether a vector of loaded languages is empty.
WK2-EFL needs it to set the default language (if the client didn't set any) when
spelling setting is being enabled. This change makes it more convenient to check
whether the dictionaries vector is empty.

No new tests, no behavior change.

* platform/text/enchant/TextCheckerEnchant.cpp:
(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::loadedSpellCheckingLanguages):
A newly exposed method is used internally too.

* platform/text/enchant/TextCheckerEnchant.h:
(WebCore::TextCheckerEnchant::hasDictionary):
Add an inline hasDictionary() method.

Source/WebKit2:

To do not get the vector of loaded languages, WebKit2-EFL calls
TextCheckerEnchant::hasDictionary() method to check whether the
dictionaries vector is empty.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_continuous_spell_checking_enabled_set):
* UIProcess/API/efl/ewk_text_checker.cpp:
(Ewk_Text_Checker::hasDictionary):
(Ewk_Text_Checker):
* UIProcess/API/efl/ewk_text_checker_private.h:
(Ewk_Text_Checker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Remove shadowPseudoId() and use pseudo() instead in TextTrackCue
shinyak@chromium.org [Fri, 9 Nov 2012 07:28:12 +0000 (07:28 +0000)]
[Refactoring] Remove shadowPseudoId() and use pseudo() instead in TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=101702

Reviewed by Hajime Morita.

We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from TextTrackCue and use
setPseudo()/pseudo() instead.

No new tests, simple refactoring.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox):
* html/track/TextTrackCue.h:
(TextTrackCueBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update chromium-mac baselines.
hayato@chromium.org [Fri, 9 Nov 2012 07:23:38 +0000 (07:23 +0000)]
Unreviewed, update chromium-mac baselines.

* platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-layer-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-surface-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Chromium test expectations after r133939.
rniwa@webkit.org [Fri, 9 Nov 2012 07:20:01 +0000 (07:20 +0000)]
Remove Chromium test expectations after r133939.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotable not aligned in center column and seems shrunk because of float:right (table...
commit-queue@webkit.org [Fri, 9 Nov 2012 07:03:41 +0000 (07:03 +0000)]
table not aligned in center column and seems shrunk because of float:right (table-layout: fixed and width: 100%)
https://bugs.webkit.org/show_bug.cgi?id=18153

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-08
Reviewed by Beth Dakin.

Source/WebCore:

Preferred logical width is computed incorrectly for fixed layout tables
with 100% percent width, in standards mode.

According to our fixed table layout algorithm (CSS2 specification - 17.5.2.1)
the ultimate width of the table is the greater of the value of the
'width' property for the table elements and the sum of the column
widths.

For our specific scenario we have a fixed layout table with 100% width
consisting of columns with fixed widths, the sum of which is less than
the specified width of the table (i.e. 100% of the containing block).
Even then the applied width is the cummulative of the width of the
columns.

This happens because of the quirks mode check added in
FixedTableLayout::computePreferredLogicalWidths(), which prohibits the
setting of maxWidth to our fixed layout table with percent width, and
which perhaps is not required anymore.

Test: fast/table/fixed-table-layout/table-with-percent-width.html

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
Removed the quirks mode check.

LayoutTests:

* fast/table/fixed-table-layout/table-with-percent-width-expected.txt: Added.
* fast/table/fixed-table-layout/table-with-percent-width.html: Added.
Test added to verify the width of the fixed layout tables with 100%
width, in standards mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134004.
commit-queue@webkit.org [Fri, 9 Nov 2012 06:54:16 +0000 (06:54 +0000)]
Unreviewed, rolling out r134004.
http://trac.webkit.org/changeset/134004
https://bugs.webkit.org/show_bug.cgi?id=101713

multiple crashes (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAlways use a textured window for the Web Inspector.
timothy@apple.com [Fri, 9 Nov 2012 06:46:47 +0000 (06:46 +0000)]
Always use a textured window for the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=101693

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]): Removed the conditional for a textured window.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Removed the conditional for a textured window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: stop using cursorCoords in CodeMirrorTextEditor
commit-queue@webkit.org [Fri, 9 Nov 2012 06:46:26 +0000 (06:46 +0000)]
Web Inspector: stop using cursorCoords in CodeMirrorTextEditor
https://bugs.webkit.org/show_bug.cgi?id=101607

Patch by Jan Keromnes <janx@linux.com> on 2012-11-08
Reviewed by Vsevolod Vlasov.

API changes completing migration to v3.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype.selection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] about:blank should display the blank page
commit-queue@webkit.org [Fri, 9 Nov 2012 06:39:19 +0000 (06:39 +0000)]
[EFL] about:blank should display the blank page
https://bugs.webkit.org/show_bug.cgi?id=101566

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-08
Reviewed by Laszlo Gombos.

Add a check to return early without prepending http:// scheme, if the
URL is 'about:blank'.

* EWebLauncher/url_utils.c:
(url_from_user_input):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed test expectations update.
noel.gordon@gmail.com [Fri, 9 Nov 2012 06:33:31 +0000 (06:33 +0000)]
[chromium] Unreviewed test expectations update.

Unskip and start generating results for fast/images/color-jpeg-with-color-profile.html
on Win to prepare for an upcoming rebaseline.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make "Other" bar color darker in NMI snapshot.
commit-queue@webkit.org [Fri, 9 Nov 2012 06:30:07 +0000 (06:30 +0000)]
Web Inspector: make "Other" bar color darker in NMI snapshot.
https://bugs.webkit.org/show_bug.cgi?id=101602

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-08
Reviewed by Vsevolod Vlasov.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: switch frontend to use int64_t-based references
alecflett@chromium.org [Fri, 9 Nov 2012 06:27:03 +0000 (06:27 +0000)]
IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426

Reviewed by Tony Chang.

Source/WebCore:

Remove String-based objectStore/index references, obsoleted by
https://bugs.webkit.org/show_bug.cgi?id=100425.

No new tests as this is the second half of a refactor.

* Modules/indexeddb/IDBCallbacks.h:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBObjectStoreMetadata::findIndex):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* inspector/Inspector-1.0.json:
* inspector/Inspector.json:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::InspectorIndexedDBAgent::requestData):
* inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):

Source/WebKit/chromium:

Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425

* src/IDBObjectStoreBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
keishi@webkit.org [Fri, 9 Nov 2012 06:24:13 +0000 (06:24 +0000)]
WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
https://bugs.webkit.org/show_bug.cgi?id=93800

Reviewed by Kent Tamura.

We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close): Set m_closing to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Expose collectFeaturesFromSelector from RuleSet.cpp
shinyak@chromium.org [Fri, 9 Nov 2012 06:17:31 +0000 (06:17 +0000)]
[Refactoring] Expose collectFeaturesFromSelector from RuleSet.cpp
https://bugs.webkit.org/show_bug.cgi?id=101692

Reviewed by Dimitri Glazkov.

We expose collectFeaturesFromSelector in RuleSet.cpp to use it for collecting ShadowDOM select attribute features.

No new tests, simple refactoring.

* css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::collectFeaturesFromSelector): Moved from RuleSet.cpp.
(WebCore):
* css/RuleFeature.h:
(WebCore):
(RuleFeatureSet):
* css/RuleSet.cpp:
(WebCore::collectFeaturesFromRuleData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, Unreviewed gardening following r133972.
hayato@chromium.org [Fri, 9 Nov 2012 06:02:19 +0000 (06:02 +0000)]
Unreviewed, Unreviewed gardening following r133972.

* platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/exif-orientation-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update chromium expectations for svg/repaint/image-with-clip-path.svg.
hayato@chromium.org [Fri, 9 Nov 2012 05:50:35 +0000 (05:50 +0000)]
Unreviewed, update chromium expectations for svg/repaint/image-with-clip-path.svg.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Make jquery/manipulation.html into one in TestExpectations
commit-queue@webkit.org [Fri, 9 Nov 2012 05:42:08 +0000 (05:42 +0000)]
[EFL][WK2] Make jquery/manipulation.html into one in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=101686

Unreviewed, EFL gardening.

Currently there are three definitions on jquery/manipulation.html case.
As BUG 100636 fixed, we don't need Crash definition anymore.
Therefore, this patch makes this case into one definition without Crash in TestExpectations.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-08

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGuard calls to WebKitSystemInterface media control drawing functions in RenderThemeMa...
commit-queue@webkit.org [Fri, 9 Nov 2012 05:02:39 +0000 (05:02 +0000)]
Guard calls to WebKitSystemInterface media control drawing functions in RenderThemeMac with PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=101634

Patch by Robert Sesek <rsesek@chromium.org> on 2012-11-08
Reviewed by Adam Barth.

No new tests, just disabling unused code in Chromium port.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update chromium expectations for tables/.
hayato@chromium.org [Fri, 9 Nov 2012 04:50:44 +0000 (04:50 +0000)]
Unreviewed, update chromium expectations for tables/.

* platform/chromium-mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/core/captions3-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-11-08 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 9 Nov 2012 04:34:22 +0000 (04:34 +0000)]
2012-11-08  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, update chromium-mac-mountainlion baselines for fast/

        Also roll remaining mountainlion-specific failures into the main
        TestExpectations file.

        * platform/chromium/TestExpectations:
        * platform/chromium-mac-mountainlion/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Don't send the messages for releasing resources during purging.
commit-queue@webkit.org [Fri, 9 Nov 2012 04:21:16 +0000 (04:21 +0000)]
Coordinated Graphics: Don't send the messages for releasing resources during purging.
https://bugs.webkit.org/show_bug.cgi?id=101685

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-08
Reviewed by Noam Rosenthal.

We don't need to send the messages related to releasing resources to UI Process
during purging, because UI Process already had removed all resources.
This patch gives us reducing slight messaging overhead and increasing readability.

* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::purgeReleasedImages):
(WebKit::LayerTreeCoordinator::removeTile):
(WebKit::LayerTreeCoordinator::removeUpdateAtlas):
(WebKit::LayerTreeCoordinator::purgeBackingStores):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArrayPrototype.h should have correct indentation
fpizlo@apple.com [Fri, 9 Nov 2012 04:18:29 +0000 (04:18 +0000)]
ArrayPrototype.h should have correct indentation

Rubber stamped by Sam Weinig.

* runtime/ArrayPrototype.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] need to call closePopup at setValueAndClosePopup
commit-queue@webkit.org [Fri, 9 Nov 2012 04:15:30 +0000 (04:15 +0000)]
[BlackBerry] need to call closePopup at setValueAndClosePopup
https://bugs.webkit.org/show_bug.cgi?id=101568

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-11-08
Reviewed by George Staikos.

When early return occurs, we need to call closePopup
at setValueAndClosePopup function. See the comments
in WebCore/page/PagePopupClient.h. If we have not it,
Webkit thread is held and browser will be unresponsive
in BlackBerry port.

RIM PR 232962
Internally reviewed by Charles Wei.

* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::setValueAndClosePopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable calendar picker for input types week/month
keishi@webkit.org [Fri, 9 Nov 2012 03:51:34 +0000 (03:51 +0000)]
Enable calendar picker for input types week/month
https://bugs.webkit.org/show_bug.cgi?id=101553

Reviewed by Kent Tamura.

Source/WebCore:

Enabling calendar picker for <input type=week/month>

No new tests. Tests will be added later in Bug 101556 and Bug 101555.

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker):

LayoutTests:

* platform/chromium/TestExpectations: Mark week/month appearance tests as needs rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Change the default return value of MediaPlayerPrivate::hasSingleSecurity...
commit-queue@webkit.org [Fri, 9 Nov 2012 03:43:36 +0000 (03:43 +0000)]
[BlackBerry] Change the default return value of MediaPlayerPrivate::hasSingleSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=101681

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-11-08
Reviewed by George Staikos.

Since the platform player in BlackBerry disallows resources that come from different origins,
so it's safe to directly returns true here.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update chromium expectations to remove a duplication.
hayato@chromium.org [Fri, 9 Nov 2012 03:36:37 +0000 (03:36 +0000)]
Unreviewed, update chromium expectations to remove a duplication.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenamed ...InlineMethods.h files to ...Inlines.h.
mark.lam@apple.com [Fri, 9 Nov 2012 03:03:44 +0000 (03:03 +0000)]
Renamed ...InlineMethods.h files to ...Inlines.h.
https://bugs.webkit.org/show_bug.cgi?id=101145.

Reviewed by Geoffrey Garen.

This is only a refactoring effort to rename the files. There are no
functionality changes.

Source/JavaScriptCore:

* API/JSObjectRef.cpp:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
* dfg/DFGOperations.cpp:
* heap/ConservativeRoots.cpp:
* heap/CopiedBlock.h:
* heap/CopiedSpace.cpp:
* heap/CopiedSpaceInlineMethods.h: Removed.
* heap/CopiedSpaceInlines.h: Copied from Source/JavaScriptCore/heap/CopiedSpaceInlineMethods.h.
* heap/CopyVisitor.cpp:
* heap/CopyVisitorInlineMethods.h: Removed.
* heap/CopyVisitorInlines.h: Copied from Source/JavaScriptCore/heap/CopyVisitorInlineMethods.h.
* heap/GCThread.cpp:
* heap/GCThreadSharedData.cpp:
* heap/HandleStack.cpp:
* heap/Heap.cpp:
* heap/HeapRootVisitor.h:
* heap/MarkStack.cpp:
* heap/MarkStackInlineMethods.h: Removed.
* heap/MarkStackInlines.h: Copied from Source/JavaScriptCore/heap/MarkStackInlineMethods.h.
* heap/SlotVisitor.cpp:
* heap/SlotVisitor.h:
* heap/SlotVisitorInlineMethods.h: Removed.
* heap/SlotVisitorInlines.h: Copied from Source/JavaScriptCore/heap/SlotVisitorInlineMethods.h.
* jit/HostCallReturnValue.cpp:
* jit/JIT.cpp:
* jit/JITArithmetic.cpp:
* jit/JITArithmetic32_64.cpp:
* jit/JITCall.cpp:
* jit/JITCall32_64.cpp:
* jit/JITInlineMethods.h: Removed.
* jit/JITInlines.h: Copied from Source/JavaScriptCore/jit/JITInlineMethods.h.
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
* jsc.cpp:
* runtime/ArrayConstructor.cpp:
* runtime/ArrayPrototype.cpp:
* runtime/ButterflyInlineMethods.h: Removed.
* runtime/ButterflyInlines.h: Copied from Source/JavaScriptCore/runtime/ButterflyInlineMethods.h.
* runtime/IndexingHeaderInlineMethods.h: Removed.
* runtime/IndexingHeaderInlines.h: Copied from Source/JavaScriptCore/runtime/IndexingHeaderInlineMethods.h.
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
* runtime/JSArray.h:
* runtime/JSCell.h:
* runtime/JSObject.cpp:
* runtime/JSValueInlineMethods.h: Removed.
* runtime/JSValueInlines.h: Copied from Source/JavaScriptCore/runtime/JSValueInlineMethods.h.
* runtime/LiteralParser.cpp:
* runtime/ObjectConstructor.cpp:
* runtime/Operations.h:
* runtime/RegExpMatchesArray.cpp:
* runtime/RegExpObject.cpp:
* runtime/StringPrototype.cpp:

Source/WebCore:

No new tests.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/HTMLEntityParser.cpp:
* html/parser/HTMLTokenizer.cpp:
* html/track/WebVTTTokenizer.cpp:
* xml/parser/CharacterReferenceParserInlineMethods.h: Removed.
* xml/parser/CharacterReferenceParserInlines.h: Copied from Source/WebCore/xml/parser/CharacterReferenceParserInlineMethods.h.
* xml/parser/MarkupTokenizerInlineMethods.h: Removed.
* xml/parser/MarkupTokenizerInlines.h: Copied from Source/WebCore/xml/parser/MarkupTokenizerInlineMethods.h.
* xml/parser/XMLCharacterReferenceParser.cpp:
* xml/parser/XMLTokenizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r133984.
commit-queue@webkit.org [Fri, 9 Nov 2012 02:52:21 +0000 (02:52 +0000)]
Unreviewed, rolling out r133984.
http://trac.webkit.org/changeset/133984
https://bugs.webkit.org/show_bug.cgi?id=101684

windows build error. (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

Source/WebCore:

* Modules/indexeddb/IDBCallbacks.h:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::getObjectStoreId):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBObjectStoreMetadata::containsIndex):
(WebCore::IDBDatabaseMetadata::findObjectStore):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::containsObjectStore):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::getIndexId):
(WebCore::IDBObjectStoreBackendImpl::getIndexIds):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::deleteObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::transaction):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::deleteIndex):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
* src/WebIDBTransactionImpl.cpp:
(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):
* src/WebIDBTransactionImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[QT] css3/line-break should be removed from TestExpectations.
commit-queue@webkit.org [Fri, 9 Nov 2012 02:49:12 +0000 (02:49 +0000)]
[QT] css3/line-break should be removed from TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=101562

Unreviewed gardening.

css3/line-break is removed by http://trac.webkit.org/changeset/133644.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-08

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLContentElement should preserve parsed CSSSelectorList
shinyak@chromium.org [Fri, 9 Nov 2012 02:40:25 +0000 (02:40 +0000)]
HTMLContentElement should preserve parsed CSSSelectorList
https://bugs.webkit.org/show_bug.cgi?id=101543

Reviewed by Dimitri Glazkov.

We would like to preserve CSSSelectorList for select attribute of HTMLContentElement.

Before, we parsed and validated select attribute every time distribution happens. If we preserve the parsed
CSSSelectorList, we can reduce distribution time.

This is also a prepration patch for Bug 101180. It also needs the parsed CSSSelectorList. We don't want to
parse and validate it again.

No new tests, covered by exising tests.

* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery): We don't parse select attribute here anymore.
if it's already parsed.
(WebCore::ContentSelectorQuery::matches):
* html/shadow/ContentSelectorQuery.h:
(ContentSelectorQuery):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::isSelectValid):
(WebCore::HTMLContentElement::ensureSelectParsed): If we don't have parsed the current select attribute,
we parse and validate it.
(WebCore::HTMLContentElement::parseAttribute): When select attribute is changed, we have to have a flag enabled
to parse select attrite again.
(WebCore::validateSubSelector): Moved from ContentSelectorQuery.
(WebCore):
(WebCore::validateSelector): Moved from ContentSelectorQuery.
(WebCore::HTMLContentElement::validateSelect):
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
(WebCore::HTMLContentElement::setSelect):
(WebCore):
(WebCore::HTMLContentElement::selectorList):
* html/shadow/HTMLShadowElement.cpp:
(WebCore::HTMLShadowElement::emptySelectorList):
(WebCore):
* html/shadow/HTMLShadowElement.h:
(HTMLShadowElement):
(WebCore::HTMLShadowElement::selectorList):
* html/shadow/InsertionPoint.h:
(InsertionPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArrayConstructor.h should have correct indentation
fpizlo@apple.com [Fri, 9 Nov 2012 02:04:37 +0000 (02:04 +0000)]
ArrayConstructor.h should have correct indentation

Rubber stamped by Sam Weinig.

* runtime/ArrayConstructor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should know that int == null is always false
fpizlo@apple.com [Fri, 9 Nov 2012 01:57:14 +0000 (01:57 +0000)]
DFG should know that int == null is always false
https://bugs.webkit.org/show_bug.cgi?id=101665

Reviewed by Oliver Hunt.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update chromium expectations for chromium-mac-mountainlion svg failure.
dpranke@chromium.org [Fri, 9 Nov 2012 01:54:57 +0000 (01:54 +0000)]
Unreviewed, update chromium expectations for chromium-mac-mountainlion svg failure.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, chromium-mac-mountainlion baselines for tables/.
dpranke@chromium.org [Fri, 9 Nov 2012 01:49:15 +0000 (01:49 +0000)]
Unreviewed, chromium-mac-mountainlion baselines for tables/.

* platform/chromium/TestExpectations:
* platform/chromium-mac-mountainlion/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArguments.h should have correct indentation
fpizlo@apple.com [Fri, 9 Nov 2012 01:42:16 +0000 (01:42 +0000)]
Arguments.h should have correct indentation

Rubber stamped by Sam Weinig.

* runtime/Arguments.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening following r133972.
jsbell@chromium.org [Fri, 9 Nov 2012 01:41:00 +0000 (01:41 +0000)]
[Chromium] Unreviewed gardening following r133972.

* platform/chromium-win/platform/chromium/virtual/deferred/fast/images/exif-orientation-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIt should be possible to JIT compile get_by_vals and put_by_vals even if the DFG...
fpizlo@apple.com [Fri, 9 Nov 2012 01:38:12 +0000 (01:38 +0000)]
It should be possible to JIT compile get_by_vals and put_by_vals even if the DFG is disabled.

Reviewed by Oliver Hunt.

* jit/JITInlineMethods.h:
(JSC::JIT::chooseArrayMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: switch frontend to use int64_t-based references
alecflett@chromium.org [Fri, 9 Nov 2012 01:36:04 +0000 (01:36 +0000)]
IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426

Reviewed by Tony Chang.

Source/WebCore:

Remove String-based objectStore/index references, obsoleted by
https://bugs.webkit.org/show_bug.cgi?id=100425.

No new tests as this is the second half of a refactor.

* Modules/indexeddb/IDBCallbacks.h:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBObjectStoreMetadata::findIndex):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* inspector/Inspector-1.0.json:
* inspector/Inspector.json:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::InspectorIndexedDBAgent::requestData):
* inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):

Source/WebKit/chromium:

Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425

* src/IDBObjectStoreBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Arabic digits should appear left-to-right
bashi@chromium.org [Fri, 9 Nov 2012 01:34:15 +0000 (01:34 +0000)]
[Chromium] Arabic digits should appear left-to-right
https://bugs.webkit.org/show_bug.cgi?id=101440

Reviewed by Tony Chang.

Source/WebCore:

Call hb_buffer_set_direction() to set direction when drawing glyphs or
direction should be overridden. Leave direction setting to HarfBuzz when
WebKit is calculating widths because the direction is LTR by default while
calculating widths.  Set script before shaping so that HarfBuzz can estimate
appropriate direction.

Test: fast/text/international/arabic-digits.html

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
Add m_script. This holds the script of the run.
(WebCore::HarfBuzzShaper::shape):
Tell shapeHarfBuzzRuns() to set direction when drawing glyphs or
direction should be overridden.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
Set script of HarfBuzzRuns.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
Add an argument that indicates it should set direction.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
(WebCore::HarfBuzzShaper::HarfBuzzRun::script):
(HarfBuzzRun):
(HarfBuzzShaper):

LayoutTests:

Add a test that checks Arabic digits appear in increasing order from left to right.

* fast/text/international/arabic-digits-expected.html: Added.
* fast/text/international/arabic-digits.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] WebElement::hasHTMLTagName returns true for non-HTML elements
tkent@chromium.org [Fri, 9 Nov 2012 01:33:26 +0000 (01:33 +0000)]
[Chromium] WebElement::hasHTMLTagName returns true for non-HTML elements
https://bugs.webkit.org/show_bug.cgi?id=101537

Reviewed by Abhishek Arya.

We should not do ignore-case comparison for tagName, which is always
upper-case and createElementNS(xhtmlNS, "INPUT") doesn't create an
HTMLInputElement object. We need to check if localName is equal to
"input" in this case.

* src/WebElement.cpp:
(WebKit::WebElement::hasHTMLTagName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TexMap] Remove contentsLayer() in GraphicsLayerTextureMapper.
commit-queue@webkit.org [Fri, 9 Nov 2012 01:31:33 +0000 (01:31 +0000)]
[TexMap] Remove contentsLayer() in GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=101658

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-08
Reviewed by Noam Rosenthal.

GraphicsLayerTextureMapper::contentsLayer() is duplicated to
GraphicsLayer::platformLayer(), so we remove it.

No new tests, this is just a refactor.

* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::platformLayer):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoop_call should have LLInt call link info even if the DFG is disabled
fpizlo@apple.com [Fri, 9 Nov 2012 01:27:25 +0000 (01:27 +0000)]
op_call should have LLInt call link info even if the DFG is disabled
https://bugs.webkit.org/show_bug.cgi?id=101672

Reviewed by Oliver Hunt.

Get rid of the evil uses of fall-through.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133980 268f45cc-cd09-0410-ab3c-d52691b4dbfc