WebKit-https.git
7 years ago[Chromium] Unreviewed gardening: updated Win results for 125160.
fmalita@chromium.org [Thu, 9 Aug 2012 16:11:04 +0000 (16:11 +0000)]
[Chromium] Unreviewed gardening: updated Win results for 125160.

Patch by Florin Malita <fmalita@chromium.org> on 2012-08-09

* platform/chromium-win/svg/custom/use-detach-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/12035637> 32-bit PluginProcess launches without appropriate DYLD...
mitz@apple.com [Thu, 9 Aug 2012 16:10:45 +0000 (16:10 +0000)]
<rdar://problem/12035637> 32-bit PluginProcess launches without appropriate DYLD environment variables if UI process is 64-bit only
https://bugs.webkit.org/show_bug.cgi?id=93596

Reviewed by Mark Rowe.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Changed to pass the current architecture, rather than
the intended child process architecture, to the DynamicLinkerEnvironmentExtractor constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening: updated results for 125167.
fmalita@chromium.org [Thu, 9 Aug 2012 15:49:58 +0000 (15:49 +0000)]
[Chromium] Unreviewed gardening: updated results for 125167.

Patch by Florin Malita <fmalita@chromium.org> on 2012-08-09

* platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
* platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-08-09 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 9 Aug 2012 15:13:56 +0000 (15:13 +0000)]
2012-08-09  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: generate preview for the objects dumped into the console upon logging.
        https://bugs.webkit.org/show_bug.cgi?id=35801

        Reviewed by Vsevolod Vlasov.

        As of today, dumping an object (array) into console will result in objects' properties being
        read upon console object expansion (i.e. lazily). This means that dumping the same object while
        mutating it will be hard to debug using the console.

        This change starts generating abbreviated previews for objects / arrays at the moment of their
        logging and passes this information along into the front-end. This only happens when the front-end
        is already opened, it only works for console.log(), not live console interaction.

        Covered by the existing console tests + collections test has been expanded to capture both: pre and post-

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/ConsoleMessage.h:
        (ConsoleMessage):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::wrapObject):
        * inspector/InjectedScript.h:
        (InjectedScript):
        * inspector/InjectedScriptSource.js:
        (.):
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::enable):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/front-end/ConsoleMessage.js:
        (WebInspector.ConsoleMessageImpl.prototype._format):
        (WebInspector.ConsoleMessageImpl.prototype._formatParameter):
        (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
        (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArrayOrObject):
        (WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
        (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
        (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
        (WebInspector.ConsoleMessageImpl.prototype._printArray):
        (WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
        (WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
        * inspector/front-end/DOMExtension.js:
        (Element.prototype.createTextChild):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection):
        * inspector/front-end/PropertiesSection.js:
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject):
        (WebInspector.RemoteObject.fromPayload):
        (WebInspector.RemoteObject.prototype.get preview):
        * inspector/front-end/Section.js:
        * inspector/front-end/inspector.css:
        (.console-group-messages .section .header .title):
        (.section .console-formatted-node):
        (.console-object-preview):
        (.section .properties .name, .event-properties .name, .console-formatted-object .name):

2012-08-09  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: generate preview for the objects dumped into the console upon logging.
        https://bugs.webkit.org/show_bug.cgi?id=35801

        Reviewed by Vsevolod Vlasov.

        * inspector/console/command-line-api-inspect-expected.txt:
        * inspector/console/console-dir-expected.txt:
        * inspector/console/console-eval-global-expected.txt:
        * inspector/console/console-eval-global.html:
        * inspector/console/console-format-collections-expected.txt:
        * inspector/console/console-format-collections.html:
        * inspector/console/console-format-expected.txt:
        * inspector/console/console-format.html:
        * inspector/console/console-log-document-proto-expected.txt:
        * inspector/console/console-log-document-proto.html:
        * inspector/console/console-log-toString-object-expected.txt:
        * inspector/debugger/watch-expressions-panel-switch-expected.txt:
        * inspector/elements/event-listener-sidebar-expected.txt:
        * inspector/elements/event-listeners-about-blank-expected.txt:
        * platform/chromium/inspector/console/console-dir-expected.txt:
        * platform/chromium/inspector/console/console-eval-global-expected.txt: Removed.
        * platform/chromium/inspector/console/console-format-collections-expected.txt:
        * platform/chromium/inspector/console/console-format-expected.txt: Removed.
        * platform/chromium/inspector/console/console-log-document-proto-expected.txt:
        * platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt:
        * platform/chromium/inspector/elements/event-listener-sidebar-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r125171.
peter@chromium.org [Thu, 9 Aug 2012 15:05:18 +0000 (15:05 +0000)]
Unreviewed, rolling out r125171.
http://trac.webkit.org/changeset/125171

Broke the Chromium Android build.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Thu, 9 Aug 2012 14:17:17 +0000 (14:17 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/fast/js/global-constructors-expected.txt:
* platform/qt/Skipped:
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/qt/fast/events/keyevent-iframe-removed-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 9 Aug 2012 14:05:45 +0000 (14:05 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update TestExpectations with one more test to rebase after r125167
allan.jensen@nokia.com [Thu, 9 Aug 2012 14:03:31 +0000 (14:03 +0000)]
Unreviewed, update TestExpectations with one more test to rebase after r125167

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPage popups can show up at wrong locations
keishi@webkit.org [Thu, 9 Aug 2012 12:43:21 +0000 (12:43 +0000)]
Page popups can show up at wrong locations
https://bugs.webkit.org/show_bug.cgi?id=93556

Reviewed by Kent Tamura.

Source/WebCore:

No new tests. Cannot test popup position.

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):

Source/WebKit/chromium:

We were showing the popup at wrong positions. When there isn't enough
room below and above the element it adjusts the position but we weren't
resetting the adjustment when we resize the popup. This patch will make
the popup adjust the popup position each time we resize.

* src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::contentSize):
* src/WebPagePopupImpl.cpp:
(WevKit::PagePopupChromeClient::setWindowRect):
(WebKit::WebPagePopupImpl::init): Use reposition().
(WebKit::WebPagePopupImpl::reposition): Repositions the page popup based on the popup size.
(WebKit):
(WebKit::WebPagePopupImpl::resize): Use reposition().
* src/WebPagePopupImpl.h:
(WebPagePopupImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: display progress bar while loading timeline data
caseq@chromium.org [Thu, 9 Aug 2012 12:24:47 +0000 (12:24 +0000)]
Web Inspector: display progress bar while loading timeline data
https://bugs.webkit.org/show_bug.cgi?id=92762

Reviewed by Pavel Feldman.

Source/WebCore:

- display progress while loading timeline data;
- disable status bar buttons while operation is in progress;
- ignore save/load/record while operation is in progress;
- disable context menu items while operation is in progress;
- misc. compilation warning fixes;

* inspector/front-end/ProgressBar.js:
(WebInspector.CompositeProgress.prototype.createSubProgress):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype.loadFromFile.parseAndImportData):
(WebInspector.TimelineModel.prototype.loadFromFile.onLoad):
(WebInspector.TimelineModel.prototype.loadFromFile.onError):
(WebInspector.TimelineModel.prototype.loadFromFile.onProgress):
(WebInspector.TimelineModel.prototype.loadFromFile):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusBarItems):
(WebInspector.TimelinePanel.prototype._setOperationInProgress):
(WebInspector.TimelinePanel.prototype._contextMenu):
(WebInspector.TimelinePanel.prototype._saveToFile):
(WebInspector.TimelinePanel.prototype._loadFromFile):
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):
(WebInspector.TimelinePanel.prototype.sidebarResized):
* inspector/front-end/utilities.js: added Array.prototype.select(field) to map array of objects to array containing particular field of each object.

LayoutTests:

- fix loading tests to pass mock progress indicator;

* inspector/timeline/timeline-load-incompatible.html:
* inspector/timeline/timeline-load.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFloored and truncated rounded confused.
allan.jensen@nokia.com [Thu, 9 Aug 2012 12:20:30 +0000 (12:20 +0000)]
Floored and truncated rounded confused.
https://bugs.webkit.org/show_bug.cgi?id=93475

Reviewed by Levi Weintraub.

Source/WebCore:

Fix the common mistake of confusing truncating (round towards zero) and
flooring (round down). They are only identical for positive numbers,
not for negative numbers.

This patch fixes instances of misimplemented or misused floor in the
layout and geometric code. And also uses the new correct implementations
to clean up the code for enclosingRect.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::fromFloatFloor):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::floor):
* platform/graphics/FloatPoint.h:
(WebCore::FloatPoint::FloatPoint):
(WebCore::roundedIntPoint):
(WebCore::flooredIntPoint):
(WebCore::ceiledIntPoint):
(WebCore::flooredIntSize):
* platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRect):
(WebCore::enclosedIntRect):
* platform/graphics/FloatSize.h:
(WebCore::roundedIntSize):
(WebCore::flooredIntSize):
(WebCore::flooredIntPoint):
* platform/graphics/FractionalLayoutPoint.h:
(WebCore::flooredIntPoint):
(WebCore::flooredFractionalLayoutPoint):
(WebCore::ceiledFractionalLayoutPoint):
* platform/graphics/FractionalLayoutRect.cpp:
(WebCore::enclosingIntRect):
(WebCore::enclosingFractionalLayoutRect):
* platform/graphics/FractionalLayoutSize.h:
(WebCore::flooredIntSize):
* platform/graphics/IntRect.cpp:
(WebCore::IntRect::IntRect):
* rendering/LayoutTypes.h:
(WebCore::flooredLayoutPoint):
(WebCore::floorToInt):
(WebCore::isIntegerValue):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToLayerCoords):

LayoutTests:

* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: use WebInspector.ProgressIndicator in AdvancedSearchController
caseq@chromium.org [Thu, 9 Aug 2012 12:18:18 +0000 (12:18 +0000)]
Web Inspector: use WebInspector.ProgressIndicator in AdvancedSearchController
https://bugs.webkit.org/show_bug.cgi?id=93362

Reviewed by Vsevolod Vlasov.

- drop custom status bar used in AdvancedSearchController, use WebInspector.ProgressIndicator;
- perform additional cancelation check after invoking searchResultCallback to account for stopSearch called from within callback;
- fix compilation warnings in ProgressBar;

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._onCancel):
* inspector/front-end/ProgressBar.js:
(WebInspector.CompositeProgress.prototype.createSubProgress):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
* inspector/front-end/inspector.css:
(.progress-bar-container progress):
(body.platform-mac .progress-bar-container progress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: improve large array logging experience
pfeldman@chromium.org [Thu, 9 Aug 2012 12:08:49 +0000 (12:08 +0000)]
Web Inspector: improve large array logging experience
https://bugs.webkit.org/show_bug.cgi?id=93499

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Group elements in chunks of 100, not smaller.

* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.FunctionScopeMainTreeElement):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
(WebInspector.ArrayGroupingTreeElement._populateRanges):

LayoutTests:

* inspector/console/console-big-array-expected.txt:
* inspector/console/console-big-array.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Pull in the android_tools directory for Android
peter@chromium.org [Thu, 9 Aug 2012 11:34:52 +0000 (11:34 +0000)]
[Chromium] Pull in the android_tools directory for Android
https://bugs.webkit.org/show_bug.cgi?id=84843

Reviewed by Jochen Eisinger.

Pull in the android_tools directory for Chromium Android checkouts. This
repository, living in Chromium's, contains checked in versions of the
Android NDK and SDK meant to make builds and updates easier.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Build system bug revealed by r124835
ossy@webkit.org [Thu, 9 Aug 2012 11:00:56 +0000 (11:00 +0000)]
[Qt][Win] Build system bug revealed by r124835
https://bugs.webkit.org/show_bug.cgi?id=93339

Reviewed by Tor Arne Vestbø.

Don't add "LC_ALL=c" on Windows in svnRevisionForDirectory() and in pathRelativeToSVNRepositoryRootForPath().

* Scripts/VCSUtils.pm:
(isWindows): Copied from webkitdirs.pm.
(svnRevisionForDirectory):
(pathRelativeToSVNRepositoryRootForPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDOMCharacterDataModified should not be fired inside shadows
morrita@google.com [Thu, 9 Aug 2012 08:16:54 +0000 (08:16 +0000)]
DOMCharacterDataModified should not be fired inside shadows
https://bugs.webkit.org/show_bug.cgi?id=93427

Reviewed by Ryosuke Niwa.

Source/WebCore:

CharacterData::dispatchModifiedEvent() fires DOMCharacterDataModified event even if
the node is in shadow. But it shouldn't. Check dispatchChildInsertionEvents() and
dispatchChildRemovalEvents() to see how other MutationEvents are suppressed behind shadows.
This change follows the same path to suppress DOMCharacterDataModified.

Tests: fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata.html
       fast/forms/textarea-and-mutation-events-appending-text.html

* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

Added two tests. This also fixes existing test, which cover the wrong behavior.

* fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata-expected.txt: Added.
* fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata.html: Added.
* fast/events/dom-character-data-modified-textarea-crash.html:
- DOMCharacterDataModified shouldn't be fired in this case.
  Fixed to allow test to terminate without the event.
  Note that The event was fired by <textarea>, which is fixed by this change.
* fast/forms/textarea-and-mutation-events-appending-text-expected.txt: Added.
* fast/forms/textarea-and-mutation-events-appending-text.html: Added.
* svg/custom/tref-nested-events-crash.svg:
- DOMCharacterDataModified shouldn't be fired in this case.
  Fixed to allow test to terminate without the event.
  Note that The event was fired by SVGShadowText, which is just an implentation detail and
  should not be exposed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update TestExpectations for chromium gardening.
toyoshim@chromium.org [Thu, 9 Aug 2012 08:09:23 +0000 (08:09 +0000)]
Unreviewed, update TestExpectations for chromium gardening.
https://bugs.webkit.org/show_bug.cgi?id=93589

Mark svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg as slow for Mac10.6 (dbg).

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-09

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse m_everHadLayout in RenderObject::checkForRepaintDuringLayout()
eric@webkit.org [Thu, 9 Aug 2012 07:58:50 +0000 (07:58 +0000)]
Use m_everHadLayout in RenderObject::checkForRepaintDuringLayout()
https://bugs.webkit.org/show_bug.cgi?id=20885

Reviewed by Dan Bernstein.

Source/WebCore:

Fix FIXME in checkForRepaintDuringLayout, making RenderObjects
no longer paint on first layout, but instead require their
parent containers to paint them.
This appears to have fixed one minor SVG overpainting issue
in svg/use-detach-expected.png.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::checkForRepaintDuringLayout):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):

LayoutTests:

Updated result.  Appears to be a progression.  I suspect
we were over-drawing the <g> container before and now we're
just drawing the two objects which change.

* platform/chromium-mac/svg/custom/use-detach-expected.png:
* platform/chromium-linux/svg/custom/use-detach-expected.png:
* platform/mac/svg/custom/use-detach-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMicrodata: PropertyNodeList cache should be invalidated on id attribute change.
arko@motorola.com [Thu, 9 Aug 2012 07:47:55 +0000 (07:47 +0000)]
Microdata: PropertyNodeList cache should be invalidated on id attribute change.
https://bugs.webkit.org/show_bug.cgi?id=93485

Reviewed by Ryosuke Niwa.

Source/WebCore:

Invalidate PropertyNodeList cache when id attribute of an element changed/modified.

Test: fast/dom/MicroData/propertiescollection-on-changing-id-attr.html

* dom/DynamicNodeList.cpp: Moved ownerNodeHasItemRefAttribute() method to DynamicNodeList.h
(WebCore):
* dom/DynamicNodeList.h:
(WebCore):
(WebCore::DynamicNodeListCacheBase::isRootedAtDocument): Return true if owner has itemref
attribute specified with root type NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr.
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange): Return true if
attrName is id attribute in case of InvalidateOnItemAttrChange.
(WebCore::DynamicNodeListCacheBase::ownerNodeHasItemRefAttribute):

LayoutTests:

Added test to verify HTMLPropertiesCollection and PropertyNodeList interfaces
behavior on changing id attribute.

* fast/dom/MicroData/propertiescollection-on-changing-id-attr-expected.txt: Added.
* fast/dom/MicroData/propertiescollection-on-changing-id-attr.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, TestExpectations update for a newly added test
toyoshim@chromium.org [Thu, 9 Aug 2012 07:45:07 +0000 (07:45 +0000)]
Unreviewed, TestExpectations update for a newly added test
https://bugs.webkit.org/show_bug.cgi?id=93586

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-09

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMicrodata: HTMLPropertiesCollection does not contain all properties when item is...
arko@motorola.com [Thu, 9 Aug 2012 07:28:14 +0000 (07:28 +0000)]
Microdata: HTMLPropertiesCollection does not contain all properties when item is not attached to the DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=93456

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLPropertiesCollection does not contain the item properties added through
itemref attribute when item is not attached to the DOM tree. We need to
find the root node of the item if its not attached in the document.

It is also possible that itemref attribute of item refers to the root node.
Made changes in getItemRefElements() method so that the traversal should
start from the root node.

Tests: fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree.html
       fast/dom/MicroData/item-not-attached-to-domtree.html
       fast/dom/MicroData/itemref-pointing-to-root-node.html

* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeListCacheBase::rootNode):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::getItemRefElements):

LayoutTests:

Added tests to ensure that HTMLPropertiesCollection contains all item properties
when item is not attached to the DOM tree.

* fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree-expected.txt: Added.
* fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree.html: Added.
* fast/dom/MicroData/item-not-attached-to-domtree-expected.txt: Added.
* fast/dom/MicroData/item-not-attached-to-domtree.html: Added.
* fast/dom/MicroData/itemref-pointing-to-root-node-expected.txt: Added.
* fast/dom/MicroData/itemref-pointing-to-root-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd optional debug logging for tiled scrolling
timothy_horton@apple.com [Thu, 9 Aug 2012 07:26:35 +0000 (07:26 +0000)]
Add optional debug logging for tiled scrolling
https://bugs.webkit.org/show_bug.cgi?id=93305

Reviewed by Simon Fraser.

Add scrolling performance logging to ScrollingTreeNodeMac and WebTileLayer, which will log
the amount of unpainted area exposed during scrolling and painting, respectively.

The logging output looks like this:

    SCROLLING: Exposed tileless area. Time: 1344464850.154839 Unfilled Pixels: 1122008
    SCROLLING: Filled visible fresh tile. Time: 1344464850.575303 Unfilled Pixels: 1078272
    SCROLLING: Filled visible fresh tile. Time: 1344464850.676569 Unfilled Pixels: 823808
    SCROLLING: Filled visible fresh tile. Time: 1344464850.795877 Unfilled Pixels: 569344
    SCROLLING: Filled visible fresh tile. Time: 1344464850.846940 Unfilled Pixels: 524288
    SCROLLING: Filled visible fresh tile. Time: 1344464850.984113 Unfilled Pixels: 262144
    SCROLLING: Filled visible fresh tile. Time: 1344464851.027985 Unfilled Pixels: 0

No new tests, as this is just debugging logging.

* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::setScrollingPerformanceLoggingEnabled):
Added setScrollingPerformanceLoggingEnabled, passes flag into TiledBacking.

* page/FrameView.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setScrollingPerformanceLoggingEnabled):
Added setScrollingPerformanceLoggingEnabled, passes flag into FrameView.

* page/Settings.h:
(WebCore::Settings::scrollingPerformanceLoggingEnabled):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::setScrollingPerformanceLoggingEnabled):
(WebCore::ScrollingTree::scrollingPeformanceLoggingEnabled):
Added ScrollingPerformanceLoggingEnabled setter/getter; this is where it's accessed from ScrollingTreeNodeMac.

* page/scrolling/ScrollingTree.h:
* page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
When updating scroll position, conditionally log the amount of unpainted area that was just exposed.

(WebCore::ScrollingTreeNodeMac::logExposedTilelessArea):
* platform/graphics/TiledBacking.h:
(WebCore::TiledBacking::TiledBacking):
(WebCore::TiledBacking::setScrollingPerformanceLoggingEnabled):
(WebCore::TiledBacking::scrollingPerformanceLoggingEnabled):
Added ScrollingPerformanceLoggingEnabled setter/getter; this is where it's accessed from WebTileLayer.

* platform/graphics/ca/mac/TileCache.h:
(WebCore::TileCache::visibleRect):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::blankPixelCount):
(WebCore::TileCache::blankPixelCountForTiles):
Compute the exposed, unpainted area of the tile cache by iterating over the layers,
checking if they've been painted, and subtracting painted layers from the total visible area.

* platform/graphics/ca/mac/WebTileLayer.h:
* platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer drawInContext:]):
(-[WebTileLayer repaintCount]):
(-[WebTileLayer logFilledFreshTile]):
When painting a WebTileLayer, conditionally log the amount of unpainted area remaining after painting said tile.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
Plumb ScrollingPerformanceLoggingEnabled through to TiledBacking.

Add a new boolean preference, ScrollingPerformanceLoggingEnabled, which will be used to toggle
the WebCore parts of this change.

* Shared/WebPreferencesStore.h: Add ScrollingPerformanceLoggingEnabled.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetScrollingPerformanceLoggingEnabled): Added.
(WKPreferencesGetScrollingPerformanceLoggingEnabled): Added.
* UIProcess/API/C/WKPreferencesPrivate.h: Add getters and setters for ScrollingPerformanceLoggingEnabled.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Add ScrollingPerformanceLoggingEnabled.
(WebKit::WebPage::updatePreferences): Add ScrollingPerformanceLoggingEnabled.
(WebKit::WebPage::setScrollingPerformanceLoggingEnabled): Propagate settings changes through to FrameView.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::scrollingPerformanceLoggingEnabled): Add a getter for the setting so that TiledCoreAnimationDrawingArea can access it.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences): Pass ScrollingPerformanceLoggingEnabled down into the scrolling thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Remove image decoding in some BitmapImage metadata functions
hclam@chromium.org [Thu, 9 Aug 2012 06:23:42 +0000 (06:23 +0000)]
Source/WebCore: Remove image decoding in some BitmapImage metadata functions
https://bugs.webkit.org/show_bug.cgi?id=93171

Reviewed by Simon Fraser.

These two metadata functions were decoding an entire frame:
- frameOrientationAtIndex
- frameHasAlphaAtIndex

This change removes image decoding from these two methods. This is for
preparation of having asynchronous image decoding, intending to reduce
code location that trigger image decoding.

frameOrientationAtIndex() doesn't require decoding a frame. This method
is only implemented in CG port in ImageSourceCG.cpp which doesn't do
image decoding.

frameHasAlphaAtIndex() is used to optimize certain drawing operations
and accelerated compositing. This change uses a heuristic for non-CG
port to determine if an image has alpha. If an image is not yet
decoded the function answers having alpha. Only if a frame is decoded
and cached that the alpha state of the frame is returned. This is an
admissible heuristic that postpone answering the question until a frame
is decoded.

Tested this change with a fully loaded image and partially loaded image
with background color.

Test: http/tests/images/jpg-img-partial-load.html

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameHasAlphaAtIndex):
(WebCore::BitmapImage::frameOrientationAtIndex):
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::frameHasAlphaAtIndex):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::frameHasAlphaAtIndex):
(WebCore):
* platform/image-decoders/ImageDecoder.h:
(ImageDecoder):

LayoutTests: Test rendering JPEG <img> with CSS background
https://bugs.webkit.org/show_bug.cgi?id=93171

Reviewed by Simon Fraser.

Tests defer answering the alpha state for BitmapImage not yet
decoded doesn't affect rendering results.

Test: http/tests/images/jpg-img-partial-load.html

Tests the rendering results of a partially loaded JPEG image.
The image should be green in the top region and blue in the
lower region. The blue is the background color revealed by
full alpha of the undecoded region.

* fast/images/resources/green-256x256.jpg: Added.
* http/tests/images/jpg-img-partial-load-expected.png: Added.
* http/tests/images/jpg-img-partial-load-expected.txt: Added.
* http/tests/images/jpg-img-partial-load.html: Added.
* http/tests/resources/load-and-stall.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoupdate bot parsing of new-run-webkit-tests' output
ossy@webkit.org [Thu, 9 Aug 2012 05:50:24 +0000 (05:50 +0000)]
update bot parsing of new-run-webkit-tests' output
https://bugs.webkit.org/show_bug.cgi?id=93537

Patch by Dirk Pranke <dpranke@chromium.org> on 2012-08-08
Reviewed by Ryosuke Niwa.

This change updates the way we parse the output from
new-run-webkit-tests on the bots so that we can show a summary
of the results properly after I re-land the changes that were
reverted in r124994 and r124870.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests._parseNewRunWebKitTestsOutput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r125146.
commit-queue@webkit.org [Thu, 9 Aug 2012 05:29:22 +0000 (05:29 +0000)]
Unreviewed, rolling out r125146.
http://trac.webkit.org/changeset/125146
https://bugs.webkit.org/show_bug.cgi?id=93578

Would like to study fast/dom/Window/timer-null-script-
execution-context.html behavior change (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-08

* bindings/js/JSDOMWindowBase.cpp:
(WebCore):
(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
(WebCore::JSDOMWindowBase::allowsAccessFrom):
* bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineOwnProperty):
(WebCore::JSDOMWindow::setLocation):
* bindings/js/JSDOMWindowCustom.h:
(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):
(WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
(WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _isSafeScript]):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip CoreAnimation plugin model tests on android
commit-queue@webkit.org [Thu, 9 Aug 2012 05:27:30 +0000 (05:27 +0000)]
Skip CoreAnimation plugin model tests on android
https://bugs.webkit.org/show_bug.cgi?id=90586

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-08-08
Reviewed by Adam Barth.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip platform/mac/editing/deleting/backward-delete.html on android
commit-queue@webkit.org [Thu, 9 Aug 2012 05:21:27 +0000 (05:21 +0000)]
Skip platform/mac/editing/deleting/backward-delete.html on android
https://bugs.webkit.org/show_bug.cgi?id=90585

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-08-08
Reviewed by Adam Barth.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnprefix window.webkitURL
kinuko@chromium.org [Thu, 9 Aug 2012 04:49:51 +0000 (04:49 +0000)]
Unprefix window.webkitURL
https://bugs.webkit.org/show_bug.cgi?id=93034

Reviewed by Jian Li.

Adding unprefixed window.URL as other browsers like FireFox and Opera 12 seem to have the API unprefixed.
(This patch doesn't remove webkitURL yet as Safari and Chrome has exposed the URL for a while now.)

Source/WebCore:

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html

* page/DOMWindow.cpp:
* page/DOMWindow.h:
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

LayoutTests:

Changed most of the window.URL test code to use unprefixed version.
To verify webkitURL is still available left webkitURL related tests in
fast/dom/DOMURL/check-instanceof-domurl-functions.html.

* editing/pasteboard/data-transfer-items-image-png.html:
* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt:
* fast/dom/DOMURL/check-instanceof-domurl-functions.html:
* fast/dom/HTMLAnchorElement/anchor-download-unset.html:
* fast/dom/HTMLAnchorElement/anchor-download.html:
* fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
* fast/dom/HTMLAnchorElement/anchor-nodownload.html:
* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/dom/window-domurl-crash.html:
* fast/files/apply-blob-url-to-img.html:
* fast/files/apply-blob-url-to-xhr.html:
* fast/files/create-blob-url-crash.html:
* fast/files/domurl-script-execution-context-crash.html:
* fast/files/revoke-blob-url.html:
* fast/files/url-null-expected.txt:
* fast/files/url-null.html:
* fast/files/url-required-arguments-expected.txt:
* fast/files/url-required-arguments.html:
* fast/files/workers/inline-worker-via-blob-url.html:
* fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
* fast/js/constructor-length.html:
* http/tests/fileapi/create-blob-url-from-data-url.html:
* http/tests/security/mixedContent/blob-url-in-iframe.html:
* platform/chromium-win/compositing/geometry/object-clip-rects-assertion-expected.txt:
* platform/chromium/fast/files/url-required-arguments-expected.txt:
* platform/chromium/media/video-capture-preview.html:
* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/gtk/fast/files/url-required-arguments-expected.txt:
* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
* platform/qt-5.0/fast/js/global-constructors-expected.txt:
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/qt/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonested fragment parser test slow on Android
commit-queue@webkit.org [Thu, 9 Aug 2012 04:26:44 +0000 (04:26 +0000)]
nested fragment parser test slow on Android
https://bugs.webkit.org/show_bug.cgi?id=90438

Patch by Wei James <james.wei@intel.com> on 2012-08-08
Reviewed by Ryosuke Niwa.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] load events shouldn't be fired during Node::insrtedInto()
morrita@google.com [Thu, 9 Aug 2012 04:16:38 +0000 (04:16 +0000)]
[SVG] load events shouldn't be fired during Node::insrtedInto()
https://bugs.webkit.org/show_bug.cgi?id=92969

Reviewed by Ryosuke Niwa.

Source/WebCore:

Event dispatches during insertedInto() allow event handlers to
break DOM tree cosistency. This chagne makes them async for load
events which are dispatched during insertedInto() call. This
prevents event handlers from breaking tree consistency while the
notification traversal.

Test: svg/custom/loadevents-async.html

* svg/SVGElement.cpp:
(WebCore::SVGElement::sendSVGLoadEventIfPossibleAsynchronously): Added.
(WebCore):
(WebCore::SVGElement::svgLoadEventTimerFired): Added.
(WebCore::SVGElement::svgLoadEventTimer):
- Added a stub. Implemented in SVGScriptElement, SVGStopElement, SVGUseElement
  where the load event happens.
* svg/SVGElement.h:
(SVGElement):
* svg/SVGExternalResourcesRequired.cpp:
(WebCore::SVGExternalResourcesRequired::insertedIntoDocument):
- Replaces event dispatch call with async version.
* svg/SVGScriptElement.h:
* svg/SVGStyleElement.h:
* svg/SVGUseElement.h:

LayoutTests:

* svg/custom/loadevents-async-expected.txt: Added.
* svg/custom/loadevents-async.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement JSDOMWindow*::allowsAccessFrom* in terms of BindingSecurity
abarth@webkit.org [Thu, 9 Aug 2012 03:52:41 +0000 (03:52 +0000)]
Implement JSDOMWindow*::allowsAccessFrom* in terms of BindingSecurity
https://bugs.webkit.org/show_bug.cgi?id=93407

Reviewed by Eric Seidel.

This patch removes allowsAccessFrom and implements the security checks
in terms of shouldAllowAccessToFrame directly. There shouldn't be any
change in behavior.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore):
(WebCore::shouldAllowAccessFrom):
* bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineOwnProperty):
(WebCore::JSDOMWindow::setLocation):
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _isSafeScript]):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r125143.
tony@chromium.org [Thu, 9 Aug 2012 03:51:20 +0000 (03:51 +0000)]
Unreviewed, rolling out r125143.
http://trac.webkit.org/changeset/125143
https://bugs.webkit.org/show_bug.cgi?id=93573

Doesn't compile on Mac (Requested by tony^work on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-08

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
* platform/graphics/ImageSource.h:
(WebCore):
* platform/graphics/NativeImagePtr.h: Removed.
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtract the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.
kseo@webkit.org [Thu, 9 Aug 2012 02:35:43 +0000 (02:35 +0000)]
Extract the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.
https://bugs.webkit.org/show_bug.cgi?id=93466

Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-08
Reviewed by Adam Barth.

Image.h includes ImageSource.h in order to know the definition of NativeImagePtr.
But Image does not need to know the definition of ImageSource. So, this patch
extracts the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.

This is a preparation for asynchronous image decoding. Async decoding
will need a callback function, which sends a NativeImagePtr to clients, and the
callback must know the definition of NativeImagePtr, not ImageSource.

No new tests, behavior is unchanged.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
* platform/graphics/ImageSource.h:
(WebCore):
* platform/graphics/NativeImagePtr.h: Added.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCompile flag for CSS Hierarchies
commit-queue@webkit.org [Thu, 9 Aug 2012 02:29:35 +0000 (02:29 +0000)]
Compile flag for CSS Hierarchies
https://bugs.webkit.org/show_bug.cgi?id=92433

Patch by Shane Stephens <shanestephens@google.com> on 2012-08-08
Reviewed by Tony Chang.

.:

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Note that this flag is disabled on all platforms for now.

No new tests since there's no functional change.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-mac] Switch to LocalizedNumberMac from LocalizedNumberICU
tkent@chromium.org [Thu, 9 Aug 2012 02:26:01 +0000 (02:26 +0000)]
[Chromium-mac] Switch to LocalizedNumberMac from LocalizedNumberICU
https://bugs.webkit.org/show_bug.cgi?id=93432

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. Covered by fast/forms/number/number-lossless-localization.html,
and WebKit/chromium/tests/LocaleMacTest.cpp.

* WebCore.gyp/WebCore.gyp:
Exclude locale-relatef files for ICU, and include files for Mac.

Source/WebKit/chromium:

* tests/LocaleMacTest.cpp:
Add some tests for number localization. They are similar to tests in
LocaleWinTest and LocalizedNumberICUTest.cpp
(LocaleMacTest):
(LocaleMacTest::decimalSeparator):
(TEST_F):
(testNumberIsReversible):
(testNumbers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocss3/flexbox/content-height-with-scrollbars.html failing on non-fractional pixel...
tony@chromium.org [Thu, 9 Aug 2012 02:22:52 +0000 (02:22 +0000)]
css3/flexbox/content-height-with-scrollbars.html failing on non-fractional pixel layout machines
https://bugs.webkit.org/show_bug.cgi?id=93530

Unreviewed, fixing the test to not depend on rounding behavior.

* css3/flexbox/content-height-with-scrollbars-expected.html: Use a fixed width.
* css3/flexbox/content-height-with-scrollbars.html: Use a fixed width.
* platform/efl/TestExpectations: Remove failing expectation.
* platform/gtk/TestExpectations: Remove failing expectation.
* platform/mac/TestExpectations: Remove failing expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed TestExpectations cleanup and a new baseline.
dpranke@chromium.org [Thu, 9 Aug 2012 02:09:30 +0000 (02:09 +0000)]
Unreviewed TestExpectations cleanup and a new baseline.

* platform/chromium/TestExpectations:
* platform/chromium/http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix invalid test
arv@chromium.org [Thu, 9 Aug 2012 02:05:36 +0000 (02:05 +0000)]
Fix invalid test
https://bugs.webkit.org/show_bug.cgi?id=93543

Reviewed by Kentaro Hara.

The HTMLMediaElement.prototype.NETWORK_NO_SOURCE is non writable so assigning to the element instance should
be ignored.

* media/network-no-source-const-shadow-expected.txt:
* media/network-no-source-const-shadow.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse char* instead of LChar* for the public interface of String construction from...
benjamin@webkit.org [Thu, 9 Aug 2012 01:29:44 +0000 (01:29 +0000)]
Use char* instead of LChar* for the public interface of String construction from literals
https://bugs.webkit.org/show_bug.cgi?id=93402

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-08
Reviewed by Michael Saboff.

Source/JavaScriptCore:

Update JSC' Identifier to use StringImpl::createFromLiteral with a char*.

* runtime/Identifier.cpp:
(JSC::IdentifierASCIIStringTranslator::translate):

Source/WTF:

When the initialization from literal was added, some constructor/initialization function were
using LChar for convenience.

Since those function should only take ASCII characters, using LChar* could cause confusion. This
patch intents to clarify this by using char* for all those APIs.

* wtf/text/AtomicString.cpp:
(WTF::CharBufferFromLiteralDataTranslator::hash):
(WTF::CharBufferFromLiteralDataTranslator::equal):
(WTF::CharBufferFromLiteralDataTranslator::translate):
(WTF::AtomicString::addFromLiteralData):
* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(AtomicString):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
* wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createFromLiteral):

Tools:

* TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEventDispatcher::dispatchSimulatedClick should not reuse the same EventDispatcher...
hayato@chromium.org [Thu, 9 Aug 2012 01:11:35 +0000 (01:11 +0000)]
EventDispatcher::dispatchSimulatedClick should not reuse the same EventDispatcher instance.
https://bugs.webkit.org/show_bug.cgi?id=93452

Reviewed by Dimitri Glazkov.

This is a follow up patch after r124975.  There is yet another
place where the same EventDispatcher instance is reused across
event dispatching.

In addition to that, in order to simulate a real click, we must
different dispatchers because we must recalculate event ancestors
each time.  Current implementation wrongly freezes event ancestors
at the first event dispatching.

No new tests, no change in functionality.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
(EventDispatcher):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowriteHelperGetString in V8HTMLDocument uses += to concatenate strings
commit-queue@webkit.org [Thu, 9 Aug 2012 01:10:01 +0000 (01:10 +0000)]
writeHelperGetString in V8HTMLDocument uses += to concatenate strings
https://bugs.webkit.org/show_bug.cgi?id=93035

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-08-08
Reviewed by Adam Barth.

Use a StringBuilder instead of String concatenation because StringBuilder is generally faster.

No new functionality, so no new tests.

* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::writeHelperGetString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: rename finder.py to layout_test_finder.py
dpranke@chromium.org [Thu, 9 Aug 2012 01:07:24 +0000 (01:07 +0000)]
nrwt: rename finder.py to layout_test_finder.py
https://bugs.webkit.org/show_bug.cgi?id=93557

Reviewed by Ryosuke Niwa.

One last cleanup per old review feedback from rniwa.

* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/finder.py.
(LayoutTestFinder):
(LayoutTestFinder.__init__):
(LayoutTestFinder.find_tests):
(LayoutTestFinder._strip_test_dir_prefixes):
(LayoutTestFinder._strip_test_dir_prefix):
(LayoutTestFinder._read_test_names_from_file):
(LayoutTestFinder._strip_comments):
(LayoutTestFinder.skip_tests):
(LayoutTestFinder.split_into_chunks):
* Scripts/webkitpy/layout_tests/controllers/manager.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move scrollbar pointer into WebScrollbarThemePainter
enne@google.com [Thu, 9 Aug 2012 01:04:31 +0000 (01:04 +0000)]
[chromium] Move scrollbar pointer into WebScrollbarThemePainter
https://bugs.webkit.org/show_bug.cgi?id=93541

Reviewed by James Robinson.

Source/Platform:

Update WebScrollbarThemePainter to encapsulate a pointer to the
scrollbar as well. Lion scrollbars and RenderScrollbars are both
incompatible with wrapping a scrollbar in a WebScrollbar.

ScrollbarTheme(Chromium)Mac attaches extra data to a scrollbar based
on the pointer value (via a static map keyed on the pointer) so
passing an object that returns all the same values for the
ScrollbarThemeClient interface but has a different pointer will fail
to paint.

RenderScrollbar does static casts on the ScrollbarThemeClient pointer
that it is passed, assuming that it is the same. Therefore, it also
cannot use a WebScrollbar.

To fix this, push the real scrollbar pointer into the painter.

* chromium/public/WebScrollbarThemePainter.h:
(WebCore):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
(WebScrollbarThemePainter):

Source/WebCore:

Update clients of WebScrollbarThemePainter.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:

Source/WebKit/chromium:

Fix WebScrollbarThemePainter implementation to make direct calls on
the scrollbar rather than through the WebScrollbarThemeClientImpl
adapter.

* src/WebScrollbarThemePainter.cpp:
(WebKit::WebScrollbarThemePainter::assign):
(WebKit::WebScrollbarThemePainter::paintScrollbarBackground):
(WebKit::WebScrollbarThemePainter::paintTrackBackground):
(WebKit::WebScrollbarThemePainter::paintBackTrackPart):
(WebKit::WebScrollbarThemePainter::paintForwardTrackPart):
(WebKit::WebScrollbarThemePainter::paintBackButtonStart):
(WebKit::WebScrollbarThemePainter::paintBackButtonEnd):
(WebKit::WebScrollbarThemePainter::paintForwardButtonStart):
(WebKit::WebScrollbarThemePainter::paintForwardButtonEnd):
(WebKit::WebScrollbarThemePainter::paintTickmarks):
(WebKit::WebScrollbarThemePainter::paintThumb):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Invalid shaders should act as pass-through filters
achicu@adobe.com [Thu, 9 Aug 2012 00:56:13 +0000 (00:56 +0000)]
[CSS Shaders] Invalid shaders should act as pass-through filters
https://bugs.webkit.org/show_bug.cgi?id=93405

Reviewed by Dean Jackson.

Source/WebCore:

If the shader fails to apply then clearShaderResult will just copy the result of the previous filter
to the output of the current filter.

Test: css3/filters/custom/invalid-custom-filter-shader.html

* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore):
(WebCore::FECustomFilter::clearShaderResult):
(WebCore::FECustomFilter::applyShader):
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):
* rendering/style/StyleCustomFilterProgram.h: The test was exposing the fact that if the shaders were referencing the same
file then StyleCustomFilterProgram will never complete the load. Having the same file for both the vertex and the fragment shader
cannot really work, because the shaders would not compile anyway, thus triggering an invalid shader.
I'm fixing it part of this change because the current test actually exposes that on Safari Mac builds. See the note in the LayoutTest/ChangeLog.
(WebCore::StyleCustomFilterProgram::notifyFinished):

LayoutTests:

Note that invalid-custom-filter-shader-expected.html is actually using another builtin filter,
just to make sure we trigger the whole FilterEffectRenderer on the images, otherwise the result will be
slightly different because of the conversion errors. Having another filter like grayscale(0) will trigger
the same precission errors on the result of the expected html.

* css3/filters/custom/invalid-custom-filter-shader-expected.html: Added.
* css3/filters/custom/invalid-custom-filter-shader.html: Added.
* css3/filters/resources/invalid-shader.vs: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRewire the same-origin checks for the JavaScriptCore bindings through BindingSecurity
abarth@webkit.org [Thu, 9 Aug 2012 00:41:02 +0000 (00:41 +0000)]
Rewire the same-origin checks for the JavaScriptCore bindings through BindingSecurity
https://bugs.webkit.org/show_bug.cgi?id=93382

Reviewed by Eric Seidel.

This patch rewires the same-origin policy checks in the JavaScriptCore
bindings to use the implementation in BindingSecurity.cpp, which is now
shared by JavaScriptCore and V8. There are still a few places were we
use the JSDOMWindowCustom-based code path, but I plan to change those
in a follow up patch in the interest of keeping this patch as small as
possible.

This patch as two main benefits:

1) We no longer need to maintain duplicate code in the JSC and the V8
   bindings for as delicate an area as the same-origin check.
   Previously, the two implementations accomplished the same task using
   a slightly different mechansim. After this patch, they use the same
   mechanism, which means we only need to convince ourselves that one
   implementation is correct.

2) This patch will make it easier to remove DOMWindow::m_securityOrigin
   because there will be only one piece of code that needs to change.
   Prior to this patch, we would have had to change both
   implementations of the same-origin policy not to rely upon
   DOMWindow::m_securityOrigin.

* bindings/js/BindingState.cpp:
(WebCore::immediatelyReportUnsafeAccessTo):
(WebCore):
* bindings/js/BindingState.h:
(WebCore):
* bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToNode):
(WebCore::shouldAllowAccessToFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium/mac] Map NSEventPhaseMayBegin appropriately on 10.8
commit-queue@webkit.org [Thu, 9 Aug 2012 00:40:37 +0000 (00:40 +0000)]
[chromium/mac] Map NSEventPhaseMayBegin appropriately on 10.8
https://bugs.webkit.org/show_bug.cgi?id=93535

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-08-08
Reviewed by Dimitri Glazkov.

This enables putting two fingers on the track pad to show overlay scroll bars on 10.8+.

* src/mac/WebInputEventFactory.mm:
(WebKit::phaseForNSEventPhase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGoogle search query text reverts to original search query after multiple searches
beidson@apple.com [Thu, 9 Aug 2012 00:34:11 +0000 (00:34 +0000)]
Google search query text reverts to original search query after multiple searches
<rdar://problem/10800686> and https://bugs.webkit.org/show_bug.cgi?id=93544

Reviewed by Darin Adler.

Source/WebCore:

For security sensitive fields we normally clear "autocomplete=off" form elements when
restoring a page from the page cache.

If the element is textual and has a defaultValue then "clearing" it actually restores
the default value.

There's no scenario we can imagine where that makes sense so we should not reset the
value in such fields.

Test: fast/forms/autocomplete-off-with-default-value-does-not-clear.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute): Update suspension callback registration as needed.
(WebCore::HTMLInputElement::needsSuspensionCallback): Don't reset text fields with a non-empty default value.

LayoutTests:

* fast/forms/autocomplete-off-with-default-value-does-not-clear-expected.txt: Added.
* fast/forms/autocomplete-off-with-default-value-does-not-clear.html: Added.
* fast/forms/resources/go-back.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Perf EWS IRC bot
rniwa@webkit.org [Thu, 9 Aug 2012 00:19:23 +0000 (00:19 +0000)]
Add Perf EWS IRC bot
https://bugs.webkit.org/show_bug.cgi?id=92913

Reviewed by Dirk Pranke.

Adds the preliminary implementation of perfalizer, a IRC bot that runs performance tests
based on IRC requests.

* Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.head_svn_revision): The actual implementation returns string, so match that.
(MockSCM.svn_revision): Ditto.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.add_attachment_to_bug): Added mimetype.
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzilla.add_attachment_to_bug): Ditto.
* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.copytree): Added.
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.copytree): Added.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Rebaselined tests
that had assumed revision numbers were integers.
(test_run_with_json_output):
(test_run_with_description):
(test_run_generates_json_by_default):
(test_run_generates_and_show_results_page):
(test_run_with_json_source):
(test_run_with_multiple_repositories):
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/commands/__init__.py:
* Scripts/webkitpy/tool/commands/perfalizer.py: Added.
(PerfalizerTask):
(PerfalizerTask.__init__):
(PerfalizerTask._copy_build_product_without_patch):
(PerfalizerTask.run):
(PerfalizerTask.parent_command):
(PerfalizerTask.run_webkit_patch):
(PerfalizerTask._json_path):
(PerfalizerTask._results_page_path):
(PerfalizerTask._run_perf_test):
(PerfalizerTask.run_command):
(PerfalizerTask.command_passed):
(PerfalizerTask.command_failed):
(PerfalizerTask.refetch_patch):
(PerfalizerTask.expected_failures):
(PerfalizerTask.build_style):
(PerfTest): IRC command.
(PerfTest.execute):
(Perfalizer): IRC bot.
(Perfalizer.begin_work_queue):
(Perfalizer.work_item_log_path):
(Perfalizer._is_old_failure):
(Perfalizer.next_work_item):
(Perfalizer.process_work_item):
(Perfalizer.handle_unexpected_error):
(Perfalizer.handle_script_error):
* Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Added.
(PerfalizerTaskTest):
(PerfalizerTaskTest._create_and_run_perfalizer):
(PerfalizerTaskTest._create_and_run_perfalizer.logger):
(PerfalizerTaskTest._create_and_run_perfalizer.run_webkit_patch):
(PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
(PerfalizerTaskTest.test_run):
(PerfalizerTaskTest.test_run_with_clean_fails):
(PerfalizerTaskTest.test_run_with_update_fails):
(PerfalizerTaskTest.test_run_with_build_fails):
(PerfalizerTaskTest.test_run_with_perf_test_fails):
(PerfalizerTaskTest.test_run_without_results_page):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractPatchQueueTest.test_upload_results_archive_for_patch): Rebaselined.
* Scripts/webkitpy/tool/commands/upload_unittest.py:
(test_attach_to_bug): Ditto.
(test_attach_to_bug_no_description_or_comment): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreating "basic waveform" Oscillator nodes is not efficient
commit-queue@webkit.org [Thu, 9 Aug 2012 00:18:23 +0000 (00:18 +0000)]
Creating "basic waveform" Oscillator nodes is not efficient
https://bugs.webkit.org/show_bug.cgi?id=93194

Patch by Raymond Toy <rtoy@google.com> on 2012-08-08
Reviewed by Chris Rogers.

Source/WebCore:

Cache the wavetables for the basic types so they don't have to be
recomputed every time.

Also fix a bug where oscillator type was always set to CUSTOM
instead of the specified oscillator type.  Test added for this.

Test: webaudio/oscillator-basic.html

* Modules/webaudio/Oscillator.cpp:
(WebCore):
(WebCore::Oscillator::setType): Use cached wavetables; fix bug in
setting the oscillator type.
* Modules/webaudio/Oscillator.h:
(Oscillator): Define static variables to hold cached wavetables.

LayoutTests:

Add test to verify that the returned oscillator type is the same
as what was set.

* webaudio/oscillator-basic-expected.txt: Added.
* webaudio/oscillator-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix "-fPIC" define in the BlackBerry build
commit-queue@webkit.org [Thu, 9 Aug 2012 00:18:01 +0000 (00:18 +0000)]
[BlackBerry] Fix "-fPIC" define in the BlackBerry build
https://bugs.webkit.org/show_bug.cgi?id=93548

Patch by Ming Xie <mxie@rim.com> on 2012-08-08
Reviewed by Rob Buis.

In the current CMake release (version 2.8.5), ${CMAKE_SHARED
_LIBRARY_C_FLAGS} and ${CMAKE_SHARED_LIBRARY_CXX_FLAGS} is
set to empty (See cmake/Modules/Platform/QNX.cmake)

This breaks the assumption which WebKit CMake build system
makes in Source/cmake/WebKitHelper.cmake

* Source/cmake/OptionsBlackBerry.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid ASSERT(m_workerContext->isSharedWorkerContext()) in WorkerScriptController...
tsepez@chromium.org [Thu, 9 Aug 2012 00:16:38 +0000 (00:16 +0000)]
Avoid ASSERT(m_workerContext->isSharedWorkerContext()) in WorkerScriptController::initScript()
https://bugs.webkit.org/show_bug.cgi?id=93521

Reviewed by Adam Barth.

Source/WebCore:

Changes WorkerContext and its subclasses so that we do not call functions that rely upon subclass
virtual methods from the superclass constructor.

Test: http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked.html

* workers/DedicatedWorkerContext.cpp:
(WebCore):
(WebCore::DedicatedWorkerContext::create):
(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):
* workers/DedicatedWorkerContext.h:
(DedicatedWorkerContext):
* workers/SharedWorkerContext.cpp:
(WebCore):
(WebCore::SharedWorkerContext::create):
(WebCore::SharedWorkerContext::SharedWorkerContext):
* workers/SharedWorkerContext.h:
(SharedWorkerContext):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
(WebCore::WorkerContext::applyContentSecurityPolicyFromString):
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):

LayoutTests:

* http/tests/security/contentSecurityPolicy/resources/worker-set-timeout.js: Added.
* http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago(r124484) inspector/device-orientation-success.html failing on Mac ports
dino@apple.com [Thu, 9 Aug 2012 00:01:30 +0000 (00:01 +0000)]
(r124484) inspector/device-orientation-success.html failing on Mac ports
https://bugs.webkit.org/show_bug.cgi?id=93552

Unreviewed test expectations update. inspector/device-orientation-success.html missing console output.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCanvasRenderContext2D::setFont() should ignore inherited properties and default keywo...
commit-queue@webkit.org [Wed, 8 Aug 2012 23:59:34 +0000 (23:59 +0000)]
CanvasRenderContext2D::setFont() should ignore inherited properties and default keyword value
https://bugs.webkit.org/show_bug.cgi?id=93491

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Treat "inherit" as an invalid value. Also ignore the "default"
keyword that was previously treated as a font family. This second
change was done in the property validation and will also affect the
CSS font parsing, but it is probably harmless since font doesn't
recognize the default keyword anyway.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFamily):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):

LayoutTests:

Unskipped tests that are now passing after this fix and removed wrong
expectations.

* platform/chromium/TestExpectations:
* platform/chromium/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Removed.
* platform/efl/Skipped:
* platform/gtk/TestExpectations:
* platform/mac/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix up includes and types in chromium compositor unit tests
jamesr@google.com [Wed, 8 Aug 2012 23:59:09 +0000 (23:59 +0000)]
[chromium] Fix up includes and types in chromium compositor unit tests
https://bugs.webkit.org/show_bug.cgi?id=93553

Reviewed by Adrienne Walker.

This removes some unused GraphicsContext3DPrivate.h includes and adds some includes that were being implicitely
depending upon - mostly for wtf/PassOwnPtr.h.

* tests/CCLayerTreeHostTest.cpp:
(::CCLayerTreeHostTestCommit::beginTest):
(::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
* tests/CCRenderSurfaceFiltersTest.cpp:
* tests/CompositorFakeWebGraphicsContext3D.h:
* tests/FakeGraphicsContext3DTest.cpp:
* tests/FakeWebScrollbarThemeGeometry.h:
* tests/TextureCopierTest.cpp:
* tests/ThrottledTextureUploaderTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add missing OVERRIDE and virtual annotations in compositor
jamesr@google.com [Wed, 8 Aug 2012 23:56:50 +0000 (23:56 +0000)]
[chromium] Add missing OVERRIDE and virtual annotations in compositor
https://bugs.webkit.org/show_bug.cgi?id=93438

Reviewed by Adrienne Walker.

As the title suggests.

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(BitmapCanvasLayerTextureUpdater):
* platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
* platform/graphics/chromium/SolidColorLayerChromium.h:
(SolidColorLayerChromium):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
* platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateController):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch rebaseline-expectations needs to support multiple expectations files
dpranke@chromium.org [Wed, 8 Aug 2012 23:55:46 +0000 (23:55 +0000)]
webkit-patch rebaseline-expectations needs to support multiple expectations files
https://bugs.webkit.org/show_bug.cgi?id=89051

Reviewed by Adam Barth.

fixed the bug described above, added unit test in
test_expectations_unittest, and updated the tool tests
to not contain all of the "missing skia expectations" warnings.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.remove_rebaselined_tests):
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(RebaseliningTest.assertRemove):
(RebaseliningTest.test_remove):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations._update_expectations_files):
(RebaselineExpectations.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Refactor tile flags.
commit-queue@webkit.org [Wed, 8 Aug 2012 23:50:35 +0000 (23:50 +0000)]
[chromium] Refactor tile flags.
https://bugs.webkit.org/show_bug.cgi?id=93059

Patch by Eric Penner <epenner@google.com> on 2012-08-08
Reviewed by Adrienne Walker.

Source/WebCore:

This has become a general refactoring patch to make updateTiles easier
to work with. The 'updated' flag had become convoluted and incorrect
and the function had lots of special cases piled into it which
makes for tangled depedancies that are hard to reason with.

This refactors the updated flag into two flags ('validForFrame',
and 'occluded') for the two purposes it is actually used for,
simplifies the use of those flags.

'validForFrame' is improved to work for all tiles that are not dirty
before painting begins, rather than just the tiles that get touched via
updateTiles().

This refactors updateTiles() into several functions that more clearly
illustrate all the depedancies that have accumulated in there. After
doing that I managed to separate the occlusion pass from the painting
passes, ecapsulating the difficult dependancies in one documented
function 'markOcclusionsAndRequestTextures'.

Now update tiles doesn't need the 'idle' flag, and returns didPaint
as an out-param. The last remaining wierd output is m_failedPaint
which is needed in place of m_skipsIdlePaint to prevent infinite
paints from being requested.

As a last step I was going to merge LayerChromium::update() and
LayerChromium::needsMoreUpdates() by having update() just return
a boolean, but this proved to be a big change so I'm holding off
on that. That would let us remove the m_failedPaint and get rid
of needsIdlePaint() altogether.

Tested by many existing tests.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::resetUpdateState):
(WebCore::UpdatableTile::markForUpdate):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::markOcclusionsAndRequestTextures):
(WebCore::TiledLayerChromium::haveTexturesForTiles):
(WebCore::TiledLayerChromium::markTilesForUpdate):
(WebCore::TiledLayerChromium::updateTileTextures):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):

Source/WebKit/chromium:

Minor fixes to existing tests.

* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] MiniBrowser crashes on quit if any windows were previously closed
ap@apple.com [Wed, 8 Aug 2012 23:47:42 +0000 (23:47 +0000)]
    [WK2] MiniBrowser crashes on quit if any windows were previously closed
        https://bugs.webkit.org/show_bug.cgi?id=93529

        Reviewed by John Sullivan.

        * MiniBrowser/mac/AppDelegate.h:
        * MiniBrowser/mac/AppDelegate.m:
        (-[BrowserAppDelegate init]):
        (-[BrowserAppDelegate newWindow:]):
        (-[BrowserAppDelegate browserWindowWillClose:]):
        (-[BrowserAppDelegate applicationWillTerminate:]):
        (-[BrowserAppDelegate frontmostBrowserWindowController]):
        Track browser windows explicitly, not relying on [NSApp windows]. Closed windows
        are not automatically removed from the list until deallocated, so a refcounting
        error can result in working on a closed window.

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController dealloc]): Moved code from -windowWillClose: here.
        Releasing data members is -dealloc's job.
        (-[BrowserWindowController windowWillClose:]): Notify BrowserAppDelegate that
        the window is no longer open. Autorelease self, making sure that WKView and
        then WebPageProxy get released.
        (-[BrowserWindowController applicationTerminating]): Don't release _webView.pageRef.
        WKView is responsible for its lifetime.
        (closePage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocss3/calc/transitions-dependent.html was causing css3/calc/transitions.html to fail
commit-queue@webkit.org [Wed, 8 Aug 2012 23:39:50 +0000 (23:39 +0000)]
css3/calc/transitions-dependent.html was causing css3/calc/transitions.html to fail
https://bugs.webkit.org/show_bug.cgi?id=93515

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-08
Reviewed by Tim Horton.

The transitions-dependent.html test was causing the transitions.html test to fail.
This was a result of a timeout callback set in the first test that was only being fired
in the second test because the first test did not use waitUntilDone/notifyDone.
The second test printed out an extra TypeError: 'undefined' error message because the callback
was defined in the first test and was thus 'undefined' by the time it was called while the second test
was running.

In addition, the test contained the following line:
window.addEventListener("load", function() { waitForAnimationStart(runTest(expectedValues)); }, false);
which does not work as intended because the parameter to waitForAnimationStart should have been a function
that calls runTest, not the call to the runTest function itself, which calls the method immediately.

* css3/calc/transitions-dependent.html:
Added waitUntilDone/notifyDone.
Fixed function parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening: Chromium results for compositing/repaint/newly-compo...
fmalita@chromium.org [Wed, 8 Aug 2012 23:36:00 +0000 (23:36 +0000)]
[Chromium] Unreviewed gardening: Chromium results for compositing/repaint/newly-composited-on-scroll.html.

* platform/chromium-mac/compositing/repaint/newly-composited-on-scroll-expected.png: Added.
* platform/chromium-win/compositing/repaint/newly-composited-on-scroll-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Clean up WebKit.h and WebKitPlatformSupport.h includes in chromium/src
jamesr@google.com [Wed, 8 Aug 2012 23:27:47 +0000 (23:27 +0000)]
[chromium] Clean up WebKit.h and WebKitPlatformSupport.h includes in chromium/src
https://bugs.webkit.org/show_bug.cgi?id=93539

Reviewed by Adam Barth.

Most of these files don't need either WebKit.h or WebKitPlatformSupport.h. Some need <public/Platform.h>, and
some are relying on the forwarding headers. This updates includes to what is actually needed and points platform
includes at <public/Foo.h> instead of "platform/Foo.h" where possible.

* src/ApplicationCacheHostInternal.h:
* src/AssociatedURLLoader.cpp:
* src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
* src/BlobRegistryProxy.cpp:
* src/ChromiumCurrentTime.cpp:
* src/ChromiumOSRandomSource.cpp:
* src/ChromiumThreading.cpp:
* src/EditorClientImpl.cpp:
* src/FrameLoaderClientImpl.cpp:
* src/IDBFactoryBackendProxy.cpp:
* src/LocalizedStrings.cpp:
* src/PlatformMessagePortChannel.cpp:
* src/WebCompositorInputHandlerImpl.cpp:
* src/WebMediaPlayerClientImpl.cpp:
* src/WebPluginContainerImpl.cpp:
* src/WebViewImpl.cpp:
* src/WebWorkerClientImpl.cpp:
* src/WorkerAsyncFileSystemChromium.cpp:
* src/WorkerFileWriterCallbacksBridge.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening: compositing/plugins/no-backing-store.html yields...
fmalita@chromium.org [Wed, 8 Aug 2012 23:19:42 +0000 (23:19 +0000)]
[Chromium] Unreviewed gardening: compositing/plugins/no-backing-store.html yields incorrect results.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=93393
bdakin@apple.com [Wed, 8 Aug 2012 23:09:37 +0000 (23:09 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=93393
Overflow regions sometimes repaint incorrectly after going into or
coming out of compositing mode
-and corresponding-
<rdar://problem/12006463>

Reviewed by Simon Fraser.

My first patch to fix this bug removed an if (parent()) check that is
needed to prevent a table crash seen in
fast/table/table-row-compositing-repaint-crash.html
The parent() check was actually added originally to prevent this same
crash. See http://trac.webkit.org/changeset/110456
This patch adds that check back, but really we should delay the
computation of repaint rects if layout has not happened yet.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r124416): fast/forms/basic-selects.html failing on Lion Debug Tests
dino@apple.com [Wed, 8 Aug 2012 22:40:50 +0000 (22:40 +0000)]
REGRESSION (r124416): fast/forms/basic-selects.html failing on Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=93538

Unreviewed test expectations update after regression from r124416 on Mac ports.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid backing store on layers created for CoreAnimation plugins
scherkus@chromium.org [Wed, 8 Aug 2012 22:28:16 +0000 (22:28 +0000)]
Avoid backing store on layers created for CoreAnimation plugins
https://bugs.webkit.org/show_bug.cgi?id=93526
<rdar://problem/12052828>

Patch by Simon Fraser <simon.fraser@apple.com> on 2012-08-08
Reviewed by Dean Jackson.

Test for backing store on CoreAnimation-based plugins in various
configurations.

* compositing/plugins/no-backing-store-expected.txt: Added.
* compositing/plugins/no-backing-store.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid backing store on layers created for CoreAnimation plugins
simon.fraser@apple.com [Wed, 8 Aug 2012 22:17:34 +0000 (22:17 +0000)]
Avoid backing store on layers created for CoreAnimation plugins
https://bugs.webkit.org/show_bug.cgi?id=93526
<rdar://problem/12052828>

Reviewed by Dean Jackson.

Source/WebCore:

We create a compositing layer for <embed> objects whose plug-in supports
the CoreAnimation rendering model. When the embed's renderer is not styled,
we can avoid allocating backing store for it.

Test: compositing/plugins/no-backing-store.html

* rendering/RenderLayerBacking.cpp:
(WebCore::isCompositedPlugin):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

LayoutTests:

Test for backing store on CoreAnimation-based plugins in various
configurations.

* compositing/plugins/no-backing-store-expected.txt: Added.
* compositing/plugins/no-backing-store.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Crash when plug-in initialization fails
andersca@apple.com [Wed, 8 Aug 2012 22:16:35 +0000 (22:16 +0000)]
REGRESSION: Crash when plug-in initialization fails
https://bugs.webkit.org/show_bug.cgi?id=93534
<rdar://problem/12059786>

Reviewed by Simon Fraser.

Protect the PluginProxy while calling out to functions that could cause it to be destroyed.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::didFailToCreatePluginInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Updating fast/canvas/webgl/gl-teximage.html to prevent valid variations...
commit-queue@webkit.org [Wed, 8 Aug 2012 22:13:19 +0000 (22:13 +0000)]
[Chromium] Updating fast/canvas/webgl/gl-teximage.html to prevent valid variations in results from causing test failures.
https://bugs.webkit.org/show_bug.cgi?id=89494

Patch by Jeff Timanus <twiz@chromium.org> on 2012-08-08
Reviewed by Adrienne Walker.

* fast/canvas/webgl/gl-teximage-expected.txt:
* fast/canvas/webgl/gl-teximage.html: Only display the actual percentage of passing pixels when outside of DRT.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake isTransparentSilverlightBackgroundValue handle all the possible transparent...
andersca@apple.com [Wed, 8 Aug 2012 22:12:39 +0000 (22:12 +0000)]
Make isTransparentSilverlightBackgroundValue handle all the possible transparent colors
https://bugs.webkit.org/show_bug.cgi?id=93532

Reviewed by Simon Fraser.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::isTransparentSilverlightBackgroundValue):
Check for all the possible transparent colors and assume that the color is opaque otherwise.

(WebKit::NetscapePlugin::initialize):
Pass the lowercase string to isTransparentSilverlightBackgroundValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents...
dino@apple.com [Wed, 8 Aug 2012 22:10:05 +0000 (22:10 +0000)]
Rebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents.html
https://bugs.webkit.org/show_bug.cgi?id=92904

Unreviewed test expectations update. The IMAGE test was passing on Lion and Mountain Lion.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Clean up includes in compositor unit tests
jamesr@google.com [Wed, 8 Aug 2012 21:57:53 +0000 (21:57 +0000)]
[chromium] Clean up includes in compositor unit tests
https://bugs.webkit.org/show_bug.cgi?id=93531

Reviewed by Adrienne Walker.

This removes unused includes and updates Platform API headers to use the <public/Web...> style paths.

* tests/CCAnimationTestCommon.cpp:
* tests/CCKeyframedAnimationCurveTest.cpp:
* tests/CCLayerAnimationControllerTest.cpp:
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
* tests/CCOcclusionTrackerTest.cpp:
* tests/CCTextureUpdateControllerTest.cpp:
* tests/CCThreadedTest.cpp:
* tests/FakeWebGraphicsContext3D.h:
* tests/LayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
* tests/WebCompositorInputHandlerImplTest.cpp:
* tests/WebLayerTest.cpp:
* tests/WebLayerTreeViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Apply all Linux layout test expectations
wangxianzhu@chromium.org [Wed, 8 Aug 2012 21:56:24 +0000 (21:56 +0000)]
[Chromium-Android] Apply all Linux layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=92653

Reviewed by Adam Barth.

Tools:

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.skipped_layout_tests): Removed. Skip these tests in TestExpectations instead.

LayoutTests:

We used to let chromium_android.py replace all 'LINUX' to 'LINUX ANDROID' in test expectations on Android to automatically inherit all test expectations of chromium-linux.
As a step of upstreaming chromium-android, now we actually update TestExpectations.

In this change, 'LINUX's are replaced to 'LINUX ANDROID', *except* those:
1) already have 'ANDROID',
2) not applicable or not to be tested on Android, e.g. plugins, inspector, non-virtual gpu tests, etc. Instead we add SKIP rules for them.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocss3/flexbox/content-height-with-scrollbars.html failing image test on Lion and Mount...
dino@apple.com [Wed, 8 Aug 2012 21:54:11 +0000 (21:54 +0000)]
css3/flexbox/content-height-with-scrollbars.html failing image test on Lion and MountainLion
https://bugs.webkit.org/show_bug.cgi?id=93530

Unreviewed test expectations update.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDOM4: classList should be defined on Element and not on HTMLElement
arv@chromium.org [Wed, 8 Aug 2012 21:52:11 +0000 (21:52 +0000)]
DOM4: classList should be defined on Element and not on HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=93015

Reviewed by Adam Barth.

DOM4 specs that Element should have the classList WebIDL attribute. This moves the
attribute to the correct IDL file.

Source/WebCore:

Test: fast/dom/Element/class-list.html

* dom/Element.idl:
* html/HTMLElement.idl:

LayoutTests:

* fast/dom/Element/class-list-expected.txt: Added.
* fast/dom/Element/class-list.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=92275
bdakin@apple.com [Wed, 8 Aug 2012 21:49:46 +0000 (21:49 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=92275
Need a way to get a snapshot image that does not show the selection
-and corresponding-
<rdar://problem/11956802>

Reviewed by Anders Carlsson.

../WebCore:

New function FrameView::paintContentsForSnapshot() has the option to
exclude selection from the snapshot.

Export new function
* WebCore.exp.in:

Clear the selection from the RenderView when selection is to be excluded. Restore
all of this information via FrameSelection::updateAppearance() after calling
paintContents().
* page/FrameView.cpp:
(WebCore::FrameView::paintContentsForSnapshot):
(WebCore):
* page/FrameView.h:

../WebKit2:

Added new API WKBundlePageCreateSnapshotWithOptions()

New enum SnapshotOptions tracks whether snapshots should exclude
selection highlighting in addition to tracking whether the image is
sharable like the original ImageOptions.
* Shared/API/c/WKImage.h:
* Shared/API/c/WKSharedAPICast.h:
(WebKit::snapshotOptionsFromImageOptions):
(WebKit):
(WebKit::toSnapshotOptions):
* Shared/ImageOptions.h:

New API.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCreateSnapshotWithOptions):

These existing APIs all now call
WebPage::scaledSnapshotWithOptions().
(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):
(WKBundlePageCreateScaledSnapshotInDocumentCoordinates):

This patch removes WebPage::snapshotInViewCoordinates(),
WebPage::snapshotInDocumentCoordinates(), and
WebPage::scaledSnapshotInDocumentCoordinates(). All of the logic is
now consolidated into WebPage::scaledSnapshotWithOptions(). It turns
out that we never did anything different for document coordinates
versus view coordinates, so that complexity could just be eliminated
outright.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::snapshotOptionsToImageOptions):
(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit):
* WebProcess/WebPage/WebPage.h:
(WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalling internals from the performance test runner prevents manual running
benjamin@webkit.org [Wed, 8 Aug 2012 21:48:38 +0000 (21:48 +0000)]
Calling internals from the performance test runner prevents manual running
https://bugs.webkit.org/show_bug.cgi?id=93527

Reviewed by Ryosuke Niwa.

Since r125065, it is impossible to run the Performance tests manually. The problem is
"internals" is not defined when running outside the test runner, so the whole script
evaluation fails.

* resources/runner.js: Verify is window.internals is available before invoking something on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Only use public Platform API in NonCompositedContentHost
jamesr@google.com [Wed, 8 Aug 2012 21:17:43 +0000 (21:17 +0000)]
[chromium] Only use public Platform API in NonCompositedContentHost
https://bugs.webkit.org/show_bug.cgi?id=93423

Reviewed by Adrienne Walker.

Source/Platform:

Adds setters to control text antialiasing and checkerboarding behavior for content layers.

* chromium/public/WebContentLayer.h:
(WebContentLayer):

Source/WebCore:

This renames the "NonCompositedContentHost" flag to "useLCDText", which is the primary purpose of the flag. We
also use this flag to control whether we have border texels or not on the "root" layer, but I can't think of a
clean name that encapsulates both behaviors.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setUseLCDText):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::useLCDText):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setUseLCDText):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setUseLCDText):
(WebCore::CCLayerImpl::useLCDText):
(CCLayerImpl):

Source/WebKit/chromium:

Switches to using Web*Layer APIs in NonCompositedContentHost instead of reaching in to the LayerChromium and
updates unit tests for the nonCompositedContent->useLCDText flag rename.

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
* src/WebContentLayer.cpp:
(WebKit::WebContentLayer::setUseLCDText):
(WebKit):
(WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):
* src/WebViewImpl.cpp:
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostImplTest.cpp:
* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=93393
bdakin@apple.com [Wed, 8 Aug 2012 21:09:59 +0000 (21:09 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=93393
Overflow regions sometimes repaint incorrectly after going into or
coming out of compositing mode
-and corresponding-
<rdar://problem/12006463>

Reviewed by Simon Fraser.

Source/WebCore:

New RenderLayer function computeRepaintRectsIncludingDescendants()
* rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::computeRepaintRectsIncludingDescendants):
* rendering/RenderLayer.h:
(RenderLayer):

It is not sufficient to compute repaint rects just for the current
layer when compositing changes. They must be recomputed for all
descendant layers as well.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):

LayoutTests:

* compositing/repaint/newly-composited-on-scroll.html: Added.
* platform/mac/compositing/repaint/newly-composited-on-scroll-expected.png: Added.
* platform/mac/compositing/repaint/newly-composited-on-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r124710-r124713): media/video-seek-past-end-paused.html failing on Apple...
eric.carlson@apple.com [Wed, 8 Aug 2012 21:08:32 +0000 (21:08 +0000)]
REGRESSION (r124710-r124713): media/video-seek-past-end-paused.html failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93394

Unreviewed. Adding the correct results for failing tests on Mac.

* platform/mac/media/video-seek-past-end-paused-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: new enums and openCursor stub
commit-queue@webkit.org [Wed, 8 Aug 2012 21:04:36 +0000 (21:04 +0000)]
IndexedDB: new enums and openCursor stub
https://bugs.webkit.org/show_bug.cgi?id=93410

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-08
Reviewed by Adam Barth.

Source/WebCore:

Introduce a new TaskType enum that will be used to prioritize
internal tasks. This is preliminary staging for
https://bugs.webkit.org/show_bug.cgi?id=91125.

No new tests, coming in bug 91125.

* Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

This stubs out the TaskType and Direction enums that will be
required to land the chromium side of
https://bugs.webkit.org/show_bug.cgi?id=91125.

* public/WebIDBCursor.h:
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::setIndexKeys):
(WebKit::WebIDBObjectStore::setIndexesReady):
(WebIDBObjectStore):
(WebKit::WebIDBObjectStore::openCursor):
* public/WebIDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement about:memory-live
zhajiang@rim.com [Wed, 8 Aug 2012 21:02:15 +0000 (21:02 +0000)]
[BlackBerry] Implement about:memory-live
https://bugs.webkit.org/show_bug.cgi?id=93153

Reviewed by Yong Li.
Patch by Jacky Jiang  <zhajiang@rim.com>

Implementing about:memory-live to track memory peaks:
- about:memory-live/start: start tracking memory peaks.
- about:memory-live: show memory peaks every 30ms.
- about:memory-live/stop: stop tracking and show memory peaks.

Mainly track the following memory peaks:
- Total used memory (malloc + JSC).
- Total committed memory.
- Total mapped memory.

Add total committed memory for about:memory

* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::memoryPage):
(WebKit):
(MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::isActive):
(BlackBerry::WebKit::MemoryTracker::clear):
(BlackBerry::WebKit::MemoryTracker::peakTotalUsedMemory):
(BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemory):
(BlackBerry::WebKit::MemoryTracker::peakTotalMappedMemory):
(BlackBerry::WebKit::MemoryTracker::MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::instance):
(BlackBerry::WebKit::MemoryTracker::start):
(BlackBerry::WebKit::MemoryTracker::stop):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):
(BlackBerry::WebKit::memoryLivePage):
(BlackBerry::WebKit::aboutData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd MountainLion WebKit Bots.
commit-queue@webkit.org [Wed, 8 Aug 2012 20:49:44 +0000 (20:49 +0000)]
Add MountainLion WebKit Bots.
https://bugs.webkit.org/show_bug.cgi?id=93417

Patch by Josh Hawn <jhawn@apple.com> on 2012-08-08
Reviewed by Stephanie Lewis.

Mountain Lion is now available, so we've added the appropriate Apple bots,
mirroring the configuration of the Lion bots.

* BuildSlaveSupport/build.webkit.org-config/config.json:
Added 10 "apple-mini-###" slaves.
Added MountainLion Builders and Schedulers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the Silverlight CAOpenGLLayer opaque if we know the plug-in contents is opaque...
andersca@apple.com [Wed, 8 Aug 2012 20:33:21 +0000 (20:33 +0000)]
Make the Silverlight CAOpenGLLayer opaque if we know the plug-in contents is opaque to reduce blending
https://bugs.webkit.org/show_bug.cgi?id=93508
<rdar://problem/12056765>

Reviewed by Simon Fraser.

* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
* Shared/Plugins/PluginQuirks.h:
Rename the MakeTransparentIfBackgroundAttributeExists quirk to MakeOpaqueUnlessTransparentSilverlightBackgroundAttributeExists
since we'll explicitly check for opaque background colors (at least one opaque background color for now), instead of just making the
plug-in transparent whenever there's a background specified.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::isTransparentSilverlightBackgroundValue):
Helper function for determining if a background value is transparent. Just check for opaque black now and treat everything else as transparent.

(WebKit::NetscapePlugin::initialize):
Call isTransparentSilverlightBackgroundValue.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::makeCGLPresentLayerOpaque):
Helper function for grabbing the CGLPresentLayer from the layer hierarchy and setting it to be opaque.

(WebKit::NetscapePlugin::updatePluginLayer):
Call makeCGLPresentLayerOpaque if the plug-in has the MakeOpaqueUnlessTransparentSilverlightBackgroundAttributeExists quirk and
the plug-in is not transparent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r125046): Breaks debug build (assertion in protocol type checks) (Requeste...
pfeldman@chromium.org [Wed, 8 Aug 2012 20:14:52 +0000 (20:14 +0000)]
REGRESSION(r125046): Breaks debug build (assertion in protocol type checks) (Requested by pfeldman on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=93505

Not reviewed: roll out.

Source/WebCore:

* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
(ConsoleMessage):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype._printArray):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
* inspector/front-end/DOMExtension.js:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection):
* inspector/front-end/PropertiesSection.js:
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):
* inspector/front-end/Section.js:
* inspector/front-end/inspector.css:
(.console-group-messages .section .header .title):
(.section .properties .name, .event-properties .name):

LayoutTests:

* inspector/console/command-line-api-inspect-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-eval-global-expected.txt:
* inspector/console/console-eval-global.html:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-collections.html:
* inspector/console/console-format-expected.txt:
* inspector/console/console-format.html:
* inspector/console/console-log-document-proto-expected.txt:
* inspector/console/console-log-document-proto.html:
* inspector/console/console-log-toString-object-expected.txt:
* inspector/debugger/watch-expressions-panel-switch-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-eval-global-expected.txt: Copied from LayoutTests/inspector/console/console-eval-global-expected.txt.
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/chromium/inspector/console/console-format-expected.txt: Copied from LayoutTests/inspector/console/console-format-expected.txt.
* platform/chromium/inspector/console/console-log-document-proto-expected.txt:
* platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt:
* platform/chromium/inspector/elements/event-listener-sidebar-expected.txt: Copied from LayoutTests/inspector/elements/event-listener-sidebar-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Enable occlusion tracker in the occlusion tests for surface cacheing
danakj@chromium.org [Wed, 8 Aug 2012 20:13:48 +0000 (20:13 +0000)]
[chromium] Enable occlusion tracker in the occlusion tests for surface cacheing
https://bugs.webkit.org/show_bug.cgi?id=93500

Reviewed by Adrienne Walker.

The occlusion tracker is not being used in these tests except to do
scissoring. We want to test occlusion with these occlusion tests,
and when scissoring is not part of occlusion tracker, these
tests would become useless otherwise.

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when reloading a Chromium "platform" app
abarth@webkit.org [Wed, 8 Aug 2012 20:03:37 +0000 (20:03 +0000)]
Crash when reloading a Chromium "platform" app
https://bugs.webkit.org/show_bug.cgi?id=93497

Reviewed by Eric Seidel.

Source/WebCore:

The framework for Chromium "platform" apps executes a big blob of
script during the didCreateScriptContext callback. This blob of scripts
interacts with a bunch of JavaScript objects and triggers a number of
security checks.

When reloading a frame, the didCreateScriptContext is called during
Frame::setDocument (as a consequence of calling
ScriptController::updateDocument). At that time, the SecurityOrigin
object hasn't yet been copied over to the DOMWindow, and we crash
trying to grab it.

The long-term fix for this bug is to fix
https://bugs.webkit.org/show_bug.cgi?id=75793, at which point there
will no longer be a SecurityOrigin object on DOMWindow. In the
meantime, however, we can fix this crash by null checking the
DOMWindow's SecurityOrigin object.

* bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):

Source/WebKit/chromium:

Test that we don't crash when executing script during the
didCreateScriptContext callback.

* tests/WebFrameTest.cpp:
* tests/data/hello_world.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Coding style violation was brought with r125031
commit-queue@webkit.org [Wed, 8 Aug 2012 19:55:37 +0000 (19:55 +0000)]
[WK2] Coding style violation was brought with r125031
https://bugs.webkit.org/show_bug.cgi?id=93503

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-08
Reviewed by Alexey Proskuryakov.

WKURLResponseCopyMimeType is corrected to WKURLResponseCopyMIMEType.

Source/WebKit2:

* Shared/API/c/WKURLResponse.cpp:
(WKURLResponseCopyMIMEType):
* Shared/API/c/WKURLResponse.h:

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didReceiveResponseForResource):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpProgressFinishedCallback): Removed trailing whitespace that was brought with the same revision.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove several non-updated blogs from Planet WebKit
peter@chromium.org [Wed, 8 Aug 2012 19:39:00 +0000 (19:39 +0000)]
Remove several non-updated blogs from Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=92973

Reviewed by Eric Seidel.

Adam Treat's blog was last updated in 2009.
Justin Haygood's blog was last updated in 2008.
Mike Smith seems to have moved to Google+ entirely.
Pierre-Luc Beaudoin's blog is unavailable, cached copy says the last (non-WebKit specific update) was in 2010.
Cameron Zwarich' summer of JSC no longer exists.
Anthony Ricaud's blog was last updated in 2009.

* config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for Mac port after http://trac.webkit.org/changeset/125051
dino@apple.com [Wed, 8 Aug 2012 19:33:58 +0000 (19:33 +0000)]
Unreviewed build fix for Mac port after trac.webkit.org/changeset/125051

Add CachedImageClient.h to project.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Tie up the scrolling machinery to the graphics tree when applicable...
tonikitoo@webkit.org [Wed, 8 Aug 2012 19:21:52 +0000 (19:21 +0000)]
[BlackBerry] Tie up the scrolling machinery to the graphics tree when applicable for in-region scroll
https://bugs.webkit.org/show_bug.cgi?id=93482
PR #187672
Make InRegionScroller a simple public webkit/ API
PR #188677

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

In order to prepare InRegionScroller to be a public API
in webkit/, the patch:

1) Renamed the current InRegionScroller class to InRegionScrollerPrivate;
2) Moved InRegionScroller.cpp|h from WebKitSupport/ to Api/;
3) Renamed InRegionScroller.h to InRegionScroller_p.h;
4) Added a new public class implementation to InRegionScroller.h;
5) Adapted WebPage and TouchEventHandler classes to use InRegionScroller::d directly.

The most important API here is '::compositedSetScrollPosition'

It is a  UI/Compositing thread method only and sets the associated LayerCompositingThread
(camouflaged as a unsigned) for each created InRegionScrollableArea that supports
composited scrolling.

The way ::compositedSetScrollPosition "scrolls" a layer is by setting the boundsOrigin
property to the LayerCompositingThread's 'override' property in the UI/Compositing thread.

* PlatformBlackBerry.cmake: Build system adaptation.

* Api/InRegionScroller.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.cpp.
(WebKit):
(BlackBerry::WebKit::InRegionScroller::InRegionScroller):
(BlackBerry::WebKit::InRegionScroller::~InRegionScroller):
(BlackBerry::WebKit::InRegionScroller::compositedSetScrollPosition):
(BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
(BlackBerry::WebKit::InRegionScrollerPrivate::setNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::node):
(BlackBerry::WebKit::InRegionScrollerPrivate::reset):
(BlackBerry::WebKit::InRegionScrollerPrivate::hasNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::canScroll):
(BlackBerry::WebKit::InRegionScrollerPrivate::compositedSetScrollPosition):
(BlackBerry::WebKit::InRegionScrollerPrivate::scrollBy):
(BlackBerry::WebKit::InRegionScrollerPrivate::inRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::scrollNodeRecursively):
(BlackBerry::WebKit::InRegionScrollerPrivate::scrollRenderer):
(BlackBerry::WebKit::InRegionScrollerPrivate::adjustScrollDelta):
(BlackBerry::WebKit::canScrollInnerFrame):
(BlackBerry::WebKit::canScrollRenderBox):
(BlackBerry::WebKit::parentLayer):
(BlackBerry::WebKit::enclosingLayerNode):
(BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
(BlackBerry::WebKit::pushBackInRegionScrollable):
* Api/InRegionScroller.h: Copied from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h.
(WebKit):
(InRegionScroller):
* Api/InRegionScroller_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h.
(WebCore):
(WebKit):
(InRegionScrollerPrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::scrollBy):
(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStatusChanged):
(BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
(BlackBerry::WebKit::WebPage::inRegionScroller):
(WebKit):
* Api/WebPage.h:
(WebKit):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Make WebOverlayPrivate::scheduleCompositingRun a WebPagePrivate method.
tonikitoo@webkit.org [Wed, 8 Aug 2012 19:20:59 +0000 (19:20 +0000)]
[BlackBerry] Make WebOverlayPrivate::scheduleCompositingRun a WebPagePrivate method.
https://bugs.webkit.org/show_bug.cgi?id=93480
PR #188682

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

... this way it can be used by others.

No behavioural change. Another preparation patch.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):
* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add boundsOrigin accessors to LayerOverride
tonikitoo@webkit.org [Wed, 8 Aug 2012 19:20:10 +0000 (19:20 +0000)]
[BlackBerry] Add boundsOrigin accessors to LayerOverride
https://bugs.webkit.org/show_bug.cgi?id=93479
PR #188677

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

This is needed in order to allow us to directly set the boundsOrigin value
to the LayerCompositingThread and avoid it to get overridden by the respective
LayerWebKitThread's boundsOrigin value in the next commit.

No new tests, since this is another preparation PR.

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::updateAnimations):
* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerOverride::isBoundsOriginSet):
(WebCore::LayerOverride::boundsOrigin):
(WebCore::LayerOverride::setBoundsOrigin):
(LayerOverride):
(WebCore::LayerOverride::LayerOverride):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Propagate GraphicsLayer::boundsOrigin down to the platform layers
tonikitoo@webkit.org [Wed, 8 Aug 2012 19:19:18 +0000 (19:19 +0000)]
[BlackBerry] Propagate GraphicsLayer::boundsOrigin down to the platform layers
https://bugs.webkit.org/show_bug.cgi?id=93478
PR #188657

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

This property will be set from both WebKit and Compositing/UI
threads in order to fast scroll block elements.

No new tests, as it is a mid-step patch.

* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setBoundsOrigin):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::updateBoundsOrigin):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::setBoundsOrigin):
* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::boundsOrigin):
(LayerData):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):
* platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::setBoundsOrigin):
(LayerWebKitThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124887.
commit-queue@webkit.org [Wed, 8 Aug 2012 19:14:05 +0000 (19:14 +0000)]
Unreviewed, rolling out r124887.
http://trac.webkit.org/changeset/124887
https://bugs.webkit.org/show_bug.cgi?id=93504

Dependent API being removed. (Requested by mfenton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-08

* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
* WebKitSupport/InputHandler.h:
(InputHandler):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::spellCheck):
(WebKit):
* WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuildmaster changes in preparation of a Chromium Android tester
peter@chromium.org [Wed, 8 Aug 2012 19:11:37 +0000 (19:11 +0000)]
Buildmaster changes in preparation of a Chromium Android tester
https://bugs.webkit.org/show_bug.cgi?id=92251

Reviewed by Adam Barth.

Slightly update the build master's configuration in preparation of adding
a Chromium Android tester.

The change in built-product-archive is required as the out/ directory
for Android has a number of unstripped .so binaries and unaligned APKs,
causing the default release.zip file to be 2.7 gigabytes. By excluding
these file types, the file is only 59.7 megabytes. We can't disable
them for all of Chromium, as Mac and Linux do use their .so files.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ArchiveBuiltProduct): Pass the full platform name instead of just the
    generic type, i.e. chromium-android instead of chromium.
(ExtractBuiltProduct): Dito, stay consistent for this script.
(RunUnitTests): Pass --chromium-android as well as --chromium. Since we
    now read the full platform name, stay on the safe side with 'win'
    even though there (as far as I know) is no win-* platform.
(RunChromiumWebKitUnitTests): Dito. The platform wasn't being passed
    at all, but we'll be needing different handling here.
(unitTestsSupported): Next to refactoring work required, as we'll be
    running this test on a device, there is no reason to disable this
    in the master's configuration.
* BuildSlaveSupport/built-product-archive:
(main): Determine the generic platform.
(archiveBuiltProduct): Use an identical set of ignorePatterns, but
    extend the list with .so, .pak and -unaligned.apk for Android.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSet access to MemoryInfo enabled for the performance tests
zoltan@webkit.org [Wed, 8 Aug 2012 19:09:07 +0000 (19:09 +0000)]
Set access to MemoryInfo enabled for the performance tests
https://bugs.webkit.org/show_bug.cgi?id=92498

Reviewed by Ryosuke Niwa.

We need access to console.memory for the memory measurements.

* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium][win] Rebaseline css3/filters/custom tests
fmalita@chromium.org [Wed, 8 Aug 2012 19:07:34 +0000 (19:07 +0000)]
[chromium][win] Rebaseline css3/filters/custom tests
https://bugs.webkit.org/show_bug.cgi?id=93404

Unreviewed gardening: updating Chromium results after 125044.

* platform/chromium-linux-x86/css3/filters/custom/effect-color-check-expected.png: Removed.
* platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png: Removed.
* platform/chromium-win-xp/css3/filters/custom/effect-color-check-expected.png: Removed.
* platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother unreviewed build fix after http://trac.webkit.org/changeset/125051
dino@apple.com [Wed, 8 Aug 2012 18:55:07 +0000 (18:55 +0000)]
Another unreviewed build fix after trac.webkit.org/changeset/125051

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 8 Aug 2012 18:54:25 +0000 (18:54 +0000)]
Unreviewed GTK gardening.

Adding expectations for three tests that are flaky crashers:
- editing/inserting/insert-character-in-first-letter-crash.html
- fast/history/nested-visited-test.html
- fast/css/first-letter-text-fragment-crash.html

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Upstream android's FlingAnimator
japhet@chromium.org [Wed, 8 Aug 2012 18:52:00 +0000 (18:52 +0000)]
[chromium] Upstream android's FlingAnimator
https://bugs.webkit.org/show_bug.cgi?id=92900

Reviewed by James Robinson.

No new tests yet, will be added once this code is called.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(WebKit::Platform::createFlingAnimator):
* chromium/public/WebFlingAnimator.h: Added.
(WebKit):
(WebFlingAnimator):
(WebKit::WebFlingAnimator::~WebFlingAnimator):

Source/WebCore:

* WebCore.gypi:
* platform/chromium/support/PlatformGestureCurveFactory.cpp: Added.
(WebKit):
(WebKit::PlatformGestureCurveFactory::get):
(WebKit::PlatformGestureCurveFactory::createCurve):
(WebKit::PlatformGestureCurveFactory::setWebFlingAnimatorForTest):
* platform/chromium/support/PlatformGestureCurveFactory.h: Added.
(WebKit):
(PlatformGestureCurveFactory):
* platform/chromium/support/WebFlingAnimatorToGestureCurveAdapter.h: Added.
(WebKit):
(WebFlingAnimatorToGestureCurveAdapter):
(WebKit::WebFlingAnimatorToGestureCurveAdapter::create):
(WebKit::WebFlingAnimatorToGestureCurveAdapter::WebFlingAnimatorToGestureCurveAdapter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125061 268f45cc-cd09-0410-ab3c-d52691b4dbfc