WebKit-https.git
9 years ago2010-10-19 Jenn Braithwaite <jennb@chromium.org>
commit-queue@webkit.org [Wed, 20 Oct 2010 02:53:54 +0000 (02:53 +0000)]
2010-10-19  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by David Levin.

        Add DirectX SDK to Installing Developer Tools web page
        https://bugs.webkit.org/show_bug.cgi?id=47911

        * building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Wed, 20 Oct 2010 02:18:11 +0000 (02:18 +0000)]
2010-10-19  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed, adding missed additionalArguments.

        [CMAKE] additional arguments was missed in GENERATE_DOM_NAMES
        https://bugs.webkit.org/show_bug.cgi?id=47694

        Pass additionalArguments for make_names.pl to choose enabled features.

        * cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 20 Oct 2010 01:55:58 +0000 (01:55 +0000)]
2010-10-19  Kenneth Russell  <kbr@google.com>

        Unreviewed, test expectations update.

        Added initial test expectations for the chromium-gpu configuration,
        generated on Windows. Pixel results have been added under chromium-gpu-win.
        The hope is that at least the text results might be shareable between the
        Windows and Linux platforms; for the time being, they are being placed
        under chromium-gpu, though they may be moved in the near future.

        platform/chromium-gpu/test_expectations.txt still has all of the tests
        marked "PASS FAIL". Only once we have a certain set of the tests passing on
        all three platforms (Windows, Mac, Linux) will we remove the FAIL from that
        line. The current effort has focused on the "compositing" directory.

        * platform/chromium-gpu-win/compositing: Added.
        * platform/chromium-gpu-win/compositing/animation: Added.
        * platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
        * platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.png: Added.
        * platform/chromium-gpu-win/compositing/direct-image-compositing-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png: Added.
        * platform/chromium-gpu-win/compositing/generated-content-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/generated-content-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry: Added.
        * platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/outline-change-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/outline-change-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png: Added.
        * platform/chromium-gpu-win/compositing/iframes: Added.
        * platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png: Added.
        * platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.png: Added.
        * platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
        * platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
        * platform/chromium-gpu-win/compositing/images: Added.
        * platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.png: Added.
        * platform/chromium-gpu-win/compositing/overflow: Added.
        * platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
        * platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.png: Added.
        * platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.png: Added.
        * platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.png: Added.
        * platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.png: Added.
        * platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections: Added.
        * platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png: Added.
        * platform/chromium-gpu-win/compositing/repaint: Added.
        * platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
        * platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.png: Added.
        * platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.png: Added.
        * platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.png: Added.
        * platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.png: Added.
        * platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.png: Added.
        * platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.png: Added.
        * platform/chromium-gpu-win/compositing/sibling-positioning-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/sibling-positioning-expected.png: Added.
        * platform/chromium-gpu-win/compositing/transitions: Added.
        * platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.png: Added.
        * platform/chromium-gpu/compositing/animation: Added.
        * platform/chromium-gpu/compositing/animation/animated-composited-inside-hidden-expected.txt: Added.
        * platform/chromium-gpu/compositing/animation/animation-compositing-expected.txt: Added.
        * platform/chromium-gpu/compositing/animation/computed-style-during-delay-expected.txt: Added.
        * platform/chromium-gpu/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
        * platform/chromium-gpu/compositing/composited-negative-zindex-child-expected.txt: Added.
        * platform/chromium-gpu/compositing/compositing-visible-descendant-expected.txt: Added.
        * platform/chromium-gpu/compositing/direct-image-compositing-expected.txt: Added.
        * platform/chromium-gpu/compositing/generated-content-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry: Added.
        * platform/chromium-gpu/compositing/geometry/clip-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/clipping-foreground-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/empty-embed-rects-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/fixed-in-composited-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/fixed-position-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/huge-layer-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/outline-change-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/partial-layout-update-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/preserve-3d-switching-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/root-layer-update-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
        * platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes: Added.
        * platform/chromium-gpu/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/iframe-content-flipping-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/iframe-size-to-zero-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/iframe-src-change-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/remove-iframe-crash-expected.txt: Added.
        * platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt: Added.
        * platform/chromium-gpu/compositing/images: Added.
        * platform/chromium-gpu/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
        * platform/chromium-gpu/compositing/images/content-image-expected.txt: Added.
        * platform/chromium-gpu/compositing/images/direct-image-background-color-expected.txt: Added.
        * platform/chromium-gpu/compositing/layer-creation: Added.
        * platform/chromium-gpu/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow: Added.
        * platform/chromium-gpu/compositing/overflow/clip-descendents-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow/get-transform-from-non-box-container-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow/overflow-positioning-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow/overflow-scroll-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow/parent-overflow-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow/scrollbar-painting-expected.txt: Added.
        * platform/chromium-gpu/compositing/overflow/zero-size-overflow-expected.txt: Added.
        * platform/chromium-gpu/compositing/plugins: Added.
        * platform/chromium-gpu/compositing/plugins/1x1-composited-plugin-expected.txt: Added.
        * platform/chromium-gpu/compositing/plugins/large-to-small-composited-plugin-expected.txt: Added.
        * platform/chromium-gpu/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
        * platform/chromium-gpu/compositing/reflections: Added.
        * platform/chromium-gpu/compositing/reflections/backface-hidden-reflection-expected.txt: Added.
        * platform/chromium-gpu/compositing/reflections/reflection-in-composited-expected.txt: Added.
        * platform/chromium-gpu/compositing/repaint: Added.
        * platform/chromium-gpu/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
        * platform/chromium-gpu/compositing/repaint/content-into-overflow-expected.txt: Added.
        * platform/chromium-gpu/compositing/repaint/inline-repaint-container-expected.txt: Added.
        * platform/chromium-gpu/compositing/repaint/layer-repaint-expected.txt: Added.
        * platform/chromium-gpu/compositing/repaint/layer-repaint-rects-expected.txt: Added.
        * platform/chromium-gpu/compositing/repaint/opacity-between-absolute-expected.txt: Added.
        * platform/chromium-gpu/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
        * platform/chromium-gpu/compositing/repaint/overflow-into-content-expected.txt: Added.
        * platform/chromium-gpu/compositing/sibling-positioning-expected.txt: Added.
        * platform/chromium-gpu/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
        * platform/chromium-gpu/compositing/tiling/huge-layer-resize-expected.txt: Added.
        * platform/chromium-gpu/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
        * platform/chromium-gpu/compositing/transitions: Added.
        * platform/chromium-gpu/compositing/transitions/opacity-on-inline-expected.txt: Added.
        * platform/chromium-gpu/compositing/transitions/singular-scale-transition-expected.txt: Added.
        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Yongjun Zhang <yongjun_zhang@apple.com>
commit-queue@webkit.org [Wed, 20 Oct 2010 01:44:08 +0000 (01:44 +0000)]
2010-10-19  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Dan Bernstein.

        Pixel cracks when using background image sprite on transformed element at certain scales.
        https://bugs.webkit.org/show_bug.cgi?id=47868

        * fast/images/pixel-crack-image-background-webkit-transform-scale.html: Added.
        * fast/images/resources/pixel-crack-image-background-webkit-transform-scale.png: Added.
        * platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
        * platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
        * platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
2010-10-19  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Dan Bernstein.

        Pixel cracks when using background image sprite on transformed element at certain scales.
        https://bugs.webkit.org/show_bug.cgi?id=47868

        The pixel bleeding happens when the current context has scale and interpolation is kCGInterpolationHigh
        or kCGInterpolationDefault.  If the source rect size is smaller than the intrinsic image size,  some
        pixels outside of the clip rect will also be used to interpolate the color value for clip edges, which
        results in unwanted thin lines around the painted area.  We need to use sub-image patch to get rid of
        the artifacts in this case.

        Test: fast/images/pixel-crack-image-background-webkit-transform-scale.html

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 20 Oct 2010 01:26:21 +0000 (01:26 +0000)]
2010-10-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Teach feeder-queue how to feed the EWS bots
        https://bugs.webkit.org/show_bug.cgi?id=47943

        queues.webkit.org already knew how to accept EWS submissions
        via /submit-to-ews.  This teaches the feeder queue how to post
        to that page with any new r? patches it sees.

        * QueueStatusServer/model/activeworkitems_unitest.py: Added.
         - More unit testing is always a good thing.
        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/net/statusserver.py:
        * Scripts/webkitpy/tool/bot/feeders.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 20 Oct 2010 01:25:09 +0000 (01:25 +0000)]
2010-10-19  James Robinson  <jamesr@chromium.org>

        Remove test expectations entries for tests that consistently pass.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Oct 2010 01:10:55 +0000 (01:10 +0000)]
2010-10-19  Tony Chang  <tony@chromium.org>

        Unreviewed, plugins/plugin-javascript-access.html is
        passing again on Chromium mac after a chromium side fix to TestShell.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 20 Oct 2010 01:08:08 +0000 (01:08 +0000)]
2010-10-19  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        sqlite: remove unused member variable
        https://bugs.webkit.org/show_bug.cgi?id=47957

        There's no need to save the error code into a member variable
        because nobody ever looks at it.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::open):
        * platform/sql/SQLiteDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Wed, 20 Oct 2010 00:20:28 +0000 (00:20 +0000)]
2010-10-19  Jia Pu  <jpu@apple.com>

        Reviewed by James Robinson.

        Moving cursor back to autocorrected word in the same line shouldn't remove the underline
        https://bugs.webkit.org/show_bug.cgi?id=47629
        <rdar://problem/8546758>

        Patch <http://trac.webkit.org/changeset/70071> breaks some Chromium Mac hehavior. This patch
        fixes that.

        * editing/Editor.cpp:
        (WebCore::Editor::respondToChangedSelection): Add "!PLATFORM(MAC)" to make sure nothing changes
          on non-Mac platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 19 Oct 2010 23:55:08 +0000 (23:55 +0000)]
2010-10-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Remove support for JSVALUE32 from JSC
        https://bugs.webkit.org/show_bug.cgi?id=47948

        Remove all the code for supporting JSVALUE32 from JSC.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompileSlowCases):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::emit_op_lshift):
        (JSC::JIT::emitSlow_op_lshift):
        (JSC::JIT::emit_op_rshift):
        (JSC::JIT::emitSlow_op_rshift):
        (JSC::JIT::emit_op_urshift):
        (JSC::JIT::emitSlow_op_urshift):
        (JSC::JIT::emit_op_jnless):
        (JSC::JIT::emitSlow_op_jnless):
        (JSC::JIT::emit_op_jless):
        (JSC::JIT::emitSlow_op_jless):
        (JSC::JIT::emit_op_jlesseq):
        (JSC::JIT::emitSlow_op_jlesseq):
        (JSC::JIT::emit_op_bitand):
        (JSC::JIT::emit_op_post_inc):
        (JSC::JIT::emit_op_post_dec):
        (JSC::JIT::emit_op_pre_inc):
        (JSC::JIT::emit_op_pre_dec):
        (JSC::JIT::emit_op_mod):
        (JSC::JIT::emitSlow_op_mod):
        * jit/JITCall.cpp:
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitGetFromCallFrameHeaderPtr):
        (JSC::JIT::emitGetFromCallFrameHeader32):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_loop_if_lesseq):
        (JSC::JIT::emit_op_bitnot):
        (JSC::JIT::emit_op_next_pname):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emit_op_put_by_val):
        * jit/JITStubs.h:
        * jit/JSInterfaceJIT.h:
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::returnDouble):
        (JSC::SpecializedThunkJIT::tagReturnAsInt32):
        * jit/ThunkGenerators.cpp:
        (JSC::sqrtThunkGenerator):
        (JSC::powThunkGenerator):
        * runtime/Collector.cpp:
        (JSC::isPossibleCell):
        (JSC::typeName):
        * runtime/JSCell.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.h:
        (JSC::Structure::prototypeForLookup):
        * runtime/JSImmediate.h:
        (JSC::reinterpretIntptrToDouble):
        (JSC::JSImmediate::isIntegerNumber):
        (JSC::JSImmediate::isDouble):
        (JSC::JSImmediate::areBothImmediateIntegerNumbers):
        (JSC::JSImmediate::makeDouble):
        (JSC::JSImmediate::doubleValue):
        (JSC::JSImmediate::toBoolean):
        (JSC::JSImmediate::fromNumberOutsideIntegerRange):
        (JSC::JSImmediate::from):
        (JSC::JSImmediate::toDouble):
        (JSC::JSFastMath::rightShiftImmediateNumbers):
        * runtime/JSNumberCell.cpp:
        * runtime/JSNumberCell.h:
        * runtime/JSObject.h:
        (JSC::JSObject::JSObject):
        * runtime/JSValue.h:
        * runtime/NumberObject.h:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 19 Oct 2010 23:41:46 +0000 (23:41 +0000)]
2010-10-19  Tony Chang  <tony@chromium.org>

        Unreviewed, updating drt expectations for plugin tests on mac.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix MiniBrowser crashes during startup and shutdown
andersca@apple.com [Tue, 19 Oct 2010 23:40:58 +0000 (23:40 +0000)]
Fix MiniBrowser crashes during startup and shutdown
https://bugs.webkit.org/show_bug.cgi?id=47954

Reviewed by Sam Weinig.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::sharedProcessContext):
Initialize the main thread.

(WebKit::WebContext::create):
Ditto.

(WebKit::WebContext::WebContext):
Add the language observer here so we know that it will always be set up.

(WebKit::WebContext::ensureWebProcess):
Remove code.

* UIProcess/WebContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
timothy@apple.com [Tue, 19 Oct 2010 23:27:09 +0000 (23:27 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 19 Oct 2010 23:17:55 +0000 (23:17 +0000)]
2010-10-19  James Robinson  <jamesr@chromium.org>

        Update chromium test expectations

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Build fix (EFL, maybe more).
ap@apple.com [Tue, 19 Oct 2010 23:15:09 +0000 (23:15 +0000)]
    Build fix (EFL, maybe more).

        * CMakeLists.txt: Added platform/Language.cpp here, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 23:02:49 +0000 (23:02 +0000)]
2010-10-19  Eric Seidel  <eric@webkit.org>

        Unreviewed, just fixing test-webkitpy.  I'm really on a roll today.

        commit-queue gets stuck when release-patch returns 404
        https://bugs.webkit.org/show_bug.cgi?id=47935

        Fix test-webkitpy and unittest NetworkTransaction.

        * Scripts/webkitpy/common/net/networktransaction.py:
        * Scripts/webkitpy/common/net/networktransaction_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename createBlobURL to createObjectURL and revokeBlobURL to
jianli@chromium.org [Tue, 19 Oct 2010 23:02:14 +0000 (23:02 +0000)]
Rename createBlobURL to createObjectURL and revokeBlobURL to
revokeObjectURL per the latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=47934

Reviewed by Darin Fisher.

WebCore:

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._contextMenu):
* inspector/front-end/utilities.js:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createObjectURL):
(WebCore::DOMWindow::revokeObjectURL):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::createObjectURL):
(WebCore::WorkerContext::revokeObjectURL):
* workers/WorkerContext.h:
* workers/WorkerContext.idl:

LayoutTests:

Update all the related test and result files to account for the
renaming changes.

* fast/dom/Window/script-tests/window-property-descriptors.js:
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-properties.html:
* fast/dom/script-tests/prototype-inheritance.js:
* fast/files/apply-blob-url-to-img.html:
* fast/files/apply-blob-url-to-xhr.html:
* fast/files/create-blob-url-crash-expected.txt:
* fast/files/create-blob-url-crash.html:
* fast/files/revoke-blob-url-expected.txt:
* fast/files/revoke-blob-url.html:
* fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCoalesce plug-in drawing
andersca@apple.com [Tue, 19 Oct 2010 22:48:18 +0000 (22:48 +0000)]
Coalesce plug-in drawing
https://bugs.webkit.org/show_bug.cgi?id=47939

Reviewed by Sam Weinig.

Coalesce plug-in drawing in the same manner as we do it in the chunked update drawing area.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_waitingForDidUpdate to false.

(WebKit::PluginControllerProxy::startPaintTimer):
Move code from invalidate out to here. Don't start the paint timer if m_waitingForDidUpdate is true.

(WebKit::PluginControllerProxy::invalidate):
Call startPaintTimer.

(WebKit::PluginControllerProxy::didUpdate):
Set m_waitingForDidUpdate to false and start the paint timer.

* PluginProcess/PluginControllerProxy.messages.in:
Add DidUpdate message.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::PluginProxy):
Initialize m_waitingForPaintInResponseToUpdate to false.

(WebKit::PluginProxy::paint):
If m_waitingForPaintInResponseToUpdate is true, send a DidUpdate message.

(WebKit::PluginProxy::update):
Set m_waitingForPaintInResponseToUpdate to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd alternateHTMLString and unreachableURL API to WebKit2
weinig@apple.com [Tue, 19 Oct 2010 22:45:36 +0000 (22:45 +0000)]
Add alternateHTMLString and unreachableURL API to WebKit2
<rdar://problem/8557864>
https://bugs.webkit.org/show_bug.cgi?id=47938

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyUnreachableURL):
* UIProcess/API/C/WKFrame.h:
Add accessor for the unreachableURL if one is set. It will only be
set during a loadAlternateHTMLString and will be unset on the next normal
didStartProvisionalLoadForFrame call.

* UIProcess/API/C/WKPage.cpp:
(WKPageLoadHTMLString): Remove whitespace.
(WKPageLoadAlternateHTMLString):
* UIProcess/API/C/WKPage.h:
Add function to load a string as "alternate", meant for use as error pages.

* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::setUnreachableURL):
(WebKit::WebFrameProxy::unreachableURL):
Add setter/getter for the unreachableURL.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTMLString):
Plumb through the call to loadAlternateHTMLString to the WebProcess
and set the main frame's unreachableURL. This does nothing if no pages
have ever been loaded in this page.

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
If this is not a provisional load of substitute data for an unreachableURL
(e.g. someone who called WKPageLoadAlternateHTMLString), reset the
frame's unreachableURL.

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Update function signatures.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Pass whether or not this is a load of SubstituteData for an unreachableURL
to the UIProcess.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTMLString):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Plumb through the loading of the alternate HTML string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 22:29:11 +0000 (22:29 +0000)]
2010-10-19  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        commit-queue gets stuck when release-patch returns 404
        https://bugs.webkit.org/show_bug.cgi?id=47935

        Turns out ClientForm gets upset if passed an int() instead of a string type.
        Yay for untestable code.

        * Scripts/webkitpy/common/net/statusserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Anders Carlsson.
ap@apple.com [Tue, 19 Oct 2010 22:28:57 +0000 (22:28 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=47933
        <rdar://problem/8494337> navigator.language doesn't work in WebKit2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 James Simonsen <simonjam@chromium.org>
commit-queue@webkit.org [Tue, 19 Oct 2010 22:16:12 +0000 (22:16 +0000)]
2010-10-19  James Simonsen  <simonjam@chromium.org>

        Reviewed by Adam Barth.

        Add "in select" insertion mode to parser.

        This was added to the spec in:
        http://html5.org/tools/web-apps-tracker?from=5520&to=5522

        And as a result of:
        http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314

        https://bugs.webkit.org/show_bug.cgi?id=47706

        No new tests. Open to ideas.

        * html/parser/HTMLElementStack.cpp: Added "in select" mode.
        (WebCore::HTMLNames::isSelectScopeMarker): Ditto.
        (WebCore::HTMLElementStack::inSelectScope): Ditto.
        * html/parser/HTMLElementStack.h: Ditto.
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag): Use "in select" instead of "in table."
        (WebCore::HTMLTreeBuilder::processEndTag): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 19 Oct 2010 22:10:16 +0000 (22:10 +0000)]
2010-10-19  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Fix multiple index support in IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=47919

        Modify an existing test to verify behavior and add another test for
        something I thought might have been related (but wasn't, but it still
        seems like a good test).

        * storage/indexeddb/index-basics-expected.txt:
        * storage/indexeddb/index-basics.html:
        * storage/indexeddb/queued-commands-expected.txt: Added.
        * storage/indexeddb/queued-commands.html: Added.
2010-10-19  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Fix multiple index support in IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=47919

        Fix 2 bugs that caused the IndexData of all but the last index to be
        properly updated:
        * The objectStoreDataId is NOT unique if there are multiple indexes. So
          remove the constraint.
        * Do not delete all existing entries with that objectStoreDataId before
          adding an entry for each index. Only do it once at the beginning.

        Test: storage/indexeddb/queued-commands.html
            + index-basics.html modified

        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::deleteIndexData):
        (WebCore::putIndexData):
        (WebCore::IDBObjectStoreBackendImpl::putInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 22:06:52 +0000 (22:06 +0000)]
2010-10-19  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Will get Adam's commentary after his meeting
        for now this gets the commit-cluster back running.

        commit-queue gets stuck when release-patch returns 404
        https://bugs.webkit.org/show_bug.cgi?id=47935

        I taught NetworkTransaction the basics of 404 handling.
        We'll want to go back and teach it how to handle urllib2 404's too
        and then deploy it to the places that want it.

        * QueueStatusServer/handlers/releasepatch.py:
        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/networktransaction.py:
        * Scripts/webkitpy/common/net/statusserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 21:58:06 +0000 (21:58 +0000)]
2010-10-19  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Eric Seidel.

        [EFL] Add setting api for disabling auto resize window
        https://bugs.webkit.org/show_bug.cgi?id=47787

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::setWindowRect): Return when
        auto_resize_window was disabled.
        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):
        (ewk_view_setting_enable_auto_resize_window_get): Added.
        (ewk_view_setting_enable_auto_resize_window_set): Added.
        * ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Tue, 19 Oct 2010 21:42:19 +0000 (21:42 +0000)]
2010-10-19  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Geoffrey Garen.

        BytecodeGenerator::m_lastOpcodePosition must be initialized in all constructors
        https://bugs.webkit.org/show_bug.cgi?id=47920

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator): Add missing member initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 19 Oct 2010 21:38:45 +0000 (21:38 +0000)]
2010-10-19  Martin Robinson  <mrobinson@igalia.com>

        Fix the GTK+ build after r70072. The logic looks incorrect, but
        this fix tries to preserves it, even so.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (baselinePositionForAccessibilityRenderObject):
        (getAttributeSetForAccessibilityObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 21:19:58 +0000 (21:19 +0000)]
2010-10-19  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Fixing typos in my previous commit.

        Make patch release explicit and not a magic part of "retry" status
        https://bugs.webkit.org/show_bug.cgi?id=47909

        All of these typos again due to our inability to unit
        test much of this code.  I added one unit test where
        possible.  activeworkitems_unittest.py will be in a separate patch.

        * QueueStatusServer/handlers/releasepatch.py:
        * QueueStatusServer/main.py:
        * QueueStatusServer/model/activeworkitems.py:
        * QueueStatusServer/model/workitems.py:
        * QueueStatusServer/model/workitems_unittest.py:
        * QueueStatusServer/templates/releasepatch.html:
        * Scripts/webkitpy/common/net/statusserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 19 Oct 2010 21:18:29 +0000 (21:18 +0000)]
2010-10-19  James Robinson  <jamesr@chromium.org>

        Update chromium expectations.

        * platform/chromium/drt_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Tue, 19 Oct 2010 21:14:32 +0000 (21:14 +0000)]
2010-10-19  Antonio Gomes  <agomes@rim.com>

        Unreviewed complementary fix to r70058 (Part III).

        Skipping fast/dom/nodesFromRect-links-and-text.html instead of fast/dom/nodesFromRect-links-and-text-expected.html.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop waiting for sync replies if the connection is closed
andersca@apple.com [Tue, 19 Oct 2010 21:11:29 +0000 (21:11 +0000)]
Stop waiting for sync replies if the connection is closed
https://bugs.webkit.org/show_bug.cgi?id=47930

Reviewed by Adam Roben.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
Initialize m_shouldWaitForSyncReplies to true.

(CoreIPC::Connection::sendSyncMessage):
Don't attempt to send a message if m_shouldWaitForSyncReplies is false.

(CoreIPC::Connection::waitForSyncReply):
Return if m_shouldWaitForSyncReplies was set to false.

(CoreIPC::Connection::connectionDidClose):
Set m_shouldWaitForSyncReplies to true and signal the semaphore.

* Platform/CoreIPC/Connection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows: Implement 'preload=none'
jer.noble@apple.com [Tue, 19 Oct 2010 21:11:24 +0000 (21:11 +0000)]
Windows: Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=47317
<rdar://problem/7718442>

Reviewed by Eric Carlson.

WebCore:

Implement the 'preload=none' identically to the mac implementation. Add three new
ivars: m_preload, m_delayLoad and m_movieURL; and override the MediaPlayerPrivate
functions: prepareToPlay() and setPreload().

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
    Initialize new ivars m_delayLoad and m_preload.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::resumeLoad): Added; new.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Split contents between
    load and loadInternal.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal): Added; new.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::prepareToPlay): Added; overrides MediaPlayerPrivate.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPreload): Added; overrides MediaPlayerPrivate.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

LayoutTests:

Do not skip the media/video-preload.html test on windows any longer.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream support of KeyCodes for iOS
enrica@apple.com [Tue, 19 Oct 2010 21:03:12 +0000 (21:03 +0000)]
Upstream support of KeyCodes for iOS
https://bugs.webkit.org/show_bug.cgi?id=47857

Reviewed by Alexey Proskuryakov.

* platform/cocoa/KeyEventCocoa.mm:
(WebCore::windowsKeyCodeForCharCode): Added special handling of keyCodes for iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 19 Oct 2010 20:59:52 +0000 (20:59 +0000)]
2010-10-19  Zhenyao Mo  <zmo@google.com>

        Unreviewed, remove a passing webgl test from test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 19 Oct 2010 20:54:25 +0000 (20:54 +0000)]
2010-10-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Use webkit's TestNetscapePlugIn in DRT mac
        https://bugs.webkit.org/show_bug.cgi?id=47850

        * platform/chromium/drt_expectations.txt:  Update passing/failing test
            list.  More new passing tests than new failing tests.
2010-10-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Use webkit's TestNetscapePlugIn in DRT mac
        https://bugs.webkit.org/show_bug.cgi?id=47850

        * WebKit.gyp: Copy WebKitTestPlugIn into plugins and add
            GCC_SYMBOLS_PRIVATE_EXTERN: NO to export the symbols.
2010-10-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Use webkit's TestNetscapePlugIn in DRT mac
        https://bugs.webkit.org/show_bug.cgi?id=47850

        * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
            because we're going to name our plugin WebKitTestNetscapePlugIn
            temporarily until the chromium forked plugin goes away.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Tue, 19 Oct 2010 20:47:56 +0000 (20:47 +0000)]
2010-10-19  Antonio Gomes  <agomes@rim.com>

         Unreviewed complementary fix to r70058 (Part II).

         Skipping the test on Gtk, Qt and Windows, because they do not implement LayoutTestController::nodesFromRect.

         * platform/gtk/Skipped:
         * platform/qt/Skipped:
         * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 20:44:14 +0000 (20:44 +0000)]
2010-10-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        cr-mac bubble has caused status bubbles to wrap
        https://bugs.webkit.org/show_bug.cgi?id=47928

        We now have too many EWSes to fit in the bugs.webkit.org
        status-bubble iframe when more than a couple EWS builds are pending.
        To fix this I've reduced the space taken up by queue position,
        and also moved cr-mac to the end of the list (since it's going to be
        triple-digits for a while).

        * QueueStatusServer/model/queues.py:
        * QueueStatusServer/templates/statusbubble.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Tue, 19 Oct 2010 20:39:05 +0000 (20:39 +0000)]
2010-10-19  Antonio Gomes  <agomes@rim.com>

        Unreviewed complementary fix to r70058.

        * fast/dom/nodesFromRect-links-and-text-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-links-and-text-expected.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Tue, 19 Oct 2010 20:34:32 +0000 (20:34 +0000)]
2010-10-19  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        iOS: ASSERT in Cache::adjustSize running layout tests
        https://bugs.webkit.org/show_bug.cgi?id=47873

        Inside Cache::pruneDeadResources we loop over the LRU lists and make resources purgeable
        with Cache::makeResourcePurgeable(). This wasn't taking into account whether the resource
        was already purgeable or not, and the makeResourcePurgeable call was always calling
        adjustSize(). Now we make sure makeResourcePurgable only adjusts the size of the Cache's
        dead sizes when it first marks the resource purgeable. Likewise, if a resource is marked
        as purgeable and then evicted, we should not adjust the size again.

        The balancing call is when we have a resource that has been marked as purgeable and we
        successfully mark it as no longer purgeable in Cache::resourceForURL.

        No test added because this requires testing purgeable memory.

        * loader/Cache.cpp:
        (WebCore::Cache::makeResourcePurgeable):
        (WebCore::Cache::evict):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Tue, 19 Oct 2010 19:43:39 +0000 (19:43 +0000)]
2010-10-19  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by David Kilzer.

        RVCT fails to compile DateMath.cpp due to overloaded function pow
        https://bugs.webkit.org/show_bug.cgi?id=47844

        Choose std::pow(double, double) among multiple overloaded pow functions
        to fix build for RVCT.

        * wtf/DateMath.cpp:
        (WTF::parseES5DateFromNullTerminatedCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 19 Oct 2010 19:38:37 +0000 (19:38 +0000)]
2010-10-19  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Disable mipmapping for ImageLayer's to prevent memory use and
        performance regression.
        https://bugs.webkit.org/show_bug.cgi?id=47913

        This patch is a straight revert of the patch committed with issue 46493

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::SharedValues::SharedValues):
        (WebCore::ContentLayerChromium::updateTextureRect):
        * platform/graphics/chromium/ContentLayerChromium.h:
        (WebCore::ContentLayerChromium::SharedValues::initialized):
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 19 Oct 2010 19:23:49 +0000 (19:23 +0000)]
2010-10-19  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Kilzer.

        Use UChar instead of wchar_t in UnicodeWinCE
        https://bugs.webkit.org/show_bug.cgi?id=47904

        Make UnicodeWinCE more portable, so we can use it for other ports too.

        * wtf/unicode/wince/UnicodeWinCE.cpp:
        (WTF::Unicode::toLower):
        (WTF::Unicode::toUpper):
        (WTF::Unicode::foldCase):
        (WTF::Unicode::isPrintableChar):
        (WTF::Unicode::isSpace):
        (WTF::Unicode::isLetter):
        (WTF::Unicode::isUpper):
        (WTF::Unicode::isLower):
        (WTF::Unicode::isDigit):
        (WTF::Unicode::isPunct):
        (WTF::Unicode::isAlphanumeric):
        (WTF::Unicode::toTitleCase):
        (WTF::Unicode::mirroredChar):
        (WTF::Unicode::digitValue):
        * wtf/unicode/wince/UnicodeWinCE.h:
        (WTF::Unicode::isSeparatorSpace):
        (WTF::Unicode::isHighSurrogate):
        (WTF::Unicode::isLowSurrogate):
        (WTF::Unicode::umemcasecmp):
        (WTF::Unicode::surrogateToUcs4):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 19 Oct 2010 19:16:06 +0000 (19:16 +0000)]
2010-10-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        gl-teximage.html fails on chromium webkit mac bot
        https://bugs.webkit.org/show_bug.cgi?id=47034

        * platform/graphics/GraphicsContext3D.cpp: Deal with endians in 16 bit image data.
        (WebCore::convertColor16LittleTo8):
        (WebCore::convertColor16BigTo8):
        (WebCore::doPacking):
        * platform/graphics/GraphicsContext3D.h: Ditto.
        * platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto.
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=47841
hyatt@apple.com [Tue, 19 Oct 2010 18:38:14 +0000 (18:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47841

Reviewed by Dan Bernstein.

Rework baselinePosition and lineHeight to be writing-mode-aware.  There's a lot of refactoring here to clean up
the method parameters to be more readable and to simplify the subclassing of the various methods in order to
keep the horizontal/vertical querying to a minimum.

* WebCore.xcodeproj/project.pbxproj:
* mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::baselinePosition):
* mathml/RenderMathMLFraction.h:
* mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::baselinePosition):
* mathml/RenderMathMLOperator.h:
* mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::baselinePosition):
* mathml/RenderMathMLRow.h:
* mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::baselinePosition):
* mathml/RenderMathMLSubSup.h:
* mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::baselinePosition):
* mathml/RenderMathMLUnderOver.h:
* rendering/InlineBox.h:
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
* rendering/InlineTextBox.h:
* rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
* rendering/RenderBR.h:
(WebCore::toRenderBR):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::localCaretRect):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::verticalPosition):
* rendering/RenderBoxModelObject.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):
* rendering/RenderInline.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::baselinePosition):
* rendering/RenderListBox.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):
* rendering/RenderListMarker.h:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
* rendering/RenderReplaced.h:
* rendering/RenderSVGRoot.cpp:
* rendering/RenderSVGRoot.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::baselinePosition):
* rendering/RenderSlider.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::baselinePosition):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableCol):
* rendering/RenderTableRow.h:
* rendering/RenderTableSection.h:
* rendering/RenderText.cpp:
* rendering/RenderText.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::baselinePosition):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateBoundaries):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 18:30:00 +0000 (18:30 +0000)]
2010-10-19  Jia Pu  <jpu@apple.com>

        Reviewed by Adele Peterson.

        Moving cursor back to autocorrected word in the same line shouldn't remove the underline
        https://bugs.webkit.org/show_bug.cgi?id=47629
        <rdar://problem/8546758>

        * platform/mac-leopard/Skipped: New tests don't apply to this Mac OSX version.
        * platform/mac-snowleopard/Skipped: Ditto.
        * platform/mac-tiger/Skipped: Ditto.
        * platform/mac-wk2/Skipped: Ditto.
        * platform/mac/editing/spelling/autocorrection-delete-expected.checksum:
        * platform/mac/editing/spelling/autocorrection-delete-expected.png:
        * platform/mac/editing/spelling/click-autocorrected-word-expected.checksum: Added.
        * platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
        * platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
        * platform/mac/editing/spelling/click-autocorrected-word.html: Added.
        * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum: Added.
        * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
        * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
        * platform/mac/editing/spelling/delete-into-autocorrected-word.html: Added.
        * platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt: Added.
        * platform/mac/editing/spelling/delete-into-misspelled-word.html: Added.
        * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum: Added.
        * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
        * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
        * platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html: Added.
        * platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt: Added.
        * platform/mac/editing/spelling/move-cursor-around-misspelled-word.html: Added.
        * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum: Added.
        * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
        * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
        * platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html: Added.
        * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum: Added.
        * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
        * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
        * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Added.
2010-10-19  Jia Pu  <jpu@apple.com>

        Reviewed by Adele Peterson.

        Moving cursor back to autocorrected word in the same line shouldn't remove the underline
        https://bugs.webkit.org/show_bug.cgi?id=47629
        <rdar://problem/8546758>

        Tests: platform/mac/editing/spelling/click-autocorrected-word.html
               platform/mac/editing/spelling/delete-into-autocorrected-word.html
               platform/mac/editing/spelling/delete-into-misspelled-word.html
               platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
               platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
               platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
               platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html

        * editing/Editor.cpp:
        (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection
          underlines when cursor is moved onto a word.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 19 Oct 2010 18:02:01 +0000 (18:02 +0000)]
2010-10-19  Tony Chang  <tony@chromium.org>

        Unreviewed.  Rolling chromium DEPS to 63057 to pick up mac plugin
        loading in DRT.

        * DEPS: bump chromium DEPS to 63057.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by David Kilzer.
ap@apple.com [Tue, 19 Oct 2010 17:58:44 +0000 (17:58 +0000)]
    Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=47864
        Convert WebNSUserDefaultsExtras.m to .mm

        Also, fixed some issues in the process:
        - removed locking, which was only necessary when this code was in Foundation;
        - fixed notification center observer to actually work (previously, it picked up changes
        when application preferences changed, not when system language did);
        - removed unused NSString category;
        - updated style.

        * Misc/WebNSUserDefaultsExtras.m: Removed.
        * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
        (createHTTPStyleLanguageCode):
        (+[NSUserDefaults _webkit_defaultsDidChange]):
        (addLanguageChangeObserver):
        (+[NSUserDefaults _webkit_preferredLanguageCode]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 19 Oct 2010 17:56:44 +0000 (17:56 +0000)]
2010-10-19  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
        https://bugs.webkit.org/show_bug.cgi?id=47874

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix
aroben@apple.com [Tue, 19 Oct 2010 17:47:48 +0000 (17:47 +0000)]
Windows build fix

* WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
(WebKit::interruptForPolicyChangeError): Add a missing comma.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart 2 of:
weinig@apple.com [Tue, 19 Oct 2010 17:15:16 +0000 (17:15 +0000)]
Part 2 of:
Need to include WKErrorRef in the WKPageDidFail... functions
<rdar://problem/8564110>
https://bugs.webkit.org/show_bug.cgi?id=47871

Reviewed by Anders Carlsson.

* Shared/API/c/WKError.cpp:
(WKErrorCopyWKErrorDomain):
* Shared/API/c/WKError.h:
* Shared/WebError.cpp: Added.
(WebKit::WebError::webKitErrorDomain):
* Shared/WebError.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(+[NSError _webKitErrorWithCode:failingURL:]):
(registerErrors):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
* WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptForPolicyChangeError):
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 19 Oct 2010 17:10:20 +0000 (17:10 +0000)]
2010-10-19  Eric Carlson  <eric.carlson@apple.com>

        Not reviewed. Build fix.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectNextSourceChild): Initialize variable to avoid Windows
        "potentially uninitialized local variable" warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 19 Oct 2010 16:43:57 +0000 (16:43 +0000)]
2010-10-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] DumpRenderTree shouldn't put '.' in include path
        https://bugs.webkit.org/show_bug.cgi?id=47877

        * WebKit.gyp: Replace '.' with <(chromium_src_dir) and add public
2010-10-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] DumpRenderTree shouldn't put '.' in include path
        https://bugs.webkit.org/show_bug.cgi?id=47877

        Fix include paths.

        * DumpRenderTree/chromium/AccessibilityController.cpp:
        * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
        * DumpRenderTree/chromium/AccessibilityUIElement.h:
        * DumpRenderTree/chromium/CppBoundClass.cpp:
        * DumpRenderTree/chromium/CppVariant.cpp:
        * DumpRenderTree/chromium/CppVariant.h:
        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
        * DumpRenderTree/chromium/DRTDevToolsAgent.h:
        * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
        * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
        * DumpRenderTree/chromium/DRTDevToolsClient.h:
        * DumpRenderTree/chromium/EventSender.cpp:
        * DumpRenderTree/chromium/EventSender.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/MockSpellCheck.cpp:
        * DumpRenderTree/chromium/NotificationPresenter.cpp:
        * DumpRenderTree/chromium/NotificationPresenter.h:
        * DumpRenderTree/chromium/PlainTextController.cpp:
        * DumpRenderTree/chromium/Task.cpp:
        * DumpRenderTree/chromium/TestNavigationController.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        * DumpRenderTree/chromium/TestWebWorker.h:
        * DumpRenderTree/chromium/TextInputController.cpp:
        * DumpRenderTree/chromium/WebPreferences.cpp:
        * DumpRenderTree/chromium/WebPreferences.h:
        * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
        * DumpRenderTree/chromium/WebThemeEngineDRT.h:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 19 Oct 2010 16:43:37 +0000 (16:43 +0000)]
2010-10-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=46763
        CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal

        Fix crashes caused by moving and deleting <source> element(s) of active media element.

        Tests: media/video-source-moved.html
               media/video-source-removed.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Add logging. Initialize selectNextSourceChild.
        (WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto.
        (WebCore::HTMLMediaElement::insertedIntoDocument): Ditto.
        (WebCore::HTMLMediaElement::removedFromDocument): Ditto.
        (WebCore::HTMLMediaElement::scheduleLoad): Ditto.
        (WebCore::HTMLMediaElement::setNetworkState): Deal with m_currentSourceNode being null when
        the media engine signals a failure by skipping the error message and continuing as usual.
        (WebCore::HTMLMediaElement::setVolume): Fix logging typo.
        (WebCore::HTMLMediaElement::havePotentialSourceChild): Save and restore m_nextChildNodeToConsider
        around call to selectNextSourceChild because they are both significant.
        (WebCore::HTMLMediaElement::selectNextSourceChild): Use m_nextChildNodeToConsider to pick
        the first node to consider. Bail immediately if it signals that we have already processed
        every <source> node. Stach the node following the current source element in m_nextChildNodeToConsider
        so we can resume the search even if m_currentSourceNode is removed while it is being processed.
        (WebCore::HTMLMediaElement::sourceWasAdded): New, move logic from HTMLSourceElement::insertedIntoTree
        here and correct it to deal with a <source> node being inserted immediately after the
        current <source> node and a new <source> node being inserted at the end of the list after
        all candidates have failed.
        (WebCore::HTMLMediaElement::sourceWillBeRemoved): New, deal with current source node and next
        potential node being removed.
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::sourceChildEndOfListValue): New, define sentinal value used to indicate
        that all nodes have been processed.

        * html/HTMLSourceElement.cpp:
        (WebCore::HTMLSourceElement::HTMLSourceElement): Add logging.
        (WebCore::HTMLSourceElement::insertedIntoTree): Call mediaElement->sourceWasAdded instead
        of having logic here.
        (WebCore::HTMLSourceElement::willRemove): New, call mediaElement->sourceWillBeRemoved
        (WebCore::HTMLSourceElement::scheduleErrorEvent): Add logging.
        (WebCore::HTMLSourceElement::cancelPendingErrorEvent): Add logging.
        * html/HTMLSourceElement.h:

2010-10-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=46763
        CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal

        Test moving and deleting <source> element(s) of active <video>.

        * media/media-file.js:
        (mimeTypeForExtension): New, added to make it possible to set 'type' attribute on <source>.

        * media/video-source-moved-expected.txt: Added.
        * media/video-source-moved.html: Added.
        * media/video-source-removed-expected.txt: Added.
        * media/video-source-removed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Need to include WKErrorRef in the WKPageDidFail... functions
weinig@apple.com [Tue, 19 Oct 2010 15:56:30 +0000 (15:56 +0000)]
WebKit2: Need to include WKErrorRef in the WKPageDidFail... functions
<rdar://problem/8564110>
https://bugs.webkit.org/show_bug.cgi?id=47871

Reviewed by Dan Bernstein.

Give WebError a WebCore::ResourceError backing and start passing it over the wire
for failure cases.  Also, fill out the WKError API to include domain, errorCode,
failingURL and localizedDescription.

* Shared/API/c/WKError.cpp:
(WKErrorCopyDomain):
(WKErrorGetErrorCode):
(WKErrorCopyFailingURL):
(WKErrorCopyLocalizedDescription):
* Shared/API/c/WKError.h:
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebError.h:
(WebKit::WebError::create):
(WebKit::WebError::domain):
(WebKit::WebError::errorCode):
(WebKit::WebError::failingURL):
(WebKit::WebError::localizedDescription):
(WebKit::WebError::platformError):
(WebKit::WebError::WebError):
* UIProcess/API/C/WKPage.h:
* UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
* UIProcess/API/qt/ClientImpl.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):

WebKitTools: Need to include WKErrorRef in the WKPageDidFail... functions
https://bugs.webkit.org/show_bug.cgi?id=47871

Reviewed by Dan Bernstein.

Update tools for new parameter in failure callbacks.

* MiniBrowser/mac/BrowserWindowController.m:
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
* TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Christian Sejersen <christian.webkit@gmail.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 15:31:53 +0000 (15:31 +0000)]
2010-10-19  Christian Sejersen  <christian.webkit@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Scratchbox has an old version of python as the default one, so
        force it to use version 2.6.
        https://bugs.webkit.org/show_bug.cgi?id=47895

        * DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>
luiz@webkit.org [Tue, 19 Oct 2010 15:28:55 +0000 (15:28 +0000)]
2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Antti Koivisto.

        [Qt] WebKit2 MacOS build fix
        https://bugs.webkit.org/show_bug.cgi?id=47897

        Qt WebKit2 MacOS build fix.

        * bridge/npapi.h:
2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Antti Koivisto.

        [Qt] WebKit2 MacOS build fix
        https://bugs.webkit.org/show_bug.cgi?id=47897

        Qt WebKit2 MacOS build fix.

        * UIProcess/WebPageProxy.cpp:
        * WebKit2.pri:
        * WebKit2.pro:
2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Antti Koivisto.

        [Qt] WebKit2 MacOS build fix
        https://bugs.webkit.org/show_bug.cgi?id=47897

        Qt WebKit2 MacOS build fix.

        * WebKitTestRunner/PlatformWebView.h:
        * WebKitTestRunner/qt/TestControllerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 15:21:01 +0000 (15:21 +0000)]
2010-10-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch stats the filesystem too many times
        https://bugs.webkit.org/show_bug.cgi?id=47883

        This patch attempts to cache the list of changed files more agressively
        and to use that list to compute the diff instead of stating the file
        system again.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/editchangelog.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Tue, 19 Oct 2010 15:12:04 +0000 (15:12 +0000)]
2010-10-18 Antonio Gomes <agomes@rim.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add a test to nodesFromRect involving links and text nodes
        https://bugs.webkit.org/show_bug.cgi?id=47795

        Similarly to bug 47766 (Enrich /fast/dom/nodesFromRect-basic.html test,
        this patch continues to improve the test coverage for Document::nodesFromRect.
        This time tests involving links and text nodes are being added this time. Basically
        it performs various rect hit tests involving the positions of the elements.

        * fast/dom/nodesFromRect-links-and-text-expected.html: Added.
        * fast/dom/nodesFromRect-links-and-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
ddkilzer@apple.com [Tue, 19 Oct 2010 14:51:47 +0000 (14:51 +0000)]
<webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly

Reviewed by Darin Adler.

* Scripts/sort-Xcode-project-file:
- Don't print an error message about missing arguments when
  -h|--help is used.
- Allow Xcode project files to be specified as Project.xcodeproj
  instead of Project.xcodeproj/project.pbxproj.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 19 Oct 2010 14:37:03 +0000 (14:37 +0000)]
2010-10-19  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Soup cache code still has some warnings
        https://bugs.webkit.org/show_bug.cgi?id=47733

        Fixed some compilation warnings happening with gcc 4.4.5 on
        64-bits architecture.

        * platform/network/soup/cache/webkit/soup-cache.c:
        (webkit_soup_cache_entry_set_freshness):
        (close_ready_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 19 Oct 2010 14:12:18 +0000 (14:12 +0000)]
2010-10-19  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: crash while trying to step over a function using inspector
        https://bugs.webkit.org/show_bug.cgi?id=47902

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.reset): reset scripts panel to resumed state on navigation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 19 Oct 2010 13:44:18 +0000 (13:44 +0000)]
2010-10-19  Andreas Kling  <kling@webkit.org>

        Unreviewed, skip fast/canvas/canvas-getImageData-negative-source.html on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=47901

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update the Qt test expectations after r70047.
benm@google.com [Tue, 19 Oct 2010 12:52:42 +0000 (12:52 +0000)]
Unreviewed, update the Qt test expectations after r70047.

Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676

* platform/qt/fast/dom/Window/window-properties-expected.txt:
    Add the new APIs to the expected results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 12:47:26 +0000 (12:47 +0000)]
2010-10-19  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed attempt to remove warning in EFL build.

        Fix #if to #ifdef.

        No new features, so no tests added.

        * platform/efl/WidgetEfl.cpp:
        (WebCore::Widget::applyFallbackCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 19 Oct 2010 12:46:03 +0000 (12:46 +0000)]
2010-10-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] getImageData returns wrong data for non-0,0 source offset
        https://bugs.webkit.org/show_bug.cgi?id=47898

        Test: fast/canvas/canvas-getImageData-negative-source.html

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::getImageData): Add missing *4's to get correct pixel offset.
2010-10-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] getImageData returns wrong data for non-0,0 source offset
        https://bugs.webkit.org/show_bug.cgi?id=47898

        * fast/canvas/canvas-getImageData-negative-source-expected.txt: Added.
        * fast/canvas/canvas-getImageData-negative-source.html: Added.
        * fast/canvas/script-tests/canvas-getImageData-negative-source.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 19 Oct 2010 12:44:24 +0000 (12:44 +0000)]
2010-10-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Correct initial state of ImageBuffer QPen
        https://bugs.webkit.org/show_bug.cgi?id=47804

        Have the QPen on ImageBuffers start in Qt::SvgMiterJoin mode.

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBufferData::ImageBufferData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 19 Oct 2010 12:15:52 +0000 (12:15 +0000)]
2010-10-19  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay
        https://bugs.webkit.org/show_bug.cgi?id=46790

        Simple API addition to PlatformVideoWindow to allow
        implementations to optionally prepare their own PlatformWidget
        before applying the GStreamer XOverlay to it. This will likely be
        needed on Mac OSX only.

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::GStreamerGWorld::setWindowOverlay):
        * platform/graphics/gstreamer/PlatformVideoWindow.h:
        * platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
        (PlatformVideoWindow::prepareForOverlay):
        * platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:
        (PlatformVideoWindow::prepareForOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Ben Murdoch <benm@google.com>
benm@google.com [Tue, 19 Oct 2010 11:50:02 +0000 (11:50 +0000)]
2010-10-19  Ben Murdoch  <benm@google.com>

        Reviewed by Steve Block.

        Missing support for document.createTouch and document.createTouchList
        https://bugs.webkit.org/show_bug.cgi?id=47676

        Add tests to verify the presence of the APIs and that they work correctly.

        * fast/events/touch/document-create-touch-expected.txt: Added.
        * fast/events/touch/document-create-touch-list-expected.txt: Added.
        * fast/events/touch/document-create-touch-list.html: Added.
        * fast/events/touch/document-create-touch.html: Added.
        * fast/events/touch/script-tests/document-create-touch-list.js: Added.
        * fast/events/touch/script-tests/document-create-touch.js: Added.
2010-10-19  Ben Murdoch  <benm@google.com>

        Reviewed by Steve Block.

        Missing support for document.createTouch and document.createTouchList
        https://bugs.webkit.org/show_bug.cgi?id=47676

        These APIs are used by many sites to detect support for touch events.

        Implement the APIs according to the documentation at:
        http://developer.apple.com/library/safari/#documentation/UserExperience/Reference/DocumentAdditionsReference/DocumentAdditions/DocumentAdditions.html

        Tests: fast/events/touch/document-create-touch-list.html
               fast/events/touch/document-create-touch.html

        * bindings/js/JSBindingsAllInOne.cpp: Add new files to list.
        * bindings/js/JSTouchCustom.cpp: Added.
        (WebCore::toJSNewlyCreated):
        * bindings/js/JSTouchListCustom.cpp: Added.
        (WebCore::toJSNewlyCreated):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.cpp:
        (WebCore::Document::createTouch):
        (WebCore::Document::createTouchList):
        * dom/Document.h:
        * dom/Document.idl: Add createTouch and createTouchList functions.
        * Android.jscbindings.mk: Update makefiles.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 19 Oct 2010 10:38:27 +0000 (10:38 +0000)]
2010-10-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: migrate from legacy Object.properties to Object.keys, remove dead code.
        https://bugs.webkit.org/show_bug.cgi?id=47890

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._reportCompletions):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onGetResources):
        * inspector/front-end/HAREntry.js:
        (WebInspector.HARLog.prototype.build):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.):
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 19 Oct 2010 10:35:21 +0000 (10:35 +0000)]
2010-10-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not access ResourcePanel from resources directly.
        https://bugs.webkit.org/show_bug.cgi?id=47892

        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.set documentURL):
        (WebInspector.Resource.prototype.set startTime):
        (WebInspector.Resource.prototype.set responseReceivedTime):
        (WebInspector.Resource.prototype.set endTime):
        (WebInspector.Resource.prototype.set resourceSize):
        (WebInspector.Resource.prototype.set expectedContentLength):
        (WebInspector.Resource.prototype.set category):
        (WebInspector.Resource.prototype.set cached):
        (WebInspector.Resource.prototype.set mimeType):
        (WebInspector.Resource.prototype.get requestHeaders):
        (WebInspector.Resource.prototype.set requestHeaders):
        (WebInspector.Resource.prototype.get responseHeaders):
        (WebInspector.Resource.prototype.set responseHeaders):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.addResource):
        (WebInspector.ResourcesPanel.prototype.refreshResource):
        (WebInspector.ResourcesPanel.prototype._recreateViewForResourceIfNeeded):
        (WebInspector.ResourcesPanel.prototype._resourceViewIsConsistentWithCategory):
        (WebInspector.ResourceGraph):
        (WebInspector.ResourceGraph.prototype.refresh):
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot...
jocelyn.turcotte@nokia.com [Tue, 19 Oct 2010 10:34:56 +0000 (10:34 +0000)]
[Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
https://bugs.webkit.org/show_bug.cgi?id=47809

Reviewed by Andreas Kling.

Connecting a call to load from the loadFinished signal can cause
re-entrance crashes in WebCore. This patch uses a timer to do so,
also giving some time to subsequent frames to finish loading.

* QtTestBrowser/urlloader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
* QtTestBrowser/urlloader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 19 Oct 2010 10:21:52 +0000 (10:21 +0000)]
2010-10-19  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Pavel Feldman.

        Make sure WebSocket resource has the url field when it is created.

        Web Inspector: Uncaught TypeError when connection to WebSocket server is refused
        https://bugs.webkit.org/show_bug.cgi?id=47891

        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::createWebSocket):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 19 Oct 2010 09:05:49 +0000 (09:05 +0000)]
2010-10-19  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Fix style of UnicodeWinCE
        https://bugs.webkit.org/show_bug.cgi?id=47818

        * wtf/unicode/wince/UnicodeWinCE.cpp:
        (WTF::Unicode::toLower):
        (WTF::Unicode::toUpper):
        * wtf/unicode/wince/UnicodeWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Tue, 19 Oct 2010 08:57:14 +0000 (08:57 +0000)]
2010-10-19  Hayato Ito  <hayato@chromium.org>

        Reviewed by Darin Adler.

        Make CSS style selector non-recursive.
        https://bugs.webkit.org/show_bug.cgi?id=43783

        This change is one of the required changes to fix the following master bug:
        https://bugs.webkit.org/show_bug.cgi?id=42806

        To avoid recursion, we prepare a call stack and maintain a list of
        function call state by ourselves and try matching iteratively.

        * fast/css/long-css-selector-matches-expected.txt: Added.
        * fast/css/long-css-selector-matches.html: Added.
2010-10-19  Hayato Ito  <hayato@chromium.org>

        Reviewed by Darin Adler.

        Make CSS style selector non-recursive.
        https://bugs.webkit.org/show_bug.cgi?id=43783

        This change is one of the required changes to fix the following master bug:
        https://bugs.webkit.org/show_bug.cgi?id=42806

        To avoid recursion, we prepare a call stack and maintain a list of
        function call state by ourselves and try matching iteratively.

        Test: fast/css/long-css-selector-matches.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::checkSelector):
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Sergio Villar Senín <svillar@igalia.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 08:48:57 +0000 (08:48 +0000)]
2010-10-19  Sergio Villar Senín  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] http/history tests are failing
        https://bugs.webkit.org/show_bug.cgi?id=36173

        Removed skipped tests from http/history

        * platform/gtk/Skipped:
2010-10-19  Sergio Villar Senín  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] http/history tests are failing
        https://bugs.webkit.org/show_bug.cgi?id=36173

        Clear the history each time a test is run. Return the actual
        history item count when calling
        LayoutTestController::webHistoryItemCount

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::webHistoryItemCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 08:30:03 +0000 (08:30 +0000)]
2010-10-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r70034.
        http://trac.webkit.org/changeset/70034
        https://bugs.webkit.org/show_bug.cgi?id=47889

        "Gustavo's bot is lame" (Requested by xan_ on #webkit).

        * configure.ac:
2010-10-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r70034.
        http://trac.webkit.org/changeset/70034
        https://bugs.webkit.org/show_bug.cgi?id=47889

        "Gustavo's bot is lame" (Requested by xan_ on #webkit).

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::defaultCookieJar):
        (WebCore::setCookies):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::prepareForURL):
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Joone Hur <joone@kldp.org>
commit-queue@webkit.org [Tue, 19 Oct 2010 08:17:22 +0000 (08:17 +0000)]
2010-10-19  Joone Hur  <joone@kldp.org>

        Reviewed by Martin Robinson.

        [GTK] Needs fixing mistyped comments in the API documentation
        https://bugs.webkit.org/show_bug.cgi?id=47656

        Fixed mistyped comments in the API documenentation.

        * webkit/webkitwebsettings.cpp: Fixed a mistyped comment in the the section block.
        * webkit/webkitwebwindowfeatures.cpp: Fixed a mistyped comment in the section block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Prof. MAAD <himself@prof-maad.org>
commit-queue@webkit.org [Tue, 19 Oct 2010 07:58:38 +0000 (07:58 +0000)]
2010-10-19  Prof. MAAD  <himself@prof-maad.org>

        Reviewed by Xan Lopez.

        [GTK] Correct erroneous documentation for webkit_web_navigation_action_get_button()
        https://bugs.webkit.org/show_bug.cgi?id=46723

        * WebKit/gtk/webkit/webkitwebnavigationaction.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Oct 2010 07:50:55 +0000 (07:50 +0000)]
2010-10-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Bump minimum requirement for libsoup to 2.30
        https://bugs.webkit.org/show_bug.cgi?id=46176

        Bump minimum libsoup to required version to 2.30.0.

        * configure.ac:

WebCore:

2010-10-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Bump minimum requirement for libsoup to 2.30
        https://bugs.webkit.org/show_bug.cgi?id=46176

        Bump minimum required libsoup version to 2.30.

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::defaultCookieJar):
        (WebCore::setCookies):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::prepareForURL):
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Oct 2010 07:15:07 +0000 (07:15 +0000)]
2010-10-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Fix distcheck, take 2.

        * GNUmakefile.am: also move the generated CSS hash files to the
        build dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 19 Oct 2010 06:54:17 +0000 (06:54 +0000)]
2010-10-18  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed.

        Re-enabled editing/execCommand/remove-formatting.html and editing/execCommand/remove-formatting-2.html on Qt platforms.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 19 Oct 2010 06:34:20 +0000 (06:34 +0000)]
2010-10-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html
        https://bugs.webkit.org/show_bug.cgi?id=47792

        Converted editing/execCommand/remove-formatting.html and remove-formatting-2.html to dump-as-markup tests.

        * editing/execCommand/remove-formatting-2-expected.txt: Added.
        * editing/execCommand/remove-formatting-2.html:
        * editing/execCommand/remove-formatting-expected.txt: Added.
        * editing/execCommand/remove-formatting.html:
        * platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.png: Removed.
        * platform/chromium-linux/editing/execCommand/remove-formatting-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/remove-formatting-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-2-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-2-expected.txt: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-expected.txt: Removed.
        * platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
        * platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.png: Removed.
        * platform/mac-leopard/editing/execCommand/remove-formatting-expected.checksum: Removed.
        * platform/mac-leopard/editing/execCommand/remove-formatting-expected.png: Removed.
        * platform/mac/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
        * platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
        * platform/mac/editing/execCommand/remove-formatting-2-expected.txt: Removed.
        * platform/mac/editing/execCommand/remove-formatting-expected.checksum: Removed.
        * platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
        * platform/mac/editing/execCommand/remove-formatting-expected.txt: Removed.
        * platform/qt/editing/execCommand/remove-formatting-2-expected.txt: Removed.
        * platform/qt/editing/execCommand/remove-formatting-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 05:37:04 +0000 (05:37 +0000)]
2010-10-18  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Export QWebPage::ViewportAttributes class.
        https://bugs.webkit.org/show_bug.cgi?id=47845

        * Api/qwebpage.h:
        * symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 05:36:59 +0000 (05:36 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Chromium Mac EWS to the list of queues at queues.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=47878

        * QueueStatusServer/model/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 05:35:14 +0000 (05:35 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queues.webkit.org/next_patch is always 404
        https://bugs.webkit.org/show_bug.cgi?id=47881

        With the addition of the Queue class, I changed most of the
        code to lookup WorkItems using get_or_insert with a key_name
        instead of WorkItems.all().filter(queue_name=).
        Because the new get_or_insert code uses an explicit key_name
        (which is obviously different from the previously autogenerated
        ones), there were new WorkItem records created for each queue.
        However, some parts of the code still use WorkItems.all().filter,
        thus some parts were getting the new record and some parts the old record.

        The same basic bug was occurring with ActiveWorkItems, because I
        changed the key_name for that class as well.

        To fix this I've moved more of the code over to using Queue.*work_items.
        I've also enabled the datastore_admin (new in GAE 1.3.8) so that
        we can go delete the old WorkItems records.
        I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).

        * QueueStatusServer/app.yaml:
        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/handlers/recentstatus.py:
        * QueueStatusServer/handlers/updatestatus.py:
        * QueueStatusServer/handlers/updateworkitems.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 19 Oct 2010 05:33:57 +0000 (05:33 +0000)]
2010-10-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Should not save state of a detached form control.
        https://bugs.webkit.org/show_bug.cgi?id=47811

        * fast/forms/state-save-of-detached-control-expected.txt: Added.
        * fast/forms/state-save-of-detached-control.html: Added.
2010-10-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Should not save state of a detached form control.
        https://bugs.webkit.org/show_bug.cgi?id=47811

        Test: fast/forms/state-save-of-detached-control.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
          If the node is detached, don't save the state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Oct 2010 04:55:09 +0000 (04:55 +0000)]
2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Bump version numbers for 1.3.5 release.

        * configure.ac:

WebCore:

2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * GNUmakefile.am: add missing files.

WebKit/gtk:

2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * NEWS: update for 1.3.5 release.
        * docs/webkitgtk-sections.txt: add new APIs.

JavaScriptCore:

2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * GNUmakefile.am: add missing file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 04:48:23 +0000 (04:48 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Correct a bunch of typos in QueueStatusServer
        https://bugs.webkit.org/show_bug.cgi?id=47880

        These are all due to our complete lack of unit testing in QueueStatusServer.
        I added a couple unit tests to cover a few of these fixes, but most of these
        are still only caught by actually running the application.

        * QueueStatusServer/handlers/nextpatch.py:
        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/handlers/statusbubble_unittest.py: Added.
        * QueueStatusServer/handlers/updateworkitems.py:
        * QueueStatusServer/model/attachment.py:
        * QueueStatusServer/model/queuepropertymixin.py:
        * QueueStatusServer/model/queuepropertymixin_unittest.py:
        * QueueStatusServer/model/workitems.py:
        * QueueStatusServer/model/workitems_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 04:25:10 +0000 (04:25 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Disable this test because it's failing on the bots and the authors
        aren't around to fix it.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 04:11:01 +0000 (04:11 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CC authors of flaky tests when the commit-queue hits a flaky test
        https://bugs.webkit.org/show_bug.cgi?id=47872

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 04:05:11 +0000 (04:05 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make it possible to run a chromium-mac-ews builder
        https://bugs.webkit.org/show_bug.cgi?id=47876

        Since we can't run Mac OS X in a VM, we need to only run committer patches.
        There was a multiple inheritance problem which was holding this patch back,
        but I decided to just ignore the problem and go with a functional hack for now.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 19 Oct 2010 03:22:04 +0000 (03:22 +0000)]
2010-10-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Tony Chang.

        Regression in run_webkit_tests_unittest from r70017
        https://bugs.webkit.org/show_bug.cgi?id=47875

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 02:44:21 +0000 (02:44 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement webkit-patch suggest-reviewers
        https://bugs.webkit.org/show_bug.cgi?id=47866

        * Scripts/webkitpy/common/checkout/api.py:
            - The main logic.  We look at the last five changes to each
              modified (non-ChangeLog) file and collect up the reviewers of
              those changes as well as the authors of those changes who are
              reviewers.
        * Scripts/webkitpy/common/checkout/api_unittest.py:
            - Test the logic with some fun mocks.
        * Scripts/webkitpy/common/checkout/scm.py:
            - Fix a bug when you have local git commits.
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
            - Test that the bug is fixed.
        * Scripts/webkitpy/tool/commands/queries.py:
            - Add the query.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Kenneth Russell <kbr@google.com>
eric@webkit.org [Tue, 19 Oct 2010 02:37:49 +0000 (02:37 +0000)]
2010-10-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Eric Seidel.

        new-run-webkit-tests produces corrupt PNG baselines on Windows
        https://bugs.webkit.org/show_bug.cgi?id=47867

        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 19 Oct 2010 02:33:33 +0000 (02:33 +0000)]
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION: Feedly extension crashes Webkit
        https://bugs.webkit.org/show_bug.cgi?id=45811

        Make test cover large number of properties/string pairs, at two offsets to get the
        new allocation to occur at different locations.

        * fast/dom/Window/window-postmessage-clone-expected.txt:
        * fast/dom/Window/window-postmessage-clone.html:
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION: Feedly extension crashes Webkit
        https://bugs.webkit.org/show_bug.cgi?id=45811

        The basic problem was the deserializer was holding a pointer into
        the constant pool, but if you were sufficiently unlucky then the
        constant pool would be moved while still relying on the pointer,
        which leads to badness.

        I looked at just making all the sites this could happen extract the
        right string/jsstring before any possible allocations, but it seemed
        too fragile so i've gone for a forwarding object as the solution.

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneDeserializer::CachedStringRef::CachedStringRef):
        (WebCore::CloneDeserializer::CachedStringRef::operator->):
        (WebCore::CloneDeserializer::readStringData):
        (WebCore::CloneDeserializer::readFile):
        (WebCore::CloneDeserializer::readTerminal):
        (WebCore::CloneDeserializer::deserialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 19 Oct 2010 02:32:09 +0000 (02:32 +0000)]
2010-10-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Eric Seidel.

        new-run-webkit-tests produces corrupt PNG baselines on Windows
        https://bugs.webkit.org/show_bug.cgi?id=47867

        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 02:13:19 +0000 (02:13 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Deploy Queue class in more places throughout QueueStatusServer
        https://bugs.webkit.org/show_bug.cgi?id=47855

        I also caught two typos from the previous change.  Unfortunately
        I don't yet know how to unittest request handlers yet.

        * QueueStatusServer/handlers/dashboard.py:
        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/handlers/updateworkitems.py:
        * QueueStatusServer/model/activeworkitems.py:
        * QueueStatusServer/model/attachment.py:
        * QueueStatusServer/model/queuepropertymixin.py: Added.
        * QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
        * QueueStatusServer/model/queuestatus.py:
        * QueueStatusServer/model/workitems.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 19 Oct 2010 01:59:09 +0000 (01:59 +0000)]
2010-10-18  Chris Rogers  <crogers@google.com>

        Reviewed by Chris Fleizach.

        Add AudioResampler files
        https://bugs.webkit.org/show_bug.cgi?id=47623

        No new tests since audio API is not yet implemented.

        * platform/audio/AudioResampler.cpp: Added.
        (WebCore::AudioResampler::AudioResampler):
        (WebCore::AudioResampler::configureChannels):
        (WebCore::AudioResampler::process):
        (WebCore::AudioResampler::setRate):
        (WebCore::AudioResampler::reset):
        * platform/audio/AudioResampler.h: Added.
        (WebCore::AudioResampler::~AudioResampler):
        (WebCore::AudioResampler::rate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 01:38:00 +0000 (01:38 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        scm.py should be able tell us what revisions made changes to a given file
        https://bugs.webkit.org/show_bug.cgi?id=47863

        Look again, your SCM.py can now log files.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 19 Oct 2010 01:02:35 +0000 (01:02 +0000)]
2010-10-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Siedel.

        new-run-webkit-tests: clean up the options-parsing code in the port
        classes.

        This change modifies the Port interface to have a get_option() and
        set_option_default() method for accessing the options argument
        passed to the constructor. If the constructor is not passed an
        options argument, we default to a MockOptions() argument from
        mocktool, which has the same semantics we want.

        Note that there is a disadvantage to port.get_option('foo') over
        port._options.foo, which is that you lose some of the checking
        for whether 'foo' is set (typos result in the default value, not
        an exception being raised. This is desired in this case, since the
        Port class is not allowed to assume that options does have any
        particular values set, and so this change ensures that all of
        the subclasses are following the same, intended, logic.

        Arguably this is the wrong semantics to have, and the Port
        classes should be able to assume a default set of
        attributes/arguments, but that change will need to wait for a
        different CL where we can modify new-run-webkit-tests to pull a
        list of arguments from the port factory routines.

        Also, add unit tests for webkitpy.tool.mocktool.MockOptions .

        https://bugs.webkit.org/show_bug.cgi?id=47510

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
        * Scripts/webkitpy/tool/mocktool_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70013 268f45cc-cd09-0410-ab3c-d52691b4dbfc