WebKit-https.git
8 years agoAX: re-organize fake elements to use new AccessibilityMockObject
cfleizach@apple.com [Fri, 7 Oct 2011 19:12:59 +0000 (19:12 +0000)]
AX: re-organize fake elements to use new AccessibilityMockObject
https://bugs.webkit.org/show_bug.cgi?id=69588

This adds an AccessibilityMockObject for "fake" elements to descend from.
Its benefit is to consolidate the various ways that these fake elements are setting
and returning their parent objects.

No functional change, hence no new tests.

Reviewed by Jon Honeycutt.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addChildren):
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
* accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::node):
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::addChildren):
* accessibility/AccessibilityMenuList.h:
(WebCore::toAccessibilityMenuList):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
(WebCore::AccessibilityMenuListOption::isVisible):
* accessibility/AccessibilityMenuListOption.h:
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
(WebCore::AccessibilityMenuListPopup::isOffScreen):
(WebCore::AccessibilityMenuListPopup::isEnabled):
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
(WebCore::AccessibilityMenuListPopup::press):
(WebCore::AccessibilityMenuListPopup::addChildren):
(WebCore::AccessibilityMenuListPopup::childrenChanged):
(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityMockObject.cpp: Added.
(WebCore::AccessibilityMockObject::AccessibilityMockObject):
(WebCore::AccessibilityMockObject::~AccessibilityMockObject):
* accessibility/AccessibilityMockObject.h: Added.
(WebCore::AccessibilityMockObject::parentObject):
(WebCore::AccessibilityMockObject::setParent):
(WebCore::AccessibilityMockObject::detachFromParent):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::addChildren):
(WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::elementRect):
* accessibility/AccessibilitySlider.h:
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::headerContainer):
* accessibility/AccessibilityTable.h:
(WebCore::toAccessibilityTable):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
(WebCore::AccessibilityTableColumn::setParent):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::headerObjectForSection):
(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
(WebCore::AccessibilityTableColumn::addChildren):
* accessibility/AccessibilityTableColumn.h:
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
(WebCore::AccessibilityTableHeaderContainer::addChildren):
* accessibility/AccessibilityTableHeaderContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix 32-bit build.
oliver@apple.com [Fri, 7 Oct 2011 18:57:41 +0000 (18:57 +0000)]
Fix 32-bit build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix chromium compile when using the components build. This test
tony@chromium.org [Fri, 7 Oct 2011 18:55:13 +0000 (18:55 +0000)]
Fix chromium compile when using the components build.  This test
helper file is using methods not available when compiling as a dll.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r96257): fast/repaint/selection-clear.html fail
rniwa@webkit.org [Fri, 7 Oct 2011 18:47:57 +0000 (18:47 +0000)]
REGRESSION(r96257): fast/repaint/selection-clear.html fail
https://bugs.webkit.org/show_bug.cgi?id=69060

Reviewed by Enrica Casucci.

After r96257, we no longer clear selection upon node removal so the selection should
still be rendered after the node removal in this test.

Changed the color of selection from red to green to indicate the success.

* fast/repaint/selection-clear.html:
* platform/mac/fast/repaint/selection-clear-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport direct calls to intrinsic functions
oliver@apple.com [Fri, 7 Oct 2011 18:39:45 +0000 (18:39 +0000)]
Support direct calls to intrinsic functions
https://bugs.webkit.org/show_bug.cgi?id=69646

Reviewed by Gavin Barraclough.

Add support for optimising non-method_check calls
to intrinsic functions (eg. when Math.abs, etc are
cached in local variables).

* bytecode/CodeBlock.h:
(JSC::getCallLinkInfoBytecodeIndex):
    Support searching CallLinkInfos by bytecode index
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
    Add support for linked calls in addition to method_check
    when searching for intrinsics
* dfg/DFGNode.h:
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::function):
    Add ability to store a JSFunction* in a node - this is safe
    as the function will be marked by the codeblock we're compiling
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::checkFunctionElimination):
(JSC::DFG::Propagator::performNodeCSE):
    Add support for new CheckFunction node, and implement CSE pass.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
    Rather trivial implementation of CheckFunction
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
    Need to propagate bytecode index for calls now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
japhet@chromium.org [Fri, 7 Oct 2011 18:16:03 +0000 (18:16 +0000)]
Make IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
This is one of the steps required to remove the SubresourceLoaderClient interface,
which will simplify the layering in the loader.
https://bugs.webkit.org/show_bug.cgi?id=69567

Reviewed by Adam Barth.

No new tests, no functionality change intended.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/cache/CachedRawResource.cpp: Added.
* loader/cache/CachedRawResource.h: Added.
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
(WebCore::CachedResource::ignoreForRequestCount): Renamed and generalized from isLinkResource(),
    which was only used to decided whether the CachedResource should count toward
    CachedResourceLoader::requestCount().
* loader/cache/CachedResourceLoader.cpp:
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
* loader/cache/CachedResourceRequest.h:
* loader/icon/IconLoader.cpp: Get a CachedResource instead of a SubresourceLoader.
(WebCore::IconLoader::notifyFinished): Merge in the status code check that was in didReceiveResponse(),
    since we won't be checking any callbacks before the load completes.
* loader/icon/IconLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update test_expectations after V8 roll.
simonjam@chromium.org [Fri, 7 Oct 2011 18:14:06 +0000 (18:14 +0000)]
[Chromium] Update test_expectations after V8 roll.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WebCore platform interfaces needed by updated PeerConnection design
commit-queue@webkit.org [Fri, 7 Oct 2011 18:06:40 +0000 (18:06 +0000)]
Add WebCore platform interfaces needed by updated PeerConnection design
https://bugs.webkit.org/show_bug.cgi?id=68460

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-10-07
Reviewed by Adam Barth.

Added the PeerConnection platform files to WebCore/platform/mediastream

Currently not testable.

* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/mediastream/MediaStreamComponent.h: Added.
(WebCore::MediaStreamComponent::create):
(WebCore::MediaStreamComponent::source):
(WebCore::MediaStreamComponent::enabled):
(WebCore::MediaStreamComponent::setEnabled):
(WebCore::MediaStreamComponent::MediaStreamComponent):
* platform/mediastream/MediaStreamDescriptor.h: Added.
(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::owner):
(WebCore::MediaStreamDescriptor::setOwner):
(WebCore::MediaStreamDescriptor::label):
(WebCore::MediaStreamDescriptor::component):
(WebCore::MediaStreamDescriptor::numberOfComponents):
(WebCore::MediaStreamDescriptor::ended):
(WebCore::MediaStreamDescriptor::setEnded):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
* platform/mediastream/MediaStreamSource.h: Added.
(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::id):
(WebCore::MediaStreamSource::type):
(WebCore::MediaStreamSource::name):
(WebCore::MediaStreamSource::muted):
(WebCore::MediaStreamSource::setMuted):
(WebCore::MediaStreamSource::MediaStreamSource):
* platform/mediastream/PeerHandler.cpp: Added.
(WebCore::PeerHandler::PeerHandler):
(WebCore::PeerHandler::~PeerHandler):
(WebCore::PeerHandler::produceInitialOffer):
(WebCore::PeerHandler::handleInitialOffer):
(WebCore::PeerHandler::processSDP):
(WebCore::PeerHandler::processPendingStreams):
(WebCore::PeerHandler::sendDataStreamMessage):
(WebCore::PeerHandler::stop):
* platform/mediastream/PeerHandler.h: Added.
(WebCore::PeerHandlerClient::~PeerHandlerClient):
(WebCore::PeerHandler::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobackground-color affects the font color in disabled textarea.
commit-queue@webkit.org [Fri, 7 Oct 2011 17:44:07 +0000 (17:44 +0000)]
background-color affects the font color in disabled textarea.
https://bugs.webkit.org/show_bug.cgi?id=65361

Patch by Vineet Chaudary <vineet.chaudhary@motorola.com> on 2011-10-07
Reviewed by Darin Adler.

Source/WebCore:

For the transparent/translucent background colors use lightening fortext color.

* rendering/RenderTextControl.cpp:
(WebCore::disabledTextColor):

LayoutTests:

For the background-color White and transparent the text color should be same.

* fast/forms/input-disabled-color.html: Modified test case.
* platform/chromium/test_expectations.txt: Needs rebaseline.
* platform/gtk/fast/forms/input-disabled-color-expected.png: Changed expected result.
* platform/gtk/fast/forms/input-disabled-color-expected.txt: Changed expected result.
* platform/mac/test_expectations.txt: Needs rebaseline.
* platform/qt/test_expectations.txt: Needs rebaseline.
* platform/win/test_expectations.txt: Needs rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd missing tests for LegacyDefaultOptionalArguments/FileAPI IDL
abarth@webkit.org [Fri, 7 Oct 2011 17:20:55 +0000 (17:20 +0000)]
Add missing tests for LegacyDefaultOptionalArguments/FileAPI IDL
https://bugs.webkit.org/show_bug.cgi?id=66236

Reviewed by Darin Adler.

These APIs are all very new and everyone who's using them should be
aware that they are vendor-prefixed and subject to adjustments as the
spec evolves.  Recently, we changed these APIs to more carefully check
whether required parameters are actually present.  This patch adds
tests to verify that we're doing the proper checks.

* fast/files/not-enough-arguments-expected.txt: Added.
* fast/files/not-enough-arguments.html: Added.
* fast/filesystem/not-enough-arguments-expected.txt: Added.
* fast/filesystem/not-enough-arguments.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement currentColor support for box-shadow and text-shadow
commit-queue@webkit.org [Fri, 7 Oct 2011 17:00:44 +0000 (17:00 +0000)]
Implement currentColor support for box-shadow and text-shadow
https://bugs.webkit.org/show_bug.cgi?id=68218

Source/WebCore:

Patch by David Barr <davidbarr@chromium.org> on 2011-10-07
Reviewed by Simon Fraser.

Test: fast/box-shadow/box-shadow-currentcolor.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseShadow): Add CSSValueCurrentcolor to supported keywords.

LayoutTests:

Patch by David Barr <davidbarr@google.com> on 2011-10-07
Reviewed by Simon Fraser.

* fast/box-shadow/box-shadow-currentcolor-expected.png: Added.
* fast/box-shadow/box-shadow-currentcolor-expected.txt: Added.
* fast/box-shadow/box-shadow-currentcolor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add Audits panel to the compilation.
pfeldman@chromium.org [Fri, 7 Oct 2011 16:44:42 +0000 (16:44 +0000)]
Web Inspector: add Audits panel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69633

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/AuditCategories.js:
* inspector/front-end/AuditLauncherView.js:
* inspector/front-end/AuditResultView.js:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
* inspector/front-end/NetworkLog.js:
* inspector/front-end/treeoutline.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFunctions that return "const Color" should simply return "Color".
andreas.kling@nokia.com [Fri, 7 Oct 2011 16:42:54 +0000 (16:42 +0000)]
Functions that return "const Color" should simply return "Color".

Rubber-stamped by Antti Koivisto.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::rendererBackgroundColor):
* rendering/RenderLayerBacking.h:
* rendering/RenderTable.h:
(WebCore::RenderTable::bgColor):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove setShouldPaintCustomScrollbars, which has no callers
abarth@webkit.org [Fri, 7 Oct 2011 16:35:29 +0000 (16:35 +0000)]
Remove setShouldPaintCustomScrollbars, which has no callers
https://bugs.webkit.org/show_bug.cgi?id=69300

Reviewed by Darin Adler.

Anders tells me this function no longer has any callers.  We should
remove it before it grows any!

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
pfeldman@chromium.org [Fri, 7 Oct 2011 16:33:00 +0000 (16:33 +0000)]
Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
https://bugs.webkit.org/show_bug.cgi?id=69634

Reviewed by Yury Semikhatsky.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink BorderValue.
andreas.kling@nokia.com [Fri, 7 Oct 2011 16:24:31 +0000 (16:24 +0000)]
Shrink BorderValue.
https://bugs.webkit.org/show_bug.cgi?id=69521

Reviewed by Antti Koivisto.

Unroll BorderValue's Color member so we can pack the color's validity flag
in BorderValue's bitfield.

This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
16 bytes. This reduces memory consumption by 760 kB when loading the full
HTML5 spec.

* platform/graphics/Color.h:
(WebCore::Color::Color):

    Allow construction of Color objects with specific validity.

* rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):
* rendering/style/OutlineValue.h:
(WebCore::OutlineValue::operator==):

    Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
    Made those variables private and added color(), setColor() accessors.

* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):

    Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
    when setting BorderValue colors.

(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

    Made color getters return "Color" instead of "const Color&" since
    BorderValue no longer has an actual object to return the reference to.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyColor::applyInheritValue):
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):

    Adapt to RenderStyle color getters now returning "Color" instead of
    "const Color&".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
commit-queue@webkit.org [Fri, 7 Oct 2011 16:22:01 +0000 (16:22 +0000)]
[EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=66380

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-07
Reviewed by Antonio Gomes.

This encapsulates EWebKit into an object that manages multiple windows
and provides a cleaner interface to EFL's DumpRenderTree.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
(DumpRenderTreeChrome::create):
(DumpRenderTreeChrome::DumpRenderTreeChrome):
(DumpRenderTreeChrome::~DumpRenderTreeChrome):
(DumpRenderTreeChrome::createNewWindow):
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::removeWindow):
(DumpRenderTreeChrome::initialize):
(DumpRenderTreeChrome::extraViews):
(DumpRenderTreeChrome::mainFrame):
(DumpRenderTreeChrome::mainView):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onWindowObjectCleared):
(DumpRenderTreeChrome::onLoadStarted):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::onLoadFinished):
(DumpRenderTreeChrome::onStatusbarTextSet):
(DumpRenderTreeChrome::onTitleChanged):
(DumpRenderTreeChrome::onDocumentLoadFinished):
* DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
* DumpRenderTree/efl/EventSender.cpp:
(sendClick): Use browser->mainFrame() instead of mainFrame.
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.
(mouseMoveToCallback): Ditto.
(mouseScrollByCallback): Ditto.
(keyDownCallback): Ditto.
(scalePageByCallback): Ditto.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::counterValueForElementById): Use
browser->mainFrame() instead of mainFrame.
(LayoutTestController::pageNumberForElementById): Ditto.
(LayoutTestController::numberOfPages): Ditto.
(LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
(LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
(LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
(LayoutTestController::numberOfActiveAnimations): Ditto.
(LayoutTestController::suspendAnimations): Ditto.
(LayoutTestController::resumeAnimations): Ditto.
(LayoutTestController::setWebViewEditable): Ditto.
(LayoutTestController::webHistoryItemCount): Use browser->mainView()
instead of browser.
(LayoutTestController::queueLoad): Ditto.
(LayoutTestController::setAcceptsEditing): Ditto.
(LayoutTestController::setUserStyleSheetEnabled): Ditto.
(LayoutTestController::setPrivateBrowsingEnabled): Ditto.
(LayoutTestController::setFrameFlatteningEnabled): Ditto.
(LayoutTestController::setSpatialNavigationEnabled): Ditto.
(LayoutTestController::setPluginsEnabled): Ditto.
(LayoutTestController::findString): Ditto.
(LayoutTestController::setDeveloperExtrasEnabled): Ditto.
* DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
(createBitmapContextFromWebView): Use browser->mainFrame() instead of
mainFrame.
* DumpRenderTree/efl/WorkQueueItemEfl.cpp:
(LoadItem::invoke): Ditto.
(LoadHTMLStringItem::invoke): Ditto.
(ScriptItem::invoke): Ditto.
(ReloadItem::invoke): Use browser->mainView() instead of browser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL
philn@webkit.org [Fri, 7 Oct 2011 16:16:28 +0000 (16:16 +0000)]
[GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL
https://bugs.webkit.org/show_bug.cgi?id=69630

Reviewed by Martin Robinson.

Use G_DEFINE_TYPE_WITH_CODE instead of GST_BOILERPLATE_FULL and
replace use of gst_ghost_pad_new_no_target_from_template() and
gst_ghost_pad_set_target() with a single call to
gst_ghost_pad_new_from_template(). These changes keep the element
compatible with GStreamer 0.10 while preparing the port to 0.11.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_class_init):
(webkit_web_src_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Freetype] Pseudo-italics do not work
commit-queue@webkit.org [Fri, 7 Oct 2011 15:51:04 +0000 (15:51 +0000)]
[Freetype] Pseudo-italics do not work
https://bugs.webkit.org/show_bug.cgi?id=40856

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-07
Reviewed by Philippe Normand.

Source/WebCore:

* platform/graphics/freetype/FontPlatformData.h: Add the font description as an argument initializeWithFontFace.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData): Pass the font description to initializeWithFontFace.
(WebCore::FontPlatformData::initializeWithFontFace): If we were asked for an italic font and we were
given one that wasn't oblique or italic, activate the synthetic oblique bit.

LayoutTests:

Add test results which show this test passing now.

* platform/gtk/Skipped: Unskip a passing test.
* platform/gtk/fast/text/fake-italic-expected.png: Added.
* platform/gtk/fast/text/fake-italic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] avoid direct access to GstMessage structure field
philn@webkit.org [Fri, 7 Oct 2011 15:47:54 +0000 (15:47 +0000)]
[GStreamer] avoid direct access to GstMessage structure field
https://bugs.webkit.org/show_bug.cgi?id=69629

Reviewed by Martin Robinson.

Use gst_message_get_structure() instead of direct access to the
structure field. No direct benefit apart from compatibility with
GStreamer 0.11.

* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::gstGWorldSyncMessageCallback):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add timeline panel to the compilation.
pfeldman@chromium.org [Fri, 7 Oct 2011 15:36:19 +0000 (15:36 +0000)]
Web Inspector: add timeline panel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69628

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/SidebarTreeElement.js:
(WebInspector.SidebarTreeElement):
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer.prototype.nextToken):
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/TimelineGrid.js:
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.updateMainViewWidth):
(WebInspector.TimelinePanel.prototype.onResize):
(WebInspector.TimelinePanel.prototype._windowChanged):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineRecordGraphRow.prototype._onClick):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] ApplicationCache LayoutTests failed
qi.2.zhang@nokia.com [Fri, 7 Oct 2011 15:09:13 +0000 (15:09 +0000)]
[Qt][WK2] ApplicationCache LayoutTests failed
https://bugs.webkit.org/show_bug.cgi?id=69541

Reviewed by Chang Shu.

Source/WebKit2:

1. Moved applicationCacheDirectory to common code.
2. Added interface setApplicationCacheDirectory to allow UI client overriding.
3. Renamed all platform-dependent implementations of applicationCacheDirectory to platformDefaultApplicationCacheDirectory.
4. On Qt, set the platformDefaultApplicationCacheDirectory to the default data location.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::applicationCacheDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setApplicationCacheDirectory):
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

LayoutTests:

Unskip passed tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96892.
podivilov@chromium.org [Fri, 7 Oct 2011 14:56:12 +0000 (14:56 +0000)]
Unreviewed, rolling out r96892.
http://trac.webkit.org/changeset/96892
https://bugs.webkit.org/show_bug.cgi?id=69626

it broke windows canary bots (Requested by podivilov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

* WebCore.gyp/scripts/rule_binding.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Disable ThreadRestrictionVerifier for JIT ExecutableMemoryHandles
dominicc@chromium.org [Fri, 7 Oct 2011 14:49:45 +0000 (14:49 +0000)]
[JSC] Disable ThreadRestrictionVerifier for JIT ExecutableMemoryHandles
https://bugs.webkit.org/show_bug.cgi?id=69599

Reviewed by Sam Weinig.

DFG JIT manipulates MetaAllocatorHandles across threads, eg in
allocating JITCode buffers on a background thread to execute a
proxy autoconfiguration PAC file but garbage collecting it in
response to allocation on the main thread. Disabling
ThreadRestrictionVerification until there is a verification scheme
that understands this handoff.

* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::allocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink StyleInheritedData.
andreas.kling@nokia.com [Fri, 7 Oct 2011 14:28:40 +0000 (14:28 +0000)]
Shrink StyleInheritedData.
https://bugs.webkit.org/show_bug.cgi?id=69625

Reviewed by Antti Koivisto.

Rearrange the members of StyleInheritedData to fold as much
as possible into the padding at the end of RefCounted.

This shrinks StyleInheritedData by 8 bytes on 64-bit, reducing
memory consumption by 500 kB when loading the full HTML5 spec.

* rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
* rendering/style/StyleInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skip failing svg test in GTK.
philn@webkit.org [Fri, 7 Oct 2011 14:18:56 +0000 (14:18 +0000)]
Unreviewed, skip failing svg test in GTK.

* platform/gtk/Skipped: Skip svg/filters/feColorMatrix-saturate.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skip http/tests/multipart/load-last-non-html-frame.php in GTK.
philn@webkit.org [Fri, 7 Oct 2011 14:08:34 +0000 (14:08 +0000)]
Unreviewed, skip http/tests/multipart/load-last-non-html-frame.php in GTK.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: make ScriptsPanel compile
pfeldman@chromium.org [Fri, 7 Oct 2011 13:55:43 +0000 (13:55 +0000)]
Web Inspector: make ScriptsPanel compile
https://bugs.webkit.org/show_bug.cgi?id=69623

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):
* inspector/front-end/DebuggerModel.js:
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
* inspector/front-end/KeyboardShortcut.js:
* inspector/front-end/Object.js:
* inspector/front-end/ObjectPropertiesSection.js:
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
* inspector/front-end/StatusBarButton.js:
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update.appendResult):
(WebInspector.WatchExpressionsSection.prototype.update):
(WebInspector.WatchExpressionTreeElement.prototype.startEditing):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype._openInspectorWindow):
(WebInspector.WorkerManager.prototype._pageInspectorClosing):
(WebInspector.DedicatedWorkerMessageForwarder.prototype._receiveMessage):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype.removeWorker):
* inspector/front-end/externs.js:
(WebInspector.linkifyURL):
(InjectedFakeWorker):
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
hausmann@webkit.org [Fri, 7 Oct 2011 12:34:12 +0000 (12:34 +0000)]
[Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
https://bugs.webkit.org/show_bug.cgi?id=69617

Reviewed by Andreas Kling.

Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
logic.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
* MiniBrowser/qt/MiniBrowserApplication.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96879.
podivilov@chromium.org [Fri, 7 Oct 2011 12:17:00 +0000 (12:17 +0000)]
Unreviewed, rolling out r96879.
http://trac.webkit.org/changeset/96879
https://bugs.webkit.org/show_bug.cgi?id=69618

Broke CCLayerTreeHostTestShortlived1 on chromium mac.
(Requested by podivilov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

* features.gypi:
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onEndTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add ResourcesPanel to the compilation.
pfeldman@chromium.org [Fri, 7 Oct 2011 11:35:25 +0000 (11:35 +0000)]
Web Inspector: add ResourcesPanel to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69612

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/ResourceView.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
(WebInspector.ResourcesPanel.prototype.showResource):
(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.StorageCategoryView):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.last):
* inspector/front-end/externs.js:
(WebInspector.openRequestInNetworkPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] http/tests/multipart/load-last-non-html-frame.php is failing
zoltan@webkit.org [Fri, 7 Oct 2011 11:11:41 +0000 (11:11 +0000)]
[Qt] http/tests/multipart/load-last-non-html-frame.php is failing
https://bugs.webkit.org/show_bug.cgi?id=69615

Ossyize failing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96909.
podivilov@chromium.org [Fri, 7 Oct 2011 10:59:22 +0000 (10:59 +0000)]
Unreviewed, rolling out r96909.
http://trac.webkit.org/changeset/96909
https://bugs.webkit.org/show_bug.cgi?id=69616

Broke chromium mac compilation (Requested by podivilov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebCore:

* platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebContentLayer.h: Removed.
* public/WebContentLayerClient.h: Removed.
* public/WebLayer.h: Removed.
* public/WebLayerClient.h: Removed.
* public/WebLayerTreeView.h: Removed.
* public/WebLayerTreeViewClient.h: Removed.
* src/WebContentLayer.cpp: Removed.
* src/WebContentLayerImpl.cpp: Removed.
* src/WebContentLayerImpl.h: Removed.
* src/WebLayer.cpp: Removed.
* src/WebLayerImpl.cpp: Removed.
* src/WebLayerImpl.h: Removed.
* src/WebLayerTreeView.cpp: Removed.
* src/WebLayerTreeViewImpl.cpp: Removed.
* src/WebLayerTreeViewImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 7 Oct 2011 10:54:20 +0000 (10:54 +0000)]
2011-10-07  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, revert r96924.

        * public/WebContentLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Element highlighting does not highlight padding/border/margin for...
vsevik@chromium.org [Fri, 7 Oct 2011 10:19:25 +0000 (10:19 +0000)]
Web Inspector: Element highlighting does not highlight padding/border/margin for inline elements.
https://bugs.webkit.org/show_bug.cgi?id=69558

Reviewed by Pavel Feldman.

* inspector/DOMNodeHighlighter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 7 Oct 2011 10:12:15 +0000 (10:12 +0000)]
2011-10-07  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix mac build after r96909.

        * public/WebContentLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTurn ENABLE_VIDEO_TRACK on for chromium.
annacc@chromium.org [Fri, 7 Oct 2011 09:53:43 +0000 (09:53 +0000)]
Turn ENABLE_VIDEO_TRACK on for chromium.
https://bugs.webkit.org/show_bug.cgi?id=69460

Reviewed by David Levin.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Don't expose objects with unknown role on GTK
mario@webkit.org [Fri, 7 Oct 2011 09:51:49 +0000 (09:51 +0000)]
[GTK] Don't expose objects with unknown role on GTK
https://bugs.webkit.org/show_bug.cgi?id=69561

Reviewed by Chris Fleizach.

Source/WebCore:

Ignore accessibility objects in accessibilityPlatformIncludesObject.

Test: platform/gtk/accessibility/unknown-roles-not-exposed.html

* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
For unknown accessibility objects, return IgnoreObject.

LayoutTests:

New test to check that unknown objects are not exposed in GTK.

* platform/gtk/accessibility/unknown-roles-not-exposed-expected.txt: Added.
* platform/gtk/accessibility/unknown-roles-not-exposed.html: Added.

Added new expectation for new accessibility layout test introduced
in r96127 that was not possible to add before because of this bug.

* platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK baselines for
philn@webkit.org [Fri, 7 Oct 2011 09:35:18 +0000 (09:35 +0000)]
Unreviewed, GTK baselines for
security/redirect-BLOCKED-to-localURL.html test.

* platform/gtk/Skipped:
* platform/gtk/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: UI performance test for logging 100 messages to the console.
loislo@chromium.org [Fri, 7 Oct 2011 09:33:26 +0000 (09:33 +0000)]
Web Inspector: UI performance test for logging 100 messages to the console.
https://bugs.webkit.org/show_bug.cgi?id=69608

Reviewed by Pavel Feldman.

* inspector/performance/resources/console-append-100-lines.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-07 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Fri, 7 Oct 2011 09:27:08 +0000 (09:27 +0000)]
2011-10-07  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: also add glass pane to the frame document's body.

        * src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove <input type=file> tests to fast/forms/file/
tkent@chromium.org [Fri, 7 Oct 2011 09:19:07 +0000 (09:19 +0000)]
Move <input type=file> tests to fast/forms/file/
https://bugs.webkit.org/show_bug.cgi?id=69504

Reviewed by Hajime Morita.

* fast/forms/file-input-change-event-expected.txt: Removed.
* fast/forms/file-input-change-event.html: Removed.
* fast/forms/file-input-direction.html: Removed.
* fast/forms/file-input-disabled.html: Removed.
* fast/forms/file-input-hit-test-expected.txt: Removed.
* fast/forms/file-input-hit-test.html: Removed.
* fast/forms/file-input-reset-expected.html: Removed.
* fast/forms/file-input-reset.html: Removed.
* fast/forms/file/file-input-change-event-expected.txt: Copied from LayoutTests/fast/forms/file-input-change-event-expected.txt.
* fast/forms/file/file-input-change-event.html: Copied from LayoutTests/fast/forms/file-input-change-event.html.
* fast/forms/file/file-input-direction.html: Copied from LayoutTests/fast/forms/file-input-direction.html.
* fast/forms/file/file-input-disabled.html: Copied from LayoutTests/fast/forms/file-input-disabled.html.
* fast/forms/file/file-input-hit-test-expected.txt: Copied from LayoutTests/fast/forms/file-input-hit-test-expected.txt.
* fast/forms/file/file-input-hit-test.html: Copied from LayoutTests/fast/forms/file-input-hit-test.html.
* fast/forms/file/file-input-reset-expected.html: Copied from LayoutTests/fast/forms/file-input-reset-expected.html.
* fast/forms/file/file-input-reset.html: Copied from LayoutTests/fast/forms/file-input-reset.html.
* fast/forms/file/get-file-upload-expected.txt: Copied from LayoutTests/fast/forms/get-file-upload-expected.txt.
* fast/forms/file/get-file-upload.html: Copied from LayoutTests/fast/forms/get-file-upload.html.
* fast/forms/file/hidden-input-file-expected.html: Copied from LayoutTests/fast/forms/hidden-input-file.html.
* fast/forms/file/hidden-input-file.html: Copied from LayoutTests/fast/forms/hidden-input-file.html.
* fast/forms/file/input-file-directory-upload-expected.txt: Copied from LayoutTests/fast/forms/input-file-directory-upload-expected.txt.
* fast/forms/file/input-file-directory-upload.html: Copied from LayoutTests/fast/forms/input-file-directory-upload.html.
* fast/forms/file/input-file-label-expected.txt: Copied from LayoutTests/fast/forms/input-file-label-expected.txt.
* fast/forms/file/input-file-label.html: Copied from LayoutTests/fast/forms/input-file-label.html.
* fast/forms/file/input-file-not-open-without-gesture-expected.txt: Copied from LayoutTests/fast/forms/input-file-not-open-without-gesture-expected.txt.
* fast/forms/file/input-file-not-open-without-gesture.html: Copied from LayoutTests/fast/forms/input-file-not-open-without-gesture.html.
* fast/forms/file/input-file-re-render.html: Copied from LayoutTests/fast/forms/input-file-re-render.html.
* fast/forms/get-file-upload-expected.txt: Removed.
* fast/forms/get-file-upload.html: Removed.
* fast/forms/hidden-input-file.html: Removed.
* fast/forms/input-file-directory-upload-expected.txt: Removed.
* fast/forms/input-file-directory-upload.html: Removed.
* fast/forms/input-file-label-expected.txt: Removed.
* fast/forms/input-file-label.html: Removed.
* fast/forms/input-file-not-open-without-gesture-expected.txt: Removed.
* fast/forms/input-file-not-open-without-gesture.html: Removed.
* fast/forms/input-file-re-render.html: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/file: Added.
* platform/chromium-cg-mac-leopard/fast/forms/file-input-direction-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/file-input-direction-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-file-re-render-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/input-file-re-render-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/file: Added.
* platform/chromium-cg-mac/fast/forms/file-input-direction-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/file-input-direction-expected.txt: Removed.
* platform/chromium-cg-mac/fast/forms/file-input-disabled-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-direction-expected.png.
* platform/chromium-cg-mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-direction-expected.txt.
* platform/chromium-cg-mac/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/file-input-disabled-expected.png.
* platform/chromium-cg-mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/forms/input-file-re-render-expected.png.
* platform/chromium-cg-mac/fast/forms/hidden-input-file-expected.txt: Removed.
* platform/chromium-cg-mac/fast/forms/input-file-re-render-expected.png: Removed.
* platform/chromium-linux/fast/forms/file: Added.
* platform/chromium-linux/fast/forms/file-input-direction-expected.png: Removed.
* platform/chromium-linux/fast/forms/file-input-direction-expected.txt: Removed.
* platform/chromium-linux/fast/forms/file-input-disabled-expected.png: Removed.
* platform/chromium-linux/fast/forms/file-input-disabled-expected.txt: Removed.
* platform/chromium-linux/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-direction-expected.png.
* platform/chromium-linux/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-direction-expected.txt.
* platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-disabled-expected.png.
* platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/file-input-disabled-expected.txt.
* platform/chromium-linux/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.png.
* platform/chromium-linux/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.txt.
* platform/chromium-linux/fast/forms/hidden-input-file-expected.png: Removed.
* platform/chromium-linux/fast/forms/hidden-input-file-expected.txt: Removed.
* platform/chromium-linux/fast/forms/input-file-re-render-expected.png: Removed.
* platform/chromium-linux/fast/forms/input-file-re-render-expected.txt: Removed.
* platform/chromium-mac/fast/forms/file: Added.
* platform/chromium-mac/fast/forms/file-input-direction-expected.png: Removed.
* platform/chromium-mac/fast/forms/file-input-direction-expected.txt: Removed.
* platform/chromium-mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.png.
* platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.txt.
* platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-file-re-render-expected.png.
* platform/chromium-mac/fast/forms/hidden-input-file-expected.png: Removed.
* platform/chromium-mac/fast/forms/hidden-input-file-expected.txt: Removed.
* platform/chromium-mac/fast/forms/input-file-re-render-expected.png: Removed.
* platform/chromium-win/fast/forms/file: Added.
* platform/chromium-win/fast/forms/file-input-direction-expected.png: Removed.
* platform/chromium-win/fast/forms/file-input-direction-expected.txt: Removed.
* platform/chromium-win/fast/forms/file-input-disabled-expected.png: Removed.
* platform/chromium-win/fast/forms/file-input-disabled-expected.txt: Removed.
* platform/chromium-win/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-direction-expected.png.
* platform/chromium-win/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-direction-expected.txt.
* platform/chromium-win/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-disabled-expected.png.
* platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/file-input-disabled-expected.txt.
* platform/chromium-win/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-file-re-render-expected.png.
* platform/chromium-win/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-file-re-render-expected.txt.
* platform/chromium-win/fast/forms/hidden-input-file-expected.png: Removed.
* platform/chromium-win/fast/forms/hidden-input-file-expected.txt: Removed.
* platform/chromium-win/fast/forms/input-file-re-render-expected.png: Removed.
* platform/chromium-win/fast/forms/input-file-re-render-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/gtk/fast/forms/file: Added.
* platform/gtk/fast/forms/file-input-direction-expected.png: Removed.
* platform/gtk/fast/forms/file-input-direction-expected.txt: Removed.
* platform/gtk/fast/forms/file-input-disabled-expected.png: Removed.
* platform/gtk/fast/forms/file-input-disabled-expected.txt: Removed.
* platform/gtk/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/file-input-direction-expected.png.
* platform/gtk/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/file-input-direction-expected.txt.
* platform/gtk/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/file-input-disabled-expected.png.
* platform/gtk/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/file-input-disabled-expected.txt.
* platform/gtk/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.png.
* platform/gtk/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.txt.
* platform/gtk/fast/forms/hidden-input-file-expected.png: Removed.
* platform/gtk/fast/forms/hidden-input-file-expected.txt: Removed.
* platform/gtk/fast/forms/input-file-re-render-expected.png: Removed.
* platform/gtk/fast/forms/input-file-re-render-expected.txt: Removed.
* platform/mac-leopard/fast/forms/file: Added.
* platform/mac-leopard/fast/forms/file-input-direction-expected.png: Removed.
* platform/mac-leopard/fast/forms/file-input-disabled-expected.png: Removed.
* platform/mac-leopard/fast/forms/file-input-disabled-expected.txt: Removed.
* platform/mac-leopard/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-direction-expected.png.
* platform/mac-leopard/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.png.
* platform/mac-leopard/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.txt.
* platform/mac-leopard/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-file-re-render-expected.png.
* platform/mac-leopard/fast/forms/hidden-input-file-expected.png: Removed.
* platform/mac-leopard/fast/forms/input-file-re-render-expected.png: Removed.
* platform/mac/Skipped:
* platform/mac/fast/forms/file: Added.
* platform/mac/fast/forms/file-input-direction-expected.png: Removed.
* platform/mac/fast/forms/file-input-direction-expected.txt: Removed.
* platform/mac/fast/forms/file-input-disabled-expected.png: Removed.
* platform/mac/fast/forms/file-input-disabled-expected.txt: Removed.
* platform/mac/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file-input-direction-expected.png.
* platform/mac/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-direction-expected.txt.
* platform/mac/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.png.
* platform/mac/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.txt.
* platform/mac/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-file-re-render-expected.png.
* platform/mac/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-file-re-render-expected.txt.
* platform/mac/fast/forms/hidden-input-file-expected.png: Removed.
* platform/mac/fast/forms/hidden-input-file-expected.txt: Removed.
* platform/mac/fast/forms/input-file-re-render-expected.png: Removed.
* platform/mac/fast/forms/input-file-re-render-expected.txt: Removed.
* platform/qt/Skipped:
* platform/qt/fast/forms/file: Added.
* platform/qt/fast/forms/file-input-direction-expected.txt: Removed.
* platform/qt/fast/forms/file-input-disabled-expected.txt: Removed.
* platform/qt/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/file-input-direction-expected.txt.
* platform/qt/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/file-input-disabled-expected.txt.
* platform/qt/fast/forms/hidden-input-file-expected.txt: Removed.
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: glass pane does not disappear after network panel's grid column resize.
pfeldman@chromium.org [Fri, 7 Oct 2011 09:12:52 +0000 (09:12 +0000)]
Web Inspector: glass pane does not disappear after network panel's grid column resize.
https://bugs.webkit.org/show_bug.cgi?id=69607

Reviewed by Yury Semikhatsky.

* src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix after r95604.
paroga@webkit.org [Fri, 7 Oct 2011 09:04:10 +0000 (09:04 +0000)]
Unreviewed build fix after r95604.

* WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::isLinkVisited):
(PlatformStrategiesWinCE::addVisitedLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add Elements and Network panels to the compilation
pfeldman@chromium.org [Fri, 7 Oct 2011 08:31:59 +0000 (08:31 +0000)]
Web Inspector: add Elements and Network panels to the compilation
https://bugs.webkit.org/show_bug.cgi?id=69604

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-07
Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
* inspector/front-end/DOMAgent.js:
* inspector/front-end/DOMBreakpointsSidebarPane.js:
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._startEditingConfig):
* inspector/front-end/Drawer.js:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.collapseDimmed):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
(WebInspector.ElementsPanel.prototype._registerShortcuts):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
(WebInspector.ElementsTreeElement.prototype._startEditingTagName):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog._show):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.startEditing):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype._updateOffscreenRows):
(WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
(WebInspector.NetworkPanel.prototype._resourceByAnchor):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
* inspector/front-end/Panel.js:
* inspector/front-end/Popover.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/TimelineGrid.js:
* inspector/front-end/UIUtils.js:
(WebInspector.EditingConfig):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
(WebInspector.formatLocalized):
(WebInspector.openLinkExternallyLabel):
(WebInspector.openInNetworkPanelLabel):
(WebInspector.copyLinkAddressLabel):
* inspector/front-end/externs.js:
(WebInspector.extensionServer.notifyObjectSelected):
(WebInspector.openResource):
* inspector/front-end/inspector.js:
(WebInspector.resourceForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange enum value names for TextTrack::readyState and TextTrack::mode
annacc@chromium.org [Fri, 7 Oct 2011 08:11:47 +0000 (08:11 +0000)]
Change enum value names for TextTrack::readyState and TextTrack::mode
https://bugs.webkit.org/show_bug.cgi?id=69603

Reviewed by David Levin.

No new tests. No new functionality.

* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::trackLoadStarted):
(WebCore::LoadableTextTrack::trackLoadError):
(WebCore::LoadableTextTrack::trackLoadCompleted):
* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setMode):
* html/TextTrack.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding parens in WebVTTParser.cpp to appease compiler preferences.
annacc@chromium.org [Fri, 7 Oct 2011 07:59:47 +0000 (07:59 +0000)]
Adding parens in WebVTTParser.cpp to appease compiler preferences.
https://bugs.webkit.org/show_bug.cgi?id=69602

Reviewed by David Levin.

No new tests. No new functionality.

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAlways call setActive() in WebViewImpl::setFocus(),
japhet@chromium.org [Fri, 7 Oct 2011 07:43:10 +0000 (07:43 +0000)]
Always call setActive() in WebViewImpl::setFocus(),
not just when enabling focus.
https://bugs.webkit.org/show_bug.cgi?id=65220

Reviewed by Darin Fisher.

* WebKit.gyp:
* WebKit.gypi:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):
* tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp.
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::loadFrame):
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp.
* tests/WebFrameTest.cpp:
* tests/WebViewTest.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest update for r96893.
tkent@chromium.org [Fri, 7 Oct 2011 07:06:09 +0000 (07:06 +0000)]
Test update for r96893.
https://bugs.webkit.org/show_bug.cgi?id=53752

r96893 changed the behavior of dataset-gc.html and
dataset-xhtml.xhtml. We update these tests because the new
behavior matches to Firefox and Opera.

* fast/dom/dataset-gc-expected.txt:
* fast/dom/dataset-xhtml-expected.txt:
* fast/dom/script-tests/dataset-gc.js:
* fast/dom/script-tests/dataset-xhtml.js:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdds a field, "saveAs", to WebFileChooserParams to present the file chooser
bbudge@chromium.org [Fri, 7 Oct 2011 07:04:45 +0000 (07:04 +0000)]
Adds a field, "saveAs", to WebFileChooserParams to present the file chooser
dialog in "Save As" mode (allows the user to choose a possibly non-existent file
for saving).
https://bugs.webkit.org/show_bug.cgi?id=69301

Reviewed by Darin Fisher.

* public/WebFileChooserParams.h:
(WebKit::WebFileChooserParams::WebFileChooserParams):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebkit API for compositor
commit-queue@webkit.org [Fri, 7 Oct 2011 06:49:55 +0000 (06:49 +0000)]
Webkit API for compositor
https://bugs.webkit.org/show_bug.cgi?id=69107

Patch by Antoine Labour <piman@chromium.org> on 2011-10-06
Reviewed by Darin Fisher.

Source/WebCore:

Covered by existing compositing tests.

* platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebContentLayer.h: Added.
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):
* public/WebContentLayerClient.h: Added.
(WebKit::WebContentLayerClient::~WebContentLayerClient):
* public/WebLayer.h: Added.
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebLayerClient.h: Added.
(WebKit::WebLayerClient::~WebLayerClient):
* public/WebLayerTreeView.h: Added.
(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebLayerTreeViewClient.h: Added.
(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):
* src/WebContentLayer.cpp: Added.
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::setNeedsDisplay):
(WebKit::WebContentLayer::dirtyRect):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<WebContentLayerImpl>):
* src/WebContentLayerImpl.cpp: Added.
(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):
(WebKit::WebContentLayerImpl::drawsContent):
(WebKit::WebContentLayerImpl::paintContents):
(WebKit::WebContentLayerImpl::notifySyncRequired):
* src/WebContentLayerImpl.h: Added.
* src/WebLayer.cpp: Added.
(WebKit::WebLayer::create):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::rootLayer):
(WebKit::WebLayer::parent):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::maskLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):
* src/WebLayerImpl.cpp: Added.
(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::paintContents):
(WebKit::WebLayerImpl::notifySyncRequired):
* src/WebLayerImpl.h: Added.
* src/WebLayerTreeView.cpp: Added.
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::assign):
(WebKit::WebLayerTreeView::equals):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::WebLayerTreeView::operator PassRefPtr<CCLayerTreeHost>):
* src/WebLayerTreeViewImpl.cpp: Added.
(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::animateAndLayout):
(WebKit::WebLayerTreeViewImpl::applyScrollDelta):
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):
* src/WebLayerTreeViewImpl.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Build fix for r96907.
tkent@chromium.org [Fri, 7 Oct 2011 06:19:29 +0000 (06:19 +0000)]
[Chromium] Build fix for r96907.

* tests/PopupMenuTest.cpp:
(WebKit::TestPopupMenuClient::valueChanged):
Use HTMLSelectElement instead of SelectElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove SelectElement class
tkent@chromium.org [Fri, 7 Oct 2011 06:05:18 +0000 (06:05 +0000)]
Remove SelectElement class
https://bugs.webkit.org/show_bug.cgi?id=69518

Reviewed by Ryosuke Niwa.

SelectElement used to be an abstract class for HTMLSelectElement
and WMLSelectElement. SelectElement is not needed anymore because
WML was removed.

This patch just removes SelectElement by moving SelectElement
functions to HTMLSelectElement.

No new tests. Just a refactoring.

* WebCore.vcproj/WebCore.vcproj:
Rename dom\SelectElementWin.cpp to html\HTMLSelectElementWin.cpp.
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::setSelected):
Remove unnecessary cast.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
Use HTMLSelectElement instead of SelectElement.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(optionFromSelection): ditto.
(webkit_accessible_selection_get_selection_count): ditto.
* accessibility/gtk/AXObjectCacheAtk.cpp:
(notifyChildrenSelectionChange): ditto.
* dom/OptionElement.cpp:
(WebCore::OptionElement::optionIndex): ditto.
* dom/OptionElement.h: ditto.
* dom/SelectElement.cpp:
(WebCore::SelectElementData::checkListItems): ditto.
(WebCore::SelectElementData::listItems): ditto.
* dom/SelectElementWin.cpp: Removed.
* dom/SelectElement.h: Removed SelectElement class declaration.
* html/HTMLSelectElement.cpp: Move functions from SelectElement.cpp.
(WebCore::HTMLSelectElement::selectedIndex):
Removed 'SelectElement::' because the function is moved to HTMLSelectElement.
(WebCore::HTMLSelectElement::deselectItems): dito.
(WebCore::HTMLSelectElement::setSelectedIndex): dito.
(WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
(WebCore::HTMLSelectElement::activeSelectionEndListIndex): ditto.
(WebCore::HTMLSelectElement::length): ditto.
(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): ditto.
(WebCore::HTMLSelectElement::parseMappedAttribute): ditto.
(WebCore::HTMLSelectElement::selectAll): ditto.
(WebCore::HTMLSelectElement::appendFormData): ditto.
(WebCore::HTMLSelectElement::optionToListIndex): ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::recalcListItems): ditto.
(WebCore::HTMLSelectElement::setRecalcListItems): ditto.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::defaultEventHandler): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::menuListOnChange): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::saveLastSelection): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
(WebCore::HTMLSelectElement::scrollToSelection): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree): ditto.
(WebCore::nextValidIndex): Moved from SelectElement.cpp.
(WebCore::nextSelectableListIndex): ditto.
(WebCore::previousSelectableListIndex): ditto.
(WebCore::firstSelectableListIndex): ditto.
(WebCore::lastSelectableListIndex): ditto.
(WebCore::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): ditto.
(WebCore::HTMLSelectElement::parseMultipleAttribute): ditto.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
(WebCore::stripLeadingWhiteSpace): ditto.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::optionCount): ditto.
(WebCore::toSelectElement): ditto.
* html/HTMLSelectElementWin.cpp: Copied from Source/WebCore/dom/SelectElementWin.cpp.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
* html/HTMLSelectElement.h: Removed 'virtual' of SelectElement functions.
(WebCore::HTMLSelectElement::size):
(WebCore::HTMLSelectElement::multiple):
(WebCore::HTMLSelectElement::listItems):
(WebCore::HTMLSelectElement::updateValidity):
* rendering/RenderListBox.cpp: Replace SelectElement with HTMLSelectElement
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::scrollToRevealSelection):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::autoscroll):
(WebCore::RenderListBox::valueChanged):
* rendering/RenderMenuList.cpp: Replace SelectElement with HTMLSelectElement
(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::valueChanged):
(WebCore::RenderMenuList::listBoxSelectItem):
(WebCore::RenderMenuList::multiple):
(WebCore::RenderMenuList::didSetSelectedIndex):
(WebCore::RenderMenuList::didUpdateActiveOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemAccessibilityText):
(WebCore::RenderMenuList::itemToolTip):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::itemBackgroundColor):
(WebCore::RenderMenuList::listSize):
(WebCore::RenderMenuList::selectedIndex):
(WebCore::RenderMenuList::itemIsSeparator):
(WebCore::RenderMenuList::itemIsLabel):
(WebCore::RenderMenuList::itemIsSelected):
(WebCore::RenderMenuList::setTextFromItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPort PixelZoomer to work in garden-o-matic
abarth@webkit.org [Fri, 7 Oct 2011 05:42:57 +0000 (05:42 +0000)]
Port PixelZoomer to work in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69577

Reviewed by David Levin.

Tools:

This implementation of PixelZoomer is basically a fork of the
implementation used by results.html.  These two apps have different
requirements on where this code lives.  results.html wants to be
self-contained whereas garden-o-matic wants to live in the public_html
folder of the buildbot.  We could do something fancy here to share the
code, but that's not likely to be of much benefit.

I had to change a few things about pixelzoomer to accounter for the
differences in DOM between results.html and garden-o-matic, but
surprisingly little.  I also moved all the code into an anonymous
function, which is the style we're suing for module separation in
garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
want to drag along too many extra functions from results.html.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
(.pixel-zoom-container):
(.pixel-zoom-container > *):
(.pixel-zoom-container .scaled-image-container):
(.scaled-image-container > img):

LayoutTests:

Change the timeout constant to so that it matches garden-o-matic.  In
garden-o-matic, 200 MS was too fast because you mouse around the UI a
lot more.

* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Motorola Mobility to team.html
amruthraj@motorola.com [Fri, 7 Oct 2011 05:22:58 +0000 (05:22 +0000)]
Add Motorola Mobility to team.html
https://bugs.webkit.org/show_bug.cgi?id=69597

Reviewed by Ryosuke Niwa.

* team.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Correct improper identification of WKQC extensions.
bfulgham@webkit.org [Fri, 7 Oct 2011 05:16:02 +0000 (05:16 +0000)]
[WinCairo] Correct improper identification of WKQC extensions.
https://bugs.webkit.org/show_bug.cgi?id=69600

* DerivedSources.make: Make sure we are not building the
WinCairo variant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
mrowe@apple.com [Fri, 7 Oct 2011 04:33:34 +0000 (04:33 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Fix test expectations. Broken test from r96870. Bug filed.
simonjam@chromium.org [Fri, 7 Oct 2011 04:21:32 +0000 (04:21 +0000)]
[Chromium] Fix test expectations. Broken test from r96870. Bug filed.

Unreviewed.

* platform/chromium/test_expectations.txt: Added smart-paste-008.html on all platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96896.
commit-queue@webkit.org [Fri, 7 Oct 2011 04:20:42 +0000 (04:20 +0000)]
Unreviewed, rolling out r96896.
http://trac.webkit.org/changeset/96896
https://bugs.webkit.org/show_bug.cgi?id=69601

broke windows and mac chromium builds (Requested by simonjam
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-06

Source/WebCore:

* platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebContentLayer.h: Removed.
* public/WebContentLayerClient.h: Removed.
* public/WebLayer.h: Removed.
* public/WebLayerClient.h: Removed.
* public/WebLayerTreeView.h: Removed.
* public/WebLayerTreeViewClient.h: Removed.
* src/WebContentLayer.cpp: Removed.
* src/WebContentLayerImpl.cpp: Removed.
* src/WebContentLayerImpl.h: Removed.
* src/WebLayer.cpp: Removed.
* src/WebLayerImpl.cpp: Removed.
* src/WebLayerImpl.h: Removed.
* src/WebLayerTreeView.cpp: Removed.
* src/WebLayerTreeViewImpl.cpp: Removed.
* src/WebLayerTreeViewImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 7 Oct 2011 03:52:51 +0000 (03:52 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-06

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html...
rniwa@webkit.org [Fri, 7 Oct 2011 03:23:06 +0000 (03:23 +0000)]
Windows rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html because it's a real failure
(tracked by the bug 69587).

* platform/win/Skipped:
* platform/win/editing/deleting/delete-br-010-expected.txt:
* platform/win/editing/deleting/regional-indicators-expected.txt: Removed.
* platform/win/editing/inserting/insert-3907422-fix-expected.txt: Copied from LayoutTests/editing/inserting/insert-3907422-fix-expected.txt.
* platform/win/editing/pasteboard/paste-text-002-expected.txt: Copied from LayoutTests/editing/pasteboard/paste-text-002-expected.txt.
* platform/win/editing/pasteboard/paste-text-004-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-text-004-expected.txt.
* platform/win/editing/pasteboard/paste-text-005-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-text-005-expected.txt.
* platform/win/editing/pasteboard/paste-text-008-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-text-008-expected.txt.
* platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Mac rebaselines after r96870.
rniwa@webkit.org [Fri, 7 Oct 2011 03:14:22 +0000 (03:14 +0000)]
Chromium Mac rebaselines after r96870.

* platform/chromium-cg-mac-snowleopard/editing: Added.
* platform/chromium-cg-mac-snowleopard/editing/inserting: Added.
* platform/chromium-cg-mac-snowleopard/editing/inserting/insert-3907422-fix-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-004-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-005-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-008-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/editing/spelling: Added.
* platform/chromium-cg-mac-snowleopard/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/events: Added.
* platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Added.
* platform/chromium-mac-leopard/editing/pasteboard: Added.
* platform/chromium-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png: Added.
* platform/chromium-mac-snowleopard/editing: Added.
* platform/chromium-mac-snowleopard/editing/inserting: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-3907422-fix-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-004-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-005-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-008-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/spelling: Added.
* platform/chromium-mac-snowleopard/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast: Added.
* platform/chromium-mac-snowleopard/fast/events: Added.
* platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Added.
* platform/chromium-win/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebkit API for compositor
commit-queue@webkit.org [Fri, 7 Oct 2011 03:01:23 +0000 (03:01 +0000)]
Webkit API for compositor
https://bugs.webkit.org/show_bug.cgi?id=69107

Patch by Antoine Labour <piman@chromium.org> on 2011-10-06
Reviewed by Darin Fisher.

Source/WebCore:

Covered by existing compositing tests.

* platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebContentLayer.h: Added.
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):
* public/WebContentLayerClient.h: Added.
(WebKit::WebContentLayerClient::~WebContentLayerClient):
* public/WebLayer.h: Added.
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebLayerClient.h: Added.
(WebKit::WebLayerClient::~WebLayerClient):
* public/WebLayerTreeView.h: Added.
(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebLayerTreeViewClient.h: Added.
(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):
* src/WebContentLayer.cpp: Added.
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::setNeedsDisplay):
(WebKit::WebContentLayer::dirtyRect):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<WebContentLayerImpl>):
* src/WebContentLayerImpl.cpp: Added.
(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):
(WebKit::WebContentLayerImpl::drawsContent):
(WebKit::WebContentLayerImpl::paintContents):
(WebKit::WebContentLayerImpl::notifySyncRequired):
* src/WebContentLayerImpl.h: Added.
* src/WebLayer.cpp: Added.
(WebKit::WebLayer::create):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::rootLayer):
(WebKit::WebLayer::parent):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::maskLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):
* src/WebLayerImpl.cpp: Added.
(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::paintContents):
(WebKit::WebLayerImpl::notifySyncRequired):
* src/WebLayerImpl.h: Added.
* src/WebLayerTreeView.cpp: Added.
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::assign):
(WebKit::WebLayerTreeView::equals):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::WebLayerTreeView::operator PassRefPtr<CCLayerTreeHost>):
* src/WebLayerTreeViewImpl.cpp: Added.
(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::animateAndLayout):
(WebKit::WebLayerTreeViewImpl::applyScrollDelta):
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):
* src/WebLayerTreeViewImpl.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed by Kent Tamura.
joepeck@webkit.org [Fri, 7 Oct 2011 02:55:39 +0000 (02:55 +0000)]
Reviewed by Kent Tamura.

Pass "accept" mime type information into FileChooser at all call sites
https://bugs.webkit.org/show_bug.cgi?id=69592

No new tests. This only exposes some more information to
WebKit ports, no functionality change in WebCore.

* html/FileInputType.cpp:
(WebCore::FileInputType::receiveDropForDirectoryUpload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should not always speculate that ConvertThis is operating on an object
fpizlo@apple.com [Fri, 7 Oct 2011 02:48:47 +0000 (02:48 +0000)]
DFG should not always speculate that ConvertThis is operating on an object
https://bugs.webkit.org/show_bug.cgi?id=69570

Reviewed by Oliver Hunt.

Mostly neutral, but with a slight regression in Kraken since it increases
coverage in DFG and thus reveals some performance pathologies (which I
prefer to think of as performance opportunities, in a good way).

* bytecode/PredictedType.cpp:
(JSC::predictionToString):
* bytecode/PredictedType.h:
(JSC::isOtherPrediction):
(JSC::mergePredictions):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC binding] Fix inconsistent behavior of DOMStringMap
tkent@chromium.org [Fri, 7 Oct 2011 02:44:52 +0000 (02:44 +0000)]
[JSC binding] Fix inconsistent behavior of DOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=53752

Reviewed by Darin Adler.

Source/WebCore:

The dataset behavior was inconsistent. The get operation handled
data-* attributes first, and the put and delete operations handled
JavaScript properties first.

Like Firefox and Opera, the put and delete operations should
handle data-* attribute first.

* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::deleteProperty):
 Handles DOMStringMap first, then returns false if the DOMStringMap makes an error.
(WebCore::JSDOMStringMap::putDelegate): ditto.

LayoutTests:

* fast/dom/dataset-expected.txt:
* fast/dom/script-tests/dataset.js:
 - Change the expectation for a case deleting a property of which name can't be a data-* attribute.
   This behavior matches to Firefox and Opera.
 - Add test cases to check put/get/delete priorities.
* platform/chromium/test_expectations.txt:
 V8 binding is not ready for this change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn...
thakis@chromium.org [Fri, 7 Oct 2011 02:43:30 +0000 (02:43 +0000)]
[chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
https://bugs.webkit.org/show_bug.cgi?id=69589

Reviewed by Adam Barth.

When building with `make -j40`, all the binding rules are built en bloc. Since this script currently
uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
255 by default, so the build used to fail with
"open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.

* WebCore.gyp/scripts/rule_binding.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSome media tests fail when run inside a directory path containing periods.
jer.noble@apple.com [Fri, 7 Oct 2011 02:33:23 +0000 (02:33 +0000)]
Some media tests fail when run inside a directory path containing periods.
https://bugs.webkit.org/show_bug.cgi?id=69580

Reviewed by Darin Adler.

To determine the extension, retrieve the last string following a period instead of the second.

* media/media-blocked-by-beforeload.html:
* media/video-source-load.html:
* media/video-source-moved.html:
* media/video-source-removed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
gyuyoung.kim@samsung.com [Fri, 7 Oct 2011 02:23:03 +0000 (02:23 +0000)]
[EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
https://bugs.webkit.org/show_bug.cgi?id=69505

Reviewed by Andreas Kling.

Source/WebKit/efl:

ewk_view_viewport_attributes_get() has used implicit casting for width and height of viewport.
However, it is better to use *int* data type as parameter data type instead of *float* casting.

* ewk/ewk_view.cpp:
(ewk_view_viewport_attributes_get):
* ewk/ewk_view.h:

Tools:

* EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
(on_viewport_changed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix
mhahnenberg@apple.com [Fri, 7 Oct 2011 02:09:35 +0000 (02:09 +0000)]
Windows build fix

Unreviewed build fix.  Weird runtime failures on Windows due to
linking issues caused by the ClassInfo struct in JSByteArray not
being declared with JS_EXPORTDATA.

* runtime/JSByteArray.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Windows and Chromium Linux rebaselines for r96870. Also skip editing/pastebo...
rniwa@webkit.org [Fri, 7 Oct 2011 01:56:25 +0000 (01:56 +0000)]
Chromium Windows and Chromium Linux rebaselines for r96870. Also skip editing/pasteboard/smart-paste-008.html
because it's a real failure (tracked by the bug 69587).

* platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-005-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-008-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-012-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-013-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-014-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-015-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-016-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-017-expected.txt:
* platform/chromium-win/editing/deleting/delete-br-010-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-011-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-012-expected.txt:
* platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
* platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
* platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt: Added.
* platform/chromium-win/editing/inserting/multiple-lines-selected-expected.txt:
* platform/chromium-win/editing/pasteboard/5032095-expected.txt:
* platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Added.
* platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-after-delete-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Added.
* platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Added.
* platform/chromium-win/editing/pasteboard/paste-text-004-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
* platform/chromium-win/fast/events/ondragenter-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Unreviewed test correction.
bfulgham@webkit.org [Fri, 7 Oct 2011 01:09:19 +0000 (01:09 +0000)]
[WinCairo] Unreviewed test correction.

* Scripts/webkitdirs.pm:
(argumentsForConfiguration): Add 'wincairo' option to the set of
configuration flags used by run-javascript-core tests, so that it
does not attempt to run Apple's release version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html because...
rniwa@webkit.org [Fri, 7 Oct 2011 01:02:35 +0000 (01:02 +0000)]
Qt rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html because it's a real failure
(tracked by the bug 69587).

* platform/qt/Skipped:
* platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
* platform/qt/editing/deleting/delete-br-010-expected.txt:
* platform/qt/editing/deleting/delete-line-012-expected.txt:
* platform/qt/editing/deleting/delete-listitem-001-expected.txt:
* platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
* platform/qt/editing/inserting/insert-3907422-fix-expected.txt: Copied from LayoutTests/editing/inserting/insert-3907422-fix-expected.txt.
* platform/qt/editing/inserting/multiple-lines-selected-expected.txt:
* platform/qt/editing/pasteboard/5032095-expected.txt:
* platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Copied from LayoutTests/editing/pasteboard/interchange-newline-1-expected.txt.
* platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
* platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
* platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
* platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
* platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
* platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/qt/editing/pasteboard/paste-text-002-expected.txt: Copied from LayoutTests/editing/pasteboard/paste-text-002-expected.txt.
* platform/qt/editing/pasteboard/paste-text-003-expected.txt: Copied from LayoutTests/editing/pasteboard/paste-text-003-expected.txt.
* platform/qt/editing/pasteboard/paste-text-004-expected.txt:
* platform/qt/editing/pasteboard/paste-text-005-expected.txt:
* platform/qt/editing/pasteboard/paste-text-008-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Unreviewed test correction.
bfulgham@webkit.org [Fri, 7 Oct 2011 00:49:52 +0000 (00:49 +0000)]
[WinCairo] Unreviewed test correction.

* BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
 of known build slave types so that test-result-archive won't fail
 when running tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove passing tests from test_expectations.txt.
simonjam@chromium.org [Fri, 7 Oct 2011 00:49:34 +0000 (00:49 +0000)]
[Chromium] Remove passing tests from test_expectations.txt.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStructure does not reset m_previous when pinning the property map
fpizlo@apple.com [Fri, 7 Oct 2011 00:47:21 +0000 (00:47 +0000)]
Structure does not reset m_previous when pinning the property map
https://bugs.webkit.org/show_bug.cgi?id=69583

Reviewed by Gavin Barraclough.

This is an 0.6% performance improvement in V8, and 0.2% overall.

* runtime/Structure.cpp:
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):
* runtime/Structure.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGTK rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html becaus...
rniwa@webkit.org [Fri, 7 Oct 2011 00:43:39 +0000 (00:43 +0000)]
GTK rebaseline after r96870. Also skip editing/pasteboard/smart-paste-008.html because it's a real failure
(tracked by the bug 69587).

* platform/gtk/Skipped:
* platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-005-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-008-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
* platform/gtk/editing/deleting/delete-br-010-expected.txt:
* platform/gtk/editing/deleting/delete-line-012-expected.txt:
* platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
* platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
* platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Copied from
LayoutTests/editing/inserting/insert-3907422-fix-expected.txt.
* platform/gtk/editing/inserting/multiple-lines-selected-expected.txt:
* platform/gtk/editing/pasteboard/5032095-expected.txt:
* platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Copied from
LayoutTests/editing/pasteboard/interchange-newline-1-expected.txt.
* platform/gtk/editing/pasteboard/merge-after-delete-1-expected.txt:
* platform/gtk/editing/pasteboard/merge-after-delete-2-expected.txt:
* platform/gtk/editing/pasteboard/merge-after-delete-expected.txt:
* platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
* platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
* platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Copied from
LayoutTests/editing/pasteboard/paste-text-002-expected.txt.
* platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Copied from
LayoutTests/editing/pasteboard/paste-text-003-expected.txt.
* platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
andersca@apple.com [Fri, 7 Oct 2011 00:34:05 +0000 (00:34 +0000)]
When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
https://bugs.webkit.org/show_bug.cgi?id=69586

Reviewed by Darin Adler.

../JavaScriptCore:

* Configurations/Base.xcconfig:
Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

* JavaScriptCore.xcodeproj/project.pbxproj:
When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

* jsc.cpp:
(runInteractive):
Move interpreterName into runInteractive.

* wtf/StdLibExtras.h:
When building with clang, disable the -Wglobal-constructors and -Wexit-time-destructors
warnings around the variable declaration.

../JavaScriptGlue:

* Configurations/Base.xcconfig:
Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

* JavaScriptGlue.xcodeproj/project.pbxproj:
When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

../WebCore:

* Configurations/Base.xcconfig:
Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

* WebCore.xcodeproj/project.pbxproj:
When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

* platform/graphics/filters/FEGaussianBlur.cpp:
(gaussianKernelFactor):
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::calculateStdDeviation):
Change the gaussian kernel factor global to be an inline function instead.

../WebKit:

* WebKit.xcodeproj/project.pbxproj:
When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

../WebKit/mac:

* Configurations/Base.xcconfig:
Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

../WebKit2:

* Configurations/Base.xcconfig:
Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

* WebKit2.xcodeproj/project.pbxproj:
When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
andersca@apple.com [Fri, 7 Oct 2011 00:20:23 +0000 (00:20 +0000)]
Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69584

Reviewed by Darin Adler.

../JavaScriptCore:

Add DEFINE_DEBUG_ONLY_GLOBAL macro.

* wtf/StdLibExtras.h:

../WebCore:

Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.

* bindings/js/JSLazyEventListener.cpp:
* dom/Node.cpp:
* dom/Range.cpp:
* history/CachedPage.cpp:
* loader/SubresourceLoader.cpp:
* loader/cache/CachedResource.cpp:
* page/Frame.cpp:
* page/Page.cpp:
* rendering/BidiRun.cpp:
* rendering/RenderObject.cpp:
* svg/SVGElementInstance.cpp:
* xml/XMLHttpRequest.cpp:

../WebKit/mac:

Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.

* Plugins/Hosted/HostedNetscapePluginStream.mm:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:

../WebKit2:

Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.

* UIProcess/WebContext.cpp:
* UIProcess/WebPageProxy.cpp:
* WebProcess/WebPage/WebFrame.cpp:
* WebProcess/WebPage/WebPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove USE(THREADED_COMPOSITING) from the tree
jamesr@google.com [Fri, 7 Oct 2011 00:17:49 +0000 (00:17 +0000)]
[chromium] Remove USE(THREADED_COMPOSITING) from the tree
https://bugs.webkit.org/show_bug.cgi?id=69489

Reviewed by Darin Fisher.

Source/WebCore:

This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.

* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Updated CCLayerTreeHostTest::onEndTest() to pump all pending messages
after posting the Quit task and before tearing down any test
infrastructure.

* features.gypi:
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove obsolete WebWidgetClient::didActivateAcceleratedCompositing call
jamesr@google.com [Fri, 7 Oct 2011 00:16:26 +0000 (00:16 +0000)]
[chromium] Remove obsolete WebWidgetClient::didActivateAcceleratedCompositing call
https://bugs.webkit.org/show_bug.cgi?id=69576

Reviewed by Darin Fisher.

The chromium implementation of this function went away at r104017.

* public/WebWidgetClient.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReturn null for the value of IDB key cursors instead of ASSERTing
dgrogan@chromium.org [Thu, 6 Oct 2011 23:58:10 +0000 (23:58 +0000)]
Return null for the value of IDB key cursors instead of ASSERTing
https://bugs.webkit.org/show_bug.cgi?id=69131

This is in support of the IndexedDB performance improvement here:
http://codereview.chromium.org/7834006/

Reviewed by Tony Chang.

* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [Mac] Should be able to scroll embedded PDFs using mouse
ap@apple.com [Thu, 6 Oct 2011 23:52:21 +0000 (23:52 +0000)]
    [Mac] Should be able to scroll embedded PDFs using mouse
        https://bugs.webkit.org/show_bug.cgi?id=69579

        Reviewed by Darin Adler.

        Hit testing doesn't find scrollbars installed by a plug-in, so mouse events don't work.

        As we want to use WebKit scrollbars with PDF plug-in, a cleaner long-term solution would be
        to have a base class under PluginViewBase that can handle scrolling instead of doing that
        in PluginView and Plugin.

        * plugins/PluginViewBase.h:
        (WebCore::PluginViewBase::horizontalScrollbar):
        (WebCore::PluginViewBase::verticalScrollbar):
        Added accessors for scrollbars installed by plug-in.

        * rendering/nodeAtPoint.cpp: (WebCore::RenderEmbeddedObject::nodeAtPoint):
        Like RenderLayer, add scrollbars to hit result after normal  hit testing.

        * rendering/RenderEmbeddedObject.h: Added a nodeAtPoint override.

        * rendering/RenderWidget.h: Made nodeAtPoint() protected instead of private, so that
        RenderEmbeddedObject could call it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWrite barrier shouldn't allocate temporaries inside control flow
oliver@apple.com [Thu, 6 Oct 2011 23:48:06 +0000 (23:48 +0000)]
Write barrier shouldn't allocate temporaries inside control flow
https://bugs.webkit.org/show_bug.cgi?id=69582

Reviewed by Gavin Barraclough.

Reorder the code to avoid spill-related badness.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9717490> Flash of white when navigating daringfireball.net
mitz@apple.com [Thu, 6 Oct 2011 23:42:57 +0000 (23:42 +0000)]
<rdar://problem/9717490> Flash of white when navigating daringfireball.net
https://bugs.webkit.org/show_bug.cgi?id=69581

Reviewed by Darin Adler.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Moved the calls to Scrollbar::setEnabled() into the code
section where invalidation is suppressed if necessary, so that they do not trigger premature invalidation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded a comment explaining code added in r96834.
mitz@apple.com [Thu, 6 Oct 2011 23:40:22 +0000 (23:40 +0000)]
Added a comment explaining code added in r96834.

Suggested by Darin Adler.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] WebIconDatabase expects a file path not a directory.
alexis.menard@openbossa.org [Thu, 6 Oct 2011 23:39:25 +0000 (23:39 +0000)]
[Qt][WK2] WebIconDatabase expects a file path not a directory.
https://bugs.webkit.org/show_bug.cgi?id=69557

Reviewed by Andreas Kling.

WebIconDatabase::setDatabasePath expects a file path not a directory.
I used the same name as the Mac port.

* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultIconDatabasePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG::shouldSpeculate methods are too complicated
fpizlo@apple.com [Thu, 6 Oct 2011 23:39:03 +0000 (23:39 +0000)]
DFG::shouldSpeculate methods are too complicated
https://bugs.webkit.org/show_bug.cgi?id=69560

Reviewed by Geoffrey Garen.

Moved shouldSpeculate methods to DFG::Node, and cleaned them up to
just use node predictions.

By itself this would have meant that SpeculativeJIT code would have
had to say things like m_jit.graph()[nodeIndex].shouldSpeculateXYZ().
So this adds an at(NodeIndex) method to JITCodeGenerator. I replaced
all uses of the m_jit.graph()[nodeIndex] idiom with at(nodeIndex).

This is an 0.4% progression overall that shows up in all benchmarks,
for reasons unknown.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::at):
(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::detectPeepHoleBranch):
(JSC::DFG::integerResult):
(JSC::DFG::noResult):
(JSC::DFG::cellResult):
(JSC::DFG::jsValueResult):
(JSC::DFG::storageResult):
(JSC::DFG::doubleResult):
(JSC::DFG::initConstantInfo):
(JSC::DFG::appendCallWithExceptionCheck):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateDouble):
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::Node::shouldSpeculateArray):
(JSC::DFG::Node::shouldSpeculateArrayOrOther):
(JSC::DFG::Node::shouldSpeculateObject):
(JSC::DFG::Node::shouldSpeculateCell):
(JSC::DFG::Node::canSpeculateInteger):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::isKnownArray):
(JSC::DFG::SpeculativeJIT::isKnownString):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDeleting line break before h1 converts h1 to span
rniwa@webkit.org [Thu, 6 Oct 2011 23:16:01 +0000 (23:16 +0000)]
Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784

Reviewed by Enrica Casucci.

Source/WebCore:

This patch fundamentally alters the kind of styles we preserve while merging or moving paragraphs.
StylizedMarkupAccumulator no longer wraps nodes by computed style when it's not annotating for interchange.
Instead, it accumulates implicit and inline styles of ancestors of the serialized contents.

The most significant code change is in StyledMarkupAccumulator::serializeNodes where we setup m_wrappingStyle
by merging implicit and inline style of ancestors with mergeInlineAndImplicitStyleOfElement. Because it walks up
the DOM tree upwards, it should not be overriding any CSS properties. Consequently, mergeStyle,
mergeInlineStyleOfElement, and mergeInlineAndImplicitStyleOfElement are modified to take CSSPropertyOverrideMode.

New behavior matches that of Internet Explorer and Firefox when merging paragraphs.

Tests: editing/deleting/merge-paragraph-from-address.html
       editing/deleting/merge-paragraph-from-h6-with-style-2.html
       editing/deleting/merge-paragraph-from-h6-with-style.html
       editing/deleting/merge-paragraph-from-h6.html
       editing/deleting/merge-paragraph-from-listing.html
       editing/deleting/merge-paragraph-from-p-with-style-2.html
       editing/deleting/merge-paragraph-from-p-with-style-3.html
       editing/deleting/merge-paragraph-from-p-with-style.html
       editing/deleting/merge-paragraph-into-h1-with-style.html
       editing/deleting/merge-paragraph-into-h1.html
       editing/deleting/merge-paragraph-into-pre.html

* css/CSSValueList.cpp:
(WebCore::CSSValueList::hasValue): Made const.
* css/CSSValueList.h:
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls mergeInlineStyleOfElement.
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Ditto.
* editing/EditingStyle.cpp:
(WebCore::copyEditingProperties): Takes a boolean includeBackgroundColor.
(WebCore::isEditingProperty): Extracted from elementIsStyledSpanOrHTMLEquivalent.
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Calls isEditingProperty.
(WebCore::EditingStyle::mergeTypingStyle): Calls mergeStyle.
(WebCore::EditingStyle::mergeInlineStyleOfElement): Takes CSSPropertyOverrideMode.
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Added.
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement): Added.
(WebCore::mergeTextDecorationValues): Extracted from mergeStyle.
(WebCore::EditingStyle::mergeStyle): Takes CSSPropertyOverrideMode.
* editing/EditingStyle.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::nodeToSplitToAvoidPastingIntoInlineNodesWithStyle): Extracted from doApply.
(WebCore::ReplaceSelectionCommand::doApply): Calls nodeToSplitToAvoidPastingIntoInlineNodesWithStyle.
(WebCore::ReplaceSelectionCommand::performTrivialReplace): Exit early when we need to split the tree to avoid
pasting into inline nodes with style. Also remove a collapsed or spurious br.
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::serializeNodes):

LayoutTests:

Many rebaselines are due to text nodes merged correctly after ReplaceSelectionCommand because
they started to use the fast path (perfromTrivialReplace).

New tests:
* editing/deleting/merge-paragraph-from-address-expected.txt: Added.
* editing/deleting/merge-paragraph-from-address.html: Added.
* editing/deleting/merge-paragraph-from-h6-expected.txt: Added.
* editing/deleting/merge-paragraph-from-h6-with-style-2-expected.txt: Added.
* editing/deleting/merge-paragraph-from-h6-with-style-2.html: Added.
* editing/deleting/merge-paragraph-from-h6-with-style-3-expected.txt: Added.
* editing/deleting/merge-paragraph-from-h6-with-style-3.html: Added.
* editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-from-h6-with-style.html: Added.
* editing/deleting/merge-paragraph-from-h6.html: Added.
* editing/deleting/merge-paragraph-from-listing-expected.txt: Added.
* editing/deleting/merge-paragraph-from-listing.html: Added.
* editing/deleting/merge-paragraph-from-p-with-style-2-expected.txt: Added.
* editing/deleting/merge-paragraph-from-p-with-style-2.html: Added.
* editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-from-p-with-style.html: Added.
* editing/deleting/merge-paragraph-into-blockquote-expected.txt:
* editing/deleting/merge-paragraph-into-h1-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-style-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-with-style.html: Added.
* editing/deleting/merge-paragraph-into-h1.html: Added.
* editing/deleting/merge-paragraph-into-pre-expected.txt: Added.
* editing/deleting/merge-paragraph-into-pre.html: Added.

Rebaselines:
* editing/pasteboard/5521237-expected.txt: A collapsed br at the end is removed.
* editing/spelling/script-tests/spelling-backspace-between-lines.js: text nodes are merged.
(testWithDelete):
(testWithForwardDelete):
* editing/spelling/spelling-backspace-between-lines-expected.txt:
* editing/style/apply-through-end-of-document-expected.txt: A collapsed br at the end is removed.
* platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/mac/editing/deleting/merge-whitespace-pre-expected.txt: "bar" is merged into p from
pre and losing monospace style.
* platform/mac/editing/pasteboard/paste-match-style-001-expected.txt: A text node is split into
two with no visual effect.

Rebaselines due to text nodes being merged:
* editing/deleting/5032066-expected.txt:
* editing/deleting/delete-across-editable-content-boundaries-2-expected.txt:
* editing/deleting/delete-across-editable-content-boundaries-3-expected.txt:
* editing/deleting/delete-line-011-expected.txt:
* editing/deleting/delete-to-end-of-paragraph-expected.txt:
* editing/deleting/deleting-line-break-preserves-underline-color-expected.txt:
* editing/pasteboard/copy-null-characters-expected.txt:
* editing/pasteboard/insert-div-text-into-text-expected.txt:
* editing/pasteboard/interchange-newline-1-expected.txt:
* editing/pasteboard/interchange-newline-2-expected.txt:
* editing/pasteboard/merge-end-3-expected.txt:
* editing/pasteboard/merge-end-4-expected.txt:
* editing/pasteboard/merge-end-5-expected.txt:
* editing/pasteboard/merge-end-list-2-expected.txt:
* editing/pasteboard/merge-end-table-2-expected.txt:
* editing/pasteboard/paste-after-inline-style-element-expected.txt:
* editing/pasteboard/paste-blockquote-2-expected.txt:
* editing/pasteboard/paste-blockquote-3-expected.txt:
* editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:
* editing/pasteboard/paste-blockquote-into-blockquote-expected.txt:
* editing/pasteboard/paste-into-blockquote-with-document-font-color-expected.txt:
* editing/pasteboard/pasting-word-in-div-extra-line-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-005-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-008-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-017-expected.txt:
* platform/mac/editing/deleting/delete-br-010-expected.txt:
* platform/mac/editing/deleting/delete-line-012-expected.txt:
* platform/mac/editing/deleting/delete-listitem-001-expected.txt:
* platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
* platform/mac/editing/pasteboard/5032095-expected.txt:
* platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
* platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
* platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
* platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
* platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r96595): First frame in assertion backtraces is no longer labeled "1"
gavinp@chromium.org [Thu, 6 Oct 2011 23:02:05 +0000 (23:02 +0000)]
REGRESSION (r96595): First frame in assertion backtraces is no longer labeled "1"
https://bugs.webkit.org/show_bug.cgi?id=69556

Reviewed by Adam Roben.

* wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in VisiblePosition::canonicalPosition.
inferno@chromium.org [Thu, 6 Oct 2011 22:55:20 +0000 (22:55 +0000)]
Crash in VisiblePosition::canonicalPosition.
https://bugs.webkit.org/show_bug.cgi?id=69568

Reviewed by Ryosuke Niwa.

Source/WebCore:

Move the position's containerNode calculation after layout is
complete(in updateLayoutIgnorePendingStylesheets).

Test: editing/selection/selection-plugin-clear-crash.html

* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::canonicalPosition):

LayoutTests:

* editing/selection/selection-plugin-clear-crash-expected.txt: Added.
* editing/selection/selection-plugin-clear-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96861.
commit-queue@webkit.org [Thu, 6 Oct 2011 22:47:17 +0000 (22:47 +0000)]
Unreviewed, rolling out r96861.
http://trac.webkit.org/changeset/96861
https://bugs.webkit.org/show_bug.cgi?id=69573

This patch didn't compile on windows (Requested by annacc on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-06

Source/WebCore:

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):

Source/WebKit/chromium:

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe GTK+ WebKit2 headers produce a lot of style warnings
commit-queue@webkit.org [Thu, 6 Oct 2011 22:44:45 +0000 (22:44 +0000)]
The GTK+ WebKit2 headers produce a lot of style warnings
https://bugs.webkit.org/show_bug.cgi?id=69481

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-06
Reviewed by David Levin.

Prevent emitting so many style warnings for GTK+ API. We skip header
files in the WebKit2 GTK+ API directory and also avoid warnings about
identifier names that begin with "webkit_" in files that contain the
string "gtk".

* Scripts/webkitpy/style/checker.py: Do not check header files in
Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
adding the ability to specify a regular expression in the skip list. Remove
a few files from the skipped list that no longer exist.
* Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
* Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
about identifiers that begin with "webkit_".
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Correct config.json for WinCairo Test builds.
bfulgham@webkit.org [Thu, 6 Oct 2011 22:43:40 +0000 (22:43 +0000)]
[WinCairo] Correct config.json for WinCairo Test builds.
https://bugs.webkit.org/show_bug.cgi?id=69272

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/config.json: Remove
 old 'WinCairo Debug (Build)' label and replace with correct
 'WinCairo Release' label.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIn background window, page flashes white if it enters and then immediately leaves...
andersca@apple.com [Thu, 6 Oct 2011 21:59:05 +0000 (21:59 +0000)]
In background window, page flashes white if it enters and then immediately leaves compositing mode
https://bugs.webkit.org/show_bug.cgi?id=69566
<rdar://problem/9521192>

Reviewed by Dan Bernstein.

Don't update the backing store state if we're just about to exit accelerated compositing mode. Otherwise
the UI process will try to render an empty layer tree for a short period of time, leading to a white flash.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a style checker watchlist definition and add myself to it.
levin@chromium.org [Thu, 6 Oct 2011 21:58:12 +0000 (21:58 +0000)]
Add a style checker watchlist definition and add myself to it.
https://bugs.webkit.org/show_bug.cgi?id=69564

Reviewed by Daniel Bates.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove passing tests from test_expectations.txt.
simonjam@chromium.org [Thu, 6 Oct 2011 21:56:29 +0000 (21:56 +0000)]
[Chromium] Remove passing tests from test_expectations.txt.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Adding parens in WebVTTParser.cpp to appease compiler preferences.
annacc@chromium.org [Thu, 6 Oct 2011 21:44:31 +0000 (21:44 +0000)]
Source/WebCore: Adding parens in WebVTTParser.cpp to appease compiler preferences.
https://bugs.webkit.org/show_bug.cgi?id=69460

Reviewed by David Levin.

No new tests. No new functionality.

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):

Source/WebKit/chromium: Turn ENABLE_VIDEO_TRACK on for chromium.
https://bugs.webkit.org/show_bug.cgi?id=69460

Reviewed by David Levin.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG implementation of UInt32ToNumber is missing a break statement
fpizlo@apple.com [Thu, 6 Oct 2011 21:43:00 +0000 (21:43 +0000)]
DFG implementation of UInt32ToNumber is missing a break statement
https://bugs.webkit.org/show_bug.cgi?id=69552

Reviewed by Oliver Hunt.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCode clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods...
fsamuel@chromium.org [Thu, 6 Oct 2011 21:36:30 +0000 (21:36 +0000)]
Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false
https://bugs.webkit.org/show_bug.cgi?id=69009

Reviewed by Simon Fraser.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Upcoming patches may make use of absoluteBoundingBoxRect on a const RenderObject, so this needed to be fixed.
Making useTransforms default to true instead of false and replacing instances of absoluteBoundingBoxRect() to
absoluteBoundingBoxRectIgnoringTransforms() partially addreses // FIXME: useTransforms should go away eventually.

* WebCore.exp.in:
* dom/Element.cpp:
(WebCore::Element::screenRect):
* dom/Node.cpp:
(WebCore::Node::getRect):
(WebCore::Node::renderRect):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
* inspector/DOMNodeHighlighter.cpp:
* plugins/IFrameShimSupport.cpp:
(WebCore::getPluginOcclusions):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::absoluteRects):
(WebCore::RenderBox::absoluteQuads):
* rendering/RenderBox.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::culledInlineAbsoluteQuads):
* rendering/RenderInline.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::paintingRootRect):
* rendering/RenderObject.h:
(WebCore::RenderObject::absoluteRects):
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::absoluteQuads):
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteQuads):
* rendering/RenderText.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::showPopup):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
(WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
* rendering/RenderView.cpp:
(WebCore::RenderView::absoluteRects):
(WebCore::RenderView::absoluteQuads):
* rendering/RenderView.h:
* rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::absoluteRects):
* rendering/svg/RenderSVGBlock.h:
* rendering/svg/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::absoluteQuads):
* rendering/svg/RenderSVGHiddenContainer.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::absoluteQuads):
* rendering/svg/RenderSVGInline.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::absoluteRects):
(WebCore::RenderSVGModelObject::absoluteQuads):
* rendering/svg/RenderSVGModelObject.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::absoluteQuads):
* rendering/svg/RenderSVGText.h:
* testing/Internals.cpp:
(WebCore::Internals::boundingBox):

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96859 268f45cc-cd09-0410-ab3c-d52691b4dbfc