WebKit-https.git
14 years ago New build to fix the i386 arch. (The _cuEnc64 symbol was missing.)
thatcher [Fri, 24 Feb 2006 02:00:03 +0000 (02:00 +0000)]
    New build to fix the i386 arch. (The _cuEnc64 symbol was missing.)

        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-23 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 01:11:00 +0000 (01:11 +0000)]
2006-02-23  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Fix linking of static constructed globals on win32.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * config.h:
        * dom/EventNames.cpp:
        (WebCore::EventNames::init):
        * dom/EventNames.h:
        * dom/dom_qname.cpp:
        (WebCore::QualifiedName::init):
        * dom/dom_qname.h:
        * khtml/html/htmlnames.cpp:
        (WebCore::HTMLNames::init):
        * khtml/html/htmlnames.h:
        * platform/AtomicString.cpp:
        (WebCore::AtomicString::init):
        * platform/StaticConstructors.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick.
vicki [Fri, 24 Feb 2006 00:20:17 +0000 (00:20 +0000)]
    Reviewed by Tim Omernick.

        - fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event

        Check shouldClose() before actually scheduling a close.

        shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a
        result based on whether the user clicks "OK" or "Cancel".  In cases where the window is closed with cmd-w
        or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method.  Since
        windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check
        for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that
        closes a window even gets started.

        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::scheduleClose): add a check for shouldClose()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin, Maciej.
ggaren [Thu, 23 Feb 2006 19:52:25 +0000 (19:52 +0000)]
    Reviewed by Darin, Maciej.

        - Inline some functions suggested by Shark. 2.9% speedup on super
        accurate JS iBench.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7411
        <rdar://problem/4448116>

        * kjs/nodes.h:
        (KJS::ArgumentsNode::evaluateList):
        * kjs/object.cpp:
        * kjs/object.h:
        (KJS::ScopeChain::release):
        (KJS::JSObject::toPrimitive):
        * kjs/scope_chain.cpp:
        * kjs/ustring.cpp:
        * kjs/ustring.h:
        (KJS::UString::toArrayIndex):
        * kjs/value.cpp:
        * kjs/value.h:
        (KJS::JSValue::toObject):
        * kxmlcore/FastMalloc.cpp:
        (KXMLCore::TCMalloc_ThreadCache_FreeList::Push):
        (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
vicki [Thu, 23 Feb 2006 19:46:50 +0000 (19:46 +0000)]
    Reviewed by Hyatt.

        - fix <rdar://problem/4456004> onbeforeunload should cancel, and
        <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)

        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window
        event, so we should be using handleWindowEvent rather than dispatching a
        generic event on the body. It seems this only worked before because of incorrect
        code in other parts of the tree.
        * dom/dom2_eventsimpl.cpp:
        (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor,
        pass true for the cancel parameter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Thu, 23 Feb 2006 19:28:25 +0000 (19:28 +0000)]
    Reviewed by Darin.

        - Turn http tests back on by default.
        - Wait for Apache to actually start serving requests.
        - Get user id from a built-in variable rather than an external command;
        don't pass the group.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Mitz Pettel, reviewed by Darin.
ap [Thu, 23 Feb 2006 17:25:36 +0000 (17:25 +0000)]
    Suggested by Mitz Pettel, reviewed by Darin.

        * Scripts/run-webkit-tests: Pass User and Group directives, so that Apache
        can run CGIs even if the permissions are 700 or 600.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Collaborating with Alexey.
darin [Thu, 23 Feb 2006 16:39:25 +0000 (16:39 +0000)]
    Collaborating with Alexey.

        - turn off http tests by default until we figure out how to get them
          to run even when permissions on CGI files are 700 instead of 755

        * Scripts/run-webkit-tests: Set $testHTTP to 0 instead of 1 for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-23 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 09:01:18 +0000 (09:01 +0000)]
2006-02-23  Eric Seidel  <eseidel@apple.com>

        Add *.user to ignore list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-23 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 08:55:57 +0000 (08:55 +0000)]
2006-02-23  Eric Seidel  <eseidel@apple.com>

        Remove binary file which shouldn't have been commited (and add to ignore list).

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Removed.
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Thu, 23 Feb 2006 07:09:14 +0000 (07:09 +0000)]
    Reviewed by Eric.

        * Scripts/run-webkit-tests: Put Apache log files in the right directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 04:10:20 +0000 (04:10 +0000)]
2006-02-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by Tim Hatcher.

        Fix install-win-extras to not try to re-install setx if installed.

        * Scripts/install-win-extras:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 03:52:41 +0000 (03:52 +0000)]
2006-02-22  Eric Seidel  <eseidel@apple.com>

        One more file possibly missing from previous commit?

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb:
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 03:38:44 +0000 (03:38 +0000)]
2006-02-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by justing.

        Files missing from previous commit.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 03:27:04 +0000 (03:27 +0000)]
2006-02-22  Eric Seidel  <eseidel@apple.com>

        Rubber-stamped by justing.

        Corrected path for DumpRenderTree.intermediate files

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 03:14:19 +0000 (03:14 +0000)]
2006-02-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by justing.

        Fixed build-dumprendertree to exit with correct error codes.

        * Scripts/build-dumprendertree:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 02:49:31 +0000 (02:49 +0000)]
2006-02-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by justing.

        Update build scripts to generalize building on Win32, and allow
        building of DumpRenderTree on Win32 from build-dumprendertree.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (main):
        * Scripts/build-dumprendertree:
        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 00:56:09 +0000 (00:56 +0000)]
2006-02-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        * DumpRenderTree/DumpRenderTree.vcproj: Added.
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Added.
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Added.
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Added.
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added.
        (_tmain):
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
        * Scripts/build-webkit: make build-webkit cleanup after itself

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Feb 2006 00:36:23 +0000 (00:36 +0000)]
2006-02-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Adding stub FrameWin class to expose link errors.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/win/FrameWin.cpp: Added.
        * bridge/win/FrameWin.h: Added.
        (WebCore::Win):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
mjs [Thu, 23 Feb 2006 00:33:08 +0000 (00:33 +0000)]
    Reviewed by Geoff.

        - move QStringList to platform, make it portable

        * ForwardingHeaders/qstringlist.h: Removed.
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DocumentImpl.h:
        * kcanvas/KCanvasFilters.h:
        * khtml/xbl/xbl_protohandler.cpp:
        * ksvg2/svg/SVGColorImpl.cpp:
        * ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
        * ksvg2/svg/SVGDOMImplementationImpl.h:
        * ksvg2/svg/SVGFEBlendElementImpl.cpp:
        * ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
        * ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
        * ksvg2/svg/SVGFECompositeElementImpl.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp:
        * ksvg2/svg/SVGFEFloodElementImpl.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
        * ksvg2/svg/SVGFELightElementImpl.cpp:
        * ksvg2/svg/SVGFEMergeElementImpl.cpp:
        * ksvg2/svg/SVGFEOffsetElementImpl.cpp:
        * ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
        * ksvg2/svg/SVGFETileElementImpl.cpp:
        * ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
        * ksvg2/svg/SVGFitToViewBoxImpl.cpp:
        * ksvg2/svg/SVGLengthListImpl.cpp:
        * ksvg2/svg/SVGNumberListImpl.cpp:
        * ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
        * ksvg2/svg/SVGStringListImpl.cpp:
        * ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
        * ksvg2/svg/SVGTransformableImpl.cpp:
        * kwq/KWQClipboard.mm:
        * kwq/KWQKConfigBase.mm:
        * kwq/KWQKHTMLSettings.h:
        * kwq/KWQKLocale.h:
        * kwq/KWQKSSLKeyGen.h:
        * kwq/KWQStringList.h: Removed.
        * kwq/KWQStringList.mm: Removed.
        * loader/DocLoader.h:
        * page/Frame.h:
        * platform/QStringList.cpp: Added.
        (QStringList::split):
        (QStringList::pop_front):
        * platform/QStringList.h: Added.
        * platform/mac/QStringListMac.mm: Added.
        (QStringList::getNSArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Wed, 22 Feb 2006 06:10:25 +0000 (06:10 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7409
          Some minor fixes to http tests.

LayoutTests:

        * http/conf/httpd.conf: don't define CustomLog and ErrorLog - these are now
        passed from run-webkit-tests.
        * http/tests/favicon.ico: Added.
        * http/tests/incremental/slow-utf8-text.text: Remove an unused variable,
        * http/tests/incremental/split-hex-entities.html: Ditto.
        * http/tests/xmlhttprequest/interactive-state.cgi: Ditto.

WebKitTools:

        * Scripts/run-webkit-tests: Pass CustomLog and ErrorLog directives to httpd.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
kdecker [Wed, 22 Feb 2006 00:55:26 +0000 (00:55 +0000)]
    Reviewed by Darin.

        Backed out my previous check in. Since these methods are internal to WebKit (and not private)
        it's perfectly OK for them to remain as categories.
        * ChangeLog:
        * WebView/WebPreferences.m:
        (-[WebPreferences _integerValueForKey:]):
        (-[WebPreferences _setIntegerValue:forKey:]):
        (-[WebPreferences _floatValueForKey:]):
        (-[WebPreferences _setFloatValue:forKey:]):
        (-[WebPreferences _boolValueForKey:]):
        (-[WebPreferences _setBoolValue:forKey:]):
        * WebView/WebPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
adele [Tue, 21 Feb 2006 23:49:10 +0000 (23:49 +0000)]
    Reviewed by Hyatt.

        - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7330
        baselinePosition is wrong for new text field when empty

        * fast/forms/input-baseline-expected.checksum: Added.
        * fast/forms/input-baseline-expected.png: Added.
        * fast/forms/input-baseline-expected.txt: Added.
        * fast/forms/input-baseline.html: Added.
        * fast/inline-block/contenteditable-baseline-expected.checksum: Added.
        * fast/inline-block/contenteditable-baseline-expected.png: Added.
        * fast/inline-block/contenteditable-baseline-expected.txt: Added.
        * fast/inline-block/contenteditable-baseline.html: Added.

        Reviewed by Hyatt.

        Tests:
        * fast/forms/input-baseline.html
        * fast/inline-block/contenteditable-baseline.html

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7330
        baselinePosition is wrong for new text field when empty

        * rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox):
         If we're dealing with an empty contenteditable block, then we've added height to the block to make room for the caret,
         and there are no children to give us the baseline.  Instead, compute the baseline for the block itself, and factor in the border and the padding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
vicki [Tue, 21 Feb 2006 22:55:29 +0000 (22:55 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7363
        REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

        Add a nil check for the renderer, and refetch the renderer for the old focus node
        after dispatching the event.

        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::setFocusNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-21 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 21 Feb 2006 22:19:38 +0000 (22:19 +0000)]
2006-02-21  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Add grammarWrapper.cpp to work around visual studio bug plaguing buildbot.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Timo O.
kdecker [Tue, 21 Feb 2006 21:51:14 +0000 (21:51 +0000)]
    Reviewed by Timo O.

        Moved these (already private) methods into the private WebPreferences header.
        Slightly better style than sprinkling the code with categories.

        * WebView/WebPreferences.m:
        (-[WebPreferences _integerValueForKey:]): Moved to WebPreferences (WebPrivate).
        (-[WebPreferences _floatValueForKey:]): Ditto.
        (-[WebPreferences _boolValueForKey:]): Ditto.
        (-[WebPreferences _setBoolValue:forKey:]): Ditto.
        (-[WebPreferences _setFloatValue:forKey:]): Ditto.
        (-[WebPreferences _setIntegerValue:forKey:]): Ditto.
        * WebView/WebPreferencesPrivate.h: Added the above methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Accidentally wrote "Release" instead of "Debug" in my last patch.
ggaren [Tue, 21 Feb 2006 19:34:00 +0000 (19:34 +0000)]
    Accidentally wrote "Release" instead of "Debug" in my last patch.

        * quality/leakhunting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-21 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 21 Feb 2006 19:17:18 +0000 (19:17 +0000)]
2006-02-21  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        * kjs/testkjs.cpp: #if out timeval code on win32

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Tue, 21 Feb 2006 19:12:37 +0000 (19:12 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6197
          Would like to use locally installed Apache for testing.

        Added two run-webkit-tests options:
          --http (--nohttp)  - whether to launch Apache (defaults to yes);
          --port - which port to listen on (defaults to 8000).

        Tests in LayoutTests/http are not run directly, and Apache is used instead.
        For example, http/tests/xmlhttprequest/post-content-type.html is loaded as
        http://127.0.0.1:8000/xmlhttprequest/post-content-type.html.

        Also added support for .shtml and .text files. Text files give an empty
        *-expected.txt, but a correct image.

        Apache only listens on the loopback interface. It writes logs to /tmp/WebKit.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Tue, 21 Feb 2006 17:04:07 +0000 (17:04 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7397
          TCPageMap.h would not compile for me because string.h was missing

        * kxmlcore/TCPageMap.h: Added <string.h> include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin [Tue, 21 Feb 2006 16:57:53 +0000 (16:57 +0000)]
    Reviewed by John Sullivan.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7404
          remove a bunch of extra implementsCall overrides

        * JavaScriptCore.xcodeproj/project.pbxproj: Sorted files.

        * kjs/internal.h: Made InternalFunctionImp::callAsFunction pure virtual so that
        we'll get a compile error if some derived class neglects to implement it.

        * kjs/function.cpp: (KJS::FunctionImp::FunctionImp): Remove unneeded initialization
        of param, which is an OwnPtr so it gets initialized by default.

        * bindings/runtime_method.cpp:
        * bindings/runtime_method.h:
        * kjs/array_object.cpp:
        * kjs/array_object.h:
        * kjs/bool_object.cpp:
        * kjs/bool_object.h:
        * kjs/date_object.cpp:
        * kjs/date_object.h:
        * kjs/error_object.cpp:
        * kjs/error_object.h:
        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/function_object.cpp:
        * kjs/function_object.h:
        * kjs/math_object.cpp:
        * kjs/math_object.h:
        * kjs/number_object.cpp:
        * kjs/number_object.h:
        * kjs/object_object.cpp:
        * kjs/object_object.h:
        * kjs/regexp_object.cpp:
        * kjs/regexp_object.h:
        * kjs/string_object.cpp:
        * kjs/string_object.h:
        Removed many rendundant implementations of implementsCall from subclasses of
        InternalFunctionImp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Mark Rowe.
darin [Tue, 21 Feb 2006 16:09:57 +0000 (16:09 +0000)]
    Suggested by Mark Rowe.

        * Scripts/run-webkit-tests: Don't include the number of excluded leaks when
        reporting leak counts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fixed build
darin [Tue, 21 Feb 2006 15:29:03 +0000 (15:29 +0000)]
    - fixed build

        * kjs/internal.cpp: (KJS::InternalFunctionImp::implementsCall):
        Oops, fixed name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Change suggested by Mitz.
darin [Tue, 21 Feb 2006 15:19:43 +0000 (15:19 +0000)]
    Change suggested by Mitz.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7402
          REGRESSION: Methods do not execute

        * kjs/internal.h: Add implementsHasCall to InternalFunctionImp.
        * kjs/internal.cpp: (KJS::InternalFunctionImp::implementsHasCall):
        Return true. All the classes derived from InternalFunctionImp need
        to return true from this -- later we can remove all the extra
        implementations too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber Stamped by Hyatt.
mjs [Tue, 21 Feb 2006 10:15:37 +0000 (10:15 +0000)]
    Rubber Stamped by Hyatt.

        - renamed STATIC, FIXED, RELATIVE, ABSOLUTE to StaticPosition, FixedPosition, etc

        This avoids conflicting with win32 headers.

        * css/css_computedstyle.cpp:
        (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        (WebCore::CSSStyleSelector::applyProperty):
        * editing/htmlediting.cpp:
        (WebCore::isSpecialElement):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):
        * rendering/render_box.cpp:
        (WebCore::RenderBox::setStyle):
        (WebCore::RenderBox::absolutePosition):
        (WebCore::RenderBox::computeAbsoluteRepaintRect):
        * rendering/render_flow.cpp:
        (WebCore::RenderFlow::getAbsoluteRepaintRect):
        * rendering/render_layer.cpp:
        (WebCore::RenderLayer::convertToLayerCoords):
        (WebCore::RenderLayer::calculateClipRects):
        (WebCore::RenderLayer::calculateRects):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::markContainingBlocksForLayout):
        (WebCore::RenderObject::containingBlock):
        (WebCore::RenderObject::setStyle):
        (WebCore::RenderObject::container):
        * rendering/render_style.cpp:
        (WebCore::RenderStyle::diff):
        * rendering/render_style.h:
        (khtml::):
        (khtml::RenderStyle::initialPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber Stamped by Hyatt.
mjs [Tue, 21 Feb 2006 09:59:03 +0000 (09:59 +0000)]
    Rubber Stamped by Hyatt.

        - remove KWQSignalStubs.cpp from project.

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Platform build fix, not reviewed.
mjs [Tue, 21 Feb 2006 09:23:03 +0000 (09:23 +0000)]
    Platform build fix, not reviewed.

        - undef min and max, and include <algorithm> so std::min works

        * rendering/font.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix build breakage caused by last-minute change to my patch
mjs [Tue, 21 Feb 2006 08:56:20 +0000 (08:56 +0000)]
    - fix build breakage caused by last-minute change to my patch

        * kjs/lookup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Tue, 21 Feb 2006 08:21:08 +0000 (08:21 +0000)]
LayoutTests:

        Reviewed by Geoff and Darin.

        Patch from Maks Orlovich, based on work by David Faure, hand-applied and
        significantly reworked by me.

        - Patch: give internal function names (KJS merge)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6279

        Updated test results, now showing correct function string.

        * fast/dom/xmlhttprequest-get-expected.txt:
        * fast/js/kde/function-expected.txt:
        * fast/js/kde/inbuilt_function_tostring-expected.txt:

WebCore:

        Reviewed by Geoff and Darin.

        Patch from Maks Orlovich, based on work by David Faure, hand-applied and
        significantly reworked by me.

        - Patch: give internal function names (KJS merge)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6279

        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElementFunction::HTMLElementFunction):
        * kwq/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame functionName]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Some quick proof-reading of the patch I just landed -- no review
ggaren [Tue, 21 Feb 2006 07:55:13 +0000 (07:55 +0000)]
    Some quick proof-reading of the patch I just landed -- no review
        necessary.

        * quality/leakhunting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff and Darin.
mjs [Tue, 21 Feb 2006 07:54:55 +0000 (07:54 +0000)]
    Reviewed by Geoff and Darin.

        Patch from Maks Orlovich, based on work by David Faure, hand-applied and
        significantly reworked by me.

        - Patch: give internal function names (KJS merge)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6279

        * tests/mozilla/expected.html: Updated for newly fixed test.

        * kjs/array_object.cpp:
        (ArrayProtoFunc::ArrayProtoFunc):
        * kjs/array_object.h:
        * kjs/bool_object.cpp:
        (BooleanPrototype::BooleanPrototype):
        (BooleanProtoFunc::BooleanProtoFunc):
        * kjs/bool_object.h:
        * kjs/date_object.cpp:
        (KJS::DateProtoFunc::DateProtoFunc):
        (KJS::DateObjectImp::DateObjectImp):
        (KJS::DateObjectFuncImp::DateObjectFuncImp):
        * kjs/error_object.cpp:
        (ErrorPrototype::ErrorPrototype):
        (ErrorProtoFunc::ErrorProtoFunc):
        * kjs/error_object.h:
        * kjs/function.cpp:
        (KJS::FunctionImp::FunctionImp):
        (KJS::GlobalFuncImp::GlobalFuncImp):
        * kjs/function.h:
        * kjs/function_object.cpp:
        (FunctionPrototype::FunctionPrototype):
        (FunctionProtoFunc::FunctionProtoFunc):
        (FunctionProtoFunc::callAsFunction):
        * kjs/function_object.h:
        * kjs/internal.cpp:
        (KJS::InterpreterImp::initGlobalObject):
        (KJS::InternalFunctionImp::InternalFunctionImp):
        * kjs/internal.h:
        (KJS::InternalFunctionImp::functionName):
        * kjs/lookup.h:
        (KJS::staticFunctionGetter):
        (KJS::HashEntryFunction::HashEntryFunction):
        (KJS::HashEntryFunction::implementsCall):
        (KJS::HashEntryFunction::toBoolean):
        (KJS::HashEntryFunction::implementsHasInstance):
        (KJS::HashEntryFunction::hasInstance):
        * kjs/math_object.cpp:
        (MathFuncImp::MathFuncImp):
        * kjs/math_object.h:
        * kjs/number_object.cpp:
        (NumberPrototype::NumberPrototype):
        (NumberProtoFunc::NumberProtoFunc):
        * kjs/number_object.h:
        * kjs/object.cpp:
        (KJS::JSObject::putDirectFunction):
        (KJS::Error::create):
        * kjs/object.h:
        * kjs/object_object.cpp:
        (ObjectPrototype::ObjectPrototype):
        (ObjectProtoFunc::ObjectProtoFunc):
        * kjs/object_object.h:
        * kjs/regexp_object.cpp:
        (RegExpPrototype::RegExpPrototype):
        (RegExpProtoFunc::RegExpProtoFunc):
        * kjs/regexp_object.h:
        * kjs/string_object.cpp:
        (StringProtoFunc::StringProtoFunc):
        (StringObjectImp::StringObjectImp):
        (StringObjectFuncImp::StringObjectFuncImp):
        * kjs/string_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin, Geoff.
ggaren [Tue, 21 Feb 2006 07:47:43 +0000 (07:47 +0000)]
    Reviewed by Darin, Geoff.

        Added a page about leakhunting, based on the info Sullivan gave in two blogposts about it. (posts 20 and 24)

        Added this page to the menu, adding in an extra section header

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Tue, 21 Feb 2006 07:46:51 +0000 (07:46 +0000)]
    Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7331
          CSS parser leaks when parsing incorrect CSS

        * css/css_base.h:
        (WebCore::CSSSelector::append): Replaced recursive implementation
        with an iterative one.
        (WebCore::StyleBaseImpl::StyleBaseImpl): Changed to be a Shared, not
        a TreeShared; parents now ref children as needed. This change was
        vital to fix the storage leaks. Also removed unused multiLength bool.
        (WebCore::StyleBaseImpl::parent): Added. Needed now that there's no
        TreeShared base class.
        (WebCore::StyleBaseImpl::setParent): Ditto.
        (WebCore::StyleBaseImpl::insertedIntoParent): Added. Hook for
        notification when added to a parent -- used by import style rules.
        (WebCore::StyleListImpl::StyleListImpl): Changed to use a Vector instead
        of a QPtrList for children. Slower for dynamic insert and remove for the
        DOM API, faster and more efficient for everything else.
        * css/css_base.cpp:
        (WebCore::StyleListImpl::append): Now calls insertedIntoParent
        and uses Vector.
        (WebCore::StyleListImpl::insert): Added. Calls insertedIntoParent.
        (WebCore::StyleListImpl::remove): Added.

        * css/css_grammar.y: Removed obsolete "don't inline" stuff. Changed all
        code that creates new objects to use new functions on CSSParser. For
        CSSSelector, ValueList, Function, and Value, this means using new
        functions with a "floating" concept, but for reference-counted classes
        this just means asking the CSSParser to create the object instead of
        calling new. Remove all explicit "delete", which is now handled by the
        parser instead, which works when the Bison-generated parser fails too,
        not just when it hits error rules in the grammar.

        * css/css_ruleimpl.h:
        * css/css_ruleimpl.cpp:
        (WebCore::CSSImportRuleImpl::CSSImportRuleImpl): Remove call to init()
        which kicks off style sheet loading. We now do that when we are added to
        our parent instead of construction time. Also removed unused constructor.
        (WebCore::CSSImportRuleImpl::insertedIntoParent): Replaced init() with this
        function that does much the same thing at a different time. Changed code
        that sets m_loading to do it in a simple way that doesn't need a big comment.
        (WebCore::CSSMediaRuleImpl::insertRule): Use RefPtr.

        * css/css_stylesheetimpl.cpp:
        (StyleSheetImpl::StyleSheetImpl): Pass 0 for parent explicitly since the
        empty constructor was removed in the other patch.
        (CSSStyleSheetImpl::CSSStyleSheetImpl): Remove code to set up m_lstChildren;
        that's now handled by the base class.
        (CSSStyleSheetImpl::insertRule): Use length() instead of m_listChildren->count()
        and insert instead of m_lstChildren->insert. Also use RefPtr for the result of
        parseRule.
        (CSSStyleSheetImpl::addRule): Use length() instead of m_lstChildren->count().
        (CSSStyleSheetImpl::deleteRule): Use length() instead of checking the result of
        take() for 0. Use remove() instead of m_lstChildren->take().
        (CSSStyleSheetImpl::parseString): Use setStrictParsing instead of going at the
        strictParsing data member directly.
        (CSSStyleSheetImpl::isLoading): Use length() and item() instead of
        m_lstChildren->first() and m_lstChildren->next().

        * css/css_valueimpl.h: Add an include of QPtrList now that it's not used in
        any included file. Also added a constructor for CSSValueImpl, now that StyleBaseImpl
        has no empty constructor.
        * css/css_valueimpl.cpp:
        (WebCore::CSSMutableStyleDeclarationImpl::setProperty): Use useStrictParsing()
        instead of looking at the strictParsing data member directly.
        (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration): Ditto.
        (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty): Ditto.
        (WebCore::CSSMutableStyleDeclarationImpl::setCssText): Ditto.

        * css/cssparser.h:
        (WebCore::ValueList): Changed to use a Vector and an index rather
        than using a QPtrList.
        (WebCore::CSSParser): Changed parseRule to return a PassRefPtr, removed the
        createStyleDeclaration function since that's now handled by createStyleRule,
        made clearProperties be private, and added a suite of functions to create the
        objects formerly made with "new" in the Bison grammar. Also put the Units enum
        here in the header, and added an operator so they can be or'ed together while
        staying with the enum type so we can use Units instead of int for a function arg.
        * css/cssparser.cpp:
        (WebCore::ValueList::~ValueList): Changed to use Vector.
        (WebCore::CSSParser::CSSParser): Removed initializer for rule now that it's a RefPtr.
        (WebCore::CSSParser::~CSSParser): Added code to delete all the items in the sets that
        track floating objects. Also removed an unneeded check before callling clearProperties.
        (WebCore::CSSParser::parseSheet): Removed "delete rule" since rule is now a RefPtr.
        (WebCore::CSSParser::parseRule): Changed code to use rule.release() since rule is now
        a RefPtr and this function now returns a PassRefPtr.
        (WebCore::CSSParser::parseValue): Removed "delete rule" since rule is now a RefPtr.
        (WebCore::CSSParser::parseColor): Ditto.
        (WebCore::CSSParser::parseDeclaration): Ditto.
        (WebCore::CSSParser::validUnit): Made this a static class member instead of a local
        function so it can be used by the SVG parser code. Also updated to use the new ValueList
        class that uses Vector.
        (WebCore::CSSParser::parse4Values): Updated to new ValueList.
        (WebCore::CSSParser::parseContent): Ditto.
        (WebCore::skipCommaInDashboardRegion): Ditto.
        (WebCore::CSSParser::parseDashboardRegions): Ditto.
        (WebCore::CSSParser::parseShape): Ditto.
        (WebCore::CSSParser::parseColorFromValue): Ditto.
        (WebCore::BorderImageParseContext::commitBorderImage): Ditto.
        (WebCore::CSSParser::createFloatingSelector): Added. Puts selector into floating set.
        (WebCore::CSSParser::sinkFloatingSelector): Added. Removes from floating set.
        (WebCore::CSSParser::createFloatingValueList): Added. Puts list into floating set.
        (WebCore::CSSParser::sinkFloatingValueList): Added. Removes from floating set.
        (WebCore::CSSParser::createFloatingFunction): Added. Puts function into floating set.
        (WebCore::CSSParser::sinkFloatingFunction): Added. Removes from floating set.
        (WebCore::CSSParser::sinkFloatingValue): Added. Removes function from floating set if
        value contains a function pointer.
        (WebCore::CSSParser::createMediaList): Added. Puts list in a vector of RefPtrs kept
        by the parser, so the object won't end up floating.
        (WebCore::CSSParser::createImportRule): Ditto.
        (WebCore::CSSParser::createMediaRule): Ditto.
        (WebCore::CSSParser::createRuleList): Ditto.
        (WebCore::CSSParser::createStyleRule): Ditto. The properties come from the parser's
        global state instead of from a parameter.

        * khtml/xsl/xsl_stylesheetimpl.h:
        * khtml/xsl/xsl_stylesheetimpl.cpp:
        (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): Initialize the new m_stylesheetDocTaken
        bool to false. Also remove code to set up m_lstChildren since the base class takes care
        of that now.
        (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): Only call xmlFreeDoc if the document
        was not taken by libxslt. We used to leak XSLStyleSheetImpl objects, which is why we
        didn't notice this before; we'll try to double free without this change.
        (WebCore::XSLStyleSheetImpl::isLoading): Use length() and item() instead of
        m_lstChildren->first() and m_lstChildren->next().
        (WebCore::XSLStyleSheetImpl::clearDocuments): Ditto.
        (WebCore::XSLStyleSheetImpl::parseString): Only call xmlFreeDoc if the document was not
        taken by libxslt. Also set m_stylesheetDocTaken for the new document.
        (WebCore::XSLStyleSheetImpl::loadChildSheet): Use RefPtr and append instead of
        m_lstChildren->append.
        (WebCore::XSLStyleSheetImpl::compileStyleSheet): Set m_stylesheetDocTaken to true if
        xsltParseStylesheetDoc is successful, since the stylesheet then owns the document.
        (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource): Use length() and item()
        instead of m_lstChildren->first() and m_lstChildren->next().
        (WebCore::XSLStyleSheetImpl::markAsProcessed): Set m_stylesheetDocTaken, since when
        this is called, the document is returned to libxslt which then attaches it to a
        stylesheet or parent document.

        * ksvg2/css/KSVGCSSParser.cpp: Changed to compile as separate
        file instead of being included in cssparser.cpp.
        (WebCore::CSSParser::parseSVGPaint): Take out unnnecessary check
        of number of args. Everything works fine without that check, and
        otherwise I'd have to change it for the change in data structure.
        (WebCore::CSSParser::parseSVGColor): Ditto.
        * WebCore.xcodeproj/project.pbxproj: Added KSVGCSSParser.cpp.

        - fixed another leak found by run-webkit-leaks --leaks

        * kwq/KWQLoader.mm: (KWQServeRequest): Delete the job if we can't do the I/O, because
        the caller is passing ownership to us.

        - updated other code to use new Vector insert and remove

        * khtml/html/HTMLFormElementImpl.cpp:
        (WebCore::removeFromVector): Changed to use Vector's remove.
        (WebCore::HTMLFormElementImpl::registerFormElement): Changed to use Vector's insert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin, with help from Eric, Maciej.
ggaren [Tue, 21 Feb 2006 07:43:10 +0000 (07:43 +0000)]
    Reviewed by Darin, with help from Eric, Maciej.

        - More changes to support super-accurate JS iBench. Doesn't work on
        Windows. (Doesn't break Windows, either.) I've filed [http://bugzilla.
        opendarwin.org/show_bug.cgi?id= 7399] about that.

        * kjs/interpreter.cpp:
        (KJS::Interpreter::evaluate): Print line numbers with exception output
        * kjs/testkjs.cpp: Changed " *" to "* " because Eric says that's the
        way we roll with .cpp files.
        (StopWatch::StopWatch): New class. Provides microsecond-accurate
        timings.
        (StopWatch::~StopWatch):
        (StopWatch::start):
        (StopWatch::stop):
        (StopWatch::getElapsedMS):
        (TestFunctionImp::callAsFunction): Added missing return statement.
        Fixed up "run" to use refactored helper functions. Removed bogus
        return statement from "quit" case. Made "print" output to stdout
        instead of stderr because that makes more sense, and PERL handles
        stdout better.
        (main): Factored out KXMLCore unit tests. Removed custom exception
        printing code because the interpreter prints exceptions for you. Added
        a "delete" call for the GlobalImp we allocate.
        (testIsInteger): New function, result of refacotring.
        (createStringWithContentsOfFile): New function, result of refactoring.
        Renamed "code" to "buffer" to match factored-out-ness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Tue, 21 Feb 2006 07:29:00 +0000 (07:29 +0000)]
LayoutTests:

        - test http://bugzilla.opendarwin.org/show_bug.cgi?id=6831
          contentEditable outline darkens as caret moves

        * editing/selection/move-by-character-6.html: Added.
        * editing/selection/move-by-character-6-expected.txt: Added.
        * editing/selection/move-by-character-6-expected.checksum: Added.
        * editing/selection/move-by-character-6-expected.png: Added.

WebCore:

        Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6831
          contentEditable outline darkens as caret moves

        Test: editing/selection/move-by-character-6.html

        The trick was to draw the focus ring clipped to a list of rectangles instead
        of clipped to exactly one.

        * kwq/KWQPainter.h: Move Color parameter from initFocusRing to drawFocusRing.
        * kwq/KWQPainter.mm:
        (WebCore::QPainterPrivate::QPainterPrivate): Change focusRingPath from
        an NSBezierPath to a CGMutablePathRef.
        (WebCore::QPainterPrivate::~QPainterPrivate): Ditto.
        (WebCore::QPainter::initFocusRing): Removed color parameter, and made a
        CGPath instead of an NSBezierPath.
        (WebCore::QPainter::addFocusRingRect): CGPath instead of NSBezierPath.
        (WebCore::QPainter::drawFocusRing): Added color parameter, and changed to
        use new bridge method to draw the focus ring.
        (WebCore::QPainter::clearFocusRing): CGPath instead of NSBezierPath.

        * kwq/WebCoreGraphicsBridge.h:
        * kwq/WebCoreGraphicsBridge.m:
        (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:]):
        Replaced setFocusRingStyle: method with this one.

        * rendering/render_flow.cpp: (WebCore::RenderFlow::paintFocusRing):
        * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline):
        Pass color to drawFocusRing instead of initFocusRing.

        - fixed message on exit from the other patch I just landed

        * platform/mac/CursorMac.mm:
        (WebCore::leakNamedCursor): Renamed and made this leak intentionally.

WebKit:

        Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this.

        - WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6831
          contentEditable outline darkens as caret moves

        * WebCoreSupport/WebGraphicsBridge.m:
        (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:]):
        Replaced the old bridge function that set up style with this one that renders a path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
darin [Tue, 21 Feb 2006 06:59:15 +0000 (06:59 +0000)]
    Reviewed by Hyatt.

        - moved Cursor into the platform directory from KWQ
        - removed a lot of other unneeded stuff from KWQ

        * platform/Cursor.h: Added.
        * platform/mac/CursorMac.mm: Added.
        * platform/mac/CursorWin.cpp: Added.

        * kwq/KWQBuffer.cpp: Removed.
        * kwq/KWQBuffer.h: Removed.
        * kwq/KWQCursor.h: Removed.
        * kwq/KWQCursor.mm: Removed.
        * kwq/KWQIODevice.h: Removed.
        * kwq/KWQKCursor.h: Removed.
        * kwq/KWQKCursor.mm: Removed.
        * kwq/KWQKDebug.h: Removed.
        * kwq/KWQSignalStubs.cpp: Removed.

        * ForwardingHeaders/kcursor.h: Removed.
        * ForwardingHeaders/kdebug.h: Removed.
        * ForwardingHeaders/qbuffer.h: Removed.

        * kwq/KWQEvent.h: Removed unused constants and types QCustomEvent,
        QFocusEvent, QHideEvent, QShowEvent, QContextMenuEvent, and QResizeEvent.

        * kwq/KWQLoader.h: Removed KWQLoader class since signals are no longer needed.
        * kwq/KWQLoader.mm: Ditto.

        * kwq/KWQNamespace.h: Removed DontClip, ShowPrefix, WordBreak, LayoutDirection,
        LeftToRight, RightToLeft, RasterOp, CopyROP, OrROP, and XorROP.

        * kwq/KWQObject.h: Removed blockSignals, sender, _signalsBlocked, _sender,
        and KWQObjectSenderScope.
        * kwq/KWQObject.cpp:
        (QObject::QObject): Removed _signalsBlocked.
        (QObject::connect): Removed special-case signals to not complain about.
        All of them were either unused, converted to non-signal functions, or in one
        case (slotScrollBarMoved) turned into a FIXME.

        * kwq/KWQPainter.h: Removed rasterOp and setRasterOp.
        * kwq/KWQPainter.mm: Ditto.

        * kwq/KWQSignal.h:
        * kwq/KWQSignal.cpp: (KWQSignal::disconnect): Removed special cases for
        various signals; all are now using plain function calls instead.

        * kwq/KWQSlot.h:
        * kwq/KWQSlot.cpp: Removed slots that are no longer needed because they
        are using plain function calls instead of signals.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Updated for changed files.

        * bridge/mac/FrameViewMac.mm: Moved the contents of KWQKHTMLView.cpp in here.
        * bridge/mac/KWQKHTMLView.cpp: Removed.

        * bridge/mac/MacFrame.h: Removed signals, changed setStatusBarText to take
        String instead of QString.
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::MacFrame): Removed signals.
        (WebCore::MacFrame::setStatusBarText): Changed parameter type.
        (WebCore::MacFrame::openURLFromPageCache): Removed parameter from started function.
        (WebCore::MacFrame::khtmlMouseMoveEvent): Changed from QCursor() to pointerCursor().

        * dom/DocumentImpl.h:
        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::DocumentImpl): Removed signals.
        (WebCore::DocumentImpl::implicitOpen): Ditto.
        (WebCore::DocumentImpl::determineParseMode): Removed a use of kdDebug.
        (WebCore::DocumentImpl::finishedParsing): Added. Does a setParsing(false) and then
        calls finishedParsing on the frame. Replaces the old finishedParsing signal.

        * dom/xml_tokenizer.h:
        * dom/xml_tokenizer.cpp: Removed the finishedParsing signal since it's not just
        a function on the document.
        (WebCore::XMLTokenizer::finish): Call the function instead of emitting the signal.

        * khtml/html/htmlparser.h:
        * khtml/html/htmlparser.cpp: Moved the parser inside the WebCore namespace.

        * khtml/html/htmltokenizer.h:
        * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::end): Updated
        to call finishedParsing function on document rather than emitting a signal.

        * kwq/KWQComboBox.mm:
        (-[KWQPopUpButton becomeFirstResponder]): Use QEvent instead of QFocusEvent.
        (-[KWQPopUpButton resignFirstResponder]): Ditto.
        * kwq/KWQFileButton.mm: (KWQFileButton::focusChanged): Ditto.
        * kwq/KWQListBox.mm:
        (-[KWQTableView becomeFirstResponder]): Ditto.
        (-[KWQTableView resignFirstResponder]): Ditto.
        * kwq/KWQSlider.mm:
        (-[KWQSlider becomeFirstResponder]): Ditto.
        (-[KWQSlider resignFirstResponder]): Ditto.
        * kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView becomeFirstResponder]): Ditto.
        (-[KWQTextAreaTextView resignFirstResponder]): Ditto.
        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController setHasFocus:]): Ditto.

        * kwq/KWQTextStream.h: Removed the mode parameter from the QTextStream constructor.
        Removed the QTextIStream and QTextOStream classes.
        * kwq/KWQTextStream.cpp: (QTextStream::QTextStream): Removed the mode parameter.

        * loader/CachedCSSStyleSheet.h: Changed to take a ByteArray instead of a QBuffer.
        * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data): Ditto.
        * loader/CachedImage.h: Ditto.
        * loader/CachedImage.cpp: (WebCore::CachedImage::data): Ditto.
        * loader/CachedObject.h: Ditto.
        * loader/CachedScript.h: Ditto.
        * loader/CachedScript.cpp: (WebCore::CachedScript::data): Ditto.
        * loader/CachedXBLDocument.h: Ditto.
        * loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::data): Ditto.
        * loader/CachedXSLStyleSheet.h:
        * loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data): Ditto.

        * loader/DocLoader.cpp: (WebCore::DocLoader::setLoadInProgress): Added a call
        to loadDone on the frame. Replaces the requestFailed and requestDone signals.

        * loader/DocLoader.h: Removed include of <qbuffer.h>.

        * loader/Request.h:
        * loader/Request.cpp: Updated to use ByteArray instead of QBuffer.

        * loader/loader.h: Removed unused signals.
        * loader/loader.cpp:
        (WebCore::Loader::Loader): Removed use of KWQLoader.
        (WebCore::Loader::~Loader): Ditto.
        (WebCore::Loader::load): Removed code to emit unused requestStarted signal.
        (WebCore::Loader::slotFinished): Removed code to emit requestFailed and
        requestDone signals, now handled by DocLoader::setLoadInProgress(false).
        (WebCore::Loader::slotReceivedResponse): Use ByteArray instead of QBuffer.
        (WebCore::Loader::slotData): Ditto.

        * page/Frame.h: Removed setURLCursor, urlCursor, slotRestoreData, slotIncZoom,
        slotDecZoom, slotLoadImages, slotPartRemoved, slotActiveFrameChanged,
        slotChildURLRequest, slotShowDocument, slotAutoScroll, slotPrintFrame, slotSelectAll,
        slotProgressUpdate, slotJobPercent, slotJobSpeed.connectChild, disconnectChild,
        and changed a number of others from slots to plain old functions.
        * page/Frame.cpp:
        (WebCore::Frame::Frame): Don't connect to loader signals.
        (WebCore::Frame::~Frame): Don't disconnect from loader signals.
        (WebCore::Frame::didOpenURL): Call started function instead of emitting
        started signal. Don't connect to speed and percent signals (which never
        existed in WebCore anyway).
        (WebCore::Frame::stopLoading): Call finishedParsing function instead of
        calling slotFinishedParsing.
        (WebCore::Frame::executeScript): Removed redundant checks and let
        submitFormAgain do the checking.
        (WebCore::Frame::clear): Removed code to disconnect from finishedParsing
        signal; we now use a function. Also removed loop that calls disconnectChild,
        becase again we use functions now instead of signals.
        (WebCore::Frame::setDocument): Remove code to disconnect and connect to the
        finishedParsing signal.
        (WebCore::Frame::begin): Remove code to connect to the finishedParsing signal.
        (WebCore::Frame::finishedParsing): Moved code that does setParsing(false) into
        the document class. Also renamed from slotFinishedParsing.
        (WebCore::Frame::loadDone): Renamed from slotLoaderRequestDone.
        (WebCore::Frame::checkCompleted): Changed to call the completed function instead
        of emitting one of the two completed signals.
        (WebCore::Frame::loadSubframe): Removed call to connectChild because we now use
        functions instead of signals. Also change the call to completed to pass false
        instead of true.
        (WebCore::Frame::submitFormAgain): Change function around so we are less likely
        to leak if something strange happens inside submitForm.
        (WebCore::Frame::submitForm): Remove code to connect signal. We now call
        submitFormAgain from inside the completed function.
        (WebCore::Frame::parentCompleted): Renamed from slotParentCompleted. No longer
        a slot, now called from completed.
        (WebCore::Frame::childCompleted): Renamed from slotChildCompleted.
        (WebCore::Frame::setJSStatusBarText): Removed "emit" from function call. Changed
        to use String instead of QString.
        (WebCore::Frame::setJSDefaultStatusBarText): Ditto.
        (WebCore::Frame::sendResizeEvent): Changed to send DOM event directly instead of
        creating a QResizeEvent to send along to the FrameView.
        (WebCore::Frame::scrollToAnchor): Changed to not pass a parameter to the started
        function, which no longer takes one.
        (WebCore::Frame::frameDetached): Removed code that calls disconnectChild, since
        we no longer use signals.
        (WebCore::Frame::completed): Added. Calls childCompleted, parentCompleted, and
        submitFormAgain.
        (WebCore::Frame::setStatusBarText): Added.
        (WebCore::Frame::started): Added. Sets the complete flag to false for the frame
        and all its ancestors, which is what slotChildStarted did recursively.

        * page/FramePrivate.h: Removed m_activeFrame and changed m_kjsStatusBarText and
        m_kjsDefaultStatusBarText to String from QString.

        * page/FrameView.h: Removed resizeEvent, focusInEvent, focusOutEvent, and
        slotPaletteChanged. Changed cleared from a signal to a private function and
        slotScrollBarMoved to a private function named scrollBarMoved.
        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView): Removed connect call here that was connecting
        a signal that's nonexistent in WebCore; we'll want to rig it up later.
        (WebCore::FrameView::~FrameView): Added a call to setQWidget(0) here to replace
        something that was done with a signal before.
        (WebCore::FrameView::clear): Call cleared as a function rather than a signal.
        (WebCore::selectCursor): Changed to use Cursor instead of QCursor.
        (WebCore::FrameView::scrollBarMoved): Renamed this function, which is never called.
        Added a FIXME about calling it.
        (WebCore::FrameView::cleared): Added. Calls viewCleared on the owner part, which
        used to be done with a signal.

        * platform/Widget.h: Changed to Cursor from QCursor.
        * platform/mac/WidgetMac.mm: (WebCore::Widget::setCursor): Ditto.

        * rendering/render_frames.h:
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::userResize): Removed cursor-setting code here. We might
        want to use resize cursors for frames again, but it was mostly disabled anyway and
        it's not clear which cursors to use.
        (WebCore::RenderPart::setWidget): Removed code to connect to the cleared signal.
        Instead, FrameView takes care of it directly.
        (WebCore::RenderPart::viewCleared): Renamed from slotViewCleared.
        (WebCore::RenderFrame::viewCleared): Ditto.
        (WebCore::RenderPartObject::viewCleared): Ditto.

        * rendering/render_image.cpp:
        (WebCore::RenderImage::imageChanged): Removed use of WordBreak, which doesn't exist
        in WebCore text rendering.
        (WebCore::RenderImage::paint): Ditto.

        * rendering/render_list.cpp: (RenderListMarker::paint): Removed use of DontClip, which
        doesn't exist in WebCore text rendering. Also removed incorrect use of references to
        temporaries for the ". " and " ." strings.

        * rendering/render_object.cpp:
        (WebCore::RenderObject::drawBorder): Removed call to setRasterOp since it is a no-op
        in WebCore's painter. Added a FIXME.
        (WebCore::RenderObject::information): Remove mode parameter to QTextStream.

        * rendering/render_replaced.h: Removed slotWidgetDestructed, made setQWidget public,
        * rendering/render_replaced.cpp:
        (WebCore::RenderWidget::setQWidget): Removed code to connect slotWidgetDestructed to
        the destroyed signal. Instead FrameView calls setQWidget(0) on us.
        (WebCore::RenderWidget::eventFilter): Removed use of QFocusEvent::reason, which is
        never "popup" in WebCore.

        * WebCore+SVG/kdom.h:
        * css/css_stylesheetimpl.cpp:
        * css/css_valueimpl.cpp:
        * css/cssparser.cpp:
        * kcanvas/KCanvasCreator.cpp:
        * kcanvas/KCanvasResources.cpp:
        * kcanvas/RenderPath.cpp:
        * khtml/ecma/xmlserializer.cpp:
        * khtml/html/html_baseimpl.cpp:
        * khtml/xsl/xsl_stylesheetimpl.cpp:
        * ksvg2/svg/SVGPathSegLinetoImpl.cpp:
        * ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
        * ksvg2/svg/SVGTransformImpl.cpp:
        * platform/StringImpl.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/render_box.cpp:
        * rendering/render_canvas.cpp:
        * rendering/render_flow.cpp:
        * rendering/render_form.cpp:
        * rendering/render_layer.cpp:
        * rendering/render_style.cpp:
        Removed includes of <kdebug.h>.

        * css/css_base.cpp: (CSSSelector::selectorText):
        * khtml/ecma/kjs_binding.cpp:
        (KJS::ScriptInterpreter::wasRunByUserGesture):
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSRule::putValueProperty):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::getValueProperty):
        (KJS::DOMNode::putValueProperty):
        (KJS::DOMDocument::getValueProperty):
        * khtml/ecma/kjs_events.cpp:
        (KJS::DOMEvent::getValueProperty):
        (KJS::DOMUIEvent::getValueProperty):
        (KJS::DOMMouseEvent::getValueProperty):
        (KJS::DOMKeyboardEvent::getValueProperty):
        (KJS::Clipboard::getValueProperty):
        (KJS::Clipboard::putValueProperty):
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocument::getValueProperty):
        (KJS::KJS::HTMLDocument::putValueProperty):
        (KJS::HTMLElement::anchorGetter):
        (KJS::HTMLElement::areaGetter):
        (KJS::KJS::HTMLElementFunction::callAsFunction):
        * khtml/ecma/kjs_navigator.cpp:
        (KJS::Navigator::getValueProperty):
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::DOMNodeIterator::getValueProperty):
        (KJS::DOMTreeWalker::getValueProperty):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Screen::getValueProperty):
        (KJS::Window::scheduleClose):
        (KJS::Window::isSafeScript):
        (KJS::Window::clear):
        (KJS::LocationFunc::callAsFunction):
        (KJS::History::getValueProperty):
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
        (SVGAnimateColorElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimateElementImpl.cpp:
        (SVGAnimateElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
        (SVGAnimateTransformElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        (SVGAnimationElementImpl::parseMappedAttribute):
        * ksvg2/svg/SVGCursorElementImpl.cpp:
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (WebCore::SVGDocumentImpl::finishedParsing):
        * ksvg2/svg/SVGLengthImpl.cpp:
        (SVGLengthImpl::updateValueInSpecifiedUnits):
        Removed use of kdWarning, kdDebug, etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Tue, 21 Feb 2006 06:28:42 +0000 (06:28 +0000)]
    Reviewed by Darin.

        - port QString to win32

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * platform/QString.cpp:
        (strncasecmp):
        (QString::mid):
        (freeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-20 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 21 Feb 2006 00:16:58 +0000 (00:16 +0000)]
2006-02-20  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Fix "Copy ICU DLLs..." phase.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-20 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 20 Feb 2006 20:27:46 +0000 (20:27 +0000)]
2006-02-20  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        <rdar://problem/4449442> GMAIL: XMLHttpRequest does not correctly report "Interactive" state on receipt of load data
        Also cleaned up spacing a little.

        No layout test possible (local loads are non incremental).

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::changeState):
        (WebCore::XMLHttpRequest::slotData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Makefile.shared: Remove use of XcodeOptionStringNoConfig. We don't need it
thatcher [Mon, 20 Feb 2006 20:20:31 +0000 (20:20 +0000)]
* Makefile.shared: Remove use of XcodeOptionStringNoConfig. We don't need it
  because commands like "make debug" have a side effect of setting the current
  configuration anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Mon, 20 Feb 2006 09:29:00 +0000 (09:29 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7318
          REGRESSION: Timer bug causes gif animation and (html and JS) page forwarding to fail

        Timers were stopping firing after a while.

        My testing makes this look like a CFRunLoopTimer bug, and it would be nice to reproduce
        this with a standalone test and report it to the CF team, but in the mean time, change
        to create a new timer each time instead of reusing the existing timer.

        * platform/mac/SharedTimerMac.cpp:
        (WebCore::setSharedTimerFiredFunction): Added an assertion.
        (WebCore::setSharedTimerFireTime): Destroy the existing timer and create a new one every time.
        Also create a non-repeating timer rather than a repeating timer.
        (WebCore::stopSharedTimer): Destroy the existing timer rather than setting its fire date
        far into the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Mon, 20 Feb 2006 09:28:32 +0000 (09:28 +0000)]
    Reviewed by Darin.

        - Added install-win-extras script which installs some extra
        programs and libraries, and does Windows first-time setup.

        * Scripts/build-webkit: Add a newline between build results.
        * Scripts/install-win-extras: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebKitSystemInterface.h: Added WKDrawFocusRing.
darin [Sun, 19 Feb 2006 18:37:19 +0000 (18:37 +0000)]
    * WebKitSystemInterface.h: Added WKDrawFocusRing.
        * libWebKitSystemInterface.a: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Sun, 19 Feb 2006 17:37:28 +0000 (17:37 +0000)]
WebCore:

        Reviewed by Maciej.

        - cut out a little unneeded bridge code

        * bridge/mac/WebCoreFrameBridge.h: Removed frame name from createWindowWithURL: method
        and changed it to return a page bridge. Also made createModalDialogWithURL: method
        return a page bridge. Removed the mainFrame and webView methods.
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge nextFrameWithWrap:]): Use page to get to main frame.
        (-[WebCoreFrameBridge setFrameNamespace:]): Ditto.
        (-[WebCoreFrameBridge frameNamespace]): Ditto.
        (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Ditto.
        (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]): Ditto.
        (-[WebCoreFrameBridge findFrameNamed:]): Ditto.
        (-[WebCoreFrameBridge installInFrame:]): Ditto.

        * bridge/mac/WebCorePageBridge.h: Added outerView method to replace webView method
        on the frame bridge.

        * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
        Update to use a page bridge instead of frame bridge.

WebKit:

        Reviewed by Maciej.

        - cut out a little unneeded bridge code

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge webView]): Added. Helper, since the WebCore side of the bridge no longer
        has this method.
        (-[WebFrameBridge createWindowWithURL:]): Removed the frameName parameter -- this is now
        handled on the WebCore side. Also return a page bridge instead of a frame bridge.
        (-[WebFrameBridge createModalDialogWithURL:]): Changed to return a page bridge instead of
        a frame bridge.

        * WebView/WebFrame.m: (-[WebFrame webView]): Change to get the webView from the page bridge
        instead of the frame bridge, since it's a per-page thing.

        * WebView/WebView.m: Removed init method since it just does what the default does (calls
        initWithFrame: with a zero rect).
        (-[WebView initWithCoder:]): Added checking so that if the obejcts have the wrong type
        we will fail gracefully instead of hitting "method not found" and the like.
        (-[WebView setPreferencesIdentifier:]): Fix storage leak. The WebPreferences object was
        not released.
        (-[WebView mainFrame]): Removed excess "return nil".
        (-[WebView _pageBridge]): Added. Helper to let you go from the WebView to the bridge
        from outside the WebView class.
        * WebView/WebViewInternal.h: Put _pageBridge into an internal header.

        * WebCoreSupport/WebPageBridge.m: (-[WebPageBridge outerView]): Added. Replaces "webView"
        as public method to tell the WebCore side about the view everything's embedded in.

        - other cleanup

        * WebCoreSupport/WebPageBridge.h: Removed some unneeded declarations.

        * Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]):
        Rearrange code so it doesn't have to get the main frame twice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - renamed ERROR to LOG_ERROR to fix build
darin [Sun, 19 Feb 2006 17:20:40 +0000 (17:20 +0000)]
    - renamed ERROR to LOG_ERROR to fix build
          presumably Maciej had this change and forgot to land it

        * kjs/collector.cpp: Removed now-unneeded #undef ERROR.
        * kxmlcore/Assertions.h: Renamed ERROR to LOG_ERROR.
        * kxmlcore/FastMalloc.cpp: Changed MESSAGE macro to use LOG_ERROR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Anders.
mjs [Sun, 19 Feb 2006 13:35:35 +0000 (13:35 +0000)]
    Rubber-stamped by Anders.

        - renamed ERROR to LOG_ERROR because some operating systems define ERROR in a system header

        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::passMouseDownEventToWidget):
        * bridge/mac/WebCoreFrameBridge.mm:
        (aeDescFromJSValue):
        (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
        * css/css_computedstyle.cpp:
        (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
        * editing/Selection.cpp:
        (WebCore::Selection::toRange):
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (WebCore::KCanvasFEBlendQuartz::getCIFilter):
        (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (WebCore::KRenderingDeviceQuartz::createResource):
        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::parseErrorFunc):
        * kwq/KWQFontMetrics.mm:
        (QFontMetrics::ascent):
        (QFontMetrics::descent):
        (QFontMetrics::lineSpacing):
        (QFontMetrics::xHeight):
        (QFontMetrics::width):
        (QFontMetrics::floatWidth):
        (QFontMetrics::checkSelectionPoint):
        * kwq/KWQKConfigBase.mm:
        (KConfig::readEntry):
        (KConfig::readNumEntry):
        (KConfig::readUnsignedNumEntry):
        * kwq/KWQLineEdit.mm:
        (KWQNSTextAlignmentForAlignmentFlags):
        * kwq/KWQObject.cpp:
        (QObject::connect):
        * kwq/KWQPainter.mm:
        (WebCore::QPainter::restore):
        (WebCore::QPainter::drawFocusRing):
        * kwq/KWQRegExp.cpp:
        (QRegExp::KWQRegExpPrivate::compile):
        (QRegExp::match):
        * kwq/KWQSignal.cpp:
        (KWQSignal::connect):
        (KWQSignal::disconnect):
        * kwq/KWQSlot.cpp:
        (KWQSlot::KWQSlot):
        * kwq/KWQTextCodec.cpp:
        (KWQTextDecoder::createICUConverter):
        (KWQTextDecoder::convertUsingICU):
        * kwq/WebCoreTextRendererFactory.mm:
        (-[WebCoreTextRendererFactory fontWithFamilies:traits:size:]):
        (-[WebCoreTextRendererFactory isFontFixedPitch:]):
        (-[WebCoreTextRendererFactory rendererWithFont:]):
        * page/Frame.cpp:
        (WebCore::Frame::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Sun, 19 Feb 2006 09:49:00 +0000 (09:49 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7308
          DumpRenderTree should be able to load files via HTTP

        * DumpRenderTree/DumpRenderTree.m: (dumpRenderTree):
        Handle tests starting with "http://" as real URLs, not file system paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ap [Sun, 19 Feb 2006 09:42:08 +0000 (09:42 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7357
          REGRESSION: Warnings from WebKit scripts if PBXProductDirectory is undefined

        * Scripts/webkitdirs.pm: only call chomp if PBXProductDirectory is configured.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix bogus line in ChangeLog.
mjs [Sun, 19 Feb 2006 09:41:10 +0000 (09:41 +0000)]
Fix bogus line in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Hyatt.
mjs [Sun, 19 Feb 2006 03:37:38 +0000 (03:37 +0000)]
    Reviewed by Dave Hyatt.

        - fix win32 build

        * css/css_grammar.y:
        * khtml/html/html_objectimpl.cpp: #ifdef out all bindings code
        (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl):
        (WebCore::HTMLAppletElementImpl::detach):
        (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl):
        (WebCore::HTMLEmbedElementImpl::detach):
        (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl):
        (WebCore::HTMLObjectElementImpl::detach):
        * khtml/html/html_objectimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Sun, 19 Feb 2006 01:34:35 +0000 (01:34 +0000)]
    Reviewed by Darin.

        Fixed Bugzilla URL's

        * projects/forms/index.html:
        * projects/html/index.html:
        * projects/xslt/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Sun, 19 Feb 2006 01:31:31 +0000 (01:31 +0000)]
JavaScriptCore:

        Test: fast/js/toString-exception.html

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7343
          REGRESSION: fast/js/toString-overrides.html fails when run multiple times

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction): Remove the object from the visited elements set before
        returning an error.

LayoutTests:

        Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7343
          REGRESSION: fast/js/toString-overrides.html fails when run multiple times

        * fast/js/resources/toString-exception.js: Added.
        * fast/js/toString-exception-expected.txt: Added.
        * fast/js/toString-exception.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Sun, 19 Feb 2006 01:24:55 +0000 (01:24 +0000)]
    Reviewed by Darin.

        Made line-height global instead of just for p

        Editing:
        fixed bugzilla link, added starting <p> to first paragraph
        removed paragraph about tab-stops

        * css/main.css:
        * projects/editing/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-18 Alexander Kellett <lypanov@kde.org>
lypanov [Sun, 19 Feb 2006 00:21:41 +0000 (00:21 +0000)]
2006-02-18  Alexander Kellett  <lypanov@kde.org>

        Reviewed by Maciej.

        - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7199.

        Testcase:
          svg/custom/text-gradient-no-content.svg

        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (WebCore::KRenderingPaintServerGradientQuartz::teardown):

2006-02-18  Alexander Kellett  <lypanov@kde.org>

        Reviewed by Maciej.

        - new test for
          http://bugzilla.opendarwin.org/show_bug.cgi?id=7199
          Text gradient fills entire screen if text empty

        * svg/custom/text-gradient-no-content.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/commit-log-editor: Added.
darin [Sun, 19 Feb 2006 00:20:42 +0000 (00:20 +0000)]
    * Scripts/commit-log-editor: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Sat, 18 Feb 2006 23:48:37 +0000 (23:48 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7345
          add insert and remove to KXMLCore::Vector

        * kxmlcore/Vector.h: Added "moveOverlapping", which is used in both
        insert and remove to slide elements within the vector. Also added
        "insert" and "remove" functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
harrison [Sat, 18 Feb 2006 18:55:03 +0000 (18:55 +0000)]
    Reviewed by John.

        <rdar://problem/4448212> _accessibilityTableCell please remove this.

        Remove override of a defamed AX method.

        * kwq/KWQListBox.mm:
        Dump _accessibilityTableCell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Not reviewed.
mjs [Sat, 18 Feb 2006 08:21:51 +0000 (08:21 +0000)]
    Not reviewed.

        - fix build broken by my last checkin, the remaining code was not doing anything.

        * WebView/WebDataSource.m:
        * WebView/WebDataSourcePrivate.h:
        * WebView/WebFrame.m:
        (-[WebFrame _createPageCacheForItem:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Sat, 18 Feb 2006 05:47:51 +0000 (05:47 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4227
          The ex unit doesn't work for font-variant: small-caps

        * fast/css/ex-after-font-variant-expected.checksum: Added.
        * fast/css/ex-after-font-variant-expected.png: Added.
        * fast/css/ex-after-font-variant-expected.txt: Added.
        * fast/css/ex-after-font-variant.html: Added.

WebCore:

        Test: fast/css/ex-after-font-variant.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4227
          The ex unit doesn't work for font-variant: small-caps

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyDeclarations): Added CSS_PROP_FONT_VARIANT to the properties
        that need to be applied first, since it dirties the font.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Sat, 18 Feb 2006 05:14:38 +0000 (05:14 +0000)]
    Reviewed by Darin.

        - removed a few unused fields and methods of WebDataSource

        * WebView/WebDataSource.m:
        * WebView/WebDataSourcePrivate.h:
        * WebView/WebView.m:
        (+[WebView _MIMETypeForFile:]):
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-17 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 18 Feb 2006 00:15:17 +0000 (00:15 +0000)]
2006-02-17  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Make Win32 have the same default "WebKitBuild" directory behavior.

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * coding/coding-style.html: Mention other non-function brace cases.
darin [Sat, 18 Feb 2006 00:06:30 +0000 (00:06 +0000)]
    * coding/coding-style.html: Mention other non-function brace cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by eric
justing [Fri, 17 Feb 2006 23:48:17 +0000 (23:48 +0000)]
    Reviewed by eric

        This test appears to be occasionally hanging.  Disabling it while
        I figure out why.

        * editing/selection/drag-to-contenteditable-iframe.html: Removed.
        * editing/selection/drag-to-contenteditable-iframe.html-disabled: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-17 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 17 Feb 2006 23:36:26 +0000 (23:36 +0000)]
2006-02-17  Eric Seidel  <eseidel@apple.com>

        Reviewed by Beth.

        * Scripts/build-webkit: make win32 actually report errors

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-17 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 17 Feb 2006 23:08:34 +0000 (23:08 +0000)]
2006-02-17  Eric Seidel  <eseidel@apple.com>

        Reviewed by adele.

        * Scripts/run-webkit-tests: Ignore quicktime plugin leaks

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-17 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 17 Feb 2006 22:49:43 +0000 (22:49 +0000)]
2006-02-17  Eric Seidel  <eseidel@apple.com>

        Reviewed by adele.

        * Scripts/run-webkit-tests: Ignore flash leaks

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim H.
thatcher [Fri, 17 Feb 2006 22:18:11 +0000 (22:18 +0000)]
    Reviewed by Tim H.

        Added left position and margin-bottom to blog footer.

        * css/main.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
adele [Fri, 17 Feb 2006 19:15:06 +0000 (19:15 +0000)]
    Reviewed by Beth.

        Adding isEdited/setEdited hooks so onChange will fire for the new text fields.

        * rendering/RenderTextField.cpp:
        (WebCore::m_dirty):
        (WebCore::RenderTextField::updateFromElement): setEdited to false when value attribute has changed.
        (WebCore::RenderTextField::subtreeHasChanged): setEdited to true when anonymous editable div has changed.
        * rendering/RenderTextField.h:
        (WebCore::RenderTextField::isEdited):
        (WebCore::RenderTextField::setEdited):
        (WebCore::RenderTextField::isTextField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
ggaren [Fri, 17 Feb 2006 18:31:22 +0000 (18:31 +0000)]
    Reviewed by John.

        - Fixed <rdar://problem/4448534> TOT REGRESSION: crash in KJS::
        Bindings::Instance::deref when leaving page @ gigaom.com

        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::~CInstance): Since we cache the class object
        globally, we shouldn't delete it, so don't.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin.
vicki [Fri, 17 Feb 2006 09:54:15 +0000 (09:54 +0000)]
    Reviewed by Justin.

        Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
        where we resign focus on the previous node in setFocusNode.  Add isTextField on RenderObject
        as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
        contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
        checked in handleFocusOut methods in isEdited() and setEdited().

        Fixes the following bugs:
        <rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
        <rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE

        Test case is on the way.

        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event
        on the node that is resigning focus.  Make sure the blur event fires after the change event - 4447009.
        * rendering/render_form.cpp:
        (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code.
        (WebCore::RenderLineEdit::isEdited): Added.
        (WebCore::RenderLineEdit::setEdited): Added.
        (WebCore::RenderTextArea::setEdited): Added.
        * rendering/render_form.h:
        (WebCore::RenderLineEdit::isTextField): Added.
        (WebCore::RenderTextArea::isTextArea): Make this non-virtual.
        (WebCore::RenderTextArea::isEdited): Added.
        * rendering/render_object.h:
        (WebCore::RenderObject::isEdited): Added.
        (WebCore::RenderObject::setEdited): Added.
        (WebCore::RenderObject::isTextField): Added.
        * rendering/render_replaced.h: Remove handleFocusOut().
        * rendering/render_replaced.cpp: Ditto.
        (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut().  Safe to do here,
        since we call setFocusNode immediately beforehand.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Fri, 17 Feb 2006 09:49:37 +0000 (09:49 +0000)]
LayoutTests:

        Reviewed by Anders Carlsson.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7265
          REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag

        * fast/parser/nofoo-tags-inside-paragraph-expected.checksum: Added.
        * fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
        * fast/parser/nofoo-tags-inside-paragraph-expected.txt: Added.
        * fast/parser/nofoo-tags-inside-paragraph.html: Added.

WebCore:

        Test: fast/parser/nofoo-tags-inside-paragraph.html

        Reviewed by Anders Carlsson.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7265
          REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag

        * khtml/html/htmlparser.cpp:
        (HTMLParser::isInline): Treat noframes, nolayer, noembed and skipped noscript
        as inline elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
adele [Fri, 17 Feb 2006 09:43:40 +0000 (09:43 +0000)]
    Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7235
          Pure CSS Tooltips method renders wrong and creates artifacts

        * manual-tests/bugzilla-7235.html: Added.
        * rendering/render_box.cpp:
        (WebCore::RenderBox::absolutePosition): Copied in here the logic for positioning
        relative to a relpositioned inline from RenderLayer::updateLayerPosition.
        (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Fri, 17 Feb 2006 09:37:34 +0000 (09:37 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
          Text underlined on mouse over

        * fast/css/universal-hover-quirk-expected.checksum: Added.
        * fast/css/universal-hover-quirk-expected.png: Added.
        * fast/css/universal-hover-quirk-expected.txt: Added.
        * fast/css/universal-hover-quirk.html: Added.

WebCore:

        Test: fast/css/universal-hover-quirk.html

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
          Text underlined on mouse over

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active
        from matching anything in quirks mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Fri, 17 Feb 2006 09:31:35 +0000 (09:31 +0000)]
LayoutTests:

        Reviewed by Dave Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7216
          white-space: pre-wrap collapses leading whitespace following a newline

        * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
        * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
        * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Added.
        * fast/text/whitespace/pre-wrap-spaces-after-newline.html: Added.

WebCore:

        Test: fast/text/whitespace/pre-wrap-spaces-after-newline.html

        Reviewed by Dave Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7216
          white-space: pre-wrap collapses leading whitespace following a newline

        * rendering/bidi.cpp:
        (khtml::RenderBlock::bidiReorderLine): Use previousLineBrokeCleanly instead of
        resetBidiAtEnd now that the former is always correct.
        (khtml::RenderBlock::layoutInlineChildren): Use new skipTrailingNewline flag.
        (khtml::RenderBlock::findNextLineBreak): Set previousLineBrokeCleanly for line breaks
        caused by newlines as well. Added skipTrailingNewline flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
tomernic [Fri, 17 Feb 2006 08:02:39 +0000 (08:02 +0000)]
    Reviewed by Adele.

        <rdar://problem/4193286> enabledPlugin returns a non-NULL object even when plugins are
        disabled (4140)

        * khtml/ecma/kjs_navigator.cpp:
        (KJS::MimeType::getValueProperty):
        Only return a Plugin object for the "enabledPlugin" property if plugins are enabled.  This
        matches what other browsers do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
thatcher [Fri, 17 Feb 2006 05:36:46 +0000 (05:36 +0000)]
    Reviewed by Maciej.

        Fixes PNGs with 8bit alpha on IE.

        * css/ie.css: attach the pngbehavior.htc to img tags
        * images/blank.png: Added.
        * index.html: add the width and height to the download img
        * pngbehavior.htc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric and Justin.
darin [Fri, 17 Feb 2006 01:08:41 +0000 (01:08 +0000)]
    Reviewed by Eric and Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7310
          fix leaks by using RefPtr more

        * bindings/objc/DOM.mm:
        (-[DOMDocument adoptNode:]):
        (-[DOMDocument createElement:]):
        (-[DOMDocument createDocumentFragment]):
        (-[DOMDocument createTextNode:]):
        (-[DOMDocument createComment:]):
        (-[DOMDocument createCDATASection:]):
        (-[DOMDocument createProcessingInstruction::]):
        (-[DOMDocument createEntityReference:]):
        (-[DOMDocument importNode::]):
        (-[DOMDocument createElementNS::]):
        (-[DOMDocument createRange]):
        (-[DOMDocument createCSSStyleDeclaration]):
        (-[DOMDocument createNodeIterator::::]):
        (-[DOMDocument createTreeWalker::::]):
        * bindings/objc/DOMCSS.mm:
        (-[DOMCSSStyleDeclaration getPropertyCSSValue:]):
        * bindings/objc/DOMEvents.mm:
        (-[DOMDocument createEvent:]):
        * bridge/mac/MacFrame.h:
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::MacFrame):
        (WebCore::MacFrame::freeClipboard):
        (WebCore::MacFrame::setView):
        (WebCore::MacFrame::wheelEvent):
        (WebCore::MacFrame::openURLFromPageCache):
        (WebCore::MacFrame::mouseDownViewIfStillGood):
        (WebCore::MacFrame::khtmlMouseMoveEvent):
        (WebCore::MacFrame::dispatchCPPEvent):
        (WebCore::MacFrame::mouseDown):
        (WebCore::MacFrame::mouseDragged):
        (WebCore::MacFrame::mouseUp):
        (WebCore::MacFrame::mouseMoved):
        (WebCore::MacFrame::sendContextMenuEvent):
        (WebCore::MacFrame::dispatchDragSrcEvent):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge convertToDOMRange:]):
        (-[WebCoreFrameBridge convertNSRangeToDOMRange:]):
        (-[WebCoreFrameBridge selectNSRange:]):
        (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
        (-[WebCoreFrameBridge typingStyle]):
        (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
        (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
        (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
        * css/css_computedstyle.cpp:
        (WebCore::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl):
        (WebCore::CSSComputedStyleDeclarationImpl::cssText):
        (WebCore::CSSComputedStyleDeclarationImpl::setCssText):
        (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
        (WebCore::CSSComputedStyleDeclarationImpl::getPropertyValue):
        (WebCore::CSSComputedStyleDeclarationImpl::removeProperty):
        (WebCore::CSSComputedStyleDeclarationImpl::setProperty):
        (WebCore::CSSComputedStyleDeclarationImpl::item):
        (WebCore::CSSComputedStyleDeclarationImpl::copyInheritableProperties):
        (WebCore::CSSComputedStyleDeclarationImpl::copy):
        (WebCore::CSSComputedStyleDeclarationImpl::makeMutable):
        * css/css_computedstyle.h:
        * css/css_grammar.y:
        * css/css_ruleimpl.cpp:
        (WebCore::CSSStyleRuleImpl::~CSSStyleRuleImpl):
        (WebCore::CSSStyleRuleImpl::setDeclaration):
        * css/css_ruleimpl.h:
        (DOM::CSSStyleRuleImpl::style):
        (DOM::CSSStyleRuleImpl::declaration):
        * css/css_valueimpl.cpp:
        (WebCore::propertyID):
        (WebCore::quoteStringIfNeeded):
        (WebCore::CSSStyleDeclarationImpl::getPropertyCSSValue):
        (WebCore::CSSStyleDeclarationImpl::getPropertyValue):
        (WebCore::CSSStyleDeclarationImpl::getPropertyPriority):
        (WebCore::CSSStyleDeclarationImpl::getPropertyShorthand):
        (WebCore::CSSStyleDeclarationImpl::isPropertyImplicit):
        (WebCore::CSSStyleDeclarationImpl::setProperty):
        (WebCore::CSSStyleDeclarationImpl::removeProperty):
        (WebCore::CSSStyleDeclarationImpl::isPropertyName):
        (WebCore::CSSMutableStyleDeclarationImpl::getPropertyValue):
        (WebCore::CSSMutableStyleDeclarationImpl::get4Values):
        (WebCore::CSSMutableStyleDeclarationImpl::getShortHandValue):
        (WebCore::CSSMutableStyleDeclarationImpl::getPropertyCSSValue):
        (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
        (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
        (WebCore::CSSMutableStyleDeclarationImpl::setStringProperty):
        (WebCore::CSSMutableStyleDeclarationImpl::setImageProperty):
        (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration):
        (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty):
        (WebCore::CSSMutableStyleDeclarationImpl::item):
        (WebCore::CSSMutableStyleDeclarationImpl::cssText):
        (WebCore::CSSMutableStyleDeclarationImpl::setCssText):
        (WebCore::CSSMutableStyleDeclarationImpl::copyBlockProperties):
        (WebCore::CSSStyleDeclarationImpl::copyPropertiesInSet):
        (WebCore::CSSMutableStyleDeclarationImpl::removePropertiesInSet):
        (WebCore::CSSMutableStyleDeclarationImpl::makeMutable):
        (WebCore::CSSMutableStyleDeclarationImpl::copy):
        (WebCore::CSSInheritedValueImpl::cssText):
        (WebCore::CSSInitialValueImpl::cssText):
        (WebCore::CSSValueListImpl::append):
        (WebCore::CSSValueListImpl::cssText):
        (WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
        (WebCore::CSSPrimitiveValueImpl::cleanup):
        (WebCore::CSSPrimitiveValueImpl::setStringValue):
        (WebCore::CSSPrimitiveValueImpl::getStringValue):
        (WebCore::CSSPrimitiveValueImpl::parseString):
        (WebCore::CSSPrimitiveValueImpl::cssText):
        (WebCore::CSSImageValueImpl::CSSImageValueImpl):
        (WebCore::CSSBorderImageValueImpl::CSSBorderImageValueImpl):
        (WebCore::CSSBorderImageValueImpl::cssText):
        (WebCore::FontFamilyValueImpl::FontFamilyValueImpl):
        (WebCore::FontFamilyValueImpl::cssText):
        (WebCore::FontValueImpl::cssText):
        (WebCore::ShadowValueImpl::ShadowValueImpl):
        (WebCore::ShadowValueImpl::cssText):
        (WebCore::CSSProperty::cssText):
        * css/css_valueimpl.h:
        (WebCore::CSSValueImpl::setCssText):
        (WebCore::CSSValueListImpl::item):
        (WebCore::CSSPrimitiveValueImpl::getFloatValue):
        (WebCore::CSSPrimitiveValueImpl::getCounterValue):
        (WebCore::CSSPrimitiveValueImpl::getRectValue):
        (WebCore::CSSPrimitiveValueImpl::getRGBColorValue):
        (WebCore::CSSPrimitiveValueImpl::getPairValue):
        (WebCore::CSSPrimitiveValueImpl::getDashboardRegionValue):
        (WebCore::CSSPrimitiveValueImpl::):
        (WebCore::CSSQuirkPrimitiveValueImpl::CSSQuirkPrimitiveValueImpl):
        (WebCore::CounterImpl::identifier):
        (WebCore::CounterImpl::listStyle):
        (WebCore::CounterImpl::separator):
        (WebCore::RectImpl::top):
        (WebCore::RectImpl::right):
        (WebCore::RectImpl::bottom):
        (WebCore::RectImpl::left):
        (WebCore::RectImpl::setTop):
        (WebCore::RectImpl::setRight):
        (WebCore::RectImpl::setBottom):
        (WebCore::RectImpl::setLeft):
        (WebCore::PairImpl::first):
        (WebCore::PairImpl::second):
        (WebCore::PairImpl::setFirst):
        (WebCore::PairImpl::setSecond):
        (WebCore::DashboardRegionImpl::DashboardRegionImpl):
        (WebCore::FontFamilyValueImpl::fontName):
        (WebCore::CSSProperty::CSSProperty):
        (WebCore::CSSProperty::value):
        (WebCore::CSSMutableStyleDeclarationImpl::setNode):
        (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
        (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
        * css/cssparser.cpp:
        (CSSParser::createStyleDeclaration):
        (CSSParser::parseDashboardRegions):
        * css/cssparser.h:
        (WebCore::Value::):
        (WebCore::qString):
        (WebCore::domString):
        (WebCore::atomicString):
        (WebCore::ValueList::current):
        (WebCore::ValueList::next):
        (WebCore::CSSParser::current):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * dom/DOMImplementationImpl.cpp:
        (DOM::DOMImplementationImpl::createDocument):
        (DOM::DOMImplementationImpl::instance):
        * dom/DOMImplementationImpl.h:
        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::DocumentImpl):
        (WebCore::DocumentImpl::~DocumentImpl):
        (WebCore::DocumentImpl::setDocType):
        (WebCore::DocumentImpl::createElement):
        (WebCore::DocumentImpl::createDocumentFragment):
        (WebCore::DocumentImpl::createTextNode):
        (WebCore::DocumentImpl::createComment):
        (WebCore::DocumentImpl::createCDATASection):
        (WebCore::DocumentImpl::createProcessingInstruction):
        (WebCore::DocumentImpl::createEntityReference):
        (WebCore::DocumentImpl::createEditingTextNode):
        (WebCore::DocumentImpl::createCSSStyleDeclaration):
        (WebCore::DocumentImpl::importNode):
        (WebCore::DocumentImpl::adoptNode):
        (WebCore::DocumentImpl::createElementNS):
        (WebCore::DocumentImpl::setTitle):
        (WebCore::DocumentImpl::createRange):
        (WebCore::DocumentImpl::createNodeIterator):
        (WebCore::DocumentImpl::createTreeWalker):
        (WebCore::DocumentImpl::setStyleSheet):
        (WebCore::DocumentImpl::setHoverNode):
        (WebCore::DocumentImpl::setActiveNode):
        (WebCore::DocumentImpl::setFocusNode):
        (WebCore::DocumentImpl::defaultView):
        (WebCore::DocumentImpl::createEvent):
        (WebCore::DocumentImpl::setHTMLWindowEventListener):
        (WebCore::DocumentImpl::addWindowEventListener):
        (WebCore::DocumentImpl::createHTMLEventListener):
        (WebCore::DocumentImpl::images):
        (WebCore::DocumentImpl::applets):
        (WebCore::DocumentImpl::embeds):
        (WebCore::DocumentImpl::objects):
        (WebCore::DocumentImpl::links):
        (WebCore::DocumentImpl::forms):
        (WebCore::DocumentImpl::anchors):
        (WebCore::DocumentImpl::all):
        (WebCore::DocumentImpl::windowNamedItems):
        (WebCore::DocumentImpl::documentNamedItems):
        (WebCore::DocumentImpl::getElementsByName):
        * dom/DocumentImpl.h:
        (WebCore::DocumentImpl::realDocType):
        (WebCore::DocumentImpl::createAttribute):
        (WebCore::DocumentImpl::title):
        (WebCore::DocumentImpl::styleSelector):
        (WebCore::DocumentImpl::setRestoreState):
        (WebCore::DocumentImpl::restoreState):
        (WebCore::DocumentImpl::view):
        (WebCore::DocumentImpl::docLoader):
        (WebCore::DocumentImpl::tokenizer):
        (WebCore::DocumentImpl::focusNode):
        (WebCore::DocumentImpl::hoverNode):
        (WebCore::DocumentImpl::activeNode):
        (WebCore::DocumentImpl::policyBaseURL):
        (WebCore::DocumentImpl::setPolicyBaseURL):
        (WebCore::DocumentImpl::):
        (WebCore::DocumentImpl::transformSourceDocument):
        (WebCore::DocumentImpl::domTreeVersion):
        (WebCore::DocumentImpl::decoder):
        * dom/NodeListImpl.cpp:
        (DOM::NodeListImpl::NodeListImpl):
        (DOM::NodeListImpl::~NodeListImpl):
        (DOM::NodeListImpl::recursiveLength):
        (DOM::NodeListImpl::recursiveItem):
        (DOM::NodeListImpl::itemById):
        * dom/NodeListImpl.h:
        * dom/dom2_eventsimpl.cpp:
        (WebCore::RegisteredEventListener::RegisteredEventListener):
        * dom/dom2_eventsimpl.h:
        (WebCore::operator!=):
        * dom/dom2_traversalimpl.cpp:
        (DOM::TraversalImpl::TraversalImpl):
        (DOM::NodeIteratorImpl::NodeIteratorImpl):
        (DOM::TreeWalkerImpl::TreeWalkerImpl):
        * dom/dom2_traversalimpl.h:
        (WebCore::TraversalImpl::root):
        (WebCore::TraversalImpl::filter):
        (WebCore::NodeIteratorImpl::referenceNode):
        (WebCore::NodeIteratorImpl::setPointerBeforeReferenceNode):
        (WebCore::NodeIteratorImpl::setDetached):
        (WebCore::NodeIteratorImpl::document):
        (WebCore::TreeWalkerImpl::currentNode):
        * dom/dom_position.cpp:
        (WebCore::Position::computedStyle):
        * dom/dom_position.h:
        * dom/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::insertErrorMessageBlock):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::createFontElement):
        (WebCore::createStyleSpanElement):
        (WebCore::ApplyStyleCommand::ApplyStyleCommand):
        (WebCore::ApplyStyleCommand::updateStartEnd):
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::extractTextDecorationStyle):
        (WebCore::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
        (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        (WebCore::ApplyStyleCommand::computedFontSize):
        * editing/ApplyStyleCommand.h:
        (WebCore::ApplyStyleCommand::style):
        * editing/EditCommand.cpp:
        (WebCore::EditCommandPtr::setTypingStyle):
        (WebCore::EditCommand::setTypingStyle):
        (WebCore::EditCommand::styleAtPosition):
        * editing/EditCommand.h:
        (WebCore::EditCommand::document):
        (WebCore::EditCommand::typingStyle):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::InsertLineBreakCommand):
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::prepareForTextInsertion):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::computeAndStoreNodeDesiredStyle):
        (WebCore::NodeDesiredStyle::NodeDesiredStyle):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:
        (WebCore::NodeDesiredStyle::node):
        (WebCore::NodeDesiredStyle::style):
        (WebCore::ReplacementFragment::root):
        * editing/WrapContentsInDummySpanCommand.cpp:
        (WebCore::WrapContentsInDummySpanCommand::doApply):
        * editing/htmlediting.cpp:
        (WebCore::createDefaultParagraphElement):
        (WebCore::createBreakElement):
        * editing/markup.cpp:
        (WebCore::createFragmentFromMarkup):
        (WebCore::createParagraphContentsFromString):
        * editing/visible_text.cpp:
        (khtml::TextIterator::rangeFromLocationAndLength):
        * editing/visible_text.h:
        (WebCore::isCollapsibleWhitespace):
        (WebCore::WordAwareIterator::range):
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::cssPropertyGetter):
        (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMDocumentProtoFunc::callAsFunction):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::HTMLSelectCollection::put):
        (KJS::OptionConstructorImp::construct):
        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::createContextualFragment):
        (WebCore::HTMLElementImpl::setInnerHTML):
        (WebCore::HTMLElementImpl::setOuterHTML):
        (WebCore::HTMLElementImpl::setOuterText):
        * khtml/html/HTMLElementImpl.h:
        * khtml/html/HTMLNameCollectionImpl.cpp:
        (WebCore::HTMLNameCollectionImpl::HTMLNameCollectionImpl):
        (WebCore::HTMLNameCollectionImpl::traverseNextItem):
        * khtml/html/HTMLNameCollectionImpl.h:
        * khtml/html/html_documentimpl.cpp:
        (WebCore::HTMLDocumentImpl::createElement):
        * khtml/html/html_documentimpl.h:
        (WebCore::HTMLDocumentImpl::collectionInfo):
        * khtml/html/htmlfactory.cpp:
        (DOM::htmlConstructor):
        (DOM::headConstructor):
        (DOM::bodyConstructor):
        (DOM::baseConstructor):
        (DOM::linkConstructor):
        (DOM::metaConstructor):
        (DOM::styleConstructor):
        (DOM::titleConstructor):
        (DOM::frameConstructor):
        (DOM::framesetConstructor):
        (DOM::iframeConstructor):
        (DOM::formConstructor):
        (DOM::buttonConstructor):
        (DOM::inputConstructor):
        (DOM::isindexConstructor):
        (DOM::fieldsetConstructor):
        (DOM::labelConstructor):
        (DOM::legendConstructor):
        (DOM::optgroupConstructor):
        (DOM::optionConstructor):
        (DOM::selectConstructor):
        (DOM::textareaConstructor):
        (DOM::dlConstructor):
        (DOM::ulConstructor):
        (DOM::olConstructor):
        (DOM::dirConstructor):
        (DOM::menuConstructor):
        (DOM::liConstructor):
        (DOM::blockquoteConstructor):
        (DOM::divConstructor):
        (DOM::headingConstructor):
        (DOM::hrConstructor):
        (DOM::paragraphConstructor):
        (DOM::preConstructor):
        (DOM::basefontConstructor):
        (DOM::fontConstructor):
        (DOM::modConstructor):
        (DOM::anchorConstructor):
        (DOM::imageConstructor):
        (DOM::mapConstructor):
        (DOM::areaConstructor):
        (DOM::canvasConstructor):
        (DOM::appletConstructor):
        (DOM::embedConstructor):
        (DOM::objectConstructor):
        (DOM::paramConstructor):
        (DOM::scriptConstructor):
        (DOM::tableConstructor):
        (DOM::tableCaptionConstructor):
        (DOM::tableColConstructor):
        (DOM::tableRowConstructor):
        (DOM::tableCellConstructor):
        (DOM::tableSectionConstructor):
        (DOM::brConstructor):
        (DOM::quoteConstructor):
        (DOM::marqueeConstructor):
        (DOM::HTMLElementFactory::createHTMLElement):
        * khtml/html/htmlfactory.h:
        * khtml/html/htmlparser.cpp:
        (HTMLParser::parseToken):
        (HTMLParser::textCreateErrorCheck):
        (HTMLParser::commentCreateErrorCheck):
        (HTMLParser::headCreateErrorCheck):
        (HTMLParser::bodyCreateErrorCheck):
        (HTMLParser::framesetCreateErrorCheck):
        (HTMLParser::iframeCreateErrorCheck):
        (HTMLParser::formCreateErrorCheck):
        (HTMLParser::isindexCreateErrorCheck):
        (HTMLParser::selectCreateErrorCheck):
        (HTMLParser::ddCreateErrorCheck):
        (HTMLParser::dtCreateErrorCheck):
        (HTMLParser::nestedCreateErrorCheck):
        (HTMLParser::nestedStyleCreateErrorCheck):
        (HTMLParser::tableCellCreateErrorCheck):
        (HTMLParser::tableSectionCreateErrorCheck):
        (HTMLParser::noembedCreateErrorCheck):
        (HTMLParser::noframesCreateErrorCheck):
        (HTMLParser::noscriptCreateErrorCheck):
        (HTMLParser::mapCreateErrorCheck):
        (HTMLParser::getNode):
        * khtml/html/htmlparser.h:
        * khtml/html/htmltokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag):
        (WebCore::HTMLTokenizer::processToken):
        * khtml/html/htmltokenizer.h:
        * ksvg2/misc/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::createSVGEventListener):
        * ksvg2/misc/SVGDocumentExtensions.h:
        * ksvg2/svg/SVGDOMImplementationImpl.cpp:
        (SVGDOMImplementationImpl::createDocumentType):
        (SVGDOMImplementationImpl::createDocument):
        (SVGDOMImplementationImpl::createCSSStyleSheet):
        * ksvg2/svg/SVGDOMImplementationImpl.h:
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (WebCore::SVGDocumentImpl::createElement):
        (WebCore::SVGDocumentImpl::dispatchZoomEvent):
        (WebCore::SVGDocumentImpl::dispatchKeyEvent):
        (WebCore::SVGDocumentImpl::dispatchUIEvent):
        (WebCore::SVGDocumentImpl::dispatchMouseEvent):
        * ksvg2/svg/SVGDocumentImpl.h:
        * ksvg2/svg/SVGElementImpl.cpp:
        (WebCore::SVGElementImpl::addSVGEventListener):
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        (WebCore::SVGSVGElementImpl::addSVGWindowEventListner):
        * page/Frame.cpp:
        (WebCore::Frame::view):
        (WebCore::Frame::begin):
        (WebCore::Frame::computeAndSetTypingStyle):
        (WebCore::Frame::selectionHasStyle):
        (WebCore::Frame::selectionStartHasStyle):
        (WebCore::Frame::selectionStartStylePropertyValue):
        (WebCore::Frame::selectionComputedStyle):
        (WebCore::Frame::forceLayout):
        (WebCore::Frame::sendResizeEvent):
        (WebCore::Frame::sendScrollEvent):
        (WebCore::Frame::clearTimers):
        (WebCore::Frame::styleForSelectionStart):
        * page/FramePrivate.h:
        * page/FrameTree.h:
        (WebCore::FrameTree::name):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Changed by Darin on my machine.
justing [Fri, 17 Feb 2006 00:32:02 +0000 (00:32 +0000)]
    Changed by Darin on my machine.

        * coding/coding-style.html: Re-merged in changes Darin made to the guidelines
        a few days back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Fri, 17 Feb 2006 00:28:33 +0000 (00:28 +0000)]
    Reviewed by Darin.

        Test:
        * manual-tests/mail-attachments.html: Added.
        Automated test not currently possible because widgets do not actually draw when not in a window.
        Geoff and Justin are fixing that and will add this test.

        * rendering/render_frames.cpp:
        (WebCore::RenderPartObject::updateWidget):
        Fix unique param check when processing object tag attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdding -Wno-deprecated-declarations to more files that include ObjC headers.
thatcher [Thu, 16 Feb 2006 23:37:25 +0000 (23:37 +0000)]
Adding -Wno-deprecated-declarations to more files that include ObjC headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix build failure.
thatcher [Thu, 16 Feb 2006 23:03:32 +0000 (23:03 +0000)]
Fix build failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Added -Wno-deprecated-declarations to all the ObjC binding files to prevent...
thatcher [Thu, 16 Feb 2006 23:01:38 +0000 (23:01 +0000)]
    Added -Wno-deprecated-declarations to all the ObjC binding files to prevent deprecation
        warnings. Using <rdar://problem/4448350> to track this.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/objc/objc_jsobject.h: Removed empty file.
        * bindings/objc/objc_jsobject.mm: Removed empty file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
adele [Thu, 16 Feb 2006 22:57:36 +0000 (22:57 +0000)]
    Reviewed by Darin.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7113
        Typing in editable overflow:hidden div doesn't scroll

        * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge ensureSelectionVisible]):
          Changed scrollRectToVisible call so that it will align to the edge instead of trying to center the selection.
          Centering looks funny when it happens after typing, deleting, moving the cursor, etc.
        * rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
          Use scrollWidth() and scrollHeight() functions instead of m_scrollWidth and m_scrollHeight.
          These functions will cause the correct scroll dimensions to be calculated for overflow:hidden layers.
          Also subtracted scrollbar width and height when calculating the layer bounds. This was causing scroll problems in overflow:scroll.
          I also did some cleanup to use xPos() and yPos() instead of m_x and m_y, and to use scrollYOffset() instead of m_scrollY.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Thu, 16 Feb 2006 22:47:55 +0000 (22:47 +0000)]
LayoutTests:

        Updating results for fix:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6812
        Missing focus ring on new text fields

        * fast/forms/input-appearance-focus-expected.checksum:
        * fast/forms/input-appearance-focus-expected.png:

WebCore:

        Reviewed by Darin.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6812
        Missing focus ring on new text fields

        Tests:
        * fast/forms/input-appearance-focus.html: Updated.

        * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline):
         call supportsFocusRing instead of checking the appearance.
        * rendering/render_theme.cpp: (khtml::RenderTheme::supportsFocusRing): Added.
         Checks appearance.  Theme will draw focus ring if there's an appearance, but not for the new text fields.
        * rendering/render_theme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded a file and function to a change log entry.
darin [Thu, 16 Feb 2006 19:35:28 +0000 (19:35 +0000)]
Added a file and function to a change log entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
darin [Thu, 16 Feb 2006 19:27:44 +0000 (19:27 +0000)]
    Reviewed by Hyatt.

        - eliminate QFrame and QObject::inherits, fix some strange stuff
          in RenderCanvas that showed up when I tested that change

        * kwq/KWQFrame.h: Removed.
        * kwq/KWQFrame.mm: Removed.

        * bridge/mac/FrameViewMac.mm: Added.

        * WebCore.xcodeproj/project.pbxproj: Updated for adds and removes.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removes.

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
        * khtml/ecma/kjs_window.cpp:
        (KJS::FrameArray::indexGetter):
        (KJS::FrameArray::nameGetter):
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject doAXTextMarkerForPosition:]):
        * kwq/KWQRenderTreeDebug.cpp:
        (write):
        * page/Frame.cpp:
        (WebCore::isFrameElement):
        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):
        Change QObject::inherits callers to call the "is" functions directly.

        * kwq/KWQObject.h:
        * kwq/KWQObject.cpp: Removed QObject::inherits, QObject::isQFrame,
        and QObject::isQScrollView.

        * kwq/KWQScrollView.h: Inherit from Widget instead of QFrame.
        Remove isQScrollView.
        * kwq/KWQScrollView.mm: Remove isQScrollView.

        * page/FrameView.h:
        * page/FrameView.cpp: Changed underMouse and clickNode to be RefPtr.
        Added m_hasBorder.
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        (WebCore::FrameViewPrivate::~FrameViewPrivate):
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::viewportMousePressEvent):
        (WebCore::FrameView::invalidateClick):
        (WebCore::FrameView::viewportMouseReleaseEvent):
        (WebCore::FrameView::keyPressEvent):
        (WebCore::FrameView::dispatchDragEvent): Use RefPtr for MouseEventImpl.
        (WebCore::FrameView::nodeUnderMouse):
        (WebCore::FrameView::dispatchMouseEvent):
        (WebCore::FrameView::setHasBorder): Added.
        (WebCore::FrameView::hasBorder): Added.
        (WebCore::FrameView::borderWidth): Added.

        * rendering/render_canvas.h: Eliminated unneeded setWidth/Height overrides.
        Eliminated viewportWidth(), viewportHeight(), m_rootWidth, m_rootHeight,
        m_viewportWidth, and m_viewportHeight.
        * rendering/render_canvas.cpp:
        (RenderCanvas::calcHeight): Remove unneeded code to set height when there's
        no view.
        (RenderCanvas::calcWidth): Fix code to set width to visibleWidth(). Removed
        incorrect old width setting, and removed unneeded code to set width when
        there's no view. Also removed incorrect margin-setting code.
        (RenderCanvas::layout): Removed incorrect code to set width and height.
        Instead letting calcWidth and calcHeight do the job.
        (RenderCanvas::repaintViewRectangle): Use new FrameView::hasBorder instead
        of QFrame::frameStyle.
        (RenderCanvas::viewRect): Removed unneeded "root width" feature for a canvas
        without a view.

        * rendering/render_frames.cpp:
        (WebCore::RenderFrame::slotViewCleared): Use new setHasBorder.
        (WebCore::RenderPartObject::slotViewCleared): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-17 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 16 Feb 2006 19:23:21 +0000 (19:23 +0000)]
2006-02-17  Eric Seidel  <eseidel@apple.com>

        Reviewed by justing.

        Close several age-old leaks in xslt code.
        Tests already were catching these.

        * khtml/xsl/xsl_stylesheetimpl.cpp:
        (WebCore::XSLStyleSheetImpl::loadChildSheets):
        (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
tomernic [Thu, 16 Feb 2006 18:33:23 +0000 (18:33 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps)
        with javascript disabled (7015)

        Added a test case, manual-tests/NPN_Invoke.  This is a skeleton of a Netscape
        plugin which uses NPN_Invoke() to call the window.alert() JavaScript function.

        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::windowScriptNPObject):
        Removed the check Darin added to return 0 when JavaScript is disabled.
        This method cannot return 0, because plugins are not guaranteed to check
        for that.
        Removed my old fix for Radar 4428609 (7015) in favor of a better solution.
        Instead of creating a "dummy" JSObject to represent the window script object
        when JavaScript is disabled, we use the new JavaScriptCore bindings API to
        create a "no script" NPObject.  This solution is better because it does not
        cause entry into any JavaScript interpreter code.

        * manual-tests/NPN_Invoke: Added.
        * manual-tests/NPN_Invoke/English.lproj: Added.
        * manual-tests/NPN_Invoke/English.lproj/Localized.r: Added.
        * manual-tests/NPN_Invoke/Info.plist: Added.
        * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added.
        * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Added.
        * manual-tests/NPN_Invoke/main.c: Added.
        * manual-tests/NPN_Invoke/test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
tomernic [Thu, 16 Feb 2006 18:32:31 +0000 (18:32 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
        javascript disabled (7015)

        * bindings/NP_jsobject.cpp:
        (_NPN_CreateNoScriptObject):
        Returns an NPObject which is not bound to a JavaScript object.  This kind of NPObject
        can be given to a plugin as the "window script object" when JavaScript is disabled.
        The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods.
        Because of this, none of the NPN_* functions called by the plugin on this "no script
        object" will cause entry into JavaScript code.
        (_NPN_InvokeDefault):
        Make sure the NPVariant is filled before returning from this function.  This never
        mattered before because we never reached this case, having only created NPObjects of
        the class NPScriptObjectClass.
        (_NPN_Invoke):
        ditto
        (_NPN_Evaluate):
        ditto
        (_NPN_GetProperty):
        ditto

        * bindings/NP_jsobject.h:
        Declared _NPN_CreateNoScriptObject().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixing name to use "ue" since I can't figure out how to include
darin [Thu, 16 Feb 2006 17:53:05 +0000 (17:53 +0000)]
Fixing name to use "ue" since I can't figure out how to include
and umlaut in a change log message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12849 268f45cc-cd09-0410-ab3c-d52691b4dbfc