WebKit-https.git
11 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Sat, 7 Feb 2009 18:40:47 +0000 (18:40 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=6868

        I have not only made TransformationMatrix platform independent
        but I've also added 3D methods, which will be used when I update
        WebKitCSSMatrix to include 3D (see https://bugs.webkit.org/show_bug.cgi?id=23689).
        I am now keeping a full 4x4 matrix in TransformationMatrix. I'm also doing all
        the math as doubles rather than floats. This makes a TransformationMatrix
        go from 24 bytes to 128 bytes, but I don't think this class is used enough to
        make this overhead will be significant.

        The change from floats to doubles has caused some differences in rounding and
        display (sometimes things that displayed as -0.0 now display as 0.0 or vice versa),
        so I've had to change some LayoutTest results in the SVG tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-07 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Sat, 7 Feb 2009 17:53:12 +0000 (17:53 +0000)]
2009-02-07  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix Use toNormalizedRange().

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::clipboard_get_contents_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-07 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Sat, 7 Feb 2009 15:33:19 +0000 (15:33 +0000)]
2009-02-07  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        For the Qt port implement Image::drawPattern via
        BitmapImage::drawPatterns' implementation and implement
        Gradient::fill.

        This partially fixes rendering of generated gradient content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix
aroben@apple.com [Sat, 7 Feb 2009 02:44:56 +0000 (02:44 +0000)]
    Build fix

        Reviewed by Sam Weinig.

        * WebCoreSupport/WebFrameLoaderClient.cpp: Added missing #include.
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Removed
        incorrect .get(), and changed to use the new overload of
        WebHistory::itemForURLString.

        * WebHistory.cpp:
        (WebHistory::itemForURLString): Made this const.
        (WebHistory::itemForURLString): Added an overload that takes a
        WebCore::String and returns the IWebHistoryItem instead of using an
        out parameter.

        * WebHistory.h: Added public overload of itemForURLString.

        * WebView.cpp:
        (WebView::prepareCandidateWindow):
        (WebView::onIMERequestCharPosition):
        (WebView::onIMERequestReconvertString):
        Updated for toRange -> toNormalizedRange rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Sat, 7 Feb 2009 01:28:59 +0000 (01:28 +0000)]
    Reviewed by Justin Garcia.

        DOMSelection.getRangeAt() returns a different range than the selection
        https://bugs.webkit.org/show_bug.cgi?id=23601

        Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range

        Test: fast/dom/Selection/getRangeAt.html

        * WebCore.base.exp:
        * dom/InputElement.cpp:
        (WebCore::InputElement::handleBeforeTextInsertedEvent):
        * editing/DeleteButtonController.cpp:
        (WebCore::enclosingDeletableElement):
        * editing/Editor.cpp:
        (WebCore::Editor::selectedRange):
        (WebCore::Editor::fontForSelection):
        (WebCore::Editor::applyStyleToSelection):
        (WebCore::Editor::applyParagraphStyleToSelection):
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::insertLineBreak):
        (WebCore::Editor::insertParagraphSeparator):
        (WebCore::Editor::ignoreSpelling):
        (WebCore::Editor::isSelectionUngrammatical):
        (WebCore::Editor::guessesForUngrammaticalSelection):
        (WebCore::markMisspellingsOrBadGrammar):
        (WebCore::Editor::rangeForPoint):
        * editing/EditorCommand.cpp:
        (WebCore::expandSelectionToGranularity):
        (WebCore::executeDeleteToMark):
        (WebCore::executeSelectToMark):
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        * editing/Selection.cpp:
        (WebCore::Selection::firstRange):
        (WebCore::Selection::toNormalizedRange):
        * editing/Selection.h:
        * editing/SelectionController.h:
        (WebCore::SelectionController::toNormalizedRange):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/markup.cpp:
        (WebCore::createMarkup):
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::createFromSelection):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::getRangeAt):
        (WebCore::DOMSelection::addRange):
        (WebCore::DOMSelection::deleteFromDocument):
        (WebCore::DOMSelection::containsNode):
        (WebCore::DOMSelection::toString):
        * page/DragController.cpp:
        (WebCore::setSelectionToDragCaret):
        (WebCore::DragController::concludeEditDrag):
        (WebCore::DragController::startDrag):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchMouseEvent):
        * page/Frame.cpp:
        (WebCore::Frame::selectedText):
        (WebCore::Frame::shouldChangeSelection):
        (WebCore::Frame::shouldDeleteSelection):
        (WebCore::Frame::selectionComputedStyle):
        (WebCore::Frame::selectionTextRects):
        (WebCore::Frame::findString):
        (WebCore::Frame::respondToChangedSelection):
        * platform/ContextMenu.cpp:
        (WebCore::selectionContainsPossibleWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Sat, 7 Feb 2009 01:26:54 +0000 (01:26 +0000)]
2009-02-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        <rdar://problem/6563402> - Workaround a case where ::didReceiveData() might be called on a ResourceHandleClient
        before ::didReceiveResponse().

        No layout test, as we don't have a concrete way to reproduce these conditions.  To that effect, I've added an ASSERT
        to catch the conditions before the workaround takes effect in case any WebKit Debug-build developer runs across
        this case and can come up with something more reproducible.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didReceiveData): If the response is null create a dummy response.  This is much
          like the FrameLoader::init() response that is used for initial document creation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 7 Feb 2009 01:16:10 +0000 (01:16 +0000)]
2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/gtk:
ggaren@apple.com [Sat, 7 Feb 2009 01:10:19 +0000 (01:10 +0000)]
WebKit/gtk:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::updateGlobalHistoryRedirectLinks):
        * WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/qt:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
        * WebCoreSupport/FrameLoaderClientQt.h:

WebKit/wx:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::updateGlobalHistoryRedirectLinks):
        * WebKitSupport/FrameLoaderClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sat, 7 Feb 2009 01:05:42 +0000 (01:05 +0000)]
2009-02-06  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=23621

        Do not use m_scrollOffset to check if we are setting the same
        value than we already have.

        m_scrollOffset starts at 0 for ScrollView, so when opening a new
        page and scrolling to 0 (the usual case) the check will fail and
        we won't update the adjustment value, resulting in a possibly
        mispositioned scrollbar. Use the adjustment value directly
        instead, which is what we are updating anyway.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::platformHandleHorizontalAdjustment):
        (WebCore::ScrollView::platformHandleVerticalAdjustment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Sat, 7 Feb 2009 00:42:34 +0000 (00:42 +0000)]
WebCore:

2009-02-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23800
        Header elements are not always preserved during paste

        At paste time, don't merge out of header elements.  At copy time, be sure to include
        headers in the list of special common ancestor blocks, so that copying a paragraph or less
        of content inside a header will include the header element in the copied markup.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::areSameHeaderElements):
        (WebCore::ReplaceSelectionCommand::shouldMerge):
        * editing/markup.cpp:
        (WebCore::isSpecialAncestorBlock):
        (WebCore::createMarkup):

LayoutTests:

2009-02-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23800
        Header elements are not always preserved during paste

        * editing/execCommand/4128080-1-expected.txt: Added.
        * editing/execCommand/4128080-1.html: Added.
        * editing/execCommand/4128080-2-expected.txt: Added.
        * editing/execCommand/4128080-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ggaren@apple.com [Sat, 7 Feb 2009 00:28:29 +0000 (00:28 +0000)]
WebCore:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Part III of <rdar://problem/6552272>.

        Make redirect data available to WebKit. (I tried having WebKit track this
        data for itself, but that went wrong -- it's just too hard to figure
        out the weird corners of the WebCore loader from within another framework.)

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        * loader/DocumentLoader.h: Store a flag indicating whether we created
        a global history entry. If we didn't, then we know that the next redirect
        should not link to us, since we're not in history.

        (WebCore::DocumentLoader::clientRedirectSourceForHistory):
        (WebCore::DocumentLoader::clientRedirectDestinationForHistory):
        (WebCore::DocumentLoader::setClientRedirectSourceForHistory):
        (WebCore::DocumentLoader::serverRedirectSourceForHistory):
        (WebCore::DocumentLoader::serverRedirectDestinationForHistory):
        (WebCore::DocumentLoader::didCreateGlobalHistoryEntry):
        (WebCore::DocumentLoader::setDidCreateGlobalHistoryEntry): Added accessors
        to help WebKit wade through the muck of WebCore history.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryRedirectLinks): Renamed
        this client function to say what it does, instead of when it's called.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::loadWithNavigationAction): In the case of a redirect,
        store a link to the previous history URL in the new DocumentLoader, so
        it can update WebKit with that link when the load commits.

        (WebCore::FrameLoader::updateHistory*): Use our new flags and names,
        described above.

        * loader/FrameLoader.h:
        (WebCore::FrameLoader::documentLoader):
        (WebCore::FrameLoader::policyDocumentLoader):
        (WebCore::FrameLoader::provisionalDocumentLoader):
        (WebCore::FrameLoader::state): Inlined a few trivial functions because
        performance mistakes give me the itches.

        * loader/FrameLoaderClient.h: Renamed this client function to say what
        it does, instead of when it's called.

WebKit/mac:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Part III of <rdar://problem/6552272>.

        Refactored to use the redirect data WebCore makes available, instead of
        tracking loading state in WebKit.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate dealloc]):
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
        (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]):
        * History/WebHistoryInternal.h:
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory):
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):

WebKit/win:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Part III of <rdar://problem/6552272>.

        Refactored to use the redirect data WebCore makes available, instead of
        tracking loading state in WebKit.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::updateGlobalHistory):
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebHistory.cpp:
        (WebHistory::visitedURL):
        * WebHistory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sat, 7 Feb 2009 00:10:01 +0000 (00:10 +0000)]
2009-02-06  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        Reported by Daniel Macks.

        https://bugs.webkit.org/show_bug.cgi?id=20412

        Use positive numbers for the target info IDs, gtk_target_list_add
        casts them to 'guint'. Also just start them from 0, since the
        values are not relevant or magic in any way, they are just used as
        tokens for the user of the API.

        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Sat, 7 Feb 2009 00:04:48 +0000 (00:04 +0000)]
    Reviewed by Justin Garcia.

        Minor refactoring and cleanup to Selection code
        https://bugs.webkit.org/show_bug.cgi?id=23774

        No functional changes, thus no tests.

        * editing/Editor.cpp:
        (WebCore::Editor::applyStyle):
        (WebCore::Editor::applyParagraphStyle):
        * editing/Selection.cpp:
        (WebCore::Selection::Selection):
        (WebCore::Selection::setBaseAndExtentToDeepEquivalents):
        (WebCore::Selection::setStartAndEndFromBaseAndExtentRespectingGranularity):
        (WebCore::Selection::updateSelectionType):
        (WebCore::Selection::validate):
        (WebCore::Selection::setWithoutValidation):
        (WebCore::Selection::adjustSelectionToAvoidCrossingEditingBoundaries):
        * editing/Selection.h:
        (WebCore::Selection::):
        (WebCore::Selection::selectionType):
        (WebCore::Selection::extent):
        (WebCore::Selection::isNone):
        (WebCore::Selection::isCaret):
        (WebCore::Selection::isRange):
        (WebCore::Selection::isCaretOrRange):
        * editing/SelectionController.h:
        (WebCore::SelectionController::selectionType):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * page/Frame.cpp:
        (WebCore::Frame::revealSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 6 Feb 2009 23:39:09 +0000 (23:39 +0000)]
2009-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23801
        Add custom V8 bindings for SVG.

        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGLengthCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGMatrixCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 David Levin <levin@chromium.org>
darin@chromium.org [Fri, 6 Feb 2009 23:29:52 +0000 (23:29 +0000)]
2009-02-06  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        Bug 23792: unused param is used in RenderLayer.cp but not #include'd
        <https://bugs.webkit.org/show_bug.cgi?id=23792>

        Add include file for UnusedParam which is used in this file.

        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 David Levin <levin@chromium.org>
eric@webkit.org [Fri, 6 Feb 2009 23:25:18 +0000 (23:25 +0000)]
2009-02-06  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        <https://bugs.webkit.org/show_bug.cgi?id=23741>

        Bug 23798: KURLGoogle needs support for protocolInHTTPFamily
        <https://bugs.webkit.org/show_bug.cgi?id=23798>

        Add protocolInHTTPFamily() to the KURLGoogle implementation.
        This is another chromium build fix to mirror r40553.

        While in this file, I did some style fixes and consistency fixes:
        + fixed many_occurences_of_underscoring_naming
        + usages of NULL
        + comparisons to 0
        + changed the copyright remove an extraneous , and capitalize the (C)
          which was suggested for other files that I've submitted.

        No observable change in behavior, so no test.

        * platform/KURL.h:
        (WebCore::KURL::protocolInHTTPFamily):
        * platform/KURLGoogle.cpp:
        (WebCore::KURLCharsetConverter::ConvertFromUTF16):
        (WebCore::lowerCaseEqualsASCII):
        (WebCore::KURLGooglePrivate::KURLGooglePrivate):
        (WebCore::KURLGooglePrivate::setUtf8):
        (WebCore::KURLGooglePrivate::setAscii):
        (WebCore::KURLGooglePrivate::init):
        (WebCore::KURLGooglePrivate::initProtocolInHTTPFamily):
        (WebCore::KURLGooglePrivate::copyTo):
        (WebCore::KURLGooglePrivate::replaceComponents):
        (WebCore::KURL::KURL):
        (WebCore::KURL::createCFURL):
        (WebCore::KURL::isEmpty):
        (WebCore::KURL::protocolInHTTPFamily):
        (WebCore::KURL::query):
        (WebCore::decodeURLEscapeSequences):
        (WebCore::KURL::protocolIs):
        (WebCore::encodeWithURLEscapeSequences):
        (WebCore::KURL::invalidate):
        (WebCore::equalIgnoringRef):
        * platform/KURLGooglePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 23741: StyleRareNonInheritedData::operator==() should not compare Content...
ddkilzer@apple.com [Fri, 6 Feb 2009 22:48:16 +0000 (22:48 +0000)]
    Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer

        <https://bugs.webkit.org/show_bug.cgi?id=23741>

        Reviewed by Darin Adler.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::contentDataEquivalent): Moved method to
        WebCore::StyleRareNonInheritedData class.
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::contentDataEquivalent): Replaced declaration
        with inline method that calls contentDataEquivalent() on
        WebCore::StyleRareNonInheritedData instead.
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::operator==): This is the bug fix!
        Replaced pointer comparison of ContentData objects with call to
        StyleRareNonInheritedData::contentDataEquivalent().
        (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added.
        * rendering/style/StyleRareNonInheritedData.h:
        (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added
        declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 6 Feb 2009 22:42:13 +0000 (22:42 +0000)]
2009-02-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6562220>
        CrashTracer: [USER] 21 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostProxy::port

        Make the handling of crashes in the plug-in host more robust.

        * Plugins/Hosted/NetscapePluginHostProxy.h:
        Add m_portSet.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        Initialize m_portSet.

        (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
        Free m_portSet.

        (WebKit::NetscapePluginHostProxy::processRequests):
        Listen for messages on the port set. If we get a message to the port death notification port,
        then call pluginHostDied. Otherwise, process the message.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::cleanup):
        Factor code that should be shared between destroy() and pluginHostDied() into cleanup.

        (WebKit::NetscapePluginInstanceProxy::destroy):
        Call cleanup().

        (WebKit::NetscapePluginInstanceProxy::pluginHostDied):
        Call cleanup().

        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
        Call NetscapePluginHostProxy::processRequests.

        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::invalidate):
        Add a null check for the host proxy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 22:17:44 +0000 (22:17 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Factor code that checks whether the object is rooted in
        repaint() and repaintRectangle() into a common isRooted()
        method.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaint):
        (WebCore::RenderObject::repaintRectangle):
        (WebCore::RenderObject::isRooted):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 22:16:19 +0000 (22:16 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Expose an isRootLayer() method on RenderLayer that works whether the
        layer is rooted or not, and use that in a few places in the
        accelerated compositing code.

        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::isRootLayer):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintingGoesToWindow):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
        (WebCore::RenderLayerCompositor::requiresCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 22:13:17 +0000 (22:13 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Make RenderStyle::transitionForProperty() const.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::transitionForProperty):
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 6 Feb 2009 21:44:27 +0000 (21:44 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/6552338> FontCache::releaseFontData() called on a small caps font that is not in the cache

        Most platforms do not retrieve the small caps font from the FontCache,
        but cross-platform code in ~SimpleFontData() assumes the the small caps
        font data did come from the cache and therefore calls releaseFontData()
        on it.

        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::~SimpleFontData): Reordered to call
        platformDestroy() before releasing the small caps font and pruning the
        glyph page tree. This allows platformDestroy() to reset
        m_smallCapsFontData to 0 if it was not obtained from the cache.
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformDestroy): Set m_smallCapsFontData to
        0 after deleting it.
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformDestroy): Ditto.
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformDestroy): Ditto.
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::platformCommonDestroy): Ditto.
        * platform/graphics/wx/SimpleFontDataWx.cpp:
        (WebCore::SimpleFontData::platformDestroy): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 21:30:37 +0000 (21:30 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Fix build when ACCELERATED_COMPOSITING is turned on.

        Remove font smoothing changes that will be committed
        separately.

        * platform/graphics/mac/WebLayer.mm:
        (WebCore::if):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - try to fix the Tiger build
mitz@apple.com [Fri, 6 Feb 2009 21:09:05 +0000 (21:09 +0000)]
    - try to fix the Tiger build

        * Misc/WebNSArrayExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Fri, 6 Feb 2009 20:49:23 +0000 (20:49 +0000)]
    Reviewed by Anders Carlsson.

        - fix an assertion failure in Vector::at() beneath
          WebHistoryItem::dictionaryRepresentation.

        * WebHistoryItem.cpp:
        (WebHistoryItem::dictionaryRepresentation): Give the numbers vector initial
        size. Also reduced the inline capacity of the vector used for weekly visit
        counts to 5, which is the expected maximum size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 6 Feb 2009 20:33:33 +0000 (20:33 +0000)]
2009-02-06  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 6 Feb 2009 20:16:12 +0000 (20:16 +0000)]
2009-02-06  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23790
        Custom -> JSCCustom in SVGPointList.idl

        * svg/SVGPointList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 6 Feb 2009 19:22:31 +0000 (19:22 +0000)]
2009-02-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6563650>
        Add Netscape plug-in API to tell the browser not to load streams (some plug-ins handle network loading manually)

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView loadStream]):
        (-[WebNetscapePluginView pluginView:receivedData:]):
        (-[WebNetscapePluginView _shouldCancelSrcStream]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Anantanarayanan Iyengar <ananta@chromium.org>
dglazkov@chromium.org [Fri, 6 Feb 2009 18:08:44 +0000 (18:08 +0000)]
2009-02-06  Anantanarayanan Iyengar  <ananta@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23309
        Fix whitespace indent errors. The rest of the original patch has already
        landed.

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::clear):
        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::clear):
        * platform/graphics/qt/ImageSourceQt.cpp:
        (WebCore::ImageSource::clear):
        * platform/graphics/wx/ImageSourceWx.cpp:
        (WebCore::ImageSource::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 6 Feb 2009 17:37:42 +0000 (17:37 +0000)]
2009-02-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Simon Hausmann.

        Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
        the context transparent.

        [QT] clearRect fill's a given rect with white
        https://bugs.webkit.org/show_bug.cgi?id=23728

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clearRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix. Re-enable missing file in Release_Cairo target.
bfulgham@webkit.org [Fri, 6 Feb 2009 17:32:48 +0000 (17:32 +0000)]
Build fix.  Re-enable missing file in Release_Cairo target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 17:05:07 +0000 (17:05 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=23781

        When the document is attached and detached, and when it becomes active/inactive
        (e.g. coming out or going into the page cache) we need to call
        RenderView::didMoveOnscreen()/willMoveOffscreen() to hook and unhook the composited
        layers.

        Also, if Document::recalcStyle() does not do a layout, it needs to
        update the compositing layers.

        * dom/Document.cpp:
        (WebCore::Document::updateRendering):
        (WebCore::Document::updateLayout):
        (WebCore::Document::attach):
        (WebCore::Document::detach):
        (WebCore::Document::documentWillBecomeInactive):
        (WebCore::Document::documentDidBecomeActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Kavindra Palaraja <kavindra.palaraja@nokia.com>
hausmann@webkit.org [Fri, 6 Feb 2009 13:50:52 +0000 (13:50 +0000)]
2009-02-06  Kavindra Palaraja  <kavindra.palaraja@nokia.com>

        Reviewed by Simon Hausmann.

        Doc - made 2 functions internal as they are not part of the API anymore (and this fixes 2 qdoc warnings)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Fri, 6 Feb 2009 12:35:49 +0000 (12:35 +0000)]
WebCore:

    2009-02-06  Simon Hausmann  <simon.hausmann@nokia.com>

            Reviewed by Tor Arne Vestbø.

            Added support for different ownership models for wrapped QObjects in
            the JavaScript environment.

WebKit/qt:

    2009-02-06  Simon Hausmann  <simon.hausmann@nokia.com>

            Reviewed by Tor Arne Vestbø.

            Added an overload of QWebFrame::addToJavaScriptWindowObject that takes a QScriptEngine::ValueOwnership parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Xan Lopez <xan@gnome.org>
ap@webkit.org [Fri, 6 Feb 2009 10:10:05 +0000 (10:10 +0000)]
2009-02-06  Xan Lopez  <xan@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23769

        Do not use empty ResourceError errors.

        Rather create bogus but non-null errors, since some codepaths
        expect these. For example, see DocumentLoader::mainReceivedError.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::cancelledError):
        (WebKit::FrameLoaderClient::blockedError):
        (WebKit::FrameLoaderClient::cannotShowURLError):
        (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
        (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
        (WebKit::FrameLoaderClient::fileDoesNotExistError):
        (WebKit::FrameLoaderClient::pluginWillHandleLoadError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Xan Lopez <xan@gnome.org>
ap@webkit.org [Fri, 6 Feb 2009 09:21:56 +0000 (09:21 +0000)]
2009-02-06  Xan Lopez  <xan@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23761

        Use two-arg KURL ctor.

        We are using the one-arg ctor currently, but:

        - It assumes the strings are already encoded, which is not
        necesarily the case for us.

        - The single-argument KURL ctors expect their input to already be
        the output of a previous KURL::parse call, so for the general
        case (ie, random user input) we need to use the two-arg ctor
        anyway.

        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Aaron Boodman <aa@chromium.org>
zecke@webkit.org [Fri, 6 Feb 2009 08:56:55 +0000 (08:56 +0000)]
2009-02-06  Aaron Boodman  <aa@chromium.org>

        Reviewed by Holger Freyther.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::documentElementAvailable):)
        Fix compile error in Qt build introduced by the below change (r40694).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-06 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 6 Feb 2009 08:16:57 +0000 (08:16 +0000)]
2009-02-06  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Dan Bernstein.

        - fix obvious problem in previous commit (|| used instead of &&)

        * WebHistoryItem.cpp:
        (WebHistoryItem::initFromDictionaryRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mjs@apple.com [Fri, 6 Feb 2009 08:11:16 +0000 (08:11 +0000)]
WebCore:

2009-02-05  Maciej Stachowiak  <mjs@apple.com> and Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein and Geoff Garen.

        - WebCore code to track per-day and per-week visit counts in history

        The basic idea is as follows: we track daily visits for up to 13
        days, and weekly visits for up to 5 weeks past the end of the
        current daily visits. As soon as the number of daily counts goes
        over 13, we squish them down into weeks, and then prune the excess weeks.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem): Remove bogus whitespace.
        (WebCore::timeToDay): Helper function: convert time to days from the epoch.
        (WebCore::HistoryItem::padDailyCountsForNewVisit): Insert 0 counts if
        a site is visited after a span of days.
        (WebCore::HistoryItem::collapseDailyVisitsToWeekly): Core day/week upgrade
        algorithm as described above.
        (WebCore::HistoryItem::recordVisitAtTime): Use above helpers to record all
        info about a visit to this history item.
        (WebCore::HistoryItem::setLastVisitedTime): Updated.
        (WebCore::HistoryItem::visited): Updated.
        (WebCore::HistoryItem::recordInitialVisit): New function to
        handle recording data about the very first visit, replacing the
        prior practice of explicitly setting visit count to 1.
        (WebCore::HistoryItem::adoptVisitCounts): Take ownership of
        daily and weekly visit count vectors.
        (WebCore::HistoryItem::mergeAutoCompleteHints): Added a comment
        noting that this function doesn't work properly now (though
        this shouldn't matter much in practice.)
        * history/HistoryItem.h:
        (WebCore::HistoryItem::dailyVisitCounts): Accessor for daily counts.
        (WebCore::HistoryItem::weeklyVisitCounts): Ditto for weekly counts.
        * WebCore.base.exp: Add new symbols and sort.

WebKit/win:

2009-02-05  Maciej Stachowiak  <mjs@apple.com> and Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein and Geoff Garen..

        - WebKit code to track per-day and per-week visit counts in history

        For now this data is only exposed via SPI for performance reasons.

        * Interfaces/IWebHistoryItemPrivate.idl: Added new interface.
        * WebHistory.cpp:
        (WebHistory::visitedURL): Use new recordInitialVisit method.
        * WebHistoryItem.cpp:
        (WebHistoryItem::initFromDictionaryRepresentation): Add parsing support
        for new data.
        (WebHistoryItem::dictionaryRepresentation): Add saving support for
        new data.
        (WebHistoryItem::getDailyVisitCounts): SPI accessor.
        (WebHistoryItem::getWeeklyVisitCounts): SPI accessor.
        (WebHistoryItem::recordInitialVisit): Tell WebCore to record an initial visit.
        * WebHistoryItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>
mjs@apple.com [Fri, 6 Feb 2009 08:04:25 +0000 (08:04 +0000)]
2009-02-05  Maciej Stachowiak  <mjs@apple.com> and Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein and Geoff Garen.

        - WebKit code to track per-day and per-week visit counts in history

        For now this data is only exposed via SPI for performance reasons.

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initFromDictionaryRepresentation:]): Add parsing support
        for new data.
        (-[WebHistoryItem _recordInitialVisit]): Tell WebCore to record an initial visit.
        (-[WebHistoryItem dictionaryRepresentation]): Add saving support for new data.
        (-[WebHistoryItem _getDailyVisitCounts:]): SPI accessor.
        (-[WebHistoryItem _getWeeklyVisitCounts:]): SPI accessor.
        * History/WebHistoryItemInternal.h: Declare new methods.
        * History/WebHistoryItemPrivate.h: Ditto.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate visitedURL:withTitle:]): For the initial visit, use
        the new _recordInitialVisit method instead of setting visit count to 1.

        * Misc/WebNSArrayExtras.h:
        * Misc/WebNSArrayExtras.m:
        (-[NSArray _webkit_numberAtIndex:]): Helper to retrieve an NSNumber or nil from an NSArray
        (-[NSArray _webkit_stringAtIndex:]): Helper to retrieve an NSString of nil from an NSArray

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Fri, 6 Feb 2009 07:53:20 +0000 (07:53 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6438271> Improve backspace handling of accented characters

        Test: platform/mac/editing/deleting/backward-delete.html

        This change makes WebKit behave like AppKit on the Mac. Other platforms are not affected,
        because the current behavior matches their standards (tested on Windows, assumed elsewhere).

        * dom/Position.cpp:
        (WebCore::Position::previous):
        (WebCore::Position::next):
        (WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion):
        * dom/Position.h:
        Added a new option for previous(), used to move to a next position for backward deletion.
        Renamed EUsingComposedCharacters to PositionMoveType.

        * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
        Use previous(BackwardDeletion) to find a proper range to delete. Also, simplified a check
        surrounding this code a little.

        * editing/htmlediting.cpp:
        (WebCore::nextVisuallyDistinctCandidate):
        (WebCore::previousVisuallyDistinctCandidate):
        Adjusted for renamed enum values.

        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderText.h:
        Added previousOffsetForBackwardDeletion().

        * rendering/RenderText.cpp: (WebCore::RenderText::previousOffsetForBackwardDeletion):
        On PLATFORM(MAC), use an algorithm that matches the one AppKit has for backward deletion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix a crash in RenderWidget::destroy when navigating away from a page with...
aroben@apple.com [Fri, 6 Feb 2009 06:06:31 +0000 (06:06 +0000)]
    Fix a crash in RenderWidget::destroy when navigating away from a page with an <iframe>

        This was a regression caused by r40679

        Reviewed by Dave Hyatt.

        Tested by many many tests.

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy): Only deref the RenderWidget after we
        finish accessing its members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 05:40:42 +0000 (05:40 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Fix the #include file order, per review comments.

        * DumpRenderTree/mac/PixelDumpSupportMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 05:37:07 +0000 (05:37 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23362

        If the WebHTMLView uses accelerated compositing, we need for force
        the on-screen capture path and also force animations to start with -display
        since the DRT window has autodisplay disabled.

        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (createBitmapContextFromWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 05:09:41 +0000 (05:09 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        getAnimatedStyleForRenderer() should not create a new
        CompositeAnimation if the object isn't already animating, and
        it should just fall back to returning renderer->style().

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix
aroben@apple.com [Fri, 6 Feb 2009 05:03:40 +0000 (05:03 +0000)]
    Build fix

        Rubberstamped by Sam Weinig.

        * wtf/TypeTraits.h: Include Platform.h, since this header uses macros
        defined there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 04:30:51 +0000 (04:30 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Fix build when ACCELERATED_COMPOSITING is turned on.

        Give RenderLayerBacking some love after the great
        RenderBoxModelObject split.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 04:22:06 +0000 (04:22 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Fix build when ACCELERATED_COMPOSITING is turned on.

        writeIndent() needs to be static to avoid warnings on some OSes,
        and remove unused CAToTransform3D() method.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::writeIndent):
        * platform/graphics/mac/GraphicsLayerCA.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 04:18:44 +0000 (04:18 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Add some methods to the TransformOperation classes that are required
        by GraphicsLayer when ACCELERATED_COMPOSITING is turned on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 04:12:27 +0000 (04:12 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Minor clenaup: fix brace style in CompositeAnimationPrivate::updateTransitions(),
        and correct a usage of UNUSED_PARAM().

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimationPrivate::updateTransitions):
        * page/animation/ImplicitAnimation.cpp:
        (WebCore::ImplicitAnimation::startAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 04:09:31 +0000 (04:09 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Fix build when ACCELERATED_COMPOSITING is turned on.

        animationOfPropertyIsAccelerated() needs to be public because
        it is called from AnimationController.

        * page/animation/AnimationBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 04:07:38 +0000 (04:07 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Fix mis-typed enum value which is hidden inside #ifdefs so didn't break
        the build.

        * page/FrameView.cpp:
        (WebCore::FrameView::updateCompositingLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Fri, 6 Feb 2009 00:26:48 +0000 (00:26 +0000)]
2009-02-05  Brent Fulgham <bfulgham@webkit.org>
Reviewed by Sam Weinig.
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@40697 268f45cc-cd09-0410...
zimmermann@webkit.org [Fri, 6 Feb 2009 00:17:40 +0000 (00:17 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 6 Feb 2009 00:15:59 +0000 (00:15 +0000)]
2009-02-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix missing checked toRenderBlock casts.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clearFloats):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::availableHeightUsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 6 Feb 2009 00:11:34 +0000 (00:11 +0000)]
2009-02-05  Sam Weinig  <sam@webkit.org>

        Patch from Darin Adler.
        Reviewed by Sam Weinig.

        Fix case where we were casting to RenderView.

        No test case possible.

        * editing/mac/SelectionControllerMac.mm:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Thu, 5 Feb 2009 23:59:47 +0000 (23:59 +0000)]
WebCore:

2009-02-05  Aaron Boodman  <aa@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23708
        Adds documentElementAvailable() callback to FrameLoaderClient.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::startElementNs):
        Add call to dispatchDocumentElementAvailable()
        * dom/XMLTokenizerQt.cpp:
        (WebCore::XMLTokenizer::parseStartElement):
        Ditto.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::insertNode):
        Ditto.
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::documentElementAvailable):
        Stub out documentElementAvailable().
        * loader/FrameLoader.cpp:
        documentElementAvailable() callback plumbing.
        * loader/FrameLoader.h:
        Ditto.
        * loader/FrameLoaderClient.h:
        Add new documentElementAvailable() callback.

WebKit/gtk:

2009-02-05  Aaron Boodman <aa@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23708
        Adds documentElementAvailable() callback to FrameLoaderClient.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::documentElementAvailable):
        Stub out documentElementAvailable()
        * WebCoreSupport/FrameLoaderClientGtk.h:
        Ditto.

WebKit/mac:

2009-02-05  Aaron Boodman  <aa@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23708
        Adds documentElementAvailable() callback to FrameLoaderClient.

        * WebCoreSupport/WebFrameLoaderClient.h:
        Stub out documentElementAvailable().
        * WebCoreSupport/WebFrameLoaderClient.mm:
        Ditto.

WebKit/qt:

2009-02-05  Aaron Boodman  <aa@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23708
        Adds documentElementAvailable() callback to FrameLoaderClient.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClient::documentElementAvailable):
        Stub out documentElementAvailable().
        * WebCoreSupport/FrameLoaderClientQt.h:
        Ditto.

WebKit/win:

2009-02-05  Aaron Boodman  <aa@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23708
        Adds documentElementAvailable() callback to FrameLoaderClient.

        * WebFrame.cpp:
        (WebFrame::documentElementAvailable):
        Stub out documentElementAvailable()
        * WebFrame.h:
        Ditto.

WebKit/wx:

2009-02-05  Aaron Boodman  <aa@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23708
        Adds documentElementAvailable() callback to FrameLoaderClient.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::documentElementAvailable):
        Stub out documentElementAvailable().
        * WebKitSupport/FrameLoaderClientWx.h:
        Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Scott Violet <sky@google.com>
dglazkov@chromium.org [Thu, 5 Feb 2009 23:40:33 +0000 (23:40 +0000)]
2009-02-05  Scott Violet  <sky@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23766
        CanvasRenderingContext2D::setShadow needs else for other platforms.

        Implements the CMYK variant of CanvasRenderingContext2D::setShadow for
        other platforms using the CMYK color constructor.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Scott Violet <sky@google.com>
dglazkov@chromium.org [Thu, 5 Feb 2009 23:36:10 +0000 (23:36 +0000)]
2009-02-05  Scott Violet  <sky@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23687
        Wires up Skia'a ImageBuffer::toDataURL to support pngs.
        This helps Chromium pass a couple of layout tests.

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/image-encoders: Added.
        * platform/image-encoders/skia: Added.
        * platform/image-encoders/skia/PNGImageEncoder.cpp: Added.
        (WebCore::):
        (WebCore::PngEncoderState::EncoderWriteCallback):
        (WebCore::PngEncoderState::ConvertBGRAtoRGB):
        (WebCore::PngEncoderState::PngWriteStructDestroyer::PngWriteStructDestroyer):
        (WebCore::PngEncoderState::PngWriteStructDestroyer::~PngWriteStructDestroyer):
        (WebCore::PNGImageEncoder::encode):
        * platform/image-encoders/skia/PNGImageEncoder.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 5 Feb 2009 23:34:31 +0000 (23:34 +0000)]
2009-02-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix missing checked cast.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fix WML enabled builds.
zimmermann@webkit.org [Thu, 5 Feb 2009 23:31:09 +0000 (23:31 +0000)]
Not reviewed. Fix WML enabled builds.
FrameLoader::load() got an additional 'lockHistory' parameter, pass 'false'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Scott Violet <sky@google.com>
dglazkov@chromium.org [Thu, 5 Feb 2009 23:28:27 +0000 (23:28 +0000)]
2009-02-05  Scott Violet  <sky@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23625
        Additional fix: Skia platform doesn't render text to a canvas or support clipping to an image buffer

        Fixes three bugs in PlatformContextSkia:

        * When a new layer was started clipped to an image we used the
          assignment operator to copy the SkBitmap. If the SkBitmap owns it's
          pixels, this is not the right thing to do. Instead we need to create
          a copy of the image.
        * State holds an SkBitmap by value. State's copy constructor does a
          memcpy. This is confusing and subtle, I've converted to use a member
          initializer list which I think is clearer and less error prone.
        * When creating a new layer there is no need to copy the clip image.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::State::State):
        (PlatformContextSkia::save):
        (PlatformContextSkia::beginLayerClippedToImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Scott Violet <sky@google.com>
dglazkov@chromium.org [Thu, 5 Feb 2009 23:24:54 +0000 (23:24 +0000)]
2009-02-05  Scott Violet  <sky@google.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=23462
        Changes call from setFillColor to setStrokeColor.

        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::applyStrokeColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Feb 2009 23:12:11 +0000 (23:12 +0000)]
2009-02-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23767
        Add custom V8 bindings for HTML5 database.

        * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Added.
        (WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback):
        (WebCore::V8CustomSQLStatementCallback::~V8CustomSQLStatementCallback):
        (WebCore::V8CustomSQLStatementCallback::handleEvent):
        * bindings/v8/custom/V8CustomSQLStatementCallback.h: Added.
        (WebCore::V8CustomSQLStatementCallback::create):
        * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Added.
        (WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback):
        (WebCore::V8CustomSQLStatementErrorCallback::~V8CustomSQLStatementErrorCallback):
        (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
        * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Added.
        (WebCore::V8CustomSQLStatementErrorCallback::create):
        * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Added.
        (WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback):
        (WebCore::V8CustomSQLTransactionCallback::~V8CustomSQLTransactionCallback):
        (WebCore::V8CustomSQLTransactionCallback::handleEvent):
        * bindings/v8/custom/V8CustomSQLTransactionCallback.h: Added.
        (WebCore::V8CustomSQLTransactionCallback::create):
        * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Added.
        (WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback):
        (WebCore::V8CustomSQLTransactionErrorCallback::~V8CustomSQLTransactionErrorCallback):
        (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
        * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Added.
        (WebCore::V8CustomSQLTransactionErrorCallback::create):
        * bindings/v8/custom/V8CustomVoidCallback.cpp: Added.
        (WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
        (WebCore::V8CustomVoidCallback::~V8CustomVoidCallback):
        (WebCore::V8CustomVoidCallback::handleEvent):
        (WebCore::invokeCallback):
        * bindings/v8/custom/V8CustomVoidCallback.h: Added.
        (WebCore::V8CustomVoidCallback::create):
        * bindings/v8/custom/V8DatabaseCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SQLTransactionCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 5 Feb 2009 23:10:25 +0000 (23:10 +0000)]
2009-02-05  David Hyatt  <hyatt@apple.com>

        Fix crash on svg custom stop test.  A virtual function didn't get patched properly.

        Reviewed by Sam Weinig

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::clippedOverflowRectForRepaint):
        * rendering/RenderSVGGradientStop.h:
        (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 5 Feb 2009 23:08:22 +0000 (23:08 +0000)]
2009-02-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=23765

        Add toRenderBoxModelObject() so that we can cast objects that
        can have layers.

        Fix getComputedStyle to return the current value of style
        properties that are undergoing accelerated animations, by
        asking the AnimationController if the property has accelerated
        animations, and, if so, asking it to generate an appropriate
        style.

        Tightened up some type safety (CSSPropertyID), and code clarity
        (replace bool with enum).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
dglazkov@chromium.org [Thu, 5 Feb 2009 23:03:27 +0000 (23:03 +0000)]
JavaScriptCore:

2009-02-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23747
        Add Chromium threading-related files.

        * wtf/MainThread.cpp: Added platform guard to initializeMainThread.
        * wtf/chromium/ChromiumThreading.h: Added.
        * wtf/chromium/MainThreadChromium.cpp: Added.
        (WTF::initializeMainThread):
        (WTF::scheduleDispatchFunctionsOnMainThread):

WebCore:

2009-02-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23747
        Add Chromium threading-related files.

        * platform/chromium/TemporaryLinkStubs.cpp: Removed theading-related stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix whitespace in the ChangeLog
weinig@apple.com [Thu, 5 Feb 2009 23:01:44 +0000 (23:01 +0000)]
Fix whitespace in the ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - build fix
mitz@apple.com [Thu, 5 Feb 2009 22:45:28 +0000 (22:45 +0000)]
    - build fix

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::initGlobalCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 5 Feb 2009 22:43:19 +0000 (22:43 +0000)]
2009-02-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Add toRenderButton methods for casting RenderObjects to RenderButtons.  The methods will assert if the object
        is not a RenderButton.  Also add a toRenderButton method that takes a RenderButton but returns void and that
        is unimplemented.  This method will catch anyone trying to do a cast when the object is already a RenderButton.

        * rendering/RenderButton.h:
        (WebCore::RenderButton::isRenderButton):
        (WebCore::toRenderButton):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isRenderButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 5 Feb 2009 22:37:32 +0000 (22:37 +0000)]
2009-02-05  Beth Dakin  <bdakin@apple.com>

        Reviewed by John Sullivan and Brady Eidson.

        Fix for <rdar://problem/6557595> REGRESSION: In Mail, selecting a
        mail note message doesn't display it in Mail's preview pane

        This was failing because revision 36962 removed a version of
        setVerticalScrollingMode that mail calls. This patch simply adds
        that method back.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 5 Feb 2009 22:26:53 +0000 (22:26 +0000)]
2009-02-05  David Hyatt  <hyatt@apple.com>

        Move the m_layer member variable of RenderBox up into RenderBoxModelObject.  Refactor styleDidChange'
        of RenderObject, RenderBoxModelObject and RenderBox to get more of the code in the correct subclass.
        In order to set the various RenderObject bits properly prior to the test for whether a layer is
        required, I added an additional method, updateBoxModelInfoAfterStyleChange, that is responsible
        for setting all of the bits.

        Eliminate hasStaticX/Y, staticX/Y, and setStaticX/Y from the render tree.  Move hasStaticX/Y to
        RenderStyle, and just use the corresponding layer() methods for the
        staticX/Y getters/setters.

        Reviewed by Sam Weinig

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::adjustPositionedBlock):
        (WebCore::RenderBlock::layoutOnlyPositionedObjects):
        (WebCore::RenderBlock::layoutPositionedObjects):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::offsetForContents):
        (WebCore::RenderBlock::calcPrefWidths):
        (WebCore::RenderBlock::baselinePosition):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::RenderBox):
        (WebCore::RenderBox::destroy):
        (WebCore::RenderBox::styleWillChange):
        (WebCore::RenderBox::styleDidChange):
        (WebCore::RenderBox::updateBoxModelInfoFromStyle):
        (WebCore::RenderBox::scrollWidth):
        (WebCore::RenderBox::scrollHeight):
        (WebCore::RenderBox::scrollLeft):
        (WebCore::RenderBox::scrollTop):
        (WebCore::RenderBox::setScrollLeft):
        (WebCore::RenderBox::setScrollTop):
        (WebCore::RenderBox::getOverflowClipRect):
        (WebCore::RenderBox::localToAbsolute):
        (WebCore::RenderBox::absoluteToLocal):
        (WebCore::RenderBox::localToContainerQuad):
        (WebCore::RenderBox::position):
        (WebCore::RenderBox::computeRectForRepaint):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::RenderBoxModelObject):
        (WebCore::RenderBoxModelObject::destroy):
        (WebCore::RenderBoxModelObject::styleWillChange):
        (WebCore::RenderBoxModelObject::styleDidChange):
        (WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
        * rendering/RenderBoxModelObject.h:
        (WebCore::RenderBoxModelObject::layer):
        (WebCore::RenderBoxModelObject::requiresLayer):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        (WebCore::RenderFlexibleBox::layoutHorizontalBox):
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::updateBoxModelInfoFromStyle):
        (WebCore::RenderInline::styleDidChange):
        (WebCore::RenderInline::relativePositionedInlineOffset):
        * rendering/RenderInline.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::setStaticY):
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle):
        (WebCore::RenderObject::styleDidChange):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::markContainingBlocksForLayout):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::paint):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):
        * rendering/bidi.cpp:
        (WebCore::appendRunsForObject):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::RenderBlock::findNextLineBreak):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::hasStaticX):
        (WebCore::InheritedFlags::hasStaticY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 David Levin <levin@chromium.org>
bfulgham@webkit.org [Thu, 5 Feb 2009 22:07:35 +0000 (22:07 +0000)]
2009-02-05  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Bug 23713: COMPILE_ASSERTS should be moved out of TypeTraits.h and into .cpp file
        <https://bugs.webkit.org/show_bug.cgi?id=23713>

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.scons:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:

        * wtf/HashTraits.h:
        Remove unnecessary header file that I missed when moving out the type traits form this file.

        * wtf/TypeTraits.cpp: Added.
        (WTF::):
        * wtf/TypeTraits.h:
        Moved the compile asserts into TypeTraits.cpp file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 5 Feb 2009 21:18:16 +0000 (21:18 +0000)]
2009-02-05  Sam Weinig  <sam@webkit.org>

        Fix the windows build.

        * bindings/scripts/CodeGeneratorCOM.pm:
        * dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 Feb 2009 20:58:34 +0000 (20:58 +0000)]
2009-02-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Update to match Gecko.

        * bridge/npapi.h:
        * plugins/npfunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 5 Feb 2009 20:35:53 +0000 (20:35 +0000)]
2009-02-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Finish merging EventTargetNode up into Node.

        This also fixes a small recently introduced issue where EventListeners
        would not be removed from the document if they were attached to comment
        nodes outside of the documentElement.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSEventTargetNodeCustom.cpp: Removed.
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        (WebCore::JSNode::pushEventHandlerScope):
        * bindings/scripts/CodeGenerator.pm:
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::CharacterData):
        (WebCore::CharacterData::rendererIsNeeded):
        * dom/CharacterData.h:
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::willRemove):
        (WebCore::ContainerNode::attach):
        (WebCore::ContainerNode::detach):
        (WebCore::ContainerNode::insertedIntoDocument):
        (WebCore::ContainerNode::removedFromDocument):
        (WebCore::ContainerNode::setFocus):
        (WebCore::ContainerNode::setActive):
        (WebCore::ContainerNode::setHovered):
        (WebCore::dispatchChildInsertionEvents):
        (WebCore::dispatchChildRemovalEvents):
        * dom/ContainerNode.h:
        (WebCore::ContainerNode::ContainerNode):
        * dom/Document.cpp:
        (WebCore::Document::removeAllEventListenersFromAllNodes):
        (WebCore::Document::removeAllDisconnectedNodeEventListeners):
        (WebCore::Document::setFocusedNode):
        * dom/EventTargetNode.cpp: Removed.
        * dom/EventTargetNode.h: Removed.
        * dom/Node.cpp:
        (WebCore::Node::scriptExecutionContext):
        (WebCore::Node::eventListeners):
        (WebCore::Node::insertedIntoDocument):
        (WebCore::Node::removedFromDocument):
        (WebCore::Node::willMoveToNewOwnerDocument):
        (WebCore::Node::didMoveToNewOwnerDocument):
        (WebCore::updateSVGElementInstancesAfterEventListenerChange):
        (WebCore::Node::addEventListener):
        (WebCore::Node::removeEventListener):
        (WebCore::Node::removeAllEventListenersSlowCase):
        (WebCore::Node::handleLocalEvents):
        (WebCore::eventTargetAsSVGElementInstance):
        (WebCore::eventTargetRespectingSVGTargetRules):
        (WebCore::Node::dispatchEvent):
        (WebCore::Node::dispatchGenericEvent):
        (WebCore::Node::dispatchSubtreeModifiedEvent):
        (WebCore::Node::dispatchWindowEvent):
        (WebCore::Node::dispatchUIEvent):
        (WebCore::Node::dispatchKeyEvent):
        (WebCore::Node::dispatchMouseEvent):
        (WebCore::Node::dispatchSimulatedMouseEvent):
        (WebCore::Node::dispatchSimulatedClick):
        (WebCore::Node::dispatchWheelEvent):
        (WebCore::Node::dispatchWebKitAnimationEvent):
        (WebCore::Node::dispatchWebKitTransitionEvent):
        (WebCore::Node::dispatchFocusEvent):
        (WebCore::Node::dispatchBlurEvent):
        (WebCore::Node::dispatchEventForType):
        (WebCore::Node::dispatchProgressEvent):
        (WebCore::Node::dispatchStorageEvent):
        (WebCore::Node::removeInlineEventListenerForType):
        (WebCore::Node::setInlineEventListenerForType):
        (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
        (WebCore::Node::inlineEventListenerForType):
        (WebCore::Node::disabled):
        (WebCore::Node::defaultEventHandler):
        (WebCore::Node::onabort):
        (WebCore::Node::setOnabort):
        (WebCore::Node::onblur):
        (WebCore::Node::setOnblur):
        (WebCore::Node::onchange):
        (WebCore::Node::setOnchange):
        (WebCore::Node::onclick):
        (WebCore::Node::setOnclick):
        (WebCore::Node::oncontextmenu):
        (WebCore::Node::setOncontextmenu):
        (WebCore::Node::ondblclick):
        (WebCore::Node::setOndblclick):
        (WebCore::Node::onerror):
        (WebCore::Node::setOnerror):
        (WebCore::Node::onfocus):
        (WebCore::Node::setOnfocus):
        (WebCore::Node::oninput):
        (WebCore::Node::setOninput):
        (WebCore::Node::onkeydown):
        (WebCore::Node::setOnkeydown):
        (WebCore::Node::onkeypress):
        (WebCore::Node::setOnkeypress):
        (WebCore::Node::onkeyup):
        (WebCore::Node::setOnkeyup):
        (WebCore::Node::onload):
        (WebCore::Node::setOnload):
        (WebCore::Node::onmousedown):
        (WebCore::Node::setOnmousedown):
        (WebCore::Node::onmousemove):
        (WebCore::Node::setOnmousemove):
        (WebCore::Node::onmouseout):
        (WebCore::Node::setOnmouseout):
        (WebCore::Node::onmouseover):
        (WebCore::Node::setOnmouseover):
        (WebCore::Node::onmouseup):
        (WebCore::Node::setOnmouseup):
        (WebCore::Node::onmousewheel):
        (WebCore::Node::setOnmousewheel):
        (WebCore::Node::onbeforecut):
        (WebCore::Node::setOnbeforecut):
        (WebCore::Node::oncut):
        (WebCore::Node::setOncut):
        (WebCore::Node::onbeforecopy):
        (WebCore::Node::setOnbeforecopy):
        (WebCore::Node::oncopy):
        (WebCore::Node::setOncopy):
        (WebCore::Node::onbeforepaste):
        (WebCore::Node::setOnbeforepaste):
        (WebCore::Node::onpaste):
        (WebCore::Node::setOnpaste):
        (WebCore::Node::ondragenter):
        (WebCore::Node::setOndragenter):
        (WebCore::Node::ondragover):
        (WebCore::Node::setOndragover):
        (WebCore::Node::ondragleave):
        (WebCore::Node::setOndragleave):
        (WebCore::Node::ondrop):
        (WebCore::Node::setOndrop):
        (WebCore::Node::ondragstart):
        (WebCore::Node::setOndragstart):
        (WebCore::Node::ondrag):
        (WebCore::Node::setOndrag):
        (WebCore::Node::ondragend):
        (WebCore::Node::setOndragend):
        (WebCore::Node::onreset):
        (WebCore::Node::setOnreset):
        (WebCore::Node::onresize):
        (WebCore::Node::setOnresize):
        (WebCore::Node::onscroll):
        (WebCore::Node::setOnscroll):
        (WebCore::Node::onsearch):
        (WebCore::Node::setOnsearch):
        (WebCore::Node::onselect):
        (WebCore::Node::setOnselect):
        (WebCore::Node::onselectstart):
        (WebCore::Node::setOnselectstart):
        (WebCore::Node::onsubmit):
        (WebCore::Node::setOnsubmit):
        (WebCore::Node::onunload):
        (WebCore::Node::setOnunload):
        * dom/Node.h:
        * editing/Editor.cpp:
        (WebCore::Editor::dispatchCPPEvent):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::handleLocalEvents):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::notifyFinished):
        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::defaultEventHandler):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::mouseButtonListener):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchDragEvent):
        (WebCore::EventHandler::updateMouseEventTargetNode):
        (WebCore::EventHandler::dispatchMouseEvent):
        (WebCore::EventHandler::handleWheelEvent):
        (WebCore::EventHandler::canMouseDownStartSelect):
        (WebCore::EventHandler::canMouseDragExtendSelect):
        (WebCore::eventTargetNodeForDocument):
        (WebCore::EventHandler::keyEvent):
        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleEvent):
        (WebCore::FrameView::updateOverflowStatus):
        * page/FrameView.h:
        * page/Page.cpp:
        (WebCore::networkStateChanged):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::updateOverflowStatus):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::valueChanged):
        * rendering/RenderMedia.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::selectionChanged):
        * svg/SVGElementInstance.h:
        (WebCore::SVGElementInstance::toNode):
        * xml/XPathExpression.cpp:
        (WebCore::XPathExpression::evaluate):
        * xml/XPathResult.cpp:
        (WebCore::XPathResult::XPathResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Thu, 5 Feb 2009 20:25:51 +0000 (20:25 +0000)]
2009-02-05  Adam Treat  <adam.treat@torchmobile.com>

        Fix the Qt build now that EventTargetNode.idl was removed in r40672.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Scott Violet <sky@google.com>
darin@chromium.org [Thu, 5 Feb 2009 20:14:24 +0000 (20:14 +0000)]
2009-02-05  Scott Violet  <sky@google.com>

        Reviewed by Sam Weinig.

        Bug 23462: Add RGB -> CMYK conversion algorithm
        <https://bugs.webkit.org/show_bug.cgi?id=23462>

        Adds an RGB -> CMYK converter. This isn't perfect, but better than
        nothing.

        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::applyStrokeColor):
        (WebCore::CanvasStyle::applyFillColor):
        (WebCore::CanvasStyle::cmykToRGB):
        * html/CanvasStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Thu, 5 Feb 2009 18:38:32 +0000 (18:38 +0000)]
WebCore:

2009-02-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        First stage of merging EventTargetNode up into Node. The intent of this change
        is to both simplify the inheritance hierarchy (at the same time making it more
        closely match the spec which states that all Nodes are EventTargets) and save
        4 bytes per Node that the polymorphic multiple-inheritance was costing us.

        This does the bare minimum to get things compiling, the next patch will clean

        * DerivedSources.make:
        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::mark):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toEventTarget):
        * bindings/js/JSEventTarget.h:
        * bindings/js/JSEventTargetNodeCustom.cpp:
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        (WebCore::JSNode::pushEventHandlerScope):
        * bindings/js/JSStyleSheetCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * dom/Attr.idl:
        * dom/CharacterData.h:
        * dom/CharacterData.idl:
        * dom/Document.idl:
        * dom/DocumentFragment.idl:
        * dom/Element.idl:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toNode):
        * dom/EventTarget.h:
        * dom/EventTarget.idl:
        * dom/EventTargetNode.cpp:
        (WebCore::Node::scriptExecutionContext):
        (WebCore::Node::eventListeners):
        (WebCore::Node::insertedIntoDocument):
        (WebCore::Node::removedFromDocument):
        (WebCore::Node::willMoveToNewOwnerDocument):
        (WebCore::Node::didMoveToNewOwnerDocument):
        (WebCore::Node::addEventListener):
        (WebCore::Node::removeEventListener):
        (WebCore::Node::removeAllEventListenersSlowCase):
        (WebCore::Node::handleLocalEvents):
        (WebCore::Node::dispatchEvent):
        (WebCore::Node::dispatchGenericEvent):
        (WebCore::Node::dispatchSubtreeModifiedEvent):
        (WebCore::Node::dispatchWindowEvent):
        (WebCore::Node::dispatchUIEvent):
        (WebCore::Node::dispatchKeyEvent):
        (WebCore::Node::dispatchMouseEvent):
        (WebCore::Node::dispatchSimulatedMouseEvent):
        (WebCore::Node::dispatchSimulatedClick):
        (WebCore::Node::dispatchWheelEvent):
        (WebCore::Node::dispatchWebKitAnimationEvent):
        (WebCore::Node::dispatchWebKitTransitionEvent):
        (WebCore::Node::dispatchFocusEvent):
        (WebCore::Node::dispatchBlurEvent):
        (WebCore::Node::dispatchEventForType):
        (WebCore::Node::dispatchProgressEvent):
        (WebCore::Node::dispatchStorageEvent):
        (WebCore::Node::removeInlineEventListenerForType):
        (WebCore::Node::setInlineEventListenerForType):
        (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
        (WebCore::Node::inlineEventListenerForType):
        (WebCore::Node::disabled):
        (WebCore::Node::defaultEventHandler):
        (WebCore::Node::onabort):
        (WebCore::Node::setOnabort):
        (WebCore::Node::onblur):
        (WebCore::Node::setOnblur):
        (WebCore::Node::onchange):
        (WebCore::Node::setOnchange):
        (WebCore::Node::onclick):
        (WebCore::Node::setOnclick):
        (WebCore::Node::oncontextmenu):
        (WebCore::Node::setOncontextmenu):
        (WebCore::Node::ondblclick):
        (WebCore::Node::setOndblclick):
        (WebCore::Node::onerror):
        (WebCore::Node::setOnerror):
        (WebCore::Node::onfocus):
        (WebCore::Node::setOnfocus):
        (WebCore::Node::oninput):
        (WebCore::Node::setOninput):
        (WebCore::Node::onkeydown):
        (WebCore::Node::setOnkeydown):
        (WebCore::Node::onkeypress):
        (WebCore::Node::setOnkeypress):
        (WebCore::Node::onkeyup):
        (WebCore::Node::setOnkeyup):
        (WebCore::Node::onload):
        (WebCore::Node::setOnload):
        (WebCore::Node::onmousedown):
        (WebCore::Node::setOnmousedown):
        (WebCore::Node::onmousemove):
        (WebCore::Node::setOnmousemove):
        (WebCore::Node::onmouseout):
        (WebCore::Node::setOnmouseout):
        (WebCore::Node::onmouseover):
        (WebCore::Node::setOnmouseover):
        (WebCore::Node::onmouseup):
        (WebCore::Node::setOnmouseup):
        (WebCore::Node::onmousewheel):
        (WebCore::Node::setOnmousewheel):
        (WebCore::Node::onbeforecut):
        (WebCore::Node::setOnbeforecut):
        (WebCore::Node::oncut):
        (WebCore::Node::setOncut):
        (WebCore::Node::onbeforecopy):
        (WebCore::Node::setOnbeforecopy):
        (WebCore::Node::oncopy):
        (WebCore::Node::setOncopy):
        (WebCore::Node::onbeforepaste):
        (WebCore::Node::setOnbeforepaste):
        (WebCore::Node::onpaste):
        (WebCore::Node::setOnpaste):
        (WebCore::Node::ondragenter):
        (WebCore::Node::setOndragenter):
        (WebCore::Node::ondragover):
        (WebCore::Node::setOndragover):
        (WebCore::Node::ondragleave):
        (WebCore::Node::setOndragleave):
        (WebCore::Node::ondrop):
        (WebCore::Node::setOndrop):
        (WebCore::Node::ondragstart):
        (WebCore::Node::setOndragstart):
        (WebCore::Node::ondrag):
        (WebCore::Node::setOndrag):
        (WebCore::Node::ondragend):
        (WebCore::Node::setOndragend):
        (WebCore::Node::onreset):
        (WebCore::Node::setOnreset):
        (WebCore::Node::onresize):
        (WebCore::Node::setOnresize):
        (WebCore::Node::onscroll):
        (WebCore::Node::setOnscroll):
        (WebCore::Node::onsearch):
        (WebCore::Node::setOnsearch):
        (WebCore::Node::onselect):
        (WebCore::Node::setOnselect):
        (WebCore::Node::onselectstart):
        (WebCore::Node::setOnselectstart):
        (WebCore::Node::onsubmit):
        (WebCore::Node::setOnsubmit):
        (WebCore::Node::onunload):
        (WebCore::Node::setOnunload):
        * dom/EventTargetNode.h:
        (WebCore::toEventTargetNode):
        (WebCore::EventTargetNodeCast):
        * dom/EventTargetNode.idl: Removed.
        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::MouseEvent):
        (WebCore::MouseEvent::initMouseEvent):
        (WebCore::MouseEvent::toElement):
        (WebCore::MouseEvent::fromElement):
        * dom/MouseEvent.h:
        (WebCore::MouseEvent::create):
        (WebCore::MouseEvent::relatedTarget):
        * dom/Node.cpp:
        (WebCore::Node::~Node):
        * dom/Node.h:
        (WebCore::Node::isEventTargetNode):
        (WebCore::Node::toNode):
        (WebCore::Node::removeAllEventListeners):
        (WebCore::Node::refEventTarget):
        (WebCore::Node::derefEventTarget):
        * dom/Node.idl:
        * page/EventHandler.h:
        * page/FrameView.h:
        * xml/XPathResult.h:
        (WebCore::XPathResult::create):

LayoutTests:

2009-02-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Layer.

        Fix after merging EventTargetNode up into Node.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-chain-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 5 Feb 2009 17:24:00 +0000 (17:24 +0000)]
2009-02-04  David Hyatt  <hyatt@apple.com>

        Convert RenderLayer from having a RenderBox* m_renderer to having a RenderBoxModelObject*.  The
        container-relative repaint methods all had to be changed as a result to use RenderBoxModelObject* also.

        All of RenderLayer.cpp now uses what will be the new style for dealing with an object that can be a block
        or an inline flow.  x()/y()/width()/height() can't be queried on an inline flow, nor can many other
        properties (like scrollWidth() / scrollHeight()), so the code has to be tightened up to convert to RenderBox
        under the right conditions.

        There was a bogus subtraction of renderer()->y() in localBounding box for RenderInlines.  Since y was always
        0, this subtraction wasn't necessary.  It has been removed.

        Reviewed by Adam Roben

        * page/animation/AnimationBase.cpp:
        * rendering/RenderBR.h:
        (WebCore::RenderBR::selectionRectForRepaint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::selectionGapRectsForRepaint):
        (WebCore::RenderBlock::rectWithOutlineForRepaint):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::selectionRectForRepaint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::outlineBoundsForRepaint):
        (WebCore::RenderBox::localToContainerQuad):
        (WebCore::RenderBox::clippedOverflowRectForRepaint):
        (WebCore::RenderBox::computeRectForRepaint):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::relativePositionOffsetX):
        (WebCore::RenderBoxModelObject::relativePositionOffsetY):
        * rendering/RenderBoxModelObject.h:
        (WebCore::RenderBoxModelObject::relativePositionOffset):
        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::computeRectForRepaint):
        * rendering/RenderForeignObject.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::clippedOverflowRectForRepaint):
        (WebCore::RenderInline::rectWithOutlineForRepaint):
        * rendering/RenderInline.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::updateTransform):
        (WebCore::RenderLayer::setHasVisibleContent):
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::scrollRectToVisible):
        (WebCore::resizerCornerRect):
        (WebCore::RenderLayer::scrollbarCornerPresent):
        (WebCore::RenderLayer::invalidateScrollbarRect):
        (WebCore::RenderLayer::positionOverflowControls):
        (WebCore::RenderLayer::computeScrollDimensions):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        (WebCore::RenderLayer::isPointInResizeControl):
        (WebCore::RenderLayer::hitTestOverflowControls):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::localBoundingBox):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::renderer):
        (WebCore::RenderLayer::renderBox):
        (WebCore::RenderLayer::renderBoxX):
        (WebCore::RenderLayer::renderBoxY):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::selectionRectForRepaint):
        * rendering/RenderListMarker.h:
        * rendering/RenderMarquee.cpp:
        (WebCore::RenderMarquee::computePosition):
        (WebCore::RenderMarquee::timerFired):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containerForRepaint):
        (WebCore::RenderObject::repaintUsingContainer):
        (WebCore::RenderObject::repaint):
        (WebCore::RenderObject::repaintRectangle):
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
        (WebCore::RenderObject::rectWithOutlineForRepaint):
        (WebCore::RenderObject::clippedOverflowRectForRepaint):
        (WebCore::RenderObject::computeRectForRepaint):
        (WebCore::RenderObject::localToContainerQuad):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::selectionRectForRepaint):
        (WebCore::RenderObject::outlineBoundsForRepaint):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::clippedOverflowRectForRepaint):
        (WebCore::RenderPath::outlineBoundsForRepaint):
        * rendering/RenderPath.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::selectionRectForRepaint):
        (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
        * rendering/RenderReplaced.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::selectionRectForRepaint):
        (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
        * rendering/RenderSVGText.h:
        * rendering/RenderSelectionInfo.h:
        (WebCore::RenderSelectionInfoBase::repaintContainer):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
        (WebCore::RenderTableCell::computeRectForRepaint):
        (WebCore::RenderTableCell::localToContainerQuad):
        * rendering/RenderTableCell.h:
        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
        * rendering/RenderTableCol.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
        * rendering/RenderTableRow.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::clippedOverflowRectForRepaint):
        (WebCore::RenderText::selectionRectForRepaint):
        * rendering/RenderText.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::localToContainerQuad):
        (WebCore::RenderView::computeRectForRepaint):
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix.
ap@webkit.org [Thu, 5 Feb 2009 14:38:39 +0000 (14:38 +0000)]
    Build fix.

        * page/animation/KeyframeAnimation.h: A function prototype had two "fromStyle" arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Yael Aharon <yael.aharon@nokia.com>
hausmann@webkit.org [Thu, 5 Feb 2009 14:34:28 +0000 (14:34 +0000)]
2009-02-05  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Alexey Proskuryakov.
        Landed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=23733

        Use a 2 arguments constructor for KURL to avoid ASSERT failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Feng Qian <feng@chromium.org>
bfulgham@webkit.org [Thu, 5 Feb 2009 07:27:34 +0000 (07:27 +0000)]
2009-02-04  Feng Qian  <feng@chromium.org>

        Reviewed by Darin Adler.

        Add Android-specific files to WebCore/editing directory.
        https://bugs.webkit.org/show_bug.cgi?id=23294

        * editing/android: Added.
        * editing/android/EditorAndroid.cpp: Added.
        (WebCore::Editor::newGeneralClipboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bfulgham@webkit.org [Thu, 5 Feb 2009 07:23:55 +0000 (07:23 +0000)]
WebCore:

2009-02-04  Dean Jackson  <dino@apple.com>

        Reviewed by Darin Adler.

        Remove -webkit-animation-play-state
        The AnimationController still has the code to execute the property, but
        it is no longer parsed or recorded.
        https://bugs.webkit.org/show_bug.cgi?id=22907

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseAnimationProperty):
        * css/CSSParser.h:
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSStyleSelector.h:
        * platform/animation/Animation.h:
        * rendering/style/RenderStyleConstants.h:

LayoutTests:

2009-02-04  Dean Jackson  <dino@apple.com>

        Reviewed by Darin Adler.

        Remove animation-play-state from expected properties.
        https://bugs.webkit.org/show_bug.cgi?id=22907

        * animations/computed-style-expected.txt:
        * animations/computed-style.html:
        * fast/css/computed-style-display-none-expected.txt:
        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:
        * fast/css/computed-style-without-renderer.html:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bfulgham@webkit.org [Thu, 5 Feb 2009 06:41:19 +0000 (06:41 +0000)]
WebCore:

2009-02-04  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Darin Adler.

        Make sure we don't load on removing the media element from the document
        https://bugs.webkit.org/show_bug.cgi?id=22105

        Test: media/remove-from-document-no-load.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::removedFromDocument):

LayoutTests:

2009-02-04  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Darin Adler.

        Make sure we don't load on removing the media element from the document
        https://bugs.webkit.org/show_bug.cgi?id=22105.

        * media/remove-from-document-no-load-expected.txt: Added.
        * media/remove-from-document-no-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 5 Feb 2009 06:15:11 +0000 (06:15 +0000)]
2009-02-04  David Hyatt  <hyatt@apple.com>

        Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines.  For
        now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy.  RenderInline remains
        derived from RenderBox for now.

        Reviewed by Sam Weinig

        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::RenderBox):
        (WebCore::RenderBox::destroy):
        (WebCore::RenderBox::styleWillChange):
        (WebCore::RenderBox::styleDidChange):
        (WebCore::RenderBox::computeRectForRepaint):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp: Added.
        (WebCore::RenderBoxModelObject::RenderBoxModelObject):
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
        * rendering/RenderBoxModelObject.h: Added.
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Chris Marrin <cmarrin@apple.com>
simon.fraser@apple.com [Thu, 5 Feb 2009 06:07:27 +0000 (06:07 +0000)]
2009-02-04  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dave Hyatt

        Added accelerated animation support to AnimationController and friends. The primary
        changes are:
        * accelerated animations get their start time from the compositing engine, so we
          wait for a callback (notifyAnimationStarted()) in order to get the start time.
        * if software and accelerated animations start in the same cycle, they all need
          to use the same start time, which is that of the accelerated animations.

        Added AnimationControllerPrivate to preserve the encapsulation under
        AnimationController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 5 Feb 2009 05:31:40 +0000 (05:31 +0000)]
2009-02-04  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver 'the nun' Hunt.

        Add -e switch to jsc to enable evaluation of scripts passed on the command line.

        * jsc.cpp:
        (Script::Script):
        (runWithScripts):
        (printUsageStatement):
        (parseArguments):
        (jscmain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Feb 2009 04:18:29 +0000 (04:18 +0000)]
2009-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        Not reviewed, build fix.

        Remove duplicate definition of msSans in FontCache::alternateFamilyName.

        * platform/graphics/FontCache.cpp:
        (WebCore::alternateFamilyName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Dmitry Titov <dimich@chromium.org>
dglazkov@chromium.org [Thu, 5 Feb 2009 04:07:17 +0000 (04:07 +0000)]
2009-02-04  Dmitry Titov  <dimich@chromium.org>

        Not reviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=22806
        Reverting the test that should not yet be landed since it depends on
        changes in DRT which were not yet landed.

        * fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Removed.
        * fast/dom/Window/cached-timeout-stopped-on-close.html: Removed.
        * fast/dom/Window/resources/cached-timeout-page-1.html: Removed.
        * fast/dom/Window/resources/cached-timeout-page-2.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 5 Feb 2009 03:40:39 +0000 (03:40 +0000)]
2009-02-04  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam 'Big Mac' Weinig.

        * assembler/AbstractMacroAssembler.h: Copied from assembler/MacroAssembler.h.
        * assembler/MacroAssemblerX86.h: Copied from assembler/MacroAssembler.h.
        * assembler/MacroAssemblerX86Common.h: Copied from assembler/MacroAssembler.h.
        * assembler/MacroAssemblerX86_64.h: Copied from assembler/MacroAssembler.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 5 Feb 2009 02:01:25 +0000 (02:01 +0000)]
2009-02-04  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        This patch tidies up the MacroAssembler, cleaning up the code and refactoring out the
        platform-specific parts.  The MacroAssembler gets split up like a beef burger, with the
        platform-agnostic data types being the lower bun (in the form of the class AbstractMacroAssembler),
        the plaform-specific code generation forming a big meaty patty of methods like 'add32',
        'branch32', etc (MacroAssemblerX86), and finally topped off with the bun-lid of the
        MacroAssembler class itself, providing covenience methods such as the stack peek & poke,
        and backwards branch methods, all of which can be described in a platform independent
        way using methods from the base class.  The AbstractMacroAssembler is templated on the
        type of the assembler class that will be used for code generation, and the three layers
        are held together with the cocktail stick of inheritance.

        The above description is a slight simplification since the MacroAssemblerX86 is actually
        formed from two layers (in effect giving us a kind on bacon double cheeseburger) - with the
        bulk of methods that are common between x86 & x86-64 implemented in MacroAssemblerX86Common,
        which forms a base class for MacroAssemblerX86 and MacroAssemblerX86_64 (which add the methods
        specific to the given platform).

        I'm landing these changes first without splitting the classes across multiple files,
        I will follow up with a second patch to split up the file MacroAssembler.h.

        * assembler/MacroAssembler.h:
        (JSC::AbstractMacroAssembler::):
        (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr):
        (JSC::AbstractMacroAssembler::DataLabelPtr::patch):
        (JSC::AbstractMacroAssembler::DataLabel32::DataLabel32):
        (JSC::AbstractMacroAssembler::DataLabel32::patch):
        (JSC::AbstractMacroAssembler::Label::Label):
        (JSC::AbstractMacroAssembler::Jump::Jump):
        (JSC::AbstractMacroAssembler::Jump::link):
        (JSC::AbstractMacroAssembler::Jump::linkTo):
        (JSC::AbstractMacroAssembler::Jump::patch):
        (JSC::AbstractMacroAssembler::JumpList::link):
        (JSC::AbstractMacroAssembler::JumpList::linkTo):
        (JSC::AbstractMacroAssembler::PatchBuffer::link):
        (JSC::AbstractMacroAssembler::PatchBuffer::addressOf):
        (JSC::AbstractMacroAssembler::PatchBuffer::setPtr):
        (JSC::AbstractMacroAssembler::size):
        (JSC::AbstractMacroAssembler::copyCode):
        (JSC::AbstractMacroAssembler::label):
        (JSC::AbstractMacroAssembler::align):
        (JSC::AbstractMacroAssembler::differenceBetween):
        (JSC::MacroAssemblerX86Common::xor32):
        (JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch):
        (JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch):
        (JSC::MacroAssemblerX86Common::move):
        (JSC::MacroAssemblerX86Common::swap):
        (JSC::MacroAssemblerX86Common::signExtend32ToPtr):
        (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
        (JSC::MacroAssemblerX86Common::branch32):
        (JSC::MacroAssemblerX86Common::jump):
        (JSC::MacroAssemblerX86_64::add32):
        (JSC::MacroAssemblerX86_64::sub32):
        (JSC::MacroAssemblerX86_64::load32):
        (JSC::MacroAssemblerX86_64::store32):
        (JSC::MacroAssemblerX86_64::addPtr):
        (JSC::MacroAssemblerX86_64::andPtr):
        (JSC::MacroAssemblerX86_64::orPtr):
        (JSC::MacroAssemblerX86_64::rshiftPtr):
        (JSC::MacroAssemblerX86_64::subPtr):
        (JSC::MacroAssemblerX86_64::xorPtr):
        (JSC::MacroAssemblerX86_64::loadPtr):
        (JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch):
        (JSC::MacroAssemblerX86_64::storePtr):
        (JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch):
        (JSC::MacroAssemblerX86_64::branchPtr):
        (JSC::MacroAssemblerX86_64::branchTestPtr):
        (JSC::MacroAssemblerX86_64::branchAddPtr):
        (JSC::MacroAssemblerX86_64::branchSubPtr):
        (JSC::MacroAssemblerX86_64::branchPtrWithPatch):
        (JSC::MacroAssemblerX86_64::storePtrWithPatch):
        (JSC::MacroAssemblerX86::add32):
        (JSC::MacroAssemblerX86::sub32):
        (JSC::MacroAssemblerX86::load32):
        (JSC::MacroAssemblerX86::store32):
        (JSC::MacroAssemblerX86::branch32):
        (JSC::MacroAssemblerX86::branchPtrWithPatch):
        (JSC::MacroAssemblerX86::storePtrWithPatch):
        (JSC::MacroAssembler::pop):
        (JSC::MacroAssembler::peek):
        (JSC::MacroAssembler::poke):
        (JSC::MacroAssembler::branchPtr):
        (JSC::MacroAssembler::branch32):
        (JSC::MacroAssembler::branch16):
        (JSC::MacroAssembler::branchTestPtr):
        (JSC::MacroAssembler::addPtr):
        (JSC::MacroAssembler::andPtr):
        (JSC::MacroAssembler::orPtr):
        (JSC::MacroAssembler::rshiftPtr):
        (JSC::MacroAssembler::subPtr):
        (JSC::MacroAssembler::xorPtr):
        (JSC::MacroAssembler::loadPtr):
        (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch):
        (JSC::MacroAssembler::storePtr):
        (JSC::MacroAssembler::storePtrWithAddressOffsetPatch):
        (JSC::MacroAssembler::branchAddPtr):
        (JSC::MacroAssembler::branchSubPtr):
        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileBinaryArithOp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 Feb 2009 01:49:49 +0000 (01:49 +0000)]
2009-02-04  Anders Carlsson  <andersca@apple.com>

        Build fix fix.

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::initGlobalCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
eric@webkit.org [Thu, 5 Feb 2009 01:26:15 +0000 (01:26 +0000)]
    Reviewed by George Staikos.

        Reverse the meaning of the if check so that Android
        (dpad devices) do not scroll on focus and normal platforms do
        http://trac.webkit.org/changeset/40647

        This was caught by George Staikos, and I wrote the patch.

        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 Feb 2009 01:18:34 +0000 (01:18 +0000)]
2009-02-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Change PCHasProperty, PCHasMethod and PCGetProperty into simpleroutines.

        Rename PHEvaluateReply to PHBooleanAndDataReply and add PHBooleanReply.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        (WKPCGetProperty):
        (WKPCHasProperty):
        (WKPCHasMethod):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 5 Feb 2009 01:02:58 +0000 (01:02 +0000)]
2009-02-04  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebHistory.cpp:
        (WebHistory::visitedURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 5 Feb 2009 00:53:38 +0000 (00:53 +0000)]
2009-02-04  David Hyatt  <hyatt@apple.com>

        Eliminate RenderContainer.

        Reviewed by Sam and Anders

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::RenderBlock):
        (WebCore::RenderBlock::destroy):
        (WebCore::RenderBlock::styleWillChange):
        (WebCore::RenderBlock::styleDidChange):
        (WebCore::RenderBlock::addChild):
        (WebCore::RenderBlock::dirtyLineBoxes):
        (WebCore::RenderBlock::createInlineBox):
        (WebCore::RenderBlock::removeChild):
        (WebCore::RenderBlock::setSelectionState):
        (WebCore::RenderBlock::avoidsFloats):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::calcInlinePrefWidths):
        (WebCore::RenderBlock::baselinePosition):
        (WebCore::RenderBlock::getBaselineOfFirstLineBox):
        (WebCore::RenderBlock::getBaselineOfLastLineBox):
        (WebCore::RenderBlock::rectWithOutlineForRepaint):
        (WebCore::RenderBlock::hoverAncestor):
        (WebCore::RenderBlock::updateDragState):
        (WebCore::RenderBlock::localCaretRect):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::virtualChildren):
        (WebCore::RenderBlock::children):
        * rendering/RenderContainer.cpp: Removed.
        * rendering/RenderContainer.h: Removed.
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::RenderFrameSet):
        (WebCore::RenderFrameSet::nodeAtPoint):
        (WebCore::RenderFrameSet::layout):
        * rendering/RenderFrameSet.h:
        (WebCore::RenderFrameSet::virtualChildren):
        (WebCore::RenderFrameSet::children):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::RenderInline):
        (WebCore::RenderInline::destroy):
        (WebCore::RenderInline::styleDidChange):
        (WebCore::nextContinuation):
        (WebCore::RenderInline::continuationBefore):
        (WebCore::RenderInline::addChildIgnoringContinuation):
        (WebCore::RenderInline::splitInlines):
        (WebCore::RenderInline::splitFlow):
        (WebCore::RenderInline::addChildToContinuation):
        (WebCore::RenderInline::offsetLeft):
        (WebCore::RenderInline::offsetTop):
        (WebCore::RenderInline::positionForCoordinates):
        (WebCore::RenderInline::clippedOverflowRectForRepaint):
        (WebCore::RenderInline::rectWithOutlineForRepaint):
        (WebCore::RenderInline::updateDragState):
        (WebCore::RenderInline::childBecameNonInline):
        * rendering/RenderInline.h:
        (WebCore::RenderInline::virtualChildren):
        (WebCore::RenderInline::children):
        (WebCore::RenderInline::continuation):
        (WebCore::RenderInline::setContinuation):
        * rendering/RenderLineBoxList.h:
        * rendering/RenderObject.h:
        * rendering/RenderObjectChildList.h:
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::RenderSVGRoot):
        (WebCore::RenderSVGRoot::applyContentTransforms):
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::absoluteTransform):
        (WebCore::RenderSVGRoot::nodeAtPoint):
        (WebCore::RenderSVGRoot::position):
        * rendering/RenderSVGRoot.h:
        (WebCore::RenderSVGRoot::virtualChildren):
        (WebCore::RenderSVGRoot::children):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::absoluteQuads):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild):
        (WebCore::RenderTable::removeChild):
        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::RenderTableCol):
        * rendering/RenderTableCol.h:
        (WebCore::RenderTableCol::virtualChildren):
        (WebCore::RenderTableCol::children):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::RenderTableRow):
        (WebCore::RenderTableRow::destroy):
        (WebCore::RenderTableRow::styleWillChange):
        (WebCore::RenderTableRow::addChild):
        * rendering/RenderTableRow.h:
        (WebCore::RenderTableRow::virtualChildren):
        (WebCore::RenderTableRow::children):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::RenderTableSection):
        (WebCore::RenderTableSection::destroy):
        (WebCore::RenderTableSection::addChild):
        (WebCore::RenderTableSection::removeChild):
        (WebCore::RenderTableSection::lowestPosition):
        (WebCore::RenderTableSection::rightmostPosition):
        (WebCore::RenderTableSection::leftmostPosition):
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::virtualChildren):
        (WebCore::RenderTableSection::children):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Feb 2009 00:49:11 +0000 (00:49 +0000)]
2009-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Rename layout test result to the correct name.

        * storage/transaction-callback-exception-crash-expected.txt: Renamed from LayoutTests/storage/transaction-callback-exception-crash.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 Feb 2009 00:40:30 +0000 (00:40 +0000)]
2009-02-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        Fix 64-bit build.

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::initGlobalCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-04 Mads Adger <mad@chromium.org>
eric@webkit.org [Thu, 5 Feb 2009 00:40:13 +0000 (00:40 +0000)]
2009-02-04  Mads Adger  <mad@chromium.org>

        Reviewed by Antti Koivisto.

        Bug 23180 Reading freed memory at DocumentLoader::checkForPendingPreloads
        https://bugs.webkit.org/show_bug.cgi?id=23180

        Added a protector for the document potentially holding on the last reference to the loader we are interating with.

        * loader/loader.cpp:
        (WebCore::Loader::Host::didFinishLoading):
        (WebCore::Loader::Host::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40648 268f45cc-cd09-0410-ab3c-d52691b4dbfc