WebKit-https.git
9 years agoPart 1 of 2: <http://webkit.org/b/56337> Enable -Werror on ANGLE
ddkilzer@apple.com [Wed, 4 May 2011 18:00:44 +0000 (18:00 +0000)]
Part 1 of 2: <webkit.org/b/56337> Enable -Werror on ANGLE

Merge ANGLE upstream commits r572, r573, r574, r575.

This unblocks enabling -Werror on ANGLE.  Since all changes are
in the upstream repository, they may be safely overwritten
during the next ANGLE update.

* src/compiler/ConstantUnion.h:
(ConstantUnion::operator==): Added a default case.
* src/compiler/Intermediate.cpp:
(TIntermBinary::promote): Added parentheses.
* src/compiler/ParseHelper.cpp:
(TParseContext::precisionErrorCheck): Added a default case.
* src/compiler/PoolAlloc.cpp:
(TAllocation::checkGuardBlock): Changed '%u' to '%lu' for size_t
variable.  Put for loop inside #ifdef GUARD_BLOCKS/#endif macros
to fix tautological-compare warning.
(TAllocation::checkAllocList): Added newline to end of file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 4 May 2011 17:50:41 +0000 (17:50 +0000)]
2011-05-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
        https://bugs.webkit.org/show_bug.cgi?id=59849

        When attempting to unwind the graphics state stack in the
        CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
        to create a new ImageBuffer.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::existingDrawingContext):
        * html/HTMLCanvasElement.h:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Wed, 4 May 2011 17:47:45 +0000 (17:47 +0000)]
2011-05-04  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Ojan Vafai.

        Send the char events to the select popup if one is showing to fix
        a bug were pressing a letter would not select the matching option.
        https://bugs.webkit.org/show_bug.cgi?id=47769

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::keyEvent):
        (WebKit::WebViewImpl::charEvent):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 4 May 2011 17:46:14 +0000 (17:46 +0000)]
2011-05-04  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Another shot at fixing flakiness under win (also renamed a couple of obsolete things).

        * inspector/elements/shadow-dom-expected.txt:
        * inspector/elements/shadow-dom.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 4 May 2011 17:37:54 +0000 (17:37 +0000)]
2011-05-04  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        [results.html] bucket crashes/timeouts into their own test lists
        https://bugs.webkit.org/show_bug.cgi?id=60181

        Also, don't show the "expected to fail but passed" table for ports
        that don't use an expectation file.

        * fast/harness/resources/results-test.js:
        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Wed, 4 May 2011 17:29:16 +0000 (17:29 +0000)]
2011-05-04  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Add NativeWebWheelEvent class
        https://bugs.webkit.org/show_bug.cgi?id=60182

        This will be needed soon when we start notifying the UI process that a mouse wheel event wasn't handled by WebKit.

        * GNUmakefile.am: Added NativeWebWheelEventGtk.cpp and NativeWebWheelEvent.h.
        * Shared/NativeWebWheelEvent.h: Added.
        (WebKit::NativeWebWheelEvent::nativeEvent): Added.
        * Shared/gtk/NativeWebWheelEventGtk.cpp: Added.
        (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
        * Shared/mac/NativeWebWheelEventMac.mm: Added.
        (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
        * Shared/qt/NativeWebWheelEventQt.cpp: Added.
        (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
        * Shared/win/NativeWebWheelEventWin.cpp: Added.
        (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):Added.
        * WebKit2.pro: Added NativeWebWheelEventQt.cpp and NativeWebWheelEvent.h.
        * WebKit2.xcodeproj/project.pbxproj: Added NativeWebWheelEventMac.mm and NativeWebWheelEvent.h.
        * win/WebKit2.vcproj: Added NativeWebWheelEventWin.cpp and NativeWebWheelEvent.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Wed, 4 May 2011 16:59:29 +0000 (16:59 +0000)]
2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Anders Carlsson.

        ArgumentDecoder should use aligned memory for its internal copy of data
        https://bugs.webkit.org/show_bug.cgi?id=59960

        Since we check for memory alignment when unpacking primitive types from the buffer,
        insure alignment of the base address.
        As uint64_t is the largest type we use in Argument encoder/decoder, use 8 byte alignment.

        * Platform/CoreIPC/ArgumentDecoder.cpp:
        (CoreIPC::ArgumentDecoder::~ArgumentDecoder): free m_alignedBase
        (CoreIPC::roundUpToAlignment): move this up in the source file
        (CoreIPC::ArgumentDecoder::initialize): m_buffer is now guaranteed sizeof(uint64_t) aligned
        * Platform/CoreIPC/ArgumentDecoder.h: add m_alignedBase member which needs to be freed in d'tor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake ShareableBitmap::makeCGImageCopy use a copy-on-write copy on Windows when possible
aroben@apple.com [Wed, 4 May 2011 16:58:01 +0000 (16:58 +0000)]
Make ShareableBitmap::makeCGImageCopy use a copy-on-write copy on Windows when possible

Fixes <http://webkit.org/b/57269> <rdar://problem/9198788> REGRESSION (r82151): Every WKView
paint now makes an extra copy of the painted bits

Reviewed by Anders Carlsson.

* Platform/SharedMemory.h:
* Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::createCopyOnWriteCopy):
Added this new function. Creates a copy-on-write copy of the first |size| bytes of the
original SharedMemory.

* Shared/ShareableBitmap.h: Added createCGImage helper function.

* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::makeCGImageCopy): Don't compile this version of this function on
Windows; we'll provide our own implementation since CGBitmapContextCreateImage isn't smart
enough to make a copy-on-write copy on Windows.
(WebKit::ShareableBitmap::makeCGImage): Moved some code from here...
(WebKit::ShareableBitmap::createCGImage): ...to this new function.

* Shared/cg/win/ShareableBitmapCGWin.cpp: Added.
(WebKit::derefSharedMemory): This function is called when the CGDataProvider is finalized.
All we have to do is deref the SharedMemory that was backing the CGDataProvider.
(WebKit::ShareableBitmap::makeCGImageCopy): Create a copy-on-write copy of the image data
when possible. We use the copy-on-write copy to back this ShareableBitmap from here on out,
and use the original SharedMemory to back the CGImage. This should prevent future
modifications to the ShareableBitmap from affecting the CGImage. If we can't make a
copy-on-write copy, we fall back to just copying the data normally.

* win/WebKit2.vcproj: Added ShareableBitmapCGWin.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLet transparent windowless plugins draw into a graphics context with an alpha channel
aroben@apple.com [Wed, 4 May 2011 16:53:20 +0000 (16:53 +0000)]
Let transparent windowless plugins draw into a graphics context with an alpha channel

Fixes <http://webkit.org/b/57647> <rdar://problem/9168462> Flash plugins with
wmode=transparent have black (instead of transparent) background in WebKit2 on Windows

I had trouble writing a test case for this, so I split that task out into
<http://webkit.org/b/60169>.

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformPaint): Give the graphics context an alpha channel if this
is a transparent windowless plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 4 May 2011 16:28:24 +0000 (16:28 +0000)]
2011-05-04  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Attempt to resolve flakiness on windows.

        * inspector/elements/shadow-dom.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 4 May 2011 15:07:20 +0000 (15:07 +0000)]
2011-05-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: expose shadow DOM in the Elements panel
        https://bugs.webkit.org/show_bug.cgi?id=60160

        Test: inspector/elements/shadow-dom.html

        * dom/Element.cpp:
        (WebCore::Element::ensureShadowRoot):
        (WebCore::Element::removeShadowRoot):
        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        (WebCore::InspectorDOMAgent::isContainerNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        (WebInspector.DOMNode.prototype.inShadowTree):
        (WebInspector.DOMNode.prototype._setShadowRootPayload):
        (WebInspector.DOMNode.prototype._renumber):
        (WebInspector.DOMAgent.prototype._bindNodes):
        (WebInspector.DOMAgent.prototype.querySelectorAll):
        (WebInspector.DOMAgent.prototype._shadowRootUpdated):
        (WebInspector.DOMDispatcher.prototype.searchResults):
        (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype._nodeUpdated):
        (WebInspector.ElementsPanel.prototype._attributesUpdated):
        (WebInspector.ElementsPanel.prototype._nodeRemoved):
        (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
        (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement):
        (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
        (WebInspector.ElementsTreeElement.prototype._updateChildren):
        ():
        * inspector/front-end/inspector.css:
        (#elements-content .dom-shadow-root):
        (.outline-disclosure li .webkit-html-tag.shadow):
        * inspector/front-end/utilities.js:

2011-05-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: expose shadow DOM in the Elements panel
        https://bugs.webkit.org/show_bug.cgi?id=60160

        * http/tests/inspector/elements-test.js:
        (initialize_ElementTest.InspectorTest.nodeWithId.processChildren):
        (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested):
        (initialize_ElementTest.InspectorTest.nodeWithId):
        * inspector/elements/shadow-dom-expected.txt: Added.
        * inspector/elements/shadow-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Wed, 4 May 2011 14:55:42 +0000 (14:55 +0000)]
2011-05-04  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Adam Roben.

        REGRESSION (r85657): webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings failing on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=60164

        Use Array#length to get the number of elements in an array. Array#count
        was added in Ruby 1.8.7, but Leopard have Ruby 1.8.6.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother attempted build fix
aroben@apple.com [Wed, 4 May 2011 14:31:46 +0000 (14:31 +0000)]
Another attempted build fix

* wtf/OwnPtr.h:
(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added a return statement. And made a tweak based on a suggestion from Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Leopard, Qt, and probably others
aroben@apple.com [Wed, 4 May 2011 14:25:22 +0000 (14:25 +0000)]
Try to fix Leopard, Qt, and probably others

* wtf/OwnPtr.h:
(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Try to get the compiler not to instantiate these function templates unnecessarily.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: Adding myself to the committers' list.
ademar.reis@openbossa.org [Wed, 4 May 2011 14:25:00 +0000 (14:25 +0000)]
Unreviewed: Adding myself to the committers' list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisallow equality comparisons between [Pass]OwnPtrs
aroben@apple.com [Wed, 4 May 2011 14:11:50 +0000 (14:11 +0000)]
Disallow equality comparisons between [Pass]OwnPtrs

If you have two OwnPtrs that are equal, you've already lost. (Unless you're doing something
really sneaky, in which case you should stop!)

Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error

Reviewed by Anders Carlsson and Antti Koivisto.

Source/JavaScriptCore:

* wtf/OwnPtr.h:
(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added private equality operators that fail to compile when used. (When not used, the
compiler will skip over them because they are function templates.)

Source/WebCore:

Remove an unnecessary OwnPtr equality check in XSLT code

* dom/Document.cpp:
(WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
we're safe.)

Source/WebKit2:

Remove WebPageProxy::setDrawingArea

It is unused. It also does a useless equality comparison between OwnPtrs; if they are equal,
we've already lost.

* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
Removed setDrawingArea.

(WebKit::WebPageProxy::drawingArea):
(WebKit::WebPageProxy::backForwardList):
Made these functions const while I was at it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Leandro Gracia Gil <leandrogracia@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 13:57:31 +0000 (13:57 +0000)]
2011-05-04  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Tony Gentilcore.

        Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
        https://bugs.webkit.org/show_bug.cgi?id=56922

        Add the basic outlines of the page controller, the per-frame controller and the embedder
        client interface for the Media Stream API. Provide methods to handle the situations
        where a frame is detached from the page or transferred between pages.

        Tests for the Media Stream API will be provided by the bug 56587.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::~Frame):
        (WebCore::Frame::pageDestroyed):
        (WebCore::Frame::transferChildFrameToNewDocument):
        * page/Frame.h:
        (WebCore::Frame::mediaStreamFrameController):
        * page/MediaStreamClient.h: Added.
        (WebCore::MediaStreamClient::~MediaStreamClient):
        * page/MediaStreamController.cpp: Added.
        (WebCore::MediaStreamController::Request::Request):
        (WebCore::MediaStreamController::Request::localId):
        (WebCore::MediaStreamController::Request::frameController):
        (WebCore::MediaStreamController::MediaStreamController):
        (WebCore::MediaStreamController::~MediaStreamController):
        (WebCore::MediaStreamController::unregisterFrameController):
        (WebCore::MediaStreamController::registerRequest):
        * page/MediaStreamController.h: Added.
        * page/MediaStreamFrameController.cpp: Added.
        (WebCore::MediaStreamFrameController::Request::Request):
        (WebCore::MediaStreamFrameController::Request::~Request):
        (WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
        (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
        (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest):
        (WebCore::MediaStreamFrameController::RequestMap::abort):
        (WebCore::MediaStreamFrameController::RequestMap::abortAll):
        (WebCore::MediaStreamFrameController::MediaStreamFrameController):
        (WebCore::MediaStreamFrameController::~MediaStreamFrameController):
        (WebCore::MediaStreamFrameController::securityOrigin):
        (WebCore::MediaStreamFrameController::scriptExecutionContext):
        (WebCore::MediaStreamFrameController::pageController):
        (WebCore::MediaStreamFrameController::enterDetachedState):
        (WebCore::MediaStreamFrameController::disconnectPage):
        (WebCore::MediaStreamFrameController::disconnectFrame):
        (WebCore::MediaStreamFrameController::transferToNewPage):
        * page/MediaStreamFrameController.h: Added.
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::PageClients::PageClients):
        * page/Page.h:
        (WebCore::Page::mediaStreamController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 4 May 2011 13:48:29 +0000 (13:48 +0000)]
2011-05-04  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
        https://bugs.webkit.org/show_bug.cgi?id=60150

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix crashes in QMetaObject::metacall
ossy@webkit.org [Wed, 4 May 2011 13:46:45 +0000 (13:46 +0000)]
[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

* platform/qt/Skipped: Unskip http/tests/websocket/tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Dominic Battre <battre@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 13:36:58 +0000 (13:36 +0000)]
2011-05-04  Dominic Battre  <battre@chromium.org>

        Reviewed by Tony Gentilcore.

        Fix missing header in case SVG is disabled
        https://bugs.webkit.org/show_bug.cgi?id=60153

        * dom/EventDispatcher.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 4 May 2011 13:25:49 +0000 (13:25 +0000)]
2011-05-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Initialize viewport argument in ewk_view.cpp
        https://bugs.webkit.org/show_bug.cgi?id=60147

        viewport computation logic can't be worked correctly because viewport argument
        isn't initialized. So, we need to initialize viewport argument.

        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 4 May 2011 13:18:27 +0000 (13:18 +0000)]
2011-05-04  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip fast/dom/Geolocation/argument-types.html crashing
        on GTK.

        [GTK] fast/dom/Geolocation/argument-types.html flaky crash on 32-bits Debug
        https://bugs.webkit.org/show_bug.cgi?id=60158

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 13:14:22 +0000 (13:14 +0000)]
2011-05-04  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: readyState
        https://bugs.webkit.org/show_bug.cgi?id=60069

        Checks the value of the request.readyState property during and
        after opening a database, setting the version, creating a datastore,
        adding a record, and retrieving a record.

        * storage/indexeddb/mozilla/readyState-expected.txt: Added.
        * storage/indexeddb/mozilla/readyState.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 13:06:49 +0000 (13:06 +0000)]
2011-05-04  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
        https://bugs.webkit.org/show_bug.cgi?id=60006

        No new tests as no functionality added. Simple rename only.

        * css/CSSStyleApplyProperty.cpp:
        Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
        * css/CSSStyleApplyProperty.h:
        Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 4 May 2011 13:03:32 +0000 (13:03 +0000)]
2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Cleanup conditionals in findNextLineBreak
        https://bugs.webkit.org/show_bug.cgi?id=60117

        Simplified conditional statements in findNextLineBreak.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 12:44:15 +0000 (12:44 +0000)]
2011-05-04  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
        https://bugs.webkit.org/show_bug.cgi?id=60114

        No new tests as no functionality changes.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 4 May 2011 12:39:25 +0000 (12:39 +0000)]
2011-05-04  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
        https://bugs.webkit.org/show_bug.cgi?id=60088

        Makes --new-baseline put new baselines into the first entry in the
        baseline search path, including any additional directories passed in via
        --additional-platform-directory.

        Simplifies baseline_path() by making it return the first entry in the
        baseline search path instead of requiring each port to have an
        implementation (should not result in any behavior change).

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Wed, 4 May 2011 12:24:40 +0000 (12:24 +0000)]
2011-05-04  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
        https://bugs.webkit.org/show_bug.cgi?id=59070

        Applications using our API and our autotests subclass QNetworkReply as part of providing a
        custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
        QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
        4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.

        The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
        watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
        indicating that it is finished. When there's no finished signal (synchronous) we set the
        dynamic property once we get the reply.

        This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
        emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
        Connect the finished signal to the new setFinished() slot.

        (WebCore::QNetworkReplyWrapper::synchronousLoad):
        Since we don't get the finished signal for synchronous loads, set the dynamic property
        before processing it.

        (WebCore::QNetworkReplyWrapper::resetConnections):
        Do not reset the connection to setFinished().

        (WebCore::QNetworkReplyWrapper::setFinished):
        Set the dynamic property in the reply.

        (WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
        (WebCore::QNetworkReplyHandler::start):
        Change to use wrapper's isFinished() instead of asking the reply directly.

        * platform/network/qt/QNetworkReplyHandler.h:
        (WebCore::QNetworkReplyWrapper::isFinished):
        Checks the dynamic property of the reply.

        * platform/network/qt/QtMIMETypeSniffer.cpp:
        (QtMIMETypeSniffer::sniff):
        Use the dynamic property to check if the reply is finished.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 4 May 2011 11:58:24 +0000 (11:58 +0000)]
2011-05-04  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline after r85669.

        * platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 4 May 2011 11:51:09 +0000 (11:51 +0000)]
2011-05-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
        https://bugs.webkit.org/show_bug.cgi?id=60080

        No functional change, just moving code.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::createLineBoxesFromBidiRuns):
        (WebCore::RenderBlock::layoutRunsAndFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Wed, 4 May 2011 11:42:51 +0000 (11:42 +0000)]
2011-05-04  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove unused function FontPlatformData::pixelSize()
        https://bugs.webkit.org/show_bug.cgi?id=60156

        * platform/graphics/qt/FontPlatformData.h:
        (WebCore::FontPlatformData::pixelSize): Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 11:35:45 +0000 (11:35 +0000)]
2011-05-04  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Darin Adler.

        Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
        https://bugs.webkit.org/show_bug.cgi?id=60011

        No new tests added as no functionality changed.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Remove reundant check for auto table layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 4 May 2011 11:34:39 +0000 (11:34 +0000)]
2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Gavin Barraclough.

        JITArithmetic.cpp produces a warning on a unused variable.
        https://bugs.webkit.org/show_bug.cgi?id=60060

        Just properly use what we already have converted.

        * jit/JITArithmetic.cpp:
        (JSC::JIT::emitSlow_op_add):
        (JSC::JIT::emitSlow_op_mul):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 4 May 2011 11:08:37 +0000 (11:08 +0000)]
2011-05-04  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Darin Adler.

        Remove double-free checks for bug 56124
        https://bugs.webkit.org/show_bug.cgi?id=60037

        Antti's speculative fix for bug 56124 (r84151) appears to have worked,
        these CRASH() calls are not triggering anymore.

        * css/CSSSelector.h:
        (WebCore::CSSSelector::CSSSelector):
        (WebCore::CSSSelector::~CSSSelector):
        * css/CSSSelectorList.cpp:
        (WebCore::CSSSelectorList::deleteSelectors):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 4 May 2011 10:44:18 +0000 (10:44 +0000)]
2011-05-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix circular dependency in webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=60075

        These functions don't belong in bugzilla.py.  They only exist there
        because they are old.  Really, these functions shouldn't be free
        functions at all, but that's a patch for another day.

        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
        * Scripts/webkitpy/common/checkout/checkout.py:
        * Scripts/webkitpy/common/config/urls.py:
        * Scripts/webkitpy/common/net/bugzilla/__init__.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
        * Scripts/webkitpy/style/checkers/changelog.py:
        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/sheriff.py:
        * Scripts/webkitpy/tool/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Satish Sampath <satish@chromium.org>
satish@chromium.org [Wed, 4 May 2011 09:41:19 +0000 (09:41 +0000)]
2011-05-04  Satish Sampath  <satish@chromium.org>

        Reviewed by Tony Gentilcore.

        Layout the speech input button to the left of outer spin button properly.
        https://bugs.webkit.org/show_bug.cgi?id=59742

        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium/test_expectations.txt:
2011-05-04  Satish Sampath  <satish@chromium.org>

        Reviewed by Tony Gentilcore.

        Layout the speech input button to the left of outer spin button properly.
        https://bugs.webkit.org/show_bug.cgi?id=59742

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 4 May 2011 08:33:12 +0000 (08:33 +0000)]
2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Geoffrey Garen.

        JITPropertyAccess produces a unused but set variable warning in gcc 4.6.0.
        https://bugs.webkit.org/show_bug.cgi?id=60050

        This patch fix a compilation warning. The new warning scenario -Wunused-but-set-variable
        in gcc 4.6.0 is included in -Wall and therefore stops the compilation when warnings are treated
        as errors. The patch introduces a new macro ASSERT_JIT_OFFSET_UNUSED and ASSERT_WITH_MESSAGE_UNUSED
        which copy the idea of ASSERT_UNUSED.

        * jit/JIT.h:
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::emit_op_method_check):
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::emit_op_put_by_id):
        * wtf/Assertions.h:
        (assertWithMessageUnused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 4 May 2011 07:03:38 +0000 (07:03 +0000)]
2011-05-04  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Build fix.

        * bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=60141 Remove reference to libWebKitSystemInte...
psolanki@apple.com [Wed, 4 May 2011 07:00:02 +0000 (07:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60141 Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit

Reviewed by Dan Bernstein.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 4 May 2011 06:45:27 +0000 (06:45 +0000)]
2011-05-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: can't inspect element in an iframe when element originates from non-frame document
        https://bugs.webkit.org/show_bug.cgi?id=60031

        * inspector/elements/elements-inspect-iframe-from-different-domain-expected.txt: Added.
        * inspector/elements/elements-inspect-iframe-from-different-domain.html: Added.
2011-05-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: can't inspect element in an iframe when element originates from non-frame document
        https://bugs.webkit.org/show_bug.cgi?id=60031

        Inspected object type evaluation has moved into native bindings. This way it doesn't
        depend on the current JS context.

        Test: inspector/elements/elements-inspect-iframe-from-different-domain.html

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish
        real undefined values from HTMLAllCollection
        (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed
        value
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
        (WebCore::V8InjectedScriptHost::typeCallback):
        * inspector/InjectedScriptHost.idl:
        * inspector/InjectedScriptSource.js:
        (.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart of WebCore should use CFNetwork-based loader on Mac
psolanki@apple.com [Wed, 4 May 2011 06:36:54 +0000 (06:36 +0000)]
Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Reviewed by Antti Koivisto.

Source/WebCore:

Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
up some warnings and #if USE(CFNETWORK) around code.

* platform/mac/CookieJar.mm:
* platform/network/CookieStorage.h:
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::privateBrowsingCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::notifyCookiesChangedOnMainThread):
(WebCore::notifyCookiesChanged):
* platform/network/cf/CookieStorageCFNet.h:
* platform/network/mac/CookieStorageMac.mm:

Source/WebKit2:

Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one.

* WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Justin Novosad <junov@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 06:25:27 +0000 (06:25 +0000)]
2011-05-03  Justin Novosad  <junov@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Make accelerated 2d canvas enabled by default with skia
        https://bugs.webkit.org/show_bug.cgi?id=59929

        No new tests. Covered by existing layout tests

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        Initialized for accelerated canvas if either the accelerated2dCanvas
        or the legacyAccelerated2dCanvas flags are enabled
        * page/Page.cpp:
        (WebCore::Page::sharedGraphicsContext3D):
        This is where the code goes to implement the functionality for the
        legacy vs current acceleration paths for the 2D canvas. Currently,
        this is a no-op, and always select the legacy path.  This is temporary
        until we are ready to sort the GPU layout tests (rebasline vs. bug)
        * page/Settings.cpp:  Added new flage for legacyAccelerated2dCanvas
        (WebCore::Settings::Settings):
        (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
        * page/Settings.h:
        (WebCore::Settings::legacyAccelerated2dCanvasEnabled):
2011-05-03  Justin Novosad  <junov@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Make accelerated 2d canvas enabled by default with skia
        https://bugs.webkit.org/show_bug.cgi?id=59929
        Added new flag for enabling the legacy accelerated 2d canvas
        The flag is not yet functional with this change.

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setLegacyAccelerated2dCanvasEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 4 May 2011 06:21:53 +0000 (06:21 +0000)]
2011-04-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Seidel.

        Implement FULLSCREEN_API on Windows, Part 4: Enable it
        https://bugs.webkit.org/show_bug.cgi?id=59798

        * wtf/Platform.h: Set ENABLE_FULLSCREEN_API on win.
2011-04-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Seidel.

        Implement FULLSCREEN_API on Windows, Part 4: Enable it
        https://bugs.webkit.org/show_bug.cgi?id=59798

        * WebCore.vcproj/WebCore.vcproj: Add missing full screen related
            files to the project.
2011-04-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Seidel.

        Implement FULLSCREEN_API on Windows, Part 4: Enable it
        https://bugs.webkit.org/show_bug.cgi?id=59798

        * win/tools/vsprops/FeatureDefines.vsprops: Set ENABLE_FULLSCREEN_API to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 4 May 2011 06:08:49 +0000 (06:08 +0000)]
2011-05-03  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Seidel.

        Unused but set variable warning in MacroAssemberX86_64
        https://bugs.webkit.org/show_bug.cgi?id=59482

        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::call):
        (JSC::MacroAssemblerX86_64::tailRecursiveCall):
        (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 05:46:04 +0000 (05:46 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        More 0 to nullptr.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::pluginLoadObserver):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3D::~GraphicsContext3D):
        * src/WebAudioBus.cpp:
        (WebKit::WebAudioBus::release):
        * src/WebBlobData.cpp:
        (WebKit::WebBlobData::reset):
        * src/WebViewImpl.cpp:
        (WebKit::WebView::addUserScript):
        (WebKit::WebView::addUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 05:30:54 +0000 (05:30 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        More places from 0 to nullptr.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::precompileScript):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::create):
        * platform/graphics/gpu/BicubicShader.cpp:
        (WebCore::BicubicShader::create):
        * platform/graphics/gpu/ConvolutionShader.cpp:
        (WebCore::ConvolutionShader::create):
        * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
        (WebCore::LoopBlinnSolidFillShader::create):
        * platform/graphics/gpu/SolidFillShader.cpp:
        (WebCore::SolidFillShader::create):
        * platform/graphics/gpu/TexShader.cpp:
        (WebCore::TexShader::create):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::~PlatformContextSkia):
        * platform/leveldb/LevelDBDatabase.cpp:
        (WebCore::LevelDBDatabase::createIterator):
        * platform/text/LocalizedNumberICU.cpp:
        (WebCore::createFormatterForCurrentLocale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated expected results after updating this test in r85676.
mitz@apple.com [Wed, 4 May 2011 05:07:17 +0000 (05:07 +0000)]
Updated expected results after updating this test in r85676.

* platform/mac/fast/text/ligature-subdivision-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 04:59:21 +0000 (04:59 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Quick suppresion for layout test failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 04:52:13 +0000 (04:52 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Using nullptr instead of 0. This makes visual studio happy.

        * storage/IDBTransactionBackendInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 03:54:14 +0000 (03:54 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage and new baselines.

        * platform/chromium-linux/fast/borders/bidi-012-expected.png: Added.
        * platform/chromium-mac-leopard/fast/borders/bidi-012-expected.png: Added.
        * platform/chromium-mac-leopard/fast/multicol/client-rects-expected.png: Added.
        * platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Removed.
        * platform/chromium-win/fast/borders/bidi-012-expected.png: Added.
        * platform/chromium-win/fast/borders/bidi-012-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/block/float/float-overhangs-root-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 03:36:06 +0000 (03:36 +0000)]
2011-05-03  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
        https://bugs.webkit.org/show_bug.cgi?id=59774

        No new tests required as on new functionality.

        * css/CSSStyleApplyProperty.cpp:
        (WebCore::ApplyPropertyColor::applyValue):
        Added template parameter "inheritColorFromParent = false".
        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        Use template parameter where appropriate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Wed, 4 May 2011 03:15:39 +0000 (03:15 +0000)]
2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Xan Lopez.

        [CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
        https://bugs.webkit.org/show_bug.cgi?id=60041

        Hardcode -Wno-c++0x-compat for the default compiler (if version >=
        4.6.0) until our codebase is ready. This is the same as done for
        autotools.

        * Source/cmake/WebKitHelpers.cmake: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 03:13:51 +0000 (03:13 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage and new baselines.

        * platform/chromium-linux/fast/box-shadow/inset-expected.png:
        * platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
        * platform/chromium-linux/fast/forms/basic-selects-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Added.
        * platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
        * platform/chromium-mac/fast/box-shadow/inset-expected.png: Removed.
        * platform/chromium-mac/fast/forms/basic-selects-expected.png: Removed.
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-expected.png:
        * platform/chromium-win/fast/forms/basic-selects-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Wed, 4 May 2011 03:07:14 +0000 (03:07 +0000)]
2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed, rolling out r85624.
        http://trac.webkit.org/changeset/85624

        The same command is used also for make_names.pl, which breaks
        the build.

        * Source/cmake/OptionsCommon.cmake: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 02:48:50 +0000 (02:48 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change and new baselines.

        * platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png: Added.
        * platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png: Added.
        * platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 02:34:42 +0000 (02:34 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.
mitz@apple.com [Wed, 4 May 2011 02:20:02 +0000 (02:20 +0000)]
<rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.

Reviewed by Darin Adler.

Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
dirty the line when the float is removed, instead of relying on the float always intersecting
its originating line.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::clearFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 02:14:22 +0000 (02:14 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage.

        * platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 4 May 2011 02:08:54 +0000 (02:08 +0000)]
2011-05-03  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by James Robinson.

        [chromium] Go through WebPermissionClient for local storage access.  Also cleanup left over code from previous WebPermissionClient change.
        https://bugs.webkit.org/show_bug.cgi?id=60066

        * public/WebFrameClient.h:
        * public/WebPermissionClient.h:
        (WebKit::WebPermissionClient::allowLocalStorage):
        * src/DatabaseObserver.cpp:
        (WebCore::DatabaseObserver::canEstablishDatabase):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::allowScriptExtension):
        (WebKit::FrameLoaderClientImpl::allowJavaScript):
        (WebKit::FrameLoaderClientImpl::allowPlugins):
        (WebKit::FrameLoaderClientImpl::allowImages):
        (WebKit::FrameLoaderClientImpl::didNotAllowScript):
        (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
        * src/StorageAreaProxy.cpp:
        (WebCore::StorageAreaProxy::setItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 01:59:32 +0000 (01:59 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 01:36:07 +0000 (01:36 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, remove obsolete baselines.

        * platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 4 May 2011 01:32:07 +0000 (01:32 +0000)]
2011-05-03  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make malloc validation useful
        https://bugs.webkit.org/show_bug.cgi?id=57502

        Reland this patch (rolled out in 82905) without
        turning it on by default.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/FastMalloc.cpp:
        (WTF::tryFastMalloc):
        (WTF::fastMalloc):
        (WTF::tryFastCalloc):
        (WTF::fastCalloc):
        (WTF::fastFree):
        (WTF::tryFastRealloc):
        (WTF::fastRealloc):
        (WTF::fastMallocSize):
        (WTF::TCMalloc_PageHeap::isScavengerSuspended):
        (WTF::TCMalloc_PageHeap::scheduleScavenger):
        (WTF::TCMalloc_PageHeap::suspendScavenger):
        (WTF::TCMalloc_PageHeap::signalScavenger):
        (WTF::TCMallocStats::malloc):
        (WTF::TCMallocStats::free):
        (WTF::TCMallocStats::fastCalloc):
        (WTF::TCMallocStats::tryFastCalloc):
        (WTF::TCMallocStats::calloc):
        (WTF::TCMallocStats::fastRealloc):
        (WTF::TCMallocStats::tryFastRealloc):
        (WTF::TCMallocStats::realloc):
        (WTF::TCMallocStats::fastMallocSize):
        * wtf/FastMalloc.h:
        (WTF::Internal::fastMallocValidationHeader):
        (WTF::Internal::fastMallocValidationSuffix):
        (WTF::Internal::fastMallocMatchValidationType):
        (WTF::Internal::setFastMallocMatchValidationType):
        (WTF::fastMallocMatchValidateFree):
        (WTF::fastMallocValidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 4 May 2011 01:28:38 +0000 (01:28 +0000)]
2011-05-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Adam Roben.

        Implement FULLSCREEN_API on Windows, Part 3: WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59845

        Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
        and WebKit2.  WebFullScreenController now uses a Client class to request work on its
        behalf by WebKit and WebKit2.  MediaPlayerPrivateFullscreenWindow now only creates a
        CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
        problems, and because a CALayerHost is overkill if the window is only drawing black to
        its client area.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
        (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create
            m_layerHost in the constructor.
        (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
        (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
        (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is
            not present, fill the window with black in WM_PAINT.
        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
        * platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
        * platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
        * platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h
        (WebCore::FullScreenControllerClient::~FullScreenControllerClient):
2011-05-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Adam Roben.

        Implement FULLSCREEN_API on Windows, Part 3: WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59845

        Implementation of WebFullScreenController has been moved into WebCore, and
        required virutal functions of WebFullScreenControllerClient have been added to
        WebView.  These functions are mostly simple accessors of existing ivars, but
        m_fullScreenElement and its accessors have also been added to WebView.

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::enterFullScreenForElement):
        * WebFullScreenController.cpp: Removed.
        * WebKit.vcproj/WebKit.vcproj:
        * WebView.cpp:
        (WebView::setFullScreenElement): Added accessor.
        (WebVIew::fullScreenElement): Ditto.
        (WebView::fullScreenClientWindow): Ditto.
        (WebView::fullScreenClientParentWindow): Ditto.
        (WebView::fullScreenClientSetParentWindow): Ditto.
        (WebView::fullScreenClientWillEnterFullScreen): Pass through to Document.
        (WebView::fullScreenClientDidEnterFullScreen): Ditto.
        (WebView::fullScreenClientWillExitFullScreen): Ditto.
        (WebView::fullScreenClientDidExitFullScreen): Ditto.
        * WebView.h:
2011-05-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Adam Roben.

        Implement FULLSCREEN_API on Windows, Part 3: WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59845

        Implement a similar full screen mode to WebKit; Re-use the same
        full screen window class used in WebKit in the new WebFullScreenController.
        No animations (yet), so many of the stubs remain unimplemented.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onKeyEvent): Handle VK_ESCAPE and cancel full screen
            mode if caught.
        (WebKit::WebView::fullScreenController): Lazily instantiate m_fullScreenController.
        (WebKit::WebView::fullScreenClientWindow): Added accessor.
        (WebKit::WebView::fullScreenClientParentWindow): Ditto.
        (WebKit::WebView::fullScreenClientSetParentWindow): Ditto.
        (WebKit::WebView::fullScreenClientWillEnterFullScreen): Pass through to WebFullScreenManagerProxy.
        (WebKit::WebView::fullScreenClientDidEnterFullScreen): Ditto.
        (WebKit::WebView::fullScreenClientWillExitFullScreen): Ditto.
        (WebKit::WebView::fullScreenClientDidExitFullScreen): Ditto.
        * UIProcess/win/WebView.h:
        * UIProcess/win/WebFullScreenManagerProxyWin.cpp:
        (WebKit::WebFullScreenManagerProxy::enterFullScreen): Pass through to
            WebFullScreenController.
        (WebKit::WebFullScreenManagerProxy::exitFullScreen): Ditto.
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::WebView):
        (WebKit::WebView::onKeyEvent): Handle the escape key and exit
           full screen mode when detected.
        (WebKit::WebView::fullScreenWindowController): Added.
        * UIProcess/win/WebView.h:
        * WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:
        (WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin):
        (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Host the root
            full screen layer if it gets detached.
        * WebProcess/FullScreen/win/WebFullScreenManagerWin.h:
        * win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 01:14:20 +0000 (01:14 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triaging.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
beidson@apple.com [Wed, 4 May 2011 00:38:54 +0000 (00:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
WK2 Icon Database should provide access to all image representations in the icon.

Reviewed by Sam Weinig.

../WebCore:

Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
(WebCore::Image::getCGImageArray):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getCGImageArray):

../WebKit2:

Expose a CFArrayRef of CGImageRefs as API for CG platforms:
* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryCopyCGImageArrayForURL):
* UIProcess/API/C/cg/WKIconDatabaseCG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Wed, 4 May 2011 00:38:36 +0000 (00:38 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 4 May 2011 00:38:05 +0000 (00:38 +0000)]
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        findNextLineBreak splits InlineIterator into 3 pieces
        https://bugs.webkit.org/show_bug.cgi?id=60082

        Avoid splitting InlineIterator into 3 variables with inter-dependencies.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::fastIncrementInTextNode): Added.
        (WebCore::InlineIterator::previousInSameNode): Added.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dean Jackson <dino@apple.com>
dino@apple.com [Wed, 4 May 2011 00:31:55 +0000 (00:31 +0000)]
2011-05-03  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        Interrupted transitions are not correctly removed
        https://bugs.webkit.org/show_bug.cgi?id=60062

        CompositeAnimation was replacing any existing
        transition as a new one was created. However, it wasn't
        clearing the lists in AnimationControllerPrivate that
        signal when a hardware animation starts. Rather than
        simple removing the existing transition, we now tell
        AnimationControllerPrivate that is has gone.

        Test: transitions/3d/interrupted-transition.html

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateTransitions):

2011-05-03  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        Interrupted transitions are not correctly removed
        https://bugs.webkit.org/show_bug.cgi?id=60062

        * transitions/3d/interrupted-transition-expected.txt: Added.
        * transitions/3d/interrupted-transition.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 4 May 2011 00:23:24 +0000 (00:23 +0000)]
2011-05-03  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        Update rebaseline queue server to handle hierarchical test results
        https://bugs.webkit.org/show_bug.cgi?id=60063

        Update test result parsing done by the rebaseline queue server to handle
        the hierarchical test result output that is generated as of r85254.

        * RebaselineQueueServer/templates/builder-queue-edit.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r84990): Nightly builds don't launch on Windows
bweinstein@apple.com [Tue, 3 May 2011 23:59:54 +0000 (23:59 +0000)]
REGRESSION(r84990): Nightly builds don't launch on Windows
https://bugs.webkit.org/show_bug.cgi?id=60081
<rdar://problem/9358635>

Reviewed by Steve Falkenburg.

Fix nightlies on Window by moving the layered window functions to the bottom
of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.

* Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
* Interfaces/WebKit.idl: Touch to force a rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 23:51:40 +0000 (23:51 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Adding rebaseline for recent changes for mac.

        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 3 May 2011 23:46:06 +0000 (23:46 +0000)]
2011-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        WebKit2 should treat API calls that start/stop loads as user gestures for responsiveness timer
        https://bugs.webkit.org/show_bug.cgi?id=60083

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::reattachToWebProcessWithItem):
        (WebKit::WebPageProxy::tryClose):
        (WebKit::WebPageProxy::loadURL):
        (WebKit::WebPageProxy::loadURLRequest):
        (WebKit::WebPageProxy::loadHTMLString):
        (WebKit::WebPageProxy::loadAlternateHTMLString):
        (WebKit::WebPageProxy::loadPlainTextString):
        (WebKit::WebPageProxy::stopLoading):
        (WebKit::WebPageProxy::reload):
        (WebKit::WebPageProxy::goForward):
        (WebKit::WebPageProxy::goBack):
        (WebKit::WebPageProxy::goToBackForwardItem):
        Start responsiveness timer for load start/stop and close.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::SendStopResponsivenessTimer::SendStopResponsivenessTimer):
        (WebKit::SendStopResponsivenessTimer::~SendStopResponsivenessTimer):
        Add simple RAII class to ensure the StopResponsivenessTimer is called.

        (WebKit::WebPage::tryClose):
        (WebKit::WebPage::loadURLRequest):
        (WebKit::WebPage::loadData):
        (WebKit::WebPage::stopLoading):
        (WebKit::WebPage::reload):
        (WebKit::WebPage::goForward):
        (WebKit::WebPage::goBack):
        (WebKit::WebPage::goToBackForwardItem):
        Sends a message back to the UIProcess to indicate the WebProcess
        is still responsive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Enrica Casucci <enrica@apple.com>
hclam@chromium.org [Tue, 3 May 2011 23:45:45 +0000 (23:45 +0000)]
2011-05-03  Enrica Casucci  <enrica@apple.com>

        Reviewed by Ryosuke Niwa.

        Crash in SpellingCorrectionController::respondToChangedSelection.
        https://bugs.webkit.org/show_bug.cgi?id=60071
        <rdar://problem/9358190>

        * editing/selection/undo-crash-expected.txt: Added.
        * editing/selection/undo-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in SpellingCorrectionController::respondToChangedSelection.
enrica@apple.com [Tue, 3 May 2011 23:40:46 +0000 (23:40 +0000)]
Crash in SpellingCorrectionController::respondToChangedSelection.
https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Creating a Visible position could trigger a layout and there is no
guarantee that the selection is still valid after that.

Tests: editing/selection/undo-crash.html

* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::respondToChangedSelection):

LayoutTests:

* editing/selection/undo-crash-expected.txt: Added.
* editing/selection/undo-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Incorrect line number dumping
ossy@webkit.org [Tue, 3 May 2011 23:35:06 +0000 (23:35 +0000)]
[Qt][WK2] Incorrect line number dumping
https://bugs.webkit.org/show_bug.cgi?id=60074

[Qt][WK2] editing/pasteboard/do-not-copy-body-color.html fails
https://bugs.webkit.org/show_bug.cgi?id=60076

* platform/qt-wk2/Skipped: Add a couple of failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 3 May 2011 23:28:11 +0000 (23:28 +0000)]
2011-05-03  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Refactor computeInlineDirectionPositionsForLine into smaller functions
        https://bugs.webkit.org/show_bug.cgi?id=60072

        Split three functions off from computeInlineDirectionPositionsForLine
        to improve its readability.

        No new tests since this is just moving code around.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::setMarginsForRubyRun):
        (WebCore::setLogicalWidthForTextRun):
        (WebCore::computeExpansionForJustifiedText):
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
ddkilzer@apple.com [Tue, 3 May 2011 23:25:15 +0000 (23:25 +0000)]
<webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking

Reviewed by Antti Koivisto.

Source/WebCore:

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
priority on the request if HTTP pipelining is enabled.
(WebCore::ResourceRequest::doUpdateResourceRequest): Read the
priority from the request if HTTP pipelining is enabled.
(readBooleanPreference): Enable code when compiling with
USE(CFNETWORK).
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
Comment out setting the minimum fast lane priority on Windows
since it's not currently available.

Source/WebKit/win:

* Interfaces/IWebViewPrivate.idl:
(IWebViewPrivate::httpPipeliningEnabled): Added declaration.
(IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.
* WebView.cpp:
(WebView::httpPipeliningEnabled): Added.
(WebView::setHTTPPipeliningEnabled): Added.
* WebView.h:
(WebView::httpPipeliningEnabled): Added declaration.
(WebView::setHTTPPipeliningEnabled): Added declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 23:20:43 +0000 (23:20 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Add a bug number for a recent regression to test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 23:18:20 +0000 (23:18 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Test expectations.

        * platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 May 2011 23:14:31 +0000 (23:14 +0000)]
2011-05-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on

        Conditionalize compositing tiled layer size-constraining logic to older
        OSes.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::constrainedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 23:08:21 +0000 (23:08 +0000)]
2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Allow access keys to be used in shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59979

        Move access key methods and members back to Document from TreeScope.
        Also traverse into shadow trees when building the access key map.

        No new tests. (refactoring)

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::getElementByAccessKey):
        (WebCore::Document::buildAccessKeyMap):
        (WebCore::Document::invalidateAccessKeyMap):
        * dom/Document.h:
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::TreeScope):
        (WebCore::TreeScope::destroyTreeScopeData):
        * dom/TreeScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 23:00:59 +0000 (23:00 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Build fix. Not reviewed.

        Add test expectations for new tests.

        * platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical...
mitz@apple.com [Tue, 3 May 2011 22:33:25 +0000 (22:33 +0000)]
<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
https://bugs.webkit.org/show_bug.cgi?id=60067

Reviewed by Darin Adler.

No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.

* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
results for flipped writing modes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAccount for font metric differences exposed by r85411.
mitz@apple.com [Tue, 3 May 2011 22:30:45 +0000 (22:30 +0000)]
Account for font metric differences exposed by r85411.
Fixes <rdar://problem/9377892> REGRESSION (r85403-r85475): platform/mac/fast/text/ligature-subdivision.html failing

Rubber-stamped by Darin Adler.

* platform/mac/fast/text/script-tests/ligature-subdivision.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 22:29:41 +0000 (22:29 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Update results for fast/harness/results.html.  We shouldn't be
        ignoring these failures :(

        * fast/harness/results-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 22:25:57 +0000 (22:25 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Update chromium linux test results after r85013.  The vertical
        positioning of the glyphs have improved.

        * platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
        * platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
        * platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
        * platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
        * platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
        * platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Tue, 3 May 2011 22:22:49 +0000 (22:22 +0000)]
2011-05-03  Anton Muhin  <antonm@chromium.org>

        Reviewed by Yury Semikhatsky.

        [v8] remove an ASSERT from grouping logic
        https://bugs.webkit.org/show_bug.cgi?id=60024

        This ASSERT was exploratory.  Alas, right now I am aware of no easy way to
        repro it.  Removing for now for greener bots.

        No new tests, only an ASSERT removal.

        * bindings/v8/V8GCController.cpp:
        (WebCore::calculateGroupId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 May 2011 22:20:34 +0000 (22:20 +0000)]
2011-05-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        webkit-patch post-commits HEAD^.. throws an exception
        https://bugs.webkit.org/show_bug.cgi?id=60027

        * Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer...
ossy@webkit.org [Tue, 3 May 2011 22:16:47 +0000 (22:16 +0000)]
[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer-items is not a Qt default build option
https://bugs.webkit.org/show_bug.cgi?id=60068

Patch by Igor Oliveira <igor.oliveira@openbossa.org> on 2011-05-03
Reviewed by Csaba Osztrogon√°c.

Skip data-transfer-items.html test because data-transfer-items
is not a Qt default build option

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Layout tests may timeout if loadFinished receives false
luiz@webkit.org [Tue, 3 May 2011 22:16:31 +0000 (22:16 +0000)]
[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Fixing ChangeLog.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::maybeDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 3 May 2011 22:14:46 +0000 (22:14 +0000)]
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebKit allows selection that crosses the shadow boundary of a readonly input element
        https://bugs.webkit.org/show_bug.cgi?id=60000

        Added pixel tests to ensure WebKit doesn't create a selection that spans across
        the shadow DOM boundary of a readonly input element. Also rebaselined a test that
        previously exhibited this behavior.

        * editing/selection/resources/select-across-readonly-input.js: Added.
        (moveMouseToMiddleOfElement):
        * editing/selection/select-across-readonly-input-1.html: Added.
        * editing/selection/select-across-readonly-input-2.html: Added.
        * editing/selection/select-across-readonly-input-3.html: Added.
        * editing/selection/select-across-readonly-input-4.html: Added.
        * editing/selection/select-across-readonly-input-5.html: Added.
        * platform/mac/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebKit allows selection that crosses the shadow boundary of a readonly input element
        https://bugs.webkit.org/show_bug.cgi?id=60000

        The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
        Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
        in its validation process.

        Tests: editing/selection/select-across-readonly-input-1.html
               editing/selection/select-across-readonly-input-2.html
               editing/selection/select-across-readonly-input-3.html
               editing/selection/select-across-readonly-input-4.html
               editing/selection/select-across-readonly-input-5.html

        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
        (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
        * editing/VisibleSelection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 May 2011 22:11:39 +0000 (22:11 +0000)]
2011-05-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Split out layoutRunsAndFloats from layoutInlineChildren
        https://bugs.webkit.org/show_bug.cgi?id=60052

        No new tests, just moving code here.  There should be
        no change in behavior.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutRunsAndFloats):
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Layout tests may timeout if loadFinished receives false
luiz@webkit.org [Tue, 3 May 2011 22:05:22 +0000 (22:05 +0000)]
[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Reviewed by NOBODY Kenneth Rohde Christiansen.

When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
a response is ignored, like it should be for 204 responses. It is a problem for creating
tests for 204 responses for example.

This change has been tested and it causes no regressions in layout tests.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::maybeDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 22:05:14 +0000 (22:05 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Add expectation to suppress new failure.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 3 May 2011 21:51:33 +0000 (21:51 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, rolling out r85659.
        http://trac.webkit.org/changeset/85659
        https://bugs.webkit.org/show_bug.cgi?id=59977

        restarting isn't working correctly

        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
ossy@webkit.org [Tue, 3 May 2011 21:47:07 +0000 (21:47 +0000)]
[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

* platform/qt-wk2/Skipped: Add failing tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 James Robinson <jamesr@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 21:40:29 +0000 (21:40 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

        * fast/canvas/canvas-resize-after-paint-expected.txt: Added.
        * fast/canvas/canvas-resize-after-paint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key...
darin@apple.com [Tue, 3 May 2011 21:33:23 +0000 (21:33 +0000)]
<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key does)

Reviewed by Sam Weinig.

No test at this time because the WebKit2 eventSender doesn't use this code path.

* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebKeyboardEvent): Copied the code to special-case certain
keys from the corresponding Mac WebKit1 code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 3 May 2011 21:21:27 +0000 (21:21 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

        * fast/canvas/canvas-resize-after-paint-expected.txt: Added.
        * fast/canvas/canvas-resize-after-paint.html: Added.
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.

        Test: fast/canvas/canvas-resize-after-paint.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::reset):
            Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
            DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
        * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
        (WebCore::Canvas2DLayerChromium::setLayerRenderer):
            Add a null check for m_drawingBuffer
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::clear):
            Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
            this is unnecessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 21:21:15 +0000 (21:21 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling the version of chromium to r83922.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85660 268f45cc-cd09-0410-ab3c-d52691b4dbfc