WebKit-https.git
6 years ago[V8] Use implicit references instead of object groups to keep registered MutationObse...
adamk@chromium.org [Wed, 6 Mar 2013 23:56:27 +0000 (23:56 +0000)]
[V8] Use implicit references instead of object groups to keep registered MutationObservers alive
https://bugs.webkit.org/show_bug.cgi?id=111382

Reviewed by Adam Barth.

.:

* ManualTests/mutation-observer-leaks-nodes.html: Added.

Source/WebCore:

Two-phase approach to implicit references: after grouping objects
together, add an implicit reference between each registered node's
group and the MutationObserver's group (which includes wrappers from
all worlds).

Also changed many uses of v8::Value to v8::Object where we know we're
dealing with Object and the V8 API expects them.

Test: ManualTests/mutation-observer-leaks-nodes.html

* bindings/v8/V8GCController.cpp:
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::wrapper):
(ImplicitConnection):
(WebCore::ImplicitReference::ImplicitReference): Wrapper class holding a parent who should have an implicit reference to a child.
(ImplicitReference):
(WebCore::operator<): Needed for std::sort() call to avoid the overhead of using a HashMap
(WebCore::WrapperGrouper::addObjectWrapperToGroup):
(WebCore::WrapperGrouper::addNodeWrapperToGroup):
(WebCore::WrapperGrouper::addImplicitReference):
(WrapperGrouper):
(WebCore::WrapperGrouper::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, roll out http://trac.webkit.org/changeset/144989
fpizlo@apple.com [Wed, 6 Mar 2013 23:14:02 +0000 (23:14 +0000)]
Unreviewed, roll out trac.webkit.org/changeset/144989

I think we want the assertion that I removed.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
* dfg/DFGAbstractState.h:
(AbstractState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
kov@webkit.org [Wed, 6 Mar 2013 23:08:35 +0000 (23:08 +0000)]
Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
such as RenderThemeGtk2.cpp, in debug mode. RenderThemeGtk2.cpp tries to allow usage
of deprecated functions by undefining GTK_DISABLE_DEPRECATED, but it ended up being
redefined because autotoolsconfig.h was included again by headers that came after
config.h.

Reviewed by Martin Robinson.

* Source/autotools/SetupWebKitFeatures.m4: add checks to ensure the
autotoolsconfig.h header is only included once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG::AbstractState::merge() is still more complicated than it needs to be
fpizlo@apple.com [Wed, 6 Mar 2013 23:04:18 +0000 (23:04 +0000)]
DFG::AbstractState::merge() is still more complicated than it needs to be
https://bugs.webkit.org/show_bug.cgi?id=111619

Reviewed by Mark Hahnenberg.

This method is the one place where we still do some minimal amount of liveness pruning, but the style with
which it is written is awkward, and it makes an assertion about variablesAtTail that will be invalidated
by https://bugs.webkit.org/show_bug.cgi?id=111539.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
* dfg/DFGAbstractState.h:
(AbstractState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Modify log method in V8DOMActivityLogger so that the apiName and
commit-queue@webkit.org [Wed, 6 Mar 2013 22:56:30 +0000 (22:56 +0000)]
Source/WebCore: Modify log method in V8DOMActivityLogger so that the apiName and
extraInfo arguments are of type const String& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483

Patch by Ankur Taly <ataly@google.com> on 2013-03-06
Reviewed by Adam Barth.

There are no new tests as there is no change in behavior.

* bindings/v8/V8DOMActivityLogger.h:
(WebCore::V8DOMActivityLogger::log):

Source/WebKit/chromium: Modify log method in WebDOMActivityLogger so that the apiName and
extraInfo arguments are of type const WebString& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483

Patch by Ankur Taly <ataly@google.com> on 2013-03-06
Reviewed by Adam Barth.

There are no new tests as there is no change in behavior.

* public/WebDOMActivityLogger.h: Added property svn:eol-style.
(WebKit::WebDOMActivityLogger::log):
* src/WebDOMActivityLogger.cpp: Added property svn:eol-style.
(WebKit::DOMActivityLoggerContainer::log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
rafaelw@chromium.org [Wed, 6 Mar 2013 22:55:28 +0000 (22:55 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations: compositing/rtl/..

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r186511. Requested by
commit-queue@webkit.org [Wed, 6 Mar 2013 22:52:53 +0000 (22:52 +0000)]
Unreviewed.  Rolled Chromium DEPS to r186511.  Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening of AppleWin port.
roger_fong@apple.com [Wed, 6 Mar 2013 22:44:05 +0000 (22:44 +0000)]
Unreviewed gardening of AppleWin port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
rafaelw@chromium.org [Wed, 6 Mar 2013 22:35:05 +0000 (22:35 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations: svg/css/font-face-crash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of...
commit-queue@webkit.org [Wed, 6 Mar 2013 22:26:51 +0000 (22:26 +0000)]
[GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=111448

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.

Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.

This prevents printing warnings about "Localized string not found" in
the console.

* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
rafaelw@chromium.org [Wed, 6 Mar 2013 22:24:31 +0000 (22:24 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations: svg/custom/foreign-object-skew.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] |m_gestureScrollOnImplThread| is not reset to false following the end...
tdanderson@chromium.org [Wed, 6 Mar 2013 22:24:24 +0000 (22:24 +0000)]
[chromium] |m_gestureScrollOnImplThread| is not reset to false following the end of a fling on the fast path
https://bugs.webkit.org/show_bug.cgi?id=111390

Reviewed by James Robinson.

If there is a fast path gesture scroll which turns into a fling, the member
|m_gestureScrollOnImplThread| is not reset to false once the fling ends. As a
result, GestureScrollUpdate events belonging to a subsequent scroll are always
handled on the fast path, even if they should have been handled on the slow
path instead.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::isGestureScrollOnImplThread):
* tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Selection handles don't drag to expand correctly for RTL languages
nghanavatian@rim.com [Wed, 6 Mar 2013 22:12:27 +0000 (22:12 +0000)]
[BlackBerry] Selection handles don't drag to expand correctly for RTL languages
https://bugs.webkit.org/show_bug.cgi?id=111618

Reviewed by Rob Buis.

PR 303712
If we are using a RTL language, we should ensure that the selection handles are angled the right way.
Further, when expanding the selection, the start and end handles should be appropriately set so that
expansion in the natural direction is possible.

Internally reviewed by Mike Fenton.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse SkTypeface API directly, rather than (soon to be private) SkFontHost
reed@google.com [Wed, 6 Mar 2013 21:38:19 +0000 (21:38 +0000)]
Use SkTypeface API directly, rather than (soon to be private) SkFontHost
https://bugs.webkit.org/show_bug.cgi?id=111588

Reviewed by Stephen White.

No new tests, as existing tests in fast/writing-mode exercise this code.

e.g. japanese-rl-text-with-broken-font.html
     vertical-subst-font-vert-no-dflt.html

* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):
(WebCore::FontPlatformData::openTypeTable):
* platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp:
(WebCore::harfBuzzSkiaGetTable):
(WebCore::HarfBuzzFace::createFace):
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] REGRESSION(r143582): API test EWK2UnitTestBase.ewk_view_contents_size_chan...
commit-queue@webkit.org [Wed, 6 Mar 2013 21:35:22 +0000 (21:35 +0000)]
[EFL][WK2] REGRESSION(r143582): API test EWK2UnitTestBase.ewk_view_contents_size_changed failing
https://bugs.webkit.org/show_bug.cgi?id=110608

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Kenneth Rohde Christiansen.

Test was expecting ContentsSizeChanged signal from ViewClientEfl, but
WebView was not calling client callback if useFixedLayout() is true.

This patch prevent early return if useFixedLayout() is true and call
client callback didChangeContentsSize(), which will emit the signal.

* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsSize):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::didChangeContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Cleanup in multipart FormData sending code.
commit-queue@webkit.org [Wed, 6 Mar 2013 21:25:35 +0000 (21:25 +0000)]
Source/WebCore: Cleanup in multipart FormData sending code.
https://bugs.webkit.org/show_bug.cgi?id=111603

Patch by Victor Costan <costan@gmail.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.

No new tests. This is cleanup.

* platform/network/FormDataBuilder.cpp:
(WebCore::appendQuotedString): use proper types (e.g, size_t instead of
unsigned long)

LayoutTests: Cleanup in multipart FormData tests.
https://bugs.webkit.org/show_bug.cgi?id=111603

Patch by Victor Costan <costan@gmail.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.

* http/tests/local/formdata/resources/send-form-data-common.js:
(sendFormData): JavaScript style cleanup.
(testSendingFormData): JavaScript style, bugfix in checking if
eventSender.beginDragWithFiles needs to be called.
* http/tests/local/formdata/send-form-data-with-filename-expected.txt: Better test description.
* http/tests/local/formdata/send-form-data-with-filename.html: Better test description.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG should not run full CSE after the optimization fixpoint, since it really just...
fpizlo@apple.com [Wed, 6 Mar 2013 21:23:39 +0000 (21:23 +0000)]
DFG should not run full CSE after the optimization fixpoint, since it really just wants store elimination
https://bugs.webkit.org/show_bug.cgi?id=111536

Reviewed by Oliver Hunt and Mark Hahnenberg.

The fixpoint will do aggressive load elimination and pure CSE. There's no need to do it after the fixpoint.
On the other hand, the fixpoint does not profit from doing store elimination (except for SetLocal/Flush).
Previously we had CSE do both, and had it avoid doing some store elimination during the fixpoint by querying
the fixpoint state. This changes CSE to be templated on mode - either NormalCSE or StoreElimination - so
that we explicitly put it into one of those modes depending on where we call it from. The goal is to reduce
time spent doing load elimination after the fixpoint, since that is just wasted cycles.

* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(JSC::DFG::performCSE):
(DFG):
(JSC::DFG::performStoreElimination):
* dfg/DFGCSEPhase.h:
(DFG):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThreaded HTML parser should use 8 bit strings for attributes
tonyg@chromium.org [Wed, 6 Mar 2013 21:21:48 +0000 (21:21 +0000)]
Threaded HTML parser should use 8 bit strings for attributes
https://bugs.webkit.org/show_bug.cgi?id=111610

Reviewed by Eric Seidel.

This fixes a 27% regression in dromaeo_jslibattrjquery on the threaded HTML parser vs. the main thread parser.

No new tests because no new functionality.

* html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake fastmalloc use guardpages
oliver@apple.com [Wed, 6 Mar 2013 21:16:45 +0000 (21:16 +0000)]
Make fastmalloc use guardpages
https://bugs.webkit.org/show_bug.cgi?id=111353

Reviewed by Anders Carlsson.

Add PROT_NONE pages at the beginning and end of every
mmap call made by fastmalloc.

* wtf/TCSystemAlloc.cpp:
(TryMmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
commit-queue@webkit.org [Wed, 6 Mar 2013 21:12:04 +0000 (21:12 +0000)]
[chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
https://bugs.webkit.org/show_bug.cgi?id=111508

Patch by James Robinson <jamesr@chromium.org> on 2013-03-06
Reviewed by Dirk Pranke.

Some tests in webkit_unit_tests, for example WebPageSerializerTest.HTMLNodes, depend on localizable resources
from a pak file. Since unit tests initialize for testing with the same webkit_support functions as layout tests
they end up using DumpRenderTree.pak, but this dependency isn't listed explicitly in the gyp so if you manage to
run webkit_unit_tests without building DumpRenderTree first these tests just crash.

This adds a dependency from webkit_unit_tests to DumpRenderTree_resources so the pak is always built. It's a bit
weird for a gyp file in Source/WebKit/chromium/ to reach into Tools/DumpRenderTree, but I can't think of
anything better.

* WebKitUnitTests.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
commit-queue@webkit.org [Wed, 6 Mar 2013 21:09:34 +0000 (21:09 +0000)]
[WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
https://bugs.webkit.org/show_bug.cgi?id=82866

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-03-06
Reviewed by Martin Robinson.

Source/WebKit2:

Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels. This is similar to r144070.

* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Modified HTML in order to give more space to the media controls.

Tools:

* Scripts/run-gtk-tests:
(TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
it is passing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDashboard cleanup: remove dashboard time logging.
jparent@chromium.org [Wed, 6 Mar 2013 21:00:54 +0000 (21:00 +0000)]
Dashboard cleanup: remove dashboard time logging.
https://bugs.webkit.org/show_bug.cgi?id=111608

Reviewed by Dirk Pranke.

Remove logTime.  It was never accurate, and the dev tools
have better ways to measure this if anyone cares to look
into dashboard perf.

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(processTestRunsForBuilder):
(appendHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
tony@chromium.org [Wed, 6 Mar 2013 20:45:35 +0000 (20:45 +0000)]
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
https://bugs.webkit.org/show_bug.cgi?id=111509

Reviewed by Dirk Pranke.

Add DumpRenderTree.pak to DumpRenderTree.app again.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a flaky crash test expectation to platform/mac/fast/speechsynthesis/speech-synthe...
rniwa@webkit.org [Wed, 6 Mar 2013 20:42:32 +0000 (20:42 +0000)]
Add a flaky crash test expectation to platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html
on Mac per 111613.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
rafaelw@chromium.org [Wed, 6 Mar 2013 20:31:03 +0000 (20:31 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations: animations/animation-delay-changed.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofast/css/hover-update.html is flaky
tony@chromium.org [Wed, 6 Mar 2013 20:24:14 +0000 (20:24 +0000)]
fast/css/hover-update.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111592

Reviewed by Ryosuke Niwa.

Speculative fix for a flaky test. The test sometimes fails on slower machines (mostly debug).
Re-check the results in a loop for up to 200ms to see if the :hover pseudo style applies.

Also force a layout after changing the style, which should also trigger the :hover style.

* fast/css/hover-update.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening: svg/custom/foreign-object-skew.svg
rafaelw@chromium.org [Wed, 6 Mar 2013 20:16:23 +0000 (20:16 +0000)]
Unreviewed gardening: svg/custom/foreign-object-skew.svg

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore cleanup in GIFImageReader
hclam@chromium.org [Wed, 6 Mar 2013 20:09:06 +0000 (20:09 +0000)]
More cleanup in GIFImageReader
https://bugs.webkit.org/show_bug.cgi?id=111137

Reviewed by Stephen White.

Refactor GIFImageReaderReader with the following changes:
+ Separate GIFLZWContext for decoding states.
+ Replace unsigned char* with Vector<unsigned char>

There is no change in code behavior and just refactoring.

No new tests. This is covered by existing GIFImageReaderTest.
I also did a local testing on a 50k image corpus and showed no regression.

* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
* platform/image-decoders/gif/GIFImageDecoder.h:
(GIFImageDecoder):
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::outputRow):
(GIFImageReader::doLZW):
(GIFImageReader::decodeInternal):
(GIFImageReader::prepareLZWContext):
* platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFLZWContext):
(GIFLZWContext::GIFLZWContext):
(GIFImageReader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] Page Overlays: Hook up the layer border/repaint counter setting to the overlay...
timothy_horton@apple.com [Wed, 6 Mar 2013 20:05:33 +0000 (20:05 +0000)]
[wk2] Page Overlays: Hook up the layer border/repaint counter setting to the overlay layer
https://bugs.webkit.org/show_bug.cgi?id=111547
<rdar://problem/13355801>

Reviewed by Simon Fraser.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Keep the page overlay layer's debug border and repaint counter settings updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix typo'd MainThreadScrollingBecauseOfStyleIndictaion
timothy_horton@apple.com [Wed, 6 Mar 2013 19:51:58 +0000 (19:51 +0000)]
Fix typo'd MainThreadScrollingBecauseOfStyleIndictaion
https://bugs.webkit.org/show_bug.cgi?id=111557

Reviewed by Geoff Garen.

* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
* platform/graphics/TiledBacking.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::updateTileCoverageMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJoing the adoptNS/adoptCF/adoptRef club.
ggaren@apple.com [Wed, 6 Mar 2013 19:48:33 +0000 (19:48 +0000)]
Joing the adoptNS/adoptCF/adoptRef club.
https://bugs.webkit.org/show_bug.cgi?id=111467

Reviewed by Darin Adler.

Responding to review comments by Darin Adler.

* NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Tighten up this code
by reducing extraneous local variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPack Structure members better.
akling@apple.com [Wed, 6 Mar 2013 19:43:24 +0000 (19:43 +0000)]
Pack Structure members better.
<http://webkit.org/b/111593>
<rdar://problem/13359200>

Reviewed by Mark Hahnenberg.

Shrink Structure by 8 bytes (now at 104 bytes) on 64-bit by packing the members better.

* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
(Structure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoediting/pasteboard/paste-table-cells.html should be a dump-as-markup test
rniwa@webkit.org [Wed, 6 Mar 2013 19:34:32 +0000 (19:34 +0000)]
editing/pasteboard/paste-table-cells.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=111491

Reviewed by Levi Weintraub.

Converted the test.

* editing/pasteboard/paste-table-cells-expected.txt: Added.
* editing/pasteboard/paste-table-cells.html:
* platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/chromium-mac-lion/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt: Removed.
* platform/chromium/editing/pasteboard/paste-table-cells-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-table-cells-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-table-cells-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-table-cells-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Use the new authenticationChallenge API in WebPage
commit-queue@webkit.org [Wed, 6 Mar 2013 19:31:10 +0000 (19:31 +0000)]
[BlackBerry] Use the new authenticationChallenge API in WebPage
https://bugs.webkit.org/show_bug.cgi?id=111542

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.

Use the new API that expects requestURL and isProxy parameters.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
* Api/WebPageClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed chromium windows rebaselines for r144837.
eae@chromium.org [Wed, 6 Mar 2013 19:29:54 +0000 (19:29 +0000)]
Unreviewed chromium windows rebaselines for r144837.

* platform/chromium-linux/fast/invalid/017-expected.txt: Removed.
* platform/chromium-linux/fast/invalid/018-expected.txt: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/chromium-mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/chromium-win/fast/invalid/017-expected.txt:
* platform/chromium-win/fast/invalid/018-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/mac-lion/tables/mozilla/bugs: Removed.
* platform/mac-lion/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
* platform/mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/mac-wk2/tables/mozilla/bugs: Removed.
* platform/mac-wk2/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
* platform/mac-wk2/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/win-future/tables: Added.
* platform/win-future/tables/mozilla: Added.
* platform/win-future/tables/mozilla/bugs: Added.
* platform/win-future/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
* platform/win-future/tables/mozilla/bugs/bug9024-expected.txt: Added.
* platform/win-future/tables/mozilla_expected_failures: Added.
* platform/win-future/tables/mozilla_expected_failures/bugs: Added.
* platform/win-future/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
* tables/mozilla/bugs/bug113235-2-expected.txt: Replaced.
* tables/mozilla/bugs/bug9024-expected.txt: Replaced.
* tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Replaced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved some dead code in the page cache
ggaren@apple.com [Wed, 6 Mar 2013 19:28:42 +0000 (19:28 +0000)]
Removed some dead code in the page cache
https://bugs.webkit.org/show_bug.cgi?id=111525

Reviewed by Alexey Proskuryakov.

Page cache autorelease doesn't exist anymore, so there's no need to keep
around these olds hacks.

../WebCore:

* WebCore.exp.in:
* history/PageCache.cpp:
(WebCore::PageCache::PageCache):
(WebCore):
* history/PageCache.h:
(PageCache):
* page/Settings.cpp:
(WebCore::Settings::setUsesPageCache):
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
* platform/qt/QtTestSupport.cpp:
(WebKit::QtTestSupport::clearMemoryCaches):

../WebKit/blackberry:

* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::clearMemoryCaches):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::destroy):

../WebKit/efl:

* ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):

../WebKit/mac:

This fixes <rdar://problem/4886761> Fix bizarre WebWindowWatcher policy in WebHistoryItem.

* History/WebHistoryItem.mm:
(+[WebHistoryItem _releaseAllPendingPageCaches]):
* History/WebHistoryItemInternal.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics autoreleasedPageCount]):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] introduce WebUserGestureIndicator
jochen@chromium.org [Wed, 6 Mar 2013 19:08:03 +0000 (19:08 +0000)]
[chromium] introduce WebUserGestureIndicator
https://bugs.webkit.org/show_bug.cgi?id=111531

Reviewed by Adam Barth.

Source/WebKit/chromium:

Currently, an embedder needs to have a WebFrame to check whether a
user gesture is being processed and to consume a user gesture. However,
the user gesture state is independed of a frame.

* WebKit.gyp:
* public/WebFrame.h:
(WebFrame):
* public/WebUserGestureIndicator.h: Added.
(WebKit):
(WebUserGestureIndicator):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::isProcessingUserGesture):
(WebKit::WebFrameImpl::consumeUserGesture):
* src/WebUserGestureIndicator.cpp: Added.
(WebKit):
(WebKit::WebUserGestureIndicator::isProcessingUserGesture):
(WebKit::WebUserGestureIndicator::consumeUserGesture):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r144924.
rafaelw@chromium.org [Wed, 6 Mar 2013 19:05:03 +0000 (19:05 +0000)]
Unreviewed, rolling out r144924.
http://trac.webkit.org/changeset/144924
https://bugs.webkit.org/show_bug.cgi?id=109908

caused multiple crashes in inspector/debugger tests

Source/WebCore:

* bindings/js/JSInjectedScriptHostCustom.cpp:
* bindings/js/ScriptObject.h:
* bindings/v8/ScriptObject.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
* inspector/InjectedScriptHost.h:
(WebCore):
(InjectedScriptHost):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
* inspector/InjectedScriptManager.h:
(InjectedScriptManager):
* inspector/InjectedScriptSource.js:
(.):

LayoutTests:

* inspector-protocol/persistent-id-expected.txt: Removed.
* inspector-protocol/persistent-id.html: Removed.
* inspector/console/command-line-api-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce new message sources for logging.
commit-queue@webkit.org [Wed, 6 Mar 2013 18:55:52 +0000 (18:55 +0000)]
Introduce new message sources for logging.
https://bugs.webkit.org/show_bug.cgi?id=110968

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.

Source/WebCore:

Added SecurityMessageSource, RenderingMessageSource, StorageMessageSource, AppCacheMessageSource, CSSMessageSource.
Changed some logging lines to contain more descriptive message source.

* Modules/webdatabase/DatabaseBase.cpp:
(WebCore::DatabaseBase::logErrorMessage):
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::logErrorMessage):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::fail):
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
* css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::notifyFinished):
* dom/ViewportArguments.cpp:
(WebCore::reportViewportWarning):
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
* html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
* inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
* inspector/Inspector.json:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::createWindow):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived):
* loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::logWarning):
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
* page/Console.cpp:
(WebCore::printMessageSourceAndLevelPrefix):
* page/ConsoleTypes.h:
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::logToConsole):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
* page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
* svg/SVGDocumentExtensions.cpp:
(WebCore::reportMessage):

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.mm:
* WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSVG pattern to pattern reference does not work if first pattern has a child node
fmalita@chromium.org [Wed, 6 Mar 2013 18:51:10 +0000 (18:51 +0000)]
SVG pattern to pattern reference does not work if first pattern has a child node
https://bugs.webkit.org/show_bug.cgi?id=111586

Reviewed by Philip Rogers.

Source/WebCore:

SVGPatternElement::collectPatternAttributes should test for child elements, not child nodes.

Tests: svg/custom/pattern-reference-expected.svg
       svg/custom/pattern-reference.svg

* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):

LayoutTests:

* svg/custom/pattern-reference-expected.svg: Added.
* svg/custom/pattern-reference.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Remove the contents of WebVideoFrame class
danakj@chromium.org [Wed, 6 Mar 2013 18:46:20 +0000 (18:46 +0000)]
[chromium] Remove the contents of WebVideoFrame class
https://bugs.webkit.org/show_bug.cgi?id=106037

Reviewed by James Robinson.

This class becomes an empty base class now, used only for the API
boundary.

* chromium/public/WebVideoFrame.h:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Track sandbox extensions for blobs in NetworkProcess
ap@apple.com [Wed, 6 Mar 2013 18:37:32 +0000 (18:37 +0000)]
    Track sandbox extensions for blobs in NetworkProcess
        https://bugs.webkit.org/show_bug.cgi?id=111484

        Reviewed by Sam Weinig.

        * WebKit2.xcodeproj/project.pbxproj:
        * NetworkProcess/FileAPI: Added.
        * NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: Added.
        * NetworkProcess/FileAPI/NetworkBlobRegistry.h: Added.
        Added a registry that wraps normal in-process "BlobRegistryImpl", and also tracks
        sandbox extensions for blobs. It will also track process connections, so that
        blobs could be removed when a process crashes.

        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
        (WebKit::NetworkConnectionToWebProcess::registerBlobURL):
        (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL):
        (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):
        Use NetworkBlobRegistry.

        * NetworkProcess/SchedulableLoader.h:
        * NetworkProcess/SchedulableLoader.cpp:
        (WebKit::SchedulableLoader::SchedulableLoader): Add extensions for blobs, both in
        request URL and in request data.
        (WebKit::SchedulableLoader::consumeSandboxExtensions): Request may now have multiple
        extensions.
        (WebKit::SchedulableLoader::invalidateSandboxExtensions): Ditto.

        * Shared/FileAPI/BlobRegistrationData.cpp: Fixed extension creation - actually
        store the result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a flaky failure expectation to fast/css/hover-update.html on Mac per bug 111592.
rniwa@webkit.org [Wed, 6 Mar 2013 18:20:17 +0000 (18:20 +0000)]
Add a flaky failure expectation to fast/css/hover-update.html on Mac per bug 111592.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLink the webkit_tests to XRENDER_LIBS.
commit-queue@webkit.org [Wed, 6 Mar 2013 18:11:24 +0000 (18:11 +0000)]
Link the webkit_tests to XRENDER_LIBS.
This solves the linking failure when building against gtk2 like:
usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
Source/WebCore/platform/gtk/Programs_unittests_testcopyandpaste-GtkVersioning.o:
undefined reference to symbol 'XFree'
/usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
note: 'XFree' is defined in DSO /usr/lib/libX11.so.6 so try adding it
to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation

https://bugs.webkit.org/show_bug.cgi?id=111572

Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-06
Reviewed by Gustavo Noronha Silva.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, fix Windows build after r144910.
akling@apple.com [Wed, 6 Mar 2013 18:10:38 +0000 (18:10 +0000)]
Unreviewed, fix Windows build after r144910.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r186371. Requested by
commit-queue@webkit.org [Wed, 6 Mar 2013 18:05:29 +0000 (18:05 +0000)]
Unreviewed.  Rolled Chromium DEPS to r186371.  Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agosheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
commit-queue@webkit.org [Wed, 6 Mar 2013 17:53:30 +0000 (17:53 +0000)]
sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
https://bugs.webkit.org/show_bug.cgi?id=73482

Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-06
Reviewed by Ryosuke Niwa.

Added input checking to the UpdateChromiumDEPS step.
Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.

* Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
(RollChromiumDEPS):
(RollChromiumDEPS._parse_args):
(RollChromiumDEPS.execute):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
(IRCCommandTest.test_roll_chromium_deps):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
(IRCBotTest.test_roll_chromium_deps_to_lkgr):
* Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
* Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
(UpdateChromiumDEPS._fetch_last_known_good_revision):
(UpdateChromiumDEPS):
(UpdateChromiumDEPS._parse_revision_number):
(UpdateChromiumDEPS._validate_revisions):
(UpdateChromiumDEPS.run):
* Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
(UpdateChromiumDEPSTest):
(UpdateChromiumDEPSTest.test_parse_revision_number):
* Scripts/webkitpy/tool/commands/roll.py: Updated help text.
(RollChromiumDEPS):
(PostChromiumDEPSRoll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG should not check if nodes are shouldGenerate prior to DCE
fpizlo@apple.com [Wed, 6 Mar 2013 17:41:40 +0000 (17:41 +0000)]
DFG should not check if nodes are shouldGenerate prior to DCE
https://bugs.webkit.org/show_bug.cgi?id=111520

Reviewed by Geoffrey Garen.

All nodes are live before DCE. We don't need to check that they aren't, because they
definitely will be.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(JSC::DFG::CSEPhase::constantCSE):
(JSC::DFG::CSEPhase::weakConstantCSE):
(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::globalVarWatchpointElimination):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix unused parameter warnings in ARM assembler
ossy@webkit.org [Wed, 6 Mar 2013 17:39:37 +0000 (17:39 +0000)]
Fix unused parameter warnings in ARM assembler
https://bugs.webkit.org/show_bug.cgi?id=111433

Reviewed by Kentaro Hara.

* assembler/ARMAssembler.h: Remove unreachable revertJump() after r143346.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::moveIntsToDouble): Remove unused scratch parameter instead of UNUSED_PARAM.
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32): Remove unused fpTemp parameter.
(JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranchPtrWithPatch): Remove unused parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Added new baseline after r144837.
kadam@inf.u-szeged.hu [Wed, 6 Mar 2013 17:32:40 +0000 (17:32 +0000)]
[Qt] Unreviewed gardening. Added new baseline after r144837.

* platform/qt/fast/invalid/017-expected.txt:
* platform/qt/fast/invalid/018-expected.txt:
* platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[soup] session cookies are not correctly reported in getRawCookies()
ch.dumez@sisa.samsung.com [Wed, 6 Mar 2013 17:25:25 +0000 (17:25 +0000)]
[soup] session cookies are not correctly reported in getRawCookies()
https://bugs.webkit.org/show_bug.cgi?id=111584

Reviewed by Martin Robinson.

As per libsoup documentation, SoupCookie->expires is NULL for session cookies.
However, the soup implementation for getRawCookies() does not check for NULL
case before passing the value to soup_date_to_time_t(), which leads to run time
warnings.

We should also pass true for WebCore::Cookie's session argument if
SoupCookie->expires is NULL. The current implementation reports the cookie as a
session one if soup_cookie_jar_is_persistent(jar) returns true, which is
inaccurate.

No new tests, no behavior change for layout tests as Web Inspector currently
ignores the "session" member and uses expires/max-age instead to deduce it.

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r111639): delayed animation start can be postponed
commit-queue@webkit.org [Wed, 6 Mar 2013 17:14:55 +0000 (17:14 +0000)]
REGRESSION(r111639): delayed animation start can be postponed
https://bugs.webkit.org/show_bug.cgi?id=108582

Source/WebCore:

Query the animation timer directly for the time it will next fire rather than
trying to cache the interval. Previous approach was incorrect -- as time advanced
it was possible for the interval to jump beyond the next service time.

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-03-06
Reviewed by Darin Adler.

Test: animations/animation-delay-changed.html

* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
* page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate): Remove m_previousTimeToNextService

LayoutTests:

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-03-06
Reviewed by Darin Adler.

* animations/animation-delay-changed-expected.txt: Added.
* animations/animation-delay-changed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [ACE] show execution line in Ace editor
commit-queue@webkit.org [Wed, 6 Mar 2013 16:51:47 +0000 (16:51 +0000)]
Web Inspector: [ACE] show execution line in Ace editor
https://bugs.webkit.org/show_bug.cgi?id=111575

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.

Highlight execution line by the means of Ace full line markers.

No new tests.

* inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor.prototype.setExecutionLine):
(WebInspector.AceTextEditor.prototype.clearExecutionLine):
(WebInspector.AceTextEditor.prototype.setSelection):
* inspector/front-end/ace/acedevtools.css:
(.ace-editor-container):
(.webkit-execution-line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
zandobersek@gmail.com [Wed, 6 Mar 2013 16:28:48 +0000 (16:28 +0000)]
Unreviewed gardening.

* platform/efl/TestExpectations: Adjusting the expectation for fast/workers/shared-worker-load-error.html.
* platform/gtk/TestExpectations: Add an expectation for a test added in r144824.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: fix closure compiler warnings in the profiler code
yurys@chromium.org [Wed, 6 Mar 2013 16:28:17 +0000 (16:28 +0000)]
Web Inspector: fix closure compiler warnings in the profiler code
https://bugs.webkit.org/show_bug.cgi?id=111581

Reviewed by Vsevolod Vlasov.

Added missing annotations. Replaced NativeProfileLauncherView with
ProfileLauncherView.

* inspector/InjectedScriptExterns.js:
(InjectedScriptHost.prototype.objectId):
(InjectedScriptHost.prototype.releaseObjectId):
* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.prototype._forEachNode):
* inspector/front-end/ProfileLauncherView.js:
* inspector/front-end/ProfilesPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Pass String::StrictConversion instead of true to String::utf8()
commit-queue@webkit.org [Wed, 6 Mar 2013 16:00:00 +0000 (16:00 +0000)]
[BlackBerry] Pass String::StrictConversion instead of true to String::utf8()
https://bugs.webkit.org/show_bug.cgi?id=111546

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.

String::utf8() API changed in r134173.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
jchaffraix@webkit.org [Wed, 6 Mar 2013 15:48:25 +0000 (15:48 +0000)]
Remove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=111505

Unreviewed minimal build fix.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Put CSSPropertyWebkitWrap under the proper if-guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed follow up to r144928: front-end closure compilation fixes.
vsevik@chromium.org [Wed, 6 Mar 2013 15:45:24 +0000 (15:45 +0000)]
Unreviewed follow up to r144928: front-end closure compilation fixes.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.JavaScriptOutlineDialog.prototype.dispose):
(WebInspector.OpenResourceDialog.prototype.dispose):
* inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Update open resource dialog when new uiSourceCodes are loaded.
vsevik@chromium.org [Wed, 6 Mar 2013 15:34:51 +0000 (15:34 +0000)]
Web Inspector: Update open resource dialog when new uiSourceCodes are loaded.
https://bugs.webkit.org/show_bug.cgi?id=111327

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.willHide):
(WebInspector.FilteredItemSelectionDialog.prototype._itemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._updateAfterItemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.SelectionDialogContentProvider.prototype.dispose):
(WebInspector.JavaScriptOutlineDialog.prototype._didBuildOutlineChunk):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype._filterUISourceCode):
(WebInspector.OpenResourceDialog.prototype._uiSourceCodeAdded):
(WebInspector.OpenResourceDialog.prototype.dispose):
* inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):

LayoutTests:

* inspector/filtered-item-selection-dialog-filtering.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Move sidebar-specific styles to a separate file.
commit-queue@webkit.org [Wed, 6 Mar 2013 15:23:11 +0000 (15:23 +0000)]
Web Inspector: Move sidebar-specific styles to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=111173

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.

* WebCore.gypi:
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane):
* inspector/front-end/NativeBreakpointsSidebarPane.js:
(WebInspector.NativeBreakpointsSidebarPane):
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarTabbedPane):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/breakpointsList.css: Added.
(.sidebar-pane > .body .breakpoint-condition):
(#breakpoint-condition-input):
(ol.breakpoint-list):
(.breakpoints-list-deactivated):
(.breakpoint-list li):
(.breakpoint-list li:hover):
(.breakpoint-list .checkbox-elem):
(.breakpoint-list .source-text):
(.sidebar-pane .breakpoint-hit):
(li.breakpoint-hit .breakpoint-hit-marker):
(.event-listener-breakpoints .event-category):
(.event-listener-breakpoints.properties-tree .children li):
(.event-listener-breakpoints .checkbox-elem):
* inspector/front-end/elementsPanel.css:
(.panel.elements .sidebar-pane-toolbar > select):
(.panel.elements .sidebar-pane-toolbar > select:hover):
(.panel.elements .sidebar-pane-toolbar > select:active):
(.panel.elements .sidebar-pane-toolbar > select.select-settings):
(.panel.elements .sidebar-pane-toolbar > select.select-filter):
(.panel.elements .sidebar-pane-toolbar > select > option, .panel.elements .sidebar-pane-toolbar > select > hr):
* inspector/front-end/inspector.css:
(.event-bar .event-properties):
* inspector/front-end/scriptsPanel.css:
(.workers-list > li):
(a.worker-item):
(a.worker-item:hover):
* inspector/front-end/sidebarPane.css: Added.
(.sidebar-pane):
(.sidebar-pane > .body):
(.sidebar-pane > .body .info):
(.sidebar-pane > .body .placard + .info):
(.sidebar-pane.visible > .body):
(.sidebar-pane .section .properties):
(.sidebar-tabbed-pane .tabbed-pane-header):
(.sidebar-pane-stack > .sidebar-pane.visible:nth-last-of-type(1)):
(.sidebar-pane-title):
(.sidebar-pane-title + .sidebar-pane-title, .pane:not(.visible) + .sidebar-pane-title, .sidebar-pane-title:first-of-type):
(.sidebar-pane-title:active):
(.sidebar-pane-title::before):
(.sidebar-pane-title.expanded::before):
(.sidebar-pane-toolbar):
(.sidebar-pane-toolbar > *):
(.sidebar-pane-toolbar > .pane-title-button):
(.sidebar-pane-toolbar > .pane-title-button:hover):
(.sidebar-pane-toolbar > .pane-title-button:active, .sidebar-pane-toolbar > .pane-title-button.toggled):
(.sidebar-pane-toolbar > .pane-title-button.add):
(.sidebar-pane-toolbar > .pane-title-button.element-state):
(.sidebar-pane-toolbar > .pane-title-button.refresh):
(.sidebar-pane-subtitle):
(body.platform-windows .sidebar-pane-subtitle):
(.sidebar-pane-subtitle input, .section .header input[type=checkbox]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: test that "importScript" is used only in module heads.
commit-queue@webkit.org [Wed, 6 Mar 2013 15:20:58 +0000 (15:20 +0000)]
Web Inspector: test that "importScript" is used only in module heads.
https://bugs.webkit.org/show_bug.cgi?id=111548

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.

Test that output file after all inlines does not have any 'importScript(s)' statements.

* scripts/inline_js_imports.py:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Combine style-related panes into a single tab when Elements panel...
commit-queue@webkit.org [Wed, 6 Mar 2013 15:20:33 +0000 (15:20 +0000)]
Web Inspector: Combine style-related panes into a single tab when Elements panel is split horizontally.
https://bugs.webkit.org/show_bug.cgi?id=111550
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.

Grouping the Elements sidebar panes into two tabbed panes proved to be
confusing and inconvenient. Put all the Elements sidebar panes into a single tabbed pane.
Combined Styles, Computed Style and Metrics into a single pane.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._splitVertically):
(WebInspector.ElementsPanel.prototype.addExtensionSidebarPane):
* inspector/front-end/elementsPanel.css:
(.sidebar-pane.composite):
(.sidebar-pane.composite > .body):
(.sidebar-pane.composite .metrics):
(.sidebar-pane.composite .sidebar-pane-toolbar):
(.sidebar-pane.composite .sidebar-pane-toolbar > .sidebar-pane-subtitle):
(.sidebar-pane.composite .styles-section.read-only):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: support stable remote object ids
yurys@chromium.org [Wed, 6 Mar 2013 15:18:54 +0000 (15:18 +0000)]
Web Inspector: support stable remote object ids
https://bugs.webkit.org/show_bug.cgi?id=109908

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced a map from javascript object to its id. It guarantees
that object is assined id only once (unless it is explicitely
released). The map is per execution context and is stored in
InjectedScriptManager.

Test: inspector-protocol/persistent-id.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::objectId):
(WebCore):
(WebCore::JSInjectedScriptHost::releaseObjectId):
* bindings/js/ScriptObject.h:
(WTF):
(WTF::ScriptObjectHash::hash):
(WTF::ScriptObjectHash::equal):
(ScriptObjectHash):
* bindings/v8/ScriptObject.h:
(WTF):
(WTF::ScriptObjectHash::hash):
(WTF::ScriptObjectHash::equal):
(ScriptObjectHash):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::objectIdMethodCustom):
(WebCore):
(WebCore::V8InjectedScriptHost::releaseObjectIdMethodCustom):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::objectId):
(WebCore):
(WebCore::InjectedScriptHost::releaseObjectId):
* inspector/InjectedScriptHost.h:
(WebCore):
(InjectedScriptHost):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptManager.cpp:
(InjectedScriptManager::ObjectIdMap):
(WebCore::InjectedScriptManager::ObjectIdMap::ObjectIdMap):
(WebCore::InjectedScriptManager::ObjectIdMap::objectId):
(WebCore::InjectedScriptManager::ObjectIdMap::releaseObjectId):
(WebCore):
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::objectId):
(WebCore::InjectedScriptManager::releaseObjectId):
* inspector/InjectedScriptManager.h:
(InjectedScriptManager):
* inspector/InjectedScriptSource.js:
(.):

LayoutTests:

Test that same object will have same id if requested several times.

* inspector-protocol/persistent-id-expected.txt: Added.
* inspector-protocol/persistent-id.html: Added.
* inspector/console/command-line-api-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Use CachedResource::resourceBuffer() instead of CachedResource::data()
commit-queue@webkit.org [Wed, 6 Mar 2013 15:09:57 +0000 (15:09 +0000)]
[BlackBerry] Use CachedResource::resourceBuffer() instead of CachedResource::data()
https://bugs.webkit.org/show_bug.cgi?id=111555

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.

CachedResource::data() was renamed to
CachedResource::resourceBuffer() in r130947.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Remove some unneeded header includes
commit-queue@webkit.org [Wed, 6 Mar 2013 15:07:19 +0000 (15:07 +0000)]
[BlackBerry] Remove some unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=111545

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.

* WebCoreSupport/CredentialTransformData.cpp:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Use hasTagName instead of hasLocalName in CredentialTransformData
commit-queue@webkit.org [Wed, 6 Mar 2013 15:05:54 +0000 (15:05 +0000)]
[BlackBerry] Use hasTagName instead of hasLocalName in CredentialTransformData
https://bugs.webkit.org/show_bug.cgi?id=111544

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.

hasLocalName() expects an AtomicString, but we are passing a
HTMLName which is a QualifiedName.

* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields): Use
hasTagName() instead of hasLocalName().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
commit-queue@webkit.org [Wed, 6 Mar 2013 14:47:10 +0000 (14:47 +0000)]
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=111571

Gardening; added accessibility failure tests.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-06

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r144617): Wrong usage of overwritten variable in toDOMWindow (V8Binding...
commit-queue@webkit.org [Wed, 6 Mar 2013 14:30:44 +0000 (14:30 +0000)]
REGRESSION(r144617): Wrong usage of overwritten variable in toDOMWindow (V8Binding.cpp)
https://bugs.webkit.org/show_bug.cgi?id=111565

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-06
Reviewed by Jochen Eisinger.

In toDOMWindow, the variable "global" was first nuked, and then used again. This
change was introduced in r144617.

No new tests (no functional changes).

* bindings/v8/V8Binding.cpp:
(WebCore::toDOMWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Illegal narrowing in tst_qwebhistory
allan.jensen@digia.com [Wed, 6 Mar 2013 14:29:23 +0000 (14:29 +0000)]
[Qt] Illegal narrowing in tst_qwebhistory
https://bugs.webkit.org/show_bug.cgi?id=111562

Reviewed by Jocelyn Turcotte.

The bytearray in tst_QWebHistory::restoreIncompatibleVersion1 has integer
values higher than 127 assigned into an array of signed chars. This causes
compiler errors in C++11 since it assigns constants (>127) that does not
fit the destination (-128 to 127)

* tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::restoreIncompatibleVersion1):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTypo in inline function in ByteOrder.h
commit-queue@webkit.org [Wed, 6 Mar 2013 14:16:30 +0000 (14:16 +0000)]
Typo in inline function in ByteOrder.h
https://bugs.webkit.org/show_bug.cgi?id=111473

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-03-06
Reviewed by Benjamin Poulain.

* wtf/ByteOrder.h:
(ntohs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: use regular eval instead of injectScript for front-end extension API
yurys@chromium.org [Wed, 6 Mar 2013 14:07:36 +0000 (14:07 +0000)]
Web Inspector: use regular eval instead of injectScript for front-end extension API
https://bugs.webkit.org/show_bug.cgi?id=111529

Reviewed by Pavel Feldman.

Removed InjectedScriptManager::injectScript and replaced all of it calls
except the actual script injection with ScriptController::executeScript.

* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptFor):
* inspector/InjectedScriptManager.h:
(InjectedScriptManager):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged.get if):
* inspector/front-end/ExtensionAPI.js:
(buildExtensionAPIInjectedScript):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][MiniBrowser] Touch mocking broken for chained getures
abecsi@webkit.org [Wed, 6 Mar 2013 14:06:40 +0000 (14:06 +0000)]
[Qt][MiniBrowser] Touch mocking broken for chained getures
https://bugs.webkit.org/show_bug.cgi?id=111430

Reviewed by Jocelyn Turcotte.

Make it possible again to use touch mocking to test gesture chains
like pan->pinch->pan->pinch without lifting the primary "finger".
For this to work we need to track the pressed mouse buttons and
only synthesize touch release events when the ctrl key is released
if no mouse button is pressed. Else the pressed mouse button(s)
should result in a stationary touch point in a touch update event.
Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
to check for the state of the ctrl key modifier instead of getting
it from the mouse events.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Fix the Mac build after r144787
abecsi@webkit.org [Wed, 6 Mar 2013 14:02:38 +0000 (14:02 +0000)]
[Qt][WK2] Fix the Mac build after r144787
https://bugs.webkit.org/show_bug.cgi?id=111569

Reviewed by Csaba Osztrogonác.

Use uint_64 explicitly instead of size_t.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Do not disable C++0x
allan.jensen@digia.com [Wed, 6 Mar 2013 14:02:13 +0000 (14:02 +0000)]
[Qt] Do not disable C++0x
https://bugs.webkit.org/show_bug.cgi?id=111559

Reviewed by Kenneth Rohde Christiansen.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
jchaffraix@webkit.org [Wed, 6 Mar 2013 13:31:17 +0000 (13:31 +0000)]
Remove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=111505

Reviewed by Alexis Menard.

The CSS parsing code expands shorthands (with the exception of 'font') to their longhands.
This means that all the code in StyleResolver / StyleBuilder to handle shorthands is basically
dead and shouldn't be there. The reason for it to be is that people didn't know about shorthands
expansion and thus copied existing code.

This change addresses both issues by removing the code and adding ASSERTs that should prevent people
from adding more dead code.

Refactoring, covered by existing tests.

* css/StylePropertyShorthand.h: Added isExpandedShorthand.
* css/StylePropertyShorthand.cpp:
(WebCore::isExpandedShorthand):
Added this function that ignores 'font' as it is the only shorthand that is no consistently expanded
to account for system fonts.

* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
Removed the shorthands.

* css/StyleBuilder.h:
(WebCore::StyleBuilder::setPropertyHandler):
Added ASSERTs that people don't add shorthand handling.

* css/StyleResolver.cpp:
(WebCore::isValidVisitedLinkProperty):
Removed all the shorthands (shouldn't be reachable unless the ASSERT in applyProperty
triggers).

(WebCore::StyleResolver::applyProperty):
Removed all shorthand handling code, moved the shorthands together and added some ASSERT
to ensure people don't abuse the code and re-add some of it back by mistake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename WebCore/editing/visible_units.* to VisibleUnits.*
tkent@chromium.org [Wed, 6 Mar 2013 13:00:14 +0000 (13:00 +0000)]
Rename WebCore/editing/visible_units.* to VisibleUnits.*
https://bugs.webkit.org/show_bug.cgi?id=111426

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests. Just a refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityNodeObject.cpp:
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* dom/Position.cpp:
* dom/Range.cpp:
* editing/AlternativeTextController.cpp:
* editing/ApplyBlockElementCommand.cpp:
* editing/ApplyStyleCommand.cpp:
* editing/CompositeEditCommand.cpp:
* editing/DeleteSelectionCommand.cpp:
* editing/EditingAllInOne.cpp:
* editing/EditingStyle.cpp:
* editing/Editor.cpp:
* editing/FormatBlockCommand.cpp:
* editing/FrameSelection.cpp:
* editing/IndentOutdentCommand.cpp:
* editing/InsertLineBreakCommand.cpp:
* editing/InsertListCommand.cpp:
* editing/InsertParagraphSeparatorCommand.cpp:
* editing/InsertTextCommand.cpp:
* editing/ReplaceSelectionCommand.cpp:
* editing/SurroundingText.cpp:
* editing/TextCheckingHelper.cpp:
* editing/TextIterator.cpp:
* editing/TypingCommand.cpp:
* editing/VisiblePosition.cpp:
* editing/VisibleSelection.cpp:
* editing/VisibleUnits.cpp: Copied from Source/WebCore/editing/visible_units.cpp.
* editing/VisibleUnits.h: Copied from Source/WebCore/editing/visible_units.h.
* editing/htmlediting.cpp:
* editing/markup.cpp:
* editing/visible_units.cpp: Removed.
* editing/visible_units.h: Removed.
* page/Frame.cpp:
* page/mac/FrameMac.mm:
* platform/win/EditorWin.cpp:

Source/WebKit/mac:

* WebView/WebFrame.mm:

Source/WebKit2:

* WebProcess/WebPage/mac/WebPageMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnused Structure property tables waste 14MB on Membuster.
akling@apple.com [Wed, 6 Mar 2013 12:52:16 +0000 (12:52 +0000)]
Unused Structure property tables waste 14MB on Membuster.
<http://webkit.org/b/110854>
<rdar://problem/13292104>

Reviewed by Geoffrey Garen.

Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.

This time it should stick; I've been through all the tests with COLLECT_ON_EVERY_ALLOCATION.
The issue with the last version was that Structure::m_offset could be used uninitialized
when re-materializing a previously GC'd property table, causing some sanity checks to fail.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:

    Added PropertyTable.cpp.

* runtime/PropertyTable.cpp: Added.
(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):

    Moved marking of property table values here from Structure::visitChildren().

* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):

    Move m_cell to a local before using it multiple times. This avoids a multiple-access race when
    Structure::checkOffsetConsistency() is used in assertions on the main thread while a marking thread
    zaps the property table.

* runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
* runtime/StructureInlines.h:
(JSC::Structure::propertyTable):

    Added a getter for the Structure's PropertyTable that ASSERTs GC currently isn't active.
    Because GC can zap an unpinned property table at any time, it's not entirely safe to access it.
    Renamed the variable itself to m_propertyTableUnsafe to force call sites into explaining themselves.

(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):

    Moved these out of Structure.h to break header dependency cycle between Structure/PropertyTable.

* runtime/Structure.cpp:
(JSC::Structure::visitChildren):

    Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.

(JSC::Structure::takePropertyTableOrCloneIfPinned):

    Added for setting up the property table in a new transition, this code is now shared between
    addPropertyTransition() and nonPropertyTransition().

* runtime/JSGlobalData.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):

    Add a global propertyTableStructure.

* runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):

    Make PropertyTable a GC object.

* runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::checkConsistency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDataReference::vector() should be const.
zeno.albisser@digia.com [Wed, 6 Mar 2013 12:41:40 +0000 (12:41 +0000)]
DataReference::vector() should be const.
https://bugs.webkit.org/show_bug.cgi?id=109928

Reviewed by Anders Carlsson.

* Platform/CoreIPC/DataReference.h:
(CoreIPC::DataReference::vector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDo not add CSSPropertyBorderImage shorthand part of the property list when parsing...
alexis@webkit.org [Wed, 6 Mar 2013 12:14:56 +0000 (12:14 +0000)]
Do not add CSSPropertyBorderImage shorthand part of the property list when parsing CSS border property
https://bugs.webkit.org/show_bug.cgi?id=111481

Reviewed by Julien Chaffraix.

Source/WebCore:

After http://trac.webkit.org/changeset/135848 and more generally we do not
add shorthand directly into the property list used afterwards to build
StylePropertySet but we rather expand the shorthand to add the
longhands. CSSPropertyBorderImage is a shorthand and it should follow
that rule, so when we successfully parsed CSS border property and we
should reset border-image then we should reset the longhands too.

Test: LayoutTests/inspector/styles/styles-new-API-expected.txt which
reflects the fact that we add longhands instead of the shorthand. All
the other tests should not regress.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

LayoutTests:

As now border-image is expanded when we sucessfully parsed a CSS border,
this test needs to be updated to reflect that the longhands are now
part of the declarated style.

* inspector/styles/styles-new-API-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAccelerated overflow scrolling for Coordinated Graphics.
commit-queue@webkit.org [Wed, 6 Mar 2013 12:07:26 +0000 (12:07 +0000)]
Accelerated overflow scrolling for Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=110323

Source/WebCore:

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-06
Reviewed by Noam Rosenthal.

A scroll offset is applied to individual layers on UI process and the
web process is notified assynchronously.
The new API WKCoordinatedScene may be used to scroll layers in the UI process.

Tests will be added on bug #111140.

Scrolling coordinator is used to provide a ScrollableArea to CoordinatedGraphicsLayer.

* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange):
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea):
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
(ScrollingCoordinatorCoordinatedGraphics):

GraphicsLayerTextureMapper is responsible for receiving the 'did commit' messages and to pass
them to its TextureMapperLayer on the appropriated time.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::didCommitScrollOffset):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::setIsScrollable):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::setScrollClient):
(WebCore::GraphicsLayerTextureMapper::setID):
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::isScrollable):

TextureMapperLayer is responsible for applying the requested scroll offset and for
sending the commit messages to web process. It is also able to hittest layers and identify
the ones that are scrollable.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::hitTest):
(WebCore):
(WebCore::TextureMapperLayer::scrollableLayerHitTestCondition):
(WebCore::TextureMapperLayer::findScrollableContentsLayerAt):
(WebCore::TextureMapperLayer::mapScrollOffset):
(WebCore::TextureMapperLayer::commitScrollOffset):
(WebCore::TextureMapperLayer::scrollBy):
(WebCore::TextureMapperLayer::didCommitScrollOffset):
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
(ScrollingClient):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(WebCore::TextureMapperLayer::setID):
(WebCore::TextureMapperLayer::id):
(WebCore::TextureMapperLayer::setScrollClient):
(WebCore::TextureMapperLayer::setIsScrollable):
(WebCore::TextureMapperLayer::isScrollable):
(WebCore::TextureMapperLayer::adjustedPosition):

CoordinatedGraphicsLayer receives the commit messages and updates its ScrollableArea.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setScrollableArea):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::commitScrollOffset):
(WebCore::CoordinatedGraphicsLayer::resetLayerState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(WebCore):
(CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::isScrollable):

CoordinatedGraphicsScene receives the commit messages from TextureMapperLayer and
dispatches them on the main thread. It also has a new method that is used to find
the topmost scrollable layer at a given point.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::dispatchCommitScrollOffset):
(WebCore):
(WebCore::CoordinatedGraphicsScene::commitScrollOffset):
(WebCore::CoordinatedGraphicsScene::findScrollableContentsLayerAt):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(WebCore):
(CoordinatedGraphicsSceneClient):
(CoordinatedGraphicsScene):

New fields have been added to CoordinatedGraphicsLayerState.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(CoordinatedGraphicsLayerState):

Source/WebKit2:

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-06
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Simon Fraser.

A scroll offset is applied to individual layers on UI process and the
web process is notified assynchronously.
The new API WKCoordinatedScene may be used to scroll layers in the UI process.

* CMakeLists.txt:

Encoding and decoding the new members of CoordinatedGraphicsLayerState.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

Adding acceleratedCompositingForOverflowScrollEnabled to WebPreferencesStore.

* Shared/WebPreferencesStore.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

New API WKCoordinatedScene is used to scroll layers on UI side.

* UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
* UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.h:
* UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:

A new message is used to send scroll commit messages to web process.

* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):
(WebKit):
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
(WebKit):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening
thiago.santos@intel.com [Wed, 6 Mar 2013 11:59:02 +0000 (11:59 +0000)]
[EFL] Unreviewed gardening

Added new baselines after r144837 and marked as failures
some pasteboard tests that we don't support yet.

* platform/efl/TestExpectations:
* platform/efl/fast/invalid/017-expected.txt:
* platform/efl/fast/invalid/018-expected.txt:
* platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Added.
* platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Wed, 6 Mar 2013 11:22:51 +0000 (11:22 +0000)]
Unreviewed EFL gardening.

Unskip authentication test that is now passing on EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 6 Mar 2013 10:48:41 +0000 (10:48 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding a failure expectation for a test added in r144877.
* platform/gtk/fast/invalid/017-expected.txt: Rebaselining after r144837.
* platform/gtk/fast/invalid/018-expected.txt: Ditto.
* platform/gtk/tables/mozilla/bugs/bug113235-2-expected.txt: Added. Ditto.
* platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Added. Ditto.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added. Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
allan.jensen@digia.com [Wed, 6 Mar 2013 09:59:22 +0000 (09:59 +0000)]
REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
https://bugs.webkit.org/show_bug.cgi?id=109291

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Report we support fixed layers.

* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::supportsFixedPositionLayers):
(ScrollingCoordinatorCoordinatedGraphics):

LayoutTests:

Unskip now passing test, and move baselines specific to having no scrolling-coordinator to WK1.

* platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png.
* platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt.
* platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png.
* platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt.
* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Convert from device view size to UI view size only in EwkView.
commit-queue@webkit.org [Wed, 6 Mar 2013 09:35:21 +0000 (09:35 +0000)]
[EFL][WK2] Convert from device view size to UI view size only in EwkView.
https://bugs.webkit.org/show_bug.cgi?id=110197

Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-06
Reviewed by Kenneth Rohde Christiansen.

Signed off for WebKit2 by Benjamin Poulain.

Device scale factor is a property of the physical display, so only EwkView
should deal with converting device view size to UI (a.k.a Density Independent Pixel)
view size. It increases readability because we can regard a view size in
other classes (e.g. WebView, PageViewportController, WebPage) except for
EwkView as UI size.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
(EwkView::setDeviceSize):
(EwkView::size):
(EwkView::deviceSize):
(EwkView::scheduleUpdateDisplay):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):
* UIProcess/API/efl/EwkView.h:
(EwkView):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::updateViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Use Vector::reserveInitialCapacity() in WebEventFactory::createWebTouchEvent()
ch.dumez@sisa.samsung.com [Wed, 6 Mar 2013 09:27:43 +0000 (09:27 +0000)]
[EFL][WK2] Use Vector::reserveInitialCapacity() in WebEventFactory::createWebTouchEvent()
https://bugs.webkit.org/show_bug.cgi?id=111530

Reviewed by Benjamin Poulain.

In WebEventFactory::createWebTouchEvent(), when constructing the vector of touch points,
we already know in advance the total number of touch points. Therefore, we should
leverage WTF::Vector::reserveInitialCapacity() and WTF::Vector::uncheckedAppend() to save
some capacity checks.

* Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
hayato@chromium.org [Wed, 6 Mar 2013 09:23:12 +0000 (09:23 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations: Delete http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r144859.
commit-queue@webkit.org [Wed, 6 Mar 2013 09:16:28 +0000 (09:16 +0000)]
Unreviewed, rolling out r144859.
http://trac.webkit.org/changeset/144859
https://bugs.webkit.org/show_bug.cgi?id=111519

Introduced a test that calls non-exist function on non-
Chromium ports and crash on Chromium (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06

Source/WebCore:

* html/HTMLAudioElement.h:
(WebCore::HTMLAudioElement::hasPendingActivity):
(HTMLAudioElement):
* html/HTMLAudioElement.idl:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasPendingActivity):
* html/HTMLMediaElement.idl:

LayoutTests:

* http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-expected.txt: Removed.
* http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html: Removed.
* http/tests/misc/resources/delete-frame-during-readystatechange-frame-with-gc-after-video-removal.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Could not open Profiles panel.
loislo@chromium.org [Wed, 6 Mar 2013 08:59:40 +0000 (08:59 +0000)]
Web Inspector: Could not open Profiles panel.
https://bugs.webkit.org/show_bug.cgi?id=111535

Reviewed by Alexander Pavlov.

* inspector/front-end/CPUProfileView.js:
* inspector/front-end/ProfilesPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash during middle mouse click when page is removed
tony@chromium.org [Wed, 6 Mar 2013 08:29:42 +0000 (08:29 +0000)]
Crash during middle mouse click when page is removed
https://bugs.webkit.org/show_bug.cgi?id=111489

Reviewed by Hajime Morrita.

Source/WebCore:

Check for a null page that can happen if we remove the document from the DOM.
The other methods in EventHandler also check for a null page.

Test: editing/pasteboard/selection-paste-crash.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handlePasteGlobalSelection):

LayoutTests:

* editing/pasteboard/resources/selection-paste-crash.html: Added.
* editing/pasteboard/selection-paste-crash-expected.txt: Added.
* editing/pasteboard/selection-paste-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][EFL] Enable asynchronous spell checking by default
g.czajkowski@samsung.com [Wed, 6 Mar 2013 08:04:39 +0000 (08:04 +0000)]
[WK2][EFL] Enable asynchronous spell checking by default
https://bugs.webkit.org/show_bug.cgi?id=111295

Reviewed by Benjamin Poulain.

Asynchronous spell checking feature is disabled by default for wk2 platforms.
It means all requests of spell checking are sent synchronously.

WebKit-EFL implements requestCheckingOfString method which allows
to check spelling asynchronously.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace shouldLazyAttach bool with an enum for readability
eric@webkit.org [Wed, 6 Mar 2013 07:59:18 +0000 (07:59 +0000)]
Replace shouldLazyAttach bool with an enum for readability
https://bugs.webkit.org/show_bug.cgi?id=111503

Reviewed by Dimitri Glazkov.

No behavioral change.

* bindings/cpp/WebDOMNodeCustom.cpp:
(WebDOMNode::insertBefore):
(WebDOMNode::replaceChild):
(WebDOMNode::appendChild):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::appendChild):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore):
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):
* dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::updateTreeAfterInsertion):
* dom/ContainerNode.h:
(ContainerNode):
* dom/Node.cpp:
(WebCore::Node::insertBefore):
(WebCore::Node::replaceChild):
(WebCore::Node::appendChild):
* dom/Node.h:
(Node):
* editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
* editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::createControls):
* html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlsBlackBerry::createControls):
* html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::initializeControls):
* html/shadow/MediaControlsChromiumAndroid.cpp:
(WebCore::MediaControlsChromiumAndroid::createControls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCustom Elements: CustomElementConstructor::m_name doesn't have any good use.
morrita@google.com [Wed, 6 Mar 2013 07:53:47 +0000 (07:53 +0000)]
Custom Elements: CustomElementConstructor::m_name doesn't have any good use.
https://bugs.webkit.org/show_bug.cgi?id=111523

Reviewed by Kentaro Hara.

This change removes CustomElementConstructor::m_name and renames
m_tagName to m_name. Now generated function name is same as interface name.

Originally, m_name was added to specify the generated constructor
name. An early version of custom element allows to give the name,
but it no longer says anything about that.

The rename is to align the semantics of type extension mechanism
of Custom Elements, where the name of a custom element isn't
necessarily a tag name.

No new tests. Just removing old code.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
* dom/CustomElementConstructor.h:
(CustomElementConstructor):
(WebCore::CustomElementConstructor::name):
* dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::registerElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Flame Chart. Provide node context info in a popover when mouse hovers...
loislo@chromium.org [Wed, 6 Mar 2013 07:43:43 +0000 (07:43 +0000)]
Web Inspector: Flame Chart. Provide node context info in a popover when mouse hovers over a flame chart item.
https://bugs.webkit.org/show_bug.cgi?id=111442

Reviewed by Yury Semikhatsky.

FlameChart is a canvas so it is not possible to attach the popover to the items on it.
It would be a bit tricky to support an offset due to complex behaviour of the popover.
The simplest solution is to create a fake anchor element and move it to the right position.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._showPopover):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype.findNodeCallback):
(WebInspector.FlameChart.prototype._coordinatesToNode):
(WebInspector.FlameChart.prototype.onResize):
* inspector/front-end/flameChart.css:
(.flame-chart .item-anchor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Ensure right format is used in SnapshotImageGL.
commit-queue@webkit.org [Wed, 6 Mar 2013 07:37:08 +0000 (07:37 +0000)]
[EFL] Ensure right format is used in SnapshotImageGL.
https://bugs.webkit.org/show_bug.cgi?id=111333

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-05
Reviewed by Benjamin Poulain.

GL_BGRA format is not standard for glReadPixels with GLES.
This patch ensures that GL_RGBA is used in SnapshotImageGL
while using GLES.

* UIProcess/API/efl/SnapshotImageGL.cpp:
(getImageSurfaceFromFrameBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of the invert argument to SpeculativeJIT::jumpSlowForUnwantedArrayMode
fpizlo@apple.com [Wed, 6 Mar 2013 07:32:39 +0000 (07:32 +0000)]
Get rid of the invert argument to SpeculativeJIT::jumpSlowForUnwantedArrayMode
https://bugs.webkit.org/show_bug.cgi?id=105624

Reviewed by Oliver Hunt.

All callers pass invert = false, which is the default value of the argument. So, get
rid of the argument and fold away all code that checks it.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed buildfix after r144787. Add missing USE(GRAPHICS_SURFACE) guards.
ossy@webkit.org [Wed, 6 Mar 2013 06:59:07 +0000 (06:59 +0000)]
Unreviewed buildfix after r144787. Add missing USE(GRAPHICS_SURFACE) guards.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAutoreleased cached pages slow down the PLT by 2%
ggaren@apple.com [Wed, 6 Mar 2013 06:54:01 +0000 (06:54 +0000)]
Autoreleased cached pages slow down the PLT by 2%
https://bugs.webkit.org/show_bug.cgi?id=111522

Reviewed by Filip Pizlo.

Let's stop doing that.

2% PLT speedup.

* history/PageCache.cpp:
(WebCore::PageCache::remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake toggle-unlink.html test Mac specific behaviour
csaavedra@igalia.com [Wed, 6 Mar 2013 06:43:13 +0000 (06:43 +0000)]
Make toggle-unlink.html test Mac specific behaviour
https://bugs.webkit.org/show_bug.cgi?id=111321

Reviewed by Ryosuke Niwa.

A new test for Windows behavior will have to be added once bug
110487 is landed.

* editing/execCommand/script-tests/toggle-unlink-mac.js: Renamed
from
LayoutTests/editing/execCommand/script-tests/toggle-unlink.js.
Also set editing behaviour to Mac.
* editing/execCommand/toggle-unlink-mac-expected.txt: Renamed from
LayoutTests/editing/execCommand/toggle-unlink-expected.txt.
* editing/execCommand/toggle-unlink-mac.html: Renamed from
LayoutTests/editing/execCommand/toggle-unlink.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed chromium test expectations update.
hayato@chromium.org [Wed, 6 Mar 2013 06:27:43 +0000 (06:27 +0000)]
Unreviewed chromium test expectations update.

Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2013-03-05

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144882 268f45cc-cd09-0410-ab3c-d52691b4dbfc