WebKit-https.git
12 years ago2008-08-02 Wouter Bolsterlee <wbolster@svn.gnome.org>
jmalonzo@webkit.org [Sat, 2 Aug 2008 09:38:55 +0000 (09:38 +0000)]
2008-08-02  Wouter Bolsterlee  <wbolster@svn.gnome.org>

        Reviewed by Eric Seidel.

        * plugins/gtk/gtk2xtbin.h:

        https://bugs.webkit.org/show_bug.cgi?id=20034
        Fix malformed Vim modeline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-02 Christian Dywan <christian@twotoasts.de>
jmalonzo@webkit.org [Sat, 2 Aug 2008 09:38:23 +0000 (09:38 +0000)]
2008-08-02  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Eric Seidel.

        Remove webkit-marshal.list, which was made obsolete in #19742

        * webkit/webkit-marshal.list: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Sat, 2 Aug 2008 06:10:31 +0000 (06:10 +0000)]
    Reviewed by Dave Hyatt.

        - tweak a comment

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoForgot to add the reviewer of r35522.
jmalonzo@webkit.org [Sat, 2 Aug 2008 05:19:49 +0000 (05:19 +0000)]
Forgot to add the reviewer of r35522.

* WebKit/gtk/ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-01 Wouter Bolsterlee <uws@xs4all.nl>
jmalonzo@webkit.org [Sat, 2 Aug 2008 05:12:11 +0000 (05:12 +0000)]
2008-08-01  Wouter Bolsterlee  <uws@xs4all.nl>

        https://bugs.webkit.org/show_bug.cgi?id=20035
        [GTK] Fix return value for webkit_web_view_go_to_back_forward_item()

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-01 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 2 Aug 2008 05:11:59 +0000 (05:11 +0000)]
2008-08-01  Jan Michael Alonzo  <jmalonzo@webkit.org>

        * ChangeLog: Fix date of previous commit (r35520)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-17 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Sat, 2 Aug 2008 05:01:00 +0000 (05:01 +0000)]
2008-06-17  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=19603
        [SOUP] segfault when closing a file using gio

        Call client->didFinishLoading() only after releasing all the gio
        resources.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::closeCallback):
        (WebCore::readCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago../../../../../../WebCore:
andersca@apple.com [Sat, 2 Aug 2008 00:29:03 +0000 (00:29 +0000)]
../../../../../../WebCore:

2008-08-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        <rdar://problem/6120206>
        Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.

        Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::wantsAllStreams):

../../../../../../WebKit/mac:

2008-08-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        <rdar://problem/6120206>
        Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.

        Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.

        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream wantsAllStreams]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Eric Seidel.
kevino@webkit.org [Sat, 2 Aug 2008 00:06:10 +0000 (00:06 +0000)]
Reviewed by Eric Seidel.

Native rendering implementations for form elements in the wx port.

https://bugs.webkit.org/show_bug.cgi?id=19069

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-01 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Fri, 1 Aug 2008 21:50:59 +0000 (21:50 +0000)]
2008-08-01  Beth Dakin  <bdakin@apple.com>

        Reviewed by Adam Roben.

        Fix for <rdar://problem/6119382> Need to hook up WebFrame's
        disconnected frame API on Windows.

        * Interfaces/IWebFrame.idl:
        * WebFrame.cpp:
        (WebFrame::setIsDisconnected):
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any form
aroben@apple.com [Fri, 1 Aug 2008 21:32:49 +0000 (21:32 +0000)]
    Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any form

        Reviewed by Darin Adler.

        * COMPropertyBag.h:
        (COMPropertyBag::QueryInterface): Cast to an appropriate type before
        assigning into ppvObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 1 Aug 2008 20:24:48 +0000 (20:24 +0000)]
2008-07-30  David Hyatt  <hyatt@apple.com>

        Improvements to selection drawing.

        Clip out floating and positioned objects when drawing selection so
        that there is no "double painting" of selection when the selection spans both the space behind the positioned/floating
        object and the positioned/floating object itself.  Improves most Web pages.

        Do not paint left/right selection gaps if the object's edge is already outside the boundary (at a negative
        position).  Significantly improves the look of selections on digg.com, since it uses giant negative text-indent.

        Reviewed by Dan

        Covered by existing selection pixel tests.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelectionRoot):
        (WebCore::RenderBlock::paintSelection):
        (WebCore::clipOutPositionedObjects):
        (WebCore::RenderBlock::fillSelectionGaps):
        (WebCore::RenderBlock::fillLeftSelectionGap):
        (WebCore::RenderBlock::fillRightSelectionGap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds the ability to disable individual properties of a CSS rule.
timothy@apple.com [Fri, 1 Aug 2008 20:23:56 +0000 (20:23 +0000)]
    Adds the ability to disable individual properties of a CSS rule.
        When hovering over a rule, checkboxes show up to the right of all
        properties and toggling a checkbox disables/enables the property.
        Behind the scenes the property is removed from the rule when disabled,
        but still remains in the list and in the computed style. When disabled
        the property has a line through it, and is faded in computed style.

        <rdar://problem/5712828> Support disabling individual CSS properties
        https://bugs.webkit.org/show_bug.cgi?id=14377

        Reviewed by Adam Roben.

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update): Include the
        inline style when it also has disabled properties. Call
        deleteDisabledProperty for any property that is in the style,
        since it might have been added back by the page. Remember all
        disabled properties so they show up in computed style.
        (deleteDisabledProperty): Helper function to delete all the
        right properties that track disabled properties.
        (WebInspector.StylePropertiesSection): Add the computed-style
        class when  the section is Computed Style.
        (WebInspector.StylePropertiesSection.prototype.onpopulate):
        Include disabled properties.
        (WebInspector.StylePropertyTreeElement): Added a disabled argument.
        (WebInspector.StylePropertyTreeElement.prototype.get/set disabled):
        Sets the _disabled property and calls updateState.
        (WebInspector.StylePropertyTreeElement.prototype.get priority):
        Return the priority of enabled or disabled properties.
        (WebInspector.StylePropertyTreeElement.prototype.get value):
        Return the value of enabled or disabled properties.
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle): Use the
        priority and value getter. Append the checkbox for root elements of
        an editable section.
        (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
        Add or remove properties from the rule and remember removed ones
        by adding three objects to the style: __disabledProperties,
        __disabledPropertyValues and __disabledPropertyPriorities.
        The __disabledProperties object will include all longhand
        properties of a shorthand for use by Computed Style.
        (WebInspector.StylePropertyTreeElement.prototype.updateState):
        Use the value getter. Update the disabled state.
        * page/inspector/inspector.css:
        * page/inspector/utilities.js:
        (Object.hasProperties): Added. Helper to test if an object
        has any properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago../../../../../../WebCore:
andersca@apple.com [Fri, 1 Aug 2008 19:23:22 +0000 (19:23 +0000)]
../../../../../../WebCore:

2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/5949410>
        Add the ability to transfer a given application cache to a new database.

        * WebCore.base.exp:
        Export ApplicationCacheStorage::storeCopyOfCache.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::~ApplicationCache):
        Don't call cacheDestroyed for our special "copy" groups.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
        Add a "copy" flag to the ApplicationCacheGroup constructor. A "copied" group is special
        and can only be stored to disk.

        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::isCopy):
        New getter.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::store):
        Make sure to set the storageID when storing an application resource.

        (WebCore::ApplicationCacheStorage::storeNewestCache):
        Change this to return true/false depending on whether storing the cache succeeded or not.

        (WebCore::ApplicationCacheStorage::storeCopyOfCache):
        New method which stores a given cache in a new storage (database file).

        * loader/appcache/ApplicationCacheStorage.h:
        Add new methods.

../../../../../../WebKit/mac:

2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/5949410>
        Add the ability to transfer a given application cache to a new database.

        * Misc/WebKitNSStringExtras.h:
        * Misc/WebKitNSStringExtras.m:
        (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]):
        New method which returns the appopriate cache directory for a given bundle identifier.

        * WebView/WebDataSource.mm:
        (-[WebDataSource _transferApplicationCache:]):
        Transfer the application cache.

        * WebView/WebDataSourcePrivate.h:
        * WebView/WebView.mm:
        (WebKitInitializeApplicationCachePathIfNecessary):
        Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add a link to the instructions to use Apple's Safari for Windows symbol server
aroben@apple.com [Fri, 1 Aug 2008 18:20:03 +0000 (18:20 +0000)]
    Add a link to the instructions to use Apple's Safari for Windows symbol server

        Reviewed by Eric Seidel.

        * building/debug.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Maciej.
ap@webkit.org [Fri, 1 Aug 2008 08:38:31 +0000 (08:38 +0000)]
    Rubber-stamped by Maciej.

        Remove JSGlobalData::DataInstance. It was only needed when we had per-thread JSGlobalData
        instances.

        * kjs/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Fri, 1 Aug 2008 03:10:13 +0000 (03:10 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Updated test results for DumpRenderTree fix in r35497
ddkilzer@apple.com [Fri, 1 Aug 2008 00:08:50 +0000 (00:08 +0000)]
    Updated test results for DumpRenderTree fix in r35497

        * svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
        Contents of the main resource are now displayed instead of encoded
        data.
        * svg/webarchive/svg-cursor-subresources-expected.webarchive: Ditto.
        * svg/webarchive/svg-feimage-subresources-expected.webarchive: Ditto.
        * svg/webarchive/svg-script-subresouces-expected.webarchive: Ditto.
        Also updated MIME types for JavaScript source now that we don't
        mangle application/x-javascript into text/javascript.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Jul 2008 23:16:45 +0000 (23:16 +0000)]
2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Get rid of FormValuesPropertyBag and use COMPropertyBag instead.

        * COMPropertyBag.h:
        Implement parts of IPropertyBag2.
        Currently just one method (CountProperties) is implemented.

        * WebCoreSupport/FormValuesPropertyBag.cpp: Removed.
        * WebCoreSupport/FormValuesPropertyBag.h: Removed.

        * WebFrame.cpp:
        (WebFrame::dispatchWillSubmitForm):
        Create a COMPropertyBag instead.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Follow-up to r35500
aroben@apple.com [Thu, 31 Jul 2008 22:18:45 +0000 (22:18 +0000)]
    Follow-up to r35500

        * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
        Release configuration, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Stefan Landvogt <stefan.landvogt@gmail.com>
aroben@apple.com [Thu, 31 Jul 2008 22:12:55 +0000 (22:12 +0000)]
2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>

        Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
        the box

        <https://bugs.webkit.org/show_bug.cgi?id=20245>

        Reviewed by Adam Roben.

        * WinLauncher/WinLauncher.vcproj: adding the following properties to
        WinLauncher > Properties > Manifest Tool > Isolated COM
        Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
        Component File Name: WebKit$(WebKitDLLConfigSuffix)
        Doing the change on "All Configurations"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
sullivan@apple.com [Thu, 31 Jul 2008 21:42:45 +0000 (21:42 +0000)]
WebCore:

2008-07-31  John Sullivan  <sullivan@apple.com>

        WebCore part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

        Reviewed by Hyatt

        * WebCore.base.exp:
        export symbol for WebCoreSettings::setZoomsTextOnly()

        * page/Frame.cpp:
        (WebCore::Frame::isZoomFactorTextOnly):
        use value from Settings instead of data member
        (WebCore::Frame::shouldApplyTextZoom):
        call isZoomFactorTextOnly() to get value instead of accessing now-removed data member
        (WebCore::Frame::shouldApplyPageZoom):
        ditto
        (WebCore::Frame::setZoomFactor):
        set value into Settings rather than into data member
        (WebCore::FramePrivate::FramePrivate):
        don't set initial value of now-removed data member; this is managed by Settings now

        * page/FramePrivate.h:
        removed m_zoomFactorIsTextOnly

        * page/Settings.cpp:
        (WebCore::Settings::setZoomsTextOnly):
        new function, sets values and reapplies styles in all frames

        * page/Settings.h:
        (WebCore::Settings::zoomsTextOnly):
        new function, returns value of new data member

WebKit/mac:

2008-07-31  John Sullivan  <sullivan@apple.com>

        WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

        Reviewed by Hyatt

        * WebView/WebPreferenceKeysPrivate.h:
        added WebKitZoomsTextOnlyPreferenceKey

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        default value of YES for WebKitZoomsTextOnlyPreferenceKey
        (-[WebPreferences zoomsTextOnly]):
        getter for WebKitZoomsTextOnlyPreferenceKey
        (-[WebPreferences setZoomsTextOnly:]):
        setter for WebKitZoomsTextOnlyPreferenceKey

        * WebView/WebPreferencesPrivate.h:
        declare zoomsTextOnly/setZoomsTextOnly:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
        update WebCore::Settings value for zoomsTextOnly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build bot fix
aroben@apple.com [Thu, 31 Jul 2008 21:35:23 +0000 (21:35 +0000)]
    Windows build bot fix

        * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
        exist for people at Apple can't be found. Also updated the ICU version
        to 3.8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix layout test results for webarchive/test-xml-stylesheet.xml
ddkilzer@apple.com [Thu, 31 Jul 2008 21:21:30 +0000 (21:21 +0000)]
    Fix layout test results for webarchive/test-xml-stylesheet.xml

WebKit:

        Fix layout test results for webarchive/test-xml-stylesheet.xml

        Reviewed by Darin.

        * WebKit.xcodeproj/project.pbxproj: Added WebHTMLRepresentationInternal.h.
        Changed WebHTMLRepresentationInternal.h and WebHTMLRepresentationPrivate.h
        to private so they're copied into PrivateHeaders.

WebKit/mac:

        Fix layout test results for webarchive/test-xml-stylesheet.xml

        Reviewed by Darin.

        Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
        for DumpRenderTree.

        * WebView/WebHTMLRepresentationInternal.h: Added.

WebKitTools:

        Fix layout test results for webarchive/test-xml-stylesheet.xml

        Reviewed by Darin.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (convertMIMEType): Work around the "text/xml" local file type
        regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
        stop mangling "application/x-javascript" into "text/javascript".
        (convertWebResourceDataToString): When checking whether to dump a
        resource as text, also check to see if the MIME type is in the
        -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
        * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
        macro.

LayoutTests:

        Fix layout test results for webarchive/test-xml-stylesheet.xml

        Reviewed by Darin.

        * platform/mac/webarchive/test-xml-stylesheet-expected.txt:
        Removed unused test results.

        * webarchive/test-duplicate-resources-expected.webarchive: Updated
        results now that we don't mangle application/x-javascript into
        text/javascript.
        * webarchive/test-script-src-expected.webarchive: Ditto.

        * webarchive/test-xml-stylesheet-expected.webarchive: Updated
        results now that we handle application/xml correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 31 Jul 2008 21:10:45 +0000 (21:10 +0000)]
2008-07-31  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Null-check parent clip rects, because they may not have been
        set up yet.
        https://bugs.webkit.org/show_bug.cgi?id=20243

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDid not mean to remove these files.
andersca@apple.com [Thu, 31 Jul 2008 20:55:20 +0000 (20:55 +0000)]
Did not mean to remove these files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Jul 2008 20:54:04 +0000 (20:54 +0000)]
2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        Tweak the names.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Jul 2008 20:48:55 +0000 (20:48 +0000)]
2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        <rdar://problem/5826110>

        Add a way for WebKit clients to embed custom content in web pages.

        * Interfaces/IWebEmbeddedView.idl: Added.
        New interface which an embedded view must implement.

        * Interfaces/IWebUIDelegatePrivate.idl:
        Add new UI delegate method for creating an embedded view.

        * Interfaces/WebKit.idl:
        Include IWebEmbeddedView.idl.

        * WebCoreSupport/EmbeddedWidget.cpp: Added.
        * WebCoreSupport/EmbeddedWidget.h: Added.
        Add EmbeddedWidget, a widget subclass which can hold an IWebEmbeddedView.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::createPlugin):
        Check if the UI delegate wants to create an embedded view.

        * WebKit.vcproj/WebKit.vcproj:
        Add EmbeddedWidget.{cpp|h}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Thu, 31 Jul 2008 20:46:20 +0000 (20:46 +0000)]
    Reviewed by Dave Hyatt.

        - fix <rdar://problem/6058958> REGRESSION (r34210): Seams are visible in border-image

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw): To work around a Core Graphics
        interpolation issue, reverted to using a temporary subimage for drawing
        a portion of the image with scaling and high-quality interpolation in
        effect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/3563671> VO doesn't highlight characters when interacting when static...
cfleizach@apple.com [Thu, 31 Jul 2008 20:44:46 +0000 (20:44 +0000)]
<rdar://problem/3563671> VO doesn't highlight characters when interacting when static text in web areas

Add ability to get bounds for individual characters through accessibility

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved da BOM from the ChangeLog.
ddkilzer@apple.com [Thu, 31 Jul 2008 20:39:07 +0000 (20:39 +0000)]
Removed da BOM from the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Release build fix.
ap@webkit.org [Thu, 31 Jul 2008 19:15:12 +0000 (19:15 +0000)]
    Release build fix.

        * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]):
        Don't define to npErr in release builds, as it is only used for logging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 31 Jul 2008 17:50:30 +0000 (17:50 +0000)]
2008-07-31  John Sullivan  <sullivan@apple.com>

        Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
        drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard

        Reviewed by Dan

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
        include Leopard in the #ifdef that forces a layout if needed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSecond attempt at Windows/wx build fix. Instead of avoiding inclusion of windows...
kevino@webkit.org [Thu, 31 Jul 2008 17:33:03 +0000 (17:33 +0000)]
Second attempt at Windows/wx build fix. Instead of avoiding inclusion of windows.h, use defines, etc. to avoid conflicts in each affected file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Erik Bunce <elbunce@thehive.com>
hausmann@webkit.org [Thu, 31 Jul 2008 17:20:00 +0000 (17:20 +0000)]
2008-07-31  Erik Bunce  <elbunce@thehive.com>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=20224

        Include the Writing Direction sub-menu in the context menu of all
        platforms but GTK. This fixes a regression introduced by revision
        34426.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 31 Jul 2008 17:14:24 +0000 (17:14 +0000)]
WebCore:

2008-07-31  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam and Hyatt

        Fix for <rdar://problem/6099748>

        Adds a "don't enforce CSS mime type in strict mode" quirk for iWeb 2

        * WebCore.base.exp:

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::setCSSStyleSheet):

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::canUseSheet):
        * loader/CachedCSSStyleSheet.h:
        (WebCore::CachedCSSStyleSheet::sheetText):
        * page/Settings.cpp:

        (WebCore::Settings::Settings):
        (WebCore::Settings::setEnforceCSSMIMETypeInStrictMode):
        * page/Settings.h:
        (WebCore::Settings::enforceCSSMIMETypeInStrictMode):

WebKit/mac:

2008-07-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam and Hyatt

        Fix for <rdar://problem/6099748>

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode"
          quirk when running under iWeb 2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Jul 2008 16:56:04 +0000 (16:56 +0000)]
2008-07-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Fix Windows build.

        * kjs/collector.h:
        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Erik Bunce <elbunce@thehive.com>
hausmann@webkit.org [Thu, 31 Jul 2008 15:11:15 +0000 (15:11 +0000)]
2008-07-31  Erik Bunce  <elbunce@thehive.com>

        Reviewed by Simon.

        Added the ability to get SQLite headers and source from the location¬∑
        specified via the SQLITE3SRCDIR environtment variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Erik Bunce <elbunce@thehive.com>
hausmann@webkit.org [Thu, 31 Jul 2008 15:10:54 +0000 (15:10 +0000)]
2008-07-31  Erik Bunce  <elbunce@thehive.com>

        Reviewed by Simon.

        Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Erik Bunce <elbunce@thehive.com>
hausmann@webkit.org [Thu, 31 Jul 2008 15:03:31 +0000 (15:03 +0000)]
2008-07-31  Erik Bunce  <elbunce@thehive.com>

        Reviewed by Simon.

        Make sure edit actions get updated when the contents change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Erik Bunce <elbunce@thehive.com>
hausmann@webkit.org [Thu, 31 Jul 2008 15:00:42 +0000 (15:00 +0000)]
2008-07-31  Erik Bunce  <elbunce@thehive.com>

        Reviewed by Simon.

        Add simple edit test abilities to QtLauncher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-31 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
hausmann@webkit.org [Thu, 31 Jul 2008 15:00:30 +0000 (15:00 +0000)]
2008-07-31  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Simon.

        Bug 20170: [Qt] missing namespace defines in JavaScriptCore.pro
        <https://bugs.webkit.org/show_bug.cgi?id=20170>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Maciej.
ap@webkit.org [Thu, 31 Jul 2008 12:19:22 +0000 (12:19 +0000)]
    Rubber-stamped by Maciej.

        Eliminate JSLock (it was already disabled, removing the stub implementaion and all
        call sites now).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Oliver Hunt.
ap@webkit.org [Thu, 31 Jul 2008 09:58:12 +0000 (09:58 +0000)]
    Rubber-stamped by Oliver Hunt.

        Fix the Mac project to not display "test/" as part of file name for tests.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Alexey Proskuryakov.
eric@webkit.org [Thu, 31 Jul 2008 08:44:58 +0000 (08:44 +0000)]
    Reviewed by Alexey Proskuryakov.

        Rename USE(MULTIPLE_THREADS) to ENABLE(JSC_MULTIPLE_THREADS)
        to better match the use/enable pattern (and better describe
        the usage of the feature in question.)

        I also fixed a couple other ENABLE_ macros to be pre-processor
        definition override-able to match the rest of the ENABLE_ macros
        since it seems to be our convention that build systems can set
        ENABLE_ macros in Makefiles.

        * kjs/InitializeThreading.cpp:
        (KJS::initializeThreadingOnce):
        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::JSGlobalData):
        (KJS::JSGlobalData::~JSGlobalData):
        * kjs/MathObject.cpp:
        * kjs/collector.cpp:
        (KJS::Heap::Heap):
        (KJS::Heap::~Heap):
        (KJS::allocateBlock):
        (KJS::Heap::markStackObjectsConservatively):
        * kjs/collector.h:
        * kjs/dtoa.cpp:
        (KJS::pow5mult):
        (KJS::rv_alloc):
        (KJS::freedtoa):
        (KJS::dtoa):
        * wtf/FastMalloc.cpp:
        * wtf/Platform.h:
        * wtf/RefCountedLeakCounter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix.
jhoneycutt@apple.com [Thu, 31 Jul 2008 07:37:44 +0000 (07:37 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
eric@webkit.org [Thu, 31 Jul 2008 06:38:54 +0000 (06:38 +0000)]
    Reviewed by Mark Rowe.

        Try to clean up our usage of USE(MULTIPLE_THREADS) vs. USE(PTHREADS) a little.
        It looks like JSC assumes that if MULTIPLE_THREADS is defined, then pthreads will always be available
        I'm not sure that's always the case for gtk, certainly not for Windows.  We should eventually go back
        and fix wtf/Threading.h to cover all these cases some day.

        * kjs/JSLock.cpp:
        * kjs/collector.h:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix.
mrowe@apple.com [Thu, 31 Jul 2008 06:14:13 +0000 (06:14 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix various minor bugs with style editing in the Inspector.
timothy@apple.com [Thu, 31 Jul 2008 04:04:52 +0000 (04:04 +0000)]
    Fix various minor bugs with style editing in the Inspector.

        - Restores the scroll position to 0,0 when finished editing a
        string that was longer than the editing input area.

        - Adjusts the margin of the list item to ensure the text does
        not shift when entering and exiting editing mode.

        - Reliably remembers if a shorthand has children when the
        children haven't been populated yet.

        - Reliably remembers if a shorthand was expanded, and expands
        if needed after editing finishes.

        - Hides color swatches when editing.

        https://bugs.webkit.org/show_bug.cgi?id=20238

        Reviewed by Adam Roben.

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.startEditing):
        Store the expanded state and children state in wasExpanded and
        reallyHasChildren properties.
        (WebInspector.StylePropertyTreeElement.prototype.editingEnded):
        Removed the wasExpanded argument and use the reallyHasChildren and
        wasExpanded properties to restore state. Deletes the state properties.
        (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
        Removed the wasExpanded argument.
        (WebInspector.StylePropertyTreeElement.prototype.editingCommitted):
        Removed the wasExpanded argument.
        * page/inspector/inspector.css: Tweak the margin and hides the color
        swatches. ALso removes a rule that was not needed.
        * page/inspector/inspector.js:
        (WebInspector.startEditing): Restore the scrollLeft and scrollTop
        to zero when editing finishes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Jul 2008 01:21:59 +0000 (01:21 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Use a COMPropertyBag instead of the HTTPHeaderPropertyBag.

        * HTTPHeaderPropertyBag.cpp: Removed.
        * HTTPHeaderPropertyBag.h: Removed.
        * WebURLResponse.cpp:
        (WebURLResponse::allHeaderFields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Jul 2008 01:11:54 +0000 (01:11 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Fix copyright years.

        * COMPropertyBag.h:
        * COMVariantSetter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Thu, 31 Jul 2008 00:33:14 +0000 (00:33 +0000)]
2008-07-30  Alice Liu  <alice.liu@apple.com>

        Implement userIdleTime() for Windows, and place a band-aid over other
        platform implementations of userIdleTime().  This will fix the issue
        of indefinitely postposing releasing pages from the PageCache
        on non-Mac platforms, causing us to hang onto just about everything
        else about a web page.

        Reviewed by Sam Weinig.

        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:
        (WebCore::userIdleTime): set to FLT_MAX

        * platform/win/SystemTimeWin.cpp:
        (WebCore::userIdleTime): implemented

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 31 Jul 2008 00:19:28 +0000 (00:19 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        More property bag work.

        * COMPropertyBag.h:
        (COMPropertyBag::COMPropertyBag):
        (::adopt):
        (::Read):
        * COMVariantSetter.h:
        (COMIUnknownVariantSetter::setVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Thu, 31 Jul 2008 00:01:52 +0000 (00:01 +0000)]
WebCore:

2008-07-30  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Fixes <rdar://problem/6041390>

        Adds the ability to have a frame that is "disconnected" from the
        main frame from the perspective of top and parent in
        Javascript.

        * WebCore.base.exp:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::parent):
        (WebCore::DOMWindow::top):
        * page/Frame.cpp:
        (WebCore::Frame::isDisconnectedFrame):
        (WebCore::Frame::setIsDisconnectedFrame):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/FrameTree.cpp:
        (WebCore::FrameTree::parent):
        (WebCore::FrameTree::top):
        * page/FrameTree.h:

WebKit/mac:

2008-07-30  Beth Dakin  <bdakin@apple.com>

        Reviewed by Anders Carlsson.

        Fixes <rdar://problem/6041390>

        Adds the ability to have a frame that is "disconnected" from the
        main frame from the perspective of top and parent in
        Javascript.

        * WebView/WebFrame.mm:
        (-[WebFrame _setIsDisconnectedFrame]):
        * WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
eric@webkit.org [Wed, 30 Jul 2008 23:14:37 +0000 (23:14 +0000)]
    Reviewed by Oliver.

        MSVC warns when structs are called classes or vice versa.
        Make all the source refer to JSGlobalData as a class.

        * kjs/CommonIdentifiers.h:
        * kjs/JSGlobalData.h:
        * kjs/Parser.h:
        * kjs/lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Justin.
eric@webkit.org [Wed, 30 Jul 2008 23:13:57 +0000 (23:13 +0000)]
    Reviewed by Justin.

        Crash Safari when dragging images into Google presentations
        https://bugs.webkit.org/show_bug.cgi?id=20161

        Test: manual-tests/remove-on-drop-crash.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * manual-tests/remove-on-drop-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Jessica Kahn <jess@apple.com>
jess@apple.com [Wed, 30 Jul 2008 22:59:16 +0000 (22:59 +0000)]
2008-07-30  Jessica Kahn  <jess@apple.com>

        Reviewed by Adam Roben.

        Slightly stricter checking for previous change, suggested by Adam.

        * Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 22:29:43 +0000 (22:29 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add COMPropertyBag, a simple template class that implements the IPropertyBag interface. All
        property bag values must be of the same type.

        The COMVariantSetter helpers are now in COMVariantSetter.h

        * COMEnumVariant.h:
        * COMPropertyBag.h: Added.
        * COMVariantSetter.h: Added.
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Jessica Kahn <jess@apple.com>
jess@apple.com [Wed, 30 Jul 2008 22:22:04 +0000 (22:22 +0000)]
2008-07-30  Jessica Kahn  <jess@apple.com>

        Reviewed by Darin Adler.

        Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.

        * Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for Cairo < 1.6
christian@webkit.org [Wed, 30 Jul 2008 21:12:12 +0000 (21:12 +0000)]
Build fix for Cairo < 1.6

* platform/graphics/cairo/PathCairo.cpp:
  (WebCore::Path::boundingRect): use cairo_stroke_extends for < 1.6

Reviewed by Mark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Wed, 30 Jul 2008 20:34:39 +0000 (20:34 +0000)]
2008-07-30  Alice Liu  <alice.liu@apple.com>

        Reviewed by Adam Roben.

        Adding logging of COM class names and counts to facilitate
        investigating memory issues.

        * Interfaces/IWebKitStatistics.idl:
        * WebKitDLL.cpp:
        * WebKitDLL.h:
        * WebKitStatistics.cpp:
        (WebKitStatistics::comClassNameCounts):
        * WebKitStatistics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 30 Jul 2008 20:17:53 +0000 (20:17 +0000)]
2008-07-29  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/6110314> Crash in profiler dereferencing null frame or
        page (20214)
        - Null check.

        * page/Console.cpp:
        (WebCore::Console::finishedProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 30 Jul 2008 20:16:06 +0000 (20:16 +0000)]
    Reviewed by Geoff Garen.

        Add consistency checks to UString to document and enforce its design.

        * kjs/ustring.cpp:
        (KJS::UString::Rep::create):
        (KJS::UString::Rep::destroy):
        (KJS::UString::Rep::checkConsistency):
        (KJS::UString::expandCapacity):
        (KJS::UString::expandPreCapacity):
        (KJS::UString::UString):
        (KJS::UString::spliceSubstringsWithSeparators):
        (KJS::UString::append):
        * kjs/ustring.h:
        (KJS::UString::Rep::checkConsistency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 30 Jul 2008 20:02:32 +0000 (20:02 +0000)]
2008-07-30  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=18070

        Full page zoom needs to work properly with JS mouse events.  Make sure to adjust the coordinates of the
        JS mouse event to account for zoom.

        Reviewed by olliej

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Wed, 30 Jul 2008 19:00:28 +0000 (19:00 +0000)]
WebCore:

2008-07-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Update Cross-site XMLHttpRequests using Access control to
        the latest spec. (Editor's Draft 8 July 2008)

        - This leaves us at about the same place as we previously were
          still needing preflight caching and better redirect support.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * xml/AccessControlList.cpp: Removed.
        * xml/AccessControlList.h: Removed.
        * xml/AccessItem.cpp: Removed.
        * xml/AccessItem.h: Removed.
        * xml/AccessItemRule.cpp: Removed.
        * xml/AccessItemRule.h: Removed.
        * xml/XMLHttpRequest.cpp:
        (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::isSimpleCrossSiteAccessRequest):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequest):
        (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
        (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::clearRequest):
        (WebCore::XMLHttpRequest::didFinishLoading):
        (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
        (WebCore::XMLHttpRequest::accessControlCheck):
        (WebCore::XMLHttpRequest::didReceiveResponse):
        (WebCore::parseAccessControlAllowList):
        (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
        * xml/XMLHttpRequest.h:

LayoutTests:

2008-07-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Update Cross-site XMLHttpRequests using Access control to
        the latest spec. (Editor's Draft 8 July 2008)

        - Update syntax in tests a remove tests for removed features.

        * http/tests/xmlhttprequest/access-control-basic-allow-async.html:
        * http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers-expected.txt: Removed.
        * http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers.html: Removed.
        * http/tests/xmlhttprequest/access-control-basic-exclude.html: Removed.
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt.
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html.
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt.
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow.html.
        * http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt: Removed.
        * http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html: Removed.
        * http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt: Removed.
        * http/tests/xmlhttprequest/access-control-basic-not-get-allow.html: Removed.
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-print-headers.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-allow.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-exclude.cgi: Removed.
        * http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-non-get-allow.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Auto generate webkitmarshal.list
christian@webkit.org [Wed, 30 Jul 2008 18:17:24 +0000 (18:17 +0000)]
[GTK] Auto generate webkitmarshal.list

Auto generate webkitmarshal.list from source files to reduce the
number of conflicts when merging git branches or when applying
patches.
Also rename webkit-marshal.* to webkitmarshal.* for consistency.

Reviewed by Holger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 30 Jul 2008 17:38:35 +0000 (17:38 +0000)]
2008-07-30  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Fixes for Windows and non-AllInOne file build with SamplingTool, plus review fixes.

        * GNUmakefile.am:              Adding SamplingTool.cpp to build.
        * JavaScriptCore.exp:          Export hooks to init & control SamplingTool.
        * JavaScriptCore.pri:          Adding SamplingTool.cpp to build.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Adding SamplingTool.cpp to build.
        * JavaScriptCore.xcodeproj/project.pbxproj: Adding SamplingTool.cpp to build.
        * JavaScriptCoreSources.bkl:   Adding SamplingTool.cpp to build.
        * VM/Machine.cpp:              MACHINE_SAMPLING_callingNativeFunction renamed MACHINE_SAMPLING_callingHostFunction
        * VM/Machine.h:
        * VM/Opcode.cpp:               SamplingTool moved to SamplingTool.cpp/.h, opcodeNames generated from FOR_EACH_OPCODE_ID.
        * VM/Opcode.h:
        * VM/SamplingTool.cpp:         Added .cpp/.h for SamplingTool.
        * VM/SamplingTool.h:
        * kjs/Shell.cpp:               Switched SAMPLING_TOOL_ENABLED to ENABLE_SAMPLING_TOOL.
        * wtf/Platform.h:              Added ENABLE_SAMPLING_TOOL config option.
        * kjs/nodes.cpp:               Header include to fix non-AllInOne builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 17:09:17 +0000 (17:09 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Copy icu38* files instead of icu36* files.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Ariya Hidayat <ariya.hidayat@trolltech.com>
ap@webkit.org [Wed, 30 Jul 2008 16:58:21 +0000 (16:58 +0000)]
2008-07-30  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Alexey Proskuryakov.

        Fix compilation without multi-threading support.

        * kjs/collector.cpp:
        (KJS::Heap::Heap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 16:37:27 +0000 (16:37 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Add WebKitAvailability.h forwarding header.

        * ForwardingHeaders/JavaScriptCore/WebKitAvailability.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 16:24:39 +0000 (16:24 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        Fix the else.

        * API/WebKitAvailability.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 16:22:39 +0000 (16:22 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        * API/WebKitAvailability.h:
        Fix Windows (and other non-Mac builds).

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        Add WebKitAvailability.h to the project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Jul 2008 16:17:50 +0000 (16:17 +0000)]
2008-07-30  Anders Carlsson  <andersca@apple.com>

        One step closer towards fixing the Windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        Make sure to copy WebKitAvailability.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTypo in comment for bracer ending block
christian@webkit.org [Wed, 30 Jul 2008 15:24:56 +0000 (15:24 +0000)]
Typo in comment for bracer ending block

https://bugs.webkit.org/show_bug.cgi?id=20205

* webkit/webkitprivate.cpp: Typo fix in comment for the brace
         that ends the WebKit namespace; WebCore -> WebKit

Reviewed by Sam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 30 Jul 2008 14:42:03 +0000 (14:42 +0000)]
2008-07-29  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Bug 20209: Atomize constant strings
        <https://bugs.webkit.org/show_bug.cgi?id=20209>

        Prevents significant performance degradation seen when a script contains multiple
        identical strings that are used as keys to identify properties on objects.

        No performance change on SunSpider.

        * kjs/nodes.cpp: Atomize constant strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6111648> JavaScript exceptions fail if the scope chain includes the...
oliver@apple.com [Wed, 30 Jul 2008 08:00:19 +0000 (08:00 +0000)]
<rdar://problem/6111648> JavaScript exceptions fail if the scope chain includes the global object

Reviewed by Alexey Proskuryakov.

In an attempt to remove the branch I just added to KJS::depth I
used the existence of a Variable Object at a point in the scope
chain as an indicator of function or global scope activation.
However this assumption results in incorrect behaviour if the
global object is injected into the scope chain with 'with'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 30 Jul 2008 07:09:40 +0000 (07:09 +0000)]
    Reviewed by Geoff Garen.

        Don't call JSGarbageCollect() on a released context.

        * API/testapi.c: (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 30 Jul 2008 06:14:26 +0000 (06:14 +0000)]
2008-07-29  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6060647> Adopt QTMovieOpenForPlaybackAttribute flag

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 30 Jul 2008 06:05:11 +0000 (06:05 +0000)]
    Reviewed by Geoff Garen.

        Implement JSContextGroup APIs to make concurrent execution possible for
        JavaScriptCore clients.

        This changes the behavior of JSGlobalContextCreate(), so that it now uses a private context
        group for each context, making JSlock implicit locking unnecessary.

        * API/JSContextRef.h:
        * API/JSContextRef.cpp:
        (JSContextGroupCreate):
        (JSContextGroupRetain):
        (JSContextGroupRelease):
        (JSGlobalContextCreate):
        (JSGlobalContextCreateInGroup):
        (JSGlobalContextRelease):
        (JSContextGetGroup):
        Added new methods. JSGlobalContextCreate() calls JSGlobalContextCreateInGroup() now.

        * API/APICast.h: (toJS): (toRef): Added converters for JSContextGroupRef.
        * API/JSBase.cpp: (JSGarbageCollect): JSGarbageCollect(0) is now a no-op, and the passed in
        context is actually used.

        * API/JSBase.h: Aded a typedef for JSContextGroupRef. Updated documentation for
        JSGarbageCollect().

        * JavaScriptCore.exp: Removed JSGlobalData::sharedInstance().

        * kjs/JSGlobalData.cpp:
        * kjs/JSGlobalData.h:
        Removed support for JSGlobalData shared instance. JSGlobalData::isSharedInstance member
        variable still remains, to be deleted in a followup patch.

        * kjs/JSLock.cpp: (KJS::JSLock::JSLock): Disabled JSLock, to be deleted in a follow-up patch.

        * kjs/collector.cpp:
        (KJS::Heap::markOtherThreadConservatively): Removed an assertion that referenced
        JSGlobalData::sharedInstance.

        * kjs/collector.h: Made Heap destructor public, so that JSContextRelease can use it.

JavaScriptGlue:
        * JSRun.cpp:
        (JSRun::JSRun):
        * JSUtils.cpp:
        (getThreadGlobalExecState):
        Changed JavaScriptGlue to use a JSGlobalData of its own, now that there is no shared
        instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 30 Jul 2008 06:02:39 +0000 (06:02 +0000)]
2008-07-29  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6031021> Make standalone video render more like the quicktime plugin to improve performance

        For standalone video, use QTMovieView to draw.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieView): Moved nil checks to setUpVideoRendering.
         Associate the QTMovieView with the WebCoreMovieObserver.
         If we're in a media document, allow QTMovieView to render in its default mode; otherwise tell it to draw synchronously.
        (WebCore::MediaPlayerPrivate::detachQTMovieView): Set the WebCoreMovieObserver's view to nil.
        (WebCore::MediaPlayerPrivate::createQTVideoRenderer): Nil check is now in setUpVideoRendering, which is the only caller of this.
        (WebCore::MediaPlayerPrivate::setUpVideoRendering): Added nil checks.  Call createQTMovieView for media documents.
        (WebCore::MediaPlayerPrivate::tearDownVideoRendering): Call detachQTMovieView if a QTMovieView exists.
        (WebCore::MediaPlayerPrivate::setRect): Call setFrame on the QTMovieView if necessary.
        (-[WebCoreMovieObserver menuForEventDelegate:]): Added. Returns the frame view's menu.
        (-[WebCoreMovieObserver setView:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 30 Jul 2008 05:55:57 +0000 (05:55 +0000)]
    Reviewed by Geoff Garen.

        Fix a leak of ThreadRegistrar objects.

        As the heap is usually deleted when registered threads still exist, ThreadSpecific doesn't
        have a chance to clean up per-thread object. Switched to native pthread calls, storing a
        plain pointer that doesn't require cleanup.

        * kjs/collector.cpp:
        (KJS::PlatformThread::PlatformThread):
        (KJS::Heap::Thread::Thread):
        (KJS::Heap::Heap):
        (KJS::Heap::~Heap):
        (KJS::Heap::registerThread):
        (KJS::Heap::unregisterThread):
        * kjs/collector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
ap@webkit.org [Wed, 30 Jul 2008 05:52:37 +0000 (05:52 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=20169
        Memory allocated with fastMalloc is freed with delete

        * VM/JSPropertyNameIterator.cpp:
        (KJS::JSPropertyNameIterator::invalidate): Free the array properly.
        (KJS::JSPropertyNameIterator::~JSPropertyNameIterator): Delete the array by calling
        invalidate().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 30 Jul 2008 05:42:04 +0000 (05:42 +0000)]
2008-07-29  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6073372> Move built-in controls below <video> element for standalone media documents

        * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added -webkit-full-page-media pseudo class.
        * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoFullPageMedia.
        * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added case to
        apply PseudoFullPageMedia for elements in a full page media document.

        * css/html4.css: Added rule to shift control panel down for video in standalone media documents.

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::lowestPosition): Added implementation that takes the controls into account.
        This makes sure that scrollbars on the page will account for controls not directly contained in the RenderMedia.
        (WebCore::RenderMedia::rightmostPosition): ditto.
        (WebCore::RenderMedia::leftmostPosition): ditto.
        * rendering/RenderMedia.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Sam Weinig.
kevino@webkit.org [Wed, 30 Jul 2008 05:34:28 +0000 (05:34 +0000)]
Reviewed by Sam Weinig.

Add tooltip support to the wx port.

https://bugs.webkit.org/show_bug.cgi?id=20173

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Wed, 30 Jul 2008 05:00:32 +0000 (05:00 +0000)]
2008-07-29  Alice Liu  <alice.liu@apple.com>

        Reviewed by Geoff Garen.

        Fix WebDocumentLoader leak on Windows.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::createDocumentLoader):
        * WebDocumentLoader.cpp:
        (WebDocumentLoader::create):
        * WebDocumentLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Wed, 30 Jul 2008 02:39:48 +0000 (02:39 +0000)]
WebCore:

2008-07-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        <rdar://problem/6084585> Investigate upload progress events.

        - Add progress notifications for data being sent via a ResourceHandle.
        - Add XMLHttpRequestUpload support.

        Upload notifications only work on the Mac right now as the CFNetwork API
        on windows does not expose enough information.

        Tests: http/tests/xmlhttprequest/upload-onload-event.html
               http/tests/xmlhttprequest/upload-onloadstart-event.html
               http/tests/xmlhttprequest/upload-onprogress-event.html
               http/tests/xmlhttprequest/upload-progress-events.html

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::toJS):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::mark):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp: Added.
        (WebCore::JSXMLHttpRequestUpload::mark):
        (WebCore::JSXMLHttpRequestUpload::onabort):
        (WebCore::JSXMLHttpRequestUpload::setOnabort):
        (WebCore::JSXMLHttpRequestUpload::onerror):
        (WebCore::JSXMLHttpRequestUpload::setOnerror):
        (WebCore::JSXMLHttpRequestUpload::onload):
        (WebCore::JSXMLHttpRequestUpload::setOnload):
        (WebCore::JSXMLHttpRequestUpload::onloadstart):
        (WebCore::JSXMLHttpRequestUpload::setOnloadstart):
        (WebCore::JSXMLHttpRequestUpload::onprogress):
        (WebCore::JSXMLHttpRequestUpload::setOnprogress):
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        (WebCore::JSXMLHttpRequestUpload::dispatchEvent):
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toXMLHttpRequestUpload):
        * dom/EventTarget.h:
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didSendData):
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didSendData):
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        (WebCore::SubresourceLoaderClient::didSendData):
        * page/DOMWindow.idl:
        * platform/network/FormData.cpp:
        (WebCore::FormData::FormData):
        * platform/network/FormData.h:
        (WebCore::FormData::alwaysStream):
        (WebCore::FormData::setAlwaysStream):
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::didSendData):
        * platform/network/mac/FormDataStreamMac.h:
        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::getStreamFormDataMap):
        (WebCore::getStreamResourceHandleMap):
        (WebCore::associateStreamWithResourceHandle):
        (WebCore::disassociateStreamWithResourceHandle):
        (WebCore::DidSendDataCallbackData::DidSendDataCallbackData):
        (WebCore::performDidSendDataCallback):
        (WebCore::formCreate):
        (WebCore::formFinalize):
        (WebCore::formRead):
        (WebCore::setHTTPBody):
        (WebCore::httpBodyFromStream):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel):
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
        (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
        (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::~XMLHttpRequest):
        (WebCore::XMLHttpRequest::upload):
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::createRequest):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::networkError):
        (WebCore::XMLHttpRequest::abortError):
        (WebCore::XMLHttpRequest::didSendData):
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::optionalUpload):
        * xml/XMLHttpRequest.idl:
        * xml/XMLHttpRequestUpload.cpp: Added.
        (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
        (WebCore::XMLHttpRequestUpload::addEventListener):
        (WebCore::XMLHttpRequestUpload::removeEventListener):
        (WebCore::XMLHttpRequestUpload::dispatchEvent):
        (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
        (WebCore::XMLHttpRequestUpload::dispatchAbortEvent):
        (WebCore::XMLHttpRequestUpload::dispatchErrorEvent):
        (WebCore::XMLHttpRequestUpload::dispatchLoadEvent):
        (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent):
        (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
        * xml/XMLHttpRequestUpload.h: Added.
        (WebCore::XMLHttpRequestUpload::create):
        (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
        (WebCore::XMLHttpRequestUpload::associatedXMLHttpRequest):
        (WebCore::XMLHttpRequestUpload::disconnectXMLHttpRequest):
        (WebCore::XMLHttpRequestUpload::setOnAbortListener):
        (WebCore::XMLHttpRequestUpload::onAbortListener):
        (WebCore::XMLHttpRequestUpload::setOnErrorListener):
        (WebCore::XMLHttpRequestUpload::onErrorListener):
        (WebCore::XMLHttpRequestUpload::setOnLoadListener):
        (WebCore::XMLHttpRequestUpload::onLoadListener):
        (WebCore::XMLHttpRequestUpload::setOnLoadStartListener):
        (WebCore::XMLHttpRequestUpload::onLoadStartListener):
        (WebCore::XMLHttpRequestUpload::setOnProgressListener):
        (WebCore::XMLHttpRequestUpload::onProgressListener):
        (WebCore::XMLHttpRequestUpload::eventListeners):
        (WebCore::XMLHttpRequestUpload::refEventTarget):
        (WebCore::XMLHttpRequestUpload::derefEventTarget):
        * xml/XMLHttpRequestUpload.idl: Added.

LayoutTests:

2008-07-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        <rdar://problem/6084585> Investigate upload progress events

        * fast/dom/Window/window-properties-expected.txt:
        * http/tests/xmlhttprequest/upload-onload-event-expected.txt: Added.
        * http/tests/xmlhttprequest/upload-onload-event.html: Added.
        * http/tests/xmlhttprequest/upload-onloadstart-event-expected.txt: Added.
        * http/tests/xmlhttprequest/upload-onloadstart-event.html: Added.
        * http/tests/xmlhttprequest/upload-onprogress-event-expected.txt: Added.
        * http/tests/xmlhttprequest/upload-onprogress-event.html: Added.
        * http/tests/xmlhttprequest/upload-progress-events-expected.txt: Added.
        * http/tests/xmlhttprequest/upload-progress-events.html: Added.
        * platform/win/Skipped: Skip new tests on windows where the feature is not
        implemented yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 Maxime Britto <britto@apple.com>
britto@apple.com [Tue, 29 Jul 2008 23:33:49 +0000 (23:33 +0000)]
2008-07-29  Maxime Britto  <britto@apple.com>

        Reviewed by Darin.

        <rdar://problem/6095023> "When pan-scrolling, mouse click on hyperlink stop the pan-Scroll but follow the link after that."
        With this patch we now stop the pan scroll and swallow the event to prevent any following action.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent): If we were in pan scrolling mode we no longer just stop the pan scroll and continue with the function, we now stop and return true to attest that we swallowed the event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 Maxime Britto <britto@apple.com>
britto@apple.com [Tue, 29 Jul 2008 22:59:18 +0000 (22:59 +0000)]
2008-07-29  Maxime Britto  <britto@apple.com>

        Reviewed by adele.

        Test: fast/events/autoscroll-in-textfield.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::canBeProgramaticallyScrolled): reverted a bad change introduced in r35244
        nb:the test case introduced in r35244 is still working.

2008-07-29  Maxime Britto  <britto@apple.com>

        Reviewed by adele.
        This test verifies that the autoscroll works within textfields.

        * fast/events/autoscroll-in-textfield-expected.txt: Added.
        * fast/events/autoscroll-in-textfield.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to fix the Qt build.
mrowe@apple.com [Tue, 29 Jul 2008 22:47:42 +0000 (22:47 +0000)]
Attempt to fix the Qt build.

* wtf/ThreadingQt.cpp: Add the extra argument to createThread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Mark Rowe.
mitz@apple.com [Tue, 29 Jul 2008 22:38:53 +0000 (22:38 +0000)]
    Rubber-stamped by Mark Rowe.

        - update results for console.group and console.groupEnd

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTweak to the build fix to keep Dan happy.
mrowe@apple.com [Tue, 29 Jul 2008 20:58:51 +0000 (20:58 +0000)]
Tweak to the build fix to keep Dan happy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Tue, 29 Jul 2008 20:28:19 +0000 (20:28 +0000)]
WebCore:

2008-07-29  Adele Peterson  <adele@apple.com>

        Reviewed by Sammy Weinig.

        Fix for <rdar://problem/6103024>
        When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video

        Test: media/video-click-dlbclick-standalone.html

        * loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler): For standalone media documents,
        match the default Quicktime plugin behavior to allow clicking and double-clicking to pause and play the media.
        * loader/MediaDocument.h: Added defaultEventHandler.

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler): Return early if the event has been handled.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Correct what was probably a typo.  Instead of "event->defaultHandled()",
         it is supposed to be "event->setDefaultHandled()".
        (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.

LayoutTests:

2008-07-29  Adele Peterson  <adele@apple.com>

        Reviewed by Sammy Weinig.

        Test for <rdar://problem/6103024>
        When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video

        * media/video-click-dlbclick-standalone-expected.txt: Added.
        * media/video-click-dlbclick-standalone.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
mrowe@apple.com [Tue, 29 Jul 2008 20:13:40 +0000 (20:13 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 29 Jul 2008 18:55:14 +0000 (18:55 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com

        Test: fast/overflow/float-in-relpositioned.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::lowestPosition): Add this block's relative offset
        to floats' and positioned objects' lowest position.
        (WebCore::RenderBlock::rightmostPosition): Ditto.
        (WebCore::RenderBlock::leftmostPosition): Ditto.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::lowestPosition): Removed redundant test.
        (WebCore::RenderBox::rightmostPosition): Ditto.
        (WebCore::RenderBox::leftmostPosition): Ditto.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test, updated test and results for <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com

        * fast/overflow/float-in-relpositioned.html: Added.
        * fast/repaint/containing-block-position-change.html: Changed to avoid
        a full repaint due to a scroll bar appearing.
        * platform/mac/fast/clip/015-expected.txt:
        * platform/mac/fast/overflow/float-in-relpositioned-expected.checksum: Added.
        * platform/mac/fast/overflow/float-in-relpositioned-expected.png: Added.
        * platform/mac/fast/overflow/float-in-relpositioned-expected.txt: Added.
        * platform/mac/fast/repaint/clipped-relative-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 29 Jul 2008 18:51:34 +0000 (18:51 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6048566> Repaint original element's position, not its offset position

        Test: fast/repaint/layout-state-relative.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition): Changed the LayoutState-enabled
        code path to account for the object's relative offset.
        (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.

LayoutTests:

        Reviewed by Dave Hyatt.

        - repaint test for <rdar://problem/6048566> Repaint original element's position, not its offset position

        * fast/repaint/layout-state-relative.html: Added.
        * platform/mac/fast/repaint/layout-state-relative-expected.checksum: Added.
        * platform/mac/fast/repaint/layout-state-relative-expected.png: Added.
        * platform/mac/fast/repaint/layout-state-relative-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Change Vector::find to return an index instead of an iterator
aroben@apple.com [Tue, 29 Jul 2008 18:51:26 +0000 (18:51 +0000)]
    Change Vector::find to return an index instead of an iterator

        Indices are more natural than iterators when working with Vector.

        Reviewed by John Sullivan.

        * wtf/Vector.h:
        (WTF::Vector::find): Changed to iterate the Vector manually and return
        the index of the found item, rather than an iterator. When the item
        could not be found, we return WTF::notFound.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@35424 268f45cc-cd09-0410...
hyatt@apple.com [Tue, 29 Jul 2008 18:28:13 +0000 (18:28 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 29 Jul 2008 18:27:22 +0000 (18:27 +0000)]
2008-07-29  David Hyatt  <hyatt@apple.com>

        Add a layout test for using multiple variable declaration blocks in a single style rule.

        * fast/css/variables/alternate-syntax/multiple-blocks-test.html: Added.
        * fast/css/variables/multiple-blocks-test.html: Added.
        * platform/mac/fast/css/variables/multiple-blocks-test-expected.checksum: Added.
        * platform/mac/fast/css/variables/multiple-blocks-test-expected.png: Added.
        * platform/mac/fast/css/variables/multiple-blocks-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Export detachThread
aroben@apple.com [Tue, 29 Jul 2008 18:10:07 +0000 (18:10 +0000)]
    Export detachThread

        Reviewed by Geoff Garen.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixed Bug 19158: Inspector should support console.group/console.groupEnd
timothy@apple.com [Tue, 29 Jul 2008 18:04:29 +0000 (18:04 +0000)]
    Fixed Bug 19158: Inspector should support console.group/console.groupEnd

        <https://bugs.webkit.org/show_bug.cgi?id=19158>

        Reviewed by Tim Hatcher and Adam Roben.

        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::group): Added.
        * page/Console.cpp:
        (WebCore::Console::group): Added.
        (WebCore::Console::groupEnd): Added.
        * page/Console.h:
        (WebCore::):
        * page/Console.idl: Added group/groupEnd.
        * page/InspectorController.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::InspectorController::InspectorController): Added m_groupLevel.
        (WebCore::InspectorController::addMessageToConsole): Added groupLevel argument.
        (WebCore::InspectorController::startGroup): Increments m_groupLevel by one and calls js function if needed.
        (WebCore::InspectorController::endGroup): Decrements m_groupLevel by one and calls js function if needed.
        (WebCore::InspectorController::addScriptConsoleMessage): Added groupLevel argument.
        (WebCore::InspectorController::didCommitLoad): Resets m_groupLevel.
        * page/InspectorController.h:
        * page/inspector/Console.js:
        (WebInspector.Console): Added groupLevel and currentGroup topGroup.
        (WebInspector.Console.addMessage): Calls addMessage method in the currentGroup.
        (WebInspector.Console.startGroup): Added.
        (WebInspector.Console.endGroup): Added.
        (WebInspector.Console.clearMessages): Resets groupLevel and currentGroup.
        (WebInspector.ConsoleMessage): Added groupLevel property.
        (WebInspector.ConsoleMessage.MessageLevel.GroupTitle): Added.
        (WebInspector.ConsoleGroup): Added.
        (WebInspector.ConsoleGroup.addMessage): Adds console message to group.
        (WebInspector.ConsoleGroup._titleClicked): Adds "collapsed" style class.
        * page/inspector/inspector.css:
        * page/inspector/inspector.js:
        (WebInspector.startGroupInConsole): Calls console.startGroup
        (WebInspector.endGroupInConsole): Calls console.endGroup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35421 268f45cc-cd09-0410-ab3c-d52691b4dbfc