darin [Mon, 2 Jul 2007 02:26:49 +0000 (02:26 +0000)]
* css/tokenizer.flex: Rolled out the fix for 14453.
The layout test wasn't passing. We'll try again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 2 Jul 2007 00:44:15 +0000 (00:44 +0000)]
Fix a crash in ~PluginViewWin()
This crash was introduced in r23827.
Reviewed by Anders.
Fixes dom/html/level2/html/HTMLAnchorElement01.html
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 1 Jul 2007 23:47:09 +0000 (23:47 +0000)]
LayoutTests:
Reviewed by Darin.
Regression test for:
http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone
* css2.1/hex-color-regression-expected.checksum: Added.
* css2.1/hex-color-regression-expected.png: Added.
* css2.1/hex-color-regression-expected.txt: Added.
* css2.1/hex-color-regression.html: Added.
WebCore:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone
* css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 1 Jul 2007 23:22:36 +0000 (23:22 +0000)]
Fixed a no-SVG test failure by removing a node that was affecting the test results differently
depending on whether SVG support was compiled in or not.
* fast/xpath/namespace-vs-predicate.xhtml: Remove the r_00 node at the end of the test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 23:01:11 +0000 (23:01 +0000)]
Fix some paths to make http tests work again on Windows
Rubberstamped by Sam.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 1 Jul 2007 17:38:29 +0000 (17:38 +0000)]
LayoutTests:
Reviewed by Oliver.
Third round of implicit 64-32 bit conversion errors fixes.
<rdar://problem/5292262>
getFloatValue() used to return a double and now returns a float for a small
loss of precision.
* fast/css/getFloatValueForUnit-expected.checksum:
* fast/css/getFloatValueForUnit-expected.png:
* fast/css/getFloatValueForUnit-expected.txt:
* fast/css/getFloatValueForUnit.html:
WebCore:
Reviewed by Oliver.
Third round of implicit 64-32 bit conversion errors fixes.
<rdar://problem/5292262>
- Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthInt):
(WebCore::CSSPrimitiveValue::computeLengthIntForLength):
(WebCore::CSSPrimitiveValue::computeLengthShort):
(WebCore::CSSPrimitiveValue::computeLengthFloat):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::getDoubleValue):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::getDoubleValue):
(WebCore::CSSPrimitiveValue::getFloatValue):
(WebCore::CSSPrimitiveValue::getIntValue):
* css/Counter.h:
(WebCore::Counter::listStyleNumber):
* css/MediaQueryEvaluator.cpp:
(WebCore::parseAspectRatio):
* css/cssparser.cpp:
(WebCore::BorderImageParseContext::commitBorderImage):
* css/cssstyleselector.cpp:
(WebCore::convertToLength):
(WebCore::applyCounterList):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapBackgroundSize):
(WebCore::CSSStyleSelector::mapBackgroundXPosition):
(WebCore::CSSStyleSelector::mapBackgroundYPosition):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute):
* ksvg2/css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* ksvg2/misc/KCanvasRenderingStyle.cpp:
(WebCore::KSVGPainterFactory::cssPrimitiveToLength):
(WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 1 Jul 2007 17:23:29 +0000 (17:23 +0000)]
Fixed a no-SVG test failure by moving a test that requires SVG into the svg directory.
* fast/dom/svg-element-attribute-js-null-expected.txt: Removed.
* fast/dom/svg-element-attribute-js-null.xhtml: Removed.
* svg/dom/svg-element-attribute-js-null-expected.txt: Copied from fast/dom/svg-element-attribute-js-null-expected.txt.
* svg/dom/svg-element-attribute-js-null.xhtml: Copied from fast/dom/svg-element-attribute-js-null.xhtml.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 1 Jul 2007 17:05:56 +0000 (17:05 +0000)]
Added a missing file for the test for <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
* fast/loader/resources/plist.app: Added. Just some random XML file I found somewhere; seems to make
the test succeed instead of failing every time!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 1 Jul 2007 15:52:59 +0000 (15:52 +0000)]
Roll out r23911 as it introduced two layout test failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 1 Jul 2007 14:26:02 +0000 (14:26 +0000)]
2007-07-01 Pamela Greene <pamg.bugs@gmail.com>
Reviewed by Darin.
Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>
Use std::stable_sort() instead of qsort() to sort gradient stops.
Adjust the comparison function accordingly.
* html/CanvasGradient.cpp:
(WebCore::compareStops):
(WebCore::CanvasGradient::findStop):
2007-07-01 Pamela Greene <pamg.bugs@gmail.com>
Reviewed by Darin.
Tests for <http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>
Add tests for various combinations of stops, including multiple stops at
the same offsets, sorted and unsorted. Update results accordingly.
* fast/canvas/fillrect_gradient-expected.checksum:
* fast/canvas/fillrect_gradient-expected.png:
* fast/canvas/fillrect_gradient-expected.txt:
* fast/canvas/fillrect_gradient.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 1 Jul 2007 14:20:13 +0000 (14:20 +0000)]
2007-07-01 MorganL <morganl.webkit@yahoo.com>
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14448
HTMLObjectElement::data should return an absolute URL
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isImageType):
(WebCore::HTMLObjectElement::data):
2007-07-01 MorganL <morganl.webkit@yahoo.com>
Reviewed by Darin.
Tests for http://bugs.webkit.org/show_bug.cgi?id=14448
HTMLObjectElement::data should return an absolute URL
* fast/dom/object-data-absurl-expected.txt: Added.
* fast/dom/object-data-absurl.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 1 Jul 2007 14:17:48 +0000 (14:17 +0000)]
2007-07-01 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin.
m_usesPageCache was not initialized. As the b/f cache is only
implemented in the Mac port and WebView.mm is taking care of calling
Settings::setUsesPageCache I decided to make it false by default.
* page/Settings.cpp:
(WebCore::Settings::Settings): m_usesPageCache was not initialized
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 1 Jul 2007 14:16:02 +0000 (14:16 +0000)]
2007-07-01 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin.
Inherited- and NonInheritedFlags is a bit field. But for comparsion
the other part of the union _iflags/_niflags is used for comparions.
This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
Make sure the unused bits have a specified value.
* ksvg2/css/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
have a value as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 1 Jul 2007 14:14:08 +0000 (14:14 +0000)]
2007-07-01 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=14481
Broken links on coding/lgpl-license.html
* coding/lgpl-license.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:53:35 +0000 (04:53 +0000)]
Compile WebCore with /W4 on Windows
Some more warnings were disabled globally, including assignment within
a conditional, unused variable, and various warnings related to
inability to instantiate opaque structs.
In addition, the "unreachable code" warning was turned off for
CSSGrammar.cpp and XPathGrammar.cpp.
Reviewed by Oliver.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:53:25 +0000 (04:53 +0000)]
Give CString an equality operator to fix a bug in HTMLFormElement::formData
WebCore:
Give CString an equality operator to fix a bug in HTMLFormElement::formData
The bug was spotted by MSVC /W4. The problem was that we were comparing
a CString to a char* using ==, but CString had no equality operator.
The result was that the CString was being cast to a const char* and a
pointer comparison was being done, which would (essentially) always
return false.
There are two parts to the fix: get rid of CString's const char*
casting operator, and add an equality operator. Previous uses of the
casting operator have been changed to use CString::data().
Test: http/misc/isindex-formdata.html
Reviewed by Oliver.
* dom/XMLTokenizer.cpp:
(WebCore::parseXMLDocumentFragment):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::determineParseMode):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formData):
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForCSSCharset):
* platform/CString.cpp:
(WebCore::operator==):
* platform/CString.h:
* platform/KURL.cpp:
(WebCore::encodeRelativeString):
* platform/StringImpl.cpp:
(WebCore::StringImpl::toDouble):
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::setHTTPBody):
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::setHTTPBody):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::markupToCF_HTML):
* plugins/win/PluginPackageWin.cpp:
(WebCore::splitString):
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::startStream):
(WebCore::PluginStreamWin::destroyStream):
(WebCore::PluginStreamWin::sendJavaScriptStream):
(WebCore::PluginStreamWin::didFinishLoading):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::start):
(WebCore::createUTF8String):
(WebCore::PluginViewWin::userAgent):
* xml/XSLStyleSheet.cpp:
(WebCore::XSLStyleSheet::locateStylesheetSubResource):
* xml/XSLTProcessor.cpp:
(WebCore::xsltParamArrayFromParameterMap):
LayoutTests:
New test that makes sure we handle putting isindex into form data correctly.
Reviewed by Oliver.
* http/tests/misc/isindex-formdata-expected.txt: Added.
* http/tests/misc/isindex-formdata.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:53:11 +0000 (04:53 +0000)]
Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
Reviewed by John.
* editing/Editor.cpp:
(WebCore::Editor::advanceToNextMisspelling):
* html/HTMLParser.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:53:01 +0000 (04:53 +0000)]
Fix some possibly unitialized variables found by MSVC /W4
Reviewed by John.
* rendering/bidi.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:52:52 +0000 (04:52 +0000)]
Remove bogus cast found by MSVC /W4
Reviewed by John and Oliver.
* ksvg2/css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:52:42 +0000 (04:52 +0000)]
Remove unused local functions uncovered by MSVC /W4
Reviewed by John and Oliver.
* platform/win/SearchPopupMenuWin.cpp:
* rendering/RenderText.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:52:32 +0000 (04:52 +0000)]
Don't take the address of temporary values to appease MSVC /W4
Reviewed by Oliver.
No regression test possible.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::invalidateItem):
(WebCore::PopupMenu::valueChanged):
(WebCore::PopupWndProc):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
* platform/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::invalidateRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:52:21 +0000 (04:52 +0000)]
Make an int -> UINT conversion explicit that MSVC /W4 complains about
Reviewed by John and Oliver.
No regression test possible.
* platform/win/SoundWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 1 Jul 2007 04:51:57 +0000 (04:51 +0000)]
Remove unreachable code uncovered by MSVC /W4
Reviewed by Oliver.
No regression test possible.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isLiveLink):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::contentEditable):
* platform/DeprecatedString.cpp:
(WebCore::allocateHandle):
(WebCore::freeHandle):
* plugins/win/npapi.cpp:
(pluginViewForInstance):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::isWidthSpecified):
(WebCore::RenderImage::isHeightSpecified):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 30 Jun 2007 18:08:19 +0000 (18:08 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Sat, 30 Jun 2007 16:29:54 +0000 (16:29 +0000)]
WebCore:
Reviewed by Oliver Hunt.
- WebCore support for accessing the set of rectangles that encompass the selected text
* page/Frame.h:
* page/Frame.cpp:
(WebCore::Frame::selectionTextRects):
new function, fills in a passed Vector with the line box rects that represent the selected range
* rendering/RenderText.cpp:
(WebCore::RenderText::addLineBoxRects):
fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
* WebCore.exp:
exported symbol for this new function
WebKit:
Reviewed by Oliver Hunt.
- WebKit support for accessing the set of rectangles that encompass the selected text
* WebView/WebDocumentPrivate.h:
added -selectionTextRects to WebDocumentSelection protocol; tweaked comments
* WebView/WebHTMLView.mm:
(-[WebHTMLView _selectionDraggingRect]):
use selectionRect instead of selectionImageRect since they're the same and maybe we can get
rid of selectionImageRect someday
(-[WebHTMLView selectionTextRects]):
added implementation of new protocol method, which calls through to WebCore
* WebView/WebPDFView.mm:
(-[WebPDFView selectionTextRects]):
added simple implementation of new protocol method, which just returns the single selection rect.
PDFKit doesn't support obtaining multiple rects to describe a multi-line selection.
(-[WebPDFView selectionImageForcingWhiteText:]):
use selectionRect instead of selectionImageRect since they're the same and maybe we can get
rid of selectionImageRect someday
* Misc/WebSearchableTextView.m:
(-[WebSearchableTextView selectionTextRects]):
added no-op implementation of new protocol method to this obsolete class
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 30 Jun 2007 03:35:39 +0000 (03:35 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 29 Jun 2007 21:56:00 +0000 (21:56 +0000)]
LayoutTests:
Reviewed by Harrison.
<rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
Backing out a change made in r23787.
* editing/deleting/4845371-expected.txt:
* editing/deleting/4845371.html:
* editing/deleting/5126166-expected.txt:
* editing/deleting/5290534.html: Removed.
* editing/deleting/5290534.html-disabled: Added.
WebCore:
Reviewed by Harrison.
<rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
Rolled out a change made in r23787.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 29 Jun 2007 21:45:36 +0000 (21:45 +0000)]
LayoutTests:
Reviewed by Darin Adler, Anders Carlsson.
Test for <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
returns NULL if response MIME type is not XML -- breaks Wikipedia widget
* fast/loader/xmlhttprequest-bad-mimetype-expected.txt: Added.
* fast/loader/xmlhttprequest-bad-mimetype.html: Added.
WebCore:
Reviewed by Darin Adler, Anders Carlsson.
Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
returns NULL if response MIME type is not XML -- breaks Wikipedia widget
The spec says that responseXML must return null for any HTTP response
with a non-XML MIME type. Technically, that leaves non-HTTP responses
free to do whatever they want.
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
MIME types if the response was HTTP.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 29 Jun 2007 21:36:10 +0000 (21:36 +0000)]
JavaScriptCore:
Reviewed by Darin.
Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Add a toFloat() method to JSValue for float conversion.
* JavaScriptCore.exp:
* kjs/value.cpp:
(KJS::JSValue::toFloat):
* kjs/value.h:
WebCore:
Reviewed by Darin.
Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Use new JSValue::toFloat() method instead of toNumber() where
appropriate.
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::strokeRect):
(WebCore::JSCanvasRenderingContext2D::drawImage):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
* bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove):
* bindings/js/JSSVGMatrixCustom.cpp:
(WebCore::JSSVGMatrix::rotateFromVector):
* bindings/js/kjs_events.cpp:
(KJS::JSClipboardPrototypeFunction::callAsFunction):
* bindings/scripts/CodeGeneratorJS.pm:
* ksvg2/svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::executeScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 29 Jun 2007 21:29:05 +0000 (21:29 +0000)]
LayoutTests:
Rolling out tests for <rdar://problem/5301322>.
* fast/forms/input-readonly-select-all-expected.checksum: Removed.
* fast/forms/input-readonly-select-all-expected.png: Removed.
* fast/forms/input-readonly-select-all-expected.txt: Removed.
* fast/forms/input-readonly-select-all.html: Removed..
* fast/forms/textarea-readonly-select-all-expected.checksum: Removed.
* fast/forms/textarea-readonly-select-all-expected.png: Removed.
* fast/forms/textarea-readonly-select-all-expected.txt: Removed.
* fast/forms/textarea-readonly-select-all.html: Removed.
WebCore:
Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 29 Jun 2007 20:37:00 +0000 (20:37 +0000)]
LayoutTests:
Reviewed by Oliver Hunt.
Layout tests for <rdar://problem/4962298> REGRESSION: Synchronous XHR for
missing local file throws exception -- breaks Wikipedia widget
* fast/loader/xmlhttprequest-missing-file-exception-expected.txt: Added.
* fast/loader/xmlhttprequest-missing-file-exception.html: Added.
WebCore:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing
local file throws exception -- breaks Wikipedia widget
* WebCore.xcodeproj/project.pbxproj:
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Fri, 29 Jun 2007 19:22:34 +0000 (19:22 +0000)]
2007-06-29 Ada Chan <adachan@apple.com>
Reviewed by Adam.
Fixed a previous fix to a signed/unsigned mismatch.
* plugins/win/PluginPackageWin.cpp:
(WebCore::splitString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 29 Jun 2007 18:15:40 +0000 (18:15 +0000)]
LayoutTests:
Reviewed by Ada and Kevin McCullough.
Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
* fast/forms/input-readonly-select-all-expected.checksum: Added.
* fast/forms/input-readonly-select-all-expected.png: Added.
* fast/forms/input-readonly-select-all-expected.txt: Added.
* fast/forms/input-readonly-select-all.html: Added.
* fast/forms/textarea-readonly-select-all-expected.checksum: Added.
* fast/forms/textarea-readonly-select-all-expected.png: Added.
* fast/forms/textarea-readonly-select-all-expected.txt: Added.
* fast/forms/textarea-readonly-select-all.html: Added.
WebCore:
Reviewed by Ada and Kevin McCullough.
Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
Tests:
fast/forms/input-readonly-select-all.html
fast/forms/textarea-readonly-select-all.html
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::canSelectAll):
(WebCore::HTMLInputElement::selectAll):
* html/HTMLTextAreaElement.h:
(WebCore::HTMLTextAreaElement::canSelectAll):
(WebCore::HTMLTextAreaElement::selectAll):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 29 Jun 2007 17:58:17 +0000 (17:58 +0000)]
Build fix
This is what happens when you test your patch on two OSs and then
commit from the wrong one.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::valueChanged):
(WebCore::RenderTextControl::itemText):
(WebCore::RenderTextControl::itemIsSeparator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 29 Jun 2007 17:50:47 +0000 (17:50 +0000)]
Start compiling WebCore with /W3 under MSVC
One warning was globally disabled: implicit conversion of int to bool.
Reviewed by Darin.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 29 Jun 2007 17:50:37 +0000 (17:50 +0000)]
Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
DeprecatedStringData now has no public copy constructor. The single
call to the old one has been replaced with a call to the new
DeprecatedStringData::createAndAdopt static method.
Reviewed by Darin.
All regression tests pass.
* platform/DeprecatedString.cpp:
(WebCore::DeprecatedStringData::createAndAdopt):
(WebCore::DeprecatedStringData::adopt):
(WebCore::DeprecatedString::detachIfInternal):
* platform/DeprecatedString.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 29 Jun 2007 17:50:27 +0000 (17:50 +0000)]
Fix more signed/unsigned mismatches uncovered by MSVC /W3
Reviewed by John.
No regression tests possible.
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::filenameHasSaneExtension):
* platform/win/FontDataWin.cpp:
(WebCore::FontData::containsCharacters):
* platform/win/PlatformScrollBarSafari.cpp:
(WebCore::):
* platform/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/win/WebCoreTextRenderer.cpp:
(WebCore::doDrawTextAtPoint):
* plugins/win/PluginDatabaseWin.cpp:
(WebCore::parseVersionString):
* plugins/win/PluginPackageWin.cpp:
(WebCore::splitString):
* plugins/win/PluginViewWin.cpp:
(WebCore::freeStringArray):
(WebCore::PluginViewWin::invalidateTimerFired):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 29 Jun 2007 17:50:16 +0000 (17:50 +0000)]
Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
Reviewed by John.
No regression test possible.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
* platform/PopupMenuClient.h:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::focusFirst):
(WebCore::PopupMenu::focusLast):
(WebCore::PopupMenu::down):
(WebCore::PopupMenu::up):
(WebCore::PopupMenu::paint):
* rendering/RenderMenuList.cpp:
* rendering/RenderMenuList.h:
* rendering/RenderTextControl.cpp:
* rendering/RenderTextControl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 29 Jun 2007 17:50:05 +0000 (17:50 +0000)]
Fix two typos spotted by MSVC /W3
Both typos were a semicolon following the condition of an if. This
would cause the intended body of the if to always execute.
Unfortunately neither of these fixes are testable.
BackForwardList::goForward is only called from WebBackForwardList, and
the createDragImageFromImage bug would only manifest itself when
CreateCompatibleDC failed.
Reviewed by Mark.
* history/BackForwardList.cpp:
(WebCore::BackForwardList::goForward):
* platform/win/DragImageWin.cpp:
(WebCore::createDragImageFromImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Fri, 29 Jun 2007 14:19:17 +0000 (14:19 +0000)]
Patch from Adam Treat to improve scroll wheel support for Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 29 Jun 2007 08:18:35 +0000 (08:18 +0000)]
Reviewed by Maciej.
Added WKQTMovieDataRate and WKQTMovieMaxTimeLoaded
* WebKitSystemInterface.h:
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 29 Jun 2007 05:49:36 +0000 (05:49 +0000)]
Get WebCore compiling with /W2 on Windows
Reviewed by Steve.
No regression tests affected.
* WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
disable two warnings: implicit int <=> float conversion, and class vs.
struct inconsistency.
* dom/CharacterData.cpp:
(WebCore::CharacterData::deleteData): Cast to int before negating.
* loader/Cache.cpp:
(WebCore::Cache::remove): Ditto.
* platform/graphics/Path.cpp:
(WebCore::pathLengthApplierFunction): Consistently use floats.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawEllipse): Ditto.
* platform/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 29 Jun 2007 04:16:57 +0000 (04:16 +0000)]
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease
pool => pathologically high high water mark
I couldn't measure any performance problems with iBench HTML or PLT.
* WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
* platform/mac/SharedTimerMac.cpp:
(WebCore::timerFired): Added autorelease pool.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 29 Jun 2007 02:46:23 +0000 (02:46 +0000)]
LayoutTests:
Reviewed by Beth.
- test for http://bugs.webkit.org/show_bug.cgi?id=14118
ASSERTION FAILED: !needsLayout() seen again
* fast/dynamic/recursive-layout-expected.txt: Added.
* fast/dynamic/recursive-layout.html: Added.
WebCore:
Reviewed by Beth.
- fix http://bugs.webkit.org/show_bug.cgi?id=14118
ASSERTION FAILED: !needsLayout() seen again
Test: fast/dynamic/recursive-layout.html
* page/FrameView.cpp:
(WebCore::FrameView::layout): Removed the midLayout guards around
the calls to invalidateSelection() and updateWidgetPositions(). Those
calls may dirty the layout, but in that case they also update it, so
they should be allowed to do it. Added an ASSERT to make sure that when
they return, the root is not marked for layout.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis [Fri, 29 Jun 2007 01:05:20 +0000 (01:05 +0000)]
Reviewed by Adam,
Allow tests to use pre-built roots instead of building the tests.
* Scripts/run-javascriptcore-tests: added --root option
* Scripts/run-webkit-tests: added --root option
* Scripts/webkitdirs.pm: added support for using a root
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 29 Jun 2007 00:06:27 +0000 (00:06 +0000)]
Reviewed by Darin.
<rdar://problem/5287569> WEBVIEW: Creating a webview in IB 3.0 (v2.0) NIB later crashes Interface Builder 2.5.4 on Tiger
Prevent encoding any of the WebView subviews. The subviews are ignored by -[WebView initWithCoder:] and will be recreated.
The Tiger 2.0 code crashed when the WebView released the subviews in initWithCoder:, so now there are no subviews to release.
This never happened before because the Tiger 2.0 code and IB wouldn't encode a WebView that has a WebHTMLView.
* WebView/WebView.mm:
(-[WebView encodeWithCoder:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 23:02:18 +0000 (23:02 +0000)]
LayoutTests:
Rubberstamped by Adam Roben.
Roll out r23861. It caused the buildbot to fail on intel.
* http/tests/navigation/goBack-blank-tab-page-expected.txt: Removed.
* http/tests/navigation/goBack-blank-tab-page.html: Removed.
* http/tests/navigation/resources/before-go-back.html: Removed.
* http/tests/navigation/resources/will-go-back.html: Removed.
WebCore:
Rubberstamped by Adam Roben.
Roll out r23861. It caused the buildbot to fail on intel.
* page/Page.cpp:
(WebCore::Page::goToItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 21:08:16 +0000 (21:08 +0000)]
LayoutTests:
Reviewed by Geoff.
Tests for http://bugs.webkit.org/show_bug.cgi?id=13038
ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
Although the test works with the script, it can't detect an eventually
error automatically since the first link must be opened in a new tab with
a _blank target to reproduce the crash. So it should be launched manually
following the steps decribed in there, then it's effective.
* http/tests/navigation/goBack-blank-tab-page-expected.txt: Added.
* http/tests/navigation/goBack-blank-tab-page.html: Added.
* http/tests/navigation/resources/before-go-back.html: Added.
* http/tests/navigation/resources/will-go-back.html: Added.
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
Modification of an ASSERT on goToItem related to go back/forward in
history.Don't need to check the frameset if the target is _blank.
* page/Page.cpp:
(WebCore::Page::goToItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 28 Jun 2007 20:16:54 +0000 (20:16 +0000)]
Tabs are bad
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 28 Jun 2007 20:13:50 +0000 (20:13 +0000)]
Remove tests that don't need to be skipped anymore.
* win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 28 Jun 2007 19:46:14 +0000 (19:46 +0000)]
Reviewed by Oliver.
<rdar://problem/5234139>
<object> with PNG src rendered as image document.
Complete the URL before passing it to the frame loader client.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isImageType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 28 Jun 2007 16:59:36 +0000 (16:59 +0000)]
Forgot committing this change in my previous commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 28 Jun 2007 16:00:29 +0000 (16:00 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14373
CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
Make sure the id selector validates against the CSS2.1 identfier
definition, not the hexcolor/HASH definition.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 28 Jun 2007 14:44:27 +0000 (14:44 +0000)]
Propagate mouse double click events from Qt to WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 28 Jun 2007 14:16:42 +0000 (14:16 +0000)]
Implemented clipboard functions in QWebPage, in particular can(Cut|Copy|Paste), cut/copy/paste as slot as well as a selectionChanged() signal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 28 Jun 2007 14:16:31 +0000 (14:16 +0000)]
Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Thu, 28 Jun 2007 13:54:25 +0000 (13:54 +0000)]
LayoutTests:
Reviewed by Mitz.
Test changes for http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>
- expand empty-cells.html to cover non-zero cellpadding case too
- update other related tests (none of these affect pixel results)
* fast/css/acid2-expected.txt:
* fast/css/acid2-pixel-expected.txt:
* fast/table/032-expected.txt:
* fast/table/empty-cells-expected.checksum:
* fast/table/empty-cells-expected.png:
* fast/table/empty-cells-expected.txt:
* fast/table/empty-cells.html:
* fast/table/empty-section-crash-expected.txt:
* http/tests/misc/acid2-expected.txt:
* http/tests/misc/acid2-pixel-expected.txt:
* tables/mozilla/bugs/bug222467-expected.txt:
* tables/mozilla/bugs/bug78162-expected.txt:
WebCore:
Reviewed by Mitz.
Fix http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>
Cells in table with non-zero cellpadding are not considered empty.
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 28 Jun 2007 07:48:16 +0000 (07:48 +0000)]
Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
Reviewed by Hyatt.
No layout test possible, as this bug didn't have any effect since
"bool & bool" has the same value as "bool && bool"
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject): Changed & to &&.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 28 Jun 2007 07:30:39 +0000 (07:30 +0000)]
Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
WebCore:
Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
The bug was caused by two typos found by prefast.
Reviewed by Hyatt.
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue): Fixed typos.
LayoutTests:
New test for <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
Reviewed by Hyatt.
* fast/css/word-break-user-modify-allowed-values-expected.txt: Added.
* fast/css/word-break-user-modify-allowed-values.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Thu, 28 Jun 2007 06:53:45 +0000 (06:53 +0000)]
JavaScriptCore:
Reviewed by Darin.
- <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
- Correctly evaluate the return value of _pcre_ucp_findchar.
* pcre/pcre_compile.c:
(compile_branch):
* pcre/pcre_exec.c:
(match):
LayoutTests:
Reviewed by Darin.
- <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
- Correctly evaluate the return value of _pcre_ucp_findchar.
* fast/js/regexp-unicode-overflow-expected.txt: Added.
* fast/js/regexp-unicode-overflow.html: Added.
* fast/js/resources/regexp-unicode-overflow.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 28 Jun 2007 06:18:24 +0000 (06:18 +0000)]
2007-06-20 Matt Perry <mpComplete@gmail.com>
Reviewed by Adam.
- Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
onchange handler for select controls doesn't fire when changing via keyboard
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
a call to saveLastSelection in the "Enter" key handler for select
controls that was preventing onchange from firing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 06:01:41 +0000 (06:01 +0000)]
Yet another build fix :(
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 05:32:45 +0000 (05:32 +0000)]
Fix Gdk, Qt, and Win32 builds.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 05:25:59 +0000 (05:25 +0000)]
LayoutTests:
Reviewed by Geoff.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings
* fast/dom/Window/window-properties-expected.txt:
* fast/js/toString-and-valueOf-override-expected.txt:
* http/tests/security/cross-frame-access-expected.txt:
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings
- Renames JS Object Selection to DOMSelection to avoid a name
conflict.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/kjs_window.cpp:
(KJS::WindowPrivate::WindowPrivate):
(KJS::Window::mark):
(KJS::Window::clearHelperObjectProperties):
(KJS::WindowFunc::callAsFunction):
(KJS::Window::disconnectFrame):
* bindings/js/kjs_window.h:
(KJS::Window::):
* page/DOMSelection.cpp: Added.
(WebCore::DOMSelection::DOMSelection):
(WebCore::DOMSelection::frame):
(WebCore::DOMSelection::disconnectFrame):
(WebCore::DOMSelection::anchorNode):
(WebCore::DOMSelection::baseNode):
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::focusNode):
(WebCore::DOMSelection::extentNode):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::extentOffset):
(WebCore::DOMSelection::isCollapsed):
(WebCore::DOMSelection::type):
(WebCore::DOMSelection::rangeCount):
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::collapseToEnd):
(WebCore::DOMSelection::collapseToStart):
(WebCore::DOMSelection::empty):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::setPosition):
(WebCore::DOMSelection::modify):
(WebCore::DOMSelection::getRangeAt):
(WebCore::DOMSelection::removeAllRanges):
(WebCore::DOMSelection::addRange):
(WebCore::DOMSelection::toString):
* page/DOMSelection.h: Added.
* page/DOMSelection.idl: Added.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::disconnectFrame):
(WebCore::DOMWindow::getSelection):
* page/DOMWindow.h:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 03:34:49 +0000 (03:34 +0000)]
Reviewed by Maciej.
2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding
- Cleanup kjs_events
* bindings/js/kjs_events.cpp:
(WebCore::JSAbstractEventListener::JSAbstractEventListener):
(WebCore::JSAbstractEventListener::handleEvent):
(WebCore::JSAbstractEventListener::isHTMLEventListener):
(WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
(WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
(WebCore::JSUnprotectedEventListener::listenerObj):
(WebCore::JSUnprotectedEventListener::windowObj):
(WebCore::JSUnprotectedEventListener::clearWindowObj):
(WebCore::JSUnprotectedEventListener::mark):
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSEventListener::listenerObj):
(WebCore::JSEventListener::windowObj):
(WebCore::JSEventListener::clearWindowObj):
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::listenerObj):
(WebCore::JSLazyEventListener::parseCode):
(WebCore::getNodeEventListener):
(WebCore::JSClipboard::JSClipboard):
(WebCore::JSClipboard::getValueProperty):
(WebCore::JSClipboard::putValueProperty):
(WebCore::JSClipboardPrototypeFunction::callAsFunction):
(WebCore::toJS):
(WebCore::toClipboard):
* bindings/js/kjs_events.h:
(WebCore::JSClipboard::classInfo):
(WebCore::JSClipboard::impl):
* bindings/js/kjs_window.h:
* ksvg2/events/JSSVGLazyEventListener.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 03:19:46 +0000 (03:19 +0000)]
LayoutTests:
Reviewed by Adam Roben.
Tests for http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>
* fast/forms/thumbslider-crash-expected.checksum: Added.
* fast/forms/thumbslider-crash-expected.png: Added.
* fast/forms/thumbslider-crash-expected.txt: Added.
* fast/forms/thumbslider-crash.html: Added.
* fast/forms/thumbslider-no-parent-slider-expected.checksum: Added.
* fast/forms/thumbslider-no-parent-slider-expected.png: Added.
* fast/forms/thumbslider-no-parent-slider-expected.txt: Added.
* fast/forms/thumbslider-no-parent-slider.html: Added.
WebCore:
Reviewed by Adam Roben.
Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>
Test: fast/forms/thumbslider-no-parent-slider.html
Test: fast/forms/thumbslider-crash.html
* rendering/RenderObject.h:
(WebCore::RenderObject::isSlider):
* rendering/RenderSlider.h:
(WebCore::RenderSlider::isSlider):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Only paint thumbslider
if the parent renderer is a RenderSlider.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintSliderThumb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 28 Jun 2007 01:50:40 +0000 (01:50 +0000)]
Missed this file as part of #23832
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 28 Jun 2007 01:36:24 +0000 (01:36 +0000)]
Make Qt builds link when XSLT is disabled
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Thu, 28 Jun 2007 00:23:10 +0000 (00:23 +0000)]
Turn on static code analysis (Windows only).
Affects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.
Reviewed by Oliver.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 28 Jun 2007 00:04:26 +0000 (00:04 +0000)]
Remove files that no longer exist (were commented out)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 23:14:04 +0000 (23:14 +0000)]
revert IDL change until the code generator is fixed
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 27 Jun 2007 23:08:03 +0000 (23:08 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/5247341> REGRESSION: Pasting sometimes loses trailing newline
Demonstrates the bug:
* editing/pasteboard/5247341-expected.checksum: Added.
* editing/pasteboard/5247341-expected.png: Added.
* editing/pasteboard/5247341-expected.txt: Added.
* editing/pasteboard/5247341.html: Added.
The changes in this patch exposed three bugs (5296964, 5296977, and 5299425).
Added FIXMES for them. Also removed tabs in them:
* editing/pasteboard/paste-table-003-expected.checksum:
* editing/pasteboard/paste-table-003-expected.png:
* editing/pasteboard/paste-table-003-expected.txt:
* editing/pasteboard/paste-table-003.html:
* fast/forms/textarea-paste-newline.html:
Equivalent trees:
* editing/pasteboard/paste-text-016-expected.txt:
* editing/pasteboard/paste-text-017-expected.txt:
WebCore:
Reviewed by John.
<rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
Pasting with a trailing interchange newline doesn't work when pasting
into an empty line. Code that handles removing brs at the insertion
position tries to also handle trailing interchange newlines by re-using
those brs and fails. Removed that code and handle all interchange
newlines with code later in doApply().
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
endBR when there's a trailing interchange newline.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 22:21:55 +0000 (22:21 +0000)]
Use the proper macros so that it builds with !SVG and !XPATH
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 22:06:14 +0000 (22:06 +0000)]
Fix compilation with various Qt configurations
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 22:05:14 +0000 (22:05 +0000)]
Fix ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 22:01:04 +0000 (22:01 +0000)]
Turn on static code analysis.
Reviewed by Oliver.
Effects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.
* CodeAnalysisConfig.h: Added.
* WebKit.vcproj/WebKit.vcproj:
* WebLocalizableStrings.cpp:
(createWebKitBundle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 21:55:41 +0000 (21:55 +0000)]
Prefast: Remove variable redefinitions in inner scopes.
Reviewed by Ada.
* WebDownload.cpp:
(WebDownload::didFinish):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::removeObserver):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 21:28:40 +0000 (21:28 +0000)]
Remove SEH block from around history plist read, since the underlying bug has been fixed.
Reviewed by Darin.
* WebHistory.cpp:
(createHistoryListFromStream):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 27 Jun 2007 21:27:23 +0000 (21:27 +0000)]
Reviewed by Oliver.
<rdar://problem/5253950>
When Shockwave plugin has been loaded, exiting crashes Safari
Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackageWin::PluginPackageWin):
(WebCore::PluginPackageWin::load):
(WebCore::PluginPackageWin::unload):
(WebCore::PluginPackageWin::unloadWithoutShutdown):
* plugins/win/PluginPackageWin.h:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::~PluginViewWin):
Make sure to unload the plugin package and clear any references to plugin script objects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 20:45:36 +0000 (20:45 +0000)]
We were compiling purely out of luck, but if qmake sets up the build order
slightly differently it fails. This forces a dependency to generate HTMLNames.h
in time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 20:13:27 +0000 (20:13 +0000)]
Patch from Eli Fidler to compile when QT_NO_IMAGE_TEXT is defined.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 20:06:38 +0000 (20:06 +0000)]
Patch from Eli Fidler to remove QT3_SUPPORT dependency in ICO handler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 27 Jun 2007 20:04:48 +0000 (20:04 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
Splits a quoted list w/o splitting a list item:
* editing/execCommand/4580583-1-expected.checksum: Added.
* editing/execCommand/4580583-1-expected.png: Added.
* editing/execCommand/4580583-1-expected.txt: Added.
* editing/execCommand/4580583-1.html: Added.
Split a quoted list item:
* editing/execCommand/4580583-2-expected.checksum: Added.
* editing/execCommand/4580583-2-expected.png: Added.
* editing/execCommand/4580583-2-expected.txt: Added.
* editing/execCommand/4580583-2.html: Added.
WebCore:
Reviewed by John.
<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
When a quoted numbered list is broken in half, it's cloned
to make the second list. That second list needs its start attribute
set so that the numbers of the list items in it will be preserved.
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
of a cloned list to be the original number of the first list item in it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 17:28:39 +0000 (17:28 +0000)]
Prefast: Fix misplaced parenthesis.
Reviewed by Darin.
* WebView.cpp:
(core):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 27 Jun 2007 17:21:46 +0000 (17:21 +0000)]
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=14413
GIF animation throttling is different from MSIE
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
Change the cut-off value to 50ms to match MSIE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 27 Jun 2007 17:15:37 +0000 (17:15 +0000)]
Reviewed by Darin
- WebKit support for displaying multiple text matches in PDF views (<rdar://problem/4601967>)
* WebView/WebPDFView.h:
new ivars textMatches and lastScrollPosition; now conforms to WebMultipleTextMatches protocol
* WebView/WebPDFView.mm:
(-[WebPDFView dealloc]):
release textMatches
(-[WebPDFView viewDidMoveToWindow]):
start observing bounds changes in the PDF document's enclosing clip view, so we can notice when
scrolling takes place
(-[WebPDFView viewWillMoveToWindow:]):
stop observing bounds changes in the PDF document's enclosing clip view
(-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
most of the code here has been moved into the new method _nextMatchFor::::, which this now calls
(-[WebPDFView setMarkedTextMatchesAreHighlighted:]):
implementation of WebMultipleTextMatches protocol method, does nothing useful here because we don't
support inline highlighting of matches in PDF documents
(-[WebPDFView markedTextMatchesAreHighlighted]):
implementation of WebMultipleTextMatches protocol method
(-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
implementation of WebMultipleTextMatches protocol method; calls _nextMatchFor:::: in a loop until
entire document is searched or limit is hit; records results by saving PDFSelections in textMatches ivar
(-[WebPDFView unmarkAllTextMatches]):
implementation of WebMultipleTextMatches protocol method; clears saved textMatches
(-[WebPDFView rectsForTextMatches]):
implementation of WebMultipleTextMatches protocol method; converts saved PDFSelections into NSValue
objects that represent NSRects
(-[WebPDFView _clipViewForPDFDocumentView]):
new helper method to find the clip view whose bounds determine the current scroll position
(-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]):
new helper method, extracted from searchFor:::::
(-[WebPDFView _PDFDocumentViewMightHaveScrolled:]):
new notification callback; tells webView's delegate when document has scrolled
(-[WebPDFView _setTextMatches:]):
new helper method, stores value in ivar
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 17:13:17 +0000 (17:13 +0000)]
Prefast: Add null check prior to writing into allocated BSTR.
Reviewed by Darin.
* MarshallingHelpers.cpp:
(MarshallingHelpers::CFStringRefToBSTR):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 16:53:09 +0000 (16:53 +0000)]
Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.
Reviewed by Sam, Darin.
Allocation failure will result in a null dereference in this case,
so it isn't exploitable.
* DefaultDownloadDelegate.cpp:
(DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 27 Jun 2007 16:47:41 +0000 (16:47 +0000)]
Forgot to commit this file with r23815.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 27 Jun 2007 16:43:01 +0000 (16:43 +0000)]
JavaScriptCore:
Reviewed by Darin.
First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Add 'f' suffix where necessary.
* kjs/testkjs.cpp:
(StopWatch::getElapsedMS):
WebCore:
Reviewed by Darin.
First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Add 'f' suffix where necessary.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
* css/csshelper.h:
* css/cssstyleselector.cpp:
(WebCore::):
(WebCore::CSSStyleSelector::largerFontSize):
(WebCore::CSSStyleSelector::smallerFontSize):
* html/CanvasGradient.cpp:
(WebCore::CanvasGradient::addColorStop):
* html/CanvasPattern.cpp:
(WebCore::CanvasPattern::createPattern):
* ksvg2/css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* ksvg2/css/SVGRenderStyle.h:
* ksvg2/events/SVGZoomEvent.cpp:
(WebCore::SVGZoomEvent::SVGZoomEvent):
* ksvg2/svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::value):
(WebCore::SVGLength::setValue):
(WebCore::SVGLength::valueAsPercentage):
(WebCore::SVGLength::PercentageOfViewport):
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::pixelUnitToMillimeterX):
(WebCore::SVGSVGElement::pixelUnitToMillimeterY):
(WebCore::SVGSVGElement::getScreenCTM):
* ksvg2/svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::getComputedTextLength):
(WebCore::SVGTextContentElement::getSubStringLength):
(WebCore::SVGTextContentElement::getRotationOfChar):
* ksvg2/svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::distance):
* page/InspectorController.cpp:
(WebCore::InspectorResource::InspectorResource):
* platform/graphics/FloatPoint3D.cpp:
(WebCore::FloatPoint3D::normalize):
* platform/graphics/Path.cpp:
(WebCore::pathLengthApplierFunction):
(WebCore::Path::createRoundedRectangle):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::FrameData::clear):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::setCurrentPage):
* platform/graphics/svg/SVGPaintServerPattern.cpp:
(WebCore::SVGPaintServerPattern::externalRepresentation):
* platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
(WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
* platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
(WebCore::cgGradientCallback):
(WebCore::CGShadingRefForRadialGradient):
(WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
* platform/mac/FontDataMac.mm:
(WebCore::webFallbackFontFamily):
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::setPositionFromValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 27 Jun 2007 16:36:43 +0000 (16:36 +0000)]
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=14288
XMLHttpRequest doesn't use a correct content type for file:// URLs
Test: fast/dom/xmlhttprequest-html-response-encoding.html
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
the network layer, since it provides it even for non-HTTP responses.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 27 Jun 2007 08:19:53 +0000 (08:19 +0000)]
Reviewed by Maciej.
Hopefully fix remainder of the IME issues on Mac.
We now assume that the IME silently consumes any event given
to it during text composition, and only override this assumption
if the NSTextInput or NSResponder callbacks are made.
This prevents us from treating those events that the IME has
consumed internally (eg. candidate window navigation) as unhandled
events that should be bubbled.
This fixes:
<rdar://problem/5107538> Major problems handling key press event with non-english Input Methods
<rdar://problem/4196249> REGRESSION: Mail: Inputting space (U+0020) with IM deletes subsequent line breaks on Mail.app
<rdar://problem/5015544> REGRESSION: Reverse conversion keyboard command does not work in Safari.
<rdar://problem/5045121> REGRESSION: Inline is confirmed after press left/right arrow keys, happens in Mail but not in TextEdit.
<rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
<rdar://problem/5085781> REGRESSION: Active input area lost "selected" highlight
<rdar://problem/5094200> space key pressed to close the associated words candidate window gets inserted as text
<rdar://problem/5228294> Candidate item for character matrix is sometimes skipped
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebHTMLView.mm:
(-[WebHTMLView launchKeyEvent:]):
(-[WebHTMLView keyDown:]):
(-[WebHTMLView keyUp:]):
(-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
(-[WebHTMLView unmarkText]):
(-[WebHTMLView setMarkedText:selectedRange:]):
(-[WebHTMLView doCommandBySelector:]):
(-[WebHTMLView insertText:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 05:45:40 +0000 (05:45 +0000)]
2007-06-26 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=14061
Implement more of FrameLoaderClientGdk
Make FrameLoaderClientGdk work properly when the MIME type is set.
* loader/gdk/FrameLoaderClientGdk.cpp:
(WebCore::FrameLoaderClientGdk::objectContentType):
(WebCore::FrameLoaderClientGdk::canShowMIMEType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 05:44:33 +0000 (05:44 +0000)]
2007-06-26 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14058
Gdk font backend cleanup
* platform/FontData.h: Remove obsolete function.
* platform/gdk/FontDataGdk.cpp:
(WebCore::FontData::containsCharacters): Lock/unlock only once.
(WebCore::FontData::platformWidthForGlyph): Remove needless cast.
* platform/gdk/FontPlatformData.h: Remove obsolete function.
* platform/gdk/FontPlatformDataGdk.cpp:
(WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
not the pixel size.
(WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
* platform/gdk/GlyphPageTreeNodeGdk.cpp:
(WebCore::GlyphPage::fill): Lock/unlock only once.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 05:33:32 +0000 (05:33 +0000)]
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=14406
<colgroup>'s borders are ignored when it has <col> children
Covered by existing tests.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- updated results for http://bugs.webkit.org/show_bug.cgi?id=14406
<colgroup>'s borders are ignored when it has <col> children
* tables/mozilla/core/table_rules-expected.checksum: Added.
* tables/mozilla/core/table_rules-expected.png: Added.
* tables/mozilla/core/table_rules-expected.txt: Added.
* tables/mozilla/core/table_rules.html: Copied from LayoutTests/tables/mozilla_expected_failures/core/table_rules.html.
* tables/mozilla/marvin/x_table_rules_groups-expected.checksum: Added.
* tables/mozilla/marvin/x_table_rules_groups-expected.png: Added.
* tables/mozilla/marvin/x_table_rules_groups-expected.txt: Added.
* tables/mozilla/marvin/x_table_rules_groups.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml.
* tables/mozilla_expected_failures/core/table_rules-expected.checksum: Removed.
* tables/mozilla_expected_failures/core/table_rules-expected.png: Removed.
* tables/mozilla_expected_failures/core/table_rules-expected.txt: Removed.
* tables/mozilla_expected_failures/core/table_rules.html: Removed.
* tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.txt: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 04:46:07 +0000 (04:46 +0000)]
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Oliver.
- fix http://bugs.webkit.org/show_bug.cgi?id=14329
REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
Test: fast/repaint/text-selection-rect-in-overflow-2.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
for overflow scroll and columns.
* rendering/RenderText.cpp:
(WebCore::RenderText::selectionRect): Adjust for columns only in the
non-clipped case, since RenderObject::absolutePosition() does not.
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Oliver.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=14329
REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
* fast/repaint/resources/text-selection-rect-in-overflow-frame.html: Added.
* fast/repaint/text-selection-rect-in-overflow-2-expected.checksum: Added.
* fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
* fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
* fast/repaint/text-selection-rect-in-overflow-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 04:43:27 +0000 (04:43 +0000)]
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Sam.
- http://bugs.webkit.org/show_bug.cgi?id=14415
Remove the unused method RenderObject::setTable()
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 27 Jun 2007 04:07:35 +0000 (04:07 +0000)]
Touching config.h to force WebCore to rebuild after r23806
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 03:16:23 +0000 (03:16 +0000)]
2007-06-26 MorganL <morganl.webkit@yahoo.com>
Reviewed by Maciej.
Implement http://bugs.webkit.org/show_bug.cgi?id=14225
Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
This change moves the bulk of ResourceRequest into a base class named
ResourceRequestBase with all platform-specific bits pushed into
ResourceRequest. This allows ports to easily add new members to a
ResourceRequest without having to #ifdef the code that is shared
between ports.
* WebCore.exp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/network/ResourceRequest.cpp: Removed.
* platform/network/ResourceRequest.h: Removed.
* platform/network/ResourceRequestBase.cpp: Added.
(WebCore::ResourceRequestBase::asResourceRequest):
(WebCore::ResourceRequestBase::isEmpty):
(WebCore::ResourceRequestBase::isNull):
(WebCore::ResourceRequestBase::url):
(WebCore::ResourceRequestBase::setURL):
(WebCore::ResourceRequestBase::cachePolicy):
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::timeoutInterval):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::mainDocumentURL):
(WebCore::ResourceRequestBase::setMainDocumentURL):
(WebCore::ResourceRequestBase::httpMethod):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::httpHeaderFields):
(WebCore::ResourceRequestBase::httpHeaderField):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::httpBody):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::allowHTTPCookies):
(WebCore::ResourceRequestBase::setAllowHTTPCookies):
(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderFields):
(WebCore::operator==):
(WebCore::ResourceRequestBase::isConditional):
(WebCore::ResourceRequestBase::updatePlatformRequest):
(WebCore::ResourceRequestBase::updateResourceRequest):
* platform/network/ResourceRequestBase.h: Added.
(WebCore::):
(WebCore::ResourceRequestBase::httpContentType):
(WebCore::ResourceRequestBase::setHTTPContentType):
(WebCore::ResourceRequestBase::httpReferrer):
(WebCore::ResourceRequestBase::setHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::httpUserAgent):
(WebCore::ResourceRequestBase::setHTTPUserAgent):
(WebCore::ResourceRequestBase::httpAccept):
(WebCore::ResourceRequestBase::setHTTPAccept):
(WebCore::ResourceRequestBase::ResourceRequestBase):
(WebCore::operator!=):
* platform/network/cf/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
* platform/network/curl/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
* platform/network/mac/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
* platform/network/qt/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 03:13:26 +0000 (03:13 +0000)]
2007-06-26 Jim Correia <jim.correia@pobox.com>
Reviewed by Darin.
Fix http://bugs.webkit.org/show_bug.cgi?id=14411
Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.
<rdar://problem/5297268>
* Plugins/WebNetscapePluginPackage.m:
(+[WebNetscapePluginPackage initialize]): Force the Resource Manager to
lazy initialize, and only set CurApRefNum to the system file if
CurApRefNum is still -1 after that forced lazy initialization.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log