WebKit-https.git
11 years ago2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 10:03:55 +0000 (10:03 +0000)]
2009-07-20  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Allow custom memory allocation control in JavaScriptCore's RegexPattern.h
        https://bugs.webkit.org/show_bug.cgi?id=27343

        Inherits RegexPattern.h's structs (which have been instantiated by operator new) from FastAllocBase:

        CharacterClass (new call: JavaScriptCore/yarr/RegexCompiler.cpp:144)
        PatternAlternative (new call: JavaScriptCore/yarr/RegexPattern.h:221)
        PatternDisjunction (new call: JavaScriptCore/yarr/RegexCompiler.cpp:446)

        * yarr/RegexPattern.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 10:03:45 +0000 (10:03 +0000)]
2009-07-20  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for JavaScriptCore's MatchFrame struct
        https://bugs.webkit.org/show_bug.cgi?id=27344

        Inherits MatchFrame struct from FastAllocBase because it has
        been instantiated by 'new' JavaScriptCore/pcre/pcre_exec.cpp:359.

        * pcre/pcre_exec.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 20 Jul 2009 10:02:49 +0000 (10:02 +0000)]
2009-07-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=26716
        [Gtk] Each XMLHttpRequest leaks memory.

        Free the SoupURI we create to check the URI. Fix suggested by John
        Kjellberg.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago.:
hausmann@webkit.org [Mon, 20 Jul 2009 09:52:00 +0000 (09:52 +0000)]
.:

2009-07-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Add an option for QtLauncher to build without QtUiTools dependency
        https://bugs.webkit.org/show_bug.cgi?id=27438

        Based on Norbert Leser's work.

        * WebKit.pri: Symbian does not have UiTools

WebKit/qt:

2009-07-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Add an option for QtLauncher to build without QtUiTools dependency
        https://bugs.webkit.org/show_bug.cgi?id=27438

        Based on Norbert Leser's work.

        * QtLauncher/main.cpp:
        (WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 09:50:44 +0000 (09:50 +0000)]
2009-07-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        Remove some outdated S60 platform specific code
        https://bugs.webkit.org/show_bug.cgi?id=27423

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 09:49:33 +0000 (09:49 +0000)]
2009-07-20  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Qt build fix with MSVC and MinGW.

        * jsc.pro: Make sure jsc is a console application, and turn off
        exceptions and stl support to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>
hausmann@webkit.org [Mon, 20 Jul 2009 09:46:56 +0000 (09:46 +0000)]
2009-07-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by David Levin.

        Add support for Qt's foreach to cpplint
        https://bugs.webkit.org/show_bug.cgi?id=27386

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 09:41:59 +0000 (09:41 +0000)]
2009-07-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] On Symbian link against system sqlite3
        https://bugs.webkit.org/show_bug.cgi?id=27368

        Add an option to force linking against system sqlite3
        by adding system-sqlite to the CONFIG variable.

        The Symbian specific part of this patch is contributed by
        Norbert Leser.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 09:32:27 +0000 (09:32 +0000)]
2009-07-20  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by and done with Tor Arne Vestbø.

        Fix fast/css/pseudo-required-optional-*.html in the Qt build
        after r46062.

        These tests triggered a bug in RenderThemeQt where we did not fall back
        to the unstyled painting of text areas and input fields when they have
        a styled background.

        Our re-implementation of isControlStyled incorrectly only checked the
        border for determining whether to style or not. The base-implementation
        performs the same check, but also includes the background. Removing
        our implementation fixes the appearance.

        * platform/qt/RenderThemeQt.cpp: Removed isControlStyled reimplementation.
        * platform/qt/RenderThemeQt.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 20 Jul 2009 08:31:59 +0000 (08:31 +0000)]
2009-07-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Do not use C++-style comments in preprocessor directives.

        GCC does not like this in some configurations, using C-style
        comments is safer.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 20 Jul 2009 08:31:46 +0000 (08:31 +0000)]
2009-07-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Change the glib version check to check for the first unstable
        release with g_mapped_file_unref. Otherwise this would be useless
        until 2.22 is released, a few months from now.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 07:51:44 +0000 (07:51 +0000)]
2009-07-20  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        Add missing (sorted) header files to the HEADERS variable in the qmake
        .pro file for improved completion in IDEs.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 20 Jul 2009 07:24:46 +0000 (07:24 +0000)]
2009-07-19  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Xan Lopez.

        Skip new fast/dom/prototype-inheritance.html test in the Qt DRT
        due to missing features/properties in the window object.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 20 Jul 2009 03:56:32 +0000 (03:56 +0000)]
2009-07-19  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        [V8] Factor V8ConsoleMessage out of V8Proxy
        https://bugs.webkit.org/show_bug.cgi?id=27421

        No behavior change.

        * WebCore.gypi:
        * bindings/v8/V8ConsoleMessage.cpp: Added.
        (WebCore::V8ConsoleMessage::V8ConsoleMessage):
        (WebCore::V8ConsoleMessage::dispatchNow):
        (WebCore::V8ConsoleMessage::dispatchLater):
        (WebCore::V8ConsoleMessage::processDelayed):
        (WebCore::V8ConsoleMessage::handler):
        * bindings/v8/V8ConsoleMessage.h: Added.
        (WebCore::V8ConsoleMessage::Scope::Scope):
        (WebCore::V8ConsoleMessage::Scope::~Scope):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::logInfo):
        (WebCore::reportUnsafeAccessTo):
        (WebCore::V8Proxy::runScript):
        (WebCore::V8Proxy::callFunction):
        (WebCore::V8Proxy::newInstance):
        (WebCore::V8Proxy::initContextIfNeeded):
        (WebCore::V8Proxy::processConsoleMessages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Barth.
rwlbuis@webkit.org [Sun, 19 Jul 2009 18:50:49 +0000 (18:50 +0000)]
    Reviewed by Adam Barth.

        Remove unused member variable.

        * svg/SVGPolyElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sun, 19 Jul 2009 18:16:00 +0000 (18:16 +0000)]
2009-07-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        HTMLAudioElement: constructor should set "autobuffer" attribute
        https://bugs.webkit.org/show_bug.cgi?id=27422

        Test: media/audio-constructor-autobuffer.html

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
            Set 'autobuffer' attribute.

2009-07-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        HTMLAudioElement: constructor should set "autobuffer" attribute
        https://bugs.webkit.org/show_bug.cgi?id=27422

        * media/audio-constructor-autobuffer-expected.txt: Added.
        * media/audio-constructor-autobuffer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Thierry Bastian <thierry.bastian@nokia.com>
hausmann@webkit.org [Sun, 19 Jul 2009 09:47:44 +0000 (09:47 +0000)]
2009-07-19  Thierry Bastian <thierry.bastian@nokia.com>

        Reviewed by Simon Hausmann.

        Fix the Qt build with mingw.

        * WebCore.pro: Don't use MSVC commandline options to disable warnings
        with mingw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 19 Jul 2009 07:39:04 +0000 (07:39 +0000)]
2009-07-19  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        [V8] Phase 2: Remove event listener methods from V8Proxy
        https://bugs.webkit.org/show_bug.cgi?id=27415

        No behavior change.

        * bindings/v8/V8ObjectEventListener.cpp:
        (WebCore::weakObjectEventListenerCallback):
        (WebCore::V8ObjectEventListener::~V8ObjectEventListener):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::disconnectEventListeners):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::eventListeners):
        (WebCore::V8Proxy::objectListeners):
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        (WebCore::getEventListener):
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::~V8EventListener):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        (WebCore::ACCESSOR_SETTER):
        * bindings/v8/custom/V8ElementCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        (WebCore::getEventListener):
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::getEventListener):
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 18 Jul 2009 23:13:45 +0000 (23:13 +0000)]
2009-07-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        [Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not declared in this scope
        https://bugs.webkit.org/show_bug.cgi?id=27230

        Use g_mapped_file_unref for GLIB version 2.22 onwards.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Jorge Gonzalez <aloriel@gmail.com>
jmalonzo@webkit.org [Sat, 18 Jul 2009 23:03:06 +0000 (23:03 +0000)]
2009-07-18  Jorge Gonzalez  <aloriel@gmail.com>

        Rubber-stamped by Jan Alonzo.

        es translation
        https://bugs.webkit.org/show_bug.cgi?id=26319

        * es.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove some stray executable flags.
darin@apple.com [Sat, 18 Jul 2009 23:00:16 +0000 (23:00 +0000)]
Remove some stray executable flags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded Radar URLs
mitz@apple.com [Sat, 18 Jul 2009 22:59:26 +0000 (22:59 +0000)]
Added Radar URLs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 18 Jul 2009 22:58:15 +0000 (22:58 +0000)]
WebCore:

        Reviewed by Anders Carlsson.

        Add spread radius support to -webkit-box-shadow
        https://bugs.webkit.org/show_bug.cgi?id=27417

        Test: fast/box-shadow/spread.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForShadow): Added a property ID parameter and used it to
            include the spread length for box-shadow but not for text-shadow.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
            Pass the property ID to valueForShadow().

        * css/CSSParser.cpp:
        (WebCore::ShadowParseContext::ShadowParseContext): Added property,
            spread, and allowSpread members. Added a property ID parameter to
            the constructor. Initialize the property and allowSpread members.
        (WebCore::ShadowParseContext::allowLength): Added allowSpread.
        (WebCore::ShadowParseContext::commitValue): Pass the spread value to
            the ShadowValue constructor. Reset allowSpread.
        (WebCore::ShadowParseContext::commitLength): Allow spread after blur
            for the box-shadow property.
        (WebCore::ShadowParseContext::commitColor): Reset allowSpread.
        (WebCore::CSSParser::parseShadow): Pass the property ID to
            ShadowParseContext().

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Get the spread value from
            the shadow value and pass it to the ShadowData constructor.

        * css/ShadowValue.cpp:
        (WebCore::ShadowValue::ShadowValue): Added spread.
        (WebCore::ShadowValue::cssText): Added spread.

        * css/ShadowValue.h:
        (WebCore::ShadowValue::create): Added spread.

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc): Blend the spread value.
        (WebCore::PropertyWrapperShadow::blend): Added 0 spread to the default
            shadow.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Account for spread in
            the visual overflow calculations.
        (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
        (WebCore::InlineFlowBox::paint): Ditto.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight): Ditto.
        (WebCore::RenderBlock::overflowWidth): Ditto.
        (WebCore::RenderBlock::overflowLeft): Ditto.
        (WebCore::RenderBlock::overflowTop): Ditto.
        (WebCore::RenderBlock::overflowRect): Ditto.
        (WebCore::RenderBlock::layoutBlock): Ditto.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow): Inflate the shadow-
            casting rect by the shadow spread value. Adjust border radii if
            necessary.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Account for spread in the
            visual overflow calculations.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateRects): Ditto.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Account for spread.
        (WebCore::RenderObject::adjustRectForOutlineAndShadow): Ditto.

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setTextShadow): Assert that text shadows do not
            have spread.

        * rendering/style/ShadowData.cpp:
        (WebCore::ShadowData::ShadowData): Added spread.
        (WebCore::ShadowData::operator==): Compare spread.
        * rendering/style/ShadowData.h:
        (WebCore::ShadowData::ShadowData): Added spread.

LayoutTests:

        Reviewed by Anders Carlsson.

        Test box-shadow spread radius
        https://bugs.webkit.org/show_bug.cgi?id=27417

        * fast/box-shadow/spread.html: Added.
        * platform/mac/fast/box-shadow/spread-expected.checksum: Added.
        * platform/mac/fast/box-shadow/spread-expected.png: Added.
        * platform/mac/fast/box-shadow/spread-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 18 Jul 2009 22:53:39 +0000 (22:53 +0000)]
2009-07-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        https://bugs.webkit.org/show_bug.cgi?id=27145
        [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615

        Reviewed by Gustavo Noronha.

        * platform/gtk/Skipped:

        Normalize file URLs.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dumpHistoryItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 18 Jul 2009 18:50:02 +0000 (18:50 +0000)]
2009-07-17  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Further improve non-Cygwin SVN support.

        * Scripts/prepare-ChangeLog: Harmless change to be consistent with other
          places that consume whitespace at the end of svn output.
        * Scripts/resolve-ChangeLogs: Add support for SVN 1.6.  Slightly
          optimize svn info parsing based on technique in svn-create-patch.
          Normalize paths and consume whitespace in the same way as
          prepare-ChangeLog, for Windows systems with a non-Cygwin SVN.  Force
          diff and patch to run in binary mode so that they won't
          "intelligently" screw up line endings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 18 Jul 2009 17:48:32 +0000 (17:48 +0000)]
2009-07-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Jan Alonzo.

        Minor FrameLoader.cpp cleanup
        https://bugs.webkit.org/show_bug.cgi?id=27406

        No behavior change.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::executeIfJavaScriptURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 18 Jul 2009 17:47:50 +0000 (17:47 +0000)]
2009-07-18  Simon Fraser  <simon.fraser@apple.com>

        Fix Tiger DRT build.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (createWebViewAndOffscreenWindow):
        * DumpRenderTree/mac/PixelDumpSupportMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 18 Jul 2009 16:59:03 +0000 (16:59 +0000)]
2009-07-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        DRT doesn't reliably snapshot composited layers
        https://bugs.webkit.org/show_bug.cgi?id=27399

        If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view
        with composited content. In that case we need to force the view to display so that
        the composited layers are rendered to the screen.

        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (createBitmapContextFromWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 18 Jul 2009 15:02:30 +0000 (15:02 +0000)]
2009-07-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        [V8] Move event listener methods from V8Proxy to V8EventListenerList
        https://bugs.webkit.org/show_bug.cgi?id=27408

        Move some event listener code out of V8Proxy and into the event
        listener list.

        I'd like to remove these methods from V8Proxy entirely and just expose
        getters for the lists themselves, but I'll do that in a follow up
        patch.

        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::findWrapper):
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::findOrCreateWrapper):
        * bindings/v8/V8ObjectEventListener.cpp:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::findV8EventListener):
        (WebCore::V8Proxy::findOrCreateV8EventListener):
        (WebCore::V8Proxy::removeV8EventListener):
        (WebCore::V8Proxy::findObjectEventListener):
        (WebCore::V8Proxy::findOrCreateObjectEventListener):
        (WebCore::V8Proxy::removeObjectEventListener):
        * bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 18 Jul 2009 08:45:06 +0000 (08:45 +0000)]
2009-07-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        [Gtk] Skip tests that require new expected results, eventSender
        and editing callbacks DRT support. Unreviewed.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert 46088.
abarth@webkit.org [Sat, 18 Jul 2009 08:37:22 +0000 (08:37 +0000)]
Revert 46088.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 18 Jul 2009 08:31:30 +0000 (08:31 +0000)]
2009-07-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Jan Alonzo.

        Minor FrameLoader.cpp cleanup
        https://bugs.webkit.org/show_bug.cgi?id=27406

        No behavior change.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::executeIfJavaScriptURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jorlow@chromium.org [Sat, 18 Jul 2009 07:44:07 +0000 (07:44 +0000)]
WebCore:

2009-07-18  Jeremy Orlow  <jorlow@chromium.org>

        Rubber stamped by Adam Barth.

        Revert https://bugs.webkit.org/show_bug.cgi?id=27383
        https://bugs.webkit.org/show_bug.cgi?id=27407

        Revert Jens' patch.  I believe he forgot to include a file.

        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/V8DataGridDataSource.cpp: Removed.
        * bindings/v8/V8DataGridDataSource.h: Removed.
        * bindings/v8/V8GCController.h:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-18  Jeremy Orlow  <jorlow@chromium.org>

        Rubber stamped by Adam Barth.

        Revert https://bugs.webkit.org/show_bug.cgi?id=27383
        https://bugs.webkit.org/show_bug.cgi?id=27407

        Revert Jens' patch.  I believe he forgot to include a file.

        * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
        * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
        * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Daniel Bates <dbates@intudata.com>
abarth@webkit.org [Sat, 18 Jul 2009 06:13:28 +0000 (06:13 +0000)]
2009-07-17  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27405

        Tests that HTML entities that contain an invalid entity, such as an
        unknown named entity, are properly handled.

        * http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt: Added.
        * http/tests/security/xssAuditor/link-onclick-ampersand.html: Added.
        * http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt: Added.
        * http/tests/security/xssAuditor/javascript-link-ampersand.html: Added.

2009-07-17  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27405

        Fixes an issue when decoding HTML entities with an unknown named entity that
        caused null-characters to be inserted into the decoded result.

        Test: http/tests/security/xssAuditor/link-onclick-ampersand.html
              http/tests/security/xssAuditor/javascript-link-ampersand.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::decodeHTMLEntities): Added check to conditional so that
        non-zero entity values are not inserted during decoding process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 18 Jul 2009 05:42:36 +0000 (05:42 +0000)]
2009-07-17  Simon Fraser  <simon.fraser@apple.com>

        Fix the font to match the rest of the blog site.

        * blog-files/3d-transforms/image-flip.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 18 Jul 2009 05:38:44 +0000 (05:38 +0000)]
2009-07-17  Simon Fraser  <simon.fraser@apple.com>

        Move the image flip effect into an iframe to avoid the long
        blog page tripping a bug on Leopard.

        * blog-files/3d-transforms/image-flip.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Mads Ager <ager@chromium.org>
abarth@webkit.org [Sat, 18 Jul 2009 05:32:11 +0000 (05:32 +0000)]
2009-07-17  Mads Ager  <ager@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27403
        Add test case for https://bugs.webkit.org/show_bug.cgi?id=27394:
        properties on a window object should be accessible after the frame
        of the window object has navigated to another site.

        * fast/dom/Window/window-access-after-navigation-expected.txt: Added.
        * fast/dom/Window/window-access-after-navigation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 18 Jul 2009 03:29:13 +0000 (03:29 +0000)]
2009-07-17  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        bugzilla-tool does not understand nested SVN repos
        https://bugs.webkit.org/show_bug.cgi?id=27404

        Determine the root of the working copy by looking at SVN's UUIDs.

        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 18 Jul 2009 03:12:29 +0000 (03:12 +0000)]
2009-07-17  Jan Michael Alonzo  <jmalonzo@webkit.org>

        <http://webkit.org/b/18363> [GTK] Combo boxes cannot be opened pressing space

        Reviewed by Holger Freyther.

        Add Gtk to platforms that want to open the menulist using the
        spacebar.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>
jmalonzo@webkit.org [Sat, 18 Jul 2009 02:57:49 +0000 (02:57 +0000)]
2009-07-17  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25523
        [GTK] The text displayed by push buttons is not exposed to assistive technologies

        Add new public method text() to RenderButton and use it from
        AccessibilityRenderObject::stringValue().

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::stringValue):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::text):
        * rendering/RenderButton.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Anton Muhin <antonm@chromium.org>
jorlow@chromium.org [Sat, 18 Jul 2009 02:14:54 +0000 (02:14 +0000)]
2009-07-17  Anton Muhin  <antonm@chromium.org>

        Reviewed by Dimitri Glazkov.

        Restore proxy retrieval
        https://bugs.webkit.org/show_bug.cgi?id=27369

        No new tests are needed.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Sat, 18 Jul 2009 02:08:34 +0000 (02:08 +0000)]
2009-07-17  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=27351
        Added platform "Symbian" to WEBCORE_NAVIGATOR_PLATFORM
        Use uname to find the correct platform for Linux.

        * page/NavigatorBase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jorlow@chromium.org [Sat, 18 Jul 2009 01:42:17 +0000 (01:42 +0000)]
WebCore:

2009-07-17  Jens Alfke  <snej@chromium.org>

        Reviewed by Dimitri Glazkov.

        Hook up V8 bindings for DataGrid elements.
        https://bugs.webkit.org/show_bug.cgi?id=27383
        http://code.google.com/p/chromium/issues/detail?id=16730

        Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
        to handle exceptions, check appropriate JS prototypes, and
        test column-list's item() method as well as array-indexing.

        * WebCore.gypi: Added new source files.
        * bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
        * bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
        * bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates.
        (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
        * bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource)
        (WebCore::V8DataGridDataSource::V8DataGridDataSource):
        (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
        * bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource)
        (WebCore::V8DataGridDataSource::create):
        (WebCore::V8DataGridDataSource::isJSDataGridDataSource):
        (WebCore::V8DataGridDataSource::jsDataSource):
        (WebCore::asV8DataGridDataSource):
        * bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
        * bindings/v8/V8Index.h: Conditionalize datagrid stuff.
        * bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
        * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-17  Jens Alfke  <snej@chromium.org>

        Reviewed by Dimitri Glazkov.

        Hook up V8 bindings for DataGrid elements.
        https://bugs.webkit.org/show_bug.cgi?id=27383
        http://code.google.com/p/chromium/issues/detail?id=16730

        Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
        to handle exceptions, check appropriate JS prototypes, and
        test column-list's item() method as well as array-indexing.

        * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
        * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
        * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 David Levin <levin@chromium.org>
levin@chromium.org [Sat, 18 Jul 2009 01:36:08 +0000 (01:36 +0000)]
2009-07-17  David Levin  <levin@chromium.org>

        Reviewed by Mark Rowe.

        webkit-tools-completion.sh has two typos and sorting issues.
        https://bugs.webkit.org/show_bug.cgi?id=27401

        * Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean".
          Also, sort all lists including items in the case statement and flags for
          the commands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Sat, 18 Jul 2009 01:26:58 +0000 (01:26 +0000)]
2009-07-17  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        StorageArea should only contain methods we intend to proxy.
        https://bugs.webkit.org/show_bug.cgi?id=27181

        Right now, StorageAreaSync takes in a StorageArea* and calls methods
        like importItem.  Really, StorageAreaSync should be operating directly
        on StorageAreaImpl* and those methods should be removed from StorageArea
        since StorageAreaSync should never be attached to anything other than a
        StorageAreaImpl.

        This was pointed out in the review for
        https://bugs.webkit.org/show_bug.cgi?id=27072

        Also clean up StorageNamespaceImpl to operate directly on
        StorageAreaImpl.  Also, get rid of the factory for StorageArea
        since nothing should ever create a StorageArea directly.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/StorageArea.cpp: Removed.
        * storage/StorageArea.h:
        (WebCore::StorageArea::~StorageArea):
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::copy):
        * storage/StorageAreaImpl.h:
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::create):
        (WebCore::StorageAreaSync::StorageAreaSync):
        * storage/StorageAreaSync.h:
        * storage/StorageNamespaceImpl.cpp:
        (WebCore::StorageNamespaceImpl::copy):
        (WebCore::StorageNamespaceImpl::storageArea):
        * storage/StorageNamespaceImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Sat, 18 Jul 2009 01:22:17 +0000 (01:22 +0000)]
2009-07-17  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add v8 implementation for DOM Storage ScriptObjectQuarantine.
        https://bugs.webkit.org/show_bug.cgi?id=27327

        Wrap the storage object with a generic object as is done elsewhere in
        the file (but continue to hit a NOTIMPLEMENTED if DOM_STORAGE is not
        enabled.

        * bindings/v8/ScriptObjectQuarantine.cpp:
        (WebCore::getQuarantinedScriptObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Mads Ager <ager@chromium.org>
eroman@chromium.org [Sat, 18 Jul 2009 00:12:15 +0000 (00:12 +0000)]
2009-07-17  Mads Ager  <ager@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=27394
        Fix access to global object wrappers after navigation of their
        frame in the V8 bindings.  This fixes selenium test failures.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::updateDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the 32-bit build by removing implicit float <-> double conversions.
mrowe@apple.com [Fri, 17 Jul 2009 23:54:52 +0000 (23:54 +0000)]
Fix the 32-bit build by removing implicit float <-> double conversions.

* inspector/InspectorController.cpp:
(WebCore::constrainedAttachedWindowHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 17 Jul 2009 23:27:11 +0000 (23:27 +0000)]
2009-07-17  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
        https://bugs.webkit.org/show_bug.cgi?id=14272

        Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
        to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
        in InspectorController.cpp to remember user's preferred height.

        * WebCoreSupport/WebInspectorClient.cpp:

2009-07-17  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
        https://bugs.webkit.org/show_bug.cgi?id=14272

        Moved preference setting for attached inspector height and inspector height calculation from
        WebInspectorClient.mm into InspectorController.cpp, to make this code cross-platform and enable
        Windows resizing of attached inspector.

        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:

2009-07-17  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
        https://bugs.webkit.org/show_bug.cgi?id=14272

        Removed size calculation code from [WebInspectorWindowController setInitialAttachedHeight] into
        InspectorController.cpp to make it cross platform, and use InspectorController to store the
        user's preferred size for an attached window, instead of NSUserDefaults.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController showWindow:]):
        (-[WebInspectorWindowController setAttachedWindowHeight:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Another attempt at fixing the build after r46063
mitz@apple.com [Fri, 17 Jul 2009 23:25:28 +0000 (23:25 +0000)]
    Another attempt at fixing the build after r46063

        * WebCore.xcodeproj/project.pbxproj: Made ExceptionCode.h a private
            header, because it is now included from htmlediting.h, which is
            a private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Fri, 17 Jul 2009 23:22:00 +0000 (23:22 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27396
        Moving cursor in Thai text sometimes jumps over two characters

        Test: editing/text-iterator/thai-cursor-movement.html

        * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added a special
        case for five Thai characters, matching ICU/CLDR changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 17 Jul 2009 23:13:04 +0000 (23:13 +0000)]
2009-07-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Some constructor objects exposed on Window have the wrong prototype chain
        https://bugs.webkit.org/show_bug.cgi?id=27276

        * fast/dom/prototype-inheritance-expected.txt: Added.
        * fast/dom/prototype-inheritance.html: Added.
        * fast/dom/resources/prototype-inheritance.js: Added.

2009-07-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Some constructor objects exposed on Window have the wrong prototype chain
        https://bugs.webkit.org/show_bug.cgi?id=27276

        Several Constructor classes were already being passed a global object
        during construction, but they were ignoring it for prototype lookup.
        I've fixed those to use the passed global object instead.

        Most of these Constructor classes should just be auto-generated, but I
        refrained from changing them over to auto-gen in this patch.

        Fixed CodeGeneratorJS to pass a global object to getDOMConstructor when
        available, otherwise default to deprecatedGlobalObjectForPrototype(exec)
        to match existing behavior.

        Test: fast/dom/prototype-inheritance.html

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor): use the existing globalObject pointer for prototype lookup
        * bindings/js/JSDOMBinding.h:
        (WebCore::deprecatedGlobalObjectForPrototype): Make it easy to detect where the wrong global object is being used.
        (WebCore::deprecatedGetDOMStructure):
        * bindings/js/JSDOMGlobalObject.h: remove error-prone getDOMConstructor, require passing JSDOMGlobalObject*
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::webKitPoint): pass "this" for the global object.
        (WebCore::JSDOMWindow::webKitCSSMatrix): pass "this" for the global object.
        (WebCore::JSDOMWindow::xsltProcessor): pass "this" for the global object.
        (WebCore::JSDOMWindow::worker): pass "this" for the global object.
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor): use the existing globalObject pointer for prototype lookup
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): use the existing globalObject pointer for prototype lookup
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor): use the existing globalObject pointer for prototype lookup
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): add new globalObject parameter and use it
        * bindings/js/JSWebKitCSSMatrixConstructor.h:
        * bindings/js/JSWebKitPointConstructor.cpp:
        (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor): add new globalObject parameter and use it
        * bindings/js/JSWebKitPointConstructor.h:
        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::JSWorkerConstructor::JSWorkerConstructor): add new globalObject parameter and use it
        * bindings/js/JSWorkerConstructor.h:
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): use the existing globalObject pointer for prototype lookup
         -- XMLHttpRequest constructor was also missing a length.  Added one.
        * bindings/js/JSXSLTProcessorConstructor.cpp:
        (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
        * bindings/js/JSXSLTProcessorConstructor.h:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix
mitz@apple.com [Fri, 17 Jul 2009 23:11:45 +0000 (23:11 +0000)]
    Build fix

        * editing/htmlediting.cpp:
        (WebCore::visiblePositionBeforeNode):
        (WebCore::visiblePositionAfterNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 17 Jul 2009 23:02:42 +0000 (23:02 +0000)]
2009-07-17  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix for symbol lookup error.

        Move AbstractWorker from SHARED_WORKERS to WORKERS as Worker derives from it now
        Changed in http://trac.webkit.org/changeset/46048

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 17 Jul 2009 23:01:31 +0000 (23:01 +0000)]
2009-07-17  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Tweak some regexes for correctness.

        * Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous
          change here didn't quite get things right).
        * Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not
          including any trailing whitespace in the name "ChangeLog", and by
          normalizing paths before calling basename() to avoid confusing it.
          (normalizePath() copied from prepare-ChangeLog.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Ryosuke Niwa <ryosuke.niwa@gmail.com>
jparent@chromium.org [Fri, 17 Jul 2009 22:58:31 +0000 (22:58 +0000)]
2009-07-17  Ryosuke Niwa  <ryosuke.niwa@gmail.com>

        Reviewed by Eric Seidel.

        htmlediting.cpp needs more utility functions to fix the bug 26816
        https://bugs.webkit.org/show_bug.cgi?id=27038

        In order to fix the bug 26816, we need several utility functions be added to htmlediting.cpp

        No tests because functions haven't been used anywhere yet.

        * dom/Range.cpp:
        (WebCore::Range::create):
        (WebCore::Range::comparePoint): added const qualifier
        (WebCore::Range::compareNode): added const qualifier
        * dom/Range.h:
        * editing/htmlediting.cpp:
        (WebCore::unsplittableElementForPosition): find the enclosing unsplittable element (editing root & table cell)
        (WebCore::positionBeforeNode): added ASSERT(node)
        (WebCore::positionAfterNode): added ASSERT(node)
        (WebCore::visiblePositionBeforeNode):
        (WebCore::visiblePositionAfterNode):
        (WebCore::createRange): create a range object from two visible positions
        (WebCore::extendRangeToWrappingNodes): extend range to include nodes that starts and ends at the boundaries
        (WebCore::canMergeLists): typo
        (WebCore::indexForVisiblePosition): added const qualifier
        (WebCore::isVisiblyAdjacent): typo
        (WebCore::isNodeVisiblyContainedWithin): determine if a node is inside a range or within the visible boundaries of the range
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLayoutTests:
pkasting@chromium.org [Fri, 17 Jul 2009 22:37:41 +0000 (22:37 +0000)]
LayoutTests:

2009-07-17  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25551
        Test suite for the required attribute, the valueMissing flag and new
        :required and :optional CSS pseudoclasses.
        Part of the HTML5 sec. Forms.
        http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required

        * fast/css/pseudo-required-optional-001-expected.txt: Added.
        * fast/css/pseudo-required-optional-001.html: Added.
        * fast/css/pseudo-required-optional-002-expected.txt: Added.
        * fast/css/pseudo-required-optional-002.html: Added.
        * fast/css/pseudo-required-optional-003-expected.txt: Added.
        * fast/css/pseudo-required-optional-003.html: Added.
        * fast/css/pseudo-required-optional-004-expected.txt: Added.
        * fast/css/pseudo-required-optional-004.html: Added.
        * fast/css/pseudo-required-optional-005-expected.txt: Added.
        * fast/css/pseudo-required-optional-005.html: Added.
        * fast/css/pseudo-required-optional-006-expected.txt: Added.
        * fast/css/pseudo-required-optional-006.html: Added.
        * fast/forms/ValidityState-valueMissing-001-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-001.html: Added.
        * fast/forms/ValidityState-valueMissing-002-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-002.html: Added.
        * fast/forms/ValidityState-valueMissing-003-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-003.html: Added.
        * fast/forms/ValidityState-valueMissing-004-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-004.html: Added.
        * fast/forms/ValidityState-valueMissing-005-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-005.html: Added.
        * fast/forms/ValidityState-valueMissing-006-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-006.html: Added.
        * fast/forms/ValidityState-valueMissing-007-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-007.html: Added.
        * fast/forms/ValidityState-valueMissing-008-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-008.html: Added.
        * fast/forms/ValidityState-valueMissing-009-expected.txt: Added.
        * fast/forms/ValidityState-valueMissing-009.html: Added.
        * fast/forms/required-attribute-001-expected.txt: Added.
        * fast/forms/required-attribute-001.html: Added.
        * fast/forms/required-attribute-002-expected.txt: Added.
        * fast/forms/required-attribute-002.html: Added.

WebCore:

2009-07-17  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25551
        Added support for the "required" attribute, the valueMissing flag
        to the ValidityState object and :required/:optional CSS pseudoclasses.
        Part of HTML5 sec. Forms specs.
        http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required

        Tests: fast/css/pseudo-required-optional-001.html
               fast/css/pseudo-required-optional-002.html
               fast/css/pseudo-required-optional-003.html
               fast/css/pseudo-required-optional-004.html
               fast/css/pseudo-required-optional-005.html
               fast/css/pseudo-required-optional-006.html
               fast/forms/ValidityState-valueMissing-001.html
               fast/forms/ValidityState-valueMissing-002.html
               fast/forms/ValidityState-valueMissing-003.html
               fast/forms/ValidityState-valueMissing-004.html
               fast/forms/ValidityState-valueMissing-005.html
               fast/forms/ValidityState-valueMissing-006.html
               fast/forms/ValidityState-valueMissing-007.html
               fast/forms/ValidityState-valueMissing-008.html
               fast/forms/ValidityState-valueMissing-009.html
               fast/forms/required-attribute-001.html
               fast/forms/required-attribute-002.html

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType): pseudoRequired/pseudoOptional
        * css/CSSSelector.h:
        (WebCore::CSSSelector::): ditto
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto
        * dom/Element.h:
        (WebCore::Element::isOptionalFormControl): check for optional controls
        (WebCore::Element::isRequiredFormControl): check for required controls
        * html/HTMLAttributeNames.in: required attribute
        * html/HTMLButtonElement.h:
        (WebCore::HTMLButtonElement::isOptionalFormControl): ditto
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::required): requiredAttr getter
        (WebCore::HTMLFormControlElement::setRequired): requiredAttr setter
        * html/HTMLFormControlElement.h:
        (WebCore::HTMLFormControlElement::valueMissing): method definition
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::valueMissing): validation code
        (WebCore::HTMLInputElement::isRequiredFormControl): ditto
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isOptionalFormControl): ditto
        * html/HTMLInputElement.idl: required DOM attribute
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::isOptionalFormControl): ditto
        * html/HTMLTextAreaElement.h:
        (WebCore::HTMLTextAreaElement::valueMissing): validation code
        (WebCore::HTMLTextAreaElement::isOptionalFormControl): ditto
        (WebCore::HTMLTextAreaElement::isRequiredFormControl): ditto
        * html/HTMLTextAreaElement.idl: required DOM attribute
        * html/ValidityState.cpp:
        * html/ValidityState.h:
        (WebCore::ValidityState::valueMissing): validation flag

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Fri, 17 Jul 2009 22:30:41 +0000 (22:30 +0000)]
2009-07-17  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=27390 CSS custom
        cursor hotspots should work in quirks mode
        - and corresponding <rdar://problem/6554340>

        Enable hotspots in quirks mode.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):

        Update this manual test to reflect the fact that hotspots are now
        expected to work in quirks mode.
        * manual-tests/css3-cursor-fallback-quirks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
pkasting@chromium.org [Fri, 17 Jul 2009 22:02:52 +0000 (22:02 +0000)]
JavaScriptCore:

2009-07-17  Peter Kasting  <pkasting@google.com>

        Reviewed by Steve Falkenburg.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Only add Cygwin to the path when it isn't already there.  This avoids
        causing problems for people who purposefully have non-Cygwin versions of
        executables like svn in front of the Cygwin ones in their paths.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
        * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:

WebCore:

2009-07-17  Peter Kasting  <pkasting@google.com>

        Reviewed by Steve Falkenburg.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Only add Cygwin to the path when it isn't already there.  This avoids
        causing problems for people who purposefully have non-Cygwin versions of
        executables like svn in front of the Cygwin ones in their paths.

        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

2009-07-17  Peter Kasting  <pkasting@google.com>

        Reviewed by Steve Falkenburg.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Only add Cygwin to the path when it isn't already there.  This avoids
        causing problems for people who purposefully have non-Cygwin versions of
        executables like svn in front of the Cygwin ones in their paths.

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/InterfacesGenerated.vcproj:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

2009-07-17  Peter Kasting  <pkasting@google.com>

        Reviewed by Steve Falkenburg.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Only add Cygwin to the path when it isn't already there.  This avoids
        causing problems for people who purposefully have non-Cygwin versions of
        executables like svn in front of the Cygwin ones in their paths.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>
barraclough@apple.com [Fri, 17 Jul 2009 21:56:28 +0000 (21:56 +0000)]
2009-07-17  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Add YARR support for generic ARM platforms (disabled by default).
        https://bugs.webkit.org/show_bug.cgi?id=24986

        Add generic ARM port for MacroAssembler. It supports the whole
        MacroAssembler functionality except floating point.

        The class JmpSrc is extended with a flag which enables to patch
        the jump destination offset during execution. This feature is
        required for generic ARM port.

        Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
        Signed off by Gabor Loki <loki@inf.u-szeged.hu>

        * JavaScriptCore.pri:
        * assembler/ARMAssembler.cpp: Added.
        (JSC::ARMAssembler::getLdrImmAddress):
        (JSC::ARMAssembler::linkBranch):
        (JSC::ARMAssembler::patchConstantPoolLoad):
        (JSC::ARMAssembler::getOp2):
        (JSC::ARMAssembler::genInt):
        (JSC::ARMAssembler::getImm):
        (JSC::ARMAssembler::moveImm):
        (JSC::ARMAssembler::dataTransfer32):
        (JSC::ARMAssembler::baseIndexTransfer32):
        (JSC::ARMAssembler::executableCopy):
        * assembler/ARMAssembler.h: Added.
        (JSC::ARM::):
        (JSC::ARMAssembler::ARMAssembler):
        (JSC::ARMAssembler::):
        (JSC::ARMAssembler::JmpSrc::JmpSrc):
        (JSC::ARMAssembler::JmpSrc::enableLatePatch):
        (JSC::ARMAssembler::JmpDst::JmpDst):
        (JSC::ARMAssembler::JmpDst::isUsed):
        (JSC::ARMAssembler::JmpDst::used):
        (JSC::ARMAssembler::emitInst):
        (JSC::ARMAssembler::and_r):
        (JSC::ARMAssembler::ands_r):
        (JSC::ARMAssembler::eor_r):
        (JSC::ARMAssembler::eors_r):
        (JSC::ARMAssembler::sub_r):
        (JSC::ARMAssembler::subs_r):
        (JSC::ARMAssembler::rsb_r):
        (JSC::ARMAssembler::rsbs_r):
        (JSC::ARMAssembler::add_r):
        (JSC::ARMAssembler::adds_r):
        (JSC::ARMAssembler::adc_r):
        (JSC::ARMAssembler::adcs_r):
        (JSC::ARMAssembler::sbc_r):
        (JSC::ARMAssembler::sbcs_r):
        (JSC::ARMAssembler::rsc_r):
        (JSC::ARMAssembler::rscs_r):
        (JSC::ARMAssembler::tst_r):
        (JSC::ARMAssembler::teq_r):
        (JSC::ARMAssembler::cmp_r):
        (JSC::ARMAssembler::orr_r):
        (JSC::ARMAssembler::orrs_r):
        (JSC::ARMAssembler::mov_r):
        (JSC::ARMAssembler::movs_r):
        (JSC::ARMAssembler::bic_r):
        (JSC::ARMAssembler::bics_r):
        (JSC::ARMAssembler::mvn_r):
        (JSC::ARMAssembler::mvns_r):
        (JSC::ARMAssembler::mul_r):
        (JSC::ARMAssembler::muls_r):
        (JSC::ARMAssembler::mull_r):
        (JSC::ARMAssembler::ldr_imm):
        (JSC::ARMAssembler::ldr_un_imm):
        (JSC::ARMAssembler::dtr_u):
        (JSC::ARMAssembler::dtr_ur):
        (JSC::ARMAssembler::dtr_d):
        (JSC::ARMAssembler::dtr_dr):
        (JSC::ARMAssembler::ldrh_r):
        (JSC::ARMAssembler::ldrh_d):
        (JSC::ARMAssembler::ldrh_u):
        (JSC::ARMAssembler::strh_r):
        (JSC::ARMAssembler::push_r):
        (JSC::ARMAssembler::pop_r):
        (JSC::ARMAssembler::poke_r):
        (JSC::ARMAssembler::peek_r):
        (JSC::ARMAssembler::clz_r):
        (JSC::ARMAssembler::bkpt):
        (JSC::ARMAssembler::lsl):
        (JSC::ARMAssembler::lsr):
        (JSC::ARMAssembler::asr):
        (JSC::ARMAssembler::lsl_r):
        (JSC::ARMAssembler::lsr_r):
        (JSC::ARMAssembler::asr_r):
        (JSC::ARMAssembler::size):
        (JSC::ARMAssembler::ensureSpace):
        (JSC::ARMAssembler::label):
        (JSC::ARMAssembler::align):
        (JSC::ARMAssembler::jmp):
        (JSC::ARMAssembler::patchPointerInternal):
        (JSC::ARMAssembler::patchConstantPoolLoad):
        (JSC::ARMAssembler::patchPointer):
        (JSC::ARMAssembler::repatchInt32):
        (JSC::ARMAssembler::repatchPointer):
        (JSC::ARMAssembler::repatchLoadPtrToLEA):
        (JSC::ARMAssembler::linkJump):
        (JSC::ARMAssembler::relinkJump):
        (JSC::ARMAssembler::linkCall):
        (JSC::ARMAssembler::relinkCall):
        (JSC::ARMAssembler::getRelocatedAddress):
        (JSC::ARMAssembler::getDifferenceBetweenLabels):
        (JSC::ARMAssembler::getCallReturnOffset):
        (JSC::ARMAssembler::getOp2Byte):
        (JSC::ARMAssembler::placeConstantPoolBarrier):
        (JSC::ARMAssembler::RM):
        (JSC::ARMAssembler::RS):
        (JSC::ARMAssembler::RD):
        (JSC::ARMAssembler::RN):
        (JSC::ARMAssembler::getConditionalField):
        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::JmpSrc::enableLatePatch):
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::Call::enableLatePatch):
        (JSC::AbstractMacroAssembler::Jump::enableLatePatch):
        * assembler/MacroAssembler.h:
        * assembler/MacroAssemblerARM.h: Added.
        (JSC::MacroAssemblerARM::):
        (JSC::MacroAssemblerARM::add32):
        (JSC::MacroAssemblerARM::and32):
        (JSC::MacroAssemblerARM::lshift32):
        (JSC::MacroAssemblerARM::mul32):
        (JSC::MacroAssemblerARM::not32):
        (JSC::MacroAssemblerARM::or32):
        (JSC::MacroAssemblerARM::rshift32):
        (JSC::MacroAssemblerARM::sub32):
        (JSC::MacroAssemblerARM::xor32):
        (JSC::MacroAssemblerARM::load32):
        (JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
        (JSC::MacroAssemblerARM::loadPtrWithPatchToLEA):
        (JSC::MacroAssemblerARM::load16):
        (JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
        (JSC::MacroAssemblerARM::store32):
        (JSC::MacroAssemblerARM::pop):
        (JSC::MacroAssemblerARM::push):
        (JSC::MacroAssemblerARM::move):
        (JSC::MacroAssemblerARM::swap):
        (JSC::MacroAssemblerARM::signExtend32ToPtr):
        (JSC::MacroAssemblerARM::zeroExtend32ToPtr):
        (JSC::MacroAssemblerARM::branch32):
        (JSC::MacroAssemblerARM::branch16):
        (JSC::MacroAssemblerARM::branchTest32):
        (JSC::MacroAssemblerARM::jump):
        (JSC::MacroAssemblerARM::branchAdd32):
        (JSC::MacroAssemblerARM::mull32):
        (JSC::MacroAssemblerARM::branchMul32):
        (JSC::MacroAssemblerARM::branchSub32):
        (JSC::MacroAssemblerARM::breakpoint):
        (JSC::MacroAssemblerARM::nearCall):
        (JSC::MacroAssemblerARM::call):
        (JSC::MacroAssemblerARM::ret):
        (JSC::MacroAssemblerARM::set32):
        (JSC::MacroAssemblerARM::setTest32):
        (JSC::MacroAssemblerARM::tailRecursiveCall):
        (JSC::MacroAssemblerARM::makeTailRecursiveCall):
        (JSC::MacroAssemblerARM::moveWithPatch):
        (JSC::MacroAssemblerARM::branchPtrWithPatch):
        (JSC::MacroAssemblerARM::storePtrWithPatch):
        (JSC::MacroAssemblerARM::supportsFloatingPoint):
        (JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
        (JSC::MacroAssemblerARM::loadDouble):
        (JSC::MacroAssemblerARM::storeDouble):
        (JSC::MacroAssemblerARM::addDouble):
        (JSC::MacroAssemblerARM::subDouble):
        (JSC::MacroAssemblerARM::mulDouble):
        (JSC::MacroAssemblerARM::convertInt32ToDouble):
        (JSC::MacroAssemblerARM::branchDouble):
        (JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
        (JSC::MacroAssemblerARM::ARMCondition):
        (JSC::MacroAssemblerARM::prepareCall):
        (JSC::MacroAssemblerARM::call32):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::JmpSrc::enableLatePatch):
        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::cacheFlush):
        * wtf/Platform.h:
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generateEnter):
        (JSC::Yarr::RegexGenerator::generateReturn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Levin.
ap@webkit.org [Fri, 17 Jul 2009 21:29:48 +0000 (21:29 +0000)]
    Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=27384
        Random crashes in appcache/update-cache.html test

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveResponse): Reorder code to avoid using a handle
        after canceling it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>
barraclough@apple.com [Fri, 17 Jul 2009 21:17:45 +0000 (21:17 +0000)]
2009-07-17  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Extend AssemblerBuffer with constant pool handling mechanism.
        https://bugs.webkit.org/show_bug.cgi?id=24986

        Add a platform independed constant pool framework.
        This pool can store 32 or 64 bits values which is enough to hold
        any integer, pointer or double constant.

        * assembler/AssemblerBuffer.h:
        (JSC::AssemblerBuffer::putIntUnchecked):
        (JSC::AssemblerBuffer::putInt64Unchecked):
        (JSC::AssemblerBuffer::append):
        (JSC::AssemblerBuffer::grow):
        * assembler/AssemblerBufferWithConstantPool.h: Added.
        (JSC::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert "2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>"
jmalonzo@webkit.org [Fri, 17 Jul 2009 21:17:14 +0000 (21:17 +0000)]
Revert "2009-07-17  Mario Sanchez Prada  <msanchez@igalia.com>"

This reverts commit http://trac.webkit.org/changeset/46038 as it breaks two
accessibility/ tests in the mac builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 17 Jul 2009 21:16:01 +0000 (21:16 +0000)]
2009-07-17  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        WebKit should have a bash completion script to aid with common commands.
        https://bugs.webkit.org/show_bug.cgi?id=27374

        * Scripts/webkit-tools-completion.sh: The script which enables option completion
          for several WebKit command line scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 17 Jul 2009 20:17:06 +0000 (20:17 +0000)]
2009-07-17  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Avoid error spew on Macs, and fix a few other tiny details.

        * Scripts/svn-create-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 17 Jul 2009 20:13:23 +0000 (20:13 +0000)]
2009-07-17  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Dave Levin.

        https://bugs.webkit.org/show_bug.cgi?id=27377
        This makes cpplint complain about this for instance:

            if (true)
            {
                int foo;
            }

        Add the appropriate unit tests.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 17 Jul 2009 20:08:13 +0000 (20:08 +0000)]
2009-07-17  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Dave Levin.

        https://bugs.webkit.org/show_bug.cgi?id=27377
        Don't filter whitespace at the end of the line.  This is not
        explicitly a rule of webkit coding style, but there is no reason
        not to warn of this common style problem.

        Don't filter whitespace newline. Now, cpplint will complain
        about the following situation:

            if (true) {
                doSomething();
                doSomethingAgain();
            }
            else
                doSomething();

        Which is a webkit coding style rule violation.

        * Scripts/modules/cpplint.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 17 Jul 2009 20:05:54 +0000 (20:05 +0000)]
2009-07-17  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Dave Levin.

        https://bugs.webkit.org/show_bug.cgi?id=27377
        Move this comment to where it belongs.

        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Fri, 17 Jul 2009 19:37:21 +0000 (19:37 +0000)]
2009-07-17  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Correct crash in WinLauncher due to improper mixing of BSTR
        and TCHAR types.
        https://bugs.webkit.org/show_bug.cgi?id=27381

        * WinLauncher/WinLauncher.cpp:
        (loadURL): Perform SysReAllocString to update the BSTR with
          the contents of the TCHAR string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Darin Adler.
eroman@chromium.org [Fri, 17 Jul 2009 19:27:39 +0000 (19:27 +0000)]
Reviewed by Darin Adler.

Build fix for non-Darwin.
Add a guard for inclusion of RetainPtr.h which includes CoreFoundation.h

https://bugs.webkit.org/show_bug.cgi?id=27382

* wtf/unicode/icu/CollatorICU.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
levin@chromium.org [Fri, 17 Jul 2009 19:11:26 +0000 (19:11 +0000)]
WebCore:

2009-07-17  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        Need to refactor Worker to derive from AbstractWorker
        https://bugs.webkit.org/show_bug.cgi?id=26948

        Changed Worker to derive from AbstractWorker, which involved moving
        AbstractWorker files from being wrapped by ENABLE_SHARED_WORKERS to
        ENABLE_WORKERS.

        Removed obsolete functionality from the JS/V8 bindings that is now
        inherited from AbstractWorker.

        * WebCore.pro:
        Moved AbstractWorker files out of SHARED_WORKERS section and into WORKERS.
        * bindings/js/JSAbstractWorkerCustom.cpp:
        Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
        * bindings/js/JSWorkerCustom.cpp:
        Removed obsolete event listener code (now in base class)
        (WebCore::JSWorker::mark):
        No longer need to explicitly mark event listeners (handled by base class).
        * bindings/v8/V8Index.h:
        Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
        * bindings/v8/custom/V8CustomBinding.h:
        Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
        * bindings/v8/custom/V8WorkerCustom.cpp:
        Removed obsolete event listener code that now lives in the base class.
        (WebCore::V8WorkerConstructor): Cleaned up legacy style nits.
        * workers/AbstractWorker.cpp:
        Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
        * workers/AbstractWorker.h:
        Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
        * workers/Worker.cpp:
        Removed event listener code (now in base class).
        (WebCore::Worker::Worker): Now derives from AbstractWorker.
        (WebCore::Worker::notifyFinished): Calls dispatchLoadErrorEvent on base class.
        * workers/Worker.h:
        Removed APIs that now live in the base class.
        * workers/Worker.idl:
        Now derives from AbstractWorker.
        Removed APIs that live in the base class, and added a GenerateToJS flag.

LayoutTests:

2009-07-17  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        Need to refactor Worker to derive from AbstractWorker
        https://bugs.webkit.org/show_bug.cgi?id=26948

        Added checks to make sure that Workers are properly constructed and Worker attributes
        are visible on the resulting object.

        * fast/workers/worker-constructor-expected.txt:
        * fast/workers/worker-constructor.html:
        Added explicit check for correct construction/postMessage visibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 17 Jul 2009 19:11:16 +0000 (19:11 +0000)]
2009-07-17  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        cpplint should flag usages of NULL.
        https://bugs.webkit.org/show_bug.cgi?id=27341

        * Scripts/modules/cpplint.py: Add the check for NULL test and call it.
          Make the collapse_strings method public.
        * Scripts/modules/cpplint_unittest.py: Add several tests to verify
          the check for NULL behavior. Adjust existing tests due to the
          new NULL check:
           1. Several had NULL removed (or were just removed completely).
           2. Two tests now do an assert that allows the caller to check
              that a particular error is one of several that was returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Fri, 17 Jul 2009 19:11:11 +0000 (19:11 +0000)]
2009-07-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        Add a parser of patches for linter.
        https://bugs.webkit.org/show_bug.cgi?id=27363

        Adds a simple parser for unified diff format.

        * Scripts/modules/diff_parser.py: Added.
        * Scripts/modules/diff_parser_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Fri, 17 Jul 2009 18:36:03 +0000 (18:36 +0000)]
WebCore:

2009-07-17  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27379
        Absolutely-positioned elements with a scrollbar wrap prematurely.  Make sure to include
        the vertical scrollbar width for overflow:scroll elements.

        Added fast/css/positioned-overflow-scroll.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcPrefWidths):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::calcPrefWidths):

LayoutTests:

2009-07-17  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27379
        Absolutely-positioned elements with a scrollbar wrap prematurely.  Make sure to include
        the vertical scrollbar width for overflow:scroll elements.

        * fast/css/positioned-overflow-scroll.html: Added.
        * platform/mac/fast/css/positioned-overflow-scroll-expected.checksum: Added.
        * platform/mac/fast/css/positioned-overflow-scroll-expected.png: Added.
        * platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by John Sullivan.
ap@webkit.org [Fri, 17 Jul 2009 18:21:58 +0000 (18:21 +0000)]
    Reviewed by John Sullivan.

        Get user default collation order via a CFLocale API when available.

        * wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Jeremy Orlow <jorlow@chromium.org>
dglazkov@chromium.org [Fri, 17 Jul 2009 18:01:53 +0000 (18:01 +0000)]
2009-07-17  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Need a DOM_STORAGE guard in DerivedSroucesAllInOne.cpp
        https://bugs.webkit.org/show_bug.cgi?id=27375

        In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp
        and StorageEvent.cpp.  Unfortunately, until later this afternoon,
        DOM_STORAGE is not turned on by default in Chromium, and so these two
        files are never generated.  This breaks the compile.

        There are no other instances of guards in the file, which puzzles me...
        but I think adding guards is the right way to go about this.

        * bindings/v8/DerivedSourcesAllInOne.cpp:  Added the guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
treat@webkit.org [Fri, 17 Jul 2009 18:00:54 +0000 (18:00 +0000)]
2009-07-17  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Adam Treat.

        Coding style fixes.

        * Api/qcookiejar.cpp:
        (QCookieJarPrivate::QCookieJarPrivate):
        (qHash):
        (QCookieJar::cookieJar):
        * Api/qwebelement.cpp:
        (QWebElement::functions):
        (QWebElement::scriptableProperties):
        * Api/qwebframe.cpp:
        (QWebFrame::metaData):
        (QWebFrame::scrollBarValue):
        (QWebFrame::scroll):
        (QWebFrame::scrollPosition):
        (QWebFrame::print):
        * Api/qwebnetworkinterface.cpp:
        (decodePercentEncoding):
        (QWebNetworkRequestPrivate::init):
        (QWebNetworkRequestPrivate::setURL):
        (QWebNetworkRequest::QWebNetworkRequest):
        (QWebNetworkRequest::operator=):
        (QWebNetworkRequest::setUrl):
        (QWebNetworkRequest::setHttpHeader):
        (QWebNetworkRequest::httpHeaderField):
        (QWebNetworkRequest::setHttpHeaderField):
        (QWebNetworkRequest::setPostData):
        (QWebNetworkJob::setResponse):
        (QWebNetworkJob::frame):
        (QWebNetworkManager::add):
        (QWebNetworkManager::cancel):
        (QWebNetworkManager::started):
        (QWebNetworkManager::data):
        (QWebNetworkManager::finished):
        (QWebNetworkManager::addHttpJob):
        (QWebNetworkManager::cancelHttpJob):
        (QWebNetworkManager::httpConnectionClosed):
        (QWebNetworkInterfacePrivate::sendFileData):
        (QWebNetworkInterfacePrivate::parseDataUrl):
        (QWebNetworkManager::doWork):
        (QWebNetworkInterface::setDefaultInterface):
        (QWebNetworkInterface::defaultInterface):
        (QWebNetworkInterface::QWebNetworkInterface):
        (QWebNetworkInterface::addJob):
        (QWebNetworkInterface::cancelJob):
        (WebCoreHttp::WebCoreHttp):
        (WebCoreHttp::request):
        (WebCoreHttp::scheduleNextRequest):
        (WebCoreHttp::getConnection):
        (WebCoreHttp::onResponseHeaderReceived):
        (WebCoreHttp::onReadyRead):
        (WebCoreHttp::onRequestFinished):
        (WebCoreHttp::onAuthenticationRequired):
        (WebCoreHttp::onProxyAuthenticationRequired):
        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        (QWebPagePrivate::mouseReleaseEvent):
        (QWebPagePrivate::inputMethodEvent):
        (QWebPagePrivate::shortcutOverrideEvent):
        (QWebPage::inputMethodQuery):
        (QWebPage::javaScriptPrompt):
        (QWebPage::updatePositionDependentActions):
        (QWebPage::userAgentForUrl):
        (QWebPagePrivate::_q_onLoadProgressChanged):
        (QWebPage::totalBytes):
        (QWebPage::bytesReceived):
        * Api/qwebsettings.cpp:
        (QWebSettings::iconForUrl):
        (QWebSettings::setObjectCacheCapacities):
        * Api/qwebview.cpp:
        (QWebView::paintEvent):
        (QWebView::changeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 17 Jul 2009 17:53:27 +0000 (17:53 +0000)]
2009-07-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26496

        Let WebCore always enforce the connection-per-host limit itself.

        * loader/loader.cpp:
        (WebCore::Loader::Host::servePendingRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>
kov@webkit.org [Fri, 17 Jul 2009 16:48:18 +0000 (16:48 +0000)]
2009-07-17  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25524
        [Gtk] Expose the title attribute to assistive technologies

        Expose 'alt' attribute from images as accessible name.
        Expose the 'title' core HTML attribute as accessible description.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::stringValue):
        (WebCore::AccessibilityRenderObject::accessibilityDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Some transitions don't work correctly on Leopard
cmarrin@apple.com [Fri, 17 Jul 2009 16:41:12 +0000 (16:41 +0000)]
    Some transitions don't work correctly on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=27356

        We only have code to do component animation using valueFunction.
        So on Leopard we always need to do matrix animation in hardware.
        This fix ensures that.

        This is currently not testable because it appears only in the
        hardware animation and we can't yet do pixel tests while
        hardware animating.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK+] Make TestNescpaePlugin loadable in mozilla
zecke@webkit.org [Fri, 17 Jul 2009 15:56:43 +0000 (15:56 +0000)]
[GTK+] Make TestNescpaePlugin loadable in mozilla

https://bugs.webkit.org/show_bug.cgi?id=27345

Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.

For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Fri, 17 Jul 2009 14:48:22 +0000 (14:48 +0000)]
2009-07-17  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by NOBODY (OOPS!).

        [GTK+] Crash in screenAvailable due a null Widget*

        JSDOMWindow::open called screenAvailableRect(0). The other
        Screen methods can be called with a null widget as well, fix the
        crashing test by checking for null.

        In screenRect and screenAvailableRect it is not tried to use
        a default screen as the existing implementation didn't try either
        in case of not having a toplevel widget.

        LayoutTests/fast/frames/crash-removed-iframe.html caused a crash.

        * platform/gtk/PlatformScreenGtk.cpp:
        (WebCore::getVisual): New method to get a visual or return zero.
        (WebCore::screenDepth): Use getVisual.
        (WebCore::screenDepthPerComponent): Use getVisual.
        (WebCore::screenIsMonochrome): Use screenDepth which will do the null checking
        (WebCore::screenRect): Check for !widget.
        (WebCore::screenAvailableRect): Check for !widget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
hausmann@webkit.org [Fri, 17 Jul 2009 14:44:11 +0000 (14:44 +0000)]
2009-07-17  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Remove tests from Qt Skipped list that are actually working.
        https://bugs.webkit.org/show_bug.cgi?id=27316

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 17 Jul 2009 14:09:53 +0000 (14:09 +0000)]
2009-07-17  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Simon Hausmann.

        Something about having a single TAB in a style checking tool like this
        is equivalent to nails on a chalk board to me...

        * Scripts/modules/cpplint.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
hausmann@webkit.org [Fri, 17 Jul 2009 13:56:42 +0000 (13:56 +0000)]
JavaScriptCore:

2009-07-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix the include path for the Symbian port
        https://bugs.webkit.org/show_bug.cgi?id=27358

        * JavaScriptCore.pri:

WebCore:

2009-07-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix the include path for the Symbian port
        https://bugs.webkit.org/show_bug.cgi?id=27358

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix a small typo in the changelog
hausmann@webkit.org [Fri, 17 Jul 2009 13:34:20 +0000 (13:34 +0000)]
Fix a small typo in the changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Fri, 17 Jul 2009 13:32:11 +0000 (13:32 +0000)]
WebCore:

2009-07-17  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Make it possible to set the plugin directories from the DRT.
        Part of https://bugs.webkit.org/show_bug.cgi?id=27215

        * plugins/PluginDatabase.cpp:
        (WebCore::PluginDatabase::installedPlugins): Now optionally takes
        a populate argument, so we can avoid loading system plugins from the
        DRT and thus avoid their strerr errors that can make tests fail.
        (WebCore::PluginDatabase::clear): Make is possible to clear the
        database. Called from setPluginDirectories.
        * plugins/PluginDatabase.h:
        (WebCore::PluginDatabase::setPluginDirectories): Make public

WebKit/qt:

2009-07-17  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Overwrite the plugin directories for the DRT.
        Part of https://bugs.webkit.org/show_bug.cgi?id=27215

        * Api/qwebpage.cpp:
        (qt_drt_overwritePluginDirectories): Only set the plugin directories
        to the ones in the QTWEBKIT_PLUGIN_PATH environment variable.

WebKitTools:

2009-07-17  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Overwrite the plugin directories for the DRT.
        Part of https://bugs.webkit.org/show_bug.cgi?id=27215

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Fri, 17 Jul 2009 12:43:05 +0000 (12:43 +0000)]
2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        PluginViewMac: Stop the plugin when loading fails

        Also, prevent event propagation when in the stopped state

        * plugins/mac/PluginViewMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Fri, 17 Jul 2009 12:40:45 +0000 (12:40 +0000)]
2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        PluginViewMac: Allow query and set of drawing and event models

        We now support querying and setting of the drawing and event model,
        but we still only support the CoreGraphics drawing model, and the
        Carbon event model.

        If unsupported drawing or event models are detected we show the
        missing-plugin icon.

        * plugins/PluginView.cpp:
        * plugins/PluginView.h:
        * plugins/mac/PluginViewMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Fri, 17 Jul 2009 12:17:25 +0000 (12:17 +0000)]
2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Initialize two PluginView members using memset

        m_npWindow is used on all platforms, not just for XP_UNIX,
        so always initialize it. m_npCgContext on the other hand
        is only used for XP_MACOSX.

        * plugins/PluginView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Fri, 17 Jul 2009 11:46:48 +0000 (11:46 +0000)]
2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Add more debug logging in PluginView

        * plugins/PluginView.cpp: Add debug for setValue
        * plugins/gtk/PluginViewGtk.cpp: Add debug for getValue
        * plugins/mac/PluginViewMac.cpp: Add debug for getValue and more
        * plugins/qt/PluginViewQt.cpp: Add debug for getValue
        * plugins/win/PluginViewWin.cpp: Add debug for getValue

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
levin@chromium.org [Fri, 17 Jul 2009 11:00:41 +0000 (11:00 +0000)]
2009-07-17  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by David Levin.

        Build fix on platforms don't have MMAP.
        https://bugs.webkit.org/show_bug.cgi?id=27365

        * interpreter/RegisterFile.h: Including stdio.h irrespectively of HAVE(MMAP)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Fri, 17 Jul 2009 10:52:42 +0000 (10:52 +0000)]
2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Holger Freyther.

        Use same license in PluginDebug.cpp as in the original PluginDebug.h

        * plugins/PluginDebug.cpp: Use license from PluginDebug.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Fri, 17 Jul 2009 10:35:12 +0000 (10:35 +0000)]
2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Add more debugging functionality for the WebCore NPAPI layer

        * GNUmakefile.am: Add PluginDebug.cpp
        * WebCore.gypi: Add PluginDebug.cpp
        * WebCore.pro: Add PluginDebug.cpp
        * WebCore.vcproj/WebCore.vcproj: Add PluginDebug.cpp
        * WebCoreSources.bkl: Add PluginDebug.cpp
        * plugins/PluginDebug.h: Move errorStrings to PluginDebug.cpp
        * plugins/PluginDebug.cpp: New file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Jeremy Orlow <jorlow@chromium.org>
levin@chromium.org [Fri, 17 Jul 2009 07:42:09 +0000 (07:42 +0000)]
2009-07-17  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by David Levin.

        Fix Chromium build with DOM_STORAGE enabled.
        https://bugs.webkit.org/show_bug.cgi?id=27360

        2 minor changes as noted below:

        * bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .cpp files.
        * storage/StorageAreaImpl.cpp:  #include "DOMWindow.h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-16 Fumitoshi Ukai <ukai@chromium.org>
levin@chromium.org [Fri, 17 Jul 2009 07:42:03 +0000 (07:42 +0000)]
2009-07-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
        https://bugs.webkit.org/show_bug.cgi?id=27206

.:

        Add --enable-web-sockets in configure.ac

        * configure.ac:

JavaScriptCore:

        Add ENABLE_WEB_SOCKETS

        * Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS

WebCore:

        Add ENABLE_WEB_SOCKETS

        * Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS
        * GNUmakefile.am: add ENABLE_WEB_SOCKETS
        * WebCore.vcproj/WebCoreCommon.vsprops: add ENABLE_WEB_SOCKETS
        * WebCore.vcproj/build-generated-files.sh: add ENABLE_WEB_SOCKETS

WebKit/mac:

        Add ENABLE_WEB_SOCKETS

        * Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS

WebKit/win:

        Add ENABLE_WEB_SOCKETS

        * WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS

WebKitTools:

        Add --web-sockets flag.

        * Scripts/build-webkit: add --web-sockets flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-16 Maxime Simon <simon.maxime@gmail.com>
abarth@webkit.org [Fri, 17 Jul 2009 06:41:58 +0000 (06:41 +0000)]
2009-07-16  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Oliver Hunt.

        Added a third bunch of Haiku-specific files for WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=26952

        Adding five files, EventLoopHaiku.cpp, FileChooserHaiku.cpp,
        FileSystemHaiku.cpp, KeyboardCodes.h and MIMETypeRegistryHaiku.cpp

        * platform/haiku/EventLoopHaiku.cpp: Added.
        (WebCore::EventLoop::cycle):
        * platform/haiku/FileChooserHaiku.cpp: Added.
        (WebCore::FileChooser::FileChooser):
        (WebCore::FileChooser::basenameForWidth):
        * platform/haiku/FileSystemHaiku.cpp: Added.
        (WebCore::fileSystemRepresentation):
        (WebCore::homeDirectoryPath):
        (WebCore::openTemporaryFile):
        (WebCore::closeFile):
        (WebCore::writeToFile):
        (WebCore::unloadModule):
        (WebCore::listDirectory):
        * platform/haiku/KeyboardCodes.h: Added.
        * platform/haiku/MIMETypeRegistryHaiku.cpp: Added.
        (WebCore::):
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-16 Maxime Simon <simon.maxime@gmail.com>
abarth@webkit.org [Fri, 17 Jul 2009 06:41:27 +0000 (06:41 +0000)]
2009-07-16  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Oliver Hunt.

        Added a second bunch of Haiku-specific files for WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=26952

        Adding four files, ContextMenuHaiku.cpp, ContextMenuItemHaiku.cpp,
        DragDataHaiku.cpp and DragImageHaiku.cpp

        * platform/haiku/ContextMenuHaiku.cpp: Added.
        (WebCore::ContextMenuReceiver::ContextMenuReceiver):
        (WebCore::ContextMenuReceiver::HandleMessage):
        (WebCore::ContextMenuReceiver::Result):
        (WebCore::ContextMenu::ContextMenu):
        (WebCore::ContextMenu::~ContextMenu):
        (WebCore::ContextMenu::appendItem):
        (WebCore::ContextMenu::itemCount):
        (WebCore::ContextMenu::insertItem):
        (WebCore::ContextMenu::platformDescription):
        (WebCore::ContextMenu::setPlatformDescription):
        * platform/haiku/ContextMenuItemHaiku.cpp: Added.
        (ContextMenuItem::ContextMenuItem):
        (ContextMenuItem::~ContextMenuItem):
        (ContextMenuItem::releasePlatformDescription):
        (ContextMenuItem::type):
        (ContextMenuItem::setType):
        (ContextMenuItem::action):
        (ContextMenuItem::setAction):
        (ContextMenuItem::title):
        (ContextMenuItem::setTitle):
        (ContextMenuItem::platformSubMenu):
        (ContextMenuItem::setSubMenu):
        (ContextMenuItem::setChecked):
        (ContextMenuItem::setEnabled):
        (ContextMenuItem::enabled):
        * platform/haiku/DragDataHaiku.cpp: Added.
        (WebCore::DragData::canSmartReplace):
        (WebCore::DragData::containsColor):
        (WebCore::DragData::containsFiles):
        (WebCore::DragData::asFilenames):
        (WebCore::DragData::containsPlainText):
        (WebCore::DragData::asPlainText):
        (WebCore::DragData::asColor):
        (WebCore::DragData::createClipboard):
        (WebCore::DragData::containsCompatibleContent):
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        (WebCore::DragData::asFragment):
        * platform/haiku/DragImageHaiku.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-16 Maxime Simon <simon.maxime@gmail.com>
abarth@webkit.org [Fri, 17 Jul 2009 06:30:12 +0000 (06:30 +0000)]
2009-07-16  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        Added Haiku-specific files for JavaScriptCore.
        https://bugs.webkit.org/show_bug.cgi?id=26620

        * wtf/haiku/MainThreadHaiku.cpp: Added.
        (WTF::initializeMainThreadPlatform):
        (WTF::scheduleDispatchFunctionsOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-16 Stephen White <senorblanco@chromium.org>
darin@chromium.org [Fri, 17 Jul 2009 06:28:02 +0000 (06:28 +0000)]
2009-07-16  Stephen White  <senorblanco@chromium.org>

        Reviewed by Darin Fisher and Brett Wilson.

        Refactor Skia implementation of gradients and patterns.

        http://bugs.webkit.org/show_bug.cgi?id=26618

        The following layout tests were breaking on Chromium/Linux:

        LayoutTests/svg/custom/js-late-gradient-creation.svg (bad baseline PNG)
        LayoutTests/svg/custom/js-late-gradient-and-object.creation.svg
        LayoutTests/svg/custom/js-late-pattern-creation.svg (bad baseline PNG)
        LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg

        I could've fixed these the easy way, by copying the same 5
        lines of code we use everywhere we need patterns or gradients, but
        I decided to fix it the hard way:  by refactoring the code so that
        PlatformContextSkia::setupPaintForFilling() and
        PlatformContextSkia::setupPaintForStroking() do the right thing,
        and also handle gradients and patterns.

        This required pushing the gradients and patterns set in
        (generic) GraphicsContext::setFillPattern() and friends down into
        PlatformContextSkia.  For this, I followed the setPlatformXXX()
        pattern used elsewhere in GraphicsContext, and stubbed them out on
        the other platforms with #if !PLATFORM(SKIA).  This also required
        pushing changes to the gradientSpaceTransform from the Gradient into
        GradientSkia.

        Since it's a Skia context, I decided to cache the values as
        SkShaders.  There were existing m_pattern and m_gradient SkShaders,
        but they were unused, and whose use was ambiguous, so I
        replaced them with one SkShader each for filling and stroking.

        * platform/graphics/Gradient.cpp:
        (WebCore::Gradient::setGradientSpaceTransform):
        (WebCore::Gradient::setPlatformGradientSpaceTransform):
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setStrokePattern):
        (WebCore::GraphicsContext::setFillPattern):
        (WebCore::GraphicsContext::setStrokeGradient):
        (WebCore::GraphicsContext::setFillGradient):
        (WebCore::GraphicsContext::setPlatformFillGradient):
        (WebCore::GraphicsContext::setPlatformFillPattern):
        (WebCore::GraphicsContext::setPlatformStrokeGradient):
        (WebCore::GraphicsContext::setPlatformStrokePattern):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/skia/GradientSkia.cpp:
        (WebCore::Gradient::setPlatformGradientSpaceTransform):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::setPlatformFillGradient):
        (WebCore::GraphicsContext::setPlatformFillPattern):
        (WebCore::GraphicsContext::setPlatformStrokeGradient):
        (WebCore::GraphicsContext::setPlatformStrokePattern):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::strokeRect):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::State::State):
        (PlatformContextSkia::State::~State):
        (PlatformContextSkia::drawRect):
        (PlatformContextSkia::setupPaintCommon):
        (PlatformContextSkia::setupPaintForFilling):
        (PlatformContextSkia::setupPaintForStroking):
        (PlatformContextSkia::setFillColor):
        (PlatformContextSkia::setStrokeColor):
        (PlatformContextSkia::setStrokeShader):
        (PlatformContextSkia::setFillShader):
        * platform/graphics/skia/PlatformContextSkia.h:
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::skiaDrawText):
        (WebCore::paintSkiaText):
        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::SVGPaintServer::teardown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46017 268f45cc-cd09-0410-ab3c-d52691b4dbfc