WebKit-https.git
7 years agoMake GraphicsLayerCA::backingStoreMemoryEstimate() give a better estimate for tiled...
simon.fraser@apple.com [Thu, 21 Mar 2013 05:59:13 +0000 (05:59 +0000)]
Make GraphicsLayerCA::backingStoreMemoryEstimate() give a better estimate for tiled layers
https://bugs.webkit.org/show_bug.cgi?id=112864

Reviewed by Tim Horton.

If a GraphicsLayerCA has TiledBacking, ask the TiledBacking how
much memory it's using for tiles, rather than just using
height * width * 4.

Implement retainedTileBackingStoreMemory() in the TileController,
summing the memory used by parented tiles.

The original code was incorrectly multiplying by contentsScale
only once rather than twice (2x contents scale uses 4x as much memory).

* platform/graphics/TiledBacking.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::backingStoreMemoryEstimate):
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::retainedTileBackingStoreMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation update for r145055
tkent@chromium.org [Thu, 21 Mar 2013 05:53:20 +0000 (05:53 +0000)]
[Chromium] Test expectation update for r145055
https://bugs.webkit.org/show_bug.cgi?id=111319

* platform/chromium-linux-x86/fast/forms/time/time-appearance-pseudo-elements-expected.png: Removed.
* platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r189497. Requested by
commit-queue@webkit.org [Thu, 21 Mar 2013 04:57:48 +0000 (04:57 +0000)]
Unreviewed.  Rolled Chromium DEPS to r189497.  Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Test expectations updates, and rebaseline to parallel r143389.
pkasting@chromium.org [Thu, 21 Mar 2013 04:05:39 +0000 (04:05 +0000)]
[chromium] Test expectations updates, and rebaseline to parallel r143389.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=99984
https://bugs.webkit.org/show_bug.cgi?id=111004
https://bugs.webkit.org/show_bug.cgi?id=112288
https://bugs.webkit.org/show_bug.cgi?id=112755

Unreviewed, test expectations updates.

* platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline some of my recent test changes
commit-queue@webkit.org [Thu, 21 Mar 2013 03:43:47 +0000 (03:43 +0000)]
Rebaseline some of my recent test changes
https://bugs.webkit.org/show_bug.cgi?id=112843

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Ojan Vafai.

* platform/chromium-mac-lion/css3/flexbox/button-expected.png: Added.
* platform/chromium-mac-lion/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium-mac-snowleopard/css3/flexbox/button-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium-mac/css3/flexbox/button-expected.png: Added.
* platform/chromium-mac/css3/flexbox/button-expected.txt: Added.
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
* platform/chromium-win/css3/flexbox/button-expected.png: Added.
* platform/chromium-win/css3/flexbox/button-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146418.
commit-queue@webkit.org [Thu, 21 Mar 2013 03:35:02 +0000 (03:35 +0000)]
Unreviewed, rolling out r146418.
http://trac.webkit.org/changeset/146418
https://bugs.webkit.org/show_bug.cgi?id=112872

It turns out that these sub pixel tests still do fail on Mac
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Remove test cases which need to do rebaseline in EFL TestExpectations.
gyuyoung.kim@samsung.com [Thu, 21 Mar 2013 02:47:04 +0000 (02:47 +0000)]
Unreviewed. Remove test cases which need to do rebaseline in EFL TestExpectations.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146419.
rniwa@webkit.org [Thu, 21 Mar 2013 02:43:43 +0000 (02:43 +0000)]
Unreviewed, rolling out r146419.
http://trac.webkit.org/changeset/146419
https://bugs.webkit.org/show_bug.cgi?id=112870

Broke many tests on debug builds (Requested by rniwa_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

Source/WebCore:

* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
(main):
* bindings/scripts/StaticString.pm: Removed.
* dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
* dom/QualifiedName.h:
(WebCore):
* dom/make_names.pl:
(printNamesCppFile):
(printDefinitions):

Source/WTF:

* wtf/text/StringImpl.h:
(StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] Implement EnforceRange IDL attribute for integer conversions
commit-queue@webkit.org [Thu, 21 Mar 2013 02:42:02 +0000 (02:42 +0000)]
[JSC] Implement EnforceRange IDL attribute for integer conversions
https://bugs.webkit.org/show_bug.cgi?id=112506

Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Implement the EnforceRange attribute for JSC bindings.

The EnforceRange attribute requires a type error to be thrown when
converting an ECMAScript number which is beyond the representable
range of the IDL integer type.

Tests: fast/js/webidl-type-mapping.html
       storage/indexeddb/cursor-advance-workers.html
       storage/indexeddb/cursor-advance.html
       storage/indexeddb/intversion-bad-parameters.html

* WebCore.exp.in:
* bindings/js/JSDOMBinding.cpp:
(WebCore):
(WebCore::enforceRange):
(WebCore::toInt32EnforceRange):
(WebCore::toUInt32EnforceRange):
(WebCore::toInt64):
(WebCore::toUInt64):
* bindings/js/JSDOMBinding.h:
(WebCore::toInt32):
(WebCore):
(WebCore::toUInt32):
* bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

* fast/js/webidl-type-mapping-expected.txt:
* platform/chromium/fast/js/webidl-type-mapping-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[QNX][ARM] REGRESSION(r135330): Various failures in Octane
commit-queue@webkit.org [Thu, 21 Mar 2013 02:33:41 +0000 (02:33 +0000)]
[QNX][ARM] REGRESSION(r135330): Various failures in Octane
https://bugs.webkit.org/show_bug.cgi?id=112863

Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-03-20
Reviewed by Yong Li.

This was fixed in http://trac.webkit.org/changeset/146396 on Linux only.
Enable this fix on QNX.

* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd flaky test expectations to compositing/geometry/limit-layer-bounds-fixed.html
rniwa@webkit.org [Thu, 21 Mar 2013 02:26:21 +0000 (02:26 +0000)]
Add flaky test expectations to compositing/geometry/limit-layer-bounds-fixed.html
and fast/dom/MutationObserver/database-callback-delivery.html on Windows per bugs
112867 and 112868.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGesture events should include AllowShadowContent in hit testing
hayato@chromium.org [Thu, 21 Mar 2013 01:51:31 +0000 (01:51 +0000)]
Gesture events should include AllowShadowContent in hit testing
https://bugs.webkit.org/show_bug.cgi?id=112073

Reviewed by Dimitri Glazkov.

Source/WebCore:

Support gesture events for Shadow DOM.
Now 'gesturetap' events can be correctly dispatched in shadow trees.

Test: fast/dom/shadow/gesture-tap.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):

LayoutTests:

* fast/dom/shadow/gesture-tap-expected.txt: Added.
* fast/dom/shadow/gesture-tap.html: Added.
* fast/dom/shadow/resources/event-dispatching.js:
(addEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShould add test for bug #112694
msaboff@apple.com [Thu, 21 Mar 2013 01:46:35 +0000 (01:46 +0000)]
Should add test for bug #112694
https://bugs.webkit.org/show_bug.cgi?id=112859

Reviewed by Filip Pizlo.

New regression test to check that eliminating a var arg DFG Node (array in this case) doesn't
cause a ASSERT or crash.

* fast/js/dfg-array-dead-expected.txt: Added.
* fast/js/dfg-array-dead.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-array-dead.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
mrowe@apple.com [Thu, 21 Mar 2013 01:44:23 +0000 (01:44 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r146415. I somehow missed the 1px difference.
rniwa@webkit.org [Thu, 21 Mar 2013 01:44:13 +0000 (01:44 +0000)]
Mac rebaseline after r146415. I somehow missed the 1px difference.

* platform/mac/svg/custom/text-ctm-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago../ThirdParty: [WinCairo] Build WinCairo port under VS2010.
bfulgham@webkit.org [Thu, 21 Mar 2013 00:49:16 +0000 (00:49 +0000)]
../ThirdParty: [WinCairo] Build WinCairo port under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861

Reviewed by Tim Horton.

* gtest/msvc/gtest-md.vcxproj: Add WinCairo targets.

../WebKit: [WinCairo] Top-level solution change to build under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861.

Reviewed by Tim Horton.

* WebKit.vcxproj/WebKit.sln: Add final set of WinCairo build
targets.
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Add #if/def guards around some media-specific exports that
are not provided by the WinCairo port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update test expectations to more closely match reality.
pkasting@chromium.org [Thu, 21 Mar 2013 00:43:54 +0000 (00:43 +0000)]
[chromium] Update test expectations to more closely match reality.
https://bugs.webkit.org/show_bug.cgi?id=106609
https://code.google.com/p/chromium/issues/detail?id=222140

Unreviewed, test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
bfulgham@webkit.org [Thu, 21 Mar 2013 00:36:16 +0000 (00:36 +0000)]
[WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010

* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
New property sheet that does not link against CoreFoundation and
CFNetwork.
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
Use new TestWebKitAPICommonWinCairo property sheet.
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLNames should construct strings at compile time
abarth@webkit.org [Thu, 21 Mar 2013 00:31:45 +0000 (00:31 +0000)]
HTMLNames should construct strings at compile time
https://bugs.webkit.org/show_bug.cgi?id=112831

Reviewed by Darin Adler.

Source/WebCore:

This patch teaches make_names how to construct strings at compile time,
eliminating a large number of startup mallocs.

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
    - Teach the Chromium build how to deal with Perl modules.
* bindings/scripts/StaticString.pm: Added.
    - A Perl module for constructing static strings.
(GenerateStrings):
(GenerateValidateStrings):
* dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
    - createQualifiedName now takes an already-constructed StringImpl
      object.
* dom/QualifiedName.h:
* dom/make_names.pl:
(valueForName):
(namesToStrings):
(printNamesCppFile):
(printDefinitions):
    - Teach make_names how to use StaticString.pm.

Source/WTF:

* wtf/text/StringImpl.h:
(StringImpl):
(StaticASCIILiteral):
    - This struct lets us construct StringImpl objects at compile time.
(WTF::StringImpl::assertValidHash):
    - This function lets us sanity check StringImpl objects created from StaticData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove entires added by r138484 now that these tests pass on Mac.
rniwa@webkit.org [Thu, 21 Mar 2013 00:20:55 +0000 (00:20 +0000)]
Remove entires added by r138484 now that these tests pass on Mac.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
falken@chromium.org [Thu, 21 Mar 2013 00:09:32 +0000 (00:09 +0000)]
Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
https://bugs.webkit.org/show_bug.cgi?id=112767

Reviewed by Kent Tamura.

This is part of a refactoring to move Node::disabled to HTMLFormControlElement::disabled.
The concept of disabled is just a form control element one.

HTMLMeterElement, HTMLOutputElement, and HTMLProgressElement never
have disabled() return true, so we can remove the call. In addition,
HTMLMeterElement and HTMLProgressElement no longer inherit from
HTMLFormControlElement, so we don't need to override supportsFocus.

No new tests because no behavior change.

* html/HTMLMeterElement.cpp:
* html/HTMLMeterElement.h:
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
* html/HTMLProgressElement.cpp:
* html/HTMLProgressElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix for VS2010.
bfulgham@webkit.org [Thu, 21 Mar 2013 00:08:39 +0000 (00:08 +0000)]
[WinCairo] Unreviewed build fix for VS2010.

Had to add WinCairo-specific property sheets to deal with some
library and path differences with the main Apple port.

* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove an entry added in r141645 as this test is now passing.
rniwa@webkit.org [Thu, 21 Mar 2013 00:06:57 +0000 (00:06 +0000)]
Remove an entry added in r141645 as this test is now passing.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/css/empty-generated-content.html needs to be rebaselined after 104462
rniwa@webkit.org [Thu, 21 Mar 2013 00:03:15 +0000 (00:03 +0000)]
fast/css/empty-generated-content.html needs to be rebaselined after 104462
https://bugs.webkit.org/show_bug.cgi?id=104595

* platform/mac/TestExpectations:
* platform/mac/fast/css/empty-generated-content-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline expected results added in r143389 so that they have alpha values.
rniwa@webkit.org [Wed, 20 Mar 2013 23:53:13 +0000 (23:53 +0000)]
Rebaseline expected results added in r143389 so that they have alpha values.

* platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* svg/as-image/image-preserveAspectRatio-all-expected.png:
* svg/filters/feImage-preserveAspectRatio-all-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove test expectations added in r133786 as these tests are now passing.
rniwa@webkit.org [Wed, 20 Mar 2013 23:49:43 +0000 (23:49 +0000)]
Remove test expectations added in r133786 as these tests are now passing.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinspector/debugger/debugger-reload-on-pause.html assertion failure on Mac after r141136
rniwa@webkit.org [Wed, 20 Mar 2013 23:46:00 +0000 (23:46 +0000)]
inspector/debugger/debugger-reload-on-pause.html assertion failure on Mac after r141136
https://bugs.webkit.org/show_bug.cgi?id=109232

Unreviewed. Remove the test expectation entry since this test hasn't been crashing lately.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline intended to be done in r146409 for r144096.
rniwa@webkit.org [Wed, 20 Mar 2013 23:41:29 +0000 (23:41 +0000)]
Mac rebaseline intended to be done in r146409 for r144096.

* platform/mac/TestExpectations:
* platform/mac/css2.1/20110323/replaced-elements-001-expected.png:
* platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Copied from LayoutTests/css2.1/20110323/replaced-elements-001-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r144096.
rniwa@webkit.org [Wed, 20 Mar 2013 23:31:44 +0000 (23:31 +0000)]
Mac rebaseline after r144096.

* platform/mac/TestExpectations:
* platform/mac/css3/flexbox/button-expected.png: Copied from LayoutTests/css3/flexbox/button-expected.png.
* platform/mac/css3/flexbox/button-expected.txt: Copied from LayoutTests/css3/flexbox/button-expected.txt.
* platform/mac/svg/custom/foreign-object-skew-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [css3-text] Parsing -webkit-each-line value for text-indent from...
commit-queue@webkit.org [Wed, 20 Mar 2013 23:20:33 +0000 (23:20 +0000)]
Source/WebCore: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=109021

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
Reviewed by Julien Chaffraix.

"each-line" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#each-line

This patch is the parsing part to support each-line value for text-indent.

"each-line" means "Indentation affects the first line of the block
container as well as each line after a forced line break, but does
not affect lines after a soft wrap break."

It's prefixed and guarded by CSS3_TEXT flag.

Tests: fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html
       fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
    style.getPropertyCSSValue(text-indent) returns CSSPrimitiveValue when text-indent has only <length>
    or <percentage> value, but returns CSSValueList when text-indent also has -webkit-each-line.

* css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID): Removed CSSPropertyTextIndent case.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextIndent): Added.
* css/CSSParser.h:
    Parsed <length> or <percentage> with -webkit-each-line for text-indent.

* css/CSSValueKeywords.in: Added new -webkit-each-line keyword.
* css/StyleBuilder.cpp:
(ApplyPropertyTextIndent): Added.
(WebCore::ApplyPropertyTextIndent::applyInheritValue):
(WebCore::ApplyPropertyTextIndent::applyInitialValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
(WebCore::ApplyPropertyTextIndent::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
    Added codes to handle applying text-indent offset and -webkit-each-line option to our style.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h: Added enum TextIndentLine.
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h: Added m_textIndentLine.
(StyleRareInheritedData):
    Added the usual getter / setter / initial methods for m_textIndentLine.

LayoutTests: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=109021

"each-line" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#each-line

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
Reviewed by Julien Chaffraix.

* fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt: Added.
* fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt: Added.
* fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html: Added.
* fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html: Added.
* fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent-inherited.js: Added.
(testComputedStyle):
(ownValueTest):
(inheritanceTest):
* fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js: Added.
(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix indentation of JSString.h
fpizlo@apple.com [Wed, 20 Mar 2013 23:16:01 +0000 (23:16 +0000)]
Fix indentation of JSString.h

Rubber stamped by Mark Hahnenberg.

* runtime/JSString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodialog-enabled.html and dialog-disabled.html don't really test what they think they do
tsepez@chromium.org [Wed, 20 Mar 2013 23:04:44 +0000 (23:04 +0000)]
dialog-enabled.html and dialog-disabled.html don't really test what they think they do
https://bugs.webkit.org/show_bug.cgi?id=112848

Reviewed by Adam Barth.

* fast/dom/HTMLDialogElement/dialog-disabled.html:
* fast/dom/HTMLDialogElement/dialog-enabled.html:
Set the dialog element enabled setting before parsing <dialog> element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r142152.
rniwa@webkit.org [Wed, 20 Mar 2013 23:03:22 +0000 (23:03 +0000)]
Mac rebaseline after r142152.

* platform/mac/TestExpectations:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r140693.
rniwa@webkit.org [Wed, 20 Mar 2013 22:52:14 +0000 (22:52 +0000)]
Mac rebaseline after r140693.

* editing/selection/extend-by-sentence-001-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/css2.1/t0505-c16-descendant-01-e-expected.png:
* platform/mac/css2.1/t0505-c16-descendant-01-e-expected.txt:
* platform/mac/editing/selection/extend-by-sentence-001-expected.png:
* platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
* platform/mac/fast/text/capitalize-empty-generated-string-expected.png:
* platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:
* platform/mac/fast/text/whitespace/006-expected.png:
* platform/mac/fast/text/whitespace/006-expected.txt:
* platform/mac/fast/text/whitespace/007-expected.png:
* platform/mac/fast/text/whitespace/007-expected.txt:
* platform/mac/svg/batik/text/xmlSpace-expected.png:
* platform/mac/svg/batik/text/xmlSpace-expected.txt:
* platform/mac/svg/carto.net/combobox-expected.png:
* platform/mac/tables/mozilla/bugs/bug113235-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1188-expected.png:
* platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* svg/carto.net/combobox-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r139282.
rniwa@webkit.org [Wed, 20 Mar 2013 22:43:58 +0000 (22:43 +0000)]
Mac rebaseline after r139282.

* fast/repaint/caret-with-transformation-expected.png: Added.
* fast/repaint/caret-with-transformation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
benjamin@webkit.org [Wed, 20 Mar 2013 22:40:59 +0000 (22:40 +0000)]
[WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112849

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-20
Reviewed by Sam Weinig.

Source/WebKit2:

The code was added in r137148 for the sole purpose of testing,
and it is not even being properly tested.

Remove the code until someone actually implement the feature in WebKit2.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
(WebPage):

Tools:

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
* WebKitTestRunner/InjectedBundle/TestRunner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago"" + x where x is not a string should be optimized by the DFG to some manner of ToStr...
fpizlo@apple.com [Wed, 20 Mar 2013 22:39:23 +0000 (22:39 +0000)]
"" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845

Reviewed by Mark Hahnenberg.

* fast/js/regress/empty-string-plus-int-expected.txt: Added.
* fast/js/regress/empty-string-plus-int.html: Added.
* fast/js/regress/script-tests/empty-string-plus-int.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago"" + x where x is not a string should be optimized by the DFG to some manner of ToStr...
fpizlo@apple.com [Wed, 20 Mar 2013 22:37:09 +0000 (22:37 +0000)]
"" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845

Reviewed by Mark Hahnenberg.

I like to do "" + x. So I decided to make DFG recognize it, and related idioms.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(FixupPhase):
(JSC::DFG::FixupPhase::fixupToString):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::resultOfToPrimitive):
(DFG):
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGPredictionPropagationPhase.h:
(DFG):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrect coordinated scrolling for RTL iframe and overflow:scroll
commit-queue@webkit.org [Wed, 20 Mar 2013 22:36:04 +0000 (22:36 +0000)]
Correct coordinated scrolling for RTL iframe and overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=112088

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-03-20
Reviewed by James Robinson.

Source/WebCore:

This patch adds appropriate offset in ScrollingCoordinatorChromium to
adjust impl-side scroll position to the range [0, maxPos - minPos].

This also corrects RenderLayer to return correct scroll position for RTL,
explained below:

There are 2 commonly used scroll offset coordinate systems in WebCore.

1. The scroll offset is the amount that needs to be translated when painting
   child elements in a RenderBox. The value can be negative when there is
   negative overflow (for RTL). The range will be within
   [overflow_top_left_corner, overflow_bottom_right_corner - client_size].
   This system is mainly used for painting and layer positioning.

2. The scroll offset will be always non-negative, and the range will be within
   [0, content_size - client_size]. This system is mainly used for scrollbars.

scrollOrigin is defined to convert between the two systems. scrollOrigin is always
non-negative, and equivalent to -overflow_top_left_corner.

The first system is used for ScrollableArea::scrollPosition/minimumScrollPosition/
maximumScrollPosition function family. So is it implemented in ScrollView/Frameview.
RenderLayer errorneously implemented scrollPosition in the second system,
and worse, returned minimumScrollPosition/maximumScrollPosition were totally non-sense.
This patch corrects RenderLayer to use the first coordinate system.

Test: compositing/rtl/rtl-overflow-scrolling.html
      ScrollingCoordinatorChromiumTest.rtlIframe

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorChromium::scrollableAreaScrollLayerDidChange):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit/chromium:

Added test to ensure RTL iframe has appropriate impl-side scroll position.

* tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::TEST_F):
(WebKit):
* tests/data/rtl-iframe-inner.html: Added.
* tests/data/rtl-iframe.html: Added.

LayoutTests:

This patch corrects scrollOrigin compensation for composited overflow:scroll.

compositing/rtl/rtl-overflow-scrolling.html is added to verify RTL divs
can be correctly scrolled to the left under accelerated scrolling mode.

fast/css/sticky/inline-sticky-abspos-child.html is modified to avoid sub-pixel
issue with Ahem font.

* compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
* compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
* compositing/rtl/rtl-overflow-scrolling.html: Added.
* fast/css/sticky/inline-sticky-abspos-child-expected.html:
* fast/css/sticky/inline-sticky-abspos-child.html:
* platform/chromium/TestExpectations:
* platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Build WebKit Tools under VS2010
bfulgham@webkit.org [Wed, 20 Mar 2013 22:33:17 +0000 (22:33 +0000)]
[WinCairo] Build WebKit Tools under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112821

Reviewed by Tim Horton.

* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
Add WinCairo-specific build target.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
Add WinCairo-specific build target.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
Add WinCairo-specific build target.
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
WinCairo-specific build target.
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
* WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
specific build target.
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
WinCairo-specific build target.
* win/record-memory/record-memory.vcxproj: Add WinCairo target.
* win/record-memory/record-memoryDebugWinCairo.props: Added.
* win/record-memory/record-memoryReleaseWinCairo.props: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r140202.
rniwa@webkit.org [Wed, 20 Mar 2013 22:19:28 +0000 (22:19 +0000)]
Mac rebaseline after r140202.

* editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* editing/input/reveal-caret-of-multiline-input-expected.png:
* fast/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
* platform/mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoARMv7 replaceWithJump ASSERT failure after r135330.
zherczeg@webkit.org [Wed, 20 Mar 2013 22:07:23 +0000 (22:07 +0000)]
ARMv7 replaceWithJump ASSERT failure after r135330.
https://bugs.webkit.org/show_bug.cgi?id=103146

Reviewed by Filip Pizlo.

On Linux, the 24 bit distance range of jumps sometimes does not
enough to cover all targets addresses. This patch supports jumps
outside of this range using a mov/movt/bx 10 byte long sequence.

* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::revertJumpTo_movT3movtcmpT2):
(JSC::ARMv7Assembler::nopw):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being...
jberlin@webkit.org [Wed, 20 Mar 2013 22:01:58 +0000 (22:01 +0000)]
REGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being copied into
the wrong location
https://bugs.webkit.org/show_bug.cgi?id=112833

Reviewed by Darin Adler.

Source/WebCore:

Fix an incorrect include path.

* loader/DocumentLoader.h:
RunLoopTimer.h lives in wtf as of r145592.

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
Make sure those three headers are copied with the rest of the WTF headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in Document::setFocusedNode if the frame of new focused node is detached in...
tkent@chromium.org [Wed, 20 Mar 2013 21:58:37 +0000 (21:58 +0000)]
Crash in Document::setFocusedNode if the frame of new focused node is detached in 'change' event handler
https://bugs.webkit.org/show_bug.cgi?id=112653

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/frames/detach-frame-during-focus.html

* page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode):
A oldDocument->setFocusedNode call might dispatch a 'change' event for
an old focused node, and an event handler code might detach the
newFocusedFrame. So we should check it. Without the check, the following
newDocument->setFocusedNode call would crash because of null
Frame::page().

LayoutTests:

* fast/frames/detach-frame-during-focus-expected.txt: Added.
* fast/frames/detach-frame-during-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoObjective-C API: Fix over-releasing in allocateConstructorAndPrototypeWithSuperClassInfo:
mhahnenberg@apple.com [Wed, 20 Mar 2013 21:41:55 +0000 (21:41 +0000)]
Objective-C API: Fix over-releasing in allocateConstructorAndPrototypeWithSuperClassInfo:
https://bugs.webkit.org/show_bug.cgi?id=112832

Reviewed by Geoffrey Garen.

If either the m_constructor or m_prototype (but not both) is collected, we will call
allocateConstructorAndPrototypeWithSuperClassInfo, which will create a new object to replace the one
that was collected, but at the end of the method we call release on both of them.
This is incorrect since we autorelease the JSValue in the case that the object doesn't need to be
reallocated. Thus we'll end up overreleasing later during the drain of the autorelease pool.

* API/JSWrapperMap.mm:
(objectWithCustomBrand): We no longer alloc here. We instead call the JSValue valueWithValue class method,
which autoreleases for us.
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We no longer call release on the
constructor or prototype JSValues.
* API/tests/testapi.mm: Added a new test that crashes on ToT due to over-releasing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion in LegacyWebArchive::create() in editing tests
rniwa@webkit.org [Wed, 20 Mar 2013 21:36:25 +0000 (21:36 +0000)]
Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642

Reviewed by Simon Fraser.

Address Simon's review comment. Don't convert String to MIMEType just to convert it back to String.

* platform/mac/PasteboardMac.mm:
(WebCore::fragmentFromWebArchive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Build ANGLE sources into a separate library from libWebCore.la
zandobersek@gmail.com [Wed, 20 Mar 2013 21:26:07 +0000 (21:26 +0000)]
[GTK] Build ANGLE sources into a separate library from libWebCore.la
https://bugs.webkit.org/show_bug.cgi?id=112778

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Include the GNUmakefile.am covering the libANGLE.la library.

Source/ThirdParty/ANGLE:

* GNUmakefile.am: Added, sets up the libANGLE.la library.

Source/WebCore:

No new tests - no change in functionality.

* GNUmakefile.list.am: Remove the ANGLE sources listing, it's now placed in the ANGLE-specific GNUmakefile.am.

Source/WebKit/gtk:

* GNUmakefile.am: Add libLevelDB.la to the libwebkitgtk library if using the OpenGL accelerated backend.

Source/WebKit2:

* GNUmakefile.am: Add libLevelDB.la to the libwebkit2gtk library if using the OpenGL accelerated backend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion in LegacyWebArchive::create() in editing tests
rniwa@webkit.org [Wed, 20 Mar 2013 21:24:24 +0000 (21:24 +0000)]
Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642

Reviewed by Enrica Casucci.

It's possible for clipboard to be overriden between the time we retrieve clipboard types and the time
we actually retrieve the Web archive buffer. Add a null check to take this into account.

Also extracted fragmentFromWebArchive for clarity.

* platform/mac/PasteboardMac.mm:
(WebCore::fragmentFromWebArchive): Extracted.
(WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebSpeech: Crash in WebCore::PlatformSpeechSynthesisUtterance::client / WebCore:...
cfleizach@apple.com [Wed, 20 Mar 2013 21:13:44 +0000 (21:13 +0000)]
WebSpeech: Crash in WebCore::PlatformSpeechSynthesisUtterance::client / WebCore::SpeechSynthesis::didResumeSpeaking
https://bugs.webkit.org/show_bug.cgi?id=112728

Reviewed by Tim Horton.

When cancel() is called, there was a delay in the platform returning and saying speech was finished, which caused
the m_currentSpeechUtterance variable to get deallocated but not cleared.

This patch fixes up the management of the utterances in SpeechSynthesis and the Mac platform given that
we can't rely on the platform to return immediately on a stop speaking job.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-cancel-crash.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::resume):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper cancel]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakWord:ofString:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAPI test gardening AppleWin port.
roger_fong@apple.com [Wed, 20 Mar 2013 20:55:30 +0000 (20:55 +0000)]
API test gardening AppleWin port.

The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.

* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix Mac release build.
eric.carlson@apple.com [Wed, 20 Mar 2013 20:47:10 +0000 (20:47 +0000)]
Unreviewed, fix Mac release build.

* page/CaptionUserPreferencesMac.mm:
(WebCore::languageIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIt's called "Hash Consing" not "Hash Consting"
fpizlo@apple.com [Wed, 20 Mar 2013 20:43:31 +0000 (20:43 +0000)]
It's called "Hash Consing" not "Hash Consting"
https://bugs.webkit.org/show_bug.cgi?id=112768

Rubber stamped by Mark Hahnenberg.

See http://en.wikipedia.org/wiki/Hash_consing

* heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
* heap/GCThreadSharedData.h:
(GCThreadSharedData):
* heap/SlotVisitor.cpp:
(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::setup):
(JSC::SlotVisitor::reset):
(JSC::JSString::tryHashConsLock):
(JSC::JSString::releaseHashConsLock):
(JSC::JSString::shouldTryHashCons):
(JSC::SlotVisitor::internalAppend):
* heap/SlotVisitor.h:
(SlotVisitor):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::haveEnoughNewStringsToHashCons):
(JSC::JSGlobalData::resetNewStringsSinceLastHashCons):
* runtime/JSString.h:
(JSC::JSString::finishCreation):
(JSString):
(JSC::JSString::isHashConsSingleton):
(JSC::JSString::clearHashConsSingleton):
(JSC::JSString::setHashConsSingleton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG implementation of op_strcat should inline rope allocations
fpizlo@apple.com [Wed, 20 Mar 2013 20:29:37 +0000 (20:29 +0000)]
DFG implementation of op_strcat should inline rope allocations
https://bugs.webkit.org/show_bug.cgi?id=112780

Reviewed by Oliver Hunt.

This gets rid of the StrCat node and adds a MakeRope node. The MakeRope node can
take either two or three operands, and allocates a rope string with either two or
three fibers. (The magic choice of three children for non-VarArg nodes happens to
match exactly with the magic choice of three fibers for rope strings.)

ValueAdd on KnownString is replaced with MakeRope with two children.

StrCat gets replaced by an appropriate sequence of MakeRope's.

MakeRope does not do the dynamic check to see if its children are empty strings.
This is replaced by a static check, instead. The downside is that we may use more
memory if the strings passed to MakeRope turn out to dynamically be empty. The
upside is that we do fewer checks in the cases where either the strings are not
empty, or where the strings are statically known to be empty. I suspect both of
those cases are more common, than the case where the string is dynamically empty.

This also results in some badness for X86. MakeRope needs six registers if it is
allocating a three-rope. We don't have six registers to spare on X86. Currently,
the code side-steps this problem by just never usign three-ropes in optimized
code on X86. All other architectures, including X86_64, don't have this problem.

This is a shocking speed-up. 9% progressions on both V8/splay and
SunSpider/date-format-xparb. 1% progression on V8v7 overall, and ~0.5% progression
on SunSpider. 2x speed-up on microbenchmarks that test op_strcat.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGAdjacencyList.h:
(AdjacencyList):
(JSC::DFG::AdjacencyList::removeEdge):
* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):
* dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::createToString):
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::convertStringAddUse):
(FixupPhase):
(JSC::DFG::FixupPhase::convertToMakeRope):
(JSC::DFG::FixupPhase::fixupMakeRope):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(DFG):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::~SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSString.h:
(JSRopeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Build the WebKit.dll under VS2010.
bfulgham@webkit.org [Wed, 20 Mar 2013 20:25:33 +0000 (20:25 +0000)]
[WinCairo] Build the WebKit.dll under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112759

Reviewed by Tim Horton.

* WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Update project to
build WinCairo variant using new property sheets.
* WebKit.vcxproj/Interfaces/InterfacesDebugWinCairo.props: Added.
* WebKit.vcxproj/Interfaces/InterfacesReleaseWinCairo.props: Added.
* WebKit.vcxproj/WebKit.sln: Update solution to use WinCairo
build targets for WebKit.dll-related projects.
* WebKit.vcxproj/WebKit/WebKit.vcxproj: Update project to build
WinCairo variant using new property sheets.
* WebKit.vcxproj/WebKit/cURL.props: Added.
* WebKit.vcxproj/WebKit/WebKitDebugWinCairo.props: Added.
* WebKit.vcxproj/WebKit/WebKitReleaseWinCairo.props: Added.
* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
Update project to build WinCairo variant using new property sheets.
* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorDebugWinCairo.props: Added.
* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorReleaseWinCairo.props: Added.
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Update project to
build WinCairo variant using new property sheets.
* WebKit.vcxproj/WebKitGUID/WebKitGUIDDebugWinCairo.props: Added.
* WebKit.vcxproj/WebKitGUID/WebKitGUIDReleaseWinCairo.props: Added.
* WebKit.vcxproj/WinCairo.props: Added.
* WebKit.vcxproj/debug_wincairo.props: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow ports specific text track menu
eric.carlson@apple.com [Wed, 20 Mar 2013 20:13:36 +0000 (20:13 +0000)]
Allow ports specific text track menu
https://bugs.webkit.org/show_bug.cgi?id=112800

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing tests updated for changes.

* English.lproj/Localizable.strings: Add localizable strings for text track names.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): userPrefersCaptions -> shouldShowCaptions.
(WebCore::HTMLMediaElement::setSelectedTextTrack): toggleTrackAtIndex -> setSelectedTextTrack.
(WebCore::HTMLMediaElement::userPrefersCaptions): userPrefersCaptions -> shouldShowCaptions.
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Get preferences from CaptionUserPreferences
    instead of from Settings.
(WebCore::HTMLMediaElement::setSelectedTextTrack): Renamed from toggleTrackAtIndex. Now takes
    a TextTrack* instead of an int.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't force a recalculation unless
    captions are enabled/disabled to avoid unnecessary thrash.
* html/HTMLMediaElement.h:

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Use the menu to track
    map instead of just the track index.
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Build and configure the
    menu from the menu to track map.
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Start with a list
    of tracks already sorted according to platform specific rules. Build a menu to track map
    so tracks are retained while the menu is visible.
* html/shadow/MediaControlElements.h:

* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged so the
    track menu will be rebuilt before it is shown again.

* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::containsOnlyForcedSubtitles): New, passthrough to the private track.
(WebCore::InbandTextTrack::isMainProgramContent): Ditto.
(WebCore::InbandTextTrack::isEasyToRead): Ditto.
* html/track/InbandTextTrack.h:
* html/track/TextTrack.h:

* html/track/TextTrackList.cpp:
(WebCore::TextTrackList::contains): New.
* html/track/TextTrackList.h:

* page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::CaptionUserPreferences): Pull in from .h ditto.
(WebCore::CaptionUserPreferences::~CaptionUserPreferences): Ditto.
(WebCore::CaptionUserPreferences::shouldShowCaptions): Renamed from userPrefersCaptions.
(WebCore::CaptionUserPreferences::setShouldShowCaptions): New.
(WebCore::CaptionUserPreferences::userPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::userPrefersSubtitles): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersSubtitles): Ditto.
(WebCore::CaptionUserPreferences::userPrefersTextDescriptions): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersTextDescriptions): Ditto.
(WebCore::CaptionUserPreferences::displayNameForTrack): Ditto.
(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Ditto.
* page/CaptionUserPreferences.h:

* page/CaptionUserPreferencesMac.h:
* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Renamed from userPrefersCaptions.
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): New.
(WebCore::CaptionUserPreferences::userPrefersSubtitles): Ditto.
(WebCore::trackDisplayName): Update logic used to build track title.
(WebCore::CaptionUserPreferencesMac::displayNameForTrack): Call trackDisplayName.
(WebCore::textTrackCompare): Text track title sort comparison function.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): New. Sort the list of tracks
    according to title, language, and user preferences.

* platform/Language.cpp:
(WebCore::displayNameForLanguageLocale): Don't leak the CFLocale.

* platform/LocalizedStrings.cpp:
(WebCore::textTrackCountryAndLanguageMenuItemText): New.
(WebCore::textTrackLanguageMenuItemText): Ditto.
(WebCore::closedCaptionTrackMenuItemText): Ditto.
(WebCore::sdhTrackMenuItemText): Ditto.
(WebCore::easyReaderTrackMenuItemText): Ditto.
* platform/LocalizedStrings.h:

* platform/graphics/InbandTextTrackPrivate.h:
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::containsOnlyForcedSubtitles): New, return AVFoundation property.
(WebCore::InbandTextTrackPrivateAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateAVFObjC::isEasyToRead): Ditto.

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setShouldDisplayTrackKind): Set setting via CaptionUserPreferences
    instead of from Settings.
(WebCore::InternalSettings::shouldDisplayTrackKind): Get setting from CaptionUserPreferences
    instead of from Settings.

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add new exports.
* win/WebKit.vcproj/WebKitExports.def.in: Ditto.

LayoutTests:

* media/track/track-user-preferences-expected.txt:
* media/track/track-user-preferences.html:
* media/video-controls-captions-trackmenu-localized.html:
* media/video-controls-captions-trackmenu-sorted.html:
* media/video-controls-captions-trackmenu.html:
* platform/mac/media/video-controls-captions-trackmenu-expected.txt:
* platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Clean up TemporaryLinkStubs.cpp
zandobersek@gmail.com [Wed, 20 Mar 2013 20:07:17 +0000 (20:07 +0000)]
[GTK] Clean up TemporaryLinkStubs.cpp
https://bugs.webkit.org/show_bug.cgi?id=112820

Reviewed by Philippe Normand.

Clean up the TemporaryLinkStubs.cpp file, removing unnecessary includes and prettifying the code.

No new tests - no new functionality.

* platform/gtk/TemporaryLinkStubs.cpp:
(WebCore):
(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
(WebCore::userIdleTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove PlatformEvent::GestureDoubleTap
commit-queue@webkit.org [Wed, 20 Mar 2013 19:27:19 +0000 (19:27 +0000)]
Remove PlatformEvent::GestureDoubleTap
https://bugs.webkit.org/show_bug.cgi?id=93045

Patch by Yufeng Shen <miletus@chromium.org> on 2013-03-20
Reviewed by Antonio Gomes.

Source/WebCore:

PlatformEvent::GestureDoubleTap is not currently
used in WebCore and replaced by GestureTap with
tap count 2, so remove it.

Test: We are removing something that is not used, so
no new test. All existing tests pass.

* dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/PlatformEvent.h:
* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):

Source/WebKit/chromium:

PlatformEvent::GestureDoubleTap is not currently
used in WebCore so remove it.

* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove repaint methods from RenderObject to RenderBox
ojan@chromium.org [Wed, 20 Mar 2013 19:22:17 +0000 (19:22 +0000)]
Move repaint methods from RenderObject to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=112773

Reviewed by Julien Chaffraix.

repaintOverhangingFloats and repaintDuringLayoutIfMoved are only ever called
on RenderBoxes, so don't need to be on RenderObject. This also lets us
devirtualize repaintDuringLayoutIfMoved.

* rendering/RenderBox.h:
(WebCore::RenderBox::repaintOverhangingFloats):
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTest fix for Win EWS bots, catch various errors and restart script if necessary.
roger_fong@apple.com [Wed, 20 Mar 2013 19:22:00 +0000 (19:22 +0000)]
Test fix for Win EWS bots, catch various errors and restart script if necessary.

* EWSTools/start-queue-win.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a feature observer for RenderDeprecatedFlexibleBox
commit-queue@webkit.org [Wed, 20 Mar 2013 19:19:53 +0000 (19:19 +0000)]
Add a feature observer for RenderDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=112740

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Tony Chang.

No new tests - only adding measurements.

* page/FeatureObserver.h:
Add constants for RenderDeprecatedFlexibleBox, and add separate
constants for its use in the UI and in extensions.
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
Call FeatureObserver. Check the document()->url() to see which
constant to use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, add myself to committers.py.
skyostil@chromium.org [Wed, 20 Mar 2013 19:09:47 +0000 (19:09 +0000)]
Unreviewed, add myself to committers.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAutosize should use documentRect height instead of scrollHeight
timothy_horton@apple.com [Wed, 20 Mar 2013 18:56:32 +0000 (18:56 +0000)]
Autosize should use documentRect height instead of scrollHeight
https://bugs.webkit.org/show_bug.cgi?id=112770

Reviewed by David Levin.

Autosizing fails to compute the correct height if the root element is very
small but the document has significant overflow.

No new tests; autosizing is not currently exposed in a testable way on Mac.

* page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFastMalloc scavenge timer specifies an overly narrow leeway value.
mrowe@apple.com [Wed, 20 Mar 2013 18:56:29 +0000 (18:56 +0000)]
FastMalloc scavenge timer specifies an overly narrow leeway value.

Reviewed by Alexey Proskuryakov.

There's no need to allow only 1ms of leeway on a 2s timer.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::initializeScavenger): Bump the leeway window
to 10% of the scavenge timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Improper repainting when grid item change their position
jchaffraix@webkit.org [Wed, 20 Mar 2013 18:50:01 +0000 (18:50 +0000)]
[CSS Grid Layout] Improper repainting when grid item change their position
https://bugs.webkit.org/show_bug.cgi?id=112749

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/css-grid-layout/grid-element-change-columns-repaint.html
       fast/css-grid-layout/grid-element-change-rows-repaint.html
       fast/css-grid-layout/grid-item-change-column-repaint.html
       fast/css-grid-layout/grid-item-change-row-repaint.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGridItems):
Added a call to repaintDuringLayoutIfMoved to repaint moving grid items.

LayoutTests:

* fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
* fast/css-grid-layout/grid-element-change-columns-repaint.html: Added.
* fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
* fast/css-grid-layout/grid-element-change-rows-repaint.html: Added.
Those are added testing for the grid element's change. They were already passing due to
the LayoutRepainter in RenderGrid::layoutBlock.

* fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
* fast/css-grid-layout/grid-item-change-column-repaint.html: Added.
* fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
* fast/css-grid-layout/grid-item-change-row-repaint.html: Added.
New testing, was failing before this change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAppleWin VS2010 build fix.
roger_fong@apple.com [Wed, 20 Mar 2013 18:24:13 +0000 (18:24 +0000)]
AppleWin VS2010 build fix.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] compositing/iframes/scroll-fixed-transformed-element.html fails in manua...
anilsson@rim.com [Wed, 20 Mar 2013 18:20:59 +0000 (18:20 +0000)]
[BlackBerry] compositing/iframes/scroll-fixed-transformed-element.html fails in manual testing
https://bugs.webkit.org/show_bug.cgi?id=112806

Reviewed by Antonio Gomes.

PR 283363

When scrolling the iframe, the position: fixed element is correctly
positioned, that is, as if it was fixed with respect to the iframe's
viewport. When scrolling the main frame however, the fixed pos element
was positioned as if it was fixed with respect to the main frame's
viewport.

Fixed by falling back to using the WebKit-thread scroll position for
fixed positioning in LayerRenderer, if the override doesn't have a
position currently set, i.e. if we are not currently scrolling the
iframe.

The effects of the bug are only visual, i.e. not detectable by DRT.

Manually testable using compositing/iframes/scroll-fixed-transformed-element.html

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Simplify implementation of EnforceRange conversions
commit-queue@webkit.org [Wed, 20 Mar 2013 18:17:36 +0000 (18:17 +0000)]
[V8] Simplify implementation of EnforceRange conversions
https://bugs.webkit.org/show_bug.cgi?id=112758

Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.

Factor out EnforceRange conversion into a helper function.
Simplify calculation for truncation.

Tests: fast/js/webidl-type-mapping.html
       storage/indexeddb/cursor-advance.html
       storage/indexeddb/cursor-advance-workers.html
       storage/indexeddb/intversion-bad-parameters.html

* bindings/v8/V8Binding.cpp:
(WebCore::enforceRange):
(WebCore):
(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Local/Remote and RTCStatsElement from WebRTCStats API
commit-queue@webkit.org [Wed, 20 Mar 2013 18:06:12 +0000 (18:06 +0000)]
Remove Local/Remote and RTCStatsElement from WebRTCStats API
https://bugs.webkit.org/show_bug.cgi?id=112678

Patch by Harald Alvestrand <hta@google.com> on 2013-03-20
Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebRTCStatsResponse.h:
(WebRTCStatsResponse):

Source/WebCore:

Pure removal, remaining functionality covered by existing test.

* Modules/mediastream/RTCStatsReport.cpp:
* Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
* Modules/mediastream/RTCStatsResponse.cpp:
* Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
* platform/chromium/support/WebRTCStatsResponse.cpp:
* platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Define MODULE_VERSION
jocelyn.turcotte@digia.com [Wed, 20 Mar 2013 17:56:11 +0000 (17:56 +0000)]
[Qt] Define MODULE_VERSION
https://bugs.webkit.org/show_bug.cgi?id=112808

Reviewed by Allan Sandfeld Jensen.

Upstream http://codereview.qt-project.org/49052
Use 5.2.0 as this is the next release that will be branched from trunk.

* .qmake.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERTION FAILED: !m_renderingAutomaticPullNodes.size()
xingnan.wang@intel.com [Wed, 20 Mar 2013 17:33:12 +0000 (17:33 +0000)]
ASSERTION FAILED: !m_renderingAutomaticPullNodes.size()
https://bugs.webkit.org/show_bug.cgi?id=112777

Reviewed by Chris Rogers.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::~AudioContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCopy-paste should not spellcheck when continuous spellcheck is turned off
commit-queue@webkit.org [Wed, 20 Mar 2013 17:28:00 +0000 (17:28 +0000)]
Copy-paste should not spellcheck when continuous spellcheck is turned off
https://bugs.webkit.org/show_bug.cgi?id=112464

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-20
Reviewed by Ryosuke Niwa.

.:

* Source/autotools/symbols.filter: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.

Source/WebCore:

Test: editing/spelling/spellcheck-paste-continuous-disabled.html

* WebCore.exp.in: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
* WebCore.order: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment): Do not spellcheck if continuous spellcheck is turned off.
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Leave continuous spellcheck turned on after a test.
(WebCore::Internals::setContinuousSpellCheckingEnabled): Let tests enable and disable continuous spellcheck.
(WebCore):
* testing/Internals.h: Let tests enable and disable continuous spellcheck.
(Internals):
* testing/Internals.idl: Let tests enable and disable continuous spellcheck.

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.

LayoutTests:

* editing/spelling/spellcheck-paste-continuous-disabled-expected.txt: Added expected results for pasting when continuous spellcheck is turned off.
* editing/spelling/spellcheck-paste-continuous-disabled.html: Added a test for pasting with continuous spellcheck turned off.
* platform/mac-wk2/TestExpectations: Skip spellcheck-paste-continuous-disabled.html, because it is a slight modification of spellcheck-paste-disabled.html, which is also skipped in mac-wk2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd support for MediaSource::isTypeSupported()
acolwell@chromium.org [Wed, 20 Mar 2013 17:22:33 +0000 (17:22 +0000)]
Add support for MediaSource::isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=112301

Reviewed by Darin Fisher.

Source/Platform:

* chromium/public/WebMimeRegistry.h:
(WebMimeRegistry): Added supportsMediaSourceMIMEType() method.

Source/WebCore:

Test: http/tests/media/media-source/video-media-source-is-type-supported.html

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer): Added isTypeSupported() call to verify parameters
                                         pass into this method.
(WebCore::MediaSource::isTypeSupported):
(WebCore):
* Modules/mediasource/MediaSource.h:
(MediaSource):
* Modules/mediasource/MediaSource.idl: Added isTypeSupported().
* platform/MIMETypeRegistry.h:
(MIMETypeRegistry): Added isSupportedMediaSourceMIMEType().
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType): Implemented in terms of WebMimeRegistry::isSupportedMediaSourceMIMEType.

LayoutTests:

* http/tests/media/media-source/video-media-source-is-type-supported-expected.txt: Added. Reflects Chromium expectations.
                                                                                   Valid MP4 type strings will return true
                                                                                   instead of false in Chrome builds.
* http/tests/media/media-source/video-media-source-is-type-supported.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding another email for me.
caio.oliveira@openbossa.org [Wed, 20 Mar 2013 17:18:34 +0000 (17:18 +0000)]
Unreviewed. Adding another email for me.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed VS2010 build correction.
bfulgham@webkit.org [Wed, 20 Mar 2013 16:56:53 +0000 (16:56 +0000)]
[WinCairo] Unreviewed VS2010 build correction.

* WebCore.vcxproj/WebCore.vcxproj: Enable build of NetworkStorageSessionStub.cpp
for WinCairo port.
* WebCore.vcxproj/WebCore.vcxproj.filters: Correct build type of
CookieJarCurl from 'custom' to 'C++ source file'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Rename DOMDataStore::isMainWorldObject
commit-queue@webkit.org [Wed, 20 Mar 2013 16:55:44 +0000 (16:55 +0000)]
[V8] Rename DOMDataStore::isMainWorldObject
https://bugs.webkit.org/show_bug.cgi?id=112817

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-20
Reviewed by Jochen Eisinger.

No new tests (no changes in functionality).

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperFast):
(WebCore::DOMDataStore::getWrapper):
(WebCore::DOMDataStore::getWrapperForMainWorld):
(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::canExistInWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Clean up sanity checks related to gesture recognition
abecsi@webkit.org [Wed, 20 Mar 2013 16:49:30 +0000 (16:49 +0000)]
[Qt][WK2] Clean up sanity checks related to gesture recognition
https://bugs.webkit.org/show_bug.cgi?id=112679

Reviewed by Jocelyn Turcotte.

The only callers of the panGestureActive and pinchGestureActive member
functions of the page viewport controller client are event delivery
related sanity check assers, thus they can be replaced by checking
for the corresponding internal states and therefore the superfluous
members can be removed.
Also update other asserts in the page viewport controller client to
be more accurate about the expected states.

* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::panGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
* UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Refactor handling of content suspension to properly cover corner cases
abecsi@webkit.org [Wed, 20 Mar 2013 16:45:17 +0000 (16:45 +0000)]
[Qt][WK2] Refactor handling of content suspension to properly cover corner cases
https://bugs.webkit.org/show_bug.cgi?id=111751

Reviewed by Jocelyn Turcotte.

The current suspend / resume infrastructure turned out to be insufficient to cover
all corner cases during transitions between gestures of complex gesture chains.

The requirements for robust suspend / resume handling are:
    - Keep the content suspended while the user is continuously interacting,
eg. does not lift the finger between transition from a pan to a pinch gesture
and vice versa.
    - The content should not be suspended unnecessarily (like for a tap gesture),
only during panning and scroll animation (flick), as well as pinch zoom and scale
animation (also includes double-tap-to-zoom).
    - The content should never end up stuck in suspended state after long gesture
chains and continuous interaction.

This patch reintroduces reference counting based suspension in form of a new
ViewportInteractionTracker member class to make it possible to reliably control the
suspend / resume cycles during scrolling and scaling.
During continuous gestures, while the user is interacting, the reference count is
increased without actually suspending the content to prevent resuming unnecessarily
during continuous interaction. At the same time this also assures that the page is
not suspended for simple tap gestures, which was a side-effect of the previous
approach based on update deferrers.
The newly added functionality replaces boolean members that tried to achive the
above requirements.
Additionally this patch also removes the redundant m_hasSuspendedContent member
from the PageViewportController since WebPageProxy already keeps this information.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::updateMinimumScaleToFit):
* UIProcess/PageViewportController.h:
(PageViewportController):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::areActiveDOMObjectsAndAnimationsSuspended):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::begin):
(WebKit):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::end):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):
* UIProcess/qt/PageViewportControllerClientQt.h:
(ViewportInteractionTracker):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::ViewportInteractionTracker):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::inProgress):
(PageViewportControllerClientQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Flame Chart. Provide Overview pane for better user expirience.
loislo@chromium.org [Wed, 20 Mar 2013 16:19:07 +0000 (16:19 +0000)]
Web Inspector: Flame Chart. Provide Overview pane for better user expirience.
https://bugs.webkit.org/show_bug.cgi?id=112496

Reviewed by Yury Semikhatsky.

This patch implements basic part of Overview Pane in FlameChart.
The idea of the patch is to move everything into chart-container element.
And put OverviewGrid into new overview-container element.

Drive by change: fix the layout of the flame chart elements.
Drive by change: fix the drag window & drag resizer mechanics
for the case when the parent element has zero offsetLeft.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.OverviewCalculator):
(WebInspector.FlameChart.OverviewCalculator.prototype._updateBoundaries):
(WebInspector.FlameChart.OverviewCalculator.prototype.computePosition):
(WebInspector.FlameChart.OverviewCalculator.prototype.formatTime):
(WebInspector.FlameChart.OverviewCalculator.prototype.maximumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.minimumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.update):
* inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._resizerElementStartDragging):
(WebInspector.OverviewGrid.Window.prototype._leftResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._rightResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._windowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.WindowSelector):
* inspector/front-end/TimelineOverviewPane.js:
* inspector/front-end/flameChart.css:
(.chart-container .item-anchor):
(.overview-container):
(.chart-container):
(#flame-chart-overview-grid .resources-dividers-label-bar):
* inspector/front-end/inspectorCommon.css:
(.resources-divider-label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Plumbing CSS warnings
commit-queue@webkit.org [Wed, 20 Mar 2013 16:07:26 +0000 (16:07 +0000)]
Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.

Adding a framework for plumbing CSS warnings from CSSParser/grammar to the Inspector console.

* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::logError):
* css/CSSParser.h:
(CSSParser):
(CSSParser::Location):
(WebCore):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::StyleSheetContents::parseStringAtLine):
* css/StyleSheetContents.h:
(StyleSheetContents):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* page/PageConsole.cpp:
(WebCore::PageConsole::addMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Qt 4.8 expected results removal from Trunk.
kadam@inf.u-szeged.hu [Wed, 20 Mar 2013 16:05:26 +0000 (16:05 +0000)]
[Qt] Qt 4.8 expected results removal from Trunk.

Reviewed by Csaba Osztrogonác.

* platform/qt-4.8/TestExpectations: Removed.
* platform/qt-4.8/css1/text_properties/text_transform-expected.txt: Removed.
* platform/qt-4.8/editing/selection/regional-indicators-expected.txt: Removed.
* platform/qt-4.8/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
* platform/qt-4.8/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Removed.
* platform/qt-4.8/fast/dom/xml-parser-error-message-crash-expected.txt: Removed.
* platform/qt-4.8/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Removed.
* platform/qt-4.8/fast/events/xsl-onload-expected.txt: Removed.
* platform/qt-4.8/fast/parser/xml-colon-entity-expected.txt: Removed.
* platform/qt-4.8/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Removed.
* platform/qt-4.8/fast/parser/xslt-with-html-expected.txt: Removed.
* platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Removed.
* platform/qt-4.8/fast/text/find-kana-expected.txt: Removed.
* platform/qt-4.8/fast/text/find-russian-expected.txt: Removed.
* platform/qt-4.8/fast/text/find-soft-hyphen-expected.txt: Removed.
* platform/qt-4.8/fast/url/path-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/subframe-location-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/transform-to-html-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/utf8-chunks-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-bad-import-uri-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-doc-noenc-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-entity-enc-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-entity-expected.png: Removed.
* platform/qt-4.8/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-recursion-expected.txt: Removed.
* platform/qt-4.8/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png: Removed.
* platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png: Removed.
* platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Removed.
* platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Removed.
* platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Removed.
* platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Removed.
* platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Removed.
* platform/qt-4.8/svg/custom/bug45331-expected.png: Removed.
* platform/qt-4.8/svg/custom/bug45331-expected.txt: Removed.
* platform/qt-4.8/svg/custom/bug78807-expected.txt: Removed.
* platform/qt-4.8/svg/custom/use-invalid-html-expected.txt: Removed.
* platform/qt-4.8/svg/custom/use-invalid-style-expected.txt: Removed.
* platform/qt-4.8/svg/hixie/error/dumpAsText/004-expected.txt: Removed.
* platform/qt-4.8/svg/hixie/error/dumpAsText/005-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
junov@google.com [Wed, 20 Mar 2013 15:59:08 +0000 (15:59 +0000)]
[Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
https://bugs.webkit.org/show_bug.cgi?id=112605

Reviewed by James Robinson.

Source/WebCore:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

No new tests: Affected code paths covered by existing tests.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
* html/HTMLCanvasElement.h:
* page/Settings.in:
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
(ImageBuffer):
* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecordingChanged):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecording):
(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):
(WebCore::Canvas2DLayerBridge::flush):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::contextAcquired):
* platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::ImageBuffer):

Source/WebKit/chromium:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

* public/WebSettings.h:
(WebKit::WebSettings::setDeferred2dCanvasEnabled):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferred2dCanvasEnabled):
* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
* tests/Canvas2DLayerManagerTest.cpp:
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):

Tools:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):

LayoutTests:

Marked some 2d canvas tests as failing. These tests are using the
two point radial gradient API.  The bug was already present in
chromium. Starts getting detected in DRT with this change.
Related: crbug.com/222140

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDrop full URLs from cross-domain access errors caused by 'document.domain' mismatches.
mkwst@chromium.org [Wed, 20 Mar 2013 15:42:42 +0000 (15:42 +0000)]
Drop full URLs from cross-domain access errors caused by 'document.domain' mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112813

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on http://wkbug.com/112042, this patch brings 'document.domain'
mismatch error messages into line with the newly origin-only default
message. There will probably be two or three more patches in this series
just to keep the rebaselines down to something managably reviewable.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):
    Move the default message redefinition up out of the final 'return' so
    that 'document.domain' mismatch errors grab the new text.

LayoutTests:

* http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
* http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
* http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add promptText param to Page.handleJavaScriptDialog
commit-queue@webkit.org [Wed, 20 Mar 2013 15:40:38 +0000 (15:40 +0000)]
Web Inspector: Add promptText param to Page.handleJavaScriptDialog
https://bugs.webkit.org/show_bug.cgi?id=112706

Patch by Ken Kania <kkania@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
* inspector/InspectorPageAgent.h:

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::handleJavaScriptDialog):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Qt 4.8 tool related stuff removal from webkitpy.
kadam@inf.u-szeged.hu [Wed, 20 Mar 2013 15:10:54 +0000 (15:10 +0000)]
[Qt] Qt 4.8 tool related stuff removal from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=112699.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._search_paths):
(QtPort._port_specific_expectations_files):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest._assert_expectations_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix SourceFrame.js compilation warning
commit-queue@webkit.org [Wed, 20 Mar 2013 14:59:52 +0000 (14:59 +0000)]
Web Inspector: fix SourceFrame.js compilation warning
https://bugs.webkit.org/show_bug.cgi?id=112804

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.

No new tests: no change in behavior.

- Explicitly parse lineNumber from object property name.
- Add type annotations to ensure addMessageToSource is monomorphic.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.clearMessages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] unsafe persistent access in V8LazyEventListener
commit-queue@webkit.org [Wed, 20 Mar 2013 14:34:33 +0000 (14:34 +0000)]
[v8] unsafe persistent access in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=112807

Patch by Dan Carney <dcarney@google.com> on 2013-03-20
Reviewed by Kentaro Hara.

No new tests.

* bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Enable appropriate vertex attribute arrays in LayerRenderer::useProgram()
anilsson@rim.com [Wed, 20 Mar 2013 14:32:50 +0000 (14:32 +0000)]
[BlackBerry] Enable appropriate vertex attribute arrays in LayerRenderer::useProgram()
https://bugs.webkit.org/show_bug.cgi?id=112757

Reviewed by Rob Buis.

PR 306465

Make the LayerRenderer and associated code more bullet-proof when it
comes to enabling vertex attribute arrays, by enabling them already
when LayerRenderer::useProgram() is called. This fixes a bug where the
video hole punch rectangle wasn't punched when preceding rendering
caused the vertex attribute array at index 0 to be disabled, such as
when rendering the text selection overlay immediately before video.

A number of places where the position attribute index was hard-coded
to 0 were also fixed. This causes no change in behavior, the position
attribute was really at 0, but nonetheless that shouldn't be hardcoded.

The effects of this patch are only manually testable.

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::useProgram):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] implement highlightRange method
commit-queue@webkit.org [Wed, 20 Mar 2013 14:30:19 +0000 (14:30 +0000)]
Web Inspector: [CodeMirror] implement highlightRange method
https://bugs.webkit.org/show_bug.cgi?id=112802

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.

- Implement highlightRange/removeHighlight methods in
CodeMirrorTextEditor.
- Update TextEditor interface closure annotations.

No new tests.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.removeHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.highlightRange):
* inspector/front-end/DefaultTextEditor.js:
* inspector/front-end/TextEditor.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] show source location for codemirror text editor
commit-queue@webkit.org [Wed, 20 Mar 2013 14:28:37 +0000 (14:28 +0000)]
Web Inspector: [CodeMirror] show source location for codemirror text editor
https://bugs.webkit.org/show_bug.cgi?id=112798

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.

No new tests.

- Implement CodeMirrorTextEditor.copyRange method
- Fire "selectionChange" event for text editor delegate from
CodeMirrorTextEditor.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):
(WebInspector.CodeMirrorTextEditor.prototype._cursorActivity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable kerning by default
allan.jensen@digia.com [Wed, 20 Mar 2013 14:18:54 +0000 (14:18 +0000)]
[Qt] Enable kerning by default
https://bugs.webkit.org/show_bug.cgi?id=112704

Reviewed by Jocelyn Turcotte.

Source/WebKit/qt:

Enable default kerning when fast kerning is available.

To support layout tests that depend on kerning being off by default,
a method is added to DumpRenderTreeSupportQt to reset the default.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetDefaultTypesettingFeatures):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/InitWebCoreQt.cpp:
(WebKit::initializeWebKitQt):

Tools:

Disable kerning by default, since some reference test expectations
expect kerning to be default off.

* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement and32 on MIPS platform
commit-queue@webkit.org [Wed, 20 Mar 2013 14:06:09 +0000 (14:06 +0000)]
Implement and32 on MIPS platform
https://bugs.webkit.org/show_bug.cgi?id=112665

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-20
Reviewed by Zoltan Herczeg.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::and32): Added missing method.
(MacroAssemblerMIPS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove empty function stubs from TestRunnerQt.
zeno.albisser@digia.com [Wed, 20 Mar 2013 13:29:41 +0000 (13:29 +0000)]
[Qt] Remove empty function stubs from TestRunnerQt.
https://bugs.webkit.org/show_bug.cgi?id=112799

We are reducing the code in TestRunnerQt step by step,
in order to finally replace all of it with the generic
TestRunner implementation.
This patch removes several simple function stubs that
currently do not implement any actual functionality.

Reviewed by Kenneth Rohde Christiansen.

* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[or] Updated WebKitGTK+ Translation for Odia [or] language.
kov@webkit.org [Wed, 20 Mar 2013 13:16:45 +0000 (13:16 +0000)]
[or] Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=103037

Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-03-20
Rubber-stamped by Gustavo Noronha Silva (kov).

* or.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146331.
commit-queue@webkit.org [Wed, 20 Mar 2013 13:08:38 +0000 (13:08 +0000)]
Unreviewed, rolling out r146331.
http://trac.webkit.org/changeset/146331
https://bugs.webkit.org/show_bug.cgi?id=112795

Does not work as expected (Requested by carewolf on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

Source/WebCore:

* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):

LayoutTests:

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Resources] Local Storage: "Add item" row height doesn't match underly...
eustas@chromium.org [Wed, 20 Mar 2013 12:43:13 +0000 (12:43 +0000)]
Web Inspector: [Resources] Local Storage: "Add item" row height doesn't match underlying grid.
https://bugs.webkit.org/show_bug.cgi?id=112433

Reviewed by Pavel Feldman.

Fixed cell height to correspond grid step.

* inspector/front-end/dataGrid.css:
(.data-grid td): Fixed cell height to correspond grid step.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
commit-queue@webkit.org [Wed, 20 Mar 2013 12:26:23 +0000 (12:26 +0000)]
[EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
https://bugs.webkit.org/show_bug.cgi?id=112687

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.

Hide the SearchBar by default on window creation.

* MiniBrowser/efl/main.c:
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt
allan.jensen@digia.com [Wed, 20 Mar 2013 11:53:52 +0000 (11:53 +0000)]
[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=112668

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Kerning is on by default in Qt. This means we need to disable it
when WebCore does not request it.

* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):

LayoutTests:

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: OverviewGrid rename classes according to names of js classes.
loislo@chromium.org [Wed, 20 Mar 2013 11:51:27 +0000 (11:51 +0000)]
Web Inspector: OverviewGrid rename classes according to names of js classes.
https://bugs.webkit.org/show_bug.cgi?id=112786

Reviewed by Yury Semikhatsky.

It is a part of meta bug 'extract OverviewGrid from TimelineOverviewPane'.
As the last step it renames timeline-...... classes to overview-grid-...... classes
and moves them to inspectorCommon.css

* inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
* inspector/front-end/inspectorCommon.css:
(.overview-grid-window-selector):
(.overview-grid-window):
(.overview-grid-dividers-background):
(.overview-grid-window-rulers):
(.overview-grid-window-resizer):
* inspector/front-end/timelinePanel.css:
(.timeline-frame-overview .overview-grid-window):
(.timeline-frame-overview .overview-grid-dividers-background):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146304.
commit-queue@webkit.org [Wed, 20 Mar 2013 11:50:58 +0000 (11:50 +0000)]
Unreviewed, rolling out r146304.
http://trac.webkit.org/changeset/146304
https://bugs.webkit.org/show_bug.cgi?id=112788

to many expectations to update (Requested by antonm on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(WebKit):
* DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
* DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
(WebThemeControlDRTWin::WebThemeControlDRTWin):
(WebThemeControlDRTWin::~WebThemeControlDRTWin):
(WebThemeControlDRTWin::box):
(WebThemeControlDRTWin::line):
(WebThemeControlDRTWin::triangle):
(WebThemeControlDRTWin::roundRect):
(WebThemeControlDRTWin::oval):
(WebThemeControlDRTWin::circle):
(WebThemeControlDRTWin::nestedBoxes):
(WebThemeControlDRTWin::markState):
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):
* DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
(WebThemeControlDRTWin):
* DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
(WebThemeEngineDRTMac):
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
(webRectToSkIRect):
(drawControl):
(drawTextField):
(drawProgressBar):
(WebThemeEngineDRTWin::paintButton):
(WebThemeEngineDRTWin::paintMenuList):
(WebThemeEngineDRTWin::paintScrollbarArrow):
(WebThemeEngineDRTWin::paintScrollbarThumb):
(WebThemeEngineDRTWin::paintScrollbarTrack):
(WebThemeEngineDRTWin::paintSpinButton):
(WebThemeEngineDRTWin::paintTextField):
(WebThemeEngineDRTWin::paintTrackbar):
(WebThemeEngineDRTWin::paintProgressBar):
(WebThemeEngineDRTWin::getSize):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
(WebThemeEngineDRTWin):
(WebThemeEngineDRTWin::WebThemeEngineDRTWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146315.
commit-queue@webkit.org [Wed, 20 Mar 2013 11:43:46 +0000 (11:43 +0000)]
Unreviewed, rolling out r146315.
http://trac.webkit.org/changeset/146315
https://bugs.webkit.org/show_bug.cgi?id=112789

followup to 146304 rollout (Requested by antonm on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
* platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Removed.
* platform/chromium-win/css1/box_properties/border_right_inline-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146328 268f45cc-cd09-0410-ab3c-d52691b4dbfc