WebKit-https.git
14 years ago Reviewed by Darin.
mjs [Tue, 28 Feb 2006 06:17:08 +0000 (06:17 +0000)]
    Reviewed by Darin.

        - write a portable ICU version of TextEncoding::fromUnicode for use on win32

        * platform/StreamingTextDecoder.h:
        * platform/TextEncoding.cpp:
        (WebCore::TextEncoding::fromUnicode): added
        (WebCore::getConverter): helper
        (WebCore::cacheConverter): ditto
        (WebCore::effectiveEncoding): ditto
        * platform/mac/TextEncodingMac.cpp: Add comment
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::TextEncoding::fromUnicode): remove

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Tue, 28 Feb 2006 05:55:54 +0000 (05:55 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7433
          REGRESSION (r12789): Second RTL text run on a line cannot be selected

        * fast/text/in-rendered-text-rtl-expected.checksum: Added.
        * fast/text/in-rendered-text-rtl-expected.png: Added.
        * fast/text/in-rendered-text-rtl-expected.txt: Added.
        * fast/text/in-rendered-text-rtl.html: Added.

WebCore:

        Test: fast/text/in-rendered-text-rtl.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7433
          REGRESSION (r12789): Second RTL text run on a line cannot be selected

        * dom/dom_position.cpp:
        (WebCore::Position::inRenderedText): If the RenderText contains
        reversed text, the text boxes are not necessarily ordered by start
        position, so iterate through all of them.
        (WebCore::Position::isRenderedCharacter): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Tue, 28 Feb 2006 05:44:49 +0000 (05:44 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321
        REGRESSION: style tag in body causes two head elements to appear in the DOM

        The head-check.html document uses an iframe as a laboratory for loading each
        head-check-N.html file and checking its DOM, with inspiration from Ian Hixie's
        Live DOM Viewer: http://software.hixie.ch/utilities/js/live-dom-viewer/

        Each of the four head-check-N.html files tests a different code path for
        creating a document's head element in WebCore/khtml/html/htmlparser.cpp.

        * editing/inserting/editing-empty-divs-expected.txt: Corrected <html> child
        index for <body> since the document previously had two <head> nodes.
        * fast/dom/HTMLHeadElement: Added.
        * fast/dom/HTMLHeadElement/head-check-expected.txt: Added.
        * fast/dom/HTMLHeadElement/head-check.html: Added.
        * fast/dom/HTMLHeadElement/resources: Added.
        * fast/dom/HTMLHeadElement/resources/head-check-1.html: Added.
        * fast/dom/HTMLHeadElement/resources/head-check-2.html: Added.
        * fast/dom/HTMLHeadElement/resources/head-check-3.html: Added.
        * fast/dom/HTMLHeadElement/resources/head-check-4.html: Added.
        * fast/dom/HTMLHeadElement/resources/head-check.js: Added.

WebCore:

        Reviewed by Darin.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321
        REGRESSION: style tag in body causes two head elements to appear in the DOM

        * khtml/html/htmlparser.cpp: Handle the head node like form and map nodes.
        (WebCore::HTMLParser::parseToken):
        (WebCore::HTMLParser::headCreateErrorCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 05:38:17 +0000 (05:38 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Add stub to make DRT link.
        Make WebCore copy libxml.dll into build directory when building.

        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::TextEncoding::fromUnicode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Tue, 28 Feb 2006 05:03:03 +0000 (05:03 +0000)]
    Reviewed by Eric.

        - fix regression in layout tests

        * dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
        Fix some code that was not properly truncating. I broke it in my
        string change this morning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 05:02:32 +0000 (05:02 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Rubber-stamped by darin.

        Remove fpconst.cpp, unused on win32 and the cause of linker warnings.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Eric.
mjs [Tue, 28 Feb 2006 04:55:28 +0000 (04:55 +0000)]
    Rubber stamped by Eric.

        - add stubs for FrameWin overrides of pure virtual Frame methods

        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::FrameWin::respondToChangedContents):
        (WebCore::FrameWin::unfocusWindow):
        (WebCore::FrameWin::locationbarVisible):
        (WebCore::FrameWin::respondToChangedSelection):
        (WebCore::FrameWin::clearUndoRedoOperations):
        (WebCore::FrameWin::issueRedoCommand):
        (WebCore::FrameWin::canRedo):
        (WebCore::FrameWin::restoreDocumentState):
        (WebCore::FrameWin::canUndo):
        (WebCore::FrameWin::overrideMediaType):
        (WebCore::FrameWin::saveDocumentState):
        (WebCore::FrameWin::print):
        (WebCore::FrameWin::issueCutCommand):
        (WebCore::FrameWin::issueCopyCommand):
        (WebCore::FrameWin::partClearedInBegin):
        (WebCore::FrameWin::issueUndoCommand):
        (WebCore::FrameWin::clearRecordedFormValues):
        (WebCore::FrameWin::issuePasteCommand):
        (WebCore::FrameWin::markedTextRange):
        (WebCore::FrameWin::shouldChangeSelection):
        (WebCore::FrameWin::scheduleClose):
        (WebCore::FrameWin::menubarVisible):
        (WebCore::FrameWin::personalbarVisible):
        (WebCore::FrameWin::createEmptyDocument):
        (WebCore::FrameWin::lastEventIsMouseUp):
        (WebCore::FrameWin::statusbarVisible):
        (WebCore::FrameWin::toolbarVisible):
        (WebCore::FrameWin::issueTransposeCommand):
        (WebCore::FrameWin::userAgent):
        (WebCore::FrameWin::canPaste):
        (WebCore::FrameWin::incomingReferrer):
        (WebCore::FrameWin::canGoBackOrForward):
        (WebCore::FrameWin::issuePasteAndMatchStyleCommand):
        (WebCore::FrameWin::handledOnloadEvents):
        (WebCore::FrameWin::generateFrameName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 04:27:32 +0000 (04:27 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Add constructor and destructor.

        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::FrameWin):
        (WebCore::FrameWin::~FrameWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Eric (sorta).
mjs [Tue, 28 Feb 2006 04:23:46 +0000 (04:23 +0000)]
    Rubber stamped by Eric (sorta).

        - add return values where needed

        * platform/win/TemporaryLinkStubs.cpp:
        (KWQServeRequest):
        (KWQServeSynchronousRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 04:13:05 +0000 (04:13 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix Assertions.cpp to compile on win32.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * kxmlcore/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 04:12:31 +0000 (04:12 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Add a couple more stubs to make Win32 link.

        * platform/win/TemporaryLinkStubs.cpp:
        (KWQServeSynchronousRequest):
        (WebCore::FrameView::topLevelWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 03:56:06 +0000 (03:56 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Move mac-specific logging logic up into WebCore (from JavaScriptCore).
        Remove KWQ prefixes from default log channels.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

        * bridge/mac/WebCorePageBridge.mm:
        (initializeLogChannel):
        (initializeLoggingChannelsIfNecessary):
        (-[WebCorePageBridge init]):
        * page/Frame.h:
        * platform/Logging.cpp:
        * platform/Logging.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 03:51:43 +0000 (03:51 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Made Assertions.cpp platform independent.
        Moved mac-specific logging logic up into WebCore.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kxmlcore/Assertions.cpp: Added.
        * kxmlcore/Assertions.h:
        * kxmlcore/Assertions.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Tue, 28 Feb 2006 03:41:51 +0000 (03:41 +0000)]
    Reviewed by Maciej.

        - fix <rdar://problem/4104575> hang due to slow saveDocumentState method

        * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]):
        Change code that iterates a QStringList with indices to use iterator instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Tue, 28 Feb 2006 03:38:07 +0000 (03:38 +0000)]
    Reviewed by Eric.

        - portable version of QString::utf8

        * platform/QString.cpp:
        (QString::utf8): moved here, rewritten to use TextCodec
        * platform/mac/QStringMac.mm:
        (QString::utf8): removed from here

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 02:53:15 +0000 (02:53 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Rubber-stamped by mjs.

        Fix FrameWin.h to use consistant line endings.
        Fix TemporaryLinkStubs to better match style guidelines.

        * bridge/win/FrameWin.h:
        (WebCore::Win):
        * platform/win/TemporaryLinkStubs.cpp:
        (QLineEdit::selectAll):
        (QPainter::save):
        (Widget::enableFlushDrawing):
        (QPainter::drawHighlightForText):
        (QFont::setPrinterFont):
        (QTextEdit::textWithHardLineBreaks):
        (Widget::mapFromGlobal):
        (QPainter::addClip):
        (QLineEdit::cursorPosition):
        (QPainter::setPen):
        (QPainter::selectedTextBackgroundColor):
        (QPainter::fontMetrics):
        (Widget::show):
        (QFont::setItalic):
        (QSlider::setValue):
        (QLineEdit::addSearchResult):
        (KWQFileButton::click):
        (QLineEdit::setWritingDirection):
        (QPainter::drawFocusRing):
        (KWQFileButton::sizeForCharacterWidth):
        (QTextEdit::sizeWithColumnsAndRows):
        (QComboBox::clear):
        (QPainter::misspellingLineThickness):
        (QComboBox::setFrameGeometry):
        (QLineEdit::maxLength):
        (Widget::isEnabled):
        (KWQServeRequest):
        (QTextEdit::setText):
        (Widget::paint):
        (QPainter::addRoundedRectClip):
        (FrameView::viewportToGlobal):
        (QTextEdit::selectionEnd):
        (QFont::determinePitch):
        (QTextEdit::setScrollBarModes):
        (QPainter::drawEllipse):
        (QTextEdit::setReadOnly):
        (QListBox::appendItem):
        (QLineEdit::setPlaceholderString):
        (Cursor::Cursor):
        (Widget::focusPolicy):
        (ScrollView::removeChild):
        (QTextEdit::selectAll):
        (QPainter::fillRect):
        (QPainter::endTransparencyLayer):
        (QFont::QFont):
        (ScrollView::addChild):
        (QTextEdit::setDisabled):
        (QScrollBar::scroll):
        (Widget::~Widget):
        (QPainter::xForm):
        (QListBox::sizeForNumberOfLines):
        (ScrollView::resizeContents):
        (QLineEdit::selectionStart):
        (QLineEdit::QLineEdit):
        (FrameView::updateBorder):
        (QLineEdit::hasSelectedText):
        (QScrollBar::QScrollBar):
        (QListBox::doneAppendingItems):
        (QTextEdit::QTextEdit):
        (ScrollView::inWindow):
        (QScrollBar::setValue):
        (QFont::setFirstFamily):
        (QTextEdit::hasSelectedText):
        (QTextEdit::selectionStart):
        (QFont::setWeight):
        (ScrollView::scrollXOffset):
        (QListBox::isSelected):
        (QLineEdit::setReadOnly):
        (QPainter::drawLineForText):
        (QPainter::QPainter):
        (QComboBox::~QComboBox):
        (QComboBox::focusPolicy):
        (QPainter::drawImageAtPoint):
        (QPainter::clearShadow):
        (QTextEdit::setLineHeight):
        (QScrollBar::setKnobProportion):
        (KWQFileButton::KWQFileButton):
        (QFontMetrics::boundingRect):
        (QTextEdit::setSelectionStart):
        (QPainter::beginTransparencyLayer):
        (QFontMetrics::setFont):
        (QComboBox::setFont):
        (Widget::frameGeometry):
        (QListBox::setSelected):
        (QPainter::addFocusRingRect):
        (QTextEdit::setCursorPosition):
        (QPainter::restore):
        (QFontMetrics::width):
        (Widget::setEnabled):
        (QTextEdit::setSelectionEnd):
        (QComboBox::populate):
        (ScrollView::setStaticBackground):
        (QPainter::font):
        (QTextEdit::setAlignment):
        (QLineEdit::setCursorPosition):
        (QPainter::drawText):
        (QPainter::pen):
        (KJavaAppletWidget::KJavaAppletWidget):
        (QFontMetrics::descent):
        (QListBox::QListBox):
        (QFontMetrics::ascent):
        (QLineEdit::selectedText):
        (Widget::setIsSelected):
        (QLineEdit::text):
        (Widget::unlockDrawingFocus):
        (QLineEdit::setLiveSearch):
        (QPainter::paintingDisabled):
        (QComboBox::QComboBox):
        (QPainter::drawConvexPolygon):
        (Widget::setFont):
        (QSlider::setMaxValue):
        (Widget::lockDrawingFocus):
        (QPainter::drawLine):
        (QPainter::setBrush):
        (QTextEdit::setSelectionRange):
        (ScrollView::scrollPointRecursively):
        (QLineEdit::sizeForCharacterWidth):
        (Cursor::~Cursor):
        (QFontMetrics::selectionRectForText):
        (ScrollView::suppressScrollBars):
        (QFontMetrics::checkSelectionPoint):
        (QTextEdit::getCursorPosition):
        (FrameView::isFrameView):
        (QScrollBar::setSteps):
        (QLineEdit::setMaxLength):
        (Widget::setCursor):
        (QLineEdit::setAutoSaveName):
        (QComboBox::baselinePosition):
        (QComboBox::appendItem):
        (QPainter::setShadow):
        (QTextEdit::setWritingDirection):
        (Widget::setDrawingAlpha):
        (QSlider::QSlider):
        (ScrollView::setVScrollBarMode):
        (QPainter::drawScaledAndTiledImage):
        (ScrollView::scrollYOffset):
        (QPainter::drawImage):
        (QComboBox::setCurrentItem):
        (QFontMetrics::height):
        (QComboBox::setWritingDirection):
        (ScrollView::setScrollBarsMode):
        (QComboBox::sizeHint):
        (QPainter::drawRect):
        (QFont::setPixelSize):
        (Widget::setFrameGeometry):
        (QLineEdit::setSelection):
        (QLineEdit::setMaxResults):
        (QListBox::clear):
        (QLineEdit::edited):
        (QPainter::drawTiledImage):
        (QPainter::clearFocusRing):
        (QFont::operator==):
        (Widget::Widget):
        (QTextEdit::text):
        (QPainter::drawImageInRect):
        (QPainter::setFont):
        (Widget::disableFlushDrawing):
        (QPainter::initFocusRing):
        (QSlider::setMinValue):
        (QTextEdit::setWordWrap):
        (QPainter::drawLineForMisspelling):
        (QLineEdit::setText):
        (QSlider::value):
        (QListBox::setSelectionMode):
        (KWQFileButton::setFilename):
        (QFontMetrics::QFontMetrics):
        (QFontMetrics::lineSpacing):
        (QLineEdit::setEdited):
        (QComboBox::frameGeometry):
        (QListBox::setWritingDirection):
        (QLineEdit::setAlignment):
        (ScrollView::updateContents):
        (QFontMetrics::floatWidth):
        (ScrollView::setHScrollBarMode):
        (KWQFileButton::focusPolicy):
        (QListBox::setFont):
        (QLineEdit::checksDescendantsForFocus):
        (KWQFileButton::baselinePosition):
        (QSlider::~QSlider):
        (KWQFileButton::setFrameGeometry):
        (QListBox::~QListBox):
        (KWQFileButton::frameGeometry):
        (QTextEdit::setFont):
        (QLineEdit::setFont):
        (KWQFileButton::~KWQFileButton):
        (QTextEdit::focusPolicy):
        (QSlider::focusPolicy):
        (QSlider::setFont):
        (QListBox::setEnabled):
        (QListBox::checksDescendantsForFocus):
        (QListBox::focusPolicy):
        (QLineEdit::baselinePosition):
        (QSlider::sizeHint):
        (QLineEdit::~QLineEdit):
        (QTextEdit::~QTextEdit):
        (QTextEdit::checksDescendantsForFocus):
        (QLineEdit::focusPolicy):
        (QScrollBar::~QScrollBar):
        (Path::operator=):
        (QLineEdit::setColors):
        (QTextEdit::setColors):
        (searchableIndexIntroduction):
        (KWQKCookieJar::setCookie):
        (KWQKCookieJar::cookie):
        (WebCore::screenRect):
        (WebCore::Widget::clearFocus):
        (WebCore::historyContains):
        (KWQFindNextSentenceFromIndex):
        (KWQFindSentenceBoundary):
        (KWQFindNextWordFromIndex):
        (KWQFindWordBoundary):
        (submitButtonDefaultLabel):
        (inputElementAltText):
        (resetButtonDefaultLabel):
        (KWQKCookieJar::cookieEnabled):
        (WebCore::Widget::setFocus):
        (WebCore::QPainter::fillRect):
        (WebCore::QPainter::~QPainter):
        (WebCore::ScrollView::viewportToContents):
        (WebCore::TransferJob::kill):
        (WebCore::TransferJob::addMetaData):
        (WebCore::TransferJob::queryMetaData):
        (WebCore::TransferJob::error):
        (WebCore::TransferJob::errorText):
        (WebCore::TransferJob::isErrorPage):
        (WebCore::TransferJob::TransferJob):
        (WebCore::Widget::hide):
        (KLocale::language):
        (PlugInInfoStore::createPluginInfoForPluginAtIndex):
        (WebCore::screenDepth):
        (QFont::italic):
        (QFontMetrics::operator=):
        (QFontMetrics::xHeight):
        (WebCore::usableScreenRect):
        (QFont::operator=):
        (Widget::setActiveWindow):
        (KWQCheckIfReloading):
        (WebCore::ScrollView::contentsX):
        (WebCore::ScrollView::contentsY):
        (WebCore::ScrollView::contentsHeight):
        (WebCore::ScrollView::contentsWidth):
        (WebCore::ScrollView::visibleHeight):
        (WebCore::ScrollView::visibleWidth):
        (WebCore::ScrollView::hScrollBarMode):
        (WebCore::ScrollView::vScrollBarMode):
        (KWQCheckCacheObjectStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
tomernic [Tue, 28 Feb 2006 01:17:05 +0000 (01:17 +0000)]
    Reviewed by Adele.

        <rdar://problem/4222043> Safari should reduce null events sent to invisible plugins

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView restartNullEvents]):
        Check to see if the plugin view is completely obscured (scrolled out of view, for example).  If it is
        obscured and it wasn't before, or the other way around, then restart the null event timer so it can
        fire at the appropriate rate.
        (-[WebBaseNetscapePluginView viewHasMoved:]):
        If a plugin is obscured, send it null events as if it were in an inactive window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 01:00:08 +0000 (01:00 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by timo.

        Fix xcode project after previous KWQLogging move.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/Logging.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 28 Feb 2006 00:41:39 +0000 (00:41 +0000)]
LayoutTests:

        Reviewed by darin

        Test for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
        elementAtPoint returns the list when the point is over a list marker

        * fast/events/onclick-list-marker-expected.txt: Added.
        * fast/events/onclick-list-marker.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
        elementAtPoint returns the list when the point is over a list marker

        Consider the case of outside list markers in nodeAtPoint.  Had to pull
        the code out of RenderListMarker::paint that computed the position/size
        of the list marker.

        Added:
        * fast/events/onclick-list-marker.html

        * rendering/render_list.cpp:
        (RenderListItem::nodeAtPoint):
        (RenderListItem::getAbsoluteRepaintRect):
        (RenderListMarker::paint):
        (RenderListMarker::nodeAtPoint):
        (RenderListMarker::getRelativeMarkerRect):
        * rendering/render_list.h:
        * rendering/render_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 00:19:49 +0000 (00:19 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by timo.

        Move KWQLogging to platform and rename as Logging.*, fix headers.
        This will break the mac build, which I will fix on my next commit.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * dom/DocumentImpl.cpp:
        * dom/dom_position.cpp:
        * editing/DeleteSelectionCommand.cpp:
        * editing/InsertLineBreakCommand.cpp:
        * editing/InsertParagraphSeparatorCommand.cpp:
        * editing/InsertTextCommand.cpp:
        * editing/VisiblePosition.cpp:
        * editing/markup.cpp:
        * khtml/ecma/kjs_window.cpp:
        * kwq/KWQLogging.h: Removed.
        * kwq/KWQLogging.m: Removed.
        * kwq/KWQRegExp.cpp:
        * kwq/KWQTextStream.cpp:
        * platform/Logging.cpp: Added.
        * platform/Logging.h: Added.
        * platform/QString.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::ScrollView::vScrollBarMode):
        (WebCore::theme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Feb 2006 00:05:59 +0000 (00:05 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Fix a bunch more link errors in the win32 build, mostly by adding stubs.

        * WebCore.vcproj/WebCore/WebCore.vcproj: add JSXMLHttpRequest and PlugInInfoStore
        * WebCore.vcproj/WebCore/build-generated-files.sh: update for JSXMLHttpRequest
        * khtml/ecma/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequest::getValueProperty): fix switch to compile
        * platform/PlugInInfoStore.h:
        * platform/mac/PlugInInfoStoreMac.mm:
        * platform/win/TemporaryLinkStubs.cpp: add a bunch of stubs.
        (WebCore::TransferJob::errorText):
        (WebCore::TransferJob::isErrorPage):
        (WebCore::Widget::hide):
        (PlugInInfoStore::createPluginInfoForPluginAtIndex):
        (PlugInInfoStore::pluginCount):
        (WebCore::refreshPlugins):
        (QFont::QFont):
        (QFont::~QFont):
        (QFont::italic):
        (QFont::weight):
        (QFontMetrics::QFontMetrics):
        (QFontMetrics::~QFontMetrics):
        (QFontMetrics::xHeight):
        (Widget::setActiveWindow):
        (WebCore::ScrollView::contentsX):
        (WebCore::ScrollView::contentsY):
        (WebCore::ScrollView::contentsHeight):
        (WebCore::ScrollView::contentsWidth):
        (WebCore::ScrollView::visibleHeight):
        (WebCore::ScrollView::visibleWidth):
        (WebCore::ScrollView::hScrollBarMode):
        (WebCore::ScrollView::vScrollBarMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Feb 2006 23:23:18 +0000 (23:23 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by timo.

        Add missing include to fix build.

        * platform/win/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-25 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Feb 2006 23:08:56 +0000 (23:08 +0000)]
2006-02-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Test new PlugInInfoStore class (used to be KConfig).

        * plugins/plugin-javascript-access-expected.txt: Added.
        * plugins/plugin-javascript-access.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Feb 2006 23:08:13 +0000 (23:08 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Test new KConfig -> PlugInInfoStore change.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

        * DumpRenderTree/DumpRenderTree.m:
        (main): load test netscape plugin
        * Scripts/run-webkit-tests: style update

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Feb 2006 23:07:36 +0000 (23:07 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Move KConfig to platform/PlugInInfoStore and add test.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

        Test: plugins/plugin-javascript-access.html

        * ForwardingHeaders/kconfig.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * khtml/ecma/kjs_navigator.cpp:
        (KJS::PluginBase::PluginBase):
        * khtml/ecma/kjs_window.cpp:
        * kwq/KWQKConfigBase.h: Removed.
        * kwq/KWQKConfigBase.mm: Removed.
        * platform/PlugInInfoStore.h: Added.
        * platform/mac/PlugInInfoStoreMac.mm: Added.
        (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
        (WebCore::PlugInInfoStore::pluginCount):
        (WebCore::refreshPlugins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Mon, 27 Feb 2006 22:43:21 +0000 (22:43 +0000)]
    Reviewed by Eric.

        * platform/win/TemporaryLinkStubs.cpp: Added more stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix for i386. Workaround for 4213314
thatcher [Mon, 27 Feb 2006 22:42:17 +0000 (22:42 +0000)]
Build fix for i386. Workaround for 4213314

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fixed Mac Debug build, there was an unused parameter
darin [Mon, 27 Feb 2006 21:55:19 +0000 (21:55 +0000)]
    - fixed Mac Debug build, there was an unused parameter

        * kxmlcore/FastMalloc.cpp: (KXMLCore::fastMallocRegisterThread):
        Remove parameter name.

        * kjs/debugger.h: Fixed comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Feb 2006 21:40:35 +0000 (21:40 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        * kxmlcore/Vector.h:
        (KXMLCore::deleteAllValues): fix unused variable warning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Mon, 27 Feb 2006 21:36:56 +0000 (21:36 +0000)]
    Reviewed by Darin.

        - Turn off -Wno-unused-param for JavaScriptCore and get rid of unused params
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7384

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/NP_jsobject.cpp:
        (jsAllocate):
        (_NPN_InvokeDefault):
        (_NPN_Evaluate):
        (_NPN_GetProperty):
        (_NPN_SetProperty):
        (_NPN_RemoveProperty):
        (_NPN_HasProperty):
        (_NPN_HasMethod):
        * bindings/c/c_class.h:
        (KJS::Bindings::CClass::constructorAt):
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertNPVariantToValue):
        * bindings/jni/jni_class.cpp:
        (JavaClass::methodsNamed):
        (JavaClass::fieldNamed):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeDefaultMethod):
        * bindings/jni/jni_jsobject.cpp:
        * bindings/jni/jni_objc.mm:
        (-[NSObject KJS::Bindings::]):
        * bindings/objc/WebScriptObject.mm:
        (+[WebUndefined allocWithZone:]):
        (-[WebUndefined initWithCoder:]):
        (-[WebUndefined encodeWithCoder:]):
        (-[WebUndefined copyWithZone:]):
        * bindings/objc/objc_class.h:
        (KJS::Bindings::ObjcClass::constructorAt):
        * bindings/objc/objc_class.mm:
        (KJS::Bindings::ObjcClass::methodsNamed):
        (KJS::Bindings::ObjcClass::fallbackObject):
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::getValueOfUndefinedField):
        * bindings/objc/objc_runtime.mm:
        (ObjcFallbackObjectImp::getOwnPropertySlot):
        (ObjcFallbackObjectImp::put):
        (ObjcFallbackObjectImp::canPut):
        (ObjcFallbackObjectImp::deleteProperty):
        (ObjcFallbackObjectImp::toBoolean):
        * bindings/runtime.cpp:
        (KJS::Bindings::Instance::createLanguageInstanceForValue):
        * bindings/runtime.h:
        (KJS::Bindings::Instance::getValueOfUndefinedField):
        (KJS::Bindings::Instance::setValueOfUndefinedField):
        * bindings/runtime_array.cpp:
        (RuntimeArray::lengthGetter):
        (RuntimeArray::indexGetter):
        (RuntimeArray::put):
        (RuntimeArray::deleteProperty):
        * bindings/runtime_method.cpp:
        (RuntimeMethod::lengthGetter):
        (RuntimeMethod::execute):
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::fallbackObjectGetter):
        (RuntimeObjectImp::fieldGetter):
        (RuntimeObjectImp::methodGetter):
        (RuntimeObjectImp::put):
        (RuntimeObjectImp::canPut):
        (RuntimeObjectImp::deleteProperty):
        (RuntimeObjectImp::defaultValue):
        (RuntimeObjectImp::callAsFunction):
        * bindings/runtime_root.cpp:
        (performJavaScriptAccess):
        * kjs/array_object.cpp:
        (ArrayInstance::lengthGetter):
        (ArrayInstance::getOwnPropertySlot):
        (ArrayPrototype::ArrayPrototype):
        (ArrayPrototype::getOwnPropertySlot):
        * kjs/bool_object.cpp:
        (BooleanObjectImp::BooleanObjectImp):
        * kjs/date_object.cpp:
        (KJS::DateObjectFuncImp::DateObjectFuncImp):
        (KJS::DateObjectFuncImp::callAsFunction):
        * kjs/error_object.cpp:
        (ErrorObjectImp::ErrorObjectImp):
        (NativeErrorPrototype::NativeErrorPrototype):
        (NativeErrorImp::NativeErrorImp):
        * kjs/function.cpp:
        (KJS::FunctionImp::argumentsGetter):
        (KJS::FunctionImp::lengthGetter):
        (KJS::Arguments::mappedIndexGetter):
        (KJS::ActivationImp::argumentsGetter):
        (KJS::ActivationImp::put):
        * kjs/function_object.cpp:
        (FunctionObjectImp::FunctionObjectImp):
        * kjs/internal.cpp:
        (KJS::GetterSetterImp::toPrimitive):
        (KJS::GetterSetterImp::toBoolean):
        * kjs/interpreter.cpp:
        (KJS::Interpreter::evaluate):
        * kjs/interpreter.h:
        (KJS::Interpreter::isGlobalObject):
        (KJS::Interpreter::interpreterForGlobalObject):
        (KJS::Interpreter::isSafeScript):
        * kjs/lexer.cpp:
        (Lexer::makeIdentifier):
        (Lexer::makeUString):
        * kjs/lookup.h:
        (KJS::staticFunctionGetter):
        (KJS::staticValueGetter):
        * kjs/nodes.cpp:
        (StatementNode::processFuncDecl):
        (PropertyNode::evaluate):
        (PropertyNameNode::evaluate):
        * kjs/number_object.cpp:
        (NumberObjectImp::NumberObjectImp):
        (NumberObjectImp::getOwnPropertySlot):
        * kjs/object.cpp:
        (KJS::JSObject::defineGetter):
        (KJS::JSObject::defineSetter):
        (KJS::JSObject::hasInstance):
        (KJS::JSObject::propertyIsEnumerable):
        * kjs/object_object.cpp:
        (ObjectObjectImp::ObjectObjectImp):
        * kjs/property_slot.cpp:
        (KJS::PropertySlot::undefinedGetter):
        (KJS::PropertySlot::functionGetter):
        * kjs/reference.cpp:
        (KJS::Reference::getPropertyName):
        * kjs/reference_list.cpp:
        (ReferenceListIterator::operator++):
        * kjs/regexp_object.cpp:
        (RegExpObjectImp::RegExpObjectImp):
        (RegExpObjectImp::getValueProperty):
        (RegExpObjectImp::putValueProperty):
        * kjs/string_object.cpp:
        (StringInstance::lengthGetter):
        (StringInstance::indexGetter):
        (StringPrototype::StringPrototype):
        * kxmlcore/Assertions.mm:
        * kxmlcore/FastMalloc.cpp:
        (KXMLCore::TCMalloc_PageHeap::CheckList):
        * kxmlcore/HashTable.h:
        (KXMLCore::HashTableConstIterator::checkValidity):
        (KXMLCore::IdentityHashTranslator::translate):
        * pcre/pcre_get.c:
        (pcre_get_stringnumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Feb 2006 21:31:01 +0000 (21:31 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Reworked KConfig and plugin architecture to be much more sane.
        This is part one.  Once this lands, I'll move it under platform with a better name.

        Darin had several great suggested further improvements as part of:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7451
        I'll make some of those when I move this to platform.

        No layout test possible (no way to control which plugins DRT sees).

        * khtml/ecma/kjs_navigator.cpp:
        (KJS::PluginBase::PluginBase):
        (KJS::PluginBase::~PluginBase):
        (KJS::PluginBase::refresh):
        (KJS::Plugins::getValueProperty):
        (KJS::Plugins::nameGetter):
        (KJS::Plugins::getOwnPropertySlot):
        (KJS::MimeTypes::getValueProperty):
        (KJS::MimeTypes::nameGetter):
        (KJS::MimeTypes::getOwnPropertySlot):
        (KJS::Plugin::getValueProperty):
        (KJS::Plugin::nameGetter):
        (KJS::Plugin::getOwnPropertySlot):
        * khtml/ecma/kjs_navigator.h:
        * khtml/ecma/kjs_window.cpp:
        * kwq/KWQKConfigBase.h:
        (WebCore::PluginInfoStore::PluginInfoStore):
        * kwq/KWQKConfigBase.mm:
        (WebCore::PluginInfoStore::createPluginInfoForPluginAtIndex):
        (WebCore::PluginInfoStore::pluginCount):
        (WebCore::refreshPlugins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-27 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Feb 2006 21:01:22 +0000 (21:01 +0000)]
2006-02-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Build fix: cast to unsigned from size_t.

        * platform/StreamingTextDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Mon, 27 Feb 2006 20:17:35 +0000 (20:17 +0000)]
    Reviewed by Darin.

        - add Selection.cpp to win32 build
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7490

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - use proper header for std::min.
mjs [Mon, 27 Feb 2006 20:11:25 +0000 (20:11 +0000)]
    - use proper header for std::min.

        * platform/StreamingTextDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Mon, 27 Feb 2006 19:30:55 +0000 (19:30 +0000)]
    Reviewed by Darin.

        - add new TextEncoding stuff to win32 build
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7491

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * platform/StreamingTextDecoder.cpp:
        (WebCore::StreamingTextDecoder::convertUTF16):
        * platform/TextEncoding.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix Windows build
darin [Mon, 27 Feb 2006 17:58:39 +0000 (17:58 +0000)]
    - try to fix Windows build

        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed rendering/font.* and added platform/Font.*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * css/csshelper.cpp: (WebCore::parseURL): Actually, the second version was...
darin [Mon, 27 Feb 2006 17:23:02 +0000 (17:23 +0000)]
    * css/csshelper.cpp: (WebCore::parseURL): Actually, the second version was fine. Rolling
        back to that; apologies for the churn.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * css/csshelper.cpp: (WebCore::parseURL): Third time's the charm.
darin [Mon, 27 Feb 2006 17:06:53 +0000 (17:06 +0000)]
    * css/csshelper.cpp: (WebCore::parseURL): Third time's the charm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * css/csshelper.cpp: (WebCore::parseURL): Oops! Checked in fixed version...
darin [Mon, 27 Feb 2006 17:00:45 +0000 (17:00 +0000)]
    * css/csshelper.cpp: (WebCore::parseURL): Oops! Checked in fixed version of this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Mon, 27 Feb 2006 16:55:53 +0000 (16:55 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7486
          a first step in improving String/StringImpl API -- use "s" and "l" less

        * css/csshelper.cpp: (WebCore::parseURL): Use a local buffer rather than
        manipulating the characters directly inside a StringImpl buffer.

        * css/cssstyleselector.cpp: (WebCore::parseUASheet): Copy the data to parse
        it rather than going out of our way to hack StringImpl to not copy the data.
        It would be better not to copy, but this is one-time work.

        * dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
        * dom/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getMatchedCSSRules):
        * dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
        * dom/dom_xmlimpl.cpp: (WebCore::EntityImpl::toString):
        * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
        * khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError):
        * platform/AtomicString.cpp:
        (WebCore::CStringTranslator::equal):
        (WebCore::QCharBufferTranslator::equal):
        (WebCore::AtomicString::add):
        * platform/StringImpl.h:
        (WebCore::StringImpl::unicode): Added.
        (KXMLCore::CaseInsensitiveHash::hash):
        (KXMLCore::CaseInsensitiveHash::equal):
        * rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionStartEnd):
        * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
        * rendering/RenderText.cpp:
        (WebCore::getCharacterBreakIterator):
        (WebCore::RenderText::RenderText):
        (WebCore::RenderText::atLineWrap):
        (WebCore::RenderText::allAscii):
        (WebCore::RenderText::widthFromCache):
        (WebCore::RenderText::trimmedMinMaxWidth):
        (WebCore::RenderText::containsOnlyWhitespace):
        (WebCore::RenderText::setSelectionState):
        (WebCore::RenderText::setTextWithOffset):
        (WebCore::RenderText::setText):
        (WebCore::RenderText::width):
        (WebCore::RenderText::selectionRect):
        (WebCore::RenderText::caretMaxOffset):
        * rendering/RenderTextFragment.cpp:
        (khtml::RenderTextFragment::RenderTextFragment):
        (khtml::RenderTextFragment::originalString):
        Use length() instead of l, unicode() instead of s, and (*x)[] instead of x->s[].

        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Use const.
        (WebCore::endOfParagraph): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix problem with a prototype that broke win32 build
mjs [Mon, 27 Feb 2006 10:49:44 +0000 (10:49 +0000)]
    - fix problem with a prototype that broke win32 build

        * platform/StreamingTextDecoder.h:
        (WebCore::StreamingTextDecoder::convert):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix debug build (broken by my last commit)
mjs [Mon, 27 Feb 2006 10:02:49 +0000 (10:02 +0000)]
    - fix debug build (broken by my last commit)

        * platform/StreamingTextDecoder.cpp:
        (WebCore::StreamingTextDecoder::createICUConverter):
        (WebCore::StreamingTextDecoder::convertUsingICU):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Mon, 27 Feb 2006 09:17:06 +0000 (09:17 +0000)]
    Reviewed by Darin.

        - platformize KWQTextCodec
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7487

        I renamed QTextCodec to TextEncoding and QTextDecoder to
        StreamingTextDecoder. I also made a bunch of other changes to make
        the API more sensible.

        * ForwardingHeaders/qtextcodec.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/MacFrame.mm:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge URLWithAttributeString:]):
        (-[WebCoreFrameBridge textEncoding]):
        (+[WebCoreFrameBridge stringWithData:textEncoding:]):
        (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::completeURL):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMDocument::getValueProperty):
        (KJS::DOMDocument::putValueProperty):
        * khtml/html/FormDataList.cpp:
        (DOM::FormDataList::FormDataList):
        (DOM::FormDataList::appendString):
        * khtml/html/FormDataList.h:
        * khtml/html/HTMLFormElementImpl.cpp:
        (WebCore::HTMLFormElementImpl::HTMLFormElementImpl):
        (WebCore::HTMLFormElementImpl::formData):
        * khtml/html/htmltokenizer.cpp:
        * khtml/misc/decoder.cpp:
        (Decoder::Decoder):
        (Decoder::setEncodingName):
        (Decoder::encodingName):
        (Decoder::decode):
        * khtml/misc/decoder.h:
        (khtml::Decoder::):
        (khtml::Decoder::visuallyOrdered):
        (khtml::Decoder::encoding):
        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::XSLTProcessorImpl::createDocumentFromSource):
        * kwq/KWQCharsets.cpp: Removed.
        * kwq/KWQCharsets.h: Removed.
        * kwq/KWQTextCodec.cpp: Removed.
        * kwq/KWQTextCodec.h: Removed.
        * kwq/WebCoreTextDecoder.h:
        * kwq/WebCoreTextDecoder.mm:
        * kwq/can-convert.mm: Removed.
        * kwq/character-sets.txt: Removed.
        * kwq/mac-encodings.txt: Removed.
        * kwq/make-charset-table.pl: Removed.
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        (WebCore::CachedCSSStyleSheet::setCharset):
        (WebCore::CachedCSSStyleSheet::data):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        (WebCore::CachedScript::setCharset):
        (WebCore::CachedScript::data):
        * loader/CachedScript.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::setCharset):
        * page/Frame.cpp:
        (WebCore::Frame::write):
        (WebCore::Frame::gotoAnchor):
        (WebCore::Frame::encoding):
        (WebCore::Frame::backslashAsCurrencySymbol):
        * platform/CharsetNames.cpp: Added.
        (KXMLCore::):
        (WebCore::EncodingHash::equal):
        (WebCore::EncodingHash::hash):
        (WebCore::buildDictionaries):
        (WebCore::textEncodingIDFromCharsetName):
        (WebCore::charsetNameFromTextEncodingID):
        * platform/CharsetNames.h: Added.
        * platform/KURL.cpp:
        (KURL::KURL):
        (KURL::decode_string):
        (encodeRelativeString):
        * platform/KURL.h:
        * platform/QString.cpp:
        (QString::fromUtf8):
        * platform/StreamingTextDecoder.cpp: Added.
        (WebCore::StreamingTextDecoder::StreamingTextDecoder):
        (WebCore::StreamingTextDecoder::convertLatin1):
        (WebCore::StreamingTextDecoder::~StreamingTextDecoder):
        (WebCore::StreamingTextDecoder::convertUTF16):
        (WebCore::effectiveEncoding):
        (WebCore::StreamingTextDecoder::createICUConverter):
        (WebCore::unwanted):
        (WebCore::StreamingTextDecoder::appendOmittingUnwanted):
        (WebCore::StreamingTextDecoder::convertUsingICU):
        (WebCore::StreamingTextDecoder::convert):
        (WebCore::StreamingTextDecoder::toUnicode):
        * platform/StreamingTextDecoder.h: Added.
        (WebCore::StreamingTextDecoder::convert):
        * platform/TextEncoding.cpp: Added.
        (WebCore::TextEncoding::TextEncoding):
        (WebCore::TextEncoding::name):
        (WebCore::effectiveEncoding):
        (WebCore::TextEncoding::backslashAsCurrencySymbol):
        (WebCore::TextEncoding::toUnicode):
        * platform/TextEncoding.h: Added.
        (WebCore::):
        (WebCore::TextEncoding::):
        (WebCore::TextEncoding::TextEncoding):
        (WebCore::TextEncoding::isValid):
        (WebCore::TextEncoding::usesVisualOrdering):
        (WebCore::TextEncoding::isJapanese):
        (WebCore::TextEncoding::encodingID):
        (WebCore::TextEncoding::flags):
        (WebCore::operator==):
        (WebCore::operator!=):
        * platform/character-sets.txt: Added.
        * platform/mac/ExtraCFEncodings.h: Added.
        * platform/mac/QStringMac.mm:
        * platform/mac/TextEncodingMac.cpp: Added.
        (WebCore::effectiveEncoding):
        (WebCore::TextEncoding::fromUnicode):
        * platform/mac/can-convert.mm: Added.
        * platform/mac/mac-encodings.txt: Added.
        * platform/make-charset-table.pl: Added.
        * platform/win/win-encodings.txt: Added.
        * rendering/render_object.cpp:
        (WebCore::RenderObject::backslashAsCurrencySymbol):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::slotData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix Windows build
darin [Mon, 27 Feb 2006 08:24:22 +0000 (08:24 +0000)]
    - fix Windows build

        * platform/win/TemporaryLinkStubs.cpp: Change KIO::TransferJob to WebCore::TransferJob.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Mon, 27 Feb 2006 08:13:12 +0000 (08:13 +0000)]
    Reviewed by Maciej.

        - merged Job and TransferJob into TransferJob and moved it to WebCore namespace
        - changed TransferJob to use a TransferJobClient object instead of signals

        * ForwardingHeaders/kio/job.h: Changed to point to "KWQKJobClasses.h".
        * kwq/KWQKJob.h: Removed.
        * kwq/TransferJobClient.h: Added.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * dom/xml_tokenizer.cpp: (WebCore::openFunc):
        * khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
        Use "new TransferJob" instead of "KIO::get" and "KIO::http_post".

        * kwq/KWQKJobClasses.h: Eliminate Job. Add a TransferJobClient* parameter to
        TransferJob. Eliminate the deliverAllData parameter to TransferJob constructor.
        Remove the signals from TransferJob.
        * kwq/KWQKJobClasses.mm:
        (WebCore::TransferJobPrivate::TransferJobPrivate): Store a client pointer.
        (WebCore::TransferJob::TransferJob): Store a client pointer, remove the
        deliverAllData boolean.
        (WebCore::TransferJob::receivedResponse): Added. Replaces the old emitReceivedResponse
        function; uses client instead of a signal.
        (WebCore::TransferJob::client): Added.

        * kwq/KWQLoader.h: Switched things to mention the WebCore namespace.
        Changed KIO::TransferJob to WebCore::TransferJob.
        * kwq/KWQLoader.mm: Ditto.

        * kwq/KWQObject.h:
        * kwq/KWQObject.cpp: Removed isKHTMLLoader.

        * kwq/KWQResourceLoader.h: Changed KIO::TransferJob to WebCore::TransferJob.
        * kwq/KWQResourceLoader.mm:
        (-[KWQResourceLoader receivedResponse:]): Call receivedResponse function on
        the job instead of emitReceivedResponse.
        (-[KWQResourceLoader redirectedToURL:]): Call receivedRedirect function on the
        client directly instead of emitRedirection on the job.
        (-[KWQResourceLoader addData:]): Call receivedData function on the
        client directly instead of emitData on the job.
        (-[KWQResourceLoader finishJobAndHandle:]): Call receivedAllData function on the
        client directly instead of emitResult on the job. Also fixed a potential memory leak
        where the handle was not released if the job was 0.

        * kwq/KWQSignal.h:
        * kwq/KWQSignal.cpp:
        * kwq/KWQSlot.h:
        * kwq/KWQSlot.cpp:
        Removed the job-related signals and slots.

        * loader/CachedObject.h: Removed unneeded declaration of TransferJob.

        * loader/loader.h:
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests): Use "new TransferJob" instead of "KIO::get".
        Also don't connect signals.
        (WebCore::Loader::receivedAllData): New name for slotFinished.
        (WebCore::Loader::receivedResponse): New name for slotReceivedResponse.
        (WebCore::Loader::receivedData): New name for slotData.
        (WebCore::Loader::cancelRequests): Changed KIO::Job to TransferJob.
        (WebCore::Loader::jobForRequest): Ditto.

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::didOpenURL): Use "new TransferJob" instead of "KIO::get" and
        "KIO::http_post". Also don't connect signals.
        (WebCore::Frame::receivedAllData): Renamed from slotFinished. Also slightly
        cleaned up the logic.
        (WebCore::Frame::receivedRedirect): Renamed from slotRedirection.
        * page/FramePrivate.h: Changed KIO::TransferJob to WebCore::TransferJob.

        * xml/xmlhttprequest.h:
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest): Eliminate XMLHttpRequestQObject.
        (WebCore::XMLHttpRequest::send): Use "new TransferJob" instead of
        "KIO::get" and "KIO::http_post". Also don't connect signals.
        (WebCore::XMLHttpRequest::processSyncLoadResults): Change to call the functions
        by their new names (names changed to use with TransferJobClient).
        (WebCore::XMLHttpRequest::receivedAllData): Renamed from slotFinished.
        (WebCore::XMLHttpRequest::receivedRedirect): Renamed from slotRedirection.
        (WebCore::XMLHttpRequest::receivedData): Renamed from slotData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej, landed by Geoff.
ggaren [Mon, 27 Feb 2006 06:34:59 +0000 (06:34 +0000)]
    Reviewed by Maciej, landed by Geoff.

        Change "Deployment" to "Release" and "Development" to "Debug".
        Update latest Xcode version from 2.2 to 2.2.1.

        * building/build.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej, landed by Geoff.
ggaren [Mon, 27 Feb 2006 06:30:27 +0000 (06:30 +0000)]
    Reviewed by Maciej, landed by Geoff.

        - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=4977
        <form> not being displayed at all.

        * fast/forms/form-hides-table-expected.checksum: Added.
        * fast/forms/form-hides-table-expected.png: Added.
        * fast/forms/form-hides-table-expected.txt: Added.
        * fast/forms/form-hides-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Mon, 27 Feb 2006 06:22:07 +0000 (06:22 +0000)]
LayoutTests:

        Test by Geoff, automated by me, reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7293
          REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit

        * fast/frames/empty-frame-document-expected.txt: Added.
        * fast/frames/empty-frame-document.html: Added.

WebKit:

        Test: fast/frames/empty-frame-document.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7293
          REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit

        The crash happened because an empty frame did not have a document.

        * WebView/WebFrame.m:
        (-[WebFrame _commitProvisionalLoad:]): Use "about:blank" instead of an empty URL for empty
        frames. This causes a document to be created for the frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try again after seeing errors from buildbot
darin [Mon, 27 Feb 2006 04:08:55 +0000 (04:08 +0000)]
    - try again after seeing errors from buildbot

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::checkNotify):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::data):
        Add __APPLE__ ifdefs to two more uses of response.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try again after seeing errors from buildbot
darin [Mon, 27 Feb 2006 03:50:26 +0000 (03:50 +0000)]
    - try again after seeing errors from buildbot

        * loader/CachedObject.cpp: (WebCore::CachedObject::~CachedObject):
        * loader/CachedObject.h: (WebCore::CachedObject::CachedObject):
        * loader/loader.cpp:
        Add __APPLE__ ifdefs to calls to setResponse and setAllData.

        * platform/win/TemporaryLinkStubs.cpp: Add missing includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Mon, 27 Feb 2006 03:31:44 +0000 (03:31 +0000)]
    Reviewed by Maciej.

        - more Win32 link fixes

        * loader/CachedObject.h: Put some Mac-specific stuff inside
        __APPLE__ ifdefs.
        * platform/win/TemporaryLinkStubs.cpp: Added more stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try again after seeing errors from buildbot
darin [Mon, 27 Feb 2006 03:08:58 +0000 (03:08 +0000)]
    - try again after seeing errors from buildbot

        * platform/win/TemporaryLinkStubs.cpp: Added more includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try again after seeing errors from buildbot
darin [Mon, 27 Feb 2006 03:08:02 +0000 (03:08 +0000)]
    - try again after seeing errors from buildbot

        * platform/win/TemporaryLinkStubs.cpp: Added more includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Mon, 27 Feb 2006 03:03:14 +0000 (03:03 +0000)]
    Reviewed by Maciej.

        - work toward getting the Win32 build to link

        * WebCore.vcproj/WebCore/WebCore.vcproj: Added KWQObject.cpp.
        * platform/win/TemporaryLinkStubs.cpp: Added more stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded reviewer to an old change; I just noticed it was missing.
darin [Sun, 26 Feb 2006 04:51:37 +0000 (04:51 +0000)]
Added reviewer to an old change; I just noticed it was missing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago RS by mjs.
ggaren [Sun, 26 Feb 2006 01:14:35 +0000 (01:14 +0000)]
    RS by mjs.

        -tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
        Re-landing results after adding missing png's to the test.

        * fast/replaced/resources/1x1-blue.png: Added.
        * fast/replaced/resources/square-blue-100x100.png: Added.
        * fast/replaced/maxheight-percent-expected.checksum: Added.
        * fast/replaced/maxheight-percent-expected.png: Added.
        * fast/replaced/maxheight-percent-expected.txt:
        * fast/replaced/maxheight-pxs-expected.checksum: Added.
        * fast/replaced/maxheight-pxs-expected.png: Added.
        * fast/replaced/maxheight-pxs-expected.txt:
        * fast/replaced/maxwidth-percent-expected.checksum: Added.
        * fast/replaced/maxwidth-percent-expected.png: Added.
        * fast/replaced/maxwidth-percent-expected.txt:
        * fast/replaced/maxwidth-pxs-expected.checksum: Added.
        * fast/replaced/maxwidth-pxs-expected.png: Added.
        * fast/replaced/maxwidth-pxs-expected.txt:
        * fast/replaced/minheight-percent-expected.checksum: Added.
        * fast/replaced/minheight-percent-expected.png: Added.
        * fast/replaced/minheight-percent-expected.txt:
        * fast/replaced/minheight-pxs-expected.checksum: Added.
        * fast/replaced/minheight-pxs-expected.png: Added.
        * fast/replaced/minheight-pxs-expected.txt:
        * fast/replaced/minwidth-percent-expected.checksum: Added.
        * fast/replaced/minwidth-percent-expected.png: Added.
        * fast/replaced/minwidth-percent-expected.txt:
        * fast/replaced/minwidth-pxs-expected.checksum: Added.
        * fast/replaced/minwidth-pxs-expected.png: Added.
        * fast/replaced/minwidth-pxs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
antti [Sat, 25 Feb 2006 03:48:12 +0000 (03:48 +0000)]
    Reviewed by Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7440
        Floats not positioned correctly

        * fast/block/float/multiple-float-positioning-expected.checksum: Added.
        * fast/block/float/multiple-float-positioning-expected.png: Added.
        * fast/block/float/multiple-float-positioning-expected.txt: Added.
        * fast/block/float/multiple-float-positioning.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
antti [Sat, 25 Feb 2006 03:46:19 +0000 (03:46 +0000)]
    Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7440
        Floats not positioned correctly

        Test: fast/block/float/multiple-float-positioning.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionNewFloats): Correct iteration of the float list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Sat, 25 Feb 2006 02:57:03 +0000 (02:57 +0000)]
LayoutTests:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
        Selection extends beyond focus ring for some contentEditable divs

        * editing/selection/extend-by-word-002-expected.checksum:
        * editing/selection/extend-by-word-002-expected.png:
        * editing/selection/select-all-001-expected.checksum:
        * editing/selection/select-all-001-expected.png:
        * editing/selection/select-all-002-expected.checksum:
        * editing/selection/select-all-002-expected.png:

WebCore:

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
        Selection extends beyond focus ring for some contentEditable divs

        Reviewed by justin

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelectionRoot): Have root editable elements paint their
        own selection gaps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Sat, 25 Feb 2006 02:25:47 +0000 (02:25 +0000)]
LayoutTests:

        - test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com
          in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)

        * fast/dom/Window/redirect-with-timer.html: Added.
        * fast/dom/Window/redirect-with-timer-expected.txt: Added.

WebCore:

        Reviewed by Maciej.

        - fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com
          in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)

        Test: fast/dom/Window/redirect-with-timer.html

        * platform/Timer.h: Made isActive no longer inline. Added inHeap function.
        * platform/Timer.cpp: Changed assertions to use inHeap function for clarity.
        (WebCore::TimerBase::isActive): Return true for timers that are ready to fire.
        They have a next fire time of 0, but they should still be considered active.
        (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new
        rule is that timers with a next fire time of 0 are not in the heap, and all other
        timers are.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Sat, 25 Feb 2006 01:07:53 +0000 (01:07 +0000)]
LayoutTests:

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
        caret does not display at the end of some lines in contenteditable divs

        Reviewed by justin

        * editing/deleting/delete-block-merge-contents-018-expected.txt:
        * editing/deleting/delete-block-merge-contents-021-expected.txt:
        * editing/deleting/delete-line-end-ws-001-expected.txt:
        * editing/deleting/delete-line-end-ws-002-expected.txt:
        * editing/deleting/forward-delete-expected.txt:
        * editing/execCommand/boldSelection-expected.txt:
        * editing/execCommand/italicizeByCharacter-expected.txt:
        * editing/execCommand/modifyForeColorByCharacter-expected.txt:
        * editing/execCommand/print-expected.txt:
        * editing/execCommand/selectAll-expected.txt:
        * editing/execCommand/strikethroughSelection-expected.txt:
        * editing/inserting/insert-div-019-expected.txt:
        * editing/inserting/insert-div-027-expected.txt:
        * editing/inserting/typing-003-expected.txt:
        * editing/pasteboard/paste-text-012-expected.txt:
        * editing/pasteboard/paste-text-013-expected.txt:
        * editing/pasteboard/paste-text-014-expected.txt:
        * editing/selection/extend-by-character-003-expected.txt:
        * editing/selection/extend-by-character-005-expected.txt:
        * editing/selection/extend-by-word-002-expected.checksum:
        * editing/selection/extend-by-word-002-expected.png:
        * editing/selection/extend-by-word-002-expected.txt:
        * editing/selection/move-by-character-003-expected.txt:
        * editing/selection/move-by-character-005-expected.txt:
        * editing/selection/select-all-001-expected.txt:
        * editing/selection/select-all-002-expected.checksum:
        * editing/selection/select-all-002-expected.png:
        * editing/selection/select-all-002-expected.txt:
        * editing/selection/select-all-003-expected.txt:
        * editing/style/create-block-for-style-001-expected.txt:
        * editing/style/create-block-for-style-002-expected.txt:
        * editing/style/create-block-for-style-003-expected.txt:
        * editing/style/create-block-for-style-004-expected.txt:
        * editing/style/create-block-for-style-005-expected.txt:
        * editing/style/create-block-for-style-006-expected.txt:
        * editing/style/create-block-for-style-007-expected.txt:
        * editing/style/create-block-for-style-008-expected.txt:
        * editing/style/create-block-for-style-009-expected.txt:
        * editing/style/create-block-for-style-010-expected.txt:
        * editing/style/create-block-for-style-011-expected.txt:
        * editing/style/create-block-for-style-012-expected.txt:
        * editing/style/create-block-for-style-013-expected.txt:
        * editing/style/relative-font-size-change-001-expected.txt:
        * editing/style/relative-font-size-change-002-expected.txt:
        * editing/style/relative-font-size-change-003-expected.txt:
        * editing/style/relative-font-size-change-004-expected.txt:
        * fast/clip/outline-overflowClip-expected.txt:
        * fast/overflow/overflow-focus-ring-expected.checksum:
        * fast/overflow/overflow-focus-ring-expected.png:
        * fast/overflow/overflow-focus-ring-expected.txt:
        * fast/text/justified-text-rect-expected.checksum:
        * fast/text/justified-text-rect-expected.png:
        * fast/text/justified-text-rect-expected.txt:
        * fast/text/justified-text-rect.html:

WebCore:

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
        caret does not display at the end of some lines in contenteditable divs

        Reviewed by justin

        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::setContentEditable):
        * page/Frame.cpp:
        (WebCore::Frame::applyEditingStyleToElement):
        (WebCore::Frame::removeEditingStyleFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 22:48:37 +0000 (22:48 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Move dom_qname to QualifiedName and dom_atomicstringlist to AtomicStringList.

        * WebCore+SVG/KDOMHeaders.h:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/css_base.h:
        * dom/AtomicStringList.h: Added.
        (WebCore::AtomicStringList::AtomicStringList):
        * dom/QualifiedName.cpp: Added.
        * dom/QualifiedName.h: Added.
        * dom/dom_atomicstringlist.h: Removed.
        * dom/dom_elementimpl.h:
        * dom/dom_qname.cpp: Removed.
        * dom/dom_qname.h: Removed.
        * editing/RemoveNodeAttributeCommand.h:
        * editing/SetNodeAttributeCommand.h:
        * khtml/html/htmlnames.h:
        * khtml/html/htmltokenizer.h:
        * ksvg2/scripts/make_names.pl: update for new headers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 22:36:14 +0000 (22:36 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by beth.

        Made a few methods on frame pure virtual.
        Added a bunch of stub functions for win32 linking.

        * bridge/mac/MacFrame.h:
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::print):
        (WebCore::MacFrame::canUndo):
        (WebCore::MacFrame::canRedo):
        (WebCore::MacFrame::canPaste):
        * bridge/win/FrameWin.h:
        * page/Frame.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (QTextEdit::sizeWithColumnsAndRows):
        (QLineEdit::maxLength):
        (QPainter::drawEllipse):
        (QTextEdit::setLineHeight):
        (QPainter::beginTransparencyLayer):
        (QLineEdit::selectedText):
        (Widget::setIsSelected):
        (QPainter::paintingDisabled):
        (QFontMetrics::selectionRectForText):
        (QTextEdit::getCursorPosition):
        (QSlider::QSlider):
        (WebCore::crossCursor):
        (WebCore::handCursor):
        (WebCore::moveCursor):
        (WebCore::iBeamCursor):
        (WebCore::waitCursor):
        (WebCore::helpCursor):
        (WebCore::eastResizeCursor):
        (WebCore::northResizeCursor):
        (WebCore::northEastResizeCursor):
        (WebCore::northWestResizeCursor):
        (WebCore::southResizeCursor):
        (WebCore::southEastResizeCursor):
        (WebCore::southWestResizeCursor):
        (WebCore::westResizeCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Fri, 24 Feb 2006 22:07:43 +0000 (22:07 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        -tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

        * fast/replaced/maxheight-percent.html: Added.
        * fast/replaced/maxheight-pxs.html: Added.
        * fast/replaced/maxwidth-percent.html: Added.
        * fast/replaced/maxwidth-pxs.html: Added.
        * fast/replaced/minheight-percent.html: Added.
        * fast/replaced/minheight-pxs.html: Added.
        * fast/replaced/minwidth-percent.html: Added.
        * fast/replaced/minwidth-pxs.html: Added.
        * fast/replaced/resources/1x1-blue.png: Added.
        * fast/replaced/resources/square-blue-100x100.png: Added.

WebCore:

        Reviewed by Hyatt, tweaked and landed by ggaren.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
          max-height/max-width not resizing images with correct aspect ratio

        This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf)
        patch of http://bugs.kde.org/show_bug.cgi?id=120107 with the needed
        modifications to suit the Webcore tree.  Makes images respect min/max
        sizes and their intrinsic aspect ratios at the same time according to
        CSS 2.1 (http://www.w3.org/TR/CSS21/visudet.html#min-max-widths).

        Test: fast/replaced/maxheight-percent.html
        Test: fast/replaced/maxheight-pxs.html
        Test: fast/replaced/maxwidth-percent.html
        Test: fast/replaced/maxwidth-pxs.html
        Test: fast/replaced/minheight-percent.html
        Test: fast/replaced/minheight-pxs.html
        Test: fast/replaced/minwidth-percent.html
        Test: fast/replaced/minwidth-pxs.html

        * rendering/render_box.cpp:
        (WebCore::RenderBox::calcReplacedWidth):
        (WebCore::RenderBox::calcReplacedWidthUsing):
        (WebCore::RenderBox::calcReplacedHeight):
        (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly
        * rendering/render_image.cpp: Respect aspect ratios and calculate max/min
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcReplacedHeight):
        (WebCore::RenderImage::calcAspectRatioWidth): Added
        (WebCore::RenderImage::calcAspectRatioHeight): Added
        (WebCore::RenderImage::calcMinMaxWidth): Added
        * rendering/render_image.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - add missing resources for manual-tests/scrolling-nestedframesets.html
vicki [Fri, 24 Feb 2006 21:47:22 +0000 (21:47 +0000)]
    - add missing resources for manual-tests/scrolling-nestedframesets.html

        * manual-tests/resources/testframe-link_text.html: Added.
        * manual-tests/resources/testframeset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - test case for <rdar://problem/4394910> calling Javascript window.close...
vicki [Fri, 24 Feb 2006 21:31:37 +0000 (21:31 +0000)]
    - test case for <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event

        * manual-tests/onbeforeunload-close_with_javascript.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 21:25:04 +0000 (21:25 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Add Path stubs for Win32 build.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * platform/win/TemporaryLinkStubs.cpp:
        (Path::Path):
        (Path::~Path):
        (Path::operator=):
        (Path::contains):
        (Path::translate):
        (Path::boundingRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago In preparation for the elimination of QFont and QFontMetrics, rename methods...
hyatt [Fri, 24 Feb 2006 21:13:08 +0000 (21:13 +0000)]
    In preparation for the elimination of QFont and QFontMetrics, rename methods on RenderStyle.  htmlFont() becomes simply
        font().  The old font() method turns into qfont().  Also added a helper for obtaining the fontDescription() directly from
        the RenderStyle (without first obtaining the htmlFont()).

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMElement _font]):
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::attributedString):
        (WebCore::MacFrame::fontForSelection):
        (WebCore::MacFrame::fontAttributesForSelectionStart):
        * css/css_computedstyle.cpp:
        (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
        * css/css_valueimpl.cpp:
        (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::pseudoStyleForElement):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
        (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::recalcStyle):
        * editing/visible_text.cpp:
        (khtml::TextIterator::exitNode):
        * ksvg2/svg/SVGLengthImpl.cpp:
        (SVGLengthImpl::updateValue):
        * kwq/KWQAccObject.mm:
        (AXAttributeStringSetStyle):
        * rendering/InlineTextBox.cpp:
        (khtml::InlineTextBox::paint):
        (khtml::InlineTextBox::offsetForPosition):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::shouldUseMonospaceCache):
        (WebCore::RenderText::font):
        (WebCore::RenderText::width):
        (WebCore::RenderText::htmlFont):
        * rendering/bidi.cpp:
        (khtml::RenderBlock::tabWidth):
        (khtml::RenderBlock::checkLinesForTextOverflow):
        * rendering/render_br.cpp:
        (WebCore::RenderBR::lineHeight):
        * rendering/render_flexbox.cpp:
        (khtml::RenderFlexibleBox::layoutVerticalBox):
        * rendering/render_flow.cpp:
        (WebCore::RenderFlow::lineHeight):
        * rendering/render_form.cpp:
        (WebCore::RenderFormElement::setStyle):
        (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::paint):
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::paintDecorations):
        (WebCore::EllipsisBox::paint):
        * rendering/render_list.cpp:
        (RenderListItem::getAbsoluteRepaintRect):
        (RenderListMarker::paint):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::lineHeight):
        * rendering/render_object.h:
        (WebCore::RenderObject::font):
        * rendering/render_replaced.cpp:
        (WebCore::RenderWidget::setStyle):
        * rendering/render_style.h:
        (khtml::RenderStyle::font):
        (khtml::RenderStyle::fontDescription):
        (khtml::RenderStyle::qfont):
        * rendering/render_theme_mac.mm:
        (WebCore::RenderThemeMac::setFontFromControlSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Fri, 24 Feb 2006 19:49:06 +0000 (19:49 +0000)]
    Reviewed by Eric.

        - add link stubs for symbols only referenced from the link stubs file

        * platform/win/TemporaryLinkStubs.cpp:
        (KWQFileButton::focusPolicy):
        (QLineEdit::checksDescendantsForFocus):
        (KWQFileButton::baselinePosition):
        (QSlider::~QSlider):
        (QListBox::~QListBox):
        (KWQFileButton::frameGeometry):
        (KWQFileButton::~KWQFileButton):
        (QTextEdit::focusPolicy):
        (QSlider::focusPolicy):
        (QListBox::setEnabled):
        (QListBox::checksDescendantsForFocus):
        (QListBox::focusPolicy):
        (QLineEdit::baselinePosition):
        (QSlider::sizeHint):
        (QLineEdit::~QLineEdit):
        (QTextEdit::~QTextEdit):
        (QTextEdit::checksDescendantsForFocus):
        (QLineEdit::focusPolicy):
        (QScrollBar::~QScrollBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Eric.
mjs [Fri, 24 Feb 2006 19:44:19 +0000 (19:44 +0000)]
    Rubber stamped by Eric.

        - fix up font.h inclues to be Font.h to fix build.

        * css/css_computedstyle.cpp:
        * css/css_valueimpl.cpp:
        * platform/Font.cpp:
        * rendering/render_style.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 19:28:31 +0000 (19:28 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix mac build by changing constants to an enum.

        * khtml/dom/dom2_events.h:
        (DOM::KeyboardEvent::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 19:19:22 +0000 (19:19 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Make DumpRenderTree link against icu.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move rendering/font to platform/Font.
hyatt [Fri, 24 Feb 2006 19:15:25 +0000 (19:15 +0000)]
    Move rendering/font to platform/Font.

        Reviewed by mjs

        * WebCore.xcodeproj/project.pbxproj:
        * css/cssstyleselector.cpp:
        * platform/Font.cpp: Added.
        * platform/Font.h: Added.
        * rendering/font.cpp: Removed.
        * rendering/font.h: Removed.
        * rendering/render_theme_mac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 19:11:41 +0000 (19:11 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Remove delcarations causing duplicate symbols on win32.

        * khtml/dom/dom2_events.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 19:02:13 +0000 (19:02 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        * bridge/win/FrameWin.cpp: fix line endings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 18:54:07 +0000 (18:54 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Make DumpRenderTree link against libxml, etc.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 18:36:30 +0000 (18:36 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by beth.

        Removed WebCore:: prefixes added using namespace WebCore, fixes win32 build.

        * platform/win/TemporaryLinkStubs.cpp:
        (QPainter::save):
        (Widget::enableFlushDrawing):
        (QPainter::drawHighlightForText):
        (QTextEdit::textWithHardLineBreaks):
        (QPainter::setPen):
        (QPainter::selectedTextBackgroundColor):
        (QPainter::fontMetrics):
        (Widget::show):
        (QLineEdit::setWritingDirection):
        (KWQFileButton::sizeForCharacterWidth):
        (QTextEdit::sizeWithColumnsAndRows):
        (iBeamCursor):
        (QPainter::misspellingLineThickness):
        (westResizeCursor):
        (Widget::isEnabled):
        (northWestResizeCursor):
        (QPainter::drawEllipse):
        (southWestResizeCursor):
        (Widget::focusPolicy):
        (waitCursor):
        (QPainter::endTransparencyLayer):
        (ScrollView::addChild):
        (Widget::~Widget):
        (QListBox::sizeForNumberOfLines):
        (FrameView::updateBorder):
        (QPainter::drawLineForText):
        (QPainter::QPainter):
        (QComboBox::focusPolicy):
        (QPainter::drawImageAtPoint):
        (QPainter::clearShadow):
        (eastResizeCursor):
        (QFontMetrics::boundingRect):
        (QPainter::beginTransparencyLayer):
        (northEastResizeCursor):
        (Widget::frameGeometry):
        (QPainter::addFocusRingRect):
        (QPainter::restore):
        (Widget::setEnabled):
        (QPainter::font):
        (QPainter::pen):
        (crossCursor):
        (Widget::setIsSelected):
        (handCursor):
        (QLineEdit::text):
        (Widget::unlockDrawingFocus):
        (QPainter::paintingDisabled):
        (northResizeCursor):
        (Widget::lockDrawingFocus):
        (QPainter::drawLine):
        (QPainter::setBrush):
        (QPainter::drawText):
        (QLineEdit::sizeForCharacterWidth):
        (Cursor::~Cursor):
        (QFontMetrics::selectionRectForText):
        (southResizeCursor):
        (moveCursor):
        (FrameView::isFrameView):
        (helpCursor):
        (QTextEdit::setWritingDirection):
        (Widget::setDrawingAlpha):
        (southEastResizeCursor):
        (QPainter::drawScaledAndTiledImage):
        (QPainter::drawImage):
        (QComboBox::setWritingDirection):
        (QComboBox::sizeHint):
        (QPainter::drawRect):
        (QPainter::drawTiledImage):
        (QPainter::clearFocusRing):
        (Widget::Widget):
        (QTextEdit::text):
        (QPainter::drawImageInRect):
        (Widget::disableFlushDrawing):
        (QPainter::initFocusRing):
        (QPainter::drawLineForMisspelling):
        (QComboBox::frameGeometry):
        (QListBox::setWritingDirection):
        (ScrollView::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
darin [Fri, 24 Feb 2006 16:24:58 +0000 (16:24 +0000)]
    Reviewed by Hyatt.

        - moved QScrollView from kwq to platform directory

        * kwq/KWQScrollView.h: Removed.
        * kwq/KWQScrollView.mm: Removed.

        * platform/ScrollBarMode.h: Added. Just the enum for scroll bar mode.
        * platform/ScrollView.h: Added. The rest of the former QScrollView.
        * platform/mac/ScrollViewMac.mm: Added.

        * WebCore.xcodeproj/project.pbxproj: Updated.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
        * platform/win/TemporaryLinkStubs.cpp: Updated.

        * bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame):
        * khtml/html/html_baseimpl.cpp:
        (WebCore::HTMLFrameElementImpl::init):
        (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
        * page/Frame.cpp: (WebCore::Frame::scrollbarsVisible):
        Changed scrolling constants to use new names.

        * khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodySetter):
        Use FrameView instead of QScrollView for a local variable.

        * khtml/html/html_baseimpl.h: Use ScrollBarMode instead of
        QScrollView::ScrollBarMode.

        * kwq/KWQListBox.h: Use WebCore::ScrollView instead of
        QScrollView and WebCore::ScrollBarMode instead of QScrollView::ScrollBarMode.
        * kwq/KWQTextEdit.h: Ditto.
        * kwq/KWQTextEdit.mm:
        (QTextEdit::setScrollBarModes): Ditto.
        (QTextEdit::focusPolicy): Ditto.

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate): Use ScrollBarMode
        instead of QScrollView::ScrollBarMode.
        (WebCore::FrameView::FrameView): Remove mention of QScrollView.
        (WebCore::FrameView::resetScrollBars): Rename QScrollView to ScrollView.
        (WebCore::FrameView::applyOverflowToViewport): Use newly-named constants.
        (WebCore::FrameView::layout): Ditto.
        (WebCore::FrameView::setScrollBarsMode): Rename QScrollView to ScrollView.
        (WebCore::FrameView::setVScrollBarMode): Ditto.
        (WebCore::FrameView::setHScrollBarMode): Ditto.
        (WebCore::FrameView::restoreScrollBar): Ditto.

        * platform/mac/MouseEventMac.mm: (WebCore::positionForEvent): Fixed comment.
        * platform/mac/WheelEventMac.mm: (WebCore::positionForEvent): Ditto.
        * platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Ditto.

        * rendering/render_form.cpp: (WebCore::RenderTextArea::setStyle):
        Use ScrollBarMode instead of QScrollView::ScrollBarMode, and new constants.
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::userResize): Changed to use an IntRect to pass to
        updateContents so we can remove the overload.
        (WebCore::RenderPart::updateWidgetPosition): Remove unnecessary of QScrollView.

        * rendering/render_layer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible): Use FrameView instead of QScrollView.
        (WebCore::RenderLayer::setHasHorizontalScrollbar): Ditto.
        (WebCore::RenderLayer::setHasVerticalScrollbar): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Mitz Pettel <opendarwin.org@mitzpettel.com>
andersca [Fri, 24 Feb 2006 12:59:21 +0000 (12:59 +0000)]
2006-02-24  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by Anders.

        Prevent rendering to the offscreen window. -[NSWindow displayIfNeeded] was
        getting called from the run loop, making the view render each test and thus slowing
        down the tests.

        * DumpRenderTree/DumpRenderTree.m:
        (main): Set the offscreen window to not autodisplay.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 09:14:17 +0000 (09:14 +0000)]
2006-02-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by anders.

        Fix the win32 build.

        * page/Frame.cpp:
        (WebCore::Frame::adjustPageHeight):
        (WebCore::Frame::forceLayoutWithPageWidthRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Fri, 24 Feb 2006 09:10:54 +0000 (09:10 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7435
          Add Ian Hickson's XMLHttpRequest tests

        * http/conf/httpd.conf: Enable send-as-is handler, required by the tests.
        * http/tests/xmlhttprequest/web-apps: Added (recursively).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename FontDef to FontDescription and move it into the platform directory.
hyatt [Fri, 24 Feb 2006 08:01:42 +0000 (08:01 +0000)]
    Rename FontDef to FontDescription and move it into the platform directory.

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::attributedString):
        * css/css_computedstyle.cpp:
        (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
        * css/css_valueimpl.cpp:
        (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
        (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
        (WebCore::CSSStyleSelector::setFontSize):
        * css/cssstyleselector.h:
        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::recalcStyle):
        * editing/visible_text.cpp:
        (khtml::TextIterator::exitNode):
        * platform/FontDescription.h: Added.
        (WebCore::FontDescription::):
        (WebCore::FontDescription::FontDescription):
        (WebCore::FontDescription::operator!=):
        (WebCore::FontDescription::family):
        (WebCore::FontDescription::firstFamily):
        (WebCore::FontDescription::specifiedSize):
        (WebCore::FontDescription::computedSize):
        (WebCore::FontDescription::italic):
        (WebCore::FontDescription::computedPixelSize):
        (WebCore::FontDescription::smallCaps):
        (WebCore::FontDescription::isAbsoluteSize):
        (WebCore::FontDescription::weight):
        (WebCore::FontDescription::genericFamily):
        (WebCore::FontDescription::usePrinterFont):
        (WebCore::FontDescription::setFamily):
        (WebCore::FontDescription::setComputedSize):
        (WebCore::FontDescription::setSpecifiedSize):
        (WebCore::FontDescription::setItalic):
        (WebCore::FontDescription::setSmallCaps):
        (WebCore::FontDescription::setIsAbsoluteSize):
        (WebCore::FontDescription::setWeight):
        (WebCore::FontDescription::setGenericFamily):
        (WebCore::FontDescription::setUsePrinterFont):
        (WebCore::FontDescription::operator==):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::widthFromCache):
        (WebCore::RenderText::trimmedMinMaxWidth):
        * rendering/bidi.cpp:
        (khtml::RenderBlock::computeHorizontalPositionsForLine):
        * rendering/font.cpp:
        (khtml::Font::selectionRectForText):
        (khtml::Font::drawHighlightForText):
        (khtml::Font::drawText):
        (khtml::Font::update):
        * rendering/font.h:
        (WebCore::Font::Font):
        (WebCore::Font::operator==):
        (WebCore::Font::fontDescription):
        (WebCore::Font::isSmallCaps):
        (WebCore::Font::wordSpacing):
        (WebCore::Font::floatWidth):
        (WebCore::Font::checkSelectionPoint):
        (WebCore::Font::width):
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        * rendering/render_list.cpp:
        (RenderListItem::getAbsoluteRepaintRect):
        * rendering/render_style.h:
        (khtml::RenderStyle::wordSpacing):
        (khtml::RenderStyle::letterSpacing):
        (khtml::RenderStyle::setFontDescription):
        (khtml::RenderStyle::setWordSpacing):
        (khtml::RenderStyle::setLetterSpacing):
        * rendering/render_theme_mac.mm:
        (WebCore::RenderThemeMac::setFontFromControlSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix build by making some pointless changes to files that Xcode doesn't
mjs [Fri, 24 Feb 2006 07:16:15 +0000 (07:16 +0000)]
    - fix build by making some pointless changes to files that Xcode doesn't
        rebuild otherwise

        * bindings/js/JSDOMCore.cpp:
        * bindings/js/JSDOMEvents.cpp:
        * dom/Element.idl:
        * dom/WheelEvent.idl:

        - add -Y 3 flag to linking; this makes the linker say what files reference
        unresolved symbols

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix buildbot failure
darin [Fri, 24 Feb 2006 06:29:35 +0000 (06:29 +0000)]
    - try to fix buildbot failure

        * bindings/c/c_utility.cpp: Touch this file, which seems to not have been
        recompiled after additional inlining was introduced (Xcode bug?).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix Windows build
darin [Fri, 24 Feb 2006 05:37:14 +0000 (05:37 +0000)]
    - try to fix Windows build

        * platform/win/TemporaryLinkStubs.cpp: Removed childX/Y stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix Windows build
darin [Fri, 24 Feb 2006 05:32:56 +0000 (05:32 +0000)]
    - fix Windows build

        * platform/win/TemporaryLinkStubs.cpp: Removed QPalette-related stubs

        - remove unused forwarding headers

        * ForwardingHeaders/kurl.h: Removed.
        * ForwardingHeaders/qlist.h: Removed.
        * ForwardingHeaders/qregion.h: Removed.
        * ForwardingHeaders/qsortedlist.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Fri, 24 Feb 2006 05:23:57 +0000 (05:23 +0000)]
    Reviewed by Maciej.

        - removed QPalette, QRegion, QPrinter
        - added Path to replace QRegion
        - removed unused QScrollView functions

        * ForwardingHeaders/qpalette.h: Removed.
        * kwq/KWQPalette.h: Removed.
        * kwq/KWQPalette.mm: Removed.
        * kwq/KWQPrinter.h: Removed.
        * kwq/KWQRegion.cpp: Removed.
        * kwq/KWQRegion.h: Removed.

        * platform/Path.h: Added. Replaces QRegion.
        * platform/cg: Added.
        * platform/cg/PathCG.cpp: Added.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * bridge/mac/MacFrame.mm: Removed use of KWQPrinter.h.
        (WebCore::MacFrame::khtmlMouseMoveEvent): Removed use of viewport().
        * bridge/mac/WebCoreFrameBridge.mm: Removed use of KWQPrinter.h.
        * khtml/html/html_imageimpl.cpp:
        (WebCore::HTMLAreaElementImpl::getRect): Replaced QRegion with Path.
        (WebCore::HTMLAreaElementImpl::getRegion): Ditto.
        * khtml/html/html_imageimpl.h: Ditto.
        * kwq/KWQPainter.mm: Removed use of QRegion.
        * page/Frame.cpp: (WebCore::Frame::~Frame): Removed use of viewport().
        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView): Ditto.
        (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
        * rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Ditto.
        * rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Ditto.

        * kwq/KWQScrollView.h: Removed viewport(), hasVerticalScrollBar(),
        hasHorizontalScrollBar(), childX(), childY().
        * kwq/KWQScrollView.mm: Ditto.

        * rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
        Removed use of QPalette that always yields white.
        * rendering/render_canvas.cpp: (WebCore::RenderCanvas::paintBoxDecorations):
        Ditto.

        * platform/Widget.h:
        * platform/mac/WidgetMac.mm: Removed palette() and setPalette().

        * kwq/KWQLineEdit.h: Replaced setPalette with setColors.
        * kwq/KWQLineEdit.mm: (QLineEdit::setColors): Replaced setPalette.
        * kwq/KWQTextEdit.h: Ditto.
        * kwq/KWQTextEdit.mm: (QTextEdit::setColors): Ditto.

        * rendering/render_form.cpp:
        (WebCore::RenderFormElement::updateFromElement): Removed call to setPalette.
        (WebCore::RenderLineEdit::updateFromElement): Added call to setColors.
        (WebCore::RenderTextArea::updateFromElement): Ditto.

        * rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
        Removed use of childX and childY functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Fri, 24 Feb 2006 05:10:18 +0000 (05:10 +0000)]
    Reviewed by Darin.

        - add KURL to windows build and fix its compile issues
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7439

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * platform/KURL.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix build (header name changed)
mjs [Fri, 24 Feb 2006 05:01:51 +0000 (05:01 +0000)]
    - fix build (header name changed)

        * platform/mac/KURLMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Fri, 24 Feb 2006 04:34:29 +0000 (04:34 +0000)]
    Reviewed by Eric.

        - add temporary stubs that call abort() for functions only called from render and editing code
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7429

        This gets rid of a couple hundred link errors.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * kwq/KWQFontMetrics.h:
        * kwq/KWQSignal.h:
        (KWQSignal::KWQSignal):
        * platform/win/TemporaryLinkStubs.cpp: Added.
        (notImplemented):
        (QLineEdit::selectAll):
        (WebCore::QPainter::save):
        (WebCore::Widget::enableFlushDrawing):
        (WebCore::QPainter::drawHighlightForText):
        (QFont::setPrinterFont):
        (QTextEdit::textWithHardLineBreaks):
        (QLineEdit::cursorPosition):
        (WebCore::QPainter::setPen):
        (WebCore::QPainter::selectedTextBackgroundColor):
        (WebCore::QPainter::fontMetrics):
        (WebCore::Widget::show):
        (QFont::setItalic):
        (QSlider::setValue):
        (QLineEdit::addSearchResult):
        (KWQFileButton::click):
        (QLineEdit::setWritingDirection):
        (KWQFileButton::sizeForCharacterWidth):
        (QTextEdit::sizeWithColumnsAndRows):
        (WebCore::iBeamCursor):
        (QComboBox::clear):
        (WebCore::QPainter::misspellingLineThickness):
        (QLineEdit::maxLength):
        (WebCore::westResizeCursor):
        (WebCore::Widget::isEnabled):
        (WebCore::northWestResizeCursor):
        (QTextEdit::selectionEnd):
        (QFont::determinePitch):
        (QTextEdit::setScrollBarModes):
        (WebCore::QPainter::drawEllipse):
        (WebCore::southWestResizeCursor):
        (QTextEdit::setReadOnly):
        (QListBox::appendItem):
        (WebCore::Widget::focusPolicy):
        (QTextEdit::selectAll):
        (WebCore::waitCursor):
        (WebCore::QPainter::endTransparencyLayer):
        (QScrollView::addChild):
        (QTextEdit::setDisabled):
        (QScrollBar::scroll):
        (WebCore::Widget::~Widget):
        (QListBox::sizeForNumberOfLines):
        (QScrollView::resizeContents):
        (QLineEdit::selectionStart):
        (QLineEdit::QLineEdit):
        (WebCore::FrameView::updateBorder):
        (QLineEdit::hasSelectedText):
        (QListBox::doneAppendingItems):
        (QScrollView::inWindow):
        (QScrollBar::setValue):
        (QTextEdit::hasSelectedText):
        (QTextEdit::selectionStart):
        (QFont::setWeight):
        (QScrollView::scrollXOffset):
        (QListBox::isSelected):
        (QLineEdit::setReadOnly):
        (WebCore::QPainter::drawLineForText):
        (QObject::disconnect):
        (WebCore::QPainter::QPainter):
        (QComboBox::~QComboBox):
        (QComboBox::focusPolicy):
        (WebCore::QPainter::drawImageAtPoint):
        (WebCore::QPainter::clearShadow):
        (QTextEdit::setLineHeight):
        (QMouseEvent::QMouseEvent):
        (WebCore::eastResizeCursor):
        (QScrollBar::setKnobProportion):
        (QFontMetrics::boundingRect):
        (QTextEdit::setSelectionStart):
        (WebCore::QPainter::beginTransparencyLayer):
        (WebCore::northEastResizeCursor):
        (WebCore::Widget::frameGeometry):
        (QListBox::setSelected):
        (WebCore::QPainter::addFocusRingRect):
        (QTextEdit::setCursorPosition):
        (WebCore::QPainter::restore):
        (QFontMetrics::width):
        (WebCore::Widget::setEnabled):
        (QTextEdit::setSelectionEnd):
        (QComboBox::populate):
        (QScrollView::setStaticBackground):
        (WebCore::QPainter::font):
        (QTextEdit::setAlignment):
        (QLineEdit::setCursorPosition):
        (WebCore::Widget::palette):
        (WebCore::QPainter::pen):
        (QFontMetrics::descent):
        (QListBox::QListBox):
        (QFontMetrics::ascent):
        (QLineEdit::selectedText):
        (WebCore::crossCursor):
        (WebCore::Widget::setIsSelected):
        (WebCore::handCursor):
        (QLineEdit::text):
        (WebCore::Widget::unlockDrawingFocus):
        (QLineEdit::setLiveSearch):
        (WebCore::QPainter::paintingDisabled):
        (WebCore::northResizeCursor):
        (QComboBox::QComboBox):
        (QSlider::setMaxValue):
        (WebCore::Widget::lockDrawingFocus):
        (WebCore::QPainter::drawLine):
        (WebCore::QPainter::setBrush):
        (QTextEdit::setSelectionRange):
        (WebCore::QPainter::drawText):
        (QScrollView::scrollPointRecursively):
        (QLineEdit::sizeForCharacterWidth):
        (WebCore::Cursor::~Cursor):
        (QFontMetrics::selectionRectForText):
        (WebCore::southResizeCursor):
        (QScrollView::suppressScrollBars):
        (QFontMetrics::checkSelectionPoint):
        (QTextEdit::getCursorPosition):
        (WebCore::moveCursor):
        (WebCore::FrameView::isFrameView):
        (QScrollBar::setSteps):
        (QLineEdit::setMaxLength):
        (QComboBox::baselinePosition):
        (QComboBox::appendItem):
        (WebCore::helpCursor):
        (QTextEdit::setWritingDirection):
        (WebCore::Widget::setDrawingAlpha):
        (QSlider::QSlider):
        (WebCore::southEastResizeCursor):
        (QScrollView::setVScrollBarMode):
        (WebCore::QPainter::drawScaledAndTiledImage):
        (QScrollView::scrollYOffset):
        (WebCore::QPainter::drawImage):
        (QComboBox::setCurrentItem):
        (QFontMetrics::height):
        (QComboBox::setWritingDirection):
        (QScrollView::setScrollBarsMode):
        (QComboBox::sizeHint):
        (WebCore::QPainter::drawRect):
        (QFont::setPixelSize):
        (QLineEdit::setSelection):
        (QLineEdit::setMaxResults):
        (QListBox::clear):
        (QLineEdit::edited):
        (WebCore::QPainter::drawTiledImage):
        (WebCore::QPainter::clearFocusRing):
        (WebCore::Widget::Widget):
        (QTextEdit::text):
        (WebCore::QPainter::drawImageInRect):
        (WebCore::Widget::disableFlushDrawing):
        (WebCore::QPainter::initFocusRing):
        (QSlider::setMinValue):
        (QTextEdit::setWordWrap):
        (WebCore::QPainter::drawLineForMisspelling):
        (QSlider::value):
        (QListBox::setSelectionMode):
        (QFontMetrics::lineSpacing):
        (QLineEdit::setEdited):
        (QComboBox::frameGeometry):
        (QListBox::setWritingDirection):
        (QLineEdit::setAlignment):
        (QScrollView::updateContents):
        (QFontMetrics::floatWidth):
        (QScrollView::setHScrollBarMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Fri, 24 Feb 2006 03:52:05 +0000 (03:52 +0000)]
    Reviewed by Eric.

        - Move KURL from kwq to platform, make portable
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7437

        * WebCore.xcodeproj/project.pbxproj:
        * css/css_ruleimpl.cpp:
        * css/cssparser.cpp:
        * css/cssstyleselector.cpp:
        * dom/DocumentImpl.h:
        * khtml/html/html_baseimpl.cpp:
        * khtml/html/html_documentimpl.cpp:
        * khtml/html/html_headimpl.cpp:
        * khtml/xbl/xbl_binding.cpp:
        * ksvg2/svg/SVGDocumentImpl.cpp:
        * kwq/KWQTextCodec.cpp:
        (QTextCodec::codecForName):
        (QTextCodec::utf8Codec):
        (QTextCodec::codecForNameEightBitOnly):
        (QTextCodec::codecForLocale):
        (QTextCodec::name):
        (QTextCodec::makeDecoder):
        * kwq/KWQTextCodec.h:
        * loader/CachedObject.cpp:
        * loader/DocLoader.cpp:
        * page/Frame.h:
        * platform/KURL.cpp: Added.
        (KURL::decode_string):
        (encodeRelativeString):
        * platform/KURL.h: Added.
        * platform/mac/KURLMac.mm: Added.
        (KURL::getNSURL):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin [Fri, 24 Feb 2006 03:08:41 +0000 (03:08 +0000)]
    Reviewed by John Sullivan.

        - moved QMouseEvent, QKeyEvent, QWheelEvent, and "Foundation extras"
          from kwq to platform directory
        - moved history function from kwq to bridge directory
        - eliminated QEvent, MousePressEvent, MouseDoubleClickEvent, MouseMoveEvent,
          MoveReleaseEvent, and DrawContents classes
        - merged NodeImpl::MouseEvent and the MouseEvent from khtml_events.h into
          a single class in the page directory
        - broke khtmllayout.h out into a file for the Length structure in the css
          directory and a file for the GapRects structure in the rendering directory
        - redid the Length structure to work more portably by not relying on bitfield
          layout and improve the names to no longer explicitly mention "width"
        - reduced use of QGuardedPtr and other uses of the QObject "destroyed" signal

        * ForwardingHeaders/kparts: Removed.
        * ForwardingHeaders/qevent.h: Removed.
        * khtml/khtml_events.cpp: Removed.
        * khtml/khtml_events.h: Removed.
        * khtml/misc/khtmllayout.h: Removed.
        * kwq/KWQEvent.h: Removed.
        * kwq/KWQEvent.mm: Removed.
        * kwq/KWQFoundationExtras.h: Removed.
        * kwq/KWQKHistoryProvider.mm: Removed.
        * kwq/KWQKPartsHistoryProvider.h: Removed.

        * bridge/History.h: Added.
        * bridge/mac/HistoryMac.mm: Added.
        * css/Length.h: Added.
        * page/MouseEventWithHitTestResults.h: Added.
        * platform/KeyEvent.h: Added.
        * platform/MouseEvent.h: Added.
        * platform/WheelEvent.h: Added.
        * platform/mac/FoundationExtras.h: Added.
        * platform/mac/KeyEventMac.mm: Added.
        * platform/mac/MouseEventMac.mm: Added.
        * platform/mac/WheelEventMac.mm: Added.
        * rendering/GapRects.h: Added.

        * WebCore.xcodeproj/project.pbxproj: Updated for above changes.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.

        * bridge/mac/MacFrame.h: Removed unused parameters from urlSelected functions.
        Replaced MouseEvent, MousePressEvent, MouseMoveEvent, and MouseReleaseEvent
        with MouseEventWithHitTestResults.
        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::urlSelected): Removed unused parameters.
        (WebCore::MacFrame::wheelEvent): Changed to use WheelEvent.
        (WebCore::MacFrame::keyEvent): Changed to use KeyEvent.
        (WebCore::MacFrame::khtmlMousePressEvent): Changed parameter type.
        (WebCore::MacFrame::khtmlMouseMoveEvent): Ditto.
        (WebCore::MacFrame::khtmlMouseReleaseEvent): Ditto.
        (WebCore::MacFrame::passSubframeEventToSubframe): Ditto.
        (WebCore::MacFrame::mouseDown): Changed to use MouseEvent.
        (WebCore::MacFrame::mouseDragged): Ditto.
        (WebCore::MacFrame::mouseUp): Ditto.
        (WebCore::MacFrame::mouseMoved): Ditto.
        (WebCore::MacFrame::sendContextMenuEvent): Ditto.

        * css/csshelper.h: Removed a bunch of unused declarations.

        * dom/DocumentImpl.h:
        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::prepareMouseEvent): Changed to take a MouseEvent
        and return a MouseEventWithHitTestResults.
        (WebCore::DocumentImpl::defaultEventHandler): Changed to use KeyEvent.

        * dom/NodeImpl.h: Removed NodeImpl::MouseEvent and NodeImpl::MouseEventType.
        * dom/NodeImpl.cpp:
        (WebCore::NodeImpl::dispatchMouseEvent): Changed to always get the type and
        detail values from the caller, never from the event. Changed to use MouseEvent.
        (WebCore::NodeImpl::dispatchKeyEvent): Changed to use KeyEvent.
        (WebCore::NodeImpl::dispatchWheelEvent): Changed to use WheelEvent.

        * dom/dom2_eventsimpl.h:
        * dom/dom2_eventsimpl.cpp:
        (WebCore::KeyboardEventImpl::KeyboardEventImpl): Changed to use KeyEvent.
        (WebCore::KeyboardEventImpl::charCode): Ditto.

        * dom/dom_elementimpl.h: Removed unused mouseEventHandler function.

        * khtml/ecma/domparser.h: Use RefPtr instead of QGuardedPtr to hold the reference
        to the document.

        * khtml/ecma/kjs_proxy.h: (WebCore::KJSProxyImpl::haveInterpreter): Added. For
        use in the Frame destructor so we can get an existing KJS::Window object without
        creating a new interpreter and window object.

        * khtml/ecma/kjs_window.h: Merged WindowQObject into Window. Changed all the
        guarded pointers to Frame to use plain old pointers that are cleared by the
        Frame explicitly (by the function disconnectFrame). Made the pointers to all
        the sub-objects of KJS::Window be mutable so we don't have to const_cast in
        the functions to get (and lazily create) them.
        * khtml/ecma/kjs_window.cpp:
        (KJS::DOMWindowTimer::DOMWindowTimer): Use Window* instead of WindowQObject*.
        (KJS::History::disconnectFrame): Added. Clears m_frame.
        (KJS::FrameArray::disconnectFrame): Added. Clears m_frame.
        (KJS::Window::Window): Removed code to create a WindowQObject.
        (KJS::Window::~Window): Removed code to delete a WindowQObject.
        (KJS::Window::location): Remove now-unneeded const_cast.
        (KJS::Window::selection): Ditto.
        (KJS::Window::locationbar): Ditto.
        (KJS::Window::menubar): Ditto.
        (KJS::Window::personalbar): Ditto.
        (KJS::Window::statusbar): Ditto.
        (KJS::Window::toolbar): Ditto.
        (KJS::Window::scrollbars): Ditto.
        (KJS::Window::getValueProperty): Update since m_frame is now a raw pointer.
        (KJS::Window::getOwnPropertySlot): Ditto.
        (KJS::Window::toBoolean): Ditto.
        (KJS::Window::scheduleClose): Remove assert that WindowQObject* is not null.
        (KJS::Window::isSafeScript): Update since m_frame is now a raw pointer.
        (KJS::Window::clear): Remove code to delete a WindowQObject. Added a call
        to clearAllTimeouts instead.
        (KJS::Window::clearAllTimeouts): Added. Does equivalent of the WindowQObject
        destructor.
        (KJS::Window::installTimeout): Moved to Window from WindowQObject.
        (KJS::Window::pauseTimeouts): Ditto.
        (KJS::Window::resumeTimeouts): Ditto.
        (KJS::Window::clearTimeout): Ditto.
        (KJS::Window::timerFired): Ditto.
        (KJS::Window::disconnectFrame): Added. Sets all the frame pointers to 0.
        (KJS::FrameArray::getOwnPropertySlot): Update since m_frame is now a raw pointer.
        (KJS::Location::getOwnPropertySlot): Ditto.
        (KJS::Location::put): Ditto.
        (KJS::Selection::getOwnPropertySlot): Ditto.
        (KJS::BarInfo::getOwnPropertySlot): Ditto.

        * khtml/html/html_baseimpl.h: Forward-declare Length instead of including khtmllayout.h.
        * khtml/html/html_imageimpl.h: Ditto.

        * khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
        Changed to use KeyEvent and removed the code to extract the button and state from the
        DOM even to pass to urlSelected.
        * ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): Ditto.

        * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::timerFired): Change to use
        a RefPtr instead of a QGuardedPtr.

        * khtml/misc/helper.h:
        * khtml/misc/helper.cpp: Removed printpainter and setPrintPainter.

        * ksvg2/svg/SVGDocumentImpl.h:
        * ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchKeyEvent):
        Change to use KeyEvent.

        * kwq/KWQComboBox.mm:
        (-[KWQPopUpButton becomeFirstResponder]):
        (-[KWQPopUpButton resignFirstResponder]):
        * kwq/KWQFileButton.mm:
        (KWQFileButton::focusChanged):
        * kwq/KWQListBox.mm:
        (-[KWQTableView becomeFirstResponder]):
        (-[KWQTableView resignFirstResponder]):
        * kwq/KWQSlider.mm:
        (-[KWQSlider becomeFirstResponder]):
        (-[KWQSlider resignFirstResponder]):
        * kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView becomeFirstResponder]):
        (-[KWQTextAreaTextView resignFirstResponder]):
        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController setHasFocus:]):
        Updated to use new eventFilterFocusIn/Out instead of the general purpose
        eventFilter function. This allows us to remove QEvent and the focus events.

        * kwq/KWQNamespace.h: Removed ButtonState.

        * kwq/KWQObject.h:
        * kwq/KWQObject.cpp: Replaced eventFilter function with eventFilterFocusIn and
        eventFilterFocusOut, allowing us to remove QEvent. Removed event function.

        * kwq/KWQSlot.cpp:
        (KWQSlot::KWQSlot): Removed the parentDestroyed slot.
        (KWQSlot::call): Ditto.

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Renamed from
        PartStyleSheetLoader. Removed a lot of unneeded null checks. Use a
        raw Frame pointer instead of a QGuardedPtr, and count on the Frame
        to delete us when it's being deleted.
        (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): No longer
        a virtual function. This is not a polymorphic class.
        (WebCore::UserStyleSheetLoader::setStyleSheet): Remove code to delete
        ourselves -- that's now the frame's responsibility.
        (WebCore::Frame::~Frame): Call disconnectFrame on the KJS::Window and
        delete m_userStyleSheetLoader.
        (WebCore::Frame::changeLocation): Update since urlSelected no longer takes
        button and state parameters.
        (WebCore::Frame::setUserStyleSheet): Delete existing loader to stop a load
        in progress before starting a new load. Store reference to loader.
        (WebCore::Frame::urlSelected): Remove button and state parameters and unused
        local variable hasTarget.
        (WebCore::Frame::selectClosestWordFromMouseEvent): Change from QMouseEvent
        to MouseEvent.
        (WebCore::Frame::handleMousePressEventDoubleClick): Change from MousePressEvent
        to MouseEventWithHitTestResults.
        (WebCore::Frame::handleMousePressEventTripleClick): Ditto.
        (WebCore::Frame::handleMousePressEventSingleClick): Ditto.
        (WebCore::Frame::khtmlMousePressEvent): Ditto.
        (WebCore::Frame::handleMouseMoveEventSelection): Change from MouseMoveEvent
        to MouseEventWithHitTestResults.
        (WebCore::Frame::khtmlMouseMoveEvent): Ditto.
        (WebCore::Frame::khtmlMouseReleaseEvent): Change from MouseReleaseEvent
        to MouseEventWithHitTestResults.
        (WebCore::Frame::khtmlMouseDoubleClickEvent): Change from
        MouseReleaseDoubleClickEvent to MouseEventWithHitTestResults.
        (WebCore::Frame::passWidgetMouseDownEventToWidget): Change from
        NodeImpl::MouseEvent to MouseEventWithHitTestResults.

        * page/FramePrivate.h: Added m_userStyleSheetLoader.

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::viewportMousePressEvent): Change from QMouseEvent to
        MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
        (WebCore::FrameView::viewportMouseDoubleClickEvent): Ditto.
        (WebCore::selectCursor): Ditto.
        (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
        (WebCore::FrameView::viewportMouseReleaseEvent): Ditto.
        (WebCore::FrameView::keyPressEvent): Change from QKeyEvent to KeyEvent.
        (WebCore::FrameView::dispatchMouseEvent): Change from QMouseEvent to
        MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
        (WebCore::FrameView::viewportWheelEvent): Change from QWheelEvent to
        WheelEvent.
        (WebCore::FrameView::hoverTimerFired): Update for change to prepareMouseEvent
        parameters.

        * platform/Widget.h:
        * platform/Widget.cpp: Removed event function.

        * rendering/render_form.h: Removed LineEditWidget, ComboBoxWidget, TextAreaWidget.
        * rendering/render_form.cpp:
        (WebCore::RenderFormElement::slotClicked): Changed from QMouseEvent to MouseEvent.
        (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed): Updated for changes
        to the Length class.
        (WebCore::RenderSelect::setWidgetWritingDirection): Updated for removal of
        ComboBoxWidget.
        (WebCore::RenderSelect::slotSelected): Ditto.
        (WebCore::RenderSelect::createComboBox): Ditto.

        * rendering/render_replaced.h:
        * rendering/render_replaced.cpp:
        (WebCore::RenderWidget::destroy): Updated since removeEventFilter no longer takes
        a parameter.
        (WebCore::RenderWidget::setQWidget): Ditto.
        (WebCore::RenderWidget::eventFilterFocusIn): Added. Replaces eventFilter.
        (WebCore::RenderWidget::eventFilterFocusOut): Ditto.

        * css/css_computedstyle.cpp:
        (WebCore::valueForLength):
        (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
        * css/cssstyleselector.cpp:
        (WebCore::checkPseudoState):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
        * khtml/html/html_imageimpl.cpp:
        (WebCore::HTMLAreaElementImpl::getRegion):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::MarginInfo::MarginInfo):
        (WebCore::RenderBlock::isSelfCollapsingBlock):
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::determineHorizontalPosition):
        (WebCore::RenderBlock::leftRelOffset):
        (WebCore::RenderBlock::rightRelOffset):
        (WebCore::RenderBlock::calcMinMaxWidth):
        (WebCore::getBPMWidth):
        (WebCore::RenderBlock::calcInlineMinMaxWidth):
        (WebCore::RenderBlock::calcBlockMinMaxWidth):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        (WebCore::RenderTable::layout):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::calcMinMaxWidth):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild):
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::calcRowHeight):
        (WebCore::RenderTableSection::layoutRows):
        * rendering/RenderText.h:
        (khtml::RenderText::marginLeft):
        (khtml::RenderText::marginRight):
        * rendering/bidi.cpp:
        (khtml::getBPMWidth):
        * rendering/render_applet.cpp:
        (WebCore::RenderApplet::createWidgetIfNecessary):
        * rendering/render_box.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):
        (WebCore::RenderBox::getClipRect):
        (WebCore::RenderBox::relativePositionOffset):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcWidthUsing):
        (WebCore::RenderBox::sizesToIntrinsicWidth):
        (WebCore::RenderBox::calcHorizontalMargins):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::calcHeightUsing):
        (WebCore::RenderBox::calcPercentageHeight):
        (WebCore::RenderBox::calcReplacedWidth):
        (WebCore::RenderBox::calcReplacedWidthUsing):
        (WebCore::RenderBox::calcReplacedHeight):
        (WebCore::RenderBox::calcReplacedHeightUsing):
        (WebCore::RenderBox::availableHeightUsing):
        (WebCore::RenderBox::calcVerticalMargins):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        * rendering/render_br.cpp:
        (WebCore::RenderBR::lineHeight):
        * rendering/render_flexbox.cpp:
        (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth):
        (khtml::RenderFlexibleBox::calcVerticalMinMaxWidth):
        (khtml::RenderFlexibleBox::calcMinMaxWidth):
        (khtml::RenderFlexibleBox::allowedChildFlex):
        * rendering/render_flow.cpp:
        (WebCore::RenderFlow::lineHeight):
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::layout):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::isWidthSpecified):
        (WebCore::RenderImage::isHeightSpecified):
        * rendering/render_layer.cpp:
        (WebCore::Marquee::direction):
        (WebCore::Marquee::start):
        (WebCore::Marquee::updateMarqueeStyle):
        (WebCore::Marquee::timerFired):
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::marginLeft):
        (WebCore::InlineFlowBox::marginRight):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::paintBorderImage):
        (WebCore::RenderObject::paddingTop):
        (WebCore::RenderObject::paddingBottom):
        (WebCore::RenderObject::paddingLeft):
        (WebCore::RenderObject::paddingRight):
        (WebCore::RenderObject::getVerticalPosition):
        (WebCore::RenderObject::lineHeight):
        (WebCore::RenderObject::addDashboardRegions):
        * rendering/render_style.h:
        * rendering/render_theme_mac.mm:
        (WebCore::RenderThemeMac::addIntrinsicMargins):
        * rendering/table_layout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):
        (WebCore::FixedTableLayout::calcMinMaxWidth):
        (WebCore::FixedTableLayout::layout):
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::fullRecalc):
        (WebCore::AutoTableLayout::calcMinMaxWidth):
        (WebCore::AutoTableLayout::calcEffectiveWidth):
        (WebCore::AutoTableLayout::layout):
        (WebCore::AutoTableLayout::calcPercentages):
        Updated for changes to the Length class.
        Also removed a check of the printpainter global, never used in WebCore.

        * bindings/objc/DOM.mm:
        * bindings/objc/DOMCSS.mm:
        * bindings/objc/DOMHTML.mm:
        * bridge/mac/WebCoreFrameBridge.mm:
        * css/csshelper.cpp:
        * editing/SelectionController.cpp:
        * khtml/ecma/kjs_html.h:
        * kwq/KWQAccObject.mm:
        * kwq/KWQAccObjectCache.mm:
        * kwq/KWQClipboard.mm:
        * kwq/KWQFont.mm:
        * kwq/KWQFontMetrics.mm:
        * kwq/KWQKJobClasses.mm:
        * kwq/KWQKURL.mm:
        * kwq/KWQLoader.mm:
        * kwq/KWQPageState.mm:
        * kwq/KWQPainter.mm:
        * kwq/WebCoreSettings.mm:
        * platform/StringImpl.cpp:
        * platform/mac/CursorMac.mm:
        * platform/mac/WidgetMac.mm:
        * rendering/RenderBlock.h:
        * rendering/render_canvas.cpp:
        * rendering/render_line.h:
        * rendering/render_style.cpp:
        * rendering/table_layout.h:
        Updated includes.

        * bindings/js/JSDOMCore.cpp: Touched, because I got strange failures if this
        didn't rebuild.
        * bindings/js/JSDOMEvents.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago New build to fix the i386 arch. (The _cuEnc64 symbol was missing.)
thatcher [Fri, 24 Feb 2006 02:00:03 +0000 (02:00 +0000)]
    New build to fix the i386 arch. (The _cuEnc64 symbol was missing.)

        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-02-23 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Feb 2006 01:11:00 +0000 (01:11 +0000)]
2006-02-23  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Fix linking of static constructed globals on win32.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * config.h:
        * dom/EventNames.cpp:
        (WebCore::EventNames::init):
        * dom/EventNames.h:
        * dom/dom_qname.cpp:
        (WebCore::QualifiedName::init):
        * dom/dom_qname.h:
        * khtml/html/htmlnames.cpp:
        (WebCore::HTMLNames::init):
        * khtml/html/htmlnames.h:
        * platform/AtomicString.cpp:
        (WebCore::AtomicString::init):
        * platform/StaticConstructors.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick.
vicki [Fri, 24 Feb 2006 00:20:17 +0000 (00:20 +0000)]
    Reviewed by Tim Omernick.

        - fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event

        Check shouldClose() before actually scheduling a close.

        shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a
        result based on whether the user clicks "OK" or "Cancel".  In cases where the window is closed with cmd-w
        or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method.  Since
        windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check
        for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that
        closes a window even gets started.

        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::scheduleClose): add a check for shouldClose()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin, Maciej.
ggaren [Thu, 23 Feb 2006 19:52:25 +0000 (19:52 +0000)]
    Reviewed by Darin, Maciej.

        - Inline some functions suggested by Shark. 2.9% speedup on super
        accurate JS iBench.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7411
        <rdar://problem/4448116>

        * kjs/nodes.h:
        (KJS::ArgumentsNode::evaluateList):
        * kjs/object.cpp:
        * kjs/object.h:
        (KJS::ScopeChain::release):
        (KJS::JSObject::toPrimitive):
        * kjs/scope_chain.cpp:
        * kjs/ustring.cpp:
        * kjs/ustring.h:
        (KJS::UString::toArrayIndex):
        * kjs/value.cpp:
        * kjs/value.h:
        (KJS::JSValue::toObject):
        * kxmlcore/FastMalloc.cpp:
        (KXMLCore::TCMalloc_ThreadCache_FreeList::Push):
        (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
vicki [Thu, 23 Feb 2006 19:46:50 +0000 (19:46 +0000)]
    Reviewed by Hyatt.

        - fix <rdar://problem/4456004> onbeforeunload should cancel, and
        <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)

        * bridge/mac/MacFrame.mm:
        (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window
        event, so we should be using handleWindowEvent rather than dispatching a
        generic event on the body. It seems this only worked before because of incorrect
        code in other parts of the tree.
        * dom/dom2_eventsimpl.cpp:
        (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor,
        pass true for the cancel parameter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Thu, 23 Feb 2006 19:28:25 +0000 (19:28 +0000)]
    Reviewed by Darin.

        - Turn http tests back on by default.
        - Wait for Apache to actually start serving requests.
        - Get user id from a built-in variable rather than an external command;
        don't pass the group.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Mitz Pettel, reviewed by Darin.
ap [Thu, 23 Feb 2006 17:25:36 +0000 (17:25 +0000)]
    Suggested by Mitz Pettel, reviewed by Darin.

        * Scripts/run-webkit-tests: Pass User and Group directives, so that Apache
        can run CGIs even if the permissions are 700 or 600.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Collaborating with Alexey.
darin [Thu, 23 Feb 2006 16:39:25 +0000 (16:39 +0000)]
    Collaborating with Alexey.

        - turn off http tests by default until we figure out how to get them
          to run even when permissions on CGI files are 700 instead of 755

        * Scripts/run-webkit-tests: Set $testHTTP to 0 instead of 1 for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12945 268f45cc-cd09-0410-ab3c-d52691b4dbfc