WebKit-https.git
8 years agochanging -webkit-order should change the paint order of flex items
tony@chromium.org [Fri, 27 Jul 2012 07:27:44 +0000 (07:27 +0000)]
changing -webkit-order should change the paint order of flex items
https://bugs.webkit.org/show_bug.cgi?id=92041

Reviewed by Ojan Vafai.

Source/WebCore:

Override paintChildren and use the flex order iterator to determine the order to paint the children.

Test: css3/flexbox/order-painting.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Save a reference to the order iterator.
(WebCore::RenderFlexibleBox::paintChildren):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox): Hold a reference to the order iterator so we don't have to recreate it at paint time.
    Also mark all the virtual methods with OVERRIDE.

LayoutTests:

Use a ref test since this is testing paint behavior.

* css3/flexbox/order-painting-expected.html: Added.
* css3/flexbox/order-painting.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests...
ossy@webkit.org [Fri, 27 Jul 2012 07:10:06 +0000 (07:10 +0000)]
[Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=88064

Reviewed by Zoltan Herczeg.

Source/WebKit/qt:

Add missing DumpRenderTreeSupportQt::resetInternalsObject(JSContextRef context) function.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Use resetInternalsObject() instead of injectInternalsObject().

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):

LayoutTests:

* platform/qt-5.0-wk2/Skipped: Unskip now passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r123820.
ossy@webkit.org [Fri, 27 Jul 2012 06:35:38 +0000 (06:35 +0000)]
Unreviewed, rolling out r123820.
http://trac.webkit.org/changeset/123820
https://bugs.webkit.org/show_bug.cgi?id=92465

It made all tests crash on all port (Requested by Ossy_home on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

* dom/EventNames.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt build fix after r123788. Fixed the typo.
rniwa@webkit.org [Fri, 27 Jul 2012 06:21:54 +0000 (06:21 +0000)]
Qt build fix after r123788. Fixed the typo.

* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::handleElementAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build fix for Qt after r123811
hbono@chromium.org [Fri, 27 Jul 2012 05:53:00 +0000 (05:53 +0000)]
[Qt] Build fix for Qt after r123811
https://bugs.webkit.org/show_bug.cgi?id=92460

Reviewed by Ryosuke Niwa.

This change explicitly converts from AtomicString to String to avoid ambiguities
when compiling HTMLAppletWidget.cpp on Qt.

No new tests because it is a build fix.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake transitions work between different Length types
mikelawther@chromium.org [Fri, 27 Jul 2012 04:32:08 +0000 (04:32 +0000)]
Make transitions work between different Length types
https://bugs.webkit.org/show_bug.cgi?id=92220

Reviewed by Simon Fraser.

Source/WebCore:

Use the existing CSS calc machinery for blending between two calculations
to blend between two Lengths of differing types.

Test: transitions/mixed-type.html

* platform/Length.cpp:
(WebCore::Length::blendMixedTypes):
* platform/Length.h:
(WebCore::Length::blend):
(Length):

LayoutTests:

* transitions/mixed-type-expected.txt: Added.
* transitions/mixed-type.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Tests] Rename fast/forms/{number,time}/*-validity-state-* to *-validity-*
yosin@chromium.org [Fri, 27 Jul 2012 04:07:48 +0000 (04:07 +0000)]
[Tests] Rename fast/forms/{number,time}/*-validity-state-* to *-validity-*
https://bugs.webkit.org/show_bug.cgi?id=92449

Reviewed by Kent Tamura.

This patch renames test files in fast/forms/{number,time} for matching
with IDL attribute names.

* fast/forms/number/number-validity-rangeoverflow-expected.txt: Copied from LayoutTests/fast/forms/number/number-validitystate-range-overflow-expected.txt.
* fast/forms/number/number-validity-rangeoverflow.html: Copied from LayoutTests/fast/forms/number/number-validitystate-range-overflow.html.
* fast/forms/number/number-validity-rangeunderflow-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-range-underflow-expected.txt.
* fast/forms/number/number-validity-rangeunderflow.html: Copied from LayoutTests/fast/forms/number/number-validity-state-range-underflow.html.
* fast/forms/number/number-validity-state-range-underflow-expected.txt: Removed.
* fast/forms/number/number-validity-state-range-underflow.html: Removed.
* fast/forms/number/number-validity-state-step-mismatch-expected.txt: Removed.
* fast/forms/number/number-validity-state-step-mismatch.html: Removed.
* fast/forms/number/number-validity-state-type-mismatch-expected.txt: Removed.
* fast/forms/number/number-validity-state-type-mismatch.html: Removed.
* fast/forms/number/number-validity-stepmismatch-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-step-mismatch-expected.txt.
* fast/forms/number/number-validity-stepmismatch.html: Copied from LayoutTests/fast/forms/number/number-validity-state-step-mismatch.html.
* fast/forms/number/number-validity-typemismatch-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-type-mismatch-expected.txt.
* fast/forms/number/number-validity-typemismatch.html: Copied from LayoutTests/fast/forms/number/number-validity-state-type-mismatch.html.
* fast/forms/number/number-validitystate-range-overflow-expected.txt: Removed.
* fast/forms/number/number-validitystate-range-overflow.html: Removed.
* fast/forms/time/time-validity-rangeoverflow-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-range-overflow-expected.txt.
* fast/forms/time/time-validity-rangeoverflow.html: Copied from LayoutTests/fast/forms/time/time-validity-state-range-overflow.html.
* fast/forms/time/time-validity-rangeunderflow-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-range-underflow-expected.txt.
* fast/forms/time/time-validity-rangeunderflow.html: Copied from LayoutTests/fast/forms/time/time-validity-state-range-underflow.html.
* fast/forms/time/time-validity-state-range-overflow-expected.txt: Removed.
* fast/forms/time/time-validity-state-range-overflow.html: Removed.
* fast/forms/time/time-validity-state-range-underflow-expected.txt: Removed.
* fast/forms/time/time-validity-state-range-underflow.html: Removed.
* fast/forms/time/time-validity-state-step-mismatch-expected.txt: Removed.
* fast/forms/time/time-validity-state-step-mismatch.html: Removed.
* fast/forms/time/time-validity-state-type-mismatch-expected.txt: Removed.
* fast/forms/time/time-validity-state-type-mismatch.html: Removed.
* fast/forms/time/time-validity-stepmismatch-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-step-mismatch-expected.txt.
* fast/forms/time/time-validity-stepmismatch.html: Copied from LayoutTests/fast/forms/time/time-validity-state-step-mismatch.html.
* fast/forms/time/time-validity-typemismatch-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-type-mismatch-expected.txt.
* fast/forms/time/time-validity-typemismatch.html: Copied from LayoutTests/fast/forms/time/time-validity-state-type-mismatch.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBlocks with reverse column progression don’t have layout overflow for overflowing...
mitz@apple.com [Fri, 27 Jul 2012 03:48:18 +0000 (03:48 +0000)]
Blocks with reverse column progression don’t have layout overflow for overflowing columns
https://bugs.webkit.org/show_bug.cgi?id=92440

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/multicol/progression-reverse-overflow.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow): If column progression is reversed, then allow
layout overflow to go in the opposite direction than it would normally be allowed to go.
For example, in a block with writing-mode: horizontal-tb, direction: ltr and
column-progression: reverse, columns overflow to the left, so layout overflow would go on
the left.

LayoutTests:

* fast/multicol/progression-reverse-overflow-expected.html: Added.
* fast/multicol/progression-reverse-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen Safari 6 is launched via the WebKit Xcode workspace, it does not link against...
mitz@apple.com [Fri, 27 Jul 2012 03:24:09 +0000 (03:24 +0000)]
When Safari 6 is launched via the WebKit Xcode workspace, it does not link against the built frameworks
https://bugs.webkit.org/show_bug.cgi?id=92331

Reviewed by Mark Rowe.

Changed references to the Safari executable to the SafariForWebKitDevelopment binary.

* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement ColorSuggestionPicker page popup
keishi@webkit.org [Fri, 27 Jul 2012 03:21:46 +0000 (03:21 +0000)]
Implement ColorSuggestionPicker page popup
https://bugs.webkit.org/show_bug.cgi?id=92109

Reviewed by Kent Tamura.

.:

* ManualTests/forms/color-suggestion-picker.html: Added. Tests colorSuggestionPicker.{js,css}

Source/WebCore:

Implements ColorSuggestionPicker page popup. This will be used in
certain ports as the datalist UI for <input type=color>.

No new tests because there is no way to open the popup yet.

* Resources/colorSuggestionPicker.css: Added.
(body):
(#main):
(.color-swatch):
(.color-swatch:hover):
(.color-swatch-container):
(.other-color):
* Resources/colorSuggestionPicker.js: Added.
(getScrollbarWidth):When there are more than 20 colors we need to
increase the window width to accommodate the scroll bar.
(createElement):
(handleMessage):
(initialize):
(handleArgumentsTimeout):
(validateArguments):
(submitValue): Calls setValueAndClosePopup with a numValue of 0.
(handleCancel): Calls setValueAndClosePopup with a numValue of -1.
(chooseOtherColor): Calls setValueAndClosePopup with a numValue of -2.
(ColorPicker):
(ColorPicker.prototype._layout): Lays out the color swatches in a 5x4
grid.
(ColorPicker.prototype._handleSwatchClick):
* WebCore.gyp/WebCore.gyp: Added ColorSuggestionPicker action.
* make-file-arrays.py:
(main): Windows gets confused when "&&" is in the command, so we will replace " AND " with " && " internally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove forwarding headers from MiniBrowser/Efl.
ryuan.choi@samsung.com [Fri, 27 Jul 2012 02:49:04 +0000 (02:49 +0000)]
[EFL] Remove forwarding headers from MiniBrowser/Efl.
https://bugs.webkit.org/show_bug.cgi?id=91627

Reviewed by Kentaro Hara.

* MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Highlight the element under mouse on web inspector
commit-queue@webkit.org [Fri, 27 Jul 2012 02:41:31 +0000 (02:41 +0000)]
[EFL] Highlight the element under mouse on web inspector
https://bugs.webkit.org/show_bug.cgi?id=91592

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-26
Reviewed by Kentaro Hara.

Implement highlighting the nodes when using the web inspector.

* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::highlight):
(WebCore::InspectorClientEfl::hideHighlight):
(WebCore::InspectorClientEfl::invalidateView):
(WebCore):
* WebCoreSupport/InspectorClientEfl.h:
(InspectorClientEfl):
* ewk/ewk_paint_context.cpp:
(ewk_paint_context_paint_contents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize WrapShape classes
commit-queue@webkit.org [Fri, 27 Jul 2012 02:30:31 +0000 (02:30 +0000)]
De-virtualize WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=90998

Patch by Anish Bhayani <anish.bhayani@gmail.com> on 2012-07-26
Reviewed by Andreas Kling.

The destructor for WrapShapes classes did not need to use a virtual
pointer. WrapShapes.cpp is created to cast the WrapShape destructor
to the subclass type saving memory and avoiding virtual calls.

There are existing tests that cover the validity of shapes. The
added changes merely change the destructor of the shape objects
which is also tested by LayoutTests/fast/exclusions.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/style/WrapShapes.cpp: Added.
(WebCore):
(WebCore::WrapShape::destroy):
* rendering/style/WrapShapes.h:
(WebCore::WrapShape::deref):
(WrapShape):
(WebCore::WrapShape::type):
(WebCore::WrapShape::setType):
(WrapShapeRectangle):
(WebCore::WrapShapeRectangle::WrapShapeRectangle):
(WebCore::WrapShapeCircle::WrapShapeCircle):
(WebCore::WrapShapeEllipse::WrapShapeEllipse):
(WebCore::WrapShapePolygon::WrapShapePolygon):
(WrapShapePolygon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r123808.
commit-queue@webkit.org [Fri, 27 Jul 2012 01:48:24 +0000 (01:48 +0000)]
Unreviewed, rolling out r123808.
http://trac.webkit.org/changeset/123808
https://bugs.webkit.org/show_bug.cgi?id=92443

Broke Apple Mac debug tests ASSERTION FAILED: !hasClients()
(Requested by msaboff_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
(WebCore::CachedCSSStyleSheet::decodedDataDeletionTimerFired):
(WebCore):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::decodedDataDeletionTimerFired):
(WebCore):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):
* loader/cache/CachedImage.h:
(CachedImage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::didAddClient):
(WebCore):
(WebCore::CachedScript::allClientsRemoved):
(WebCore::CachedScript::decodedDataDeletionTimerFired):
* loader/cache/CachedScript.h:
(CachedScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove some unreachable code in ClipboardChromium.cpp
tony@chromium.org [Fri, 27 Jul 2012 01:41:48 +0000 (01:41 +0000)]
[chromium] Remove some unreachable code in ClipboardChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=92427

Reviewed by Adam Barth.

convertURIListToURL does the same thing (implementation in ClipboardUtilitiesChromium.*).

No new tests, just deleting unused code.

* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::getData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement undoscope attribute.
commit-queue@webkit.org [Fri, 27 Jul 2012 01:28:51 +0000 (01:28 +0000)]
Implement undoscope attribute.
https://bugs.webkit.org/show_bug.cgi?id=88793

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

undoscope attribute support as specified at
http://dvcs.w3.org/hg/undomanager/raw-file/tip/undomanager.html

Test: editing/undomanager/undoscope-attribute.html

* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/Element.cpp:
(WebCore):
(WebCore::Element::undoScope):
(WebCore::Element::setUndoScope):
(WebCore::Element::undoManager):
(WebCore::Element::disconnectUndoManager):
(WebCore::Element::disconnectUndoManagersInSubtree):
* dom/Element.h:
(Element):
* dom/Element.idl:
* dom/ElementRareData.h:
(ElementRareData):
* editing/UndoManager.cpp:
(WebCore::UndoManager::disconnect):
(WebCore::UndoManager::transact):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore):
(WebCore::UndoManager::clearRedo):
(WebCore::UndoManager::clearUndoRedo):
(WebCore::UndoManager::isConnected):
* editing/UndoManager.h:
(WebCore):
(UndoManager):
(WebCore::UndoManager::length):
* editing/UndoManager.idl:
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::setContentEditable):

LayoutTests:

* editing/undomanager/undoscope-attribute-expected.txt: Added.
* editing/undomanager/undoscope-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month...
yosin@chromium.org [Fri, 27 Jul 2012 01:27:06 +0000 (01:27 +0000)]
[Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
https://bugs.webkit.org/show_bug.cgi?id=92339

Reviewed by Kent Tamura.

Source/WebCore:

To detect compilation errors and test failure earlier, I would like
build and run tests for input type datetime, datetime-local, month,
time and week with runtime feature flags to avoid behavior changes
other than test shell.

This patch adds runtime features for input types, datetime, datetime-local,
month, time and week and integrates them into InputType::createInputTypeFactoryMap
to follow runtime feature flags.

At this time, these runtime features are enabled by default for all
ports define ENABLE_INPUT_TYPE_XXX except for Chromium port other than
Android. I'll remove these #if after I update Chromium browser for
disabling them for non-Android.

No new tests. Enabling disabled tests (fast/forms/datetime, fast/forms/dattimelocal,
fast/forms/month, fast/forms/time, fast/forms/week)

* bindings/generic/RuntimeEnabledFeatures.cpp: Added initializations of
variables for runtime features of input types.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeLocalEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeLocalEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeMonthEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeMonthEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeWeekEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeWeekEnabled): Added.
* html/InputType.cpp:
(WebCore::createInputTypeFactoryMap): Register input types datetime,
datetime-local, month, time and week if corresponding runtime feature
flag is enabled.
* html/InputType.h: Changed indentation to force building *InputType.cpp for
making Chromium-win bots to be happy.

Source/WebKit/chromium:

To detect compilation errors and test failure earlier, I would like
build and run tests for input type datetime, datetime-local, month,
time and week with runtime feature flags to avoid behavior changes
on chromium browser.

This patch adds query and change functions for runtime features of
input type datetime, datetime-local, month, time and week to WebRuntimeFeatures
class for exposing DRT and chromium browser expermental flags.

* features.gypi: Turn on ENABLE_INPUT_TYPE_DATETIME, ENABLE_INPUT_TYPE_DATETIMELOCAL,
ENABLE_INPUT_TYPE_MONTH, ENABLE_INPUT_TYPE_TIME, and ENABLE_INPUT_TYPE_WEEK for all OS.
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableInputTypeDateTime): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeDateTimeLocal): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeLocalEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeMonth): Added.
(WebKit::WebRuntimeFeatures::isInputTypeMonthEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeTime): Added.
(WebKit::WebRuntimeFeatures::isInputTypeTimeEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeWeek): Added.
(WebKit::WebRuntimeFeatures::isInputTypeWeekEnabled): Added.

Tools:

This patch enables runtime features for input type datetime, datetime-local,
month, time and week for Chromium DRT.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.

LayoutTests:

This patch enables tests for input type datetime, datetime-local,
month, time and week for Chromium ports.

* platform/chromium/TestExpectations: Removed disabled directives for
input type datetime, datetime-local, month, time and week.
* platform/chromium/fast/forms/datalist/input-list-expected.txt: Updated
expecations for input type datetime, datetime-local, month, time and week
to null for IDL list attribute. So far, these expectations specified
HTMLDataListElement for input type "text" as unsupported input types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium-Android] Don't overlay scrollbars in layout test mode
wangxianzhu@chromium.org [Fri, 27 Jul 2012 01:07:39 +0000 (01:07 +0000)]
[Chromium-Android] Don't overlay scrollbars in layout test mode
https://bugs.webkit.org/show_bug.cgi?id=92419

Reviewed by Adam Barth.

No new tests. This fixes failures of existing tests, e.g. css1/box_properties/border.html and many others.

* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars): Returns false in layout test mode.
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb): Returns false in layout test mode (to match pixel test expectations).
* platform/chromium/ScrollbarThemeChromiumAndroid.h:
(ScrollbarThemeChromiumAndroid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline after r123790.
bweinstein@apple.com [Fri, 27 Jul 2012 01:00:42 +0000 (01:00 +0000)]
Unreviewed rebaseline after r123790.

* platform/mac/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/mac/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReloading substitute-data/alternate html string for unreachableURL will add an item...
jpfau@apple.com [Fri, 27 Jul 2012 00:52:32 +0000 (00:52 +0000)]
Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
https://bugs.webkit.org/show_bug.cgi?id=84041

Reviewed by Brady Eidson.

Source/WebCore:

Previously, loadAlternateHTMLString:baseURL:forUnreachableURL: would insert a new history item, regardless of
the load type of the original frame load. This could cause navigation to a broken website to make back and
forward navigation difficult to use. This change ensures that a reload type makes it through all the way.

Added API test 'mac/BackForwardList.mm'.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load): Prevent m_loadType from being overwritten early and check if it's a reload.
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForCommit): Amend check when committing the provisional item for a reload.
(WebCore::HistoryController::isReloadTypeWithProvisionalItem): Check that a reload type has a provisional item.
(WebCore):
* loader/HistoryController.h:
(HistoryController): Add prototype for isReloadTypeWithProvisionalItem.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
(-[BackForwardListTest webView:didFinishLoadForFrame:]):
(-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Regression: Global-buffer-overflow in WebCore::mediaControlElementType
commit-queue@webkit.org [Fri, 27 Jul 2012 00:48:15 +0000 (00:48 +0000)]
[Chromium] Regression: Global-buffer-overflow in WebCore::mediaControlElementType
https://bugs.webkit.org/show_bug.cgi?id=91333

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-07-26
Reviewed by Eric Seidel.

Source/WebCore:

MediaControlChromiumEnclosureElement now is a subclass of MediaControlElement, which
fixes the broken cast detected in the bug.
The displayType() of MediaControlChromiumEnclosureElement is set to 'MediaControlsPanel',
since the Panel element is sufficiently close in functionality to the Enclosure element.
By reusing this type, we do not need to introduce a Chromium-specific constant into
the generally used MediaControlElementType.

Test: accessibility/media-controls.html

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlChromiumEnclosureElement::MediaControlChromiumEnclosureElement):
Subclass MediaControlChromiumEnclosureElement from MediaControlElement.
(WebCore::MediaControlChromiumEnclosureElement::displayType):
Give the enclosure the MediaPanels type.
* html/shadow/MediaControlRootElementChromium.h:
Add the MediaControlElement.h header file.
(MediaControlChromiumEnclosureElement):
Subclass MediaControlChromiumEnclosureElement from MediaControlElement.

LayoutTests:

This new test assures that the creation of a audio element with controls does not
break when accessibility is turned on.

* accessibility/media-controls-expected.txt: Added.
* accessibility/media-controls.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] avoid unneeded object creation when calling Vector::append
commit-queue@webkit.org [Fri, 27 Jul 2012 00:41:55 +0000 (00:41 +0000)]
[GTK] avoid unneeded object creation when calling Vector::append
https://bugs.webkit.org/show_bug.cgi?id=88805

Patch by Arnaud Renevier <arno@renevier.net> on 2012-07-26
Reviewed by Alexey Proskuryakov.

No new tests: no change in functionality.

* platform/gtk/ContextMenuGtk.cpp:
(WebCore::contextMenuItemVector):
* platform/gtk/KeyBindingTranslator.h:
(WebCore::KeyBindingTranslator::addPendingEditorCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInitialize the Event Names' strings from read only memory
benjamin@webkit.org [Fri, 27 Jul 2012 00:34:48 +0000 (00:34 +0000)]
Initialize the Event Names' strings from read only memory
https://bugs.webkit.org/show_bug.cgi?id=92435

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-26
Reviewed by Anders Carlsson.

Similarily to r123689, we can initialize the event names' strings from memory without copying the data.
This saves us memory and initialization time.

* dom/EventNames.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoconstructing TypedArray from another TypedArray is slow
commit-queue@webkit.org [Fri, 27 Jul 2012 00:25:04 +0000 (00:25 +0000)]
constructing TypedArray from another TypedArray is slow
https://bugs.webkit.org/show_bug.cgi?id=90838

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-26
Reviewed by Kenneth Russell.

PerformanceTests:

* Bindings/typed-array-construct-from-same-type.html: Added.
* Bindings/typed-array-construct-from-typed.html: Added.

Source/WebCore:

When constructing a typed array from an array like element, try to
determine if the argument is a typed array. If so, cast the argument
to a typed array, and read each element with .item() method. That
avoid reading the value as a JSValue, and speedups construction by
approximatively 3x (even 30x if TypedArrays are both the same type).

In order to achieve that, we use virtual getType method. We can use
this information to cast the TypedArray to the actual type, and then
read the values from the source.

Introduce constructArrayBufferViewWithTypedArrayArgument template
function which returns a new typed array if first argument is a typed
array, or 0 otherwise.

This patch also replaces previous is<Type>Array() calls with new
getType method.

* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore):
(WebCore::constructArrayBufferView):
* bindings/v8/SerializedScriptValue.cpp:
* html/canvas/DataView.h:
(DataView):
(WebCore::DataView::getType):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::validateTexFuncData):
* page/Crypto.cpp:

Source/WTF:

Introduce virtual method getType on ArrayBufferView. It returns the actual
type of the view. This method replaces previous is<Type>Array() methods.

* wtf/ArrayBufferView.h:
* wtf/Float32Array.h:
(WTF::Float32Array::getType):
(Float32Array):
* wtf/Float64Array.h:
(WTF::Float64Array::getType):
(Float64Array):
* wtf/Int16Array.h:
(WTF::Int16Array::getType):
(Int16Array):
* wtf/Int32Array.h:
(WTF::Int32Array::getType):
(Int32Array):
* wtf/Int8Array.h:
(WTF::Int8Array::getType):
(Int8Array):
* wtf/IntegralTypedArrayBase.h:
* wtf/TypedArrayBase.h:
(TypedArrayBase):
(WTF::TypedArrayBase::item):
* wtf/Uint16Array.h:
(WTF::Uint16Array::getType):
(Uint16Array):
* wtf/Uint32Array.h:
(WTF::Uint32Array::getType):
(Uint32Array):
* wtf/Uint8Array.h:
(WTF::Uint8Array::getType):
(Uint8Array):
* wtf/Uint8ClampedArray.h:
(WTF::Uint8ClampedArray::getType):
(Uint8ClampedArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded binding and updated chromium tests.
commit-queue@webkit.org [Fri, 27 Jul 2012 00:22:59 +0000 (00:22 +0000)]
Added binding and updated chromium tests.

[CSS Filters] Add V8 binding for WebKitCSSFilterValue
https://bugs.webkit.org/show_bug.cgi?id=92391

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-07-26
Reviewed by Adam Barth.

Source/WebCore:

No new tests. This fixes test cases in:
    platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt
    platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt
    platform/chromium/css3/filters/filter-property-computed-style-expected.txt
    platform/chromium/css3/filters/filter-property-parsing-expected.txt

* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):

LayoutTests:

* platform/chromium-linux/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
Removed. The chromium-linux expectations are (and were) exactly the same as the chromium expectations.
* platform/chromium-linux/css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
Removed. Ditto.
* platform/chromium-linux/css3/filters/custom/custom-filter-property-parsing-expected.txt:
Removed. Ditto.
* platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
Many test cases are now expected to pass instead of fail.
* platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
Ditto.
* platform/chromium/css3/filters/filter-property-computed-style-expected.txt:
Removed. We can use the platform-independent results now.
* platform/chromium/css3/filters/filter-property-parsing-expected.txt:
Many test cases are now expected to pass instead of fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSObject::reallocateStorageIfNecessary is neither used nor defined
fpizlo@apple.com [Fri, 27 Jul 2012 00:11:44 +0000 (00:11 +0000)]
JSObject::reallocateStorageIfNecessary is neither used nor defined
https://bugs.webkit.org/show_bug.cgi?id=92417

Reviewed by Mark Rowe.

* runtime/JSObject.h:
(JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebGL] Initial size of canvas can be larger than MAX_VIEWPORT_DIMS.
nayankk@motorola.com [Fri, 27 Jul 2012 00:05:53 +0000 (00:05 +0000)]
[WebGL] Initial size of canvas can be larger than MAX_VIEWPORT_DIMS.
https://bugs.webkit.org/show_bug.cgi?id=91976

Reviewed by Kenneth Russell.

From section 2.2 of the spec the WebGL implementation says initial size of
the canvas can be larger than MAX_VIEWPORT_DIMS. With the current WebGL
implementation, we get error when initial size if greater than MAX_VIEWPORT_DIMS.
This change limits the width and height of drawingbuffer to MAX_VIEWPORT_DIMS
when given initial size exceeds it.

Source/WebCore:

Added tests to LayoutTests/fast/canvas/webgl/drawingbuffer-test.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):

LayoutTests:

* fast/canvas/webgl/drawingbuffer-test-expected.txt:
* fast/canvas/webgl/drawingbuffer-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Remove synchronous spellchecking code
commit-queue@webkit.org [Fri, 27 Jul 2012 00:01:08 +0000 (00:01 +0000)]
[BlackBerry] Remove synchronous spellchecking code
https://bugs.webkit.org/show_bug.cgi?id=92415

Removing synchronous spellchecking code path.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

* Api/WebPageClient.h:
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::checkSpellingOfString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] When computing surface content scale, use top level device scale
enne@google.com [Thu, 26 Jul 2012 23:55:10 +0000 (23:55 +0000)]
[chromium] When computing surface content scale, use top level device scale
https://bugs.webkit.org/show_bug.cgi?id=92328

Reviewed by Kenneth Russell.

Previously, surface scale was calculated with layer->contentsScale(),
however this value is 1 for any layer that is not ContentLayerChromium
because of layer->needsContentsScale(). This would cause any surface
created with a non-content owner layer to look fuzzy on a high DPI
device. Fix by using the top level device scale.

Additionally, remove contentsScale from CCLayerImpl as it is no longer
used.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllocate Structures in a separate part of the Heap
mhahnenberg@apple.com [Thu, 26 Jul 2012 23:27:53 +0000 (23:27 +0000)]
Allocate Structures in a separate part of the Heap
https://bugs.webkit.org/show_bug.cgi?id=92420

Reviewed by Filip Pizlo.

To fix our issue with destruction/finalization of Structures before their objects, we can move Structures to a separate
part of the Heap that will be swept after all other objects. This first patch will just be separating Structures
out into their own separate MarkedAllocator. Everything else will behave identically.

* heap/Heap.h: New function to allocate Structures in the Heap.
(Heap):
(JSC):
(JSC::Heap::allocateStructure):
* heap/MarkedAllocator.cpp: Pass whether or not we're allocated Structures to the MarkedBlock.
(JSC::MarkedAllocator::allocateBlock):
* heap/MarkedAllocator.h: Add tracking for whether or not we're allocating only Structures.
(JSC::MarkedAllocator::onlyContainsStructures):
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::init):
* heap/MarkedBlock.cpp: Add tracking for whether or not we're allocating only Structures. We need this to be able to
distinguish the various MarkedBlock types in MarkedSpace::allocatorFor(MarkedBlock*).
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::onlyContainsStructures):
(JSC):
* heap/MarkedSpace.cpp: Include the new Structure allocator in all the places that all the other allocators are used/modified.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::MarkedSpace::isPagedOut):
* heap/MarkedSpace.h: Add new MarkedAllocator just for Structures.
(MarkedSpace):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::allocateStructure):
(JSC):
(JSC::MarkedSpace::forEachBlock):
* runtime/Structure.h: Move all of the functions that call allocateCell<Structure> down below the explicit template specialization
for allocateCell<Structure>. The new inline specialization for allocateCell directly calls the allocateStructure() function in the
Heap.
(Structure):
(JSC::Structure):
(JSC):
(JSC::Structure::create):
(JSC::Structure::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium expectations update for table-row-outline-paint.html from r123793.
atwilson@chromium.org [Thu, 26 Jul 2012 23:10:19 +0000 (23:10 +0000)]
Unreviewed chromium expectations update for table-row-outline-paint.html from r123793.

* platform/chromium-mac/fast/table/table-row-outline-paint-expected.png: Added.
* platform/chromium-win/fast/table/table-row-outline-paint-expected.png: Added.
* platform/chromium/fast/table/table-row-outline-paint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/table/table-row-outline-paint-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLAppletElement should inherit from HTMLPlugInImageElement
andersca@apple.com [Thu, 26 Jul 2012 23:08:49 +0000 (23:08 +0000)]
HTMLAppletElement should inherit from HTMLPlugInImageElement
https://bugs.webkit.org/show_bug.cgi?id=92320

Reviewed by Eric Seidel.

In order to simplify the class hierarchy and eventually merge HTMLPlugInImageElement and HMTLPlugInElement,
make HTMLAppletElement inherit from HTMLPlugInImageElement. While this does mean that HTMLAppletElement will grow by
a couple of words, in practice it won't matter.

Also, make RenderApplet inherit from RenderEmbeddedObject and move the plug-in instantiation to HTMLAppletElement which matches
both HTMLEmbedElement and HTMLObjectElement.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::create):
(WebCore::HTMLAppletElement::parseAttribute):
(WebCore::HTMLAppletElement::rendererIsNeeded):
(WebCore::HTMLAppletElement::createRenderer):
(WebCore):
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
(WebCore::HTMLAppletElement::updateWidget):
* html/HTMLAppletElement.h:
(HTMLAppletElement):
* html/HTMLTagNames.in:
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
* loader/SubframeLoader.h:
(SubframeLoader):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::RenderApplet):
* rendering/RenderApplet.h:
(RenderApplet):
* rendering/RenderEmbeddedObject.h:
(WebCore::toRenderEmbeddedObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
* rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r123799.
commit-queue@webkit.org [Thu, 26 Jul 2012 23:06:44 +0000 (23:06 +0000)]
Unreviewed, rolling out r123799.
http://trac.webkit.org/changeset/123799
https://bugs.webkit.org/show_bug.cgi?id=92431

broke the Apple Mac build (Requested by bweinstein on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/GestureEvent.cpp: Removed.
* dom/GestureEvent.h: Removed.
* dom/Node.cpp:
* dom/Node.h:
(WebCore):
(Node):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
* page/EventHandler.h:

Source/WebKit/chromium:

* src/WebInputEventConversion.cpp:
(WebKit):
* src/WebInputEventConversion.h:
(WebKit):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

Tools:

* DumpRenderTree/chromium/TestWebPlugin.cpp:
* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin::handleInputEvent):

LayoutTests:

* platform/chromium/plugins/gesture-events-expected.txt: Removed.
* platform/chromium/plugins/gesture-events.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Support async spellcheck for the blackberry port
commit-queue@webkit.org [Thu, 26 Jul 2012 23:05:02 +0000 (23:05 +0000)]
[BlackBerry] Support async spellcheck for the blackberry port
https://bugs.webkit.org/show_bug.cgi?id=92160

Source/WebCore:

Set USE_UNIFIED_TEXT_CHECKING for PLATFORM(BLACKBERRY) to use the
asynchronous spellchecking code path.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

* platform/text/TextChecking.h:
(WebCore):

Source/WebKit/blackberry:

PR124517
Implementing support for async spellcheck.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::spellCheckingRequestCancelled):
(WebKit):
(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebPage.h:
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isAsynchronousSpellCheckingEnabled):
(BlackBerry::WebKit::WebSettings::setAsynchronousSpellCheckingEnabled):
* Api/WebSettings.h:
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore):
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
(WebCore::EditorClientBlackBerry::checkTextOfParagraph):
* WebCoreSupport/EditorClientBlackBerry.h:
(EditorClientBlackBerry):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::convertTransactionIdToSequenceId):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::getSpellChecker):
* WebKitSupport/InputHandler.h:
(WebCore):
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGather the duplicated timer code into CachedResource.
kseo@webkit.org [Thu, 26 Jul 2012 23:03:40 +0000 (23:03 +0000)]
Gather the duplicated timer code into CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=92332

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-26
Reviewed by Nate Chapin.

Internal review by Jae Hyun Park.

When all clients are removed, CachedImage, CachedScript and CachedCSSStyleSheet
start the timer to destroy decoded data. Those three classes have their own
timer.
Changed CachedCSSStyleSheet::didAddClient to call super class method in order to
stop the timer. This change does not have any side effect because
CachedResource::didAddClient only stops the timer in this case.

No new tests - no new testable functionality.

* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):
* loader/cache/CachedImage.h:
(CachedImage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore):
(WebCore::CachedResource::decodedDataDeletionTimerFired):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
* loader/cache/CachedScript.h:
(CachedScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSArray has methods that are neither used nor defined
fpizlo@apple.com [Thu, 26 Jul 2012 23:01:05 +0000 (23:01 +0000)]
JSArray has methods that are neither used nor defined
https://bugs.webkit.org/show_bug.cgi?id=92416

Reviewed by Simon Fraser.

* runtime/JSArray.h:
(JSArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline for tests introduced in r123790
piman@chromium.org [Thu, 26 Jul 2012 23:00:18 +0000 (23:00 +0000)]
Unreviewed, rebaseline for tests introduced in r123790

* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png: Added.
* platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: pass --verbose twice on the bots to ensure getting the debug output for now
dpranke@chromium.org [Thu, 26 Jul 2012 23:00:08 +0000 (23:00 +0000)]
nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
https://bugs.webkit.org/show_bug.cgi?id=92172

Reviewed by Tony Chang.

Right now new-run-webkit-tests --verbose prints out too much
information (it's like --verbose + debugging). I plan to fix
this in bug 88702, and also clean up and simplify all of the
--print options, but in preparation for these changes I need to
pass --verbose twice to get the same level of output
temporarily (for compatibility).

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse the constant count of Tags/Attributes names instead of getting the size when...
benjamin@webkit.org [Thu, 26 Jul 2012 22:41:04 +0000 (22:41 +0000)]
Use the constant count of Tags/Attributes names instead of getting the size when obtaining the tags/attributes
https://bugs.webkit.org/show_bug.cgi?id=92411

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-26
Reviewed by Julien Chaffraix.

Since r123582, the number of tags and attributes per "namespace" is exposed in a constant in the header file.
This makes it possible to access this value through two ways:
1) The constant.
2) The first parameter of the tags/attributes getter function.

Having two ways to access the value is error prone. This patches changes the code to have all accesses done
through the constant.

* dom/make_names.pl:
(printNamesHeaderFile):
(printNamesCppFile):
Change the code generator to not provide the size in the getter function.

* html/HTMLObjectElement.cpp:
(WebCore::isRecognizedTagName):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::adjustSVGTagNameCase):
(WebCore):
(WebCore::adjustAttributes):
(WebCore::adjustSVGAttributes):
(WebCore::adjustMathMLAttributes):
(WebCore::adjustForeignAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Reskip fast/table WK2 added results
igor.o@sisa.samsung.com [Thu, 26 Jul 2012 22:40:35 +0000 (22:40 +0000)]
[Qt] Reskip fast/table WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91621

Patch by Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
Reviewed by Noam Rosenthal.

This patch reverts the added WK2 layout test results from r123229 "[Qt]
Added/updated missing fast/table results after rebaseline". As discussed with
Caio, these expectations are actually caused by an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990). These
tests were reskipped and reassigned to proper bugs.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.png: Removed.
* platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png: Removed.
* platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Removing http/tests/media/media-source/video-media-source-add-and-remove...
annacc@chromium.org [Thu, 26 Jul 2012 22:31:25 +0000 (22:31 +0000)]
[Chromium] Removing http/tests/media/media-source/video-media-source-add-and-remove-ids.html from TestExpectations

Unreviewed gardening.

Recent chromium patch fixes this problem:
http://src.chromium.org/viewvc/chrome?view=rev&revision=148473

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Reskip fast/text WK2 added results
igor.o@sisa.samsung.com [Thu, 26 Jul 2012 22:22:08 +0000 (22:22 +0000)]
[Qt] Reskip fast/text WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91570

Patch by Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
Unreviewed gardening.

This patch reverts the added WK2 layout test results from r123144 "[Qt]
Added/updated missing fast/text results after rebaseline". As discussed with
Caio, these expectations are actually caused by an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990). These
tests were reskipped and reassigned to proper bugs.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Removed.
* platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt: Removed.
* platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport constructor-type static readonly attribute for CodeGenerator.
commit-queue@webkit.org [Thu, 26 Jul 2012 22:15:56 +0000 (22:15 +0000)]
Support constructor-type static readonly attribute for CodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=92413.

Patch by Chang Shu <cshu@webkit.org> on 2012-07-26
Reviewed by Adam Barth.

Added support for constructor-type static readonly attribute for CodeGenerator.
This is achieved by putting the attribute entry in the table where static properties
belong to but leave the implementation same as a non-static constructor-type attribute.

Tested by running run-bindings-tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::jsTestObjConstructorTestSubObj):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPropagate gesture events to plugins.
commit-queue@webkit.org [Thu, 26 Jul 2012 22:10:54 +0000 (22:10 +0000)]
Propagate gesture events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=92281

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-07-26
Reviewed by Adam Barth.

Source/WebCore:

Propagate gesture events to plugins. This change does not expose the gesture events
to JavaScript, since there is no spec for that at the moment. Exposing gesture events
to JavaScript will be done separately, once there is a spec for it.

Test: platform/chromium/plugins/gesture-events.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
(WebCore::EventNames::isGestureEventType):
(EventNames):
* dom/GestureEvent.cpp: Added.
(WebCore):
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::initGestureEvent):
(WebCore::GestureEvent::interfaceName):
(WebCore::GestureEvent::GestureEvent):
(WebCore::GestureEventDispatchMediator::GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::event):
(WebCore::GestureEventDispatchMediator::dispatchEvent):
* dom/GestureEvent.h: Added.
(WebCore):
(GestureEvent):
(WebCore::GestureEvent::~GestureEvent):
(WebCore::GestureEvent::deltaX):
(WebCore::GestureEvent::deltaY):
(WebCore::GestureEvent::GestureEvent):
(GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::create):
* dom/Node.cpp:
(WebCore):
(WebCore::Node::dispatchGestureEvent):
* dom/Node.h:
(WebCore):
(Node):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
* page/EventHandler.h:

Source/WebKit/chromium:

Propagate gesture events to plugins.

* src/WebInputEventConversion.cpp:
(WebKit):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
* src/WebInputEventConversion.h:
(WebCore):
(WebKit):
(WebGestureEventBuilder):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):
* src/WebPluginContainerImpl.h:
(WebCore):
(WebPluginContainerImpl):

Tools:

Update TestWebPlugin to receive events, and output logs for the events.

* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::handleInputEvent):
* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin):

LayoutTests:

Added a layout test to show that the plugins receive the gesture events correctly.

* platform/chromium/plugins/gesture-events-expected.txt: Added.
* platform/chromium/plugins/gesture-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGuard Prerenderer against inserting prerenders into detached documents.
gavinp@chromium.org [Thu, 26 Jul 2012 22:07:20 +0000 (22:07 +0000)]
Guard Prerenderer against inserting prerenders into detached documents.
https://bugs.webkit.org/show_bug.cgi?id=92401

Reviewed by Adam Barth.

Source/WebCore:

If the document is detached, we should not launch a prerender.

Test: fast/dom/HTMLLinkElement/prerender-insert-after-stop.html

* loader/Prerenderer.cpp:
(WebCore::Prerenderer::render):

LayoutTests:

If the document is detached, we should just not launch a prerender.

* fast/dom/HTMLLinkElement/prerender-insert-after-stop-expected.txt: Added.
* fast/dom/HTMLLinkElement/prerender-insert-after-stop.html: Added.
* fast/dom/HTMLLinkElement/resources/empty2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Improve the logs in Selection Handler.
mifenton@rim.com [Thu, 26 Jul 2012 22:03:48 +0000 (22:03 +0000)]
[BlackBerry] Improve the logs in Selection Handler.
https://bugs.webkit.org/show_bug.cgi?id=92405

Reviewed by Rob Buis.

Clean up selection logging, fix priority and style
of helper function.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectObject):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Qt buildfix after r123786.
zeno.albisser@nokia.com [Thu, 26 Jul 2012 21:46:16 +0000 (21:46 +0000)]
Unreviewed Qt buildfix after r123786.

Qt-minimal builds with ENABLE_REQUEST_ANIMATION_FRAME=0.
Therefore adding #ifdefs to allow for that configuration.

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore):
* WebCoreSupport/ChromeClientQt.h:
(ChromeClientQt):

Source/WebKit2:

* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium expectations change to fix lint err.
atwilson@chromium.org [Thu, 26 Jul 2012 21:37:16 +0000 (21:37 +0000)]
Unreviewed chromium expectations change to fix lint err.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r123525.
commit-queue@webkit.org [Thu, 26 Jul 2012 21:23:08 +0000 (21:23 +0000)]
Unreviewed, rolling out r123525.
http://trac.webkit.org/changeset/123525
https://bugs.webkit.org/show_bug.cgi?id=92421

it needed to be rolled out after r123779 too (Requested by
jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

* fast/table/crash-table-section-layoutRows-expected.txt: Removed.
* fast/table/crash-table-section-layoutRows.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOutline is always painted on the first table row regardless of the row it's set on
commit-queue@webkit.org [Thu, 26 Jul 2012 21:18:53 +0000 (21:18 +0000)]
Outline is always painted on the first table row regardless of the row it's set on
https://bugs.webkit.org/show_bug.cgi?id=92389

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-26
Reviewed by Eric Seidel.

Source/WebCore:

The outlines of all the rows are drawn on the row instead of their respective rows.
The paint offset for the outlines does not take the row location into account.

Test: fast/table/table-row-outline-paint.html

* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::paintOutlineForRowIfNeeded):
The row's location is taken into account for calculating the correct paint offset
for its outline.

LayoutTests:

* fast/table/table-row-outline-paint.html: Added.
* platform/chromium-linux/fast/table/table-row-outline-paint-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-outline-paint-expected.txt: Added.
  Paint phase issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium expectations change to mark inspector tests as SLOW.
atwilson@chromium.org [Thu, 26 Jul 2012 21:16:08 +0000 (21:16 +0000)]
Unreviewed chromium expectations change to mark inspector tests as SLOW.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Combine color matrix filters and apply them in a single pass.
piman@chromium.org [Thu, 26 Jul 2012 20:54:15 +0000 (20:54 +0000)]
[chromium] Combine color matrix filters and apply them in a single pass.
https://bugs.webkit.org/show_bug.cgi?id=92059

Reviewed by Stephen White.

Sequential color matrix filters can easily be combined, by simply
multiplying the color matrices and applying it in a single pass. This
helps dramatically with performance (bandwidth savings by avoiding extra
copy & clear, also saves fragment shader processing).

Covered by css3/filters layout tests, added effect-brightness-clamping
and effect-brightness-clamping-hw.

* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium mac/win rebaseline post r123782.
eae@chromium.org [Thu, 26 Jul 2012 20:52:41 +0000 (20:52 +0000)]
Unreviewed chromium mac/win rebaseline post r123782.

* css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Removed.
* platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHref attribute with javascript protocol is stripped when content is pasted into a...
rniwa@webkit.org [Thu, 26 Jul 2012 20:23:09 +0000 (20:23 +0000)]
Href attribute with javascript protocol is stripped when content is pasted into a XML doucment
https://bugs.webkit.org/show_bug.cgi?id=92310

Reviewed by Adam Barth.

Source/WebCore:

The bug was caused by setAttributeNS's stripping attributes for which isAttributeToRemove
return true instead of setting an empty string. Changing this in setAttributeNS is problematic
because it will trigger a logic, in HTMLAnchorElement for example, to resolve the URL.

Fixed the bug by making XML parsers call parserSetAttributes instead of setAttributeNS.
After this patch, handleNamespaceAttributes and handleElementAttributes simply fills up a Vector
with which startElementNs (or parseStartElement in Qt) calls parserSetAttributes.

* dom/Element.cpp:
(WebCore::Element::parserSetAttributes): Sets emptyAtom instead of nullAtom as nullAtom can be
turned into "null".
(WebCore::Element::parseAttributeName): Extracted from setAttributeNS.
(WebCore::Element::setAttributeNS): No longer takes FragmentScriptingPermission.
* dom/Element.h:
(Element):
* editing/markup.cpp:
(WebCore::completeURLs): Don't resolve URLs when it's empty since empty attribute has a canonical
meaning in some cases. e.g. <frame src=""></iframe>
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::handleNamespaceAttributes): Renamed from handleElementNamespaces. Call
parserSetAttributes even when exiting early to be maintain the same behavior.
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::startElementNs):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::handleNamespaceAttributes): Use XMLNSNames::xmlnsNamespaceURI. Call parserSetAttributes
even when exiting early to be maintain the same behavior.
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::parseStartElement):

LayoutTests:

Rebaseline a test that catches this bug.

* editing/pasteboard/paste-noscript-xhtml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add timing logs to SelectionHandler.
mifenton@rim.com [Thu, 26 Jul 2012 20:19:39 +0000 (20:19 +0000)]
[BlackBerry] Add timing logs to SelectionHandler.
https://bugs.webkit.org/show_bug.cgi?id=92404

Reviewed by Rob Buis.

Add selection timing logs.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] requestAnimationFrame should only trigger when a new frame can be displayed.
zeno.albisser@nokia.com [Thu, 26 Jul 2012 20:15:53 +0000 (20:15 +0000)]
[Qt] requestAnimationFrame should only trigger when a new frame can be displayed.
https://bugs.webkit.org/show_bug.cgi?id=88638

Source/WebKit/qt:

Disable REQUEST_ANIMATION_FRAME_TIMER for the Qt port and tie
the servicing of scripted animations to the renderNextFrame call for WK2.
For WK1 we rely on the RefreshAnimation that is based on QAbstractAnimation.

Reviewed by Jocelyn Turcotte.

* WebCoreSupport/ChromeClientQt.cpp:
(RefreshAnimation):
    Add a RefreshAnimation that is based on QAbstractAnimation
    and drives the servicing of the scripted animations for WK1.
(WebCore::RefreshAnimation::RefreshAnimation):
(WebCore::RefreshAnimation::duration):
(WebCore::RefreshAnimation::scheduleAnimation):
    Set m_animationScheduled to true and start the animation
    timer in case it is not running yet.
(WebCore::RefreshAnimation::updateCurrentTime):
    Call serviceScriptedAnimations if m_animationScheduled is true.
    If this is not the case, the animation timer can be stopped,
    because no animation needs to be scheduled anymore.
(WebCore):
(WebCore::ChromeClientQt::scheduleAnimation):
    Create and start the RefreshAnimation instance with the
    first call to scheduleAnimation.
* WebCoreSupport/ChromeClientQt.h:
(WebCore):
(ChromeClientQt):

Source/WebKit2:

Disable REQUEST_ANIMATION_FRAME_TIMER for the Qt port and tie
the servicing of scripted animations to layer syncing for WK2.
For WK1 we rely on the RefreshAnimation that is based on QAbstractAnimation.

Reviewed by Jocelyn Turcotte.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit):
(WebKit::WebChromeClient::scheduleAnimation):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::scheduleAnimation):
(WebKit):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):

Source/WTF:

Disable REQUEST_ANIMATION_FRAME_TIMER for the Qt port and tie
the servicing of scripted animations to layer syncing for WK2.
For WK1 we rely on the RefreshAnimation that is based on QAbstractAnimation.

Reviewed by Jocelyn Turcotte.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<svg> element with no intrinsic size and max-width gets sized incorrectly
mitz@apple.com [Thu, 26 Jul 2012 20:10:26 +0000 (20:10 +0000)]
<svg> element with no intrinsic size and max-width gets sized incorrectly
https://bugs.webkit.org/show_bug.cgi?id=92410

Reviewed by Dean Jackson.

Source/WebCore:

Test: svg/css/max-width-2.html

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth): The rule for computing the width for
elements whose computed width and height are both auto and which have no intrinsic size, but
have an intrinsic ratio was applied only to elements with a content renderer (such as <img>
with an SVG source). Removed the requirement to have a content renderer, so that it will
apply to all elements including <svg>.

LayoutTests:

* svg/css/max-width-2-expected.html: Added.
* svg/css/max-width-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] InputHandler failure logs should be logAlways and critical.
mifenton@rim.com [Thu, 26 Jul 2012 20:02:06 +0000 (20:02 +0000)]
[BlackBerry] InputHandler failure logs should be logAlways and critical.
https://bugs.webkit.org/show_bug.cgi?id=92403

Reviewed by Rob Buis.

Update Log level for failures and fix mask in log.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setTextAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression: r123696 made css3/flexbox tests failing
tony@chromium.org [Thu, 26 Jul 2012 19:56:26 +0000 (19:56 +0000)]
Regression: r123696 made css3/flexbox tests failing
https://bugs.webkit.org/show_bug.cgi?id=92352

Reviewed by Levi Weintraub.

Source/WebCore:

Use roundedLayoutUnit so ports without subpixel layout still pass existing tests.

Covered by css3/flexbox/flex-algorithm-min-max.html which should pass again.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):

LayoutTests:

Skip css3/flexbox/flex-rounding.html on ports that don't enable subpixel layout.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Contained div with right 0 sometimes overlaps parent div
eae@chromium.org [Thu, 26 Jul 2012 19:54:29 +0000 (19:54 +0000)]
Source/WebCore: Contained div with right 0 sometimes overlaps parent div
https://bugs.webkit.org/show_bug.cgi?id=91521

Reviewed by Levi Weintraub.

Due to unnecessary rounding in clientLogicalWidth and clientLogicalHeight
we lost precision when computing the width and position of render boxes.
Change clientLogicalWidth/Height to return values with subpixel precision
to avoid this.

Test: fast/sub-pixel/position-right-aligns-with-container.html

* rendering/RenderBox.h:
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
Remove unnecessary rounding.

Source/WebKit2: Add a ChromeClient method to send diagnostic logging messages from WebCore to the client.
https://bugs.webkit.org/show_bug.cgi?id=92340

Reviewed by Anders Carlsson.

Pipe the ChromeClient logDiagnosticMessage() function through WebKit2 to a new bundle class
InjectedBundlePageDiagnosticLoggingClient, to be implemented by the client.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetDiagnosticLoggingClient): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::logDiagnosticMessage):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleDiagnosticLoggingClient):

Add a convenience class to retrieve the diagnostic message keys:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):

Add the InjectedBundlePageDiagnosticLoggingClient.cpp,h files.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* win/WebKit2.vcproj:
* WebKit2.xcodeproj/project.pbxproj:

Tools: [nrwt] get rid of --skip-pixel-test-if-no-baseline
https://bugs.webkit.org/show_bug.cgi?id=92377

Reviewed by Adam Barth.

Remove the option and all code paths that handled it.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_run_as_pixel_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each):

LayoutTests: Contained div with right 0 sometimes overlaps parent div
https://bugs.webkit.org/show_bug.cgi?id=91521

Reviewed by Levi Weintraub.

Add test for elements positioned based on the right edge and update two
existing tests that where affected by the rounding.

* fast/sub-pixel/position-right-aligns-with-container-expected.html: Added.
* fast/sub-pixel/position-right-aligns-with-container.html: Added.
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Mark new subpixel test as skipped on platforms that do not enable
subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild broken when svg is disabled.
commit-queue@webkit.org [Thu, 26 Jul 2012 19:10:12 +0000 (19:10 +0000)]
Build broken when svg is disabled.
https://bugs.webkit.org/show_bug.cgi?id=92393.

Patch by Chang Shu <cshu@webkit.org> on 2012-07-26
Reviewed by Laszlo Gombos.

Need to surpress unused parameters warning.

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd diagnostic messages when media and plugins load or fail to load.
jer.noble@apple.com [Thu, 26 Jul 2012 19:01:20 +0000 (19:01 +0000)]
Add diagnostic messages when media and plugins load or fail to load.
https://bugs.webkit.org/show_bug.cgi?id=92341

Reviewed by Anders Carlsson.

Send diagnostic messages when a media or plugin element loads or fails to load. Include in
the trace the media engine description, error code, or plugin mime type.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): Send a diagnostic message.
* html/HTMLMediaElement.cpp:
(WebCore::stringForNetworkState): Added convenience function to stringify network states.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Send a diagnostic message.
(WebCore::HTMLMediaElement::setReadyState): Send a diagnostic message.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget): Send a diagnostic message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r123159, r123165, r123168, r123492,
commit-queue@webkit.org [Thu, 26 Jul 2012 18:50:48 +0000 (18:50 +0000)]
Unreviewed, rolling out r123159, r123165, r123168, r123492,
and r123650.
http://trac.webkit.org/changeset/123159
http://trac.webkit.org/changeset/123165
http://trac.webkit.org/changeset/123168
http://trac.webkit.org/changeset/123492
http://trac.webkit.org/changeset/123650
https://bugs.webkit.org/show_bug.cgi?id=92406

allowing inline-table anonymous wrappers is a bad idea due to
tons of corner cases that should be properly handled
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChildIgnoringContinuation):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::createAnonymousWithParentRenderer):

LayoutTests:

* css2.1/20110323/inline-table-002b-expected.htm: Removed.
* css2.1/20110323/inline-table-002b.html: Removed.
* fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
* fast/table/inline-block-generates-table-wrapper-expected.html: Removed.
* fast/table/inline-block-generates-table-wrapper.html: Removed.
* fast/table/inline-table-in-continuation-expected.html: Removed.
* fast/table/inline-table-in-continuation.html: Removed.
* fast/table/inline-table-with-caption-expected.html: Removed.
* fast/table/inline-table-with-caption.html: Removed.
* platform/chromium-linux/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-mac-snowleopard/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-win/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug3037-1-expected.txt:
* platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
* platform/efl/tables/mozilla/bugs/bug3037-1-expected.txt: Renamed from LayoutTests/tables/mozilla/bugs/bug3037-1-expected.txt.
* platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug3037-1-expected.txt:
* platform/mac-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
* platform/mac-wk2/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
* platform/mac-wk2/tables/mozilla/bugs/bug3037-1-expected.txt: Removed.
* platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a ChromeClient method to send diagnostic logging messages from WebCore to the...
jer.noble@apple.com [Thu, 26 Jul 2012 18:45:46 +0000 (18:45 +0000)]
Add a ChromeClient method to send diagnostic logging messages from WebCore to the client.
https://bugs.webkit.org/show_bug.cgi?id=92340

Reviewed by Anders Carlsson.

Source/WebCore:

Add a new ChromeClient menthod, to be implemented by WebKit and WebKit2, which sends
a diagnostic logging message up to the client.

* page/ChromeClient.h:
(WebCore::ChromeClient::logDiagnosticMessage):
* page/ChromeClient.h:
(WebCore::ChromeClient::logDiagnosticMessage):
(ChromeClient):
* page/DiagnosticLoggingKeys.cpp: Added.
(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):
* page/DiagnosticLoggingKeys.h: Added.
(DiagnosticLoggingKeys):

Add the new files DiagnosticLoggingKeys.cpp,h to the project:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Pipe the ChromeClient logDiagnosticMessage() function through WebKit2 to a new bundle class
InjectedBundlePageDiagnosticLoggingClient, to be implemented by the client.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetDiagnosticLoggingClient): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::logDiagnosticMessage):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleDiagnosticLoggingClient):

Add a convenience class to retrieve the diagnostic message keys:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):

Add the InjectedBundlePageDiagnosticLoggingClient.cpp,h files.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* win/WebKit2.vcproj:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoexpectations change for skia rev. 4771
reed@google.com [Thu, 26 Jul 2012 18:27:02 +0000 (18:27 +0000)]
expectations change for skia rev. 4771
https://bugs.webkit.org/show_bug.cgi?id=92402

Reviewed by NOBODY : expectations change only

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[nrwt] get rid of --skip-pixel-test-if-no-baseline
kbalazs@webkit.org [Thu, 26 Jul 2012 18:26:41 +0000 (18:26 +0000)]
[nrwt] get rid of --skip-pixel-test-if-no-baseline
https://bugs.webkit.org/show_bug.cgi?id=92377

Reviewed by Adam Barth.

Remove the option and all code paths that handled it.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_run_as_pixel_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd setting to enable and disable diagnostic logging.
jer.noble@apple.com [Thu, 26 Jul 2012 18:26:32 +0000 (18:26 +0000)]
Add setting to enable and disable diagnostic logging.
https://bugs.webkit.org/show_bug.cgi?id=92337

Reviewed by Anders Carlsson.

Source/WebCore:

Add a new entry in Settings, defaulting to false.

* page/Settings.cpp:
(WebCore::Settings::Settings): Default the new setting to false.
* page/Settings.h:
(WebCore::Settings::setDiagnosticLoggingEnabled): Simple accessor.
(WebCore::Settings::diagnosticLoggingEnabled): Ditto.

Source/WebKit/mac:

Add a WebKit WebPreferences API to set set the WebCore diagnosticLoggingEnabled setting.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Register the default value to false.
(-[WebPreferences diagnosticLoggingEnabled]): Simple userDefaults accessor.
(-[WebPreferences setDiagnosticLoggingEnabled:]): Ditto.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Ensure this preference is propagated to Settings
    whenever the preferences change.

Source/WebKit2:

Add a WebKit2 WKPreferences API to set set the WebCore diagnosticLoggingEnabled setting.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDiagnosticLoggingEnabled):
(WKPreferencesGetDiagnosticLoggingEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Ensure this preference is propagated to Settings
    whenever the preferences change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Regression(r123731): Linking errors due to efreet functions
commit-queue@webkit.org [Thu, 26 Jul 2012 18:18:09 +0000 (18:18 +0000)]
[EFL][WK2] Regression(r123731): Linking errors due to efreet functions
https://bugs.webkit.org/show_bug.cgi?id=92378

Unreviewed build fix.

The library list created by PlatformEfl.cmake was being erased by a
SET called after including the platform specific file. Luckily the
dependencies were fulfilled by other targets until efreet was add.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-26

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd FastMalloc statistics in window.internals
commit-queue@webkit.org [Thu, 26 Jul 2012 18:16:54 +0000 (18:16 +0000)]
Add FastMalloc statistics in window.internals
https://bugs.webkit.org/show_bug.cgi?id=91274

Patch by Olivier Blin <olivier.blin@softathome.com> on 2012-07-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/harness/fastmallocstatistics-object.html

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCoreTestSupport.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* testing/FastMallocStatistics.h: Added.
(WebCore):
(FastMallocStatistics):
(WebCore::FastMallocStatistics::create):
(WebCore::FastMallocStatistics::reservedVMBytes):
(WebCore::FastMallocStatistics::committedVMBytes):
(WebCore::FastMallocStatistics::freeListBytes):
(WebCore::FastMallocStatistics::FastMallocStatistics):
* testing/FastMallocStatistics.idl: Added.
* testing/Internals.cpp:
(WebCore::Internals::fastMallocStatistics):
(WebCore):
* testing/Internals.h:
(WebCore):
(Internals):
* testing/Internals.idl:

Tools:

* GNUmakefile.am:

LayoutTests:

* fast/harness/fastmallocstatistics-object-expected.txt: Added.
* fast/harness/fastmallocstatistics-object.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [chromium] Remove redundant surface origin transforms
enne@google.com [Thu, 26 Jul 2012 18:02:42 +0000 (18:02 +0000)]
Source/WebCore: [chromium] Remove redundant surface origin transforms
https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit2: [EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
https://bugs.webkit.org/show_bug.cgi?id=92387

Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::EWK2UnitTestServer):

LayoutTests: [Qt] css3/filters, editing/undo, fast/block/lineboxcontain, fast/js and tables/layering tests need update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92292

Reviewed by Alexis Menard.

* platform/qt-5.0/Skipped:
* platform/qt/css3/filters/effect-blur-expected.txt:
* platform/qt/css3/filters/effect-blur-hw-expected.txt:
* platform/qt/css3/filters/regions-expanding-expected.txt:
* platform/qt/editing/undo/5378473-expected.txt:
* platform/qt/editing/undo/undo-misspellings-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-box-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-replaced-expected.txt:
* platform/qt/fast/block/lineboxcontain/none-expected.png:
* platform/qt/fast/block/lineboxcontain/none-expected.txt:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/qt/fast/block/lineboxcontain/replaced-expected.png:
* platform/qt/fast/block/lineboxcontain/replaced-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove redundant surface origin transforms
enne@google.com [Thu, 26 Jul 2012 17:59:59 +0000 (17:59 +0000)]
[chromium] Remove redundant surface origin transforms
https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Source/WebCore:

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

Clean up use of origin transforms in tests. Where possible, test
against the equivalent draw transform.

* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCRenderSurfaceTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: simplify handling of status bar items
caseq@chromium.org [Thu, 26 Jul 2012 17:55:35 +0000 (17:55 +0000)]
Web Inspector: simplify handling of status bar items
https://bugs.webkit.org/show_bug.cgi?id=92143

Reviewed by Pavel Feldman.

- split status bars into "global" (always in the bottom) and "panel"
    (on top of the drawer when drawer is shown)
- use "inner" status bar section in global status bar to display either
    panel status bar items or drawer view items (depending on drawer visibility)
- let panels/views manage their counters as part of their status bar
    items, not through special interface members;
- get rid of absolute positioning in the status bars where possible;

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.get statusBarItems):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._startStatusBarDragging):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype.willHide):
* inspector/front-end/elementsPanel.css:
(.crumbs):
* inspector/front-end/inspector.css:
(#main):
(body.drawer-visible #main-panels):
(.status-bar):
(.status-bar-item):
(#panel-status-bar-placeholder):
(body.drawer-visible #panel-status-bar-placeholder):
(#panel-status-bar-resizer):
(#panel-status-bar):
(#panel-status-bar > div):
(#error-warning-count):
(#drawer):
(#drawer-contents):
(.status-bar-items):
(.drawer-header):
(#inner-status-bar):
(.search-status-bar-item):
(.search-status-bar-message):
(.search-status-bar-progress):
(body:not(.platform-mac) .search-status-bar-progress):
(body.platform-mac .search-status-bar-progress):
(.search-status-bar-stop-button-item):
(.search-status-bar-stop-button .glyph):
(.search-results-status-bar-message):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector.showViewInDrawer):
(WebInspector._closePreviousDrawerView):
* inspector/front-end/timelinePanel.css:
(.timeline-records-counter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Implement Network Information provider
commit-queue@webkit.org [Thu, 26 Jul 2012 17:47:18 +0000 (17:47 +0000)]
[EFL][WK2] Implement Network Information provider
https://bugs.webkit.org/show_bug.cgi?id=92343

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Moved Network Information provider code from WebKit1
to WebCore so that it can be shared with WebKit2.

No new tests, no behavior change.

* PlatformEfl.cmake:
* platform/efl/NetworkInfoProviderEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp.
(WebCore):
(WebCore::NetworkInfoProviderEfl::NetworkInfoProviderEfl):
(WebCore::NetworkInfoProviderEfl::startUpdating):
(WebCore::NetworkInfoProviderEfl::stopUpdating):
(WebCore::NetworkInfoProviderEfl::bandwidth):
* platform/efl/NetworkInfoProviderEfl.h: Added.
(WebCore):
(NetworkInfoProviderEfl):

Source/WebKit:

WebKit EFL not longer needs to link against EEZE
library since the Network Information provider
was moved to WebCore.

* CMakeLists.txt:
* PlatformEfl.cmake:

Source/WebKit/efl:

Make NetworkInfoClientEfl use NetworkInfoProviderEfl
from WebCore to avoid code duplication with WebKit2.

* WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):
(WebCore):
* WebCoreSupport/NetworkInfoClientEfl.h:
(WebCore):
(NetworkInfoClientEfl):

Source/WebKit2:

Add Network Information provider for WebKit2 EFL
by using NetworkInfoProviderEfl class from
WebCore.

* CMakeLists.txt:
* PlatformEfl.cmake:
* UIProcess/API/efl/NetworkInfoProvider.cpp: Added.
(toNetworkInfoProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(getBandwidthCallback):
(isMeteredCallback):
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):
(NetworkInfoProvider::bandwidth):
(NetworkInfoProvider::metered):
(NetworkInfoProvider::startUpdating):
(NetworkInfoProvider::stopUpdating):
* UIProcess/API/efl/NetworkInfoProvider.h: Added.
(NetworkInfoProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: SASS source mapping straw man (behind experiment)
pfeldman@chromium.org [Thu, 26 Jul 2012 17:25:00 +0000 (17:25 +0000)]
Web Inspector: SASS source mapping straw man (behind experiment)
https://bugs.webkit.org/show_bug.cgi?id=92265

Reviewed by Vsevolod Vlasov.

This change introduces SASS mapping support (behind the experiment).

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.resourceBinding):
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype.resetSourceMappings):
(WebInspector.CSSStyleModel.prototype._rawLocationToUILocation):
(WebInspector.CSSLocation):
(WebInspector.CSSRule):
(WebInspector.CSSRule.prototype.get isRegular):
(WebInspector.CSSRule.prototype.uiLocation):
* inspector/front-end/ContentProviders.js:
(WebInspector.StaticContentProvider.prototype.contentType):
* inspector/front-end/SASSSourceMapping.js: Added.
(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._populate):
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(rawLocationToUILocation):
(uiLocationToRawLocation):
(uiSourceCodes):
(reset):
(WebInspector.SASSSource):
(WebInspector.SASSSource.prototype.isEditable):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
(WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/UISourceCode.js:
(WebInspector.UILocation.prototype.uiLocationToRawLocation):
(WebInspector.UILocation.prototype.url):
* inspector/front-end/Workspace.js:
(WebInspector.Workspace):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit should expose @title as label (AXTitle or AXDescription) sometimes instead...
cfleizach@apple.com [Thu, 26 Jul 2012 17:23:20 +0000 (17:23 +0000)]
WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
https://bugs.webkit.org/show_bug.cgi?id=91911

Reviewed by Anders Carlsson.

Source/WebCore:

The ARIA spec states that the title attribute should be used as the last resort for a description of an element. WebKit needs to honor that.

Test: platform/mac/accessibility/title-attribute-used-as-last-resort.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):

LayoutTests:

* platform/mac/accessibility/title-attribute-used-as-last-resort-expected.txt: Added.
* platform/mac/accessibility/title-attribute-used-as-last-resort.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
commit-queue@webkit.org [Thu, 26 Jul 2012 16:59:07 +0000 (16:59 +0000)]
[EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
https://bugs.webkit.org/show_bug.cgi?id=92387

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::EWK2UnitTestServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed r123761 follow-up, inspector closure compilation fix.
vsevik@chromium.org [Thu, 26 Jul 2012 16:54:44 +0000 (16:54 +0000)]
Unreviewed r123761 follow-up, inspector closure compilation fix.

* inspector/front-end/Script.js:
(WebInspector.Script.Location.prototype.uiLocation):
* inspector/front-end/ScriptSnippetModel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
paroga@webkit.org [Thu, 26 Jul 2012 16:50:44 +0000 (16:50 +0000)]
Cleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
https://bugs.webkit.org/show_bug.cgi?id=92113

Reviewed by Simon Hausmann.

Cleanup the definition of the two methods across different ports and
replace the calls to them with LocalWindowsContext where possible.

* platform/graphics/GraphicsContext.h:
(GraphicsContext):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Fix after r123733.
kbalazs@webkit.org [Thu, 26 Jul 2012 16:45:07 +0000 (16:45 +0000)]
[Qt] Unreviewed gardening. Fix after r123733.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Reskip fast/forms WK2 added results
commit-queue@webkit.org [Thu, 26 Jul 2012 16:44:11 +0000 (16:44 +0000)]
[Qt] Reskip fast/forms WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91504

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-26
Reviewed by Alexis Menard.

This patch reverts the added WK2 layout test results from r123156 "[Qt]
Added/updated missing fast/forms results after rebaseline". As discussed with
Caio, almost all of these additions were due to an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990), and a
few ones that are still failing independent of font changes (handled in bug
91610). These tests were reskipped and reassigned to proper bugs.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/forms/basic-inputs-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/basic-inputs-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/control-restrict-line-height-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/control-restrict-line-height-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/encoding-test-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-disabled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-disabled-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-focus-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-focus-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-preventDefault-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-readonly-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-readonly-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-visibility-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-baseline-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-baseline-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-readonly-dimmed-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-readonly-empty-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-spaces-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-click-inside-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-double-click-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-option-delete-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-word-wrap-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-width-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/placeholder-position-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/placeholder-position-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/search-display-none-cancel-button-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/search-rtl-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/search-vertical-alignment-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/search-vertical-alignment-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/text-style-color-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/text-style-color-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textfield-focus-ring-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textfield-outline-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textfield-overflow-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Introduce generic LiveLocation, make Script.Location inherit it.
vsevik@chromium.org [Thu, 26 Jul 2012 16:42:27 +0000 (16:42 +0000)]
Web Inspector: Introduce generic LiveLocation, make Script.Location inherit it.
https://bugs.webkit.org/show_bug.cgi?id=92388

Reviewed by Pavel Feldman.

Introduced abstract LiveLocation implemented by Script.Location.

* inspector/front-end/Script.js:
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.uiLocation):
(WebInspector.Script.Location.prototype.dispose):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.update):
(WebInspector.LiveLocation.prototype.rawLocation):
(WebInspector.LiveLocation.prototype.uiLocation):
(WebInspector.LiveLocation.prototype.dispose):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
rafael.lobo@openbossa.org [Thu, 26 Jul 2012 16:40:49 +0000 (16:40 +0000)]
[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91242

Reviewed by Alexis Menard.

Some leftovers were removed from qt-5.0-wk1 and wk2. If some of them
fail on qt-5.0-wk2, then they should be skipped again, but creating
proper bug reports for them.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.png: Removed.
* platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] readPixels on FBOs are limited to canvas size on SGX platforms
commit-queue@webkit.org [Thu, 26 Jul 2012 16:34:29 +0000 (16:34 +0000)]
[BlackBerry] readPixels on FBOs are limited to canvas size on SGX platforms
https://bugs.webkit.org/show_bug.cgi?id=92301

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Rob Buis.

This fixes fast/canvas/webgl/uninitialized-test.html on BlackBerry, no new tests.

* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: reduce auto refresh rate of the live native memory diagram
commit-queue@webkit.org [Thu, 26 Jul 2012 16:26:46 +0000 (16:26 +0000)]
Web Inspector: reduce auto refresh rate of the live native memory diagram
https://bugs.webkit.org/show_bug.cgi?id=92372

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-26
Reviewed by Pavel Feldman.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart.prototype.wasShown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobuildbot: Remove the configuration of hfreyther*
zecke@webkit.org [Thu, 26 Jul 2012 16:23:41 +0000 (16:23 +0000)]
buildbot: Remove the configuration of hfreyther*
https://bugs.webkit.org/show_bug.cgi?id=91849

Reviewed by Adam Roben.

The machine running these configs was decommissioned and
there is no replacement at this point. Remove them from the
configuration.

* BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
them too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Refactor BackingStorePrivate::BackingStorePrivate::clearAndUpdateTileOfN...
commit-queue@webkit.org [Thu, 26 Jul 2012 16:22:25 +0000 (16:22 +0000)]
[BlackBerry] Refactor BackingStorePrivate::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion() to avoid touching tile frontbuffer
https://bugs.webkit.org/show_bug.cgi?id=92095

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-26
Reviewed by George Staikos.

PR: 141439
Specifically, we want to avoid changing the rendered region of the
front buffer without proper synchronization.

The method is trying to force checkerboard to appear on screen because
an area was invalidated but the render job was dropped, so the tile
contents are now invalid.

Unfortunately it did this in a way which is not thread safe. Fixed by
making it thread safe, in a way that minimizes memory bandwidth usage.

Instead of using the customary sequence of copy-back, modify and swap,
we send a synchronous message to the compositing thread to avoid the
copy-back step and save memory bandwidth. The trade-off is that the
WebKit thread might wait a little longer for the compositing thread
than it would from a waitForCurrentMessage() call.

The way we synchronize this is rather expensive for the WebKit thread,
and this method is called rather carelessly, so add various early
returns to avoid doing it redundantly.

Internally reviewed by Jakob Petsovits and Adam Treat.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
* Api/BackingStore_p.h:
(BackingStorePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add GC button to the profiles panel toolbar.
commit-queue@webkit.org [Thu, 26 Jul 2012 16:17:21 +0000 (16:17 +0000)]
Web Inspector: add GC button to the profiles panel toolbar.
https://bugs.webkit.org/show_bug.cgi?id=92369

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-26
Reviewed by Pavel Feldman.

* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype._garbageCollectButtonClicked):
* inspector/front-end/profilesPanel.css:
(.garbage-collect-status-bar-item .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove region from HitTestResult to HitTestPoint.
allan.jensen@nokia.com [Thu, 26 Jul 2012 16:15:27 +0000 (16:15 +0000)]
Move region from HitTestResult to HitTestPoint.
https://bugs.webkit.org/show_bug.cgi?id=92367

Reviewed by Antonio Gomes.

Moves the region to HitTestPoint where it makes more sense, and use this
change to simplify hit-testing a new region in RenderFlowThread.

No new functionality. No new tests.

* rendering/HitTestResult.cpp:
(WebCore::HitTestPoint::HitTestPoint):
(WebCore::HitTestPoint::operator=):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
* rendering/HitTestResult.h:
(HitTestPoint):
(WebCore::HitTestPoint::region):
(HitTestResult):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestRegion):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: ExtensionView constructor shouldn't take parent argument
commit-queue@webkit.org [Thu, 26 Jul 2012 16:12:32 +0000 (16:12 +0000)]
Web Inspector: ExtensionView constructor shouldn't take parent argument
https://bugs.webkit.org/show_bug.cgi?id=92326

Patch by Jan Keromnes <janx@linux.com> on 2012-07-26
Reviewed by Pavel Feldman.

ExtensionView's constructor took a parent element parameter and auto-
showed itself in the constructor. This didn't allow lazy showing and
was confusing because it didn't work like a classic View object. Fixed.

No new tests needed: Refactoring with no behavior changes.

* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
* inspector/front-end/ExtensionView.js:
(WebInspector.ExtensionView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add unit tests for Ewk_Context
commit-queue@webkit.org [Thu, 26 Jul 2012 16:04:20 +0000 (16:04 +0000)]
[EFL][WK2] Add unit tests for Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=92005

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Antonio Gomes.

Add unit tests for WebKit2 Ewk_Context.

* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_url_scheme_request.cpp:
(ewk_url_scheme_request_finish):
* UIProcess/API/efl/ewk_url_scheme_request.h: Mark content_data
argument as const.
* UIProcess/API/efl/tests/test_ewk2_context.cpp: Added.
(TEST_F):
(schemeRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Refactor BackingStorePrivate::render() to avoid touching tile frontbuffer
commit-queue@webkit.org [Thu, 26 Jul 2012 16:00:16 +0000 (16:00 +0000)]
[BlackBerry] Refactor BackingStorePrivate::render() to avoid touching tile frontbuffer
https://bugs.webkit.org/show_bug.cgi?id=91989

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-26
Reviewed by George Staikos.

PR: 141439
Specifically, we want to avoid changing the rendered region of the
front buffer. The code only touched the front buffer rendered region
if the tile was not committed.

Instead of immediately marking the tile as committed, and clearing the
front buffer's rendered region to make it appear as checkerboard, we
leave the front buffer alone and only mark the tile as committed once
the front buffer has valid content. Un-committed tiles will also be
rendered as checkerboard, so leaving it uncommitted is equivalent to
clearing the front buffer rendered region here.

In addition to the main change, some related changes follow naturally.

The copyPreviousContentsToBackSurfaceOfTile() call only makes sense if
the tile is committed, and the front buffer has valid content.
Otherwise, clearing the back buffer is equivalent. The code has been
updated to this effect.

Since copyPreviousContentsToBackSurfaceOfTile() always sets the
rendered region to the union of the front and back buffer regions,
there is no point in the "backBufferIsValid" check. It has been turned
into an ASSERT instead, just to make sure.

Internally reviewed by Jakob Petsovits.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] editing/selection tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Thu, 26 Jul 2012 15:51:45 +0000 (15:51 +0000)]
[Qt] editing/selection tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92186

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-26
Reviewed by Alexis Menard.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, editing/selection tests directory needs to be
updated.

It is important to notice some Qt WK2 layout tests are still failing, some
requires more investigation (handled in bug 91610) and others have a known cause
(input text and text areas differ in WK2 - bug 91990).

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/editing/selection/select-box-expected.png:
* platform/qt-5.0-wk2/editing/selection/select-box-expected.txt:
* platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.txt:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/editing/selection/editable-html-element-expected.txt:
* platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt:
* platform/qt-5.0/editing/selection/select-box-expected.png:
* platform/qt-5.0/editing/selection/select-box-expected.txt:
* platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.txt:
* platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/qt/editing/selection/5825350-1-expected.txt:
* platform/qt/editing/selection/5825350-2-expected.txt:
* platform/qt/editing/selection/drag-start-event-client-x-y-expected.txt:
* platform/qt/editing/selection/fake-doubleclick-expected.png:
* platform/qt/editing/selection/fake-doubleclick-expected.txt:
* platform/qt/editing/selection/hit-test-on-text-with-line-height-expected.txt:
* platform/qt/editing/selection/unrendered-001-expected.png:
* platform/qt/editing/selection/unrendered-001-expected.txt:
* platform/qt/editing/selection/unrendered-002-expected.png:
* platform/qt/editing/selection/unrendered-002-expected.txt:
* platform/qt/editing/selection/unrendered-003-expected.png:
* platform/qt/editing/selection/unrendered-003-expected.txt:
* platform/qt/editing/selection/unrendered-004-expected.png:
* platform/qt/editing/selection/unrendered-004-expected.txt:
* platform/qt/editing/selection/unrendered-005-expected.png:
* platform/qt/editing/selection/unrendered-005-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebGL] ANGLEWebKitBridge should support ESSL platforms
commit-queue@webkit.org [Thu, 26 Jul 2012 15:25:47 +0000 (15:25 +0000)]
[WebGL] ANGLEWebKitBridge should support ESSL platforms
https://bugs.webkit.org/show_bug.cgi?id=92295

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Rob Buis.

This tells ANGLEWebKitBridge to output ESSL code for the BlackBerry
platform. This eliminates the need for a previous hack. In addition,
some (GLSL) ANGLE output that could not be compiled (for example,
glsl-mat4-to-mat3.html) now compiles.

* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: replace "textInput" keyboard event listener breakpoint with "input"
pfeldman@chromium.org [Thu, 26 Jul 2012 15:21:58 +0000 (15:21 +0000)]
Web Inspector: replace "textInput" keyboard event listener breakpoint with "input"
https://bugs.webkit.org/show_bug.cgi?id=92384

Reviewed by Vsevolod Vlasov.

* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a MediaPlayer API to retrieve the description of the current media engine.
jer.noble@apple.com [Thu, 26 Jul 2012 15:10:00 +0000 (15:10 +0000)]
Add a MediaPlayer API to retrieve the description of the current media engine.
https://bugs.webkit.org/show_bug.cgi?id=92336

Reviewed by Eric Carlson.

Add a utility function which retrieves, for diagnostic purposes, a brief description
of the current media engine. Stubs have been added for each of the MediaPlayerPrivate
subclasses which return the name of the class.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::engineDescription):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::engineDescription):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::engineDescription):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(WebCore::MediaPlayerPrivate::engineDescription):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::engineDescription):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(WebCore::MediaPlayerPrivateQTKit::engineDescription):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivateQt::engineDescription):
* platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(WebCore::MediaPlayerPrivate::engineDescription):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::engineDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Edits of styles declared after invalid selector are not applied
pfeldman@chromium.org [Thu, 26 Jul 2012 15:08:14 +0000 (15:08 +0000)]
Web Inspector: Edits of styles declared after invalid selector are not applied
https://bugs.webkit.org/show_bug.cgi?id=92382

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Now popping selectorless rules as well.

Test: inspector/styles/styles-edit-property-after-invalid-rule.html

* css/CSSParser.cpp:
(WebCore::CSSParser::createStyleRule):

LayoutTests:

Additional information of the change such as approach, rationale.

* inspector/styles/styles-edit-property-after-invalid-rule-expected.txt: Added.
* inspector/styles/styles-edit-property-after-invalid-rule.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebGL] GraphicsContext3D::readPixels has extraneous code from GraphicsContext3D...
commit-queue@webkit.org [Thu, 26 Jul 2012 14:54:23 +0000 (14:54 +0000)]
[WebGL] GraphicsContext3D::readPixels has extraneous code from GraphicsContext3D::readPixelsIMG
https://bugs.webkit.org/show_bug.cgi?id=92302

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Noam Rosenthal.

This undoes a mistake from https://bugs.webkit.org/show_bug.cgi?id=90567.

No new tests, because it introduces no new functionality, but it makes the WebGL aquarium demo
run quite a bit smoother on SGX :)

* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Revert r123740 as it breaks AppleMac compilation.
yurys@chromium.org [Thu, 26 Jul 2012 14:49:36 +0000 (14:49 +0000)]
Unreviewed. Revert r123740 as it breaks AppleMac compilation.

Source/WebCore:

* WebCore.exp.in:
* inspector/InspectorMemoryAgent.cpp:
(WebCore):

Source/WTF:

* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix AppleMac compilation after r123740.
yurys@chromium.org [Thu, 26 Jul 2012 14:40:08 +0000 (14:40 +0000)]
Unreviewed. Fix AppleMac compilation after r123740.

* WebCore.exp.in: Added missing symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add form client for Ewk_View
commit-queue@webkit.org [Thu, 26 Jul 2012 13:28:25 +0000 (13:28 +0000)]
[EFL][WK2] Add form client for Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=92358

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Implement a form client for EFL port in order to
send a "form,request,new" signal on the Ewk_View
whenever a form will be submitted.

The Ewk_Form_Submission_Request type is
introduced to provide the client with information
about the form (e.g. text fields contained in the
form) and to submit it.

This is typically used to store login information
that can be used later to pre-fill the form.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_form_submission_request.cpp: Added.
(_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::~_Ewk_Form_Submission_Request):
(ewk_form_submission_request_ref):
(ewk_form_submission_request_unref):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
(ewk_form_submission_request_submit):
(ewk_form_submission_request_new):
* UIProcess/API/efl/ewk_form_submission_request.h: Added.
* UIProcess/API/efl/ewk_form_submission_request_private.h: Added.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
(ewk_view_form_submission_request_new):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_form_client.cpp: Added.
(willSubmitForm):
(ewk_view_form_client_attach):
* UIProcess/API/efl/ewk_view_form_client_private.h: Added.
* UIProcess/API/efl/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123742 268f45cc-cd09-0410-ab3c-d52691b4dbfc