13 years ago Reviewed by Mark Rowe.
mjs [Mon, 24 Sep 2007 01:23:37 +0000 (01:23 +0000)]
    Reviewed by Mark Rowe.

        - Limit custom list bullets to ordered lists only

        * css/blue.css:
        * css/gray.css:
        * css/green.css:
        * css/ie.css:
        * css/main.css:
        * css/pink.css:
        * css/purple.css:
        * css/yellow.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning.
bdash [Mon, 24 Sep 2007 00:21:47 +0000 (00:21 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitSite:
ddkilzer [Sun, 23 Sep 2007 16:38:43 +0000 (16:38 +0000)]

        Reviewed by Adam.

        * coding/coding-style.html:
          - in section Other Punctuation
            - syntax instead of synatax
            - fix sample code alignment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago/:
zecke [Sun, 23 Sep 2007 09:50:35 +0000 (09:50 +0000)]
2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber stamped by Adam.

        Renamed files from *Gdk to *Gtk (see #14732) using the
        work of Juan A. Suarez Romero as a base.

        GDK -> GTK

        * WebKit.pri:
        * WebKit.pro:

2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber stamped by Adam.

        Renamed files from *Gdk to *Gtk (see #14732) using the
        work of Juan A. Suarez Romero as a base.

        GDK -> GTK

        * JavaScriptCore.pri:
        * kjs/testkjs.pro:
        * pcre/dftables.pro:
        * wtf/Platform.h: PLATFORM(GDK) to PLATFORM(GTK)

2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber stamped by Adam.

        Renamed files from *Gdk to *Gtk (see #14732) using the
        work of Juan A. Suarez Romero as a base.

        GDK -> GTK

        * Projects/gdk/webcore-gdk.bkl:
        * WebCore.pro:
        * WebCoreSources.bkl:
        * loader/gdk: Removed.
        * loader/gdk/DocumentLoaderGdk.cpp: Removed.
        * loader/gtk: Added.
        * loader/gtk/DocumentLoaderGdk.cpp: Removed.
        * loader/gtk/DocumentLoaderGtk.cpp: Added.
        * page/FrameView.cpp:
        * page/FrameView.h:
        * page/gdk: Removed.
        * page/gdk/DragControllerGdk.cpp: Removed.
        * page/gdk/EventHandlerGdk.cpp: Removed.
        * page/gdk/FrameGdk.cpp: Removed.
        * page/gtk: Added.
        * page/gtk/DragControllerGdk.cpp: Removed.
        * page/gtk/DragControllerGtk.cpp: Added.
        * page/gtk/EventHandlerGdk.cpp: Removed.
        * page/gtk/EventHandlerGtk.cpp: Added.
        * page/gtk/FrameGdk.cpp: Removed.
        * page/gtk/FrameGtk.cpp: Added.
        * platform/ContextMenuItem.h:
        * platform/Cursor.h:
        * platform/DragData.h:
        * platform/DragImage.h:
        * platform/FontData.h:
        * platform/NotImplemented.h:
        * platform/PlatformKeyboardEvent.h:
        * platform/PlatformMenuDescription.h:
        * platform/PlatformMouseEvent.h:
        * platform/PlatformWheelEvent.h:
        * platform/ScrollView.h:
        * platform/Widget.h:
        * platform/gdk: Removed.
        * platform/gdk/ClipboardGdk.cpp: Removed.
        * platform/gdk/ClipboardGdk.h: Removed.
        * platform/gdk/ContextMenuGdk.cpp: Removed.
        * platform/gdk/ContextMenuItemGdk.cpp: Removed.
        * platform/gdk/CookieJarGdk.cpp: Removed.
        * platform/gdk/CursorGdk.cpp: Removed.
        * platform/gdk/DragDataGdk.cpp: Removed.
        * platform/gdk/DragImageGdk.cpp: Removed.
        * platform/gdk/FileChooserGdk.cpp: Removed.
        * platform/gdk/FileSystemGdk.cpp: Removed.
        * platform/gdk/FontCacheGdk.cpp: Removed.
        * platform/gdk/FontDataGdk.cpp: Removed.
        * platform/gdk/FontGdk.cpp: Removed.
        * platform/gdk/FontPlatformData.h: Removed.
        * platform/gdk/FontPlatformDataGdk.cpp: Removed.
        * platform/gdk/GlyphPageTreeNodeGdk.cpp: Removed.
        * platform/gdk/KeyEventGdk.cpp: Removed.
        * platform/gdk/KeyboardCodes.h: Removed.
        * platform/gdk/LocalizedStringsGdk.cpp: Removed.
        * platform/gdk/LoggingGdk.cpp: Removed.
        * platform/gdk/MIMETypeRegistryGdk.cpp: Removed.
        * platform/gdk/MouseEventGdk.cpp: Removed.
        * platform/gdk/PasteboardGdk.cpp: Removed.
        * platform/gdk/PlatformScreenGdk.cpp: Removed.
        * platform/gdk/PlatformScrollBar.h: Removed.
        * platform/gdk/PlatformScrollBarGdk.cpp: Removed.
        * platform/gdk/PopupMenuGdk.cpp: Removed.
        * platform/gdk/RenderThemeGdk.cpp: Removed.
        * platform/gdk/RenderThemeGdk.h: Removed.
        * platform/gdk/ScrollViewGdk.cpp: Removed.
        * platform/gdk/SearchPopupMenuGdk.cpp: Removed.
        * platform/gdk/SharedTimerLinux.cpp: Removed.
        * platform/gdk/SoundGdk.cpp: Removed.
        * platform/gdk/SystemTimeLinux.cpp: Removed.
        * platform/gdk/TemporaryLinkStubs.cpp: Removed.
        * platform/gdk/WheelEventGdk.cpp: Removed.
        * platform/gdk/WidgetGdk.cpp: Removed.
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/gdk: Removed.
        * platform/graphics/gdk/IconGdk.cpp: Removed.
        * platform/graphics/gdk/ImageGdk.cpp: Removed.
        * platform/graphics/gtk: Added.
        * platform/graphics/gtk/IconGdk.cpp: Removed.
        * platform/graphics/gtk/IconGtk.cpp: Added.
        * platform/graphics/gtk/ImageGdk.cpp: Removed.
        * platform/graphics/gtk/ImageGtk.cpp: Added.
        * platform/gtk: Added.
        * platform/gtk/ClipboardGdk.cpp: Removed.
        * platform/gtk/ClipboardGdk.h: Removed.
        * platform/gtk/ClipboardGtk.cpp: Added.
        * platform/gtk/ClipboardGtk.h: Added.
        * platform/gtk/ContextMenuGdk.cpp: Removed.
        * platform/gtk/ContextMenuGtk.cpp: Added.
        * platform/gtk/ContextMenuItemGdk.cpp: Removed.
        * platform/gtk/ContextMenuItemGtk.cpp: Added.
        * platform/gtk/CookieJarGdk.cpp: Removed.
        * platform/gtk/CookieJarGtk.cpp: Added.
        * platform/gtk/CursorGdk.cpp: Removed.
        * platform/gtk/CursorGtk.cpp: Added.
        * platform/gtk/DragDataGdk.cpp: Removed.
        * platform/gtk/DragDataGtk.cpp: Added.
        * platform/gtk/DragImageGdk.cpp: Removed.
        * platform/gtk/DragImageGtk.cpp: Added.
        * platform/gtk/FileChooserGdk.cpp: Removed.
        * platform/gtk/FileChooserGtk.cpp: Added.
        * platform/gtk/FileSystemGdk.cpp: Removed.
        * platform/gtk/FileSystemGtk.cpp: Added.
        * platform/gtk/FontCacheGdk.cpp: Removed.
        * platform/gtk/FontCacheGtk.cpp: Added.
        * platform/gtk/FontDataGdk.cpp: Removed.
        * platform/gtk/FontDataGtk.cpp: Added.
        * platform/gtk/FontGdk.cpp: Removed.
        * platform/gtk/FontGtk.cpp: Added.
        * platform/gtk/FontPlatformDataGdk.cpp: Removed.
        * platform/gtk/FontPlatformDataGtk.cpp: Added.
        * platform/gtk/GlyphPageTreeNodeGdk.cpp: Removed.
        * platform/gtk/GlyphPageTreeNodeGtk.cpp: Added.
        * platform/gtk/KeyEventGdk.cpp: Removed.
        * platform/gtk/KeyEventGtk.cpp: Added.
        * platform/gtk/LocalizedStringsGdk.cpp: Removed.
        * platform/gtk/LocalizedStringsGtk.cpp: Added.
        * platform/gtk/LoggingGdk.cpp: Removed.
        * platform/gtk/LoggingGtk.cpp: Added.
        * platform/gtk/MIMETypeRegistryGdk.cpp: Removed.
        * platform/gtk/MIMETypeRegistryGtk.cpp: Added.
        * platform/gtk/MouseEventGdk.cpp: Removed.
        * platform/gtk/MouseEventGtk.cpp: Added.
        * platform/gtk/PasteboardGdk.cpp: Removed.
        * platform/gtk/PasteboardGtk.cpp: Added.
        * platform/gtk/PlatformScreenGdk.cpp: Removed.
        * platform/gtk/PlatformScreenGtk.cpp: Added.
        * platform/gtk/PlatformScrollBarGdk.cpp: Removed.
        * platform/gtk/PlatformScrollBarGtk.cpp: Added.
        * platform/gtk/PopupMenuGdk.cpp: Removed.
        * platform/gtk/PopupMenuGtk.cpp: Added.
        * platform/gtk/RenderThemeGdk.cpp: Removed.
        * platform/gtk/RenderThemeGdk.h: Removed.
        * platform/gtk/RenderThemeGtk.cpp: Added.
        * platform/gtk/RenderThemeGtk.h: Added.
        * platform/gtk/ScrollViewGdk.cpp: Removed.
        * platform/gtk/ScrollViewGtk.cpp: Added.
        * platform/gtk/SearchPopupMenuGdk.cpp: Removed.
        * platform/gtk/SearchPopupMenuGtk.cpp: Added.
        * platform/gtk/SoundGdk.cpp: Removed.
        * platform/gtk/SoundGtk.cpp: Added.
        * platform/gtk/WheelEventGdk.cpp: Removed.
        * platform/gtk/WheelEventGtk.cpp: Added.
        * platform/gtk/WidgetGdk.cpp: Removed.
        * platform/gtk/WidgetGtk.cpp: Added.
        * platform/network/ResourceHandle.h:

2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber stamped by Adam.

        * GdkLauncher: Removed.
        * GdkLauncher/Bakefiles.bkgen: Removed.
        * GdkLauncher/ENV: Removed.
        * GdkLauncher/GdkLauncher.pro: Removed.
        * GdkLauncher/gdklauncher.bkl: Removed.
        * GdkLauncher/main.cpp: Removed.
        * GdkLauncher/mk: Removed.
        * GdkLauncher/simple.svg: Removed.
        * GdkLauncher/text.html: Removed.
        * GtkLauncher: Added.
        * GtkLauncher/GdkLauncher.pro: Removed.
        * GtkLauncher/GtkLauncher.pro: Added.
        * GtkLauncher/main.cpp:
        * Scripts/build-webkit:
        * Scripts/regenerate-makefiles:
        * Scripts/run-javascriptcore-tests:
        * Scripts/run-launcher:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
rwlbuis [Sun, 23 Sep 2007 08:55:50 +0000 (08:55 +0000)]
    Reviewed by Hyatt.

        Background repeat css property is not inherited from parent if unspecified

        Don't let invalid url specification in background shorthand make
        the entire shorthand invalid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or...
aroben [Sun, 23 Sep 2007 04:03:20 +0000 (04:03 +0000)]
 Fix Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value


         Fix Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value


         Reviewed by Maciej.

         Test: fast/forms/range-reset.html

         * html/HTMLInputElement.cpp:
         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): <input
         type=range> should be storing its value separately from the value
         attribute, as do all of our variable-input input types.


         Test for Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value


         Reviewed by Maciej.

         * fast/forms/range-reset-expected.txt: Added.
         * fast/forms/range-reset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-21 Mark Rowe <mrowe@apple.com>
bdash [Sat, 22 Sep 2007 04:20:59 +0000 (04:20 +0000)]
2007-09-21  Mark Rowe  <mrowe@apple.com>

        Build fix for non-Mac platforms after r25697.

        Rename Frame::cleanupPlatformScriptObjects to Frame::clearPlatformScriptObjects.

        * bridge/win/FrameWin.cpp:
        * page/gdk/FrameGdk.cpp:
        * page/qt/FrameQt.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele [Sat, 22 Sep 2007 03:56:30 +0000 (03:56 +0000)]

        Reviewed by Sam.

        Fix for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page

        Test: fast/dom/HTMLSelectElement/options-collection-set-string-length.html

        * bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength):
          Convert the value to a number.  We already have code here to check if the value is not a number.
          This matches other browsers, which allow a string value to be used to set the length.


        Reviewed by Sam.

        Test for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page

        * fast/dom/HTMLSelectElement/options-collection-set-string-length-expected.txt: Added.
        * fast/dom/HTMLSelectElement/options-collection-set-string-length.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
thatcher [Sat, 22 Sep 2007 00:49:09 +0000 (00:49 +0000)]

        Reviewed by Darin.

        <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded

        Calling -[WebView windowScriptObject] before the page loads would give you nil. This behavior didn't match Tiger.
        The API behavior in Tiger let you get the window script object once and keep ahold of it as long as you needed it.
        The window object would remain valid even after page loads. This change restores the Tiger behavior.

        <rdar://problem/5495790> NULL dereference crash beneath Bindings::RootObject::interpreter when saving Dashcode document

        The changes to WebScriptObject's _isSafeScript call also fixed the crash in Dashcode.

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject _setOriginRootObject:andRootObject:]): New method used to update the the root objects,
        so the WebScriptObject can still be used after a page load.
        (-[WebScriptObject _isSafeScript]): Call [self _rootObject] instead of accessing the data member directly.
        DOMNode has an override for the _rootObject method, and it can return 0 when _private->_rootObject
        is non-zero. We would return YES here when it wasn't safe and later crash with my modified layout tests.
        Checking _rootObject first prevents other calls sites from needing to check for a valid root object,
        this fixed the Dashcode crash.
        (-[WebScriptObject _imp]): Ditto.

        * bindings/objc/WebScriptObjectPrivate.h: Add _setOriginRootObject:andRootObject:.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear): Call the renamed clearScriptObjects function.
        (WebCore::FrameLoader::dispatchWindowObjectAvailable): Some gratuitous code cleanup.

        * page/Frame.cpp:
        (WebCore::Frame::clearScriptObjects): Renamed cleanupScriptObject to clearScriptObjects.
        Call clearPlatformScriptObjects last so m_bindingRootObject is already NULL.
        (WebCore::Frame::windowScriptNPObject): Hold a JSLock before accessing the window. This
        change is unrelated to the bug, but should be fixed.

        * page/mac/FrameMac.mm:
        (WebCore::Frame::windowScriptObject): Return a script object even if the interpreter is NULL.
        This resotres the Tiger behavior of always being able to access the window object.
        (WebCore::Frame::clearPlatformScriptObjects): Keep the window script object around, and update
        the root objects for the window script object.

        * page/Frame.h: Rename cleanupScriptObject to clearScriptObjects.
        * page/FramePrivate.h: Use a RetainPtr for m_windowScriptObject.


        Reviewed by Darin.

        <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)

        Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
        This is tested by plugins/root-object-premature-delete-crash.html.

        * DumpRenderTree/mac/ObjCController.m:
        (-[ObjCController accessStoredWebScriptObject]):


        Reviewed by Darin.

        <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)

        Updated results to show the didClearWindowScriptObject delegate call. Tweaked plugins/root-object-premature-delete-crash.html
        to test a non-window script object half the time. This change works with a change to DumpRenderTree.

        * http/tests/loading/empty-subframe-expected.txt:
        * http/tests/loading/simple-subframe-expected.txt:
        * plugins/root-object-premature-delete-crash.html:
        * webarchive/loading/test-loading-archive-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-21 Mike Fenton <mike@staikos.net>
staikos [Sat, 22 Sep 2007 00:30:22 +0000 (00:30 +0000)]
2007-09-21  Mike Fenton  <mike@staikos.net>

        Reviewed by George Staikos.

        Fix styled pen support by not clobbering QPen properties.

        * html/CanvasStyle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDarin reviewed as well, and pointed out mistake in ChangeLog
oliver [Sat, 22 Sep 2007 00:00:59 +0000 (00:00 +0000)]
Darin reviewed as well, and pointed out mistake in ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tristan.
oliver [Fri, 21 Sep 2007 23:51:47 +0000 (23:51 +0000)]
    Reviewed by Tristan.

        <rdar://problem/5491955> REGRESSION (r25547): With Hanin IME, one cannot input characters into forms (15239)

        This problem was caused by the setComposition method failing to clearing
        the composition markers in the presence of an empty string.  This would
        result in the caret being locked within the 0 length bounds of the "composition"
        and so preventing basic keyboard interaction.

        * editing/Editor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tristan.
adele [Fri, 21 Sep 2007 23:29:14 +0000 (23:29 +0000)]
    Reviewed by Tristan.

        Fix for <rdar://problem/5497346> "Check spelling when I click Send" crashes on stationery messages every time

        No test. I wasn't able to find a way to get this to occur with Safari or DumpRenderTree.

        * editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): Updated comment.
        * editing/htmlediting.cpp:
        (WebCore::firstEditablePositionAfterPositionInRoot): Only return the root position if its editable.
        (WebCore::maxDeepOffset): Added nil check & assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Steve.
andersca [Fri, 21 Sep 2007 23:18:18 +0000 (23:18 +0000)]
    Reviewed by Steve.

        Site redirects continuosly, starving UI thread, causing app to hang.

        Use GetQueueStatus to see if there are input messages in the queue that aren't being processed.
        If so, use a low-priority timer instead of PostMessage.

        * platform/win/SharedTimerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
darin [Fri, 21 Sep 2007 22:47:35 +0000 (22:47 +0000)]
    Reviewed by Anders.

        - add QueryInterface capabilities to COMPtr

        * platform/win/COMPtr.h:
        (COMPtr::COMPtr): Added constructor that takes a Query tag and
        does an appropriate QueryInterface.
        (COMPtr::query): Added function to do a queryInterface.
        (COMPtr::copyQueryInterfaceRef): Added private helper used by
        both of the above. Note that when the query fails you get a 0,
        which is the same thing you get if a 0 pointer is passed in.

        * platform/win/FontCacheWin.cpp:
        (WebCore::FontCache::getFontLinkInterface): Convert to using
        the new query as a test case. Also eliminate the unnecessary
        second global variable and use COMPtr objects rather than just
        leaking references.

        * platform/win/WCDataObject.h: Removed unneeded include and
        using statements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca [Fri, 21 Sep 2007 21:58:55 +0000 (21:58 +0000)]
    Reviewed by Adam.

        clicking any link in the Flash regions at bananarepublic.com results in bad page

        Don't replace the frame contents, the Mac version doesn't do this.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca [Fri, 21 Sep 2007 20:15:51 +0000 (20:15 +0000)]
    Reviewed by Darin.

        Repro crash loading http://www.tivo.com/whatistivo/tivohd/index.html

        Don't continue if the plug-in cancelled the stream.

        * loader/win/NetscapePlugInStreamLoaderWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
kmccullo [Fri, 21 Sep 2007 20:12:26 +0000 (20:12 +0000)]
    Reviewed by Oliver.

        - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)

        * DumpRenderTree/win/FrameLoaderDelegate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * Plugins/WebBaseNetscapePluginView.mm: Build fix.
kdecker [Fri, 21 Sep 2007 19:48:16 +0000 (19:48 +0000)]
    * Plugins/WebBaseNetscapePluginView.mm: Build fix.
        The first argument of aglChoosePixelFormat() has changed from const AGLDevice *gdevs on Tiger to
        const void *gdevs on Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
kdecker [Fri, 21 Sep 2007 19:15:42 +0000 (19:15 +0000)]
    Reviewed by Darin Adler.


        Reduced launch time by lazily linking both the AGL and OpenGL frameworks until they are really needed.

        * Plugins/WebBaseNetscapePluginView.mm: Soft link all AGL and OpenGL functions used by

        * WebKit.xcodeproj/project.pbxproj: Removed AGL and OpenGL from the project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * platform/mac/SoftLinking.h: Build fix; added necessary #imports.
kdecker [Fri, 21 Sep 2007 19:14:50 +0000 (19:14 +0000)]
    * platform/mac/SoftLinking.h: Build fix; added necessary #imports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
kdecker [Fri, 21 Sep 2007 19:06:55 +0000 (19:06 +0000)]
    Reviewed by Darin Adler.

        * WebCore.xcodeproj/project.pbxproj: Added SoftLinking.h to the project.
        * platform/mac/SoftLinking.h: Contains a new macro; useful in helping to lazily load frameworks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - Fixed a syntax guideline mistake.
kmccullo [Fri, 21 Sep 2007 17:15:15 +0000 (17:15 +0000)]
    - Fixed a syntax guideline mistake.

        * WebChromeClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-21 Mark Rowe <mrowe@apple.com>
bdash [Fri, 21 Sep 2007 11:06:33 +0000 (11:06 +0000)]
2007-09-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Antti Koivisto.

        <rdar://problem/5496942> REGRESSION: Reproducible crash in Safari when evaluating script in Drosera console (15250)

        * kjs/function.cpp:
        (KJS::GlobalFuncImp::callAsFunction): Null-check thisObj before passing it to interpreterForGlobalObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-20 Oliver Hunt <oliver@apple.com>
oliver [Fri, 21 Sep 2007 07:02:55 +0000 (07:02 +0000)]
2007-09-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Steve.

        <rdar://problem/5487153> Korean characters are displayed as garbage with default encoding in some Korean web sites

        Adding support for per-localisation default character encodings on

        * English.lproj/Localizable.strings:
        * WebPreferences.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
kmccullo [Fri, 21 Sep 2007 00:48:58 +0000 (00:48 +0000)]
    Reviewed by Oliver.

        - Added the ability to ask if scrollbars are visible
        - <rdar://problem/5496211> scrollbarsVisible in WebChromeClient is not implemented

        * WebChromeClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoIgnore WebKitAuxiliaryLibraries files put here by update-webkit.
darin [Fri, 21 Sep 2007 00:28:34 +0000 (00:28 +0000)]
Ignore WebKitAuxiliaryLibraries files put here by update-webkit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoIgnore WebKitAuxiliaryLibraries files put here by the update-webkit script.
darin [Fri, 21 Sep 2007 00:27:35 +0000 (00:27 +0000)]
Ignore WebKitAuxiliaryLibraries files put here by the update-webkit script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5477240> Regression: Footer is too high in print preview
adachan [Fri, 21 Sep 2007 00:19:49 +0000 (00:19 +0000)]
    <rdar://problem/5477240> Regression: Footer is too high in print preview

        Reviewed by Steve.

        Make computePageRectsForFrame() return the height of the page adjusted for margins.

        * bridge/win/FrameWin.cpp:
        * bridge/win/FrameWin.h:

        * WebFrame.cpp:
        (WebFrame::WebFrame): initialize new data member m_pageHeight, which is the height of the page adjusted for margins.
        (WebFrame::computePageRects): get the height of the page adjusted for margins by passing m_pageHeight to
        (WebFrame::spoolPages): footer rect's top is the max of the bottom of the page content and the bottom of the page
        minus footer height.
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
kmccullo [Thu, 20 Sep 2007 23:26:41 +0000 (23:26 +0000)]

        Reviewed by Hyatt.

        - <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
        - Implementing missing scrollbar functionality to allow turning off scrollbars correctly.

        * platform/ScrollView.h:
        * platform/win/ScrollViewWin.cpp:


        Reviewed by Hyatt.

        - <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
        - Implementing missing scrollbar functionality to allow turning off scrollbars correctly.

        * Interfaces/IWebFrame.idl:
        * Interfaces/IWebFrameView.idl:
        * WebChromeClient.cpp:
        * WebFrame.cpp:
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Thu, 20 Sep 2007 23:13:20 +0000 (23:13 +0000)]
        Reviewed by Dave Hyatt

        <rdar://problem/5245981> - No favicon shows up for cnet.com

        CNet's favicon has two images in it - a 32x32 white square, and a 16x16 image that is their actual icon
        Till now on Windows we've always gone straight for the first image in an icon for the favicon, now we
        actually do proper size matching

        * platform/graphics/BitmapImage.h:

        * platform/graphics/Image.h:
        (WebCore::Image::drawFrameMatchingSourceSize): Search through the frames of the image for the correct size

        * platform/graphics/win/ImageWin.cpp:

        Reviewed by Dave Hyatt

        <rdar://problem/5245981> - No favicon shows up for cnet.com

        * WebIconDatabase.cpp:
        (WebIconDatabase::iconForURL): Call getHBITMAPOfSize
        (WebIconDatabase::getOrCreateDefaultIconBitmap): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
sfalken [Thu, 20 Sep 2007 21:58:38 +0000 (21:58 +0000)]
    Reviewed by Brady.

        Call ascii() instead of utf8() from debug logging code to avoid threading
        issues associated w/ converting to UTF8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-20 Mike Fenton <mike@staikos.net>
staikos [Thu, 20 Sep 2007 18:53:10 +0000 (18:53 +0000)]
2007-09-20  Mike Fenton  <mike@staikos.net>

        Reviewed by George Staikos.

        Implement gradients and more of canvas for Qt.  Style changes and some
        of the stroking fixes by George.

        * html/CanvasGradient.cpp:
        * html/CanvasGradient.h:
        * html/CanvasRenderingContext2D.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix for stoooopid old PPC gcc compiler
sullivan [Thu, 20 Sep 2007 17:26:24 +0000 (17:26 +0000)]
    Build fix for stoooopid old PPC gcc compiler

        * WebCoreSupport/WebEditorClient.mm:
        replace perfectly valid ?: syntax with if/else

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
ddkilzer [Thu, 20 Sep 2007 11:05:39 +0000 (11:05 +0000)]

        Reviewed by Adam.

        Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
        webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt

        Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
        Now isQt() and isGdk() use global variables that are only set once.

        An array of all the parameters is now given to build-dumprender which includes
        the platform on linux.

        * Scripts/build-dumprendertree:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded radar.
ddkilzer [Thu, 20 Sep 2007 10:53:56 +0000 (10:53 +0000)]
Added radar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
rwlbuis [Thu, 20 Sep 2007 08:52:09 +0000 (08:52 +0000)]
    Reviewed by Mitz.

        Options can not be removed from a Select element with OptGroup's using JavaScript

        Remove HTMLOptionElement children against the proper parent node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBump version for submit
sfalken [Thu, 20 Sep 2007 06:44:02 +0000 (06:44 +0000)]
Bump version for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber stamped by Adam Roben.
weinig [Thu, 20 Sep 2007 05:56:17 +0000 (05:56 +0000)]
    Rubber stamped by Adam Roben.

        * WebKit.vcproj/WebKit.sln: Update location of DumpRenderTree and TestNetscapePlugin
        to point to their new locations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning.
bdash [Thu, 20 Sep 2007 02:03:52 +0000 (02:03 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
sullivan [Thu, 20 Sep 2007 00:43:38 +0000 (00:43 +0000)]

        Reviewed by Darin Adler.

        - WebCore part of speculative fix for <rdar://problem/5490627>, about crashes constructing a
          String using the values filled in by checkSpellingOfString()

        * editing/Editor.cpp:
        initialize out parameters the way we do elsewhere; add many assertions for improper results
        from checkSpellingOfString(); don't create a String at all until we've checked all the ways
        that checkSpellingOfString() results could indicate invalid string, even the unexpected ones;
        as an optimization, don't construct a String at all when looping through to mark all instances.


        Reviewed by Darin Adler.

        - WebKit part of speculative fix for <rdar://problem/5490627>, about crashes constructing a
          String using the values filled in by checkSpellingOfString()

        * WebCoreSupport/WebEditorClient.mm:
        convert NSNotFound to -1, since WebCore code expects -1 for this purpose. We already do this
        in checkGrammarOfString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubberstamped by Hyatt.
aroben [Thu, 20 Sep 2007 00:17:34 +0000 (00:17 +0000)]
    Rubberstamped by Hyatt.

        * Spinneret: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 23:55:11 +0000 (23:55 +0000)]
2007-09-19  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber stamped by Adam.

        Make the guard/#if use the same name (ENABLE_FTPDIR) as the #define. This follows
        the ENABLE_ICONDATABASE example from a couple of lines above.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRestore the ChangeLog entries accidently removed by r25646 which was spotted by Mark.
zecke [Wed, 19 Sep 2007 23:14:36 +0000 (23:14 +0000)]
Restore the ChangeLog entries accidently removed by r25646 which was spotted by Mark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 23:00:28 +0000 (23:00 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        There is no need to have FTPDirectoryDocument stubs. We can
        compile FTPDirectoryDocument.cpp and FTPDirectoryTokenizer.cpp

        * WebCore.pro:
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 23:00:03 +0000 (23:00 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        Remove includes that are not needed.

        * platform/gdk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:59:33 +0000 (22:59 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        Move the Pasteboard stubs to PasteboardGdk.cpp.

        * WebCore.pro:
        * platform/gdk/PasteboardGdk.cpp: Added.
        * platform/gdk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:57:43 +0000 (22:57 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        Move the Icon stubs to IconGdk.cpp

        * WebCore.pro:
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/graphics/gdk/IconGdk.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:48:00 +0000 (22:48 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        Move the Font stubs to FontGdk.cpp

        * platform/gdk/FontGdk.cpp:
        * platform/gdk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:45:18 +0000 (22:45 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        Move the SearchPopupMenu stubs to SearchPopupMenuGdk.cpp

        * WebCore.pro:
        * platform/gdk/SearchPopupMenuGdk.cpp: Added.
        * platform/gdk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:39:44 +0000 (22:39 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        Move the ContextMenu and ContextMenuItem stubs to
        ContextMenuGdk.cpp and ContextMenuItemGdk.cpp.

        * WebCore.pro:
        * platform/gdk/ContextMenuGdk.cpp: Added.
        * platform/gdk/ContextMenuItemGdk.cpp: Added.
        * platform/gdk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:36:12 +0000 (22:36 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        Implement the WebCore::fileSize function using g_stat.

        * platform/gdk/FileSystemGdk.cpp:
        * platform/gdk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:33:48 +0000 (22:33 +0000)]
2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        Move the ResourceHandle stubs from TemporaryLinkStubs
        to the ResourceHandleCurl.cpp file. This affects the
        Gtk+ and wx port as they share the curl implementation.

        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/network/curl/ResourceHandleCurl.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:26:09 +0000 (22:26 +0000)]
2007-09-17 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Adam.

        WebKitGtkPage and WebKitGtkFrame have a dependency on each other. To
        allow client code to include both headers the typedef's for
        WebKitGtkFrame, WebKitGtkPage, WebKitGtkFrameData and WebKitGtkNetworkRequest
        are moved into webkitgtkdefines.h and included by both webkitgtkpage.h and

        * Api/webkitgtkdefines.h:
        * Api/webkitgtkframe.h:
        * Api/webkitgtkpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 19 Sep 2007 22:17:18 +0000 (22:17 +0000)]
2007-09-17 Holger Hans Peter Freyther <zecke@selfish.org>

        Reviewed by Mark.

        Take http://bugs.webkit.org/show_bug.cgi?id=15221 into account
        and change the variable names from nameSystem to systemName and
        change the name of the function to stringByAdoptingFileSystemRepresentation.

        * platform/gdk/FileChooserGdk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by.
kmccullo [Wed, 19 Sep 2007 22:02:01 +0000 (22:02 +0000)]
    Reviewed by.

        - Layout Test fixe

        * fast/dom/Window/new-window-opener.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff and Sam.
kmccullo [Wed, 19 Sep 2007 21:25:10 +0000 (21:25 +0000)]
    Reviewed by Geoff and Sam.

        - Added test cases for the different features of a new opened window.

        * fast/dom/Window/new-window-opener-expected.txt: Added.
        * fast/dom/Window/new-window-opener.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Wed, 19 Sep 2007 20:51:26 +0000 (20:51 +0000)]

        Reviewed by Geoff Garen.

        Fix <rdar://problem/5492141> Assertion in isdigit() on windows Safari

        Test: fast/css/hexColor-isDigit-assert.html

        * platform/DeprecatedString.cpp:
        (WebCore::isCharacterAllowedInBase): Check that the character is ascii
        to avoid an assertions on Windows.


        Reviewed by Geoff Garen.

        Test for <rdar://problem/5492141> Assertion in isdigit() on windows Safari

        * fast/css/hexColor-isDigit-assert-expected.txt: Added.
        * fast/css/hexColor-isDigit-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
andersca [Wed, 19 Sep 2007 20:17:37 +0000 (20:17 +0000)]
    Reviewed by Geoff.

        Combination of real player with high connection quality in selecting player makes Safari quit.

        Prevent the Real Player plug-in from calling the window proc recursively.

        * plugins/win/PluginViewWin.cpp:
        * plugins/win/PluginViewWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele [Wed, 19 Sep 2007 18:04:30 +0000 (18:04 +0000)]

        Reviewed by Maciej.

        Fix for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
        and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)


        This fix has a few steps:
        1) Removes the ignore value for the -webkit-user-select property.  We now decide when to prevent selection from starting by calling canStartSelection on the node.
        2) Implements canStartSelection which returns false for all elements that used to have -webkit-user-select:ignore set, true for content editable nodes,
           and walks up the tree to ask the parent before allowing selection to be started on any other nodes.
        3) We used to disallow selection from starting within -webkit-user-select:none blocks, but now we only use canStartSelection for that.  This will allow easy selections
           in cases like iChat where there's a mix of selectable and non-selectable content.
        4) Makes -webkit-user-select inherited.  After removing the "ignore" value, -webkit-user-select would behave like it was inherited anyways since we already allowed the text value to override the none value.

        * css/html4.css: Removed all usage of -webkit-user-select: ignore.  This is now handled internally with canStartSelection().
          Now -webkit-user-select won't be unintentionally overridden by nodes that don't want to allow selection to be started, but do want to honor the -webkit-user-select to
          determine whether or not selection is allowed at all.

        * editing/SelectionController.cpp: (WebCore::SelectionController::selectAll):
          Don't try to determine whether selection is allowed inside the root node here.  VisiblePosition and Selection creation will keep Selection endpoints out of -webkit-user-select:none regions.

        * dom/Node.h:
        * dom/Node.cpp: (WebCore::Node::canStartSelection): Added. Always allows selection to be started in a content editable node.  If there's a parent, ask the parent if starting a selection is allowed.
          If there's no parent, default to allowing selection.
        * html/HTMLAnchorElement.h:
        * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::canStartSelection): Added. If its not a link, then calls the base class. Disallows selection for non-editable links.
          Allows selection for editable links.
          This logic used to be done in CSSStyleSelector by changing the user-select property.
        * html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canStartSelection): Added. Disallows selection from starting in buttons.
        * html/HTMLImageElement.h: (WebCore::HTMLImageElement::canStartSelection): Added. Disallows selection from starting in images.
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canStartSelection): Added. Disallows selection from anything that's not a text field.  Text fields call up to the base class.
          When they're editable, text controls will always be selectable because of the case for content editable content. Otherwise, they'll respect their parent element's decision about starting a selection.
        * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::canStartSelection): Added. Disallows selection from starting in popup buttons.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect instead of the ambiguously named shouldSelect().
        (WebCore::EventHandler::handleMousePressEventTripleClick): ditto.
        (WebCore::EventHandler::handleMousePressEventSingleClick): ditto.
        (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect.
        (WebCore::EventHandler::selectCursor): Paint an ibeam in any region that allows you to click to create a selection.
        (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and calls canStartSelection instead of checking the user-select property.
        (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to canMouseDownStartSelect because of 12823, even though it seems strange that we would fire the selectStart event here.
        * page/EventHandler.h:
        * page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Calls canStartSelection instead of checking the user-select property to decide when to prevent selection creation.
        * rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): ditto.
        * rendering/RenderObject.h: Removed helper methods that are no longer needed.

        * rendering/RenderStyle.h: Made userSelect inherited.  After removing the "ignore" value, -webkit-user-select would behave like it was inherited
          anyways since we already allowed the text value to override the none value.
          Removed the SELECT_AUTO and SELECT_IGNORE values since they're no longer used.
        * rendering/RenderStyle.cpp:

        * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Remove case for SELECT_AUTO and SELECT_IGNORE
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):  Remove adjustment for links.  This is now handled in HTMLAnchorElement::canStartSelection.
        (WebCore::CSSStyleSelector::applyProperty): Map CSS_VAL_AUTO to SELECT_TEXT.  Remove CSS_VAL_IGNORE.


        Reviewed by Maciej.

        Tests for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
        and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

        * fast/css/computed-style-expected.txt: Updated for default -webkit-user-select value.
        * fast/css/computed-style-without-renderer-expected.txt: ditto.

        * editing/selection/5333725.html: Re-enabled.
        * editing/selection/5333725.html-disabled: Removed.

        * editing/selection/user-select-text-inside-user-select-ignore.html-disabled: Removed. Adjusted this test to be more specific and renamed it to textfield-inside-anchor.
        * editing/selection/user-select-text-inside-user-select-ignore-expected.txt: Removed.
        * fast/forms/textfield-inside-anchor-expected.txt: Added.
        * fast/forms/textfield-inside-anchor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
kdecker [Wed, 19 Sep 2007 17:59:05 +0000 (17:59 +0000)]
   Reviewed by Darin Adler.

        <rdar://problem/5491066> soft link Accelerate.framework

        * Misc/WebGraphicsExtras.c:
        (WebConvertBGRAToARGB): Improve launch time performance and reduce vsize
        footprint by soft linking the Accelerate.framework.
        * WebKit.xcodeproj/project.pbxproj: Remove no longer needed frameworks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
ddkilzer [Wed, 19 Sep 2007 16:11:44 +0000 (16:11 +0000)]

        Reviewed by David Kilzer.

        * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-19 George Staikos <staikos@kde.org>
staikos [Wed, 19 Sep 2007 14:40:38 +0000 (14:40 +0000)]
2007-09-19  George Staikos  <staikos@kde.org>

        As discussed with Brady and Maciej, on platforms without pthreads, use
        IconDatabaseNone for now and don't use pthreads.  Fixes Qt Win32 build
        for now.

        * loader/icon/IconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-19 Mark Rowe <mrowe@apple.com>
bdash [Wed, 19 Sep 2007 10:07:19 +0000 (10:07 +0000)]
2007-09-19  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5487107> NULL dereference crash in FastMallocZone::enumerate when running leaks against Safari

        Storing remote pointers to their local equivalents in mapped memory was leading to the local pointer being
        interpreted as a remote pointer.  This caused a crash when using the result of mapping this invalid remote pointer.
        The fix is to follow the pattern used elsewhere in FastMallocZone by always doing the mapping after reading and
        never storing the mapped pointer.

        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
antti [Wed, 19 Sep 2007 09:45:13 +0000 (09:45 +0000)]

        Reviewed by Maciej.

        Fix <rdar://problem/5488539>
        (9A550) iPhone Banner on O2.UK site not clickable with Safari due to styled noscript element

        Don't create renderer for noscript if scripts are enabled.

        Test: fast/dom/noscript-style.html

        * html/HTMLElement.cpp:
        * html/HTMLElement.h:


        Reviewed by Maciej.

        Test for <rdar://problem/5488539>
        (9A550) iPhone Banner on O2.UK site not clickable with Safari due to styled noscript element

        * fast/dom/noscript-style-expected.txt: Added.
        * fast/dom/noscript-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam
beidson [Wed, 19 Sep 2007 06:14:58 +0000 (06:14 +0000)]
    Reviewed by Adam

        Final part of <rdar://problem/5471308> - Hook up async icon database on Windows

        * CFDictionaryPropertyBag.cpp:
        (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Took the opportunity to rewrite with a RetainPtr
          since it became available after the initial implementation
        (CFDictionaryPropertyBag::dictionary): Added accessor to the CFDictionaryRef to ease use within WebKit
        (CFDictionaryPropertyBag::QueryInterface): Added IID_CFDictionaryPropertyBag accessor
        * CFDictionaryPropertyBag.h: Added IID_CFDictionaryPropertyBag

        * WebFrame.cpp:
        (WebFrame::url): Added accessor, gets the current URL from WebCore
        (WebFrame::dispatchDidReceiveIcon): Calls through to the WebView
        (WebFrame::registerForIconNotification): Ditto
        * WebFrame.h:

        * WebIconDatabase.cpp:
        * WebIconDatabase.h:

        * WebView.cpp:
        (WebView::close): Unregister for the notification, just in case
        (WebView::notifyDidAddIcon): Called when the webview gets the didAddIcon notification, compares the url
          in the notification to the current main frame URL.  If they match, calls to dispatchDidReceiveIconFromWebFrame
        (WebView::dispatchDidReceiveIconFromWebFrame): Dispatches the FrameLoadDelegate call.  Once the delegate call is dispatched,
          either via the FrameLoaderClient interface of by listening for a notification, we know that our info is up to date in the
          IconDatabase and we don't need to listen for the generic notification any long, so we unregister for it here, as well.
        (WebView::onNotify): The WebView listens for two notifications now, so make the decision which was received
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
thatcher [Wed, 19 Sep 2007 01:39:59 +0000 (01:39 +0000)]

        Reviewed by Darin.

        <rdar://problem/5478250> REGRESSION: After pasting text copied from Mail subject and typing return, the cursor disappears because of negative left margin

        When pasting text from the Mail subject line, the RTF pasteboard contains text that has a first line negative indent along with a
        paragraph indent that has a counteracting positive indent. This results in the first line being flush left justified, and the remaining
        wrapped lines being indented. When this is converted to a DOM fragment, AppKit makes a block element with a margin-left and a negative
        text-indent that matches the RTF. So far this is all correct behavior.

        When this content is pasted on the line of an existing paragraph that has content, ReplaceSelectionCommand will decided to merge the paragraphs.
        This will convert the block element to a style span that has all inherited style properties. These inherited properties will still contain block
        properties that have no affect on inline elements. These block properties will hang around on the style span and will get cloned to new block
        elements if the user hit return on that line. The new block elements would then have the text-indent but not the margin-left, so the text would be
        hidden off the left edge of the page.

        In the end, we should never hang on to block-only properties in our style spans. This cuts out meaningless properties and prevents properties
        from magically affecting blocks later if the style is cloned for a new block element during a future editing operation.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Remove any inherited block properties that are now in the span's style.
        * editing/markup.cpp:
        (WebCore::createMarkup): Ditto.


        Reviewed by Darin.

        Test for <rdar://problem/5478250> REGRESSION: After pasting text copied from Mail subject and typing return, the cursor disappears because of negative left margin

        * editing/pasteboard/5478250.html: Added.
        * platform/mac/editing/pasteboard/5478250-expected.txt: Added.

        Updated results that are affected by the style span being removed or added with different style properties.

        * editing/execCommand/5144139-1-expected.txt:
        * editing/execCommand/create-list-with-hr-expected.txt:
        * editing/pasteboard/merge-end-blockquote-expected.txt:
        * editing/pasteboard/styled-element-markup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix. Ran update-webkitsysteminterface script on Tiger, because
ggaren [Wed, 19 Sep 2007 00:04:58 +0000 (00:04 +0000)]
    Build fix. Ran update-webkitsysteminterface script on Tiger, because
        the resulting binary differs when built on Tiger. See

        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand a new UnicodeRange helper class that will be used to determine languages for...
hyatt [Tue, 18 Sep 2007 23:47:40 +0000 (23:47 +0000)]
Land a new UnicodeRange helper class that will be used to determine languages for fonts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Ada and Geoff
beidson [Tue, 18 Sep 2007 23:12:55 +0000 (23:12 +0000)]
    Reviewed by Ada and Geoff

        Part of <rdar://problem/5471308> - Get async Icon Database fully hooked up on Windows

        Hook up main thread delivery of Icon Database notifications from the secondary thread

        * WebIconDatabase.cpp:
        (WebIconDatabase::WebIconDatabase): Initialize m_deliveryRequested
        (WebIconDatabase::init): Set the IconDatabaseClient to the shared WebIconDatabase
        (WebIconDatabase::dispatchDidRemoveAllIcons): Queue the notification to be delivered on the main thread then
          ask for the delivery
        (WebIconDatabase::dispatchDidAddIconForPageURL): Ditto
        (WebIconDatabase::scheduleNotificationDelivery): If the m_deliveryRequested hasn't been set, then set it
          and perform the callOnMainThread() for WebIconDatabase::deliverNotifications
        (WebIconDatabase::deliverNotifications): Deliver all notifications in the current queue
        * WebIconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTouch file in DRT to recompile it now. Frowny-face.
weinig [Tue, 18 Sep 2007 22:59:24 +0000 (22:59 +0000)]
Touch file in DRT to recompile it now.  Frowny-face.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix. Ran update-webkitsysteminterface script.
ggaren [Tue, 18 Sep 2007 22:54:50 +0000 (22:54 +0000)]
    Build fix. Ran update-webkitsysteminterface script.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBump version for submit
aroben [Tue, 18 Sep 2007 22:25:07 +0000 (22:25 +0000)]
Bump version for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Tue, 18 Sep 2007 22:23:06 +0000 (22:23 +0000)]
    Reviewed by Darin Adler.

        Fixed <rdar://problem/5490204> In some cases, WebKit can make the
        Foundation disk cache way too big or way too small

        Use the actual location of the foundation disk cache, rather than
        the user's home directory, when determining how big to make it.

        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTouch JavaScriptCore file to force rebuild.
weinig [Tue, 18 Sep 2007 22:16:44 +0000 (22:16 +0000)]
Touch JavaScriptCore file to force rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix some HDC badness with my previous checkin.
hyatt [Tue, 18 Sep 2007 21:34:17 +0000 (21:34 +0000)]
Fix some HDC badness with my previous checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Tue, 18 Sep 2007 21:32:10 +0000 (21:32 +0000)]

        Reviewed by Darin.

        Patch for <rdar://problem/5488478> Safari crashes when passing null to Range.insertNode()

        Test: fast/dom/Range-insertNode-crash.html

        * dom/Range.cpp:
        (WebCore::Range::insertNode): Null check the passed in node to insert.


        Reviewed by Darin.

        Test for <rdar://problem/5488478> Safari crashes when passing null to Range.insertNode()

        * fast/dom/Range-insertNode-crash-expected.txt: Added.
        * fast/dom/Range-insertNode-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add JSRetainPtr.h #include to fix some builds.
weinig [Tue, 18 Sep 2007 20:59:01 +0000 (20:59 +0000)]
    Add JSRetainPtr.h #include to fix some builds.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Mike Fenton <mike@staikos.net>
staikos [Tue, 18 Sep 2007 20:58:59 +0000 (20:58 +0000)]
2007-09-18  Mike Fenton  <mike@staikos.net>

        Reviewed by George Staikos.

        Retain the pen properties when changing one aspect of the pen.

        * html/CanvasStyle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-09-18 Mike Fenton <mike@staikos.net>
staikos [Tue, 18 Sep 2007 20:55:22 +0000 (20:55 +0000)]
2007-09-18  Mike Fenton  <mike@staikos.net>

        Reviewed by George Staikos.

        Make <canvas> work in more cases by restarting the painter after we
        finish painting, and restoring the pen and opacity.

        * html/HTMLCanvasElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Tue, 18 Sep 2007 18:33:58 +0000 (18:33 +0000)]

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15169
          Freeze on Google maps using the "Dig a hole" tool

        Test: fast/dom/CSSStyleDeclaration-empty-string-property.html

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::cssPropertyName): Added an early return if the property name
        is the empty string, thus avoiding a loop that is not prepared for that


        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15169
          Freeze on Google maps using the "Dig a hole" tool

        * fast/dom/CSSStyleDeclaration-empty-string-property-expected.txt: Added.
        * fast/dom/CSSStyleDeclaration-empty-string-property.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
darin [Tue, 18 Sep 2007 17:52:51 +0000 (17:52 +0000)]
    Reviewed by Adam.

        - fix <rdar://problem/5415734> <select> dras incorrectly if size of menu options
          is changed after it pops up once

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::PopupMenu): Removed unnecessary initialization of IntRect.
        (WebCore::PopupMenu::show): Check that the clientRect is empty instead of checking
        the entire windowRect -- this fixes a bug where we pop up a tiny 2-pixel high black
        box when you click on an empty menu.
        (WebCore::PopupMenu::visibleItems): Base the number of items on the client rect
        instead of the window rect. Rounding down means this would have worked anyway, but
        it's more correct to do it this way.
        (WebCore::PopupMenu::paint): Deallocate the bitmap so it gets reallocated if it
        has the wrong width or height (or if GetObject returns false, which should not
        happen in practice).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
harrison [Tue, 18 Sep 2007 17:23:22 +0000 (17:23 +0000)]

        Reviewed by Darin.

        <rdar://problem/5486974> REGRESSION(r25373): 1/4 second to doubleclick word in GMail when using Kotoeri IM, also slow in other IMs (15163)

        Updated tests:
        * fast/dom/Window/window-xy-properties-expected.txt:
        * fast/dom/plugin-attributes-enumeration-expected.txt:
        * fast/events/onerror-bubbling-expected.txt:
        * fast/events/related-target-expected.txt:
        * fast/forms/select-namedItem-expected.txt:
        * fast/table/incomplete-table-in-fragment-2-expected.txt:
        * fast/table/incomplete-table-in-fragment-hang-expected.txt:
        * fast/table/large-rowspan-crash-expected.txt:
        * plugins/embed-attributes-setting-expected.txt:

        * editing/TextIterator.cpp:
        Avoid VisiblePosition check if the current node is a descendant
        of the start container and the start offset was 0. In that case
        we already had enough context to correctly decide whether to emit
        a newline after a preceding block. We chose not to emit
        (m_haveEmitted is false), so don't second guess that.

        Changed some comments.


        Reviewed by Darin.

        Updated for:
        <rdar://problem/5486974> REGRESSION(r25373): 1/4 second to doubleclick word in GMail when using Kotoeri IM, also slow in other IMs (15163)

        NOTE: This reverts the test result changes I made for rdar://5472125, back to not emitting
        a newline for collapsed block or hr at start of range.

        * fast/dom/Window/window-xy-properties-expected.txt:
        * fast/dom/plugin-attributes-enumeration-expected.txt:
        * fast/events/onerror-bubbling-expected.txt:
        * fast/events/related-target-expected.txt:
        * fast/forms/select-namedItem-expected.txt:
        * fast/table/incomplete-table-in-fragment-2-expected.txt:
        * fast/table/incomplete-table-in-fragment-hang-expected.txt:
        * fast/table/large-rowspan-crash-expected.txt:
        * plugins/embed-attributes-setting-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
ddkilzer [Tue, 18 Sep 2007 13:55:26 +0000 (13:55 +0000)]

        Reviewed by Adam.

        * Scripts/prepare-ChangeLog:
        - Properly parse GECOS field.
        - Use git configuration for user name and email when appropriate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
weinig [Tue, 18 Sep 2007 06:08:58 +0000 (06:08 +0000)]
    Build fix.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig [Tue, 18 Sep 2007 05:56:43 +0000 (05:56 +0000)]
    Reviewed by Adam Roben.

        Share more code between mac and windows DRT.
            - GCController is now shared.
            - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.

        * DumpRenderTree/GCController.cpp:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
        * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
        * DumpRenderTree/win/GCController.cpp: Removed.
        * DumpRenderTree/win/GCController.h: Removed.
        * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
        * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
        * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig [Tue, 18 Sep 2007 02:44:03 +0000 (02:44 +0000)]
    Reviewed by Adam Roben.

        Begin sharing code between mac and windows DRT.
            - both now share LayoutTestController.h/cpp and implement platform dependant
              operations in LayoutTestControllerMac/Win.
            - DumpRenderTree.h is now shared.
            - WorkQueue and WorkQueueItem are also shared.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/LayoutTestController.cpp:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/DumpRenderTree.h: Removed.
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
        * DumpRenderTree/win/EditingDelegate.cpp:
        * DumpRenderTree/win/LayoutTestController.cpp: Removed.
        * DumpRenderTree/win/LayoutTestController.h: Removed.
        * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
        * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
        * DumpRenderTree/win/WorkQueue.cpp: Removed.
        * DumpRenderTree/win/WorkQueue.h: Removed.
        * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
        * DumpRenderTree/win/WorkQueueItem.h: Removed.
        * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ggaren [Tue, 18 Sep 2007 02:11:08 +0000 (02:11 +0000)]

        Reviewed by Darin Adler.

        Speculative fix for <rdar://problem/5479443> REGRESSION: Hang due to
        infinite JS recursion on close @ engadget.com (onunload-based ad)

        If page is NULL, shouldInterruptScript now returns true, so you can't
        get stuck in a state in which a script executes forever without putting
        up a UI to ask if it should stop.

        * bindings/js/kjs_binding.cpp:


        Reviewed by Darin Adler.

        Fixed a hang due to an infinite script running in the window's unload
        event handler, which may be the cause of <rdar://problem/5479443>
        REGRESSION: Hang due to infinite JS recursion on close @ engadget.com
        (onunload-based ad)

        * WebView/WebUIDelegatePrivate.h: Added FIXME.

        * WebView/WebView.h: Clarified headerdoc ambiguity about when delegate
        methods stop firing.

        * WebView/WebView.mm:
        (-[WebView _close]): The fix: don't nil out our delegates until after
        detaching the FrameLoader, because the act of detaching the FrameLoader
        might fire important delegate methods, like webViewShouldInterruptJavaScript:.
        Don't do other tear-down either, because the unload event handler needs
        to run in a fully constructed page.

        This change is fairly low risk because niling out our delegates is a
        very recent, never-shipped feature in WebKit, so it's unlikely that any
        apps rely on it in a crazy way.


        Reviewed by Darin Adler.

        Fixed a hang due to an infinite script running in the window's unload
        event handler, which may be the cause of <rdar://problem/5479443>
        REGRESSION: Hang due to infinite JS recursion on close @ engadget.com
        (onunload-based ad)

        Added a bunch of WebKitMac's close features, and reordered others to
        match WebKitMac.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix for 14743, missing glyphs because of mlang's tiny font cache.
hyatt [Tue, 18 Sep 2007 00:36:51 +0000 (00:36 +0000)]
Fix for 14743, missing glyphs because of mlang's tiny font cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix <rdar://5423441> Should get focus ring color from SafariTheme
aroben [Tue, 18 Sep 2007 00:30:39 +0000 (00:30 +0000)]
    Fix <rdar://5423441> Should get focus ring color from SafariTheme

        Reviewed by Hyatt.

        No regression test possible.

        * WebCore.vcproj/WebCore.vcproj: Added ColorSafari.cpp.
        * platform/graphics/win/ColorSafari.cpp: Added.
        (WebCore::makeRGBAFromCGColor): Added.
        (WebCore::focusRingColor): Added. Gets the focus ring color from
        SafariTheme if SafariTheme has support for it.
        (WebCore::setFocusRingColorChangeFunction): Added.
        * platform/win/TemporaryLinkStubs.cpp: Removed focus ring color

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Windows build.
andersca [Tue, 18 Sep 2007 00:27:08 +0000 (00:27 +0000)]
    Fix Windows build.

        * WebCore.vcproj/WebCore.vcproj:
        * loader/NetscapePlugInStreamLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Mac build.
andersca [Tue, 18 Sep 2007 00:22:43 +0000 (00:22 +0000)]
    Fix Mac build.

        * loader/NetscapePlugInStreamLoader.cpp:
        * loader/NetscapePlugInStreamLoader.h:
        * loader/win/NetscapePlugInStreamLoaderWin.cpp: Copied from loader/NetscapePlugInStreamLoader.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca [Tue, 18 Sep 2007 00:11:23 +0000 (00:11 +0000)]
    Reviewed by Adam.

        crash at vw.com WebCore::PluginViewWin::disconnectStream.

        The following events would lead to this crash:

        1. a plug-in stream finishes loading and calls NPP_DestroyStream.
        2. the DestroyStream handler calls NPN_Evaluate, submitting a form through JavaScript.
        3. A new page is going to be loaded and DocumentLoader::stopLoading is called.
        4. DocumentLoader::stopLoading will stop all loader, including the one that is done loading!

        The fix is to port NetscapePluginStreamLoader over from the Mac code and use it instead. This fixes the crash
        because it disassociates the stream loader with the document loader _before_ calling NPP_DestroyStream, whereas
        SubresourceLoader does this _after_ calling NPP_DestroyStream.

        * loader/NetscapePlugInStreamLoader.cpp:
        * loader/NetscapePlugInStreamLoader.h:
        * plugins/win/PluginStreamWin.cpp:
        * plugins/win/PluginStreamWin.h:
        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca [Tue, 18 Sep 2007 00:06:49 +0000 (00:06 +0000)]
    Reviewed by Adam.

        Crash loading http://www.microsoft.com if Silverlight 1.0 is installed.

        Work around a problem in our NPRuntime implementation by never unloading the silverlight plug-in dll.

        * plugins/win/PluginViewWin.cpp:
        * plugins/win/PluginViewWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHaving bad Changelog composition issues today
beidson [Mon, 17 Sep 2007 23:41:12 +0000 (23:41 +0000)]
Having bad Changelog composition issues today

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan
beidson [Mon, 17 Sep 2007 23:38:14 +0000 (23:38 +0000)]
    Reviewed by John Sullivan

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15178

        The stress test proves that this was an overzealous ASSERT.  It is very possible to mark and icon
        for addition to the on-disk database and then mark it for removal before it is ever added.  This
        is not an error and was already handled gracefully

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::removeIconFromSQLDatabase): Don't ASSERT of log if the icon wasn't on disk

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver
beidson [Mon, 17 Sep 2007 22:59:06 +0000 (22:59 +0000)]
    Reviewed by Oliver

        <rdar://problem/5487048> - ASSERT in stress test in IconDatabase

        If a PageURLRecord went away, it never clears its URL from the IconRecord it retained.

        * loader/icon/PageURLRecord.cpp:
        (WebCore::PageURLRecord::~PageURLRecord): Set the icon record to 0, clearing the page url
        * loader/icon/PageURLRecord.h: Add the destructor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThat Changelog was HORRIBLE
beidson [Mon, 17 Sep 2007 22:55:54 +0000 (22:55 +0000)]
That Changelog was HORRIBLE

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver
beidson [Mon, 17 Sep 2007 22:54:48 +0000 (22:54 +0000)]
    Reviewed by Oliver

        <rdar://problem/5487048> - ASSERT in stress test in IconDatabase

        If a PageURLRecord went away, it never clear it's URL from the IconRecord it retained.

        * loader/icon/PageURLRecord.cpp:
        (WebCore::PageURLRecord::~PageURLRecord): Set the icon record to 0, clearing the page url
        * loader/icon/PageURLRecord.h: Add the destructor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix <rdar://4979801> overflow divs don't respond to keyboard scrolling (affec...
aroben [Mon, 17 Sep 2007 21:34:39 +0000 (21:34 +0000)]
    Fix <rdar://4979801> overflow divs don't respond to keyboard scrolling (affects RSS pages)

        Reviewed by Hyatt.

        * WebView.cpp:
        (WebView::keyDown): Attempt to scroll an overflow area before
        scrolling the whole frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25600 268f45cc-cd09-0410-ab3c-d52691b4dbfc