git://git.webkit.org / WebKit-https.git / log
? search:
summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next
WebKit-https.git
8 years agoElement is displayed behind a composited layer when clipping is used on a previous...
commit | commitdiff | tree
achicu@adobe.com [Fri, 11 Jan 2013 22:05:25 +0000 (22:05 +0000)]
Element is displayed behind a composited layer when clipping is used on a previous element
https://bugs.webkit.org/show_bug.cgi?id=104981

Reviewed by Simon Fraser.

Source/WebCore:

RenderLayerCompositor::computeCompositingRequirements uses the local bounding box of the layers to optimize the number of composited
layers that are created. That's needed in order to make sure that composited layers that are displayed behind non-composited
layers are correctly promoting the layers in front to be composited. Otherwise the non-composited layers are rendered
in the parent composited layer, displaying behind the other composited layers. That might be wrong as the correct paint order might not be
preserved.

In order to make animations work, there's a flag that will disable that optimization. That's because the animations run in the platform
layer and the platform layer doesn't know about the layers that are not promoted to composited layers. When the overlapping of the layers
is computed it just uses the start or the stop state, but no intermediate states. For that reason, all the 'top' layers in front of animated
elements will become composited.

When an animation has a clipping rectangle, then we know for sure that the animation is going to be contained inside the clip area, so WebKit
uses the bounding box of the clipping area to detect the overlapping layers, so there's no need to disable the optimization in that case.

However, if there is a different animation displaying behind the clipping container, we cannot safely disable that optimization anymore. That's
because we still don't know what are the intermediate states of that particular animated layer. The bug was that the optimization was re-enabled
anyway, even in this particular case.

In order to fix it, I changed the logic, so that instead of re-enabling the optimization after a clipping container, it will just avoid to propagate
the internal state to the following layers when there's no need to so.

Note that 3D transforms behave like animations for now and disable the optimization. Because of that some of the existing tests ended up
creating more layers than needed. That's because the tests had an overflow area that recreated the issue that this patch fixes, but with
3D transforms instead of animations. 3D transforms will be treated in a separate patch.

Tests: compositing/layer-creation/overlap-animation-clipping.html
       compositing/layer-creation/overlap-animation-container.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

Updated existing test results and added two new tests to check that animations respect the correct paint order,
even though they are painted with composited layers.

Note that there are side effects of this patch that will be corrected in a following bug. 3D layers are treated like animations, so they
disable the overlapping optimizations. Because of that, some of the test results were updated to include the layers that, previously,
were not created as a result of being in front of a "clipping container".

* compositing/geometry/foreground-layer-expected.txt:
* compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
* compositing/layer-creation/overlap-animation-clipping.html: Added. Checking that the animation inside a clipping container is not
affecting how we compute the animations outside the clipping container.
* compositing/layer-creation/overlap-animation-container-expected.txt: Added.
* compositing/layer-creation/overlap-animation-container.html: Added. Checking that we don't create unnecessary composited layers for layers inside
composited containers that draw in front of animated layers.
* compositing/overflow/clip-descendents-expected.txt:
* compositing/overflow/clip-descendents.html: Removed the text from the output, so that platforms can share the same expected result.
* platform/chromium-win/compositing/overflow/clip-descendents-expected.txt: Removed. Not needed anymore, all Chromium platforms can share the same results now.
* platform/chromium/compositing/geometry/foreground-layer-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
* platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
* platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt: Added.
* platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
* platform/chromium/compositing/overflow/clip-descendents-expected.txt: Renamed from LayoutTests/platform/chromium-mac/compositing/overflow/clip-descendents-expected.txt.
* platform/qt/compositing/overflow/clip-descendents-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] More test expectations for Skia changes
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 21:45:01 +0000 (21:45 +0000)]
[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

Mozilla test cases for linux. Also re-adding hixie/perf/006.xml, which is failing

* platform/chromium-linux-x86/tables/mozilla/bugs/bug1188-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug1318-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug137388-2-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug138725-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug18359-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug23235-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-2-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-3-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug26178-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug28928-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug29326-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug33855-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug39209-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug4093-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug4382-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug4429-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug44505-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-1-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-2-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug51037-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug51727-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug52505-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug52506-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug60749-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug68912-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug7342-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug92647-2-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug96334-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/collapsing_borders: Added.
* platform/chromium-linux-x86/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/core: Added.
* platform/chromium-linux-x86/tables/mozilla/core/margins-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/dom: Added.
* platform/chromium-linux-x86/tables/mozilla/dom/tableDom-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/other: Added.
* platform/chromium-linux-x86/tables/mozilla/other/move_row-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
* platform/chromium-linux-x86/transforms/2d/zoom-menulist-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug23235-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
* platform/chromium-linux/tables/mozilla/core/margins-expected.png:
* platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
* platform/chromium-mac-lion/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/chromium-mac-lion/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-win-xp/tables/mozilla/bugs/bug137388-2-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug23235-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug4093-expected.png: Added.
* platform/chromium-win/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug23235-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved getDirectLocation and offsetForLocation and all their uses
commit | commitdiff | tree
ggaren@apple.com [Fri, 11 Jan 2013 21:33:47 +0000 (21:33 +0000)]
Removed getDirectLocation and offsetForLocation and all their uses
https://bugs.webkit.org/show_bug.cgi?id=106692

Reviewed by Filip Pizlo.

getDirectLocation() and its associated offsetForLocation() relied on
detailed knowledge of the rules of PropertyOffset, JSObject, and
Structure, which is a hard thing to reverse-engineer reliably. Luckily,
it wasn't needed, and all clients either wanted a true value or a
PropertyOffset. So, I refactored accordingly.

* dfg/DFGOperations.cpp: Renamed putDirectOffset to putDirect, to clarify
that we are not putting an offset.

* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertySlot): Get a value instead of a value
pointer, since we never wanted a pointer to begin with.

* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot): Use a PropertyOffset instead of a pointer,
so we don't have to reverse-engineer the offset from the pointer.

* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::resetInheritorID):
(JSC::JSObject::inheritorID):
(JSC::JSObject::removeDirect):
(JSC::JSObject::fillGetterPropertySlot):
(JSC::JSObject::getOwnPropertyDescriptor): Renamed getDirectOffset and
putDirectOffset, as explaind above. We want to use the name "getDirectOffset"
for when the thing you're getting is the offset.

* runtime/JSObject.h:
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectOffset): Changed getDirectLocation to getDirectOffset,
since clients really wants PropertyOffsets and not locations.

(JSObject::offsetForLocation): Removed this function because it was hard
to get right.

(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectUndefined):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/JSScope.cpp:
(JSC::executeResolveOperations):
(JSC::JSScope::resolvePut):
* runtime/JSValue.cpp:
(JSC::JSValue::putToPrimitive): Updated for renames.

* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot): Use a PropertyOffset instead of a pointer,
so we don't have to reverse-engineer the offset from the pointer.

* runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure): Updated for renames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 21:30:33 +0000 (21:30 +0000)]
Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
Marking them as crashing in TestExpectations.

Patch by Levi Weintraub <leviw@chromium.org> on 2013-01-11

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
commit | commitdiff | tree
leviw@chromium.org [Fri, 11 Jan 2013 21:20:43 +0000 (21:20 +0000)]
Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
Marking them as crashing in TestExpectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved an unused version of getDirectLocation
commit | commitdiff | tree
ggaren@apple.com [Fri, 11 Jan 2013 21:09:29 +0000 (21:09 +0000)]
Removed an unused version of getDirectLocation
https://bugs.webkit.org/show_bug.cgi?id=106691

Reviewed by Gavin Barraclough.

getDirectLocation is a weird operation. Removing the unused version is
the easy part.

* runtime/JSObject.h:
(JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WTF_EXPORT_PRIVATE to printInternal() methods of PrintStream.h
commit | commitdiff | tree
fpizlo@apple.com [Fri, 11 Jan 2013 21:08:47 +0000 (21:08 +0000)]
Add WTF_EXPORT_PRIVATE to printInternal() methods of PrintStream.h

Rubber stamped by Mark Hahnenberg.

This will make it easier to use dataLog() from WebCore.

* wtf/PrintStream.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoObjective-C objects that are passed to JavaScript leak (until the JSContext is destroyed)
commit | commitdiff | tree
mhahnenberg@apple.com [Fri, 11 Jan 2013 20:56:20 +0000 (20:56 +0000)]
Objective-C objects that are passed to JavaScript leak (until the JSContext is destroyed)
https://bugs.webkit.org/show_bug.cgi?id=106056

Reviewed by Darin Adler.

* API/APIJSValue.h:
* API/JSValue.mm: Make the reference to the JSContext strong.
(-[JSValue context]):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
* API/JSWrapperMap.mm: Make the reference back from wrappers to Obj-C objects weak instead of strong.
Also add an explicit WeakGCMap in the JSWrapperMap rather than using Obj-C associated object API which
was causing memory leaks.
(wrapperClass):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap dealloc]):
(-[JSWrapperMap wrapperForObject:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] More test expectations for Skia changes
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 20:31:09 +0000 (20:31 +0000)]
[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

These are a few files that had some platforms already failing, hence
requiring special care and attention.

* platform/chromium-linux-x86/fast/dom/HTMLMeterElement: Added.
* platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
* platform/chromium-linux-x86/fast/forms/validation-message-appearance-expected.png: Added.
* platform/chromium-linux-x86/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
* platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
* platform/chromium-linux-x86/fast/speech: Added.
* platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.png: Added.
* platform/chromium-linux-x86/fast/transforms: Added.
* platform/chromium-linux-x86/fast/transforms/transformed-focused-text-input-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/batik/filters: Added.
* platform/chromium-linux-x86/svg/batik/filters/feTile-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/js-late-gradient-creation-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png:
* platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-linux/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
* platform/chromium-linux/svg/batik/filters/feTile-expected.png:
* platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png:
* platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
* platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
* platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-lion/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
* platform/chromium-mac-lion/fast/gradients/css3-linear-right-angle-gradients-expected.png:
* platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-mac-lion/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
* platform/chromium-mac-lion/svg/batik/filters/feTile-expected.png: Added.
* platform/chromium-mac-lion/svg/custom/js-late-gradient-creation-expected.png:
* platform/chromium-mac-lion/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
* platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-mac/fast/gradients/css3-linear-right-angle-gradients-expected.png:
* platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
* platform/chromium-mac/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png:
* platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
* platform/chromium-win-xp/fast/gradients: Added.
* platform/chromium-win-xp/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
* platform/chromium-win-xp/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
* platform/chromium-win-xp/fast/speech: Added.
* platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Added.
* platform/chromium-win-xp/svg/batik/filters: Added.
* platform/chromium-win-xp/svg/batik/filters/feTile-expected.png: Added.
* platform/chromium-win-xp/svg/custom/js-late-gradient-creation-expected.png: Added.
* platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-win/svg/batik/filters/feTile-expected.png:
* platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
* platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip CachedImage::CreateImage if we don't have image data
commit | commitdiff | tree
pdr@google.com [Fri, 11 Jan 2013 20:23:46 +0000 (20:23 +0000)]
Skip CachedImage::CreateImage if we don't have image data
https://bugs.webkit.org/show_bug.cgi?id=106156

Reviewed by Nate Chapin.

This patch skips image creation if we do not have image data. This can occur during
cache revalidation when the revalidation request (304 not modified) comes back without
any content. In this revalidation case, the http spec requires that a mimetype not be set
on the response to prevent a cached resource from having a different mimetype
from the revalidated resource. Because revalidation requests do not have a mimetype,
CachedImage::CreateImage() will fail on SVG images. This patch prevents
CachedImage::CreateImage() from being called during revalidation.

No new tests as there are no observable changes from this patch.

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::data):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined run-bindings-tests.
commit | commitdiff | tree
haraken@chromium.org [Fri, 11 Jan 2013 20:21:41 +0000 (20:21 +0000)]
Unreviewed. Rebaselined run-bindings-tests.

* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::TestExceptionV8Internal::nameAttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed some bogus PropertyOffset ASSERTs
commit | commitdiff | tree
ggaren@apple.com [Fri, 11 Jan 2013 20:20:25 +0000 (20:20 +0000)]
Fixed some bogus PropertyOffset ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=106686

Reviewed by Gavin Barraclough.

The ASSERTs were passing a JSType instead of an inlineCapacity, due to
an incomplete refactoring.

The compiler didn't catch this because both types are int underneath.

* runtime/JSObject.h:
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::offsetForLocation):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransitionToExistingStructure): Validate against
our inline capacity, as we intended.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename propertyOffsetFor => offsetForPropertyNumber
commit | commitdiff | tree
ggaren@apple.com [Fri, 11 Jan 2013 20:13:21 +0000 (20:13 +0000)]
Rename propertyOffsetFor => offsetForPropertyNumber
https://bugs.webkit.org/show_bug.cgi?id=106685

Reviewed by Gavin Barraclough.

Since the argument is just a typedef and not an object, I wanted to clarify the meaning.

* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::nextOffset): Updated for rename.

* runtime/PropertyOffset.h:
(JSC::offsetForPropertyNumber): Renamed. Also changed some PropertyOffset variables
to plain ints, because they're not actually on the PropertyOffsets number line.

* runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure):
* runtime/Structure.h:
(JSC::Structure::lastValidOffset): Updated for rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderGeometryMap and TransformState disagree with sub-pixel layout and translations
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 20:06:20 +0000 (20:06 +0000)]
RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
https://bugs.webkit.org/show_bug.cgi?id=106047

Patch by Levi Weintraub <leviw@chromium.org> on 2013-01-11
Reviewed by Simon Fraser.

* fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
* fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderGeometryMap and TransformState disagree with sub-pixel layout and translations
commit | commitdiff | tree
leviw@chromium.org [Fri, 11 Jan 2013 19:59:48 +0000 (19:59 +0000)]
RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
https://bugs.webkit.org/show_bug.cgi?id=106047

Reviewed by Simon Fraser.

Source/WebCore:

Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
pixel-snapped later when a translation occurred between two sub-pixel containers.

Test: fast/layers/geometry-map-transform-state-translation-mismatch.html

* platform/graphics/transforms/TransformState.h:
(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
implementation only works properly when only tracking a quad.
* platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
for performance and consistency with RenderGeometryMap.

LayoutTests:

* fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
* fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTestRunner leaks when running tests
commit | commitdiff | tree
psolanki@apple.com [Fri, 11 Jan 2013 19:58:00 +0000 (19:58 +0000)]
TestRunner leaks when running tests
https://bugs.webkit.org/show_bug.cgi?id=106683

Reviewed by Simon Fraser.

Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
tests.

* DumpRenderTree/TestRunner.cpp:
(TestRunner::makeWindowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Mac editing test rebaseline
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 19:46:33 +0000 (19:46 +0000)]
[Chromium] Mac editing test rebaseline

Unreviewed expectations update.

For whatever reason Mac 10.6 and 10.7 use Skia for drawing edit boxes.
They all needed rebaselining.

* platform/chromium-mac-lion/editing/deleting/delete-tab-004-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-to-select-table-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-003-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-004-expected.png:
* platform/chromium-mac-lion/editing/deleting/list-item-1-expected.png:
* platform/chromium-mac-lion/editing/deleting/merge-different-styles-expected.png:
* platform/chromium-mac-lion/editing/deleting/merge-endOfParagraph-expected.png:
* platform/chromium-mac-lion/editing/deleting/merge-no-br-expected.png:
* platform/chromium-mac-lion/editing/deleting/merge-unrendered-space-expected.png:
* platform/chromium-mac-lion/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-mac-lion/editing/deleting/non-smart-delete-expected.png:
* platform/chromium-mac-lion/editing/deleting/pruning-after-merge-2-expected.png:
* platform/chromium-mac-lion/editing/deleting/smart-delete-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/smart-delete-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/smart-delete-003-expected.png:
* platform/chromium-mac-lion/editing/deleting/smart-delete-004-expected.png:
* platform/chromium-mac-lion/editing/deleting/table-cells-expected.png:
* platform/chromium-mac-lion/editing/deleting/type-delete-after-quote-expected.png:
* platform/chromium-mac-lion/editing/execCommand/4580583-1-expected.png:
* platform/chromium-mac-lion/editing/execCommand/4580583-2-expected.png:
* platform/chromium-mac-lion/editing/execCommand/4641880-1-expected.png:
* platform/chromium-mac-lion/editing/execCommand/4641880-2-expected.png:
* platform/chromium-mac-lion/editing/execCommand/4747450-expected.png:
* platform/chromium-mac-lion/editing/execCommand/4916402-expected.png:
* platform/chromium-mac-lion/editing/execCommand/4916541-expected.png:
* platform/chromium-mac-lion/editing/execCommand/4924441-expected.png:
* platform/chromium-mac-lion/editing/execCommand/5080333-1-expected.png:
* platform/chromium-mac-lion/editing/execCommand/5080333-2-expected.png:
* platform/chromium-mac-lion/editing/execCommand/5136770-expected.png:
* platform/chromium-mac-lion/editing/execCommand/5138441-expected.png:
* platform/chromium-mac-lion/editing/execCommand/5142012-1-expected.png:
* platform/chromium-mac-lion/editing/execCommand/5481523-expected.png:
* platform/chromium-mac-lion/editing/execCommand/5569741-expected.png:
* platform/chromium-mac-lion/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-mac-lion/editing/execCommand/format-block-with-trailing-br-expected.png:
* platform/chromium-mac-lion/editing/execCommand/indent-empty-root-expected.png:
* platform/chromium-mac-lion/editing/execCommand/indent-list-item-expected.png:
* platform/chromium-mac-lion/editing/execCommand/indent-selection-expected.png:
* platform/chromium-mac-lion/editing/execCommand/insert-list-and-stitch-expected.png:
* platform/chromium-mac-lion/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-mac-lion/editing/execCommand/insertImage-expected.png:
* platform/chromium-mac-lion/editing/execCommand/nsresponder-indent-expected.png:
* platform/chromium-mac-lion/editing/execCommand/nsresponder-outdent-expected.png:
* platform/chromium-mac-lion/editing/execCommand/print-expected.png:
* platform/chromium-mac-lion/editing/execCommand/remove-list-from-range-selection-expected.png:
* platform/chromium-mac-lion/editing/execCommand/remove-list-item-1-expected.png:
* platform/chromium-mac-lion/editing/execCommand/selectAll-expected.png:
* platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-mac-lion/editing/inserting/12882-expected.png:
* platform/chromium-mac-lion/editing/inserting/4278698-expected.png:
* platform/chromium-mac-lion/editing/inserting/4840662-expected.png:
* platform/chromium-mac-lion/editing/inserting/4875189-1-expected.png:
* platform/chromium-mac-lion/editing/inserting/4875189-2-expected.png:
* platform/chromium-mac-lion/editing/inserting/4959067-expected.png:
* platform/chromium-mac-lion/editing/inserting/4960120-1-expected.png:
* platform/chromium-mac-lion/editing/inserting/4960120-2-expected.png:
* platform/chromium-mac-lion/editing/inserting/5002441-expected.png:
* platform/chromium-mac-lion/editing/inserting/5058163-1-expected.png:
* platform/chromium-mac-lion/editing/inserting/5058163-2-expected.png:
* platform/chromium-mac-lion/editing/inserting/5156401-2-expected.png:
* platform/chromium-mac-lion/editing/inserting/5418891-expected.png:
* platform/chromium-mac-lion/editing/inserting/5510537-expected.png:
* platform/chromium-mac-lion/editing/inserting/5549929-2-expected.png:
* platform/chromium-mac-lion/editing/inserting/5549929-3-expected.png:
* platform/chromium-mac-lion/editing/inserting/6703873-expected.png:
* platform/chromium-mac-lion/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac-lion/editing/inserting/break-blockquote-after-delete-expected.png:
* platform/chromium-mac-lion/editing/inserting/editable-inline-element-expected.png:
* platform/chromium-mac-lion/editing/inserting/edited-whitespace-1-expected.png:
* platform/chromium-mac-lion/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-3775316-fix-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-3778059-fix-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-3800346-fix-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-after-delete-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-at-end-01-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-at-end-02-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-002-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-003-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-004-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-005-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-006-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-007-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-008-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-009-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-002-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-003-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-quoted-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-quoted-002-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-quoted-003-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-quoted-004-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-quoted-005-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-br-quoted-006-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-div-025-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-div-026-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-paragraph-01-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-paragraph-02-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-paragraph-03-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-paragraph-04-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-paragraph-05-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-space-in-empty-doc-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-tab-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-tab-002-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-tab-003-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-tab-004-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-002-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-003-expected.png:
* platform/chromium-mac-lion/editing/inserting/insert-text-with-newlines-expected.png:
* platform/chromium-mac-lion/editing/inserting/line-break-expected.png:
* platform/chromium-mac-lion/editing/inserting/multiple-lines-selected-expected.png:
* platform/chromium-mac-lion/editing/inserting/paragraph-separator-01-expected.png:
* platform/chromium-mac-lion/editing/inserting/paragraph-separator-02-expected.png:
* platform/chromium-mac-lion/editing/inserting/paragraph-separator-03-expected.png:
* platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-1-expected.png:
* platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-mac-lion/editing/inserting/redo-expected.png:
* platform/chromium-mac-lion/editing/inserting/return-key-with-selection-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/return-key-with-selection-002-expected.png:
* platform/chromium-mac-lion/editing/inserting/return-key-with-selection-003-expected.png:
* platform/chromium-mac-lion/editing/inserting/typing-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/typing-002-expected.png:
* platform/chromium-mac-lion/editing/inserting/typing-003-expected.png:
* platform/chromium-mac-lion/editing/inserting/typing-around-br-001-expected.png:
* platform/chromium-mac-lion/editing/inserting/typing-around-image-001-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/3976872-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/4076267-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/4242293-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/4631972-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/4947130-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5006779-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5032095-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5071074-2-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5071074-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5075944-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5134759-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5156401-1-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5247341-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5387578-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5478250-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/5601583-1-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/8145-1-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/8145-2-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/8145-3-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/bad-placeholder-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/copy-standalone-image-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/cut-text-001-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/displaced-generic-placeholder-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/displaced-placeholder-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/drag-drop-modifies-page-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-1-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-2-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/merge-end-borders-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/merge-start-blockquote-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/merge-start-list-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-4035648-fix-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-4038267-fix-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-001-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-002-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-003-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-004-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-005-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-006-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-007-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-008-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-009-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-010-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-match-style-001-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-match-style-002-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-text-019-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/pasting-object-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/pasting-tabs-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/quirks-mode-br-1-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/smart-drag-drop-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/smart-paste-007-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/styled-element-markup-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/unrendered-br-expected.png:
* platform/chromium-mac-lion/editing/selection/13804-expected.png:
* platform/chromium-mac-lion/editing/selection/4818145-expected.png:
* platform/chromium-mac-lion/editing/selection/4866671-expected.png:
* platform/chromium-mac-lion/editing/selection/4889598-expected.png:
* platform/chromium-mac-lion/editing/selection/4895428-2-expected.png:
* platform/chromium-mac-lion/editing/selection/4895428-3-expected.png:
* platform/chromium-mac-lion/editing/selection/4932260-1-expected.png:
* platform/chromium-mac-lion/editing/selection/4932260-2-expected.png:
* platform/chromium-mac-lion/editing/selection/4932260-3-expected.png:
* platform/chromium-mac-lion/editing/selection/4947387-expected.png:
* platform/chromium-mac-lion/editing/selection/5007143-2-expected.png:
* platform/chromium-mac-lion/editing/selection/5007143-expected.png:
* platform/chromium-mac-lion/editing/selection/5057506-2-expected.png:
* platform/chromium-mac-lion/editing/selection/5057506-expected.png:
* platform/chromium-mac-lion/editing/selection/5076323-1-expected.png:
* platform/chromium-mac-lion/editing/selection/5076323-2-expected.png:
* platform/chromium-mac-lion/editing/selection/5076323-3-expected.png:
* platform/chromium-mac-lion/editing/selection/5099303-expected.png:
* platform/chromium-mac-lion/editing/selection/5131716-1-expected.png:
* platform/chromium-mac-lion/editing/selection/5131716-2-expected.png:
* platform/chromium-mac-lion/editing/selection/5131716-3-expected.png:
* platform/chromium-mac-lion/editing/selection/5131716-4-expected.png:
* platform/chromium-mac-lion/editing/selection/5195166-2-expected.png:
* platform/chromium-mac-lion/editing/selection/5234383-1-expected.png:
* platform/chromium-mac-lion/editing/selection/5234383-2-expected.png:
* platform/chromium-mac-lion/editing/selection/6476-expected.png:
* platform/chromium-mac-lion/editing/selection/after-line-wrap-expected.png:
* platform/chromium-mac-lion/editing/selection/caret-ltr-2-expected.png:
* platform/chromium-mac-lion/editing/selection/caret-ltr-2-left-expected.png:
* platform/chromium-mac-lion/editing/selection/caret-ltr-expected.png:
* platform/chromium-mac-lion/editing/selection/caret-ltr-right-expected.png:
* platform/chromium-mac-lion/editing/selection/caret-rtl-2-expected.png:
* platform/chromium-mac-lion/editing/selection/caret-rtl-2-left-expected.png:
* platform/chromium-mac-lion/editing/selection/caret-rtl-expected.png:
* platform/chromium-mac-lion/editing/selection/caret-rtl-right-expected.png:
* platform/chromium-mac-lion/editing/selection/click-start-of-line-expected.png:
* platform/chromium-mac-lion/editing/selection/contains-boundaries-expected.png:
* platform/chromium-mac-lion/editing/selection/contenteditable-click-inside-expected.png:
* platform/chromium-mac-lion/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac-lion/editing/selection/editable-non-editable-crash-expected.png:
* platform/chromium-mac-lion/editing/selection/end-of-document-expected.png:
* platform/chromium-mac-lion/editing/selection/expanding-selections-expected.png:
* platform/chromium-mac-lion/editing/selection/expanding-selections2-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-character-001-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-character-002-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-character-003-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-character-004-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-character-005-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-character-006-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-word-001-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-by-word-002-expected.png:
* platform/chromium-mac-lion/editing/selection/extend-selection-bidi-expected.png:
* platform/chromium-mac-lion/editing/selection/image-before-linebreak-expected.png:
* platform/chromium-mac-lion/editing/selection/inline-table-expected.png:
* platform/chromium-mac-lion/editing/selection/leave-requested-block-expected.png:
* platform/chromium-mac-lion/editing/selection/mixed-editability-3-expected.png:
* platform/chromium-mac-lion/editing/selection/mixed-editability-4-expected.png:
* platform/chromium-mac-lion/editing/selection/mixed-editability-5-expected.png:
* platform/chromium-mac-lion/editing/selection/mixed-editability-6-expected.png:
* platform/chromium-mac-lion/editing/selection/mixed-editability-7-expected.png:
* platform/chromium-mac-lion/editing/selection/mixed-editability-8-expected.png:
* platform/chromium-mac-lion/editing/selection/mixed-editability-9-expected.png:
* platform/chromium-mac-lion/editing/selection/move-backwords-by-word-001-expected.png:
* platform/chromium-mac-lion/editing/selection/move-between-blocks-no-001-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-character-001-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-character-002-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-character-003-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-character-004-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-character-005-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-character-6-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-line-002-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-sentence-001-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-sentence-linebreak-expected.png:
* platform/chromium-mac-lion/editing/selection/move-by-word-001-expected.png:
* platform/chromium-mac-lion/editing/selection/move-past-trailing-space-expected.png:
* platform/chromium-mac-lion/editing/selection/previous-line-position-expected.png:
* platform/chromium-mac-lion/editing/selection/replace-selection-1-expected.png:
* platform/chromium-mac-lion/editing/selection/replaced-boundaries-1-expected.png:
* platform/chromium-mac-lion/editing/selection/replaced-boundaries-2-expected.png:
* platform/chromium-mac-lion/editing/selection/select-all-001-expected.png:
* platform/chromium-mac-lion/editing/selection/select-all-002-expected.png:
* platform/chromium-mac-lion/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
* platform/chromium-mac-lion/editing/selection/selection-3748164-fix-expected.png:
* platform/chromium-mac-lion/editing/selection/table-caret-1-expected.png:
* platform/chromium-mac-lion/editing/selection/table-caret-2-expected.png:
* platform/chromium-mac-lion/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac-lion/editing/selection/triple-click-in-pre-expected.png:
* platform/chromium-mac-lion/editing/selection/unrendered-001-expected.png:
* platform/chromium-mac-lion/editing/selection/unrendered-002-expected.png:
* platform/chromium-mac-lion/editing/selection/unrendered-003-expected.png:
* platform/chromium-mac-lion/editing/selection/unrendered-004-expected.png:
* platform/chromium-mac-lion/editing/selection/unrendered-005-expected.png:
* platform/chromium-mac-lion/editing/selection/unrendered-space-expected.png:
* platform/chromium-mac-lion/editing/selection/wrapped-line-caret-1-expected.png:
* platform/chromium-mac-lion/editing/selection/wrapped-line-caret-2-expected.png:
* platform/chromium-mac-lion/editing/spelling/grammar-markers-expected.png:
* platform/chromium-mac-lion/editing/spelling/spelling-expected.png:
* platform/chromium-mac-lion/editing/style/4916887-expected.png:
* platform/chromium-mac-lion/editing/style/5017613-1-expected.png:
* platform/chromium-mac-lion/editing/style/5017613-2-expected.png:
* platform/chromium-mac-lion/editing/style/5046875-1-expected.png:
* platform/chromium-mac-lion/editing/style/5046875-2-expected.png:
* platform/chromium-mac-lion/editing/style/5065910-expected.png:
* platform/chromium-mac-lion/editing/style/5084241-expected.png:
* platform/chromium-mac-lion/editing/style/5228141-expected.png:
* platform/chromium-mac-lion/editing/style/5279521-expected.png:
* platform/chromium-mac-lion/editing/style/block-styles-007-expected.png:
* platform/chromium-mac-lion/editing/style/highlight-expected.png:
* platform/chromium-mac-lion/editing/style/smoosh-styles-001-expected.png:
* platform/chromium-mac-lion/editing/style/smoosh-styles-003-expected.png:
* platform/chromium-mac-lion/editing/style/style-3681552-fix-001-expected.png:
* platform/chromium-mac-lion/editing/style/style-3681552-fix-002-expected.png:
* platform/chromium-mac-lion/editing/style/style-3998892-fix-expected.png:
* platform/chromium-mac-lion/editing/style/style-boundary-001-expected.png:
* platform/chromium-mac-lion/editing/style/style-boundary-002-expected.png:
* platform/chromium-mac-lion/editing/style/style-boundary-003-expected.png:
* platform/chromium-mac-lion/editing/style/style-boundary-004-expected.png:
* platform/chromium-mac-lion/editing/style/style-boundary-005-expected.png:
* platform/chromium-mac-lion/editing/style/typing-style-001-expected.png:
* platform/chromium-mac-lion/editing/style/typing-style-002-expected.png:
* platform/chromium-mac-lion/editing/style/unbold-in-bold-expected.png:
* platform/chromium-mac-lion/editing/undo/4063751-expected.png:
* platform/chromium-mac-lion/editing/undo/5378473-expected.png: Added.
* platform/chromium-mac-lion/editing/undo/redo-typing-001-expected.png:
* platform/chromium-mac-lion/editing/undo/undo-combined-delete-boundary-expected.png:
* platform/chromium-mac-lion/editing/undo/undo-combined-delete-expected.png:
* platform/chromium-mac-lion/editing/undo/undo-delete-boundary-expected.png:
* platform/chromium-mac-lion/editing/undo/undo-delete-expected.png:
* platform/chromium-mac-lion/editing/undo/undo-forward-delete-boundary-expected.png:
* platform/chromium-mac-lion/editing/undo/undo-forward-delete-expected.png:
* platform/chromium-mac-lion/editing/undo/undo-misspellings-expected.png: Added.
* platform/chromium-mac-lion/editing/undo/undo-typing-001-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/list-delete-001-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/list-delete-003-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/list-type-after-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/list-type-before-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/table-delete-001-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/table-delete-002-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/table-delete-003-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-mac-lion/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-tab-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/list-item-1-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/merge-different-styles-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/merge-endOfParagraph-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/merge-no-br-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/merge-unrendered-space-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/non-smart-delete-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/pruning-after-merge-2-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/smart-delete-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/smart-delete-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/smart-delete-003-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/smart-delete-004-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/type-delete-after-quote-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/4580583-1-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/4580583-2-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/4641880-1-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/4641880-2-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/4747450-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/4916402-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/4916541-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/4924441-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5080333-1-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5080333-2-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5136770-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5138441-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5142012-1-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5481523-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/format-block-with-trailing-br-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/indent-empty-root-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/indent-list-item-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/indent-selection-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/insertImage-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-indent-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-outdent-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/print-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/execCommand/remove-list-from-range-selection-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/remove-list-item-1-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/selectAll-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/4278698-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/4840662-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/4875189-1-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/4959067-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/4960120-1-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/4960120-2-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5002441-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5058163-1-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5058163-2-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5156401-2-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5510537-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5549929-2-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5549929-3-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/6703873-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/break-blockquote-after-delete-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/editable-inline-element-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/edited-whitespace-1-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-3775316-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-3778059-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-3800346-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-after-delete-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-01-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-02-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-006-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-008-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-009-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-001-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-002-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-003-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-004-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-005-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-006-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-div-026-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-01-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-04-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-05-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-space-in-empty-doc-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-tab-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-tab-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/line-break-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/multiple-lines-selected-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-1-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/redo-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/typing-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/typing-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/typing-around-image-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/3976872-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4076267-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4631972-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4947130-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5006779-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5032095-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5071074-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5071074-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5075944-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5134759-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5156401-1-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5247341-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5478250-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/5601583-1-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/8145-1-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/8145-3-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/bad-placeholder-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/displaced-generic-placeholder-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/displaced-placeholder-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/drag-drop-modifies-page-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-borders-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-blockquote-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-list-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-4035648-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-4038267-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-005-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-006-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-007-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-008-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-009-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-010-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-match-style-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-match-style-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-at-tabspan-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/pasting-object-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/quirks-mode-br-1-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/smart-drag-drop-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-007-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/styled-element-markup-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/unrendered-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4818145-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4866671-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4889598-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4895428-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4932260-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4932260-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4932260-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4947387-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5007143-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5007143-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5057506-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5057506-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5076323-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5076323-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5076323-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5099303-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5131716-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5131716-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5131716-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5131716-4-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5195166-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/6476-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/after-line-wrap-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-left-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/caret-ltr-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/caret-ltr-right-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/click-start-of-line-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/contains-boundaries-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/contenteditable-click-inside-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/editable-non-editable-crash-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/end-of-document-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/expanding-selections-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/expanding-selections2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/extend-by-character-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/extend-by-character-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/extend-by-character-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/extend-by-character-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/extend-by-character-005-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/extend-by-character-006-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/extend-by-sentence-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/extend-by-word-002-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/image-before-linebreak-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/leave-requested-block-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/mixed-editability-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/mixed-editability-4-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/mixed-editability-5-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/mixed-editability-6-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/mixed-editability-7-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/mixed-editability-8-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/mixed-editability-9-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-between-blocks-no-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-character-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-character-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-character-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-character-005-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-character-6-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-line-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-sentence-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-by-sentence-linebreak-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/move-past-trailing-space-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/previous-line-position-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/replace-selection-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-all-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-all-002-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-missing-image-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/selection-3748164-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/table-caret-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/table-caret-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/triple-click-in-pre-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/unrendered-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/unrendered-003-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/unrendered-004-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/unrendered-005-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/unrendered-space-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-2-expected.png:
* platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-expected.png:
* platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
* platform/chromium-mac-snowleopard/editing/style/4916887-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5017613-1-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5017613-2-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5065910-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5084241-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5228141-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5279521-expected.png:
* platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/highlight-expected.png:
* platform/chromium-mac-snowleopard/editing/style/smoosh-styles-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/smoosh-styles-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/style-3681552-fix-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/style-3681552-fix-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/style-3998892-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/style-boundary-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/style-boundary-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/style-boundary-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/style-boundary-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/style-boundary-005-expected.png:
* platform/chromium-mac-snowleopard/editing/style/typing-style-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/typing-style-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/style/unbold-in-bold-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/4063751-expected.png:
* platform/chromium-mac-snowleopard/editing/undo/5378473-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/redo-typing-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/undo-combined-delete-boundary-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/undo-combined-delete-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/undo-delete-boundary-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/undo-delete-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/undo-forward-delete-boundary-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/undo-forward-delete-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/undo-misspellings-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/undo/undo-typing-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png:
* platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png:
* platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-after-expected.png:
* platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-before-expected.png:
* platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png:
* platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png:
* platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png:
* platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
commit | commitdiff | tree
jparent@chromium.org [Fri, 11 Jan 2013 19:39:34 +0000 (19:39 +0000)]
Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
https://bugs.webkit.org/show_bug.cgi?id=106247

Old code nulled out the loader instance when it completed loading and
then later used the fact that it was null to determine if it had loaded
or not.  This is not only unintuitive, but it also prevents using the
loader object later on.

Added new method, used it, added unit test for it.

Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/dashboard_base.js:
(resourceLoadingComplete):
(handleLocationChange):
* TestResultServer/static-dashboards/loader.js:
(.):
* TestResultServer/static-dashboards/loader_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHeap-use-after-free in WebCore::RenderText::computePreferredLogicalWidths
commit | commitdiff | tree
inferno@chromium.org [Fri, 11 Jan 2013 19:35:31 +0000 (19:35 +0000)]
Heap-use-after-free in WebCore::RenderText::computePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=95901

Reviewed by Simon Fraser.

Prevent re-entrancy of view layout. Loading of SVG document during font load
causes it to re-enter layout and blowing the style away from underneath.

Test: Go to http://www.speckproducts.com and make sure crash does not happen.

* dom/Document.cpp:
(WebCore::Document::updateLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Do not create a local handle for a cached v8 string that is returned to V8 immed...
commit | commitdiff | tree
haraken@chromium.org [Fri, 11 Jan 2013 19:27:39 +0000 (19:27 +0000)]
[V8] Do not create a local handle for a cached v8 string that is returned to V8 immediately
https://bugs.webkit.org/show_bug.cgi?id=106557

Reviewed by Adam Barth.

Currently we are always creating a local handle for a cached
V8 string returned to V8:

  Handle<Value> v8String(StringImpl* impl, Isolate* isolate) {
    ...;
    return Local<String>::New(isolate, m_cachedString);
  }

However, we don't need to create a local handle in a case
where it is guaranteed that no V8 object allocation is conducted
before a control flow returns back to V8. In particular, in a case
where a cached V8 string is immediately returned to V8, we don't
need to create a local handle:

  Handle<Value> xxxxAttrGetter() {
    ...;
    return v8String(imp->xxxx(), isolate);  // This can return a persistent handle safely.
  }

This patch improves performance of div.id by 9.2%.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::TestExceptionV8Internal::nameAttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):
* bindings/v8/V8Binding.h:
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
* bindings/v8/V8ValueCache.cpp:
(WebCore::StringCache::v8ExternalStringSlow):
* bindings/v8/V8ValueCache.h:
(WebCore::StringCache::v8ExternalString):
(StringCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Marking platform/chromium/virtual/gpu/fast/hidpi/image-set...
commit | commitdiff | tree
leviw@chromium.org [Fri, 11 Jan 2013 19:21:55 +0000 (19:21 +0000)]
Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html
as slow on Debug builds.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[ Chromium ] New Mac rebaselines (some)
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 19:20:16 +0000 (19:20 +0000)]
[ Chromium ] New Mac rebaselines (some)

Unreviewed expectatiosn update after skia changes.

These are some of the Mac fixes, but mostly it addresses the issues
with TestExpectations, so hopefully we'll get green builds.

* platform/chromium-mac-lion/editing/deleting/4922367-expected.png:
* platform/chromium-mac-lion/editing/deleting/5099303-expected.png:
* platform/chromium-mac-lion/editing/deleting/5126166-expected.png:
* platform/chromium-mac-lion/editing/deleting/5144139-2-expected.png:
* platform/chromium-mac-lion/editing/deleting/5206311-1-expected.png:
* platform/chromium-mac-lion/editing/deleting/5272440-expected.png:
* platform/chromium-mac-lion/editing/deleting/5369009-expected.png:
* platform/chromium-mac-lion/editing/deleting/5433862-2-expected.png:
* platform/chromium-mac-lion/editing/deleting/5483370-expected.png:
* platform/chromium-mac-lion/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Added.
* platform/chromium-mac-lion/editing/deleting/delete-3608445-fix-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-3608462-fix-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-4083333-fix-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-003-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-and-undo-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-at-start-or-end-expected.png: Added.
* platform/chromium-mac-lion/editing/deleting/delete-block-contents-001-expected.png: Added.
* platform/chromium-mac-lion/editing/deleting/delete-block-contents-002-expected.png: Added.
* platform/chromium-mac-lion/editing/deleting/delete-block-contents-003-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-003-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-004-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-005-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-006-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-007-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-008-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-009-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-010-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-011-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-012-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-013-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-014-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-015-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-016-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-017-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-br-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-br-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-br-003-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-br-004-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-br-005-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-br-006-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-br-007-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-br-013-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-character-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-contiguous-ws-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-first-list-item-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-hr-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-image-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-image-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-image-003-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-image-004-expected.png: Added.
* platform/chromium-mac-lion/editing/deleting/delete-leading-ws-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-line-015-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-line-016-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-line-017-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-listitem-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-listitem-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-selection-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-tab-001-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-tab-002-expected.png:
* platform/chromium-mac-lion/editing/deleting/delete-tab-003-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/4922367-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/5099303-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/5144139-2-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/5206311-1-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/5272440-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/5369009-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/5433862-2-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-3608445-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-3608462-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-4083333-fix-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-001-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-002-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-003-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-008-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-at-start-or-end-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-br-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-br-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-br-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-br-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-br-005-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-br-006-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-br-007-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-br-013-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-character-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-first-list-item-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-hr-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-image-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-image-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-image-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-image-004-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-leading-ws-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-line-015-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-line-016-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-line-017-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-001-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-002-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-listitem-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-listitem-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-selection-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-tab-001-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/replaced-min-max-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Update NEWS and configure.ac for 1.11.4 release
commit | commitdiff | tree
carlosgc@webkit.org [Fri, 11 Jan 2013 19:14:25 +0000 (19:14 +0000)]
Unreviewed. Update NEWS and configure.ac for 1.11.4 release

.:

* configure.ac: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 1.11.4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix make distcheck.
commit | commitdiff | tree
carlosgc@webkit.org [Fri, 11 Jan 2013 19:11:12 +0000 (19:11 +0000)]
Unreviewed. Fix make distcheck.

* GNUmakefile.list.am: Add missing header files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncoming synchronous messages can sometimes arrive out of order
commit | commitdiff | tree
andersca@apple.com [Fri, 11 Jan 2013 19:08:47 +0000 (19:08 +0000)]
Incoming synchronous messages can sometimes arrive out of order
https://bugs.webkit.org/show_bug.cgi?id=106677
<rdar://problem/12889499>

Reviewed by Andreas Kling.

In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.

Fix this by separating the "dispatch all incoming synchronous messages" phase out into multiple phases, so we'll
schedule one call per connection instead of one call for all connections.

* Platform/CoreIPC/Connection.cpp:
(Connection::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection):
(CoreIPC::Connection::waitForSyncReply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Skipping accessibility/corresponding-control-deleted-crash...
commit | commitdiff | tree
leviw@chromium.org [Fri, 11 Jan 2013 19:07:46 +0000 (19:07 +0000)]
Unreviewed gardening. Skipping accessibility/corresponding-control-deleted-crash.html on Mac since
it fails without Shadow DOM enabled.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderLayerCompositor should let ScrollingCoordinator update main thread scrolling...
commit | commitdiff | tree
wangxianzhu@chromium.org [Fri, 11 Jan 2013 18:57:42 +0000 (18:57 +0000)]
RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers
https://bugs.webkit.org/show_bug.cgi?id=105652

Reviewed by Simon Fraser.

Source/WebCore:

Let ScrollingCoordinator know the change of ViewportConstrainedNotCompositedReason in time.
By the way moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to RenderLayer::ViewportConstrainedNotCompositedReason.

Tests: compositing/layer-creation/fixed-position-in-view-dynamic.html
       compositing/layer-creation/fixed-position-out-of-view-dynamic.html

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasonsAsText):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/mac/ScrollingCoordinatorMac.h:
(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintViewportConstrainedObjects):
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::logThreadedScrollingMode):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintLayer):
* rendering/RenderLayer.h:
(RenderLayer): Moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to here and renamed it to ViewportConstrainedNotCompositedReason.
(WebCore::RenderLayer::setViewportConstrainedNotCompositedReason):
(WebCore::RenderLayer::viewportConstrainedNotCompositedReason):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::updateBacking): Now updates ViewportConstrainedNotCompositedReason here instead of in computeCompositingRequirements before so that the reason is updated in time.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::reasonForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::reportMemoryUsage):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

LayoutTests:

Tests to ensure mainThreadScrollingReasons are correctly updated after a fixed element is dynamically inserted into the DOM tree.

* compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added.
* compositing/layer-creation/fixed-position-in-view-dynamic.html: Added.
* compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt: Added.
* compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry CRLF to LF change in r139407 again.
commit | commitdiff | tree
rniwa@webkit.org [Fri, 11 Jan 2013 18:39:21 +0000 (18:39 +0000)]
Try CRLF to LF change in r139407 again.

* BuildSlaveSupport/delete-stale-build-files:
(main):
(webkitBuildDirectory):
* BuildSlaveSupport/kill-old-processes:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] WebGL typed array constructor crashes on exception
commit | commitdiff | tree
kbr@google.com [Fri, 11 Jan 2013 18:39:10 +0000 (18:39 +0000)]
[Chromium] WebGL typed array constructor crashes on exception
https://bugs.webkit.org/show_bug.cgi?id=106308

Reviewed by Kentaro Hara.

Source/WebCore:

Check for empty handles (indicating exception thrown) after calls
into V8 VM.

Added new case from Khronos typed array conformance tests to
fast/canvas/webgl/array-unit-tests.html.

* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
    Check for empty handles after calls into V8 VM.

LayoutTests:

Updated typed array tests to latest version from Khronos repository.

* fast/canvas/webgl/array-unit-tests-expected.txt:
* fast/canvas/webgl/array-unit-tests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Slightly optimize getWrapperFast()
commit | commitdiff | tree
haraken@chromium.org [Fri, 11 Jan 2013 18:37:25 +0000 (18:37 +0000)]
[V8] Slightly optimize getWrapperFast()
https://bugs.webkit.org/show_bug.cgi?id=106667

Reviewed by Adam Barth.

This patch improves an if condition in getWrapperFast(),
as commented in DOMDataStore.h.

This patch improves performance of div.firstChild from
15.1 ns to 14.0 ns (+7.8%), although I couldn't observe
performance improvement in Dromaeo/dom-traverse.

No tests. No change in behavior.

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperFast):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[SVG] Suppress resource rebuilding for unattached and shadow elements
commit | commitdiff | tree
fmalita@chromium.org [Fri, 11 Jan 2013 18:10:10 +0000 (18:10 +0000)]
[SVG] Suppress resource rebuilding for unattached and shadow elements
https://bugs.webkit.org/show_bug.cgi?id=106664

Reviewed by Dirk Schulze.

Source/WebCore:

SVGStyledElement::buildPendingResourcesIfNeeded() can be called while cloning a subtree
(as nodes are inserted into the clone, while still detached) or when elements are inserted
into the shadow tree. Both of these cases are problematic for SVGUseElement and can trigger
indirect recursion in SVGUseElement::buildPendingResource.

Since shadow and !inDocument() nodes are of no interest to ID dependents (they cannot be
found by ID in the document), the patch short-circuits buildPendingResource() for these
cases.

Test: svg/custom/use-rebuild-resources-crash.svg

* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):

LayoutTests:

* svg/custom/use-rebuild-resources-crash-expected.txt: Added.
* svg/custom/use-rebuild-resources-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: Computed hierarchical level is not consistent with aria-level
commit | commitdiff | tree
dmazzoni@google.com [Fri, 11 Jan 2013 18:06:57 +0000 (18:06 +0000)]
AX: Computed hierarchical level is not consistent with aria-level
https://bugs.webkit.org/show_bug.cgi?id=106638

Reviewed by Chris Fleizach.

Source/WebCore:

Make hierarchicalLevel computation 1-based to match the aria-level spec.

Extends an existing test: platform/mac/accessibility/aria-tree.html.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::hierarchicalLevel):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

Extend aria-tree.html to check the hierarchicalLevel automatically
computed when aria-level is not provided. Make sure they're consistent.
Now, the mac disclosureLevel will be one less than the web aria-level.

* platform/mac/accessibility/aria-tree-expected.txt:
* platform/mac/accessibility/aria-tree.html:
* platform/mac/accessibility/aria-treegrid-expected.txt:
* platform/mac/accessibility/aria-treegrid.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test Expectations update after Skia flag changes.
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 17:48:09 +0000 (17:48 +0000)]
[Chromium] Test Expectations update after Skia flag changes.

Unreviewed test expectations update.

These are still failing, not sure why as some of them are already in expectations.
Test lint passes.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Workspace should support several projects and should not have temporar...
commit | commitdiff | tree
vsevik@chromium.org [Fri, 11 Jan 2013 17:31:04 +0000 (17:31 +0000)]
Web Inspector: Workspace should support several projects and should not have temporary UISourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=105856

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace now supports several projects with the networkProject being a main one.
Replaced temporary UISourceCodes with specific projects (debugger and liveedit).
The concept of workspace reset on navigation is now replaced with project reset concept instead.
Introduced snippets project (that is not reset on navigation).
Script mappings are now reset on GlobalObjectCleared event.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._innerSetBreakpoint):
(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.toggleAllBreakpoints):
(WebInspector.BreakpointManager.prototype.removeAllBreakpoints):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._inspectedURLChanged):
(WebInspector.CSSStyleModel.prototype._resetSourceMappings):
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype._viaInspectorResourceURL):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype._debuggerReset):
* inspector/front-end/DebuggerScriptMapping.js:
* inspector/front-end/DefaultScriptMapping.js:
(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DefaultScriptMapping.prototype._debuggerReset):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetPageResources):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.show):
* inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
(WebInspector.LiveEditSupport.prototype._debuggerReset):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._mainFrameNavigated):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptMapping.prototype._debuggerReset):
* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.prototype._projectWillReset):
* inspector/front-end/SASSSourceMapping.js:
(_bindUISourceCode):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.reset):
* inspector/front-end/ScriptsNavigator.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._removeUISourceCodes):
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._debuggerReset):
(WebInspector.ScriptsPanel.prototype._projectWillReset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.reset):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.project):
* inspector/front-end/Workspace.js:
(WebInspector.WorkspaceController):
(WebInspector.WorkspaceController.prototype._inspectedURLChanged):
(WebInspector.Project):
(WebInspector.Project.prototype.name):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Project.prototype._reset):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.project):
(WebInspector.Workspace.prototype.projects):
(WebInspector.Workspace.prototype.uiSourceCodes):
(WebInspector.Workspace.prototype.projectForUISourceCode):
(WebInspector.Workspace.prototype.requestFileContent):
(WebInspector.Workspace.prototype.setFileContent):
(WebInspector.Workspace.prototype.searchInFileContent):
* inspector/front-end/inspector.js:
* inspector/front-end/utilities.js:

LayoutTests:

* http/tests/inspector-enabled/dynamic-scripts.html:
* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/dynamic-scripts.html:
* inspector/debugger/live-edit-breakpoints-expected.txt:
* inspector/debugger/live-edit-breakpoints.html:
* inspector/debugger/resource-script-mapping-expected.txt:
* inspector/debugger/resource-script-mapping.html:
* inspector/debugger/resources/edit-me-breakpoints.js: Added.
(f):
* inspector/debugger/script-snippet-model-expected.txt:
* inspector/debugger/script-snippet-model.html:
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/watch-expressions-preserve-expansion-expected.txt:
* inspector/debugger/watch-expressions-preserve-expansion.html:
* inspector/uisourcecode-revisions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Disable the unit tests timeout when running from make check
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 17:28:12 +0000 (17:28 +0000)]
[GTK] Disable the unit tests timeout when running from make check
https://bugs.webkit.org/show_bug.cgi?id=106670

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-01-11
Reviewed by Philippe Normand.

* GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Resources] Make grid columns set configurable.
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 17:09:21 +0000 (17:09 +0000)]
Web Inspector: [Resources] Make grid columns set configurable.
https://bugs.webkit.org/show_bug.cgi?id=105739

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-11
Reviewed by Pavel Feldman.

Added context menu on grid header to hide/show grid columns.
Hidden columns set is persisted.

* inspector/front-end/DataGrid.js:
Fixed show/hide behavior, introduced weight control.
* inspector/front-end/NetworkPanel.js:
Added member to track visibility of columns in detailerd mode. Added
context menu for grid header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
commit | commitdiff | tree
sudarsana.nagineni@linux.intel.com [Fri, 11 Jan 2013 17:08:45 +0000 (17:08 +0000)]
Unreviewed EFL gardening.

Remove unnecessary platform expectations for now-passing test.

* platform/efl/media/video-controls-captions-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening.
commit | commitdiff | tree
fmalita@chromium.org [Fri, 11 Jan 2013 16:56:53 +0000 (16:56 +0000)]
[Chromium] Unreviewed gardening.

Rebaselining results after http://trac.webkit.org/changeset/139238.

* platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
* platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png:
* platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
* platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png:
* platform/chromium-mac/fast/borders/border-radius-wide-border-05-expected.png:
* platform/chromium-mac/fast/borders/border-styles-split-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
* platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
* platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png:
* platform/chromium-win/fast/borders/border-radius-wide-border-05-expected.png:
* platform/chromium-win/fast/borders/border-styles-split-expected.png:
* platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoYet another unreviewed fix after r139431.
commit | commitdiff | tree
rakuco@webkit.org [Fri, 11 Jan 2013 16:49:25 +0000 (16:49 +0000)]
Yet another unreviewed fix after r139431.

* Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
the correct order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test Expectations update after Skia flag changes.
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 16:39:12 +0000 (16:39 +0000)]
[Chromium] Test Expectations update after Skia flag changes.

Unreviewed test expectations update.

Apparently, we use Skia to draw some forms on Mac and Win, causing
failures not seen on Linux.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix the build if libxslt is not available but libxml2 is
commit | commitdiff | tree
abecsi@webkit.org [Fri, 11 Jan 2013 15:55:02 +0000 (15:55 +0000)]
[Qt] Fix the build if libxslt is not available but libxml2 is
https://bugs.webkit.org/show_bug.cgi?id=106661

Reviewed by Simon Hausmann.

On Linux building the xml parser sources fails if the needed libxslt
dependencies are not installed but libxml2 is.

* WebCore.pri: add libxml2 to pkg-config if not on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/chromium: Removing Skia flags that have been disabling oprtimizations...
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 15:41:11 +0000 (15:41 +0000)]
Source/WebKit/chromium: Removing Skia flags that have been disabling oprtimizations and other improvements.

Unreviewed build fix.

These changes have been extensively tested by the Skia team, and
WebKit test result changes will be monitored.

* skia_webkit.gyp:

LayoutTests: Unreviewed test expectations update.

All of the tests will be rebaselined by end of day.

* platform/chromium/TestExpectations: Mark tests affected by Skia flag changes as expected to fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoObjects can be re-added to the AXObjectCache during removal
commit | commitdiff | tree
schenney@chromium.org [Fri, 11 Jan 2013 15:35:06 +0000 (15:35 +0000)]
Objects can be re-added to the AXObjectCache during removal
https://bugs.webkit.org/show_bug.cgi?id=104171

Source/WebCore:

The problem occurs when a label's corresponding element is a sibling
that precedes it in the render tree, and the corresponding element is
removed. The corresponding element's AX render object is removed, but
then recreated when accessibilityIsIgnored() invokes correspondingControl()
on the label. The corresponding renderer then has an AX render object
that survives beyond the deleted renderer, leading to invalid memory
accesses.

The solution is to rearrange the calls to delete the renderer's AX
render object only when we are sure it will no longer be required.

Reviewed by Simon Fraser.

Test: accessibility/corresponding-control-deleted-crash.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed): Move the call to remove the
renderer from the AXCache to after the renderer is removed from the
render tree. This means that the AXObject still exists during renderer
removal, as we require.

LayoutTests:

Reviewed by Simon Fraser.

New test which asserts with !m_hasAXObject in RenderObject::~RenderObject without the patch. Requires Shadow DOM enabled.

* accessibility/corresponding-control-deleted-crash-expected.txt: Added.
* accessibility/corresponding-control-deleted-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] move some whitespace and resize related methods to TestRunner library
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 15:33:57 +0000 (15:33 +0000)]
[chromium] move some whitespace and resize related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106655

Patch by Dan Carney <dcarney@google.com> on 2013-01-11
Reviewed by Jochen Eisinger.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestRunner::WebTestDelegate::setClientWindowRect):
(WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
(WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
(WebTestRunner::TestRunner::enableAutoResizeMode):
(WebTestRunner::TestRunner::disableAutoResizeMode):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setClientWindowRect):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Update my e-mail addresses.
commit | commitdiff | tree
mario@webkit.org [Fri, 11 Jan 2013 15:31:12 +0000 (15:31 +0000)]
Unreviewed. Update my e-mail addresses.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
commit | commitdiff | tree
sudarsana.nagineni@linux.intel.com [Fri, 11 Jan 2013 14:43:39 +0000 (14:43 +0000)]
Unreviewed EFL gardening.

Skip new failing tests introduced in r139330 since
ENABLE_CSS_FILTERS flag is not enabled on EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother unreviewed fix after r139431.
commit | commitdiff | tree
rakuco@webkit.org [Fri, 11 Jan 2013 14:40:51 +0000 (14:40 +0000)]
Another unreviewed fix after r139431.

In a way, this is also a generic bug fix, since previously isEfl()
would fail when called from run-efl-tests and we thus did not use
jhbuild to run our tests. This now resulted in us calling
"jhbuild-wrapper run" without specifying a platform.

* Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
to work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK1] Web Audio support
commit | commitdiff | tree
allan.jensen@digia.com [Fri, 11 Jan 2013 14:37:29 +0000 (14:37 +0000)]
[Qt][WK1] Web Audio support
https://bugs.webkit.org/show_bug.cgi?id=106651

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Convert JavaScript Uint8Array to QByteArray. This conversion is necessary to support testRunner.setAudioData().

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::isJSUint8Array):
(Bindings):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):

Source/WebKit/qt:

Expose setting to enable WebAudio at runtime.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h:

Tools:

Implements support for dumping audio data in DumpRenderTree.

Adds WebAudio to toggleable features in QtTestBrowser.

Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::reset):
(TestRunner::overridePreference):
(TestRunner::setAudioData):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner::shouldDumpAsAudio):
(TestRunner::audioData):
(TestRunner):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::applyPrefs):
(LauncherWindow::createChrome):
(LauncherWindow::toggleWebAudio):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
(WindowOptions):
(LauncherWindow):
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Build fix for the GTK debug builds of WebKit2 after r139415.
commit | commitdiff | tree
zandobersek@gmail.com [Fri, 11 Jan 2013 14:34:06 +0000 (14:34 +0000)]
Unreviewed. Build fix for the GTK debug builds of WebKit2 after r139415.

* WebProcess/gtk/WebGtkExtensionManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText Autosizing - elements much narrower than its parent autosizing clusters should...
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 13:56:37 +0000 (13:56 +0000)]
Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
https://bugs.webkit.org/show_bug.cgi?id=105188

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-01-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Some blocks of text might be narrower than their parent clusters and should be autosized separately.
This helps with autosizing for the pages implementing the sidebars as a narrow blocks of text with wide margins and
the main content being positioned atop this margin (or vice versa).

* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::isContainerAutosizingCluster):

    Returns true if the container is more than 200 pixels narrower than its parent cluster's lowest common
    ancestor of all the text nodes.

LayoutTests:

Checked that a narrow autosizing container becomes an autosizing cluster.
Fixed other tests that used narrow descendant blocks.

* fast/text-autosizing/cluster-narrow-in-wide-expected.html:
* fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
* fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
* fast/text-autosizing/cluster-narrow-in-wide.html:
* fast/text-autosizing/cluster-with-wide-lca-expected.html:
* fast/text-autosizing/cluster-with-wide-lca.html:
* fast/text-autosizing/narrow-child-expected.html:
* fast/text-autosizing/narrow-child.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed jhbuild-related fix after r139431.
commit | commitdiff | tree
rakuco@webkit.org [Fri, 11 Jan 2013 13:28:32 +0000 (13:28 +0000)]
Unreviewed jhbuild-related fix after r139431.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__): Pass a string to set_option_default(), since
shlex.split() will be called on it later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed typo fixes after r139431.
commit | commitdiff | tree
ossy@webkit.org [Fri, 11 Jan 2013 13:18:43 +0000 (13:18 +0000)]
Unreviewed typo fixes after r139431.

* Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused CSSSelector(QualifiedName) constructor.
commit | commitdiff | tree
akling@apple.com [Fri, 11 Jan 2013 12:58:53 +0000 (12:58 +0000)]
Remove unused CSSSelector(QualifiedName) constructor.
<http://webkit.org/b/106652>

Reviewed by Antti Koivisto.

* css/CSSSelector.h:
(CSSSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[jhbuild] Remove the "run-with-jhbuild" scripts.
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 12:50:53 +0000 (12:50 +0000)]
[jhbuild] Remove the "run-with-jhbuild" scripts.
https://bugs.webkit.org/show_bug.cgi?id=106572

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-01-11
Reviewed by Martin Robinson.

Both ports which use jhbuild were mostly duplicating the
`run-with-jhbuild' script in their own directories for no clear reason.

The script itself was just a thin wrapper around the `jhbuild-wrapper',
so just start using that directly and get rid of a useless middle man.

Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
instead.

* Scripts/run-javascriptcore-tests:
* Scripts/run-launcher:
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
(buildAutotoolsProject):
(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
* Scripts/webkitpy/common/multiprocessing_bootstrap.py:
(run):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__):
(EflPort._image_diff_command):
* efl/run-with-jhbuild: Removed.
* gtk/run-with-jhbuild: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Disable the ENABLE_LEGACY_WEB_AUDIO feature define in release builds
commit | commitdiff | tree
zandobersek@gmail.com [Fri, 11 Jan 2013 12:43:46 +0000 (12:43 +0000)]
[GTK] Disable the ENABLE_LEGACY_WEB_AUDIO feature define in release builds
https://bugs.webkit.org/show_bug.cgi?id=106577

Reviewed by Philippe Normand.

The Web Audio feature is not enabled in the release builds, so there's
no need to enable the legacy Web Audio API either.

No new tests - no new functionality.

* GNUmakefile.features.am.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Option+Click on Node Expander Doesn't Work the First Time
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 12:28:24 +0000 (12:28 +0000)]
Web Inspector: Option+Click on Node Expander Doesn't Work the First Time
https://bugs.webkit.org/show_bug.cgi?id=66868

Source/WebCore:

Up to now, the TreeElement.prototype.expandRecursively() method would correctly
expand children recursively based on the provided depth, but would not wait to
perform this task until all child nodes had been populated, which means that this
would only work incrementally with one additional level of child nodes being shown
expanded in the DOM tree upon alt+clicking a given node with a deep hierarchy.

In order to fix this, this patch adds a new optional argument to the DOMAgent's
requestChildNodes() methods to provide the depth at which we want to retrieve children
of a given node. The DOMAgent provides a new .getSubtree() method that calls
requestChildNodes() with the provided depth.

Then in ElementsTreeOutline, we subclass .expandRecursively() to first call DOMAgent's
new .getSubtree() method and then call the default implementation when all nodes
have been retrieved from the backend.

Patch by Antoine Quint <graouts@apple.com> on 2013-01-11
Reviewed by Pavel Feldman.

Tests: inspector-protocol/dom-request-child-nodes-depth.html
       inspector/elements/expand-recursively.html

* inspector/Inspector.json: Add the new `depth` parameter to DOM.requestChildNodes().
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend): Add a new optional `depth` parameter
which defaults to 1.
(WebCore::InspectorDOMAgent::requestChildNodes): Add a new optional `depth` parameter
which defaults to 1 and allows -1 as an unbound value.
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.):
(WebInspector.DOMNode.prototype.getSubtree): New method allowing to specify at what depth
we want to retrieve children of a given node from the backend.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.expandRecursively): Override default implementation
to first obtain the deepest subtree for the current node so that deep expansion happens as expected.

LayoutTests:

Adding a new protocol test that covers the new `depth` parameter for the
requestChildNodes method and a new front-end method that tests correct
behavior of the expandRecursively() method.

Patch by Antoine Quint <graouts@apple.com> on 2013-01-11
Reviewed by Pavel Feldman.

* inspector-protocol/dom-request-child-nodes-depth-expected.txt: Added.
* inspector-protocol/dom-request-child-nodes-depth.html: Added.
* inspector/elements/expand-recursively-expected.txt: Added.
* inspector/elements/expand-recursively.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Remove support for global extensions in WebKit2 GTK+
commit | commitdiff | tree
carlosgc@webkit.org [Fri, 11 Jan 2013 12:26:37 +0000 (12:26 +0000)]
[GTK] Remove support for global extensions in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=106646

Reviewed by Xan Lopez.

We have now API to set the web extensions directory. A global web
estensions directory doesn't make sense anymore.

* WebProcess/gtk/WebGtkExtensionManager.cpp:
(WebKit::WebGtkExtensionManager::scanModules): Only scan the given
directory for modules.
(WebKit::WebGtkExtensionManager::initialize): Load modules found
in the given directory only.
* WebProcess/gtk/WebGtkExtensionManager.h:
(WebGtkExtensionManager): Remove appendModuleDirectories().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Elements] Search in the DOM tree does not scroll horizontally
commit | commitdiff | tree
apavlov@chromium.org [Fri, 11 Jan 2013 12:09:30 +0000 (12:09 +0000)]
Web Inspector: [Elements] Search in the DOM tree does not scroll horizontally
https://bugs.webkit.org/show_bug.cgi?id=106648

Reviewed by Vsevolod Vlasov.

Scroll into view the first match in every tree element, if needed.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Canvas] a minor follow-up to r137262
commit | commitdiff | tree
aandrey@chromium.org [Fri, 11 Jan 2013 11:59:58 +0000 (11:59 +0000)]
Web Inspector: [Canvas] a minor follow-up to r137262
https://bugs.webkit.org/show_bug.cgi?id=106644

Reviewed by Pavel Feldman.

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add ImageOnlyFailure for fast/css/font-face-unicode-range.html on win
commit | commitdiff | tree
noel.gordon@gmail.com [Fri, 11 Jan 2013 11:44:01 +0000 (11:44 +0000)]
[chromium] Add ImageOnlyFailure for fast/css/font-face-unicode-range.html on win
https://bugs.webkit.org/show_bug.cgi?id=100806

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBaseDateAndTimeInputType should not inherit from TextFieldInputType
commit | commitdiff | tree
tkent@chromium.org [Fri, 11 Jan 2013 11:24:43 +0000 (11:24 +0000)]
BaseDateAndTimeInputType should not inherit from TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=106306

Reviewed by Hajime Morita.

Date/time input types don't need text-field features at all.

No new tests. This should not make any behavior changes except reduction
of memory usage.

* html/BaseDateAndTimeInputType.h:
Inherit InputType instead of TextFieldInputType.
(WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
(BaseDateAndTimeInputType): Update function declarations.
* html/BaseDateAndTimeInputType.cpp:
Remove handleKeydownEvent and convertFromVisibleValue, which are for
TextFieldInputType.
(WebCore::BaseDateAndTimeInputType::shouldRespectListAttribute):
Added. This is necessary for <datalist> support. TextFieldInputType has
the same code.
(WebCore::BaseDateAndTimeInputType::valueMissing):
Added. This is necessary for validity.valueMissing. TextFieldInputType
has the same code.

* html/BaseChooserOnlyDateAndTimeInputType.cpp:
Remove unnecessary functions which cancel TextFieldInputType behavior.
* html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType): Remove declarations for them.

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
Remove unnecessary functions which cancel TextFieldInputType behavior.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Add SpinButtonOwner interface. We didn't need it because
TextFieldInputType implements it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Enable concatenating headers with same field name
commit | commitdiff | tree
mary.wu@torchmobile.com.cn [Fri, 11 Jan 2013 11:12:18 +0000 (11:12 +0000)]
[BlackBerry] Enable concatenating headers with same field name
https://bugs.webkit.org/show_bug.cgi?id=106625

Reviewed by Rob Buis.

RFC 2616 specifies that headers could concatenate with comma if they have
same field name. We should enable this if the header allows multiple values.

RIM PR# 275508, internally reviewed by Joe Mason

(WebCore):
(WebCore::isAppendableHeader):
(WebCore::NetworkJob::handleNotifyHeaderReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add ewk_view_page_contents_get() API
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 10:31:42 +0000 (10:31 +0000)]
[EFL][WK2] Add ewk_view_page_contents_get() API
https://bugs.webkit.org/show_bug.cgi?id=106440

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-01-11
Reviewed by Gyuyoung Kim.

Add ewk_view_page_contents_get() API for getting contents of the current page.
Currently, it supports only MHTML type.

* UIProcess/API/efl/ewk_view.cpp:
(Ewk_Page_Contents_Context):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(PageContentsCallback):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 10:30:15 +0000 (10:30 +0000)]
[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
https://bugs.webkit.org/show_bug.cgi?id=106447

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-01-11
Reviewed by Andreas Kling.

Files do not have HAVE(ACCESSIBILITY) guards.
This is source of potential build breakes, when macro is not enabled.

* WebProcess/WebPage/atk/WebPageAccessibilityObject.h:
* WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow arbitrary queue launch parameters in EWSTools/start-queue.sh
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 10:11:47 +0000 (10:11 +0000)]
Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
https://bugs.webkit.org/show_bug.cgi?id=106636

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-11
Reviewed by Adam Barth.

This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.

* EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
* EWSTools/GoogleComputeEngine/build-commit-queue.sh:
* EWSTools/screen-config:
* EWSTools/start-queue.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConnect UserGestureIndicator for mousedown and mouseup events
commit | commitdiff | tree
jochen@chromium.org [Fri, 11 Jan 2013 10:07:49 +0000 (10:07 +0000)]
Connect UserGestureIndicator for mousedown and mouseup events
https://bugs.webkit.org/show_bug.cgi?id=105138

Reviewed by Adam Barth.

Source/WebCore:

Ports that consume user gestures to prevent certain types of pop-ups
need to be able to connect mousedown and mouseup events, otherwise, a
single mouse click will allow for opening multiple pop-ups.

Note that a mousedown is not always followed by a mouseup and vice
versa, e.g. when the mousedown results in a context menu being shown, or
something is dragged into the page.

Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html

* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
* page/EventHandler.h:

LayoutTests:

* platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added.
* platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Resources] "Delete" cookie deletes all cookies with matching name.
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 10:06:11 +0000 (10:06 +0000)]
Web Inspector: [Resources] "Delete" cookie deletes all cookies with matching name.
https://bugs.webkit.org/show_bug.cgi?id=105633

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-11
Reviewed by Pavel Feldman.

Source/WebCore:

"Delete" cookie deletes all cookies with matching name,
ignoring domain and path.

* inspector/Inspector.json: Change argument "domain" to "url"
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::deleteCookie): Use url to delte cookies.
* inspector/InspectorPageAgent.h: Adopt new signature.
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._deleteCookie): Ditto.

LayoutTests:

Adopt new signatures.

* http/tests/inspector/resource-main-cookies.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Fix unused parameter build error
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 09:53:11 +0000 (09:53 +0000)]
[EFL] Fix unused parameter build error
https://bugs.webkit.org/show_bug.cgi?id=106639

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-01-11
Reviewed by Kentaro Hara.

Use UNUSED_PARAM macro to fix build error.

Source/WebCore:

No new tests, no behavior change.

* platform/efl/EflScreenUtilities.cpp:
(WebCore::isUsingEcoreX):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::supportsDataListUI):

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::intentMessagePorts):
* ewk/ewk_contextmenu.cpp:
(ewk_context_menu_destroy):
(ewk_context_menu_item_select):
* ewk/ewk_file_chooser.cpp:
(ewk_file_chooser_capture_get):
* ewk/ewk_frame.cpp:
(ewk_frame_feed_touch_event):
* ewk/ewk_intent.cpp:
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
* ewk/ewk_intent_request.cpp:
(ewk_intent_request_ref):
(ewk_intent_request_unref):
(ewk_intent_request_intent_get):
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
* ewk/ewk_settings.cpp:
(ewk_settings_shadow_dom_enable_set):
* ewk/ewk_view.cpp:
(ewk_view_context_menu_forward_event):
(ewk_view_setting_should_display_subtitles_get):
(ewk_view_setting_should_display_captions_get):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_text_descriptions_get):
(ewk_view_setting_should_display_text_descriptions_set):

Source/WebKit2:

* UIProcess/API/efl/ewk_color_picker.cpp:
(ewk_color_picker_color_set):
(ewk_color_picker_color_get):
* UIProcess/API/efl/ewk_context.cpp:
(ewk_context_additional_plugin_path_set):
* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_deliver):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_fullscreen_exit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload...
commit | commitdiff | tree
pfeldman@chromium.org [Fri, 11 Jan 2013 09:45:03 +0000 (09:45 +0000)]
Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
https://bugs.webkit.org/show_bug.cgi?id=106555

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Wrong ::enable was made virtual in the InspectorDebuggerAgent.

Test: inspector/debugger/debugger-scripts-reload.html

* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/debugger-scripts-reload-expected.txt: Added.
* inspector/debugger/debugger-scripts-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add API to set the web extensions directory to WebKit2 GTK+
commit | commitdiff | tree
carlosgc@webkit.org [Fri, 11 Jan 2013 08:42:42 +0000 (08:42 +0000)]
[GTK] Add API to set the web extensions directory to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=106462

Reviewed by Xan Lopez.

.:

* Source/autotools/symbols.filter: Update
WebGtkExtensionManager::initialize symbol.

Source/WebKit2:

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_web_extensions_directory): Set
the given directory as injected bundle initialization user data.
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
* UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(beforeAll): Update the test to use
webkit_web_context_set_web_extensions_directory()
instead of setting the WEBKIT_WEB_EXTENSIONS_PATH env var.
* WebProcess/gtk/WebGtkExtensionManager.cpp:
(WebKit::WebGtkExtensionManager::scanModules): Append the given
additional web extensions directory to the list of directories to
scan for modules.
(WebKit::WebGtkExtensionManager::initialize): Get the additional
web extensions directory from initialization user data and pass it
to scanModules().
* WebProcess/gtk/WebGtkExtensionManager.h:
(WebGtkExtensionManager): Add userData parameter.
* WebProcess/gtk/WebGtkInjectedBundleMain.cpp:
(WKBundleInitialize): Pass initialization user data to
WebGtkExtensionManager.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Refactoring, move NetworkWorkspaceProvider to NetworkUISourceCodeProvi...
commit | commitdiff | tree
vsevik@chromium.org [Fri, 11 Jan 2013 08:37:07 +0000 (08:37 +0000)]
Web Inspector: Refactoring, move NetworkWorkspaceProvider to NetworkUISourceCodeProvider.js and rename its parent to SimpleWorkspaceProvider.
https://bugs.webkit.org/show_bug.cgi?id=106635

Reviewed by Pavel Feldman.

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
* inspector/front-end/DefaultScriptMapping.js:
(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DebuggerWorkspaceProvider):
(WebInspector.DebuggerWorkspaceProvider.prototype.addDebuggerFile):
* inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
(WebInspector.LiveEditWorkspaceProvider):
(WebInspector.LiveEditWorkspaceProvider.prototype.addLiveEditFile):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkWorkspaceProvider):
(WebInspector.NetworkWorkspaceProvider.prototype.addNetworkFile):
* inspector/front-end/SimpleWorkspaceProvider.js: Renamed from Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js.
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.requestFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.setFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* inspector/debugger/resource-script-mapping.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom...
commit | commitdiff | tree
pfeldman@chromium.org [Fri, 11 Jan 2013 08:33:06 +0000 (08:33 +0000)]
Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
https://bugs.webkit.org/show_bug.cgi?id=106560

Reviewed by Vsevolod Vlasov.

* src/js/devTools.css:
(body.dock-to-bottom.platform-mac #toolbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOn Linux, should be able to get spelling suggestions without selecting the misspelled...
commit | commitdiff | tree
g.czajkowski@samsung.com [Fri, 11 Jan 2013 07:54:11 +0000 (07:54 +0000)]
On Linux, should be able to get spelling suggestions without selecting the misspelled word
https://bugs.webkit.org/show_bug.cgi?id=103520

Reviewed by Ryosuke Niwa.

Source/WebCore:

Allow to get/insert spelling suggestions without selecting the misspelled word for
Linux WebKit ports. WebCore assumes that the misspelled word has to be selected
to get its suggestions.

In compliance with native application behaviour a new editing policy is introduced,
to do not highlight the misspelled word to just get its guesses.

No new tests, covered by context-menu-suggestions.html.

* WebCore.exp.in:
Remove _ZN7WebCore6Editor21isSelectionMisspelledEv symbol as Mac port doesn't
need it any longer.

* editing/EditingBehavior.h:
(EditingBehavior):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
Add a new behavior for Linux, to allow spelling suggestions without selecting
the misspelled word.

* editing/Editor.cpp:
(WebCore::Editor::isContinuousSpellCheckingEnabled):
Add missing const modifier, to use this method in 'misspelledWordAtCaretOrRange() const'.

(WebCore::Editor::misspelledWordAtCaretOrRange):
Allow to check spelling under the caret or selected word.
Does nothing for selection made on the multiple words.

(WebCore::Editor::misspelledSelectionString):
Return the misspelled selection.

(WebCore::Editor::guessesForMisspelledWord):
Remove 'Selection' from method name as it may return guesses without selection.

(WebCore::Editor::guessesForMisspelledOrUngrammatical):
Ditto.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
Select the word under caret to meet the conditions from misspelledWordAtCaretOrRange.

(WebCore::ContextMenuController::populate):
Update guessesForMisspelledOrUngrammatical call.

LayoutTests:

* platform/efl/TestExpectations:
Unskip context-menu-suggestions.html for WebKit-EFL as it passes now.

* platform/gtk/TestExpectations:
Update failing reason.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Disable PNG and ICO image webkit-unit-tests after r139347
commit | commitdiff | tree
noel.gordon@gmail.com [Fri, 11 Jan 2013 07:44:27 +0000 (07:44 +0000)]
[chromium] Disable PNG and ICO image webkit-unit-tests after r139347
https://bugs.webkit.org/show_bug.cgi?id=106631

Reviewed by Eric Seidel.

* tests/WebImageTest.cpp:
(WebKit::TEST): Disable ICOImage and PNGImage tests on WIN and MAC to
green their respective webkit-unit-test bots. The tests still pass on
LINUX so keep test coverage there for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=106283
commit | commitdiff | tree
morrita@google.com [Fri, 11 Jan 2013 07:39:23 +0000 (07:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=106283
[Shadow DOM] HTMLContentElement and HTMLShadowElement should be behind SHADOW_DOM

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

This change moves <content> and <shadow> behind
ENABLE(SHADOW_DOM). Note that empty stub definitions are remaining
even after this change. They are for minimizing #if/#endif usage
and won't hurt code size.

* WebCore.exp.in:
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
* html/shadow/HTMLContentElement.cpp:
(WebCore):
(WebCore::HTMLContentElement::create):
(WebCore::HTMLContentElement::HTMLContentElement):
* html/shadow/HTMLContentElement.h:
(WebCore):
(HTMLContentElement):
* html/shadow/HTMLShadowElement.cpp:
* html/shadow/HTMLShadowElement.h:
(WebCore):
(WebCore::isHTMLShadowElement):
(WebCore::toHTMLShadowElement):
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::decorate):
* testing/Internals.cpp:
(WebCore::Internals::createContentElement):
(WebCore::Internals::isValidContentSelect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement CSSGroupingRule for @host @-rules and @supports.
commit | commitdiff | tree
tasak@google.com [Fri, 11 Jan 2013 07:08:28 +0000 (07:08 +0000)]
Implement CSSGroupingRule for @host @-rules and @supports.
https://bugs.webkit.org/show_bug.cgi?id=106418

Reviewed by Antti Koivisto.

CSSGroupingRule is to share code between CSSMediaRule, CSSSupportsRule
and CSSHostRule. @supports and @host @-rules are dervied from
CSSGroupingRule:
http://www.w3.org/TR/2012/WD-css3-conditional/#the-cssgroupingrule-interface
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#css-host-rule-interface
Since @media is also derived from CSSGroupingRule and @region has the
same interface as CSSGroupingRule, modify to use CSSGroupingRule:
http://dev.w3.org/csswg/css3-regions/#the-at-region-style-rule

No new tests, because no new feature is implemented.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added CSSGroupingRule.h and CSSGroupingRule.cpp.
* css/CSSAllInOne.cpp:
Modified to include CSSGroupingRule.cpp.
* css/CSSGroupingRule.cpp: Added.
(WebCore):
(WebCore::CSSGroupingRule::CSSGroupingRule):
(WebCore::CSSGroupingRule::~CSSGroupingRule):
(WebCore::CSSGroupingRule::insertRule):
(WebCore::CSSGroupingRule::deleteRule):
(WebCore::CSSGroupingRule::appendCssTextForItems):
(WebCore::CSSGroupingRule::length):
(WebCore::CSSGroupingRule::item):
(WebCore::CSSGroupingRule::cssRules):
(WebCore::CSSGroupingRule::reattach):
(WebCore::CSSGroupingRule::reportMemoryUsage):
These codes are moved from CSSMediaRule and WebKitCSSRegionRule.
* css/CSSGroupingRule.h:
(WebCore):
(CSSGroupingRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
Make CSSMediaRule inherit CSSGroupingRule.
(WebCore::CSSMediaRule::media):
(WebCore::CSSMediaRule::reattach):
Keep the code for updating media queries' CSSOMWrapper.
(WebCore::CSSMediaRule::reportMemoryUsage):
We need to report media queries' CSSOMWrapper memory usage.
(WebCore::CSSMediaRule::mediaQueries):
(WebCore::CSSMediaRule::cssText):
* css/CSSMediaRule.h:
* css/WebKitCSSRegionRule.cpp:
Make WebKitCSSRegionRule inherit CSSGroupingRule.
(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):
* css/WebKitCSSRegionRule.h:
* css/StyleRule.h:
Added inlined accessor to obtain StyleRuleMedia* and StyleRuleRegion*
from StyleRuleBlock*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Canvas] add an option to reload the page if there is an uninstrumente...
commit | commitdiff | tree
aandrey@chromium.org [Fri, 11 Jan 2013 06:57:14 +0000 (06:57 +0000)]
Web Inspector: [Canvas] add an option to reload the page if there is an uninstrumented canvas
https://bugs.webkit.org/show_bug.cgi?id=105822

Reviewed by Pavel Feldman.

Show in the front-end an option to reload the page if there is an uninstrumented canvas.

* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.decorationElement):
(WebInspector.CanvasProfileType.prototype._updateDecorationElement):
(WebInspector.CanvasProfileType.prototype._onReloadPageButtonClick):
* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView.prototype.addProfileType):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.decorationElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agokill-old-processes and delete-stale-build-files use CRLF linebreaks
commit | commitdiff | tree
rniwa@webkit.org [Fri, 11 Jan 2013 06:22:49 +0000 (06:22 +0000)]
kill-old-processes and delete-stale-build-files use CRLF linebreaks
https://bugs.webkit.org/show_bug.cgi?id=106622

Reviewed by Simon Fraser.

Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
Also escape clang\+\+ correctly in kill-old-processes.

* BuildSlaveSupport/delete-stale-build-files:
* BuildSlaveSupport/kill-old-processes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe word "selector" is somewhat redundant redundantly used in SelectorChecker.
commit | commitdiff | tree
dglazkov@chromium.org [Fri, 11 Jan 2013 06:18:34 +0000 (06:18 +0000)]
The word "selector" is somewhat redundant redundantly used in SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=106413

In https://bugs.webkit.org/show_bug.cgi?id=105864, Antti suggested reducing some of the redundant uses of the word
"selector" in SelectorChecker. Here's a start.

Reviewed by Antti Koivisto.

Simple renames, no change in behavior.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match): Renamed.
(WebCore):
(WebCore::SelectorChecker::fastCheck): Ditto,
(WebCore::SelectorChecker::checkOne): Ditto.
* css/SelectorChecker.h:
(SelectorChecker):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use new name.
(WebCore::StyleResolver::ruleMatches): Renamed from checkSelector to better match argument and return value.
(WebCore::StyleResolver::checkRegionSelector): Changed to use new names.
* css/StyleResolver.h:
(StyleResolver):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::matches): Ditto.
(WebCore::SelectorDataList::execute): Ditto.
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorChecker::checkContentSelector): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Pass the script url to the script-preprocessor script
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 06:17:07 +0000 (06:17 +0000)]
Web Inspector: Pass the script url to the script-preprocessor script
https://bugs.webkit.org/show_bug.cgi?id=104384

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Source/WebCore:

Add url argument to the script-preprocessor script in PageAgent.reload()

Test: inspector/debugger/debugger-script-preprocessor.html

* bindings/v8/DebuggerScript.js:
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptPreprocessor::ScriptPreprocessor):
(WebCore::ScriptDebugServer::ScriptPreprocessor::preprocessSourceCode):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):

LayoutTests:

Tests for Bug 80922 by Pavel Feldman <pfeldman@chromium.org> that did not land somehow,
with additional test for Bug 104384

* inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
* inspector/debugger/debugger-script-preprocessor.html: Added.
* platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: DataGrid refactoring: make cell editing more generic.
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 05:49:24 +0000 (05:49 +0000)]
Web Inspector: DataGrid refactoring: make cell editing more generic.
https://bugs.webkit.org/show_bug.cgi?id=105849

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Source/WebCore:

Editing feature has been added to DataGrid to edit localStorage.
Column numbers (0 and 1) are hardcoded.

This patch makes column editing feature more generic: remove hardcoded
colums, take "editable" column property into account.

This patch is a prerequisite for cookie editing.

* inspector/front-end/DOMStorageItemsView.js:
Use meaningful column names.
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._ondblclick): Check column editability.
(WebInspector.DataGrid.prototype._contextMenuInDataTable): Ditto.
(WebInspector.DataGridNode.prototype.createCell):
Supply cell element with column id.
(WebInspector.DataGrid.prototype.columnIdentifierFromNode):
Added utility method.
(WebInspector.DataGrid.prototype._nextEditableColumn): Ditto.
(WebInspector.DataGrid.prototype._keyDown): Calculate editable column.
(WebInspector.DataGrid.prototype._editingCommitted): Ditto.
(WebInspector.DataGrid.prototype._startEditing): Ditto.
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
Refined parameter type / name.
(WebInspector.DataGrid.prototype._resizerDragging):
Fix resizer index property names.
(WebInspector.DataGrid.prototype._startResizerDragging): Ditto.
(WebInspector.DataGrid.prototype._positionResizers): Ditto.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded): Ditto.

LayoutTests:

* inspector/storage-panel-dom-storage-update.html: Fix column names.
* inspector/storage-panel-dom-storage.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix after r139357. It was missing a comma.
commit | commitdiff | tree
rniwa@webkit.org [Fri, 11 Jan 2013 05:33:05 +0000 (05:33 +0000)]
Build fix after r139357. It was missing a comma.

* QueueStatusServer/model/queues.py:
(Queue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoElements must be reattached when inserted/removed from top layer
commit | commitdiff | tree
falken@chromium.org [Fri, 11 Jan 2013 04:46:21 +0000 (04:46 +0000)]
Elements must be reattached when inserted/removed from top layer
https://bugs.webkit.org/show_bug.cgi?id=105489

Reviewed by Julien Chaffraix.

Source/WebCore:

Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.

We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.

Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html
       fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html

* dom/Element.cpp:
(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.

LayoutTests:

* fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
* fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.
This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).
* fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
* fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.
This tests that top layer ordering is correct after removing and readding an element to the top layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen a selected node in nested ShadowDOM is deleted, selection have wrong range.
commit | commitdiff | tree
shinyak@chromium.org [Fri, 11 Jan 2013 04:44:20 +0000 (04:44 +0000)]
When a selected node in nested ShadowDOM is deleted, selection have wrong range.
https://bugs.webkit.org/show_bug.cgi?id=106526

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since FrameSelection and htmlediting did not consider nested Shadow DOM, the FrameSelection still selects
removed elements if selected nodes in nested Shadow DOM are removed.

We have to use containsIncludingShadowDOM to handle with nested Shadow DOM correctly.

Test: fast/dom/shadow/selection-in-nested-shadow.html

* editing/FrameSelection.cpp:
(WebCore::removingNodeRemovesPosition):
* editing/htmlediting.cpp:
(WebCore::updatePositionForNodeRemoval):

LayoutTests:

* fast/dom/shadow/selection-in-nested-shadow-expected.txt: Added.
* fast/dom/shadow/selection-in-nested-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks
commit | commitdiff | tree
morrita@google.com [Fri, 11 Jan 2013 04:00:13 +0000 (04:00 +0000)]
[Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks
https://bugs.webkit.org/show_bug.cgi?id=106614

Reviewed by Dimitri Glazkov.

This change simplifies InsertionPoint overrides and give some flexibility to it.

The change

- Removes InsertionPoint::isSelectValid(). now ContentSelectorQuery parses given selector anyway.
  Invalid select attribute is handled by newly introduced matchTypeFor() method.
- Introduces InsertionPoint::matchTypeFor() to give a chance each InsertionPoint to decide whether it
  accepts the given node as its distribution. Then it lets DetailsSummaryElement adopt it.
- Pulls some HTMLShadowElement overrides up to InsertionPoint so that other upcoming InsertionPoint
  subclasses don't need to override them.

No new tests. Refactoring.

* html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
- Implemented matchTypeFor() to get rid of HTMLContentElement machinery which is compiled out in the upcoming change.
(DetailsSummaryElement):
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::matchTypeFor): Added.
(WebCore):
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
(WebCore::isHTMLContentElement):
* html/shadow/HTMLShadowElement.cpp:
* html/shadow/HTMLShadowElement.h:
(HTMLShadowElement):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::emptySelectorList): Moved from HTMLShadowElement.
(WebCore):
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::matchTypeFor): Added.
(WebCore::InsertionPoint::selectorList): Moved from HTMLShadowElement.
(InsertionPoint):
* testing/Internals.cpp:
(WebCore::Internals::isValidContentSelect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixing AuthenticationError when running test-webkitpy as a non-committer.
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 03:18:36 +0000 (03:18 +0000)]
Fixing AuthenticationError when running test-webkitpy as a non-committer.
https://bugs.webkit.org/show_bug.cgi?id=106420

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.push_local_commits_to_server):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository):
(SVNRepository.has_authorization_for_realm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPlugin snapshot label should take device resolution and inset into account
commit | commitdiff | tree
dino@apple.com [Fri, 11 Jan 2013 02:01:02 +0000 (02:01 +0000)]
Plugin snapshot label should take device resolution and inset into account
https://bugs.webkit.org/show_bug.cgi?id=106619

Reviewed by Simon Fraser.

* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paintLabel): Take into account the inset in the label image.
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel): Look at the page's device scale, and adjust the label image accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Store scrollable layer's contents size for coordinated scrollable layers
commit | commitdiff | tree
jamesr@google.com [Fri, 11 Jan 2013 00:07:22 +0000 (00:07 +0000)]
[chromium] Store scrollable layer's contents size for coordinated scrollable layers
https://bugs.webkit.org/show_bug.cgi?id=106518

Reviewed by Adrienne Walker.

Source/WebCore:

This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
layer.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Update expected results for IndexedDB layout tests
commit | commitdiff | tree
commit-queue@webkit.org [Fri, 11 Jan 2013 00:01:42 +0000 (00:01 +0000)]
IndexedDB: Update expected results for IndexedDB layout tests
https://bugs.webkit.org/show_bug.cgi?id=106411

Patch by Michael Pruett <michael@68k.org> on 2013-01-10
Reviewed by Tony Chang.

For IndexedDB layout tests whose output differs between V8 and
JSC, move V8 test output to platform/chromium and set expected
results to JSC test output.

* platform/chromium/storage/indexeddb/exception-in-event-aborts-expected.txt: Copied from LayoutTests/storage/indexeddb/exception-in-event-aborts-expected.txt.
* platform/chromium/storage/indexeddb/transaction-error-expected.txt: Copied from LayoutTests/storage/indexeddb/transaction-error-expected.txt.
* platform/chromium/storage/indexeddb/version-change-abort-expected.txt: Copied from LayoutTests/storage/indexeddb/version-change-abort-expected.txt.
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/transaction-error-expected.txt:
* storage/indexeddb/version-change-abort-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky.
commit | commitdiff | tree
dglazkov@chromium.org [Thu, 10 Jan 2013 23:43:09 +0000 (23:43 +0000)]
Layout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=106612

* platform/chromium/TestExpectations: Marked as flake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController.
commit | commitdiff | tree
commit-queue@webkit.org [Thu, 10 Jan 2013 23:35:54 +0000 (23:35 +0000)]
[Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController.
https://bugs.webkit.org/show_bug.cgi?id=106537

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Rename 3 methods to match the terms of ViewportAttributes.

* UIProcess/API/qt/qwebkittest.cpp:
(QWebKitTest::viewport):
(QWebKitTest::contentsScale):
* UIProcess/PageViewportController.h:
(WebKit::PageViewportController::minimumScale):
(WebKit::PageViewportController::maximumScale):
(WebKit::PageViewportController::currentScale):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test animations/fill-mode-iteration-count-non-integer.html is failing.
commit | commitdiff | tree
dglazkov@chromium.org [Thu, 10 Jan 2013 23:14:33 +0000 (23:14 +0000)]
[Chromium] Layout Test animations/fill-mode-iteration-count-non-integer.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=106609

* platform/chromium/TestExpectations: Marked as failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdjust ref-test expectation to actual work.
commit | commitdiff | tree
dglazkov@chromium.org [Thu, 10 Jan 2013 23:11:10 +0000 (23:11 +0000)]
Adjust ref-test expectation to actual work.

* platform/chromium/TestExpectations: Adjusted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline. Apple Windows port.
commit | commitdiff | tree
roger_fong@apple.com [Thu, 10 Jan 2013 22:45:16 +0000 (22:45 +0000)]
Unreviewed rebaseline. Apple Windows port.

* platform/win/fast/ruby/base-shorter-than-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky...
commit | commitdiff | tree
dglazkov@chromium.org [Thu, 10 Jan 2013 22:42:09 +0000 (22:42 +0000)]
[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=106606

* platform/chromium/TestExpectations: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement AutocompleteErrorEvent#reason
commit | commitdiff | tree
commit-queue@webkit.org [Thu, 10 Jan 2013 22:40:15 +0000 (22:40 +0000)]
Implement AutocompleteErrorEvent#reason
https://bugs.webkit.org/show_bug.cgi?id=105568

Source/WebCore:

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Test: fast/events/constructors/autocomplete-error-event-constructor.html

* WebCore.gypi: Added AutocompleteErrorEvent.idl and AutocompleteErrorEvent.h for chromium port's build.
* dom/AutocompleteErrorEvent.h: Added.
(WebCore): Added new type of error named AutocompleteErrorEvent.
(AutocompleteErrorEventInit): Added init params for AutocompleteErrorEvents (so initEvent() can be used).
(AutocompleteErrorEvent): Added a new error event that inherits from Event but also has a reason for failure.
(WebCore::AutocompleteErrorEvent::create): Factory function to create AutocompleteErrorEvents.
(WebCore::AutocompleteErrorEvent::reason): The reason why a requestAutocomplete() invocation failed. Can be
                                           "disabled", "cancel", or "invalid".
(WebCore::AutocompleteErrorEvent::interfaceName): The name of the event's interface (for event.toString()).
(WebCore::AutocompleteErrorEvent::AutocompleteErrorEvent): Various ways of constructing the error event.
* dom/AutocompleteErrorEvent.idl: Added.
* dom/EventNames.in: Added AutocompleteError to this list, based on REQUEST_AUTOCOMPLETE conditional.
* html/HTMLFormElement.cpp: Updated form elements to dispatch AutocompleteErrorEvents on errors and to give
                            more details (event.reason) when the request fails.
(WebCore::HTMLFormElement::requestAutocomplete): Changed to newly added failure type "disabled".
(WebCore::HTMLFormElement::finishRequestAutocomplete): Changed
* html/HTMLFormElement.h: Added new results (ErrorDisabled, ErrorCancel, ErrorInvalid).
* page/DOMWindow.idl: Added global event constructor for new AutocompleteErrorEvent() style event creation.

Source/WebKit/chromium:

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

* public/WebFormElement.h: Added matching enum values for public chromium WebKit API.
* src/AssertMatchingEnums.cpp: Updated compile assert that WebKit and WebCore enums match.

LayoutTests:

Added tests to verify event creation and global event constructor existence of AutocompleteErrorEvent
and updated the existing tests to make sure errors received are of the right type and have the right reason.

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

* fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
* fast/events/constructors/autocomplete-error-event-constructor.html: Added.
* fast/events/event-creation.html: Added new AutocompleteErrorEvent() test case.
* fast/forms/form-request-autocomplete.html: Updated 'autocompleteerror' listeners to check event.reason.
* fast/js/constructor-length.html: Added AutocompleteErrorEvent to list.
* fast/js/script-tests/global-constructors.js: Added AutocompleteErrorEvent to list.
* platform/blackberry/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
* platform/chromium/fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
* platform/chromium/fast/forms/form-request-autocomplete-expected.txt: Updated passing expectations.
* platform/chromium/fast/js/constructor-length-expected.txt: Added expected 0 length result.
* platform/gtk/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
* platform/mac/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
* platform/qt/fast/js/constructor-length-expected.txt: Added expected ReferenceError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLMediaElement::resume() should schedule a load rather than load immediately
commit | commitdiff | tree
yoli@rim.com [Thu, 10 Jan 2013 22:31:48 +0000 (22:31 +0000)]
HTMLMediaElement::resume() should schedule a load rather than load immediately
https://bugs.webkit.org/show_bug.cgi?id=106587

Reviewed by Eric Carlson.

It is not always safe to start the jobs at the time resume() is called. That is why the jobs are
suspended. It can also be suspended again right after being resumed.

No new tests as there is no visible functional change, also it is a theoretically good-to-have change
that doesn't fix any known cross-platform issue.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::resume): Replace load() with scheduleLoad().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaselines. Apple Windows port.
commit | commitdiff | tree
roger_fong@apple.com [Thu, 10 Jan 2013 22:31:22 +0000 (22:31 +0000)]
Unreviewed rebaselines. Apple Windows port.

* platform/win/TestExpectations:
* platform/win/fast/dom/window-load-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r139226.
commit | commitdiff | tree
commit-queue@webkit.org [Thu, 10 Jan 2013 22:25:40 +0000 (22:25 +0000)]
Unreviewed, rolling out r139226.
http://trac.webkit.org/changeset/139226
https://bugs.webkit.org/show_bug.cgi?id=106602

re
baselines were premature (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-10

* platform/win/accessibility/canvas-fallback-content-2-expected.txt:
* platform/win/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Removed.
* platform/win/platform/win/accessibility/select-element-valuechange-event-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate WebkitSystemInterface lib for Windows port.
commit | commitdiff | tree
roger_fong@apple.com [Thu, 10 Jan 2013 22:09:24 +0000 (22:09 +0000)]
Update WebkitSystemInterface lib for Windows port.
This hasn't been done in a while and the current one is out of date.
In addition I believe it will fix:
<rdar://problem/12990844>

Rubberstamped by Timothy Horton.

* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

next
Mirror of the WebKit open source project from svn.webkit.org.