WebKit-https.git
8 years ago[GTK] Unit tests are noisy when run under jhbuild
mrobinson@webkit.org [Mon, 5 Mar 2012 08:42:06 +0000 (08:42 +0000)]
[GTK] Unit tests are noisy when run under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80241

Reviewed by Philippe Normand.

Force the 'memory' backend in GSettings so that each unit
test doesn't produce a warning when it's forced to fall back
to the 'memory' backend.

* Scripts/run-gtk-tests:
(TestRunner.run): Force the 'memory' backend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInternally used HTMLContentElement subclasses should have correct wrapper.
morrita@google.com [Mon, 5 Mar 2012 08:37:51 +0000 (08:37 +0000)]
Internally used HTMLContentElement subclasses should have correct wrapper.
https://bugs.webkit.org/show_bug.cgi?id=80237

Reviewed by Kent Tamura.

Source/WebCore:

DetailsContentElement and DetailsSummaryElement used to use
<div> as their tag name. But this means they are wrapped by
wrapper objects for HTMLDivElement, which is wrong. This happened
to work though because HTMLDivElement has no extra state or API.

This change introduces "noConstructor" keyword for make_name.pl
sources.  This keyword allows a tag name to specify its own
wrapper without making the tag name visible from the parser, or
HTMLElementFactory in precise.

Following this addition, this change also adds a new tag name
"webkitShadowContent" for DetailsContentElement and DetailsSummaryElement,
which has no constructor, and whose wrapper type is HTMLElement.

This change isn't visible from the page author and only matters for testing.

Test: fast/dom/shadow/content-element-user-agent-shadow.html

* dom/make_names.pl:
(defaultTagPropertyHash):
(buildConstructorMap):
(printConstructors):
(printFunctionInits):
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
* html/HTMLTagNames.in:
* html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):

LayoutTests:

* fast/dom/shadow/content-element-user-agent-shadow-expected.txt: Added.
* fast/dom/shadow/content-element-user-agent-shadow.html: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector"...
mrobinson@webkit.org [Mon, 5 Mar 2012 08:35:15 +0000 (08:35 +0000)]
[GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
https://bugs.webkit.org/show_bug.cgi?id=80235

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Wait to inspect the WebView until the page has finished loading. Also
clean up some minor style errors.

* tests/testwebinspector.c:
(closeInspector): Small style fixes.
(showInspector): Ditto.
(loadFinished): Ditto.
(test_webkit_web_inspector_close_and_inspect): Wait to inspect until the page has loaded.
(test_webkit_web_inspector_destroy_inspected_web_view): Ditto.
(main): Small style fixes.

Tools:

* Scripts/run-gtk-tests:
(TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
inspector resources path determination is shared by all tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] REGRESSION: r108278 broke some tests that expect focus
mrobinson@webkit.org [Mon, 5 Mar 2012 08:28:59 +0000 (08:28 +0000)]
[GTK] REGRESSION: r108278 broke some tests that expect focus
https://bugs.webkit.org/show_bug.cgi?id=79084

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Grab focus before running the test. This ensures that if the
WebView lost focus, it has it before sending events.

* tests/testcopyandpaste.c:
(test_copy_and_paste): Grab focus.

Tools:

Grab focus when dumping test results and also when sending
events. During the course of testing, the WebView may lose
focus and this seems to snap it back when tests demand it.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump): Grab focus.
* DumpRenderTree/gtk/EventSender.cpp:
(dispatchEvent): Ditto.

LayoutTests:

* platform/gtk/Skipped: Unskip passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: Move HTMLContentElement::attach to InsertionPoint::attach.
shinyak@chromium.org [Mon, 5 Mar 2012 08:22:33 +0000 (08:22 +0000)]
Refactoring: Move HTMLContentElement::attach to InsertionPoint::attach.
https://bugs.webkit.org/show_bug.cgi?id=80243

Reviewed by Hajime Morita.

Since the current code in HTMLContentElement::attach() will be used for coming <shadow>
elements, it is natural that InsertionPoint::attach() has such code.

No new tests, no change in behavior.

* html/shadow/HTMLContentElement.cpp:
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach):
(WebCore):
(WebCore::InsertionPoint::detach):
* html/shadow/InsertionPoint.h:
(InsertionPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline search-field-cancel.html for r109503.
tkent@chromium.org [Mon, 5 Mar 2012 08:18:11 +0000 (08:18 +0000)]
[Chromium] Rebaseline search-field-cancel.html for r109503.

* platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
* platform/chromium-mac-leopard/fast/repaint/search-field-cancel-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Added.
* platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
* platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoallowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not...
abarth@webkit.org [Mon, 5 Mar 2012 08:13:42 +0000 (08:13 +0000)]
allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=80178

Reviewed by Eric Seidel.

These functions are only used by SQLDatabase, which means we can move
them to DatabaseContext, removing one more tendril of the SQLDatabase
code.

* dom/Document.cpp:
(WebCore):
* dom/Document.h:
(Document):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
* storage/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::from):
(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore):
(WebCore::DatabaseContext::databaseExceededQuota):
* storage/DatabaseContext.h:
(DatabaseContext):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
* storage/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExceedQuota):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::executeSQL):
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, mark two tests as flaky in GTK.
philn@webkit.org [Mon, 5 Mar 2012 08:03:08 +0000 (08:03 +0000)]
Unreviewed, mark two tests as flaky in GTK.

* platform/gtk/test_expectations.txt:
editing/selection/select-line-break-with-opposite-directionality.html
and fast/css/hover-update.html are flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r107551.
commit-queue@webkit.org [Mon, 5 Mar 2012 07:57:36 +0000 (07:57 +0000)]
Unreviewed, rolling out r107551.
http://trac.webkit.org/changeset/107551
https://bugs.webkit.org/show_bug.cgi?id=80245

caused incorrect style sharing (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-04

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused macro HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE_WITH_VALUE.
macpherson@chromium.org [Mon, 5 Mar 2012 06:57:40 +0000 (06:57 +0000)]
Remove unused macro HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE_WITH_VALUE.
https://bugs.webkit.org/show_bug.cgi?id=80236

Reviewed by Eric Seidel.

No new tests / unused code deletion only.

* css/CSSStyleSelector.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJIT heuristics should be hyperbolic
fpizlo@apple.com [Mon, 5 Mar 2012 06:52:44 +0000 (06:52 +0000)]
JIT heuristics should be hyperbolic
https://bugs.webkit.org/show_bug.cgi?id=80055
<rdar://problem/10922260>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Added tracking of the amount of executable memory typically used for a bytecode
instruction. Modified the execution counter scheme to use this, and the amount
of free memory, to determine how long to wait before invoking the JIT.

The result is that even if we bomb the VM with more code than can fit in our
executable memory pool, we still keep running and almost never run out of
executable memory - which ensures that if we have to JIT something critical, then
we'll likely have enough memory to do so. This also does not regress performance
on the three main benchmarks.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::predictedMachineCodeSize):
(JSC):
(JSC::CodeBlock::usesOpcode):
* bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::checkIfJITThresholdReached):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecutionActiveThreshold):
(JSC::CodeBlock::offsetOfJITExecutionTotalCount):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
* bytecode/ExecutionCounter.cpp: Added.
(JSC):
(JSC::ExecutionCounter::ExecutionCounter):
(JSC::ExecutionCounter::checkIfThresholdCrossedAndSet):
(JSC::ExecutionCounter::setNewThreshold):
(JSC::ExecutionCounter::deferIndefinitely):
(JSC::ExecutionCounter::applyMemoryUsageHeuristics):
(JSC::ExecutionCounter::applyMemoryUsageHeuristicsAndConvertToInt):
(JSC::ExecutionCounter::hasCrossedThreshold):
(JSC::ExecutionCounter::setThreshold):
(JSC::ExecutionCounter::reset):
* bytecode/ExecutionCounter.h: Added.
(JSC):
(ExecutionCounter):
(JSC::ExecutionCounter::formattedTotalCount):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* jit/ExecutableAllocator.cpp:
(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
* llint/LowLevelInterpreter32_64.asm:
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
* wtf/SimpleStats.h: Added.
(WTF):
(SimpleStats):
(WTF::SimpleStats::SimpleStats):
(WTF::SimpleStats::add):
(WTF::SimpleStats::operator!):
(WTF::SimpleStats::count):
(WTF::SimpleStats::sum):
(WTF::SimpleStats::sumOfSquares):
(WTF::SimpleStats::mean):
(WTF::SimpleStats::variance):
(WTF::SimpleStats::standardDeviation):

Source/WebCore:

Reviewed by Oliver Hunt.

No new tests, since there's no new functionality.

* ForwardingHeaders/wtf/SimpleStats.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Methods like firstRendererOf of NodeRenderingContext should be extracted.
shinyak@chromium.org [Mon, 5 Mar 2012 06:30:22 +0000 (06:30 +0000)]
Source/WebCore: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902

Reviewed by Hajime Morita.

firstRendererOfInsertionPoint should return the first renderer of its child, however
it returns next renderer of parent. The same thing happens lastRendererOfInsertionPoint.

Test: content-element-move.html has another test case.

* dom/NodeRenderingContext.cpp:
(WebCore):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

LayoutTests: Refactoring: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902

Reviewed by Hajime Morita.

Added a new test case.

* fast/dom/shadow/content-element-move-expected.txt:
* fast/dom/shadow/content-element-move.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for ENABLE(MATHML).
morrita@google.com [Mon, 5 Mar 2012 04:43:00 +0000 (04:43 +0000)]
Unreviewed build fix for ENABLE(MATHML).

* mathml/MathMLElement.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
morrita@google.com [Mon, 5 Mar 2012 04:09:39 +0000 (04:09 +0000)]
WebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
https://bugs.webkit.org/show_bug.cgi?id=80229

Reviewed by Kent Tamura.

The code generator has naked static_cast<> which could be unsafe.
We can turn it into toHTMLUnknownElement() and the like.

No new tests. Just added a sanity check.

* dom/make_names.pl:
(printWrapperFactoryCppFile):
* html/HTMLElement.h:
(HTMLElement):
(WebCore::HTMLElement::isHTMLUnknownElement):
* html/HTMLUnknownElement.h:
(HTMLUnknownElement):
(WebCore::toHTMLUnknownElement):
(WebCore):
* mathml/MathMLElement.h:
(toMathMLElement):
* svg/SVGElement.h:
(WebCore::toSVGElement):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Add myself to committer list.
charles.wei@torchmobile.com.cn [Mon, 5 Mar 2012 04:02:12 +0000 (04:02 +0000)]
Unreviewed, Add myself to committer list.
https://bugs.webkit.org/show_bug.cgi?id=80232

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHandle CSSPropertyWebkitColumnBreakAfter, CSSPropertyWebkitColumnBreakBefore and...
macpherson@chromium.org [Mon, 5 Mar 2012 03:38:58 +0000 (03:38 +0000)]
Handle CSSPropertyWebkitColumnBreakAfter, CSSPropertyWebkitColumnBreakBefore and CSSPropertyWebkitColumnBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80226

Reviewed by Eric Seidel.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] upstream CredentialManager and CredentialTransformData implementation
commit-queue@webkit.org [Mon, 5 Mar 2012 03:29:28 +0000 (03:29 +0000)]
[BlackBerry] upstream CredentialManager and CredentialTransformData implementation
https://bugs.webkit.org/show_bug.cgi?id=80107

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.

Initial upstream of CredentialManager.[h|cpp] and
CredentialTransformData.[h|cpp].
No new test.

Source/WebKit:

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

* WebCoreSupport/CredentialManager.cpp: Added.
(WebCore):
(WebCore::CredentialManager::CredentialManager):
(WebCore::CredentialManager::autofillAuthenticationChallenge):
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
* WebCoreSupport/CredentialManager.h: Added.
(WebKit):
(WebCore):
(CredentialManager):
* WebCoreSupport/CredentialTransformData.cpp: Added.
(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore):
(WebCore::CredentialTransformData::url):
(WebCore::CredentialTransformData::credential):
(WebCore::CredentialTransformData::setCredential):
(WebCore::CredentialTransformData::findPasswordFormFields):
* WebCoreSupport/CredentialTransformData.h: Added.
(WebCore):
(CredentialTransformData):
(WebCore::CredentialTransformData::isValid):
(WebCore::CredentialTransformData::protectionSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Credential backing store implementation
commit-queue@webkit.org [Mon, 5 Mar 2012 03:23:58 +0000 (03:23 +0000)]
[BlackBerry] Credential backing store implementation
https://bugs.webkit.org/show_bug.cgi?id=79650

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.

Opened Credential database in CedentialBackingStore::instance().
Added never_remember table and associated sql statment
members to store the never remember sites.
Removed CredentialStorage initialize codes because that
won't give users a chance to re-enter the new credential
information for an already stored site.
Changed login update and has statement to support
autofill feature of multiple credential forms in the
same page; Also added url as a parameter of hasLogin() function.
Added calling reset() after each statement calls step(),
to make it work correctly next time.
Also fixed a macro typo in HANDLE_SQL_EXEC_FAILURE.

No new tests.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::instance):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::close):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::hasNeverRemember):
(WebCore::CredentialBackingStore::getNeverRemember):
(WebCore::CredentialBackingStore::removeNeverRemember):
(WebCore::CredentialBackingStore::clearLogins):
(WebCore::CredentialBackingStore::clearNeverRemember):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
commit-queue@webkit.org [Mon, 5 Mar 2012 03:15:18 +0000 (03:15 +0000)]
[EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=80211

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.

This patch adds initialization and destruction codes using Evas_GL APIs to GC3DPrivate.

No new tests. No behavior change.

* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Libraries are installed to /usr/lib and not /usr/lib64 on x86_64
kubo@profusion.mobi [Mon, 5 Mar 2012 03:01:38 +0000 (03:01 +0000)]
[CMake] Libraries are installed to /usr/lib and not /usr/lib64 on x86_64
https://bugs.webkit.org/show_bug.cgi?id=71507

Reviewed by Antonio Gomes.

.:

* Source/cmake/OptionsCommon.cmake: Provide two variables which
can be changed via CMake: LIB_SUFFIX, which is often used in CMake
projects to let the user choose whether a suffix should be added
to the library installation directory (such as 32 or 64), and
LIB_INSTALL_DIR, which takes LIB_SUFFIX into account to determine
whether to install libraries.

Source/JavaScriptCore:

* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebCore:

No new tests, buildsystem change.

* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebKit:

* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebKit2:

* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Implementation of missing functions in GraphicsContext3DPrivate
commit-queue@webkit.org [Mon, 5 Mar 2012 02:43:37 +0000 (02:43 +0000)]
[EFL] Implementation of missing functions in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=79759

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.

The initial patch (Bug 62961) only contains implementations for simple functions
which call GL functions through Evas_GL_API.
This patch implements a little complicated functions such as getActiveAttrib(),
getShaderSource() and so on.

No new tests. No behavior change.

* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getError):
(WebCore::GraphicsContext3DPrivate::getIntegerv):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
haraken@chromium.org [Mon, 5 Mar 2012 02:33:21 +0000 (02:33 +0000)]
Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80139

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl.

No tests. No change in behavior.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.idl:
* svg/DOMWindowSVG.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] We should reset mouse position before calling eventSender.mouseMove in...
tkent@chromium.org [Mon, 5 Mar 2012 02:32:00 +0000 (02:32 +0000)]
[Chromium] We should reset mouse position before calling eventSender.mouseMove in LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=79748

* platform/chromium/test_expectations.txt: Removed flaky expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
haraken@chromium.org [Mon, 5 Mar 2012 02:24:20 +0000 (02:24 +0000)]
Revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80144

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl.

No tests. No change in behavior.

* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/DOMWindowWebGL.idl: Removed.
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Mon, 5 Mar 2012 02:01:45 +0000 (02:01 +0000)]
Unreviewed, gardening.

* platform/chromium/fast/files/xhr-response-blob-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
morrita@google.com [Mon, 5 Mar 2012 01:59:51 +0000 (01:59 +0000)]
Unreviewed build fix.

* rendering/RenderButton.cpp:
(WebCore::RenderButton::canHaveGeneratedChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r108758): Assertion failure in WebCore::RenderMenuList::addChild
morrita@google.com [Mon, 5 Mar 2012 01:39:47 +0000 (01:39 +0000)]
REGRESSION(r108758): Assertion failure in WebCore::RenderMenuList::addChild
https://bugs.webkit.org/show_bug.cgi?id=80096

Reviewed by Dimitri Glazkov.

Source/WebCore:

After r108758 RenderBlock allowed <select> to have generated
contents. But it shouldn't. This change stops allowing it again by
replacing some canHaveChildren() invocations with
less permissive canHaveGeneratedChildren().

This change also pulls back original canHaveChildren() logic to
RenderButton to allow <button> to have generated contents.

Then RenderDeprecatedFlexibleBox::buttonText() is morphed to
more intention revealing canHaveGeneratedChildren().

Test: fast/forms/select-generated-content.html

* rendering/RenderBlock.cpp:
(WebCore):
(WebCore::canHaveGeneratedChildren):
(WebCore::RenderBlock::styleDidChange):
(WebCore::findFirstLetterBlock):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderButton.cpp:
* rendering/RenderButton.h:
(RenderButton):
* rendering/RenderDeprecatedFlexibleBox.h:
(WebCore::RenderDeprecatedFlexibleBox::canHaveGeneratedChildren):
* rendering/RenderMenuList.h:

LayoutTests:

* fast/forms/select-generated-content-expected.txt: Added.
* fast/forms/select-generated-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-03-04 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Mon, 5 Mar 2012 01:34:22 +0000 (01:34 +0000)]
2012-03-04 Antonio Gomes <agomes@rim.com>

        Fixed positioned element not correctly positioned after orientation change,
        when viewport metatag is used with "initial-scale=1" MKS_2992596
        PR #138865

        Reviewed by George Staikos.

        Viewport size changes in two main scenarios:
        - orientation changes;
        - virtual keyboard pop up/hide.

        When we are setting a new viewport size, we need to
        update the FixedReportedSize of the mainframe. This size
        is used to return innerWidth|Heigth as well as to calculate
        the fixed position elements height relative to the RenderView [1].

        [1] RenderBox::containingBlockLogicalHeightForPositioned.

        When we are rotating, we need to delay setting the new FixedReportedSize
        till we layout and are able to figure out the new contents size. At this
        time we call setFixedReportedSize, but we do not reposition the fixed elemts
        afterwards.

        Patch adds a call to FrameView::repaintFixedElementsAfterScrolling, after
        setting the new size.

        Source/WebKit/blackberry:
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):

        Source/WebCore:
        * manual-tests/blackberry/meta-viewport-fixed-position-preserved-on-rotation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Mon, 5 Mar 2012 01:09:02 +0000 (01:09 +0000)]
Unreviewed, gardening.

* platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Mon, 5 Mar 2012 00:44:28 +0000 (00:44 +0000)]
Unreviewed, gardening.

* platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Mon, 5 Mar 2012 00:30:01 +0000 (00:30 +0000)]
Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Mon, 5 Mar 2012 00:23:47 +0000 (00:23 +0000)]
Unreviewed, gardening.

* platform/chromium/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream two helper files from platform/graphics/blackberry
commit-queue@webkit.org [Sun, 4 Mar 2012 21:35:38 +0000 (21:35 +0000)]
[BlackBerry] Upstream two helper files from platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=80125

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Added.
(WebCore):
(InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::~InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::isSolidColor):
(WebCore::InstrumentedPlatformCanvas::solidColor):
(WebCore::InstrumentedPlatformCanvas::save):
(WebCore::InstrumentedPlatformCanvas::saveLayer):
(WebCore::InstrumentedPlatformCanvas::restore):
(WebCore::InstrumentedPlatformCanvas::translate):
(WebCore::InstrumentedPlatformCanvas::scale):
(WebCore::InstrumentedPlatformCanvas::rotate):
(WebCore::InstrumentedPlatformCanvas::skew):
(WebCore::InstrumentedPlatformCanvas::concat):
(WebCore::InstrumentedPlatformCanvas::setMatrix):
(WebCore::InstrumentedPlatformCanvas::clipRect):
(WebCore::InstrumentedPlatformCanvas::clipPath):
(WebCore::InstrumentedPlatformCanvas::clipRegion):
(WebCore::InstrumentedPlatformCanvas::clear):
(WebCore::InstrumentedPlatformCanvas::drawPaint):
(WebCore::InstrumentedPlatformCanvas::drawPoints):
(WebCore::InstrumentedPlatformCanvas::drawRect):
(WebCore::InstrumentedPlatformCanvas::drawPath):
(WebCore::InstrumentedPlatformCanvas::drawBitmap):
(WebCore::InstrumentedPlatformCanvas::drawBitmapRect):
(WebCore::InstrumentedPlatformCanvas::drawBitmapMatrix):
(WebCore::InstrumentedPlatformCanvas::drawSprite):
(WebCore::InstrumentedPlatformCanvas::drawText):
(WebCore::InstrumentedPlatformCanvas::drawPosText):
(WebCore::InstrumentedPlatformCanvas::drawPosTextH):
(WebCore::InstrumentedPlatformCanvas::drawTextOnPath):
(WebCore::InstrumentedPlatformCanvas::drawPicture):
(WebCore::InstrumentedPlatformCanvas::drawVertices):
(WebCore::InstrumentedPlatformCanvas::drawData):
* platform/graphics/blackberry/LayerMessage.h: Added.
(WebCore):
(WebCore::isCompositingThread):
(WebCore::compositingThread):
(WebCore::isWebKitThread):
(WebCore::webKitThread):
(WebCore::dispatchCompositingMessage):
(WebCore::dispatchSyncCompositingMessage):
(WebCore::dispatchWebKitMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNewer versions of clang fail to compile WebKit.
andersca@apple.com [Sun, 4 Mar 2012 20:46:32 +0000 (20:46 +0000)]
Newer versions of clang fail to compile WebKit.

Fix build.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(descriptionOfValue):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::selectedTextRange):
* DumpRenderTree/mac/EditingDelegate.mm:
(-[DOMRange dump]):
* DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSError _drt_descriptionSuitableForTestResult]):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::descriptionOfValue):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::selectedTextRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotable tests for CSS3 calc
mikelawther@chromium.org [Sun, 4 Mar 2012 20:43:42 +0000 (20:43 +0000)]
table tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75898

Reviewed by Julien Chaffraix.

Tests CSS3 calc() (see http://webkit.org/b/16662) on some simple examples with tables.

* css3/calc/table-calcs-expected.txt: Added.
* css3/calc/table-calcs.html: Added.
* css3/calc/table-empty-cells-expected.html: Added.
* css3/calc/table-empty-cells.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly
zimmermann@webkit.org [Sun, 4 Mar 2012 19:07:52 +0000 (19:07 +0000)]
Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly
https://bugs.webkit.org/show_bug.cgi?id=79790

Reviewed by Dirk Schulze.

Source/WebCore:

Restore SMIL animation behavior back to pre-r109342.
1) Always animate presentation attributes as CSS properties, regardless of the
attributeTypes value. Matches Opera/FF, and makes the attribute optional again
as specified in both SMIL & SVG.

Extend existing svg/animations/attributesTypes.html to verify this.

2) Switch setInstancesUpdatesBlocked calls to the right locations again, to
avoid chromium assertions (and/or extra work being done). Fixing that reveals another
problem: in the instance updating code path, we always called setTargetAttributeAnimatedCSSValue
even for XML animations.

* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::shouldApplyAnimation): Restore old logic.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): Fix typo, move setInstancesUpdatesBlocked calls.

LayoutTests:

Extended attributesTypes.html test case to check that presentation attributes are
always animated as CSS properties, regardless of their attributeTypes value.

* platform/chromium/test_expectations.txt: Remove animate-elem-32-t.svg suppression.
* svg/animations/attributeTypes-expected.txt: Updated expectations.
* svg/animations/resources/attributeTypes.svg: Fix comment.
* svg/animations/script-tests/attributeTypes.js: Extend test.
(sample1):
(sample2):
(sample3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build when the classic interpreter is enabled
ddkilzer@apple.com [Sun, 4 Mar 2012 18:53:51 +0000 (18:53 +0000)]
Fix build when the classic interpreter is enabled

Reviewed by Gavin Barraclough.

Fixes the following build error when running the "Generate
Derived Sources" build phase script:

    offlineasm: Parsing JavaScriptCore/llint/LowLevelInterpreter.asm and ../../JSCLLIntOffsetsExtractor and creating assembly file LLIntAssembly.h.
    ./JavaScriptCore/offlineasm/offsets.rb:145:in `offsetsAndConfigurationIndex': unhandled exception
            from JavaScriptCore/offlineasm/asm.rb:131
    Command /bin/sh failed with exit code 1

Gavin's fix in r109674 avoided the #error statement in
JITStubs.h when compiling LLIntOffsetsExtractor.cpp, but it
caused the "Generate Derived Sources" build phase script to fail
when JavaScriptCore/offlineasm/asm.rb was run.  The solution is
to detect when the classic interpreter is being built and simply
exit early from asm.rb in that case.

* llint/LLIntOffsetsExtractor.cpp:
(JSC::LLIntOffsetsExtractor::dummy): Return NULL pointer if the
JIT is disabled.  Note that offsets.rb doesn't care about the
return value here, but instead it cares about finding the magic
values in the binary.  The magic values are no longer present
when the JIT is disabled.
* offlineasm/asm.rb: Catch MissingMagicValuesException and exit
early with a status message.
* offlineasm/offsets.rb:
(MissingMagicValuesException): Add new exception class.
(offsetsAndConfigurationIndex): Throw
MissingMagicValuesException when no magic values are found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] upstream MediaPlayerPrivateBlackBerry.[cpp|h]
commit-queue@webkit.org [Sun, 4 Mar 2012 17:11:45 +0000 (17:11 +0000)]
[BlackBerry] upstream MediaPlayerPrivateBlackBerry.[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=79729

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Rob Buis and Antonio Gomes.

Implementation of MediaPlayerPrivate for BlackBerry porting.
Initial upstream, No new tests.

* PlatformBlackBerry.cmake:
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp: Added.
(WebCore):
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::notifyAppActivatedEvent):
(WebCore::MediaPlayerPrivate::setCertificatePath):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
(WebCore::MediaPlayerPrivate::movieLoadType):
(WebCore::MediaPlayerPrivate::userAgent):
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
(WebCore::MediaPlayerPrivate::setFullscreenWebPageClient):
(WebCore::MediaPlayerPrivate::getWindow):
(WebCore::MediaPlayerPrivate::getPeerWindow):
(WebCore::MediaPlayerPrivate::getWindowPosition):
(WebCore::MediaPlayerPrivate::mmrContextName):
(WebCore::MediaPlayerPrivate::percentLoaded):
(WebCore::MediaPlayerPrivate::sourceWidth):
(WebCore::MediaPlayerPrivate::sourceHeight):
(WebCore::MediaPlayerPrivate::setAllowPPSVolumeUpdates):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::onStateChanged):
(WebCore::MediaPlayerPrivate::onMediaStatusChanged):
(WebCore::MediaPlayerPrivate::onError):
(WebCore::MediaPlayerPrivate::onDurationChanged):
(WebCore::MediaPlayerPrivate::onTimeChanged):
(WebCore::MediaPlayerPrivate::onPauseStateChanged):
(WebCore::MediaPlayerPrivate::onRateChanged):
(WebCore::MediaPlayerPrivate::onVolumeChanged):
(WebCore::MediaPlayerPrivate::onRepaint):
(WebCore::MediaPlayerPrivate::onSizeChanged):
(WebCore::MediaPlayerPrivate::onPlayNotified):
(WebCore::MediaPlayerPrivate::onPauseNotified):
(WebCore::MediaPlayerPrivate::onBuffering):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::frameView):
(WebCore::MediaPlayerPrivate::platformWindow):
(WebCore::MediaPlayerPrivate::isFullscreen):
(WebCore::MediaPlayerPrivate::platformMedia):
(WebCore::MediaPlayerPrivate::platformLayer):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::bufferingTimerFired):
(WebCore::MediaPlayerPrivate::setBuffering):
(WebCore::allocateTextureId):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h: Added.
(WebKit):
(WebCore):
(MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSPARC also needs aligned accesses.
kov@webkit.org [Sun, 4 Mar 2012 15:42:54 +0000 (15:42 +0000)]
SPARC also needs aligned accesses.

Patch by Jurij Smakov <jurij@wooyd.org> on 2012-03-04
Rubber-stamped by Gustavo Noronha Silva.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
barraclough@apple.com [Sun, 4 Mar 2012 09:04:00 +0000 (09:04 +0000)]
Unreviewed build fix.

* jit/JITStubs.h:
    - Move ENABLE(JIT) to head of file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit JSArray's [[Put]] & [[DefineOwnProperty]] traps.
barraclough@apple.com [Sun, 4 Mar 2012 05:56:24 +0000 (05:56 +0000)]
Split JSArray's [[Put]] & [[DefineOwnProperty]] traps.
https://bugs.webkit.org/show_bug.cgi?id=80217

Reviewed by Filip Pizlo.

putByIndex() provides similar behavior to put(), but for indexed property names.
Many places in ArrayPrototype call putByIndex() where they really mean to call
[[DefineOwnProperty]]. This is only okay due to a bug – putByIndex should be
calling numeric accessors (& respecting numeric read only properties) on the
prototype chain, but isn't. Add a new putDirectIndex (matching JSObject's
putDirect* methods), to correctly provide a fast [[DefineOwnProperty]] interface.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
* runtime/JSArray.cpp:
(JSC):
(JSC::reject):
(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
* runtime/JSArray.h:
(SparseArrayValueMap):
(JSArray):
(JSC::JSArray::putDirectIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the unused function WebCore::protocolIsInHTTPFamily()
benjamin@webkit.org [Sun, 4 Mar 2012 05:04:16 +0000 (05:04 +0000)]
Remove the unused function WebCore::protocolIsInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80218

Reviewed by Anders Carlsson.

* WebCore.order:
* platform/KURL.cpp:
* platform/KURL.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement the basis of KURLWTFURL
benjamin@webkit.org [Sun, 4 Mar 2012 03:49:19 +0000 (03:49 +0000)]
Implement the basis of KURLWTFURL
https://bugs.webkit.org/show_bug.cgi?id=79600

Reviewed by Adam Barth.

Source/JavaScriptCore:

Add an API to know if a ParsedURL is valid.

* wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::ParsedURL):
(WTF):
(WTF::ParsedURL::isolatedCopy): This is needed by APIs moving URL objects between thread
and by KURL's detach() on write.
(WTF::ParsedURL::baseAsString):
(WTF::ParsedURL::segment):
Add a stronger constraint on accessors: the client of this API should never ask for the segments
on an invalid URL.
* wtf/url/api/ParsedURL.h:
(WTF):
(WTF::ParsedURL::ParsedURL):
(ParsedURL):
(WTF::ParsedURL::isValid):

Source/WebCore:

Add a simple, non-optimized, implementation for the main methods of KURL based
on ParsedURL.

* platform/KURLWTFURL.cpp:
(WebCore):
(WebCore::detach):
(WebCore::KURL::KURL):
(WebCore::KURL::copy):
(WebCore::KURL::isEmpty):
(WebCore::KURL::isValid):
(WebCore::KURL::string):
(WebCore::KURL::protocol):
(WebCore::KURL::host):
(WebCore::KURL::hasPort):
(WebCore::KURL::port):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::lastPathComponent):
(WebCore::KURL::query):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::baseAsString):
(WebCore::KURL::fileSystemPath):
(WebCore::KURL::protocolIs):
(WebCore::KURL::protocolIsInHTTPFamily):
(WebCore::KURL::setProtocol):
(WebCore::KURL::setHost):
(WebCore::KURL::removePort):
(WebCore::KURL::setPort):
(WebCore::KURL::setHostAndPort):
(WebCore::KURL::setUser):
(WebCore::KURL::setPass):
(WebCore::KURL::setPath):
(WebCore::KURL::setQuery):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::protocolHostAndPortAreEqual):
* platform/KURLWTFURLImpl.h:
(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::copy):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the redundant method KURL::protocolInHTTPFamily()
benjamin@webkit.org [Sun, 4 Mar 2012 03:26:27 +0000 (03:26 +0000)]
Remove the redundant method KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80216

Reviewed by Anders Carlsson.

Source/WebCore:

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::addExtraFieldsToRequest):
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::hostForURL):
(WebCore::ResourceLoadScheduler::scheduleLoad):
* loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
* loader/icon/IconController.cpp:
(WebCore::IconController::defaultURL):
* platform/KURL.h:
(KURL):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
* platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::set):
(WebCore::findDefaultProtectionSpaceForURL):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):
(WebCore::ResourceRequestBase::addHTTPHeaderField):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):
* src/WebPageSerializer.cpp:
(WebCore::retrieveResourcesForElement):

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
* WebHistory.cpp:
(WebHistory::visitedURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix static_libs_as_shared build
commit-queue@webkit.org [Sun, 4 Mar 2012 03:08:45 +0000 (03:08 +0000)]
[Qt] Fix static_libs_as_shared build
https://bugs.webkit.org/show_bug.cgi?id=80214

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-03
Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

Add helper function to be called by WebProcess main
to potentially initialize the QStyle theme.

* WebCoreSupport/InitWebCoreQt.cpp:
(WebKit):
(WebKit::initializeWebKit2Theme):

Source/WebKit2:

Replace (static) link time dependency to WK1 with entrypoint
in the separate WebProcess for activating the QStyle theme if
necessary.

* Target.pri:
* UIProcess/Launcher/ProcessLauncher.h:
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
* qt/MainQt.cpp:
(WebKit):
(main):

Tools:

* WebKitTestRunner/qt/main.cpp:
(main): Set the correct environment variable for choosing the theme in the
web process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream LayerWebKitThread and its derived classes
commit-queue@webkit.org [Sun, 4 Mar 2012 03:04:59 +0000 (03:04 +0000)]
[BlackBerry] Upstream LayerWebKitThread and its derived classes
https://bugs.webkit.org/show_bug.cgi?id=79871

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-03
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setCanvas):
(WebCore::CanvasLayerWebKitThread::setNeedsDisplay):
(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/CanvasLayerWebKitThread.h: Added.
(WebCore):
(CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::create):
* platform/graphics/blackberry/LayerData.h: Added.
(WebCore):
(LayerData):
(WebCore::LayerData::LayerData):
(WebCore::LayerData::~LayerData):
(WebCore::LayerData::anchorPoint):
(WebCore::LayerData::anchorPointZ):
(WebCore::LayerData::backgroundColor):
(WebCore::LayerData::borderColor):
(WebCore::LayerData::borderWidth):
(WebCore::LayerData::bounds):
(WebCore::LayerData::doubleSided):
(WebCore::LayerData::frame):
(WebCore::LayerData::masksToBounds):
(WebCore::LayerData::opacity):
(WebCore::LayerData::opaque):
(WebCore::LayerData::position):
(WebCore::LayerData::sublayerTransform):
(WebCore::LayerData::transform):
(WebCore::LayerData::preserves3D):
(WebCore::LayerData::getTextureID):
(WebCore::LayerData::setTextureID):
(WebCore::LayerData::needsTexture):
(WebCore::LayerData::layerProgramShader):
(WebCore::LayerData::isFixedPosition):
(WebCore::LayerData::hasFixedContainer):
(WebCore::LayerData::hasFixedAncestorInDOMTree):
(WebCore::LayerData::pluginView):
(WebCore::LayerData::holePunchRect):
(WebCore::LayerData::hasHolePunchRect):
(WebCore::LayerData::mediaPlayer):
(WebCore::LayerData::canvas):
(WebCore::LayerData::replicate):
(WebCore::LayerData::layerType):
(WebCore::LayerData::includeVisibility):
* platform/graphics/blackberry/LayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::LayerWebKitThread::create):
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::contentsVisible):
(WebCore::LayerWebKitThread::createFrontBufferLock):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setDrawable):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore::LayerWebKitThread::insertSublayer):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayer):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::indexOfSublayer):
(WebCore::LayerWebKitThread::setBounds):
(WebCore::LayerWebKitThread::setFrame):
(WebCore::LayerWebKitThread::rootLayer):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::setNeedsDisplayInRect):
(WebCore::LayerWebKitThread::setNeedsDisplay):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):
* platform/graphics/blackberry/LayerWebKitThread.h: Added.
(WebCore):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::setAnchorPoint):
(WebCore::LayerWebKitThread::setAnchorPointZ):
(WebCore::LayerWebKitThread::setBackgroundColor):
(WebCore::LayerWebKitThread::setBorderColor):
(WebCore::LayerWebKitThread::setBorderWidth):
(WebCore::LayerWebKitThread::setDoubleSided):
(WebCore::LayerWebKitThread::setMasksToBounds):
(WebCore::LayerWebKitThread::setMaskLayer):
(WebCore::LayerWebKitThread::maskLayer):
(WebCore::LayerWebKitThread::setReplicaLayer):
(WebCore::LayerWebKitThread::replicaLayer):
(WebCore::LayerWebKitThread::setNeedsDisplayOnBoundsChange):
(WebCore::LayerWebKitThread::setOpacity):
(WebCore::LayerWebKitThread::setOpaque):
(WebCore::LayerWebKitThread::setPosition):
(WebCore::LayerWebKitThread::getSublayers):
(WebCore::LayerWebKitThread::setSublayerTransform):
(WebCore::LayerWebKitThread::superlayer):
(WebCore::LayerWebKitThread::setTransform):
(WebCore::LayerWebKitThread::setPreserves3D):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setHasFixedContainer):
(WebCore::LayerWebKitThread::setHasFixedAncestorInDOMTree):
(WebCore::LayerWebKitThread::contents):
(WebCore::LayerWebKitThread::setOwner):
(WebCore::LayerWebKitThread::drawsContent):
(WebCore::LayerWebKitThread::layerCompositingThread):
(WebCore::LayerWebKitThread::setAbsoluteOffset):
(WebCore::LayerWebKitThread::contentsScale):
(WebCore::LayerWebKitThread::setRunningAnimations):
(WebCore::LayerWebKitThread::setSuspendedAnimations):
(WebCore::LayerWebKitThread::setNeedsTexture):
(WebCore::LayerWebKitThread::setLayerProgramShader):
(WebCore::LayerWebKitThread::isDrawable):
(WebCore::LayerWebKitThread::boundsChanged):
(WebCore::LayerWebKitThread::setSuperlayer):
(WebCore::LayerWebKitThread::numSublayers):
* platform/graphics/blackberry/PluginLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::PluginLayerWebKitThread::PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::~PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::setPluginView):
(WebCore::PluginLayerWebKitThread::setHolePunchRect):
(WebCore::PluginLayerWebKitThread::setNeedsDisplay):
(WebCore::PluginLayerWebKitThread::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/PluginLayerWebKitThread.h: Added.
(WebCore):
(PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::create):
* platform/graphics/blackberry/VideoLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::VideoLayerWebKitThread::VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::~VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::setMediaPlayer):
(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::setNeedsDisplay):
(WebCore::VideoLayerWebKitThread::boundsChanged):
(WebCore::VideoLayerWebKitThread::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/VideoLayerWebKitThread.h: Added.
(WebCore):
(VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Speech JavaScript API
hans@chromium.org [Sun, 4 Mar 2012 01:06:09 +0000 (01:06 +0000)]
Implement Speech JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=80019

Reviewed by Adam Barth.

.:

Add ENABLE_SCRIPTED_SPEECH.

* configure.ac:

Source/JavaScriptCore:

Add ENABLE_SCRIPTED_SPEECH.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add ENABLE_SCRIPTED_SPEECH and runtime flag.

No functionality yet, so no new tests.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* Target.pri:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):

Source/WebKit/chromium:

Add ENABLE_SCRIPTED_SPEECH and runtime flag.

* features.gypi:
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableScriptedSpeech):
(WebKit):
(WebKit::WebRuntimeFeatures::isScriptedSpeechEnabled):

Source/WebKit/mac:

Add ENABLE_SCRIPTED_SPEECH.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add ENABLE_SCRIPTED_SPEECH.

* Configurations/FeatureDefines.xcconfig:

Tools:

Add ENABLE_SCRIPTED_SPEECH.

* Scripts/build-webkit:
* qmake/mkspecs/features/features.prf:

WebKitLibraries:

Add ENABLE_SCRIPTED_SPEECH.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDelayNode has a fixed one second max delay time
commit-queue@webkit.org [Sat, 3 Mar 2012 22:48:55 +0000 (22:48 +0000)]
DelayNode has a fixed one second max delay time
https://bugs.webkit.org/show_bug.cgi?id=78758

Source/WebCore:

Change DelayNode to accept an optional parameter to specify the
maximum delay allowed. If not specified, the default is 1 sec.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.

Test: webaudio/delaynode-maxdelay.html
      webaudio/delaynode-maxdelay-expected.txt

* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createDelayNode): Allow maxDelayTime
parameter to specify max delay.
* webaudio/AudioContext.h: Allow maxDelayTime
parameter to specify max delay but default to 1.
(AudioContext):
* webaudio/AudioContext.idl: createDelayNode takes optional max
delay time parameter.
* webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel): Remove unused
DefaultMaxDelayTime. Set m_maxDelayTime from processor
maxDelayTime.
* webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode): Add maxDelayTime parameter.
* webaudio/DelayNode.h:
(WebCore::DelayNode::create): Add maxDelayTime parameter.
(DelayNode): Add maxDelayTime parameter.
* webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor): Add maxDelayTime
parameter.
* webaudio/DelayProcessor.h:
(DelayProcessor): Add maxDelayTime parameter.
(WebCore::DelayProcessor::maxDelayTime): New slot to hold
maxDelayTime.

LayoutTests:

Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.

* webaudio/resources/delay-testing.js: Added more informative
messages.
* webaudio/delaynode-expected.txt: Updated result for more
informative messages
* webaudio/delaynode-scheduling-expected.txt: Updated result for
more informative messages.
* webaudio/delaynode-maxdelay-expected.txt: Added
* webaudio/delaynode-maxdelay.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplified discreteTimeConstantForSampleRate
commit-queue@webkit.org [Sat, 3 Mar 2012 22:30:23 +0000 (22:30 +0000)]
Simplified discreteTimeConstantForSampleRate
https://bugs.webkit.org/show_bug.cgi?id=78051

Remove hardcoded constant and simplify computation of discrete
time constant.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.

No new tests needed.  Covered by existing AudioParam tests.

* platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
Simplify formula.
* platform/audio/AudioUtilities.h:
(AudioUtilities): Update function signature.
* platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
cast to float to avoid warnings.
* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): cast to
float to avoid warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
noam.rosenthal@nokia.com [Sat, 3 Mar 2012 19:26:39 +0000 (19:26 +0000)]
[Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
https://bugs.webkit.org/show_bug.cgi?id=79543

Use QSGNode::inheritedOpacity() and QSGNode::matrix().
Also, remove flags from changedStates() that we don't actually touch.
This is covered by existing API tests.

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::changedStates):
(PageProxyNode::render):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build with newer versions of clang.
andersca@apple.com [Sat, 3 Mar 2012 19:13:56 +0000 (19:13 +0000)]
Fix build with newer versions of clang.

Source/WebCore:

* bindings/objc/DOM.mm:
(-[DOMNode description]):
Remove an unused parameter.

* bridge/objc/objc_instance.mm:
(ObjcInstance::getClass):
Use object_getClass instead of accessing isa directly.

* platform/LocalizedStrings.cpp:
(WebCore::formatLocalizedString):
Disable the -Wformat-nonliteral warning around the call to CFStringCreateWithFormatAndArguments.

* platform/graphics/mac/WebLayer.mm:
(-[CALayer _descriptionWithPrefix:]):
Use %p for the CALayer pointer, and use %lu for the number of sublayers.

* platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
Cast the NSAttachmentCharacte enum to unichar.

Source/WebKit/mac:

* Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
Use %ld and cast to long.

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:value:]):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.

Source/WebKit2:

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBiquad getFrequencyResponse needs a layout test.
commit-queue@webkit.org [Sat, 3 Mar 2012 18:55:49 +0000 (18:55 +0000)]
Biquad getFrequencyResponse needs a layout test.
https://bugs.webkit.org/show_bug.cgi?id=79503

Add simple test for getFrequencyResponse.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.

* webaudio/biquad-getFrequencyResponse-expected.txt: Added.
* webaudio/biquad-getFrequencyResponse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixes AssociatedURLLoader support for Access-Control-Expose-Headers field in response.
bbudge@chromium.org [Sat, 3 Mar 2012 18:49:50 +0000 (18:49 +0000)]
Fixes AssociatedURLLoader support for Access-Control-Expose-Headers field in response.
https://bugs.webkit.org/show_bug.cgi?id=80198

Reviewed by Adam Barth.

* src/AssociatedURLLoader.cpp:
* tests/AssociatedURLLoaderTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r109343.
commit-queue@webkit.org [Sat, 3 Mar 2012 12:34:40 +0000 (12:34 +0000)]
Unreviewed, rolling out r109343.
http://trac.webkit.org/changeset/109343
https://bugs.webkit.org/show_bug.cgi?id=80212

Int32array can't handle values for native nodes because they
have int64 ids (Requested by loislo1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-03

Source/WebCore:

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):

LayoutTests:

* inspector/profiler/heap-snapshot-loader.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK tests_expectations update.
philn@webkit.org [Sat, 3 Mar 2012 09:16:57 +0000 (09:16 +0000)]
Unreviewed, GTK tests_expectations update.

* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFree up a bit in RenderObject.
commit-queue@webkit.org [Sat, 3 Mar 2012 09:12:21 +0000 (09:12 +0000)]
Free up a bit in RenderObject.
http://webkit.org/b/80208

Patch by Andreas Kling <awesomekling@apple.com> on 2012-03-03
Reviewed by Anders Carlsson.

Move m_hasMarkupTruncation to RenderBlock, stealing one bit from m_lineHeight.
This flag is only used by RenderBlock.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::setHasMarkupTruncation):
(WebCore::RenderBlock::hasMarkupTruncation):
(RenderBlock):
* rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline after r109623.
philn@webkit.org [Sat, 3 Mar 2012 09:09:54 +0000 (09:09 +0000)]
Unreviewed, rebaseline after r109623.

* editing/selection/select-line-break-with-opposite-directionality-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement vw/vh/vmin (viewport sizes) from CSS 3 Values and Units
commit-queue@webkit.org [Sat, 3 Mar 2012 08:35:36 +0000 (08:35 +0000)]
Implement vw/vh/vmin (viewport sizes) from CSS 3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160

The specification related to this implementation is located at http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.
vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units and creation of primitive values.

Added new Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin for viewport-relative lengths
and included the support for fetching the value of these relative length units based on the current viewport size.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-03
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
       css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html

* css/CSSComputedStyleDeclaration.cpp: Modified to support viewport relative Length types.
(WebCore::getPositionOffsetValue): Ditto.
(WebCore::getBorderRadiusCornerValues): Ditto.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::getBorderRadiusShorthandValue): Ditto.
(WebCore::lineHeightFromStyle): Ditto.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
* css/CSSGrammar.y: Added vw/vh/vmin support.
* css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.
(WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
(WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
(WebCore::CSSPrimitiveValue::customCssText): Ditto.
(WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
(WebCore):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
(CSSPrimitiveValue):
* css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue): Applying relative viewport length units to the specific CSS property.
(WebCore::ApplyPropertyBorderRadius::applyValue): Ditto.
(WebCore::ApplyPropertyFontSize::applyValue): Ditto.
(WebCore::ApplyPropertyLineHeight::applyValue): Ditto.
(WebCore::ApplyPropertyVerticalAlign::applyValue): Ditto.
* css/CSSStyleSelector.cpp:
(WebCore::convertToLength): Added support for viewport relative units.
(WebCore::createGridTrackBreadth): Ditto.
(WebCore::CSSStyleSelector::mapFillSize): Ditto.
(WebCore::CSSStyleSelector::mapFillXPosition): Ditto.
(WebCore::CSSStyleSelector::mapFillYPosition): Ditto.
* dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
(WebCore::Document::viewportSize): New function to fetch the current viewport size.
(WebCore):
* dom/Document.h: Ditto.
(Document):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion): Modified to support viewport relative Length types.
* platform/Length.h: New LengthTypes such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin added.
(WebCore::Length::calcValue): Modified to support viewport relative Length types.
(WebCore::Length::calcMinValue): Ditto.
(WebCore::Length::calcFloatValue): Ditto.
(Length):
(WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
(WebCore::Length::viewportRelativeLength): To get the relative value.
* rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight): Modified to support viewport relative Length types.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight): Ditto.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectionOffset): Ditto.
(WebCore::RenderBox::paintBoxDecorations): Ditto.
(WebCore::RenderBox::clipRect): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegion): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Ditto.
(WebCore::RenderBox::computeInlineDirectionMargins): Ditto.
(WebCore::RenderBox::computeLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePercentageLogicalHeight): Ditto.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computeBlockDirectionMargins): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Ditto.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX): Ditto.
(WebCore::RenderBoxModelObject::relativePositionOffsetY): Ditto.
(WebCore::RenderBoxModelObject::paddingTop): Ditto.
(WebCore::RenderBoxModelObject::paddingBottom): Ditto.
(WebCore::RenderBoxModelObject::paddingLeft): Ditto.
(WebCore::RenderBoxModelObject::paddingRight): Ditto.
(WebCore::RenderBoxModelObject::paddingBefore): Ditto.
(WebCore::RenderBoxModelObject::paddingAfter): Ditto.
(WebCore::RenderBoxModelObject::paddingStart): Ditto.
(WebCore::RenderBoxModelObject::paddingEnd): Ditto.
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect): Ditto.
(WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Ditto.
(WebCore::computeBorderImageSide): Ditto.
(WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Ditto.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Ditto.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Ditto.
* rendering/RenderInline.cpp:
(WebCore::computeMargin): Ditto.
(WebCore::RenderInline::lineHeight): Ditto.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Ditto.
* rendering/RenderObject.h:
(WebCore::RenderObject::viewportSize): New function to fetch the current viewport size.
(RenderObject):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint): Modified to support viewport relative Length types.
* rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarWidth): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarHeight): Ditto.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Ditto.
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalHeightForRowSizing): Ditto.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Ditto.
* rendering/RenderText.h:
(WebCore::RenderText::marginLeft): Ditto.
(WebCore::RenderText::marginRight): Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients): Ditto.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint): Ditto.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox): Ditto.
* rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor): Ditto.
(WebCore::RenderStyle::getRoundedBorderFor): Ditto.
* rendering/style/RenderStyle.h: Ditto.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::resolveLengthAttributeForSVG): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.

LayoutTests:

* css3/viewport-relative-lengths: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
* fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip a new crashing test.
ossy@webkit.org [Sat, 3 Mar 2012 07:43:53 +0000 (07:43 +0000)]
[Qt] Unreviewed gardening, skip a new crashing test.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, updated expected files.
ossy@webkit.org [Sat, 3 Mar 2012 07:34:34 +0000 (07:34 +0000)]
[Qt] Unreviewed gardening, updated expected files.

* platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.png: Added.
* platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
* platform/qt/fast/dom/prototype-inheritance-2-expected.png:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEditor's default paragraph separator is not reset when a frame's document is changed
commit-queue@webkit.org [Sat, 3 Mar 2012 05:48:54 +0000 (05:48 +0000)]
Editor's default paragraph separator is not reset when a frame's document is changed
https://bugs.webkit.org/show_bug.cgi?id=80065

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/execCommand/reset-values-after-navigation.html

* editing/Editor.cpp:
(WebCore::Editor::clear):

LayoutTests:

* editing/execCommand/default-paragraph-separator.html: Last line of the test did a manual reset of the value to work around this problem. Removed.
* editing/execCommand/reset-values-after-navigation-expected.txt: Added.
* editing/execCommand/reset-values-after-navigation.html: Added.
* editing/execCommand/resources/reset-default-values-helper-1.html: Added.
* editing/execCommand/resources/reset-default-values-helper-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHave a copy of plug-in sandboxing API header in WebCore
ap@apple.com [Sat, 3 Mar 2012 05:31:13 +0000 (05:31 +0000)]
Have a copy of plug-in sandboxing API header in WebCore
https://bugs.webkit.org/show_bug.cgi?id=80185
<rdar://problem/8242128>

Reviewed by Anders Carlsson.

* plugins/npapi-sandbox.h: Added.

* WebCore.xcodeproj/project.pbxproj: Added as unused file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago:empty should apply to elements made empty via page dynamics
noel.gordon@gmail.com [Sat, 3 Mar 2012 03:28:41 +0000 (03:28 +0000)]
:empty should apply to elements made empty via page dynamics
https://bugs.webkit.org/show_bug.cgi?id=79734

Reviewed by Antonio Gomes.

* fast/css/pseudo-empty-dynamic-empty-expected.txt: Added.
* fast/css/pseudo-empty-dynamic-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Fix commit queue, remove duplicate entry.
ap@apple.com [Sat, 3 Mar 2012 03:18:34 +0000 (03:18 +0000)]
    Fix commit queue, remove duplicate entry.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Expose WebInspector state to client and clean up WebSettings
commit-queue@webkit.org [Sat, 3 Mar 2012 02:41:36 +0000 (02:41 +0000)]
[BlackBerry] Expose WebInspector state to client and clean up WebSettings
https://bugs.webkit.org/show_bug.cgi?id=80177

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.

Expose the Web Inspector state to WebPage client's and
re-order initialization of WebSettings to be alphabetical
matching their definitions.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled):
* Api/WebPage.h:
* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, add myself as a committer * Scripts/webkitpy/common/config/committers.py:
schenney@chromium.org [Sat, 3 Mar 2012 02:35:53 +0000 (02:35 +0000)]
Unreviewed, add myself as a committer * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoES5.1-15.3.5.4. prohibits Function.caller from [[Get]]ting a strict caller
barraclough@apple.com [Sat, 3 Mar 2012 01:52:17 +0000 (01:52 +0000)]
ES5.1-15.3.5.4. prohibits Function.caller from [[Get]]ting a strict caller
https://bugs.webkit.org/show_bug.cgi?id=80011

We now support getting the caller from within an accessor.

Reviewed by Sam Weinig.

* fast/js/function-dot-arguments-and-caller.html:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChrome 18 fails html5test.com XHR Blob response test
eric@webkit.org [Sat, 3 Mar 2012 01:48:49 +0000 (01:48 +0000)]
Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760

Unreviewed rebaselining.  Cr-Linux returns
application/javascript for .js files instead of text/javascript.

* platform/chromium-linux/fast/files/xhr-response-blob-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert borders to integers for subpixel layout
eae@chromium.org [Sat, 3 Mar 2012 01:47:46 +0000 (01:47 +0000)]
Revert borders to integers for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=80175

Reviewed by Eric Seidel.

Change border representation and calculation back to integers to ensure
that borders given the same width are rendered with the same actual width.

This will also avoid unnecessary type conversions when we switch over
to subpixel precision.

No new tests.

* rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect):
(WebCore):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderTop):
(WebCore::RenderBoxModelObject::borderBottom):
(WebCore::RenderBoxModelObject::borderLeft):
(WebCore::RenderBoxModelObject::borderRight):
(WebCore::RenderBoxModelObject::borderBefore):
(WebCore::RenderBoxModelObject::borderAfter):
(WebCore::RenderBoxModelObject::borderStart):
(WebCore::RenderBoxModelObject::borderEnd):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::borderBefore):
(WebCore::RenderTable::borderAfter):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
* rendering/RenderTable.h:
(WebCore::RenderTable::borderStart):
(WebCore::RenderTable::borderEnd):
(RenderTable):
(WebCore::RenderTable::borderLeft):
(WebCore::RenderTable::borderRight):
(WebCore::RenderTable::borderTop):
(WebCore::RenderTable::borderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::RenderTableCell::paintCollapsedBorders):
* rendering/RenderTableCell.h:
(RenderTableCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, remove an erroneous expected result that showed up in r109303.
michaeln@google.com [Sat, 3 Mar 2012 01:32:05 +0000 (01:32 +0000)]
Unreviewed, remove an erroneous expected result that showed up in r109303.

* platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark a few tests as flaky on Leopard debug.
adamk@chromium.org [Sat, 3 Mar 2012 01:24:24 +0000 (01:24 +0000)]
Mark a few tests as flaky on Leopard debug.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAccelerated compositing: Checkerboard never goes away
commit-queue@webkit.org [Sat, 3 Mar 2012 01:22:24 +0000 (01:22 +0000)]
Accelerated compositing: Checkerboard never goes away
https://bugs.webkit.org/show_bug.cgi?id=79020
RIM PR #134164

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-02
Reviewed by Adam Treat.

Checkerboard appears in accelerated compositing layers when there's no
texture for (part of) a layer. The layer renderer queues up some render
jobs and schedules a commit to make the WebKit thread process those
jobs. Render jobs performed during commit cause texture upload jobs to
be scheduled on the UI thread. Texture uploads are performed when next
drawing the layers.

Unfortunately, sometimes commit operation happens without a subsequent
call draw the layers.

In order to implement one-shot drawing sync, I added a call to
commitRootLayerIfNeeded() in BackingStore::renderContents(), and
I was lucky that most of the time, renderContents() is followed by
blit(Visible)Contents() which in turn draws the layers.
However, render is not always followed by a blit, for example when
rendering offscreen tiles in BackingStore::renderOnIdle(), and in
direct rendering mode.

Fixed by making sure that every call to commitRootLayerIfNeeded() that
returns true is followed by a call to drawLayersOnCommit(), unless a
blit was requested already.

Also tweak the logic for one-shot drawing sync to make the code in
drawLayersOnCommit() reusable outside of rootLayerCommitTimerFired().

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderOnTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderOnIdle):
(BlackBerry::WebKit::BackingStorePrivate::willFireTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
* Api/BackingStore_p.h:
(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::willDrawLayersOnCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother test fix after r109593. Remove the extra start body tag.
rniwa@webkit.org [Sat, 3 Mar 2012 01:03:33 +0000 (01:03 +0000)]
Another test fix after r109593. Remove the extra start body tag.

* editing/selection/select-line-break-with-opposite-directionality.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline for Leopard.
adamk@chromium.org [Sat, 3 Mar 2012 00:59:28 +0000 (00:59 +0000)]
Unreviewed rebaseline for Leopard.

* platform/chromium-mac-leopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChrome 18 fails html5test.com XHR Blob response test
eric@webkit.org [Sat, 3 Mar 2012 00:57:10 +0000 (00:57 +0000)]
Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760

Reviewed by Adam Barth.

Source/WebCore:

Most of the code was already there, this just fixes the FIXME
which was causing this feature not to work.  Chromium already
had this #ifdef enabled, but other ports (at least Mac) do not.

Test: fast/files/xhr-response-blob.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):

LayoutTests:

* fast/files/script-tests/xhr-response-blob.js: Added.
(xhr.onreadystatechange):
* fast/files/xhr-response-blob-expected.txt: Added.
* fast/files/xhr-response-blob.html: Added.
* platform/chromium/fast/files/xhr-response-blob-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl
haraken@chromium.org [Sat, 3 Mar 2012 00:50:55 +0000 (00:50 +0000)]
Revert Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80151

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl.

No tests. No change in behavior.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* page/DOMWindow.idl:
* workers/DOMWindowWorker.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove nsStringFromWebCoreString out of PageClientImpl
aestes@apple.com [Sat, 3 Mar 2012 00:39:06 +0000 (00:39 +0000)]
Move nsStringFromWebCoreString out of PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=80202

Reviewed by Sam Weinig.

nsStringFromWebCoreString() doesn't really belong in PageClientImpl.mm,
and it makes us include PageClientImpl.h in places where we shouldn't.
Move this function into StringUtilities.{h, mm}.

* Platform/mac/StringUtilities.h: Added.
* Platform/mac/StringUtilities.mm: Added.
(WebKit::nsStringFromWebCoreString):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/mac/WKView.mm:
* UIProcess/mac/WebContextMenuProxyMac.mm:
* UIProcess/mac/WebPageProxyMac.mm:
* UIProcess/mac/WebPopupMenuProxyMac.mm:
* UIProcess/mac/WebPreferencesMac.mm:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test expectations cleanup.
adamk@chromium.org [Sat, 3 Mar 2012 00:29:41 +0000 (00:29 +0000)]
Unreviewed test expectations cleanup.
Marked a bunch of flakiness as happening only in DEBUG,
and removed a whole set of tests that are no longer flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline of SVG feImage tests after r105612 and r106113.
adamk@chromium.org [Sat, 3 Mar 2012 00:19:51 +0000 (00:19 +0000)]
Unreviewed rebaseline of SVG feImage tests after r105612 and r106113.

* platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
* platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
* platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
* platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
* platform/chromium-mac-leopard/svg/filters/feImage-subregions-expected.png: Added.
* platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
* platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-position-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-id-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-position-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-subregions-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-add-to-document-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-changes-id-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-id-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-remove-from-document-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl
haraken@chromium.org [Sat, 3 Mar 2012 00:15:51 +0000 (00:15 +0000)]
Revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80140

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
we should revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl.

No tests. No change in behavior.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/DOMWindowHTML.idl: Removed.
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline some SVG tests after r105612.
adamk@chromium.org [Sat, 3 Mar 2012 00:08:27 +0000 (00:08 +0000)]
Unreviewed, rebaseline some SVG tests after r105612.

* platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* platform/chromium-linux/svg/filters/feImage-reference-svg-primitive-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* platform/chromium-win/svg/filters/feImage-reference-invalidation-expected.png:
* platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl
haraken@chromium.org [Fri, 2 Mar 2012 23:59:12 +0000 (23:59 +0000)]
Revert XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80148

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl.

No tests. No change in behavior.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.idl:
* xml/DOMWindowXML.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen getting the line number of a call into a call frame with no code block, it's
fpizlo@apple.com [Fri, 2 Mar 2012 23:57:31 +0000 (23:57 +0000)]
When getting the line number of a call into a call frame with no code block, it's
incorrect to rely on the returnPC
https://bugs.webkit.org/show_bug.cgi?id=80195

Reviewed by Oliver Hunt.

* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, widen flaky crash expectations for FileWriter test.
adamk@chromium.org [Fri, 2 Mar 2012 23:49:11 +0000 (23:49 +0000)]
Unreviewed gardening, widen flaky crash expectations for FileWriter test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaselining, update a bunch of old results for Snow Leopard.
adamk@chromium.org [Fri, 2 Mar 2012 23:42:44 +0000 (23:42 +0000)]
Unreviewed rebaselining, update a bunch of old results for Snow Leopard.

* platform/chromium-linux/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
* platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.txt: Added.
* platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt.
* platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
* platform/chromium-mac-snowleopard/fonts/monospace-expected.png: Added.
* platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.png: Added.
* platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test fix. Don't add an event listener for interactive debugging
rniwa@webkit.org [Fri, 2 Mar 2012 23:34:36 +0000 (23:34 +0000)]
Unreviewed test fix. Don't add an event listener for interactive debugging
when  the test is ran inside a DumpRenderTree / WebKitTestRunner.

* editing/selection/select-line-break-with-opposite-directionality.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a ChangeLog typo.
aestes@apple.com [Fri, 2 Mar 2012 23:24:17 +0000 (23:24 +0000)]
Fix a ChangeLog typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove com.apple.WebKit.PluginProcess.sb from WebKit2.xcodeproj's Headers build phase
aestes@apple.com [Fri, 2 Mar 2012 23:23:28 +0000 (23:23 +0000)]
Remove com.apple.WebKit.PluginProcess.sb from WebKit2.xcodeproj's Headers build phase
https://bugs.webkit.org/show_bug.cgi?id=80197

Reviewed by Alexey Proskuryakov.

It doesn't belong there, and it makes the Xcode consider the project to
be invalid, triggering assertions in some builds of Xcode.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake webkit-gtk translations respect LINGUAS
commit-queue@webkit.org [Fri, 2 Mar 2012 23:10:32 +0000 (23:10 +0000)]
Make webkit-gtk translations respect LINGUAS
https://bugs.webkit.org/show_bug.cgi?id=79605

Patch by Alexandre Rostovtsev <tetromino@gentoo.org> on 2012-03-02
Reviewed by Martin Robinson.

.:

PO_LINGUAS, USER_LINGUAS, and USE_LINGUAS added to root
GNUmakefile.am to ensure that they can be used in the definition of
MOFILES that will be generated by automake.

* GNUmakefile.am:

Source/WebKit/gtk/po:

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instea...
caio.oliveira@openbossa.org [Fri, 2 Mar 2012 22:48:03 +0000 (22:48 +0000)]
Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
https://bugs.webkit.org/show_bug.cgi?id=80188

Reviewed by Ryosuke Niwa.

Using setNamedItem() in setAttributeNode() implementation made us do unnecessary
checks like whether the element existed or whether the given node was an
attribute. So now setAttributeNode() do less work.

No new tests were added, functionality should be unchanged.

* dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):
* dom/Element.h:
(Element):
(WebCore::Element::attributes): We got rid of ensureUpdatedAttributes(), next in
line will be updatedAttributes().
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpected results updated for checking type conversion
commit-queue@webkit.org [Fri, 2 Mar 2012 22:44:46 +0000 (22:44 +0000)]
Expected results updated for checking type conversion
https://bugs.webkit.org/show_bug.cgi?id=80138

Patch by Han Hojong <hojong.han@samsung.com> on 2012-03-02
Reviewed by Gavin Barraclough.

* tests/mozilla/ecma/TypeConversion/9.3.1-3.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r109602.
commit-queue@webkit.org [Fri, 2 Mar 2012 22:41:35 +0000 (22:41 +0000)]
Unreviewed, rolling out r109602.
http://trac.webkit.org/changeset/109602
https://bugs.webkit.org/show_bug.cgi?id=80194

some TEXT baselines were wrong and some baselines were wrongly
removed (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-02

* platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
* platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
* platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Removed.
* platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
* platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
* platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
* platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Removed.
* platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Removed.
* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
* platform/chromium-mac/fast/clip/008-expected.png: Added.
* platform/chromium-mac/fast/clip/011-expected.png: Added.
* platform/chromium-mac/fast/clip/012-expected.png: Added.
* platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win/fast/clip/008-expected.txt:
* platform/chromium-win/fast/clip/011-expected.txt:
* platform/chromium-win/fast/clip/012-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
* platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
* platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
* platform/mac/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
* platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
* platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
* platform/qt/fast/repaint/subtree-root-clip-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Widen/correct a few chromium expectations.
adamk@chromium.org [Fri, 2 Mar 2012 22:34:48 +0000 (22:34 +0000)]
Unreviewed gardening. Widen/correct a few chromium expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDOM tests take too long to run
rniwa@webkit.org [Fri, 2 Mar 2012 22:25:27 +0000 (22:25 +0000)]
DOM tests take too long to run
https://bugs.webkit.org/show_bug.cgi?id=80082

Reviewed by Eric Seidel.

Reduce benchmark.timeToRun from 500ms to 100ms. Doesn't seem to affect test results much
(except DOM/DOMTable.html) but significantly reduces the runtime of tests.

* DOM/resources/dom-perf.js:
(BenchmarkSuite.prototype.RunSingle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline an inspector test after r109599.
adamk@chromium.org [Fri, 2 Mar 2012 22:16:36 +0000 (22:16 +0000)]
Rebaseline an inspector test after r109599.
"evt" was changed to "event", lengthening it by two characters.

Unreviewed gardening.

* platform/chromium/inspector/debugger/debugger-scripts-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd the Chromium Lion canary bot to the flakiness dashboard.
ojan@chromium.org [Fri, 2 Mar 2012 22:00:13 +0000 (22:00 +0000)]
Add the Chromium Lion canary bot to the flakiness dashboard.
* TestResultServer/static-dashboards/builders.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout issue with fieldset legend element
dpranke@chromium.org [Fri, 2 Mar 2012 21:59:06 +0000 (21:59 +0000)]
Layout issue with fieldset legend element
https://bugs.webkit.org/show_bug.cgi?id=78684

Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-02
Reviewed by Dirk Pranke.

Source/WebCore:

The clipping logic for legend element was incorrect and now it has been corrected by taking correct offset in to consideration.

Test: fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html

* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):

LayoutTests:

* fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html: Added.

Test case to check un-clipped border logic

* platform/chromium/test_expectations.txt:
* platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Bindings for node always check if they are a Document.
arv@chromium.org [Fri, 2 Mar 2012 21:45:10 +0000 (21:45 +0000)]
[V8] Bindings for node always check if they are a Document.
https://bugs.webkit.org/show_bug.cgi?id=79947

Reviewed by Adam Barth.

This changes the generated bindings code to only generate the Document code for the Document wrappers.

No new tests. Covered by existing tests.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoanimation-timing-function falls back to ease when overriding animation-name
igor.o@sisa.samsung.com [Fri, 2 Mar 2012 21:40:54 +0000 (21:40 +0000)]
animation-timing-function falls back to ease when overriding animation-name
https://bugs.webkit.org/show_bug.cgi?id=71623

Source/WebCore:

In this patch the animation name needs to be the first value declared, if
a different value is found, we do not check for the animation name again.

Reviewed by Dean Jackson.

Test: animations/animation-shorthand-overriding.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationShorthand):

LayoutTests:

Add a test to verify if the override the animation-name property works when the parent
animation did not set the animation name.

Reviewed by Dean Jackson.

* animations/animation-shorthand-overriding-expected.txt: Added.
* animations/animation-shorthand-overriding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [AC] Connect WebGL to the TextureMapperGL code
mrobinson@webkit.org [Fri, 2 Mar 2012 21:37:11 +0000 (21:37 +0000)]
[GTK] [AC] Connect WebGL to the TextureMapperGL code
https://bugs.webkit.org/show_bug.cgi?id=78968

Reviewed by Gustavo Noronha Silva.

No new tests. This is covered by existing accelerated compositing and
WebGL tests.

Rely on the shared version of GL acquisition from GLContext. This reduces
a lot of code and now allows us to connect WebGL into the accelerated compositing
rendering path.

* GNUmakefile.list.am: GLContext should be included for all X11 builds now.
There are no longer GTK+ specific versions of GraphicsContext3D.
* platform/graphics/GraphicsContext3D.h: Add a default argument for
resolveMultisamplingIfNecessary. This will resolve the entire texture.
* platform/graphics/cairo/GraphicsContext3DCairo.cpp: GraphicsContext3D is
now responsible for creating GraphicsContext3DPrivate in the constructor.
(WebCore::GraphicsContext3D::platformLayer): Now return m_private.
* platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Added.
* platform/graphics/cairo/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h.
* platform/graphics/glx/GraphicsContext3DPrivate.cpp: Removed.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Properly
handle the default argument.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Use the new default argument now.
(WebCore::GraphicsContext3D::readRenderingResults): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109609 268f45cc-cd09-0410-ab3c-d52691b4dbfc