WebKit-https.git
9 years ago2011-04-29 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 4 May 2011 06:21:53 +0000 (06:21 +0000)]
2011-04-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Seidel.

        Implement FULLSCREEN_API on Windows, Part 4: Enable it
        https://bugs.webkit.org/show_bug.cgi?id=59798

        * wtf/Platform.h: Set ENABLE_FULLSCREEN_API on win.
2011-04-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Seidel.

        Implement FULLSCREEN_API on Windows, Part 4: Enable it
        https://bugs.webkit.org/show_bug.cgi?id=59798

        * WebCore.vcproj/WebCore.vcproj: Add missing full screen related
            files to the project.
2011-04-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Seidel.

        Implement FULLSCREEN_API on Windows, Part 4: Enable it
        https://bugs.webkit.org/show_bug.cgi?id=59798

        * win/tools/vsprops/FeatureDefines.vsprops: Set ENABLE_FULLSCREEN_API to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 4 May 2011 06:08:49 +0000 (06:08 +0000)]
2011-05-03  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Seidel.

        Unused but set variable warning in MacroAssemberX86_64
        https://bugs.webkit.org/show_bug.cgi?id=59482

        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::call):
        (JSC::MacroAssemblerX86_64::tailRecursiveCall):
        (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 05:46:04 +0000 (05:46 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        More 0 to nullptr.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::pluginLoadObserver):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3D::~GraphicsContext3D):
        * src/WebAudioBus.cpp:
        (WebKit::WebAudioBus::release):
        * src/WebBlobData.cpp:
        (WebKit::WebBlobData::reset):
        * src/WebViewImpl.cpp:
        (WebKit::WebView::addUserScript):
        (WebKit::WebView::addUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 05:30:54 +0000 (05:30 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        More places from 0 to nullptr.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::precompileScript):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::create):
        * platform/graphics/gpu/BicubicShader.cpp:
        (WebCore::BicubicShader::create):
        * platform/graphics/gpu/ConvolutionShader.cpp:
        (WebCore::ConvolutionShader::create):
        * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
        (WebCore::LoopBlinnSolidFillShader::create):
        * platform/graphics/gpu/SolidFillShader.cpp:
        (WebCore::SolidFillShader::create):
        * platform/graphics/gpu/TexShader.cpp:
        (WebCore::TexShader::create):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::~PlatformContextSkia):
        * platform/leveldb/LevelDBDatabase.cpp:
        (WebCore::LevelDBDatabase::createIterator):
        * platform/text/LocalizedNumberICU.cpp:
        (WebCore::createFormatterForCurrentLocale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated expected results after updating this test in r85676.
mitz@apple.com [Wed, 4 May 2011 05:07:17 +0000 (05:07 +0000)]
Updated expected results after updating this test in r85676.

* platform/mac/fast/text/ligature-subdivision-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 04:59:21 +0000 (04:59 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Quick suppresion for layout test failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 04:52:13 +0000 (04:52 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Using nullptr instead of 0. This makes visual studio happy.

        * storage/IDBTransactionBackendInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 03:54:14 +0000 (03:54 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage and new baselines.

        * platform/chromium-linux/fast/borders/bidi-012-expected.png: Added.
        * platform/chromium-mac-leopard/fast/borders/bidi-012-expected.png: Added.
        * platform/chromium-mac-leopard/fast/multicol/client-rects-expected.png: Added.
        * platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Removed.
        * platform/chromium-win/fast/borders/bidi-012-expected.png: Added.
        * platform/chromium-win/fast/borders/bidi-012-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/block/float/float-overhangs-root-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 03:36:06 +0000 (03:36 +0000)]
2011-05-03  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
        https://bugs.webkit.org/show_bug.cgi?id=59774

        No new tests required as on new functionality.

        * css/CSSStyleApplyProperty.cpp:
        (WebCore::ApplyPropertyColor::applyValue):
        Added template parameter "inheritColorFromParent = false".
        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        Use template parameter where appropriate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Wed, 4 May 2011 03:15:39 +0000 (03:15 +0000)]
2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Xan Lopez.

        [CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
        https://bugs.webkit.org/show_bug.cgi?id=60041

        Hardcode -Wno-c++0x-compat for the default compiler (if version >=
        4.6.0) until our codebase is ready. This is the same as done for
        autotools.

        * Source/cmake/WebKitHelpers.cmake: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 03:13:51 +0000 (03:13 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage and new baselines.

        * platform/chromium-linux/fast/box-shadow/inset-expected.png:
        * platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
        * platform/chromium-linux/fast/forms/basic-selects-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Added.
        * platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
        * platform/chromium-mac/fast/box-shadow/inset-expected.png: Removed.
        * platform/chromium-mac/fast/forms/basic-selects-expected.png: Removed.
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-expected.png:
        * platform/chromium-win/fast/forms/basic-selects-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Wed, 4 May 2011 03:07:14 +0000 (03:07 +0000)]
2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed, rolling out r85624.
        http://trac.webkit.org/changeset/85624

        The same command is used also for make_names.pl, which breaks
        the build.

        * Source/cmake/OptionsCommon.cmake: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 02:48:50 +0000 (02:48 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change and new baselines.

        * platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png: Added.
        * platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png: Added.
        * platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 02:34:42 +0000 (02:34 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.
mitz@apple.com [Wed, 4 May 2011 02:20:02 +0000 (02:20 +0000)]
<rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.

Reviewed by Darin Adler.

Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
dirty the line when the float is removed, instead of relying on the float always intersecting
its originating line.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::clearFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 02:14:22 +0000 (02:14 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage.

        * platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 4 May 2011 02:08:54 +0000 (02:08 +0000)]
2011-05-03  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by James Robinson.

        [chromium] Go through WebPermissionClient for local storage access.  Also cleanup left over code from previous WebPermissionClient change.
        https://bugs.webkit.org/show_bug.cgi?id=60066

        * public/WebFrameClient.h:
        * public/WebPermissionClient.h:
        (WebKit::WebPermissionClient::allowLocalStorage):
        * src/DatabaseObserver.cpp:
        (WebCore::DatabaseObserver::canEstablishDatabase):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::allowScriptExtension):
        (WebKit::FrameLoaderClientImpl::allowJavaScript):
        (WebKit::FrameLoaderClientImpl::allowPlugins):
        (WebKit::FrameLoaderClientImpl::allowImages):
        (WebKit::FrameLoaderClientImpl::didNotAllowScript):
        (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
        * src/StorageAreaProxy.cpp:
        (WebCore::StorageAreaProxy::setItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 01:59:32 +0000 (01:59 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triage.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 01:36:07 +0000 (01:36 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, remove obsolete baselines.

        * platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 4 May 2011 01:32:07 +0000 (01:32 +0000)]
2011-05-03  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make malloc validation useful
        https://bugs.webkit.org/show_bug.cgi?id=57502

        Reland this patch (rolled out in 82905) without
        turning it on by default.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/FastMalloc.cpp:
        (WTF::tryFastMalloc):
        (WTF::fastMalloc):
        (WTF::tryFastCalloc):
        (WTF::fastCalloc):
        (WTF::fastFree):
        (WTF::tryFastRealloc):
        (WTF::fastRealloc):
        (WTF::fastMallocSize):
        (WTF::TCMalloc_PageHeap::isScavengerSuspended):
        (WTF::TCMalloc_PageHeap::scheduleScavenger):
        (WTF::TCMalloc_PageHeap::suspendScavenger):
        (WTF::TCMalloc_PageHeap::signalScavenger):
        (WTF::TCMallocStats::malloc):
        (WTF::TCMallocStats::free):
        (WTF::TCMallocStats::fastCalloc):
        (WTF::TCMallocStats::tryFastCalloc):
        (WTF::TCMallocStats::calloc):
        (WTF::TCMallocStats::fastRealloc):
        (WTF::TCMallocStats::tryFastRealloc):
        (WTF::TCMallocStats::realloc):
        (WTF::TCMallocStats::fastMallocSize):
        * wtf/FastMalloc.h:
        (WTF::Internal::fastMallocValidationHeader):
        (WTF::Internal::fastMallocValidationSuffix):
        (WTF::Internal::fastMallocMatchValidationType):
        (WTF::Internal::setFastMallocMatchValidationType):
        (WTF::fastMallocMatchValidateFree):
        (WTF::fastMallocValidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 4 May 2011 01:28:38 +0000 (01:28 +0000)]
2011-05-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Adam Roben.

        Implement FULLSCREEN_API on Windows, Part 3: WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59845

        Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
        and WebKit2.  WebFullScreenController now uses a Client class to request work on its
        behalf by WebKit and WebKit2.  MediaPlayerPrivateFullscreenWindow now only creates a
        CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
        problems, and because a CALayerHost is overkill if the window is only drawing black to
        its client area.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
        (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create
            m_layerHost in the constructor.
        (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
        (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
        (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is
            not present, fill the window with black in WM_PAINT.
        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
        * platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
        * platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
        * platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h
        (WebCore::FullScreenControllerClient::~FullScreenControllerClient):
2011-05-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Adam Roben.

        Implement FULLSCREEN_API on Windows, Part 3: WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59845

        Implementation of WebFullScreenController has been moved into WebCore, and
        required virutal functions of WebFullScreenControllerClient have been added to
        WebView.  These functions are mostly simple accessors of existing ivars, but
        m_fullScreenElement and its accessors have also been added to WebView.

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::enterFullScreenForElement):
        * WebFullScreenController.cpp: Removed.
        * WebKit.vcproj/WebKit.vcproj:
        * WebView.cpp:
        (WebView::setFullScreenElement): Added accessor.
        (WebVIew::fullScreenElement): Ditto.
        (WebView::fullScreenClientWindow): Ditto.
        (WebView::fullScreenClientParentWindow): Ditto.
        (WebView::fullScreenClientSetParentWindow): Ditto.
        (WebView::fullScreenClientWillEnterFullScreen): Pass through to Document.
        (WebView::fullScreenClientDidEnterFullScreen): Ditto.
        (WebView::fullScreenClientWillExitFullScreen): Ditto.
        (WebView::fullScreenClientDidExitFullScreen): Ditto.
        * WebView.h:
2011-05-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Adam Roben.

        Implement FULLSCREEN_API on Windows, Part 3: WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59845

        Implement a similar full screen mode to WebKit; Re-use the same
        full screen window class used in WebKit in the new WebFullScreenController.
        No animations (yet), so many of the stubs remain unimplemented.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onKeyEvent): Handle VK_ESCAPE and cancel full screen
            mode if caught.
        (WebKit::WebView::fullScreenController): Lazily instantiate m_fullScreenController.
        (WebKit::WebView::fullScreenClientWindow): Added accessor.
        (WebKit::WebView::fullScreenClientParentWindow): Ditto.
        (WebKit::WebView::fullScreenClientSetParentWindow): Ditto.
        (WebKit::WebView::fullScreenClientWillEnterFullScreen): Pass through to WebFullScreenManagerProxy.
        (WebKit::WebView::fullScreenClientDidEnterFullScreen): Ditto.
        (WebKit::WebView::fullScreenClientWillExitFullScreen): Ditto.
        (WebKit::WebView::fullScreenClientDidExitFullScreen): Ditto.
        * UIProcess/win/WebView.h:
        * UIProcess/win/WebFullScreenManagerProxyWin.cpp:
        (WebKit::WebFullScreenManagerProxy::enterFullScreen): Pass through to
            WebFullScreenController.
        (WebKit::WebFullScreenManagerProxy::exitFullScreen): Ditto.
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::WebView):
        (WebKit::WebView::onKeyEvent): Handle the escape key and exit
           full screen mode when detected.
        (WebKit::WebView::fullScreenWindowController): Added.
        * UIProcess/win/WebView.h:
        * WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:
        (WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin):
        (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Host the root
            full screen layer if it gets detached.
        * WebProcess/FullScreen/win/WebFullScreenManagerWin.h:
        * win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 4 May 2011 01:14:20 +0000 (01:14 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations triaging.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
beidson@apple.com [Wed, 4 May 2011 00:38:54 +0000 (00:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
WK2 Icon Database should provide access to all image representations in the icon.

Reviewed by Sam Weinig.

../WebCore:

Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
(WebCore::Image::getCGImageArray):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getCGImageArray):

../WebKit2:

Expose a CFArrayRef of CGImageRefs as API for CG platforms:
* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryCopyCGImageArrayForURL):
* UIProcess/API/C/cg/WKIconDatabaseCG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Wed, 4 May 2011 00:38:36 +0000 (00:38 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 4 May 2011 00:38:05 +0000 (00:38 +0000)]
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        findNextLineBreak splits InlineIterator into 3 pieces
        https://bugs.webkit.org/show_bug.cgi?id=60082

        Avoid splitting InlineIterator into 3 variables with inter-dependencies.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::fastIncrementInTextNode): Added.
        (WebCore::InlineIterator::previousInSameNode): Added.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dean Jackson <dino@apple.com>
dino@apple.com [Wed, 4 May 2011 00:31:55 +0000 (00:31 +0000)]
2011-05-03  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        Interrupted transitions are not correctly removed
        https://bugs.webkit.org/show_bug.cgi?id=60062

        CompositeAnimation was replacing any existing
        transition as a new one was created. However, it wasn't
        clearing the lists in AnimationControllerPrivate that
        signal when a hardware animation starts. Rather than
        simple removing the existing transition, we now tell
        AnimationControllerPrivate that is has gone.

        Test: transitions/3d/interrupted-transition.html

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateTransitions):

2011-05-03  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        Interrupted transitions are not correctly removed
        https://bugs.webkit.org/show_bug.cgi?id=60062

        * transitions/3d/interrupted-transition-expected.txt: Added.
        * transitions/3d/interrupted-transition.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 4 May 2011 00:23:24 +0000 (00:23 +0000)]
2011-05-03  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        Update rebaseline queue server to handle hierarchical test results
        https://bugs.webkit.org/show_bug.cgi?id=60063

        Update test result parsing done by the rebaseline queue server to handle
        the hierarchical test result output that is generated as of r85254.

        * RebaselineQueueServer/templates/builder-queue-edit.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r84990): Nightly builds don't launch on Windows
bweinstein@apple.com [Tue, 3 May 2011 23:59:54 +0000 (23:59 +0000)]
REGRESSION(r84990): Nightly builds don't launch on Windows
https://bugs.webkit.org/show_bug.cgi?id=60081
<rdar://problem/9358635>

Reviewed by Steve Falkenburg.

Fix nightlies on Window by moving the layered window functions to the bottom
of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.

* Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
* Interfaces/WebKit.idl: Touch to force a rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 23:51:40 +0000 (23:51 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Adding rebaseline for recent changes for mac.

        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 3 May 2011 23:46:06 +0000 (23:46 +0000)]
2011-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        WebKit2 should treat API calls that start/stop loads as user gestures for responsiveness timer
        https://bugs.webkit.org/show_bug.cgi?id=60083

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::reattachToWebProcessWithItem):
        (WebKit::WebPageProxy::tryClose):
        (WebKit::WebPageProxy::loadURL):
        (WebKit::WebPageProxy::loadURLRequest):
        (WebKit::WebPageProxy::loadHTMLString):
        (WebKit::WebPageProxy::loadAlternateHTMLString):
        (WebKit::WebPageProxy::loadPlainTextString):
        (WebKit::WebPageProxy::stopLoading):
        (WebKit::WebPageProxy::reload):
        (WebKit::WebPageProxy::goForward):
        (WebKit::WebPageProxy::goBack):
        (WebKit::WebPageProxy::goToBackForwardItem):
        Start responsiveness timer for load start/stop and close.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::SendStopResponsivenessTimer::SendStopResponsivenessTimer):
        (WebKit::SendStopResponsivenessTimer::~SendStopResponsivenessTimer):
        Add simple RAII class to ensure the StopResponsivenessTimer is called.

        (WebKit::WebPage::tryClose):
        (WebKit::WebPage::loadURLRequest):
        (WebKit::WebPage::loadData):
        (WebKit::WebPage::stopLoading):
        (WebKit::WebPage::reload):
        (WebKit::WebPage::goForward):
        (WebKit::WebPage::goBack):
        (WebKit::WebPage::goToBackForwardItem):
        Sends a message back to the UIProcess to indicate the WebProcess
        is still responsive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Enrica Casucci <enrica@apple.com>
hclam@chromium.org [Tue, 3 May 2011 23:45:45 +0000 (23:45 +0000)]
2011-05-03  Enrica Casucci  <enrica@apple.com>

        Reviewed by Ryosuke Niwa.

        Crash in SpellingCorrectionController::respondToChangedSelection.
        https://bugs.webkit.org/show_bug.cgi?id=60071
        <rdar://problem/9358190>

        * editing/selection/undo-crash-expected.txt: Added.
        * editing/selection/undo-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in SpellingCorrectionController::respondToChangedSelection.
enrica@apple.com [Tue, 3 May 2011 23:40:46 +0000 (23:40 +0000)]
Crash in SpellingCorrectionController::respondToChangedSelection.
https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Creating a Visible position could trigger a layout and there is no
guarantee that the selection is still valid after that.

Tests: editing/selection/undo-crash.html

* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::respondToChangedSelection):

LayoutTests:

* editing/selection/undo-crash-expected.txt: Added.
* editing/selection/undo-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Incorrect line number dumping
ossy@webkit.org [Tue, 3 May 2011 23:35:06 +0000 (23:35 +0000)]
[Qt][WK2] Incorrect line number dumping
https://bugs.webkit.org/show_bug.cgi?id=60074

[Qt][WK2] editing/pasteboard/do-not-copy-body-color.html fails
https://bugs.webkit.org/show_bug.cgi?id=60076

* platform/qt-wk2/Skipped: Add a couple of failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 3 May 2011 23:28:11 +0000 (23:28 +0000)]
2011-05-03  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Refactor computeInlineDirectionPositionsForLine into smaller functions
        https://bugs.webkit.org/show_bug.cgi?id=60072

        Split three functions off from computeInlineDirectionPositionsForLine
        to improve its readability.

        No new tests since this is just moving code around.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::setMarginsForRubyRun):
        (WebCore::setLogicalWidthForTextRun):
        (WebCore::computeExpansionForJustifiedText):
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
ddkilzer@apple.com [Tue, 3 May 2011 23:25:15 +0000 (23:25 +0000)]
<webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking

Reviewed by Antti Koivisto.

Source/WebCore:

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
priority on the request if HTTP pipelining is enabled.
(WebCore::ResourceRequest::doUpdateResourceRequest): Read the
priority from the request if HTTP pipelining is enabled.
(readBooleanPreference): Enable code when compiling with
USE(CFNETWORK).
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
Comment out setting the minimum fast lane priority on Windows
since it's not currently available.

Source/WebKit/win:

* Interfaces/IWebViewPrivate.idl:
(IWebViewPrivate::httpPipeliningEnabled): Added declaration.
(IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.
* WebView.cpp:
(WebView::httpPipeliningEnabled): Added.
(WebView::setHTTPPipeliningEnabled): Added.
* WebView.h:
(WebView::httpPipeliningEnabled): Added declaration.
(WebView::setHTTPPipeliningEnabled): Added declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 23:20:43 +0000 (23:20 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Add a bug number for a recent regression to test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 23:18:20 +0000 (23:18 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Test expectations.

        * platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 May 2011 23:14:31 +0000 (23:14 +0000)]
2011-05-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on

        Conditionalize compositing tiled layer size-constraining logic to older
        OSes.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::constrainedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 23:08:21 +0000 (23:08 +0000)]
2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Allow access keys to be used in shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59979

        Move access key methods and members back to Document from TreeScope.
        Also traverse into shadow trees when building the access key map.

        No new tests. (refactoring)

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::getElementByAccessKey):
        (WebCore::Document::buildAccessKeyMap):
        (WebCore::Document::invalidateAccessKeyMap):
        * dom/Document.h:
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::TreeScope):
        (WebCore::TreeScope::destroyTreeScopeData):
        * dom/TreeScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 23:00:59 +0000 (23:00 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Build fix. Not reviewed.

        Add test expectations for new tests.

        * platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical...
mitz@apple.com [Tue, 3 May 2011 22:33:25 +0000 (22:33 +0000)]
<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
https://bugs.webkit.org/show_bug.cgi?id=60067

Reviewed by Darin Adler.

No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.

* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
results for flipped writing modes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAccount for font metric differences exposed by r85411.
mitz@apple.com [Tue, 3 May 2011 22:30:45 +0000 (22:30 +0000)]
Account for font metric differences exposed by r85411.
Fixes <rdar://problem/9377892> REGRESSION (r85403-r85475): platform/mac/fast/text/ligature-subdivision.html failing

Rubber-stamped by Darin Adler.

* platform/mac/fast/text/script-tests/ligature-subdivision.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 22:29:41 +0000 (22:29 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Update results for fast/harness/results.html.  We shouldn't be
        ignoring these failures :(

        * fast/harness/results-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 22:25:57 +0000 (22:25 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Update chromium linux test results after r85013.  The vertical
        positioning of the glyphs have improved.

        * platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
        * platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
        * platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
        * platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
        * platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
        * platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Tue, 3 May 2011 22:22:49 +0000 (22:22 +0000)]
2011-05-03  Anton Muhin  <antonm@chromium.org>

        Reviewed by Yury Semikhatsky.

        [v8] remove an ASSERT from grouping logic
        https://bugs.webkit.org/show_bug.cgi?id=60024

        This ASSERT was exploratory.  Alas, right now I am aware of no easy way to
        repro it.  Removing for now for greener bots.

        No new tests, only an ASSERT removal.

        * bindings/v8/V8GCController.cpp:
        (WebCore::calculateGroupId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 May 2011 22:20:34 +0000 (22:20 +0000)]
2011-05-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        webkit-patch post-commits HEAD^.. throws an exception
        https://bugs.webkit.org/show_bug.cgi?id=60027

        * Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer...
ossy@webkit.org [Tue, 3 May 2011 22:16:47 +0000 (22:16 +0000)]
[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer-items is not a Qt default build option
https://bugs.webkit.org/show_bug.cgi?id=60068

Patch by Igor Oliveira <igor.oliveira@openbossa.org> on 2011-05-03
Reviewed by Csaba Osztrogon√°c.

Skip data-transfer-items.html test because data-transfer-items
is not a Qt default build option

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Layout tests may timeout if loadFinished receives false
luiz@webkit.org [Tue, 3 May 2011 22:16:31 +0000 (22:16 +0000)]
[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Fixing ChangeLog.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::maybeDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 3 May 2011 22:14:46 +0000 (22:14 +0000)]
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebKit allows selection that crosses the shadow boundary of a readonly input element
        https://bugs.webkit.org/show_bug.cgi?id=60000

        Added pixel tests to ensure WebKit doesn't create a selection that spans across
        the shadow DOM boundary of a readonly input element. Also rebaselined a test that
        previously exhibited this behavior.

        * editing/selection/resources/select-across-readonly-input.js: Added.
        (moveMouseToMiddleOfElement):
        * editing/selection/select-across-readonly-input-1.html: Added.
        * editing/selection/select-across-readonly-input-2.html: Added.
        * editing/selection/select-across-readonly-input-3.html: Added.
        * editing/selection/select-across-readonly-input-4.html: Added.
        * editing/selection/select-across-readonly-input-5.html: Added.
        * platform/mac/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebKit allows selection that crosses the shadow boundary of a readonly input element
        https://bugs.webkit.org/show_bug.cgi?id=60000

        The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
        Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
        in its validation process.

        Tests: editing/selection/select-across-readonly-input-1.html
               editing/selection/select-across-readonly-input-2.html
               editing/selection/select-across-readonly-input-3.html
               editing/selection/select-across-readonly-input-4.html
               editing/selection/select-across-readonly-input-5.html

        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
        (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
        * editing/VisibleSelection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 May 2011 22:11:39 +0000 (22:11 +0000)]
2011-05-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Split out layoutRunsAndFloats from layoutInlineChildren
        https://bugs.webkit.org/show_bug.cgi?id=60052

        No new tests, just moving code here.  There should be
        no change in behavior.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutRunsAndFloats):
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Layout tests may timeout if loadFinished receives false
luiz@webkit.org [Tue, 3 May 2011 22:05:22 +0000 (22:05 +0000)]
[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Reviewed by NOBODY Kenneth Rohde Christiansen.

When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
a response is ignored, like it should be for 204 responses. It is a problem for creating
tests for 204 responses for example.

This change has been tested and it causes no regressions in layout tests.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::maybeDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 22:05:14 +0000 (22:05 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Add expectation to suppress new failure.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 3 May 2011 21:51:33 +0000 (21:51 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, rolling out r85659.
        http://trac.webkit.org/changeset/85659
        https://bugs.webkit.org/show_bug.cgi?id=59977

        restarting isn't working correctly

        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
ossy@webkit.org [Tue, 3 May 2011 21:47:07 +0000 (21:47 +0000)]
[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

* platform/qt-wk2/Skipped: Add failing tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 James Robinson <jamesr@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 21:40:29 +0000 (21:40 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

        * fast/canvas/canvas-resize-after-paint-expected.txt: Added.
        * fast/canvas/canvas-resize-after-paint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key...
darin@apple.com [Tue, 3 May 2011 21:33:23 +0000 (21:33 +0000)]
<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key does)

Reviewed by Sam Weinig.

No test at this time because the WebKit2 eventSender doesn't use this code path.

* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebKeyboardEvent): Copied the code to special-case certain
keys from the corresponding Mac WebKit1 code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 3 May 2011 21:21:27 +0000 (21:21 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

        * fast/canvas/canvas-resize-after-paint-expected.txt: Added.
        * fast/canvas/canvas-resize-after-paint.html: Added.
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.

        Test: fast/canvas/canvas-resize-after-paint.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::reset):
            Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
            DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
        * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
        (WebCore::Canvas2DLayerChromium::setLayerRenderer):
            Add a null check for m_drawingBuffer
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::clear):
            Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
            this is unnecessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 21:21:15 +0000 (21:21 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling the version of chromium to r83922.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 3 May 2011 21:18:43 +0000 (21:18 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: fix http server startup/shutdown

        Previous versions of the code had three problems that made startup
        and shutdown flaky. The first is that it would throw exceptions
        if it couldn't delete stale log files, which was overly
        paranoid. The second is that some of the exceptions weren't
        defined properly. The third, and most important, is that it was
        using urllib to check if ports were available, which was leaving
        sockets in a half-closed state, and keeping ports from being
        reused. By switching to raw sockets, we are able to now reliably
        restart.

        This change also switches the code to using Executives to stop
        processes, which will let us delete a bunch of code in the
        port/* implementations and fix a weird layering problem in a
        subsequent patch.

        https://bugs.webkit.org/show_bug.cgi?id=59977

        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 3 May 2011 21:14:48 +0000 (21:14 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        fix failing printing_unittest on win32
        https://bugs.webkit.org/show_bug.cgi?id=59963

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Tue, 3 May 2011 20:57:14 +0000 (20:57 +0000)]
2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Adam Roben.

        Add tests to PrettyPatch
        https://bugs.webkit.org/show_bug.cgi?id=57298

        Verify that 'prettify' parse the right number of files and parts
        (add/remove/shared) by checking a set of patches available in
        bugs.webkit.org.

        * PrettyPatch/PrettyPatch.rb: exported a couple a globals with
        statistics information for our test script.
        * PrettyPatch/PrettyPatch_test.rb: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd some missing virtual keywords on derived-class destructors
aroben@apple.com [Tue, 3 May 2011 20:55:44 +0000 (20:55 +0000)]
Add some missing virtual keywords on derived-class destructors

Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
just matches our style of explicitly marking overrides "virtual".

* WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and
WebInspectorFrontendClient destructors explicitly virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Tue, 3 May 2011 20:54:26 +0000 (20:54 +0000)]
2011-05-03  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Unreachable URL is lost when canceling load of a new page
        https://bugs.webkit.org/show_bug.cgi?id=60057
        <rdar://problem/9049135>

        When setting the unreachable URL in the WebFrameProxy, keep track of any previous unreachable URL
        so we can restore it if the page load fails.

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::didFailProvisionalLoad): Restore m_unreachableURL to previous value.
        (WebKit::WebFrameProxy::setUnreachableURL): Keep track of previous unreachable URL in m_lastUnreachableURL.
        * UIProcess/WebFrameProxy.h: Moved setUnreachableURL() implementation to .cpp file, added m_lastUnreachableURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 20:51:46 +0000 (20:51 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        store results.html options in localstorage
        https://bugs.webkit.org/show_bug.cgi?id=60048

        This makes options persistent per-domain. It's not perfect,
        but it should make it possible to have preferences for how
        people would like the results.html page to render.

        * fast/harness/resources/results-test.js:
        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix most strict PassOwnPtr violations on Windows
aroben@apple.com [Tue, 3 May 2011 20:51:30 +0000 (20:51 +0000)]
Fix most strict PassOwnPtr violations on Windows

Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
enabled

Reviewed by Anders Carlsson.

Source/WebCore:

* loader/EmptyClients.h:
* platform/GeolocationService.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
* platform/mock/GeolocationServiceMock.cpp:
* rendering/RenderTheme.cpp:
* rendering/RenderThemeSafari.cpp:

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now
that this type is put into a PassOwnPtr. (Previously, only
WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)

* FullscreenVideoController.cpp:
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebInspectorClient.cpp:
* WebHistory.cpp:
* WebHistoryItem.cpp:
* WebView.cpp:

Source/WebKit2:

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::writeEventHandler): Use nullptr.

Tools:

* WebKitAPITest/Test.h: Use adoptPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 3 May 2011 20:49:15 +0000 (20:49 +0000)]
2011-05-03  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Extract LineInfo class
        https://bugs.webkit.org/show_bug.cgi?id=60044

        Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
        layout information about a line. This simplifies function signatures and clears up initialization.

        No new tests as this is refactoring.

        * rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::LineInfo::LineInfo):
        (WebCore::LineInfo::isFirstLine):
        (WebCore::LineInfo::isLastLine):
        (WebCore::LineInfo::isEmpty):
        (WebCore::LineInfo::previousLineBrokeCleanly):
        (WebCore::LineInfo::setFirstLine):
        (WebCore::LineInfo::setLastLine):
        (WebCore::LineInfo::setEmpty):
        (WebCore::LineInfo::setPreviousLineBrokeCleanly):
        (WebCore::RenderBlock::createLineBoxes):
        (WebCore::RenderBlock::constructLine):
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::determineStartPosition):
        (WebCore::skipNonBreakingSpace):
        (WebCore::shouldCollapseWhiteSpace):
        (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp
        (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Tue, 3 May 2011 20:39:14 +0000 (20:39 +0000)]
2011-05-03  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

        Force linking with zlib so that uncompress() exists.

        * Source/cmake/OptionsEfl.cmake: Find zlib.
2011-05-03  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

        Force linking with zlib so that uncompress() exists.

        * CMakeListsEfl.txt: Append zlib libraries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 20:35:39 +0000 (20:35 +0000)]
2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Update node list cache count on the containing TreeScope rather than the Document
        https://bugs.webkit.org/show_bug.cgi?id=59983

        Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
        Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
        Make setDocument() and setDocumentRecursively() private.

        No new tests. (refactoring)

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::childrenChanged):
        * dom/Node.cpp:
        (WebCore::Node::~Node):
        (WebCore::Node::setDocument):
        (WebCore::Node::setTreeScopeRecursively):
        (WebCore::Node::childNodes):
        (WebCore::Node::registerDynamicNodeList):
        (WebCore::Node::unregisterDynamicNodeList):
        (WebCore::Node::notifyLocalNodeListsAttributeChanged):
        (WebCore::Node::notifyLocalNodeListsChildrenChanged):
        (WebCore::Node::getElementsByTagName):
        (WebCore::Node::getElementsByTagNameNS):
        (WebCore::Node::getElementsByName):
        (WebCore::Node::getElementsByClassName):
        * dom/Node.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::labels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 3 May 2011 20:33:25 +0000 (20:33 +0000)]
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
        https://bugs.webkit.org/show_bug.cgi?id=60046

        Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::TrailingObjects::TrailingObjects):
        (WebCore::TrailingObjects::setTrailingWhitespace):
        (WebCore::TrailingObjects::clear):
        (WebCore::TrailingObjects::appendBoxIfNeeded):
        (WebCore::TrailingObjects::addMidpoints):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 3 May 2011 20:29:58 +0000 (20:29 +0000)]
2011-05-03  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Eric Seidel.

        [Qt] Implement initial support to DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=58448

        Remove data-transfer-items.html from Qt skipped tests and create an expected
        result file for data-transfer-items.html test. The need to create a expected result
        file is because the test presuppose that the type of the first element in
        DataTransferItems list is a html but when Qt selects a data, it first copies a text
        and then it copies the html, so for Qt expected test file the first element is a
        text and the second one is a html.

        * platform/qt/Skipped:
        * platform/qt/editing/pasteboard/data-transfer-items-expected.txt: Added.
2011-05-03  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Eric Seidel.

        [Qt] Implement initial support to DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=58448

        Implement initial support to DataTransferItems. DataTransferItems are used to
        hold data for drag and drop operations. DataTransferItems hold a list of
        DataTransferItem objects each of which holds an item being dragged.

        * WebCore.pro:
        * dom/DataTransferItems.idl:
        * editing/qt/EditorQt.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * page/qt/EventHandlerQt.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/chromium/DataTransferItemsChromium.h:
        * platform/qt/ClipboardQt.cpp:
        (WebCore::Clipboard::create):
        (WebCore::ClipboardQt::ClipboardQt):
        (WebCore::ClipboardQt::items):
        * platform/qt/ClipboardQt.h:
        (WebCore::ClipboardQt::create):
        * platform/qt/DataTransferItemQt.cpp: Added.
        (WebCore::DataTransferItem::create):
        (WebCore::DataTransferItemQt::createFromPasteboard):
        (WebCore::DataTransferItemQt::create):
        (WebCore::DataTransferItemQt::DataTransferItemQt):
        (WebCore::DataTransferItemQt::getAsString):
        (WebCore::DataTransferItemQt::getAsFile):
        * platform/qt/DataTransferItemQt.h: Added.
        * platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
        (WebCore::DataTransferItemsQt::create):
        (WebCore::DataTransferItemsQt::DataTransferItemsQt):
        (WebCore::DataTransferItemsQt::addPasteboardItem):
        * platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Tue, 3 May 2011 20:22:04 +0000 (20:22 +0000)]
2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        Add myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 20:16:10 +0000 (20:16 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        new baseline for SVG test.

        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 20:11:39 +0000 (20:11 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        New baseline for GPU layout tests.

        * platform/chromium-gpu-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-gpu-mac/animations/3d/state-at-end-event-transform-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Tue, 3 May 2011 20:08:26 +0000 (20:08 +0000)]
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        No new tests, refactoring only.

        * dom/Element.cpp:
        (WebCore::Element::copyNonAttributeProperties):
        (WebCore::Element::insertedIntoDocument):
        (WebCore::Element::removedFromDocument):
        (WebCore::Element::insertedIntoTree):
        (WebCore::Element::removedFromTree):
        (WebCore::Element::attach):
        (WebCore::Element::detach):
        (WebCore::Element::recalcStyle):
        (WebCore::Element::shadowRoot):
        (WebCore::Element::ensureShadowRoot):
        (WebCore::Element::childrenChanged):
        * dom/Node.cpp:
        (WebCore::Node::setTreeScopeRecursively):
        (WebCore::shadowRoot):
        (WebCore::Node::setDocumentRecursively):
        (WebCore::NodeRendererFactory::findVisualParent):
        Updated all the call sites for shadowRoot and ensureShadowRoot in the 2
        previous classes.

        * dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.

        * dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.

        * html/HTMLDetailsElement.cpp:
        * html/HTMLSummaryElement.cpp:
        Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * src/WebElement.cpp: Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added #include for ShadowRoot.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 3 May 2011 20:07:20 +0000 (20:07 +0000)]
2011-05-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Implement mediaSliderTrack
        https://bugs.webkit.org/show_bug.cgi?id=59998

        Implement paintMediaSliderTrack.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::RenderThemeEfl):
        (WebCore::RenderThemeEfl::paintMediaSliderTrack):
        * platform/efl/RenderThemeEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 3 May 2011 20:03:34 +0000 (20:03 +0000)]
2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
        https://bugs.webkit.org/show_bug.cgi?id=60023

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotConstructorNode):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshot.prototype.dispose):
        (WebInspector.HeapSnapshot.prototype.aggregates):
        (WebInspector.HeapSnapshot.prototype._buildAggregates):
        (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
        (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
        (WebInspector.HeapSnapshotFilteredOrderedIterator):
        (WebInspector.HeapSnapshotNodesProvider):
        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotProxy.prototype.aggregates):
        (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 3 May 2011 19:52:59 +0000 (19:52 +0000)]
2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
        https://bugs.webkit.org/show_bug.cgi?id=60029

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset):
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>
commit-queue@webkit.org [Tue, 3 May 2011 19:51:24 +0000 (19:51 +0000)]
2011-05-03  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtDeclarative Webview element has a fixed white background
        https://bugs.webkit.org/show_bug.cgi?id=40918

        QProperty REVISION feature is not present in certain Qt Trunk clones.
        These builds report their version as 4.8.0, and therefore break on the
        prior #if QT_VERSION >= 0x040704.  The proper fix is to check based on
        the existance of Q_REVISION.

        * declarative/plugin.cpp:
        (WebKitQmlPlugin::registerTypes):
        * declarative/qdeclarativewebview.cpp:
        * declarative/qdeclarativewebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 3 May 2011 19:50:26 +0000 (19:50 +0000)]
2011-05-03  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping test timing out in the GTK 64-bit bot.

        * platform/gtk/Skipped: Skipped media/video-volume-slider.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 19:47:40 +0000 (19:47 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        improve styling of options menu in results.html file

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 19:42:09 +0000 (19:42 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        New baseline and add test expectation to suppress failure.

        * platform/chromium-gpu-win/animations/3d/replace-filling-transform-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 19:34:36 +0000 (19:34 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        Don't include the test itself in expanded test results
        https://bugs.webkit.org/show_bug.cgi?id=60051

        When loading from local disk, we can't force it to render as
        plain text, which causes the page to actually run. Also,
        the extra clutter of another iframe is probably not worth it.

        If we decide we want this later, we can add it back in as a
        preference that's off by default.

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 19:31:34 +0000 (19:31 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Test expectation for a slow test to avoid flakiness.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 19:25:08 +0000 (19:25 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Fix test that broke after adding CSS animations.

        * fast/harness/resources/results-test.js:
        * fast/harness/results-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 19:19:25 +0000 (19:19 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Adding test expectations for some SVG tests on Windows.

        * platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
        * platform/chromium-win/svg/text/text-intro-05-t-expected.png:
        * platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 19:17:19 +0000 (19:17 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Adding test expectations for some SVG tests on Windows.

        * platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
        * platform/chromium-win/svg/text/text-intro-05-t-expected.png:
        * platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Tue, 3 May 2011 19:11:39 +0000 (19:11 +0000)]
2011-05-03  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: cursor update updates indexes
        https://bugs.webkit.org/show_bug.cgi?id=59995

        This test creates an object store, adds both a unique and a non-unique index,
        adds a record, opens a cursor, changes the record, and verifies that both
        indexes correctly updated to reflect the modified record.

        * storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt: Added.
        * storage/indexeddb/mozilla/cursor-update-updates-indexes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 3 May 2011 18:45:46 +0000 (18:45 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Remove stale expectations for animations/3d in chromium test_expectations.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=60045
bdakin@apple.com [Tue, 3 May 2011 18:45:23 +0000 (18:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60045
Scrollbar thumb sometimes leaves artifacts in the track after scrolling
-and corresponding-
<rdar://problem/9015376>

Reviewed by Dan Bernstein.

When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should
always be ignored.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 3 May 2011 18:43:42 +0000 (18:43 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Layout test animations/3d/replace-filling-transform.html failing
        https://bugs.webkit.org/show_bug.cgi?id=59839

        Ignore animations/3d when run in CPU mode as these are compositor tests.

        * platform/chromium/test_expectations.txt:
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Layout test animations/3d/replace-filling-transform.html failing
        https://bugs.webkit.org/show_bug.cgi?id=59839

        Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 18:18:06 +0000 (18:18 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        make pixel zooming in results.html file less jarring
        https://bugs.webkit.org/show_bug.cgi?id=60038

        -Hide zoomed images when you mouse out of the document or
        mouseover an iframe.
        -Handle the case where the zoomed images overlap the actual images.

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Tue, 3 May 2011 18:15:51 +0000 (18:15 +0000)]
2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed, rolling out r85471.
        http://trac.webkit.org/changeset/85471
        https://bugs.webkit.org/show_bug.cgi?id=59922

        The rule of thumb in EFL is that you init in all the places
        you use it. So, if in your application you call ecore_evas_*
        functions, you have to call ecore_evas_init() first.

        * EWebLauncher/main.c: always call *_init() functions when you use
        that namespace.
        (quit):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Tue, 3 May 2011 18:10:59 +0000 (18:10 +0000)]
2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        [CMAKE] Unreviewed build fix for gcc >= 4.6

        Same fix as done in r84123. CMake explicitly pass the arguments to
        make_names.pl, so let's make them the same.

        * Source/cmake/OptionsCommon.cmake: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=60040
hyatt@apple.com [Tue, 3 May 2011 18:00:23 +0000 (18:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60040
<rdar://problem/9261591>

Reviewed by Dan Bernstein.

Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.

Source/WebCore:

Added fast/inline/skipped-whitespace-client-rect.html

* rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteQuads):

LayoutTests:

Added fast/inline/skipped-whitespace-client-rect.html

* fast/inline/skipped-whitespace-client-rect-expected.txt: Added.
* fast/inline/skipped-whitespace-client-rect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore quarantine related sandbox denial when downloading files
weinig@apple.com [Tue, 3 May 2011 17:43:44 +0000 (17:43 +0000)]
More quarantine related sandbox denial when downloading files
<rdar://problem/9362626>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-03 Xan Lopez <xlopez@igalia.com>
alexis.menard@openbossa.org [Tue, 3 May 2011 17:34:15 +0000 (17:34 +0000)]
2011-05-03  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Anders Carlsson.

        Compile error with GCC 4.6.0, tries to assign unsigned& to bitfield
        https://bugs.webkit.org/show_bug.cgi?id=59261

        Use unary '+' to force proper type detection in template arguments
        with GCC 4.6.0. See bug report for more details.

        * runtime/Structure.cpp:
        (JSC::StructureTransitionTable::remove): Use '+' to force precise type detection.
        (JSC::StructureTransitionTable::add): ditto.
        * runtime/Structure.h:
        (JSC::StructureTransitionTable::keyForWeakGCMapFinalizer): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix chromium build.
weinig@apple.com [Tue, 3 May 2011 17:27:01 +0000 (17:27 +0000)]
Fix chromium build.

* page/Settings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 17:20:17 +0000 (17:20 +0000)]
2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 59974 - Update image map on the containing TreeScope rather than the Document
        https://bugs.webkit.org/show_bug.cgi?id=59974

        No new tests. (reefactoring)

        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::parseMappedAttribute):
        (WebCore::HTMLMapElement::insertedIntoDocument):
        (WebCore::HTMLMapElement::removedFromDocument):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix chromium build.
weinig@apple.com [Tue, 3 May 2011 17:18:28 +0000 (17:18 +0000)]
Fix chromium build.

* loader/HistoryController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 17:17:44 +0000 (17:17 +0000)]
2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
        https://bugs.webkit.org/show_bug.cgi?id=59966

        No new tests. (refactoring)

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::elementsFromAttribute):
        (WebCore::AccessibilityRenderObject::activeDescendant):
        * accessibility/AccessibilityRenderObject.h:
        (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
        * css/CSSCursorImageValue.cpp:
        (WebCore::resourceReferencedByCursorElement):
        (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
        (WebCore::CSSCursorImageValue::cachedImage):
        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::itemWithName):
        * dom/Element.h:
        (WebCore::Element::updateId):
        * dom/Node.cpp:
        (WebCore::Node::querySelector):
        * html/FormAssociatedElement.cpp:
        (WebCore::FormAssociatedElement::insertedIntoTree):
        (WebCore::FormAssociatedElement::resetFormOwner):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::dataList):
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::control):
        * rendering/svg/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::layoutPath):
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::glyphElement):
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource):
        (WebCore::SVGFEImageElement::build):
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::collectGradientAttributes):
        * svg/SVGMPathElement.cpp:
        (WebCore::SVGMPathElement::pathElement):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::collectPatternAttributes):
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::collectGradientAttributes):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::getElementById):
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::updateReferencedText):
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::insertedIntoDocument):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildPendingResource):
        (WebCore::SVGUseElement::hasCycleUseReferencing):
        (WebCore::SVGUseElement::expandUseElementsInShadowTree):
        * svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::viewTarget):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::eventBaseFor):
        (WebCore::SVGSMILElement::connectConditions):
        (WebCore::SVGSMILElement::targetElement):
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunId::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85617 268f45cc-cd09-0410-ab3c-d52691b4dbfc