WebKit-https.git
8 years ago[BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies...
commit-queue@webkit.org [Wed, 18 Apr 2012 10:56:38 +0000 (10:56 +0000)]
[BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies have been cleared.
https://bugs.webkit.org/show_bug.cgi?id=84223

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.

.:

* ManualTests/blackberry/clear-cookie-refresh-result.php: Added.
* ManualTests/blackberry/clear-cookie-refresh.php: Added.

Source/WebCore:

Webkit uses the old ResourceRequest when refreshing. Its cookies' header isn't removed after clicking
"clear cookies" button. We need to set cookies for this request again.

We must click "clear button" to test, so have to write a manual test case.

Test: ManualTests/blackberry/clear-cookie-refresh.php

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Chromium] Module's require injects scripts before the debug id is...
pfeldman@chromium.org [Wed, 18 Apr 2012 10:09:56 +0000 (10:09 +0000)]
Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166

Reviewed by Yury Semikhatsky.

V8IsolatedContext was getting debug id assigned post-construction. At the same time, it was compiling all
its module scripts within the constructor. As a result, scripts ended up in the main world's list.

* bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureConten...
commit-queue@webkit.org [Wed, 18 Apr 2012 10:04:24 +0000 (10:04 +0000)]
[Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
https://bugs.webkit.org/show_bug.cgi?id=84172

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-18
Reviewed by Simon Hausmann.

After the viewport computing refactor, ensureContentWithinViewportBoundary() can be called
with resumed page. QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
functionality does not necessarily require the page to be suspended. It's the caller's context
that determines whether the page needs to be suspended, so it's the caller's responsibility
to enforce the ASSERT().
Remove the invalid ASSERT on m_suspendCount at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update expectations
toyoshim@chromium.org [Wed, 18 Apr 2012 08:53:21 +0000 (08:53 +0000)]
Unreviewed, update expectations
https://bugs.webkit.org/show_bug.cgi?id=84230

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: document.open removes the documentElement, but does not clear the...
pfeldman@chromium.org [Wed, 18 Apr 2012 08:49:28 +0000 (08:49 +0000)]
Web Inspector: document.open removes the documentElement, but does not clear the elements panel.
https://bugs.webkit.org/show_bug.cgi?id=84179

Reviewed by Yury Semikhatsky.

Source/WebCore:

Perform total update upon modifications of the document node.

Test: inspector/elements/delete-from-document.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpElementsTree.print):
(initialize_ElementTest.InspectorTest.dumpElementsTree):
* inspector/elements/delete-from-document-expected.txt: Added.
* inspector/elements/delete-from-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio
commit-queue@webkit.org [Wed, 18 Apr 2012 08:40:40 +0000 (08:40 +0000)]
Source/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

Test: media/audio-concurrent-supported.html

* platform/blackberry/PageClientBlackBerry.h:
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::isTabVisible):
(WebCore):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

Source/WebKit/blackberry: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

* Api/WebPageClient.h:
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::isVisible):

LayoutTests: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Layout test for concurrent HTML5 audio. This is a simple test
to confirm that multiple audio elements can play at the same time.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

* media/audio-concurrent-supported-expected.txt: Added.
* media/audio-concurrent-supported.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM
kkristof@inf.u-szeged.hu [Wed, 18 Apr 2012 08:17:11 +0000 (08:17 +0000)]
[Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-18

* platform/qt/Skipped: fast/dom/shadow/adopt-node-with-shadow-root.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CG] ImageBuffer: check getPremultipliedImageData() error return
noel.gordon@gmail.com [Wed, 18 Apr 2012 08:05:43 +0000 (08:05 +0000)]
[CG] ImageBuffer: check getPremultipliedImageData() error return
https://bugs.webkit.org/show_bug.cgi?id=84022

Reviewed by Eric Seidel.

ImageBuffer::getPremultipliedImageData() can fail. toDataURL() should check for a
failure return, and return "data:," if so.

No new tests. Covered by existing toDataURL tests, in particular:
  canvas/philip/tests/toDataURL.jpeg.alpha.html

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Rename |arr| variable to premultipliedData and
return "data:," if premultipliedData is empty. Clean up whitespace and a comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] atk/textChangedNotifications API test fails
mario@webkit.org [Wed, 18 Apr 2012 07:37:32 +0000 (07:37 +0000)]
[GTK] atk/textChangedNotifications API test fails
https://bugs.webkit.org/show_bug.cgi?id=84010

Unreviewed, unskipping test after bug being fixed by r114311.

* Scripts/run-gtk-tests:
(TestRunner): Unskip now passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Viewport metatag doesn't disable double-tap zoom
commit-queue@webkit.org [Wed, 18 Apr 2012 06:39:35 +0000 (06:39 +0000)]
[BlackBerry] Viewport metatag doesn't disable double-tap zoom
https://bugs.webkit.org/show_bug.cgi?id=84199

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-17
Reviewed by George Staikos.

Source/WebKit/blackberry:

PR: 148279
When we set "user-scalable=no" in viewport meta-tag and change any
other WebSettings, the WebPage can turn to be scalable.
This is a regression of the change master_32/SHA:fa0f8ee9. In that
change, we used setUserScalable(webSettings->isUserScalable())
in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
case, as webSettings->isUserScalable() would always return true by
default.
Create a new API WebPage::setUserScalable which will be used in
DumpRenderTree.cpp.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setUserScalable):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebPage.h:

Tools:

Revert a part of the change master_32/SHA:fa0f8ee9 and use
WebPage::setUserScalable instead.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkia OOM error when upscaling small subsets of images by large quantities
commit-queue@webkit.org [Wed, 18 Apr 2012 06:36:30 +0000 (06:36 +0000)]
Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225

Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.

Tested with manual tests.

* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::shouldCacheResampling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline of svg/W3C-SVG-1.1/masking-intro-01-f.svg .
toyoshim@chromium.org [Wed, 18 Apr 2012 05:54:26 +0000 (05:54 +0000)]
Unreviewed, rebaseline of svg/W3C-SVG-1.1/masking-intro-01-f.svg .

* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitTestRunner needs textInputController
jer.noble@apple.com [Wed, 18 Apr 2012 05:47:45 +0000 (05:47 +0000)]
WebKitTestRunner needs textInputController
https://bugs.webkit.org/show_bug.cgi?id=42337

Update wk2 Skipped list to skip new failing test.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] http/tests/navigation/anchor-frames-same-origin.html fails
jer.noble@apple.com [Wed, 18 Apr 2012 05:34:09 +0000 (05:34 +0000)]
[WK2] http/tests/navigation/anchor-frames-same-origin.html fails
https://bugs.webkit.org/show_bug.cgi?id=84227

Update wk2 Skipped list to skip new failing test.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline of svg/as-background-image/svg-as-background-6.html .
toyoshim@chromium.org [Wed, 18 Apr 2012 05:27:22 +0000 (05:27 +0000)]
Unreviewed, rebaseline of svg/as-background-image/svg-as-background-6.html .

* platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-6-expected.png: Added.
* svg/as-background-image/svg-as-background-6-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-6-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShadowRoot shouldn't be adopted by any Document.
morrita@google.com [Wed, 18 Apr 2012 04:52:47 +0000 (04:52 +0000)]
ShadowRoot shouldn't be adopted by any Document.
https://bugs.webkit.org/show_bug.cgi?id=84127

Reviewed by Dimitri Glazkov.

Source/WebCore:

ShadowRoot cannot cannot be removed from its host, which means
ShadowRoot cannot be adopted by any Document directly because the
adoptNode() tries to remove it from its parent but it doesn't make
sense for ShadowRoot.

This change adds a guard to check such a case.

Test: fast/dom/shadow/adopt-node-with-shadow-root.html

* dom/Document.cpp:
(WebCore::Document::adoptNode):

LayoutTests:

* fast/dom/shadow/adopt-node-with-shadow-root-expected.txt: Added.
* fast/dom/shadow/adopt-node-with-shadow-root.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r114406-r114417): media/video-playing-and-pause.html failing on Lion...
jer.noble@apple.com [Wed, 18 Apr 2012 04:40:44 +0000 (04:40 +0000)]
REGRESSION (r114406-r114417): media/video-playing-and-pause.html failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84226

Remove expected failing results ſtor media/video-playing-and-pause.html.

* platform/mac-wk2/media/video-playing-and-pause-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, revert temporal expectation changeset (114248)
toyoshim@chromium.org [Wed, 18 Apr 2012 04:04:23 +0000 (04:04 +0000)]
Unreviewed, revert temporal expectation changeset (114248)
https://bugs.webkit.org/show_bug.cgi?id=84024

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should not attempt to get rare case counts for op_mod on ARM
fpizlo@apple.com [Wed, 18 Apr 2012 03:54:34 +0000 (03:54 +0000)]
DFG should not attempt to get rare case counts for op_mod on ARM
https://bugs.webkit.org/show_bug.cgi?id=84218

Reviewed by Geoff Garen.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
* dfg/DFGCommon.h:
(JSC::DFG::isX86):
(DFG):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBumpPointerAllocator assumes page size is less than MINIMUM_BUMP_POOL_SIZE
commit-queue@webkit.org [Wed, 18 Apr 2012 03:42:43 +0000 (03:42 +0000)]
BumpPointerAllocator assumes page size is less than MINIMUM_BUMP_POOL_SIZE
https://bugs.webkit.org/show_bug.cgi?id=80912

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-17
Reviewed by Hajime Morita.

* wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] USPS Shipping label prints without barcode
ap@apple.com [Wed, 18 Apr 2012 03:34:06 +0000 (03:34 +0000)]
[Mac] USPS Shipping label prints without barcode
https://bugs.webkit.org/show_bug.cgi?id=84099
<rdar://problem/11133877>

Reviewed by Sam Weinig.

Use PDFDocuemnt instead of CGPDFDocument when printing PDFs, because PDFKit knows
how to draw PDF buttons, and CG does not.

* Shared/mac/PDFKitImports.h: Added.
* Shared/mac/PDFKitImports.mm: Added.
* UIProcess/API/mac/WKPrintingView.mm:
Moved code for dealing with dynamically loaded PDFKit from WKPrintingView, as we
now also need it elsewhere.

* WebKit2.xcodeproj/project.pbxproj: Added
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Rebamed to .mm.

* WebProcess/Plugins/PDF/BuiltInPDFView.h: Changed m_pdfDocument to PDFDocument.

* WebProcess/Plugins/PDF/BuiltInPDFView.mm: Copied from Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp.
(WebKit::BuiltInPDFView::pdfDocumentDidLoad):
(WebKit::BuiltInPDFView::calculateSizes):
(WebKit::BuiltInPDFView::paintContent):
Changed m_pdfDocument to PDFDocument, and updated for the changes. We still use
CGPDF when drawing to screen though, because that doesn't affect USPS.

* WebProcess/Plugins/Plugin.h: (WebKit::Plugin::pdfDocumentForPrinting): Updated
the type, and changed ifsed from CG to MAC, as we're now fully dependent on Cocoa.

* WebProcess/Plugins/PluginView.h: (WebKit::PluginView::pdfDocumentForPrinting):
Ditto.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pdfDocumentForPrintingFrame):
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::computePagesForPrinting):
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):
* WebProcess/WebPage/WebPage.h:
Moved PDF document printing code to WebPageMac.mm, as it's now Objective C.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::computePagesForPrintingPDFDocument):
(WebKit::roundCGFloat):
(WebKit::drawPDFPage): While moving, also fixed a logic error in calculating the box
(it used to intersect with an empty box).
(WebKit::WebPage::drawRectToPDFFromPDFDocument):
(WebKit::WebPage::drawPagesToPDFFromPDFDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Ensure RateLimiter waits for Swapbuffers completion
commit-queue@webkit.org [Wed, 18 Apr 2012 02:57:28 +0000 (02:57 +0000)]
[chromium] Ensure RateLimiter waits for Swapbuffers completion
https://bugs.webkit.org/show_bug.cgi?id=83649

Patch by John Bauman <jbauman@chromium.org> on 2012-04-17
Reviewed by James Robinson.

We were waiting only on the canvas context, which with the new GPU
scheduling was causing the RateLimiter not to ratelimit enough. We
need to insert no-op commands in the compositor context, so that we'll
wait for the canvas context and SwapBuffers as well.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::doNoOp):
(WebCore):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/RateLimiter.cpp:
(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::rateLimitContext):
* platform/graphics/chromium/RateLimiter.h:
(RateLimiterClient):
(WebCore):
(RateLimiter):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::forceNoOpCommand):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::forceNoOpCommand):
(WebCore):
(WebCore::CCThreadProxy::forceNoOpCommandOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSValuePool: Made identifier value cache a fixed-size array.
kling@webkit.org [Wed, 18 Apr 2012 02:49:54 +0000 (02:49 +0000)]
CSSValuePool: Made identifier value cache a fixed-size array.
<http://webkit.org/b/84219>

Reviewed by Antti Koivisto.

Change the identifier CSSPrimitiveValue cache in CSSValuePool from a HashMap to a
fixed-size array of RefPtr<CSSPrimitiveValue>s.

We have ~700 values total, so this is quite space efficient now that the CSSValuePool
is globally shared. More importantly it avoids a hash lookup every time we need an
identifier value.

* css/CSSValuePool.h:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createIdentifierValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Clean up texture ids on the impl side when losing the context
piman@chromium.org [Wed, 18 Apr 2012 00:52:40 +0000 (00:52 +0000)]
[Chromium] Clean up texture ids on the impl side when losing the context
https://bugs.webkit.org/show_bug.cgi?id=84122

Reviewed by James Robinson.

Tested by CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext.

* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::didLoseContext):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::didLoseContext):
(WebCore):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::didLoseContext):
(WebCore):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange RenderThemeChromiumSkia paint methods to use pixel snapping
eae@chromium.org [Wed, 18 Apr 2012 00:31:32 +0000 (00:31 +0000)]
Change RenderThemeChromiumSkia paint methods to use pixel snapping
https://bugs.webkit.org/show_bug.cgi?id=84175

Reviewed by Eric Seidel.

No new tests, no change in functionality.

Change RenderThemeChromiumSkia to use subpixel types and pixel snap
values just before painting.

* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
* rendering/RenderThemeChromiumSkia.h:

 2012-04-17  Levi Weintraub  <leviw@chromium.org>

Clean up outstanding LayoutUnit misuse in WebCore
https://bugs.webkit.org/show_bug.cgi?id=84209

Reviewed by Eric Seidel.

Small changes to a handful of files to prepare trunk for FractionalLayoutUnits.
For more details, see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): minimumValueForLength preserves
sub-pixel precision, so we should avoid unnecessarily using integers.
* platform/graphics/FractionalLayoutPoint.h:
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint): Adding an explicit constructor from
FractionalLayoutSizes. This mirrors a method in IntPoint.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder): The rects that change come from roundedRects,
which are already pixel-snapped.
* rendering/RenderBoxModelObject.h: Removing a comment that is no longer applicable.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Since we layout tables using integers, we
need to explicitly calculate the width to be integral as well to avoid pushing the next element
over by a pixel that we won't later paint with our own box decorations.
* rendering/RenderText.h:
(RenderText): Correcting an unfortunate mismatch between in the return value of linesBoundingBox
between the header and implementation.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedBorderFor): We were incorrectly not using the snapped border
rect to pass to calcRadiiFor (which takes an IntRect). Correcting this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago 2012-04-17 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 18 Apr 2012 00:30:04 +0000 (00:30 +0000)]
 2012-04-17  Levi Weintraub  <leviw@chromium.org>

Clean up outstanding LayoutUnit misuse in WebCore
https://bugs.webkit.org/show_bug.cgi?id=84209

Reviewed by Eric Seidel.

Small changes to a handful of files to prepare trunk for FractionalLayoutUnits.
For more details, see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): minimumValueForLength preserves
sub-pixel precision, so we should avoid unnecessarily using integers.
* platform/graphics/FractionalLayoutPoint.h:
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint): Adding an explicit constructor from
FractionalLayoutSizes. This mirrors a method in IntPoint.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder): The rects that change come from roundedRects,
which are already pixel-snapped.
* rendering/RenderBoxModelObject.h: Removing a comment that is no longer applicable.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Since we layout tables using integers, we
need to explicitly calculate the width to be integral as well to avoid pushing the next element
over by a pixel that we won't later paint with our own box decorations.
* rendering/RenderText.h:
(RenderText): Correcting an unfortunate mismatch between in the return value of linesBoundingBox
between the header and implementation.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedBorderFor): We were incorrectly not using the snapped border
rect to pass to calcRadiiFor (which takes an IntRect). Correcting this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobuild-webkit: make ninja work with chromium linux
dpranke@chromium.org [Wed, 18 Apr 2012 00:29:24 +0000 (00:29 +0000)]
build-webkit: make ninja work with chromium linux
https://bugs.webkit.org/show_bug.cgi?id=84213

Reviewed by Eric Seidel.

Fix typos so that build-webkit will use ninja to
build chromium if a build.ninja file exists and is up-to-date.

* Scripts/webkitdirs.pm:
(determineIsChromiumNinja):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnsure CSSParser member variables are initialized.
macpherson@chromium.org [Wed, 18 Apr 2012 00:24:06 +0000 (00:24 +0000)]
Ensure CSSParser member variables are initialized.
https://bugs.webkit.org/show_bug.cgi?id=84205

Reviewed by Andreas Kling.

No new tests / code cleanup only.

* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(114172): Use after free in CustomFilterProgram::notifyClients
achicu@adobe.com [Wed, 18 Apr 2012 00:19:40 +0000 (00:19 +0000)]
Regression(114172): Use after free in CustomFilterProgram::notifyClients
https://bugs.webkit.org/show_bug.cgi?id=84000

Reviewed by Dean Jackson.

The function returned early and the shaders didn't have a chance to be saved. Moving
those two lines before the return false just to make sure that FilterEffectRenderer never adds
itself as a client for a shader without keeping track of that.

No new tests. The problem reproduces with existing tests.
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/effect-custom-combined-missing.html

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRe-enable W3C canPlayType() tests on Chromium
commit-queue@webkit.org [Tue, 17 Apr 2012 23:44:22 +0000 (23:44 +0000)]
Re-enable W3C canPlayType() tests on Chromium
https://bugs.webkit.org/show_bug.cgi?id=84164

They use the new expectations override from changeset 112937 and pass after http://crrev.com/132463.

Unreviewed, layout test expectations update.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-17

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r114206): fast/harness/use-page-cache.html tests failing on Lion Debug...
jer.noble@apple.com [Tue, 17 Apr 2012 23:26:58 +0000 (23:26 +0000)]
REGRESSION (r114206): fast/harness/use-page-cache.html tests failing on Lion Debug (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84206

Remove expected failing test results for fast/harness/use-page-cache.html.

* platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor
commit-queue@webkit.org [Tue, 17 Apr 2012 23:26:02 +0000 (23:26 +0000)]
IndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor
https://bugs.webkit.org/show_bug.cgi?id=60746

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Ojan Vafai.

Source/WebCore:

When iterating backwards with PREV_NO_DUPLICATE, keep walking past
the 'prev' key until it changes, then walk forward one time. This
covers the object store and index cases.

Test: storage/indexeddb/mozilla/index-prev-no-duplicate.html

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):

LayoutTests:

Test for PREV_NO_DUPLICATE.

* storage/indexeddb/cursor-prev-no-duplicate.html: Added.
* storage/indexeddb/cursor-prev-no-duplicate.txt: Added.
* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt: Added.
* storage/indexeddb/mozilla/index-prev-no-duplicate.html: Added.
* storage/indexeddb/resources/cursor-prev-no-duplicate.js: Added.
(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(runAllTests):
(waitFor):
(complete.fireCallback):
(complete):
(testFarRangeCursor):
(makeOpenKeyCursor):
(runTest.trans.oncomplete):
(runTest.testFunction):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, unskip some WebSocket worker tests that should not be skipped.
yutak@chromium.org [Tue, 17 Apr 2012 23:20:45 +0000 (23:20 +0000)]
Unreviewed, unskip some WebSocket worker tests that should not be skipped.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoneed to rebaseline after skia 3695 lands
reed@google.com [Tue, 17 Apr 2012 23:17:49 +0000 (23:17 +0000)]
need to rebaseline after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84184

Unreviewed. expectations change only.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCaret is not rendered properly inside an input element with text-indent
yi.4.shen@nokia.com [Tue, 17 Apr 2012 23:10:21 +0000 (23:10 +0000)]
Caret is not rendered properly inside an input element with text-indent
https://bugs.webkit.org/show_bug.cgi?id=82688

Reviewed by Ryosuke Niwa.

For an empty input element, there is no RenderText. Instead, RenderBlock::localCaretRect provides
the caret position for rendering the caret in the empty input element. To get correct caret rect,
textIndentOffset() should be used to adjust the caret's position.

Source/WebCore:

Test: editing/style/text-indent.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect):

LayoutTests:

* editing/style/text-indent-expected.txt: Added.
* editing/style/text-indent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd caching to the flakiness dashboard json files
ojan@chromium.org [Tue, 17 Apr 2012 23:08:05 +0000 (23:08 +0000)]
Add caching to the flakiness dashboard json files
https://bugs.webkit.org/show_bug.cgi?id=84198

Reviewed by Dirk Pranke.

* TestResultServer/handlers/testfilehandler.py:
(GetFile._get_file_list):
(GetFile._get_file_content):
(GetFile._get_file_content_from_key):
(GetFile._get_test_list_json):
(GetFile._serve_json):
Add a Last-Modified header and handle If-Modified-Since headers.
(GetFile.get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix Windows build.
fpizlo@apple.com [Tue, 17 Apr 2012 23:03:40 +0000 (23:03 +0000)]
Attempt to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[MutationObservers] enable V8RecursionScope debug ASSERT()
rafaelw@chromium.org [Tue, 17 Apr 2012 23:02:44 +0000 (23:02 +0000)]
[MutationObservers] enable V8RecursionScope debug ASSERT()
https://bugs.webkit.org/show_bug.cgi?id=84094

Reviewed by Ojan Vafai.

This patch enables the ASSERT() which enforces usage of
V8RecursionScope.

* src/WebKit.cpp:
(WebKit::assertV8RecursionScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIt should be possible to create an inheritorID for the global this object without...
fpizlo@apple.com [Tue, 17 Apr 2012 23:01:14 +0000 (23:01 +0000)]
It should be possible to create an inheritorID for the global this object without crashing
https://bugs.webkit.org/show_bug.cgi?id=84200
<rdar://problem/11251082>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject):
* runtime/JSGlobalThis.h:
(JSC::JSGlobalThis::unwrappedObject):
(JSGlobalThis):
* runtime/JSObject.cpp:
(JSC::JSObject::createInheritorID):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::resetInheritorID):

Source/WebCore:

No new tests, because the circumstances necessary to make this happen are rather hairy.

* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct.
macpherson@chromium.org [Tue, 17 Apr 2012 22:56:23 +0000 (22:56 +0000)]
Make CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct.
https://bugs.webkit.org/show_bug.cgi?id=83544

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

The code as it stands appears to be correct, but static analysis was concerned that value could become null.
This patch adds a null check and ASSERT_NOT_REACHED() to make the code more obviously correct.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix gyp for WebFilterOperation.h and WebFilterOperations.h
danakj@chromium.org [Tue, 17 Apr 2012 22:48:21 +0000 (22:48 +0000)]
[chromium] Fix gyp for WebFilterOperation.h and WebFilterOperations.h
https://bugs.webkit.org/show_bug.cgi?id=84182

Reviewed by James Robinson.

Source/Platform:

* Platform.gypi:

Source/WebKit/chromium:

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit2: Need a client callback for when the user tires to interact with an...
andersca@apple.com [Tue, 17 Apr 2012 22:43:44 +0000 (22:43 +0000)]
Source/WebKit2: Need a client callback for when the user tires to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>

Reviewed by Andreas Kling.

Add a interactionOccurredWhileProcessUnresponsive callback that's called when the unresponsiveness timer
fires while it's already unresponsive.

* UIProcess/API/C/WKPage.h:
* UIProcess/ResponsivenessTimer.cpp:
(WebKit):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
* UIProcess/ResponsivenessTimer.h:
(Client):
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit):
(WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit):
* UIProcess/WebProcessProxy.h:
(WebProcessProxy):

Tools: Need a client callback for when the user tries to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>

Reviewed by Andreas Kling.

Add new client functions.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add TextureUploader which allows us to use persistent GC3D state for textu...
commit-queue@webkit.org [Tue, 17 Apr 2012 22:42:11 +0000 (22:42 +0000)]
[Chromium] Add TextureUploader which allows us to use persistent GC3D state for texture uploads.
https://bugs.webkit.org/show_bug.cgi?id=83972

Patch by David Reveman <reveman@chromium.org> on 2012-04-17
Reviewed by James Robinson.

Source/WebCore:

Add TextureUploader class that allows us to add persistent GC3D state to the upload machinery.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::textureUploader):
(LayerRendererChromium):
* platform/graphics/chromium/TextureUploader.cpp: Added.
(WebCore):
(WebCore::AcceleratedTextureUploader::AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::~AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::uploadTexture):
* platform/graphics/chromium/TextureUploader.h: Added.
(WebCore):
(TextureUploader):
(WebCore::TextureUploader::~TextureUploader):
(AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::create):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(WebCore):
(CCTextureUpdater):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

Source/WebKit/chromium:

* tests/CCTiledLayerTestCommon.h:
(FakeTextureUploader):
(WebKitTests::FakeTextureUploader::uploadTexture):
(WebKitTests):
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Mark test failing IMAGE: svg/transforms/transform-origin-css-property...
scheib@chromium.org [Tue, 17 Apr 2012 22:37:28 +0000 (22:37 +0000)]
[Chromium] Mark test failing IMAGE: svg/transforms/transform-origin-css-property.xhtml

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up CSSParser::parseFillRepeat().
macpherson@chromium.org [Tue, 17 Apr 2012 22:16:55 +0000 (22:16 +0000)]
Clean up CSSParser::parseFillRepeat().
https://bugs.webkit.org/show_bug.cgi?id=83547

Reviewed by Kentaro Hara.

Removed multiple unnecessary calls to m_valueList->current().
Restructured logic for parsing second value to make it clearer.

No new tests / code cleanup only.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillRepeat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
dpranke@chromium.org [Tue, 17 Apr 2012 22:09:26 +0000 (22:09 +0000)]
nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84190

Reviewed by Ojan Vafai.

LayoutTestHelper would exit when the user typed ctrl-c, but we
would attempt to write to it to shut it down, generating an
IOError.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.stop_helper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorename --experimental-fully-parallel
dpranke@chromium.org [Tue, 17 Apr 2012 22:04:30 +0000 (22:04 +0000)]
rename --experimental-fully-parallel
https://bugs.webkit.org/show_bug.cgi?id=84188

Reviewed by Ojan Vafai.

I thought this was done long ago; rename
--experimental-fully-parallel to just --fully-parallel and
remove the --no- switch that AFAIK no one uses.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Pass Isolate to toV8Slow()
haraken@chromium.org [Tue, 17 Apr 2012 22:03:45 +0000 (22:03 +0000)]
[V8] Pass Isolate to toV8Slow()
https://bugs.webkit.org/show_bug.cgi?id=84173

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to toV8Slow().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the ACCELERATED_COMPOSITING code to not expose RenderLayer outside rendering
jchaffraix@webkit.org [Tue, 17 Apr 2012 21:51:22 +0000 (21:51 +0000)]
Fix the ACCELERATED_COMPOSITING code to not expose RenderLayer outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83816

Reviewed by James Robinson.

No change in behavior expected.

This code adds several functions on RenderBoxModelObject to forward
to the associated layer. This removes the RenderLayer dependencies
at the call sites.

Currently only RenderBoxModelObject can be hardware accelerated as
we need a RenderLayer, this looks like the best place to put those
new functions.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::contentChanged):
(WebCore::RenderBoxModelObject::hasAcceleratedCompositing):
(WebCore::RenderBoxModelObject::startTransition):
(WebCore::RenderBoxModelObject::transitionPaused):
(WebCore::RenderBoxModelObject::transitionFinished):
(WebCore::RenderBoxModelObject::startAnimation):
(WebCore::RenderBoxModelObject::animationPaused):
(WebCore::RenderBoxModelObject::animationFinished):
(WebCore::RenderBoxModelObject::suspendAnimations):
* rendering/RenderBoxModelObject.h:
Added the previous functions to hide the layer need.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasAcceleratedCompositing):
* rendering/RenderLayer.h:
Removed the previous method as it was superseeded by the
one on RenderBoxModelObject. Also moved the ContentChangeType
enumaration.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentChanged):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
Updated after the ContentChangeType enumaration move.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::didDraw):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::reshape):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::freezeAtTime):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::startAnimation):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::endAnimation):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::startAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::imageChanged):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::notifyFinished):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
Updated all those call sites to use the new functions. Also
removed unneeded RenderLayer.h include as we went.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG and LLInt should not clobber the frame pointer on ARMv7
fpizlo@apple.com [Tue, 17 Apr 2012 21:41:17 +0000 (21:41 +0000)]
DFG and LLInt should not clobber the frame pointer on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84185
<rdar://problem/10767252>

Reviewed by Gavin Barraclough.

Changed LLInt to use a different register. Changed DFG to use one fewer
registers. We should revisit this and switch the DFG to use a different
register instead of r7, but we can do that in a subsequent step since
the performance effect is tiny.

* dfg/DFGGPRInfo.h:
(GPRInfo):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
* offlineasm/armv7.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago-webkit-mask-box-image does not draw when layer tree flattening is enabled
aestes@apple.com [Tue, 17 Apr 2012 21:32:37 +0000 (21:32 +0000)]
-webkit-mask-box-image does not draw when layer tree flattening is enabled
https://bugs.webkit.org/show_bug.cgi?id=84111

Reviewed by Simon Fraser.

No new tests since taking pixel test results with
PaintBehaviorFlattenCompositingLayers set is not currently supported.
<https://bugs.webkit.org/show_bug.cgi?id=84110> tracks fixing this.

When painting mask images, we should take the non-composited path if
layers are being flattened.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintMask):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintMaskImages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRollout r114404 as it broke a couple of chromium builds.
eae@chromium.org [Tue, 17 Apr 2012 20:56:12 +0000 (20:56 +0000)]
Rollout r114404 as it broke a couple of chromium builds.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago`localStorage.setItem` can overwrite `localStorage` methods
benm@google.com [Tue, 17 Apr 2012 20:32:22 +0000 (20:32 +0000)]
`localStorage.setItem` can overwrite `localStorage` methods
https://bugs.webkit.org/show_bug.cgi?id=30996

Source/WebCore:

Update the JSC and V8 bindings such that if the name of the DOM
Storage property being retrieved is a match for a property in the
prototype, always return the prototype version. If there is a DOM
Storage key of the same name, it can still be retrieved via the
getItem method. This prevents storage methods from being
accidentally hidden. This brings WebKit behavior in line with the
de facto standard implemented by FireFox and IE.

Reviewed by Kentaro Hara.

Test: storage/domstorage/storage-functions-not-overwritten.html

* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::nameGetter):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyGetter):

LayoutTests:

Add a test to verify that setting a DOM Storage key with the same name
as a function on the Storage object does not prevent that function
being called, but also that it can still be retrieved via the getItem
function.

Reviewed by Kentaro Hara.

* storage/domstorage/script-tests/storage-functions-not-overwritten.js: Added.
(doWedgeThySelf):
(testStorage):
(runTest):
* storage/domstorage/storage-functions-not-overwritten-expected.txt: Added.
* storage/domstorage/storage-functions-not-overwritten.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline minor text pixel differences in bidi-menulist-expected.
scheib@chromium.org [Tue, 17 Apr 2012 20:25:30 +0000 (20:25 +0000)]
[Chromium] Rebaseline minor text pixel differences in bidi-menulist-expected.

Unreviewed.

* platform/chromium-mac-leopard/fast/text/international/bidi-menulist-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Chromium/Windows build broken by r114404.
eae@chromium.org [Tue, 17 Apr 2012 20:21:53 +0000 (20:21 +0000)]
Fix Chromium/Windows build broken by r114404.

* platform/FractionalLayoutUnit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReorganise Chromium test_expectations to group SVG expectations.
schenney@chromium.org [Tue, 17 Apr 2012 20:08:11 +0000 (20:08 +0000)]
Reorganise Chromium test_expectations to group SVG expectations.

Unreviewed Chromium expectations change.

This is done to make future maintenance easier.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEFL's LayoutTestController does not implement callShouldCloseOnWebView
commit-queue@webkit.org [Tue, 17 Apr 2012 20:05:57 +0000 (20:05 +0000)]
EFL's LayoutTestController does not implement callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=82301

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Martin Robinson.

Source/WebKit/efl:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related
test to be removed from the skip list.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::callShouldCloseOnWebView):

LayoutTests:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Performance][V8] Skip Isolate look-up to find StringCache
haraken@chromium.org [Tue, 17 Apr 2012 20:05:22 +0000 (20:05 +0000)]
[Performance][V8] Skip Isolate look-up to find StringCache
https://bugs.webkit.org/show_bug.cgi?id=84103

Reviewed by Nate Chapin.

This patch improves the performance of a lot of DOM attribute
getters that return a string.

- Improves the performance of Dromaeo/dom-attr.html(element.property)
  by 27.7%.
- Improves the performance of Dromaeo/dom-attr.html(getAttribute)
  by 10.6%.
- Improves the performance of div.id, div.className,
  div.nodeName, text.nodeValue, text.textContent by 12% -- 21%.

The followings are the test results in my Linux desktop.

Performance test: Dromaeo/dom-attr.html
Total:                     674.64runs/s ->  707.03runs/s (+ 4.8%)
getAttribute:             1537.60runs/s -> 1700.20runs/s (+10.6%)
element.property:         1389.00runs/s -> 1774.20runs/s (+27.7%)
setAttribute:              538.88runs/s ->  548.87runs/s (+ 1.9%)
element.property = value:  644.07runs/s ->  656.67runs/s (+ 2.0%)
element.expando = value:   219.76runs/s ->  207.14runs/s (- 6.8%)
element.expando:           578.77runs/s ->  554.67runs/s (- 4.2%)

Performance test: https://bugs.webkit.org/attachment.cgi?id=137440
div.id:           30.70ns -> 26.70ns (+15%)
div.className:    31.10ns -> 26.40ns (+18%)
div.nodeName:     37.70ns -> 33.00ns (+14%)
text.nodeValue:   31.40ns -> 25.90ns (+21%)
text.textContent: 51.50ns -> 45.90ns (+12%)

Previously V8 bindings need to look up an Isolate to find
an Isolate-local StringCache. This patch skips the look-up
by getting the Isolate from AccessorInfo.GetIsolate()
or Arguments.GetIsolate().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
* bindings/v8/V8Binding.h:
(WebCore::v8ExternalString): Make 'isolate' an optional argument.
Ideally we want to make 'isolate' a non-optional argument,
but it is difficult to rewrite all v8ExternalString() callers
at a breath. We can rewrite them incrementally.
(WebCore::v8String): Ditto.
(WebCore::v8StringOrNull): Ditto.
(WebCore::v8StringOrUndefined): Ditto.
(WebCore::v8StringOrFalse): Ditto.

* bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just...
commit-queue@webkit.org [Tue, 17 Apr 2012 20:01:15 +0000 (20:01 +0000)]
[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one
https://bugs.webkit.org/show_bug.cgi?id=84052

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit the "load,finished" signal from dispatchDidFinishLoad() / instead of
postProgressFinishedNotification() in order to send notifications all frames,
not just the main one.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

LayoutTests:

Unskip EFL test cases which rely on the DumpRenderTree support for
LayoutTestController's dumpFrameLoadCallbacks() and expect notifications for other
frame than the main one.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Add setting API to enable/disable XSSAuditor
commit-queue@webkit.org [Tue, 17 Apr 2012 19:56:47 +0000 (19:56 +0000)]
[EFL] Add setting API to enable/disable XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=83281

Source/WebKit/efl:

Add setting API to enable or disable WebKit's XSSAuditor to protect
from reflective cross-site scripting attacks. Also, emit the signal
'xss,detected' and provide addition information received from
XSSAuditor when reflected XSS is encountered in the page.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::didDetectXSS):
* ewk/ewk_frame.cpp:
(ewk_frame_xss_detected):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_xss_auditor_get):
(ewk_view_setting_enable_xss_auditor_set):
* ewk/ewk_view.h:

Tools:

Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
'xss,detected' in DRT to enable a test, which is expecting a line containing
'didDetectXSS' in the output when reflected XSS is encountered in the page.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onDidDetectXSS):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

Unskip tests in http/tests/security/xssAuditor

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in invalid index for _textMarkerForIndex
cfleizach@apple.com [Tue, 17 Apr 2012 19:48:15 +0000 (19:48 +0000)]
Crash in invalid index for _textMarkerForIndex
https://bugs.webkit.org/show_bug.cgi?id=84104

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):

LayoutTests:

* platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt: Added.
* platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTML5 Video Full Screen button broken (looks like white square)
jer.noble@apple.com [Tue, 17 Apr 2012 19:44:08 +0000 (19:44 +0000)]
HTML5 Video Full Screen button broken (looks like white square)
https://bugs.webkit.org/show_bug.cgi?id=84101

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests; updated platform results which were previously rebaselined.

Use the correct CSS keyword for the -webkit-appearance of the full screen button.

* css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

* platform/mac/media/controls-after-reload-expected.png:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.png:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.png:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.png:
* platform/mac/media/video-playing-and-pause-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG should support transform-origin and relative values
schenney@chromium.org [Tue, 17 Apr 2012 19:33:51 +0000 (19:33 +0000)]
SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Unreviewed Chromium expectations update.

* platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Added.
* platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPaddings and borders on root SVG element with viewbox causes child SVG elements to...
schenney@chromium.org [Tue, 17 Apr 2012 19:30:21 +0000 (19:30 +0000)]
Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-mac/svg/custom/circle-move-invalidation-expected.png: Added.
* platform/chromium-win/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-win/svg/custom/circle-move-invalidation-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake sure that the layer hosting mode is kept up to date if it changes before the...
andersca@apple.com [Tue, 17 Apr 2012 19:24:33 +0000 (19:24 +0000)]
Make sure that the layer hosting mode is kept up to date if it changes before the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=84180
<rdar://problem/11265113>

Reviewed by Andreas Kling.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoonclick is not reliable for transformed SVG elements
schenney@chromium.org [Tue, 17 Apr 2012 19:23:35 +0000 (19:23 +0000)]
onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
* platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
* platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
* platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agouse after free in JSC::DFG::Node::op / JSC::DFG::ByteCodeParser::flushArgument
fpizlo@apple.com [Tue, 17 Apr 2012 19:22:29 +0000 (19:22 +0000)]
use after free in JSC::DFG::Node::op / JSC::DFG::ByteCodeParser::flushArgument
https://bugs.webkit.org/show_bug.cgi?id=83942
<rdar://problem/11247370>

Reviewed by Gavin Barraclough.

Don't use references to the graph after resizing the graph.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushArgument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogetCTM() on SVG root element with borders, paddings, and viewbox returns incorrect...
schenney@chromium.org [Tue, 17 Apr 2012 19:19:13 +0000 (19:19 +0000)]
getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-mac-leopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
* platform/chromium-mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-win/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Cleanup of outdated test expectations
schenney@chromium.org [Tue, 17 Apr 2012 19:15:30 +0000 (19:15 +0000)]
[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: stub getKey/getObject interfaces for IDBKeyRange
commit-queue@webkit.org [Tue, 17 Apr 2012 19:11:41 +0000 (19:11 +0000)]
IndexedDB: stub getKey/getObject interfaces for IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=84089

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Dimitri Glazkov.

Added stub methods on WebIDBIndex.h to cleanly land
https://bugs.webkit.org/show_bug.cgi?id=83638

* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::getObject):
(WebKit::WebIDBIndex::getKey):
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::getObject):
(WebKit):
(WebKit::WebIDBIndexImpl::getKey):
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux
schenney@chromium.org [Tue, 17 Apr 2012 19:09:35 +0000 (19:09 +0000)]
[chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=53378

Unreviewed expectations update after the fix went in.

* platform/chromium-linux-x86/svg/zoom: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-win-xp/svg/zoom: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFramesniffing defense is too aggressive.
tsepez@chromium.org [Tue, 17 Apr 2012 19:03:42 +0000 (19:03 +0000)]
Framesniffing defense is too aggressive.
https://bugs.webkit.org/show_bug.cgi?id=83721

Reviewed by James Robinson.

Source/WebCore:

The RenderLayer code currently propagates scroll position to parent frames
without any cross-origin checks.  This gives it a quick origin boundary check
that is set by FrameLoader only when performing a fragment navigation.  This
allows us to safely relax the restriction on not scrolling at load time in
FrameLoader since the safe thing will happen later on at scroll time.

Test: http/tests/navigation/anchor-frames-same-origin.html

* dom/Document.cpp:
(WebCore::Document::findUnsafeParentScrollPropagationBoundary):
* dom/Document.h:
(Document):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::scrollToFragmentWithParentBoundary):
* loader/FrameLoader.h:
(FrameLoader):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
* page/FrameView.h:
(WebCore::FrameView::safeToPropagateScrollToParent):
(WebCore::FrameView::setSafeToPropagateScrollToParent):
(FrameView):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests:

* http/tests/inspector/resource-parameters-expected.txt:
* http/tests/navigation/anchor-frames-cross-origin-expected.txt:
* http/tests/navigation/anchor-frames-cross-origin.html:
* http/tests/navigation/anchor-frames-same-origin-expected.txt: Added.
* http/tests/navigation/anchor-frames-same-origin.html: Added.
* http/tests/navigation/resources/frame-with-anchor-cross-origin.html:
* http/tests/navigation/resources/frame-with-anchor-same-origin.html: Added.
* http/tests/navigation/resources/grandchild-with-anchor.html: Added.
* http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
* http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoArray.prototype.toString should be generic
barraclough@apple.com [Tue, 17 Apr 2012 18:58:26 +0000 (18:58 +0000)]
Array.prototype.toString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
    - check for join function, use fast case if base object is array & join is present & default.
* runtime/CommonIdentifiers.h:
    - added 'join'.

LayoutTests:

* fast/js/array-functions-non-arrays-expected.txt:
    - check in new results
* fast/js/array-prototype-properties-expected.txt:
    - new more detailed error message.
* fast/js/script-tests/array-functions-non-arrays.js:
    - added new test cases, fix incorrect one.
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.2_Array_prototype_toString/S15.4.4.2_A2_T1-expected.txt:
    - check in failing result (test is wrong)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd size_t versions of multiplication and division operators to FractionalLayoutUnit
eae@chromium.org [Tue, 17 Apr 2012 18:51:50 +0000 (18:51 +0000)]
Add size_t versions of multiplication and division operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=83848

Reviewed by Julien Chaffraix.

Add size_t versions of operator* and operator/ for platforms where there
is no ambiguity between unsigned int and size_t.

No new tests, no new functionality.

* platform/FractionalLayoutUnit.h:
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):
(WebCore::operator*):
(WebCore::operator/):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate long-failing Chromium expectations.
schenney@chromium.org [Tue, 17 Apr 2012 18:45:47 +0000 (18:45 +0000)]
Update long-failing Chromium expectations.

Unreviewed Chromium expectation update.

There is some chance that the background test is flaky, as many others are.

* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExiting full screen video brings the wrong Safari window to the foreground
jer.noble@apple.com [Tue, 17 Apr 2012 18:35:48 +0000 (18:35 +0000)]
Exiting full screen video brings the wrong Safari window to the foreground
https://bugs.webkit.org/show_bug.cgi?id=83936

Reviewed by Adele Peterson.

Tell the original webView's window to makeKeyAndOrderFront once the exit
animation completes.

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController finishedExitFullScreenAnimation:]):

Source/WebKit2:

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Add an optional Isolate argument to toV8().
haraken@chromium.org [Tue, 17 Apr 2012 18:21:28 +0000 (18:21 +0000)]
[V8] Add an optional Isolate argument to toV8().
https://bugs.webkit.org/show_bug.cgi?id=84161

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to toV8().
After rewriting all toV8() callers so that they pass Isolate,
I will make the Isolate argument non-optional.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
Modified as described above.
(GenerateHeader):
(NativeToJSValue):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):

* bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(WebCore):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate Chromium test expectations for long failing tests.
schenney@chromium.org [Tue, 17 Apr 2012 18:20:54 +0000 (18:20 +0000)]
Update Chromium test expectations for long failing tests.

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/chromium-linux/svg/carto.net/combobox-expected.png: Added.
* platform/chromium-linux/svg/carto.net/combobox-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Create baselines for tests related to caret behaviour
commit-queue@webkit.org [Tue, 17 Apr 2012 18:19:25 +0000 (18:19 +0000)]
[EFL] Create baselines for tests related to caret behaviour
https://bugs.webkit.org/show_bug.cgi?id=83277

Unreviewed, EFL baselines for tests related to cursor
positioning behaviour.

Adding baselines and unskipping tests related to cursor
positioning behaviour after r114250.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17

* platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
* platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
* platform/efl/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
* platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofill-opacity does not render properly on chromium mac
schenney@chromium.org [Tue, 17 Apr 2012 18:11:20 +0000 (18:11 +0000)]
fill-opacity does not render properly on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=78624

Unreviewed expectations update after this change.

* platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Removed.
* platform/chromium-mac/svg/text/text-fill-opacity-expected.png: Added.
* platform/chromium-win/svg/text/text-fill-opacity-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Fix build break when FULLSCREEN_API is enabled.
commit-queue@webkit.org [Tue, 17 Apr 2012 18:01:42 +0000 (18:01 +0000)]
[EFL][WK2] Fix build break when FULLSCREEN_API is enabled.
https://bugs.webkit.org/show_bug.cgi?id=84142

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-04-17
Reviewed by Martin Robinson.

Create a cpp file needed to build EFL port with FULLSCREEN_API.

* PlatformEfl.cmake: Added WebFullScreenManagerProxyEfl.cpp to build list.
* UIProcess/WebFullScreenManagerProxy.h:
(WebKit):
* UIProcess/efl/WebFullScreenManagerProxyEfl.cpp: Added.
(WebKit):
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::close):
(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove fast/forms/implicit-submission.html from flaky expectations,
dglazkov@chromium.org [Tue, 17 Apr 2012 17:59:18 +0000 (17:59 +0000)]
[Chromium] Remove fast/forms/implicit-submission.html from flaky expectations,
because it was fixed in r113808.

* platform/chromium/test_expectations.txt: Removed flaky expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline after Skia changes (CR105305)
schenney@chromium.org [Tue, 17 Apr 2012 17:57:23 +0000 (17:57 +0000)]
[Chromium] Rebaseline after Skia changes (CR105305)
https://bugs.webkit.org/show_bug.cgi?id=84165

Unreviewed Chromium expectations update.

* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
* platform/chromium-linux/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
* platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-linux/svg/text/selection-background-color-expected.png:
* platform/chromium-linux/svg/text/selection-styles-expected.png:
* platform/chromium-linux/svg/text/text-gradient-positioning-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
* platform/chromium-mac-leopard/svg/css/composite-shadow-text-expected.png:
* platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/text/selection-styles-expected.png:
* platform/chromium-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
* platform/chromium-mac/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-mac/svg/css/text-gradient-shadow-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/text/selection-styles-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/text/text-gradient-positioning-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-win-vista/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-win-xp/svg/css/text-gradient-shadow-expected.png: Added.
* platform/chromium-win/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew baselines for crbug 104128
schenney@chromium.org [Tue, 17 Apr 2012 17:24:58 +0000 (17:24 +0000)]
new baselines for crbug 104128
https://bugs.webkit.org/show_bug.cgi?id=72746

Unreviewed Chromium expectations update, just for SVG files.

* platform/chromium-mac/svg/css/shadow-with-large-radius-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/css/shadow-with-negative-offset-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
* platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
* platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
* platform/gtk/svg/css/shadow-with-large-radius-expected.txt: Removed.
* platform/gtk/svg/css/shadow-with-negative-offset-expected.txt: Removed.
* platform/mac/svg/css/shadow-with-large-radius-expected.txt: Removed.
* platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Removed.
* platform/qt/svg/css/shadow-with-large-radius-expected.txt: Removed.
* platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Removed.
* svg/css/shadow-with-large-radius-expected.txt: Added.
* svg/css/shadow-with-negative-offset-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move heap snapshot data grids into their own file
yurys@chromium.org [Tue, 17 Apr 2012 17:17:59 +0000 (17:17 +0000)]
Web Inspector: move heap snapshot data grids into their own file
https://bugs.webkit.org/show_bug.cgi?id=84160

Moved heap snapshot data grids into a separate file.

Reviewed by Pavel Feldman.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/DataGrid.js:
* inspector/front-end/HeapSnapshotDataGrids.js: Added.
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
* inspector/front-end/HeapSnapshotView.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoScript make_names.pl should generate consistent .h & .cpp files
commit-queue@webkit.org [Tue, 17 Apr 2012 17:12:19 +0000 (17:12 +0000)]
Script make_names.pl should generate consistent .h & .cpp files
https://bugs.webkit.org/show_bug.cgi?id=84140

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-17
Reviewed by Kentaro Hara.

Added a newline character and removed ';' after the DEFINE_GLOBAL

No test cases required for this change.

* dom/make_names.pl:
(printNamesCppFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Add webkitSourceAddId() & webkitSourceRemoveId() to HTMLMediaElement
commit-queue@webkit.org [Tue, 17 Apr 2012 17:09:40 +0000 (17:09 +0000)]
Source/WebCore: Add webkitSourceAddId() & webkitSourceRemoveId() to HTMLMediaElement
and propagate calls to the MediaPlayerPrivate interface.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

Test: http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html

* html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::isValidSourceId):
(WebCore::HTMLMediaElement::webkitSourceAddId):
(WebCore::HTMLMediaElement::webkitSourceRemoveId):
(WebCore::HTMLMediaElement::setSourceState):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::sourceAddId):
(WebCore::NullMediaPlayerPrivate::sourceRemoveId):
(WebCore):
(WebCore::MediaPlayer::sourceAddId):
(WebCore::MediaPlayer::sourceRemoveId):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::sourceAddId):
(WebCore::MediaPlayerPrivateInterface::sourceRemoveId):

Source/WebKit/chromium: Add sourceAddId() & sourceRemoveId() stubs for Chromium.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

* public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::sourceAddId):
(WebKit::WebMediaPlayer::sourceRemoveId):
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::sourceAddId):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceRemoveId):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

LayoutTests: Add LayoutTests for new webkitSourceAddId() & webkitSourceRemoveId() methods.
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

* http/tests/media/media-source/webm/video-media-source-add-and-remove-ids-expected.txt: Added.
* http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Refactor the gesture recognizers
abecsi@webkit.org [Tue, 17 Apr 2012 16:41:29 +0000 (16:41 +0000)]
[Qt][WK2] Refactor the gesture recognizers
https://bugs.webkit.org/show_bug.cgi?id=83044

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

This patch implements a simple decision tree in the web page event handler
on the basis of how many active touch points the current touch event has.

Active touch points are pressed, moved or stationary and the number of these
fully determine which gesture recognizer should be updated, cancelled or
finished.

This new structure makes the internal states of the pinch and pan gesture
recognizers independent from the event type, thus makes it possible to handle
the transitions between these gestures in one centralized place which reduces
code duplication and complexity and fixes some issues regarding incorrectly
handled transitions.

* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit):
(WebKit::QtPanGestureRecognizer::cancel):
* UIProcess/qt/QtPanGestureRecognizer.h:
(QtPanGestureRecognizer):
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit):
(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
* UIProcess/qt/QtPinchGestureRecognizer.h:
(QtPinchGestureRecognizer):
* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::cancel):
(WebKit):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):
* UIProcess/qt/QtTapGestureRecognizer.h:
(QtTapGestureRecognizer):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [CRASH] InspectorDOMAgent::didInsertDOMNode() on page reload with...
apavlov@chromium.org [Tue, 17 Apr 2012 16:31:01 +0000 (16:31 +0000)]
Web Inspector: [CRASH] InspectorDOMAgent::didInsertDOMNode() on page reload with open Inspector
https://bugs.webkit.org/show_bug.cgi?id=84154

Source/WebCore:

Check that a node inserted actually has a parent.

Reviewed by Yury Semikhatsky.

Test: inspector/elements/elements-panel-reload-assert.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didInsertDOMNode):

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/elements/elements-panel-reload-assert-expected.txt: Added.
* inspector/elements/elements-panel-reload-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
commit-queue@webkit.org [Tue, 17 Apr 2012 16:26:48 +0000 (16:26 +0000)]
[Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
https://bugs.webkit.org/show_bug.cgi?id=77533

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-17
Reviewed by Simon Hausmann.

Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
the corresponding parameter to the buildQMakeProjects function.

* Scripts/build-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
commit-queue@webkit.org [Tue, 17 Apr 2012 16:13:19 +0000 (16:13 +0000)]
[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit "load,started" and "onload,event" signals needed to support
LayoutTestController's dumpFrameLoadCallbacks() in EFL's DumpRenderTree.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
* ewk/ewk_frame.cpp:
(ewk_frame_load_committed):
(ewk_frame_load_started):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_load_started):
(ewk_view_onload_event):
* ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. Make use of the new frame argument passed to
the "load,started" and "load,finished" signals.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onLoadStarted):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Enable back double buffering on WebKitWebView to fix flickering
commit-queue@webkit.org [Tue, 17 Apr 2012 16:12:25 +0000 (16:12 +0000)]
[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149

Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.

Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.

Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.

* webkit/webkitwebview.cpp:
(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r113172) Wheel events are scrolling inversed.
commit-queue@webkit.org [Tue, 17 Apr 2012 16:10:38 +0000 (16:10 +0000)]
REGRESSION(r113172) Wheel events are scrolling inversed.
https://bugs.webkit.org/show_bug.cgi?id=84156

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Consistent checking for clipped rects when we need the computed result...
danakj@chromium.org [Tue, 17 Apr 2012 15:50:20 +0000 (15:50 +0000)]
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543

Reviewed by Adrienne Walker.

It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.

One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.

Covered by existing tests.

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Suggest box appears after the command was executed in console sometimes.
vsevik@chromium.org [Tue, 17 Apr 2012 15:38:40 +0000 (15:38 +0000)]
Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148

Reviewed by Pavel Feldman.

TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r114376.
commit-queue@webkit.org [Tue, 17 Apr 2012 15:37:03 +0000 (15:37 +0000)]
Unreviewed, rolling out r114376.
http://trac.webkit.org/changeset/114376
https://bugs.webkit.org/show_bug.cgi?id=84155

Wrong patch version committed, asked by the patch author.
(Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-17

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
* ewk/ewk_frame.cpp:
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
* ewk/ewk_view.h:

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::onLoadFinished):
(DumpRenderTreeChrome::onWillSendRequest):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Pattern matching should be applied to numbers
mifenton@rim.com [Tue, 17 Apr 2012 15:20:29 +0000 (15:20 +0000)]
[BlackBerry] Pattern matching should be applied to numbers
https://bugs.webkit.org/show_bug.cgi?id=84152

Reviewed by Antonio Gomes.

PR 148906.

Add pattern matching for number based on [0-9] to trigger
input help matching number fields.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesNumber):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
(BlackBerry::WebKit::DOMSupport::elementPatternMatches):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r105453): Crash when handling touch events
commit-queue@webkit.org [Tue, 17 Apr 2012 15:20:01 +0000 (15:20 +0000)]
REGRESSION (r105453): Crash when handling touch events
https://bugs.webkit.org/show_bug.cgi?id=81958

Patch by Yong Li <yoli@rim.com> on 2012-04-17
Reviewed by Antonio Gomes.

.:

Add a manual test for this issue because DumpRenderTree
currently cannot send a group of touch points with
different touch states in one shot.

* ManualTests/resources/iframe-reloaded-on-touch.html: Added.
* ManualTests/touch-stale-iframe-crash.html: Added.

Source/WebCore:

Always perform sanity checks when handling every touch point
because the node and document may have been destroyed or detached.

ManualTests/touch-stale-iframe-crash.html added.
(DumpRenderTree doesn't support transiting touch states in one shot yet)

* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline svg/carto.net/colourpicker.svg
schenney@chromium.org [Tue, 17 Apr 2012 15:18:37 +0000 (15:18 +0000)]
[Chromium] Rebaseline svg/carto.net/colourpicker.svg

Unreviewed Chromium test expectations update.

This test has been marked as failing for so long that its result is
always wrong. Rebaselining to review flakiness.

* platform/chromium-linux/svg/carto.net/colourpicker-expected.png: Added.
* platform/chromium-linux/svg/carto.net/colourpicker-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
schenney@chromium.org [Tue, 17 Apr 2012 15:06:37 +0000 (15:06 +0000)]
[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
https://bugs.webkit.org/show_bug.cgi?id=84150

Unreviewed Chromium test expectations update.

* fast/repaint/background-misaligned-expected.txt: Added.
* platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Added.
* platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/fast/gradients/background-clipped-expected.txt: Added.
* platform/chromium-mac-leopard/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac/fast/gradients/background-clipped-expected.txt:
* platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
* platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-win-vista/fast/repaint: Added.
* platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-win-xp/svg/as-border-image: Removed.
* platform/chromium-win/fast/repaint/background-misaligned-expected.png:
* platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
* platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/gtk/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/mac/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114377 268f45cc-cd09-0410-ab3c-d52691b4dbfc