WebKit-https.git
6 years agoTighten typing in SVGResourcesCycleSolver a bit.
akling@apple.com [Sat, 9 Nov 2013 16:11:22 +0000 (16:11 +0000)]
Tighten typing in SVGResourcesCycleSolver a bit.
<https://webkit.org/b/124104>

Make the SVGResourcesCycleSolver constructor take a RenderElement&
and a SVGResources&.

While I was in the neighborhood, also converted one loop to use a
renderer iterator instead of walking siblings manually.

Finally used "auto" to clean up some overly wordy loops.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBeat SVGRenderSupport with the RenderElement stick.
akling@apple.com [Sat, 9 Nov 2013 11:32:57 +0000 (11:32 +0000)]
Beat SVGRenderSupport with the RenderElement stick.
<https://webkit.org/b/124102>

Tighten up all the SVGRenderSupport helper functions by making them
take const RenderElements references instead of raw RenderObject
pointers as much as possible.

This tunes up a bunch of branchy style() calls.

The patch looks big but it's mostly mechanical. I just changed the
signatures and then worked backwards until everything built again.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSVGTextLayoutAttributes always has a RenderSVGInlineText.
akling@apple.com [Sat, 9 Nov 2013 11:17:29 +0000 (11:17 +0000)]
SVGTextLayoutAttributes always has a RenderSVGInlineText.
<https://webkit.org/b/124101>

No SVGTextLayoutAttributes object is without a RenderSVGInlineText
"context" so make context() return a reference.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove BindingSecurity stuff under JSDOMBinding umbrella.
akling@apple.com [Sat, 9 Nov 2013 11:16:41 +0000 (11:16 +0000)]
Move BindingSecurity stuff under JSDOMBinding umbrella.
<https://webkit.org/b/124099>

We are hitting shouldAllowAccessToDOMWindow() pretty hard on the
demo here: <http://www.jasondavies.com/maps/rotate/>

Putting it together with the rest of the JSDOMBinding code takes
CPU time spent in there from 8.7% to 6.5%. The abstraction was
only used to support alternate JS engines in the past.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd subtest for word-break:break-all to Layout/line-layout-simple.html
antti@apple.com [Sat, 9 Nov 2013 11:14:37 +0000 (11:14 +0000)]
Add subtest for word-break:break-all to Layout/line-layout-simple.html
https://bugs.webkit.org/show_bug.cgi?id=124103

Reviewed by Andreas Kling.

* Layout/line-layout-simple.html:

Combination "white-space:pre-wrap; word-break:break-all" is common for pure text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK build fix.
zandobersek@gmail.com [Sat, 9 Nov 2013 07:57:38 +0000 (07:57 +0000)]
Unreviewed GTK build fix.

* GNUmakefile.list.am: Remove redundant build targets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove dead FTL C ABI support
fpizlo@apple.com [Sat, 9 Nov 2013 06:55:07 +0000 (06:55 +0000)]
Remove dead FTL C ABI support
https://bugs.webkit.org/show_bug.cgi?id=124100

Reviewed by Jer Noble.

* JavaScriptCore.xcodeproj/project.pbxproj:
* ftl/FTLCArgumentGetter.cpp: Removed.
* ftl/FTLCArgumentGetter.h: Removed.
* ftl/FTLOSRExitCompiler.cpp:
* jit/FPRInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate binary drops to a version that includes new stackmap fixes and exposes the...
fpizlo@apple.com [Sat, 9 Nov 2013 06:53:38 +0000 (06:53 +0000)]
Update binary drops to a version that includes new stackmap fixes and exposes the new calling conventions.

* LLVMIncludesMountainLion.tar.bz2:
* LLVMLibrariesMountainLion.tar.bz2:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl
beidson@apple.com [Sat, 9 Nov 2013 06:27:23 +0000 (06:27 +0000)]
Merge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124088

Source/WebCore:

Reviewed by Tim Horton.

Source/WebKit2:

Reviewed by Tim Horton.

This abstraction is no longer meaningful in its current form in WebCore.
The current groundwork for the WK2 DatabaseProcess relied on this abstraction,
but that will be reworked in a future patch.

* DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h:

* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::maybeCreateTransactionBackend):
(WebKit::WebIDBFactoryBackend::createCursorBackend):
* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

* WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::put):
(WebKit::WebProcessIDBDatabaseBackend::openCursor):
* WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdating LayoutTests that depend on RTCPeerConnection
commit-queue@webkit.org [Sat, 9 Nov 2013 06:00:50 +0000 (06:00 +0000)]
Updating LayoutTests that depend on RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=124097

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Needed to do not throw unwanted exception

* fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
* fast/mediastream/RTCPeerConnection-createAnswer.html:
* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-datachannel.html:
* fast/mediastream/RTCPeerConnection-dtmf.html:
* fast/mediastream/RTCPeerConnection-events.html:
* fast/mediastream/RTCPeerConnection-ice.html:
* fast/mediastream/RTCPeerConnection-localDescription.html:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
* fast/mediastream/RTCPeerConnection-remoteDescription.html:
* fast/mediastream/RTCPeerConnection-state.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r158984.
ljaehun.lim@samsung.com [Sat, 9 Nov 2013 04:40:42 +0000 (04:40 +0000)]
Unreviewed build fix after r158984.

No needs to include "KeyedEncoder.h".
WebKit/Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:31:26: fatal error: KeyedEncoder.h: No such file or directory

* WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed #include line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL should support Phantom(FinalObject:)
fpizlo@apple.com [Sat, 9 Nov 2013 04:24:27 +0000 (04:24 +0000)]
FTL should support Phantom(FinalObject:)
https://bugs.webkit.org/show_bug.cgi?id=124092

Reviewed by Oliver Hunt.

* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isType):
(JSC::FTL::LowerDFGToLLVM::isNotType):
(JSC::FTL::LowerDFGToLLVM::speculateFinalObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of the FTL tail call APIs since they are unused
fpizlo@apple.com [Sat, 9 Nov 2013 04:20:47 +0000 (04:20 +0000)]
Get rid of the FTL tail call APIs since they are unused
https://bugs.webkit.org/show_bug.cgi?id=124093

Reviewed by Oliver Hunt.

* ftl/FTLAbbreviations.h:
(JSC::FTL::buildCall):
* ftl/FTLOutput.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImproving readability of LayoutTests in fast/mediastream
commit-queue@webkit.org [Sat, 9 Nov 2013 04:17:42 +0000 (04:17 +0000)]
Improving readability of LayoutTests in fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=124095

Adding some indentation

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

* fast/mediastream/MediaStream-add-remove-tracks.html:
* fast/mediastream/MediaStream-onended.html:
* fast/mediastream/MediaStreamConstructor.html:
* fast/mediastream/RTCIceCandidate.html:
* fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
* fast/mediastream/RTCPeerConnection-createAnswer.html:
* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-datachannel.html:
* fast/mediastream/RTCPeerConnection-dtmf.html:
* fast/mediastream/RTCPeerConnection-events.html:
* fast/mediastream/RTCPeerConnection-ice.html:
* fast/mediastream/RTCPeerConnection-localDescription.html:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
* fast/mediastream/RTCPeerConnection-remoteDescription.html:
* fast/mediastream/RTCPeerConnection-state.html:
* fast/mediastream/RTCPeerConnection-stats.html:
* fast/mediastream/RTCPeerConnection-statsSelector.html:
* fast/mediastream/RTCPeerConnection.html:
* fast/mediastream/RTCSessionDescription.html:
* fast/mediastream/argument-types.html:
* fast/mediastream/constructors.html:
* fast/mediastream/enabled.html:
* fast/mediastream/getusermedia.html:
* fast/mediastream/no-interface-object.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReindent JSDOMBinding.h (finally.)
akling@apple.com [Sat, 9 Nov 2013 03:40:02 +0000 (03:40 +0000)]
Reindent JSDOMBinding.h (finally.)

Rubber-stamped by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange collectStyleForPresentationAttribute and related functions to take a MutableSt...
weinig@apple.com [Sat, 9 Nov 2013 03:24:55 +0000 (03:24 +0000)]
Change collectStyleForPresentationAttribute and related functions to take a MutableStylePropertySet by reference
https://bugs.webkit.org/show_bug.cgi?id=124096

Reviewed by Andreas Kling.

Pass MutableStylePropertySet by reference. It is never null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement encoding of arrays of objects
andersca@apple.com [Sat, 9 Nov 2013 01:51:11 +0000 (01:51 +0000)]
Implement encoding of arrays of objects
https://bugs.webkit.org/show_bug.cgi?id=124091

Reviewed by Beth Dakin.

Source/WebCore:

* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the rest of the members.

* platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeObjects):
Call beginArray, then beginArrayElement/endArrayElement for every element and lastly endArray.

Source/WebKit2:

Add a new array stack and push and pop from it accordingly.

* Shared/cf/KeyedEncoder.cpp:
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):
* Shared/cf/KeyedEncoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL should support AllocatePropertyStorage
fpizlo@apple.com [Sat, 9 Nov 2013 01:44:56 +0000 (01:44 +0000)]
FTL should support AllocatePropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=124086

Reviewed by Oliver Hunt.

Also rationalized some offsets in the DFG.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile...
timothy_horton@apple.com [Sat, 9 Nov 2013 01:43:45 +0000 (01:43 +0000)]
Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache
https://bugs.webkit.org/show_bug.cgi?id=123944

Reviewed by Simon Fraser.

Ensure that the tile cache retrieves repaint rects from the tile layer,
not from the tiled backing layer.

Rework RemoteLayerBackingStore painting to fix some rounding issues
that would cause pixel cracks upon repaint, and to speed it up a bit.

* Shared/mac/RemoteLayerBackingStore.h:
Redefine RepaintRectList because we can't include WebLayer.h here yet.
Remove createBackingStore, which was never implemented.
Remove mapToContentCoordinates, because we don't need it on Mac.

(WebKit::RemoteLayerBackingStore::paintingRects): Added.

* Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Stop using mapToContentCoordinates.

(RemoteLayerBackingStore::drawInContext):
Use clipping instead of painting the image multiple times.
Never repaint more than the dirty region's bounds.
Don't waste time with all of the drawNativeImage code, just use CG.
Unindent the switch's cases.
Store the rects we're painting so that enumerateRectsBeingDrawn can get them.
Pixel-snap the rects we're painting.
Clip the context before going to paint.

* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::enumerateRectsBeingDrawn):
* WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Retrieve the rects currently being painted from our backing store, and
transform them (mostly) according to the CTM, to match the transformation
that will have occurred underneath wkCALayerEnumerateRectsBeingDrawnWithBlock.

* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/mac/PlatformCALayerMac.h:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::enumerateRectsBeingDrawn):
Allow the PlatformCALayer to decide how to enumerate rects to paint.

* WebCore.exp.in:
* platform/graphics/mac/WebLayer.h:
Add RepaintRectList, remove some unnecessary WebCore::s.

* platform/graphics/mac/WebLayer.mm:
(WebCore::collectRectsToPaint):
Factor collectRectsToPaint out; it just grabs the rects from
the layer and makes the decision whether to repaint the bounds
of the dirty region or just the subregions.

Move calls to collectRectsToPaint() to callers of drawLayerContents(),
so that TileController can collect rects from the appropriate source
(the Tile layer) and other layers just continue grabbing them from
their relevant layers.

Make sure that the list that comes from collectRectsToPaint() always
has at least one rect in it (appending the clip bounds if we don't
want to repaint subregions) so we can simplify logic in drawLayerContents.

(WebCore::drawLayerContents):
Remove code to support CompositingCoordinatesBottomUp, as it's only
used on Windows, so this Mac-specific code doesn't need to support it.

Simplify logic given that dirtyRects will always be non-empty.

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer setNeedsDisplayInRect:]):
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::platformCALayerPaintContents):
Adopt collectRectsToPaint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of the bizarre Darwin/x86-only MacroAssembler::shouldBlindForSpecificArch...
fpizlo@apple.com [Sat, 9 Nov 2013 01:29:30 +0000 (01:29 +0000)]
Get rid of the bizarre Darwin/x86-only MacroAssembler::shouldBlindForSpecificArch(uintptr_t) overload
https://bugs.webkit.org/show_bug.cgi?id=124087

Reviewed by Michael Saboff.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlindPointerForSpecificArch):
(JSC::MacroAssembler::shouldBlind):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement more KeyedEncoder functionality
andersca@apple.com [Sat, 9 Nov 2013 01:16:26 +0000 (01:16 +0000)]
Implement more KeyedEncoder functionality
https://bugs.webkit.org/show_bug.cgi?id=124089

Reviewed by Beth Dakin.

Source/WebCore:

* bindings/js/SerializedScriptValue.h:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode):
* platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeConditionalObject):

Source/WebKit2:

* Shared/cf/KeyedEncoder.cpp:
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeFloat):
* Shared/cf/KeyedEncoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agogetCueAsHTML() on an empty cue should return a document fragment
eric.carlson@apple.com [Sat, 9 Nov 2013 01:13:29 +0000 (01:13 +0000)]
getCueAsHTML() on an empty cue should return a document fragment
https://bugs.webkit.org/show_bug.cgi?id=124084

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-empty-cue-text.html

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::createDocumentFragmentFromCueText): Don't return early when the
    passed an empty string.

LayoutTests:

* media/track/track-cue-empty-cue-text-expected.txt: Added.
* media/track/track-cue-empty-cue-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoKeyedEncoder should be able to encoder objects
andersca@apple.com [Sat, 9 Nov 2013 00:51:54 +0000 (00:51 +0000)]
KeyedEncoder should be able to encoder objects
https://bugs.webkit.org/show_bug.cgi?id=124085

Reviewed by Sam Weinig.

Source/WebCore:

* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree):
Encode the root object.

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the target.

* history/HistoryItem.h:
Add new members.

* platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeObject):
Call beginObject, call the functor and then call endObject().

Source/WebKit2:

Add a dictionary stack to KeyedEncoder that's pushed and popped by
beginObject/endObject.

* Shared/cf/KeyedEncoder.cpp:
(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):
* Shared/cf/KeyedEncoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL should support NewArrayBuffer
fpizlo@apple.com [Sat, 9 Nov 2013 00:42:05 +0000 (00:42 +0000)]
FTL should support NewArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=124067

Reviewed by Michael Saboff.

This expanded coverage and revealed some bugs.

This revealed a bug in FTL::OSRExitCompiler where it was assuming that it could save
the framePointer in regT3 even though DFG::reifyInlinedCallFrames() would clobber it.
It turns out that this can be fixed by just completely restoring the stack prior to
doing reifyInlineCallFrames().

I used this as an opportunity to simplify NewArray. That revealed a bug; whenever we say
lowJSValue() in there we need to use ManualOperandSpeculation since we're using it to
rebox values even when we also have to do some speculations. The speculations are done
at the top of compileNewArray().

This also revealed a bug in StringCharAt() for the OOB case.

* ftl/FTLAbstractHeapRepository.h:
(JSC::FTL::AbstractHeapRepository::forIndexingType):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayBuffer):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: It should be possible to debug the Inspector code
achicu@adobe.com [Sat, 9 Nov 2013 00:39:31 +0000 (00:39 +0000)]
Web Inspector: It should be possible to debug the Inspector code
https://bugs.webkit.org/show_bug.cgi?id=124065

Reviewed by Timothy Hatcher.

Source/WebKit2:

When the script is paused, the debugger will pause all the pages in the same PageGroup.
All the Inspector windows were created in the same PageGroup, so pausing one debugger
would stop the other too.

Added WebInspectorPageGroups to manage the PageGroups created for the Inspectors.
The WebInspectors will now use the inspection "level" to figure out which PageGroup to use.
The inspector that debugs the main page will use "__WebInspectorPageGroupLevel1__",
the second inspector (that debugs the first inspector) will use "__WebInspectorPageGroupLevel2__" ...

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorPageGroups::shared):
(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorPageGroups::inspectorPageGroupForLevel):
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::inspectorPageGroup):
(WebKit::WebInspectorProxy::isInspectorPage):
(WebKit::WebInspectorProxy::canAttach):
* UIProcess/WebInspectorProxy.h:

LayoutTests:

Added test to check that a second inspector window can be used to debug the first one.

* inspector-protocol/debugger/nested-inspectors-expected.txt: Added.
* inspector-protocol/debugger/nested-inspectors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIt should be easy to disable blinding on a per-architecture basis
fpizlo@apple.com [Sat, 9 Nov 2013 00:39:03 +0000 (00:39 +0000)]
It should be easy to disable blinding on a per-architecture basis
https://bugs.webkit.org/show_bug.cgi?id=124083

Reviewed by Michael Saboff.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::haveScratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::scratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::canBlind):
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::canBlind):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::haveScratchRegisterForBlinding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTeach CanvasObserver about references
weinig@apple.com [Sat, 9 Nov 2013 00:27:50 +0000 (00:27 +0000)]
Teach CanvasObserver about references
https://bugs.webkit.org/show_bug.cgi?id=124082

Reviewed by Anders Carlsson.

* css/CSSCanvasValue.cpp:
* css/CSSCanvasValue.h:
* html/HTMLCanvasElement.cpp:
* html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBegin stubbing out a KeyedEncoder class in WebCore
andersca@apple.com [Sat, 9 Nov 2013 00:25:24 +0000 (00:25 +0000)]
Begin stubbing out a KeyedEncoder class in WebCore
https://bugs.webkit.org/show_bug.cgi?id=124079

Reviewed by Sam Weinig.

Source/WebCore:

* WebCore.exp.in:
Add symbol needed by WebCore.

* WebCore.xcodeproj/project.pbxproj:
Add new header file.

* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree):
* history/HistoryItem.h:
Add an encodeBackForwardTree overload that takes a KeyedEncoder object. Encode the version.

* platform/KeyedCoding.h:
Add a KeyedEncoder class that just has a single encodeUInt32 member function for now.

Source/WebKit2:

* Shared/KeyedEncoder.h: Removed.
* Shared/cf/KeyedCodingValueCF.cpp: Removed.
* Shared/cf/KeyedEncoder.cpp: Added.
Remove old keyed encoders.

(WebKit::createDictionary):
Helper function to create a mutable dictionary.
(WebKit::KeyedEncoder::KeyedEncoder):
Create the root dictionary.

(WebKit::KeyedEncoder::encodeUInt32):
Create a CFNumberRef and add it to the dictionary.

* Shared/cf/KeyedEncoder.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
Create a KeyedEncoder and encode the history tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge IDBTransactionBackendInterface and IDBTransactionBackendImpl
beidson@apple.com [Sat, 9 Nov 2013 00:09:04 +0000 (00:09 +0000)]
Merge IDBTransactionBackendInterface and IDBTransactionBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124077

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The abstraction is no longer needed.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:

* Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.

* Modules/indexeddb/IDBTransactionBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
* Modules/indexeddb/IDBTransactionBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.

* Modules/indexeddb/IDBBackingStoreInterface.h:
* Modules/indexeddb/IDBCursorBackend.cpp:
* Modules/indexeddb/IDBCursorBackend.h:
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
* Modules/indexeddb/IDBFactoryBackendInterface.h:
* Modules/indexeddb/IDBTransactionBackendOperations.h:
* Modules/indexeddb/IDBTransactionCoordinator.cpp:
* Modules/indexeddb/IDBTransactionCoordinator.h:
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars
simon.fraser@apple.com [Fri, 8 Nov 2013 23:53:54 +0000 (23:53 +0000)]
REGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=124075

Reviewed by Beth Dakin.

In r155660 I removed some scrollbar-related layouts when scrollbars
are in overlay mode.

However, ScrollView::updateScrollbars() has a case where we still need
to do multiple pases, related to its "Never ever try to both gain/lose a
scrollbar in the same pass" comment. When we avoid making a new scrollbar
because the other was removed, we need to do another pass to bring the
correct scrollbar back.

Can't test overlay scrollbars in tests.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Image valued shape-outside that extends vertically into the margin-box...
hmuller@adobe.com [Fri, 8 Nov 2013 23:46:57 +0000 (23:46 +0000)]
[CSS Shapes] Image valued shape-outside that extends vertically into the margin-box is top-clipped
https://bugs.webkit.org/show_bug.cgi?id=123769

Reviewed by Dirk Schulze.

Source/WebCore:

Remove the assumption that Y coordinates are >= 0 from the RasterShapeIntervals class
and correct its computeShapeMarginIntervals() method. The computeShapeMarginIntervals()
method now generates intervals with Y coordinates that begin at the image shape's
bounds.y - shape-margin, which may be less than 0.

The RasterShapeIntervals::intervalsAt() method now offsets its Y coordinate parameter
by the shape-margin. A non-const overload of the method was added to centralize all
access to m_intervalLists.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html
      fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html

* rendering/shapes/RasterShape.cpp:
(WebCore::MarginIntervalGenerator::intervalAt): Don't clip X coordinates to 0 since they can extend into the margin-box.
(WebCore::RasterShapeIntervals::appendInterval): Use the non-const intervalsAt() method.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Ditto.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals): See above.
* rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::RasterShapeIntervals): Added a field for the margin.
(WebCore::RasterShapeIntervals::intervalsAt): Offset y coordinates by the margin; added a non-const overload.

LayoutTests:

Verify that lines overlap a shape-outside that extends into the top of the margin-box
do wrap around the top of the shape as well its side and bottom.

* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: remove -webkit-min and -webkit-max from CSS completions
commit-queue@webkit.org [Fri, 8 Nov 2013 23:46:09 +0000 (23:46 +0000)]
Web Inspector: remove -webkit-min and -webkit-max from CSS completions
https://bugs.webkit.org/show_bug.cgi?id=124072

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-11-08
Reviewed by Timothy Hatcher.

-webkit-min and -webkit-max are not implemented in WebCore, despite mentions of it.

* UserInterface/CSSKeywordCompletions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnded event should work also when playback rate is negative
commit-queue@webkit.org [Fri, 8 Nov 2013 23:45:22 +0000 (23:45 +0000)]
Ended event should work also when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123879

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

According to W3C specification playback is ended also when playback rate is
negative and position is the earliest possible position.

Test: media/video-ended-event-negative-playback.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

LayoutTests:

Tests if ended event is triggered for audio/video elements after
changing playback rate to negative.

* media/video-ended-event-negative-playback-expected.txt: Added.
* media/video-ended-event-negative-playback.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChecking for TypeError in RTCPeerConnection object creation
commit-queue@webkit.org [Fri, 8 Nov 2013 23:36:31 +0000 (23:36 +0000)]
Checking for TypeError in RTCPeerConnection object creation
https://bugs.webkit.org/show_bug.cgi?id=124049

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

If invalid parameters are passed on RTCPeerConnection creation we must throw a TypeError exception.
According to the spec it requires a Dictionary argument, the RTCConfiguration, which is mandatory.

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

Existing tests were updated.

* GNUmakefile.list.am:
* Modules/mediastream/RTCPeerConnection.idl:
* UseJSC.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSRTCPeerConnectionCustom.cpp: Added.
(WebCore::JSRTCPeerConnectionConstructor::constructJSRTCPeerConnection):

LayoutTests:

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

* fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
* fast/mediastream/RTCPeerConnection-createAnswer.html:
* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-datachannel.html:
* fast/mediastream/RTCPeerConnection-dtmf.html:
* fast/mediastream/RTCPeerConnection-events.html:
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCPeerConnection-ice-expected.txt:
* fast/mediastream/RTCPeerConnection-ice.html:
* fast/mediastream/RTCPeerConnection-localDescription.html:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
* fast/mediastream/RTCPeerConnection-remoteDescription.html:
* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:
* fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
* fast/mediastream/RTCPeerConnection-statsSelector.html:
* fast/mediastream/RTCPeerConnection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse references instead of pointers to RenderBlockFlow in FloatingObjects and ComputeF...
bjonesbe@adobe.com [Fri, 8 Nov 2013 23:24:40 +0000 (23:24 +0000)]
Use references instead of pointers to RenderBlockFlow in FloatingObjects and ComputeFloatOffsetAdapter
https://bugs.webkit.org/show_bug.cgi?id=124074

Reviewed by Sam Weinig.

Just a straightforward conversion from const pointers to const references.

Also, remove unneeded argument from FloatingObjects constructor.

No new tests, no behavior change.

* rendering/FloatingObjects.cpp:
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clearLineBoxTreePointers):
(WebCore::FloatingObjects::computePlacedFloatsTree):
(WebCore::shapeInfoForFloat):
(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::heightRemaining):
* rendering/FloatingObjects.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::createFloatingObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTeach SubframeLoader a bit about references
weinig@apple.com [Fri, 8 Nov 2013 23:23:16 +0000 (23:23 +0000)]
Teach SubframeLoader a bit about references
https://bugs.webkit.org/show_bug.cgi?id=124076

Reviewed by Anders Carlsson.

* html/HTMLAppletElement.cpp:
* html/HTMLFrameElementBase.cpp:
* html/HTMLMediaElement.cpp:
* loader/SubframeLoader.cpp:
* loader/SubframeLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBlind Windows build-fix attempt after r158959
beidson@apple.com [Fri, 8 Nov 2013 23:16:25 +0000 (23:16 +0000)]
Blind Windows build-fix attempt after r158959

* WebCore.vcxproj/WebCore.vcxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge IDBCursorBackendInterface and IDBCursorBackendImpl
beidson@apple.com [Fri, 8 Nov 2013 22:48:22 +0000 (22:48 +0000)]
Merge IDBCursorBackendInterface and IDBCursorBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124068

Reviewed by Anders Carlsson.

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:

* Modules/indexeddb/IDBCursorBackendInterface.h: Removed.

* Modules/indexeddb/IDBCursorBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
* Modules/indexeddb/IDBCursorBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.

* Modules/indexeddb/IDBCallbacks.h:
* Modules/indexeddb/IDBCursor.cpp:
* Modules/indexeddb/IDBCursor.h:
* Modules/indexeddb/IDBCursorWithValue.cpp:
* Modules/indexeddb/IDBCursorWithValue.h:
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
* Modules/indexeddb/IDBFactoryBackendInterface.h:
* Modules/indexeddb/IDBRequest.cpp:
* Modules/indexeddb/IDBRequest.h:
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
* Modules/indexeddb/IDBTransactionBackendImpl.h:
* Modules/indexeddb/IDBTransactionBackendInterface.h:
* Modules/indexeddb/IDBTransactionBackendOperations.cpp:
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createCursorBackend):
* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModernize FrameLoader a bit
weinig@apple.com [Fri, 8 Nov 2013 22:42:27 +0000 (22:42 +0000)]
Modernize FrameLoader a bit
https://bugs.webkit.org/show_bug.cgi?id=124073

Reviewed by Anders Carlsson.

* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
Use std::unique_ptrs rather than OwnPtrs.

* loader/MixedContentChecker.cpp:
* loader/MixedContentChecker.h:
Switch to hold a Frame& rather than Frame*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove more accidentally added files.
oliver@apple.com [Fri, 8 Nov 2013 22:11:21 +0000 (22:11 +0000)]
Remove more accidentally added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove code guarded with ENABLE(STREAM)
zandobersek@gmail.com [Fri, 8 Nov 2013 22:09:55 +0000 (22:09 +0000)]
Remove code guarded with ENABLE(STREAM)
https://bugs.webkit.org/show_bug.cgi?id=123667

Reviewed by Anders Carlsson.

Remove ENABLE(STREAM)-guarded code. This was added in the effort to provide Stream API support, but
no port enables the feature and the work on this feature has wound down after the Chromium port forked,
leaving this code unmaintained.

* fileapi/FileReaderLoader.cpp:
* fileapi/FileReaderLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove a workaround for a bug in malloc on Symbian
andersca@apple.com [Fri, 8 Nov 2013 22:04:43 +0000 (22:04 +0000)]
Remove a workaround for a bug in malloc on Symbian
https://bugs.webkit.org/show_bug.cgi?id=124069

Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):
* Platform/CoreIPC/ArgumentDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderBlockFlow::nextFloatLogicalBottomBelow should not use ShapeOutsideFloatOffsetMode
bjonesbe@adobe.com [Fri, 8 Nov 2013 22:01:33 +0000 (22:01 +0000)]
RenderBlockFlow::nextFloatLogicalBottomBelow should not use ShapeOutsideFloatOffsetMode
https://bugs.webkit.org/show_bug.cgi?id=123931

Reviewed by Sam Weinig.

Rewrite nextFloatLogicalBottomBelow to use the placed floats tree for
the search and to not need ShapeOutsideFloatOffsetMode anymore. This
moves almost all of the logic into FloatingObjects, making a small
reduction in the amount that RenderBlockFlow needs to know about the
implementation of FloatingObjects.

In addition, change ComputeFloatOffsetAdapter to take in LayoutUnits
and roundToInt itself so that all of it's callers can be simplified.

No new tests, no new behavior.

* rendering/FloatingObjects.cpp:
(WebCore::rangesIntersect):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::lowValue):
(WebCore::FindNextFloatLogicalBottomAdapter::highValue):
(WebCore::FindNextFloatLogicalBottomAdapter::nextLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::nextShapeLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
* rendering/FloatingObjects.h:
* rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock):
(WebCore::RenderBlockFlow::getClearDelta):
* rendering/RenderBlockFlow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore build fixes.
andersca@apple.com [Fri, 8 Nov 2013 21:35:58 +0000 (21:35 +0000)]
More build fixes.

* UIProcess/API/mac/WKBrowsingContextController.mm:
* UIProcess/API/mac/WKConnection.mm:
(didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore build fixes.
andersca@apple.com [Fri, 8 Nov 2013 21:22:56 +0000 (21:22 +0000)]
More build fixes.

* UIProcess/API/mac/WKConnection.h:
* UIProcess/API/mac/WKConnection.mm:
(didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix the 32-bit build.
andersca@apple.com [Fri, 8 Nov 2013 21:19:19 +0000 (21:19 +0000)]
Try to fix the 32-bit build.

* Shared/API/Cocoa/WKBrowsingContextHandleInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded myself as a contributor.
matthew_hanson@apple.com [Fri, 8 Nov 2013 21:17:08 +0000 (21:17 +0000)]
Added myself as a contributor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=124064
ap@apple.com [Fri, 8 Nov 2013 21:07:13 +0000 (21:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=124064
Some WebCrypto files are not in correct directories

Rubber-stamped by Anders Carlsson.

* WebCore.xcodeproj/project.pbxproj:
* crypto/CryptoAlgorithmAesCbcParams.h: Removed.
* crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
* crypto/CryptoKeyAES.cpp: Removed.
* crypto/CryptoKeyAES.h: Removed.
* crypto/CryptoKeyMac.cpp: Removed.
* crypto/keys/CryptoKeyAES.cpp: Copied from Source/WebCore/crypto/CryptoKeyAES.cpp.
* crypto/keys/CryptoKeyAES.h: Copied from Source/WebCore/crypto/CryptoKeyAES.h.
* crypto/mac/CryptoKeyMac.cpp: Copied from Source/WebCore/crypto/CryptoKeyMac.cpp.
* crypto/parameters/CryptoAlgorithmAesCbcParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesCbcParams.h.
* crypto/parameters/CryptoAlgorithmAesKeyGenParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace __alignof with alignof.
andersca@apple.com [Fri, 8 Nov 2013 21:05:13 +0000 (21:05 +0000)]
Replace __alignof with alignof.

Rubber-stamped by Beth Dakin.

* Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::decodeStringText):
* Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::SimpleArgumentCoder::encode):
(CoreIPC::SimpleArgumentCoder::decode):
* Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):
* WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::decodeString):
* WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::encodeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement JWK key import for HMAC and AES-CBC
ap@apple.com [Fri, 8 Nov 2013 21:01:09 +0000 (21:01 +0000)]
Implement JWK key import for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=124059

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-import-jwk.html
       crypto/subtle/hmac-import-jwk.html
       crypto/subtle/import-jwk.html

WebCrypto supports multiple key formats - raw, pkcs8, spki, jwk. The design is that
we'll transform these into parsed KeyData subclasses before passing to algorithms.

CryptoKeySerialization is a base class for handling all these formats.

* WebCore.xcodeproj/project.pbxproj: Added new files. Removed CryptoKeyFormat.h.

* bindings/js/JSCryptoKeySerializationJWK.h: Added.
* bindings/js/JSCryptoKeySerializationJWK.cpp: Added.
(WebCore::getStringFromJSON): A helper. Note that we can rely on the object being
a nice freshly parsed JSON, no getters or anything.
(WebCore::getBooleanFromJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::JSCryptoKeySerializationJWK):
(WebCore::JSCryptoKeySerializationJWK::~JSCryptoKeySerializationJWK):
(WebCore::createHMACParameters): A simple helper.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): WebCrypto API is weird,
you can have algorithm parameters both inside a JWK key and passed as importKey()
arguments. They need to agree, whatever that means for specific serialization's
algorithm options (not all necessarily have a 1-1 matching to WebCrypto).
(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Take an intersection of usages.
(WebCore::JSCryptoKeySerializationJWK::reconcileExtractable): Only extractable if
both JWK and the caller agree.
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid): Verify validity of JWK key.
(WebCore::JSCryptoKeySerializationJWK::keyData): Return an appropriate KeyData
subclass.

* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::ENUM_CLASS): Moved CryptoKeyFormat here.
(WebCore::cryptoKeyFormatFromJSValue): Added a human readable string to an exception.
(WebCore::JSSubtleCrypto::importKey): Support multiple key formats, not just raw.

* crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::importKey):
* crypto/CryptoAlgorithm.h:
Updated signature for importKey to one that makes more sense. Decoding formats all
the way from a binary blob is not something that CryptoAlgorithm subclasses should
do, we now pass a KeyData subclass instead.
Removed exportKey/wrapKey/unwrapKey altogether, because I don't yet know what the
signatures will be.

* crypto/CryptoKeyData.h: Added.
(WebCore::CryptoKeyData::ENUM_CLASS):
(WebCore::CryptoKeyData::CryptoKeyData):
(WebCore::CryptoKeyData::~CryptoKeyData):
(WebCore::CryptoKeyData::format):
A base class for passing key material to algorithms. Currently, only one type is
supported, that being OctetSequence for secret keys. Keys for RSA and EC are more
complicated, and secret/public ones are different too.

* crypto/CryptoKeyFormat.h: Removed. There are too many key format classes
confusingly floating around, and this was only needed in one file for parsing.

* crypto/CryptoKeySerialization.h: Added.
Base class for handling raw/pkcs8/spki/jwk keys.

* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::importKey):
* crypto/algorithms/CryptoAlgorithmAES_CBC.h:
Updated to use CryptoKeyData.

* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::importKey):
* crypto/algorithms/CryptoAlgorithmHMAC.h:
Updated to use CryptoKeyData.

* crypto/keys/CryptoKeyDataOctetSequence.cpp: Added.
(WebCore::CryptoKeyDataOctetSequence::CryptoKeyDataOctetSequence):
(WebCore::CryptoKeyDataOctetSequence::~CryptoKeyDataOctetSequence):
* crypto/keys/CryptoKeyDataOctetSequence.h: Added.
(WebCore::asCryptoKeyDataOctetSequence):
* crypto/keys/CryptoKeySerializationRaw.cpp: Added.
(WebCore::CryptoKeySerializationRaw::CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::~CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::reconcileAlgorithm):
(WebCore::CryptoKeySerializationRaw::reconcileUsages):
(WebCore::CryptoKeySerializationRaw::reconcileExtractable):
(WebCore::CryptoKeySerializationRaw::keyData):
* crypto/keys/CryptoKeySerializationRaw.h: Added.
Much code to pass around a Vector<char>.

LayoutTests:

* crypto/subtle/aes-cbc-import-jwk-expected.txt: Added.
* crypto/subtle/aes-cbc-import-jwk.html: Added.
* crypto/subtle/hmac-import-jwk-expected.txt: Added.
* crypto/subtle/hmac-import-jwk.html: Added.
* crypto/subtle/import-jwk-expected.txt: Added.
* crypto/subtle/import-jwk.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a way to get a WKWebProcessPlugInBrowserContextController from a handle
andersca@apple.com [Fri, 8 Nov 2013 20:42:42 +0000 (20:42 +0000)]
Add a way to get a WKWebProcessPlugInBrowserContextController from a handle
https://bugs.webkit.org/show_bug.cgi?id=124063

Reviewed by Beth Dakin.

* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove accidentally added files.
oliver@apple.com [Fri, 8 Nov 2013 20:41:12 +0000 (20:41 +0000)]
Remove accidentally added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix minor (unobservable) bug in ArrayIterator::next()
oliver@apple.com [Fri, 8 Nov 2013 20:27:55 +0000 (20:27 +0000)]
Fix minor (unobservable) bug in ArrayIterator::next()
https://bugs.webkit.org/show_bug.cgi?id=124061

Reviewed by Beth Dakin.

I noticed this while reading the array iterator code.  Due to how
ArrayIterator::next() and our enumeration behaviour is implemented
this is not actually a code path that can be hit.  But in order to
future proof this it should be correct.

* runtime/JSArrayIterator.cpp:
(JSC::arrayIteratorNext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore work on WKBrowsingContextHandle
andersca@apple.com [Fri, 8 Nov 2013 20:22:36 +0000 (20:22 +0000)]
More work on WKBrowsingContextHandle
https://bugs.webkit.org/show_bug.cgi?id=124060

Reviewed by Beth Dakin.

Implement -hash and -isEqual: and add -[WKWebProcessPlugInBrowserContextController handle].

* Shared/API/Cocoa/WKBrowsingContextHandle.mm:
(-[WKBrowsingContextHandle hash]):
(-[WKBrowsingContextHandle isEqual:]):
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(decodeInvocation):
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
(-[WKWebProcessPlugInBrowserContextController handle]):
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove breakpoint (and exception break) functionality into JSC::Debugger.
mark.lam@apple.com [Fri, 8 Nov 2013 20:03:50 +0000 (20:03 +0000)]
Move breakpoint (and exception break) functionality into JSC::Debugger.
https://bugs.webkit.org/show_bug.cgi?id=121796.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

- In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are
  now numeric tokens.

- JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint
  record. Previously, this info is tracked in the ScriptBreakpoint record
  in ScriptDebugServer. The only element of ScriptBreakpoint that is not
  being tracked by JSC::Breakpoint is the ScriptBreakpointAction.
     The ScriptBreakpointAction is still tracked by the ScriptDebugServer
  in a list keyed on the corresponding BreakpointID.
     The ScriptBreakpoint record is now only used as a means of passing
  breakpoint paramaters to the ScriptDebugServer.

- ScriptDebugServer now no longer accesses the JSC::CallFrame* directly.
  It always goes through the DebuggerCallFrame.

* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/Breakpoint.h: Added.
(JSC::Breakpoint::Breakpoint):
- Breakpoint class to track info for each breakpoint in JSC::Debugger.
* debugger/Debugger.cpp:
(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope):
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(JSC::Debugger::Debugger):
(JSC::Debugger::detach):
(JSC::Debugger::updateNeedForOpDebugCallbacks):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::setBreakpointsActivated):
(JSC::Debugger::setPauseOnExceptionsState):
(JSC::Debugger::setPauseOnNextStatement):
(JSC::Debugger::breakProgram):
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::updateCallFrame):
(JSC::Debugger::updateCallFrameAndPauseIfNeeded):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::exception):
(JSC::Debugger::atStatement):
(JSC::Debugger::callEvent):
(JSC::Debugger::returnEvent):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::didReachBreakpoint):
(JSC::Debugger::currentDebuggerCallFrame):
* debugger/Debugger.h:
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):
* debugger/DebuggerCallFrame.h:
* debugger/DebuggerPrimitives.h: Added.
- define SourceID, noSourceID, BreakpointID, and noBreakpointID.

Source/WebCore:

No new tests.

- In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are
  now numeric tokens.

- JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint
  record. Previously, this info is tracked in the ScriptBreakpoint record
  in ScriptDebugServer. The only element of ScriptBreakpoint that is not
  being tracked by JSC::Breakpoint is the ScriptBreakpointAction.
     The ScriptBreakpointAction is still tracked by the ScriptDebugServer
  in a list keyed on the corresponding BreakpointID.
     The ScriptBreakpoint record is now only used as a means of passing
  breakpoint paramaters to the ScriptDebugServer.

- ScriptDebugServer now no longer accesses the JSC::CallFrame* directly.
  It always goes through the DebuggerCallFrame.

* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/BreakpointID.h: Added.
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::notifyDoneProcessingDebuggerEvents):
(WebCore::ScriptDebugServer::needPauseHandling):
(WebCore::ScriptDebugServer::handleBreakpointHit):
(WebCore::ScriptDebugServer::handleExceptionInBreakpointCondition):
(WebCore::ScriptDebugServer::handlePause):
* bindings/js/ScriptDebugServer.h:
* bindings/js/SourceID.h: Added.
* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
* bindings/js/WorkerScriptDebugServer.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptDebugListener.h:

Source/WebKit/mac:

* WebView/WebScriptDebugger.h:
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::handlePause):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd A WKBrowsingContextHandle class
andersca@apple.com [Fri, 8 Nov 2013 19:49:32 +0000 (19:49 +0000)]
Add A WKBrowsingContextHandle class
https://bugs.webkit.org/show_bug.cgi?id=124058

Reviewed by Sam Weinig.

The WKBrowsingContextHandle class represents a browsing context and can be sent across process boundaries.

* Shared/API/Cocoa/WKBrowsingContextHandle.h: Added.
* Shared/API/Cocoa/WKBrowsingContextHandle.mm: Added.
(-[WKBrowsingContextHandle _initWithPageID:]):
(-[WKBrowsingContextHandle encodeWithCoder:]):
(-[WKBrowsingContextHandle initWithCoder:]):
(+[WKBrowsingContextHandle supportsSecureCoding]):
* Shared/API/Cocoa/WKBrowsingContextHandleInternal.h: Added.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController handle]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
* UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:
(NS_ENUM):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInspectorConsoleAgent::didFinishXHRLoading ConsoleMessage should include a column...
commit-queue@webkit.org [Fri, 8 Nov 2013 19:45:41 +0000 (19:45 +0000)]
InspectorConsoleAgent::didFinishXHRLoading ConsoleMessage should include a column number
https://bugs.webkit.org/show_bug.cgi?id=114316

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-08
Reviewed by Timothy Hatcher.

InspectorConsoleAgent::didFinishXHRLoading creates a ConsoleMessage with a line number,
but it should also include a column number. It looks like ultimately the line number comes from
JSXMLHttpRequest::send, it should also be possible to get the column number at the time.
The column number would be needed by the Web Inspector to jump to the proper place in source code
to show where the XHR originated from.

* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::SendFunctor::SendFunctor):
(WebCore::SendFunctor::column):
(WebCore::SendFunctor::operator()):
(WebCore::JSXMLHttpRequest::send):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber):
(WebCore::XMLHttpRequest::didFinishLoading):
* xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLeft sidebar on cubic-bezier.com flickers
simon.fraser@apple.com [Fri, 8 Nov 2013 19:38:58 +0000 (19:38 +0000)]
Left sidebar on cubic-bezier.com flickers
https://bugs.webkit.org/show_bug.cgi?id=123128

Source/WebCore:

Reviewed by Dean Jackson.

The logic that determined whether position:fixed elements outside the viewport
should be composited was incorrect if the fixed element also had a transform.

layer.calculateLayerBounds() only takes into account painted transforms (since they
affect layer bounds). So we need to compute the bounds relative to the layer
itself, then use localToContainerQuad() to map them to document coordinates,
but only to the RenderView so that we don't hit the page scale transform.

Tests: compositing/layer-creation/fixed-position-transformed-into-view.html
       compositing/layer-creation/fixed-position-transformed-outside-view.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Reviewed by Dean Jackson.

Tests with transformed, fixed elements which dump the layer tree to see
which layers get composited.

* compositing/layer-creation/fixed-position-transformed-into-view-expected.txt: Added.
* compositing/layer-creation/fixed-position-transformed-into-view.html: Added.
* compositing/layer-creation/fixed-position-transformed-outside-view-expected.txt: Added.
* compositing/layer-creation/fixed-position-transformed-outside-view.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake base64url decoding actually work
ap@apple.com [Fri, 8 Nov 2013 19:37:57 +0000 (19:37 +0000)]
Make base64url decoding actually work
https://bugs.webkit.org/show_bug.cgi?id=124050

Reviewed by Sam Weinig.

* wtf/text/Base64.cpp: (WTF::base64DecodeInternal): Don't hardcode knowledge about
alphabet, put it into the map.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix layout test that was actually testing incorrect behaviour.
oliver@apple.com [Fri, 8 Nov 2013 19:28:06 +0000 (19:28 +0000)]
Fix layout test that was actually testing incorrect behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MathML] Center of stretched curly bracket not always vertically centered
mrobinson@webkit.org [Fri, 8 Nov 2013 19:27:03 +0000 (19:27 +0000)]
[MathML] Center of stretched curly bracket not always vertically centered
https://bugs.webkit.org/show_bug.cgi?id=123715

Reviewed by Brent Fulgham.

Source/WebCore:

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Update an assertion and
handle the case where two glyph pieces abut.
(WebCore::RenderMathMLOperator::paint): Do not offset the center glyph by y().

LayoutTests:

* TestExpectations: Unskip mo-stretch.html. It was skipped originally,
because MathML is changing rapidly, but we need it to test these changes.
* mathml/presentation/mo-stretch.html: Update to show stretching characteristics
of all stretchable glyphs.
* platform/gtk/mathml/presentation/mo-stretch-expected.png:
* platform/gtk/mathml/presentation/mo-stretch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd WKRemoteObjectRegistry to WKConnection
andersca@apple.com [Fri, 8 Nov 2013 19:10:27 +0000 (19:10 +0000)]
Add WKRemoteObjectRegistry to WKConnection
https://bugs.webkit.org/show_bug.cgi?id=124054

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKConnection.h:
* UIProcess/API/mac/WKConnection.mm:
(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMap.forEach crashes on deleted values
oliver@apple.com [Fri, 8 Nov 2013 18:47:26 +0000 (18:47 +0000)]
Map.forEach crashes on deleted values
https://bugs.webkit.org/show_bug.cgi?id=124017

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

MapData iterator did not consider the case of the first entries
being holes.  To fix this I've refactored iteration so that we
can perform an initialisation increment on construction, whle
retaining the useful assertion in MapData::const_iterator::operator++

* runtime/MapData.h:
(JSC::MapData::const_iterator::operator++):
(JSC::MapData::const_iterator::internalIncrement):
(JSC::MapData::const_iterator::const_iterator):

LayoutTests:

Test case

* js/map-iterate-first-entry-is-a-hole-expected.txt: Added.
* js/map-iterate-first-entry-is-a-hole.html: Added.
* js/script-tests/map-iterate-first-entry-is-a-hole.js: Added.
(set map0):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MSE] Bring SourceBuffer.append up to the most recent spec.
jer.noble@apple.com [Fri, 8 Nov 2013 18:30:29 +0000 (18:30 +0000)]
[MSE] Bring SourceBuffer.append up to the most recent spec.
https://bugs.webkit.org/show_bug.cgi?id=123377

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-append-failed.html

Bring the MediaSource append() implementation up to the current spec.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::appendBufferTimerFired):
* platform/graphics/SourceBufferPrivate.h:
* platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::evictCodedFrames):
(WebCore::MockSourceBufferPrivate::isFull):
* platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

* media/media-source/media-source-append-failed-expected.txt: Added.
* media/media-source/media-source-append-failed.html: Added.
* media/media-source/mock-media-source.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEncode and decode NSURLRequests using NSCoder
andersca@apple.com [Fri, 8 Nov 2013 18:28:06 +0000 (18:28 +0000)]
Encode and decode NSURLRequests using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124051

Reviewed by Sam Weinig.

* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::archiveAndEncodeObject):
(CoreIPC::decodeAndUnarchiveObject):
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r158883): Fix crashes for ARM architecture.
commit-queue@webkit.org [Fri, 8 Nov 2013 18:25:52 +0000 (18:25 +0000)]
REGRESSION(r158883): Fix crashes for ARM architecture.
https://bugs.webkit.org/show_bug.cgi?id=124038

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

* jit/GPRInfo.h: Remove r11 from the temporary register set, use a free register for
nonPreservedNonReturnGPR and remove obsolete declaration of bucketCounterRegister.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
* jit/JITOperations.cpp: Frame pointer register is r11 for ARM_TRADITIONAL and
r7 for ARM_THUMB2 instead of r5 since r158883.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r158883): Fix crashes for MIPS architecture.
commit-queue@webkit.org [Fri, 8 Nov 2013 18:24:32 +0000 (18:24 +0000)]
REGRESSION(r158883): Fix crashes for MIPS architecture.
https://bugs.webkit.org/show_bug.cgi?id=124044

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

* jit/JITOperations.cpp: Frame pointer register is fp instead of s0 since r158883 for MIPS.
* jit/ThunkGenerators.cpp: Save and restore the new frame pointer register.
(JSC::returnFromJavaScript):
(JSC::callToJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracks...
jer.noble@apple.com [Fri, 8 Nov 2013 17:55:39 +0000 (17:55 +0000)]
[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange + 26
https://bugs.webkit.org/show_bug.cgi?id=124031

Reviewed by Eric Carlson.

WTF::bind() causes errors when given a bare id pointer as a parameter,
when that parameter is casted to a specific NS type pointer (in this
case, a NSArray*) in order to pass it as a parameter to the bound
function.

Instead of passing around bare id pointers, wrap them in RetainPtr<>
objects before passing them to WTF::bind().

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] JavaScript crash in getHostCallReturnValue.
commit-queue@webkit.org [Fri, 8 Nov 2013 17:12:27 +0000 (17:12 +0000)]
[Win] JavaScript crash in getHostCallReturnValue.
https://bugs.webkit.org/show_bug.cgi?id=124040

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-08
Reviewed by Geoffrey Garen.

* jit/JITOperations.cpp: Update MSVC assembler code in getHostCallReturnValue according to gcc x86 version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Fri, 8 Nov 2013 15:27:09 +0000 (15:27 +0000)]
Unreviewed EFL gardening

Add test expectations for failing tests.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd line layout performance test that exercises more cases
antti@apple.com [Fri, 8 Nov 2013 14:57:51 +0000 (14:57 +0000)]
Add line layout performance test that exercises more cases
https://bugs.webkit.org/show_bug.cgi?id=124041

Reviewed by Anders Carlsson.

The existing line-layout.html covers the most basic left-aligned case only.
Add a test with more coverage for things that are mostly not yet supported by the simple
line layout path:

- centered text
- right aligned text
- justified text
- pre
- white-space:pre-wrap
- text with simple inlines
- text with br

* Layout/line-layout-simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add new GTK-specific layout test results for vertical text
commit-queue@webkit.org [Fri, 8 Nov 2013 14:42:22 +0000 (14:42 +0000)]
[GTK] Add new GTK-specific layout test results for vertical text
https://bugs.webkit.org/show_bug.cgi?id=124000

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Rebaselined some expected results for tests that use vertical text.
These tests are now working fine after the fix from Bug 50619.
They have specific results for WebKit2 GTK+ because WebKit1 has a
permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.

* fast/repaint/japanese-rl-selection-clear-expected.txt:
* fast/repaint/japanese-rl-selection-repaint-expected.txt:
* fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* fast/text/international/vertical-text-glyph-test-expected.txt:
* fast/text/justify-ideograph-vertical-expected.txt:
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
* platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
* platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Removed.
* platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-clear-expected.txt.
* platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-repaint-expected.txt.
* platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
* platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/fast/text/international/vertical-text-glyph-test-expected.txt.
* platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/fast/text/justify-ideograph-vertical-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTemplated LChar/UChar paths for simple line layout
antti@apple.com [Fri, 8 Nov 2013 12:53:19 +0000 (12:53 +0000)]
Templated LChar/UChar paths for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=124035

Reviewed by Andreas Kling.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseFor):

    Use a templated function to check for illegal characters.

(WebCore::SimpleLineLayout::skipWhitespaces):

    Make a template function.

(WebCore::SimpleLineLayout::textWidth):

    Make a template function plus some argument changes.

(WebCore::SimpleLineLayout::createTextRuns):

    Template function for creating runs while operating with either LChars or UChar.
    Also simplified line breaking and text width measuring logic.

(WebCore::SimpleLineLayout::create):

    Pick the template.

* rendering/break_lines.cpp:
* rendering/break_lines.h:

    Move the implementation to the header (except for the table) so we can use the template
    versions directly.

(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] accessibility/aria-link-supports-press.html
commit-queue@webkit.org [Fri, 8 Nov 2013 12:16:33 +0000 (12:16 +0000)]
[EFL] accessibility/aria-link-supports-press.html
https://bugs.webkit.org/show_bug.cgi?id=111987

Unreviewed EFL gardening, passes after r158913.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08

* platform/efl-wk1/TestExpectations: test is no longer failing.
* platform/efl-wk2/TestExpectations: test is no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[mips] Fix typo (introduced in r158751).
ossy@webkit.org [Fri, 8 Nov 2013 11:26:24 +0000 (11:26 +0000)]
[mips] Fix typo (introduced in r158751).
https://bugs.webkit.org/show_bug.cgi?id=124033.

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Csaba Osztrogonác.

* jit/ThunkGenerators.cpp:
(JSC::callToJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
ossy@webkit.org [Fri, 8 Nov 2013 11:22:04 +0000 (11:22 +0000)]
[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
https://bugs.webkit.org/show_bug.cgi?id=123891

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

Although patchableBranch32 is implemented in MacroAssemblerARM.h, the used implementation
is the generic one in MacroAssembler.h. This patch fixes it and also implements the
patchableJump() function for CPU(ARM_TRADITIONAL). These specific implementations are
needed for this architecture backend to ensure that these jumps can be relinked.

* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::patchableJump):
* jit/GPRInfo.h: Remove static_cast that are generating warnings in debug builds.
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: [ATK] <span> elements exposed through ATK when not needed
mario@webkit.org [Fri, 8 Nov 2013 10:55:38 +0000 (10:55 +0000)]
AX: [ATK] <span> elements exposed through ATK when not needed
https://bugs.webkit.org/show_bug.cgi?id=123885

Reviewed by Chris Fleizach.

Source/WebCore:

As per SVN r158195, the way it's decided whether <span> elements
should be ignored or not has slightly changed, causing that the
GTK/EFL ports expose them in cases that they should be ignored,
such as for text elements that neither are focusable (e.g. by
explicitly setting tabindex) nor have a meaningful accessible name
suggesting they should be exposed.

As a result, the flattening that ATK based ports normally do for
this kind of elements (by folding them into their parents) do not
work correctly anymore, making two tests to fail:

    platform/gtk/accessibility/spans-paragraphs-and-divs.html
    platform/gtk/accessibility/spans.html

This patch encapsulates the part of the logic that affects this in
the computeAccessibilityIsIgnored() method, placing it in a
new method of AccessibilityObject that we can call from ATK's
accessibilityPlatformIncludesObject() to ensure we hide those
<span> elements when they don't fulfill those requirements.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion):
New virtual method encapsulating part of the logic from the function
that computes whether accessibility should be ignored or not.
* accessibility/AccessibilityObject.h:

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion):
Override of the new method adding additional checks, as extracted from
the original bits in computeAccessibilityIsIgnored().
* accessibility/AccessibilityNodeObject.h:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Use the newly added function where we had the original code before.

* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Make sure <span> elements are ignored if they are not focusable
and they don't have a meaningful accessible name.

LayoutTests:

Removed failure expectations for tests now passing.

* platform/gtk/TestExpectations: Removed expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] accessibility/aria-link-supports-press.html is failing
commit-queue@webkit.org [Fri, 8 Nov 2013 10:24:39 +0000 (10:24 +0000)]
[GTK] accessibility/aria-link-supports-press.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98355

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Tools:

Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isPressActionSupported):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):

LayoutTests:

Removed failure expectation.

* platform/gtk/TestExpectations: test is no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[JHBUILD] Jhbuild Makefile build bug workaround
commit-queue@webkit.org [Fri, 8 Nov 2013 09:43:44 +0000 (09:43 +0000)]
[JHBUILD] Jhbuild Makefile build bug workaround
https://bugs.webkit.org/show_bug.cgi?id=123971

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-08
Reviewed by Ryosuke Niwa.

After Jhbuild repository is cloned (for instance when you use
Tools/Scripts/update-webkitefl-libs) it is built from sources.
If you have GREP_OPTIONS grep env variable set (for instance
GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
uses shell grep. For specific GREP_OPTIONS grep output will be
different than expected one by Jhbuild and there is an error
with Jhbuild build. Jhbuild will not be built and then WebKit
source also will not be built. This patch is a workaround to this
issue. It disables GREP_OPTIONS for Jhbuild build time.

* jhbuild/jhbuild-wrapper:
(install_jhbuild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd back expectation for test that went missing in r158813.
akling@apple.com [Fri, 8 Nov 2013 09:06:21 +0000 (09:06 +0000)]
Add back expectation for test that went missing in r158813.

* svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
carlosgc@webkit.org [Fri, 8 Nov 2013 08:16:08 +0000 (08:16 +0000)]
[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
https://bugs.webkit.org/show_bug.cgi?id=123990

Reviewed by Philippe Normand.

Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to the
symbols files.

* bindings/gobject/WebKitDOMEventTarget.symbols:
* bindings/gobject/webkitdom.symbols:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Ignore deprecated macros when generating gtk-doc
carlosgc@webkit.org [Fri, 8 Nov 2013 08:14:08 +0000 (08:14 +0000)]
[GTK] Ignore deprecated macros when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=123988

Reviewed by Philippe Normand.

* gtk/generate-gtkdoc:
(get_common_options): Ignore also WEBKIT_DEPRECATED and
WEBKIT_DEPRECATED_FOR decorators.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Pass the library namespace to gtkdoc-mkdb
carlosgc@webkit.org [Fri, 8 Nov 2013 08:12:09 +0000 (08:12 +0000)]
[GTK] Pass the library namespace to gtkdoc-mkdb
https://bugs.webkit.org/show_bug.cgi?id=123900

Reviewed by Martin Robinson.

This fixes the generation of the index of symbols in the API
documentation.

* gtk/generate-gtkdoc:
(get_webkit2_options): Define namespace as WebKit.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Define namespace as WebKitDOM.
* gtk/gtkdoc.py:
(GTKDoc.__init__): Add namespace option.
(GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
carlosgc@webkit.org [Fri, 8 Nov 2013 08:09:23 +0000 (08:09 +0000)]
[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=123899

Reviewed by Martin Robinson.

Do not include deprecated API when compiling with
WEBKIT_DISABLE_DEPRECATED option.

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnhance SQL journal_mode setting code to be less likely to log an error.
beidson@apple.com [Fri, 8 Nov 2013 06:08:41 +0000 (06:08 +0000)]
Enhance SQL journal_mode setting code to be less likely to log an error.
<rdar://problem/15418577> and https://bugs.webkit.org/show_bug.cgi?id=124018

Reviewed by Anders Carlsson.

Even though the docs says SQLITE_ROW will always be returned, apparently SQLITE_OK is sometimes returned.
Change the code to handle that.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open): Save the statement result value, and accept SQLITE_OK as a non-error condition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Layout tests with vertical texts need to be rebaselined
gyuyoung.kim@samsung.com [Fri, 8 Nov 2013 05:52:07 +0000 (05:52 +0000)]
[EFL] Layout tests with vertical texts need to be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=123985

Unreviewed, EFL port needs to do rebaseline since r158848.

* platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Removed.
* platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Removed.
* platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/efl/TestExpectations:
* platform/efl/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/efl/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/efl/fast/block/lineboxcontain/block-with-ideographs-expected.txt:
* platform/efl/fast/dynamic/text-combine-expected.txt:
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
* platform/efl/fast/text/decorations-with-text-combine-expected.txt:
* platform/efl/fast/text/emphasis-combined-text-expected.txt:
* platform/efl/fast/text/emphasis-vertical-expected.txt:
* platform/efl/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/efl/fast/text/international/text-spliced-font-expected.txt:
* platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
* platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Added.
* platform/efl/fast/text/orientation-sideways-expected.txt:
* platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
* platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/efl/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-text-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/efl/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
* platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate an out-dated ASSERT in IconDatabase code.
beidson@apple.com [Fri, 8 Nov 2013 05:40:19 +0000 (05:40 +0000)]
Update an out-dated ASSERT in IconDatabase code.
<rdar://problem/15171118> and https://bugs.webkit.org/show_bug.cgi?id=124030.

Reviewed by Andreas Kling.

With the asynchronous interfaces that have been added and the support for WK2 that has been added,
this ASSERT can incorrectly fire if an icon is asked for before database cleanup is allowed.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL): Update an invalid ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderSVGResource helpers should take RenderStyle by const reference.
akling@apple.com [Fri, 8 Nov 2013 05:24:20 +0000 (05:24 +0000)]
RenderSVGResource helpers should take RenderStyle by const reference.
<https://webkit.org/b/124029>

Take const RenderStyle& instead of RenderStyle* in a few more places
so we can get rid of some ampersands and assertions.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
gyuyoung.kim@samsung.com [Fri, 8 Nov 2013 05:21:32 +0000 (05:21 +0000)]
[AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
https://bugs.webkit.org/show_bug.cgi?id=123984

Reviewed by Mario Sanchez Prada.

As a step to let static_cast<> use TYPE_CASTS_BASE, AccessibilityTableRow|Column|Cell use
ACCESSIBILITY_OBJECT_TYPE_CASTS which can support more helper functions rather than manual
static_cast<>. This change will help to detect bad type casts further.

No new tests, no behavior changes.

* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cellForColumnAndRow):
* accessibility/AccessibilityTableCell.h:
* accessibility/AccessibilityTableColumn.h:
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
* accessibility/AccessibilityTableRow.h:
* accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(cellAtIndex):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableCellParent]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of the regT* definitions in JSInterfaceJIT.h.
mark.lam@apple.com [Fri, 8 Nov 2013 04:05:27 +0000 (04:05 +0000)]
Get rid of the regT* definitions in JSInterfaceJIT.h.
https://bugs.webkit.org/show_bug.cgi?id=123806.

Reviewed by Geoffrey Garen.

JSInterfaceJIT now inherits from GPRInfo and FPRInfo, and relies on them
to provide all the register definitions.

* jit/GPRInfo.h:
(JSC::GPRInfo::toArgumentRegister):
* jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompile):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_get_argument_by_val):
(JSC::JIT::emitSlow_op_loop_hint):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::JSInterfaceJIT):
* jit/SlowPathCall.h:
(JSC::JITSlowPathCall::call):
* jit/ThunkGenerators.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r154375): Image is oriented incorrectly
gyuyoung.kim@samsung.com [Fri, 8 Nov 2013 03:55:30 +0000 (03:55 +0000)]
REGRESSION (r154375): Image is oriented incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123831

Reviewed by Antonio Gomes.

r154375 made that shouldRespectImageOrientation() isn't used by drawImage().
It causes an image isn't oriented correctly. This patch sets shouldRespectImageOrientation()
value by default.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r158846.
gyuyoung.kim@samsung.com [Fri, 8 Nov 2013 03:54:46 +0000 (03:54 +0000)]
Unreviewed, rolling out r158846.
http://trac.webkit.org/changeset/158846

r158846 was duplicating gardening against r158837.

* platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
* platform/efl/http/tests/media/video-cookie-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
* platform/efl/media/context-menu-actions-expected.txt: Removed.
* platform/efl/media/media-can-play-flac-audio-expected.txt: Removed.
* platform/efl/media/media-can-play-webm-expected.txt: Removed.
* platform/efl/media/media-volume-slider-rendered-below-expected.txt: Removed.
* platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Removed.
* platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Removed.
* platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Removed.
* platform/efl/media/track/track-cue-mutable-text-expected.txt: Removed.
* platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Removed.
* platform/efl/media/track/track-language-preference-expected.txt: Removed.
* platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Removed.
* platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Removed.
* platform/efl/media/video-controls-fullscreen-volume-expected.txt: Removed.
* platform/efl/media/video-controls-toggling-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
hmuller@adobe.com [Fri, 8 Nov 2013 03:50:52 +0000 (03:50 +0000)]
[CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123934

Reviewed by Andreas Kling.

Source/WebCore:

RasterShapeIntervals::getExcludedIntervals() was returning an empty
list when the line overlapped any vertical gap in the image. This short-circuit
had been mistakenly copied from getIncludedIntervals(), where it makes sense.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html

* rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::getExcludedIntervals):

LayoutTests:

* fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake contents layer borders more visible
simon.fraser@apple.com [Fri, 8 Nov 2013 03:07:41 +0000 (03:07 +0000)]
Make contents layer borders more visible
https://bugs.webkit.org/show_bug.cgi?id=124025

Reviewed by Tim Horton.

Layer borders for contents layers are impossible to see when the
contentsLayer has the same bounds as its parent; make the contents
layer border 4px thick to make it more visible.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setupContentsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize baselines: svg/filters
akling@apple.com [Fri, 8 Nov 2013 02:57:58 +0000 (02:57 +0000)]
Optimize baselines: svg/filters

Unreviewed; run "webkit-patch optimize-baselines svg/filters"

* platform/gtk/svg/filters/animate-fill-expected.png: Removed.
* platform/gtk/svg/filters/feColorMatrix-default-type-expected.png: Removed.
* platform/gtk/svg/filters/feColorMatrix-offset-expected.png: Removed.
* platform/gtk/svg/filters/feColorMatrix-values-expected.png: Removed.
* platform/gtk/svg/filters/feComposite-expected.txt: Removed.
* platform/gtk/svg/filters/feDisplacementMap-expected.txt: Removed.
* platform/gtk/svg/filters/feDropShadow-subregion-expected.png: Removed.
* platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.png: Removed.
* platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
* platform/gtk/svg/filters/feGaussianBlur-subregion-expected.png: Removed.
* platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.png: Removed.
* platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
* platform/gtk/svg/filters/feImage-change-target-id-expected.png: Removed.
* platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
* platform/gtk/svg/filters/feImage-remove-target-expected.png: Removed.
* platform/gtk/svg/filters/feLighting-crash-expected.png: Removed.
* platform/gtk/svg/filters/feMerge-wrong-input-expected.png: Removed.
* platform/gtk/svg/filters/filter-empty-g-expected.png: Removed.
* platform/gtk/svg/filters/filter-hidden-content-expected.txt: Removed.
* platform/gtk/svg/filters/filter-on-filter-for-text-expected.png: Removed.
* platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt: Removed.
* platform/gtk/svg/filters/filter-on-tspan-expected.txt: Removed.
* platform/gtk/svg/filters/filter-refresh-expected.png: Removed.
* platform/gtk/svg/filters/filter-rounding-issues-expected.png: Removed.
* platform/gtk/svg/filters/filter-width-update-expected.txt: Removed.
* platform/gtk/svg/filters/filterRes-expected.txt: Removed.
* platform/gtk/svg/filters/filterRes2-expected.png: Removed.
* platform/gtk/svg/filters/filteredImage-expected.png: Removed.
* platform/gtk/svg/filters/sourceAlpha-expected.png: Removed.
* platform/gtk/svg/filters/sourceAlpha-expected.txt: Removed.
* platform/mac/svg/filters/feDisplacementMap-expected.txt: Removed.
* platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
* platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
* platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
* platform/mac/svg/filters/filter-hidden-content-expected.txt: Removed.
* platform/mac/svg/filters/filterRes-expected.txt: Removed.
* platform/win-future/svg/filters/feImage-reference-svg-primitive-expected.png: Renamed from LayoutTests/svg/filters/feImage-reference-svg-primitive-expected.png.
* svg/filters/animate-fill-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/animate-fill-expected.png.
* svg/filters/feColorMatrix-default-type-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-default-type-expected.png.
* svg/filters/feColorMatrix-offset-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-offset-expected.png.
* svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-values-expected.png.
* svg/filters/feComposite-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feComposite-expected.txt.
* svg/filters/feDisplacementMap-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDisplacementMap-expected.txt.
* svg/filters/feDropShadow-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-subregion-expected.png.
* svg/filters/feDropShadow-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png.
* svg/filters/feDropShadow-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt.
* svg/filters/feGaussianBlur-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-subregion-expected.png.
* svg/filters/feGaussianBlur-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png.
* svg/filters/feGaussianBlur-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt.
* svg/filters/feImage-change-target-id-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-change-target-id-expected.png.
* svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt.
* svg/filters/feImage-remove-target-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-remove-target-expected.png.
* svg/filters/feLighting-crash-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feLighting-crash-expected.png.
* svg/filters/feMerge-wrong-input-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feMerge-wrong-input-expected.png.
* svg/filters/filter-empty-g-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-empty-g-expected.png.
* svg/filters/filter-hidden-content-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-hidden-content-expected.txt.
* svg/filters/filter-on-filter-for-text-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.png.
* svg/filters/filter-on-filter-for-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.txt.
* svg/filters/filter-on-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-tspan-expected.txt.
* svg/filters/filter-refresh-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-refresh-expected.png.
* svg/filters/filter-rounding-issues-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-rounding-issues-expected.png.
* svg/filters/filter-width-update-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-width-update-expected.txt.
* svg/filters/filterRes-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filterRes-expected.txt.
* svg/filters/filterRes2-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filterRes2-expected.png.
* svg/filters/filteredImage-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filteredImage-expected.png.
* svg/filters/sourceAlpha-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.png.
* svg/filters/sourceAlpha-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEncode and decode NSURLResponse objects using NSCoder
andersca@apple.com [Fri, 8 Nov 2013 02:47:20 +0000 (02:47 +0000)]
Encode and decode NSURLResponse objects using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124028

Reviewed by Andreas Kling.

* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInlineFlowBox always has a RenderBoxModelObject, take advantage.
akling@apple.com [Fri, 8 Nov 2013 02:43:22 +0000 (02:43 +0000)]
InlineFlowBox always has a RenderBoxModelObject, take advantage.
<https://webkit.org/b/124024>

Since InlineFlowBox already has the branch-less renderer() returning
a RenderBoxModelObject&, avoid using InlineBox::boxModelObject()
wherever we have a tightly-typed box. One branch disappears from
every call site.

Deleted boxModelObject() on InlineFlowBox to prevent new code from
calling the less efficient function.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCTTE: Scrolling tree nodes should always have a ScrollingTree&.
akling@apple.com [Fri, 8 Nov 2013 02:41:19 +0000 (02:41 +0000)]
CTTE: Scrolling tree nodes should always have a ScrollingTree&.
<https://webkit.org/b/124022>

Let ScrollingTreeNode and subclasses store the backpointer to the
tree as a ScrollingTree& reference.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove m_destinationID to MessageDecoder
andersca@apple.com [Fri, 8 Nov 2013 02:22:40 +0000 (02:22 +0000)]
Move m_destinationID to MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=124026

Reviewed by Andreas Kling.

* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/MessageDecoder.h:
(CoreIPC::MessageDecoder::destinationID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL should support NewArray
fpizlo@apple.com [Fri, 8 Nov 2013 01:55:49 +0000 (01:55 +0000)]
FTL should support NewArray
https://bugs.webkit.org/show_bug.cgi?id=124010

Reviewed by Oliver Hunt.

* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::allocateObject):
(JSC::FTL::LowerDFGToLLVM::allocateBasicStorageAndGetEnd):
(JSC::FTL::LowerDFGToLLVM::ArrayValues::ArrayValues):
(JSC::FTL::LowerDFGToLLVM::allocateJSArray):
* ftl/FTLOutput.h:
(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::storeDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158891 268f45cc-cd09-0410-ab3c-d52691b4dbfc