WebKit-https.git
7 years agoCrash in visiblePositionForIndex
rniwa@webkit.org [Fri, 17 Feb 2012 01:43:50 +0000 (01:43 +0000)]
Crash in visiblePositionForIndex
https://bugs.webkit.org/show_bug.cgi?id=77683

Reviewed by Eric Seidel.

Source/WebCore:

Fixed the crash.

Test: editing/execCommand/applyblockelement-visiblepositionforindex-crash.html

* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
* editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
* editing/htmlediting.h:
(WebCore):

LayoutTests:

Add a regression test. It crashes Webkit with very high frequency.

* editing/execCommand/applyblockelement-visiblepositionforindex-crash-expected.txt: Added.
* editing/execCommand/applyblockelement-visiblepositionforindex-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
mdelaney@apple.com [Fri, 17 Feb 2012 01:40:33 +0000 (01:40 +0000)]
ShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
https://bugs.webkit.org/show_bug.cgi?id=78765

Reviewed by Simon Fraser.

No new tests due to the flaky nature of reproducing the issue.

* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::getScratchBuffer): Make sure to call clearScratchBuffer()
when we create a new ImageBuffer in order to invalidate cached values.
(WebCore::ScratchBuffer::setCachedShadowValues): Roll together matching and setting
of cached values into one method to enforce them being the same.
(WebCore::ScratchBuffer::setCachedInsetShadowValues): Ditto.

Restructure to use new method described above.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::beginShadowLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Empty divs not transforming overflow correctly
commit-queue@webkit.org [Fri, 17 Feb 2012 01:30:27 +0000 (01:30 +0000)]
[chromium] Empty divs not transforming overflow correctly
https://bugs.webkit.org/show_bug.cgi?id=78850

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/overflow/transform-in-empty-container.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setSize):

LayoutTests:

* compositing/overflow/transform-in-empty-container-expected.png: Added.
* compositing/overflow/transform-in-empty-container-expected.txt: Added.
* compositing/overflow/transform-in-empty-container.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix use of long long in FractionalLayoutUnit::setRawValue
eae@chromium.org [Fri, 17 Feb 2012 01:16:15 +0000 (01:16 +0000)]
Fix use of long long in FractionalLayoutUnit::setRawValue
https://bugs.webkit.org/show_bug.cgi?id=78835

Reviewed by Eric Seidel.

Change setRawValue(long long) to compare against int min and max instead
of using abs as not all platforms we support implement a long long
version of abs or llabs.

No new tests.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::setRawValue):
Compare against int min/max instead of just max with abs.

(WebCore::FractionalLayoutUnit::isInBounds):
Fix type mismatch warning.

(WebCore::operator==):
Fix typo.

(WebCore::operator*):
Use long long version of setRawValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: simplify worker interface
dpranke@chromium.org [Fri, 17 Feb 2012 01:11:25 +0000 (01:11 +0000)]
nrwt: simplify worker interface
https://bugs.webkit.org/show_bug.cgi?id=78181

Reviewed by Tony Chang.

This change moves code in name(), is_done(), run(), and cancel()
from Worker to AbstractWorker, since the logic is pretty much
boilerplate code that any implementation would want to use.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get.should):
(AbstractWorker.__init__):
(AbstractWorker):
(AbstractWorker.name):
(AbstractWorker.stop_handling_messages):
(AbstractWorker.run):
(AbstractWorker.is_done):
(AbstractWorker.cancel):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker.run):
(Worker.handle_stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed baseline update for compositing/scrollbar-painting.html
jamesr@google.com [Fri, 17 Feb 2012 01:06:41 +0000 (01:06 +0000)]
[chromium] Unreviewed baseline update for compositing/scrollbar-painting.html

* platform/chromium-mac-snowleopard/compositing/scrollbar-painting-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Add an internal flag to accept multiple shadow roots for the purpose...
shinyak@chromium.org [Fri, 17 Feb 2012 00:57:19 +0000 (00:57 +0000)]
Source/WebCore: Add an internal flag to accept multiple shadow roots for the purpose of tests.
https://bugs.webkit.org/show_bug.cgi?id=78453

Reviewed by Hajime Morita.

This patch introduces a flag to enable multiple shadow subtrees.
This flag is intended to be used for testing purpose for a while.
We will remove it later.

No new tests, no change in behavior.

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::multipleShadowSubtreesEnabled):
(WebCore::RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::pushShadowRoot):
* testing/Internals.cpp:
(WebCore::Internals::setMultipleShadowSubtreesEnabled):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests: Needs an internal flag to accept multiple shadow roots for the purpose of tests
https://bugs.webkit.org/show_bug.cgi?id=78453

Reviewed by Hajime Morita.

* fast/dom/shadow/shadow-root-js-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove usability of coding-style.html
tkent@chromium.org [Fri, 17 Feb 2012 00:57:14 +0000 (00:57 +0000)]
Improve usability of coding-style.html
https://bugs.webkit.org/show_bug.cgi?id=78470

Reviewed by Eric Seidel.

* coding/coding-style.html:
- Do not add a title attribute to each of LI elements
- Do not add a click handler to each of them
- Add a SPAN element in order to show [id-name] and provide smaller clickable area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the broken viewport tests
mhahnenberg@apple.com [Fri, 17 Feb 2012 00:54:37 +0000 (00:54 +0000)]
Fix the broken viewport tests
https://bugs.webkit.org/show_bug.cgi?id=78774

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/WTFString.cpp:
(WTF):
(WTF::toDoubleType): Template-ized to allow other functions to specify whether they
want to allow trailing junk or not when calling strtod.
(WTF::charactersToDouble):
(WTF::charactersToFloat):
(WTF::charactersToFloatIgnoringJunk): Created new version of charactersToFloat that allows
trailing junk.
* wtf/text/WTFString.h:
(WTF):

Source/WebCore:

No new tests.

* dom/ViewportArguments.cpp:
(WebCore::numericPrefix): Changed to use the new charactersToFloatWithJunk function(s).

LayoutTests:

* platform/gtk/Skipped: Undoing tests skipped due to earlier breakage.
* platform/qt/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Disable mock scrollbars for rubber-banding tests
commit-queue@webkit.org [Fri, 17 Feb 2012 00:49:42 +0000 (00:49 +0000)]
[chromium] Disable mock scrollbars for rubber-banding tests
https://bugs.webkit.org/show_bug.cgi?id=78370

Turning on mock scrollbars caused rubber-banding tests to fail
because the overhang is painted by the ScrollbarTheme, which
was replaced by the mock theme. Disable mock scrollbars for
these tests.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-16
Reviewed by James Robinson.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVery large strings could cause the new quoted string to wrap.
cdn@chromium.org [Fri, 17 Feb 2012 00:48:11 +0000 (00:48 +0000)]
Very large strings could cause the new quoted string to wrap.
https://bugs.webkit.org/show_bug.cgi?id=78387

Reviewed by Eric Seidel.

* css/CSSParser.cpp:
(WebCore::quoteCSSString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a themeChromiumAndroid.css file for android-specific default styles
eric@webkit.org [Fri, 17 Feb 2012 00:46:50 +0000 (00:46 +0000)]
Add a themeChromiumAndroid.css file for android-specific default styles
https://bugs.webkit.org/show_bug.cgi?id=78547

Reviewed by Adam Barth.

This includes the themeChromiumAndroid.css file from the Chromium-Android port
as well as some addidtional changes they had to html.css.  I believe those
changes were made before themeChromiumAndroid was created, but it's now the better place for this CSS.

* WebCore.gyp/WebCore.gyp:
* css/themeChromiumAndroid.css: Added.
(select[size][multiple]):
(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):
(WebCore):
* rendering/RenderThemeChromiumAndroid.h:
(RenderThemeChromiumAndroid):
(WebCore::RenderThemeChromiumAndroid::delegatesMenuListRendering):
(WebCore::RenderThemeChromiumAndroid::platformTapHighlightColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoENH: Add ability to run subset of JavaScript layout tests with JSC
msaboff@apple.com [Fri, 17 Feb 2012 00:46:38 +0000 (00:46 +0000)]
ENH: Add ability to run subset of JavaScript layout tests with JSC
https://bugs.webkit.org/show_bug.cgi?id=78764

Reviewed by Gavin Barraclough.

Tools:

New simple test drive shell script that runs a defined
list of javascript tests using jsc and the standalone-{pre,post}.js
wrappers.

* Scripts/run-fast-jsc: Added.

LayoutTests:

* fast/js/jsc-test-list: Added. List of tests that can be run
using jsc.  Used by new Tools/Scripts/run-fast-jsc script.
* fast/js/resources/standalone-post.js: ~pdated to match changes
in js-test-post.js
* fast/js/resources/standalone-pre.js: Updated to match changes
in js-test-pre.js

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed. Mark fast/js/stack.html as an expected failure, we aren't...
jamesr@google.com [Fri, 17 Feb 2012 00:28:33 +0000 (00:28 +0000)]
[chromium] Unreviewed. Mark fast/js/stack.html as an expected failure, we aren't interesting in converging on
this in v8.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/10616280> and https://bugs.webkit.org/show_bug.cgi?id=78767
beidson@apple.com [Fri, 17 Feb 2012 00:26:03 +0000 (00:26 +0000)]
<rdar://problem/10616280> and https://bugs.webkit.org/show_bug.cgi?id=78767
REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. (Subtle API change attached to a specific application)

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInAPISense): Return true if the app needs the quirk
and there are outstanding subresource loads.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setNeedsIsLoadingInAPISenseQuirk):
(WebCore::Settings::needsIsLoadingInAPISenseQuirk):
(Settings):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _needsIsLoadingInAPISenseQuirk]):
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove [ConvertScriptString] from FileReaderSync.idl
haraken@chromium.org [Fri, 17 Feb 2012 00:10:19 +0000 (00:10 +0000)]
Remove [ConvertScriptString] from FileReaderSync.idl
https://bugs.webkit.org/show_bug.cgi?id=78335

Reviewed by Eric Seidel.

Source/WebCore:

The spec says that FileReadSync should throw NOT_FOUND_ERR
if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync

By this fix, we can completely remove [ConvertScriptString] from WebKit.

Tests: fast/files/workers/worker-read-blob-sync.html
       fast/files/workers/worker-read-file-sync.html

* fileapi/FileReaderSync.cpp: Modified to throw NOT_FOUND_ERR if a blob is invalid.
(WebCore::FileReaderSync::readAsArrayBuffer):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
* fileapi/FileReaderSync.idl:

* bindings/scripts/CodeGeneratorJS.pm: Removed [ConvertScriptString]
since no one is using it.
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(NativeToJSValue):

* bindings/scripts/test/TestObj.idl: Removed a test case for [ConvertScriptString].

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):

LayoutTests:

The spec says that FileReadSync should throw NOT_FOUND_ERR
if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync
This patch adds test cases for FileReaderSync with an invalid blob
to check that NOT_FOUND_ERR is thrown.

* fast/files/resources/read-common.js:
(_readBlobAsArrayBufferSync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):
* fast/files/workers/worker-read-blob-sync-expected.txt:
* fast/files/workers/worker-read-file-sync-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Chromium WebKit API support for IDBObjectStore.delete(IDBKeyRange)
jsbell@chromium.org [Fri, 17 Feb 2012 00:10:09 +0000 (00:10 +0000)]
IndexedDB: Chromium WebKit API support for IDBObjectStore.delete(IDBKeyRange)
https://bugs.webkit.org/show_bug.cgi?id=78619

Add an overload to WebIDBObjectStore::deleteFunction(). First part of a two-sided patch.

Reviewed by Darin Fisher.

* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::deleteFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Feb 2012 00:04:35 +0000 (00:04 +0000)]
2012-02-16  Antonio Gomes  <agomes@rim.com>

       [BlackBerry] Implemented a way to defer client navigation change client notifications
       https://bugs.webkit.org/show_bug.cgi?id=78848

       Reviewed by Rob Buis.

       Currently we postpone touch_down till touch_up if user touches
       the screen and an input field has the WebKit focus. This is done
       so we can scroll the page without hidding the vkb needlessly.

       However, it breaks the conversion of touch to mouse events
       if an input field has the focus in the following scenario:
       an <input type=text> is focused and an user grab and-drag
       a <input type=range> knob/slide. It does not work until the
       user unfocuses the currently focused edit field.

       Patch introduces a way to unfocus a currently focused input field,
       without requesting the client to show or hide the virtual keyboard
       right way. Instead it gets a delayed notification of the vkb mode requested
       at either touch_released/mouse_up or touch_cancel time.

       For now, due to content side issues with major web sites,
       only delay navigation mode notification changes if we are not dealing with
       input modes.

       * WebKitSupport/InputHandler.cpp:
       (BlackBerry::WebKit::InputHandler::InputHandler):
       (BlackBerry::WebKit::InputHandler::nodeFocused):
       (BlackBerry::WebKit::InputHandler::setElementFocused):
       (BlackBerry::WebKit::InputHandler::setNavigationMode):
       (WebKit):
       (BlackBerry::WebKit::InputHandler::setDelayClientNotificationOfNavigationModeChange):
       (BlackBerry::WebKit::InputHandler::processPendingClientNavigationModeChangeNotification):
       (BlackBerry::WebKit::InputHandler::notifyClientOfNavigationModeChange):
       (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
       (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
       (BlackBerry::WebKit::InputHandler::spannableTextInRange):
       (BlackBerry::WebKit::InputHandler::removeComposedText):
       (BlackBerry::WebKit::InputHandler::firstSpanInString):
       (BlackBerry::WebKit::InputHandler::setText):
       (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
       * WebKitSupport/InputHandler.h:
       (InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Feb 2012 00:04:23 +0000 (00:04 +0000)]
2012-02-16  Antonio Gomes  <agomes@rim.com>

        Crash @WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling MKS_2986818
        https://bugs.webkit.org/show_bug.cgi?id=78845

        Reviewed by Rob Buis.

        We were trying to operate on a cached Node when its page/frame/document
        were gone to PageCache already. To avoid such problems, lets clean up
        any document data we have cached when the Frame goes into the cache.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
        (WebCore):
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Feb 2012 00:04:11 +0000 (00:04 +0000)]
2012-02-16 Antonio Gomes <agomes@rim.com>

        [BlackBerry] Upstream touch handling related classes (Part III: InRegionScrollableArea)
        https://bugs.webkit.org/show_bug.cgi?id=78509

        Reviewed by Adam Treat and Rob Buis.

        InRegionScrollableArea specializes the BlackBerry specific ScrollViewBase,
        working as a read-only wrapper object for a scrollable areas in the page.
        It is used in our client side to control in-region scrolling (scrollable boxes,
        inner frames, etc).

        Initial upstream.

        * WebKitSupport/InRegionScrollableArea.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
        (BlackBerry::WebKit::InRegionScrollableArea::calculateMinimumScrollPosition):
        (BlackBerry::WebKit::InRegionScrollableArea::calculateMaximumScrollPosition):
        (BlackBerry::WebKit::InRegionScrollableArea::layer):
        (BlackBerry):
        * WebKitSupport/InRegionScrollableArea.h: Added.
        (WebCore):
        (WebKit):
        (InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAttempt to fix the GTK build.
abarth@webkit.org [Thu, 16 Feb 2012 23:59:27 +0000 (23:59 +0000)]
Attempt to fix the GTK build.

* WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Clipping/Transforms applied in wrong order in opaque paint tracking
commit-queue@webkit.org [Thu, 16 Feb 2012 23:51:00 +0000 (23:51 +0000)]
[chromium] Clipping/Transforms applied in wrong order in opaque paint tracking
https://bugs.webkit.org/show_bug.cgi?id=78775

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by Stephen White.

Source/WebCore:

The clip was being applied in device coordinates, before transforming the painted
rect into device coordinates. This made any translations get doubly represented,
and gave incorrect paint tracking results.

Test: compositing/culling/unscrolled-within-boxshadow.html

Unit test: PlatformContextSkiaTest.cpp

* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDraw):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):

LayoutTests:

* compositing/culling/unscrolled-within-boxshadow-expected.png: Added.
* compositing/culling/unscrolled-within-boxshadow-expected.txt: Added.
* compositing/culling/unscrolled-within-boxshadow.html: Added.
* compositing/overflow/clip-content-under-overflow-controls-expected.png:
* compositing/scrollbar-painting-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash with tables in multi-column layout.
inferno@chromium.org [Thu, 16 Feb 2012 23:35:17 +0000 (23:35 +0000)]
Crash with tables in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78415

Reviewed by Julien Chaffraix.

Source/WebCore:

Multi-column code creates anonymous column blocks directly
under RenderTable, thereby violating table layout assumption.
E.g. Captions in this testcase gets reparented to these anonymous
column blocks and when they go away, they are not able to clear
themselves from table's m_captions list (since RenderTable::removeChild
is not called).

Test: fast/multicol/span/table-multi-column-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):

LayoutTests:

* fast/multicol/span/table-multi-column-crash-expected.txt: Added.
* fast/multicol/span/table-multi-column-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] File system api build is broken
commit-queue@webkit.org [Thu, 16 Feb 2012 23:32:46 +0000 (23:32 +0000)]
[GTK] File system api build is broken
https://bugs.webkit.org/show_bug.cgi?id=78479

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-16
Reviewed by Philippe Normand.

This patch is a small step to support FileSystem API for GTK port.
As I know, bug58443 also dealt with it, but it looks like the submitted patch
needs to be updated. To do that, I think I need to discuss with the original author.
So, I hope to just fix build break issue in this bug.

No new tests. Implementing the feature is not done yet.

* GNUmakefile.list.am: Added some missing files.
* bindings/js/JSDirectoryEntryCustom.cpp: Added Error.h to use its API.
* platform/AsyncFileSystem.cpp:
(WebCore):
(WebCore::AsyncFileSystem::create): The arguments don't match the declaration in AsyncFileSystem.h.
* platform/gtk/AsyncFileSystemGtk.cpp: Added.
(WebCore):
(WebCore::AsyncFileSystem::isAvailable):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemGtk::AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::~AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::toURL):
(WebCore::AsyncFileSystemGtk::move):
(WebCore::AsyncFileSystemGtk::copy):
(WebCore::AsyncFileSystemGtk::remove):
(WebCore::AsyncFileSystemGtk::removeRecursively):
(WebCore::AsyncFileSystemGtk::readMetadata):
(WebCore::AsyncFileSystemGtk::createFile):
(WebCore::AsyncFileSystemGtk::createDirectory):
(WebCore::AsyncFileSystemGtk::fileExists):
(WebCore::AsyncFileSystemGtk::directoryExists):
(WebCore::AsyncFileSystemGtk::readDirectory):
(WebCore::AsyncFileSystemGtk::createWriter):
* platform/gtk/AsyncFileSystemGtk.h: Added.
(WebCore):
(AsyncFileSystemGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHandle dirty descendant visibility status in RenderLayer::updateLayerPositionsAfterScroll
enne@google.com [Thu, 16 Feb 2012 23:30:55 +0000 (23:30 +0000)]
Handle dirty descendant visibility status in RenderLayer::updateLayerPositionsAfterScroll
https://bugs.webkit.org/show_bug.cgi?id=78286

Reviewed by Julien Chaffraix.

This is an unfortunate bandaid over a corner case where sometimes the
visible descendant status dirty flag is true when this function is
called from FrameView::repaintFixedElementsAfterScrolling. As it
should be cheap to refresh this flag when dirty in most cases (as it
early outs after finding any visible descendant), just lazily update
the dirty flag here to ensure correctness.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update table pixel expectations. Unreviewed.
jamesr@google.com [Thu, 16 Feb 2012 23:25:43 +0000 (23:25 +0000)]
[chromium] Update table pixel expectations. Unreviewed.

* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug27038-1-expected.png.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png.
* platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add WEBKIT_EXPORT to new WebDragData methods.
dcheng@chromium.org [Thu, 16 Feb 2012 22:54:43 +0000 (22:54 +0000)]
[chromium] Add WEBKIT_EXPORT to new WebDragData methods.
https://bugs.webkit.org/show_bug.cgi?id=78843

Reviewed by Tony Chang.

* public/platform/WebDragData.h:
(WebDragData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be...
abarth@webkit.org [Thu, 16 Feb 2012 22:50:12 +0000 (22:50 +0000)]
Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
https://bugs.webkit.org/show_bug.cgi?id=78844

Reviewed by Eric Seidel.

These function serve no useful purpose and should be removed.

* page/Chrome.cpp:
(WebCore):
* page/Chrome.h:
(Chrome):
* page/Geolocation.cpp:
(WebCore::Geolocation::reset):
(WebCore::Geolocation::requestPermission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a missing image for my commit r107965.
inferno@chromium.org [Thu, 16 Feb 2012 22:45:14 +0000 (22:45 +0000)]
Add a missing image for my commit r107965.

* fast/multicol/span/clone-flexbox-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement Error.stack
oliver@apple.com [Thu, 16 Feb 2012 22:38:39 +0000 (22:38 +0000)]
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Implement support for stack traces on exception objects.  This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.

* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):

LayoutTests:

Add testcases for producing a stack trace on exception objects.

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):
* fast/js/stack-trace-expected.txt: Added.
* fast/js/stack-trace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 16 Feb 2012 22:03:33 +0000 (22:03 +0000)]
2012-02-16 Antonio Gomes <agomes@rim.com>

        [BlackBerry] Upstream touch handling related classes (part II: FatFingers)
        https://bugs.webkit.org/show_bug.cgi?id=78509

        Reviewed by Rob Buis.

        FatFingers is the class responsible to the whole touch
        accuracy of the BlackBerry port. Initial upstream.

        * WebKitSupport/FatFingers.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
        (BlackBerry::WebKit::hasMousePressListener):
        (BlackBerry::WebKit::FatFingers::isElementClickable):
        (BlackBerry::WebKit::isFieldWithText):
        (BlackBerry::WebKit::distanceBetweenPoints):
        (BlackBerry::WebKit::compareDistanceBetweenPoints):
        (BlackBerry::WebKit::isValidFrameOwner):
        (BlackBerry::WebKit::FatFingers::FatFingers):
        (BlackBerry::WebKit::FatFingers::~FatFingers):
        (BlackBerry::WebKit::FatFingers::findBestPoint):
        (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
        (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
        (BlackBerry::WebKit::FatFingers::checkForClickableElement):
        (BlackBerry::WebKit::FatFingers::checkForText):
        (BlackBerry::WebKit::FatFingers::getPaddings):
        (BlackBerry::WebKit::FatFingers::nodesFromRect):
        (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
        (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
        * WebKitSupport/FatFingers.h: Added.
        (WebCore):
        (WebKit):
        (FatFingersResult):
        (BlackBerry::WebKit::FatFingersResult::FatFingersResult):
        (BlackBerry::WebKit::FatFingersResult::reset):
        (BlackBerry::WebKit::FatFingersResult::originPosition):
        (BlackBerry::WebKit::FatFingersResult::adjustedPosition):
        (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
        (BlackBerry::WebKit::FatFingersResult::isTextInput):
        (BlackBerry::WebKit::FatFingersResult::isValid):
        (BlackBerry::WebKit::FatFingersResult::validNode):
        (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
        (FatFingers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, update baselines for region repaint tests due to skia off...
jamesr@google.com [Thu, 16 Feb 2012 21:32:57 +0000 (21:32 +0000)]
[chromium] Unreviewed, update baselines for region repaint tests due to skia off-by-one.

* platform/chromium-mac-snowleopard/fast/repaint/region-painting-invalidation-expected.png: Added.
* platform/chromium-win/fast/repaint/region-painting-invalidation-expected.png: Added.
* platform/chromium-win/fast/repaint/region-painting-invalidation-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, these regions tests pass after r107961.
tony@chromium.org [Thu, 16 Feb 2012 21:24:51 +0000 (21:24 +0000)]
[chromium] Unreviewed, these regions tests pass after r107961.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed rebaselines and expectation updates.
jamesr@google.com [Thu, 16 Feb 2012 21:20:31 +0000 (21:20 +0000)]
[chromium] Unreviewed rebaselines and expectation updates.

* platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r107952.
philn@webkit.org [Thu, 16 Feb 2012 21:06:25 +0000 (21:06 +0000)]
Unreviewed, GTK rebaseline after r107952.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[soup] Move important SoupSession feature initialization to WebCore
sergio@webkit.org [Thu, 16 Feb 2012 20:56:02 +0000 (20:56 +0000)]
[soup] Move important SoupSession feature initialization to WebCore
https://bugs.webkit.org/show_bug.cgi?id=68602

Reviewed by Martin Robinson.

Source/WebCore:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* webkit/webkitglobals.cpp:
(webkitInit):

Source/WebKit2:

Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.

No new tests required as we're just moving stuff from the
WebProcess to WebCore.

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 16 Feb 2012 20:55:34 +0000 (20:55 +0000)]
2012-02-16 Antonio Gomes <agomes@rim.com>

        [BlackBerry] Upstream touch handling related classes
        https://bugs.webkit.org/show_bug.cgi?id=78509

        Reviewed by Rob Buis.

        Initial upstream of the Blackberry specific single touch event
        handler class.

        * blackberry/WebKitSupport/TouchEventHandler.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::hasMouseMoveListener):
        (BlackBerry::WebKit::hasTouchListener):
        (BlackBerry::WebKit::elementExpectsMouseEvents):
        (BlackBerry::WebKit::shouldConvertTouchToMouse):
        (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
        (BlackBerry::WebKit::TouchEventHandler::~TouchEventHandler):
        (BlackBerry::WebKit::TouchEventHandler::shouldSuppressMouseDownOnTouchDown):
        (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
        (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent):
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
        (BlackBerry::WebKit::TouchEventHandler::spellCheck):
        (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
        (BlackBerry::WebKit::elementForTapHighlight):
        (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
        * blackberry/WebKitSupport/TouchEventHandler.h: Added.
        (WebCore):
        (WebKit):
        (TouchEventHandler):
        (BlackBerry::WebKit::TouchEventHandler::lastFatFingersResult):
        (BlackBerry::WebKit::TouchEventHandler::resetLastFatFingersResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agothead in table without tbody causes table height doubling
jchaffraix@webkit.org [Thu, 16 Feb 2012 20:50:08 +0000 (20:50 +0000)]
thead in table without tbody causes table height doubling
https://bugs.webkit.org/show_bug.cgi?id=37244

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/double-height-table-no-tbody-expected.html
       fast/table/double-height-table-no-tbody.html

The bug is caused by the layout code would wrongly assuming that a
table without a <tbody> is an empty table. We would set the logical
height to the style's logical height wrongly before inflating the
logical height to account for the section(s). This would cause us
to increase past our needed size thus the bug.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
A table is empty if it does not have any top section, not just a <tbody>.
The test uncovered an issue with height distribution in layoutRows where we
would distribute the extra height to the first <tbody> not section.

LayoutTests:

* fast/table/double-height-table-no-tbody-expected.html: Added.
* fast/table/double-height-table-no-tbody.html: Added.
Test that we properly lay out tables with only a <thead> or <tfoot>
exactly like a table with only a <tbody>.

* platform/chromium-linux/tables/mozilla/bugs/bug27038-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.txt:
This is neither a progression nor a regression. We are not doing the right
thing as we don't distribute the extra logical height evenly over our sections.
Now we give the extra height to the <thead> (first section) instead of the <tbody>.

* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:
Marked the previous tests as needing a new baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
robert@webkit.org [Thu, 16 Feb 2012 20:40:20 +0000 (20:40 +0000)]
CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
https://bugs.webkit.org/show_bug.cgi?id=78027

Reviewed by Julien Chaffraix.

Source/WebCore:

Both of these test the (slightly implicit) rule that width set on column-groups cannot
affect the width of columns in a fixed layout table: http://www.w3.org/TR/CSS21/tables.html#fixed-table-layout
FF, Opera and IE all pass these two tests.

Tests: css2.1/20110323/fixed-table-layout-013.htm
       css2.1/20110323/fixed-table-layout-015.htm

* rendering/FixedTableLayout.cpp:
(WebCore::nextCol): A helper function for finding the next column along.
(WebCore::FixedTableLayout::calcWidthArray): Ignore width specified by column groups.
* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableColGroup): Convenience function for identifying column groups.

LayoutTests:

* css2.1/20110323/fixed-table-layout-013-expected.html: Added.
* css2.1/20110323/fixed-table-layout-013.htm: Added.
* css2.1/20110323/fixed-table-layout-015-expected.html: Added.
* css2.1/20110323/fixed-table-layout-015.htm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, tests passing after the fix in r107874.
tony@chromium.org [Thu, 16 Feb 2012 20:32:43 +0000 (20:32 +0000)]
[chromium] Unreviewed, tests passing after the fix in r107874.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r107941.
philn@webkit.org [Thu, 16 Feb 2012 20:32:06 +0000 (20:32 +0000)]
Unreviewed, rolling out r107941.
http://trac.webkit.org/changeset/107941
https://bugs.webkit.org/show_bug.cgi?id=68602

Broke 23 http tests on GTK

Source/WebCore:

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

* webkit/webkitglobals.cpp:
(webkitInit):

Source/WebKit2:

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoXSS Auditor bypass with U+2028/2029
tsepez@chromium.org [Thu, 16 Feb 2012 20:30:09 +0000 (20:30 +0000)]
XSS Auditor bypass with U+2028/2029
https://bugs.webkit.org/show_bug.cgi?id=78732

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html

* html/parser/XSSAuditor.cpp:
(WebCore::isJSNewline):
(WebCore::XSSAuditor::snippetForJavaScript):

LayoutTests:

* http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNPN_GetValueForURL / NPNURLVProxy returns DIRECT when proxy configured via PAC
mrowe@apple.com [Thu, 16 Feb 2012 20:19:57 +0000 (20:19 +0000)]
NPN_GetValueForURL / NPNURLVProxy returns DIRECT when proxy configured via PAC
<http://webkit.org/b/78766> / <rdar://problem/10729283>

Reviewed by Anders Carlsson.

* platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::proxyAutoConfigurationResultCallback): Stop the runloop, and then process
the results that we received.
(WebCore::processProxyServers): Processing of array of proxy configuration information
moved from addProxyServersForURL. Handling of proxy auto-configuration URLs is now handled
by calling CFNetworkExecuteProxyAutoConfigurationURL and waiting synchronously on the result
callback. Doing this synchronously is not great, but it's the best we can do without a lot
of restructuring of the code that calls this. We arbitrarily time out the execution after five
seconds to avoid permanently hanging.
(WebCore::addProxyServersForURL): Call in to our helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix clone() function to handle descendant classes of RenderBlock.
inferno@chromium.org [Thu, 16 Feb 2012 20:16:46 +0000 (20:16 +0000)]
Fix clone() function to handle descendant classes of RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=78273

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/span/clone-flexbox-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):

LayoutTests:

You should see two RenderFlexibleBox in the rendertree, indicating that
cloning was correct.

* fast/multicol/span/clone-flexbox-expected.txt: Added.
* fast/multicol/span/clone-flexbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a perf test for the CSS parser.
alexis.menard@openbossa.org [Thu, 16 Feb 2012 20:14:38 +0000 (20:14 +0000)]
Add a perf test for the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=78114

Reviewed by Ryosuke Niwa.

Add a perf test for the CSS parser. It load a big CSS chunk
which contains some snippets of the YUI library from Yahoo!.

* Parser/css-parser-yui.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd to committers.py
tsepez@chromium.org [Thu, 16 Feb 2012 20:00:22 +0000 (20:00 +0000)]
Add to committers.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening
jamesr@google.com [Thu, 16 Feb 2012 19:57:50 +0000 (19:57 +0000)]
[chromium] Unreviewed gardening

* platform/chromium/fast/js/property-getters-and-setters-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions]overflowRegion tests are flaky
commit-queue@webkit.org [Thu, 16 Feb 2012 19:39:53 +0000 (19:39 +0000)]
[CSSRegions]overflowRegion tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=78761

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-16
Reviewed by Tony Chang.

Source/WebCore:

The overflowRegion tests were updated.

* dom/Element.cpp:
(WebCore::Element::webkitRegionOverflow):

LayoutTests:

* fast/regions/element-region-overflow-state-expected.txt:
* fast/regions/element-region-overflow-state-vertical-rl-expected.txt:
* fast/regions/element-region-overflow-state-vertical-rl.html:
* fast/regions/element-region-overflow-state.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add method to WebPluginContainer to check if a rectangle is topmost
commit-queue@webkit.org [Thu, 16 Feb 2012 19:36:26 +0000 (19:36 +0000)]
[chromium] Add method to WebPluginContainer to check if a rectangle is topmost
https://bugs.webkit.org/show_bug.cgi?id=78166

Patch by Viet-Trung Luu <viettrungluu@chromium.org> on 2012-02-16
Reviewed by Darin Fisher.

* public/WebPluginContainer.h:
(WebPluginContainer):
* src/WebPluginContainerImpl.cpp:
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Repaint issues when changing innerHTML of content
commit-queue@webkit.org [Thu, 16 Feb 2012 19:15:40 +0000 (19:15 +0000)]
[CSS Regions] Repaint issues when changing innerHTML of content
https://bugs.webkit.org/show_bug.cgi?id=78787

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-16
Reviewed by David Hyatt.

Source/WebCore:

The calculation of the clipping rectangle is based on the repaint rectangle,
so it needs to be clipped to the current region, because it might spread over multiple ones.

Test: fast/repaint/region-painting-invalidation.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):

LayoutTests:

* fast/repaint/region-painting-invalidation.html: Added.
* platform/chromium/test_expectations.txt: Needs baseline
* platform/mac/fast/repaint/region-painting-invalidation-expected.png: Added.
* platform/mac/fast/repaint/region-painting-invalidation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed chromium gardening
jamesr@google.com [Thu, 16 Feb 2012 19:12:32 +0000 (19:12 +0000)]
[chromium] Unreviewed chromium gardening

* platform/chromium-linux/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.png: Added.
* platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.txt: Added.
* platform/chromium-mac-leopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/chromium-win/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/chromium-win/svg/text/tspan-dynamic-positioning-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNumerous trivial bugs in Object.defineProperty
barraclough@apple.com [Thu, 16 Feb 2012 19:08:01 +0000 (19:08 +0000)]
Numerous trivial bugs in Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=78777

Reviewed by Sam Weinig.

There are a handful of really trivial bugs, related to Object.defineProperty:
    * Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
    * Calling an undefined setter should only throw in strict mode.
    * When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
    * Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
    * Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
    * If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
    * 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
    * Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
    * Should be able to define an non-configurable accessor.
These are mostly all one-line changes, e.g. inverted boolean checks, masking against wrong attribute.

Source/JavaScriptCore:

* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::put):
    - Added ASSERT.
    - Calling an undefined setter should only throw in strict mode.
(JSC::JSArray::putDescriptor):
    - Should be able to define an non-configurable accessor.
(JSC::JSArray::defineOwnNumericProperty):
    - Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
(JSC::JSArray::putByIndexBeyondVectorLength):
    - If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
* runtime/JSArray.h:
(JSArray):
    - made enterDictionaryMode public, called from JSObject.
* runtime/JSObject.cpp:
(JSC::JSObject::put):
    - Calling an undefined setter should only throw in strict mode.
(JSC::JSObject::preventExtensions):
    - Put array objects into dictionary mode to handle this!
(JSC::JSObject::defineOwnProperty):
    - Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
    - Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorDefineProperties):
    - Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::attributesWithOverride):
    - When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
(JSC::PropertyDescriptor::attributesOverridingCurrent):
    - When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
* runtime/Structure.cpp:
(JSC::Structure::freezeTransition):
    - 'freezeTransition' shouldn't be setting the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
(JSC::Structure::isFrozen):
    - 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').

LayoutTests:

* fast/js/Object-defineProperties-expected.txt:
* fast/js/Object-defineProperty-expected.txt:
* fast/js/preventExtensions-expected.txt:
* fast/js/property-getters-and-setters-expected.txt:
* fast/js/script-tests/Object-defineProperty.js:
* fast/js/script-tests/preventExtensions.js:
* fast/js/script-tests/property-getters-and-setters.js:
    - Update result & add new test cases for all bugs fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/JavaScriptCore: <<<<<<< .mine
barraclough@apple.com [Thu, 16 Feb 2012 19:06:03 +0000 (19:06 +0000)]
Source/JavaScriptCore: <<<<<<< .mine

LayoutTests: <<<<<<< .mine

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll out r107887
aroben@apple.com [Thu, 16 Feb 2012 18:12:25 +0000 (18:12 +0000)]
Roll out r107887

It broke 32-bit builds due to truncation from "long long" to "int".

Original bug is <http://webkit.org/b/76571> Add FractionalLayoutPoint/Size/Rect for
sub-pixel layout

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore::operator==):
(WebCore::operator*):
* platform/graphics/FloatPoint.cpp:
* platform/graphics/FloatPoint.h:
(WebCore):
(FloatPoint):
(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):
* platform/graphics/FloatRect.cpp:
* platform/graphics/FloatRect.h:
(WebCore):
* platform/graphics/FloatSize.cpp:
* platform/graphics/FloatSize.h:
(WebCore):
* platform/graphics/FractionalLayoutPoint.h: Removed.
* platform/graphics/FractionalLayoutRect.cpp: Removed.
* platform/graphics/FractionalLayoutRect.h: Removed.
* platform/graphics/FractionalLayoutSize.cpp: Removed.
* platform/graphics/FractionalLayoutSize.h: Removed.
* platform/graphics/IntRect.cpp:
* platform/graphics/IntRect.h:
(WebCore):
(IntRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: cache settings values
pfeldman@chromium.org [Thu, 16 Feb 2012 18:08:23 +0000 (18:08 +0000)]
Web Inspector: cache settings values
https://bugs.webkit.org/show_bug.cgi?id=78815

Reviewed by Vsevolod Vlasov.

* inspector/front-end/Settings.js:
(WebInspector.Setting.prototype.get if):
(WebInspector.Setting.prototype):
(WebInspector.Setting.prototype.):
(WebInspector.Setting.prototype.set this):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit does not support DOM 3 Events FocusEvent
commit-queue@webkit.org [Thu, 16 Feb 2012 17:51:27 +0000 (17:51 +0000)]
WebKit does not support DOM 3 Events FocusEvent
https://bugs.webkit.org/show_bug.cgi?id=76216

Source/WebCore:

Created a new FocusEvent class (extends UIEvent) with a relatedTarget attribute.  Moved
the {Focus,Blur,FocusIn,FocusOut}EventDispatchMediator classes inside FocusEvent.  Now when
focusin or focusout events are dispatched, a FocusEvent is created with the relatedTarget
attribute set accordingly.  No other logic changes have been made besides adding the
FocusEvent class.

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-02-16
Reviewed by Eric Seidel.

Test: fast/events/related-target-focusevent.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
    - Included mention of FocusEvent / JSFocusEvent in the above files to
      allow the patch to build on the different platforms
* dom/EventDispatchMediator.cpp:
* dom/EventDispatchMediator.h:
* dom/EventFactory.in:
* dom/FocusEvent.cpp: Added.
(WebCore):
(WebCore::FocusEvent::FocusEvent):
(WebCore::FocusEvent::~FocusEvent):
(WebCore::FocusEvent::initFocusEvent):
(WebCore::FocusEvent::interfaceName):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::event):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::event):
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
* dom/FocusEvent.h: Copied from Source/WebCore/dom/EventDispatchMediator.h.
(WebCore):
(FocusEvent):
(WebCore::FocusEvent::create):
(WebCore::FocusEvent::relatedTarget):
(WebCore::FocusEvent::setRelatedTarget):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
* dom/FocusEvent.idl: Added.
* dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
* dom/UIEvent.cpp:
* dom/UIEvent.h:
* page/DOMWindow.idl:

LayoutTests:

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-02-16
Reviewed by Eric Seidel.

* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:
    - Changed the focusin/focusout parts of this layout test to include the
      relatedTarget attribute, which is now set on FocusEvent objects
* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html:
    - Added the creation of FocusEvents to this layout test
* fast/events/related-target-focusevent-expected.txt: Added.
* fast/events/related-target-focusevent.html: Added.
    - This is a new layout test I created specifically for this patch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Improve the way we deal with BGRA extension
noam.rosenthal@nokia.com [Thu, 16 Feb 2012 17:48:04 +0000 (17:48 +0000)]
[Texmap] Improve the way we deal with BGRA extension
https://bugs.webkit.org/show_bug.cgi?id=78822

Source/WebCore:

Swizzle the RGBA manually only in OpenGL ES, and only if the extension is not available.
Pass the pixel-format of the images when updating TextureMapperTiledBackingStore.

Reviewed by Kenneth Rohde Christiansen.

No new behavior.

* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore):
(WebCore::hasExtension):
(WebCore::hasBgraExtension):
(WebCore::BitmapTextureGL::updateContents):
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
* platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperTile):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContents):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):

Source/WebKit2:

Get rid of swizzling in the web process. Instead, we moved swizzling back to
TextureMapperGL, as we're moving towards a setup where textures are uploaded
in the web process.

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createImage):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::adoptImageBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix WebKit2 GTK+ build after r107947.
carlosgc@webkit.org [Thu, 16 Feb 2012 17:45:48 +0000 (17:45 +0000)]
Unreviewed. Fix WebKit2 GTK+ build after r107947.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix linking in debug builds on Mac OS X
commit-queue@webkit.org [Thu, 16 Feb 2012 17:33:40 +0000 (17:33 +0000)]
[Qt] Fix linking in debug builds on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=78811

Patch by Alexander Færøy <ahf@0x90.dk> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/tests/bytearraytestdata.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Page content is incorrectly translated whenh rendering pages for printing in...
carlosgc@webkit.org [Thu, 16 Feb 2012 17:16:10 +0000 (17:16 +0000)]
[GTK] Page content is incorrectly translated whenh rendering pages for printing in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78712

Reviewed by Martin Robinson.

* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::enumeratePrintersFunction):
Simplify the code to select the printer.
(WebKit::WebPrintOperationGtk::renderPage): Call cairo_save()
before rendering the page and cairo_restore() when page has been
rendered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WebKitPrintOperation to WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 16 Feb 2012 17:10:58 +0000 (17:10 +0000)]
[GTK] Add WebKitPrintOperation to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76448

Reviewed by Martin Robinson.

* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitDefines.h:
* UIProcess/API/gtk/WebKitPrintOperation.cpp: Added.
(webViewDestroyed): Delete the print operation when the view
widget associated is destroyed.
(webkitPrintOperationConstructed): Connect to destroy signal of
associated web view.
(webkitPrintOperationGetProperty):
(webkitPrintOperationSetProperty):
(webkit_print_operation_init):
(webkit_print_operation_class_init):
(webkitPrintOperationRunDialogUnix): Use GtkPrintUnixDialog to
show the printing dialog in UNIX platforms.
(webkitPrintOperationRunDialogWin32): Empty, not implemented yet.
(drawPagesForPrintingCompleted): Callback called when printing
operation has finished in the web process.
(webkitPrintOperationRunDialogForFrame): Run the printing dialog
and start printing the given frame.
(webkit_print_operation_new): Create a new print operation for the
given web view.
(webkit_print_operation_get_print_settings):
(webkit_print_operation_set_print_settings):
(webkit_print_operation_get_page_setup):
(webkit_print_operation_set_page_setup):
(webkit_print_operation_run_dialog): Run the print dialog to print
the web view main frame.
* UIProcess/API/gtk/WebKitPrintOperation.h: Added.
* UIProcess/API/gtk/WebKitPrintOperationPrivate.h: Added.
* UIProcess/API/gtk/WebKitUIClient.cpp:
(printFrame): Call webkitWebViewPrintFrame.
(attachUIClientToView): Add implementation for
printFrame callback.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add WebKitWebView::print-requested
signal.
(webkitWebViewPrintFrame): Emit print-requested and show the print
dialog to print the frame when not signal is not handled by user.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitPrintOperation.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestPrinting.cpp: Added.
(testPrintOperationPrintSettings):
(webViewPrintRequestedCallback):
(testWebViewPrintRequested):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/webkit2.h: Include WebKitPrintOperation.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Style clean-up in WebPageCompositor
commit-queue@webkit.org [Thu, 16 Feb 2012 17:09:49 +0000 (17:09 +0000)]
[BlackBerry] Style clean-up in WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=78738

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-16
Reviewed by Rob Buis.

No new functionality, no new tests.

* blackberry/WebKitSupport/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::drawLayers):
* blackberry/WebKitSupport/WebPageCompositor.h:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk][Efl][Qt] Move OpenGLShims out of cairo/ subdirectory
commit-queue@webkit.org [Thu, 16 Feb 2012 17:03:50 +0000 (17:03 +0000)]
[Gtk][Efl][Qt] Move OpenGLShims out of cairo/ subdirectory
https://bugs.webkit.org/show_bug.cgi?id=78800

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The file is not specific to Cairo and used in other ports. Move it into
common space.

* GNUmakefile.list.am:
* PlatformEfl.cmake:
* Target.pri:
* platform/graphics/OpenGLShims.cpp: Renamed from Source/WebCore/platform/graphics/cairo/OpenGLShims.cpp.
(WebCore):
(WebCore::openGLFunctionTable):
(WebCore::getProcAddress):
(WebCore::lookupOpenGLFunctionAddress):
(WebCore::initializeOpenGLShims):
* platform/graphics/OpenGLShims.h: Renamed from Source/WebCore/platform/graphics/cairo/OpenGLShims.h.
(WebCore):
(_OpenGLFunctionTable):
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
* platform/graphics/opengl/TextureMapperGL.cpp:
* platform/graphics/qt/Extensions3DQt.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:

Source/WebKit2:

* UIProcess/qt/LayerTreeHostProxyQt.cpp: Adjust to changed OpenGLShims.h
location - no more cairo prefix needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK baselines for new SVG and fast/ tests.
philn@webkit.org [Thu, 16 Feb 2012 17:00:25 +0000 (17:00 +0000)]
Unreviewed, GTK baselines for new SVG and fast/ tests.

* platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
* platform/gtk/fast/css/font-face-weight-matching-expected.txt: Added.
* platform/gtk/fast/js/constructor-length-expected.txt: Added.
* platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
* platform/gtk/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
* platform/gtk/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
* platform/gtk/svg/text/ems-display-none-expected.txt: Added.
* platform/gtk/svg/text/exs-display-none-expected.txt: Added.
* platform/gtk/svg/text/text-fill-opacity-expected.txt: Added.
* platform/gtk/svg/text/tspan-dynamic-positioning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Allow opaque tiles
noam.rosenthal@nokia.com [Thu, 16 Feb 2012 16:53:31 +0000 (16:53 +0000)]
[Qt][WK2] Allow opaque tiles
https://bugs.webkit.org/show_bug.cgi?id=78809

Source/WebCore:

Add a supportsAlpha property to TiledBackingStore.
We invalidate all the tiles if that property changes, because the buffers need to be
recreated in a different format.

Reviewed by Kenneth Rohde Christiansen.

No behavior changes.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setSupportsAlpha):
(WebCore):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
(WebCore::TiledBackingStore::supportsAlpha):

Source/WebKit2:

Set the supportsAlpha flag for TiledBackingStore when the layer has contentsOpaque enabled.
Use the flag for ShareableBitmaps created by TiledBackingStore.

For now this will not have impact on performance/memory, because we allocate the same type
of buffers for opaque and transparent tiles.

Reviewed by Kenneth Rohde Christiansen.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore):
(WebCore::WebGraphicsLayer::updateContentBuffers):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline.
philn@webkit.org [Thu, 16 Feb 2012 16:46:06 +0000 (16:46 +0000)]
Unreviewed, GTK rebaseline.

* platform/gtk/fast/table/027-expected.txt:
* platform/gtk/fast/table/027-vertical-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug14929-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[soup] Move important SoupSession feature initialization to WebCore
sergio@webkit.org [Thu, 16 Feb 2012 16:41:38 +0000 (16:41 +0000)]
[soup] Move important SoupSession feature initialization to WebCore
https://bugs.webkit.org/show_bug.cgi?id=68602

Reviewed by Martin Robinson.

Source/WebCore:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* webkit/webkitglobals.cpp:
(webkitInit):

Source/WebKit2:

Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.

No new tests required as we're just moving stuff from the
WebProcess to WebCore.

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove free flow DOM editing experiment.
pfeldman@chromium.org [Thu, 16 Feb 2012 16:37:54 +0000 (16:37 +0000)]
Web Inspector: remove free flow DOM editing experiment.
https://bugs.webkit.org/show_bug.cgi?id=78813

Reviewed by Yury Semikhatsky.

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._markRevision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] fast/events/drag-dataTransfer-live-attributes.html fails
philn@webkit.org [Thu, 16 Feb 2012 16:32:16 +0000 (16:32 +0000)]
[GTK] fast/events/drag-dataTransfer-live-attributes.html fails
https://bugs.webkit.org/show_bug.cgi?id=78818

Unreviewed, rebaseline the test and unskip, as advised by Daniel Cheng.

* platform/gtk/Skipped:
* platform/gtk/fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skipping 2 new test failures and unskipping some
philn@webkit.org [Thu, 16 Feb 2012 16:15:47 +0000 (16:15 +0000)]
Unreviewed, skipping 2 new test failures and unskipping some
needing rebaselining.

* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWinCE build fix after r107453.
paroga@webkit.org [Thu, 16 Feb 2012 16:15:04 +0000 (16:15 +0000)]
WinCE build fix after r107453.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::isInBounds): Use fabs() instead of abs().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r107869 and skip a failing test.
philn@webkit.org [Thu, 16 Feb 2012 15:48:41 +0000 (15:48 +0000)]
Unreviewed, GTK rebaseline after r107869 and skip a failing test.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: explicitly mark undoable state from the front-end.
pfeldman@chromium.org [Thu, 16 Feb 2012 15:38:42 +0000 (15:38 +0000)]
Web Inspector: explicitly mark undoable state from the front-end.
https://bugs.webkit.org/show_bug.cgi?id=78716

Reviewed by Vsevolod Vlasov.

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
* inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::redo):
* inspector/InspectorHistory.h:
(InspectorHistory):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._markRevision):
(WebInspector.DOMAgent.prototype.get markUndoableState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: revert 'modification of DOM upon single click for selected nodes'.
pfeldman@chromium.org [Thu, 16 Feb 2012 15:36:39 +0000 (15:36 +0000)]
Web Inspector: revert 'modification of DOM upon single click for selected nodes'.
https://bugs.webkit.org/show_bug.cgi?id=78717

Reviewed by Vsevolod Vlasov.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.onattach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move style disable checkboxes to the left
pfeldman@chromium.org [Thu, 16 Feb 2012 15:34:17 +0000 (15:34 +0000)]
Web Inspector: move style disable checkboxes to the left
https://bugs.webkit.org/show_bug.cgi?id=78780

Reviewed by Vsevolod Vlasov.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/elementsPanel.css:
(.styles-section.matched-styles .properties):
(.styles-section.matched-styles .properties li):
(.styles-section .properties li.parent::before):
(.styles-section .properties li.parent.expanded::before):
(.styles-section.matched-styles .properties li.parent .expand-element):
(.styles-section.matched-styles .properties li.parent.expanded .expand-element):
(.styles-section.computed-style .properties li.parent::before):
(.styles-section.computed-style .properties li.parent.expanded::before):
(.styles-section.matched-styles:not(.read-only):hover .properties .enabled-button):
(.styles-section.matched-styles:not(.read-only) .properties li.disabled .enabled-button):
(.styles-section .properties .enabled-button):
(.styles-section.matched-styles .properties ol.expanded):
* inspector/front-end/treeoutline.js:
(TreeElement.treeElementDoubleClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: show memory counter graphics when switching to memory view
yurys@chromium.org [Thu, 16 Feb 2012 15:32:21 +0000 (15:32 +0000)]
Web Inspector: show memory counter graphics when switching to memory view
https://bugs.webkit.org/show_bug.cgi?id=78808

Switching to memory view in timeline will display memory counters. Counter
graphics know show fair data without approximations between sampling points.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):
(WebInspector.MemoryStatistics.prototype._calculateXValues):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._timelinesOverviewItemSelected):
(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd new Qt performance tester bot to build.webkit.org
ossy@webkit.org [Thu, 16 Feb 2012 15:16:44 +0000 (15:16 +0000)]
Add new Qt performance tester bot to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=78795

Reviewed by Adam Roben.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Thu, 16 Feb 2012 14:58:48 +0000 (14:58 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [heap snapshot] It could be useful to have access to the selected...
loislo@chromium.org [Thu, 16 Feb 2012 14:23:51 +0000 (14:23 +0000)]
Web Inspector: [heap snapshot] It could be useful to have access to the selected heap object from the console.
https://bugs.webkit.org/show_bug.cgi?id=78496

Reviewed by Yury Semikhatsky.

Source/WebCore:

       * bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedObject):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallback):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::InspectableObject::get):
(WebCore):
(WebCore::InjectedScriptHost::addInspectedObject):
(WebCore::InjectedScriptHost::clearInspectedObjects):
(WebCore::InjectedScriptHost::inspectedObject):
* inspector/InjectedScriptHost.h:
(InspectableObject):
(WebCore::InjectedScriptHost::InspectableObject::~InspectableObject):
(InjectedScriptHost):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::domContentLoadedEventFired):
* inspector/InspectorConsoleAgent.cpp:
(InspectableHeapObject):
(WebCore::InspectableHeapObject::InspectableHeapObject):
(WebCore::InspectableHeapObject::get):
(WebCore):
(WebCore::InspectorConsoleAgent::addInspectedHeapObject):
* inspector/InspectorConsoleAgent.h:
(InspectorConsoleAgent):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
* inspector/PageConsoleAgent.cpp:
(InspectableNode):
(WebCore::InspectableNode::InspectableNode):
(WebCore::InspectableNode::get):
(WebCore):
(WebCore::PageConsoleAgent::addInspectedNode):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._selectionChanged):
(WebInspector.DetailedHeapshotView.prototype._inspectedObjectChanged):

LayoutTests:

* inspector/protocol/console-agent-expected.txt:
* inspector/protocol/console-agent.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline after r107881
loislo@chromium.org [Thu, 16 Feb 2012 13:59:58 +0000 (13:59 +0000)]
[chromium] Rebaseline after r107881

* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 13:48:16 +0000 (13:48 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #21 of N.

* platform/chromium-linux-x86/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-linux/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
* platform/chromium-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png:
* platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-win-vista/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-win-xp/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/mac/fast/images/color-jpeg-with-color-profile-expected.png: Renamed from LayoutTests/fast/images/color-jpeg-with-color-profile-expected.png.
* platform/qt/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd support for unsigned long[] to idl bindings to JSC.
commit-queue@webkit.org [Thu, 16 Feb 2012 13:46:34 +0000 (13:46 +0000)]
Add support for unsigned long[] to idl bindings to JSC.
https://bugs.webkit.org/show_bug.cgi?id=78210

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-16
Reviewed by Kentaro Hara.

Add support for unsigned long[] parameter type in idl.
This patch adds support just for unsigned long[] parameter type.
(support for other types of array should be done in another patch.)

tests added to TestObj.idl.

* bindings/js/JSDOMBinding.h:
(WebCore::jsUnsignedLongArrayToVector):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [InspectorIndexedDB] Add IndexedDB TreeElement to resources panel.
vsevik@chromium.org [Thu, 16 Feb 2012 13:30:00 +0000 (13:30 +0000)]
Web Inspector: [InspectorIndexedDB] Add IndexedDB TreeElement to resources panel.
https://bugs.webkit.org/show_bug.cgi?id=78609

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added IndexedDB tree element to resources panel (behind experimental setting).
Test is currently disabled, since we don't run tests with experiments enabled.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* inspector/front-end/Images/indexedDB.png: Added.
* inspector/front-end/Images/indexedDBIndex.png: Added.
* inspector/front-end/Images/indexedDBObjectStore.png: Added.
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype.refreshDatabase):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._originAddedToFrame):
(WebInspector.IndexedDBModel.prototype._originRemoved):
(WebInspector.IndexedDBModel.prototype._databaseAdded):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Frame):
(WebInspector.IndexedDBModel.DatabaseId):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
(WebInspector.IndexedDBModel.Database):
(WebInspector.IndexedDBModel.Index):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement):
(WebInspector.IndexedDBTreeElement.prototype.onexpand):
(WebInspector.IndexedDBTreeElement.prototype._createIndexedDBModel):
(WebInspector.IndexedDBTreeElement.prototype.refreshIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.IndexedDBTreeElement.prototype._idbDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement):
(WebInspector.IDBIndexTreeElement.prototype.update):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/resourcesPanel.css:
(.indexed-db-storage-tree-item .icon):
(.indexed-db-object-store-storage-tree-item .icon):
(.indexed-db-index-storage-tree-item .icon):

LayoutTests:

* http/tests/inspector/indexeddb/database-data-expected.txt:
* http/tests/inspector/indexeddb/database-data.html:
* http/tests/inspector/indexeddb/database-names-expected.txt:
* http/tests/inspector/indexeddb/database-structure-expected.txt:
* http/tests/inspector/indexeddb/database-structure.html:
* http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest.dumpIndexedDBTree):
(initialize_IndexedDBTest.InspectorTest.evaluateWithCallback):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
(createDatabase.closeDatabase):
(createDatabase):
(deleteDatabase):
* http/tests/inspector/indexeddb/resources-panel-expected.txt: Added.
* http/tests/inspector/indexeddb/resources-panel.html_disabled: Added.
* http/tests/inspector/indexeddb/resources/without-indexed-db.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 16 Feb 2012 13:07:36 +0000 (13:07 +0000)]
2012-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing results for Lion, and regenerate one test result with Lion,
        so my baseline passes again with --tolerance 0 -p svg.

        * platform/mac/svg/text/text-fill-opacity-expected.png: Added.
        * platform/mac/svg/text/text-fill-opacity-expected.txt: Added.
        * platform/mac/svg/text/tspan-dynamic-positioning-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (Safari 5.0.5 - 5.1): No animation on svg-wow.org/text-effects/text-effect...
zimmermann@webkit.org [Thu, 16 Feb 2012 12:58:42 +0000 (12:58 +0000)]
REGRESSION (Safari 5.0.5 - 5.1): No animation on svg-wow.org/text-effects/text-effects.xhtml
https://bugs.webkit.org/show_bug.cgi?id=65072

Reviewed by Zoltan Herczeg.

Source/WebCore:

Fix EMS/EXS length resolving, when the target context has no renderer, eg.
<text display="none" dy="1em">ABC</text>, myText.dy.baseVal.getItem(0).value()
currently throws, even if <text> has a parent, we could use to resolve the length.

Always fall-back to parent context, to resolve EMS/EXS units, instead of ignoring it.
The current behaviour stays the same, if the target element is not in the document,
then we really can't resolve lengths like this.

Tests: svg/text/ems-display-none.svg
       svg/text/exs-display-none.svg

* svg/SVGLengthContext.cpp:
(WebCore::renderStyleForLengthResolving):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS):
(WebCore::SVGLengthContext::convertValueFromEMSToUserUnits):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEXS):
(WebCore::SVGLengthContext::convertValueFromEXSToUserUnits):

LayoutTests:

* platform/chromium/test_expectations.txt:
* platform/mac/svg/text/ems-display-none-expected.png: Added.
* platform/mac/svg/text/ems-display-none-expected.txt: Added.
* platform/mac/svg/text/exs-display-none-expected.png: Added.
* platform/mac/svg/text/exs-display-none-expected.txt: Added.
* svg/text/ems-display-none.svg: Added.
* svg/text/exs-display-none.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Qt 5 without QtWidgets.
hausmann@webkit.org [Thu, 16 Feb 2012 12:46:12 +0000 (12:46 +0000)]
Build fix for Qt 5 without QtWidgets.

Reviewed by Tor Arne Vestbø.

The reason why QGLContext is included in Extensions3DQt.cpp is to
achieve an implicit gl.h inclusion (needed for GL_FALSE). This patch
replaces the inclusion with the OpenGLShims.h inclusions, which has
the necessary #ifdefs in place to pull in gl.h with Qt 5 without QtWidgets.

* platform/graphics/qt/Extensions3DQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Refactor CCLayerTreeHostCommon: create helper function for complex boolean...
shawnsingh@chromium.org [Thu, 16 Feb 2012 12:15:50 +0000 (12:15 +0000)]
[chromium] Refactor CCLayerTreeHostCommon: create helper function for complex boolean condition
https://bugs.webkit.org/show_bug.cgi?id=78539

Reviewed by James Robinson.

This change should introduce no change in behavior, and its
expected behavior is already covered by existing tests.

In calculateDrawTransformsAndVisibility, there is a complex
boolean condition that indicates whether we should create a
RenderSurface or not. This patch pulls out that boolean logic,
and wraps it in a helper function for much better readability.

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeSkipped):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [refactoring] move timeline overview sidebar creation to TimelineOverv...
caseq@chromium.org [Thu, 16 Feb 2012 12:11:33 +0000 (12:11 +0000)]
Web Inspector: [refactoring] move timeline overview sidebar creation to TimelineOverviewPane
https://bugs.webkit.org/show_bug.cgi?id=78782

Reviewed by Vsevolod Vlasov.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.showTimelines):
(WebInspector.TimelineOverviewPane.prototype.showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShare font-family CSS values through CSSValuePool.
kling@webkit.org [Thu, 16 Feb 2012 11:05:24 +0000 (11:05 +0000)]
Share font-family CSS values through CSSValuePool.
<http://webkit.org/b/78604>

Reviewed by Darin Adler.

Cache and share FontFamilyValue instances in the per-document CSSValuePool.
This reduces memory consumption by 248 kB on the Moz page cycler (64-bit)
and avoids a bunch of extra work.

This is a regression from the recent attribute style refactoring; previously
the mapped attribute declaration table would ensure that multiple 'font'
elements with the same 'face' value would share the same FontFamilyValue.

We're not yet sharing the entire CSSValueList returned by parseFontFamily()
but this is a step on the way there.

* css/FontFamilyValue.cpp:
* css/FontFamilyValue.h:

    Removed appendSpaceSeparated(), making FontFamilyValue immutable.

* css/CSSParser.cpp:
(FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::add):
(WebCore::FontFamilyValueBuilder::commit):
(WebCore::CSSParser::parseFontFamily):

    Refactor parseFontFamily() to defer creation of FontFamilyValue until
    the whole family name is known. Added a little helper class to avoid
    code duplication.

* css/CSSValuePool.h:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):

    Added a FontFamilyValue cache to CSSValuePool. All values are tied to
    the lifetime of the pool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed brown-paper bag build fix.
hausmann@webkit.org [Thu, 16 Feb 2012 10:47:32 +0000 (10:47 +0000)]
Unreviewed brown-paper bag build fix.

* WebCoreSupport/WebEventConversion.cpp:
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild Fix: R107894 breaks Chromium Linux Build.
tkent@chromium.org [Thu, 16 Feb 2012 10:46:20 +0000 (10:46 +0000)]
Build Fix: R107894 breaks Chromium Linux Build.
https://bugs.webkit.org/show_bug.cgi?id=78790

WebDragDataPrivate::types, inherited from ChromiumDataObject, returns PassRef<DOMStringList> since r107894. However, WebDragData expected to get old return value type HashSet<String>.

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-16
Reviewed by Kent Tamura.

* src/WebDragData.cpp:
(WebKit::WebDragData::items): Use RefPtr<DOMStringList> rather than HashSet<String> for value of m_private->types().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 16 Feb 2012 10:34:04 +0000 (10:34 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip new failing tests.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r107869.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r107869.
* platform/qt/fast/js/global-constructors-expected.txt: Updated after r107869.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Move event conversion functions from WebCore to WebKit
hausmann@webkit.org [Thu, 16 Feb 2012 10:31:01 +0000 (10:31 +0000)]
[Qt] Move event conversion functions from WebCore to WebKit
https://bugs.webkit.org/show_bug.cgi?id=78788

Reviewed by Kenneth Rohde Christiansen.

.:

* Source/api.pri: Add new files to the build.

Source/WebCore:

Move QtWidgets dependent mouse event constructors out of WebCore
into WebKit, similar to the web event conversions of WebKit2.

* Target.pri:
* platform/PlatformMouseEvent.h:
(PlatformMouseEvent):
* platform/PlatformWheelEvent.h:
(PlatformWheelEvent):

Source/WebKit/qt:

Move QtWidgets dependent mouse event constructors out of WebCore
into WebKit, similar to the web event conversions of WebKit2.

* Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPage::swallowContextMenuEvent):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
* WebCoreSupport/WebEventConversion.cpp: Added.
(WebCore):
(WebCore::mouseEventModifiersFromQtKeyboardModifiers):
(WebCore::mouseEventTypeAndMouseButtonFromQEvent):
(WebKitPlatformMouseEvent):
(WebCore::WebKitPlatformMouseEvent::WebKitPlatformMouseEvent):
(WebCore::convertMouseEvent):
(WebKitPlatformWheelEvent):
(WebCore::WebKitPlatformWheelEvent::applyDelta):
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
(WebCore::convertWheelEvent):
* WebCoreSupport/WebEventConversion.h: Added.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin
hausmann@webkit.org [Thu, 16 Feb 2012 10:28:39 +0000 (10:28 +0000)]
[Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=73215

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/qt:

Adding a class to access security information data
(e.g. port/scheme/etc),
while allowing it to be handled in QML side.

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

Introducing a new class to expose security origin information
(port/scheme/etc), useful for inspecting the origin of permission
requests.

* Target.pri:
* UIProcess/API/qt/qtwebsecurityorigin.cpp: Added.
(QtWebSecurityOrigin::QtWebSecurityOrigin):
(QtWebSecurityOrigin::~QtWebSecurityOrigin):
(QtWebSecurityOrigin::host):
(QtWebSecurityOrigin::scheme):
(QtWebSecurityOrigin::path):
(QtWebSecurityOrigin::port):
(QtWebSecurityOrigin::setHost):
(QtWebSecurityOrigin::setScheme):
(QtWebSecurityOrigin::setPath):
(QtWebSecurityOrigin::setPort):
* UIProcess/API/qt/qtwebsecurityorigin_p.h: Added.
* UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Added.
* UIProcess/API/qt/qwebpermissionrequest.cpp:
(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
(QWebPermissionRequest::securityOrigin):
* UIProcess/API/qt/qwebpermissionrequest_p.h:
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed prospective Qt 4.8/Mac build fix.
hausmann@webkit.org [Thu, 16 Feb 2012 10:06:38 +0000 (10:06 +0000)]
Unreviewed prospective Qt 4.8/Mac build fix.

Cast the PlatformWidget from QObject* to QWidget* to gain access
to QWidget methods.

* plugins/mac/PluginViewMac.mm:
(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should not check the types of arguments that are dead
fpizlo@apple.com [Thu, 16 Feb 2012 10:06:28 +0000 (10:06 +0000)]
DFG should not check the types of arguments that are dead
https://bugs.webkit.org/show_bug.cgi?id=78518

Reviewed by Geoff Garen.

The argument checks are now elided if the corresponding SetArgument is dead,
and the abstract value of the argument is set to bottom (None, []). This is
performance neutral on the benchmarks we currently track.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<style scoped>: Implement scoped selector matching in the slow path
rolandsteiner@chromium.org [Thu, 16 Feb 2012 09:31:17 +0000 (09:31 +0000)]
<style scoped>: Implement scoped selector matching in the slow path
https://bugs.webkit.org/show_bug.cgi?id=77528

Source/WebCore:

Added scope information to SelectorCheckingContext, SelectorChecker methods and CSSStyleSelector methods.
Added matchOptions struct to CSSStyleSelector similar to SelectorCheckingContext in SelectorChecker.
Adapted the calling sites.

Reviewed by Antti Koivisto.

No new tests. (extended existing tests)

* css/CSSStyleSelector.cpp:
(RuleData):
(RuleSet):
(WebCore::CSSStyleSelector::determineScopingElement):
(WebCore::CSSStyleSelector::collectMatchingRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForRegion):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
(MatchOptions):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):
(SelectorChecker):

LayoutTests:

Extended existing <style scoped> tests to also verify that selector matching doesn't exceed the scoping element.

Reviewed by Antti Koivisto.

* fast/css/style-scoped/style-scoped-basic-expected.txt:
* fast/css/style-scoped/style-scoped-basic.html:
* fast/css/style-scoped/style-scoped-remove-scoped-expected.txt:
* fast/css/style-scoped/style-scoped-remove-scoped.html:
* fast/css/style-scoped/style-scoped-set-scoped-expected.txt:
* fast/css/style-scoped/style-scoped-set-scoped.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 09:15:53 +0000 (09:15 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #20 of N.

* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 08:50:21 +0000 (08:50 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #19 of N.

* platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
* platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable inspector on WinCE.
paroga@webkit.org [Thu, 16 Feb 2012 08:44:08 +0000 (08:44 +0000)]
Disable inspector on WinCE.

Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107908 268f45cc-cd09-0410-ab3c-d52691b4dbfc