WebKit-https.git
6 years agoREGRESSION(r174567): [GTK] Layout Tests platform/gtk/accessibility/aria-table-hierarc...
jdiggs@igalia.com [Tue, 14 Oct 2014 19:30:08 +0000 (19:30 +0000)]
REGRESSION(r174567): [GTK] Layout Tests platform/gtk/accessibility/aria-table-hierarchy.html and platform/gtk/accessibility/table-hierarchy.html fail
https://bugs.webkit.org/show_bug.cgi?id=137697

These tests were overlooked when updating tests to reflect the correct
mapping for ColumnHeaderRole and RowHeaderRole in ATK.

Reviewed by Chris Fleizach.

* platform/gtk/TestExpectations: Remove two failing tests.
* platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Updated expectations.
* platform/gtk/accessibility/aria-table-hierarchy.html: Updated in-test shouldBe values for headers.
* platform/gtk/accessibility/table-hierarchy-expected.txt: Updated expectations.
* platform/gtk/accessibility/table-hierarchy.html: Updated in-test shouldBe values for headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: paint flashing mode should be disabled when remote inspecting legacy...
commit-queue@webkit.org [Tue, 14 Oct 2014 19:29:41 +0000 (19:29 +0000)]
Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
https://bugs.webkit.org/show_bug.cgi?id=137575

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-14
Reviewed by Simon Fraser.

Remove setShowPaintRects from the legacy iOS protocol definitions.
The methods were unimplemented by the backends, so they should
not advertise supporting it.

* UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-6.0.json:
* Versions/Inspector-iOS-7.0.json:
* Versions/InspectorWeb-iOS-8.0.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Avoid unnecessary dictionary lookup in ImageSource::isSizeAvailable()
cdumez@apple.com [Tue, 14 Oct 2014 19:24:27 +0000 (19:24 +0000)]
[Mac] Avoid unnecessary dictionary lookup in ImageSource::isSizeAvailable()
https://bugs.webkit.org/show_bug.cgi?id=137701

Reviewed by Simon Fraser.

The CG implementation of ImageSource::isSizeAvailable() was looking up
both the width and the height keys in the dictionary before determining
if the size is available. We can abort early and return false if the
first key (the width) is missing, thus avoiding an extra dictionary
lookup in this case.

This is a small win but ImageSource::isSizeAvailable() is called quite
frequently during page loads

No new tests, no behavior change.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::isSizeAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoves references to LLVMJIT which is no longer part of LLVM
mmirman@apple.com [Tue, 14 Oct 2014 19:22:41 +0000 (19:22 +0000)]
Removes references to LLVMJIT which is no longer part of LLVM
https://bugs.webkit.org/show_bug.cgi?id=137708

Reviewed by Filip Pizlo.

* Configurations/LLVMForJSC.xcconfig: removed -lLLVMJIT
* llvm/LLVMAPIFunctions.h: removed LinkInJIT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[cmake] Fix the make build after r174683
ossy@webkit.org [Tue, 14 Oct 2014 19:12:42 +0000 (19:12 +0000)]
[cmake] Fix the make build after r174683
https://bugs.webkit.org/show_bug.cgi?id=137703

Reviewed by Martin Robinson.

* Scripts/webkitdirs.pm:
(buildCMakeGeneratedProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Add some logging to debug random crashing when running layout tests on...
roger_fong@apple.com [Tue, 14 Oct 2014 18:36:04 +0000 (18:36 +0000)]
[Windows] Add some logging to debug random crashing when running layout tests on Windows.

* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unnecessary logging from SimpleFontData
mmaxfield@apple.com [Tue, 14 Oct 2014 18:32:01 +0000 (18:32 +0000)]
Remove unnecessary logging from SimpleFontData
https://bugs.webkit.org/show_bug.cgi?id=137699

Reviewed by Andreas Kling.

Because of web fonts, fonts that don't have a glyph page 0 are common and expected. Printing out a
message is not helpful, especially if you're not dealing with a font-related piece of WebKit.

No new tests because there is no behavior change.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdding myself to the watchlist to CachedFont
mmaxfield@apple.com [Tue, 14 Oct 2014 18:24:51 +0000 (18:24 +0000)]
Adding myself to the watchlist to CachedFont

Unreviewed.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAddressing post-review comment.
mmaxfield@apple.com [Tue, 14 Oct 2014 18:05:12 +0000 (18:05 +0000)]
Addressing post-review comment.
https://bugs.webkit.org/show_bug.cgi?id=137550

Unreviewed.

* WebView/WebHTMLView.mm:
(fontNameForDescription):
(-[WebHTMLView _addToStyle:fontA:fontB:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate ViewportConfiguration whenever its size attributes change
mhock@apple.com [Tue, 14 Oct 2014 17:57:48 +0000 (17:57 +0000)]
Update ViewportConfiguration whenever its size attributes change
https://bugs.webkit.org/show_bug.cgi?id=137682
rdar://problem/18643655

Reviewed by Benjamin Poulain.

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setMinimumLayoutSize):
(WebCore::ViewportConfiguration::setMinimumLayoutSizeForMinimalUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Processing Instruction Nodes appear poorly in DOM Tree
commit-queue@webkit.org [Tue, 14 Oct 2014 17:53:34 +0000 (17:53 +0000)]
Web Inspector: Processing Instruction Nodes appear poorly in DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=137681

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-14
Reviewed by Timothy Hatcher.

Source/WebCore:

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
Include the nodeName, localName, and nodeValue (string data)
properties for processing instruction nodes.

Source/WebInspectorUI:

Handle processing instruction node types in more places. The
backend sends the contents as a pure string, not as attribute
pairs, so just include the string in the UI.

* UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.prototype._generateClassName):
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
Display the value in the UI.

* UserInterface/Views/DOMTreeElementPathComponent.js:
(WebInspector.DOMTreeElementPathComponent):
Include an icon like DOCTYPE.

* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.syntax-highlighted .html-processing-instruction):
Style gray like a DOCTYPE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse is<>() / downcast<>() for RenderFrame / RenderFrameSet
cdumez@apple.com [Tue, 14 Oct 2014 17:31:59 +0000 (17:31 +0000)]
Use is<>() / downcast<>() for RenderFrame / RenderFrameSet
https://bugs.webkit.org/show_bug.cgi?id=137696

Reviewed by Darin Adler.

Use is<>() / downcast<>() for RenderFrame / RenderFrameSet.

No new tests, no behavior change.

* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::defaultEventHandler):
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::updateFromElement):
* rendering/RenderFrame.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::computeEdgeInfo):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
* rendering/RenderFrameSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed GTK gardening.
clopez@igalia.com [Tue, 14 Oct 2014 17:18:36 +0000 (17:18 +0000)]
[GTK] Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Report new failures and update expectations.
* platform/gtk/css3/selectors3/html/css3-modsel-61-expected.txt: Rebaseline after r174535.
* platform/gtk/css3/selectors3/html/css3-modsel-83-expected.txt: Rebaseline after r174535.
* platform/gtk/css3/selectors3/xhtml/css3-modsel-61-expected.txt: Rebaseline after r174535.
* platform/gtk/css3/selectors3/xhtml/css3-modsel-83-expected.txt: Rebaseline after r174535.
* platform/gtk/css3/selectors3/xml/css3-modsel-61-expected.txt: Rebaseline after r174535.
* platform/gtk/css3/selectors3/xml/css3-modsel-83-expected.txt: Rebaseline after r174535.
* platform/gtk/fast/borders/bidi-002-expected.txt: Rebaseline after r174160.
* platform/gtk/fast/borders/bidi-009a-expected.txt: Rebaseline after r174160.
* platform/gtk/fast/selectors/061-expected.txt: Rebaseline after r174535.
* platform/gtk/fast/selectors/083-expected.txt: Rebaseline after r174535.
* platform/gtk/mathml/opentype/horizontal-expected.txt: Rebaseline after r174540.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[XHR] Abort method execution when m_loader->cancel() in internalAbort() caused reentry
commit-queue@webkit.org [Tue, 14 Oct 2014 17:10:24 +0000 (17:10 +0000)]
[XHR] Abort method execution when m_loader->cancel() in internalAbort() caused reentry
https://bugs.webkit.org/show_bug.cgi?id=126975

Patch by Youenn Fablet <youennf@gmail.com> on 2014-10-14
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merging https://chromium.googlesource.com/chromium/blink/+/0d75daf2053631518606ae15daaece701a25b2c4
Ensuring new test from https://codereview.chromium.org/76133002/ is passing.

Test: http/tests/xmlhttprequest/reentrant-cancel-abort.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open): exit early if internalAbort asks so
(WebCore::XMLHttpRequest::abort): exit early if internalAbort asks so
(WebCore::XMLHttpRequest::internalAbort): ask calling function to exit early if a new loader is created during the cancellation of the loader (potential reentrant case through window.onload callback)
(WebCore::XMLHttpRequest::didTimeout): exit early if internalAbort asks so
* xml/XMLHttpRequest.h:

LayoutTests:

Adding reentrant-cancel-abort.html (from https://codereview.chromium.org/76133002/)
that crashes without the patch
Updated reentrant-cancel.html test to expect the exception
that is now hit in initSend function (since a XHR open() call is aborted)

* http/tests/xmlhttprequest/reentrant-cancel-abort-expected.txt: Added.
* http/tests/xmlhttprequest/reentrant-cancel-abort.html: Added.
* http/tests/xmlhttprequest/reentrant-cancel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][GTK] Make it possible to get verbose output with ninja
evab.u-szeged@partner.samsung.com [Tue, 14 Oct 2014 16:42:53 +0000 (16:42 +0000)]
[EFL][GTK] Make it possible to get verbose output with ninja
https://bugs.webkit.org/show_bug.cgi?id=137606

Reviewed by Csaba Osztrogon√°c.

* Scripts/webkitdirs.pm:
(buildCMakeGeneratedProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win32] Thunk is not implemented.
commit-queue@webkit.org [Tue, 14 Oct 2014 16:25:25 +0000 (16:25 +0000)]
[Win32] Thunk is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=137691

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-10-14
Reviewed by Mark Lam.

Thunks for functions with double operands (floor, etc.) are not implemented on Win32.

* jit/ThunkGenerators.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Make it possible to use ninja for EFL build too
evab.u-szeged@partner.samsung.com [Tue, 14 Oct 2014 12:09:52 +0000 (12:09 +0000)]
[EFL] Make it possible to use ninja for EFL build too
https://bugs.webkit.org/show_bug.cgi?id=137605

Reviewed by Csaba Osztrogon√°c.

* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
* efl/install-dependencies:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd test to check stretchy value is case sensitive
alex@webkit.org [Tue, 14 Oct 2014 10:56:04 +0000 (10:56 +0000)]
Add test to check stretchy value is case sensitive
https://bugs.webkit.org/show_bug.cgi?id=137602

Reviewed by Darin Adler.

* mathml/presentation/mo-stretchy-case-sensitive-expected.html: Added.
* mathml/presentation/mo-stretchy-case-sensitive.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Minibrowser : Add home buton and keyboard support for home page load
commit-queue@webkit.org [Tue, 14 Oct 2014 10:49:09 +0000 (10:49 +0000)]
[GTK] Minibrowser : Add home buton and keyboard support for home page load
https://bugs.webkit.org/show_bug.cgi?id=137486

Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-10-14
Reviewed by Philippe Normand.

* MiniBrowser/gtk/BrowserWindow.c:
(loadHomePage): Callback for home page load.
(browser_window_init):
* MiniBrowser/gtk/BrowserWindow.h:
* MiniBrowser/gtk/main.c:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMultiple refactors in RenderMathMLOperator
alex@webkit.org [Tue, 14 Oct 2014 10:05:03 +0000 (10:05 +0000)]
Multiple refactors in RenderMathMLOperator
https://bugs.webkit.org/show_bug.cgi?id=137611

Reviewed by Darin Adler.

The changes include:
- Rename m_operator to m_textContent.
- Make most of the functions private, we needed to create some
public member functions to be able to make the some funtions private
and move trailingSpaceError to RenderMathMLOperator.
- Fix incorrect capitalization of setOperatorProperties function.
- Make all data members private and move them to the end of the
class defition.

No new tests as no change in functionality.

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::setOperatorProperties): Renamed,
incorrect capitalization
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLOperator::rebuildTokenContent):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::updateOperatorProperties):
(WebCore::RenderMathMLOperator::shouldAllowStretching):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::trailingSpaceError):
(WebCore::RenderMathMLOperator::SetOperatorProperties): Deleted.
(WebCore::RenderMathMLOperator::advanceForGlyph): Deleted.
(WebCore::RenderMathMLOperator::updateTokenContent): Deleted.
(WebCore::RenderMathMLOperator::getGlyphAssemblyFallBack): Deleted.
* rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::setLeadingSpace): Added.
(WebCore::RenderMathMLOperator::setTrailingSpace):  Added.
(WebCore::RenderMathMLOperator::textContent): Added.
(WebCore::RenderMathMLOperator::isInvisibleOperator):
* rendering/mathml/RenderMathMLRadicalOperator.cpp:
(WebCore::RenderMathMLRadicalOperator::setOperatorProperties):
Renamed, incorrect capitalization
(WebCore::RenderMathMLRadicalOperator::SetOperatorProperties): Deleted.
(WebCore::RenderMathMLRadicalOperator::trailingSpaceError): Deleted.
* rendering/mathml/RenderMathMLRadicalOperator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChanges in the stretchy attribute do not update rendering
alex@webkit.org [Tue, 14 Oct 2014 09:53:59 +0000 (09:53 +0000)]
Changes in the stretchy attribute do not update rendering
https://bugs.webkit.org/show_bug.cgi?id=136883

Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/presentation/mo-stretch-update.html

We need to relayout when a change in the stretchy attribute
happens.

* mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::parseAttribute): Parse the
modifications of the stretchy attribute.
* mathml/MathMLTextElement.h:
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::setOperatorFlagAndScheduleLayoutIfNeeded):
Add function that receives the value instead of looking for it and
checks if the change should schedule a layout.
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttributeValue):
Add function that receives the value instead of looking for it.
* rendering/mathml/RenderMathMLOperator.h:

LayoutTests:

The test updates the stretchy value in a timeout.

* mathml/presentation/mo-stretch-update-expected.html: Added.
* mathml/presentation/mo-stretch-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse is<>() / downcast<>() for RenderImage
cdumez@apple.com [Tue, 14 Oct 2014 09:07:21 +0000 (09:07 +0000)]
Use is<>() / downcast<>() for RenderImage
https://bugs.webkit.org/show_bug.cgi?id=137683

Reviewed by Mihnea Ovidenie.

Use is<>() / downcast<>() for RenderImage.

Source/WebCore:

No new tests, no behavior change.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeText):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
* bindings/objc/DOM.mm:
(-[DOMElement image]):
(-[DOMElement _imageTIFFRepresentation]):
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleReplacedElement):
* editing/cocoa/HTMLConverter.mm:
(fileWrapperForElement):
* editing/gtk/EditorGtk.cpp:
(WebCore::getImageForElement):
* editing/ios/EditorIOS.mm:
(WebCore::getImage):
* editing/mac/EditorMac.mm:
(WebCore::getImage):
* html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::setFocus):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::didAttachRenderers):
(WebCore::HTMLImageElement::createImageControls):
(WebCore::HTMLImageElement::destroyImageControls):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::didAttachRenderers):
(WebCore::HTMLVideoElement::parseAttribute):
* html/ImageInputType.cpp:
(WebCore::ImageInputType::altAttributeChanged):
(WebCore::ImageInputType::attach):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::size):
* html/shadow/mac/ImageControlsRootElementMac.cpp:
(WebCore::RenderImageControls::updateLogicalWidth):
(WebCore::RenderImageControls::computeLogicalHeight):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::renderImageResource):
* page/ContextMenuController.cpp:
(WebCore::imageFromImageElementNode):
* page/DragController.cpp:
(WebCore::getCachedImage):
(WebCore::getImage):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
(WebCore::getCachedImage):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::image):
* rendering/RenderImage.h:
* rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::getImageSize):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
(WebCore::RenderLayerBacking::updateImageContents):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::createShapeForImage):

Source/WebKit/mac:

* Misc/WebNSPasteboardExtras.mm:
(imageFromElement):
(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::cachedImage):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::performActionOnElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[AX] Improve AccessibilityTableCell columnHeaders and rowHeaders functions.
commit-queue@webkit.org [Tue, 14 Oct 2014 08:18:32 +0000 (08:18 +0000)]
[AX] Improve AccessibilityTableCell columnHeaders and rowHeaders functions.
https://bugs.webkit.org/show_bug.cgi?id=136818

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-10-14
Reviewed by Chris Fleizach.

Source/WebCore:

Take into account that <th> elements can be both the column headers and row headers
improved the operation of two functions: columnHeaders and rowHeaders.

Test: accessibility/table-headers.html

* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::isColumnHeaderCell):
A new function that helps the main goal.
(WebCore::AccessibilityTableCell::isRowHeaderCell):
A new function that helps the main goal.
(WebCore::AccessibilityTableCell::columnHeaders):
Use isColumnHeaderCell instead of isTableHeaderCell.
(WebCore::AccessibilityTableCell::rowHeaders):
Use isRowHeaderCell also includes <th> row header element next to the scope attribute.
* accessibility/AccessibilityTableCell.h:
Adds new functions to the header file.

LayoutTests:

* accessibility/table-headers-expected.txt: Added.
* accessibility/table-headers.html: Added.
* platform/mac/accessibility/table-attributes-expected.txt:
* platform/mac/accessibility/table-cells-expected.txt:
* platform/mac/accessibility/table-sections-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the !ENABLE(VIDEO) build after r174353
ossy@webkit.org [Tue, 14 Oct 2014 08:14:01 +0000 (08:14 +0000)]
Fix the !ENABLE(VIDEO) build after r174353
https://bugs.webkit.org/show_bug.cgi?id=137655

Reviewed by Darin Adler.

* dom/Document.cpp:
* dom/Document.h:
* page/Page.cpp:
* page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Curl] Compile error in CurlDownload.cpp.
commit-queue@webkit.org [Tue, 14 Oct 2014 08:11:19 +0000 (08:11 +0000)]
[Curl] Compile error in CurlDownload.cpp.
https://bugs.webkit.org/show_bug.cgi?id=137654

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-10-14
Reviewed by Philippe Normand.

A template specialization is not needed anymore.

* platform/network/curl/CurlDownload.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoimport-w3c-tests doesn't prefix property values
rego@igalia.com [Tue, 14 Oct 2014 08:08:05 +0000 (08:08 +0000)]
import-w3c-tests doesn't prefix property values
https://bugs.webkit.org/show_bug.cgi?id=137600

Reviewed by Bem Jones-Bey.

Some property values are prefixed in WebKit. Modified the W3C import
script in order to prefix property values and not only properties.
The patch re-uses most of the already existent logic to prefix
properties.

* Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
from CSSValueKeywords.in and adapt converter to modify both properties
and property values.
(convert_for_webkit):
(_W3CTestConverter.__init__):
(_W3CTestConverter.output):
(_W3CTestConverter.read_webkit_prefixed_css_property_list):
(_W3CTestConverter):
(_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
(_W3CTestConverter.add_webkit_prefix_following_regex):
(_W3CTestConverter.convert_reference_relpaths):
(_W3CTestConverter.convert_style_data):
(_W3CTestConverter.convert_attributes_if_needed):
(_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
* Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
include checks for property values too.
(W3CTestConverterTest.test_read_prefixed_property_list):
(verify_no_conversion_happened):
(verify_prefixed_properties):
(verify_prefixed_property_values):
(generate_test_content_properties_and_values):
(generate_test_content):
* Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
prefixed property values and inform about them.
(TestImporter.import_tests):
(TestImporter.write_import_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][CMake] Non-ninja build is broken since r174422
carlosgc@webkit.org [Tue, 14 Oct 2014 06:58:15 +0000 (06:58 +0000)]
[GTK][CMake] Non-ninja build is broken since r174422
https://bugs.webkit.org/show_bug.cgi?id=137656

Reviewed by Philippe Normand.

Make WebKit2-forwarding-headers depend only on static,
non-generated sources.

* CMakeLists.txt:
* PlatformGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Paint Flashing button does not match page state after reload
commit-queue@webkit.org [Tue, 14 Oct 2014 04:43:53 +0000 (04:43 +0000)]
Web Inspector: Paint Flashing button does not match page state after reload
https://bugs.webkit.org/show_bug.cgi?id=137680

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-13
Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.loaded):
Make paint flashing a frontend setting. Enable it when the inspector
is opened if it was previously enabled.

* UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView):
(WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
(WebInspector.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
Have the paint flashing button always match the global setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd test coverage for the more complex cases of :not()
benjamin@webkit.org [Tue, 14 Oct 2014 01:31:00 +0000 (01:31 +0000)]
Add test coverage for the more complex cases of :not()
https://bugs.webkit.org/show_bug.cgi?id=137671

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-10-13
Reviewed by Andreas Kling.

Those tests cover the future CSS JIT support of :not(). I'll to the implementation
split over multiple patch, better put the tests first.

* fast/selectors/not-backtracking-expected.txt: Added.
* fast/selectors/not-backtracking.html: Added.
* fast/selectors/not-boundaries-expected.txt: Added.
* fast/selectors/not-boundaries.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore:
commit-queue@webkit.org [Tue, 14 Oct 2014 01:30:03 +0000 (01:30 +0000)]
Source/WebCore:
Web Inspector: Remove unused stale Page protocol methods
https://bugs.webkit.org/show_bug.cgi?id=137678

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-13
Reviewed by Andreas Kling.

* inspector/InspectorClient.h:
(WebCore::InspectorClient::canShowDebugBorders): Deleted.
(WebCore::InspectorClient::setShowDebugBorders): Deleted.
(WebCore::InspectorClient::canShowFPSCounter): Deleted.
(WebCore::InspectorClient::setShowFPSCounter): Deleted.
(WebCore::InspectorClient::canContinuouslyPaint): Deleted.
(WebCore::InspectorClient::setContinuousPaintingEnabled): Deleted.
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowDebugBorders): Deleted.
(WebCore::InspectorPageAgent::setShowDebugBorders): Deleted.
(WebCore::InspectorPageAgent::canShowFPSCounter): Deleted.
(WebCore::InspectorPageAgent::setShowFPSCounter): Deleted.
(WebCore::InspectorPageAgent::canContinuouslyPaint): Deleted.
(WebCore::InspectorPageAgent::setContinuousPaintingEnabled): Deleted.
* inspector/InspectorPageAgent.h:
* inspector/protocol/Page.json:

Source/WebInspectorUI:
Web Inspector: Improve appearance of alpha color swatches
https://bugs.webkit.org/show_bug.cgi?id=137627

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-13
Reviewed by Andreas Kling.

* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-7.0.json:
* Versions/InspectorWeb-iOS-8.0.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMediaPlayer::characteristicChanged() is not called when new tracks are found in Sourc...
jer.noble@apple.com [Tue, 14 Oct 2014 01:16:25 +0000 (01:16 +0000)]
MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=137533

Reviewed by Andy Estes.

Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.

* TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
(TestWebKitAPI::isMSEEnabledCallback):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Refactor AirPlay monitoring code
eric.carlson@apple.com [Tue, 14 Oct 2014 00:22:49 +0000 (00:22 +0000)]
[iOS] Refactor AirPlay monitoring code
https://bugs.webkit.org/show_bug.cgi?id=137645
<rdar://problem/18444817>

Reviewed by Jer Noble.

Refactor AirPlay route change monitoring code:
+ Have MediaSessionManager register/unregister for route changes depending on the state of
    all sessions so it does the right thing when there is more than one media element.
+ Make HTMLMediaElement unregister with MediaSession as soon as the media player is cleared
    because there can be no wireless playback without a player.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call mediaSession->setHasPlaybackTargetAvailabilityListeners
    when there are target availability changed listeners.
(WebCore::HTMLMediaElement::clearMediaPlayer): Ditto.
(WebCore::HTMLMediaElement::wirelessRoutesAvailableDidChange): New, media session client method.
* html/HTMLMediaElement.h:

* html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::HTMLMediaSession): Initialize m_hasPlaybackTargetAvailabilityListeners.
(WebCore::HTMLMediaSession::setHasPlaybackTargetAvailabilityListeners): Remember whether or not
    the client has a target availability listener and tell the media session manager to reconfigure
    itself instead of telling it to start or stop listening for route changes so it does the
    right thing when there is more than one media element.
* html/HTMLMediaSession.h:
(WebCore::HTMLMediaSession::requiresPlaybackTargetRouteMonitoring): Return true when the client
    has a target availability listener, false otherwise.

* platform/audio/MediaSession.cpp:
(WebCore::MediaSession::wirelessRoutesAvailableDidChange): Inform the client that routes have changed.
* platform/audio/MediaSession.h:
(WebCore::MediaSession::requiresPlaybackTargetRouteMonitoring):
(WebCore::MediaSessionClient::wirelessRoutesAvailableDidChange):

* platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::wirelessRoutesAvailableChanged): Implement it.
* platform/audio/MediaSessionManager.h:
(WebCore::MediaSessionManager::configureWireLessTargetMonitoring):
(WebCore::MediaSessionManager::hasWirelessTargetsAvailable):
(WebCore::MediaSessionManager::sessions):
(WebCore::MediaSessionManager::startMonitoringAirPlayRoutes): Deleted.
(WebCore::MediaSessionManager::stopMonitoringAirPlayRoutes): Deleted.

* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::configureWireLessTargetMonitoring): Start or stop monitoring
    for route changes depending on client state.
(WebCore::MediaSessionManageriOS::startMonitoringAirPlayRoutes): Deleted.
(WebCore::MediaSessionManageriOS::stopMonitoringAirPlayRoutes): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Return value of createImageSourceOptions() is leaked in ImageSourceCG
cdumez@apple.com [Mon, 13 Oct 2014 23:46:20 +0000 (23:46 +0000)]
[Mac] Return value of createImageSourceOptions() is leaked in ImageSourceCG
https://bugs.webkit.org/show_bug.cgi?id=137677

Reviewed by Simon Fraser.

The return value of createImageSourceOptions() was leaked in
ImageSourceCG.cpp. It was returning a CFDictionaryRef created using
CFDictionaryCreate(). Therefore, the return value should have been
released but wasn't.

This patch makes createImageSourceOptions() return a
RetainPtr<CFDictionaryRef> to make sure the CFDictionaryRef properly
gets released after use.

No new tests, no behavior change.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::createImageSourceOptions):
(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Implement a page load profiling tool
bfulgham@apple.com [Mon, 13 Oct 2014 23:10:20 +0000 (23:10 +0000)]
[Win] Implement a page load profiling tool
https://bugs.webkit.org/show_bug.cgi?id=137673

Reviewed by Dean Jackson.

Source/WebKit/win:

Add a new predicate (isMainFrame) to the IWebFrame interface so
that we can make decisions about a frames position in the page
load hierarchy in client programs.

* Interfaces/IWebFrame.idl: Added new isMainFrame
predicate to interface definition.
* WebFrame.cpp:
(WebFrame::isMainFrame): Added.
* WebFrame.h:

Tools:

Add a tool to capture and summarize page load statistics.

* WinLauncher/Common.cpp:
(parseCommandLine): Move from WinMain.cpp so that it can
be shared with internal tools.
* WinLauncher/PageLoadTestClient.cpp: Added.
(PageLoadTestClient::PageLoadTestClient):
(PageLoadTestClient::pageLoadStartedAtTime):
(PageLoadTestClient::didStartProvisionalLoad):
(PageLoadTestClient::didCommitLoad):
(PageLoadTestClient::didFirstLayoutForMainFrame):
(PageLoadTestClient::didHandleOnLoadEvents):
(PageLoadTestClient::didFinishLoad):
(PageLoadTestClient::didFailLoad):
(PageLoadTestClient::didInitiateResourceLoad):
(PageLoadTestClient::didEndResourceLoad):
(PageLoadTestClient::pageLoadEndedAtTime):
(PageLoadTestClient::endPageLoad):
(PageLoadTestClient::clearPageLoadState):
(PageLoadTestClient::shouldConsiderPageLoadEnded):
(PageLoadTestClient::maybeEndPageLoadSoon):
(PageLoadTestClient::setPageURL):
(PageLoadTestClient::dumpRunStatistics):
* WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::createWebViewWithRequest): Handle
nullptr URL properly.
* WinLauncher/ResourceLoadDelegate.cpp: Added.
(ResourceLoadDelegate::QueryInterface):
(ResourceLoadDelegate::AddRef):
(ResourceLoadDelegate::Release):
(ResourceLoadDelegate::identifierForInitialRequest):
(ResourceLoadDelegate::willSendRequest):
(ResourceLoadDelegate::didReceiveAuthenticationChallenge):
(ResourceLoadDelegate::didCancelAuthenticationChallenge):
(ResourceLoadDelegate::didReceiveResponse):
(ResourceLoadDelegate::didReceiveContentLength):
(ResourceLoadDelegate::didFinishLoadingFromDataSource):
(ResourceLoadDelegate::didFailLoadingWithError):
(ResourceLoadDelegate::plugInFailedWithError):
* WinLauncher/ResourceLoadDelegate.h: Added.
(ResourceLoadDelegate::ResourceLoadDelegate):
* WinLauncher/WinLauncher.cpp:
(WinLauncher::WinLauncher): Accept argument to indicate we want to capture
page loading statistics.
(WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
and set private load delegate state.
(WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
that sets the view's resource load delegate.
(WinLauncher::loadURL): If no URL is passed, load the test document.
* WinLauncher/WinLauncher.h:
(WinLauncher::pageLoadTestClient):
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
* WinLauncher/WinLauncherWebHost.cpp:
(WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
(WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
it could be used from other source files.
(WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
(WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
(WinLauncherWebHost::didFailLoadWithError): Ditto.
(WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
(WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
(WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
(WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
(WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
* WinLauncher/WinLauncherWebHost.h:
* WinLauncher/WinMain.cpp:
(wWinMain): Create and use new delegates for gathering page load data.
* WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCSS JIT: Implement :visited pseudo class
utatane.tea@gmail.com [Mon, 13 Oct 2014 22:46:59 +0000 (22:46 +0000)]
CSS JIT: Implement :visited pseudo class
https://bugs.webkit.org/show_bug.cgi?id=135293

Reviewed by Benjamin Poulain.

Source/WebCore:

This patch implements CSS JIT for :visited. And it makes :not(:link) JIT-ed.
Following the design discussed at the other bug[1], implemented :visited JIT
without tracking VisitedMatchEnabled state.

In this patch, we change the semantics of :visited / :link
inside functional pseudo classes for further CSS Selector Level 4 extensions.

Edge cases are tested by the existing tests.
:not(:link)
    fast/history/link-inside-not.html
:not(:visited)
    fast/history/visited-inside-not.html
:-webkit-any(:link)
    fast/history/link-inside-any.html
:-webkit-any(:visited)
    fast/history/visited-inside-any.html

[1]: https://bugs.webkit.org/show_bug.cgi?id=135639

Test: fast/history/link-inside-not-inside-any.html
    To cover the :-webkit-any(:not(:link)), added new tests.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorCheckerExcludingPseudoElements):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRightmostTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstLink):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateStoreLastVisitedElement):

LayoutTests:

To cover the :-webkit-any(:not(:link)), added new tests.

* TestExpectations:
* fast/history/link-inside-not-expected.txt:
* fast/history/link-inside-not-inside-any-expected.txt: Added.
* fast/history/link-inside-not-inside-any.html: Added.
* fast/history/link-inside-not.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImprove the test image diffs page
simon.fraser@apple.com [Mon, 13 Oct 2014 22:44:48 +0000 (22:44 +0000)]
Improve the test image diffs page
https://bugs.webkit.org/show_bug.cgi?id=137674

Reviewed by Alexey Proskuryakov.

Tools:

Don't treat the input file as a format string, otherwise we have to escape special
characters. Just do a couple of replaces.

* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):

LayoutTests:

New version of the image diff page that has the diff images in-place, and allows
for control of the image toggling.

* fast/harness/image-diff-template-expected.txt:
* fast/harness/image-diff-template.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse modern loops in RenderLayerCompositor
cdumez@apple.com [Mon, 13 Oct 2014 22:35:50 +0000 (22:35 +0000)]
Use modern loops in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=137670

Reviewed by Simon Fraser.

Use modern range for-loops in RenderLayerCompositor.

No new tests, no behavior change.

* rendering/RenderLayerCompositor.cpp:
(WebCore::OverlapMapContainer::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::intersects):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayersAfterFlush):
(WebCore::RenderLayerCompositor::updateCustomLayersAfterFlush):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirementsForNamedFlowFixed):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTreeForNamedFlowFixed):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
(WebCore::resetTrackedRepaintRectsRecursive):
(WebCore::RenderLayerCompositor::layerHas3DContent):
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
(WebCore::RenderLayerCompositor::registerAllScrollingLayers):
(WebCore::RenderLayerCompositor::unregisterAllScrollingLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd StringCapture helper for thread-safe lambda capture
antti@apple.com [Mon, 13 Oct 2014 22:30:20 +0000 (22:30 +0000)]
Add StringCapture helper for thread-safe lambda capture
https://bugs.webkit.org/show_bug.cgi?id=137664

Reviewed by Anders Carlsson.

There is currently no clean way to capture a String in a thread-safe manner. This will now work:

StringCapture stringCapture(string);
auto lambdaThatRunsInAnotherThread = [stringCapture] { String string = stringCapture.string(); ... }

This type won't be necessary with C++14 initialized lambda capture: [string = string.isolatedCopy()].

* wtf/text/WTFString.h:
(WTF::StringCapture::StringCapture): Create isolated copy in copy-constructor.
(WTF::StringCapture::string):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r174555.
rniwa@webkit.org [Mon, 13 Oct 2014 21:58:30 +0000 (21:58 +0000)]
Unreviewed build fix after r174555.

* public/include/manifest.php:
(ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
* tests/admin-regenerate-manifest.js: Fixed the test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDrop unnecessary overlapMap null checks in computeCompositingRequirements()
cdumez@apple.com [Mon, 13 Oct 2014 21:33:22 +0000 (21:33 +0000)]
Drop unnecessary overlapMap null checks in computeCompositingRequirements()
https://bugs.webkit.org/show_bug.cgi?id=137668

Reviewed by Andreas Kling.

Drop unnecessary overlapMap null checks in computeCompositingRequirements().
The function is never called with a null overlapMap so we can make the
argument a reference and drop all the null checks.

No new tests, no behavior change.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirementsForNamedFlowFixed):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse is<>() / downcast<>() for PlatformCALayer subclasses
cdumez@apple.com [Mon, 13 Oct 2014 20:59:32 +0000 (20:59 +0000)]
Use is<>() / downcast<>() for PlatformCALayer subclasses
https://bugs.webkit.org/show_bug.cgi?id=137661

Reviewed by Simon Fraser.

Source/WebCore:

Use is<>() / downcast<>() for PlatformCALayer subclasses and clean up
the surrounding code.

No new tests, no behavior change.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::updateReplicatedLayers):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::fetchCloneLayers): Deleted.
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::TileCoverageMap):
* platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::ensureTilesForRect):
* platform/graphics/ca/mac/PlatformCALayerMac.h:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::clone):
(PlatformCALayerMac::appendSublayer):
(PlatformCALayerMac::insertSublayer):
(PlatformCALayerMac::replaceSublayer):
(PlatformCALayerMac::adoptSublayers):
(PlatformCALayerMac::copyFiltersFrom):
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::setRootChildLayer):
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::clone):
(PlatformCALayerWin::rootLayer):
(PlatformCALayerWin::appendSublayer):
(PlatformCALayerWin::insertSublayer):
(PlatformCALayerWin::replaceSublayer):
(PlatformCALayerWin::adoptSublayers):
(PlatformCALayerWin::copyFiltersFrom):
* platform/graphics/ca/win/PlatformCALayerWin.h:
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::insertSublayer):
* platform/graphics/ca/win/PlatformCALayerWinInternal.h:

Source/WebKit/win:

Use is<>() / downcast<>() for PlatformCALayer subclasses and clean up
the surrounding code.

* FullscreenVideoController.cpp:
(FullscreenVideoController::enterFullscreen):

Source/WebKit2:

Use is<>() / downcast<>() for PlatformCALayer subclasses and clean up
the surrounding code.

* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::~PlatformCALayerRemote):
(WebKit::PlatformCALayerRemote::updateClonedLayerProperties):
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::setSublayers):
(WebKit::PlatformCALayerRemote::appendSublayer):
(WebKit::PlatformCALayerRemote::insertSublayer):
(WebKit::PlatformCALayerRemote::replaceSublayer):
(WebKit::PlatformCALayerRemote::adoptSublayers):
(WebKit::PlatformCALayerRemote::setMask):
(WebKit::PlatformCALayerRemote::copyFiltersFrom):
* WebProcess/WebPage/mac/PlatformCALayerRemote.h:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
clopez@igalia.com [Mon, 13 Oct 2014 18:50:16 +0000 (18:50 +0000)]
[XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
https://bugs.webkit.org/show_bug.cgi?id=137659

Reviewed by Martin Robinson.

* Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd more detailed wait time information to EWS metrics
ap@apple.com [Mon, 13 Oct 2014 18:46:30 +0000 (18:46 +0000)]
Add more detailed wait time information to EWS metrics
https://bugs.webkit.org/show_bug.cgi?id=137649

Reviewed by Daniel Bates.

Added average and worst time (we used to only have median), and also a percentage
of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.

There is always some wait due to the polling nature of the queues, which is well understood
and doesn't need to be measured. What needs to be measured is whether there is enough
bot machines to process patches as soon as they are submitted.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer.prototype._analyzeBubblePerformance):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
(MetricsBubbleView.prototype._update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse is<>() / downcast<>() for Filter / FilterOperation subclasses
cdumez@apple.com [Mon, 13 Oct 2014 18:28:25 +0000 (18:28 +0000)]
Use is<>() / downcast<>() for Filter / FilterOperation subclasses
https://bugs.webkit.org/show_bug.cgi?id=137644

Reviewed by Darin Adler.

Use is<>() / downcast<>() for Filter / FilterOperation subclasses.

Source/WebCore:

No new tests, no behavior change.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForFilter):
* platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
(PlatformCAFilters::filterValueForOperation):
(PlatformCAFilters::colorMatrixValueForFilter):
* platform/graphics/filters/Filter.h:
* platform/graphics/filters/FilterOperation.cpp:
(WebCore::DefaultFilterOperation::operator==):
(WebCore::ReferenceFilterOperation::operator==):
(WebCore::BasicColorMatrixFilterOperation::blend):
(WebCore::BasicColorMatrixFilterOperation::operator==):
(WebCore::BasicComponentTransferFilterOperation::blend):
(WebCore::BasicComponentTransferFilterOperation::operator==):
(WebCore::BlurFilterOperation::operator==):
(WebCore::BlurFilterOperation::blend):
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::blend):
* platform/graphics/filters/FilterOperation.h:
* platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::outsets):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
* rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients):
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
* svg/graphics/filters/SVGFilter.h:
(isType):

Source/WebKit2:

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::FilterOperations>::encode):
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<FilterOperation>::encode):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse is<>() / downcast<>() for Table render objects
cdumez@apple.com [Mon, 13 Oct 2014 18:21:11 +0000 (18:21 +0000)]
Use is<>() / downcast<>() for Table render objects
https://bugs.webkit.org/show_bug.cgi?id=137641

Reviewed by Mihnea Ovidenie.

Use is<>() / downcast<>() for table-related render objects and clean
up the surrounding code.

No new tests, no behavior change.

* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addChildren):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::isDataTable):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::addChildren):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentTable):
(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):
(WebCore::AccessibilityTableCell::titleUIElement):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObject):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
* editing/TextIterator.cpp:
(WebCore::shouldEmitTabBeforeNode):
(WebCore::shouldEmitNewlinesBeforeAndAfterNode):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::parseAttribute):
(WebCore::HTMLTableCellElement::cellAbove):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseAttribute):
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::parseAttribute):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::shouldScaleColumns):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::addChild):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::firstColumn):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):
(WebCore::RenderTable::bottomSection):
* rendering/RenderTable.h:
* rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::table):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::nextCell):
(WebCore::RenderTableCell::previousCell):
(WebCore::RenderTableRow::firstCell):
(WebCore::RenderTableRow::lastCell):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::table):
(WebCore::RenderTableCol::enclosingColumnGroup):
(WebCore::RenderTableCol::nextColumn):
* rendering/RenderTableCol.h:
Make updateFromElement() public to allow the callers to use tighter
typing and devitualize the call as the class is final.

* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableRow.h:
(WebCore::RenderTableSection::firstRow):
(WebCore::RenderTableSection::lastRow):
(WebCore::RenderTableRow::nextRow):
(WebCore::RenderTableRow::previousRow):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::paintCell):
* rendering/RenderTableSection.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
(WebCore::writeSimpleLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMediaPlayer::characteristicChanged() is not called when new tracks are found in Sourc...
jer.noble@apple.com [Mon, 13 Oct 2014 17:49:16 +0000 (17:49 +0000)]
MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=137533

Reviewed by Darin Adler.

Source/WebCore:

When a new AVAsset is returned out of the AVStreamDataParser, notify the HTMLMediaElement that
characteristics of the player may have changed.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::characteristicsChanged):
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
* TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Stop listening for wireless playback target availability when the default contr...
jer.noble@apple.com [Mon, 13 Oct 2014 17:44:39 +0000 (17:44 +0000)]
[iOS] Stop listening for wireless playback target availability when the default controls are hidden.
https://bugs.webkit.org/show_bug.cgi?id=137633

Reviewed by Dean Jackson.

In order to minimize the excess bandwidth and power consumption required for actively listening
for wireless playback target availablity, unregister for those notifications while the controls
are hidden due to playback, or when the element's document is hidden.

* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.createBase): Register for document visiblity change notfications.
(ControllerIOS.prototype.setControlsType): Call updateShouldListenForPlaybackTargetAvailabilityEvent()
    instead of setShouldListenForPlaybackTargetAvailabilityEvent()
(ControllerIOS.prototype.hideControls): Ditto.
(ControllerIOS.prototype.showControls): Ditto.
(ControllerIOS.prototype.updateStatusDisplay): Ditto.
(ControllerIOS.prototype.handleVisibilityChange): Ditto.
(ControllerIOS.prototype.updateShouldListenForPlaybackTargetAvailabilityEvent): Added. Only listen
    for target availability when the video has no errors, is not in the initial "big play button"
    controls state, and when the controls are not hidden.
* platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper stopMonitoringAirPlayRoutes]): Explicitly set the discoveryMode to "disabled"
    rather than waiting for the autoreleasepool to destroy our routing controller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS DRT snapshots are limited to the page visible area
simon.fraser@apple.com [Mon, 13 Oct 2014 17:33:28 +0000 (17:33 +0000)]
iOS DRT snapshots are limited to the page visible area
https://bugs.webkit.org/show_bug.cgi?id=137650

Reviewed by Daniel Bates.
Source/WebCore:

LegacyTileCache drawing was limited to the window's visible area, found by
crawling up the layer hierarchy to the root layer. This caused test snapshots to
be missing non-composited content outside the iPhone visible area, which hinders
testing.

Fix by adding a test-only mode where the window visible area is the entire window.

* platform/ios/wak/WAKWindow.h:
* platform/ios/wak/WAKWindow.mm:
(-[WAKWindow setEntireWindowVisibleForTesting:]):
(-[WAKWindow _visibleRectRespectingMasksToBounds:]):

Tools:

LegacyTileCache drawing was limited to the window's visible area, found by
crawling up the layer hierarchy to the root layer. This caused test snapshots to
be missing non-composited content outside the iPhone visible area, which hinders
testing.

Fix by adding a test-only mode where the window visible area is the entire window.

* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
for the DRT window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGardening.
simon.fraser@apple.com [Mon, 13 Oct 2014 16:08:07 +0000 (16:08 +0000)]
Gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Make RenderNamedFlowFragment::computeStyleInRegion const
mihnea@adobe.com [Mon, 13 Oct 2014 14:33:45 +0000 (14:33 +0000)]
[CSSRegions] Make RenderNamedFlowFragment::computeStyleInRegion const
https://bugs.webkit.org/show_bug.cgi?id=137604

Reviewed by Andrei Bucur.

The method computeStyleInRegion should be const as it does not modify
the state of the RenderNamedFlowFragment instance. Make pointers to
the region used for styling const along the way. No new tests as no
change in functionality.

* css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::ElementRuleCollector):
(WebCore::ElementRuleCollector::setRegionForStyling):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleForElement):
* css/StyleResolver.h:
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::computeStyleInRegion):
* rendering/RenderNamedFlowFragment.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Pass the valid set of tracks to grow beyond growth limits
svillar@igalia.com [Mon, 13 Oct 2014 08:44:24 +0000 (08:44 +0000)]
[CSS Grid Layout] Pass the valid set of tracks to grow beyond growth limits
https://bugs.webkit.org/show_bug.cgi?id=137253

Reviewed by Darin Adler.

Source/WebCore:

Section 10.4 of the specs describe how to resolve content based
track sizing functions. Among others it describes the "distribute
extra space" algorithm. The 3rd bullet of that algorithm specifies
how to distribute (and also the target tracks) the extra space
once all the tracks have reached their growth limits.

Our implementation had 2 problems. First we were not passing a
valid subset of tracks (instead we were always using all of
them). Now we use a function that filters the right tracks to be
the target of the extra space distribution depending on whether
we're computing the min track function or the max track function.

Secondly the algorithm that was distributing the extra space was
not using that list of passed in tracks (it iterated over all of
them). From now on it will use the set of tracks selected using
the filter function described above.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):
* rendering/RenderGrid.h:
* rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::hasMinContentMinTrackBreadthAndMinOrMaxContentMaxTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadthAndMaxContentMaxTrackBreadth):

LayoutTests:

* fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
* fast/css-grid-layout/grid-content-sized-columns-resolution.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPage not fully rendered in iOS DRT snapshots
simon.fraser@apple.com [Sun, 12 Oct 2014 21:48:16 +0000 (21:48 +0000)]
Page not fully rendered in iOS DRT snapshots
https://bugs.webkit.org/show_bug.cgi?id=137638

Reviewed by Tim Horton.

In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
to ensure that the page has laid out and is rendered by the time we take
the snapshot.

* DumpRenderTree/mac/DumpRenderTree.mm:
(-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
(-[DumpRenderTree _webThreadInvoked]): Moved.
(-[DumpRenderTree _waitForWebThreadThenDump]):
(dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
relies on dispatch_async too, and the inner block won't complete until the outer block
has completed.
(dumpTestResults): Move the guts of dump() here.
(runTest): Whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdding svn:ignore so that .pyc files don't show up as new.
ap@apple.com [Sun, 12 Oct 2014 18:48:12 +0000 (18:48 +0000)]
Adding svn:ignore so that .pyc files don't show up as new.

Source/JavaScriptCore:

* inspector/scripts/codegen: Added property svn:ignore.

Tools:

* Scripts/webkitpy/xcode: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReferrer Policy: Update <meta name="referrer"> values to match the spec
mkwst@chromium.org [Sun, 12 Oct 2014 12:55:45 +0000 (12:55 +0000)]
Referrer Policy: Update <meta name="referrer"> values to match the spec
https://bugs.webkit.org/show_bug.cgi?id=137635

Reviewed by Jochen Eisinger.

Source/WebCore:

The Referrer Policy specification ([Working Draft][WD], [Editor's
draft[ED]) defines different keywords than we originally
implemented. We should support them in the interests of clarity and
interoperability with other browsers implementing the specification.

[WD]: http://www.w3.org/TR/referrer-policy/#referrer-policy-delivery-meta
[ED]: http://w3c.github.io/webappsec/specs/referrer-policy/#referrer-policy-delivery-meta

This patch is a port of Blink's https://codereview.chromium.org/607433002/

Tests: http/tests/security/referrer-policy-conflicting-policies.html
       http/tests/security/referrer-policy-https-no-referrer-when-downgrade.html
       http/tests/security/referrer-policy-https-no-referrer.html
       http/tests/security/referrer-policy-https-unsafe-url.html
       http/tests/security/referrer-policy-no-referrer-when-downgrade.html
       http/tests/security/referrer-policy-no-referrer.html

* dom/Document.cpp:
(WebCore::Document::processReferrerPolicy):

LayoutTests:

* http/tests/security/referrer-policy-https-no-referrer-expected.txt: Added.
* http/tests/security/referrer-policy-https-no-referrer-when-downgrade-expected.txt: Added.
* http/tests/security/referrer-policy-https-no-referrer-when-downgrade.html: Added.
* http/tests/security/referrer-policy-https-no-referrer.html: Added.
* http/tests/security/referrer-policy-https-unsafe-url-expected.txt: Added.
* http/tests/security/referrer-policy-https-unsafe-url.html: Added.
* http/tests/security/referrer-policy-invalid-expected.txt: Update the error message with new keywords.
* http/tests/security/referrer-policy-no-referrer-expected.txt: Added.
* http/tests/security/referrer-policy-no-referrer-when-downgrade-expected.txt: Added.
* http/tests/security/referrer-policy-no-referrer-when-downgrade.html: Added.
* http/tests/security/referrer-policy-no-referrer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SOUP] [WK2] WebProcess and NetworkProcess initialization clears cache contents
svillar@igalia.com [Sun, 12 Oct 2014 09:32:10 +0000 (09:32 +0000)]
[SOUP] [WK2] WebProcess and NetworkProcess initialization clears cache contents
https://bugs.webkit.org/show_bug.cgi?id=137489

Reviewed by Carlos Garcia Campos.

Temporarily set the SoupCache's maximum size to a huge value
before calling soup_cache_load() so that the cache is not shrinked
to the default value.

* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport activation behavior of link element
commit-queue@webkit.org [Sun, 12 Oct 2014 08:35:34 +0000 (08:35 +0000)]
Support activation behavior of link element
https://bugs.webkit.org/show_bug.cgi?id=137597

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-10-12
Reviewed by Benjamin Poulain.

Source/WebCore:

Support activation behavior of link elements as defined in [1],
i.e. to follow the hyperlink created by the link element when it is fully active.

[1] https://html.spec.whatwg.org/multipage/semantics.html#the-link-element

Tests: fast/dom/html-link-element-activation-behavior-on-element-click.html
       fast/dom/html-link-element-activation-behavior-on-mouse-click.html
       fast/dom/html-link-element-activation-behavior-url-is-null.html

* dom/MouseEvent.cpp:
(WebCore::MouseEvent::triggerActivationBehavior):
* dom/MouseEvent.h:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::isLinkClick): Deleted.
* html/HTMLAnchorElement.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::defaultEventHandler):
(WebCore::HTMLLinkElement::handleClick):
* html/HTMLLinkElement.h:
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):

LayoutTests:

Add test cases for link element activation behavior.

* fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt: Added.
* fast/dom/html-link-element-activation-behavior-on-element-click.html: Added.
* fast/dom/html-link-element-activation-behavior-on-mouse-click-expected.txt: Added.
* fast/dom/html-link-element-activation-behavior-on-mouse-click.html: Added.
* fast/dom/html-link-element-activation-behavior-url-is-null-expected.txt: Added.
* fast/dom/html-link-element-activation-behavior-url-is-null.html: Added.
* fast/dom/resources/html-link-element-activation-behavior-on-element-click-step1.html: Added.
* fast/dom/resources/html-link-element-activation-behavior-on-mouse-click-step1.html: Added.
* fast/dom/resources/html-link-element-activation-behavior-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Introduce EWebKit_Extension
ryuan.choi@gmail.com [Sun, 12 Oct 2014 07:15:25 +0000 (07:15 +0000)]
[EFL] Introduce EWebKit_Extension
https://bugs.webkit.org/show_bug.cgi?id=134921

Reviewed by Gyuyoung Kim.

Source/WebKit2:

EWebKit2 does not provide the functionality to extend WebProcess.
Although there is ewk_context_new_with_injected_bundle_path() in ewebkit2 APIs,
application developers can not make bundle object without touching WK APIs
which ewebkit2 does not expose.

This patch introduces EWebKit_Extension, basic structure for the extension of WebProcess.

* PlatformEfl.cmake:
Added files for the EWebKit_Extension and install them properly.
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(bundlePathForExtension):
(EwkContext::create):
(EwkContext::getInjectedBundleInitializationUserData):
(EwkContext::setMessageFromInjectedBundleCallback):
(ewk_context_new_with_extensions_path):
Deleted because ewebkit2 does not have a way to make injected bundle.
Instead, Ewk_Extension will cover the same functionalities.
(ewk_context_new_with_injected_bundle_path): Deleted.
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_context_private.h:
(EwkContext::extensionsPath):
* UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp: Removed.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::extensionSample):
(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample): Renamed injectedBundleSample to extensionSample.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
* UIProcess/API/efl/tests/extensions/extension_sample.cpp: Copied from Source/WebKit2/UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp.
* UIProcess/API/efl/tests/test_ewk2_context.cpp: Renamed ewk_context_new_with_injected_bundle_path to ewk_context_new_with_extensions_path.
(TEST_F):
* WebProcess/InjectedBundle/API/efl/EWebKit_Extension.h: Added.
* WebProcess/InjectedBundle/API/efl/ewk_extension.cpp: Added.
(EwkExtension::append):
(EwkExtension::remove):
(ewk_extension_client_add):
(ewk_extension_client_del):
* WebProcess/InjectedBundle/API/efl/ewk_extension.h: Added.
* WebProcess/InjectedBundle/API/efl/ewk_extension_private.h: Added.
(EwkExtension::EwkExtension):
(EwkExtension::~EwkExtension):
* WebProcess/efl/ExtensionManagerEfl.cpp: Added.
(WebKit::ExtensionManagerEfl::shared):
(WebKit::ExtensionManagerEfl::ExtensionManagerEfl):
(WebKit::ExtensionManagerEfl::initialize):
* WebProcess/efl/ExtensionManagerEfl.h: Added.
* WebProcess/efl/WebInjectedBundleMainEfl.cpp: Added.
(WKBundleInitialize):
* efl/ewebkit2-extension.pc.in: Added.

Tools:

* MiniBrowser/efl/main.c: Added x option to test extension path.
(window_create):
(elm_main):
* Scripts/webkitpy/common/config/watchlist:
Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
* Scripts/webkitpy/style/checker.py:
Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark some more tests as sometimes passing.
simon.fraser@apple.com [Sat, 11 Oct 2014 18:07:45 +0000 (18:07 +0000)]
Mark some more tests as sometimes passing.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAfter r174628 we send the test process a SIGTERM before the SIGKILL.
simon.fraser@apple.com [Sat, 11 Oct 2014 17:27:06 +0000 (17:27 +0000)]
After r174628 we send the test process a SIGTERM before the SIGKILL.

* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.serial_test_kill_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Enable WebP support.
commit-queue@webkit.org [Sat, 11 Oct 2014 16:22:32 +0000 (16:22 +0000)]
[EFL] Enable WebP support.
https://bugs.webkit.org/show_bug.cgi?id=136156

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-10-11
Reviewed by Gyuyoung Kim.

.:

Add WebP package finding rule.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add WebP library and inlcude path to WebCore path for WK2 Efl.
No new tests since existing feature is just enabled for WK2 Efl.

* PlatformEfl.cmake:

Source/WTF:

Enable WTF_USE_WEBP macro for WK2 Efl.

* wtf/Platform.h:

Tools:

Include libwebp-dev package to support WebP for WK2 Efl.

* efl/install-dependencies:

LayoutTests:

Clarify skipped webp test for Webkit EFL.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThre...
carlosgc@webkit.org [Sat, 11 Oct 2014 07:08:59 +0000 (07:08 +0000)]
[GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
https://bugs.webkit.org/show_bug.cgi?id=137485

Reviewed by Sergio Villar Senin.

Source/WebCore:

Use GThreadSafeMainLoopSource for GStreamer sources, since they
can be used from different threads. Also update GMutexLocker
usages, since it's now a template.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(unlockBufferMutex):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkStart):
* platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

Source/WTF:

We made GMainLoopSource thread safe, but in most of the cases we
know the sources are used by a single thread, which has an impact
in the performance (mutex, GCancellable, etc.). The new class
GThreadSafeMainLoopSource inherits from GMainLoopSource overriding
the new virtual methods and calling the parent for the common code.
GMutexLocker now supports recursive mutexes, it's a template that
can wrap a GMutex or a GRecMutex. GThreadSafeMainLoopSource uses a
recursive mutex using the new GMutexLocker API.

* wtf/PlatformEfl.cmake: Add new file to compilation.
* wtf/PlatformGTK.cmake: Ditto.
* wtf/gobject/GMainLoopSource.cpp:
(WTF::GMainLoopSource::GMainLoopSource):
(WTF::GMainLoopSource::~GMainLoopSource):
(WTF::GMainLoopSource::cancel):
(WTF::GMainLoopSource::schedule):
(WTF::GMainLoopSource::scheduleAfterDelay):
(WTF::GMainLoopSource::prepareVoidCallback):
(WTF::GMainLoopSource::finishVoidCallback):
(WTF::GMainLoopSource::voidCallback):
(WTF::GMainLoopSource::prepareBoolCallback):
(WTF::GMainLoopSource::finishBoolCallback):
(WTF::GMainLoopSource::boolCallback):
(WTF::GMainLoopSource::socketCallback):
(WTF::GMainLoopSource::cancelWithoutLocking): Deleted.
* wtf/gobject/GMainLoopSource.h:
* wtf/gobject/GMutexLocker.h:
(WTF::MutexWrapper<GMutex>::lock):
(WTF::MutexWrapper<GMutex>::unlock):
(WTF::MutexWrapper<GRecMutex>::lock):
(WTF::MutexWrapper<GRecMutex>::unlock):
(WTF::GMutexLocker::GMutexLocker):
(WTF::GMutexLocker::lock):
(WTF::GMutexLocker::unlock):
* wtf/gobject/GThreadSafeMainLoopSource.cpp: Added.
(WTF::GThreadSafeMainLoopSource::GThreadSafeMainLoopSource):
(WTF::GThreadSafeMainLoopSource::~GThreadSafeMainLoopSource):
(WTF::GThreadSafeMainLoopSource::cancel):
(WTF::GThreadSafeMainLoopSource::schedule):
(WTF::GThreadSafeMainLoopSource::scheduleAfterDelay):
(WTF::GThreadSafeMainLoopSource::prepareVoidCallback):
(WTF::GThreadSafeMainLoopSource::finishVoidCallback):
(WTF::GThreadSafeMainLoopSource::voidCallback):
(WTF::GThreadSafeMainLoopSource::prepareBoolCallback):
(WTF::GThreadSafeMainLoopSource::finishBoolCallback):
(WTF::GThreadSafeMainLoopSource::boolCallback):
* wtf/gobject/GThreadSafeMainLoopSource.h: Added.

Tools:

Update GMainLoopSource tests. Most of the tests are now run twice,
first with a GMainLoopSource and then with a
GThreadSafeMainLoopSource, since both should have the same
behaviour. The threading test uses GThreadSafeMainLoopSource and
the delete on destroy test uses GMainLoopSource. The tests
themselves haven't changed, since there's no change in behaviour.

* TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
(TestWebKitAPI::GMainLoopSourceTest::source):
(TestWebKitAPI::basicRescheduling):
(TestWebKitAPI::TEST):
(TestWebKitAPI::reentrantRescheduling):
(TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
(TestWebKitAPI::basicDestroyCallbacks):
(TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
(TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Improve appearance of alpha color swatches
commit-queue@webkit.org [Sat, 11 Oct 2014 03:43:05 +0000 (03:43 +0000)]
Web Inspector: Improve appearance of alpha color swatches
https://bugs.webkit.org/show_bug.cgi?id=137627

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-10
Reviewed by Timothy Hatcher.

This improves the sizes. The color-swatch size is 1em x 1em,
which ends up being 11px, and thus there is still an imbalance.
However on both 1x and 2x displays this looks more even.

* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: assert always logs undefined instead of the desired string
commit-queue@webkit.org [Sat, 11 Oct 2014 03:41:04 +0000 (03:41 +0000)]
Web Inspector: assert always logs undefined instead of the desired string
https://bugs.webkit.org/show_bug.cgi?id=137632

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-10
Reviewed by Timothy Hatcher.

* UserInterface/Protocol/InspectorFrontendAPI.js:
(InspectorFrontendAPI.dispatch):
Fix the assert log to include the method name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix fat-fingered function name in git-add-reviewer.
dburkart@apple.com [Sat, 11 Oct 2014 02:00:27 +0000 (02:00 +0000)]
Fix fat-fingered function name in git-add-reviewer.

Unreviewed.

* Scripts/git-add-reviewer:
(getConfigValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
dfarler@apple.com [Sat, 11 Oct 2014 01:09:30 +0000 (01:09 +0000)]
[iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
https://bugs.webkit.org/show_bug.cgi?id=137528

Reviewed by Simon Fraser.

Catch SIGINT and SIGTERM signals in the LayoutTestRelay
and SIGKILL the paired simulator app before exiting cleanly.

webkitpy only uses SIGKILL to kill processes which you cannot
catch. Send SIGTERM to the process and give it chance to do
its thing before sending SIGKILL. Sending a SIGKILL to an already
dead PID is safe.

* LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
* LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController finish]):
* LayoutTestRelay/LayoutTestRelay/main.m:
(receivedSignal):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake these animation tests not timeout if hit testing fails.
simon.fraser@apple.com [Sat, 11 Oct 2014 00:59:43 +0000 (00:59 +0000)]
Make these animation tests not timeout if hit testing fails.

* animations/animation-hit-test-transform.html:
* animations/animation-hit-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
dfarler@apple.com [Sat, 11 Oct 2014 00:03:39 +0000 (00:03 +0000)]
[iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
https://bugs.webkit.org/show_bug.cgi?id=137527

Reviewed by Simon Fraser.

NSFileHandle doesn't notify of EOF in its readability handler.
Use a dispatch_source_t and an event handler that is called when reading is possible.
In the handler block, do a run-of-the-mill read(2) from standard input and
detect EOF in the usual way by checking that zero bytes were read.

Once an EOF is received, the FIFOs are disconnected, the simulator app
is killed, and the relay exits with status 0.

* LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
(-[LTRelayController didDisconnect]):
(-[LTRelayController didConnect]):
(-[LTRelayController launchApp]):
Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
confusion with this new dispatch source, called "standardInputDispatchSource".
(-[LTRelayController finish]): Added.
(-[LTRelayController readFileHandle:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Crash on facebook.com
commit-queue@webkit.org [Fri, 10 Oct 2014 23:49:23 +0000 (23:49 +0000)]
[EFL] Crash on facebook.com
https://bugs.webkit.org/show_bug.cgi?id=137562

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-10-10
Reviewed by Chris Dumez.

Crash occurs on the facebook.com when the webview is resized
after the <select> item is clicked but no item is chosen.
This crash is just caused by the reference of invalidated variable.
From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
on MiniBrowser is called.
As a result, just set ewk_menu to NULL in order to prevent crash condition.

* MiniBrowser/efl/main.c:
(on_popup_menu_hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoA small wording change for clarity.
ap@apple.com [Fri, 10 Oct 2014 23:46:05 +0000 (23:46 +0000)]
A small wording change for clarity.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
(MetricsBubbleView.prototype._update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse is<>() / downcast<>() for Image subclasses
cdumez@apple.com [Fri, 10 Oct 2014 23:32:45 +0000 (23:32 +0000)]
Use is<>() / downcast<>() for Image subclasses
https://bugs.webkit.org/show_bug.cgi?id=137625

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for Image subclasses.

Source/WebCore:

No new tests, no behavior change.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::createImage):
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
* platform/mac/DragImageMac.mm:
(WebCore::createDragImageFromImage):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::embeddedContentBox):
* svg/graphics/SVGImage.h:

Source/WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginSnapshotTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDashboard metrics page should have EWS statistics
ap@apple.com [Fri, 10 Oct 2014 23:29:52 +0000 (23:29 +0000)]
Dashboard metrics page should have EWS statistics
https://bugs.webkit.org/show_bug.cgi?id=137626

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
(BubbleQueue): Put shortName in the object, so that it's actually useful.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer): Re-ordered queues to match bubble order.
(BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
(BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
Added analysis for bubble queues.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
(buildBubbleQueuesTable): Build the UI.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
Added JS sources to load.

* QueueStatusServer/app.yaml: To update app version.

* QueueStatusServer/handlers/processingtimesjson.py: Added.

* QueueStatusServer/main.py: Added a handler for processing-times-json.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused classes WebRender{Node, Layer}
dbates@webkit.org [Fri, 10 Oct 2014 23:24:38 +0000 (23:24 +0000)]
Remove unused classes WebRender{Node, Layer}
https://bugs.webkit.org/show_bug.cgi?id=137628

Reviewed by Simon Fraser.

We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
of excluded source files when building for iOS.
* WebKit.exp: Remove symbol for WebRenderLayer.
* WebKit.mac.exp: Remove symbol for WebRenderNode.
* WebView/WebRenderLayer.h: Removed.
* WebView/WebRenderLayer.mm: Removed.
* WebView/WebRenderNode.h: Removed.
* WebView/WebRenderNode.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark compositing/rtl/rtl-fixed-overflow-scrolled.html as [ Failure ] on mac-wk1 platf...
aestes@apple.com [Fri, 10 Oct 2014 23:15:40 +0000 (23:15 +0000)]
Mark compositing/rtl/rtl-fixed-overflow-scrolled.html as [ Failure ] on mac-wk1 platforms.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse is<>() / downcast<>() for RenderElement
cdumez@apple.com [Fri, 10 Oct 2014 23:06:32 +0000 (23:06 +0000)]
Use is<>() / downcast<>() for RenderElement
https://bugs.webkit.org/show_bug.cgi?id=137622

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for RenderElement and clean up the
surrounding code.

Source/WebCore:

No new tests, no behavior change.

* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
* dom/Node.cpp:
(WebCore::Node::materializeRareData):
* dom/Position.cpp:
(WebCore::isNonTextLeafChild):
(WebCore::searchAheadForBetterMatch):
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::didRecalcStyle):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
* editing/htmlediting.cpp:
(WebCore::isEmptyTableCell):
* rendering/InlineIterator.h:
(WebCore::bidiNextShared):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getFirstLetter):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::layout):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::rendererRemovedFromTree):
(WebCore::RenderCounter::rendererSubtreeAttached):
(showCounterRendererTree):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::findNextLayer):
(WebCore::RenderElement::layout):
* rendering/RenderElement.h:
(WebCore::RenderObject::isRenderLayerModelObject):
(WebCore::RenderObject::isBoxModelObject):
(WebCore::RenderObject::isRenderBlock):
(WebCore::RenderObject::isRenderBlockFlow):
(WebCore::RenderObject::isRenderReplaced):
(WebCore::RenderObject::isRenderInline):
(WebCore::RenderObject::style):
(WebCore::RenderObject::firstLineStyle):
(WebCore::ContainerNode::renderer):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::computeChildrenStyleInRegion):
(WebCore::RenderNamedFlowFragment::setObjectStyleInRegion):
(WebCore::RenderNamedFlowFragment::restoreRegionObjectsOriginalStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::clearNeedsLayout):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::collectAnnotatedRegions):
* rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::initializeLayoutParameters):
(WebCore::RenderVTTCue::repositionGenericCue):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::addChild):
* rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::addChild):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::rebuildTokenContent):
(WebCore::RenderMathMLOperator::updateStyle):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::layout):
* rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::addChild):
(WebCore::RenderMathMLToken::updateTokenContent):
(WebCore::RenderMathMLToken::updateStyle):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
* rendering/svg/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
* rendering/svg/RenderSVGText.cpp:
(WebCore::findPreviousAndNextAttributes):
(WebCore::RenderSVGText::subtreeStyleDidChange):
(WebCore::updateFontInAllDescendants):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForForSubtree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):
* rendering/svg/SVGTextLayoutAttributesBuilder.h:
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::walkTree):
(WebCore::SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes):
* rendering/svg/SVGTextMetricsBuilder.h:
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::createGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/events tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 23:04:22 +0000 (23:04 +0000)]
iOS Simulator results for fast/events tests.

* platform/ios-simulator/fast/events/*: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/dynamic tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 23:04:18 +0000 (23:04 +0000)]
iOS Simulator results for fast/dynamic tests.

* platform/ios-simulator/fast/dynamic/*: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/css3-text, fast/doctypes, fast/dom tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 23:04:16 +0000 (23:04 +0000)]
iOS Simulator results for fast/css3-text, fast/doctypes, fast/dom tests.
Skip fast/DeviceOrientation, fast/dom/shadow and some other failing tests.

* platform/ios-simulator/fast/css3-text/*: Added.
* platform/ios-simulator/fast/doctypes/*: Added.
* platform/ios-simulator/fast/dom/*: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: CSS minification should not strip whitespace around calc +/- binary...
commit-queue@webkit.org [Fri, 10 Oct 2014 22:38:37 +0000 (22:38 +0000)]
Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators
https://bugs.webkit.org/show_bug.cgi?id=137624

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-10
Reviewed by Timothy Hatcher.

Be careful when stripping whitespace around "+". We want to strip for
selectors "a + b" but not for calc expressions "calc(1px + 2px)".

This is not a perfect solution, but it does a good job. It may still break
with more complex calc expressions, like "calc(1px + calc())" but this
handles the basics.

* Scripts/copy-user-interface-resources-dryrun.rb: Added.
* Scripts/cssmin.py:
(cssminify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderMathMLUnderOver adds spacing to the child operator indefinitely when resizing...
dino@apple.com [Fri, 10 Oct 2014 22:29:20 +0000 (22:29 +0000)]
RenderMathMLUnderOver adds spacing to the child operator indefinitely when resizing the window.
https://bugs.webkit.org/show_bug.cgi?id=137330

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-10-10
Reviewed by Simon Fraser.

Change the layout with resize test of the MathML underover object from being render tree test
to be reference test. The render test was failing on WK2 because it was doing window resizing
and view zooming.  The new test rely solely on forcing the layout synchronously by resizing the
math container <div> element.

* mathml/opentype/munderover-layout-resize-expected.html: Added.
* mathml/opentype/munderover-layout-resize.html: Added.
* mathml/opentype/munderover-window-resize-expected.txt: Removed.
* mathml/opentype/munderover-window-resize.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate :nth-child(An+B of selector-list) to the latest specification
benjamin@webkit.org [Fri, 10 Oct 2014 21:23:37 +0000 (21:23 +0000)]
Update :nth-child(An+B of selector-list) to the latest specification
https://bugs.webkit.org/show_bug.cgi?id=137593

Reviewed by Andreas Kling.

Source/WebCore:

Following my implementation feedback on :nth-child(An+B of selector-list),
the CSS WG decided to change the definition such that the current element on which
the selector is matched must also match the selector list in :nth-child().

This patch updates the implementation accordingly.

Test: fast/selectors/nth-child-of-chained-3.html

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::matchSelectorList):
* css/SelectorChecker.h:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChildOf):

LayoutTests:

* fast/selectors/nth-child-of-chained-3-expected.txt: Added.
* fast/selectors/nth-child-of-chained-3.html: Added.
This is an interesting new case with the new definition. Since the initial
element must also match the selector, it is now possible to fail even
if the combination An+B can match anything.

* fast/css/nth-child-of-classname-expected.html:
* fast/css/nth-child-of-classname.html:
* fast/css/nth-child-of-compound-selector-expected.html:
* fast/css/nth-child-of-compound-selector.html:
* fast/css/nth-child-of-tagname-expected.html:
* fast/css/nth-child-of-tagname.html:
* fast/selectors/nth-child-of-backtracking-adjacent-2.html:
* fast/selectors/nth-child-of-backtracking-adjacent.html:
* fast/selectors/nth-child-of-basics-2-expected.txt:
* fast/selectors/nth-child-of-basics-2.html:
* fast/selectors/nth-child-of-basics-expected.txt:
* fast/selectors/nth-child-of-basics.html:
* fast/selectors/nth-child-of-chained-2-expected.txt:
* fast/selectors/nth-child-of-chained-2.html:
* fast/selectors/nth-child-of-complex-selectors-expected.txt:
* fast/selectors/nth-child-of-complex-selectors.html:
* fast/selectors/nth-child-of-never-matching-selector-expected.txt:
* fast/selectors/nth-child-of-never-matching-selector.html:
* fast/selectors/nth-child-of-selector-list-expected.txt:
* fast/selectors/nth-child-of-selector-list.html:
Updating the test and tests result for the new definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Update a Mavericks-specific baseline.
aestes@apple.com [Fri, 10 Oct 2014 21:10:26 +0000 (21:10 +0000)]
[Mac] Update a Mavericks-specific baseline.

* platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: Commit queue doesn't process rollouts
ap@apple.com [Fri, 10 Oct 2014 20:33:03 +0000 (20:33 +0000)]
REGRESSION: Commit queue doesn't process rollouts
https://bugs.webkit.org/show_bug.cgi?id=137623

Reviewed by Tim Horton.

* QueueStatusServer/app.yaml:
* QueueStatusServer/handlers/updateworkitems.py:
(UpdateWorkItems._work_items_from_request):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r174606.
commit-queue@webkit.org [Fri, 10 Oct 2014 20:30:32 +0000 (20:30 +0000)]
Unreviewed, rolling out r174606.
https://bugs.webkit.org/show_bug.cgi?id=137621

broke a JSC test (Requested by estes on #webkit).

Reverted changeset:

"Various arguments optimisations in codegen fail to account
for arguments being in lexical record"
https://bugs.webkit.org/show_bug.cgi?id=137617
http://trac.webkit.org/changeset/174606

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip some tests that timeout every time.
simon.fraser@apple.com [Fri, 10 Oct 2014 20:20:15 +0000 (20:20 +0000)]
Skip some tests that timeout every time.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Re-enable some compositing/rtl/ tests that acquired correct baselines in r174589
aestes@apple.com [Fri, 10 Oct 2014 19:59:29 +0000 (19:59 +0000)]
[Mac] Re-enable some compositing/rtl/ tests that acquired correct baselines in r174589

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOnly run platform/mac/editing/input/undo-grouping-on-text-insertion.html on Yosemite
aestes@apple.com [Fri, 10 Oct 2014 19:41:37 +0000 (19:41 +0000)]
Only run platform/mac/editing/input/undo-grouping-on-text-insertion.html on Yosemite

* platform/mac-mavericks/TestExpectations: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVarious arguments optimisations in codegen fail to account for arguments being in...
oliver@apple.com [Fri, 10 Oct 2014 19:03:20 +0000 (19:03 +0000)]
Various arguments optimisations in codegen fail to account for arguments being in lexical record
https://bugs.webkit.org/show_bug.cgi?id=137617

Reviewed by Michael Saboff.

Rework the way we track |arguments| references so that we don't try
to use the |arguments| reference on the stack if it's not safe.

To do this without nuking performance it was necessary to update
the parser to track modification of the |arguments| reference
itself.

* bytecode/CodeBlock.cpp:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::willResolveToArguments):
(JSC::BytecodeGenerator::uncheckedLocalArgumentsRegister):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::uncheckedRegisterForArguments): Deleted.
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::hasSafeLocalArgumentsRegister):
* bytecompiler/NodesCodegen.cpp:
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::getArgumentByVal):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):
* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::existingArguments):
* parser/Nodes.h:
(JSC::ScopeNode::modifiesArguments):
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
* parser/Parser.h:
(JSC::Scope::getCapturedVariables):
* parser/ParserModes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed GTK gardening.
clopez@igalia.com [Fri, 10 Oct 2014 18:32:44 +0000 (18:32 +0000)]
[GTK] Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Mark and report test failing after r137615 and r174540.
* platform/gtk/mathml/opentype/munderover-window-resize-expected.txt: Added. Rebaseline after r174540.
* platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Rebaseline after r174540.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix syntax error after r174601.
simon.fraser@apple.com [Fri, 10 Oct 2014 18:16:44 +0000 (18:16 +0000)]
Fix syntax error after r174601.

* Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDrop RENDER_OBJECT_TYPE_CASTS() for a lot of RenderObject subclasses
cdumez@apple.com [Fri, 10 Oct 2014 18:02:32 +0000 (18:02 +0000)]
Drop RENDER_OBJECT_TYPE_CASTS() for a lot of RenderObject subclasses
https://bugs.webkit.org/show_bug.cgi?id=137594

Reviewed by Darin Adler.

Drop RENDER_OBJECT_TYPE_CASTS() for RenderObject subclasses that no
longer needed it or that required very few changes to do so. This will
make sure developers start using is<>() / downcast<>() for those
classes.

No new tests, no behavior change.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::titleUIElement):
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::didAttachRenderers):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot):
(WebCore::HTMLPlugInImageElement::checkSnapshotStatus):
* html/SearchInputType.cpp:
(WebCore::SearchInputType::addSearchResult):
(WebCore::SearchInputType::didSetValueByUserEdit):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::renderer):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
* page/FrameView.cpp:
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
* rendering/RenderButton.h:
* rendering/RenderCounter.h:
* rendering/RenderDetailsMarker.h:
* rendering/RenderFieldset.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderFileUploadControl.h:
* rendering/RenderFlexibleBox.h:
* rendering/RenderFullScreen.h:
* rendering/RenderGrid.h:
* rendering/RenderHTMLCanvas.h:
* rendering/RenderIFrame.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentsBox):
* rendering/RenderMedia.h:
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::attachQuote):
* rendering/RenderQuote.h:
* rendering/RenderReplaced.h:
* rendering/RenderScrollbarPart.h:
* rendering/RenderSearchField.h:
* rendering/RenderSnapshottedPlugIn.h:
* rendering/RenderTableCaption.h:
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
* rendering/RenderVideo.cpp:
(WebCore::rendererPlaceholder):
* rendering/line/BreakingContextInlineHeaders.h:
(WebCore::updateCounterIfNeeded):
* rendering/svg/RenderSVGContainer.h:
* rendering/svg/RenderSVGGradientStop.h:
* rendering/svg/RenderSVGModelObject.h:
* rendering/svg/RenderSVGPath.h:
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
* rendering/svg/RenderSVGTextPath.h:
* rendering/svg/RenderSVGTransformableContainer.h:
* rendering/svg/RenderSVGViewportContainer.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow):
(WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout):
(WebCore::updateObjectBoundingBox):
(WebCore::layoutSizeOfNearestViewportChanged):
(WebCore::SVGRenderSupport::transformToRootChanged):
(WebCore::SVGRenderSupport::rendererHasSVGShadow):
(WebCore::SVGRenderSupport::setRendererHasSVGShadow):
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::beginTextPathLayout):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::getBBox):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse is<>() / downcast<>() for GraphicsLayer subclasses
cdumez@apple.com [Fri, 10 Oct 2014 17:51:01 +0000 (17:51 +0000)]
Use is<>() / downcast<>() for GraphicsLayer subclasses
https://bugs.webkit.org/show_bug.cgi?id=137595

Reviewed by Darin Adler.

Use is<>() / downcast<>() for GraphicsLayer subclasses and clean up the
surrounding code.

Source/WebCore:

No new tests, no behavior change.

* page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::Highlight::Highlight):
(WebCore::ServicesOverlayController::Highlight::fadeIn):
(WebCore::ServicesOverlayController::Highlight::fadeOut):
* platform/graphics/GraphicsLayer.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::removeFromParent):
(WebCore::GraphicsLayerCA::setMaskLayer):
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::replicatedLayerRoot):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::propagateLayerChangeToReplicas):
(WebCore::GraphicsLayerCA::fetchCloneLayers):
* platform/graphics/ca/GraphicsLayerCA.h:

Source/WebKit2:

* WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::layerForTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::shadowLayerForTransientZoom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd ability to select tarfile name in run-jsc-stress-tests
msaboff@apple.com [Fri, 10 Oct 2014 17:47:52 +0000 (17:47 +0000)]
Add ability to select tarfile name in run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=137614

Reviewed by Mark Hahnenberg.

Added optional file name argument to the --tarball option.

* Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
extra test given after the options wont be used for the optional tarball file name.
* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/css-generated-content, css-grid-layout tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 17:42:54 +0000 (17:42 +0000)]
iOS Simulator results for fast/css-generated-content, css-grid-layout tests.

* platform/ios-simulator/fast/css-generated-content/*: Added.
* platform/ios-simulator/fast/css-grid-layout/*: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/css tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 17:42:52 +0000 (17:42 +0000)]
iOS Simulator results for fast/css tests.

* platform/ios-simulator/fast/css/*: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/box-shadow, box-sizing, canvas, clip and compact tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 17:42:47 +0000 (17:42 +0000)]
iOS Simulator results for fast/box-shadow, box-sizing, canvas, clip and compact tests.

* platform/ios-simulator/TestExpectations:
* platform/ios-simulator/fast/box-shadow/*
* platform/ios-simulator/fast/box-sizing/*: Added.
* platform/ios-simulator/fast/canvas/*: Added.
* platform/ios-simulator/fast/clip/*: Added.
* platform/ios-simulator/fast/compact/*: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/borders tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 17:42:45 +0000 (17:42 +0000)]
iOS Simulator results for fast/borders tests.

* platform/ios-simulator/fast/borders/*: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/body-propagation tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 17:42:43 +0000 (17:42 +0000)]
iOS Simulator results for fast/body-propagation tests.

* platform/ios-simulator/fast/body-propagation/*: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS Simulator results for fast/block tests.
simon.fraser@apple.com [Fri, 10 Oct 2014 17:42:41 +0000 (17:42 +0000)]
iOS Simulator results for fast/block tests.

* platform/ios-simulator/fast/block/*: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip fast/animation in the iOS Simulator.
simon.fraser@apple.com [Fri, 10 Oct 2014 17:42:34 +0000 (17:42 +0000)]
Skip fast/animation in the iOS Simulator.
Add results for fast/backgrounds

* platform/ios-simulator/TestExpectations:
* platform/ios-simulator/fast/backgrounds/*: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, update my information in contributors.json
cdumez@apple.com [Fri, 10 Oct 2014 17:35:32 +0000 (17:35 +0000)]
Unreviewed, update my information in contributors.json

Use my preferred first name and update my expertise areas.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174593 268f45cc-cd09-0410-ab3c-d52691b4dbfc