WebKit-https.git
9 years ago2010-11-19 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 19 Nov 2010 20:08:20 +0000 (20:08 +0000)]
2010-11-19  Daniel Bates  <dbates@rim.com>

        Reviewed by Antonio Gomes.

        Replace null checks of newParent in Frame::transferChildFrameToNewDocument() with ASSERT
        https://bugs.webkit.org/show_bug.cgi?id=49489

        Substitute ASSERT(newParent) for null-checks for newParent in
        Frame::transferChildFrameToNewDocument() since newParent is
        never null.

        When Frame::transferChildFrameToNewDocument() is called the child
        frame's owner element has already been transferred to the new
        document D and D is attached (i.e. has a frame).

        * page/Frame.cpp:
        (WebCore::Frame::transferChildFrameToNewDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd SandboxExtension abstraction and use it for the injected bundle extension
andersca@apple.com [Fri, 19 Nov 2010 20:01:27 +0000 (20:01 +0000)]
Add SandboxExtension abstraction and use it for the injected bundle extension
https://bugs.webkit.org/show_bug.cgi?id=49817

Reviewed by Sam Weinig.

WebCore:

Export fileSystemRepresentation symbol needed by WebKit2.

* WebCore.exp.in:

WebKit2:

* Shared/SandboxExtension.h:
Add SandboxExtension abstraction.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Instead of encoding/decoding a token, encode/decode the sandbox extension handle.

* Shared/mac/SandboxExtensionMac.mm: Added.
Add Mac implementation of SandboxExtension.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
Create a SandboxExtension::Handle object.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::InjectedBundle::setSandboxExtension):
Set the sandbox extension.

* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::load):
Consume the sandbox extension.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Create a sandbox extension and set it on the injected bundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 19 Nov 2010 19:21:42 +0000 (19:21 +0000)]
2010-11-19  Tony Chang  <tony@chromium.org>

        Unreviewed, updating Chromium DEPS to try and fix the chromium win build.

        * DEPS: r66792

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix. Remove leftover Debug_Internal use.
sfalken@apple.com [Fri, 19 Nov 2010 19:06:17 +0000 (19:06 +0000)]
Windows build fix. Remove leftover Debug_Internal use.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, remove suppression for fast/repaint/inline-block-overflow.html.
antonm@chromium.org [Fri, 19 Nov 2010 18:52:03 +0000 (18:52 +0000)]
Not reviewed, remove suppression for fast/repaint/inline-block-overflow.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Fri, 19 Nov 2010 18:37:11 +0000 (18:37 +0000)]
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * JavaScriptCore.vcproj/JavaScriptCore.sln:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKit.sln:
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * WebCore.vcproj/WebCore.sln:
        * WebCore.vcproj/WebCore.submit.sln:
        * WebCore.vcproj/WebCoreGenerated.vcproj:
        * WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Added.
        * WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Added.
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * DumpRenderTree/DumpRenderTree.sln:
        * FindSafari/FindSafari.vcproj:
        * TestWebKitAPI/win/TestWebKitAPI.sln:
        * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
        * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
        * WebKitAPITest/WebKitAPITest.vcproj:
        * WebKitAPITest/WebKitAPITestCommon.vsprops:
        * WebKitLauncherWin/WebKitLauncherWin.vcproj:
        * WebKitTestRunner/WebKitTestRunner.sln:
        * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
        * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
        * record-memory-win/record-memory-win.vcproj:
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * win/WebKit2.submit.sln:
        * win/WebKit2Generated.vcproj:
        * win/WebKit2GeneratedCommon.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 19 Nov 2010 18:29:35 +0000 (18:29 +0000)]
2010-11-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
        https://bugs.webkit.org/show_bug.cgi?id=49706

        * platform/chromium/drt_expectations.txt:
2010-11-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
        https://bugs.webkit.org/show_bug.cgi?id=49706

        It is enabled simply by copying the plugin into
        {Debug,Release}/plugins.  This change also rolls in a version of
        Chromium that disables the old plugin.

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 19 Nov 2010 18:23:24 +0000 (18:23 +0000)]
2010-11-19  Mihai Parparita  <mihaip@chromium.org>

        Add recent upstream Chromium dependencies to .gitignore.

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 James Simonsen <simonjam@chromium.org>
commit-queue@webkit.org [Fri, 19 Nov 2010 18:19:30 +0000 (18:19 +0000)]
2010-11-19  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Add unloadEventStart
        https://bugs.webkit.org/show_bug.cgi?id=49101

        * fast/dom/Window/window-properties-performance-expected.txt:
        * fast/dom/script-tests/webtiming.js:
        (checkTimingBeforeLoad):
        (checkTimingWhileDeferred):
        (checkWebTimingWhileAsync):
        (checkWebTimingOnLoad):
        (checkWebTimingAfterLoad):
        * fast/dom/webtiming-document-open-expected.txt:
        * fast/dom/webtiming-expected.txt:
        * fast/dom/webtiming-navigate-within-document-expected.txt:
2010-11-19  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Add unloadEventStart
        https://bugs.webkit.org/show_bug.cgi?id=49101

        * loader/DocumentLoadTiming.h:
        (WebCore::DocumentLoadTiming::DocumentLoadTiming):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): Use dispatchTimedEvent().
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent): Use dispatchTimedEvent().
        (WebCore::DOMWindow::dispatchTimedEvent): Added.
        * page/DOMWindow.h:
        * page/Timing.cpp:
        (WebCore::Timing::unloadEventStart):
        * page/Timing.h:
        * page/Timing.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, remove a suppression for svg/dom/svglist-exception-on-out-bounds-error...
antonm@chromium.org [Fri, 19 Nov 2010 18:08:52 +0000 (18:08 +0000)]
Not reviewed, remove a suppression for svg/dom/svglist-exception-on-out-bounds-error.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 19 Nov 2010 18:02:40 +0000 (18:02 +0000)]
2010-11-19  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] fast/text/international tests are flaky on the bots
        https://bugs.webkit.org/show_bug.cgi?id=49781

        Beef up the == operator overload for Freetype FontPlatformData. Before
        if two FontPlatformDatas had hash values which fell into the same bucket
        and were similar enough, they would be evaluated as being equal, leading
        to failures.

        No new tests for this change. It's very hard to test, because it depends
        on the memory address of new allocations. Hopefully flakiness on the bots
        will go away after patch.

        * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
        (WebCore::FontPlatformData::operator==): Beef up the == operator overload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Fri, 19 Nov 2010 17:34:14 +0000 (17:34 +0000)]
2010-11-19  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] mask-box-image renders wrong in certain conditions
        https://bugs.webkit.org/show_bug.cgi?id=43476

        When rendering a pixmap with a dest rect having a null dimension,
        Qt uses the dimension of the Pixmap. The other ports do not render
        anything by convention.

        This patch change BitmapImage to follow the convention of other ports and do not
        paint anything.

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 19 Nov 2010 17:16:54 +0000 (17:16 +0000)]
2010-11-19  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed, build fix after r72360.

        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::bytecodeOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTemporary suppression for fast/repaint/inline-block-overflow.html
antonm@chromium.org [Fri, 19 Nov 2010 17:01:00 +0000 (17:01 +0000)]
Temporary suppression for fast/repaint/inline-block-overflow.html
See r72405.
It needs Chromium's images.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Sam Magnuson <smagnuso@gmail.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 16:51:52 +0000 (16:51 +0000)]
2010-11-19  Sam Magnuson  <smagnuso@gmail.com>

        Reviewed by Andreas Kling.

        [Qt] Compile with QT_NO_UNDOCOMMAND
        https://bugs.webkit.org/show_bug.cgi?id=49752

        * WebCoreSupport/EditCommandQt.cpp:
        (EditCommandQt::EditCommandQt):
        * WebCoreSupport/EditCommandQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosvg/batik/text/smallFonts.svg needs Leopard-specific results after
aestes@apple.com [Fri, 19 Nov 2010 16:51:13 +0000 (16:51 +0000)]
svg/batik/text/smallFonts.svg needs Leopard-specific results after
r72141.

* platform/mac-leopard/svg/batik/text/smallFonts-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTemporary suppression for fast/images/imagemap-focus-ring-zoom.html.
antonm@chromium.org [Fri, 19 Nov 2010 16:45:11 +0000 (16:45 +0000)]
Temporary suppression for fast/images/imagemap-focus-ring-zoom.html.
See r72402.
It needs Chromium's images.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip failing tests on the Leopard bots.
aestes@apple.com [Fri, 19 Nov 2010 16:41:22 +0000 (16:41 +0000)]
Skip failing tests on the Leopard bots.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 16:27:54 +0000 (16:27 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Don't call invalidateSVGAttributes() from the setFooBaseValue() methods
        https://bugs.webkit.org/show_bug.cgi?id=49807

        Covered by existing tests.

        * svg/SVGComponentTransferFunctionElement.cpp:
        (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Use setFooBaseValue(newList) instead of fooBaseValue() = newList;
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Ditto.
        * svg/SVGFEConvolveMatrixElement.cpp:
        (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Ditto.
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::parseMappedAttribute): Ditto.
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::parseMappedAttribute): Ditto.
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::parseMappedAttribute): Ditto.
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::parseMappedAttribute): Ditto.
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::parseMappedAttribute): Ditto.
        * svg/properties/SVGAnimatedPropertyMacros.h: Don't call invalidateSVGAttributes() in setFooBaseValue().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, nuking now unnecessary suppression.
antonm@chromium.org [Fri, 19 Nov 2010 16:21:31 +0000 (16:21 +0000)]
Not reviewed, nuking now unnecessary suppression.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 16:16:24 +0000 (16:16 +0000)]
2010-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72399.
        http://trac.webkit.org/changeset/72399
        https://bugs.webkit.org/show_bug.cgi?id=49805

        Broke Chromium build (Requested by antonm_ on #webkit).

        * page/chromium/ChromeClientChromium.h:
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showPopup):
        (WebCore::PopupContainer::showExternal):
        (WebCore::PopupListBox::layout):
        (WebCore::PopupMenuChromium::show):
        * platform/chromium/PopupMenuChromium.h:
2010-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72399.
        http://trac.webkit.org/changeset/72399
        https://bugs.webkit.org/show_bug.cgi?id=49805

        Broke Chromium build (Requested by antonm_ on #webkit).

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::popupOpened):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Fri, 19 Nov 2010 16:05:13 +0000 (16:05 +0000)]
2010-11-19  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Focus ring in image maps does not take zooming into account
        https://bugs.webkit.org/show_bug.cgi?id=49625

        * fast/images/imagemap-focus-ring-zoom.html: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
2010-11-19  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Focus ring in image maps does not take zooming into account
        https://bugs.webkit.org/show_bug.cgi?id=49625

        Take pageZoomFactor into account when calculating the path of the focus ring.

        Test: fast/images/imagemap-focus-ring-zoom.html

        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::getPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in WebKit::PluginView::manualLoadDidReceiveResponse when navigating to a .wav...
andersca@apple.com [Fri, 19 Nov 2010 15:47:12 +0000 (15:47 +0000)]
Crash in WebKit::PluginView::manualLoadDidReceiveResponse when navigating to a .wav file in WebKit2 on Mac
https://bugs.webkit.org/show_bug.cgi?id=48559
<rdar://problem/8606622>

Reviewed by Adam Roben.

Add null checks for m_plugin.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::manualLoadDidReceiveResponse):
(WebKit::PluginView::manualLoadDidReceiveData):
(WebKit::PluginView::manualLoadDidFinishLoading):
(WebKit::PluginView::manualLoadDidFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 15:44:35 +0000 (15:44 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGTransformList::consolidate() fails on empty lists
        https://bugs.webkit.org/show_bug.cgi?id=49619

        Return null in consolidate() when the list is empty, according to SVG 1.1.

        Test: svg/dom/SVGTransformList-empty-list-consolidation.html

        * svg/properties/SVGTransformListPropertyTearOff.h:
        (WebCore::SVGTransformListPropertyTearOff::consolidate):

2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGTransformList::consolidate() fails on empty lists
        https://bugs.webkit.org/show_bug.cgi?id=49619

        * svg/dom/SVGTransformList-empty-list-consolidation-expected.txt: Added.
        * svg/dom/SVGTransformList-empty-list-consolidation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Fri, 19 Nov 2010 15:38:58 +0000 (15:38 +0000)]
2010-11-19  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        [chromium] Removing the now unused code to show popup externally on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=49747

        * page/chromium/ChromeClientChromium.h:
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showPopup):
        (WebCore::PopupListBox::layout):
        (WebCore::PopupMenuChromium::show):
        * platform/chromium/PopupMenuChromium.h:
2010-11-19  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Removing unused code to show popup externally on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=49747

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::popupOpened):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 19 Nov 2010 15:34:10 +0000 (15:34 +0000)]
2010-11-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: reduce the footprint of InspectorBackendDispatcher.
        InspectorBackendDispatcher is a generated file.
        Its content is not optimal and loc may be reduced by a quarter.
        In each generated function we have a code for getting 'in' values from
        the arguments properties object. I've extracted this code into separate getters.
        The side effect is better readability of the generated code.

        https://bugs.webkit.org/show_bug.cgi?id=49729

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Fri, 19 Nov 2010 15:14:14 +0000 (15:14 +0000)]
Unreviewed.

[Qt] REGRESSION (r72351): fast/profiler/throw-exception-from-eval.html fails
https://bugs.webkit.org/show_bug.cgi?id=49801

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802

* platform/qt/Skipped: Add failing tests to the Skipped list until fix.
 - fast/profiler/throw-exception-from-eval.html
 - http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
 - http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
 - http/tests/security/aboutBlank/xss-DENIED-set-opener.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Fri, 19 Nov 2010 15:06:41 +0000 (15:06 +0000)]
2010-11-19  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Reentrant Geolocation tests crash with an assertion.
        https://bugs.webkit.org/show_bug.cgi?id=39908

        PositionErrors should not be sent to Geolocation watches or one
        shots that are due to receive a valid cached position. Re-enable
        fast/dom/Geolocation/maximum-age.html on Mac WebKit.

        * platform/mac/Skipped:
2010-11-19  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Reentrant Geolocation tests crash with an assertion.
        https://bugs.webkit.org/show_bug.cgi?id=39908

        PositionErrors should not be sent to Geolocation watches or one shots
        that are due to receive a valid cached position.

        Test: fast/dom/Geolocation/maximum-age.html

        * page/Geolocation.cpp:
        (WebCore::Geolocation::sendError):
        (WebCore::Geolocation::copyCachedNotifiers):
        (WebCore::Geolocation::handleError):
        * page/Geolocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, next batch of Chromium suppressions for layout test failures after
antonm@chromium.org [Fri, 19 Nov 2010 14:57:23 +0000 (14:57 +0000)]
Not reviewed, next batch of Chromium suppressions for layout test failures after
http://trac.webkit.org/changeset/72381.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Sam Magnuson <smagnuso@gmail.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 14:42:30 +0000 (14:42 +0000)]
2010-11-19  Sam Magnuson  <smagnuso@gmail.com>

        Reviewed by Laszlo Gombos.

        [Qt] Compile with QT_NO_CLIPBOARD
        https://bugs.webkit.org/show_bug.cgi?id=49742

        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::canSmartReplace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, removing duplicate expectation.
antonm@chromium.org [Fri, 19 Nov 2010 14:38:52 +0000 (14:38 +0000)]
Not reviewed, removing duplicate expectation.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 19 Nov 2010 14:26:35 +0000 (14:26 +0000)]
2010-11-19  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: flip chromium version to mitigate two-sided patch impact.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstreaming Chromium suppressions.
antonm@chromium.org [Fri, 19 Nov 2010 14:21:25 +0000 (14:21 +0000)]
Upstreaming Chromium suppressions.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 14:15:23 +0000 (14:15 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Andreas Kling.

        Remove more unused V8/SVG code
        https://bugs.webkit.org/show_bug.cgi?id=49800

        Remove DOMSVGObjectWithContextMap and all usages.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMDataStore.cpp:
        (WebCore::DOMDataStore::DOMDataStore):
        (WebCore::DOMDataStore::getDOMWrapperMap):
        * bindings/v8/DOMDataStore.h:
        (WebCore::DOMDataStore::domSvgElementInstanceMap):
        * bindings/v8/ScopedDOMDataStore.cpp:
        (WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
        (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
        * bindings/v8/StaticDOMDataStore.cpp:
        (WebCore::StaticDOMDataStore::StaticDOMDataStore):
        * bindings/v8/StaticDOMDataStore.h:
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::removeAllDOMObjectsInCurrentThread):
        * bindings/v8/V8DOMMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocreateImageBuffer fail should be handled in the same way as other fails
zherczeg@webkit.org [Fri, 19 Nov 2010 14:13:43 +0000 (14:13 +0000)]
createImageBuffer fail should be handled in the same way as other fails
https://bugs.webkit.org/show_bug.cgi?id=49799

Reviewed by Nikolas Zimmermann.

WebCore:

When createImageBuffer fails (i.e the image width or height is less than
0.5, which is rounded to 0) it just returs with false. Since the m_filter
hash map is not updated in this case, the filter image is not drawn.

Test: svg/filters/filter-rounding-issues.svg

* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

* platform/mac/svg/filters/filter-rounding-issues-expected.checksum: Added.
* platform/mac/svg/filters/filter-rounding-issues-expected.png: Added.
* svg/filters/filter-rounding-issues-expected.txt: Added.
* svg/filters/filter-rounding-issues.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, next batch of Chromium suppressions for layout test failures after
antonm@chromium.org [Fri, 19 Nov 2010 14:08:31 +0000 (14:08 +0000)]
Not reviewed, next batch of Chromium suppressions for layout test failures after
http://trac.webkit.org/changeset/72381.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 13:58:10 +0000 (13:58 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Andreas Kling.

        Remove old style SVG DOM JS bindings and DeprecatedSVGAnimated* files
        https://bugs.webkit.org/show_bug.cgi?id=49796

        Just remove the old style SVG DOM JS bindings, now that everything has been converted to the new concept.

        * GNUmakefile.am: Remove SVGList/SVGListTraits/JSSVGPODListCustom/JSSVGPODTypeWrapper/JSSVGContextCache and V8SVGPODTypeWrapper files.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSSVGContextCache.h: Removed.
        * bindings/js/JSSVGPODListCustom.h: Removed.
        * bindings/js/JSSVGPODTypeWrapper.h: Removed.
        * bindings/v8/V8Proxy.cpp: Remove SVG specific context cache code, which is no longer needed.
        * bindings/v8/V8Proxy.h: Ditto.
        * bindings/v8/V8SVGPODTypeWrapper.h: Removed.
        * svg/DeprecatedSVGAnimatedProperty.h: Removed.
        * svg/DeprecatedSVGAnimatedPropertyTraits.h: Removed.
        * svg/DeprecatedSVGAnimatedTemplate.h: Removed.
        * svg/SVGElement.h: Remove DeprecatedSVGAnimated* include, which pulled in SVGNames.h for every file.
        * svg/SVGList.h: Removed.
        * svg/SVGListTraits.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 19 Nov 2010 13:33:04 +0000 (13:33 +0000)]
2010-11-19  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] Crash on opening WebInspector for a page with CSS containing @media with nested rules
        https://bugs.webkit.org/show_bug.cgi?id=49731

        Temporarily disable building of styles for nested rules.

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::buildObjectForRule):
        (WebCore::InspectorStyleSheet::buildObjectForStyle):
        (WebCore::InspectorStyleSheet::ensureParsedDataReady):
        (WebCore::InspectorStyleSheet::ensureSourceData):
        * inspector/InspectorStyleSheet.h:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
        (WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
        (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, suppressing Chromium layout test failures after
antonm@chromium.org [Fri, 19 Nov 2010 13:30:11 +0000 (13:30 +0000)]
Not reviewed, suppressing Chromium layout test failures after
http://trac.webkit.org/changeset/72381.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 13:20:30 +0000 (13:20 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix Qt build.

        * WebCore.pro: Move SVGPathSegListPropertyTearOff.cpp from HEADERS to SOURCES list. This got lost, when reapplying the patch from the bug - I only fixed it locally before landing the first time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, rebaselining vertical text tests for Chromium.
antonm@chromium.org [Fri, 19 Nov 2010 13:19:42 +0000 (13:19 +0000)]
Not reviewed, rebaselining vertical text tests for Chromium.

* platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
* platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 19 Nov 2010 13:00:49 +0000 (13:00 +0000)]
2010-11-19  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, added the font-size-zero.html test to skipped and
        uploaded the bug: https://bugs.webkit.org/show_bug.cgi?id=49793

        It was added with r72327.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 12:54:11 +0000 (12:54 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=49580

        SVGPathElement.cloneNode loses generated pathSegList
        https://bugs.webkit.org/show_bug.cgi?id=43388

        SVG Path elements are not correctly updated through pathSegList manipulation on relative values
        https://bugs.webkit.org/show_bug.cgi?id=30219

        Changing an SVGPathSeg does not update a following Smooth Cubic Curveto
        https://bugs.webkit.org/show_bug.cgi?id=19741

        SVGPathElement should only build SVGPathSeg* list on demand
        https://bugs.webkit.org/show_bug.cgi?id=10827

        Tests: svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg
               svg/dom/SVGPathSegList-appendItem.xhtml
               svg/dom/SVGPathSegList-clear-and-initialize.xhtml
               svg/dom/SVGPathSegList-cloning.html
               svg/dom/SVGPathSegList-insertItemBefore.xhtml
               svg/dom/SVGPathSegList-removeItem.xhtml
               svg/dom/SVGPathSegList-replaceItem.xhtml
               svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml
               svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml
               svg/dom/SVGPathSegList-segment-modification.svg

        Convert SVGPathSeg*/SVGPathSegList to the new SVG(Animated)PropertyTearOff concept.
        Unlike all other SVG* types that use the SVGPropertyTearOff concept, SVGPathSegs are already refcounted,
        and don't need to be wrapped in SVGPropertyTearOff objects. The consequence is that SVGPathSegs need to track
        themselves to which list and path element they belong. Introduce new SVGAnimatedPathSegListPropertyTearOff
        and SVGPathSegListPropertyTearOff classes, that encapsulate the special needed for SVGPathSegList.

        Each SVGPathSeg now needs to store a RefPtr<SVGPathElement> - this makes it impossible to use SVGPathSegList
        to represent the 'd' attribute internally in SVGPathElement. SVGPathSegList is now only used in the SVG DOM bindings
        if someone explicitely requests 'pathElement.pathSegList' (eg. via JS). Switch to use SVGPathByteStream to store
        the 'd' attribute data in SVGPathElement, which is much more compact, and less memory intensive.
        Dirk already prepared SVGPathParserFactory some months ago, which allows easy conversion between
        String/Path/SVGPathSegList/SVGPathByteStream in all directions, including normalizing the lists, when requested.

        As consequence SVGPathSegList is now only built on demand, when explicitely requested. Using the SVGAnimatedProperty
        concept gives us 'd' attribute <-> SVGPathSegList synchronization for free, fixing several bugs, listed above.

        * Android.mk: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
        * CMakeLists.txt: Ditto.
        * DerivedSources.make: Remove SVGAnimatedPathData IDL generation.
        * GNUmakefile.am: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
        * WebCore.gyp/WebCore.gyp: Remove SVGAnimatedPathData IDL generation.
        * WebCore.gypi: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
        * WebCore.order: Remove no-longer existant SVGAnimatedPathData symbols.
        * WebCore.pro:  Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp / JSSVGPathSegCustom.* from build.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGPathSegCustom.cpp from build.
        * bindings/js/JSDOMBinding.cpp: Adapt to toJS() changes, remove context parameter.
        (WebCore::setDOMException):
        * bindings/js/JSDOMBinding.h: Remove obsolete CREATE_SVG_OBJECT_WRAPPER macro, the context parameter is not existant anymore.
        * bindings/js/JSSVGPathSegCustom.cpp: Replace CREATE_SVG_OBJECT_WRAPPER by CREATE_DOM_OBJECT_WRAPPER. Remove context parameter/handling.
        (WebCore::toJS):
        * bindings/js/JSSVGPathSegListCustom.cpp: Removed.
        * bindings/scripts/CodeGenerator.pm: Map 'SVGPathSegList' IDL type to SVG 'SVGPathSegListPropertyTearOff' native type.
        * bindings/scripts/CodeGeneratorJS.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages. Handle SVGPathSegListPropertyTearOff.
        * bindings/scripts/CodeGeneratorObjC.pm: Handle SVGPathSegListPropertyTearOff.
        * bindings/scripts/CodeGeneratorV8.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages.
        * rendering/SVGRenderTreeAsText.cpp: Build path string from byte stream, not path segment list.
        (WebCore::operator<<):
        * svg/SVGAllInOne.cpp: Remove obsolete cpp files.
        * svg/SVGAnimatedPathData.cpp: Removed.
        * svg/SVGAnimatedPathData.h: Removed.
        * svg/SVGAnimatedPathData.idl: Removed.
        * svg/SVGPathElement.cpp: Build SVGPathList on demand. Use SVGPathByteStream to parse/store the 'd' attribute content.
        (WebCore::SVGPathElement::SVGPathElement):
        (WebCore::SVGPathElement::getPathSegAtLength): Use SVGPathByteStream, not SVGPathSegList to determine the getPathSegAtLength() information.
        (WebCore::SVGPathElement::createSVGPathSegClosePath): Pass SVGPathElement to SVGPathSeg and a SVGPathSegRole parameter and store it to track the list origin.
        (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegMovetoRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegArcAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegArcRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): Ditto.
        (WebCore::SVGPathElement::parseMappedAttribute): Build SVGPathByteStream from 'd' attribute, not a SVGPathSegList.
        (WebCore::SVGPathElement::svgAttributeChanged): If a SVGPathSegList object has been built, synchronize it with the 'd' attribute.
        (WebCore::SVGPathElement::synchronizeProperty): Synchronize 'd' attribute with the SVGPathSegList, if needed.
        (WebCore::SVGPathElement::synchronizeD): Added.
        (WebCore::SVGPathElement::pathSegList): Use same trick as in SVGPolyElement to expose the 'pathSegList' / 'animatedPathSegList' object to the SVG DOM bindings.
        (WebCore::SVGPathElement::normalizedPathSegList): Ditto.
        (WebCore::SVGPathElement::animatedPathSegList): Ditto.
        (WebCore::SVGPathElement::animatedNormalizedPathSegList): Ditto.
        (WebCore::SVGPathElement::toPathData): Build 'Path' object from SVGPathByteStream, not from SVGPathSegList.
        (WebCore::SVGPathElement::pathSegListChanged): Used to synchronize the SVGPathSegLists and the d attribute, as well as any changes from any SVGPathSeg associated with this SVGPathElement.
        * svg/SVGPathElement.h: Add new accessors...
        (WebCore::SVGPathElement::pathByteStream): ... needed by SVGRenderTreeAsText.
        (WebCore::SVGPathElement::animatablePathSegList): ... needed by SVGPathSegListPropertyTearOff.
        * svg/SVGPathElement.idl: Merge SVGAnimatedPathData interface into SVGPathElement.
        * svg/SVGPathParserFactory.cpp: Cleanup SVGPathParserFactory, remove obsolete methods, now that SVGPathElement switched to using SVGPathByteStream internally.
        (WebCore::globalSVGPathSegListBuilder):
        (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList):
        (WebCore::SVGPathParserFactory::buildPathFromByteStream):
        (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream):
        (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList):
        (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
        (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
        (WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathByteStream):
        * svg/SVGPathParserFactory.h:
        * svg/SVGPathSeg.cpp: Removed.
        * svg/SVGPathSeg.h: Add new SVGPathSegRole enum, identifying to which list a path segment belongs.
        (WebCore::SVGPathSeg::SVGPathSeg):
        * svg/SVGPathSeg.idl: Reindented.
        * svg/SVGPathSegArc.cpp: Removed.
        * svg/SVGPathSegArc.h: All setters now call the commitChange() method.
        * svg/SVGPathSegArcAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegArcRel.idl: Ditto.
        * svg/SVGPathSegClosePath.cpp: Removed.
        * svg/SVGPathSegClosePath.h:
        * svg/SVGPathSegCurvetoCubic.cpp: Removed.
        * svg/SVGPathSegCurvetoCubic.h: All setters now call the commitChange() method.
        * svg/SVGPathSegCurvetoCubicAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegCurvetoCubicRel.idl: Ditto.
        * svg/SVGPathSegCurvetoCubicSmooth.cpp: Removed.
        * svg/SVGPathSegCurvetoCubicSmooth.h: All setters now call the commitChange() method.
        * svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegCurvetoCubicSmoothRel.idl: Ditto.
        * svg/SVGPathSegCurvetoQuadratic.cpp: Removed.
        * svg/SVGPathSegCurvetoQuadratic.h: All setters now call the commitChange() method.
        * svg/SVGPathSegCurvetoQuadraticAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegCurvetoQuadraticRel.idl: Ditto.
        * svg/SVGPathSegCurvetoQuadraticSmooth.cpp: Removed.
        * svg/SVGPathSegCurvetoQuadraticSmooth.h: All setters now call the commitChange() method.
        * svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Ditto.
        * svg/SVGPathSegLineto.cpp: Removed.
        * svg/SVGPathSegLineto.h: All setters now call the commitChange() method.
        * svg/SVGPathSegLinetoAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegLinetoHorizontal.cpp: Removed.
        * svg/SVGPathSegLinetoHorizontal.h: All setters now call the commitChange() method.
        * svg/SVGPathSegLinetoHorizontalAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegLinetoHorizontalRel.idl: Ditto.
        * svg/SVGPathSegLinetoRel.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegLinetoVertical.cpp: Removed.
        * svg/SVGPathSegLinetoVertical.h: All setters now call the commitChange() method.
        * svg/SVGPathSegLinetoVerticalAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegLinetoVerticalRel.idl: Ditto.
        * svg/SVGPathSegList.cpp: Switch from SVGList<RefPtr<SVGPathSeg> > to a plain Vector<RefPtr<SVGPathSeg> >.
        (WebCore::SVGPathSegList::valueAsString): Utilize SVGPathParserFactory to build a String from a SVGPathSegList.
        (WebCore::SVGPathSegList::commitChange): Call SVGPathElement::pathSegListChanged().
        * svg/SVGPathSegList.h:
        (WebCore::SVGPathSegList::SVGPathSegList):
        * svg/SVGPathSegList.idl: Remove [JSCCustom] flags, no longer needed.
        * svg/SVGPathSegListBuilder.cpp: Adapt to SVGPathSegList API changes.
        (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
        (WebCore::SVGPathSegListBuilder::moveTo):
        (WebCore::SVGPathSegListBuilder::lineTo):
        (WebCore::SVGPathSegListBuilder::lineToHorizontal):
        (WebCore::SVGPathSegListBuilder::lineToVertical):
        (WebCore::SVGPathSegListBuilder::curveToCubic):
        (WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
        (WebCore::SVGPathSegListBuilder::curveToQuadratic):
        (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
        (WebCore::SVGPathSegListBuilder::arcTo):
        (WebCore::SVGPathSegListBuilder::closePath):
        * svg/SVGPathSegListBuilder.h: Ditto.
        (WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement):
        (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList):
        (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole):
        (WebCore::SVGPathSegListBuilder::cleanup):
        * svg/SVGPathSegListSource.cpp: Ditto.
        (WebCore::SVGPathSegListSource::SVGPathSegListSource):
        (WebCore::SVGPathSegListSource::parseSVGSegmentType):
        (WebCore::SVGPathSegListSource::nextCommand):
        (WebCore::SVGPathSegListSource::parseMoveToSegment):
        (WebCore::SVGPathSegListSource::parseLineToSegment):
        (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
        * svg/SVGPathSegListSource.h: Ditto.
        (WebCore::SVGPathSegListSource::create):
        * svg/SVGPathSegMoveto.cpp: Removed.
        * svg/SVGPathSegMoveto.h: All setters now call the commitChange() method.
        * svg/SVGPathSegMovetoAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegMovetoRel.idl: Ditto.
        * svg/SVGPathSegWithContext.h: Added. This is the new base class for all SVGPathSeg derived types, that's associated with a SVGPathElement and a 'role' (normalized/unaltered segment list).
        (WebCore::SVGPathSegWithContext::SVGPathSegWithContext):
        (WebCore::SVGPathSegWithContext::animatedProperty):
        (WebCore::SVGPathSegWithContext::setContextAndRole):
        (WebCore::SVGPathSegWithContext::commitChange):
        (WebCore::SVGPathSegSingleCoordinate::x):
        (WebCore::SVGPathSegSingleCoordinate::setX):
        (WebCore::SVGPathSegSingleCoordinate::y):
        (WebCore::SVGPathSegSingleCoordinate::setY):
        (WebCore::SVGPathSegSingleCoordinate::SVGPathSegSingleCoordinate):
        * svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Added.
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::create):
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):
        * svg/properties/SVGPathSegListPropertyTearOff.cpp: Added.
        (WebCore::SVGPathSegListPropertyTearOff::clear): Added in the cpp file, not in the header, as it needs access to SVGPathSegWithContext, which we can't include from the header.
        (WebCore::SVGPathSegListPropertyTearOff::getItem): Ditto.
        (WebCore::SVGPathSegListPropertyTearOff::removeItem): Ditto.
        (WebCore::SVGPathSegListPropertyTearOff::contextElement): Needs access to SVGPathElement, that's why it lives in the cpp file.
        (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue): Needs access to SVGPathSegWithContext.
        * svg/properties/SVGPathSegListPropertyTearOff.h: Added.
        (WebCore::SVGPathSegListPropertyTearOff::create):
        (WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
        (WebCore::SVGPathSegListPropertyTearOff::numberOfItems):
        (WebCore::SVGPathSegListPropertyTearOff::initialize):
        (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
        (WebCore::SVGPathSegListPropertyTearOff::replaceItem):
        (WebCore::SVGPathSegListPropertyTearOff::appendItem):
        (WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff):
        (WebCore::SVGPathSegListPropertyTearOff::commitChange):
        (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):

2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=49580

        Add several new tests covering SVGPathSegList usage.

        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
        * platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
        * platform/mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-cloning-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
        * platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
        * svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg: Added.
        * svg/dom/SVGPathSegList-appendItem-expected.txt: Added.
        * svg/dom/SVGPathSegList-appendItem.xhtml: Added.
        * svg/dom/SVGPathSegList-clear-and-initialize-expected.txt: Added.
        * svg/dom/SVGPathSegList-clear-and-initialize.xhtml: Added.
        * svg/dom/SVGPathSegList-cloning.html: Added.
        * svg/dom/SVGPathSegList-insertItemBefore-expected.txt: Added.
        * svg/dom/SVGPathSegList-insertItemBefore.xhtml: Added.
        * svg/dom/SVGPathSegList-removeItem-expected.txt: Added.
        * svg/dom/SVGPathSegList-removeItem.xhtml: Added.
        * svg/dom/SVGPathSegList-replaceItem-expected.txt: Added.
        * svg/dom/SVGPathSegList-replaceItem.xhtml: Added.
        * svg/dom/SVGPathSegList-segment-modification.svg: Added.
        * svg/dom/SVGPathSegList-xml-dom-synchronization-expected.txt: Added.
        * svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml: Added.
        * svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: Added.
        * svg/dom/fuzz-path-parser-expected.txt:
        * svg/dom/path-parser-expected.txt:
        * svg/dom/script-tests/path-parser.js:
        ():
        * svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
        * svg/dom/svglist-exception-on-out-bounds-error.html:
        * svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 19 Nov 2010 12:42:26 +0000 (12:42 +0000)]
2010-11-19  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, GTK expectations update after r72347

        * platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
        * platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
        * platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 19 Nov 2010 12:41:37 +0000 (12:41 +0000)]
2010-11-19  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: one line follow up to r72376.

        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 12:32:54 +0000 (12:32 +0000)]
2010-11-19  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] "CRITICAL **: msg_got_headers_cb: assertion `entry' failed" when using HTTP cache
        https://bugs.webkit.org/show_bug.cgi?id=49666

        WebKit resource load cache does validate its own resources by
        issuing conditional requests to the server. The HTTP cache was
        making the assumption that any possible conditional request was
        always generated by itself.

        * platform/network/soup/cache/webkit/soup-cache.c:
        (webkit_soup_cache_entry_remove): added an assertion
        (msg_got_headers_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 12:13:44 +0000 (12:13 +0000)]
2010-11-19  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        stepUp/stepDown for values in step-mismatching state for input elements
        https://bugs.webkit.org/show_bug.cgi?id=48976

        * fast/forms/input-stepup-stepdown-expected.txt:
        * fast/forms/script-tests/input-stepup-stepdown.js:
2010-11-19  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        stepUp/stepDown for values in step-mismatching state for input elements
        https://bugs.webkit.org/show_bug.cgi?id=48976

        Fixed stepUp/stepDown behaviors for step-mismatching values to follow the specification of
        HTML5 4.10.7.3 Common input element APIs. In details, disabled any stepwise adjustment for
        step-mismatching values.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::applyStep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 19 Nov 2010 11:20:38 +0000 (11:20 +0000)]
2010-11-19  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolled out build failures introduced in r72373.

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 19 Nov 2010 11:14:45 +0000 (11:14 +0000)]
2010-11-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide response code and status text as
        a part of raw headers data.
        https://bugs.webkit.org/show_bug.cgi?id=49668

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager.prototype._updateResourceWithResponse):
        * platform/network/ResourceLoadInfo.h: Renamed from WebCore/platform/network/ResourceRawHeaders.h.
        (WebCore::ResourceLoadInfo::ResourceLoadInfo):
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::resourceLoadInfo):
        (WebCore::ResourceResponseBase::setResourceLoadInfo):
        * platform/network/ResourceResponseBase.h:
2010-11-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide response code and status text as a part
        of raw headers data.
        https://bugs.webkit.org/show_bug.cgi?id=49668

        * WebKit.gyp:
        * public/WebHTTPLoadInfo.h: Renamed from WebKit/chromium/public/WebResourceRawHeaders.h.
        (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
        (WebKit::WebHTTPLoadInfo::~WebHTTPLoadInfo):
        (WebKit::WebHTTPLoadInfo::operator =):
        * public/WebURLResponse.h:
        * src/WebHTTPLoadInfo.cpp: Renamed from WebKit/chromium/src/WebResourceRawHeaders.cpp.
        (WebKit::WebHTTPLoadInfo::initialize):
        (WebKit::WebHTTPLoadInfo::reset):
        (WebKit::WebHTTPLoadInfo::assign):
        (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
        (WebKit::WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>):
        (WebKit::WebHTTPLoadInfo::responseCode):
        (WebKit::WebHTTPLoadInfo::setResponseCode):
        (WebKit::WebHTTPLoadInfo::statusText):
        (WebKit::WebHTTPLoadInfo::setStatusText):
        (WebKit::addHeader):
        (WebKit::WebHTTPLoadInfo::addRequestHeader):
        (WebKit::WebHTTPLoadInfo::addResponseHeader):
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::httpLoadInfo):
        (WebKit::WebURLResponse::setHTTPLoadInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Mike Lawther <mikelawther@chromium.org>
commit-queue@webkit.org [Fri, 19 Nov 2010 11:09:47 +0000 (11:09 +0000)]
2010-11-19  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by James Robinson.

        [skia] assert when attempting to get (but not use) pointer to outside the canvas
        https://bugs.webkit.org/show_bug.cgi?id=49698

        Removed expectation of failure on Win dbg

        * platform/chromium/test_expectations.txt:
2010-11-19  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by James Robinson.

        [skia] assert when attempting to get (but not use) pointer to outside the canvas
        https://bugs.webkit.org/show_bug.cgi?id=49698

        Early return to avoid getting a pointer to outside the canvas, and
        hence triggering a Skia assert.

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 19 Nov 2010 10:57:18 +0000 (10:57 +0000)]
2010-11-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: reduce the footprint of InspectorBackendDispatcher.
        InspectorBackendDispatcher is a generated file.
        Its content is not optimal and loc may be reduced by a quarter.
        In each generated function we have a code for getting 'in' values from
        the arguments properties object. I've extracted this code into separate getters.
        The side effect is better readability of the generated code.

        https://bugs.webkit.org/show_bug.cgi?id=49729

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Julie Parent <jparent@chromium.org>
jparent@chromium.org [Fri, 19 Nov 2010 10:54:08 +0000 (10:54 +0000)]
2010-11-19  Julie Parent  <jparent@chromium.org>

        Reviewed by Ojan Vafai.

        [Chromium]Several fast/transforms tests need linux specific baselines
        https://bugs.webkit.org/show_bug.cgi?id=48788

        * platform/chromium-linux/fast/transforms/transform-on-inline-expected.checksum: Added.
        * platform/chromium-linux/fast/transforms/transform-on-inline-expected.png: Added.
        * platform/chromium-linux/fast/transforms/transform-table-row-expected.checksum: Added.
        * platform/chromium-linux/fast/transforms/transform-table-row-expected.png: Added.
        * platform/chromium-linux/fast/transforms/transformed-document-element-expected.checksum: Added.
        * platform/chromium-linux/fast/transforms/transformed-document-element-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Fri, 19 Nov 2010 10:31:26 +0000 (10:31 +0000)]
2010-11-19  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Focus ring does not show for image maps
        https://bugs.webkit.org/show_bug.cgi?id=49615

        * platform/qt/fast/images/imagemap-focus-ring-expected.checksum: Added.
        * platform/qt/fast/images/imagemap-focus-ring-expected.png: Added.
        * platform/qt/fast/images/imagemap-focus-ring-expected.txt: Added.
2010-11-19  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Focus ring does not show for image maps
        https://bugs.webkit.org/show_bug.cgi?id=49615

        Draw a focus ring for the paths surrounding the focus ring of image map area.
        Provide Qt specific results for the test fast/images/imagemap-focus-ring.html.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawFocusRing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 09:35:09 +0000 (09:35 +0000)]
2010-11-19  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        https://bugs.webkit.org/show_bug.cgi?id=49200
        [Qt] bugs in Composition mode for QWebPage::inputMethodEvent & inputMethodQuery()

        Make QWebPage work as following when editor is in composition mode:
        1. anchor position and cursor position are the same and always >= 0
        2. current selection is always null

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        (QWebPage::inputMethodQuery):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update/Add baselines for r72362 and r72355.
levin@chromium.org [Fri, 19 Nov 2010 07:11:37 +0000 (07:11 +0000)]
[chromium] Update/Add baselines for r72362 and r72355.

* platform/chromium-linux/fast/ruby/nested-ruby-expected.checksum: Added.
* platform/chromium-linux/fast/ruby/nested-ruby-expected.png: Added.
* platform/chromium-linux/fast/ruby/nested-ruby-expected.txt: Added.
* platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt:
* platform/chromium-mac/fast/ruby/nested-ruby-expected.checksum: Added.
* platform/chromium-mac/fast/ruby/nested-ruby-expected.png: Added.
* platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt:
* platform/chromium-win/fast/ruby/nested-ruby-expected.checksum: Added.
* platform/chromium-win/fast/ruby/nested-ruby-expected.png: Added.
* platform/chromium-win/fast/ruby/nested-ruby-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix - update error messages folllowing r72360.
barraclough@apple.com [Fri, 19 Nov 2010 07:02:00 +0000 (07:02 +0000)]
Build fix - update error messages folllowing r72360.

* tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-01 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 19 Nov 2010 06:25:28 +0000 (06:25 +0000)]
2010-11-01  MORITA Hajime  <morrita@google.com>

        Reviewed by David Hyatt.

        Navigating dark background websites results in blinding white flashes between pages.
        https://bugs.webkit.org/show_bug.cgi?id=45640

        This FOUC is caused by an early layout request before the <body> is ready,
        and the page's background style given for <body>, instead of <html>.
        So many sites have such stylesheets that we should care them.

        - Some DOM operation such as 'element.offsetLeft' causes page layout.
        - The page layout results page repaint
        - The page page repaint makes a white screen. because there is nothing to paint
          before <body> is available.

        This change:
        - extracted existing FOUC check on RenderBlock and RenderLayer to
          Document::mayCauseFlashOfUnstyledContent(),
        - checked non-<head> element availability on mayCauseFlashOfUnstyledContent(), and
        - added FOUC guards before requesting reapint on FrameView.

        Note that non-<head> document root children are typically <body>, but possibly
        some other type of elements in the case of non-HTML documents.

        No new tests. The data loading speed matters and it cannot be
        captured by DRT.

        * dom/Document.cpp:
        (hasHeadSibling): Added.
        (WebCore::Document::mayCauseFlashOfUnstyledContent): Added.
        * dom/Document.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::invalidateRect): Added a guard.
        (WebCore::FrameView::repaintContentRectangle): Added a guard.
        (WebCore::FrameView::doDeferredRepaints): Added a guard.
        (WebCore::FrameView::shouldUpdate): Added.
        * page/FrameView.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintContents): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer): Replaced FOUC check to use mayCauseFlashOfUnstyledContent

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix - as per DRT-mac, always enabled developer extras,
barraclough@apple.com [Fri, 19 Nov 2010 06:20:18 +0000 (06:20 +0000)]
Build fix - as per DRT-mac, always enabled developer extras,
in win/qt/gtk DRT.

This is necessary to enable rich exception messages to be generated
following https://bugs.webkit.org/show_bug.cgi?id=49708.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(shouldEnableDeveloperExtras):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::shouldEnableDeveloperExtras):
* DumpRenderTree/win/DumpRenderTree.cpp:
(shouldEnableDeveloperExtras):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
kinuko@chromium.org [Fri, 19 Nov 2010 05:16:15 +0000 (05:16 +0000)]
2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72357.
        http://trac.webkit.org/changeset/72357
        https://bugs.webkit.org/show_bug.cgi?id=49784

        It broke test-webkitpy tests since the patch didn't have the
        corresponding test update (Requested by kinuko on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 19 Nov 2010 04:51:17 +0000 (04:51 +0000)]
2010-11-18  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Rebaseline server: add rebaseline queue
        https://bugs.webkit.org/show_bug.cgi?id=49763

        Add a UI queue (a multi-item <select>) where tests to be baselined
        can be enqueued (also supports basic removal). A queue is used instead
        of immediately doing rebaselines since SCM operations can take a while.
        It's better to go through lots of tests quickly to mark them as
        needing rebaselining and then batch the SCM operations.

        Also adds a simple log where results can be displayed.

        * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 19 Nov 2010 04:48:45 +0000 (04:48 +0000)]
2010-11-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        Add more validation message functions
        https://bugs.webkit.org/show_bug.cgi?id=49716

        Add the following message functions:
        - validationMessageValueMissingForCheckbox()
        - validationMessageValueMissingForFile()
        - validationMessageValueMissingForMultipleFile()
        - validationMessageValueMissingForRadio()
        - validationMessageValueMissingForSelect()

        and update ValidityState, HTMLInputElement, and InputTypes to use them.

        No new tests because this doesn't change visible behavior.

        * html/CheckboxInputType.cpp:
        (WebCore::CheckboxInputType::valueMissingText):
        * html/CheckboxInputType.h:
        * html/FileInputType.cpp:
        (WebCore::FileInputType::valueMissingText):
        * html/FileInputType.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::valueMissingText):
        * html/HTMLInputElement.h:
        * html/InputType.cpp:
        (WebCore::InputType::valueMissingText):
        * html/InputType.h:
        * html/RadioInputType.cpp:
        (WebCore::RadioInputType::valueMissingText):
        * html/RadioInputType.h:
        * html/ValidityState.cpp:
        (WebCore::ValidityState::validationMessage):
        * platform/LocalizedStrings.cpp:
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
        * platform/LocalizedStrings.h:
        * platform/android/LocalizedStringsAndroid.cpp:
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
        * platform/brew/LocalizedStringsBrew.cpp:
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
        * platform/efl/LocalizedStringsEfl.cpp:
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
        * platform/haiku/LocalizedStringsHaiku.cpp:
        (WebCore::validationMessageValueMissingText):
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
        * platform/wx/LocalizedStringsWx.cpp:
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
2010-11-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        Add more validation message functions
        https://bugs.webkit.org/show_bug.cgi?id=49716

        Add implementations of new functions and symbols for new messages.

        * public/WebLocalizedString.h:
        * src/LocalizedStrings.cpp:
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 49577 - Function.prototype should be non-configurable
barraclough@apple.com [Fri, 19 Nov 2010 04:33:17 +0000 (04:33 +0000)]
Bug 49577 - Function.prototype should be non-configurable

Rubber stamped by Geoff Garen.

Ooops, Function.prototype should not be enumerable!

JavaScriptCore:

* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):

LayoutTests:

* fast/js/function-prototype-descriptor-expected.txt:
* fast/js/script-tests/function-prototype-descriptor.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Misc test updates (most Ruby).
levin@chromium.org [Fri, 19 Nov 2010 03:34:25 +0000 (03:34 +0000)]
[chromium] Misc test updates (most Ruby).
Rebaselines corresponding to 72347 and 72355.
Add failures for r72344 (until I get the chance to investigate).
Add failures for context-menu failures.

* platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
* platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.txt: Removed.
* platform/chromium-linux/fast/ruby/ruby-length-expected.checksum:
* platform/chromium-linux/fast/ruby/ruby-length-expected.png:
* platform/chromium-linux/fast/ruby/ruby-run-break-expected.checksum:
* platform/chromium-linux/fast/ruby/ruby-run-break-expected.png:
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-mac/fast/ruby/ruby-run-break-expected.checksum: Added.
* platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
* platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
* platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
* platform/chromium-win/fast/ruby/ruby-beforeafter-expected.txt:
* platform/chromium-win/fast/ruby/ruby-empty-rt-expected.txt:
* platform/chromium-win/fast/ruby/ruby-length-expected.checksum:
* platform/chromium-win/fast/ruby/ruby-length-expected.png:
* platform/chromium-win/fast/ruby/ruby-length-expected.txt:
* platform/chromium-win/fast/ruby/ruby-run-break-expected.checksum:
* platform/chromium-win/fast/ruby/ruby-run-break-expected.png:
* platform/chromium-win/fast/ruby/ruby-run-break-expected.txt:
* platform/chromium-win/fast/ruby/ruby-runs-expected.txt:
* platform/chromium-win/fast/ruby/ruby-runs-spans-expected.txt:
* platform/chromium-win/fast/ruby/ruby-simple-expected.txt:
* platform/chromium-win/fast/ruby/ruby-simple-rp-expected.txt:
* platform/chromium-win/fast/ruby/ruby-trailing-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-remove-text2-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 49708 - Stop recompiling functions to regenerate exception info.
barraclough@apple.com [Fri, 19 Nov 2010 02:35:25 +0000 (02:35 +0000)]
Bug 49708 - Stop recompiling functions to regenerate exception info.

Reviewed by Oliver Hunt.

Instead only hold info as necessary – keep divot info is the inspector
is enabled, line number info is debugging or profiling, and handler
info for functions with try/catch.

JavaScriptCore:

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::addExpressionInfo):
(JSC::CodeBlock::addLineInfo):
(JSC::CodeBlock::hasExpressionInfo):
(JSC::CodeBlock::hasLineInfo):
(JSC::CodeBlock::needsCallReturnIndices):
(JSC::CodeBlock::callReturnIndexVector):
* bytecode/SamplingTool.cpp:
(JSC::SamplingTool::dump):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
(JSC::BytecodeGenerator::emitExpressionInfo):
(JSC::BytecodeGenerator::addLineInfo):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::appendSourceToError):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITStubs.cpp:
(JSC::jitThrow):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Collector.cpp:
(JSC::Heap::markRoots):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::usingAPI):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsRichSourceInfo):
(JSC::JSGlobalObject::globalData):

WebCore:

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
    - report to JSC whether the inspector is enabled - in which
      case we will generate better error messages on exceptions.
* bindings/js/JSDOMWindowBase.h:

WebKitTools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(shouldEnableDeveloperExtras):
    - always enable the developer tools from DRT, to ensure we
      produce rich error messages on JavaScript exceptions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a script to delete manifest-related files when they are older than any .vsprops...
aroben@apple.com [Fri, 19 Nov 2010 02:19:32 +0000 (02:19 +0000)]
Add a script to delete manifest-related files when they are older than any .vsprops file

Changes to .vsprops files can cause the manifest files to become
invalid, and Visual Studio doesn't always figure out that it needs to
rebuild them.

Reviewed by Sam Weinig.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
Call the new script.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
Added the new script.

* JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py: Added.
(file_modification_times): Generator to return the modification time of
each file in a directory hierarchy.
(main): Get the modification time of the newest vsprops file, then find
all manifest-related files in the obj directory. Delete all
manifest-related files that are older than the newest vsprops file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake binding code generation scripts support 'short' type
jianli@chromium.org [Fri, 19 Nov 2010 02:13:44 +0000 (02:13 +0000)]
Make binding code generation scripts support 'short' type
https://bugs.webkit.org/show_bug.cgi?id=49704

Reviewed by Kenneth Russell.

Updated binding tests.

* bindings/scripts/CodeGeneratorJS.pm: Also fixed a style issue.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 19 Nov 2010 02:05:54 +0000 (02:05 +0000)]
2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
        https://bugs.webkit.org/show_bug.cgi?id=49702

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8602509&8602717&8602724> Enable compaction support.
mrowe@apple.com [Fri, 19 Nov 2010 01:58:10 +0000 (01:58 +0000)]
<rdar://problem/8602509&8602717&8602724> Enable compaction support.

Rubber-stamped by Adam Roben.

JavaScriptCore:

* Configurations/JavaScriptCore.xcconfig:

WebCore:

* Configurations/WebCore.xcconfig:

WebKit/mac:

* Configurations/WebKit.xcconfig:

WebKit2:

* Configurations/WebKit2.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49772
hyatt@apple.com [Fri, 19 Nov 2010 01:33:33 +0000 (01:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49772

Reviewed by Dan Bernstein.

Fix nested ruby.  My previous checkin (for 49717) broke it.  Push the ruby text and ruby base text
together based off logicalTopOverflow and logicalBottomOverflow rather than lineTop and lineBottom.
This way the overflow from nested rubies is accounted for.

Added fast/ruby/nested-ruby.html

WebCore:

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layout):

LayoutTests:

* fast/ruby/nested-ruby.html: Added.
* platform/mac/fast/ruby/nested-ruby-expected.checksum: Added.
* platform/mac/fast/ruby/nested-ruby-expected.png: Added.
* platform/mac/fast/ruby/nested-ruby-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 19 Nov 2010 01:32:06 +0000 (01:32 +0000)]
2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Nate Chapin.

        [V8] ASSERT(WTF::isMainThread()) fails in V8Binding::int32ToWebCoreString in workers
        https://bugs.webkit.org/show_bug.cgi?id=49613

        No new tests. Running existing worker tests like
        fast/workers/storage/execute-sql-args-worker.html in chromium
        would verify it.

        * bindings/v8/V8Binding.cpp:
        (WebCore::int32ToWebCoreStringFast):
        (WebCore::int32ToWebCoreString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Updating test results. I don't know what this mega-test is doing, but at...
ap@apple.com [Fri, 19 Nov 2010 01:21:10 +0000 (01:21 +0000)]
    Updating test results. I don't know what this mega-test is doing, but at least they changed
        from FAIL to PASS.

        * fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago WebKit2: Safari shouldn't auto-activate plug-ins in background tabs.
bweinstein@apple.com [Fri, 19 Nov 2010 01:11:27 +0000 (01:11 +0000)]
 WebKit2: Safari shouldn't auto-activate plug-ins in background tabs.
 https://bugs.webkit.org/show_bug.cgi?id=49770
 <rdar://problem/8482424>

Reviewed by Adam Roben.

 Add an API on Windows to call setIsInWindow, which calls through to WebPage::setIsInWindow.
 Remove the !PLATFORM(WIN) check in WebPage, so we don't automatically start plugins that are
 loaded in background tabs.

* UIProcess/API/C/win/WKView.cpp:
(WKViewSetIsInWindow): Call through to WebView::setIsInWindow.
* UIProcess/API/C/win/WKView.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::setIsInWindow): Call through to WebPage::setIsInWindow.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Remove the !PLATFORM(WIN) check and update the comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 49635 - Profiler implementation is fragile
barraclough@apple.com [Fri, 19 Nov 2010 00:54:26 +0000 (00:54 +0000)]
Bug 49635 - Profiler implementation is fragile

Reviewed by Oliver Hunt.

JavaScriptCore:

The profile presently requires the exception handling mechanism to explicitly
remove all stack frames that are exited during the exception unwind mechanism.
This is fragile in a number of ways:
  * We have to change bytecode register allocation when compiling code to run
    when profiling, to preserve the callee function (this is also required to
    call did_call after the call has returned).
  * In the JIT we have to maintain additional data structures
    (CodeBlock::RareData::m_functionRegisterInfos) to map back to the register
    containing the callee.
  * In the interpreter we use 'magic values' to offset into the instruction
    stream to rediscover the register containing the function.

Instead, move profiling into the head and tail of functions.
  * This correctly accounts the cost of the call itself to the caller.
  * This allows us to access the callee function object from the callframe.
  * This means that at the point a call is made we can track the stack depth
    on the ProfileNode.
  * When unwinding we can simply report the depth at which the exception is
    being handled - all call frames above this level are freed.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::methodCallLinkInfo):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::exceptionUnwind):
(JSC::ProfileGenerator::stopProfiling):
* profiler/ProfileGenerator.h:
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::willExecute):
* profiler/ProfileNode.h:
(JSC::ProfileNode::create):
(JSC::ProfileNode::callerCallFrame):
* profiler/Profiler.cpp:
(JSC::dispatchFunctionToProfiles):
(JSC::Profiler::_willExecute):
(JSC::Profiler::_didExecute):
(JSC::Profiler::exceptionUnwind):
* profiler/Profiler.h:

LayoutTests:

Fixes previously failing tests - output was incorrect, showing duplicate entries
for '(program) (no file) (line 1)'.

* fast/profiler/throw-exception-from-eval-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* WebProcess/WebPage/WebPage.cpp: Fix build by rolling out a change.
darin@apple.com [Fri, 19 Nov 2010 00:51:57 +0000 (00:51 +0000)]
* WebProcess/WebPage/WebPage.cpp: Fix build by rolling out a change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 19 Nov 2010 00:51:51 +0000 (00:51 +0000)]
2010-11-18  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/win/Skipped: Add a bug URL for <progress>-related tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Windows build fix.
ap@apple.com [Fri, 19 Nov 2010 00:46:23 +0000 (00:46 +0000)]
    Windows build fix.

        https://bugs.webkit.org/show_bug.cgi?id=49762
        Stylesheet wrappers are not GC protected

        * bindings/js/JSBindingsAllInOne.cpp: Added new custom binding files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49717
hyatt@apple.com [Fri, 19 Nov 2010 00:43:29 +0000 (00:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49717

Reviewed by Dan Bernstein.

Implement better behavior for the logical height and block direction spacing of ruby text and ruby
base text.

Added six new tests: ruby-auto-line-expansion.html (one version for each of the four writing modes) to
test ruby text accommodation and quirks-mode-ruby-spacing.html / quirks-mode-ruby-spacing-bt.html to test
that ruby doesn't reset line-height.

* css/html.css:
Remove the line-height:normal rule for <ruby>  This behavior was incorrect, since a <ruby> on a line
by itself in quirks mode would cause the overall line-height of the enclosing block to not be honored.

* rendering/InlineBox.h:
(WebCore::InlineBox::adjustBlockDirectionPosition):
Add adjustBlockDirectionPosition as a shorthand for calling adjustPosition with the correct delta (x or y)
depending on orientation.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
placeBoxesInBlockDirection now looks for Ruby runs, and when it encounters them it sets a flag, containsRuby,
to true.  This flag is stored as a bit on the RootInlineBox and lets us know whether we need to do a later
crawl of the line boxes after they are positioned to see if all the Ruby texts fit or not.

Add the notion of a lineTop and lineBottom that include margins, since flipped lines writing modes (lr and bt)
mess up the flipping otherwise.  These new variables are lineTopIncludingMargins and lineBottomIncludingMargins.
This is only relevant for replaced elements, since the block direction margins of inline flows are always 0.

Because RenderRubyRun is implemented as an inline-block (this is probably not a behavior we want to keep long-term),
the line-height is propagated into the inline-block, and it ends up being counted as part of the overall lineTop
and lineBottom since it is inside the inline-block's height.  To prevent this from happening, we have to fake it
as though RenderRubyRun was just a normal inline.  We look at the line boxes of the ruby base and we push lineTop/Bottom
in by the leading on either side so that it isn't counted as part of lineTop and lineBottom.  This enables the later
Ruby code that examines the spacing between lines to not be fooled into thinking it can't intrude into an inline-block's
interior on a previous line.

(WebCore::InlineFlowBox::computeBlockDirectionRubyAdjustment):
This function computes the amount that a line box has to be moved in order to accommodate all of the Ruby texts on the
line.  With tb and rl writing modes, the Ruby is trying to fit between the current line and a previous line, and so
we're checking some highest previous position and computing the amount we have to move.

For lr and bt writing modes, the lines are flipped relative to the block direction, so we are computing how much we have
to move the *following* line based off a lowest position.

In all writing modes we will allow Ruby text to intrude into the padding of a block.

* rendering/InlineFlowBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
Ruby text is now considered a special child that should be excluded from normal layout, margin collapsing and height
computations.  Rename the layoutLegend function to be more generalized and make it apply to both Ruby text and to
legends.  This means that the RenderRubyRun computes its logical height without any regard for the ruby text.

* rendering/RenderBlock.h:
(WebCore::RenderBlock::layoutSpecialExcludedChild):
layoutSpecialExcludedChild is the new version of layoutLegend and it is implemented by RenderFieldset and RenderRubyRun.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
When we hit the end of line layout, if we're in lr or bt writing modes, we have to potentially grow the height of the block
to accommodate ruby text along the bottom side of the line.  We call computeBlockDirectionRubyAdjustment here in flipped lines
writing mode only, and then we increase the logical height of the block if necessary.

* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
* rendering/RenderFieldset.h:
No changes here other than the function rename.

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::staticCreateRubyRun):
Remove the hack that locked RenderRubyRun's writing mode to tb or rl, since it didn't really work anyway, and it isn't necessary
now that RenderRubyRun has its own layout method.

(WebCore::RenderRubyRun::layoutSpecialExcludedChild):
RenderRubyRun lays out the ruby text here but doesn't do anything with its placement yet.  We wait until the base is positioned
and then handled positioning the RenderRubyText at the end of RenderRubyRun's layout method.

(WebCore::RenderRubyRun::layout):
* rendering/RenderRubyRun.h:
RenderRubyRun now has its own layout method that calls the base class to get the RenderRubyBase positioned and then moves the
RenderRubyText such that its bottommost line box's bottom and the RenderRubyBase's topmost line box's line top are flush with
one another.  The RenderRubyText will commonly be positioned at a negative coordinate now and spill out of the RenderRubyRun
as overflow.

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
Added the m_containsRuby bit for performance to avoid the extra pass to try to accommodate ruby texts when none are present.

(WebCore::RootInlineBox::adjustPosition):
Fixed a bug in adjustPosition where the lineTop, lineBottom and blockLogicalHeight values were always being augmented by dy
even in vertical writing modes (where dx needed to be used instead).

WebCore:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::blockDirectionRubyAdjustment):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::containsRuby):
RootInlineBox now calls blockDirectionRubyAdjustment to determine the amount of additional spacing that has to exist between
the lines in order to accommodate all Ruby texts, and then it does adjustPosition to move the new line by the amount required.

LayoutTests:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::blockDirectionRubyAdjustment):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::containsRuby):
RootInlineBox now calls blockDirectionRubyAdjustment to determine the amount of additional spacing that has to exist between
the lines in order to accommodate all Ruby texts, and then it does adjustPosition to move the new line by the amount required.

* fast/ruby/ruby-line-height-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/mac/fast/ruby/quirks-mode-ruby-spacing-bt-expected.checksum: Added.
* platform/mac/fast/ruby/quirks-mode-ruby-spacing-bt-expected.png: Added.
* platform/mac/fast/ruby/quirks-mode-ruby-spacing-bt-expected.txt: Added.
* platform/mac/fast/ruby/quirks-mode-ruby-spacing-expected.checksum: Added.
* platform/mac/fast/ruby/quirks-mode-ruby-spacing-expected.png: Added.
* platform/mac/fast/ruby/quirks-mode-ruby-spacing-expected.txt: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-bt-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-bt-expected.png: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-bt-expected.txt: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-expected.png: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-expected.txt: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-lr-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-lr-expected.png: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-lr-expected.txt: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-rl-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-rl-expected.png: Added.
* platform/mac/fast/ruby/ruby-auto-line-expansion-rl-expected.txt: Added.
* platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
* platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
* platform/mac/fast/ruby/ruby-length-expected.txt:
* platform/mac/fast/ruby/ruby-run-break-expected.checksum:
* platform/mac/fast/ruby/ruby-run-break-expected.png:
* platform/mac/fast/ruby/ruby-run-break-expected.txt:
* platform/mac/fast/ruby/ruby-runs-expected.txt:
* platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
* platform/mac/fast/ruby/ruby-simple-expected.txt:
* platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
* platform/mac/fast/ruby/ruby-trailing-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 19 Nov 2010 00:40:30 +0000 (00:40 +0000)]
2010-11-18  Darin Adler  <darin@apple.com>

        Reviewed by Kevin Decker.

        REGRESSION (WebKit2): Plug-ins and <video> start playing immediately in background tabs
        https://bugs.webkit.org/show_bug.cgi?id=49766

        Test: manual-tests/resources/video-tab.html

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage): Call setCanStartMedia(false) since the rest of the code
        starts out treating the page as "not in a window".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Test baseline updates.
levin@chromium.org [Fri, 19 Nov 2010 00:40:06 +0000 (00:40 +0000)]
[chromium] Test baseline updates.

* platform/chromium-linux/fast/compact/001-expected.checksum:
  Rebaselined due to r72141. Removes the green background in the
  test. Dave Hyatt confirmed the behavior: "We actually removed
  compact support ages ago, so really the test should just be removed."

* platform/chromium-linux/fast/compact/001-expected.png:
  Ditto.
* platform/chromium-mac/fast/compact/001-expected.checksum: Added.
  Ditto.
* platform/chromium-mac/fast/compact/001-expected.png: Added.
  Ditto.
* platform/chromium-win/fast/compact/001-expected.checksum:
  Ditto.
* platform/chromium-win/fast/compact/001-expected.png:
  Ditto.
* platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.checksum:
* platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.png:
  Updated due to r72173. The changes in output appear minimal and the output looks ok.

* platform/chromium-win/fast/js/regexp-overflow-expected.txt: Removed.
  Consolidated the results for this test.
* platform/chromium/fast/js/regexp-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/js/regexp-overflow-expected.txt.
  Ditto.

* platform/chromium-linux/fast/parser/style-script-head-test-expected.txt: Removed.
* platform/chromium-win/fast/parser/style-script-head-test-expected.txt: Removed.
  Chromium results are exactly the same as platform/mac, so no need for platform
  specific results.

* platform/chromium/test_expectations.txt: Updated due to these changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Geoffrey Garen.
ap@apple.com [Fri, 19 Nov 2010 00:23:41 +0000 (00:23 +0000)]
    Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=49762
        Stylesheet wrappers are not GC protected

        Tests: fast/dom/StyleSheet/gc-inline-style-cssvalues.html
               fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        Added the new custom bindings files.

        * WebCore.xcodeproj/project.pbxproj: Added the new custom bindings files. Also, added some
        existing headers.

        * bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM): If a node has a stylesheet
        with a wrapper, it may be the only thing having the stylesheet's wrapper alive, so its own
        wrapper has to stay alive, too.
        While at it, also fixed the same issue with inline style declarations.
        Also, added a FIXME comment about one with attribute nodes. We implement a less conservative
        approach for nodes, so perhaps fixing this is not as easy as removing a hasCustomProperties()
        check.

        * bindings/js/JSHTMLLinkElementCustom.cpp: Added.
        (WebCore::JSHTMLLinkElement::markChildren):
        * bindings/js/JSHTMLStyleElementCustom.cpp: Added.
        (WebCore::JSHTMLStyleElement::markChildren):
        * bindings/js/JSProcessingInstructionCustom.cpp: Added.
        (WebCore::JSProcessingInstruction::markChildren):
        Mark stylesheets owned by these nodes. As always in markChildren() functions, we do it
        conservatively, without checking whether the stylesheet or any of its children have custom
        properties.

        * dom/ProcessingInstruction.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLStyleElement.idl:
        These have custom mark functions now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove length and slice out of ArrayBufferView interface
jianli@chromium.org [Fri, 19 Nov 2010 00:12:06 +0000 (00:12 +0000)]
Move length and slice out of ArrayBufferView interface
https://bugs.webkit.org/show_bug.cgi?id=49697

Reviewed by Kenneth Russell.

No functionality change. Covered by existing ArrayBuffer tests.

* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSArrayBufferViewCustom.cpp: Removed.
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Removed.
* html/canvas/ArrayBufferView.h:
* html/canvas/ArrayBufferView.idl:
* html/canvas/Float32Array.cpp:
(WebCore::Float32Array::slice):
* html/canvas/Float32Array.h:
* html/canvas/Float32Array.idl:
* html/canvas/Int16Array.cpp:
(WebCore::Int16Array::slice):
* html/canvas/Int16Array.h:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.cpp:
(WebCore::Int32Array::slice):
* html/canvas/Int32Array.h:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.cpp:
(WebCore::Int8Array::slice):
* html/canvas/Int8Array.h:
* html/canvas/Int8Array.idl:
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::length):
* html/canvas/Uint16Array.cpp:
(WebCore::Uint16Array::slice):
* html/canvas/Uint16Array.h:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.cpp:
(WebCore::Uint32Array::slice):
* html/canvas/Uint32Array.h:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.cpp:
(WebCore::Uint8Array::slice):
* html/canvas/Uint8Array.h:
* html/canvas/Uint8Array.idl:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::readPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 19 Nov 2010 00:03:12 +0000 (00:03 +0000)]
2010-11-18  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/win/Skipped: Skip fast/forms/form-atribute.html. It needs <progress> support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 18 Nov 2010 23:56:00 +0000 (23:56 +0000)]
2010-11-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=47196

        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::ignoresGammaAndColorProfile): Add a getter function for the ignoreGammaAndColorProfile setting.
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::decode): Hookup ignoreGammaAndColorProfile setting with color profile processing.
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable): Ditto.
2010-11-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=47196

        * fast/canvas/webgl/gl-teximage-expected.txt:
        * fast/canvas/webgl/gl-teximage.html: Add test cases for images with ICC profiles.
        * fast/canvas/webgl/resources/small-square-with-cie-rgb-profile.png: Added.
        * fast/canvas/webgl/resources/small-square-with-colormatch-profile.png: Added.
        * fast/canvas/webgl/resources/small-square-with-colorspin-profile.jpg: Added.
        * fast/canvas/webgl/resources/small-square-with-colorspin-profile.png: Added.
        * fast/canvas/webgl/resources/small-square-with-e-srgb-profile.png: Added.
        * fast/canvas/webgl/resources/small-square-with-smpte-c-profile.png: Added.
        * fast/canvas/webgl/resources/small-square-with-srgb-iec61966-2.1-profile.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove fileapi test files under http/tests/local to a new subdirectory under it
jianli@chromium.org [Thu, 18 Nov 2010 23:33:54 +0000 (23:33 +0000)]
Move fileapi test files under http/tests/local to a new subdirectory under it
https://bugs.webkit.org/show_bug.cgi?id=49709

Reviewed by David Levin.

* http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js: Renamed from LayoutTests/http/tests/local/resources/setup-file-input-element-for-drag.js.
* http/tests/local/fileapi/script-tests/TEMPLATE.html: Added.
* http/tests/local/fileapi/script-tests/send-dragged-file.js: Renamed from LayoutTests/http/tests/local/resources/send-dragged-file.js.
* http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js: Renamed from LayoutTests/http/tests/local/resources/send-sliced-dragged-file.js.
* http/tests/local/fileapi/send-dragged-file-expected.txt: Renamed from LayoutTests/http/tests/local/send-dragged-file-expected.txt.
* http/tests/local/fileapi/send-dragged-file.html: Renamed from LayoutTests/http/tests/local/send-dragged-file.html.
* http/tests/local/fileapi/send-sliced-dragged-file-expected.txt: Renamed from LayoutTests/http/tests/local/send-sliced-dragged-file-expected.txt.
* http/tests/local/fileapi/send-sliced-dragged-file.html: Renamed from LayoutTests/http/tests/local/send-sliced-dragged-file.html.
* platform/gtk/Skipped:
* platform/mac-tiger/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 18 Nov 2010 23:23:31 +0000 (23:23 +0000)]
2010-11-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes

        Create the first version of the 'message_broker' package. This
        class will encapsulate all of the threading/multiprocessing and
        message-sending details for the communication between the
        'manager' object and the 'worker' objects. For the moment, it
        just holds some routines and tests for logging thread stacks.

        There should be no functional changes in this patch, just moving stuff
        around.

        https://bugs.webkit.org/show_bug.cgi?id=49707

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add test expectations for failing tests.
levin@chromium.org [Thu, 18 Nov 2010 22:46:44 +0000 (22:46 +0000)]
[chromium] Add test expectations for failing tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 18 Nov 2010 22:30:13 +0000 (22:30 +0000)]
2010-11-18  Tony Chang  <tony@chromium.org>

        Unreviewed, fix chromium compile.  We need ipc and openssl now.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused debug_internal vsprops file.
sfalken@apple.com [Thu, 18 Nov 2010 22:26:12 +0000 (22:26 +0000)]
Remove unused debug_internal vsprops file.

Rubber-stamped by Adam Roben.

* win/tools/vsprops/debug_internal.vsprops: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove leftover Windows Debug_Internal configurations
sfalken@apple.com [Thu, 18 Nov 2010 22:12:08 +0000 (22:12 +0000)]
Remove leftover Windows Debug_Internal configurations
https://bugs.webkit.org/show_bug.cgi?id=49758

Reviewed by Adam Roben.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:

WebCore:

* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/WebCore.vcproj:

WebKit/win:

* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:

WebKit2:

* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:

WebKitTools:

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
* MiniBrowser/MiniBrowser.vcproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* WebKitAPITest/WebKitAPITest.vcproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
* WinLauncher/WinLauncher.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r72299.
levin@chromium.org [Thu, 18 Nov 2010 22:03:47 +0000 (22:03 +0000)]
Unreviewed, rolling out r72299.
http://trac.webkit.org/changeset/72299
https://bugs.webkit.org/show_bug.cgi?id=49761

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-11-18
Broke chromium ui test SessionHistoryTest.FrameBackForward.
(Requested by dave_levin on #webkit).

* loader/HistoryController.cpp:
(WebCore::HistoryController::HistoryController):
(WebCore::HistoryController::saveDocumentState):
(WebCore::HistoryController::updateForBackForwardNavigation):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateForFrameLoadCompleted):
(WebCore::HistoryController::setCurrentItem):
(WebCore::HistoryController::createItem):
(WebCore::HistoryController::createItemTree):
(WebCore::HistoryController::recursiveGoToItem):
* loader/HistoryController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 18 Nov 2010 21:52:15 +0000 (21:52 +0000)]
2010-11-18  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for the Mac port.

        For the tests that currently fail on Snow Leopard with --pixel-tests
        --tolerance 0, this moves the current pixel results to mac-leopard and
        adds new Snow Leopard-specific results to platform/mac.

        List of files omitted due to length but composed entirely of moves from
        platform/mac to platform/mac-leopard and newly added files in
        platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* StringsNotToBeLocalized.txt: Updated for recent changes.
darin@apple.com [Thu, 18 Nov 2010 21:50:16 +0000 (21:50 +0000)]
* StringsNotToBeLocalized.txt: Updated for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix failures seen on bot.
darin@apple.com [Thu, 18 Nov 2010 21:42:16 +0000 (21:42 +0000)]
Fix failures seen on bot.

* platform/qt/Skipped: Skip test, added bugs.webkit.org reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd three new Windows XP build slaves
aroben@apple.com [Thu, 18 Nov 2010 21:33:42 +0000 (21:33 +0000)]
Add three new Windows XP build slaves

Reviewed by Steve Falkenburg.

* BuildSlaveSupport/build.webkit.org-config/config.json: Added three
new slaves, and added them to the Windows XP Debug (Tests) builder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-12 Luiz Agostini <luiz.agostini@openbossa.org>
luiz@webkit.org [Thu, 18 Nov 2010 21:29:27 +0000 (21:29 +0000)]
2010-11-12  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Static platform plugin support
        https://bugs.webkit.org/show_bug.cgi?id=49470

        Adding support for statically linked platform plugins.

        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::loadStaticallyLinkedPlugin):
        (WebCore::QtPlatformPlugin::plugin):
        * WebCoreSupport/QtPlatformPlugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPage overlays should be able to handle mouse events
andersca@apple.com [Thu, 18 Nov 2010 21:21:36 +0000 (21:21 +0000)]
Page overlays should be able to handle mouse events
https://bugs.webkit.org/show_bug.cgi?id=49756

Reviewed by John Sullivan.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
Add API cast function for converting an IntPoint to a WKPoint.

* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(PageOverlayClientImpl::mouseEvent):
Call the appropriate callbacks.

* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
Add new callbacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
sfalken@apple.com [Thu, 18 Nov 2010 20:42:44 +0000 (20:42 +0000)]
WebCore: [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
https://bugs.webkit.org/show_bug.cgi?id=49638

Patch by James Robinson <jamesr@chromium.org> on 2010-11-18
Reviewed by Darin Fisher.

Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
like Safari Win did in r72270.

Test: fast/text/font-size-zero.html

* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):

WebKit/win: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753

Reviewed by Adam Roben.

* WebKitPrefix.h:

WebKit2: Keep the web process alive if there are active downloads
https://bugs.webkit.org/show_bug.cgi?id=49755

Patch by Anders Carlsson <andersca@apple.com> on 2010-11-18
Reviewed by Sam Weinig.

Make sure that Download objects are destroyed when the download finishes or fails.
Don't close the web process if there are live Download objects.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didFail):
Add stub.

* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/Downloads/DownloadProxy.messages.in:
Add DidFail message.

* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didFinish):
Call DownloadManager::downloadFinished.

(WebKit::Download::didFail):
Send DidFail message and call DownloadManager::downloadFinished.

* WebProcess/Downloads/Download.h:
(WebKit::Download::destinationID):
Call downloadID().

(WebKit::Download::downloadID):
Return the download ID.

* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::downloadFinished):
Delete the Download object and call WebProcess::shutdownIfPossible.

* WebProcess/Downloads/DownloadManager.h:
(WebKit::DownloadManager::isDownloading):
Return whether the download manager has any active downloads.

* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didFailWithError:]):
Call Download::didFail.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::removeWebPage):
Call shutdownIfPossible.

(WebKit::WebProcess::shutdownIfPossible):
New function. Don't shutdown if there are live pages or active downloads.

* WebProcess/WebProcess.h:

WebKitLibraries: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753

Reviewed by Adam Roben.

* win/tools/vsprops/debug.vsprops:
* win/tools/vsprops/debug_internal.vsprops:

WebKitTools: update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
https://bugs.webkit.org/show_bug.cgi?id=49503

Patch by Daniel Bates <dbates@rim.com> on 2010-11-18
Reviewed by Adam Roben.

Fall back to existing support libraries (if present) when there is
no internet connection.

Currently, update-webkit-support-libs dies with an "out-of-date"
error when there is no internet connection because it cannot
retrieve versioning information from developer.apple.com. Because
update-webkit-support-libs fails, build-webkit fails. Instead,
if there is no internet connection and the support libraries are
present then we should warn the user and exit() with success so
that build-webkit can work without an internet connection.

* Scripts/update-webkit-support-libs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 18 Nov 2010 20:29:19 +0000 (20:29 +0000)]
2010-11-18  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Roben.

        update-webkit-support-libs should fall back to existing
        WebKitSupportLibrary version if there is no internet connectivity
        https://bugs.webkit.org/show_bug.cgi?id=49503

        Fall back to existing support libraries (if present) when there is
        no internet connection.

        Currently, update-webkit-support-libs dies with an "out-of-date"
        error when there is no internet connection because it cannot
        retrieve versioning information from developer.apple.com. Because
        update-webkit-support-libs fails, build-webkit fails. Instead,
        if there is no internet connection and the support libraries are
        present then we should warn the user and exit() with success so
        that build-webkit can work without an internet connection.

        * Scripts/update-webkit-support-libs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows results for test added in r71980
aroben@apple.com [Thu, 18 Nov 2010 20:26:11 +0000 (20:26 +0000)]
Add Windows results for test added in r71980

* platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
* platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
* platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 18 Nov 2010 20:10:27 +0000 (20:10 +0000)]
2010-11-18  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
        https://bugs.webkit.org/show_bug.cgi?id=49638

        Adds a test checking that the bounding client rect of a text run with font-size:0
        has zero height.  This is also covered by acid3, but an isolated test case is easier
        to work with.

        * fast/text/font-size-zero-expected.txt: Added.
        * fast/text/font-size-zero.html: Added.
        * fast/text/script-tests/font-size-zero.js: Added.
2010-11-18  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
        https://bugs.webkit.org/show_bug.cgi?id=49638

        Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
        Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
        like Safari Win did in r72270.

        Test: fast/text/font-size-zero.html

        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::setupPaint):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72324 268f45cc-cd09-0410-ab3c-d52691b4dbfc