WebKit-https.git
9 years ago2010-11-23 Adam Bergkvist <adam.bergkvist@ericsson.com>
commit-queue@webkit.org [Tue, 23 Nov 2010 17:29:20 +0000 (17:29 +0000)]
2010-11-23  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        Reviewed by Martin Robinson.

        [GTK] Building with Blob support fails
        https://bugs.webkit.org/show_bug.cgi?id=49724

        Build fix.

        * GNUmakefile.am:
        * platform/gtk/FileSystemGtk.cpp:
        (WebCore::seekFile): Not implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Nov 2010 17:18:56 +0000 (17:18 +0000)]
2010-11-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Updated chromium expectations.

        Plugin tests were disabled.

        MAC : compositing/plugins/1x1-composited-plugin.html = CRASH
        MAC : compositing/plugins/composited-plugin.html = CRASH
        MAC : compositing/plugins/large-to-small-composited-plugin.html = CRASH
        MAC : compositing/plugins/small-to-large-composited-plugin.html = CRASH

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
andreas.kling@nokia.com [Tue, 23 Nov 2010 16:58:46 +0000 (16:58 +0000)]
2010-11-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Adapt to setShouldDelegateScrolling not being a real setting anymore.
        We now similarily to setUseFixedLayout and setPaintEntireContents
        set it on the FrameView wen transitioning to a new page.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2010-11-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make setShouldDelegateScrolling not a real setting, so that it works
        similar to the related setUseFixedLayout and setPaintEntireContents
        options which are all in ScrollView.

        * page/FrameView.cpp:
        * page/FrameView.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::ScrollView):
        (WebCore::ScrollView::setDelegatesScrolling):
        * platform/ScrollView.h:
        (WebCore::ScrollView::delegatesScrolling):
2010-11-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Adapt to setShouldDelegateScrolling not being a real setting anymore.
        We now similarily to setUseFixedLayout and setPaintEntireContents
        set it on the FrameView wen transitioning to a new page, etc.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setResizesToContentsUsingLayoutSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't rely on DocumentLoader outliving the load/unload events
aroben@apple.com [Tue, 23 Nov 2010 16:54:18 +0000 (16:54 +0000)]
Don't rely on DocumentLoader outliving the load/unload events

DocumentLoader::m_documentLoadTiming is used to record how long firing
the load event took. But the DocumentLoader was being destroyed while
the event was being dispatched (due to a call to document.open), which
meant that when we tried to record the time when the load event
finished, we were writing into freed memory. We now protect the
DocumentLoader using a RefPtr. (I initially made a change where we
would only access the DocumentLoader after the event has finished
firing, but it seemed possible that a different DocumentLoader could
have come into existence by then, which would cause us to record the
times on the wrong DocumentLoadTiming struct.)

I only saw a crash when firing the load event, but the code for timing
the unload event seemed like it was vulnerable to the same issue, so I
made the same fix for it.

Fixes <http://webkit.org/b/49972> REGRESSION (r72415?): Crash in
DOMWindow::dispatchTimedEvent when running fast/dom/onload-open.html

Reviewed by Darin Fisher.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
Protect the DocumentLoader (and thus its DocumentLoadTiming) with a
RefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 23 Nov 2010 16:51:12 +0000 (16:51 +0000)]
2010-11-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        readPixels should generate INVALID_ENUM if only one of type/format mismatch UNSIGNED_BYTE/RGBA
        https://bugs.webkit.org/show_bug.cgi?id=49673

        Test: fast/canvas/webgl/read-pixels-test.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::readPixels):
2010-11-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        readPixels should generate INVALID_ENUM if only one of type/format mismatch UNSIGNED_BYTE/RGBA
        https://bugs.webkit.org/show_bug.cgi?id=49673

        * fast/canvas/webgl/read-pixels-test-expected.txt: Added.
        * fast/canvas/webgl/read-pixels-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Nov 2010 16:19:30 +0000 (16:19 +0000)]
2010-11-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Expectations for chromium were fixed.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Nov 2010 15:47:47 +0000 (15:47 +0000)]
2010-11-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Just fixing tipo in test_expectations.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Nov 2010 15:34:50 +0000 (15:34 +0000)]
2010-11-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Updating test expectations for chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 23 Nov 2010 15:33:21 +0000 (15:33 +0000)]
2010-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix compilation with !ENABLE(INSPECTOR)
        https://bugs.webkit.org/show_bug.cgi?id=49942

        Add ENABLE(INSPECTOR) to the Qt specific files following r71981.

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::inspectorDestroyed):
        (WebCore::InspectorClientQt::openInspectorFrontend):
        (WebCore::InspectorClientQt::sendMessageToFrontend):
        * WebCoreSupport/InspectorServerQt.cpp:
        (WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Nov 2010 15:01:35 +0000 (15:01 +0000)]
2010-11-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Adjusting expectations for chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Restore binary compatibility with the QtWebKit 2.1 branch
hausmann@webkit.org [Tue, 23 Nov 2010 14:52:22 +0000 (14:52 +0000)]
[Qt] Restore binary compatibility with the QtWebKit 2.1 branch

Reviewed by Andreas Kling.

Re-order the enums by adding new enum entries to the end.

* Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Review the setUserPermission & friends API
hausmann@webkit.org [Tue, 23 Nov 2010 14:24:06 +0000 (14:24 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Renamed requestPermissionFromUser to featurePermissionRequested
and cancelRequestsForPermission to featurePermissionRequestCanceled.

WebKit/qt:

* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
(WebPage::featurePermissionRequestCanceled):
* QtTestBrowser/webpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Review the setUserPermission & friends API
hausmann@webkit.org [Tue, 23 Nov 2010 14:23:46 +0000 (14:23 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Rename setUserPermission to setFeaturePermission

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::setFeaturePermission):
* Api/qwebpage.h:
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::requestPermission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Review the setUserPermission & friends API
hausmann@webkit.org [Tue, 23 Nov 2010 14:23:24 +0000 (14:23 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
and GeolocationPermissionDomain to Geolocation.

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::setUserPermission):
* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::cancelPermission):
(WebCore::WebPage::permissionSet):
(WebCore::DumpRenderTree::geolocationPermissionSet):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
(WebPage::requestPermission):
(WebPage::cancelRequestsForPermission):
* QtTestBrowser/webpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Review the setUserPermission & friends API
hausmann@webkit.org [Tue, 23 Nov 2010 14:22:59 +0000 (14:22 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Add a ByUser suffix to PermissionGranted/Denied. In the future
we can add PermissionGrantedByDefault.

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::setUserPermission):
* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::setPermission):
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::requestPermission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Nov 2010 13:25:25 +0000 (13:25 +0000)]
2010-11-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed rollout r72534 and r72533 because  r72544, r72530 and r72527 were reverted.

        * platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
        * platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
        * platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
        * platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
        * platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
        * platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
        * platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
        * platform/chromium-linux/fast/doctypes/002-expected.checksum:
        * platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
        * platform/chromium-linux/fast/lists/001-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/001-vertical-expected.txt.
        * platform/chromium-linux/fast/lists/002-expected.checksum:
        * platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
        * platform/chromium-linux/fast/lists/002-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/002-vertical-expected.txt.
        * platform/chromium-linux/fast/lists/003-expected.checksum:
        * platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
        * platform/chromium-linux/fast/lists/003-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/003-vertical-expected.txt.
        * platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
        * platform/chromium-linux/fast/lists/007-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/007-vertical-expected.txt.
        * platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
        * platform/chromium-linux/fast/lists/008-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/008-vertical-expected.txt.
        * platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
        * platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Removed.
        * platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
        * platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
        * platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
        * platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Added.
        * platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Added.
        * platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
        * platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Removed.
        * platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
        * platform/chromium-win/css1/box_properties/margin_right-expected.txt:
        * platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
        * platform/chromium-win/css1/box_properties/padding_right-expected.txt:
        * platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
        * platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
        * platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
        * platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
        * platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
        * platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
        * platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
        * platform/chromium-win/fast/doctypes/002-expected.checksum:
        * platform/chromium-win/fast/doctypes/002-expected.txt:
        * platform/chromium-win/fast/lists/001-vertical-expected.checksum:
        * platform/chromium-win/fast/lists/001-vertical-expected.txt:
        * platform/chromium-win/fast/lists/002-expected.checksum:
        * platform/chromium-win/fast/lists/002-expected.txt:
        * platform/chromium-win/fast/lists/002-vertical-expected.checksum:
        * platform/chromium-win/fast/lists/002-vertical-expected.txt:
        * platform/chromium-win/fast/lists/003-expected.checksum:
        * platform/chromium-win/fast/lists/003-expected.txt:
        * platform/chromium-win/fast/lists/003-vertical-expected.checksum:
        * platform/chromium-win/fast/lists/003-vertical-expected.txt:
        * platform/chromium-win/fast/lists/007-vertical-expected.checksum:
        * platform/chromium-win/fast/lists/007-vertical-expected.txt:
        * platform/chromium-win/fast/lists/008-vertical-expected.checksum:
        * platform/chromium-win/fast/lists/008-vertical-expected.txt:
        * platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
        * platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
        * platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Removed.
        * platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 23 Nov 2010 13:19:22 +0000 (13:19 +0000)]
2010-11-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [STYLES] Use strike through as an 'overridden' marker.
        https://bugs.webkit.org/show_bug.cgi?id=49961

        "line-through" is used for inactive properties overridden within the same style.

        * inspector/front-end/inspector.css:
        (.styles-section .properties .overloaded, .styles-section .properties .inactive, .styles-section .properties .disabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 23 Nov 2010 13:04:20 +0000 (13:04 +0000)]
2010-11-23  Satish Sampath  <satish@chromium.org>

        Unreviewed, chromium build fix.

        * public/WebSpeechInputControllerMock.h:
        (WebKit::WebSpeechInputControllerMock::setMockRecognitionResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Tue, 23 Nov 2010 12:57:17 +0000 (12:57 +0000)]
2010-11-23  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Code cleanup
        https://bugs.webkit.org/show_bug.cgi?id=49442

        Remove code that is not used anymore after http://trac.webkit.org/changeset/72522.
        Added const to canBeScrolledIntoView.
        No new tests because this is only code cleanup.

        * page/FocusController.cpp:
        * page/FocusController.h:
        * page/SpatialNavigation.cpp:
        (WebCore::canBeScrolledIntoView):
        * page/SpatialNavigation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Nov 2010 12:48:54 +0000 (12:48 +0000)]
2010-11-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed.

        fast/text/font-size-zero.html was disabled.
        It is failing on Mac platform.

        https://bugs.webkit.org/show_bug.cgi?id=49967

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 23 Nov 2010 11:54:40 +0000 (11:54 +0000)]
2010-11-23  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed. Rebaselined
        svg-curve-with-relative-cordinates-expected.txt test.

        Skipped fast/profiler/throw-exception-from-eval.html, checked in
        bug https://bugs.webkit.org/show_bug.cgi?id=49801

        Skipped fast/canvas/canvas-fillPath-shadow.html and
        fast/canvas/canvas-strokePath-shadow.html until we check if there
        is an issue in the gtk shadows or DRT.

        * platform/gtk/Skipped:
        * platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 23 Nov 2010 11:14:12 +0000 (11:14 +0000)]
2010-11-23  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Remove unimplemented (and untested) methods from IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=49911

        * storage/IDBCursor.idl:
        * storage/IDBDatabase.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 23 Nov 2010 10:07:20 +0000 (10:07 +0000)]
2010-11-23  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Sam Weinig.

        Use WTF::StringHasher directly in JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=49893

        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::Hash::hash):
        * runtime/Identifier.cpp:
        (JSC::IdentifierCStringTranslator::hash):
        (JSC::IdentifierUCharBufferTranslator::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-18 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 23 Nov 2010 10:01:52 +0000 (10:01 +0000)]
2010-11-18  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        For speech input event, send an event object containing all the recognition results and metadata.
        https://bugs.webkit.org/show_bug.cgi?id=49736

        * fast/speech/input-onspeechchange-event-expected.txt: Added.
        * fast/speech/input-onspeechchange-event.html: New test to check multiple results.
        * fast/speech/input-text-language-tag.html: Updated with new method signature.
        * fast/speech/input-text-speechbutton.html: Ditto.
        * fast/speech/speech-button-ignore-generated-events.html: Ditto.
2010-11-18  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        For speech input event, send an event object containing all the recognition results and metadata.
        https://bugs.webkit.org/show_bug.cgi?id=49736

        Currently the speech input event 'onwebkitspeechchange' receives no parameters. WebCore already
        has the full list of recognition results and populates only the top result into the input field
        automatically. In this patch we pass a SpeechInputEvent object to the event handler, and the JS
        code can access the full list of results via "event.results.length", "results[i].utterance" and
        "results[i].confidence". Also updated mock object with appropriate methods to test multiple results.

        Test: fast/speech/input-onspeechchange-event.html

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS): Added new event
        * bindings/v8/custom/V8EventCustom.cpp:
        (WebCore::toV8): Added new event
        * dom/Event.cpp:
        (WebCore::Event::isSpeechInputEvent):
        * dom/Event.h:
        * html/HTMLInputElement.cpp:
        * html/HTMLInputElement.h:
        * page/SpeechInputEvent.h: New file implementing SpeechInputEvent.idl
        (WebCore::SpeechInputEvent::~SpeechInputEvent):
        (WebCore::SpeechInputEvent::create):
        (WebCore::SpeechInputEvent::isSpeechInputEvent):
        (WebCore::SpeechInputEvent::results):
        (WebCore::SpeechInputEvent::SpeechInputEvent):
        * page/SpeechInputEvent.idl: New file defining SpeechInputEvent object
        * page/SpeechInputListener.h:
        * page/SpeechInputResult.cpp:
        (WebCore::SpeechInputResult::create):
        * page/SpeechInputResult.h:
        * page/SpeechInputResult.idl: New file defining a single SpeechInputResult object
        * page/SpeechInputResultList.h: New file implementing SpeechInputResultList.idl
        (WebCore::SpeechInputResultList::create):
        (WebCore::SpeechInputResultList::length):
        (WebCore::SpeechInputResultList::item):
        (WebCore::SpeechInputResultList::SpeechInputResultList):
        * page/SpeechInputResultList.idl: New file defining a list of SpeechInputResult objects
        * platform/mock/SpeechInputClientMock.cpp:
        (WebCore::SpeechInputClientMock::addRecognitionResult): Renamed method and added one parameter.
        (WebCore::SpeechInputClientMock::clearResults):
        (WebCore::SpeechInputClientMock::timerFired):
        * platform/mock/SpeechInputClientMock.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Pass new event object to handler.
2010-11-18  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        For speech input event, send an event object containing all the recognition results and metadata.
        https://bugs.webkit.org/show_bug.cgi?id=49736

        Updated mock object's method to new signature.

        * public/WebSpeechInputControllerMock.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::addMockRecognitionResult):
        * src/WebSpeechInputControllerMockImpl.h:
2010-11-18  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        For speech input event, send an event object containing all the recognition results and metadata.
        https://bugs.webkit.org/show_bug.cgi?id=49736

        Updated DRT by renaming the mock result method on all platforms to the new signature.

        * DumpRenderTree/LayoutTestController.cpp:
        (addMockSpeechInputResultCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::addMockSpeechInputResult):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::addMockSpeechInputResult):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::addMockSpeechInputResult):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::addMockSpeechInputResult):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::addMockSpeechInputResult):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::addMockSpeechInputResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 23 Nov 2010 08:55:45 +0000 (08:55 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=49860
        CSS style rules don't GC protect objects reachable as their properties

        Test: fast/dom/StyleSheet/gc-rule-children-wrappers.html

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        Added new files, sorted appropriate sections for easier adding.

        * bindings/js/JSCSSFontFaceRuleCustom.cpp: Added.
        (WebCore::JSCSSFontFaceRule::markChildren):
        * bindings/js/JSCSSImportRuleCustom.cpp: Added.
        (WebCore::JSCSSImportRule::markChildren):
        * bindings/js/JSCSSMediaRuleCustom.cpp: Added.
        (WebCore::JSCSSMediaRule::markChildren):
        * bindings/js/JSCSSPageRuleCustom.cpp: Added.
        (WebCore::JSCSSPageRule::markChildren):
        * bindings/js/JSCSSStyleRuleCustom.cpp: Added.
        (WebCore::JSCSSStyleRule::markChildren):
        * bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp: Added.
        (WebCore::JSWebKitCSSKeyframeRule::markChildren):
        * bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp: Added.
        (WebCore::JSWebKitCSSKeyframesRule::markChildren):
        Mark objects reachable through these ones.

        * css/CSSFontFaceRule.idl:
        * css/CSSImportRule.idl:
        * css/CSSMediaRule.idl:
        * css/CSSPageRule.idl:
        * css/CSSStyleRule.idl:
        * css/WebKitCSSKeyframeRule.idl:
        * css/WebKitCSSKeyframesRule.idl:
        Added CustomMarkFunction IDL attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed revert r72544 and r72530, because r72527 was reverted.
ossy@webkit.org [Tue, 23 Nov 2010 08:43:56 +0000 (08:43 +0000)]
Unreviewed revert r72544 and r72530, because r72527 was reverted.

Outside list bullets ignore text-align style.
https://bugs.webkit.org/show_bug.cgi?id=15713

* platform/gtk/css1/box_properties/margin_right-expected.txt:
* platform/gtk/css1/box_properties/padding_right-expected.txt:
* platform/gtk/fast/lists/001-vertical-expected.txt:
* platform/gtk/fast/lists/002-vertical-expected.txt:
* platform/gtk/fast/lists/003-vertical-expected.txt:
* platform/gtk/fast/lists/007-vertical-expected.txt:
* platform/gtk/fast/lists/008-vertical-expected.txt:
* platform/gtk/fast/lists/outSideListMarkers-expected.txt: Removed.
* platform/qt/css1/box_properties/margin_right-expected.checksum: Removed.
* platform/qt/css1/box_properties/margin_right-expected.png: Removed.
* platform/qt/css1/box_properties/margin_right-expected.txt:
* platform/qt/css1/box_properties/padding_right-expected.checksum: Removed.
* platform/qt/css1/box_properties/padding_right-expected.png: Removed.
* platform/qt/css1/box_properties/padding_right-expected.txt:
* platform/qt/editing/pasteboard/merge-end-list-expected.checksum: Removed.
* platform/qt/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/qt/editing/pasteboard/merge-end-list-expected.txt:
* platform/qt/fast/doctypes/002-expected.checksum: Removed.
* platform/qt/fast/doctypes/002-expected.png: Removed.
* platform/qt/fast/doctypes/002-expected.txt:
* platform/qt/fast/lists/001-vertical-expected.checksum:
* platform/qt/fast/lists/001-vertical-expected.png:
* platform/qt/fast/lists/001-vertical-expected.txt:
* platform/qt/fast/lists/002-vertical-expected.checksum:
* platform/qt/fast/lists/002-vertical-expected.png:
* platform/qt/fast/lists/002-vertical-expected.txt:
* platform/qt/fast/lists/003-vertical-expected.checksum:
* platform/qt/fast/lists/003-vertical-expected.png:
* platform/qt/fast/lists/003-vertical-expected.txt:
* platform/qt/fast/lists/007-vertical-expected.checksum:
* platform/qt/fast/lists/007-vertical-expected.png:
* platform/qt/fast/lists/007-vertical-expected.txt:
* platform/qt/fast/lists/008-vertical-expected.checksum:
* platform/qt/fast/lists/008-vertical-expected.png:
* platform/qt/fast/lists/008-vertical-expected.txt:
* platform/qt/fast/lists/outSideListMarkers-expected.checksum: Removed.
* platform/qt/fast/lists/outSideListMarkers-expected.png: Removed.
* platform/qt/fast/lists/outSideListMarkers-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-23 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 23 Nov 2010 08:00:30 +0000 (08:00 +0000)]
2010-11-23  Helder Correia  <helder@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] Drawing an image on canvas with shadowBlur draws a solid shadow
        https://bugs.webkit.org/show_bug.cgi?id=49878

        New test checking solid and blurry shadow on images drawn on canvas.

        * fast/canvas/canvas-drawImage-shadow-expected.txt: Added.
        * fast/canvas/canvas-drawImage-shadow.html: Added.
        * fast/canvas/script-tests/canvas-drawImage-shadow.js: Added.
2010-11-23  Helder Correia  <helder@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] Drawing an image on canvas with shadowBlur draws a solid shadow
        https://bugs.webkit.org/show_bug.cgi?id=49878

        Add support for blurry shadows when drawing images on canvas.

        Test: fast/canvas/canvas-drawImage-shadow.html

        * platform/graphics/qt/ContextShadowQt.cpp:
        (WebCore::ContextShadow::endShadowLayer): Make composition work for solid shadow too.
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::draw): Remove old shadow code and introduce ContextShadow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Alexey Marinichev <amarinichev@chromium.org>
commit-queue@webkit.org [Tue, 23 Nov 2010 07:44:05 +0000 (07:44 +0000)]
2010-11-22  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB
        https://bugs.webkit.org/show_bug.cgi?id=49946

        * public/WebGraphicsContext3D.h: added isContextLost()
        * src/Extensions3DChromium.cpp:
        (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::isContextLost):
        * src/GraphicsContext3DInternal.h:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::isContextLost):
        * src/WebGraphicsContext3DDefaultImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::reallocateRenderer): ensure root layer repaining

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Tue, 23 Nov 2010 06:46:45 +0000 (06:46 +0000)]
2010-11-22  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Don't create an external popup menu when there are no items to show.
        https://bugs.webkit.org/show_bug.cgi?id=49937

        * src/ExternalPopupMenu.cpp:
        (WebKit::ExternalPopupMenu::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 23 Nov 2010 06:26:26 +0000 (06:26 +0000)]
2010-11-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Port ContextMenuWin.cpp to WinCE
        https://bugs.webkit.org/show_bug.cgi?id=48408

        * platform/ContextMenu.h:
        * platform/win/ContextMenuWin.cpp:
        (WebCore::ContextMenu::ContextMenu):
        (WebCore::ContextMenu::itemCount):
        (WebCore::insertMenuItem):
        (WebCore::ContextMenu::insertItem):
        (WebCore::contextMenuItemByIdOrPosition):
        (WebCore::ContextMenu::setPlatformDescription):
        (WebCore::contextMenuItemVector):
        (WebCore::platformMenuDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Tue, 23 Nov 2010 06:05:09 +0000 (06:05 +0000)]
2010-11-22  Nat Duca  <nduca@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Send didActivateAcceleratedCompositing when compositor
        initializes but does not create the shared context3d.
        https://bugs.webkit.org/show_bug.cgi?id=49930

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBack out rebaselines from r72527.
hyatt@apple.com [Tue, 23 Nov 2010 05:44:48 +0000 (05:44 +0000)]
Back out rebaselines from r72527.

* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBack out r72527 since it caused multiple rendering regressions. Details in bug.
hyatt@apple.com [Tue, 23 Nov 2010 05:41:24 +0000 (05:41 +0000)]
Back out r72527 since it caused multiple rendering regressions.  Details in bug.

WebCore:

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):

LayoutTests:

* fast/lists/outSideListMarkers-expected.txt: Removed.
* fast/lists/outSideListMarkers.html: Removed.
* platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/margin_right-expected.png:
* platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/padding_right-expected.png:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/doctypes/002-expected.checksum:
* platform/mac-leopard/fast/doctypes/002-expected.png:
* platform/mac-leopard/fast/lists/001-expected.checksum:
* platform/mac-leopard/fast/lists/001-expected.png:
* platform/mac-leopard/fast/lists/002-expected.checksum:
* platform/mac-leopard/fast/lists/002-expected.png:
* platform/mac-leopard/fast/lists/003-expected.checksum:
* platform/mac-leopard/fast/lists/003-expected.png:
* platform/mac/css1/box_properties/margin_right-expected.txt:
* platform/mac/css1/box_properties/padding_right-expected.txt:
* platform/mac/editing/pasteboard/merge-end-list-expected.txt:
* platform/mac/editing/selection/extend-by-word-002-expected.checksum:
* platform/mac/editing/selection/extend-by-word-002-expected.png:
* platform/mac/editing/selection/extend-by-word-002-expected.txt:
* platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/mac/fast/css/empty-pseudo-class-expected.txt:
* platform/mac/fast/css/first-child-pseudo-class-expected.txt:
* platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/last-child-pseudo-class-expected.txt:
* platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/only-child-pseudo-class-expected.txt:
* platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/mac/fast/doctypes/002-expected.txt:
* platform/mac/fast/lists/001-expected.txt:
* platform/mac/fast/lists/001-vertical-expected.checksum:
* platform/mac/fast/lists/001-vertical-expected.png:
* platform/mac/fast/lists/001-vertical-expected.txt:
* platform/mac/fast/lists/002-expected.txt:
* platform/mac/fast/lists/002-vertical-expected.checksum:
* platform/mac/fast/lists/002-vertical-expected.png:
* platform/mac/fast/lists/002-vertical-expected.txt:
* platform/mac/fast/lists/003-expected.txt:
* platform/mac/fast/lists/003-vertical-expected.checksum:
* platform/mac/fast/lists/003-vertical-expected.png:
* platform/mac/fast/lists/003-vertical-expected.txt:
* platform/mac/fast/lists/007-vertical-expected.checksum:
* platform/mac/fast/lists/007-vertical-expected.png:
* platform/mac/fast/lists/007-vertical-expected.txt:
* platform/mac/fast/lists/008-vertical-expected.checksum:
* platform/mac/fast/lists/008-vertical-expected.png:
* platform/mac/fast/lists/008-vertical-expected.txt:
* platform/mac/fast/lists/outSideListMarkers-expected.checksum: Removed.
* platform/mac/fast/lists/outSideListMarkers-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Tue, 23 Nov 2010 04:43:16 +0000 (04:43 +0000)]
2010-11-22  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Implement mocks for client-based Geolocation.
        https://bugs.webkit.org/show_bug.cgi?id=49258

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/mock/GeolocationClientMock.cpp: Added.
        (WebCore::GeolocationClientMock::GeolocationClientMock):
        (WebCore::GeolocationClientMock::~GeolocationClientMock):
        (WebCore::GeolocationClientMock::setController):
        (WebCore::GeolocationClientMock::setPosition):
        (WebCore::GeolocationClientMock::setError):
        (WebCore::GeolocationClientMock::geolocationDestroyed):
        (WebCore::GeolocationClientMock::startUpdating):
        (WebCore::GeolocationClientMock::stopUpdating):
        (WebCore::GeolocationClientMock::setEnableHighAccuracy):
        (WebCore::GeolocationClientMock::lastPosition):
        (WebCore::GeolocationClientMock::timerFired):
        (WebCore::GeolocationClientMock::makeGeolocationCallback):
        * platform/mock/GeolocationClientMock.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Leandro Pereira <leandro@profusion.mobi>
commit-queue@webkit.org [Tue, 23 Nov 2010 04:10:29 +0000 (04:10 +0000)]
2010-11-22  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Andreas Kling.

        Add Leandro Pereira's blog to Planet WebKit
        https://bugs.webkit.org/show_bug.cgi?id=49910

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Alex Grilo <abgrilo@profusion.mobi>
commit-queue@webkit.org [Tue, 23 Nov 2010 02:35:10 +0000 (02:35 +0000)]
2010-11-22  Alex Grilo  <abgrilo@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Tiled Backing Store for Webkit-Efl
        https://bugs.webkit.org/show_bug.cgi?id=45397

        This tile based backing store is a grid of tiles where each tile is
        an Evas_Object showing a piece of the page content. The
        new ewk_view_tiled.c is an implementation of some of the functions of
        the original ewk_view, that makes calls to the Tiled Backing Store
        specific functions.

        The rendering occurs in the pixels stored in each tile (Evas_Object),
        in the same way as the previous single backing store. Tiles not being
        shown in the viewport are stored in a cache, and can be reused later
        to avoid having to be rendered again.

        Scrolling occurs as just moving the tiles, using Evas move operations,
        and when more than one tile size is scrolled, a shift of rows or
        columns needs to be done.

        * CMakeListsEfl.txt:
        * ewk/ewk_tiled_backing_store.c: Added.
        (_ewk_tiled_backing_store_updates_process):
        (_ewk_tiled_backing_store_flush):
        (_ewk_tiled_backing_store_tile_new):
        (_ewk_tiled_backing_store_item_move):
        (_ewk_tiled_backing_store_item_resize):
        (_ewk_tiled_backing_store_tile_associate):
        (_ewk_tiled_backing_store_tile_dissociate):
        (_ewk_tiled_backing_store_tile_dissociate_all):
        (_ewk_tiled_backing_store_pre_render_request_add):
        (_ewk_tiled_backing_store_pre_render_request_del):
        (_ewk_tiled_backing_store_pre_render_request_first):
        (_ewk_tiled_backing_store_pre_render_request_flush):
        (_ewk_tiled_backing_store_pre_render_request_remove_unassociated):
        (_ewk_tiled_backing_store_pre_render_request_remove_associated):
        (_ewk_tiled_backing_store_pre_render_request_process_single):
        (_ewk_tiled_backing_store_item_process_idler_cb):
        (_ewk_tiled_backing_store_item_process_idler_stop):
        (_ewk_tiled_backing_store_item_process_idler_start):
        (_ewk_tiled_backing_store_item_request_del):
        (_ewk_tiled_backing_store_item_request_add):
        (_ewk_tiled_backing_store_disable_render):
        (_ewk_tiled_backing_store_enable_render):
        (_ewk_tiled_backing_store_visible_tiles_rect):
        (_ewk_tiled_backing_store_tile_is_inside_viewport):
        (_ewk_tiled_backing_store_tile_is_adjacent_to_viewport):
        (_ewk_tiled_backing_store_item_fill):
        (_ewk_tiled_backing_store_item_add):
        (_ewk_tiled_backing_store_item_del):
        (_ewk_tiled_backing_store_item_smooth_scale_set):
        (_ewk_tiled_backing_store_changed):
        (_ewk_tiled_backing_store_view_cols_end_del):
        (_ewk_tiled_backing_store_view_cols_end_add):
        (_ewk_tiled_backing_store_view_row_del):
        (_ewk_tiled_backing_store_view_rows_range_del):
        (_ewk_tiled_backing_store_view_rows_all_del):
        (_ewk_tiled_backing_store_render):
        (_ewk_tiled_backing_store_model_matrix_create):
        (_ewk_tiled_backing_store_smart_member_del):
        (_ewk_tiled_backing_store_smart_member_add):
        (_ewk_tiled_backing_store_mem_dbg):
        (_ewk_tiled_backing_store_sig_usr):
        (_ewk_tiled_backing_store_smart_add):
        (_ewk_tiled_backing_store_smart_del):
        (_ewk_tiled_backing_store_smart_move):
        (_ewk_tiled_backing_store_smart_resize):
        (_ewk_tiled_backing_store_recalc_renderers):
        (_ewk_tiled_backing_store_smart_calculate_size):
        (_ewk_tiled_backing_store_view_dbg):
        (_ewk_tiled_backing_store_view_wrap_up):
        (_ewk_tiled_backing_store_view_wrap_down):
        (_ewk_tiled_backing_store_view_wrap_left):
        (_ewk_tiled_backing_store_view_wrap_right):
        (_ewk_tiled_backing_store_view_refill):
        (_ewk_tiled_backing_store_view_pos_apply):
        (_ewk_tiled_backing_store_smart_calculate_offset_force):
        (_ewk_tiled_backing_store_smart_calculate_offset):
        (_ewk_tiled_backing_store_smart_calculate_pos):
        (_ewk_tiled_backing_store_fill_renderers):
        (_ewk_tiled_backing_store_smart_calculate):
        (ewk_tiled_backing_store_add):
        (ewk_tiled_backing_store_render_cb_set):
        (ewk_tiled_backing_store_tile_unused_cache_get):
        (ewk_tiled_backing_store_tile_unused_cache_set):
        (_ewk_tiled_backing_store_scroll_full_offset_set_internal):
        (ewk_tiled_backing_store_scroll_full_offset_set):
        (ewk_tiled_backing_store_scroll_full_offset_add):
        (_ewk_tiled_backing_store_zoom_set_internal):
        (ewk_tiled_backing_store_zoom_set):
        (ewk_tiled_backing_store_zoom_weak_set):
        (ewk_tiled_backing_store_fix_offsets):
        (ewk_tiled_backing_store_zoom_weak_smooth_scale_set):
        (ewk_tiled_backing_store_update):
        (ewk_tiled_backing_store_updates_process_pre_set):
        (ewk_tiled_backing_store_updates_process_post_set):
        (ewk_tiled_backing_store_updates_process):
        (ewk_tiled_backing_store_updates_clear):
        (ewk_tiled_backing_store_contents_resize):
        (ewk_tiled_backing_store_disabled_update_set):
        (ewk_tiled_backing_store_flush):
        (ewk_tiled_backing_store_pre_render_region):
        (ewk_tiled_backing_store_pre_render_relative_radius):
        (ewk_tiled_backing_store_pre_render_cancel):
        (ewk_tiled_backing_store_disable_render):
        (ewk_tiled_backing_store_enable_render):
        (ewk_tiled_backing_store_process_entire_queue_set):
        * ewk/ewk_tiled_backing_store.h: Added.
        * ewk/ewk_tiled_matrix.c: Added.
        (_ewk_tile_matrix_cell_free):
        (_ewk_tile_matrix_tile_free):
        (ewk_tile_matrix_new):
        (ewk_tile_matrix_free):
        (ewk_tile_matrix_resize):
        (ewk_tile_matrix_unused_cache_get):
        (ewk_tile_matrix_tile_exact_get):
        (ewk_tile_matrix_tile_exact_exists):
        (ewk_tile_matrix_tile_nearest_get):
        (ewk_tile_matrix_tile_new):
        (ewk_tile_matrix_tile_put):
        (ewk_tile_matrix_tile_update):
        (ewk_tile_matrix_tile_update_full):
        (ewk_tile_matrix_tile_updates_clear):
        (_ewk_tile_matrix_slicer_setup):
        (ewk_tile_matrix_update):
        (ewk_tile_matrix_updates_process):
        (ewk_tile_matrix_updates_clear):
        (ewk_tile_matrix_dbg):
        (ewk_tile_matrix_freeze):
        (ewk_tile_matrix_thaw):
        * ewk/ewk_tiled_matrix.h: Added.
        * ewk/ewk_tiled_model.c: Added.
        (_ewk_tile_account_get):
        (_ewk_tile_account_allocated):
        (_ewk_tile_account_freed):
        (ewk_tile_accounting_dbg):
        (_ewk_tile_paint_rgb888):
        (_ewk_tile_paint_rgb565):
        (_ewk_tile_paint):
        (ewk_tile_new):
        (ewk_tile_free):
        (ewk_tile_show):
        (ewk_tile_hide):
        (ewk_tile_visible_get):
        (ewk_tile_update_full):
        (ewk_tile_update_area):
        (ewk_tile_updates_process):
        (ewk_tile_updates_clear):
        (ewk_tile_unused_cache_new):
        (ewk_tile_unused_cache_lock_area):
        (ewk_tile_unused_cache_unlock_area):
        (ewk_tile_unused_cache_free):
        (ewk_tile_unused_cache_clear):
        (ewk_tile_unused_cache_ref):
        (ewk_tile_unused_cache_unref):
        (ewk_tile_unused_cache_max_set):
        (ewk_tile_unused_cache_max_get):
        (ewk_tile_unused_cache_used_get):
        (ewk_tile_unused_cache_flush):
        (ewk_tile_unused_cache_auto_flush):
        (ewk_tile_unused_cache_dirty):
        (ewk_tile_unused_cache_freeze):
        (ewk_tile_unused_cache_thaw):
        (ewk_tile_unused_cache_tile_get):
        (ewk_tile_unused_cache_tile_put):
        (ewk_tile_unused_cache_dbg):
        * ewk/ewk_tiled_model.h: Added.
        * ewk/ewk_tiled_private.h: Added.
        * ewk/ewk_view.cpp:
        (_ewk_view_smart_add):
        (_ewk_view_smart_calculate):
        (_ewk_view_smart_show):
        (_ewk_view_smart_hide):
        (_ewk_view_smart_pre_render_relative_radius):
        (_ewk_view_zoom_animator_cb):
        (_ewk_view_smart_disable_render):
        (_ewk_view_smart_enable_render):
        (ewk_view_base_smart_set):
        (ewk_view_pre_render_region):
        (ewk_view_pre_render_relative_radius):
        (ewk_view_enable_render):
        (ewk_view_disable_render):
        (ewk_view_scroll):
        (ewk_view_did_first_visually_nonempty_layout):
        (ewk_view_dispatch_did_finish_loading):
        (ewk_view_transition_to_commited_for_newpage):
        * ewk/ewk_view.h:
        * ewk/ewk_view_tiled.c: Added.
        (_ewk_view_tiled_render_cb):
        (_ewk_view_tiled_updates_process_pre):
        (_ewk_view_tiled_smart_backing_store_add):
        (_ewk_view_tiled_contents_size_changed_cb):
        (_ewk_view_tiled_smart_add):
        (_ewk_view_tiled_smart_scrolls_process):
        (_ewk_view_tiled_smart_repaints_process):
        (_ewk_view_tiled_smart_contents_resize):
        (_ewk_view_tiled_smart_zoom_set):
        (_ewk_view_tiled_smart_zoom_weak_set):
        (_ewk_view_tiled_smart_zoom_weak_smooth_scale_set):
        (_ewk_view_tiled_smart_flush):
        (_ewk_view_tiled_smart_pre_render_region):
        (_ewk_view_tiled_smart_pre_render_relative_radius):
        (_ewk_view_tiled_smart_pre_render_cancel):
        (_ewk_view_tiled_smart_disable_render):
        (_ewk_view_tiled_smart_enable_render):
        (ewk_view_tiled_smart_set):
        (_ewk_view_tiled_smart_class_new):
        (ewk_view_tiled_add):
        (ewk_view_tiled_unused_cache_get):
        (ewk_view_tiled_unused_cache_set):
        (ewk_view_tiled_process_entire_queue_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 23 Nov 2010 01:50:20 +0000 (01:50 +0000)]
2010-11-22  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Fix bogus include guard.

        * loader/NavigationScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 23 Nov 2010 01:47:04 +0000 (01:47 +0000)]
2010-11-22  Andreas Kling  <kling@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] Canvas: strokeText() and fillText() produce same shadow
        https://bugs.webkit.org/show_bug.cgi?id=48845

        Test: fast/canvas/canvas-strokeText-strokes-shadow.html

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::drawTextCommon): Stroke the shadow rather than filling it in the cTextStroke case.
2010-11-22  Andreas Kling  <kling@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] Canvas: strokeText() and fillText() produce same shadow
        https://bugs.webkit.org/show_bug.cgi?id=48845

        Add test to verify that strokeText() doesn't produce a fillText() shadow.

        * fast/canvas/canvas-strokeText-strokes-shadow.html: Added.
        * fast/canvas/canvas-strokeText-strokes-shadow-expected.txt: Added.
        * fast/canvas/script-tests/canvas-strokeText-strokes-shadow.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 23 Nov 2010 00:56:52 +0000 (00:56 +0000)]
2010-11-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        Fix some spacing issues with log messages with
        new-run-webkit-tests --verbose.

        https://bugs.webkit.org/show_bug.cgi?id=49936

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 23 Nov 2010 00:56:08 +0000 (00:56 +0000)]
2010-11-22  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        update scm to work with different remote branches
        https://bugs.webkit.org/show_bug.cgi?id=49949

        This works if there are multiple svn tracking branches
        and/or if the tracking branch is refs/remots/origin/master
        instead of refs/remotes/trunk which is the direction we're trying
        to head since that makes fetches faster.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 23 Nov 2010 00:55:59 +0000 (00:55 +0000)]
2010-11-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Sam Weinig.

        Add WTF::FixedArray::size()
        https://bugs.webkit.org/show_bug.cgi?id=49891

        Add a method to get the size of a FixedArray.

        * wtf/FixedArray.h:
        (WTF::FixedArray::size):
2010-11-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Sam Weinig.

        Use WTF::FixedArray::size()
        https://bugs.webkit.org/show_bug.cgi?id=49891

        * dom/Document.cpp:
        (WebCore::Document::~Document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 23 Nov 2010 00:25:10 +0000 (00:25 +0000)]
2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        SelectionController::typingStyle() should return EditingStyle*
        https://bugs.webkit.org/show_bug.cgi?id=49813

        Changed the return value of SelectionController::typingStyle() to EditingStyle*.
        Also added SelectionController::copyTypingStyle() to copy the typing style
        as an instance of CSSMutableStyleDeclaration.

        No tests are added since this is no behavioral change.

        * WebView/WebFrame.mm:
        (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        SelectionController::typingStyle() should return EditingStyle*
        https://bugs.webkit.org/show_bug.cgi?id=49813

        Changed the return type of SelectionController::typingStyle to EditingStyle*.

        Extracted textDirection from Editor::textDirectionForSelection to hide the underlying
        CSSMutableStyleDeclaration.

        Also extracted the code to preserve unicode-bidi and direction CSS properties in
        InsertTextCommand::input, and moved into EditingStyle::prepareToApplyAt. ShouldPreserveWritingDirection,
        which is added to the argument list of EditingStyle::prepareToApplyAt, decides whether or not
        these two properties are preserved.

        Also added SelectionController::copyTypingStyle() to copy the typing style as an instance of
        CSSMutableStyleDeclaration.

        No new tests are added since this is a refactoring.

        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::textDirection): Extracted from Editor::textDirectionForSelection.
        (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added a missing null check.
        (WebCore::EditingStyle::prepareToApplyAt): See above.
        (WebCore::editingStyleIncludingTypingStyle): Calls SelectionController::typingStyle.
        * editing/EditingStyle.h: Moved WritingDirection from Editor.h
        * editing/Editor.cpp:
        (WebCore::Editor::textDirectionForSelection): Calls EditingStyle::textDirection.
        (WebCore::Editor::computeAndSetTypingStyle): Calls SelectionController::typingStyle.
        (WebCore::Editor::selectionComputedStyle): Ditto.
        (WebCore::Editor::styleForSelectionStart): Ditto.
        * editing/Editor.h:
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply): Ditto.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input): Calls EditingStyle::prepareToApplyAt with PreserveWritingDirection.
        * editing/SelectionController.h:
        (WebCore::SelectionController::typingStyle): Returns EditingStyle* rather than CSSMutableStyleDeclaration*.
        (WebCore::SelectionController::copyTypingStyle): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 23 Nov 2010 00:18:47 +0000 (00:18 +0000)]
2010-11-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Set correct preprocessor definitions
        https://bugs.webkit.org/show_bug.cgi?id=49887

        * wtf/Platform.h:
2010-11-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Set correct preprocessor definitions
        https://bugs.webkit.org/show_bug.cgi?id=49887

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows 7 results for two tests
aroben@apple.com [Mon, 22 Nov 2010 23:57:47 +0000 (23:57 +0000)]
Update Windows 7 results for two tests

Windows 7 uses different fonts from Windows XP on these tests (and even
has a font that can render the inverted nun in bidi-mirror-he-ar.html).

* platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum:
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/win/fast/text/international/bold-bengali-expected.checksum: Added.
* platform/win/fast/text/international/bold-bengali-expected.png: Added.
* platform/win/fast/text/international/bold-bengali-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows 7 results for fast/text/international/complex-character-based-fallback...
aroben@apple.com [Mon, 22 Nov 2010 23:38:58 +0000 (23:38 +0000)]
Update Windows 7 results for fast/text/international/complex-character-based-fallback.html

* platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
* platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
* platform/win/fast/text/international/complex-character-based-fallback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows XP results for fast/text/international/complex-character-based-fallbac...
aroben@apple.com [Mon, 22 Nov 2010 23:27:06 +0000 (23:27 +0000)]
Update Windows XP results for fast/text/international/complex-character-based-fallback.html after r72173

The existing pixel results were XP-specific so I moved them into
LayoutTests/platform/win-xp.

* platform/win-xp/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
* platform/win-xp/fast/text/international/complex-character-based-fallback-expected.png: Added.
* platform/win-xp/fast/text/international/complex-character-based-fallback-expected.txt:
* platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
* platform/win/fast/text/international/complex-character-based-fallback-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows results after r72552
aroben@apple.com [Mon, 22 Nov 2010 23:21:09 +0000 (23:21 +0000)]
Update Windows results after r72552

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 22 Nov 2010 23:04:10 +0000 (23:04 +0000)]
2010-11-22  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] font-size:0 text runs should have zero width
        https://bugs.webkit.org/show_bug.cgi?id=49871

        Expands test to check width in addition to height.

        * fast/text/font-size-zero-expected.txt:
        * fast/text/font-size-zero.html:
        * fast/text/script-tests/font-size-zero.js:
2010-11-22  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] font-size:0 text runs should have zero width
        https://bugs.webkit.org/show_bug.cgi?id=49871

        Returns 0 from platformWidthForGlyph if the specified font size is 0.

        Test: fast/text/font-size-zero.html

        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Charlie Reis <creis@chromium.org>
commit-queue@webkit.org [Mon, 22 Nov 2010 23:01:28 +0000 (23:01 +0000)]
2010-11-22  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        Update correct content state during back/forward navigations
        https://bugs.webkit.org/show_bug.cgi?id=48809

        Test that we update content state when leaving a form in a subframe.

        * fast/history/saves-state-after-frame-nav.html:
        * fast/history/saves-state-after-frame-nav-expected.txt:
        * fast/history/resources/subframe-with-form.html:
2010-11-22  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        Update correct content state during back/forward navigations
        https://bugs.webkit.org/show_bug.cgi?id=48809

        Ensures that history's previousItem is non-null when clients try to
        update content state (e.g., Chromium's UpdateSessionHistory).  We now
        track load completions with a boolean field rather than by clearing
        previousItem.

        Test: fast/history/saves-state-after-frame-nav.html

        * loader/HistoryController.cpp:
        * loader/HistoryController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Add flaky crash expectation for fast/files/revoke-blob-url.html on mac...
jparent@chromium.org [Mon, 22 Nov 2010 22:59:10 +0000 (22:59 +0000)]
Unreviewed.  Add flaky crash expectation for fast/files/revoke-blob-url.html on mac debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Mon, 22 Nov 2010 22:52:30 +0000 (22:52 +0000)]
2010-11-22  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Ignore reference files which will be used by reftests when collecting
        test cases.
        https://bugs.webkit.org/show_bug.cgi?id=49835

        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows results for transforms/2d/hindi-rotated.html after r72173
aroben@apple.com [Mon, 22 Nov 2010 22:45:22 +0000 (22:45 +0000)]
Update Windows results for transforms/2d/hindi-rotated.html after r72173

The existing pixel results were XP-specific so I moved them to
LayoutTests/platform/win-xp.

* platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Added.
* platform/win-xp/transforms/2d/hindi-rotated-expected.png: Added.
* platform/win-xp/transforms/2d/hindi-rotated-expected.txt:
* platform/win/transforms/2d/hindi-rotated-expected.checksum:
* platform/win/transforms/2d/hindi-rotated-expected.png:
* platform/win/transforms/2d/hindi-rotated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 22 Nov 2010 22:40:48 +0000 (22:40 +0000)]
2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed rebaseline for Chromium.

        Removed the erroneous expected result for editing/deleting/5168598.html on chromium linux.

        * platform/chromium-linux/editing/deleting/5168598-expected.txt: Removed.
        * platform/chromium/test_expectations.txt: Removed editing/deleting/5168598.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update GTK and Mac specific expected results after r72552.
ossy@webkit.org [Mon, 22 Nov 2010 22:24:37 +0000 (22:24 +0000)]
Unreviewed. Update GTK and Mac specific expected results after r72552.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 22 Nov 2010 22:15:08 +0000 (22:15 +0000)]
2010-11-22  Tony Chang  <tony@chromium.org>

        Unreviewed, roll Chromium DEPS to r67004.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebKit2 skipped list.
weinig@apple.com [Mon, 22 Nov 2010 22:05:13 +0000 (22:05 +0000)]
Update WebKit2 skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Luiz Agostini <luiz.agostini@openbossa.org>
luiz@webkit.org [Mon, 22 Nov 2010 22:01:01 +0000 (22:01 +0000)]
2010-11-22  Luiz Agostini  <luiz.agostini@openbossa.org>

        Unreviewed, Windows build fix.

        Adding JSMediaQueryList to DerivedSources.cpp.

        * DerivedSources.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update Qt specific expected results after r72552.
ossy@webkit.org [Mon, 22 Nov 2010 21:53:51 +0000 (21:53 +0000)]
Unreviewed. Update Qt specific expected results after r72552.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
aroben@apple.com [Mon, 22 Nov 2010 21:21:16 +0000 (21:21 +0000)]
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files

Apple's Windows build allows placing header files and import libraries for WebKit's
dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
$WebKitLibrariesDir environment variable. This is both required for production builds and
convenient for Apple-internal developer builds. Apple's production builds also require that
WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
builds, the files are copied into that directory tree by the
WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
copying is done by
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.

This .vsprops copying is problematic in one very important case: when a developer updates
their source tree and then tries to build. Visual Studio only reads .vsprops files when a
project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
$WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
will proceed with out-of-date .vsprops files, which will likely result in a build failure.

To fix this, we now use normal relative paths to access the .vsprops files in the source
tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
unset, so the normal relative paths are used to read the .vsprops files out of the source
tree directly. In production builds, this environment variable is set to a fake directory
that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
is resolved.

For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:

$(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
"$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
FeatureDefines.vsprops becomes:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

which resolves to:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

(We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
actually exist since they are matched by an equal number of ".." path components.)

Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
Studio is open, but that problem hasn't seemed to cause developers many headaches so far.

Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
updated

Reviewed by Dave Hyatt.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore.make: Set $WebKitVSPropsRedirectionDir so that
production builds can find the .vsprops files.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stopy copying the
.vsprops files. It isn't needed anymore.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebCore:

* WebCore.vcproj/WebCore.make: Set $WebKitVSPropsRedirectionDir so that
production builds can find the .vsprops files.

* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/WebCore.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKit/win:

* WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can
find the .vsprops files.

* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKit2:

* win/WebKit2.make: Set $WebKitVSPropsRedirectionDir so that production builds can
find the .vsprops files.

* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKitLibraries:

* win/tools/WinTools.make: Copy the shared .vsprops files into a directory tree beneath
AppleInternal\tools\vsprops that matches the source directory tree. This allows production
builds to redirect the relative paths used to find the shared .vsprops files into
AppleInternal by setting $WebKitVSPropsRedirectionDir to the appropriate value.

WebKitTools:

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
* FindSafari/FindSafari.vcproj:
* MiniBrowser/MiniBrowser.vcproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
* WebKitAPITest/WebKitAPITest.vcproj:
* WebKitLauncherWin/WebKitLauncherWin.vcproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
* WinLauncher/WinLauncher.vcproj:
* record-memory-win/record-memory-win.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake it possible to run tests on Windows without Visual Studio or VC++ Express installed
aroben@apple.com [Mon, 22 Nov 2010 21:17:23 +0000 (21:17 +0000)]
Make it possible to run tests on Windows without Visual Studio or VC++ Express installed

webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
are not installed. But this function doesn't need to be called when we
already have a build available and are just trying to run the tests.

Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
because Visual Studio/VC++ Express aren't installed

Reviewed by Dave Hyatt.

* Scripts/webkitdirs.pm:
(determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
it is not needed by this function. Also added a FIXME.

(usingVisualStudioExpress): Call setupCygwinEnv directly rather than
relying on determineConfigurationForVisualStudio doing it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 22 Nov 2010 21:16:44 +0000 (21:16 +0000)]
2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed update of Windows's skipped list and Chromium's test expectation.

        fast/text/international/thai-cursor-position.html erroneously had an expected result
        on Windows even though textInputController hasn't been implemented on Windows (the bug 32021).

        Removed the expected result and added the tests to Windows platform's skipped list.

        * platform/chromium/test_expectations.txt: Removed fast/text/international/thai-cursor-position.html.
        * platform/win/Skipped: Added fast/text/international/thai-cursor-position.html.
        * platform/win/fast/text/international/thai-cursor-position-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-21 Luiz Agostini <luiz.agostini@openbossa.org>
luiz@webkit.org [Mon, 22 Nov 2010 21:02:27 +0000 (21:02 +0000)]
2010-10-21  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Darin Adler.

        Implement CSSOM View matchMedia interface
        https://bugs.webkit.org/show_bug.cgi?id=37205

        New property matchMedia was added to window.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:

        window.matchMedia and MediaQueryList tests.

        * fast/media/media-query-list-01-expected.txt: Added.
        * fast/media/media-query-list-01.html: Added.

        The following tests depend on LayoutTestController::setViewModeMediaFeature() to work.
        As it is only implemented by Qt and Gtk the tests needed to be skipped in all other platforms.

        * fast/media/media-query-list-02-expected.txt: Added.
        * fast/media/media-query-list-02.html: Added.
        * fast/media/media-query-list-03-expected.txt: Added.
        * fast/media/media-query-list-03.html: Added.
        * fast/media/media-query-list-04-expected.txt: Added.
        * fast/media/media-query-list-04.html: Added.
        * fast/media/media-query-list-05-expected.txt: Added.
        * fast/media/media-query-list-05.html: Added.
        * fast/media/media-query-list-06-expected.txt: Added.
        * fast/media/media-query-list-06.html: Added.
        * fast/media/media-query-list-07-expected.txt: Added.
        * fast/media/media-query-list-07.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/Skipped:
        * platform/win/Skipped:
2010-10-21  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Darin Adler.

        Implement CSSOM View matchMedia interface
        https://bugs.webkit.org/show_bug.cgi?id=37205

        New interfaces may be used to evaluate media queries and to associate listeners
        to media queries. Those listeners are called whenever the associated query changes.
        Specification may be found at http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface

        operator== added to JS version of ScriptValue.
        Method isFunction added to JS and V8 versions of ScriptValue.

        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::isFunction):
        * bindings/js/ScriptValue.h:
        (WebCore::ScriptValue::operator==):
        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::isFunction):

        Some changes were needed to the code generators to handle type MediaQueryListListener.

        * bindings/scripts/CodeGeneratorGObject.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:

        Some changes to the bindings test results that were previously added.

        * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
        (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
        * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
        (WebCore::TestMediaQueryListListenerInternal::methodCallback):
        (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

        New interfaces:

        * css/MediaQueryList.cpp: Added.
        * css/MediaQueryList.h: Added.
        * css/MediaQueryList.idl: Added.

        * css/MediaQueryListListener.cpp: Added.
        * css/MediaQueryListListener.h: Added.
        * css/MediaQueryListListener.idl: Added.

        To avoid adding code to classes DOMWindow and Document a new class MediaQueryMatcher was created.

        * css/MediaQueryMatcher.cpp: Added.
        * css/MediaQueryMatcher.h: Added.

        Document and DOMWindow have changed to support new features. DOMWindow is the class that
        publishes methods matchMedia but for page cache to work properly the reference to the
        MediaQueryMatcher must be in Document.

        * dom/Document.cpp:
        (WebCore::Document::~Document):
        (WebCore::Document::mediaQueryMatcher):
        (WebCore::Document::styleSelectorChanged):
        * dom/Document.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::matchMedia):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

        Build systems

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/gobject/GNUmakefile.am:

        Tests: fast/media/media-query-list-01.html
               fast/media/media-query-list-02.html
               fast/media/media-query-list-03.html
               fast/media/media-query-list-04.html
               fast/media/media-query-list-05.html
               fast/media/media-query-list-06.html
               fast/media/media-query-list-07.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-19 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Mon, 22 Nov 2010 21:00:41 +0000 (21:00 +0000)]
2010-11-19  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Simplify Driver.run_test() so that it takes only one parameter, TestInput.

        https://bugs.webkit.org/show_bug.cgi?id=49812

        * Scripts/webkitpy/layout_tests/driver_test.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 22 Nov 2010 20:13:21 +0000 (20:13 +0000)]
2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed update of Windows Skipped list.

        editing/selection/5825350-1.html and 5825350-2.html erroneously
        had expectations with console error message even though textInputController
        hasn't been implemented on Windows (the bug 32021),

        Removed these expectations and added the tests to the skipped list.

        * platform/win/Skipped:
        * platform/win/editing/selection/5825350-1-expected.txt: Removed.
        * platform/win/editing/selection/5825350-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows-specific results for fast/ruby/nested-ruby.html
aroben@apple.com [Mon, 22 Nov 2010 20:08:06 +0000 (20:08 +0000)]
Add Windows-specific results for fast/ruby/nested-ruby.html

* platform/win/fast/ruby/nested-ruby-expected.checksum: Added.
* platform/win/fast/ruby/nested-ruby-expected.png: Added.
* platform/win/fast/ruby/nested-ruby-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows XP results for fast/text/international/bidi-control-chars-treated...
aroben@apple.com [Mon, 22 Nov 2010 20:07:17 +0000 (20:07 +0000)]
Update Windows XP results for fast/text/international/bidi-control-chars-treated-as-ZWS.html

The render tree dump on XP now matches Mac. I updated the pixel results
to match the current rendering (the two test lines have moved down
slightly).

* platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
* platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
* platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Mon, 22 Nov 2010 19:58:29 +0000 (19:58 +0000)]
2010-11-22  Hayato Ito  <hayato@chromium.org>

        Reviewed by Tony Chang.

        [NRWT] Retry a few times in reading a png image to avoid a race condition.

        https://bugs.webkit.org/show_bug.cgi?id=49924

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove obsolete Windows-specific results for svg/dom/path-parser.html
aroben@apple.com [Mon, 22 Nov 2010 19:09:00 +0000 (19:09 +0000)]
Remove obsolete Windows-specific results for svg/dom/path-parser.html

r72381 made these unnecessary.

* platform/win/svg/dom/path-parser-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows results for fast/dom/prototype-inheritance-2.html
aroben@apple.com [Mon, 22 Nov 2010 19:08:22 +0000 (19:08 +0000)]
Update Windows results for fast/dom/prototype-inheritance-2.html

This is the Windows equivalent of r72353.

* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 22 Nov 2010 18:55:37 +0000 (18:55 +0000)]
2010-11-22  Andreas Kling  <kling@webkit.org>

        Unreviewed, rebaseline GTK+ after r72527.

        * platform/gtk/css1/box_properties/margin_right-expected.txt:
        * platform/gtk/css1/box_properties/padding_right-expected.txt:
        * platform/gtk/fast/lists/001-vertical-expected.txt:
        * platform/gtk/fast/lists/002-vertical-expected.txt:
        * platform/gtk/fast/lists/003-vertical-expected.txt:
        * platform/gtk/fast/lists/007-vertical-expected.txt:
        * platform/gtk/fast/lists/008-vertical-expected.txt:
        * platform/gtk/fast/lists/outSideListMarkers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows-specific results for editing/selection/extend-selection-home-end.html
aroben@apple.com [Mon, 22 Nov 2010 18:50:40 +0000 (18:50 +0000)]
Add Windows-specific results for editing/selection/extend-selection-home-end.html

These results are identical to the cross-platform results, but are
needed to override the Mac-specific results in platform/mac.

Fixes <http://webkit.org/b/49874>.

* platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Test expectations arrangements and rebaselinings.
antonm@chromium.org [Mon, 22 Nov 2010 18:44:11 +0000 (18:44 +0000)]
Not reviewed.  Test expectations arrangements and rebaselinings.

* platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Fallback font rebaselines.
antonm@chromium.org [Mon, 22 Nov 2010 18:30:33 +0000 (18:30 +0000)]
Not reviewed.  Fallback font rebaselines.

* platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
* platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.png: Added.
* platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
* platform/chromium-linux/fast/text/international/hebrew-vowels-expected.checksum: Added.
* platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counters-04-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum:
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
* platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
* platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
* platform/chromium-mac/fast/forms/select-visual-hebrew-expected.checksum: Added.
* platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Added.
* platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
* platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Added.
* platform/chromium-mac/fast/text/international/001-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/001-expected.png: Added.
* platform/chromium-mac/fast/text/international/hebrew-vowels-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
* platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.png: Added.
* platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
* platform/chromium-win/fast/text/international/hebrew-vowels-expected.checksum: Added.
* platform/chromium-win/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/chromium-win/fast/text/international/hebrew-vowels-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 22 Nov 2010 18:26:59 +0000 (18:26 +0000)]
2010-11-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] Contents of rules inside @media not displayed/editable
        https://bugs.webkit.org/show_bug.cgi?id=49804

        WebCore:
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::insertedIntoParent):
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::setStyleSheetText2):
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::asCSSRuleList):
        (WebCore::InspectorStyleSheet::reparseStyleSheet):
        (WebCore::InspectorStyleSheet::setText):
        (WebCore::InspectorStyleSheet::addRule):
        (WebCore::InspectorStyleSheet::ruleForId):
        (WebCore::InspectorStyleSheet::ruleIndexByStyle):
        (WebCore::InspectorStyleSheet::ensureText):
        (WebCore::InspectorStyleSheet::ensureSourceData):
        (WebCore::InspectorStyleSheet::ensureFlatRules):
        (WebCore::InspectorStyleSheet::revalidateStyle):
        (WebCore::InspectorStyleSheet::buildArrayForRuleList):
        (WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges):
        (WebCore::InspectorStyleSheet::collectFlatRules):
        * inspector/InspectorStyleSheet.h:

        LayoutTests:
        * inspector/resources/styles-new-API-1.css: Added.
        (@page):
        (@page :first):
        (#absent-id):
        (body):
        * inspector/resources/styles-new-API.css:
        * inspector/styles-new-API-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Amending expectations for Chromium.
antonm@chromium.org [Mon, 22 Nov 2010 17:53:46 +0000 (17:53 +0000)]
Not reviewed.  Amending expectations for Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Another portion of Chromium rebaselines for SVG.
antonm@chromium.org [Mon, 22 Nov 2010 17:50:12 +0000 (17:50 +0000)]
Not reviewed.  Another portion of Chromium rebaselines for SVG.

* platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
* platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Another portion of Chromium rebaselines.
antonm@chromium.org [Mon, 22 Nov 2010 17:39:37 +0000 (17:39 +0000)]
Not reviewed.  Another portion of Chromium rebaselines.

* platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
* platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
* platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
* platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
* platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
* platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
* platform/chromium-win/svg/carto.net/selectionlist-expected.png:
* platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
* platform/chromium-win/svg/custom/image-small-width-height-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 22 Nov 2010 17:36:53 +0000 (17:36 +0000)]
2010-11-22  Tony Chang  <tony@chromium.org>

        Unreviewed, update Chromium Win plugin test expectations.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Chromium rebaselines after http://trac.webkit.org/changeset/72518
antonm@chromium.org [Mon, 22 Nov 2010 17:33:43 +0000 (17:33 +0000)]
Not reviewed.  Chromium rebaselines after trac.webkit.org/changeset/72518

* platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.checksum:
* platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPointList-basics-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGStringList-basics-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-win/svg/dom/SVGLengthList-basics-expected.checksum:
* platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-win/svg/dom/SVGNumberList-basics-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPointList-basics-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/chromium-win/svg/dom/SVGStringList-basics-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/chromium-win/svg/dom/SVGTransformList-basics-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Reorganizing suppressions.
antonm@chromium.org [Mon, 22 Nov 2010 17:23:59 +0000 (17:23 +0000)]
Not reviewed.  Reorganizing suppressions.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Tons of Chromium rebaselines after http://trac.webkit.org/changeset...
antonm@chromium.org [Mon, 22 Nov 2010 17:16:18 +0000 (17:16 +0000)]
Unreviewed.  Tons of Chromium rebaselines after trac.webkit.org/changeset/72527

* platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-linux/css1/box_properties/margin_right-expected.png:
* platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-linux/css1/box_properties/padding_right-expected.png:
* platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
* platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
* platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
* platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
* platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
* platform/chromium-linux/fast/doctypes/002-expected.checksum:
* platform/chromium-linux/fast/doctypes/002-expected.png:
* platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/001-vertical-expected.png:
* platform/chromium-linux/fast/lists/001-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/002-expected.checksum:
* platform/chromium-linux/fast/lists/002-expected.png:
* platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/002-vertical-expected.png:
* platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/003-expected.checksum:
* platform/chromium-linux/fast/lists/003-expected.png:
* platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/003-vertical-expected.png:
* platform/chromium-linux/fast/lists/003-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/007-vertical-expected.png:
* platform/chromium-linux/fast/lists/007-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/008-vertical-expected.png:
* platform/chromium-linux/fast/lists/008-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
* platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
* platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Added.
* platform/chromium-linux/fast/lists/outSideListMarkers-expected.png: Added.
* platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-mac/css1/box_properties/margin_right-expected.png:
* platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-mac/css1/box_properties/padding_right-expected.png:
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
* platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/extend-by-word-002-expected.png: Removed.
* platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Removed.
* platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
* platform/chromium-mac/fast/lists/008-vertical-expected.png:
* platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Added.
* platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.png: Added.
* platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-win/css1/box_properties/margin_right-expected.png:
* platform/chromium-win/css1/box_properties/margin_right-expected.txt:
* platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-win/css1/box_properties/padding_right-expected.png:
* platform/chromium-win/css1/box_properties/padding_right-expected.txt:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
* platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
* platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
* platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
* platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
* platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/chromium-win/fast/doctypes/002-expected.checksum:
* platform/chromium-win/fast/doctypes/002-expected.png:
* platform/chromium-win/fast/doctypes/002-expected.txt:
* platform/chromium-win/fast/lists/001-vertical-expected.checksum:
* platform/chromium-win/fast/lists/001-vertical-expected.png:
* platform/chromium-win/fast/lists/001-vertical-expected.txt:
* platform/chromium-win/fast/lists/002-expected.checksum:
* platform/chromium-win/fast/lists/002-expected.png:
* platform/chromium-win/fast/lists/002-expected.txt:
* platform/chromium-win/fast/lists/002-vertical-expected.checksum:
* platform/chromium-win/fast/lists/002-vertical-expected.png:
* platform/chromium-win/fast/lists/002-vertical-expected.txt:
* platform/chromium-win/fast/lists/003-expected.checksum:
* platform/chromium-win/fast/lists/003-expected.png:
* platform/chromium-win/fast/lists/003-expected.txt:
* platform/chromium-win/fast/lists/003-vertical-expected.checksum:
* platform/chromium-win/fast/lists/003-vertical-expected.png:
* platform/chromium-win/fast/lists/003-vertical-expected.txt:
* platform/chromium-win/fast/lists/007-vertical-expected.checksum:
* platform/chromium-win/fast/lists/007-vertical-expected.png:
* platform/chromium-win/fast/lists/007-vertical-expected.txt:
* platform/chromium-win/fast/lists/008-vertical-expected.checksum:
* platform/chromium-win/fast/lists/008-vertical-expected.png:
* platform/chromium-win/fast/lists/008-vertical-expected.txt:
* platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
* platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:
* platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
* platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Added.
* platform/chromium-win/fast/lists/outSideListMarkers-expected.png: Added.
* platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WebKit2 compile with ENABLE_JAVASCRIPT_DEBUGGER=0
ossy@webkit.org [Mon, 22 Nov 2010 16:57:45 +0000 (16:57 +0000)]
Make WebKit2 compile with ENABLE_JAVASCRIPT_DEBUGGER=0

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.

* WebProcess/WebPage/WebInspector.cpp: Add missing ENABLE(JAVASCRIPT_DEBUGGER) guards.
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 22 Nov 2010 16:46:45 +0000 (16:46 +0000)]
2010-11-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: dump inspector protocol messages into console.
        Sometimes I need to dump inspector messages into console.
        It'd be much simple to have this code in repository and
        enable protocol dumping just by a flag.

        https://bugs.webkit.org/show_bug.cgi?id=49905

        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end/WorkersSidebarPane.js:
        (WebInspector.WorkersSidebarPane.prototype.reset):
        * inspector/front-end/inspector.js:
        (WebInspector_syncDispatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update Qt specific expected results after r72527.
ossy@webkit.org [Mon, 22 Nov 2010 16:43:08 +0000 (16:43 +0000)]
Unreviewed. Update Qt specific expected results after r72527.

* platform/qt/css1/box_properties/margin_right-expected.checksum: Added.
* platform/qt/css1/box_properties/margin_right-expected.png: Added.
* platform/qt/css1/box_properties/margin_right-expected.txt:
* platform/qt/css1/box_properties/padding_right-expected.checksum: Added.
* platform/qt/css1/box_properties/padding_right-expected.png: Added.
* platform/qt/css1/box_properties/padding_right-expected.txt:
* platform/qt/editing/pasteboard/merge-end-list-expected.checksum: Added.
* platform/qt/editing/pasteboard/merge-end-list-expected.png: Added.
* platform/qt/editing/pasteboard/merge-end-list-expected.txt:
* platform/qt/fast/doctypes/002-expected.checksum: Added.
* platform/qt/fast/doctypes/002-expected.png: Added.
* platform/qt/fast/doctypes/002-expected.txt:
* platform/qt/fast/lists/001-vertical-expected.checksum:
* platform/qt/fast/lists/001-vertical-expected.png:
* platform/qt/fast/lists/001-vertical-expected.txt:
* platform/qt/fast/lists/002-vertical-expected.checksum:
* platform/qt/fast/lists/002-vertical-expected.png:
* platform/qt/fast/lists/002-vertical-expected.txt:
* platform/qt/fast/lists/003-vertical-expected.checksum:
* platform/qt/fast/lists/003-vertical-expected.png:
* platform/qt/fast/lists/003-vertical-expected.txt:
* platform/qt/fast/lists/007-vertical-expected.checksum:
* platform/qt/fast/lists/007-vertical-expected.png:
* platform/qt/fast/lists/007-vertical-expected.txt:
* platform/qt/fast/lists/008-vertical-expected.checksum:
* platform/qt/fast/lists/008-vertical-expected.png:
* platform/qt/fast/lists/008-vertical-expected.txt:
* platform/qt/fast/lists/outSideListMarkers-expected.checksum: Added.
* platform/qt/fast/lists/outSideListMarkers-expected.png: Added.
* platform/qt/fast/lists/outSideListMarkers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 22 Nov 2010 16:18:52 +0000 (16:18 +0000)]
2010-11-22  Andreas Kling  <kling@webkit.org>

        Unreviewed, 2 missing rebaselines after r72527.

        * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
        * platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 22 Nov 2010 15:52:38 +0000 (15:52 +0000)]
2010-11-22  Andreas Kling  <kling@webkit.org>

        Reviewed by Nikolas Zimmermann.

        GraphicsContext: Make drawFocusRing() take a Path instead of a Vector<Path>
        https://bugs.webkit.org/show_bug.cgi?id=49840

        This avoid copying a Path object when drawing focus rings.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * rendering/RenderImage.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        (WebCore::RenderImage::paintFocusRing):
        Renamed from paintFocusRings since it only paints one ring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOutside list bullets ignore text-align style.
reni@webkit.org [Mon, 22 Nov 2010 15:13:52 +0000 (15:13 +0000)]
Outside list bullets ignore text-align style.
https://bugs.webkit.org/show-bug.cgi?id=15713

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.

WebCore:

Fix the position of outside markers by setting its logicalLeft member. Embedded markers need special treatment.
First, the total width of markers should be calculated. Subtracting it from logicalLeft we get the outermost bullet's
position. As for the others, this sum should be decremented with the previous marker's width.
In case of vertical markers the padding is unneeded.

Test: fast/lists/outSideListMarkers.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):

LayoutTests:

Add new test for checking outside marker's position and update the related expecteds of tests.

* fast/lists/outSideListMarkers-expected.txt: Added.
* fast/lists/outSideListMarkers.html: Added.
* platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/margin_right-expected.png:
* platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/padding_right-expected.png:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/doctypes/002-expected.checksum:
* platform/mac-leopard/fast/doctypes/002-expected.png:
* platform/mac-leopard/fast/lists/001-expected.checksum:
* platform/mac-leopard/fast/lists/001-expected.png:
* platform/mac-leopard/fast/lists/002-expected.checksum:
* platform/mac-leopard/fast/lists/002-expected.png:
* platform/mac-leopard/fast/lists/003-expected.checksum:
* platform/mac-leopard/fast/lists/003-expected.png:
* platform/mac/css1/box_properties/margin_right-expected.txt:
* platform/mac/css1/box_properties/padding_right-expected.txt:
* platform/mac/editing/pasteboard/merge-end-list-expected.txt:
* platform/mac/editing/selection/extend-by-word-002-expected.checksum:
* platform/mac/editing/selection/extend-by-word-002-expected.png:
* platform/mac/editing/selection/extend-by-word-002-expected.txt:
* platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/mac/fast/css/empty-pseudo-class-expected.txt:
* platform/mac/fast/css/first-child-pseudo-class-expected.txt:
* platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/last-child-pseudo-class-expected.txt:
* platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/only-child-pseudo-class-expected.txt:
* platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/mac/fast/doctypes/002-expected.txt:
* platform/mac/fast/lists/001-expected.txt:
* platform/mac/fast/lists/001-vertical-expected.checksum:
* platform/mac/fast/lists/001-vertical-expected.png:
* platform/mac/fast/lists/001-vertical-expected.txt:
* platform/mac/fast/lists/002-expected.txt:
* platform/mac/fast/lists/002-vertical-expected.checksum:
* platform/mac/fast/lists/002-vertical-expected.png:
* platform/mac/fast/lists/002-vertical-expected.txt:
* platform/mac/fast/lists/003-expected.txt:
* platform/mac/fast/lists/003-vertical-expected.checksum:
* platform/mac/fast/lists/003-vertical-expected.png:
* platform/mac/fast/lists/003-vertical-expected.txt:
* platform/mac/fast/lists/007-vertical-expected.checksum:
* platform/mac/fast/lists/007-vertical-expected.png:
* platform/mac/fast/lists/007-vertical-expected.txt:
* platform/mac/fast/lists/008-vertical-expected.checksum:
* platform/mac/fast/lists/008-vertical-expected.png:
* platform/mac/fast/lists/008-vertical-expected.txt:
* platform/mac/fast/lists/outSideListMarkers-expected.checksum: Added.
* platform/mac/fast/lists/outSideListMarkers-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Mon, 22 Nov 2010 14:57:15 +0000 (14:57 +0000)]
2010-11-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Additional tests.
        https://bugs.webkit.org/show_bug.cgi?id=49604

        * fast/events/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt: Added.
        * fast/events/spatial-navigation/snav-div-overflow-scrol-hidden.html: Added.
        * fast/events/spatial-navigation/snav-z-index-expected.txt: Added.
        * fast/events/spatial-navigation/snav-z-index.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Rebaselining various Win/Linux only deviations.
antonm@chromium.org [Mon, 22 Nov 2010 14:40:45 +0000 (14:40 +0000)]
Not reviewed.  Rebaselining various Win/Linux only deviations.

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/chromium-linux/svg/custom/baseval-animval-equality-expected.checksum:
* platform/chromium-linux/svg/custom/baseval-animval-equality-expected.png:
* platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
* platform/chromium-linux/svg/dom/path-parser-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.checksum:
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.png:
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
* platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
* platform/chromium-win/svg/dom/path-parser-expected.txt: Added.
* platform/chromium-win/svg/filters/filter-rounding-issues-expected.checksum: Added.
* platform/chromium-win/svg/filters/filter-rounding-issues-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 22 Nov 2010 14:37:28 +0000 (14:37 +0000)]
Unreviewed.

[Qt] fast/workers/storage/interrupt-database-sync.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=49906

* platform/qt/Skipped: fast/workers/storage/interrupt-database-sync.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 22 Nov 2010 14:12:52 +0000 (14:12 +0000)]
Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/css/negative-leading-expected.checksum: Added.
* platform/qt/fast/css/negative-leading-expected.png: Added.
* platform/qt/fast/css/negative-leading-expected.txt: Added. (introduced in r72141)
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.txt: Added. (introduced in r72402)
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added. (introduced in r72381)
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added. (introduced in r72518)
* platform/qt/svg/custom/image-rescale-expected.checksum: Added.
* platform/qt/svg/custom/image-rescale-expected.png: Added.
* platform/qt/svg/custom/image-rescale-expected.txt: Added. (introduced in r72470)
* platform/qt/svg/custom/image-rescale-scroll-expected.checksum: Added.
* platform/qt/svg/custom/image-rescale-scroll-expected.png: Added.
* platform/qt/svg/custom/image-rescale-scroll-expected.txt: Added. (introduced in r72470)
* platform/qt/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
* platform/qt/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/qt/svg/dom/SVGPathSegList-cloning-expected.txt: Added. (introduced in r72381)
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added. (introduced in r72381)
* platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
* platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
* platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added. (introduced in r72381)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpatial Navigation: issues with the node selection algorithm.
yael.aharon@nokia.com [Mon, 22 Nov 2010 13:49:09 +0000 (13:49 +0000)]
Spatial Navigation: issues with the node selection algorithm.
https://bugs.webkit.org/show_bug.cgi?id=49382

Patch by Yael Aharon  <yael.aharon@nokia.com>, Chang Shu <chang.shu@nokia.com> on 2010-11-22
Reviewed by Antonio Gomes.

WebCore:

Modify the Spatial Navigation algorithm, to better handle initial focus and
navigation between frames.
The new algorithm takes the rect of the focused node as the startingRect,
instead of the node itself. That allows us to construct a virtual rect if
there is no focused node, or if it is off the screen.
The virtual rect is the edge of the container in the direction of the navigation.

With this patch, scrollable containers and frames will scroll regardless of weather
they have focusable content. Users will be able to use arrow keys to view all the
content of such a container. The only exception is if the container has style overflow:hidden.
We will not scroll in that case.

With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
we do a hit test and only the node on top can get focus.

hasOffScreenRect() was modified so that it can check if a node will be off-screen even after we scrolled
its parent container. We do not add the scrolling conditions for containers that have overflow:hidden
and cannot scroll.

calculateScrollbarModesForLayout is used to decide if a frame can scroll or not. We cannot rely on
the exsistance of the scrollbar, because it could be removed via the API, while the frame is still
allowed to scroll.

* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
* page/FocusController.h:
* page/FrameView.h:
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::distanceDataForNode):
(WebCore::alignmentForRects):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isScrollableContainerNode):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):
* page/SpatialNavigation.h:

LayoutTests:

Replaced text in tests with images with fixed size to make them more cross platform and modified
test results to reflect that we can scroll container that do not include focusable content.

* fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
* fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
* fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt:
* fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
* fast/events/spatial-navigation/snav-iframe-no-focusable-content-expected.txt:
* fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
* fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
* fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
* fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt:
* fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAmending suppressions from previous commit.
antonm@chromium.org [Mon, 22 Nov 2010 13:29:14 +0000 (13:29 +0000)]
Amending suppressions from previous commit.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Adding new suppressions after http://trac.webkit.org/changeset/72518
antonm@chromium.org [Mon, 22 Nov 2010 13:25:59 +0000 (13:25 +0000)]
Not reviewed.  Adding new suppressions after trac.webkit.org/changeset/72518

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Next batch of SVG rebaselines.
antonm@chromium.org [Mon, 22 Nov 2010 12:53:55 +0000 (12:53 +0000)]
Not reviewed.  Next batch of SVG rebaselines.

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
* platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
* platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-22 Nikolas Zimmermann <nzimmermann@rim.com>
commit-queue@webkit.org [Mon, 22 Nov 2010 12:32:31 +0000 (12:32 +0000)]
2010-11-22  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Fix various problems with the SVG*List code
        https://bugs.webkit.org/show_bug.cgi?id=49880

        Add tests for all SVG*List types, that were missing.
        Add SVG 1.1 2nd edition testcase, types-dom-07-f.svg, testing that all animVal values are readonly.

        * platform/mac-leopard/svg/custom/baseval-animval-equality-expected.checksum:
        * platform/mac-leopard/svg/custom/baseval-animval-equality-expected.png:
        * platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.checksum:
        * platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
        * platform/mac/svg/custom/baseval-animval-equality-expected.txt:
        * platform/mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
        * platform/mac/svg/dom/SVGNumberList-basics-expected.png: Added.
        * platform/mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPointList-basics-expected.png: Added.
        * platform/mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
        * platform/mac/svg/dom/SVGStringList-basics-expected.png: Added.
        * platform/mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
        * platform/mac/svg/dom/SVGTransformList-basics-expected.png: Added.
        * svg/W3C-SVG-1.1-SE/types-dom-07-f.svg: Added.
        * svg/custom/baseval-animval-equality.svg: Fix wrong test.
        * svg/custom/polyline-points-crash-expected.txt:
        * svg/dom/SVGLengthList-basics-expected.txt:
        * svg/dom/SVGLengthList-basics.xhtml: Extended test, synchronized with the other SVG*List tests.
        * svg/dom/SVGNumberList-basics-expected.txt: Added.
        * svg/dom/SVGNumberList-basics.xhtml: Added.
        * svg/dom/SVGPointList-basics-expected.txt: Added.
        * svg/dom/SVGPointList-basics.xhtml: Added.
        * svg/dom/SVGStringList-basics-expected.txt: Added.
        * svg/dom/SVGStringList-basics.xhtml: Added.
        * svg/dom/SVGTransformList-basics-expected.txt: Added.
        * svg/dom/SVGTransformList-basics.xhtml: Added.
        * svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
2010-11-22  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Fix various problems with the SVG*List code
        https://bugs.webkit.org/show_bug.cgi?id=49880

        Write tests for SVGNumberList/SVGPointList/SVGStringList/SVGTransformList and extend SVGLengthList tests.
        SVG DOM <-> XML DOM synchronization is now tested for all these types, and works great. Unify the string format produced
        by the various valueAsString() functions for maximum compatibility with Firefox / Opera.

        * Build a real transform string for SVGTransformList, instead of dumping the elements of the concatted matrix.
        * Add SVGStringList XML dom synchronization, only affects SVGTests requiredFeatures/requiredExtensions/systemLanguage.
        * Make all animVal properties readonly, tested by types-dom-07-f.svg (from SVG 1.1 2nd edition).
        * Enable StrictTypeChecking/RequiresAllArguments=Raise for all SVGList types.

        Tests: svg/W3C-SVG-1.1-SE/types-dom-07-f.svg
               svg/dom/SVGNumberList-basics.xhtml
               svg/dom/SVGPointList-basics.xhtml
               svg/dom/SVGStringList-basics.xhtml
               svg/dom/SVGTransformList-basics.xhtml

        * bindings/js/JSSVGLengthCustom.cpp:
        (WebCore::JSSVGLength::setValue): Throw NO_MODIFICATION_ALLOWED_ERR when the SVGPropertyTearOffs role is AnimValRole.
        (WebCore::JSSVGLength::convertToSpecifiedUnits): Ditto.
        * bindings/scripts/CodeGeneratorJS.pm: Ditto.
        * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
        * bindings/scripts/CodeGeneratorV8.pm: Ditto.
        * bindings/v8/custom/V8SVGLengthCustom.cpp:
        (WebCore::V8SVGLength::valueAccessorSetter): Ditto.
        (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback): Ditto.
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::synchronizeProperty): Ditto.
        * svg/SVGCircleElement.cpp:
        (WebCore::SVGCircleElement::synchronizeProperty): Ditto.
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::synchronizeProperty): Ditto.
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::synchronizeProperty): Ditto.
        * svg/SVGDefsElement.cpp:
        (WebCore::SVGDefsElement::synchronizeProperty): Ditto.
        * svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::synchronizeProperty): Ditto.
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::synchronizeProperty): Ditto.
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::synchronizeProperty): Ditto.
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::synchronizeProperty): Ditto.
        * svg/SVGLengthList.cpp:
        (WebCore::SVGLengthList::valueAsString): Use ' ' instead of ',' as seperator.
        * svg/SVGLengthList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
        * svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::synchronizeProperty): Ditto.
        * svg/SVGNumberList.cpp:
        (WebCore::SVGNumberList::valueAsString): Use ' ' instead of ',' as seperator.
        * svg/SVGNumberList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::synchronizeProperty): Ditto.
        * svg/SVGPointList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
        * svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::synchronizeProperty): Ditto.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::synchronizeProperty): Ditto.
        * svg/SVGStringList.cpp:
        (WebCore::SVGStringList::valueAsString): Add valueAsString() implementation, necessary for SVG DOM <-> XML DOM synchronization.
        * svg/SVGStringList.h:
        * svg/SVGStringList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
        * svg/SVGSwitchElement.cpp:
        (WebCore::SVGSwitchElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
        * svg/SVGTests.cpp: Rewrite, similar to SVGPolyElement, to synchronize the requiredFeatures/requiredExtension/systemLanguage SVGStringLists with their XML DOM attributes.
        (WebCore::SVGTests::SVGTests):
        (WebCore::SVGTests::isValid):
        (WebCore::SVGTests::parseMappedAttribute):
        (WebCore::SVGTests::isKnownAttribute):
        (WebCore::SVGTests::handleAttributeChange):
        (WebCore::SVGTests::synchronizeProperties): To be called by all classes inheriting from SVGTests, in their synchronizeProperty() methods.
        (WebCore::SVGTests::synchronizeRequiredFeatures):
        (WebCore::SVGTests::synchronizeRequiredExtensions):
        (WebCore::SVGTests::synchronizeSystemLanguage):
        (WebCore::SVGTests::requiredFeatures):
        (WebCore::SVGTests::requiredExtensions):
        (WebCore::SVGTests::systemLanguage):
        * svg/SVGTests.h:
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
        * svg/SVGTransform.cpp:
        (WebCore::SVGTransform::valueAsString): Added a proper way to serialize a SVGTransform into a String.
        * svg/SVGTransform.h:
        * svg/SVGTransformList.cpp:
        (WebCore::SVGTransformList::valueAsString): Rewrite, to build a real transform list string, instead of dumping the concatted matrix.
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
        * svg/properties/SVGListProperty.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox.
        (WebCore::SVGListProperty::initializeValuesAndWrappers):
        (WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
        (WebCore::SVGListProperty::replaceItemValues):
        (WebCore::SVGListProperty::replaceItemValuesAndWrappers):
        (WebCore::SVGListProperty::removeItemValuesAndWrappers): Handle corner case, the item passed to removeItem() was the only on in the list, list is empty now, nothing to replace.
        (WebCore::SVGListProperty::appendItemValuesAndWrappers):
        (WebCore::SVGListProperty::role): Expose the role of this list property.
        * svg/properties/SVGPathSegListPropertyTearOff.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox.
        (WebCore::SVGPathSegListPropertyTearOff::initialize):
        (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
        (WebCore::SVGPathSegListPropertyTearOff::replaceItem):
        (WebCore::SVGPathSegListPropertyTearOff::appendItem):
        * svg/properties/SVGProperty.h: Add new virtual SVGPropertyRole role() accessor.
        * svg/properties/SVGPropertyTearOff.h:
        (WebCore::SVGPropertyTearOff::create): Store the passed in SVGProperyRole, instead of ignoring it.
        (WebCore::SVGPropertyTearOff::role):
        (WebCore::SVGPropertyTearOff::SVGPropertyTearOff):
        * svg/properties/SVGStaticPropertyTearOff.h:
        (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Pass UndefinedRole as default role to SVGPropertyTearOff.
        * svg/properties/SVGStaticPropertyWithParentTearOff.h: Ditto.
        (WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Rebaselining fast/images/imagemap-focus-ring-zoom.html for Chromium...
antonm@chromium.org [Mon, 22 Nov 2010 12:11:40 +0000 (12:11 +0000)]
Not reviewed.  Rebaselining fast/images/imagemap-focus-ring-zoom.html for Chromium on Win and Linux.

* platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
* platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Rebaselining svg/custom/image-rescale.svg for Chromium on Mac.
antonm@chromium.org [Mon, 22 Nov 2010 12:02:22 +0000 (12:02 +0000)]
Not reviewed.  Rebaselining svg/custom/image-rescale.svg for Chromium on Mac.

* platform/chromium-mac/svg/custom/image-rescale-expected.checksum: Added.
* platform/chromium-mac/svg/custom/image-rescale-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, removing suppression for now passing editing/selection/5354455-1.html...
antonm@chromium.org [Mon, 22 Nov 2010 11:57:12 +0000 (11:57 +0000)]
Not reviewed, removing suppression for now passing editing/selection/5354455-1.html (on Win)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, proper platform for international test.
antonm@chromium.org [Mon, 22 Nov 2010 10:53:28 +0000 (10:53 +0000)]
Not reviewed, proper platform for international test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72514 268f45cc-cd09-0410-ab3c-d52691b4dbfc