WebKit-https.git
4 years ago[GTK] Use --version-script only on Linux
commit-queue@webkit.org [Mon, 12 Oct 2015 17:01:05 +0000 (17:01 +0000)]
[GTK] Use --version-script only on Linux
https://bugs.webkit.org/show_bug.cgi?id=144555

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.

* Source/cmake/OptionsGTK.cmake: Don't add --version-script
option on Darwin (whose linker doesn't support it.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Update jhbuild's version of harfbuzz
mario@webkit.org [Mon, 12 Oct 2015 15:30:32 +0000 (15:30 +0000)]
[GTK] Update jhbuild's version of harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=149749

Reviewed by Martin Robinson.

Update harfbuzz to 0.9.35, following the lead of Debian Stable.

* gtk/jhbuild.modules: Updated details for harfbuzz.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
mario@webkit.org [Mon, 12 Oct 2015 12:37:05 +0000 (12:37 +0000)]
[GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
https://bugs.webkit.org/show_bug.cgi?id=150026

Reviewed by Philippe Normand.

Backport upstream patch from gst-plugins-bad so that the right version
of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
gets compiled properly, avoiding crashes on runtime while running tests.

* gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
* gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, fixing debug builds with Clang on Linux
zandobersek@gmail.com [Mon, 12 Oct 2015 11:31:26 +0000 (11:31 +0000)]
Unreviewed, fixing debug builds with Clang on Linux
by including the stdio.h header where it's required
under a debug configuration.

* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
* rendering/SimpleLineLayoutFunctions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, followup to r190643.
zandobersek@gmail.com [Mon, 12 Oct 2015 11:24:40 +0000 (11:24 +0000)]
Unreviewed, followup to r190643.

Inline the std::function<> constructor wrappings around lambdas
into a single line, instead of spanning it across four lines.

* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Bump Version/X in user agent
gyuyoung.kim@webkit.org [Mon, 12 Oct 2015 07:52:53 +0000 (07:52 +0000)]
[EFL] Bump Version/X in user agent
https://bugs.webkit.org/show_bug.cgi?id=150013

Reviewed by Csaba Osztrogonác.

EFL port needs to ensure maximum compatibility with existing web sites.
Thus version number needs to be bumped from 5.0 to 8.0 as GTK port.

* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd missing builtins files to the Xcode projects
bburg@apple.com [Mon, 12 Oct 2015 04:41:36 +0000 (04:41 +0000)]
Add missing builtins files to the Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=150015

Reviewed by Yusuke Suzuki.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCleanup and simplification of SVG path-related classes
simon.fraser@apple.com [Mon, 12 Oct 2015 03:34:08 +0000 (03:34 +0000)]
Cleanup and simplification of SVG path-related classes
https://bugs.webkit.org/show_bug.cgi?id=150011

Reviewed by Zalan Bujtas.

Many SVG path-related subclasses were stateful, but only because code in
SVGPathUtilities kept global copies around for no reason. A microbenchmark
showed that there was no benefit to keeping global singletons of SVGPathBuilder,
SVGPathSegListBuilder, SVGPathByteStreamBuilder, SVGPathStringBuilder,
SVGPathTraversalStateBuilder, SVGPathParser and SVGPathBlender.

Making these classes not be re-usable makes the code much simpler, allowing
their SVGPathSources, SVGPathConsumers, SVGPathByteStream etc. to be stored
by reference, and eliminating the cleanup() function which created annoying
ordering issues.

Code that uses SVGPathParser and SVGPathBlender is further simplified by having
these classes expose only static functions, hiding any internal statefulness.

* svg/SVGPathBlender.cpp: Remove the m_progress member variable and instead
pass progress to the various blend functions, as we do for other blend functions.
Expose two only static functions. Pointers to references.
(WebCore::SVGPathBlender::addAnimatedPath):
(WebCore::SVGPathBlender::blendAnimatedPath):
(WebCore::SVGPathBlender::SVGPathBlender):
(WebCore::SVGPathBlender::blendAnimatedDimensonalFloat):
(WebCore::SVGPathBlender::blendAnimatedFloatPoint):
(WebCore::SVGPathBlender::blendMoveToSegment):
(WebCore::SVGPathBlender::blendLineToSegment):
(WebCore::SVGPathBlender::blendLineToHorizontalSegment):
(WebCore::SVGPathBlender::blendLineToVerticalSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
(WebCore::SVGPathBlender::blendArcToSegment):
(WebCore::SVGPathBlender::cleanup): Deleted.
* svg/SVGPathBlender.h: Make the constructor take a ref to the destination Path,
which is stored by reference.
* svg/SVGPathBuilder.cpp:
(WebCore::SVGPathBuilder::SVGPathBuilder):
(WebCore::SVGPathBuilder::moveTo):
(WebCore::SVGPathBuilder::lineTo):
(WebCore::SVGPathBuilder::curveToCubic):
(WebCore::SVGPathBuilder::closePath):
* svg/SVGPathBuilder.h:
(WebCore::SVGPathBuilder::setCurrentPath): Deleted.
* svg/SVGPathByteStreamBuilder.cpp: References, assertions removed.
(WebCore::SVGPathByteStreamBuilder::SVGPathByteStreamBuilder):
* svg/SVGPathByteStreamBuilder.h:
(WebCore::SVGPathByteStreamBuilder::writeType):
(WebCore::SVGPathByteStreamBuilder::setCurrentByteStream): Deleted.
* svg/SVGPathConsumer.h:
* svg/SVGPathElement.cpp:
* svg/SVGPathParser.cpp: Expose some static helper functions for parsing
to byte streams and strings. References.
(WebCore::SVGPathParser::parse):
(WebCore::SVGPathParser::parseToByteStream):
(WebCore::SVGPathParser::parseToString):
(WebCore::SVGPathParser::SVGPathParser):
(WebCore::SVGPathParser::parseClosePathSegment):
(WebCore::SVGPathParser::parseMoveToSegment):
(WebCore::SVGPathParser::parseLineToSegment):
(WebCore::SVGPathParser::parseLineToHorizontalSegment):
(WebCore::SVGPathParser::parseLineToVerticalSegment):
(WebCore::SVGPathParser::parseCurveToCubicSegment):
(WebCore::SVGPathParser::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathParser::parseArcToSegment):
(WebCore::SVGPathParser::parsePathData):
(WebCore::SVGPathParser::decomposeArcToCubic):
(WebCore::SVGPathParser::parsePathDataFromSource): Deleted.
(WebCore::SVGPathParser::cleanup): Deleted.
* svg/SVGPathParser.h:
(WebCore::SVGPathParser::setCurrentConsumer): Deleted.
(WebCore::SVGPathParser::setCurrentSource): Deleted.
* svg/SVGPathSegListBuilder.cpp:
(WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
(WebCore::SVGPathSegListBuilder::moveTo):
(WebCore::SVGPathSegListBuilder::lineTo):
(WebCore::SVGPathSegListBuilder::lineToHorizontal):
(WebCore::SVGPathSegListBuilder::lineToVertical):
(WebCore::SVGPathSegListBuilder::curveToCubic):
(WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
(WebCore::SVGPathSegListBuilder::curveToQuadratic):
(WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
(WebCore::SVGPathSegListBuilder::arcTo):
(WebCore::SVGPathSegListBuilder::closePath):
* svg/SVGPathSegListBuilder.h:
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement): Deleted.
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList): Deleted.
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole): Deleted.
* svg/SVGPathStringBuilder.cpp:
(WebCore::SVGPathStringBuilder::cleanup): Deleted.
* svg/SVGPathStringBuilder.h:
* svg/SVGPathTraversalStateBuilder.cpp:
(WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):
(WebCore::SVGPathTraversalStateBuilder::moveTo):
(WebCore::SVGPathTraversalStateBuilder::lineTo):
(WebCore::SVGPathTraversalStateBuilder::curveToCubic):
(WebCore::SVGPathTraversalStateBuilder::closePath):
(WebCore::SVGPathTraversalStateBuilder::continueConsuming):
(WebCore::SVGPathTraversalStateBuilder::totalLength):
(WebCore::SVGPathTraversalStateBuilder::currentPoint):
(WebCore::SVGPathTraversalStateBuilder::setDesiredLength): Deleted.
* svg/SVGPathTraversalStateBuilder.h:
(WebCore::SVGPathTraversalStateBuilder::pathSegmentIndex):
(WebCore::SVGPathTraversalStateBuilder::setCurrentTraversalState): Deleted.
* svg/SVGPathUtilities.cpp: Remove globals accessors, making things on the stack
instead. Use SVGPathParser helper functions where possible.
(WebCore::buildPathFromString):
(WebCore::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::buildPathFromByteStream):
(WebCore::buildSVGPathSegListFromByteStream):
(WebCore::buildStringFromByteStream):
(WebCore::buildStringFromSVGPathSegList):
(WebCore::buildSVGPathByteStreamFromString):
(WebCore::buildAnimatedSVGPathByteStream):
(WebCore::addToSVGPathByteStream):
(WebCore::getSVGPathSegAtLengthFromSVGPathByteStream):
(WebCore::getTotalLengthOfSVGPathByteStream):
(WebCore::getPointAtLengthOfSVGPathByteStream):
(WebCore::buildStringFromPath):
(WebCore::globalSVGPathBuilder): Deleted.
(WebCore::globalSVGPathSegListBuilder): Deleted.
(WebCore::globalSVGPathByteStreamBuilder): Deleted.
(WebCore::globalSVGPathStringBuilder): Deleted.
(WebCore::globalSVGPathTraversalStateBuilder): Deleted.
(WebCore::globalSVGPathParser): Deleted.
(WebCore::globalSVGPathBlender): Deleted.
* svg/SVGPathUtilities.h:
* svg/SVGToOTFFontConversion.cpp: CFFBuilder no longer inherits from SVGPathBuilder.
It did nothing with the Path, re-implemented all the functions, and only made use of
the m_current member var, so just make it inherit from SVGPathConsumer, and have
its own m_current.
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest font-variant-* and font-feature-settings with mocked preinstalled fonts
mmaxfield@apple.com [Sun, 11 Oct 2015 20:23:26 +0000 (20:23 +0000)]
Test font-variant-* and font-feature-settings with mocked preinstalled fonts
https://bugs.webkit.org/show_bug.cgi?id=149777

Reviewed by Simon Fraser.

Tools:

Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
to the list of tests to preinstall at startup time.

Also, update the generation of the 'name' table in the FontWithFeatures font.

* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(activateTestingFonts):
(activateFontsIOS):
* FontWithFeatures/FontWithFeatures/FontCreator.cpp:
(Generator::generate):
(Generator::appendCFFTable):
(Generator::appendNameSubtable):
(Generator::appendNAMETable):
* FontWithFeatures/FontWithFeatures/main.cpp:
(main):
* WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
(WTR::allowedFontFamilySet):
(WTR::activateFonts):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::allowedFontFamilySet):

LayoutTests:

See per-file comments.

* css3/font-feature-settings-preinstalled-fonts.html: Removed. Superseded by
css3/font-feature-settings-rendering.html.
* css3/font-feature-settings-rendering-2-expected.html: Removed.
* css3/font-feature-settings-rendering-2.html: Removed. Renamed to
css3/font-feature-settings-rendering.html
* css3/font-feature-settings-rendering-expected.html: Added.
* css3/font-feature-settings-rendering.html:
* css3/font-variant-all-expected.html:
* css3/font-variant-all.html:
* css3/resources/FontWithFeatures.otf: Update for new 'name' table.
* css3/resources/FontWithFeatures.ttf: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoES6 classes: When a class extends B, super() invokes B.prototype.constructor() instea...
utatane.tea@gmail.com [Sun, 11 Oct 2015 18:46:52 +0000 (18:46 +0000)]
ES6 classes: When a class extends B, super() invokes B.prototype.constructor() instead of B()
https://bugs.webkit.org/show_bug.cgi?id=149001

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch matches the `super()` call in the constructor to the latest spec.
Before this patch, when calling `super()`, it loads `callee.[[HomeObject]].__proto__.constructor`
as a super constructor. But after this patch, it loads `callee.__proto__` as a super constructor.
This behavior corresponds to the section 12.3.5.2[1].

[1]: http://www.ecma-international.org/ecma-262/6.0/#sec-getsuperconstructor

* bytecompiler/NodesCodegen.cpp:
(JSC::SuperNode::emitBytecode):
* tests/stress/super-call-does-not-look-up-constructor.js: Added.
(shouldBe):
(B):
(C):
(B.prototype):

LayoutTests:

An error message becomes changed.

* js/class-syntax-call-expected.txt:
* js/class-syntax-extends-expected.txt:
* js/class-syntax-super-expected.txt:
* js/script-tests/class-syntax-call.js:
* js/script-tests/class-syntax-extends.js:
* js/script-tests/class-syntax-super.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Add Jinyoung Hur as a committer.
hur.ims@navercorp.com [Sun, 11 Oct 2015 16:09:49 +0000 (16:09 +0000)]
Unreviewed. Add Jinyoung Hur as a committer.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove InsertionPoint and ContentDistributor
antti@apple.com [Sun, 11 Oct 2015 07:18:58 +0000 (07:18 +0000)]
Remove InsertionPoint and ContentDistributor
https://bugs.webkit.org/show_bug.cgi?id=150004

Rubber-stamped by Sam Weinig.

Now that <details> is on top of the modern Shadow DOM remove the last vestiges of the V0 Shadow DOM API.

* CMakeLists.txt:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* css/SelectorChecker.cpp:
* css/StyleResolver.cpp:
* dom/ContainerNode.cpp:
* dom/Element.cpp:
(WebCore::shouldUseNodeRenderingTraversalSlowPath):
(WebCore::Element::resetNeedsNodeRenderingTraversalSlowPath):
* dom/Node.cpp:
(WebCore::Node::parentOrShadowHostElement):
(WebCore::Node::insertedInto):
(WebCore::Node::insertionParentForBinding): Deleted.
* dom/Node.h:
(WebCore::Node::isCharacterDataNode):
(WebCore::Node::isFrameOwnerElement):
(WebCore::Node::isPluginElement):
(WebCore::Node::isImageControlsRootElement):
(WebCore::Node::isImageControlsButtonElement):
(WebCore::Node::isDocumentFragment):
(WebCore::Node::isShadowRoot):
(WebCore::Node::isInsertionPointNode): Deleted.
(WebCore::Node::isInsertionPoint): Deleted.
* dom/NodeRenderingTraversal.cpp:
(WebCore::NodeRenderingTraversal::traverseParent):
(WebCore::NodeRenderingTraversal::traverseFirstChild):
(WebCore::NodeRenderingTraversal::traverseLastChild):
(WebCore::NodeRenderingTraversal::traverseNextSibling):
(WebCore::NodeRenderingTraversal::traversePreviousSibling):
(WebCore::NodeRenderingTraversal::parentSlow):
(WebCore::NodeRenderingTraversal::nextInScope):
(WebCore::NodeRenderingTraversal::previousInScope):
(WebCore::NodeRenderingTraversal::parentInScope):
(WebCore::NodeRenderingTraversal::lastChildInScope):
(WebCore::NodeRenderingTraversal::nodeCanBeDistributed): Deleted.
(WebCore::NodeRenderingTraversal::findFirstSiblingEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findFirstEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findFirstFromDistributedNode): Deleted.
(WebCore::NodeRenderingTraversal::findLastSiblingEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findLastEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findLastFromDistributedNode): Deleted.
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::distributor): Deleted.
* html/HTMLInputElement.cpp:
* html/HTMLSlotElement.cpp:
* html/HTMLSlotElement.h:
* html/shadow/ContentDistributor.cpp: Removed.
* html/shadow/ContentDistributor.h: Removed.
* html/shadow/InsertionPoint.cpp: Removed.
* html/shadow/InsertionPoint.h: Removed.
* page/FocusController.cpp:
(WebCore::FocusController::previousFocusableElement):
* testing/Internals.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUse references and more const in SVGPathUtilities
simon.fraser@apple.com [Sun, 11 Oct 2015 06:16:18 +0000 (06:16 +0000)]
Use references and more const in SVGPathUtilities
https://bugs.webkit.org/show_bug.cgi?id=150007

Reviewed by Zalan Bujtas.

SVGPathUtilities had lots of pointers whose non-nullness was asserted,
little const, and was very trigger-happy with stack allocations. Clean
that all up.

* svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPathAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):
* svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::begin):
(WebCore::SVGPathByteStream::end):
(WebCore::SVGPathByteStream::append):
* svg/SVGPathByteStreamSource.cpp:
(WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource):
* svg/SVGPathByteStreamSource.h:
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getTotalLength):
(WebCore::SVGPathElement::getPointAtLength):
(WebCore::SVGPathElement::getPathSegAtLength):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::SVGPathElement): Deleted.
* svg/SVGPathElement.h:
* svg/SVGPathUtilities.cpp:
(WebCore::globalSVGPathBuilder):
(WebCore::globalSVGPathSegListBuilder):
(WebCore::globalSVGPathByteStreamBuilder):
(WebCore::globalSVGPathStringBuilder):
(WebCore::globalSVGPathTraversalStateBuilder):
(WebCore::globalSVGPathParser):
(WebCore::globalSVGPathBlender):
(WebCore::buildPathFromString):
(WebCore::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::buildPathFromByteStream):
(WebCore::buildSVGPathSegListFromByteStream):
(WebCore::buildStringFromByteStream):
(WebCore::buildStringFromSVGPathSegList):
(WebCore::buildSVGPathByteStreamFromString):
(WebCore::buildAnimatedSVGPathByteStream):
(WebCore::addToSVGPathByteStream):
(WebCore::getSVGPathSegAtLengthFromSVGPathByteStream):
(WebCore::getTotalLengthOfSVGPathByteStream):
(WebCore::getPointAtLengthOfSVGPathByteStream):
(WebCore::buildStringFromPath):
* svg/SVGPathUtilities.h:
* svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoReduce pointless malloc traffic in CodeBlock construction.
akling@apple.com [Sat, 10 Oct 2015 21:14:56 +0000 (21:14 +0000)]
Reduce pointless malloc traffic in CodeBlock construction.
<https://webkit.org/b/149999>

Reviewed by Antti Koivisto.

Create the RefCountedArray<Instruction> for CodeBlock's m_instructions directly
instead of first creating a Vector<Instruction> and then creating a RefCountedArray
from that. None of the Vector functionality is needed here anyway.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
* bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoReduce pointless malloc traffic in ElementRuleCollector.
akling@apple.com [Sat, 10 Oct 2015 21:13:15 +0000 (21:13 +0000)]
Reduce pointless malloc traffic in ElementRuleCollector.
<https://webkit.org/b/150003>

Reviewed by Antti Koivisto.

Don't use a unique_ptr for the m_matchedRules vector in ElementRuleCollector.
This is one of our heaviest sources of transient allocations, with ~88000
malloc/free pairs on loading theverge.com.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
* css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::hasMatchedRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Remove unnecessary iOS version checks
mitz@apple.com [Sat, 10 Oct 2015 20:05:53 +0000 (20:05 +0000)]
[iOS] Remove unnecessary iOS version checks
https://bugs.webkit.org/show_bug.cgi?id=150002

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

* llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):

Source/WebCore:

* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
* loader/cocoa/DiskCacheMonitorCocoa.h:
(WebCore::DiskCacheMonitor::monitorFileBackingStoreCreation):
* page/mac/SettingsMac.mm:
(WebCore::sansSerifTraditionalHanFontFamily):
(WebCore::sansSerifSimplifiedHanFontFamily):
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::appendOpenTypeFeature):
* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::getSystemFontFallbackForCharacters):
(WebCore::platformLookupFallbackFont):
* platform/ios/PlatformSpeechSynthesizerIOS.mm:
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
* platform/ios/WebCoreSystemInterfaceIOS.h:
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
* platform/ios/wak/WAKWindow.mm:
(+[WAKWindow hasLandscapeOrientation]):
(-[WAKWindow hostLayer]):
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::copyCookiesForURLWithFirstPartyURL):
(WebCore::createCookies):
* platform/network/mac/CertificateInfoMac.mm:
(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate):
* platform/spi/cf/CFNetworkSPI.h:
* platform/spi/cocoa/AVKitSPI.h:
* platform/spi/cocoa/CoreTextSPI.h:
* platform/spi/cocoa/NEFilterSourceSPI.h:
* platform/spi/cocoa/QuartzCoreSPI.h:
* platform/spi/cocoa/SecuritySPI.h:
* platform/spi/ios/LaunchServicesSPI.h:
* platform/spi/mac/AVFoundationSPI.h:
* platform/text/TextBreakIterator.cpp:
* platform/text/TextFlags.h:
* platform/text/ios/LocalizedDateCache.mm:
(WebCore::LocalizedDateCache::calculateMaximumWidth):
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::LocaleMac):
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::cachedSystemFontDescription):
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):
* svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendKERNTable):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):

Source/WebKit/mac:

* Plugins/WebPluginController.h:
* Plugins/WebPluginController.mm:
(-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
(+[WebPluginController addPlugInView:]):
(+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): Deleted.
* WebCoreSupport/WebFrameLoaderClient.mm:
(pluginView):
* WebView/WebPreferences.mm:
(-[WebPreferences isDNSPrefetchingEnabled]):
(-[WebPreferences setWebInspectorServerEnabled:]): Deleted.
(-[WebPreferences _setAllowCompositingLayerVisualDegradation:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(shouldAllowPictureInPictureMediaPlayback):

Source/WebKit2:

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* Platform/IPC/mac/ConnectionMac.mm:
(IPC::AccessibilityProcessSuspendedNotification):
* Platform/spi/ios/SafariServicesSPI.h:
* Platform/spi/ios/UIKitSPI.h:
* Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
* Shared/Network/NetworkProcessCreationParameters.h:
* Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):
* Shared/Plugins/PluginProcessCreationParameters.h:
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::NativeWebTouchEvent::extractWebTouchPoint):
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
* Shared/ios/WebPlatformTouchPointIOS.cpp:
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _mayAutomaticallyShowVideoPictureInPicture]):
(shouldAllowPictureInPictureMediaPlayback):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
* UIProcess/ios/ViewGestureControllerIOS.mm:
(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView _ensureFormAccessoryView]):
(-[WKContentView webSelectionAssistant]):
(-[WKContentView selectionInteractionAssistant]):
* UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::create):
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(photoLibraryIcon):
(cameraIcon):
(fallbackIconForFile):
(iconForImageFile):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

* wtf/Platform.h:

Tools:

* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
* WebKitTestRunner/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRewrite HTMLDetailsElement using HTMLSlotElement
antti@apple.com [Sat, 10 Oct 2015 18:16:37 +0000 (18:16 +0000)]
Rewrite HTMLDetailsElement using HTMLSlotElement
https://bugs.webkit.org/show_bug.cgi?id=149698

Reviewed by Andreas Kling.

Source/WebCore:

Use the modern Shadow DOM to implement <details> element. After this the legacy InsertionPoint and
related code can be removed.

Based on a patch by Ryosuke.

* dom/Element.cpp:
(WebCore::Element::childrenChanged):
* dom/EventDispatcher.cpp:
(WebCore::EventPath::EventPath):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::removeAllEventListeners):
(WebCore::ShadowRoot::findAssignedSlot):
(WebCore::ShadowRoot::addSlotElementByName):
(WebCore::ShadowRoot::removeSlotElementByName):
(WebCore::ShadowRoot::invalidateSlotAssignments):
(WebCore::ShadowRoot::invalidateDefaultSlotAssignments):
(WebCore::ShadowRoot::assignedNodesForSlot):
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::distributor):
(WebCore::ShadowRoot::isOrphan):
* dom/SlotAssignment.cpp:
(WebCore::slotNameFromAttributeValue):

    Rename for clarity.

(WebCore::slotNameFromSlotAttribute):

    SlotAssignment can now be specialized by providing function that maps from node to slot name.
    This is the default function that gets the name from the slot attribute.

(WebCore::SlotAssignment::SlotAssignment):
(WebCore::SlotAssignment::findAssignedSlot):

    Use the name mapping function.
    Ensure that the slots are assigned.

(WebCore::SlotAssignment::addSlotElementByName):
(WebCore::SlotAssignment::removeSlotElementByName):
(WebCore::SlotAssignment::assignedNodesForSlot):
(WebCore::SlotAssignment::invalidate):
(WebCore::SlotAssignment::invalidateDefaultSlot):
(WebCore::SlotAssignment::resolveAllSlotElements):
(WebCore::SlotAssignment::assignSlots):

    Use the name mapping function.

(WebCore::SlotAssignment::assignToSlot):

    Factor into function.

(WebCore::treatNullAsEmpty): Deleted.
* dom/SlotAssignment.h:
(WebCore::SlotAssignment::~SlotAssignment):
(WebCore::SlotAssignment::defaultSlotName):

    Add static getter for emptyAtom for clarity.

(WebCore::SlotAssignment::SlotAssignment): Deleted.
* html/HTMLDetailsElement.cpp:
(WebCore::summarySlotName):
(WebCore::slotNameFunction):

    Slot name function for <details>. It assigns the first <summary> child to the summary slot and others
    to the default content slot if the element is open.

(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot):
(WebCore::HTMLDetailsElement::isActiveSummary):
(WebCore::HTMLDetailsElement::parseAttribute):
(WebCore::HTMLDetailsElement::toggleOpen):
(WebCore::summaryQuerySelector): Deleted.
(WebCore::DetailsContentElement::create): Deleted.
(WebCore::DetailsSummaryElement::create): Deleted.
(WebCore::HTMLDetailsElement::findMainSummary): Deleted.
(WebCore::HTMLDetailsElement::childShouldCreateRenderer): Deleted.
* html/HTMLDetailsElement.h:
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::create):
(WebCore::HTMLSummaryElement::createElementRenderer):
(WebCore::HTMLSummaryElement::didAddUserAgentShadowRoot):
(WebCore::HTMLSummaryElement::detailsElement):
(WebCore::HTMLSummaryElement::isActiveSummary):
(WebCore::isClickableControl):
(WebCore::HTMLSummaryElement::supportsFocus):
(WebCore::HTMLSummaryElement::defaultEventHandler):
(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents):
(WebCore::SummaryContentElement::create): Deleted.
(WebCore::HTMLSummaryElement::childShouldCreateRenderer): Deleted.
(WebCore::HTMLSummaryElement::isMainSummary): Deleted.
* html/HTMLSummaryElement.h:
* html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::rendererIsNeeded):
* style/RenderTreePosition.cpp:
(WebCore::RenderTreePosition::computeNextSibling):

    Skip the verification assert for shadow host children. Getting this right requires
    better shadow-aware traversal code.

* style/StyleResolveTree.cpp:
(WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
(WebCore::Style::attachChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachSlotAssignees):
(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):
(WebCore::Style::detachShadowRoot):
(WebCore::Style::detachSlotAssignees):
(WebCore::Style::detachRenderTree):
(WebCore::Style::resolveChildren):
(WebCore::Style::resolveSlotAssignees):
(WebCore::Style::resolveTree):
(WebCore::Style::attachDistributedChildren): Deleted.
(WebCore::Style::detachDistributedChildren): Deleted.

    Remove InsertionPoint related code paths.

LayoutTests:

* TestExpectations:
* platform/mac/fast/html/details-add-child-2-expected.txt:
* platform/mac/fast/html/details-open2-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Improve error messages for internal Inspector code
nvasilyev@apple.com [Sat, 10 Oct 2015 15:50:32 +0000 (15:50 +0000)]
Web Inspector: Improve error messages for internal Inspector code
https://bugs.webkit.org/show_bug.cgi?id=149995

Don't log "error.stack" since the error view already includes a nicely formatted stacktrace.

Reviewed by Timothy Hatcher.

* UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass.prototype._dispatchResponseToCallback):
(InspectorBackendClass.prototype._dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSerializedScriptValue should use a compact encoding for 8-bit strings.
akling@apple.com [Sat, 10 Oct 2015 15:27:46 +0000 (15:27 +0000)]
SerializedScriptValue should use a compact encoding for 8-bit strings.
<https://webkit.org/b/149934>

Reviewed by Antti Koivisto.

Source/WebCore:

We were encoding known 8-bit strings in a 16-bit format when serializing script values.

Extend the format to support 8-bit strings. The 8-bittiness is encoded in the highest bit
of the string length. This is possible while supporting all older formats due to string
lengths >= 0x7FFFFFFF being disallowed.

This patch knocks ~1 MB off of theverge.com, where some ad or tracker or whatever likes to
do a ton of postMessage() business.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CurrentVersion): Bump the serialization format version. Also updated the grammar
comment to describe the new format. Artistic license applied in description of bitfield.

(WebCore::writeLittleEndianUInt16): Deleted.

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::deserializeString):
(WebCore::CloneDeserializer::readString):
(WebCore::CloneDeserializer::readStringData): Support 8-bit strings. I kept the string
length limit at UINT_MAX/sizeof(UChar) since the highest bit of the length is no longer
available. Besides, it seems flimsy to support longer strings if they happen to have all
8-bit characters.

LayoutTests:

Update a test to reflect changes to the serialization format.

* fast/storage/serialized-script-value.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Remove project support for iOS 8
mitz@apple.com [Sat, 10 Oct 2015 08:40:34 +0000 (08:40 +0000)]
[iOS] Remove project support for iOS 8
https://bugs.webkit.org/show_bug.cgi?id=149993

Reviewed by Alexey Proskuryakov.

Source/bmalloc:

* Configurations/Base.xcconfig:
* Configurations/bmalloc.xcconfig:
* Configurations/mbmalloc.xcconfig:

Source/JavaScriptCore:

* Configurations/Base.xcconfig:
* Configurations/JSC.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* Configurations/LLVMForJSC.xcconfig:
* Configurations/ToolExecutable.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/ANGLE.xcconfig:
* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/WebCore.xcconfig:
* Configurations/WebCoreTestSupport.xcconfig:

Source/WebKit/mac:

* Configurations/WebKitLegacy.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:
* Configurations/BaseLegacyProcess.xcconfig:
* Configurations/BaseXPCService.xcconfig:
* Configurations/PluginProcessShim.xcconfig:
* Configurations/SecItemShim.xcconfig:
* Configurations/WebKit.xcconfig:
* Configurations/WebKit2.xcconfig:
* Configurations/WebProcessShim.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:
* Configurations/WTF.xcconfig:
* Configurations/mbmalloc.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190689
mmaxfield@apple.com [Sat, 10 Oct 2015 03:52:41 +0000 (03:52 +0000)]
Unreviewed, rolling out r190689
https://bugs.webkit.org/show_bug.cgi?id=149992

Fixed in other repository.

Reverted changesets:

"Unreviewed, rolling out r190572, r190593, r190594, and r190639."
https://bugs.webkit.org/show_bug.cgi?id=149897

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCheck if start and end positions are still valid after updating them through VisibleS...
zalan@apple.com [Sat, 10 Oct 2015 02:53:53 +0000 (02:53 +0000)]
Check if start and end positions are still valid after updating them through VisibleSelection.
https://bugs.webkit.org/show_bug.cgi?id=149982

Reviewed by Ryosuke Niwa.

This patch is required to be able to clean up anonymous tables structure.
In certain edge cases, start/end positions could become nullptr after various text splitting
operations.

Covered by editing/execCommand/crash-137961.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::applyInlineStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRename RenderObject::isRoot() to isDocumentElementRenderer()
simon.fraser@apple.com [Sat, 10 Oct 2015 02:20:52 +0000 (02:20 +0000)]
Rename RenderObject::isRoot() to isDocumentElementRenderer()
https://bugs.webkit.org/show_bug.cgi?id=149976

Reviewed by Zalan Bujtas.

RenderObject::isRoot() was confusingly named, because it returns true for
the document element's renderer, not for the actual root (the RenderView).
In this way it mismatched RenderLayer::isRootLayer(), which returned true
for the RenderView's layer.

Rename it to the more accurate isDocumentElementRenderer().

* dom/Node.cpp:
(WebCore::Node::renderRect):
* page/ios/FrameIOS.mm:
(WebCore::Frame::renderRectForPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::selectionGaps):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::requiresColumns):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::paintBackground):
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::createsNewFormattingContext):
(WebCore::RenderBox::percentageLogicalHeightIsResolvableFromBlock):
* rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewport):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::fixedBackgroundPaintsInLocalCoordinates):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
* rendering/RenderBoxModelObject.h:
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::rendererForRootBackground):
(WebCore::shouldRepaintForImageAnimation):
* rendering/RenderElement.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
* rendering/RenderLayer.cpp:
(WebCore::shouldSuppressPaintingLayer):
(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::rendererBackgroundColor):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintSlowRepaintObject):
(WebCore::RenderObject::offsetParent):
* rendering/RenderObject.h:
(WebCore::RenderObject::isDocumentElementRenderer):
(WebCore::RenderObject::isRoot): Deleted.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::shouldApplyViewportClip):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::isOverflowHidden):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount...
n_wang@apple.com [Sat, 10 Oct 2015 01:08:32 +0000 (01:08 +0000)]
AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan
https://bugs.webkit.org/show_bug.cgi?id=148967

Reviewed by Chris Fleizach.

Source/WebCore:

Added support for ARIA 1.1 table/grid related attributes. Created new attributes for mac, so
VoiceOver can pick up the information and speak accordingly.

Test: accessibility/mac/aria-table-attributes.html

* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell):
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):
(WebCore::AccessibilityARIAGridCell::parentRowGroup):
* accessibility/AccessibilityARIAGridCell.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::initializeRoleMap):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::title):
(WebCore::AccessibilityTable::ariaColumnCount):
(WebCore::AccessibilityTable::ariaRowCount):
* accessibility/AccessibilityTable.h:
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::titleUIElement):
(WebCore::AccessibilityTableCell::ariaColumnIndex):
(WebCore::AccessibilityTableCell::ariaRowIndex):
(WebCore::AccessibilityTableCell::ariaColumnSpan):
(WebCore::AccessibilityTableCell::ariaRowSpan):
* accessibility/AccessibilityTableCell.h:
(WebCore::AccessibilityTableCell::setARIAColIndexFromRow):
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
(WebCore::AccessibilityTableRow::addChildren):
(WebCore::AccessibilityTableRow::ariaColumnIndex):
(WebCore::AccessibilityTableRow::ariaRowIndex):
* accessibility/AccessibilityTableRow.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
* html/HTMLAttributeNames.in:

LayoutTests:

* accessibility/mac/aria-columnrowheaders-expected.txt:
* accessibility/mac/aria-table-attributes-expected.txt: Added.
* accessibility/mac/aria-table-attributes.html: Added.
* platform/mac/accessibility/table-attributes-expected.txt:
* platform/mac/accessibility/table-cell-spans-expected.txt:
* platform/mac/accessibility/table-cells-expected.txt:
* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/accessibility/table-sections-expected.txt:
* platform/mac/accessibility/table-with-rules-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRubber-stamped by Anders Carlsson.
bdakin@apple.com [Fri, 9 Oct 2015 23:30:32 +0000 (23:30 +0000)]
Rubber-stamped by Anders Carlsson.

Remove unnecessary includes.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/mac/WebPageMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoModernize and cleanup an NSNumber constant
commit-queue@webkit.org [Fri, 9 Oct 2015 23:19:57 +0000 (23:19 +0000)]
Modernize and cleanup an NSNumber constant
https://bugs.webkit.org/show_bug.cgi?id=149962

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-09
Reviewed by Andreas Kling.

* API/JSVirtualMachine.mm:
(-[JSVirtualMachine addExternalRememberedObject:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBuild fix.
bdakin@apple.com [Fri, 9 Oct 2015 23:19:00 +0000 (23:19 +0000)]
Build fix.

* CMakeLists.txt:
* Shared/API/APIHitTestResult.cpp: Removed.
* Shared/API/APIHitTestResult.h: Removed.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoNo need to keep setting needsVisit flag in SmallStrings
commit-queue@webkit.org [Fri, 9 Oct 2015 23:17:59 +0000 (23:17 +0000)]
No need to keep setting needsVisit flag in SmallStrings
https://bugs.webkit.org/show_bug.cgi?id=149961

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-09
Reviewed by Andreas Kling.

SmallStrings are all initialized at once privately before the VM
enables Garbage Collection. There is no need to keep updating
this flag, as it couldn't have changed.

* runtime/SmallStrings.cpp:
(JSC::SmallStrings::createEmptyString):
(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::initialize):
* runtime/SmallStrings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBuild fix.
bdakin@apple.com [Fri, 9 Oct 2015 23:15:11 +0000 (23:15 +0000)]
Build fix.

* UIProcess/API/APIHitTestResult.cpp: Copied from Shared/API/APIHitTestResult.cpp.
* UIProcess/API/APIHitTestResult.h: Copied from Shared/API/APIHitTestResult.h.
* UIProcess/mac/PageClientImpl.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago2015-10-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 9 Oct 2015 23:10:16 +0000 (23:10 +0000)]
2015-10-09  Geoffrey Garen  <ggaren@apple.com>

        Unreviewed, rolling back in r190694
        https://bugs.webkit.org/show_bug.cgi?id=149727

        This time for double sure?

        The cause of the crash was an incorrect write barrier.

        OSR exit was barriering the baseline codeblock for the top of the stack
        twice, missing the baseline codeblock for the bottom of the stack.

        Restored changesets:

        "CodeBlock should be a GC object"
        https://bugs.webkit.org/show_bug.cgi?id=149727
        http://trac.webkit.org/changeset/r190694

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove hack that allowed plug-ins to always take over certain image formats
andersca@apple.com [Fri, 9 Oct 2015 22:48:39 +0000 (22:48 +0000)]
Remove hack that allowed plug-ins to always take over certain image formats
https://bugs.webkit.org/show_bug.cgi?id=149972

Reviewed by Tim Horton.

This hack was added 8 years ago to allow a certain plug-in to show multi-page TIFF images on uspto.gov.
We now support said TIFFs natively, and the plug-in has been discontinued so it's safe to get rid of this.

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::shouldUsePlugin): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWKWebView needs SPI to customize immediate actions
bdakin@apple.com [Fri, 9 Oct 2015 22:24:04 +0000 (22:24 +0000)]
WKWebView needs SPI to customize immediate actions
https://bugs.webkit.org/show_bug.cgi?id=149939
-and corresponding-
rdar://problem/20016849

Reviewed by Anders Carlsson.

This patch breaks WebHitTestResult into two files. WebHiTestResultData
continues to live in the WebKit namespace and contains the old
WebHitTestResult::Data struct. The rest of WebHitTestResult is now
API::HitTestResult. The patch also adds _WKHitTestResult as Obj-C API to wrap
API::HitTestResult.

Attempt to keep other ports happy with new files.
* CMakeLists.txt:

WebKit::WebHitTestResult no longer contains the Data struct and is now called
API::HitTestResult.
* Shared/API/APIHitTestResult.cpp: Copied from Shared/WebHitTestResult.cpp.
(API::HitTestResult::create):
(WebKit::WebHitTestResult::create): Deleted.
(WebKit::WebHitTestResult::Data::Data): Deleted.
(WebKit::WebHitTestResult::Data::~Data): Deleted.
(WebKit::WebHitTestResult::Data::encode): Deleted.
(WebKit::WebHitTestResult::Data::decode): Deleted.
(WebKit::WebHitTestResult::Data::platformEncode): Deleted.
(WebKit::WebHitTestResult::Data::platformDecode): Deleted.
(WebKit::WebHitTestResult::Data::elementBoundingBoxInWindowCoordinates): Deleted.
* Shared/API/APIHitTestResult.h: Copied from Shared/WebHitTestResult.h.
(API::HitTestResult::absoluteImageURL):
(API::HitTestResult::absolutePDFURL):
(API::HitTestResult::absoluteLinkURL):
(API::HitTestResult::absoluteMediaURL):
(API::HitTestResult::linkLabel):
(API::HitTestResult::linkTitle):
(API::HitTestResult::lookupText):
(API::HitTestResult::isContentEditable):
(API::HitTestResult::isDownloadableMedia):
(API::HitTestResult::HitTestResult):
(WebKit::WebHitTestResult::absoluteImageURL): Deleted.
(WebKit::WebHitTestResult::absolutePDFURL): Deleted.
(WebKit::WebHitTestResult::absoluteLinkURL): Deleted.
(WebKit::WebHitTestResult::absoluteMediaURL): Deleted.
(WebKit::WebHitTestResult::linkLabel): Deleted.
(WebKit::WebHitTestResult::linkTitle): Deleted.
(WebKit::WebHitTestResult::lookupText): Deleted.
(WebKit::WebHitTestResult::isContentEditable): Deleted.
(WebKit::WebHitTestResult::isDownloadableMedia): Deleted.
(WebKit::WebHitTestResult::WebHitTestResult): Deleted.

This is a new obj-c object that we can use for the modern immediate action
API.
* Shared/API/Cocoa/_WKHitTestResult.h: Added.
* Shared/API/Cocoa/_WKHitTestResult.mm: Added.
(-[_WKHitTestResult dealloc]):
(-[_WKHitTestResult absoluteImageURL]):
(-[_WKHitTestResult absolutePDFURL]):
(-[_WKHitTestResult absoluteLinkURL]):
(-[_WKHitTestResult absoluteMediaURL]):
(-[_WKHitTestResult linkLabel]):
(-[_WKHitTestResult linkTitle]):
(-[_WKHitTestResult lookupText]):
(-[_WKHitTestResult isContentEditable]):
(-[_WKHitTestResult elementBoundingBox]):
(-[_WKHitTestResult copyWithZone:]):
(-[_WKHitTestResult _apiObject]):

_WKHitTestResult wraps API::HitTestResult.
* Shared/API/Cocoa/_WKHitTestResultInternal.h: Added.
(API::wrapper):
* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):

Since we want to use the same enum name for the new enum, use a #define instead of a typedef in the old C SPI. This should keep old clients working in the meantime.
* Shared/API/c/WKImmediateActionTypes.h:

WebHitTestResult::Data is now WebHitTestResultData.
* Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::webHitTestResultData):
(WebKit::ContextMenuContextData::selectedText):

Remove WebHitTestResult, and add WebHitTestResultData for the Data struct.
* Shared/WebHitTestResult.cpp: Removed.
* Shared/WebHitTestResult.h: Removed.
* Shared/WebHitTestResultData.cpp: Added.
(WebKit::WebHitTestResultData::WebHitTestResultData):
(WebKit::WebHitTestResultData::~WebHitTestResultData):
(WebKit::WebHitTestResultData::encode):
(WebKit::WebHitTestResultData::decode):
(WebKit::WebHitTestResultData::platformEncode):
(WebKit::WebHitTestResultData::platformDecode):
(WebKit::WebHitTestResultData::elementBoundingBoxInWindowCoordinates):
* Shared/WebHitTestResultData.h: Added.
* Shared/mac/WebHitTestResult.mm: Removed.
* Shared/mac/WebHitTestResultData.mm: Copied from Shared/mac/WebHitTestResult.mm.
(WebKit::WebHitTestResultData::platformEncode):
(WebKit::WebHitTestResultData::platformDecode):
(WebKit::WebHitTestResult::Data::platformEncode): Deleted.
(WebKit::WebHitTestResult::Data::platformDecode): Deleted.

WebHitTestResult::Data is now WebHitTestResultData.
* UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::~ContextMenuClient):
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::customContextMenuItemSelected):
(API::ContextMenuClient::contextMenuDismissed):
(API::ContextMenuClient::showContextMenu):

WebHitTestResult is now WebHitTestResult
* UIProcess/API/APIUIClient.h:
(API::UIClient::runJavaScriptPrompt):
(API::UIClient::setStatusText):
(API::UIClient::mouseDidMoveOverElement):
(API::UIClient::unavailablePluginButtonClicked):
(API::UIClient::pinnedStateDidChange):
(API::UIClient::didBeginTrackingPotentialLongMousePress):
(API::UIClient::didRecognizeLongMousePress):
(API::UIClient::didCancelTrackingPotentialLongMousePress):
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKHitTestResult.cpp:
(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
(WKPageSetPageUIClient):

New WKWebView SPI _immediateActionAnimationControllerForHitTestResult
* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

Attempts to keep other ports happy with the re-name.
* UIProcess/API/efl/WebAccessibility.cpp:
* UIProcess/API/gtk/WebKitContextMenuClient.cpp:
* UIProcess/API/gtk/WebKitHitTestResult.cpp:
(webkit_hit_test_result_class_init):
(webkitHitTestResultCreate):
(stringIsEqualToCString):
(webkitHitTestResultCompare):
* UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
* UIProcess/API/gtk/WebKitUIClient.cpp:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewMakePermissionRequest):
(webkitWebViewMouseTargetChanged):
(contextMenuDismissed):
(webkitWebViewPopulateContextMenu):
* UIProcess/API/gtk/WebKitWebViewPrivate.h:

Re-name, and just use uint32_t for the old SPI.
* UIProcess/API/mac/WKView.mm:
(-[WKView _didPerformImmediateActionHitTest:contentPreventsDefault:userData:]):
(-[WKView _setDidMoveSwipeSnapshotCallback:]):
(-[WKView _immediateActionAnimationControllerForHitTestResult:withType:userData:]):
* UIProcess/API/mac/WKViewInternal.h:

PageClient will figure out whether to call into WKWebView or WKView for this
SPI.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::immediateActionAnimationControllerForHitTestResult):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::immediateActionAnimationControllerForHitTestResult):

WebKit::WebHitTestResult::Data is now WebKit::WebHitTestResultData.
* UIProcess/WebPageProxy.messages.in:

WKImmediateActionController calls through to WebPageProxy which calls to
PageClient, which figures out which API to call. Also cache the type as a
uint32_t
* UIProcess/mac/WKImmediateActionController.h:
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _updateImmediateActionItem]):

WebHitTestResult::Data is now WebHitTestResultData.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::platformInitializeShareMenuItem):

New files!
* WebKit2.xcodeproj/project.pbxproj:

Deal with the #define situation for the enum.
* WebKit2Prefix.h:

New names for things. WebHitTestResult::Data -> WebHitTestResultData
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/PDF/PDFPlugin.h:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::pointInLayoutSpaceForPointInWindowSpace):
(WebKit::PDFPlugin::lookupTextAtLocation):
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement):
(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove unused RecursiveAllocationScope
commit-queue@webkit.org [Fri, 9 Oct 2015 22:06:32 +0000 (22:06 +0000)]
Remove unused RecursiveAllocationScope
https://bugs.webkit.org/show_bug.cgi?id=149967

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-09
Reviewed by Csaba Osztrogonác.

RecursiveAllocationScope has been unused since r163691.

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
* heap/Heap.h:
* heap/RecursiveAllocationScope.h: Removed.
* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTeach webkitperl how to figure out IOS versions from the SDK
bburg@apple.com [Fri, 9 Oct 2015 22:01:16 +0000 (22:01 +0000)]
Teach webkitperl how to figure out IOS versions from the SDK
https://bugs.webkit.org/show_bug.cgi?id=149963

Reviewed by Daniel Bates.

It should be easier to check the major and minor version of IOS SDKs.

* Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
* Scripts/webkitdirs.pm:
(splitVersionString): Added.
(determineOSXVersion): Use splitVersionString.
(determineIOSVersion): Added. Look at the SDK version and make a tuple.
(iosVersion): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGarbage texture data with composited table row
simon.fraser@apple.com [Fri, 9 Oct 2015 21:50:03 +0000 (21:50 +0000)]
Garbage texture data with composited table row
https://bugs.webkit.org/show_bug.cgi?id=148984

Reviewed by Zalan Bujtas.
Source/WebCore:

Don't pretend to know if the layer for a table header, section or cell is
opaque, since table painting is special.

Test: compositing/contents-opaque/table-parts.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

* compositing/contents-opaque/table-parts-expected.txt: Added.
* compositing/contents-opaque/table-parts.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
simon.fraser@apple.com [Fri, 9 Oct 2015 21:34:56 +0000 (21:34 +0000)]
[iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
https://bugs.webkit.org/show_bug.cgi?id=149960

Reviewed by Tim Horton.

Use adoptWK(), and null out some members (file is not using ARC).

* WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::uiScriptComplete):
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGarbage pixels on enphaseenergy.com site
simon.fraser@apple.com [Fri, 9 Oct 2015 21:07:25 +0000 (21:07 +0000)]
Garbage pixels on enphaseenergy.com site
https://bugs.webkit.org/show_bug.cgi?id=149915
rdar://problem/22976184

Reviewed by Darin Adler.

Source/WebCore:

When the <html> gets a composited RenderLayer, and we ask whether its background
is opaque, return false, since the document element's background propagates
to the root, and is painted by the RenderView.

Also improve the compositing logging to indicate when fore- and background layers
are present.

Test: compositing/contents-opaque/negative-z-before-html.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):

LayoutTests:

New ref test. Also update the expected result for another test that uses negative
z-index children.

* compositing/contents-opaque/body-background-painted-expected.txt:
* compositing/contents-opaque/negative-z-before-html-expected.html: Added.
* compositing/contents-opaque/negative-z-before-html.html: Added.
* platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPerf dashboard erroneously shows an old OS build in A/B testing range
rniwa@webkit.org [Fri, 9 Oct 2015 21:00:27 +0000 (21:00 +0000)]
Perf dashboard erroneously shows an old OS build in A/B testing range
https://bugs.webkit.org/show_bug.cgi?id=149942

Reviewed by Darin Adler.

Ordering OS builds lexicologically turned out be a bad idea since 15A25 falls between 15A242 and 15A251.
Use a fake/synthetic timestamp to force the commonly understood total order instead.

Refactored pull-os-versions.py to share the server config JSON with other scripts. Also made the script
support pulling multiple sources; e.g. both OS X and iOS.

Also removed superfluous feature to submit results in chunks. The perf dashboard can handle thousands of
revisions being submitted at once just fine.

* public/api/commits.php:
(main): A partial revert of r185574 since we no longer need to order builds lexicologically.

* tools/pull-os-versions.py:
(main): Takes --os-config-json, --server-config-json, and --seconds-to-sleep as arguments instead of
a single --config argument to share the server config JSON with other scripts.
(OSBuildFetcher): Extracted out of main. This class is instantiated for each OS kind (e.g. OS X).
(OSBuildFetcher.__init__): Added.
(OSBuildFetcher._fetch_available_builds): Extracted out of main. Fetches available builds from a website
or custom commands.
(OSBuildFetcher.fetch_and_report_new_builds): Extracted out of main. Submits the fetched builds after
filtering out the ones we've already reported.
(OSBuildFetcher._assign_fake_timestamps): Creates a fake timestamp to establish a total order amongst each
OS X / iOS style build number such as 12A3456b.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDynamic background color changes do not update until a layout is forced
commit-queue@webkit.org [Fri, 9 Oct 2015 19:59:12 +0000 (19:59 +0000)]
Dynamic background color changes do not update until a layout is forced
https://bugs.webkit.org/show_bug.cgi?id=131623

Source/WebCore:

Compute correct repaint rect for decorated RenderSVGRoots.

The current implementation of clippedOverflowRectForRepaint() uses the
generic repaint-rect calculations in SVGRenderSupport. Those in turn make
use of repaintRectInLocalCoordinates(), which for RenderSVGRoot is the
union of the painted children (w/ some expansion). If there're no children,
or they do not fill the entire content box, then a repaint would not
repaint the correct parts.
Fix by calculating the union of the border-box and the SVG content
when the SVG root is decorated (has background/border/etc.)

Adapted from a Chromium patch by fs@opera.com
https://src.chromium.org/viewvc/blink?revision=170890&view=revision

Patch by Antoine Quint <graouts@apple.com> on 2015-10-09
Reviewed by Darin Adler.

Tests: svg/repaint/add-background-property-on-root.html
       svg/repaint/add-border-property-on-root.html
       svg/repaint/add-outline-property-on-root.html
       svg/repaint/change-background-color.html
       svg/repaint/remove-background-property-on-root.html
       svg/repaint/remove-border-property-on-root.html
       svg/repaint/remove-outline-property-on-root.html

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::styleDidChange):
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):

LayoutTests:

Add some new tests checking that dynamically updating the "background",
"border" and "outline" CSS properties repaint correctly and rebase a few
existing tests that yield the same rendered results but slightly different
DRT output.

Patch by Antoine Quint <graouts@apple.com> on 2015-10-09
Reviewed by Darin Adler.

* platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt:
* svg/css/composite-shadow-example-expected.txt:
* svg/css/composite-shadow-with-opacity-expected.txt:
* svg/repaint/add-background-property-on-root-expected.html: Added.
* svg/repaint/add-background-property-on-root.html: Added.
* svg/repaint/add-border-property-on-root-expected.html: Added.
* svg/repaint/add-border-property-on-root.html: Added.
* svg/repaint/add-outline-property-on-root-expected.html: Added.
* svg/repaint/add-outline-property-on-root.html: Added.
* svg/repaint/change-background-color-expected.html: Added.
* svg/repaint/change-background-color.html: Added.
* svg/repaint/remove-background-property-on-root-expected.html: Added.
* svg/repaint/remove-background-property-on-root.html: Added.
* svg/repaint/remove-border-property-on-root-expected.html: Added.
* svg/repaint/remove-border-property-on-root.html: Added.
* svg/repaint/remove-outline-property-on-root-expected.html: Added.
* svg/repaint/remove-outline-property-on-root.html: Added.
* svg/repaint/repaint-webkit-svg-shadow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS WK2] Fix assertion in ViewportConfiguration::setDefaultConfiguration seen in...
simon.fraser@apple.com [Fri, 9 Oct 2015 18:36:49 +0000 (18:36 +0000)]
[iOS WK2] Fix assertion in ViewportConfiguration::setDefaultConfiguration seen in testing
https://bugs.webkit.org/show_bug.cgi?id=149959

Reviewed by Tim Horton.

When loading tests which set a flexible viewport, ViewportConfiguration::setDefaultConfiguration()
is called first with testingParameters() and then with webpageParameters(). This
would trigger the assertion that m_defaultConfiguration.initialScaleIsSet but
the new initial scale is zero.

The assertion seems wrong anyway; it's consulting m_defaultConfiguration.initialScaleIsSet
but defaultConfiguration.initialScale, so fix it to test defaultConfiguration.initialScaleIsSet.

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setDefaultConfiguration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago2015-10-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 9 Oct 2015 17:54:16 +0000 (17:54 +0000)]
2015-10-09  Geoffrey Garen  <ggaren@apple.com>

        Unreviewed, rolling out r190694
        https://bugs.webkit.org/show_bug.cgi?id=148560

        Crashes seen on PLT bots and facebook.com.

        Reverted changesets:

        "CodeBlock should be a GC object"
        https://bugs.webkit.org/show_bug.cgi?id=149727
        http://trac.webkit.org/changeset/190694

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd some missing iOS results.
simon.fraser@apple.com [Fri, 9 Oct 2015 17:53:28 +0000 (17:53 +0000)]
Add some missing iOS results.

* fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt: Added.
* platform/ios-simulator/compositing/transitions/scale-transition-no-start-expected.txt: Added.
* platform/ios-simulator/compositing/transitions/singular-scale-transition-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove two unused WKFrame functions
andersca@apple.com [Fri, 9 Oct 2015 17:30:36 +0000 (17:30 +0000)]
Remove two unused WKFrame functions
https://bugs.webkit.org/show_bug.cgi?id=149958

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames): Deleted.
(WKFrameGetParentFrame): Deleted.
* UIProcess/API/C/WKFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove ENABLE_SUID_SANDBOX_LINUX cruft
ossy@webkit.org [Fri, 9 Oct 2015 17:20:54 +0000 (17:20 +0000)]
Remove ENABLE_SUID_SANDBOX_LINUX cruft
https://bugs.webkit.org/show_bug.cgi?id=149954

Reviewed by Darin Adler.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the !ENABLE(STREAM_API) build after r190794
ossy@webkit.org [Fri, 9 Oct 2015 17:08:25 +0000 (17:08 +0000)]
Fix the !ENABLE(STREAM_API) build after r190794
https://bugs.webkit.org/show_bug.cgi?id=149955

Reviewed by Darin Adler.

* bindings/js/WebCoreJSBuiltinInternals.h:
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the binding generator after r190785
ossy@webkit.org [Fri, 9 Oct 2015 17:04:41 +0000 (17:04 +0000)]
Fix the binding generator after r190785
https://bugs.webkit.org/show_bug.cgi?id=149956

Reviewed by Darin Adler.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::getConstructData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, more Mac test gardening after r190629.
bburg@apple.com [Fri, 9 Oct 2015 16:52:46 +0000 (16:52 +0000)]
Unreviewed, more Mac test gardening after r190629.

These more accurate expectations are based on several days
of builds with the newly-imported Blink tests.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake iOS builders generate debug information in a separate dSYM file
dbates@webkit.org [Fri, 9 Oct 2015 15:55:29 +0000 (15:55 +0000)]
Make iOS builders generate debug information in a separate dSYM file
https://bugs.webkit.org/show_bug.cgi?id=149696

Reviewed by Darin Adler.

Similar to the Mac builders, the iOS builders should write debug information
into a separate dSYM file instead of including such information in the binary
itself (default Xcode behavior)

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBackgrounds bleed out of natively rendered text fields
wenson_hsieh@apple.com [Fri, 9 Oct 2015 15:18:42 +0000 (15:18 +0000)]
Backgrounds bleed out of natively rendered text fields
https://bugs.webkit.org/show_bug.cgi?id=149843
<rdar://problem/22896977>

Reviewed by Darin Adler.

Source/WebCore:

When natively rendering a text field with a background on Mac, the background bleeds out
of the text field's border when the graphics context is scaled (as a result of a retina
display or zoom/scale effects). This is because when we render the text field in bezeled
style within a certain frame, AppKit adds 1 device pixel insets on all sides of the frame,
which renders a text field that is slightly smaller than the frame. To adjust for this, we
inflate the paint rect.

Test: fast/forms/hidpi-textfield-background-bleeding.html

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintTextField):

LayoutTests:

Add a layout test to check that the background of a natively rendered text field
cell does not bleed.

* TestExpectations:
* fast/forms/hidpi-textfield-background-bleeding-expected.html: Added.
* fast/forms/hidpi-textfield-background-bleeding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/JavaScriptCore:
youenn.fablet@crf.canon.fr [Fri, 9 Oct 2015 14:21:58 +0000 (14:21 +0000)]
Source/JavaScriptCore:
Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

* generate-js-builtins: updating the part related to WebCore JS binding.

Source/WebCore:
Refactor WebCore JS builtins to prepare for automatic generation
https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names should be exported automatically.
Added WebCoreJSBuiltins.h to simplify handling of builtins in JSVMClientData.
Added WebCoreJSInternals.h to simplify handling of builtin private function in JSDOMWindowBase.
Renamed WebCoreJSClientData to JSVMClientData.

Covered by existing tests.

* CMakeLists.txt:
* Modules/streams/ByteLengthQueuingStrategy.js:
* Modules/streams/CountQueuingStrategy.js:
* Modules/streams/ReadableStream.js:
* Modules/streams/ReadableStreamController.js:
* Modules/streams/ReadableStreamInternals.js:
* Modules/streams/ReadableStreamReader.js:
* WebCore.order:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
(WebCore::JSDOMWindowBase::destroy): Deleted.
* bindings/js/JSDOMWindowBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
* bindings/js/WebCoreJSBuiltinInternals.h: Added.
(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions):
(WebCore::JSBuiltinInternalFunctions::readableStreamInternals):
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::init):
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSBuiltins.h: Added.
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::byteLengthQueuingStrategyBuiltins):
(WebCore::JSBuiltinFunctions::countQueuingStrategyBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamControllerBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamInternalsBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamReaderBuiltins):
* bindings/js/WebCoreJSClientData.h:
(WebCore::JSVMClientData::JSVMClientData):
(WebCore::JSVMClientData::~JSVMClientData):
(WebCore::JSVMClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::JSVMClientData::normalWorld): Deleted.
(WebCore::JSVMClientData::getAllWorlds): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRationalize JSXXConstructor class definition
youenn.fablet@crf.canon.fr [Fri, 9 Oct 2015 13:44:42 +0000 (13:44 +0000)]
Rationalize JSXXConstructor class definition
https://bugs.webkit.org/show_bug.cgi?id=149923

Reviewed by Darin Adler.

Declaration of JSXXConstructor::construct and JSXXConstructor::getConstructData
as long as JSXX is constructable from JavaScript.

Previously, JSXXConstructor::construct was not generated in case of CustomConstructor.
It is now generated and directly calls the custom constructor function.

getConstructData was declared conditionally with #if in case of ConstructorConditional.
The #if are now within getConstructData body.

Covered by binding tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateOverloadedConstructorDefinition):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
(GenerateConstructorDefinitions):.
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::construct):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):.
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::construct):
(WebCore::JSTestEventConstructorConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::JSTestInterfaceConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::construct):
(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::construct):
(WebCore::JSTestNodeConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
(WebCore::JSTestObjConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
(WebCore::JSTestOverloadedConstructorsConstructor::construct):
(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
(WebCore::JSTestTypedefsConstructor::getConstructData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[css-grid] Include freeSpace in GridSizingData struct
svillar@igalia.com [Fri, 9 Oct 2015 12:56:43 +0000 (12:56 +0000)]
[css-grid] Include freeSpace in GridSizingData struct
https://bugs.webkit.org/show_bug.cgi?id=149876

Reviewed by Darin Adler.

During the layout process we keep the free space for rows and
columns in two variables that are passed to a few methods
along with the GridSizingData struct. Those two variables
should clearly be part of GridSizingData as they're temporary
values used just for the sake of the layout.

No new tests required as this is just a refactoring.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::GridSizingData::freeSpaceForDirection):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::applyStretchAlignmentToTracksIfNeeded):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
* rendering/RenderGrid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[css-grid] Remove unneeded calls to compute(Content)LogicalWidth(Height)
svillar@igalia.com [Fri, 9 Oct 2015 12:47:47 +0000 (12:47 +0000)]
[css-grid] Remove unneeded calls to compute(Content)LogicalWidth(Height)
https://bugs.webkit.org/show_bug.cgi?id=149926

Reviewed by Darin Adler.

In order to resolve a Length to a LayoutUnit we need to
provide a maximum value so that i.e. percentages are correctly
computed. That maximum value was computeLogicalWidth() for
columns and computeContentLogicalHeight() for rows. We were
calling it for every single track with a definite size instead
of computing it once and reusing it multiple times.

This brings some nice performance improvements:
- 2.9%  in /Layout/fixed-grid-lots-of-data
- 2.95% in /Layout/fixed-grid-lots-of-stretched-data

No new tests required as there is no change in functionality.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeUsedBreadthOfMinLength):
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
* rendering/RenderGrid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix webkitpy tests after r190779
ossy@webkit.org [Fri, 9 Oct 2015 09:07:32 +0000 (09:07 +0000)]
Fix webkitpy tests after r190779
https://bugs.webkit.org/show_bug.cgi?id=149949

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults.format):
(BenchmarkResults._format_values):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CMake] Remove ENABLE_SUBPIXEL_LAYOUT macro
gyuyoung.kim@webkit.org [Fri, 9 Oct 2015 08:18:32 +0000 (08:18 +0000)]
[CMake] Remove ENABLE_SUBPIXEL_LAYOUT macro
https://bugs.webkit.org/show_bug.cgi?id=149947

Reviewed by Csaba Osztrogonác.

ENABLE(SUBPIXEL_LAYOUT) was removed though, it is still alive in .cmake.
Removed it.

* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Stack trace view doesn't properly display lines without function names
nvasilyev@apple.com [Fri, 9 Oct 2015 06:01:30 +0000 (06:01 +0000)]
Web Inspector: Stack trace view doesn't properly display lines without function names
https://bugs.webkit.org/show_bug.cgi?id=149922

Source/WebInspectorUI:

Reviewed by Timothy Hatcher.

* UserInterface/Models/StackTrace.js:
(WebInspector.StackTrace._parseStackTrace):
(WebInspector.StackTrace._parseLocation): Added.

LayoutTests:

Test an anomymous function.

Reviewed by Timothy Hatcher.

* inspector/debugger/js-stacktrace-expected.txt: Also, rebaseline one old test.
* inspector/debugger/js-stacktrace.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoExtend run-benchmark script to support human-readable results conversion.
dewei_zhu@apple.com [Fri, 9 Oct 2015 05:53:12 +0000 (05:53 +0000)]
Extend run-benchmark script to support human-readable results conversion.
https://bugs.webkit.org/show_bug.cgi?id=149944

Reviewed by Ryosuke Niwa.

Add '--read-results-json' and '--no-adjust-unit' options.
'--read-results-json' option converts result file to human readable format.
'--no-adjust-unit' option skips scientific notation convertion.
'--platform' defaults to 'osx' and '--browser' defaults to 'safari'.

* Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults.format):
(BenchmarkResults._format_tests):
(BenchmarkResults._format_values):
* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__):
(BenchmarkRunner._run_benchmark):
(BenchmarkRunner._dump):
(BenchmarkRunner.show_results):
(BenchmarkRunner._show_results): Deleted.
* Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(parse_args):
(start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agohttp/tests/media/media-source/SourceBuffer-abort-updating.html is flaky
bburg@apple.com [Fri, 9 Oct 2015 05:26:15 +0000 (05:26 +0000)]
http/tests/media/media-source/SourceBuffer-abort-updating.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149816

Unreviewed, fix updated expectation so it doesn't accidentally cause bots
to run the test on Mavericks (where Media Source is unsupported).

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd iOS 9 device builder to WebKit Bot Watcher's Dashboard
dbates@webkit.org [Fri, 9 Oct 2015 04:28:24 +0000 (04:28 +0000)]
Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=149945

Reviewed by Dan Bernstein.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.ios-9 img.logo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTeach build-webkit to install LLVM binaries for iOS when building for device with...
dbates@webkit.org [Fri, 9 Oct 2015 04:01:54 +0000 (04:01 +0000)]
Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=149943

Reviewed by Dan Bernstein.

Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
teach build-webkit to install them when building for iOS device using the public iOS SDK.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agopull-svn.py fails to sync revisions when SVN credentials is not setup
rniwa@webkit.org [Fri, 9 Oct 2015 01:13:26 +0000 (01:13 +0000)]
pull-svn.py fails to sync revisions when SVN credentials is not setup
https://bugs.webkit.org/show_bug.cgi?id=149941

Reviewed by Chris Dumez.

Added the support for specifying subversion credentials.

Also added the support for pulling from multiple subversion servers. Subversion servers are specified
in a JSON configuration file specified by --svn-config formatted as follows:

[
    {
        "name": "WebKit",
        "url": "http://svn.webkit.org/repository/webkit",
        "username": "webkitten",
        "password": "webkitten's password",
        "trustCertificate": true,
        "accountNameFinderScript":
            ["python", "/Volumes/Data/WebKit/Tools/Scripts/webkit-patch", "find-users"]
    },
    ...
]

In addition, refactored it to use the shared server config JSON for the dashboard access.

* tools/pull-svn.py:
(main): Now takes --svn-config-json, --server-config-json, --seconds-to-sleep and --max-fetch-count
as required options instead of seven unnamed arguments.
(fetch_commits_and_submit): Extracted from main. Fetches at most max_fetch_count new revisions from
the subversion server, and submits them in accordance with server_config.
(fetch_commit_and_resolve_author): Now takes a single repository dictionary instead of two separate
arguments for name and URL to pass down the repository's authentication info to fetch_commit.
(fetch_commit): Ditto. Add appropriate arguments when username and passwords are specified.
(resolve_author_name_from_account): Use a list argument instead of a single string argument now that
the argument comes from a JSON instead of sys.argv.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, build fix for ENABLE(MEDIA_SESSION) after r190030.
cdumez@apple.com [Fri, 9 Oct 2015 00:47:47 +0000 (00:47 +0000)]
Unreviewed, build fix for ENABLE(MEDIA_SESSION) after r190030.

* dom/Document.cpp:
(WebCore::Document::updateIsPlayingMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, build fixes for ENABLE(MEDIA_SESSION) after r190030.
cdumez@apple.com [Fri, 9 Oct 2015 00:31:03 +0000 (00:31 +0000)]
Unreviewed, build fixes for ENABLE(MEDIA_SESSION) after r190030.

* Modules/mediasession/HTMLMediaElementMediaSession.cpp:
(WebCore::HTMLMediaElementMediaSession::session):
* Modules/mediasession/HTMLMediaElementMediaSession.h:
* Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::controls):
* Modules/mediasession/MediaSession.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDFG SSA should remove unreachable code
fpizlo@apple.com [Fri, 9 Oct 2015 00:13:58 +0000 (00:13 +0000)]
DFG SSA should remove unreachable code
https://bugs.webkit.org/show_bug.cgi?id=149931

Reviewed by Geoffrey Garen.

Rolled back in with a call to m_state.reset(), which fixes the debug asserts.

* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run): Remove unreachable code.
* dfg/DFGObjectAllocationSinkingPhase.cpp: Deal with the CFG changing.
* dfg/DFGPutStackSinkingPhase.cpp: Deal with the CFG changing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGracefully handle XMLDocumentParser being detached by mutation events.
commit-queue@webkit.org [Thu, 8 Oct 2015 23:45:11 +0000 (23:45 +0000)]
Gracefully handle XMLDocumentParser being detached by mutation events.
https://bugs.webkit.org/show_bug.cgi?id=149485
<rdar://problem/22811489>

Source/WebCore:

This is a merge of Blink change 200026,
https://codereview.chromium.org/1267283002

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Test: fast/parser/xhtml-dom-character-data-modified-crash.html

* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::createLeafTextNode):
Renamed from enterText() to make it more descriptive.

(WebCore::XMLDocumentParser::updateLeafTextNode):
Renamed from exitText to firm up this stage.

(WebCore::XMLDocumentParser::end):
Gracefully handle stopped states.

(WebCore::XMLDocumentParser::enterText): Deleted.
(WebCore::XMLDocumentParser::exitText): Deleted.

* xml/parser/XMLDocumentParser.h:
Rename enterText to createLeafTextNode.
Rename exitText to updateLeafTextNode.

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::endDocument):
Rename function calls and firm up updateLeafTextNode stage accordingly.

LayoutTests:

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

* fast/parser/resources/xhtml-overwrite-frame.xhtml: Added.
* fast/parser/xhtml-dom-character-data-modified-crash-expected.txt: Added.
* fast/parser/xhtml-dom-character-data-modified-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd LLVM binaries for iOS 9 device
dbates@webkit.org [Thu, 8 Oct 2015 23:34:08 +0000 (23:34 +0000)]
Add LLVM binaries for iOS 9 device
https://bugs.webkit.org/show_bug.cgi?id=149913

Source/JavaScriptCore:

Reviewed by Filip Pizlo.

Look for locally built/binary dropped LLVM headers and libraries when building for iOS device
in WebKitBuild/usr/local.

Currently Mac and iOS look for the locally built/binary dropped LLVM in different directories:
WebKitBuild/usr/local and /usr/local/LLVMForJavaScriptCore, respectively. This difference is
due to dependencies with the Apple internal build system. We should look to resolve the
Apple internal dependencies and standardize on one location for both platforms.

* Configurations/Base.xcconfig:

Tools:

Reviewed by Filip Pizlo.

Implement support for building LLVM for ARM64-based iOS devices.

* Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
* Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
an existing build earlier in the file such that remove previously built
libraries before building/copying new ones (if applicable).
(fileContains): Moved function outside of if-block.
(isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
(buildLLVM): Added. Extracted machinery to build LLVM into this function and
added logic to build LLVM for ARM64-based iOS devices.
(symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
LLVM into the WebKitBuild directory.

WebKitLibraries:

Rubber-stamped by Filip Pizlo.

Add LLVM 3.6.2 binaries for ARM64-based iOS devices. We make use of LLVM for the FTL,
which is enabled for 64-bit iOS devices.

I built these binaries by performing the following:

1) Check out WebKit to a directory like /some/path/OpenSource.

2) Download and expand the archive <http://llvm.org/releases/3.6.2/llvm-3.6.2.src.tar.xz> into /some/path/OpenSource/llvm.

3) In /some/path/OpenSource, delete the WebKitBuild directory to ensure a clean build.

4) Run `Tools/Scripts/build-jsc --release --device ARCHS=arm64 ONLY_ACTIVE_ARCH=NO` to build both LLVM and JavaScriptCore.

5) Run `Tools/Scripts/export-llvm-build -i WebKitLibraries/LLVMIncludesIOSDevice9.tar.bz2 -l WebKitLibraries/LLVMLibrariesIOSDevice9.tar.bz2 -b llvm/wkLLVMBuild -B llvm/wkLLVMBuild/Release+Asserts -s llvm` to produce files LLVM{Includes, Libraries}IOS9.tar.bz2.

* LLVMIncludesIOS9.tar.bz2: Added.
* LLVMLibrariesIOS9.tar.bz2: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCleaning up after revision 190339
commit-queue@webkit.org [Thu, 8 Oct 2015 23:19:27 +0000 (23:19 +0000)]
Cleaning up after revision 190339
https://bugs.webkit.org/show_bug.cgi?id=149732

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Myles C. Maxfield.

* svg/custom/invalid-xslt-crash.svg:
* svg/custom/invalid-xslt-crash-expected.txt:
Replace render tree dump test with text dump.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190749.
commit-queue@webkit.org [Thu, 8 Oct 2015 23:14:34 +0000 (23:14 +0000)]
Unreviewed, rolling out r190749.
https://bugs.webkit.org/show_bug.cgi?id=149938

Caused 50+ layout test failures
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r190749%20(213)/results.html
(Requested by litherum1 on #webkit).

Reverted changeset:

"DFG SSA should remove unreachable code"
https://bugs.webkit.org/show_bug.cgi?id=149931
http://trac.webkit.org/changeset/190749

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agodata: URLs should not be preloaded
cdumez@apple.com [Thu, 8 Oct 2015 22:59:15 +0000 (22:59 +0000)]
data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Darin Adler.

Fix review comments after r190605:
Use protocolIs() instead of String::startsWith().

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRevert r187626 (and r188025) as it caused a PLT regression
cdumez@apple.com [Thu, 8 Oct 2015 22:53:51 +0000 (22:53 +0000)]
Revert r187626 (and r188025) as it caused a PLT regression
https://bugs.webkit.org/show_bug.cgi?id=149898
<rdar://problem/22657123>

Reviewed by Myles Maxfield.

* css/CSSPropertyNames.in:
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueWebkitLocale):
* platform/graphics/Font.cpp:
(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::FontDescriptionKey): Deleted.
(WebCore::FontDescriptionKey::computeHash): Deleted.
* platform/graphics/FontDescription.cpp:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::traitsMask): Deleted.
(WebCore::FontCascadeDescription::FontCascadeDescription): Deleted.
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::setScript):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::setFeatureSettings): Deleted.
(WebCore::FontCascadeDescription::initialVariantAlternates): Deleted.
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
* style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarking http/tests/media/media-source/SourceBuffer-abort-updating.html as flaky
commit-queue@webkit.org [Thu, 8 Oct 2015 22:53:16 +0000 (22:53 +0000)]
Marking http/tests/media/media-source/SourceBuffer-abort-updating.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=149816

Patch by Ryan Haddad <ryanhaddad@apple.com> on 2015-10-08
Reviewed by Darin Adler.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGenerated frame tree names should be kept reasonably long.
akling@apple.com [Thu, 8 Oct 2015 22:43:17 +0000 (22:43 +0000)]
Generated frame tree names should be kept reasonably long.
<https://webkit.org/b/149874>

Reviewed by Darin Adler.

Source/WebCore:

Some clumsy advertising script is going around assigning JavaScript source code
to the "name" attribute of iframes. This is causing WebKit to generate way too huge
names for anonymous descendants of such iframes.

Previously, the generated name of an anonymous subframe would be its slash-separated
path from the root frame, with the "name" attribute of each ancestor between the
slashes, or "<!--frame${index in parent}-->" for anonymous ancestors.

These ad scripts are often over 100kB in size, with multiple subframes, so we'd end
up with frame names looking like this:

"<!--framePath //<MONSTER BLOB OF JAVASCRIPT FROM HELL>/<!--frame0--><!--frame0-->-->"

While this is worth fixing for the memory usage alone, we've been making it way
worse by also using these paths when recording the back/forward history parts of
WebKit session state.

This patch makes generated paths always use index-in-parent as the "directory name"
for ancestors of anonymous subframes. The above example path will now instead be:

"<!--framePath //<!--frame0-->/<!--frame0-->/<!--frame0-->-->"

Test: fast/frames/long-names-in-nested-subframes.html

* page/FrameTree.cpp:
(WebCore::FrameTree::indexInParent):
(WebCore::FrameTree::uniqueChildName):
* page/FrameTree.h:

LayoutTests:

Added a test to document our name generation behavior for subframes with long-named ancestors.
Also rebaselined some tests that exposed the old behavior.

* fast/forms/form-and-frame-interaction-retains-values-expected.txt:
* fast/frames/long-names-in-nested-subframes-expected.txt: Added.
* fast/frames/long-names-in-nested-subframes.html: Added.
* http/tests/navigation/image-load-in-subframe-unload-handler-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
* http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-to-javscript-url-expected.txt:
* http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDFG SSA should remove unreachable code
fpizlo@apple.com [Thu, 8 Oct 2015 22:18:49 +0000 (22:18 +0000)]
DFG SSA should remove unreachable code
https://bugs.webkit.org/show_bug.cgi?id=149931

Reviewed by Geoffrey Garen.

* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run): Remove unreachable code.
* dfg/DFGObjectAllocationSinkingPhase.cpp: Deal with the CFG changing.
* dfg/DFGPutStackSinkingPhase.cpp: Deal with the CFG changing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190701.
cdumez@apple.com [Thu, 8 Oct 2015 22:00:46 +0000 (22:00 +0000)]
Unreviewed, rolling out r190701.
https://bugs.webkit.org/show_bug.cgi?id=149937

"It did not help, will try a full roll out instead" (Requested
by cdumez on #webkit).

Reverted changeset:

"Partial revert of r187626 as it caused a PLT regression"
https://bugs.webkit.org/show_bug.cgi?id=149898
http://trac.webkit.org/changeset/190701

Patch by Commit Queue <commit-queue@webkit.org> on 2015-10-08

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed build fix. Missing forward declaration.
joepeck@webkit.org [Thu, 8 Oct 2015 20:53:27 +0000 (20:53 +0000)]
Unreviewed build fix. Missing forward declaration.

* heap/Heap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed Cloop build fix after bug: https://bugs.webkit.org/show_bug.cgi?id=149601
sbarati@apple.com [Thu, 8 Oct 2015 20:24:25 +0000 (20:24 +0000)]
Unreviewed Cloop build fix after bug: https://bugs.webkit.org/show_bug.cgi?id=149601

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
* jit/JITCode.cpp:
(JSC::NativeJITCode::addressForCall):
(JSC::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
* jit/JITCode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoClean up Marked classes
joepeck@webkit.org [Thu, 8 Oct 2015 20:19:02 +0000 (20:19 +0000)]
Clean up Marked classes
https://bugs.webkit.org/show_bug.cgi?id=149853

Reviewed by Darin Adler.

Source/JavaScriptCore:

* heap/Heap.h:
Move include here where it is really needed.

* heap/HeapStatistics.cpp:
* heap/HeapStatistics.h:
Simplify includes.

* heap/MarkedAllocator.h:
Add missing copyright header.

* heap/MarkedBlock.cpp:
* heap/MarkedBlock.h:
(JSC::MarkedBlock::needsSweeping):
Remove unused constants. Add some static asserts. Add some `const` ness.

* heap/MarkedSpace.h:
(JSC::MarkedSpace::isIterating):
Update comments to better reflect actual values.
Remove unimplemented method (moved to Heap).

* heap/MarkedSpace.cpp:
(JSC::Free::Free):
(JSC::Free::operator()):
(JSC::Free::returnValue): Deleted.
(JSC::FreeOrShrink::FreeOrShrink):
(JSC::FreeOrShrink::operator()):
(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::shrink):
Replace conditional Functor that was not using return value
with simplified targeted VoidFunctors.

(JSC::Shrink::operator()): Deleted.
Remove unused functor.

* heap/WeakBlock.cpp:
* heap/WeakBlock.h:
* runtime/Options.cpp:
Remove dead code.

Source/WTF:

* wtf/PageBlock.h:
Remove duplicate using statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWe should be able to inline getter/setter calls inside an inline cache even when...
sbarati@apple.com [Thu, 8 Oct 2015 19:37:28 +0000 (19:37 +0000)]
We should be able to inline getter/setter calls inside an inline cache even when the SpillRegistersMode is NeedsToSpill
https://bugs.webkit.org/show_bug.cgi?id=149601

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Before, if we had a PolymorphicAccess with and a StructureStubInfo
with a NeedToSpill spillMode, we wouldn't generate getter/setter
calls. This patch changes it such that we will generate the
getter/setter call and do the necessary register spilling/filling
around the getter/setter call to preserve any "usedRegisters".

This has an interesting story with how it relates to exception handling
inside the DFG. Because the GetById variants are considered a throwing call
site, we must make sure that we properly restore the registers spilled to the stack
in case of an exception being thrown inside the getter/setter call. We do
this by having the inline cache register itself as a new exception handling
call site. When the inline cache "catches" the exception (i.e, genericUnwind
will jump to this code), it will restore the registers it spilled that are
live inside the original catch handler, and then jump to the original catch
handler. We make sure to only generate this makeshift catch handler when we
actually need to do any cleanup. If we determine that we don't need to restore
any registers, we don't bother generating this makeshift catch handler.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::handlerForIndex):
(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
(JSC::CodeBlock::removeExceptionHandlerForCallSite):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::appendExceptionHandler):
* bytecode/PolymorphicAccess.cpp:
(JSC::AccessGenerationState::AccessGenerationState):
(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::AccessGenerationState::preserveLiveRegistersToStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCallWithThrownException):
(JSC::AccessGenerationState::liveRegistersForCall):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandlingOrOriginal):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandling):
(JSC::AccessGenerationState::originalExceptionHandler):
(JSC::AccessGenerationState::numberOfStackBytesUsedForRegisterPreservation):
(JSC::AccessGenerationState::needsToRestoreRegistersIfException):
(JSC::AccessGenerationState::originalCallSiteIndex):
(JSC::AccessGenerationState::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::AccessCase::AccessCase):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerateWithCases):
(JSC::PolymorphicAccess::regenerate):
(JSC::PolymorphicAccess::aboutToDie):
* bytecode/PolymorphicAccess.h:
(JSC::AccessCase::doesCalls):
(JSC::AccessCase::isGetter):
(JSC::AccessCase::callLinkInfo):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::addAccessCase):
* bytecode/StructureStubInfo.h:
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::isInJSValueRegs):
(JSC::ValueRecovery::fpr):
* dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::addCodeOriginUnconditionally):
(JSC::DFG::CommonData::lastCallSite):
(JSC::DFG::CommonData::removeCallSiteIndex):
(JSC::DFG::CommonData::shrinkToFit):
* dfg/DFGCommonData.h:
* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
(JSC::DFG::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::DFG::JITCode::checkIfOptimizationThresholdReached):
* dfg/DFGJITCode.h:
(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::appendExceptionHandlingOSRExit):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
* dfg/DFGOSRExit.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
* ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::validateReferences):
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
* ftl/FTLJITCode.h:
(JSC::FTL::JITCode::handles):
(JSC::FTL::JITCode::dataSections):
* jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::~GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::observeZeroRefCount):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::markRequiredObjectsInternal):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::GCAwareJITStubRoutineWithExceptionHandler):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::aboutToDie):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::~GCAwareJITStubRoutineWithExceptionHandler):
(JSC::createJITStubRoutine):
* jit/GCAwareJITStubRoutine.h:
* jit/JITCode.cpp:
(JSC::NativeJITCode::addressForCall):
(JSC::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
* jit/JITCode.h:
* jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
* jit/JITInlineCacheGenerator.h:
(JSC::JITByIdGenerator::reportSlowPathCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
* jit/JITStubRoutine.h:
(JSC::JITStubRoutine::createSelfManagedRoutine):
(JSC::JITStubRoutine::aboutToDie):
* jit/RegisterSet.cpp:
(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
(JSC::RegisterSet::registersToNotSaveForCall):
(JSC::RegisterSet::allGPRs):
* jit/RegisterSet.h:
(JSC::RegisterSet::set):
(JSC::RegisterSet::clear):
* jit/ScratchRegisterAllocator.cpp:
(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::ScratchRegisterAllocator::usedRegistersForCall):
(JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBufferForCall):
(JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBufferForCall):
(JSC::ScratchRegisterAllocator::preserveRegistersToStackForCall):
(JSC::ScratchRegisterAllocator::restoreRegistersFromStackForCall):
* jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::numberOfReusedRegisters):
(JSC::ScratchRegisterAllocator::usedRegisters):
* jsc.cpp:
(WTF::CustomGetter::CustomGetter):
(WTF::CustomGetter::createStructure):
(WTF::CustomGetter::create):
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::Element::handleOwner):
(GlobalObject::finishCreation):
(functionCreateImpureGetter):
(functionCreateCustomGetterObject):
(functionSetImpureGetterDelegate):
* tests/stress/try-catch-custom-getter-as-get-by-id.js: Added.
(assert):
(bar):
(foo):
* tests/stress/try-catch-getter-as-get-by-id-register-restoration.js: Added.
(assert):
(o1.get f):
(bar):
(foo):
* tests/stress/try-catch-getter-as-get-by-id.js: Added.
(assert):
(o1.get f):
(bar):
(foo):
* tests/stress/try-catch-setter-as-put-by-id.js: Added.
(assert):
(o1.set f):
(bar):
(foo):
* tests/stress/try-catch-stub-routine-replaced.js: Added.
(assert):
(arr):
(hello):
(foo):
(objChain.get f):
(fakeOut.get f):
(o.get f):

LayoutTests:

* js/regress/custom-setter-getter-as-put-get-by-id-expected.txt: Added.
* js/regress/custom-setter-getter-as-put-get-by-id.html: Added.
* js/regress/script-tests/custom-setter-getter-as-put-get-by-id.js: Added.
(assert):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFallback to the RenderView when repaint container is null.
zalan@apple.com [Thu, 8 Oct 2015 18:46:20 +0000 (18:46 +0000)]
Fallback to the RenderView when repaint container is null.
https://bugs.webkit.org/show_bug.cgi?id=149903

Reviewed by Simon Fraser.

Reduces code complexity at the calling sites.

No change in functionality.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agofast/events/scroll-after-click-on-tab-index.html is flaky
ap@apple.com [Thu, 8 Oct 2015 17:44:18 +0000 (17:44 +0000)]
fast/events/scroll-after-click-on-tab-index.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149859

Reviewed by Simon Fraser.

* fast/events/scroll-after-click-on-tab-index-expected.txt:
* fast/events/scroll-after-click-on-tab-index.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd NULL check for renderBox::layer() on applying zoom level change
commit-queue@webkit.org [Thu, 8 Oct 2015 17:40:09 +0000 (17:40 +0000)]
Add NULL check for renderBox::layer() on applying zoom level change
https://bugs.webkit.org/show_bug.cgi?id=149302
<rdar://problem/22747292>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/zoom-on-nested-scroll-crash.html

This is a merge of Blink r158238:
https://chromiumcodereview.appspot.com/23526081

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):

LayoutTests:

* fast/css/zoom-on-nested-scroll-crash-expected.txt: Added.
* fast/css/zoom-on-nested-scroll-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate Inspector to only work with Legacy IDB (for now).
beidson@apple.com [Thu, 8 Oct 2015 17:35:25 +0000 (17:35 +0000)]
Update Inspector to only work with Legacy IDB (for now).
https://bugs.webkit.org/show_bug.cgi?id=149928.

Reviewed by Tim Horton.

* Modules/indexeddb/IDBAny.h:
(WebCore::IDBAny::isLegacy):

* Modules/indexeddb/legacy/LegacyAny.h:
* inspector/InspectorIndexedDBAgent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrash-only queues on bot watcher's dashboard should not have non-crashing tests in...
ap@apple.com [Thu, 8 Oct 2015 17:07:37 +0000 (17:07 +0000)]
Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
https://bugs.webkit.org/show_bug.cgi?id=149848

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarking fast/events/scroll-after-click-on-tab-index.html as flaky on Mac
commit-queue@webkit.org [Thu, 8 Oct 2015 16:32:16 +0000 (16:32 +0000)]
Marking fast/events/scroll-after-click-on-tab-index.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=149859

Patch by Ryan Haddad <ryanhaddad@apple.com> on 2015-10-08
Reviewed by Darin Adler.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrol...
antti@apple.com [Thu, 8 Oct 2015 16:26:40 +0000 (16:26 +0000)]
CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/use-window-inactive-crash.html

* css/SelectorCheckerTestFunctions.h:
(WebCore::isWindowInactive):

    Null check page.

LayoutTests:

The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.

* svg/css/use-window-inactive-crash-expected.html: Added.
* svg/css/use-window-inactive-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: An error view doesn't get expanded by clicking on the expand arrow
nvasilyev@apple.com [Thu, 8 Oct 2015 15:33:36 +0000 (15:33 +0000)]
Web Inspector: An error view doesn't get expanded by clicking on the expand arrow
https://bugs.webkit.org/show_bug.cgi?id=149917

Reviewed by Timothy Hatcher.

* UserInterface/Views/ErrorObjectView.css:
(.error-object > .formatted-error::before):
(.error-object.expanded > .formatted-error::before):
(.error-object::before): Deleted.
(.error-object.expanded::before): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFormat string issues in NetworkCache.cpp
mcatanzaro@igalia.com [Thu, 8 Oct 2015 15:29:47 +0000 (15:29 +0000)]
Format string issues in NetworkCache.cpp
https://bugs.webkit.org/show_bug.cgi?id=149867

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFormat string issues in LegacyRequest.cpp
mcatanzaro@igalia.com [Thu, 8 Oct 2015 15:27:36 +0000 (15:27 +0000)]
Format string issues in LegacyRequest.cpp
https://bugs.webkit.org/show_bug.cgi?id=149866

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* Modules/indexeddb/legacy/LegacyRequest.cpp:
(WebCore::LegacyRequest::dispatchEvent):
(WebCore::LegacyRequest::enqueueEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFormat string issue in WebResourceLoadScheduler.cpp
mcatanzaro@igalia.com [Thu, 8 Oct 2015 15:27:06 +0000 (15:27 +0000)]
Format string issue in WebResourceLoadScheduler.cpp
https://bugs.webkit.org/show_bug.cgi?id=149868

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190716.
commit-queue@webkit.org [Thu, 8 Oct 2015 15:23:24 +0000 (15:23 +0000)]
Unreviewed, rolling out r190716.
https://bugs.webkit.org/show_bug.cgi?id=149924

broke mac build from time to time (Requested by youenn on
#webkit).

Reverted changeset:

"Automate WebCore JS builtins generation and build system"
https://bugs.webkit.org/show_bug.cgi?id=149751
http://trac.webkit.org/changeset/190716

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the WASM build on Linux
ossy@webkit.org [Thu, 8 Oct 2015 15:20:52 +0000 (15:20 +0000)]
Fix the WASM build on Linux
https://bugs.webkit.org/show_bug.cgi?id=149919

Reviewed by Mark Lam.

* inspector/ScriptCallStackFactory.cpp:
* wasm/JSWASMModule.cpp:
* wasm/WASMFunctionCompiler.h:
(JSC::sizeOfMemoryType):
* wasm/WASMFunctionLLVMIRGenerator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[css-grid] Percentages of indefinite sizes to be resolved as auto
svillar@igalia.com [Thu, 8 Oct 2015 13:28:54 +0000 (13:28 +0000)]
[css-grid] Percentages of indefinite sizes to be resolved as auto
https://bugs.webkit.org/show_bug.cgi?id=149810

Reviewed by Darin Adler.

Specs mention that percentages in grid track sizes must be
resolved as 'auto' if the grid container has an indefinite
size in the corresponding axis.

The 'auto' keyword used to be resolved as
minmax(min-content,max-content) but since r189911 it's
resolved as minmax(auto,auto). Updated the implementation so
we properly resolve those percentages.

No new tests as the behavior does not change at all. That's
because 'auto' as min-track sizing function is the same as
min-content (unless we have a specified value for
min-{width|height}, but those cases were already handled in the
code), and as a max sizing function is works as max-content.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed CLOOP buildfix after r190718.
ossy@webkit.org [Thu, 8 Oct 2015 12:26:55 +0000 (12:26 +0000)]
Unreviewed CLOOP buildfix after r190718.

* jit/Repatch.h:
(JSC::resetGetByID): Deleted.
(JSC::resetPutByID): Deleted.
(JSC::resetIn): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove PageReservation.h clang fixme that has been fixed for a while
commit-queue@webkit.org [Thu, 8 Oct 2015 10:37:43 +0000 (10:37 +0000)]
Remove PageReservation.h clang fixme that has been fixed for a while
https://bugs.webkit.org/show_bug.cgi?id=149908

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-08
Reviewed by Csaba Osztrogonác.

* wtf/PageReservation.h:
(WTF::PageReservation::operator bool): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove references to removed class RepatchBuffer
commit-queue@webkit.org [Thu, 8 Oct 2015 10:33:04 +0000 (10:33 +0000)]
Remove references to removed class RepatchBuffer
https://bugs.webkit.org/show_bug.cgi?id=149909

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-08
Reviewed by Csaba Osztrogonác.

* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARM64.h:
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
* assembler/MacroAssemblerSH4.h:
* assembler/MacroAssemblerX86.h:
* assembler/MacroAssemblerX86_64.h:
* jit/JITStubRoutine.h:
* jit/Repatch.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Stop using a nested main loop for popup menus
carlosgc@webkit.org [Thu, 8 Oct 2015 10:06:41 +0000 (10:06 +0000)]
[GTK] Stop using a nested main loop for popup menus
https://bugs.webkit.org/show_bug.cgi?id=149920

Reviewed by Sergio Villar Senin.

Source/WebKit2:

WebPageProxy used to expect the popup menus to run in a nested
main loop and invalidated the menu right after showing it. But
this is no longer the case, so there's no reason to keep using
the nested main loop.

* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::cancelTracking):
(WebKit::WebPopupMenuProxyGtk::menuItemActivated):
(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk): Deleted.
(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Deleted.
(WebKit::WebPopupMenuProxyGtk::shutdownRunLoop): Deleted.
(WebKit::WebPopupMenuProxyGtk::menuUnmapped): Deleted.
* UIProcess/gtk/WebPopupMenuProxyGtk.h:
(WebKit::WebPopupMenuProxyGtk::setActiveItem): Deleted.

LayoutTests:

Unskip platform/gtk/fast/forms/menulist-typeahead-find.html that
was timing out because of the nested main loop.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAutomate WebCore JS builtins generation and build system
youenn.fablet@crf.canon.fr [Thu, 8 Oct 2015 09:55:30 +0000 (09:55 +0000)]
Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

Source/JavaScriptCore:

* generate-js-builtins: updating the part related to WebCore JS binding.

Source/WebCore:

Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names are exported automatically.
Added auto generation of WebCoreJSBuiltins.cpp
Added auto generation of JSBuiltinFunctions class inside WebCoreJSBuiltins that takes the role of
WebCoreJSClientData as wrapper for builtins.
Added auto generation of WebCoreJSBuiltinInternals.h which contain a wrapper around all private functions, used by
JSDOMWindowBase. The class is named JSBuiltinInternalFunctions.
Renamed WebCoreJSClientData to JSVMClientData.

The remaining manual part for private functions is the pairing between private identifiers and
the private JS functions within JSDOMWindowBase::finishCreation.

Covered by existing tests.

* CMakeLists.txt:
* DerivedSources.make:
* Modules/streams/ByteLengthQueuingStrategy.js:
* Modules/streams/CountQueuingStrategy.js:
* Modules/streams/ReadableStream.js:
* Modules/streams/ReadableStreamInternals.js:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
* bindings/js/WebCoreJSClientData.h:
(WebCore::JSClientData::JSClientData):
(WebCore::JSClientData::~JSClientData):
(WebCore::JSClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::readableStreamBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins): Deleted.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Deleted.
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins): Deleted.
* generate-js-builtins-allinone: Added.
(retrieveGenerationParameters):
(retrieveFilesWithParameters):
(retrieveFilesWithParameters.FileInput):
(writeConditional):
(JSBuiltinFunctions):
(Private):
(JSBuiltinInternalFunctions):
(copytempfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed GTK+ gardening. Mark several inspector tests as slow.
carlosgc@webkit.org [Thu, 8 Oct 2015 07:33:59 +0000 (07:33 +0000)]
Unreviewed GTK+ gardening. Mark several inspector tests as slow.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBinding generated JS constructors should use GlobalObject references
youenn.fablet@crf.canon.fr [Thu, 8 Oct 2015 07:30:23 +0000 (07:30 +0000)]
Binding generated JS constructors should use GlobalObject references
https://bugs.webkit.org/show_bug.cgi?id=149872

Reviewed by Darin Adler.

Updated binding generator to generate JS DOM constructors code with JSDOMGlobalOBject references.
Updated WebCore JS binding layer accordingly.

Covered by updated binding tests.

* bindings/js/DOMConstructorWithDocument.h:
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
(WebCore::DOMConstructorWithDocument::finishCreation):
* bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMStructure):
(WebCore::cacheDOMStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorJSBuiltinObject::DOMConstructorJSBuiltinObject):
(WebCore::getDOMStructure):
(WebCore::deprecatedGetDOMStructure):
(WebCore::getDOMPrototype):
(WebCore::createJSBuiltin):
(WebCore::createWrapper):
* bindings/js/JSDOMConstructor.h:
(WebCore::JSBuiltinConstructor::JSBuiltinConstructor):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::image):
(WebCore::JSDOMWindow::touch):
(WebCore::JSDOMWindow::touchList):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
(WebCore::JSImageConstructor::finishCreation):
* bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::create):
(WebCore::JSImageConstructor::createStructure):
* bindings/js/JSReadableStreamPrivateConstructors.cpp:
(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::createJSObject):
(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::createJSObject):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::createStructure):
(WebCore::JSTestActiveDOMObjectConstructor::JSTestActiveDOMObjectConstructor):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getConstructor):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::create):
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::createStructure):
(WebCore::JSTestCallbackConstructor::JSTestCallbackConstructor):
(WebCore::JSTestCallback::getConstructor):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::createStructure):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::JSTestCustomConstructorWithNoInterfaceObjectConstructor):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::create):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getConstructor):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetter::create):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::createStructure):
(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::create):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::createStructure):
(WebCore::JSTestEventTargetConstructor::JSTestEventTargetConstructor):
(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getConstructor):
* bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::createStructure):
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getConstructor):
* bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::create):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::createStructure):
(WebCore::JSTestGenerateIsReachableConstructor::JSTestGenerateIsReachableConstructor):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::getConstructor):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::JSTestGenerateIsReachable::create):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::createStructure):
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterfaceConstructor::finishCreation):
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getConstructor):
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::createStructure):
(WebCore::JSTestJSBuiltinConstructorConstructor::JSTestJSBuiltinConstructorConstructor):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor):
(WebCore::JSTestJSBuiltinConstructor::getConstructor):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
(WebCore::JSTestJSBuiltinConstructor::create):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::getConstructor):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::create):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::createStructure):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::createStructure):
(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::JSTestNamedConstructorNamedConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::JSTestNamedConstructor::getNamedConstructor):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::create):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::createStructure):
(WebCore::JSTestNodeConstructor::JSTestNodeConstructor):
(WebCore::JSTestNodeConstructor::finishCreation):
(WebCore::JSTestNode::JSTestNode):
(WebCore::JSTestNode::getConstructor):
* bindings/scripts/test/JS/JSTestNode.h:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::createStructure):
(WebCore::JSTestNondeterministicConstructor::JSTestNondeterministicConstructor):
(WebCore::JSTestNondeterministicConstructor::finishCreation):
(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::JSTestNondeterministic::getConstructor):
* bindings/scripts/test/JS/JSTestNondeterministic.h:
(WebCore::JSTestNondeterministic::create):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::createStructure):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getConstructor):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::create):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::createStructure):
(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::getConstructor):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::create):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::createStructure):
(WebCore::JSTestOverrideBuiltinsConstructor::JSTestOverrideBuiltinsConstructor):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getConstructor):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
(WebCore::JSTestOverrideBuiltins::create):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::create):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::createStructure):
(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):
(WebCore::JSTestTypedefsConstructor::finishCreation):
(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getConstructor):
* bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::create):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::createStructure):
(WebCore::JSattributeConstructor::JSattributeConstructor):
(WebCore::JSattributeConstructor::finishCreation):
(WebCore::JSattribute::JSattribute):
(WebCore::JSattribute::getConstructor):
* bindings/scripts/test/JS/JSattribute.h:
(WebCore::JSattribute::create):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::createStructure):
(WebCore::JSreadonlyConstructor::JSreadonlyConstructor):
(WebCore::JSreadonlyConstructor::finishCreation):
(WebCore::JSreadonly::JSreadonly):
(WebCore::JSreadonly::getConstructor):
* bindings/scripts/test/JS/JSreadonly.h:
(WebCore::JSreadonly::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebRTC: Add event names needed by updated RTCPeerConnection
commit-queue@webkit.org [Thu, 8 Oct 2015 07:21:41 +0000 (07:21 +0000)]
WebRTC: Add event names needed by updated RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=149875

Patch by Philippe Normand <pnormand@igalia.com> on 2015-10-08
Reviewed by Eric Carlson.

The track event name was recently added in the WebRTC spec. The
icegatheringstatechange event has been part of the spec for a while but
was not registered in our DOM events.

* dom/EventNames.h: Add track and icegatheringstatechange even names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190713 268f45cc-cd09-0410-ab3c-d52691b4dbfc