WebKit-https.git
7 years agoShare common code between calendar picker and color suggestion picker
keishi@webkit.org [Wed, 15 Aug 2012 03:34:14 +0000 (03:34 +0000)]
Share common code between calendar picker and color suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=93802

Reviewed by Kent Tamura.

.:

* ManualTests/forms/calendar-picker.html:
* ManualTests/forms/color-suggestion-picker.html:

Source/WebCore:

We want to share common code like utility functions between picker page popups.

No new tests because no behavior change. Covered by existing tests, color-suggestion-picker-appearance.html and calendar-picker-apeparance.html.

* Resources/pagepopups/calendarPicker.js:
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._showPopup):
* Resources/pagepopups/colorSuggestionPicker.js:
(handleMessage):
(handleArgumentsTimeout):
* Resources/pagepopups/pickerCommon.css: Added.
(body):
* Resources/pagepopups/pickerCommon.js: Added.
(createElement):
(resizeWindow):
(getScrollbarWidth):
* WebCore.gyp/WebCore.gyp: Add actions for pickerCommon.{css,js}
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::writeDocument):

Source/WebKit/chromium:

* src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::writeDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed. Add new test expectation for nested-rounded-corners.html.
yutak@chromium.org [Wed, 15 Aug 2012 03:24:55 +0000 (03:24 +0000)]
[Chromium] Unreviewed. Add new test expectation for nested-rounded-corners.html.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, build fix for !ENABLE(DFG_JIT)
fpizlo@apple.com [Wed, 15 Aug 2012 03:10:57 +0000 (03:10 +0000)]
Unreviewed, build fix for !ENABLE(DFG_JIT)

* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake...
mitz@apple.com [Wed, 15 Aug 2012 02:52:20 +0000 (02:52 +0000)]
fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=94045

Reviewed by Geoff Garen.

* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArray checks should use the structure, not the class info
fpizlo@apple.com [Wed, 15 Aug 2012 02:48:35 +0000 (02:48 +0000)]
Array checks should use the structure, not the class info
https://bugs.webkit.org/show_bug.cgi?id=93150

Reviewed by Mark Hahnenberg.

This changes all array checks used in array accesses (get, put, get length,
push, pop) to use the structure, not the class info. Additionally, these
checks in the LLInt and baseline JIT record the structure in an ArrayProfile,
so that the DFG can know exactly what structure to check for.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/ArrayProfile.cpp: Added.
(JSC):
(JSC::ArrayProfile::computeUpdatedPrediction):
* bytecode/ArrayProfile.h: Added.
(JSC):
(JSC::arrayModeFromStructure):
(ArrayProfile):
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::bytecodeOffset):
(JSC::ArrayProfile::addressOfLastSeenStructure):
(JSC::ArrayProfile::observeStructure):
(JSC::ArrayProfile::expectedStructure):
(JSC::ArrayProfile::structureIsPolymorphic):
(JSC::ArrayProfile::hasDefiniteStructure):
(JSC::ArrayProfile::observedArrayModes):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::getArrayProfile):
(JSC):
(JSC::CodeBlock::getOrAddArrayProfile):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::executionEntryCount):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addArrayProfile):
(CodeBlock):
* bytecode/Instruction.h:
(JSC):
(JSC::Instruction::Instruction):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetArgumentByVal):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitPutByVal):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
* dfg/DFGAbstractValue.h:
(JSC::DFG::StructureAbstractValue::hasSingleton):
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::singleton):
* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculateArray):
(DFG):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* llint/LLIntOffsetsExtractor.cpp:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/Structure.h:
(Structure):
(JSC::Structure::classInfoOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectation update. Address new flakiness
yutak@chromium.org [Wed, 15 Aug 2012 02:33:41 +0000 (02:33 +0000)]
[Chromium] Unreviewed test expectation update. Address new flakiness
and slow tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix access to m_markupBox in WebCore::EllipsisBox::paint
ojan@chromium.org [Wed, 15 Aug 2012 02:14:23 +0000 (02:14 +0000)]
Fix access to m_markupBox in WebCore::EllipsisBox::paint
https://bugs.webkit.org/show_bug.cgi?id=91138

Reviewed by Abhishek Arya.

Source/WebCore:

EllipsisBox would hold on to m_markupBox, which would then get destroyed during
the followup layoutIfNeeded in layoutVerticalBox. Instead, have EllipsisBox
dynamically grab to pointer to the markup box during paint since there's no
straightforward way to notify the EllipsisBox that the markupBox has been destroyed
and/or point it at the new markupBox.

Test: fast/overflow/line-clamp-and-columns.html

* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore):
(WebCore::EllipsisBox::paintMarkupBox):
* rendering/EllipsisBox.h:
(WebCore::EllipsisBox::EllipsisBox):
Just store a boolean that we have a markup box that needs painting.
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
Clearing the override size right after setting it was incorrect because
there are cases where we'll do a followup layout in layoutVerticalBox, at which
point we'll still need the override size.
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
Clear the override size here to handle cases where line clamp is removed since
we don't call applyLineClamp in those cases.

LayoutTests:

* fast/overflow/line-clamp-and-columns-expected.html: Added.
* fast/overflow/line-clamp-and-columns.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Make input type "time" to use multiple field time input UI
yosin@chromium.org [Wed, 15 Aug 2012 02:08:02 +0000 (02:08 +0000)]
[Forms] Make input type "time" to use multiple field time input UI
https://bugs.webkit.org/show_bug.cgi?id=93929

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes input type "time" UI to use multiple field time
input UI when build flag ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
enabled.

No new tests. This patch doesn't change behavior for users, however,
this patch changes behavior on layout tests. Tests will be added
in another patch with runtime enabled feature flag is enabled.

Test expectations for following tests are updated:
 - fast/forms/time/time-input-visible-string.html
 - fast/forms/time/time-stepup-stepdown-from-renderer.html

* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType): Exposed serialize() to derived classes.
* html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::DateTimeEditControlOwnerImpl):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::~DateTimeEditControlOwnerImpl):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlMouseFocus):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerDisabled):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerReadOnly):
(WebCore::TimeInputType::TimeInputType):
(WebCore::TimeInputType::~TimeInputType):
(WebCore::TimeInputType::createRenderer):
(WebCore::TimeInputType::createShadowSubtree):
(WebCore::TimeInputType::destroyShadowSubtree):
(WebCore::TimeInputType::forwardEvent):
(WebCore::TimeInputType::disabledAttributeChanged):
(WebCore::TimeInputType::handleKeydownEvent):
(WebCore::TimeInputType::handleDOMActivateEvent):
(WebCore::TimeInputType::isKeyboardFocusable):
(WebCore::TimeInputType::isMouseFocusable):
(WebCore::TimeInputType::minOrMaxAttributeChanged):
(WebCore::TimeInputType::readonlyAttributeChanged):
(WebCore::TimeInputType::isTextField):
(WebCore::TimeInputType::setValue):
(WebCore::TimeInputType::shouldUseInputMethod):
(WebCore::TimeInputType::stepAttributeChanged):
(WebCore::TimeInputType::updateEditElementLayout):
(WebCore::TimeInputType::updateInnerTextValue):
(WebCore::TimeInputType):
* html/TimeInputType.h:
(TimeInputType):
(DateTimeEditControlOwnerImpl):

LayoutTests:

This patch added test expectations for multiple fields time input UI
testing which are different behavior from single field time input UI
for Chromium which enables multiple fields time input UI.

* platform/chromium/fast/forms/time/time-input-visible-string-expected.txt: Select all in a field doesn't select text.
* platform/chromium/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Fields don't change value on Up/Down keyboard events when they don't have focus and Up/Down keyboard increment/decrement value on hour field rather than minute field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInitial call to webkitRequestAnimationFrame returns 0, Spec indicates the handle...
dino@apple.com [Wed, 15 Aug 2012 01:51:14 +0000 (01:51 +0000)]
Initial call to webkitRequestAnimationFrame returns 0, Spec indicates the handle should always be > 0
https://bugs.webkit.org/show_bug.cgi?id=85819

Reviewed by James Robinson.

Source/WebCore:

The callback id returned by requestAnimationFrame was beginning at zero, when the spec
says it should be above one. Use a pre-increment rather than a post-increment.

Test: fast/animation/request-animation-frame-callback-id.html

* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback): Pre-increment rather than post-increment.

LayoutTests:

* fast/animation/request-animation-frame-callback-id-expected.txt: Added.
* fast/animation/request-animation-frame-callback-id.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agor125591 broke tests with SUBPIXEL_LAYOUT disabled
leviw@chromium.org [Wed, 15 Aug 2012 01:39:20 +0000 (01:39 +0000)]
r125591 broke tests with SUBPIXEL_LAYOUT disabled
https://bugs.webkit.org/show_bug.cgi?id=94027

Reviewed by Eric Seidel.

The previous patch to fix block preferred widths for subpixel layout broke ports
without the flag enabled. This patch adds a static inline function --
adjustFloatForSubPixelLayout -- that truncates with sub-pixel layout disabled, and
ceil's to the nearest FractionalLayoutUnit when sub-pixel layout is enabled.

A block's max preferred width should be enough to layout the entire line without
wrapping. r125591 addressed a bug whereby converting floats to LayoutUnits with sub-
pixel layout enabled lost precision in certain cases, and could result in a line
being layed out to slightly over the max preferred width of the block.

This patch reverts the behavior when sub-pixel layout is disabled to truncating
sub-pixel values (such as those that originate in Length) when assigning them to
LayoutUnits, and ceiling the length of the entire line to the next largest integer.

Covered by existing tests.

* rendering/RenderBlock.cpp:
(WebCore):
(WebCore::adjustFloatForSubPixelLayout):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHandle the XPath / (root) operator correctly for nodes that aren't attached to the...
cevans@google.com [Wed, 15 Aug 2012 01:28:54 +0000 (01:28 +0000)]
Handle the XPath / (root) operator correctly for nodes that aren't attached to the document.
https://bugs.webkit.org/show_bug.cgi?id=36427

Reviewed by Abhishek Arya.

Source/WebCore:

We now behave the same as Firefox 14.
The consensus seems to be that the XPath spec is ambiguous for the case of detached nodes, and that using the fragment root is more intuitive than the document root for the case of detached nodes.
For example, http://www.w3.org/TR/xpath/ section 2 "Location Paths" is only clear for attached nodes: "A / by itself selects the root node of the document containing the context node. If it is followed by a relative location path, then the location path selects the set of nodes that would be selected by the relative location path relative to the root node of the document containing the context node."

Test: fast/xpath/xpath-detached-nodes.html

* xml/XPathPath.cpp:
(WebCore::XPath::LocationPath::evaluate): Jump to the root of the detached subtree instead of the parent document if the node isn't attached to the document.

LayoutTests:

* fast/xpath/xpath-detached-nodes-expected.txt: Added.
* fast/xpath/xpath-detached-nodes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders][Chromium] Filters area applied twice when CustomFilterOperation is...
achicu@adobe.com [Wed, 15 Aug 2012 01:21:47 +0000 (01:21 +0000)]
[CSS Shaders][Chromium] Filters area applied twice when CustomFilterOperation is in the list
https://bugs.webkit.org/show_bug.cgi?id=93900

Reviewed by James Robinson.

Source/WebCore:

Whenever the platform cannot render a shader in hardware it will fallback to software.
In such cases, the platform should remove any old filters applied, so that the filters do not apply twice.

Test: css3/filters/custom/filter-fallback-to-software.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setFilters):

LayoutTests:

Added a test that first applies a blur and then switches to a CSS Shader plus a blur.
The test was failing on Chromium by not removing the old blur filter from the platform layer.

* css3/filters/custom/filter-fallback-to-software-expected.html: Added.
* css3/filters/custom/filter-fallback-to-software.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Fix some typos in MiniBrowser
ap@apple.com [Wed, 15 Aug 2012 01:19:23 +0000 (01:19 +0000)]
[WK2] Fix some typos in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=94047

Reviewed by Jon Honeycutt.

* MiniBrowser/mac/AppDelegate.m:
(didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didReceiveMessage):
(WKBundleInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: add tracing to IDBLevelDBBackingStore
commit-queue@webkit.org [Wed, 15 Aug 2012 01:18:25 +0000 (01:18 +0000)]
IndexedDB: add tracing to IDBLevelDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=93914

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-14
Reviewed by Tony Chang.

Add a bunch of trace events to the lower level
database layer, to separate database slowness
from core IDB slowness.

Also moving findKeyInIndex into IDBLevelDBBackingStore to
eventually make it const.

No new tests, just adding debug logging.

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor EventDispatcher, moving code to make actual changes easier to review later.
hayato@chromium.org [Wed, 15 Aug 2012 00:56:02 +0000 (00:56 +0000)]
Refactor EventDispatcher, moving code to make actual changes easier to review later.
https://bugs.webkit.org/show_bug.cgi?id=93959

Reviewed by Dimitri Glazkov.

No new tests - no new functionality.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore):
(WebCore::EventDispatcher::dispatchSimulatedClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix warnings on Windows build
commit-queue@webkit.org [Wed, 15 Aug 2012 00:33:21 +0000 (00:33 +0000)]
[Chromium] Fix warnings on Windows build
https://bugs.webkit.org/show_bug.cgi?id=93997

Patch by Scott Graham <scottmg@chromium.org> on 2012-08-14
Reviewed by Kentaro Hara.

Fixes truncation from 'double' to 'float' warnings on Chromium Windows
build.

* tests/CCRenderSurfaceFiltersTest.cpp:
(WebKit::TEST):
* tests/CCScrollbarAnimationControllerLinearFadeTest.cpp:
(WebCore::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClear pattern to prevent timing problem between cancelVibration and vibrate
commit-queue@webkit.org [Wed, 15 Aug 2012 00:10:36 +0000 (00:10 +0000)]
Clear pattern to prevent timing problem between cancelVibration and vibrate
https://bugs.webkit.org/show_bug.cgi?id=93957

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-14
Reviewed by Kentaro Hara.

There is a timing issue in the cancelVibration.
Since vibrate works based on timer, cancelVibration might be called
eariler than vibrate when cancelVibration is called just after vibrate call.
It can be prevented from clearing m_pattern in the cancelVibration.

* Modules/vibration/Vibration.cpp:
(WebCore::Vibration::cancelVibration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago/SAFESEH should not be a common linker option
commit-queue@webkit.org [Tue, 14 Aug 2012 23:40:17 +0000 (23:40 +0000)]
/SAFESEH should not be a common linker option
https://bugs.webkit.org/show_bug.cgi?id=89372

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-14
Reviewed by Darin Adler.

* win/tools/vsprops/common.vsprops:
removed /SAFESEH as a default option for the linker (doesn't work for x64)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add baselines for video-controls-layer-creation layout test
enne@google.com [Tue, 14 Aug 2012 23:21:57 +0000 (23:21 +0000)]
[chromium] Add baselines for video-controls-layer-creation layout test

Unreviewed expectation update.

* compositing/video/video-controls-layer-creation-expected.txt: Added.
* platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png: Added.
* platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png: Added.
* platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement new synchronized audio I/O render method in chromium
crogers@google.com [Tue, 14 Aug 2012 23:17:08 +0000 (23:17 +0000)]
Implement new synchronized audio I/O render method in chromium
https://bugs.webkit.org/show_bug.cgi?id=93510

Reviewed by Kenneth Russell.

The chromium implementation of AudioDestination is being upgraded to
support synchronized audio I/O.  Other changes on the chromium-side
can then be tested against something that works in WebKit.

* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::render):
(WebCore):
(WebCore::AudioDestinationChromium::provideInput):
* src/AudioDestinationChromium.h:
(WebCore):
(AudioDestinationChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test css3/filters/custom/custom-filter-animation.html is failing
achicu@adobe.com [Tue, 14 Aug 2012 23:16:35 +0000 (23:16 +0000)]
Layout Test css3/filters/custom/custom-filter-animation.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91769

Reviewed by Dean Jackson.

Source/WebCore:

Mountain Lion added support for accelerated filter animations, but CSS Shaders are still
rendered in software mode. The setFilters method is using PlatformCALayer::filtersCanBeComposited to check
if the filters can be handled in hardwawre, so I've reused that in the createFilterAnimationsFromKeyframes
to check if the animations can also run in hardware.

Also the GraphicsContext3D doesn't update its own internal m_boundFBO when a framebuffer is deleted,
so I've added that to the FECustomFilter. Otherwise, if the next framebuffer is created using the same
identifier, bindFramebuffer will just return without calling the glBindFramebuffer because of this optimization.

The documentation for glDeleteFramebuffer says that the bound framebuffer is unbound before deleting it.
This is not reproduceable from WebGL, because WebGLRenderingContext::deleteFramebuffer
already knows to unbind the framebuffer when needed. However, I'm also adding that in GraphicsContext3DOpenGLCommon.cpp
and efl/GraphicsContext3DPrivate.cpp, to make sure that m_boundFBO is not used for other purposes.

No new tests, this patch fixes a failing test.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::deleteFramebuffer):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::deleteRenderBuffers):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::deleteFramebuffer):

LayoutTests:

The test should be passing on Mountain Lion now, so I'm removing it from the list.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelete Frame::domWindow() and Frame::existingDOMWindow()
abarth@webkit.org [Tue, 14 Aug 2012 22:34:01 +0000 (22:34 +0000)]
Delete Frame::domWindow() and Frame::existingDOMWindow()
https://bugs.webkit.org/show_bug.cgi?id=93990

Reviewed by Eric Seidel.

Source/WebCore:

These functions just call through to document()->domWindow(). This
patch updates the callers so it's clearer what's going on.

* bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore::printErrorMessageForFrame):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::JSDocument::setLocation):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWindowShell):
* bindings/objc/DOMAbstractView.mm:
(core):
* bindings/v8/NPV8Object.cpp:
(WebCore::toV8Context):
* bindings/v8/ScriptController.cpp:
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrieveFrame):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
(WebCore::V8Document::locationAccessorSetter):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
* dom/Document.cpp:
(WebCore::printNavigationErrorMessage):
* dom/ViewportArguments.cpp:
(WebCore::reportViewportWarning):
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
* editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::setComposition):
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::contentWindow):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::storageId):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::checkLoadComplete):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::FrameLoader::prepareForCachedPageRestore):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::fireBeforeUnloadEvent):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::isCurrentlyDisplayedInFrame):
(WebCore::DOMWindow::self):
(WebCore::DOMWindow::opener):
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):
* page/DOMWindowProperty.cpp:
(WebCore::DOMWindowProperty::DOMWindowProperty):
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
* page/DragController.cpp:
(WebCore::DragController::dispatchTextInputEventFor):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTextInputEvent):
* page/Frame.cpp:
* page/Frame.h:
(Frame):
* page/Location.cpp:
(WebCore::Location::replace):
(WebCore::Location::reload):
(WebCore::Location::setLocation):
* storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch):
* svg/SVGDocumentExtensions.cpp:
(WebCore::reportMessage):
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::parseString):
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::docLoaderFunc):
* xml/XSLTProcessorQt.cpp:
(WebCore::XSLTMessageHandler::handleMessage):

Source/WebKit/blackberry:

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::toOriginString):
(WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
(WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
(WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::requestWebGLPermission):

Source/WebKit/chromium:

* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):
* src/WebDOMMessageEvent.cpp:
(WebKit::WebDOMMessageEvent::initMessageEvent):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::performance):
(WebKit::WebFrameImpl::addMessageToConsole):
(WebKit::WebFrameImpl::unloadListenerCount):
(WebKit::WebFrameImpl::addEventListener):
(WebKit::WebFrameImpl::removeEventListener):
(WebKit::WebFrameImpl::dispatchEvent):
(WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck):
(WebKit::WebFrameImpl::deliverIntent):
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
* ewk/ewk_frame.cpp:
(ewk_frame_intent_deliver):

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getPendingUnloadEventCount):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _pendingFrameUnloadEventCount]):
(-[WebFrame _cacheabilityDictionary]):

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::DOMWindow):
(WebFrame::pendingFrameUnloadEventCount):

Source/WebKit2:

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::deliverIntent):
(WebKit::WebFrame::pendingUnloadCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTighten up parsing the 'script-nonce' CSP directive value.
commit-queue@webkit.org [Tue, 14 Aug 2012 22:27:08 +0000 (22:27 +0000)]
Tighten up parsing the 'script-nonce' CSP directive value.
https://bugs.webkit.org/show_bug.cgi?id=93783

Patch by Mike West <mkwst@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Source/WebCore:

Currently we're accepting any non-whitespace character. This patch
limits the valid characters to VCHAR minus ',' and ';', and pulls the
validity check out into a named function for clarity.

Test: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::parseScriptNonce):

LayoutTests:

* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelete DOMWindow::m_url
abarth@webkit.org [Tue, 14 Aug 2012 22:14:47 +0000 (22:14 +0000)]
Delete DOMWindow::m_url
https://bugs.webkit.org/show_bug.cgi?id=93989

Reviewed by Eric Seidel.

Source/WebCore:

There's no reason for DOMWindow to keep a separate copy of the
Document's URL now that there is a predictable way to get a Document
from a DOMWindow.

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):
* page/DOMWindow.h:
(DOMWindow):

LayoutTests:

The error messages for these tests now relect the document's updated
URL after document.write has changed the URL. Previously, we failed to
sync these changes to DOMWindow::m_url, which is why the error messages
showed the wrong URL.

* http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDe-inline stuff from RenderStyle.h
commit-queue@webkit.org [Tue, 14 Aug 2012 22:05:45 +0000 (22:05 +0000)]
De-inline stuff from RenderStyle.h
https://bugs.webkit.org/show_bug.cgi?id=94019

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-14
Reviewed by Eric Seidel.

De-inline things from RenderStyle.h in preparation of fixing a series of
errant includes.

No new tests. Doesn't change functionality

* WebCore.exp.in:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::listStyleImage):
(WebCore::RenderStyle::setListStyleImage):
(WebCore):
(WebCore::RenderStyle::color):
(WebCore::RenderStyle::visitedLinkColor):
(WebCore::RenderStyle::setColor):
(WebCore::RenderStyle::setVisitedLinkColor):
(WebCore::RenderStyle::horizontalBorderSpacing):
(WebCore::RenderStyle::verticalBorderSpacing):
(WebCore::RenderStyle::setHorizontalBorderSpacing):
(WebCore::RenderStyle::setVerticalBorderSpacing):
(WebCore::RenderStyle::font):
(WebCore::RenderStyle::fontMetrics):
(WebCore::RenderStyle::fontDescription):
(WebCore::RenderStyle::fontSize):
(WebCore::RenderStyle::wordSpacing):
(WebCore::RenderStyle::letterSpacing):
(WebCore::RenderStyle::setFontDescription):
(WebCore::RenderStyle::lineHeight):
(WebCore::RenderStyle::setLineHeight):
(WebCore::RenderStyle::computedLineHeight):
(WebCore::RenderStyle::setWordSpacing):
(WebCore::RenderStyle::setLetterSpacing):
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Checkerboard flashes on Go Back
commit-queue@webkit.org [Tue, 14 Aug 2012 22:02:19 +0000 (22:02 +0000)]
[BlackBerry] Checkerboard flashes on Go Back
https://bugs.webkit.org/show_bug.cgi?id=94018

Patch by Leo Yang <leoyang@rim.com> on 2012-08-14
Reviewed by Yong Li.
Reviewed internally by Yong Li.

The backing store need to be suspended before the
WebPagePrivate::restoreHistoryViewState() is called to avoid UI thread
drawing checkerboard.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions]Region overset property is incorectly computed when content has negative...
commit-queue@webkit.org [Tue, 14 Aug 2012 21:36:08 +0000 (21:36 +0000)]
[CSSRegions]Region overset property is incorectly computed when content has negative letter spacing and is flowed near to the edge of a region
https://bugs.webkit.org/show_bug.cgi?id=92506

Patch by Andrei Onea <onea@adobe.com> on 2012-08-14
Reviewed by Eric Seidel.

Source/WebCore:

When the content which is flowed inside a region creates visual overflow in
the writing direction, the overflow rect is also extended in the other direction, and
that forces regionOverset to become "fit" for all regions.

Tests: fast/regions/element-region-overset-state-negative-letter-spacing.html
       fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

LayoutTests:

Added tests for incorrect regionOverset computation when visual overflow in the writing direction creates
overset for all regions.

* fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Added.
* fast/regions/element-region-overset-state-negative-letter-spacing.html: Added.
* fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Added.
* fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove unnecessary \n's from InputHandler log messages.
mifenton@rim.com [Tue, 14 Aug 2012 21:35:06 +0000 (21:35 +0000)]
[BlackBerry] Remove unnecessary \n's from InputHandler log messages.
https://bugs.webkit.org/show_bug.cgi?id=94015

Reviewed by Rob Buis.

Remove many unnecessary \n's from the end of log messages.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setText):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agobeginElement() does not observe updated animation attributes
fmalita@chromium.org [Tue, 14 Aug 2012 21:33:56 +0000 (21:33 +0000)]
beginElement() does not observe updated animation attributes
https://bugs.webkit.org/show_bug.cgi?id=93972

Reviewed by Dirk Schulze.

Source/WebCore:

The SVG animation attributes 'from', 'to' and 'by' should be registered as supported
SVGSMILElement attributes in order to trigger animationAttributeChanged() on dynamic
updates.

Test: svg/animations/updated-attributes.html

* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::updateAnimation):
Minor optimization - avoid recalculating animationMode().

* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::isSupportedAttribute):
Register 'from', 'to' and 'by' as supported SVGSMILElement attributes.

LayoutTests:

* svg/animations/updated-attributes-expected.txt: Added.
* svg/animations/updated-attributes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents...
commit-queue@webkit.org [Tue, 14 Aug 2012 21:23:58 +0000 (21:23 +0000)]
Rebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents.html.
https://bugs.webkit.org/show_bug.cgi?id=93909

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-14
Reviewed by Tim Horton.

As per https://bugs.webkit.org/show_bug.cgi?id=92904 rebaselining those tests.

* compositing/overflow/clip-descendents-expected.txt: Rebaselined.
* platform/mac/TestExpectations: Removed tests from expectations list.
* platform/mac/fast/box-sizing/box-sizing-expected.txt: Rebaselined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Don't crash on OOM in AC
commit-queue@webkit.org [Tue, 14 Aug 2012 21:20:01 +0000 (21:20 +0000)]
[BlackBerry] Don't crash on OOM in AC
https://bugs.webkit.org/show_bug.cgi?id=93999

Patch by Filip Spacek <fspacek@rim.com> on 2012-08-14
Reviewed by George Staikos.

Internally reviewed by George Staikos.

Fail gracefully in case we fail to allocate the bitmap
for the AC layer contents.

* platform/graphics/blackberry/InstrumentedPlatformCanvas.h:
(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoold-run-webkit-tests should skip all file extensions for ref tests, not just .html.
commit-queue@webkit.org [Tue, 14 Aug 2012 21:16:08 +0000 (21:16 +0000)]
old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
https://bugs.webkit.org/show_bug.cgi?id=93904

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-14
Reviewed by Tim Horton.

old-run-webkit-tests ref test only skipped .html test.
They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.

* Scripts/old-run-webkit-tests:
(isUsedInReftest): Skip all extensions for ref tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert signals/slots to Q_* macros.
commit-queue@webkit.org [Tue, 14 Aug 2012 21:11:33 +0000 (21:11 +0000)]
Convert signals/slots to Q_* macros.

[Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
https://bugs.webkit.org/show_bug.cgi?id=93996

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Change usage of keyword-conflicting 'signals' and 'slots' for
Q_SIGNALS and Q_SLOTS macro.

Source/WebCore:

* bridge/testqtbindings.cpp:
(MyObject):
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
* platform/network/qt/DnsPrefetchHelper.h:
(DnsPrefetchHelper):
* platform/network/qt/NetworkStateNotifierPrivate.h:
(NetworkStateNotifierPrivate):
* platform/network/qt/QNetworkReplyHandler.h:
(QNetworkReplyHandler):
* platform/network/qt/QtMIMETypeSniffer.h:
(QtMIMETypeSniffer):
* platform/network/qt/SocketStreamHandlePrivate.h:
(SocketStreamHandlePrivate):
* platform/qt/GamepadsQt.cpp:
(GamepadDeviceLinuxQt):
(GamepadsQt):
* platform/qt/SharedTimerQt.cpp:
(SharedTimerQt):

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
* WebCoreSupport/FullScreenVideoQt.h:
(FullScreenVideoQt):
* WebCoreSupport/FullScreenVideoWidget.h:
(FullScreenVideoWidget):
* WebCoreSupport/IconDatabaseClientQt.h:
(IconDatabaseClientQt):
* WebCoreSupport/InspectorClientQt.cpp:
(InspectorClientWebPage):
* WebCoreSupport/InspectorServerQt.h:
(InspectorServerQt):
(InspectorServerRequestHandlerQt):
* WebCoreSupport/PopupMenuQt.h:
(PopupMenuQt):
* WebCoreSupport/QtFallbackWebPopup.h:
(QtFallbackWebPopup):
* docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:
(wrapInFunction):
* docs/webkitsnippets/webpage/main.cpp:
(Thumbnailer):
* examples/platformplugin/WebPlugin.h:
(Popup):
(WebPopup):
* tests/benchmarks/webgl/tst_webgl.cpp:
(tst_WebGlPerformance):
* tests/hybridPixmap/tst_hybridPixmap.cpp:
(tst_hybridPixmap):
* tests/hybridPixmap/widget.h:
(Widget):
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView):
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView):
(WebPage):
(ResizeSpy):
* tests/qobjectbridge/tst_qobjectbridge.cpp:
(MyWebElementSlotOnlyObject):
(tst_QObjectBridge):
(TestPluginWidget):
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement):
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame):
(FakeReply):
* tests/qwebhistory/tst_qwebhistory.cpp:
* tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:
(tst_QWebHistoryInterface):
* tests/qwebinspector/tst_qwebinspector.cpp:
(tst_QWebInspector):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(JSTestPage):
(RepaintRequestedRenderer):
(SpyForLoadSignalsOrder):
* tests/qwebplugindatabase/tst_qwebplugindatabase.cpp:
(tst_QWebPluginDatabase):
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView):
(WebViewCrashTest):

Source/WebKit2:

* UIProcess/API/qt/qwebkittest_p.h:
* UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp:
(tst_InspectorServer):
* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
(tst_publicapi):
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView):
* UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:
(WebView):
(tst_qrawwebview):
* UIProcess/API/qt/tests/util.cpp:
(LoadSpy):
* UIProcess/API/qt/tests/util.h:
(LoadStartedCatcher):
* UIProcess/InspectorServer/qt/WebSocketServerQt.h:
(QtTcpServerHandler):
* UIProcess/qt/QtDialogRunner.cpp:
(DialogContextBase):
(DialogContextObject):
(BaseAuthenticationContextObject):
(CertificateVerificationDialogContextObject):
(FilePickerContextObject):
(DatabaseQuotaDialogContextObject):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):
* WebProcess/Downloads/qt/QtFileDownloader.h:

Tools:

* DumpRenderTree/qt/DumpRenderTreeQt.h:
(NetworkAccessManager):
(WebPage):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender):
* DumpRenderTree/qt/GCControllerQt.h:
(GCController):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
* DumpRenderTree/qt/TextInputControllerQt.h:
(TextInputController):
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions):
* MiniBrowser/qt/UrlLoader.h:
(UrlLoader):
* QtTestBrowser/cookiejar.h:
(TestBrowserCookieJar):
* QtTestBrowser/fpstimer.h:
(FpsTimer):
* QtTestBrowser/launcherwindow.h:
(LauncherWindow):
* QtTestBrowser/locationedit.h:
(LocationEdit):
* QtTestBrowser/mainwindow.h:
(MainWindow):
* QtTestBrowser/urlloader.h:
(UrlLoader):
* QtTestBrowser/webinspector.h:
(WebInspector):
* QtTestBrowser/webpage.h:
(WebPage):
* QtTestBrowser/webview.h:
(WebViewGraphicsBased):
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
(WatchdogTimerHelper):
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WrapperWindow):
* WebKitTestRunner/qt/main.cpp:
(Launcher):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Track multiple Web Processes per context
ap@apple.com [Tue, 14 Aug 2012 21:06:41 +0000 (21:06 +0000)]
    [WK2] Track multiple Web Processes per context
        https://bugs.webkit.org/show_bug.cgi?id=93915

        Reviewed by Sam Weinig.

        * UIProcess/Downloads/DownloadProxy.cpp:
        (WebKit::DownloadProxy::didReceiveAuthenticationChallenge): Downloads don't work
        yet, added a FIXME.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::deprecatedSharedProcess): Renamed from process(), added an
        assertion that this is only used in single proces mode.
        (WebKit::WebContext::textCheckerStateChanged): Abstract out access to web processes.
        (WebKit::WebContext::ensureSharedWebProcess): Renamed ensureWebProcess() for clarity.
        (WebKit::WebContext::createNewWebProcess): Extracted code for creating a process
        from ensureWebProcess().
        (WebKit::WebContext::warmInitialProcess): Create the process more explicitly.
        (WebKit::WebContext::enableProcessTermination): Iterate over all processes.
        (WebKit::WebContext::shouldTerminate): Updated assertion.
        (WebKit::WebContext::processDidFinishLaunching): Changed to use process argument
        instead of m_process.
        (WebKit::WebContext::disconnectProcess): Updated code forto use m_processes.
        (WebKit::WebContext::createWebPage): Handle both process policies (initial support
        for multi-process).
        (WebKit::WebContext::relaunchProcessIfNecessary): Added cases for both policies.
        (WebKit::WebContext::download): Ditto.
        (WebKit::WebContext::postMessageToInjectedBundle): Ditto.
        (WebKit::WebContext::didReceiveSyncMessage): Fixed whitespace.
        (WebKit::WebContext::getWebCoreStatistics): Added cases for both policies.

        * UIProcess/WebContext.h:
        (WebKit::WebContext::sendToAllProcesses):
        (WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
        Send to all processes. Changed return type to void, since no caller checked it.

        * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createWebPage): Removed
        an assertion that assumed one process per context.

        * UIProcess/WebTextChecker.cpp: (WebKit::updateStateForAllWebProcesses): Updated
        to use a WebContext method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION r125500: 7 tests crashing on Mac bots
tsepez@chromium.org [Tue, 14 Aug 2012 21:02:24 +0000 (21:02 +0000)]
REGRESSION r125500: 7 tests crashing on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=93970

Reviewed by Eric Seidel.

Make WebFrameLoaderClient::redirectDataToPlugin expect the now real possibility
of a NULL pluginWidget argument.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::redirectDataToPlugin)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions]regionOverset is computed as "overset" even though the region is not...
commit-queue@webkit.org [Tue, 14 Aug 2012 20:53:09 +0000 (20:53 +0000)]
[CSSRegions]regionOverset is computed as "overset" even though the region is not the last in the chain
https://bugs.webkit.org/show_bug.cgi?id=93102

Patch by Andrei Onea <onea@adobe.com> on 2012-08-14
Reviewed by Eric Seidel.

Source/WebCore:

Making Element.webkitRegionOverset return "overset" only for the last region in a region chain,
if the content cannot fit inside it, to reflect current spec. http://www.w3.org/TR/css3-regions/#dom-region-regionoverset

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

LayoutTests:

Modified existing tests to reflect spec, where Element.webkitRegionOverset can be
"overset" only for the last region in a region chain, if the content cannot fit inside it.

* fast/regions/element-region-overset-state-expected.txt:
* fast/regions/element-region-overset-state-vertical-rl-expected.txt:
* fast/regions/element-region-overset-state-vertical-rl.html:
* fast/regions/element-region-overset-state.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Render breakpoint gutter markers and execution line in CodeMirrorTextE...
commit-queue@webkit.org [Tue, 14 Aug 2012 20:47:37 +0000 (20:47 +0000)]
Web Inspector: Render breakpoint gutter markers and execution line in CodeMirrorTextEditor
https://bugs.webkit.org/show_bug.cgi?id=93686

Patch by Jan Keromnes <janx@linux.com> on 2012-08-14
Reviewed by Pavel Feldman.

Divided TextEditor.addDecoration into addBreakpoint, setExecutionLine
and addDecoration. Same for removeDecoration. Render breakpoint
markers and execution line in CodeMirrorTextEditor.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._onGutterClick):
(WebInspector.CodeMirrorTextEditor.prototype.addBreakpoint):
(WebInspector.CodeMirrorTextEditor.prototype.removeBreakpoint):
(WebInspector.CodeMirrorTextEditor.prototype.setExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.removeAttribute):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._onMouseDown):
(WebInspector.DefaultTextEditor.prototype.addBreakpoint):
(WebInspector.DefaultTextEditor.prototype.removeBreakpoint):
(WebInspector.DefaultTextEditor.prototype.setExecutionLine):
(WebInspector.DefaultTextEditor.prototype.clearExecutionLine):
(WebInspector.DefaultTextEditor.prototype.addDecoration):
(WebInspector.DefaultTextEditor.prototype.removeDecoration):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.addBreakpoint):
(WebInspector.TextEditor.prototype.removeBreakpoint):
(WebInspector.TextEditor.prototype.setExecutionLine):
(WebInspector.TextEditor.prototype.clearExecutionLine):
(WebInspector.TextEditor.prototype.addDecoration):
(WebInspector.TextEditor.prototype.removeDecoration):
* inspector/front-end/cmdevtools.css:
(.CodeMirror):
(.cm-highlight):
(@-webkit-keyframes fadeout):
(to):
(.cm-breakpoint):
(.cm-breakpoint-disabled):
(.cm-breakpoint-conditional):
(.cm-execution-line):
(.webkit-html-message-bubble):
(.webkit-html-warning-message):
(.webkit-html-error-message):
(.webkit-html-message-line):
(.webkit-html-message-line-hover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Queue spellcheck requests with char-count limitations
commit-queue@webkit.org [Tue, 14 Aug 2012 20:45:10 +0000 (20:45 +0000)]
[BlackBerry] Queue spellcheck requests with char-count limitations
https://bugs.webkit.org/show_bug.cgi?id=93866

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-14
Reviewed by Rob Buis.

PR184196
Making spellcheck a little more granular so as to work around
the limitations of the inputservice.
Also, spellcheck the entire field on focus only if
spellcheck="on" is explicitly set.

Internally reviewed by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r109851): Video controls do not render
enne@google.com [Tue, 14 Aug 2012 20:44:35 +0000 (20:44 +0000)]
REGRESSION (r109851): Video controls do not render
https://bugs.webkit.org/show_bug.cgi?id=93859

Reviewed by Simon Fraser.

Source/WebCore:

Because video layers can't act as an ancestor composited layer whose
backing can be shared by child layers, any child layer of a video
layer needs to be put into its own composited layer. Because this is
technically overlap, the "overlap" indirect compositing reason is
reused for this case.

Test: compositing/video/video-controls-layer-creation.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

Convert jernoble's test into a layout test.

* compositing/video/video-controls-layer-creation.html: Added.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Test Expectations to consolidate bug refs for new tests added
robert@webkit.org [Tue, 14 Aug 2012 20:30:52 +0000 (20:30 +0000)]
Update Test Expectations to consolidate bug refs for new tests added
with r125578.

Unreviewed gardening.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark css2.1/20110323/c541-word-sp-000.htm as failing on Windows Chromium
enne@google.com [Tue, 14 Aug 2012 20:06:48 +0000 (20:06 +0000)]
[chromium] Mark css2.1/20110323/c541-word-sp-000.htm as failing on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=94017

Unreviewed gardening. Expectation update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Test Expectations after r125578
robert@webkit.org [Tue, 14 Aug 2012 20:02:05 +0000 (20:02 +0000)]
Update Test Expectations after r125578

       Unreviewed gardening.

       * platform/mac/TestExpectations:
       * platform/qt/TestExpectations:
       * platform/efl/TestExpectations:
       * platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
commit-queue@webkit.org [Tue, 14 Aug 2012 19:49:40 +0000 (19:49 +0000)]
WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
https://bugs.webkit.org/show_bug.cgi?id=42332

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Provide build for mac.

* WebCore.exp.in: Added __ZNK7WebCore19ResourceRequestBase20firstPartyForCookiesEv.

Source/WebKit2:

Added new getters to WKURL, WKURLRequest, WKURLResponse so that it is possible
to dump information necessary for the tests passing.

* Shared/API/c/WKURL.cpp:
(WKURLCopyPath):
* Shared/API/c/WKURL.h:
* Shared/API/c/WKURLRequest.cpp:
(WKURLRequestCopyFirstPartyForCookies):
(WKURLRequestCopyHTTPMethod):
* Shared/API/c/WKURLRequest.h:
* Shared/API/c/WKURLResponse.cpp:
(WKURLResponseHTTPStatusCode):
* Shared/API/c/WKURLResponse.h:
* Shared/WebURL.h:
(WebKit::WebURL::path):
(WebURL):

Tools:

Added Resource Callbacks logging. Several aux dumping functions are added.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::isFileScheme):
(WTR):
(WTR::pathSuitableForTestResult):
(WTR::urlSuitableForTestResult):
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::dumpErrorDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
(WTR::InjectedBundlePage::didFinishLoadForResource):
(WTR::InjectedBundlePage::didFailLoadForResource):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpResourceLoadCallbacks):
(WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
(LayoutTestController):

LayoutTests:

Unskipped correspondong test cases.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDOMWindow::document() should not reach through Frame
abarth@webkit.org [Tue, 14 Aug 2012 19:47:59 +0000 (19:47 +0000)]
DOMWindow::document() should not reach through Frame
https://bugs.webkit.org/show_bug.cgi?id=27640

Reviewed by Eric Seidel.

Source/WebCore:

Originally, the lifetime of DOMWindow was similar to that of Frame in
that it was reused for each document that was displayed in the Frame.
To fix some tricky security issues, all modern browsers use a "split
window" architecture whereby the DOMWindow is not reused by each
Document in a Frame. Instead a JavaScript "window shell" object
redirects JavaScript references to the active Document's DOMWindow.

When we implemented split windows, we left DOMWindow attached to the
Frame and attempted to keep it in sync with the Document via a lot of
delicate code. One of the main problems with this approach is that
finding the DOMWindow associated with a Document or the Document
associated with a DOMWindow required traversing through the Frame.
Because there is a many-to-one relationship between both Documents and
Frames (as well as DOMWindows and Frames), this traversal is error
prone and not always available (e.g., for inactive documents).

This patch moves the "owning" reference for DOMWindow to Document so
that we can directly traverse from Document to DOMWindow. For
traversing from DOMWindow to Document, each DOMWindow keeps a Document
pointer via a ContextDestructionObserver base class.

The main sublties in this patch are related to situations in which
there isn't precisely a one-to-one relationship between Documents and
DOMWindows. Previously, these situations were handled implicitly by the
"flex and slop" of having separate Document and DOMWindow pointers in
Frame. In this patch, these sublties are made explicit via
Document::takeDOMWindowFrom, which explicitly transfers the DOMWindow
(as well as ASSERTs that all the relevant objects exist in a sensible
constellation).

* WebCore.exp.in:
    - These functions are no longer exported because they're inline.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
* bindings/js/ScriptController.h:
(ScriptController):
    - clearWindowShell now explicitly takes the new DOMWindow that will
      be pointed to by the WindowShell. Previously, clearWindowShell
      would implicitly create the new DOMWindow by accessing
      Frame::domWindow (which used to lazily create the DOMWindow).
* bindings/v8/BindingState.cpp:
(WebCore::currentDocument):
* bindings/v8/BindingState.h:
(WebCore):
    - currentDocument provides a directly path from the current
      v8::Context to the Document (by way of DOMWindow). Previously,
      code transited via the Frame using currentFrame.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:
(ScriptController):
    - Mirror JSC changes to clearWindowShell.
* bindings/v8/V8Utilities.cpp:
(WebCore::getScriptExecutionContext):
    - Update getScriptExecutionContext to transit directly from the
      DOMWindow to the Document rather than detouring via the Frame.
* dom/ContextDestructionObserver.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore):
(WebCore::ContextDestructionObserver::observeContext):
* dom/ContextDestructionObserver.h:
(ContextDestructionObserver):
    - When we transfer a DOMWindow from one Document to another, we
      need to update the Document pointer in the DOMWindow to point to
      the new Document. The DOMWindow holds the Document pointer via
      ContextDestructionObserver, so this patch teaches
      ContextDestructionObserver how to change which
      ScriptExecutionContext it is observing. This code mirrors similar
      code in FrameDestructionObserver.
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::detach):
(WebCore::Document::createDOMWindow):
    - createDOMWindow now explicitly creates the DOMWindow. Previously,
      we created the DOMWindow implicitly in Frame::domWindow when it
      was first accessed.
(WebCore::Document::takeDOMWindowFrom):
    - takeDOMWindowFrom explicitly transfers the DOMWindow from one
      Document to another. The main benefit of this function is the
      ASSERTs that ensure that the Document, DOMWindow, and Frame all
      point to each other the correct configuration.
(WebCore::Document::didUpdateSecurityOrigin):
    - We no longer need to keep the SecurityOrigin pointer in DOMWindow
      in sync with the Document because DOMWindow no longer has a
      SecurityOrigin object.
* dom/Document.h:
(Document):
(WebCore::Document::domWindow):
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::destroy):
* history/CachedFrame.h:
(CachedFrameBase):
    - Previously, CachedFrame held the Document and the DOMWindow with
      separate pointers. Now, the CachedFrame holds the DOMWnidow via
      the Document, which makes adding and removing Documents from the
      PageCache simpler because we don't need to keep the Frame's
      DOMWindow pointer synchronized.
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
    - begin now explicitly creates the DOMWindow and transfers
      DOMWindow when performing a "secure transition." Previously, both
      of these processes were handled implicitly: the DOMWindow was
      created implicitly by Frame::domWindow, and the DOMWindow was
      reused during navigation by not clearing Frame::m_domWindow.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::cancelAndClear):
(WebCore::FrameLoader::clear):
    - These functions now pass the new Document so that we have access
      to the new DOMWindow in clearDOMWindowShell.
(WebCore::FrameLoader::setOpener):
    - We no longer need to keep the DOMWindow's SecurityOrigin in sync
      with the Document's SecurityOrigin because DOMWindow no longer
      has a duplicate SecurityOrigin pointer.
(WebCore::FrameLoader::open):
    - We no longer need to keep the Frame::m_domWindow in sync with the
      Document because the Document carries its own DOMWindow.
* loader/FrameLoader.h:
(FrameLoader):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
    - DOMWindow now uses Document as its primary context object. In a
      future patch, we should remove the FrameDestructionObserver base
      class and instead access the frame via DOMWindow::document().
(WebCore::DOMWindow::didSecureTransitionTo):
    - Notify the DOMWindow that it is now associated with a new
      Document.
(WebCore::DOMWindow::scriptExecutionContext):
(WebCore::DOMWindow::document):
(WebCore::DOMWindow::securityOrigin):
    - These functions now retrieve the Document directly rather than
      transiting via the Frame.
* page/DOMWindow.h:
(WebCore::DOMWindow::create):
(DOMWindow):
* page/Frame.cpp:
(WebCore::Frame::setDocument):
    - Add more ASSERTs that the Document and its DOMWindow are properly
      wired up to this Frame.
(WebCore::Frame::domWindow):
    - Rather than lazily creating the DOMWindow, this function now just
      accesses the already-created DOMWindow on Document. Eventually,
      all callers should retreive the DOMWindow from the Document
      directly.
* page/Frame.h:
(WebCore::Frame::existingDOMWindow):
    - The DOMWindow always exists, so there is no distinction between
      domWindow() and existingDOMWindow().
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
    - Previously, open would exit early if it was unable to find its
      ScriptExecutionContext (e.g., if the ScriptExecutionContext was
      inactive). Now we can always locate the ScriptExecutionContext
      and so we need to test whether the ScriptExecutionContext is
      still attached to the Page before accessing Settings. Tests
      verify that the platform-visible behaviors of XMLHttpRequest are
      unchanged, even for XMLHttpRequest constructors associated with
      inactive Documents.
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
    - Make it explicit that XSLT re-uses the DOMWindow from the source
      Document in the transformed Document.

LayoutTests:

* fast/dom/Window/timer-null-script-execution-context.html:
    - This test was assuming that we'd throw an exception when we
      failed to find the script execution context. Now that we are
      always able to find the script execution context, we never throw
      that exception, even after GC. As far as I can tell, the original
      intent of the test was to make sure we don't crash in that case,
      which of course we don't.
* fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt:
    - Remove warning message about not being able to find the script
      execution context. We can now always find the script execution
      context.
* http/tests/security/MessagePort/event-listener-context-expected.txt:
* http/tests/security/MessagePort/event-listener-context.html:
    - This test is attempting to check that MessagePorts behave in a
      reasonable way when created in inactive documents. The test
      relies on us throwing an exception in the inactive case because
      we're unable to find the script execution context. We are now
      able to find the script execution context (as above), so we no
      longer throw the exception. It's not clear whether this test is
      valuable any more, but I've converted it to be a test that we
      don't crash in this situation.
* platform/chromium/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
    - Remove platform-specific result as it now matches the cross-platform result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccumulating LayoutUnits with floats for determining block preferred width can lead...
leviw@chromium.org [Tue, 14 Aug 2012 19:45:49 +0000 (19:45 +0000)]
Accumulating LayoutUnits with floats for determining block preferred width can lead to wrapping
https://bugs.webkit.org/show_bug.cgi?id=93513

Reviewed by Eric Seidel.

Source/WebCore:

Sub-pixel values from floats are subject to small losses in precision when accumulated with
floating point values, as we do in RenderBlock. This patch adds a new method to FractionalLayoutUnit --
ceilToFloat -- which guarantees us a floating point value at least as big as our original LayoutUnit
value, and uses it along with ceiledLayoutUnit to avoid underprovisioning RenderBlock's preferred
widths due to lost precision.

Test: fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::ceilToFloat): Returns a float value the same or larger than the
FractionalLayoutUnit value.
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::epsilon): Now returns 0 when sub-pixel is disabled.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Adding a LayoutUnit::epsilon fudge factor
for fitting floats. This is probably necessary due to precision being lost elsewhere.
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths): Ensure no precision is lost due to conversion
when accumulating our min/max width with floats.

LayoutTests:

Ensuring floats with sub-pixel values don't unnecessarily wrap.

* fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt: Added.
* fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFullscreen/normal volume sliders don't stay in sync
jer.noble@apple.com [Tue, 14 Aug 2012 19:38:04 +0000 (19:38 +0000)]
Fullscreen/normal volume sliders don't stay in sync
https://bugs.webkit.org/show_bug.cgi?id=93867

Reviewed by Eric Carlson.

Source/WebCore:

Change the full screen volume slider, if present, when the media element's volume
changes.

Test: media/video-controls-fullscreen-volume.html

* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::changedVolume):

LayoutTests:

New test checking that volume changes in the media element are reflected in the full
screen volume slider.

* media/video-controls-fullscreen-volume-expected.txt: Added.
* media/video-controls-fullscreen-volume.html: Added.
* platform/chromium/TestExpectations: Skip this test on chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused yyparse method in CSSParser
commit-queue@webkit.org [Tue, 14 Aug 2012 19:17:39 +0000 (19:17 +0000)]
Remove unused yyparse method in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=93986

Patch by Olivier Blin <olivier.blin@softathome.com> on 2012-08-14
Reviewed by Darin Adler.

This method is unused and not even declared.

No new tests, it just removes unused code.

* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use Form helper functions to determine state in DOMSupport::isTextBasedC...
mifenton@rim.com [Tue, 14 Aug 2012 19:02:31 +0000 (19:02 +0000)]
[BlackBerry] Use Form helper functions to determine state in DOMSupport::isTextBasedContentEditableElement
https://bugs.webkit.org/show_bug.cgi?id=93992

Reviewed by Antonio Gomes.

Use form control helper functions to determine the editable state
of the input field.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark fast/regex/unicodeCaseInsensitive.html expectation as crashing
enne@google.com [Tue, 14 Aug 2012 18:54:32 +0000 (18:54 +0000)]
[chromium] Mark fast/regex/unicodeCaseInsensitive.html expectation as crashing
https://bugs.webkit.org/show_bug.cgi?id=94010

Unreviewed gardening. Update expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Test Expectations after r125578
robert@webkit.org [Tue, 14 Aug 2012 18:53:23 +0000 (18:53 +0000)]
Update Test Expectations after r125578

Unreviewed gardening.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/Skipped:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
mifenton@rim.com [Tue, 14 Aug 2012 18:28:03 +0000 (18:28 +0000)]
[BlackBerry] Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
https://bugs.webkit.org/show_bug.cgi?id=93988

Reviewed by Antonio Gomes.

Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix use of endsWith to use string instead of char.
mifenton@rim.com [Tue, 14 Aug 2012 18:23:55 +0000 (18:23 +0000)]
[BlackBerry] Fix use of endsWith to use string instead of char.
https://bugs.webkit.org/show_bug.cgi?id=93994

Reviewed by Antonio Gomes.

Regex comparison should use string instead of char comparison.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementPatternMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile...
zandobersek@gmail.com [Tue, 14 Aug 2012 17:58:19 +0000 (17:58 +0000)]
[Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile.list.am into the build
https://bugs.webkit.org/show_bug.cgi?id=90696

Reviewed by Philippe Normand.

Include all files in the Autotools build that are currently guarded by ENABLE_* guards in
the WebCore GNUmakefile.list.am, regardless of the feature being enabled. Compilation should
rely on proper use of guards inside source files and preprocessor work to keep the disabled
features out.

The only exception left is the ENABLE_WEBGL guard that includes the ANGLE into compilation
only if WebGL feature is enabled.

No new tests - no new functionality.

* GNUmakefile.am:
* GNUmakefile.list.am:
* bindings/gobject/GNUmakefile.am: Add StorageInfo to the DOM bindings, despite
the feature being currently disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark inspector/debugger tests as flaky timeout on Win7
enne@google.com [Tue, 14 Aug 2012 17:58:08 +0000 (17:58 +0000)]
[chromium] Mark inspector/debugger tests as flaky timeout on Win7
https://bugs.webkit.org/show_bug.cgi?id=94002

Unreviewed gardening. Update expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
commit-queue@webkit.org [Tue, 14 Aug 2012 17:55:03 +0000 (17:55 +0000)]
[chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
https://bugs.webkit.org/show_bug.cgi?id=93108

Patch by Iain Merrick <husky@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange,
and also serves to test WebFrameImpl::visiblePositionForWindowPoint as it is
used by selectRange.

The test uses sample files that contain selected text on load. The test uses
WebViewImpl::selectionBounds to get the coordinates, deselects all, then
calls WebFrameImpl::selectRange to attempt to reselect the same text.

Four cases are tested:
- the basic case
- the case where the selected text is offscreen due to a scroll
- the case where the selected text is in an iframe
- the case where the selected text is in an editable element

* tests/WebFrameTest.cpp:
* tests/data/select_range_basic.html: Added.
* tests/data/select_range_editable.html: Added.
* tests/data/select_range_iframe.html: Added.
* tests/data/select_range_scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlumb through EXT_debug_marker entry points
commit-queue@webkit.org [Tue, 14 Aug 2012 17:51:48 +0000 (17:51 +0000)]
Plumb through EXT_debug_marker entry points
https://bugs.webkit.org/show_bug.cgi?id=93860

Patch by Gregg Tavares <gman@google.com> on 2012-08-14
Reviewed by Kenneth Russell.

Source/Platform:

insertEventMarkerEXT, pushGroupMarkerEXT, popGroupMarkerEXT are
all entry points exposed by the OpenGL ES EXT_debug_marker
extension.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::insertEventMarkerEXT):
(WebKit::WebGraphicsContext3D::pushGroupMarkerEXT):
(WebKit::WebGraphicsContext3D::popGroupMarkerEXT):

Source/WebCore:

insertEventMarkerEXT, pushGroupMarkerEXT, popGroupMarkerEXT,
are all entry points exposed by the OpenGL ES
EXT_debug_marker extension

No new tests as no new functionality exposed to web.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
* platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DChromium::pushGroupMarkerEXT):
(WebCore::Extensions3DChromium::popGroupMarkerEXT):
* platform/graphics/Extensions3D.h:
(Extensions3D):
* platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DOpenGL::pushGroupMarkerEXT):
(WebCore::Extensions3DOpenGL::popGroupMarkerEXT):
* platform/graphics/opengl/Extensions3DOpenGL.h:
(Extensions3DOpenGL):
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DOpenGLES::pushGroupMarkerEXT):
(WebCore::Extensions3DOpenGLES::popGroupMarkerEXT):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
(Extensions3DOpenGLES):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: Word-spacing affects each space and non-breaking space
robert@webkit.org [Tue, 14 Aug 2012 17:36:45 +0000 (17:36 +0000)]
CSS 2.1 failure: Word-spacing affects each space and non-breaking space
https://bugs.webkit.org/show_bug.cgi?id=89826

Reviewed by Eric Seidel.

Source/WebCore:

Add word spacing to consecutive spaces in a run per http://www.w3.org/TR/CSS21/text.html#spacing-props.

Test: fast/css/word-spacing-characters.html
      fast/css/word-spacing-characters-complex-text.html
      fast/css/word-spacing-characters-linebreak.html
      css2.1/20110323/word-spacing-characters-002.htm
      css2.1/20110323/word-spacing-characters-003.htm
      css2.1/20110323/word-spacing-remove-space-001.htm
      css2.1/20110323/word-spacing-remove-space-002.htm
      css2.1/20110323/word-spacing-remove-space-003.htm
      css2.1/20110323/word-spacing-remove-space-004.htm
      css2.1/20110323/word-spacing-remove-space-005.htm
      css2.1/20110323/word-spacing-remove-space-006.htm
      css2.1/20110323/c541-word-sp-001.htm
      css2.1/20110323/c541-word-sp-000.htm

* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): All spaces (ordinary space or &nbsp;) get word-spacing added, even
  if they are consecutive.
* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use
  m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
  text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
  find it specified anywhere.
* platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html

LayoutTests:

* css2.1/20110323/c541-word-sp-000-expected.html: Added.
* css2.1/20110323/c541-word-sp-000.htm: Renamed from LayoutTests/css2.1/t1604-c541-word-sp-00-b-a.html.
* css2.1/20110323/c541-word-sp-001-expected.html: Added.
* css2.1/20110323/c541-word-sp-001.htm: Added.
  Replaces t1604-c541-word-sp-01-b-a.html below.
* css2.1/20110323/word-spacing-characters-002-expected.html: Added.
* css2.1/20110323/word-spacing-characters-002.htm: Added.
* css2.1/20110323/word-spacing-characters-003-expected.html: Added.
* css2.1/20110323/word-spacing-characters-003.htm: Added.
  These passed already.
* css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-001.htm: Added.
* css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-002.htm: Added.
* css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-003.htm: Added.
* css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-004.htm: Added.
* css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-005.htm: Added.
* css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-006.htm: Added.
  These 6 tests are fixed by this patch.
* css2.1/t1604-c541-word-sp-01-b-a.html: Removed.
  Per http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is
  now invalid and has been replaced by c541-word-sp-001.htm above.
* fast/css/word-spacing-characters-complex-text-expected.html: Added.
* fast/css/word-spacing-characters-complex-text.html: Added.
  This is a complex text version of word-spacing-characters-001.htm
* fast/css/word-spacing-characters-expected.html: Added.
* fast/css/word-spacing-characters.html: Added.
  The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case.
  This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced
  with word-spacing-characters-001.htm from the css test suite when https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
* fast/css/word-spacing-linebreak-expected.html: Added.
* fast/css/word-spacing-linebreak.html: Added.
* platform/chromium-linux/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/chromium-linux/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-linux/fast/css/word-space-extra-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/chromium-win/fast/css/word-space-extra-expected.txt:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/efl/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/gtk/TestExpectations:
* platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/qt/TestExpectations:
* platform/qt/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProx...
piman@chromium.org [Tue, 14 Aug 2012 17:25:55 +0000 (17:25 +0000)]
[chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProxy::beginFrameCompleteOnImplThread
https://bugs.webkit.org/show_bug.cgi?id=93684

Reviewed by James Robinson.

This keeps track of whether we're between the beginFrame post and the
commit when releaseContentsTextures comes, and if that is the case, we
prune the texture uploads, keep the "textures purged" flag on and kick a
new commit.

Added CCLayerTreeHostTestEvictTextures test.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::beginFramePosted):
(WebCore):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::contentsTexturesPurged):
(WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastBeginFrame):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::commitAndComposite):
* platform/graphics/chromium/cc/CCTextureUpdateController.h:
(CCTextureUpdateController):
* platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp:
(WebCore::CCTextureUpdateQueue::clearUploads):
(WebCore):
* platform/graphics/chromium/cc/CCTextureUpdateQueue.h:
(CCTextureUpdateQueue):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Pass URL String's 8-bit buffer directly to platform layer when possible
commit-queue@webkit.org [Tue, 14 Aug 2012 17:19:36 +0000 (17:19 +0000)]
[BlackBerry] Pass URL String's 8-bit buffer directly to platform layer when possible
https://bugs.webkit.org/show_bug.cgi?id=93861

Patch by Yong Li <yoli@rim.com> on 2012-08-14
Reviewed by Rob Buis.

PR# 187605.
URL strings and HTTP header strings usually use 8-bit buffers internally. We can
just pass the buffers to platform calls when only Latin1 strings are needed.

* platform/blackberry/ReadOnlyLatin1String.h: Added.
(WebCore):
(ReadOnlyLatin1String): A utility class that uses either WTF::CString or WTF::String's 8-bit buffer.
(WebCore::ReadOnlyLatin1String::ReadOnlyLatin1String): Can only be constructed with WTF::String for now.
(WebCore::ReadOnlyLatin1String::data):
(WebCore::ReadOnlyLatin1String::length):
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix LayoutTests/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html
commit-queue@webkit.org [Tue, 14 Aug 2012 17:16:19 +0000 (17:16 +0000)]
Fix  LayoutTests/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html
https://bugs.webkit.org/show_bug.cgi?id=92974

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Replace space characters by U+0020 SPACE characters in
CanvasRenderingContext2D::drawTextInternal() in order to
comply with the HTML Canvas 2D Context specification:
- http://www.w3.org/TR/2dcontext/#drawing-text-to-the-canvas

No new tests, already tested by canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::replaceCharacterInString):
(WebCore):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

Unskip canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html for
all the ports now that space characters are correctly replaced in
the text passed to fillText() and strokeText().

* platform/chromium/TestExpectations:
* platform/efl/Skipped:
* platform/gtk/TestExpectations:
* platform/mac/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Double-tap zoom on blocks on cnn.com desktop page doesn't work
zhajiang@rim.com [Tue, 14 Aug 2012 17:09:55 +0000 (17:09 +0000)]
[BlackBerry] Double-tap zoom on blocks on cnn.com desktop page doesn't work
https://bugs.webkit.org/show_bug.cgi?id=93895

Reviewed by Antonio Gomes.
Patch by Jacky Jiang  <zhajiang@rim.com>

PR: 188232
When adjusting block zoom node, don't choose a node if the width of the
node size is very close to the width of the actual visible size as
block zoom can do nothing on such kind of node. This condition is more
restrictive than the one based on area and can bail out early.
In this way, we can get a better node for double-tap zoom.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Change the call to setUserScalable to use the setting.
kpiascik@rim.com [Tue, 14 Aug 2012 17:01:37 +0000 (17:01 +0000)]
[BlackBerry] Change the call to setUserScalable to use the setting.
https://bugs.webkit.org/show_bug.cgi?id=93974

Reviewed by Rob Buis.

We should be using the WebSetting and not the current value of m_userScalable.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 14 Aug 2012 16:52:00 +0000 (16:52 +0000)]
Unreviewed GTK gardening.

Adding image failure expectation for fast/css-generated-content/quotes-lang.html.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, updated the GTK WK2 Skipped file with well-known
sergio@webkit.org [Tue, 14 Aug 2012 16:47:27 +0000 (16:47 +0000)]
Unreviewed, updated the GTK WK2 Skipped file with well-known
failures in the WK2 bot.

* platform/gtk-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Avoid assertion failure in App Cache.
staikos@webkit.org [Tue, 14 Aug 2012 16:36:02 +0000 (16:36 +0000)]
[BlackBerry] Avoid assertion failure in App Cache.
https://bugs.webkit.org/show_bug.cgi?id=93926

Reviewed by Rob Buis.

Short-circuit data url decoding if we know it's not a data URL to
avoid an assertion failure in debug mode.  No functional change.

No new tests since this is just a debug mode assertion failure.

* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Do not warn when the default theme is not found
commit-queue@webkit.org [Tue, 14 Aug 2012 16:12:17 +0000 (16:12 +0000)]
[EFL] Do not warn when the default theme is not found
https://bugs.webkit.org/show_bug.cgi?id=93968

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Even if you are using a custom theme, we always try to load first the
theme at the default path (that may or may not exist). In the case it
doesn't exist and you have a custom theme, we were always getting a
misleading error message.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::createEdje):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Pass cursor continue results back in callback
jsbell@chromium.org [Tue, 14 Aug 2012 16:06:43 +0000 (16:06 +0000)]
IndexedDB: Pass cursor continue results back in callback
https://bugs.webkit.org/show_bug.cgi?id=92278

Reviewed by Tony Chang.

Supply the updated cursor key/primaryKey/value in the success callback,
rather than forcing the callee to make three calls into the back end to
fetch them. Callbacks onSuccess(cursor) and onSuccessWithContinuation()
are given the three new payload parameters (and the latter is renamed.)

Source/WebCore:

No new tests - no behavioral changes.

* Modules/indexeddb/IDBCallbacks.h: Updated callbacks.
(IDBCallbacks):
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady): Takes values rather than fetching them.
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBCursorBackendImpl.cpp: Delete accessors.
(WebCore::IDBCursorBackendImpl::advanceInternal): Pass along updated cursor state.
(WebCore::IDBCursorBackendImpl::continueFunctionInternal): Ditto.
* Modules/indexeddb/IDBCursorBackendImpl.h:
(IDBCursorBackendImpl): Delete accessors from interface...
(WebCore::IDBCursorBackendImpl::key): ...but keep them for use within back-end.
(WebCore::IDBCursorBackendImpl::primaryKey):
(WebCore::IDBCursorBackendImpl::value):
* Modules/indexeddb/IDBCursorBackendInterface.h: Delete accessors.
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal): Pass along new cursor state.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal): Ditto.
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResultCursor): Stash updated cursor state until dispatch.
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent): Update cursor with new state.
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* inspector/InspectorIndexedDBAgent.cpp: Update iteration code to use new callbacks.
(WebCore):

Source/WebKit/chromium:

* public/WebIDBCallbacks.h:
(WebIDBCallbacks):
(WebKit::WebIDBCallbacks::onSuccess): Replace with no-op stub.
(WebKit::WebIDBCallbacks::onSuccessWithContinuation): Ditto.
* public/WebIDBCursor.h:
(WebIDBCursor): Methods can be removed once Chromium is cleaned up.
* src/IDBCallbacksProxy.cpp: Updated callbacks.
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit):
* src/IDBCallbacksProxy.h: Updated callbacks.
(IDBCallbacksProxy):
* src/IDBCursorBackendProxy.cpp: Remove back end accessors.
* src/IDBCursorBackendProxy.h:
(IDBCursorBackendProxy):
* src/WebIDBCallbacksImpl.cpp: Updated callbacks.
(WebKit::WebIDBCallbacksImpl::onSuccess):
* src/WebIDBCallbacksImpl.h: Updated callbacks.
(WebIDBCallbacksImpl):
* src/WebIDBCursorImpl.cpp: Remove back end accessors.
* src/WebIDBCursorImpl.h: Remove back end accessors.
(WebIDBCursorImpl):
* tests/IDBAbortOnCorruptTest.cpp: Update test stubs.
(WebCore::MockIDBCallbacks::onSuccess):
* tests/IDBDatabaseBackendTest.cpp: Ditto.
* tests/IDBRequestTest.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of failing tests and new passes
commit-queue@webkit.org [Tue, 14 Aug 2012 15:53:26 +0000 (15:53 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=93967

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14

* platform/efl/TestExpectations:
* platform/efl/fast/css-generated-content/quotes-lang-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline filter results after 125462
fmalita@chromium.org [Tue, 14 Aug 2012 15:48:19 +0000 (15:48 +0000)]
[Chromium] Rebaseline filter results after 125462
https://bugs.webkit.org/show_bug.cgi?id=93969

Unreviewed gardening.

* platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
* platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-expected.png: Removed.
* platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac/css3/filters/add-filter-rendering-expected.png:
* platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
* platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-expected.png:
* platform/chromium-mac/css3/filters/effect-contrast-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
* platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
* platform/chromium-mac/css3/filters/effect-invert-expected.png:
* platform/chromium-mac/css3/filters/effect-opacity-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-external-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
* platform/chromium-mac/css3/filters/effect-saturate-expected.png:
* platform/chromium-mac/css3/filters/effect-sepia-expected.png:
* platform/chromium-mac/css3/filters/filtered-inline-expected.png:
* platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
* platform/chromium-mac/css3/filters/nested-filters-expected.png:
* platform/chromium-mac/css3/filters/regions-expanding-expected.png:
* platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png:
* platform/chromium-mac/svg/filters/color-interpolation-filters-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png.
* platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
* platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-expected.png: Removed.
* platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
* platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-win/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-win/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-win/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
* platform/chromium-win/css3/filters/custom/filter-repaint-custom-expected.png:
* platform/chromium-win/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-expected.png:
* platform/chromium-win/svg/filters/color-interpolation-filters-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/efl/svg/filters/color-interpolation-filters-expected.txt: Removed.
* platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Removed.
* svg/filters/color-interpolation-filters-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/filters/color-interpolation-filters-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Some callback of Select onchange doesn't work
charles.wei@torchmobile.com.cn [Tue, 14 Aug 2012 15:09:08 +0000 (15:09 +0000)]
[BlackBerry] Some callback of Select onchange doesn't work
https://bugs.webkit.org/show_bug.cgi?id=93944

Reviewed by George Staikos.

The Selection element is implemented with PagePopup, an HTML-based WebView with
some Javascripts to make the UI of the select and option lists; The selection
change is initiated from the javascript code in the Select Webview, and back to
the native code of SelectPopupClient, which now in turn dispatches
FormControlChangeEvent to the select element directly, and that causes the
javascript callback been invoked in the same cycle as the javascript in the
Popup View, and causes some Javascript Context problem.

The solution is to send the FormControlChangeEvent asynchronously by a timer,
when the JavaScript in the Popup view finishes execution, we then send the
FormControlChangeEvent to the select element in the content page, that avoids
the concurrent Javascript context issue.

* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::SelectPopupClient):
(WebCore::SelectPopupClient::setValueAndClosePopup):
(WebCore):
(WebCore::SelectPopupClient::notifySelectionChange):
* WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate INdT build bot to Mountain Lion.
alexis.menard@openbossa.org [Tue, 14 Aug 2012 14:52:25 +0000 (14:52 +0000)]
Update INdT build bot to Mountain Lion.
https://bugs.webkit.org/show_bug.cgi?id=93963

Reviewed by Csaba Osztrogonác.

We updated the machine as well as the OS as the Qt port is now running
on top of Qt5.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Get rid of glCopyTexImage2D in Canvas and WebGL code paths
commit-queue@webkit.org [Tue, 14 Aug 2012 14:33:40 +0000 (14:33 +0000)]
[BlackBerry] Get rid of glCopyTexImage2D in Canvas and WebGL code paths
https://bugs.webkit.org/show_bug.cgi?id=93614

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Antonio Gomes.

We used to set up resource sharing between the compositing thread
context and the Canvas and WebGL contexts, and use glCopyTexImage2D to
get a copy of the framebuffer to use as front buffer for compositing
purposes.

Now we instead create an EGLImage and blit the Canvas/WebGL output to
it. The compositing thread creates a texture from the EGLImage in order
to composite the output.

Source/WebCore:

Created a new EGLImageLayerWebKitThread base class that handles the
EGLImage and does the blitting. CanvasLayerWebKitThread and
WebGLLayerWebKitThread now inherit from this new base class.

However, we need to be careful to restore state after the blit because
it's done using the Canvas/WebGL context.

The BlackBerry implementation of GraphicsContext3D::prepareTexture()
was changed to no longer call glCopyTexImage, and
GraphicsContext3D::platformLayer() now returns the target texture
directly.

Reviewed internally by Filip Spacek.

PR 188472

No change in behavior, new tests.

* PlatformBlackBerry.cmake:
* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setDevice):
(WebCore::CanvasLayerWebKitThread::makeContextCurrent):
(WebCore::CanvasLayerWebKitThread::textureSize):
(WebCore):
(WebCore::CanvasLayerWebKitThread::textureID):
* platform/graphics/blackberry/CanvasLayerWebKitThread.h:
(CanvasLayerWebKitThread):
* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp: Added.
(WebCore):
(WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
(WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
(WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
(WebCore::EGLImageLayerCompositingThreadClient::setImage):
* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h: Added.
(WebCore):
(EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::create):
(WebCore::EGLImageLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(WebCore::EGLImageLayerCompositingThreadClient::layerVisibilityChanged):
(WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):
* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::setNeedsDisplay):
(WebCore::EGLImageLayerWebKitThread::makeContextCurrent):
(WebCore::EGLImageLayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
(WebCore::EGLImageLayerWebKitThread::createImageIfNeeded):
(WebCore::EGLImageLayerWebKitThread::createShaderIfNeeded):
(WebCore::EGLImageLayerWebKitThread::drawTexture):
* platform/graphics/blackberry/EGLImageLayerWebKitThread.h: Copied from Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.h.
(WebCore):
(EGLImageLayerWebKitThread):
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::releaseTextureResources):
* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::setClient):
(LayerCompositingThread):
* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
(LayerData):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::commitPendingTextureUploads):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
* platform/graphics/blackberry/LayerWebKitThread.h:
(LayerWebKitThread):
* platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:
(WebCore::WebGLLayerWebKitThread::WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::WebGLLayerWebKitThread::makeContextCurrent):
(WebCore):
(WebCore::WebGLLayerWebKitThread::textureSize):
(WebCore::WebGLLayerWebKitThread::textureID):
* platform/graphics/blackberry/WebGLLayerWebKitThread.h:
(WebGLLayerWebKitThread):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore):
(WebCore::GraphicsContext3D::prepareTexture):

Source/WebKit/blackberry:

This allows us to turn off resource sharing, so the WebPageCompositor
no longer needs to pass the compositing thread context to the webkit
thread.

Reviewed internally by Filip Spacek.

PR 188472

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setCompositorHelper):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update expectation files for fast/forms/date/calendar-picker-appearance...
tkent@chromium.org [Tue, 14 Aug 2012 14:31:45 +0000 (14:31 +0000)]
[Chromium] Update expectation files for fast/forms/date/calendar-picker-appearance.html

* platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove unneeded build logic for Android
peter@chromium.org [Tue, 14 Aug 2012 14:26:14 +0000 (14:26 +0000)]
[Chromium] Remove unneeded build logic for Android
https://bugs.webkit.org/show_bug.cgi?id=93962

Reviewed by Dimitri Glazkov.

The Android SDK and NDK have been checked in to the Chromium tree, which
allows WebKit to leverage those as well. They will already be pulled in
through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
environment variable, the envsetup.sh will set the project files up
appropriately for us.

Source/WebKit/chromium:

* DEPS:

Tools:

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1...
commit-queue@webkit.org [Tue, 14 Aug 2012 14:05:48 +0000 (14:05 +0000)]
REGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93910

Unreviewed gardening.

Removed wrong and duplicated expectations. Mac port should use the
global expectations since this test is now passing.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14

* platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Removed.
* platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/mac/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Removed.
* platform/mac/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Tue, 14 Aug 2012 14:00:40 +0000 (14:00 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Texture cache must adapt to HashMap changes
commit-queue@webkit.org [Tue, 14 Aug 2012 13:53:14 +0000 (13:53 +0000)]
[BlackBerry] Texture cache must adapt to HashMap changes
https://bugs.webkit.org/show_bug.cgi?id=93955

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

This was fixed locally, but not upstreamed yet.

Based on an original patch by Konrad Piascik.

* platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureCacheCompositingThread::textureForTiledContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, Qt gardening
allan.jensen@nokia.com [Tue, 14 Aug 2012 13:37:50 +0000 (13:37 +0000)]
Unreviewed, Qt gardening

Unmark tests that has been passing since they were fixed generally in r125371.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening for Qt, rebaselining marked test from r125167.
allan.jensen@nokia.com [Tue, 14 Aug 2012 13:30:01 +0000 (13:30 +0000)]
Unreviewed gardening for Qt, rebaselining marked test from r125167.

Changelog and commit mixed with entry below.

* platform/qt/TestExpectations:
* platform/qt/fast/block/float/overhanging-tall-block-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening for Qt, rebaselining marked test from r125167.
allan.jensen@nokia.com [Tue, 14 Aug 2012 13:27:15 +0000 (13:27 +0000)]
Unreviewed gardening for Qt, rebaselining marked test from r125167.

* platform/qt/TestExpectations:
* platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] LayerCompositingThread.h doesn't compile
commit-queue@webkit.org [Tue, 14 Aug 2012 13:16:34 +0000 (13:16 +0000)]
[BlackBerry] LayerCompositingThread.h doesn't compile
https://bugs.webkit.org/show_bug.cgi?id=93956

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

I forgot to upstream this local change.

* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerOverride::setBounds):
(WebCore::LayerOverride::setOpacity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QNX build fails due to reference to MADV_FREE_REUSE and MADV_FREE_REUSABLE
commit-queue@webkit.org [Tue, 14 Aug 2012 12:52:56 +0000 (12:52 +0000)]
[Qt] QNX build fails due to reference to MADV_FREE_REUSE and MADV_FREE_REUSABLE
https://bugs.webkit.org/show_bug.cgi?id=93843

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-14
Reviewed by Simon Hausmann.

QNX does not implement MADV_FREE_REUSE nor MADV_FREE_REUSABLE.
The Blackberry port already sets the define to use the system
malloc, which is now also done for QNX in general.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] LayerAnimation is not immutable, which makes dereferencing an expensive...
commit-queue@webkit.org [Tue, 14 Aug 2012 12:39:17 +0000 (12:39 +0000)]
[BlackBerry] LayerAnimation is not immutable, which makes dereferencing an expensive operation
https://bugs.webkit.org/show_bug.cgi?id=93946

Patch by Ed Baker <edbaker@rim.com> on 2012-08-14
Reviewed by Antonio Gomes.

Make LayerAnimation immutable so it can be dereferenced from the main
WebKit thread without having to dispatch to the compositing thread,
which is an expensive operation.

TransformOperation and TimingFunction need to be made thread safe as
they are referenced in LayerAnimation, but that effort is being tracked
by a separate bug, #86483.

Reviewed internally by Arvid Nilsson.

No change in behavior, no new tests.

* platform/graphics/blackberry/LayerAnimation.h:
(WebCore::LayerAnimation::name):
(LayerAnimation):
(WebCore::LayerAnimation::LayerAnimation):
(WebCore::LayerAnimation::setName):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::~LayerWebKitThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] GraphicsLayerBlackBerry::willBeDestroyed() must call superclass implemen...
commit-queue@webkit.org [Tue, 14 Aug 2012 12:34:23 +0000 (12:34 +0000)]
[BlackBerry] GraphicsLayerBlackBerry::willBeDestroyed() must call superclass implementation
https://bugs.webkit.org/show_bug.cgi?id=93947

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

This was fixed locally, but not upstreamed yet.

Based on an original patch by Konrad Piascik.

* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::willBeDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove custom JSC bindings from ConvolverNode.idl
commit-queue@webkit.org [Tue, 14 Aug 2012 12:10:37 +0000 (12:10 +0000)]
Remove custom JSC bindings from ConvolverNode.idl
https://bugs.webkit.org/show_bug.cgi?id=93952

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-08-14
Reviewed by Kentaro Hara.

We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro.

No new tests. No behavioural changes.
All tests under webaudio/* should behave same.

* GNUmakefile.list.am: Removed JSConvolverNodeCustom.cpp from builds.
* Modules/webaudio/ConvolverNode.idl: Removed [JSCustomSetter].
* UseJSC.cmake: Removed JSConvolverNodeCustom.cpp from builds.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto
* bindings/js/JSConvolverNodeCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix failing tst_QWebPage::findText unit test
commit-queue@webkit.org [Tue, 14 Aug 2012 11:56:06 +0000 (11:56 +0000)]
[Qt] Fix failing tst_QWebPage::findText unit test
https://bugs.webkit.org/show_bug.cgi?id=93951

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Adjust the expected text, as the HTML editing code improved to avoid unnecessary tags.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::findText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add external test runner for running inspector front-end tests with...
pfeldman@chromium.org [Tue, 14 Aug 2012 11:52:00 +0000 (11:52 +0000)]
Web Inspector: add external test runner for running inspector front-end tests with no TestRunner infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=93833

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added mock test runner that allows running front-end layout tests.
InspectorFrontendAPI can now dispatch whatever it receives from its embedder (opener).

* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.evaluateForTest):
(InspectorFrontendAPI.dispatch):
(InspectorFrontendAPI.loadCompleted):
(.onMessageFromOpener):

LayoutTests:

* http/tests/inspector/inspector-test.js:
* http/tests/inspector/resources/test-runner.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Incomplete repaint of link underline
allan.jensen@nokia.com [Tue, 14 Aug 2012 11:47:30 +0000 (11:47 +0000)]
[Qt] Incomplete repaint of link underline
https://bugs.webkit.org/show_bug.cgi?id=66034

Reviewed by Kenneth Rohde Christiansen.

When trying to point a line of width 30, we end up painting on of width 31, because Qt
interprets the line as end-inclusive. So adjust for end-include/exclusive difference
before requesting the draw from Qt.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] [GTK] Plugin tests failing in WK2 bot
sergio@webkit.org [Tue, 14 Aug 2012 11:46:56 +0000 (11:46 +0000)]
[WK2] [GTK] Plugin tests failing in WK2 bot
https://bugs.webkit.org/show_bug.cgi?id=93954

Reviewed by Carlos Garcia Campos.

Plugin tests are failing in the WK2 bot because we aren't exporting
the Netscape plugin when creating the product archive.

* BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
to the list of directories to export.
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix test calendar-picker-appearance.html after r125507
keishi@webkit.org [Tue, 14 Aug 2012 11:43:44 +0000 (11:43 +0000)]
[Chromium] Fix test calendar-picker-appearance.html after r125507

Unreviewed.

* fast/forms/date/calendar-picker-appearance.html: Use resize event instead of transitionEnd.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QtWebKit linking fails for QNX cross build
commit-queue@webkit.org [Tue, 14 Aug 2012 11:42:04 +0000 (11:42 +0000)]
[Qt] QtWebKit linking fails for QNX cross build
https://bugs.webkit.org/show_bug.cgi?id=93460

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-14
Reviewed by Simon Hausmann.

The GCC 4.4.2 used by the QNX BBNDK 2.0.1 fails to link QtWebKit.
Apparently it does not properly support the linker invokation using
-Wl,-whole-archive -l... -Wl,-no-whole-archive
yielding a "cc: no files to process" error. This patch works around
this issue by adding an empty dummy file (and thus object file) to
the linking stage.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix crash in http/tests/plugins/plugin-document-has-focus
commit-queue@webkit.org [Tue, 14 Aug 2012 11:39:28 +0000 (11:39 +0000)]
Fix crash in http/tests/plugins/plugin-document-has-focus
https://bugs.webkit.org/show_bug.cgi?id=93949

Patch by Mike West <mkwst@chromium.org> on 2012-08-14
Reviewed by Jochen Eisinger.

Covered by http/tests/plugins/plugin-document-has-focus.html. If that
doesn't crash, we're good!

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::pluginIsLoadable):
    Check the PluginDocument's ownerElement before derefing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix apk generation for the Android platform
peter@chromium.org [Tue, 14 Aug 2012 11:32:46 +0000 (11:32 +0000)]
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841

Unreviewed build fix (step 2).

The path from webkit_unit_tests isn't robust enough. Use the same
convention as the Chromium side, i.e. walk up from the ant_build_out path.
One-line Android-only gyp change.

* WebKitUnitTests.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename functions in the ARM port of DFG-JIT for better code readability.
commit-queue@webkit.org [Tue, 14 Aug 2012 11:28:25 +0000 (11:28 +0000)]
Rename functions in the ARM port of DFG-JIT for better code readability.
https://bugs.webkit.org/show_bug.cgi?id=93609

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-14
Reviewed by Zoltan Herczeg.

Rename functions in the ARM port of DFG-JIT for better code
readability, and for following the WebKit coding style
wherever it is possible.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::genInt):
(JSC::ARMAssembler::getImm):
(JSC::ARMAssembler::moveImm):
(JSC::ARMAssembler::encodeComplexImm):
(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::dataTransfer16):
(JSC::ARMAssembler::baseIndexTransfer16):
(JSC::ARMAssembler::dataTransferFloat):
(JSC::ARMAssembler::baseIndexTransferFloat):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::bitAnd):
(JSC::ARMAssembler::bitAnds):
(JSC::ARMAssembler::eor):
(JSC::ARMAssembler::eors):
(JSC::ARMAssembler::sub):
(JSC::ARMAssembler::subs):
(JSC::ARMAssembler::rsb):
(JSC::ARMAssembler::rsbs):
(JSC::ARMAssembler::add):
(JSC::ARMAssembler::adds):
(JSC::ARMAssembler::adc):
(JSC::ARMAssembler::adcs):
(JSC::ARMAssembler::sbc):
(JSC::ARMAssembler::sbcs):
(JSC::ARMAssembler::rsc):
(JSC::ARMAssembler::rscs):
(JSC::ARMAssembler::tst):
(JSC::ARMAssembler::teq):
(JSC::ARMAssembler::cmp):
(JSC::ARMAssembler::cmn):
(JSC::ARMAssembler::orr):
(JSC::ARMAssembler::orrs):
(JSC::ARMAssembler::mov):
(JSC::ARMAssembler::movw):
(JSC::ARMAssembler::movt):
(JSC::ARMAssembler::movs):
(JSC::ARMAssembler::bic):
(JSC::ARMAssembler::bics):
(JSC::ARMAssembler::mvn):
(JSC::ARMAssembler::mvns):
(JSC::ARMAssembler::mul):
(JSC::ARMAssembler::muls):
(JSC::ARMAssembler::mull):
(JSC::ARMAssembler::vmov_f64):
(JSC::ARMAssembler::vadd_f64):
(JSC::ARMAssembler::vdiv_f64):
(JSC::ARMAssembler::vsub_f64):
(JSC::ARMAssembler::vmul_f64):
(JSC::ARMAssembler::vcmp_f64):
(JSC::ARMAssembler::vsqrt_f64):
(JSC::ARMAssembler::vabs_f64):
(JSC::ARMAssembler::vneg_f64):
(JSC::ARMAssembler::ldrImmediate):
(JSC::ARMAssembler::ldrUniqueImmediate):
(JSC::ARMAssembler::dtrUp):
(JSC::ARMAssembler::dtrUpRegister):
(JSC::ARMAssembler::dtrDown):
(JSC::ARMAssembler::dtrDownRegister):
(JSC::ARMAssembler::halfDtrUp):
(JSC::ARMAssembler::halfDtrUpRegister):
(JSC::ARMAssembler::halfDtrDown):
(JSC::ARMAssembler::halfDtrDownRegister):
(JSC::ARMAssembler::doubleDtrUp):
(JSC::ARMAssembler::doubleDtrDown):
(JSC::ARMAssembler::push):
(JSC::ARMAssembler::pop):
(JSC::ARMAssembler::poke):
(JSC::ARMAssembler::peek):
(JSC::ARMAssembler::vmov_vfp64):
(JSC::ARMAssembler::vmov_arm64):
(JSC::ARMAssembler::vmov_vfp32):
(JSC::ARMAssembler::vmov_arm32):
(JSC::ARMAssembler::vcvt_f64_s32):
(JSC::ARMAssembler::vcvt_s32_f64):
(JSC::ARMAssembler::vcvt_u32_f64):
(JSC::ARMAssembler::vcvt_f64_f32):
(JSC::ARMAssembler::vcvt_f32_f64):
(JSC::ARMAssembler::clz):
(JSC::ARMAssembler::lslRegister):
(JSC::ARMAssembler::lsrRegister):
(JSC::ARMAssembler::asrRegister):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::vmov):
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::or32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::countLeadingZeros32):
(JSC::MacroAssemblerARM::convertibleLoadPtr):
(JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::pop):
(JSC::MacroAssemblerARM::push):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::mull32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::load32):
(JSC::MacroAssemblerARM::relativeTableJump):
(JSC::MacroAssemblerARM::moveWithPatch):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::moveDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::absDouble):
(JSC::MacroAssemblerARM::negateDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::convertFloatToDouble):
(JSC::MacroAssemblerARM::convertDoubleToFloat):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerARM::truncateDoubleToInt32):
(JSC::MacroAssemblerARM::truncateDoubleToUint32):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] UpdateAtlas is wasting memory
allan.jensen@nokia.com [Tue, 14 Aug 2012 11:22:06 +0000 (11:22 +0000)]
[Qt] UpdateAtlas is wasting memory
https://bugs.webkit.org/show_bug.cgi?id=93606

Reviewed by Jocelyn Turcotte.

Imported and QAreaAllocator from Qt3D and ported it to WebCore style,
and use this new area allocator to replace old one from UpdateAtlas.

* CMakeLists.txt:
* Target.pri:
* WebProcess/WebPage/AreaAllocator.cpp: Added.
(WebKit::AreaAllocator::AreaAllocator):
(WebKit::AreaAllocator::~AreaAllocator):
(WebKit::AreaAllocator::expand):
(WebKit::AreaAllocator::expandBy):
(WebKit::AreaAllocator::release):
(WebKit::AreaAllocator::overhead):
(WebKit::AreaAllocator::roundAllocation):
(WebKit::GeneralAreaAllocator::GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::freeNode):
(WebKit::GeneralAreaAllocator::expand):
(WebKit::fitsWithin):
(WebKit::GeneralAreaAllocator::allocate):
(WebKit::GeneralAreaAllocator::allocateFromNode):
(WebKit::GeneralAreaAllocator::splitNode):
(WebKit::GeneralAreaAllocator::updateLargestFree):
(WebKit::GeneralAreaAllocator::release):
(WebKit::GeneralAreaAllocator::overhead):
* WebProcess/WebPage/AreaAllocator.h: Added.
(WebCore::nextPowerOfTwo):
(AreaAllocator):
(WebKit::AreaAllocator::size):
(WebKit::AreaAllocator::minimumAllocation):
(WebKit::AreaAllocator::setMinimumAllocation):
(WebKit::AreaAllocator::margin):
(WebKit::AreaAllocator::setMargin):
(GeneralAreaAllocator):
(Node):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::renderNextFrame):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(UpdateAtlas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove duplicated platform test expectations
ossy@webkit.org [Tue, 14 Aug 2012 11:14:55 +0000 (11:14 +0000)]
[Qt] Remove duplicated platform test expectations
https://bugs.webkit.org/show_bug.cgi?id=93351

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-10
Reviewed by Csaba Osztrogonác.

Remove platform test expectations that are the same as the global
expectations.

* platform/qt-5.0-wk2/compositing/iframes/fixed-position-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/invisible-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/nested-composited-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/remove-iframe-crash-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/scroll-grandchild-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/reflections/become-simple-composited-reflection-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/reflections/empty-reflection-with-mask-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/reflections/remove-add-reflection-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/reflections/remove-reflection-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-relative-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Removed.
* platform/qt-5.0-wk2/plugins/document-open-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceMotion/no-page-cache-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceMotion/optional-event-properties-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceMotion/window-property-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceOrientation/no-page-cache-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceOrientation/optional-event-properties-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceOrientation/window-property-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
* platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
* platform/qt-mac/plugins/plugin-javascript-access-expected.txt: Removed.
* platform/qt/compositing/geometry/composited-in-columns-expected.txt: Removed.
* platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/qt/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
* platform/qt/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
* platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt: Removed.
* platform/qt/editing/pasteboard/4242293-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
* platform/qt/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
* platform/qt/editing/selection/hit-test-on-text-with-line-height-expected.txt: Removed.
* platform/qt/fast/backgrounds/svg-as-mask-expected.txt: Removed.
* platform/qt/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusSolid01-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusSolid02-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusSolid03-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusSolid04-expected.txt: Removed.
* platform/qt/fast/box-shadow/box-shadow-radius-expected.txt: Removed.
* platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt: Removed.
* platform/qt/fast/css/font-face-descending-unicode-range-expected.txt: Removed.
* platform/qt/fast/css/font-face-font-family-descriptor-expected.txt: Removed.
* platform/qt/fast/css/font-family-pictograph-expected.txt: Removed.
* platform/qt/fast/css/hsla-color-expected.txt: Removed.
* platform/qt/fast/css/rgba-custom-text-expected.txt: Removed.
* platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
* platform/qt/fast/dom/icon-url-change-expected.txt: Removed.
* platform/qt/fast/dom/icon-url-list-expected.txt: Removed.
* platform/qt/fast/inline/inline-fixed-position-boundingbox-expected.txt: Removed.
* platform/qt/fast/inline/inline-relative-offset-boundingbox-expected.txt: Removed.
* platform/qt/fast/multicol/hit-test-gap-between-pages-expected.txt: Removed.
* platform/qt/fast/reflections/reflection-masks-expected.txt: Removed.
* platform/qt/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
* platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt: Removed.
* platform/qt/fast/writing-mode/background-horizontal-bt-expected.txt: Removed.
* platform/qt/fast/writing-mode/background-vertical-lr-expected.txt: Removed.
* platform/qt/fast/writing-mode/background-vertical-rl-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
* platform/qt/svg/custom/bug86119-expected.txt: Removed.
* platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
* platform/qt/svg/custom/svg-features-expected.txt: Removed.
* platform/qt/svg/custom/use-instanceRoot-event-listeners-expected.txt: Removed.
* platform/qt/svg/custom/use-setAttribute-crash-expected.txt: Removed.
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
* platform/qt/svg/hixie/viewbox/002-expected.txt: Removed.
* platform/qt/svg/hixie/viewbox/003-expected.txt: Removed.
* platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Removed.
* platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Removed.
* platform/qt/svg/text/text-viewbox-rescale-expected.txt: Removed.
* platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Removed.
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug26553-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug83786-expected.txt: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix apk generation for the Android platform
peter@chromium.org [Tue, 14 Aug 2012 11:02:21 +0000 (11:02 +0000)]
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841

Unreviewed build fix.

APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.

Source/WebKit/chromium:

* WebKitUnitTests.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r125525.
commit-queue@webkit.org [Tue, 14 Aug 2012 10:24:07 +0000 (10:24 +0000)]
Unreviewed, rolling out r125525.
http://trac.webkit.org/changeset/125525
https://bugs.webkit.org/show_bug.cgi?id=93950

rebaseline revert after r125526... (Requested by philn on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-14

* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fixed displaying buffering progress in the media control.
commit-queue@webkit.org [Tue, 14 Aug 2012 10:13:06 +0000 (10:13 +0000)]
[EFL] Fixed displaying buffering progress in the media control.
https://bugs.webkit.org/show_bug.cgi?id=75681

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

It is required "rangeRect" instead of "rect" to display buffering
progress properly.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaSliderTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening after r125516.
kkristof@inf.u-szeged.hu [Tue, 14 Aug 2012 10:12:41 +0000 (10:12 +0000)]
[Qt] Gardening after r125516.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-08-14
Reviewed by Csaba Osztrogonác.

Added baseline to fast/text/zero-font-size.html.

* platform/qt/fast/text/zero-font-size-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125535 268f45cc-cd09-0410-ab3c-d52691b4dbfc