WebKit-https.git
14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@14916 268f45cc-cd09-0410...
weinig [Mon, 19 Jun 2006 22:58:36 +0000 (22:58 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
sullivan [Mon, 19 Jun 2006 21:58:12 +0000 (21:58 +0000)]
    Reviewed by Darin.

        - added mechanism to notify UIDelegate when part of the webview is redrawn. For now, it only
          works for HTML views.

        * WebView/WebUIDelegatePrivate.h:
        Define a new UIDelegate method -webView:didDrawRect:
        * WebView/WebHTMLView.m:
        (-[WebView drawSingleRect:]):
        Call through to UIDelegate if it implements that method. I tested that this does not impact PLT numbers
        in the case where the delegate implements the method but does nothing in it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
darin [Mon, 19 Jun 2006 21:39:28 +0000 (21:39 +0000)]
    Reviewed by Brady.

        - removed a few empty/unused files Brady found by tracking down the nm error message

        * editing/VisibleRange.cpp: Removed.
        * editing/VisibleRange.h: Removed.
        * kcanvas/KCanvasImage.cpp: Removed.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed VisibleRange.cpp/h.
        * WebCore.xcodeproj/project.pbxproj: Removed VisibleRange.cpp/h and KCanvasImage.cpp.
        * WebCoreSources.bkl: Removed VisibleRange.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-19 Anders Carlsson <acarlsson@apple.com>
andersca [Mon, 19 Jun 2006 19:23:18 +0000 (19:23 +0000)]
2006-06-19  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John.

        * kjs/interpreter.cpp:
        (KJS::TimeoutChecker::pauseTimeoutCheck):
        (KJS::TimeoutChecker::resumeTimeoutCheck):
        Fix argument order in setitimer calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Mon, 19 Jun 2006 16:42:35 +0000 (16:42 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9492
        Fix or remove window.debug.

        It was only available in newly created windows, and became undefined after changing the URL
        or reloading. Let's try removing it; hopefully, no-one will notice.

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::initScriptIfNeeded): Don't add window.debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Mon, 19 Jun 2006 16:15:31 +0000 (16:15 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8972
        REGRESSION: invalid UTF-8 sequences are not displayed

        Test: LayoutTests/fast/encoding/invalid-UTF-8.html

        * dom/xml_tokenizer.cpp:
        (WebCore::getXHTMLEntity): Properly null-terminate the result. This didn't matter
        before, because the garbage at the end was guaranteed to be invalid UTF-8, and was
        omitted in appendOmittingUnwanted();

        * platform/StreamingTextDecoder.cpp:
        (WebCore::StreamingTextDecoder::appendOmittingBOM): Only omit BOM characters.
        Renamed back from appendOmittingUnwanted();

        (WebCore::StreamingTextDecoder::convertUsingICU):
        * platform/StreamingTextDecoder.h:
        Update for the above function renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKit:
ddkilzer [Mon, 19 Jun 2006 10:51:11 +0000 (10:51 +0000)]
WebKit:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9452
          Assertion failure in -[WebFramePrivate setProvisionalDataSource:]

        * WebView/WebFrame.m:
        (-[WebFrame _checkLoadCompleteForThisFrame]): Avoid re-entering the delegate's
        -[webView:didFailProvisionalLoadWithError:forFrame].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Mon, 19 Jun 2006 00:00:53 +0000 (00:00 +0000)]
WebKitTools:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9485
        Teach svn-apply and svn-unapply to use full path names

        * Scripts/svn-apply: Changed to use full path names.  Cleaned up code.
        * Scripts/svn-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 18 Jun 2006 23:54:59 +0000 (23:54 +0000)]
WebCore:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9498
        Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838)

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLDocument::getOwnPropertySlot): Remove dead code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 18 Jun 2006 22:20:04 +0000 (22:20 +0000)]
LayoutTests:

        Reviewed by ggaren.

        * fast/history/clicked-link-is-visited.html: Changed to use DOM mouse event.

WebCore:

        Reviewed by ggaren.

        * manual-tests/redraw-page-cache-visited-links.html: Changed to use DOM mouse event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKit:
ddkilzer [Sun, 18 Jun 2006 17:58:53 +0000 (17:58 +0000)]
WebKit:

        Reviewed by xenon.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9479
          Disassociate the inspector from the frame when it detaches from its parent

        * WebInspector/WebInspector.m:
        (-[NSWindow setWebFrame:]): Added code to (de)register with the WebFrame
        the inspector is (no longer) targeting.
        (-[WebInspector _webFrameDetached:]): Added. Moved the code that was previously
        in -[inspectedWindowWillClose:] here. This is called by the WebFrame when it
        is detached from its parent.
        * WebInspector/WebInspectorInternal.h:
        * WebView/WebFrame.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame _detachFromParent]): Added code to notify all registered inspectors
        that the WebFrame is detaching.
        (-[WebFrame _addInspector:]): Added.
        (-[WebFrame _removeInspector:]): Added.
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 18 Jun 2006 17:54:35 +0000 (17:54 +0000)]
LayoutTests:

        Reviewed by ggaren.

        - test and results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9150
          DumpRenderTree should be able to keep URL history during runs

        * fast/history/clicked-link-is-visited-expected.checksum: Added.
        * fast/history/clicked-link-is-visited-expected.png: Added.
        * fast/history/clicked-link-is-visited-expected.txt: Added.
        * fast/history/clicked-link-is-visited.html: Added.
        * fast/history/resources/clicked-link-is-visited-2.html: Added.

WebCore:

        Reviewed by ggaren.

        - Update a manual test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9150
          DumpRenderTree should be able to keep URL history during runs

        * manual-tests/redraw-page-cache-visited-links.html: Added note about window.history hack.
        Fixed coordinates for mouse events.  Added call to keepWebHistory().
        * manual-tests/resources/redraw-page-cache-visited-links-2.html: Added note about
        window.history hack.

WebKitTools:

        Reviewed by ggaren.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9150
          DumpRenderTree should be able to keep URL history during runs

        Test: LayoutTests/fast/history/clicked-link-is-visited.html

        * DumpRenderTree/DumpRenderTree.m: Add keepWebHistory function to layoutTestController
        (+[LayoutTestController isSelectorExcludedFromWebScript:]): Updated for keepWebHistory.
        (-[LayoutTestController keepWebHistory]): Added.  We only set optional shared history if
        it is currently nil since keepWebHistory() might be called more than once incidentally
        for the same test.
        (dumpRenderTree): Set optional shared history in WebHistory to nil by default.
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Xcode 2.3 clean up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andersca [Sun, 18 Jun 2006 17:11:51 +0000 (17:11 +0000)]
JavaScriptCore:

2006-06-18  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * kjs/interpreter.cpp:
        (KJS::TimeoutChecker::pauseTimeoutCheck):
        Do nothing if the timeout check hasn't been started.

        (KJS::TimeoutChecker::resumeTimeoutCheck):
        Do nothing if the timeout check hasn't been started.
        Use the right signal handler when unblocking.

        (KJS::Interpreter::handleTimeout):
        pause/resume the timeout check around the call to
        shouldInterruptScript().

WebCore:

2006-06-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * bindings/js/kjs_binding.cpp:
        (KJS::ScriptInterpreter::ScriptInterpreter):
        Set the default script timeout.

        (KJS::ScriptInterpreter::shouldInterruptScript):
        New function which asks the frame if the script should be interrupted.

        * bindings/js/kjs_binding.h:

        * bindings/js/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::evaluate):
        Add calls to startTimeoutCheck/stopTimeoutCheck

        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction):
        Add calls to pauseTimeoutCheck/unpauseTimeoutCheck

        (KJS::ScheduledAction::execute):
        Add calls to startTimeoutCheck/stopTimeoutCheck

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::shouldInterruptJavaScript):
        New function which asks the bridge if the script should be interrupted.

        * bridge/mac/WebCoreFrameBridge.h:
        * page/Frame.h:
        Add function declarations.

WebKit:

2006-06-18  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge shouldInterruptJavaScript]):
        Ask the UI delegate if the script should be interrupted.

        * WebView/WebUIDelegatePrivate.h:
        Declare webViewShouldInterruptJavaScript: delegate method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by ggaren.
ap [Sun, 18 Jun 2006 07:00:54 +0000 (07:00 +0000)]
    Reviewed by ggaren.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8131
        Some properties and methods of window and document objects cannot be converted to a string

        Most of the properties were already fixed, this just adds adds a prototype to window.debug.

        Test: fast/dom/everything-to-string.html

        * bindings/js/kjs_proxy.cpp:
        (WebCore::TestFunctionImp::TestFunctionImp):
        (WebCore::KJSProxy::initScriptIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
mjs [Sun, 18 Jun 2006 06:25:06 +0000 (06:25 +0000)]
    Reviewed by Maciej

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9491
        Windows build breaks in interpreter.cpp

        * kjs/interpreter.cpp
        (KJS::TimeoutChecker::pauseTimeoutCheck):
        (KJS::TimeoutChecker::resumeTimeoutCheck):
        Make sure to only assert equality with s_executingInterpreter when it
        is being used (i.e. when HAVE(SYS_TIME_H) == true)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 18 Jun 2006 04:22:56 +0000 (04:22 +0000)]
WebCore:

        Reviewed by Maciej.

        - Fix capitalization issue for case-sensitive filesystems.

        * icon/SQLStatement.cpp: Change assertions.h to Assertions.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ddkilzer [Sun, 18 Jun 2006 00:30:57 +0000 (00:30 +0000)]
JavaScriptCore:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9477
        REGRESSION: fast/dom/replaceChild.html crashes on WebKit ToT in debug build

        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction): Refetch the debugger after executing the function
        in case the WebFrame it was running in has since been destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Sat, 17 Jun 2006 15:54:58 +0000 (15:54 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=7395
          Table not properly re-flowed when floated div removed from layout

        * css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum: Updated.
        * css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Updated.
        * css2.1/t0905-c5525-fltmult-00-d-g-expected.txt: Updated.
        * fast/block/float/table-relayout-expected.checksum: Added.
        * fast/block/float/table-relayout-expected.png: Added.
        * fast/block/float/table-relayout-expected.txt: Added.
        * fast/block/float/table-relayout.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7395
          Table not properly re-flowed when floated div removed from layout

        Test: fast/block/float/table-relayout.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): Added marking
        of children that use lineWidth.
        * rendering/RenderBlock.h: Added a FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Sat, 17 Jun 2006 15:37:58 +0000 (15:37 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test cases for
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6282>

        * fast/dom/select-selectedIndex-multiple.html: Added.
        * fast/dom/select-selectedIndex.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6282:
        Adding new Option with new Option(text, value, defaultSelected, selected) fails to update selectedIndex

        Update selectedIndex when a new option is added using javascript.

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLSelectCollection::put):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::setOption):
        (WebCore::HTMLSelectElement::setLength):
        * html/HTMLSelectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Sat, 17 Jun 2006 15:29:59 +0000 (15:29 +0000)]
WebCore:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9466
          Assertion failure when dragging an image from the document into Safari's address bar

        * manual-tests/reset-initiatedDrag.html: Added.

WebKit:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9466
          Assertion failure when dragging an image from the document into Safari's address bar

        * WebView/WebFrameView.m:
        (-[WebFrameView _setDocumentView:]): Reset the WebView's initiatedDrag flag
        when the document view is changed.
        * WebView/WebHTMLView.m:
        (-[WebHTMLView draggedImage:endedAt:operation:]): Changed the ASSERT to allow
        for drags that end after the view has been removed from the WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ddkilzer [Sat, 17 Jun 2006 10:48:33 +0000 (10:48 +0000)]
JavaScriptCore:

        Reviewed by ggaren.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9476
        REGRESSION: Reproducible crash after closing window after viewing
        css2.1/t0803-c5501-imrgn-t-00-b-ag.html

        * kjs/debugger.cpp:
        (Debugger::detach): Call setDebugger(0) for all interpreters removed from
        the 'attached to a debugger' list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sat, 17 Jun 2006 01:15:54 +0000 (01:15 +0000)]
WebCore:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9463
        REGRESSION (r14879): Assertion failure in CSSParser::sinkFloatingSelector()
        (m_floatingSelectors.contains(selector)) in some CSS tests

        * css/CSSGrammar.y: Create CSSSelector for FUNCTION using CSSParser::createFloatingSelector()
        instead of the bare constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/4565312> Mail has a weird drawing artifact with dotted red...
harrison [Sat, 17 Jun 2006 01:08:52 +0000 (01:08 +0000)]
    <rdar://problem/4565312> Mail has a weird drawing artifact with dotted red lines running across the window

        Problem was that revision lost a check to not draw the markers
        when paintingDisabled().   This led the markers to be drawn when
        the window deactivated, at which time the view happens to be flipped.

        It is similar but not the same as the Mail ToDo highlighting
        issue, which is due to the custom highlight method
        drawing when the focusView is nil.  Mail team knows this
        and has tested the fix.

        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawLineForMisspelling):
        Early return if paintingDisabled().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-17 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 16 Jun 2006 23:47:20 +0000 (23:47 +0000)]
2006-06-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej and Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7080
        Provide some way to stop a JavaScript infinite loop

        * kjs/completion.h:
        (KJS::):
        Add Interrupted completion type.

        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::GlobalFuncImp::callAsFunction):
        Only set the exception on the new ExecState if the current one has had one.

        * kjs/interpreter.cpp:
        (KJS::TimeoutChecker::startTimeoutCheck):
        (KJS::TimeoutChecker::stopTimeoutCheck):
        (KJS::TimeoutChecker::alarmHandler):
        (KJS::TimeoutChecker::pauseTimeoutCheck):
        (KJS::TimeoutChecker::resumeTimeoutCheck):
        New TimeoutChecker class which handles setting Interpreter::m_timedOut flag after a given
        period of time. This currently only works on Unix platforms where setitimer and signals are used.

        (KJS::Interpreter::Interpreter):
        Initialize new member variables.

        (KJS::Interpreter::~Interpreter):
        Destroy the timeout checker.

        (KJS::Interpreter::startTimeoutCheck):
        (KJS::Interpreter::stopTimeoutCheck):
        (KJS::Interpreter::pauseTimeoutCheck):
        (KJS::Interpreter::resumeTimeoutCheck):
        Call the timeout checker.

        (KJS::Interpreter::handleTimeout):
        Called on timeout. Resets the m_timedOut flag and calls shouldInterruptScript.

        * kjs/interpreter.h:
        (KJS::Interpreter::setTimeoutTime):
        New function for setting the timeout time.

        (KJS::Interpreter::shouldInterruptScript):
        New function. The idea is that this should be overridden by subclasses in order to for example
        pop up a dialog asking the user if the script should be interrupted.

        (KJS::Interpreter::checkTimeout):
        New function which checks the m_timedOut flag and calls handleTimeout if it's set.

        * kjs/nodes.cpp:
        (DoWhileNode::execute):
        (WhileNode::execute):
        (ForNode::execute):
        Call Interpreter::checkTimeout after each iteration of the loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
adele [Fri, 16 Jun 2006 23:45:07 +0000 (23:45 +0000)]
    Reviewed by Hyatt.

        Adjust padding of inner div so text lines up with text fields.
        Adjust height of textarea so it only leaves room for the horizontal
        scrollbar if overflow is set to scroll, or if overflow is set to
        auto and there's no word wrap.

        These changes will be tested by current layout tests when the
        new textarea implementation takes effect.

        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle):
        (WebCore::RenderTextField::calcHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin
sullivan [Fri, 16 Jun 2006 21:49:23 +0000 (21:49 +0000)]
    Reviewed by Darin

        - fixed <rdar://problem/4590062> crash in marker code with particular set of steps on daringfireball.net

        * dom/Document.cpp:
        (WebCore::Document::addMarker):
        Store [it - markers.begin()] in a local variable before modifying markers, since modifying markers can
        change value of [it - markers.begin()].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim O.
thatcher [Fri, 16 Jun 2006 21:10:40 +0000 (21:10 +0000)]
    Reviewed by Tim O.

        Exposes a distributed objects server for clients to register for script debugger calls.
        For preformance concerns this is disabled by default, you will need to enable this per application.
        To enable for Safari do this: defaults write com.apple.Safari WebKitScriptDebuggerEnabled -bool true

        Clients will need to listen to the following distributed notification to discover servers:
        WebScriptDebugServerDidLoadNotification

        To discover servers that previously loaded before the client, the client needs to send the following notification:
        WebScriptDebugServerQueryNotification

        All servers will reply with the WebScriptDebugServerQueryReplyNotification notification that contains the
        registered server connection name to use with distributed objects.

        * DefaultDelegates/WebScriptDebugServer.h: Added.
        * DefaultDelegates/WebScriptDebugServer.m: Added.
        (+[WebScriptDebugServer sharedScriptDebugServer]):
        (-[WebScriptDebugServer init]):
        (-[WebScriptDebugServer dealloc]):
        (-[WebScriptDebugServer serverQuery:]):
        (-[WebScriptDebugServer listenerConnectionDidDie:]):
        (-[WebScriptDebugServer addListener:]):
        (-[WebScriptDebugServer removeListener:]):
        (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]):
        (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        * DefaultDelegates/WebScriptDebugServerPrivate.h: Added.
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge windowObjectCleared]):
        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebScriptDebugDelegate.m:
        (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]):
        (-[WebScriptCallFrame enteredFrame:sourceId:line:]):
        (-[WebScriptCallFrame hitStatement:sourceId:line:]):
        (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
        * WebView/WebView.m:
        (+[WebView _developerExtrasEnabled]):
        (+[WebView _scriptDebuggerEnabled]):
        (-[WebView _menuForElement:defaultItems:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Fri, 16 Jun 2006 18:27:54 +0000 (18:27 +0000)]
WebCore:

        Reviewed by Alice.

        Added code to draw Cocoa-like border for textareas instead of just using CSS.

        * WebCore.exp:
        * css/html4.css: Sets a 1px solid border.
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        * rendering/RenderThemeMac.h: Formatting changes.
        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextArea):
        Uses new wkDrawBezeledTextArea to draw border.

WebKit:

        Reviewed by Alice.

        Added initialization for WKDrawBezeledTextArea.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

WebKitLibraries:

        Reviewed by Alice.

        * WebKitSystemInterface.h: Added WKDrawBezeledTextArea().
        * libWebKitSystemInterface.a: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
adele [Fri, 16 Jun 2006 17:02:30 +0000 (17:02 +0000)]
    Reviewed by Maciej.

        Adding missing expected result for test from yesterday.

        * fast/events/window-load-capture-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Fri, 16 Jun 2006 13:13:55 +0000 (13:13 +0000)]
LayoutTests:

        Reviewed by hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9432
          REGRESSION: crash in capitalization code due to empty-string generated content

        * fast/text/capitalize-empty-generated-string-expected.checksum: Added.
        * fast/text/capitalize-empty-generated-string-expected.png: Added.
        * fast/text/capitalize-empty-generated-string-expected.txt: Added.
        * fast/text/capitalize-empty-generated-string.html: Added.

WebCore:

        Reviewed by hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9432
          REGRESSION: crash in capitalization code due to empty-string generated content

        Test: fast/text/capitalize-empty-generated-string.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::setText): Skip empty-string text renderers when
        looking for the previous character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Fri, 16 Jun 2006 00:45:02 +0000 (00:45 +0000)]
LayoutTests:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
        REGRESSION (11-16-05): Selection gaps left behind after delete

        * fast/repaint/selection-after-delete-expected.checksum: Added.
        * fast/repaint/selection-after-delete-expected.png: Added.
        * fast/repaint/selection-after-delete-expected.txt: Added.
        * fast/repaint/selection-after-delete.html: Added.
        * fast/repaint/selection-after-remove-expected.checksum: Added.
        * fast/repaint/selection-after-remove-expected.png: Added.
        * fast/repaint/selection-after-remove-expected.txt: Added.
        * fast/repaint/selection-after-remove.html: Added.

WebCore:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
        REGRESSION (11-16-05): Selection gaps left behind after delete

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved): Invalidate the selection so that
        selection gaps are invalidated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
thatcher [Thu, 15 Jun 2006 22:33:56 +0000 (22:33 +0000)]
JavaScriptCore:

        Reviewed by Geoff and Darin.

        Prefer the DWARF debugging symbols format for use in Xcode 2.3.

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Geoff and Darin.

        Prefer the DWARF debugging symbols format for use in Xcode 2.3.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Geoff and Darin.

        Prefer the DWARF debugging symbols format for use in Xcode 2.3.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Geoff and Darin.

        Prefer the DWARF debugging symbols format for use in Xcode 2.3.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAnd now with the ugly line gone, and the proper expected test results
jdevalk [Thu, 15 Jun 2006 22:31:25 +0000 (22:31 +0000)]
And now with the ugly line gone, and the proper expected test results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoupdate testresults
jdevalk [Thu, 15 Jun 2006 22:28:48 +0000 (22:28 +0000)]
update testresults

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Thu, 15 Jun 2006 22:26:52 +0000 (22:26 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/deleting/pruning-after-merge-2-expected.checksum: Added.
        * editing/deleting/pruning-after-merge-2-expected.png: Added.
        * editing/deleting/pruning-after-merge-2-expected.txt: Added.
        * editing/deleting/pruning-after-merge-2.html: Added.

WebCore:

        Reviewed by harrison

        * editing/CompositeEditCommand.cpp:
        (WebCore::hasARenderedDescendant):
        (WebCore::CompositeEditCommand::prune): Ascend using the DOM
        (WebCore::CompositeEditCommand::moveParagraphs): Placeholder insertion
        during deletion is fixed, removing the fall back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdding :lang support, patch by Nicholas Shanks, review by Hyatt
jdevalk [Thu, 15 Jun 2006 21:37:13 +0000 (21:37 +0000)]
Adding :lang support, patch by Nicholas Shanks, review by Hyatt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImprove wording of first paragraph of index.html
jdevalk [Thu, 15 Jun 2006 21:09:32 +0000 (21:09 +0000)]
Improve wording of first paragraph of index.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Thu, 15 Jun 2006 20:05:00 +0000 (20:05 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
        REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

        * editing/execCommand/findString-2-expected.checksum: Added.
        * editing/execCommand/findString-2-expected.png: Added.
        * editing/execCommand/findString-2-expected.txt: Added.
        * editing/execCommand/findString-2.html: Added.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
        REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

        * page/Frame.cpp:
        (WebCore::Frame::findString): When comparing the found range with
        what's currently selected a) build a selection with the found
        range to remove collapsed whitespace and b) compare ranges
        instead of selection objects to ignore the way that the
        current selection was made (to ignore the base and extent).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim O.
sullivan [Thu, 15 Jun 2006 17:37:44 +0000 (17:37 +0000)]
    Reviewed by Tim O.

        Fixed bug in WebKit support for computing but not highlighting rects for text matches.

        * WebView/WebView.m:
        (-[WebView rectsForTextMatches]):
        leave out empty rects, and convert rects to WebView coordinates. Since this makes a batch
        of autoreleased NSValue objects, use a local autorelease pool

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
sullivan [Thu, 15 Jun 2006 13:37:17 +0000 (13:37 +0000)]
    Reviewed by John Sullivan.

        * Plugins/WebPluginController.m:
        (-[WebPluginController _cancelOutstandingChecks]):
        add nil check before calling CFSetApplyFunction

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Thu, 15 Jun 2006 11:12:18 +0000 (11:12 +0000)]
WebCore:

        Reviewed by mjs.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9382
        IDL files missing copyright/license headers

        Add Apple BSD license and copyright to IDL files.

        * ksvg2/bindings/idl/svg/GetSVGDocument.idl:
        * ksvg2/bindings/idl/svg/SVGAElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedRect.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedString.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimationElement.idl:
        * ksvg2/bindings/idl/svg/SVGCircleElement.idl:
        * ksvg2/bindings/idl/svg/SVGClipPathElement.idl:
        * ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl:
        * ksvg2/bindings/idl/svg/SVGCursorElement.idl:
        * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl:
        * ksvg2/bindings/idl/svg/SVGDefsElement.idl:
        * ksvg2/bindings/idl/svg/SVGDescElement.idl:
        * ksvg2/bindings/idl/svg/SVGElementInstance.idl:
        * ksvg2/bindings/idl/svg/SVGElementInstanceList.idl:
        * ksvg2/bindings/idl/svg/SVGEllipseElement.idl:
        * ksvg2/bindings/idl/svg/SVGEvent.idl:
        * ksvg2/bindings/idl/svg/SVGException.idl:
        * ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl:
        * ksvg2/bindings/idl/svg/SVGFEBlendElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl:
        * ksvg2/bindings/idl/svg/SVGFECompositeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFloodElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEImageElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEMergeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl:
        * ksvg2/bindings/idl/svg/SVGFETileElement.idl:
        * ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl:
        * ksvg2/bindings/idl/svg/SVGFilterElement.idl:
        * ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl:
        * ksvg2/bindings/idl/svg/SVGFitToViewBox.idl:
        * ksvg2/bindings/idl/svg/SVGGElement.idl:
        * ksvg2/bindings/idl/svg/SVGGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGICCColor.idl:
        * ksvg2/bindings/idl/svg/SVGImageElement.idl:
        * ksvg2/bindings/idl/svg/SVGLangSpace.idl:
        * ksvg2/bindings/idl/svg/SVGLengthList.idl:
        * ksvg2/bindings/idl/svg/SVGLineElement.idl:
        * ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGLocatable.idl:
        * ksvg2/bindings/idl/svg/SVGMarkerElement.idl:
        * ksvg2/bindings/idl/svg/SVGNumberList.idl:
        * ksvg2/bindings/idl/svg/SVGPaint.idl:
        * ksvg2/bindings/idl/svg/SVGPathElement.idl:
        * ksvg2/bindings/idl/svg/SVGPathSeg.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegArc.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLineto.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegList.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl:
        * ksvg2/bindings/idl/svg/SVGPatternElement.idl:
        * ksvg2/bindings/idl/svg/SVGPointList.idl:
        * ksvg2/bindings/idl/svg/SVGPolygonElement.idl:
        * ksvg2/bindings/idl/svg/SVGPolylineElement.idl:
        * ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGRectElement.idl:
        * ksvg2/bindings/idl/svg/SVGRenderingIntent.idl:
        * ksvg2/bindings/idl/svg/SVGScriptElement.idl:
        * ksvg2/bindings/idl/svg/SVGSetElement.idl:
        * ksvg2/bindings/idl/svg/SVGStopElement.idl:
        * ksvg2/bindings/idl/svg/SVGStringList.idl:
        * ksvg2/bindings/idl/svg/SVGStylable.idl:
        * ksvg2/bindings/idl/svg/SVGStyleElement.idl:
        * ksvg2/bindings/idl/svg/SVGSwitchElement.idl:
        * ksvg2/bindings/idl/svg/SVGSymbolElement.idl:
        * ksvg2/bindings/idl/svg/SVGTSpanElement.idl:
        * ksvg2/bindings/idl/svg/SVGTests.idl:
        * ksvg2/bindings/idl/svg/SVGTextContentElement.idl:
        * ksvg2/bindings/idl/svg/SVGTextElement.idl:
        * ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl:
        * ksvg2/bindings/idl/svg/SVGTitleElement.idl:
        * ksvg2/bindings/idl/svg/SVGTransformList.idl:
        * ksvg2/bindings/idl/svg/SVGTransformable.idl:
        * ksvg2/bindings/idl/svg/SVGURIReference.idl:
        * ksvg2/bindings/idl/svg/SVGUnitTypes.idl:
        * ksvg2/bindings/idl/svg/SVGUseElement.idl:
        * ksvg2/bindings/idl/svg/SVGViewElement.idl:
        * ksvg2/bindings/idl/svg/SVGZoomAndPan.idl:
        * ksvg2/bindings/idl/svg/SVGZoomEvent.idl:
        * ksvg2/svg/SVGAnimatedLength.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Thu, 15 Jun 2006 00:12:49 +0000 (00:12 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4439248>
        REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

        * editing/pasteboard/copy-paste-bidi-expected.checksum: Added.
        * editing/pasteboard/copy-paste-bidi-expected.png: Added.
        * editing/pasteboard/copy-paste-bidi-expected.txt: Added.
        * editing/pasteboard/copy-paste-bidi.html: Added.

WebCore:

        Reviewed by levi

        <rdar://problem/4439248>
        REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

        * editing/markup.cpp:
        (WebCore::renderedText): Use plainText so that we'll pull rendered text but in DOM order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 14 Jun 2006 23:23:50 +0000 (23:23 +0000)]
LayoutTests:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * editing/deleting/delete-ws-fixup-002-expected.checksum:
        * editing/deleting/delete-ws-fixup-002-expected.png:
        * editing/deleting/delete-ws-fixup-002-expected.txt:
        * editing/deleting/delete-ws-fixup-002.html:
        * editing/execCommand/format-block-expected.checksum: Added.
        * editing/execCommand/format-block-expected.png: Added.
        * editing/execCommand/format-block-expected.txt: Added.
        * editing/execCommand/format-block-from-range-selection-expected.checksum: Added.
        * editing/execCommand/format-block-from-range-selection-expected.png: Added.
        * editing/execCommand/format-block-from-range-selection-expected.txt: Added.
        * editing/execCommand/format-block-from-range-selection.html: Added.
        * editing/execCommand/format-block.html: Added.

WebCore:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * WebCore.xcodeproj/project.pbxproj: Added FormatBlock.{h,cpp} to the project.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
        * bridge/mac/WebCoreFrameBridge.h: Added WebUndoActions
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraph): Added a preserveStyle bool.
        (WebCore::CompositeEditCommand::moveParagraphs): Ditto.  downstream() the start
        or else we'll move collapsed whitespace and uncollapse it.
        * editing/CompositeEditCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Don't update m_endingPosition
        because that's removeNode's responsibility.
        (WebCore::updatePositionForNodeRemoval): Added.
        (WebCore::DeleteSelectionCommand::removeNode): Turned removeFullySelectedNode into a virtual
        overload of removeNode so that we can update positions as we remove nodes.
        (WebCore::updatePositionForTextRemoval): Added.
        (WebCore::DeleteSelectionCommand::deleteTextFromNode):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::fixupWhitespace): Got rid of m_trailingWhitespaceValid
        since m_trailingWhitespace is always valid (we update it as we remove nodes).
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        (WebCore::DeleteSelectionCommand::doApply): Leading and trailing spaces should
        be fixed if they have collapsed before merging paragraphs.
        * editing/DeleteSelectionCommand.h:
        * editing/EditAction.h:
        (WebCore::):
        * editing/FormatBlockCommand.cpp: Added.
        (WebCore::FormatBlockCommand::FormatBlockCommand):
        (WebCore::FormatBlockCommand::modifyRange): Similar to InsertListCommand::modifyRange().
        (WebCore::FormatBlockCommand::doApply):
        * editing/FormatBlockCommand.h: Added.
        (WebCore::FormatBlockCommand::editingAction):
        * editing/InsertListCommand.h:
        (WebCore::InsertListCommand::editingAction):
        * editing/JSEditor.cpp:
        * editing/MergeIdenticalElementsCommand.cpp:
        (WebCore::MergeIdenticalElementsCommand::doApply):
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag):
        (WebCore::createElement):
        * editing/htmlediting.h:

WebKit:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * English.lproj/Localizable.strings:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge nameForUndoAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Wed, 14 Jun 2006 22:59:18 +0000 (22:59 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4577988> GC: WebPluginController uses inefficient resurrecting enumeration

        * Plugins/WebPluginController.m:
        (cancelOutstandingCheck):
        (-[WebPluginController _cancelOutstandingChecks]):
        Use CFSetApplyFunction() instead of an enumerator to guard against modifications to the set while enumerating.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Wed, 14 Jun 2006 22:21:34 +0000 (22:21 +0000)]
LayoutTests:

        Test case by Anders, reviewed and tweaked by Maciej.

        - fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

        * fast/events/window-load-capture.html: Added.

WebCore:

        Reviewed by Anders.

        - fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWindowEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
ggaren [Wed, 14 Jun 2006 21:45:06 +0000 (21:45 +0000)]
    Reviewed by Beth.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9438
        Someone broke ToT: cannot build

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/runtime_root.h: Changed "Interpreter.h" to "interpreter.h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename RenderSlider to DeprecatedSlider, so that I can start work on
hyatt [Wed, 14 Jun 2006 21:17:46 +0000 (21:17 +0000)]
    Rename RenderSlider to DeprecatedSlider, so that I can start work on
        the new NSView-less slider.

        Reviewed by john

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::createRenderer):
        * rendering/DeprecatedSlider.cpp: Added.
        (WebCore::DeprecatedSlider::DeprecatedSlider):
        (WebCore::DeprecatedSlider::calcMinMaxWidth):
        (WebCore::DeprecatedSlider::updateFromElement):
        (WebCore::DeprecatedSlider::valueChanged):
        * rendering/DeprecatedSlider.h: Added.
        (WebCore::DeprecatedSlider::renderName):
        * rendering/RenderSlider.cpp: Removed.
        * rendering/RenderSlider.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Wed, 14 Jun 2006 05:54:06 +0000 (05:54 +0000)]
LayoutTests:

        Test for createHTMLDocument.

        * fast/dom/implementation-createHTMLDocument-expected.txt: Added.
        * fast/dom/implementation-createHTMLDocument.html: Added.

WebCore:

        Reviewed by Maciej.

        - Fixed <rdar://problem/4562192> Creating a new DOMHTMLDocument
        appears challenging.

        - Added createHTMLDocument to Objc bindings, fixed up implementation
        to comply with the DOM 2 Candidate Recommendation in which is was defined.
        (It never made the final spec.) Also removed use of deprecatedString,
        to avoid unnecessary killing of puppies.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMImplementation createHTMLDocument:]):
        * bindings/objc/DOMPrivate.h:
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        (WebCore::DOMImplementation::createHTMLDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fixed up results of the layout test I committed for 4583892,
mjs [Wed, 14 Jun 2006 05:03:16 +0000 (05:03 +0000)]
    - fixed up results of the layout test I committed for 4583892,
        they were guaranteed to fail

        * fast/events/no-window-load-expected.txt:
        * fast/events/resources/greenbox.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago RS by MacDome. Added missing results for this test.
ggaren [Wed, 14 Jun 2006 05:01:56 +0000 (05:01 +0000)]
    RS by MacDome. Added missing results for this test.

        * fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
aliceli1 [Wed, 14 Jun 2006 01:35:01 +0000 (01:35 +0000)]
    Reviewed by Adele.

        fixed <rdar://problem/4457902> HTMLSelectElement.remove() can't handle an option obj being passed to it, results in hang on http://www.ibc-solar.de/www_ibc/fst_solarmonitoring.jsp

        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):
        support this by converting the argument to an options object
        before passing to remove()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 14 Jun 2006 01:33:34 +0000 (01:33 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - test for <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

        * fast/events/event-listener-html-non-html-confusion-expected.txt: Added.
        * fast/events/event-listener-html-non-html-confusion.html: Added.

WebCore:

        Reviewed by Geoff.

        - fix <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

        This patch fixes a bug where the event listener cache does not distinguish
        HTML and non-HTML listeners. Incorrect behavior where stopPropagation also
        prevented default masked a case of this bug on the yahoo.com home page until
        we fixed bug 5180 on 2005-10-03.

        Test: fast/events/event-listener-html-non-html-confusion.html

        * bindings/js/kjs_window.h: Add additional listener maps for HTML event listeners.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::~Window): Go through the additional maps when clearing the window object
        pointer in event listeners.
        (KJS::Window::getJSEventListener): Look in the HTML or non-HTML map depending on the
        argument passed.
        (KJS::Window::getJSUnprotectedEventListener): Ditto.

        * bindings/js/kjs_events.cpp:
        (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Add to either the HTML
        or non-HTML map depending on the argument passed.
        (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Remove from either the
        HTML or non-HTML map depending on whether the HTML flag is set.
        (KJS::JSEventListener::JSEventListener): More of the same.
        (KJS::JSEventListener::~JSEventListener): Ditto.
        (KJS::JSLazyEventListener::parseCode): Same thing here. In a lazy event listener there
        is not a listener at construction time, thus the code here to put the listener into a
        map needs the HTML vs. non-HTML logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Wed, 14 Jun 2006 01:25:42 +0000 (01:25 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - test case for <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load
        search results at mapquest.com

        * fast/events/no-window-load-expected.txt: Added.
        * fast/events/no-window-load.html: Added.

WebCore:

        Reviewed by Darin.

        <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchGenericEvent): Don't allow
        "load" events to propagate up to the window. We need this quirk to
        avoid site hangs, because they depend on an old Mozilla bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
antti [Tue, 13 Jun 2006 23:19:33 +0000 (23:19 +0000)]
LayoutTests:

        Reviewed by Hyatt

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9314

        * fast/block/positioning/relative-overflow-block-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-block-expected.png: Added.
        * fast/block/positioning/relative-overflow-block-expected.txt: Added.
        * fast/block/positioning/relative-overflow-block.html: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.png: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.txt: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.txt: Added.
        * fast/block/positioning/relative-overflow-replaced-float.html: Added.
        * fast/block/positioning/relative-overflow-replaced.html: Added.

WebCore:

        Reviewed by Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9314
        Relative positioned block size doesnt update root layer size

        - take relative positioning into account in leftmost/rightmost/lowestPosition()
        - ignore zero width/height boxes in leftmost/rightmost/lowestPosition()
        - split relativePositionOffset() to x and y functions

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition):
        (WebCore::RenderBox::relativePositionOffsetX):
        (WebCore::RenderBox::relativePositionOffsetY):
        (WebCore::RenderBox::lowestPosition):
        (WebCore::RenderBox::rightmostPosition):
        (WebCore::RenderBox::leftmostPosition):
        * rendering/RenderBox.h:
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lowestPosition):
        (WebCore::RenderFlow::rightmostPosition):
        (WebCore::RenderFlow::leftmostPosition):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetLeft):
        (WebCore::RenderObject::offsetTop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Tue, 13 Jun 2006 22:20:00 +0000 (22:20 +0000)]
WebCore:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9427
        xml-stylesheet processing instructions outside of the prolog should have no effect.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        Remove todo comment.

        * dom/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::processingInstruction):
        Only check for style sheet if the root element hasn't yet been encountered.

LayoutTests:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9427

        * fast/css/resources/xml-stylesheet-pi-not-in-prolog.css: Added.
        * fast/css/xml-stylesheet-pi-not-in-prolog.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim O.
sullivan [Tue, 13 Jun 2006 22:19:46 +0000 (22:19 +0000)]
    Reviewed by Tim O.

        - fixed <rdar://problem/4498606> REGRESSION (417.8-420+): 3 missing items (but extra separators) in context
        menu in Mail message body

        * WebView/WebView.m:
        (-[WebView _menuForElement:defaultItems:]):
        Add special-case hackery to recover from this SPI -> API mismatch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Clarified my previous ChangeLog entry.
tomernic [Tue, 13 Jun 2006 21:58:14 +0000 (21:58 +0000)]
    Clarified my previous ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
tomernic [Tue, 13 Jun 2006 21:56:30 +0000 (21:56 +0000)]
    Reviewed by Anders.

        Fixed a recently-introduced assertion failure when handling 404 errors.

        * WebView/WebDataSource.m:
        (-[WebDataSource _handleFallbackContent]):
        Use the -[WebFrame _bridge] instead of -[WebDataSource _bridge].  The former is not valid until the data
        source has been committed, as is the case when the resource fails to load.  The latter is safe to call at
        any time.  This broke last night with Maciej's change to WebFrameResourceLoader.  The old code used to call
        -[WebFrame _bridge].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Tue, 13 Jun 2006 13:37:18 +0000 (13:37 +0000)]
WebCore:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
        REGRESSION: fix for bug 9390 broke two layout tests

        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::writeRawData):
        Call finished() after setting up the document structure so we'll emit onload events.

WebKit:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
        REGRESSION: fix for bug 9390 broke two layout tests

        * Plugins/WebPluginDatabase.h:
        (-[WebPluginDatabase isMIMETypeRegistered:]):
        Add new function isMIMETypeRegistered which returns whether a given MIME type has a
        plugin registered.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase init]):
        Init set of registered MIME types.

        (-[WebPluginDatabase refresh]):
        Add and remove MIME types from the set of registered MIME types when registering and unregistering
        plugin MIME types.

        (-[WebPluginDatabase dealloc]):
        Release set of registered MIME types.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        Use isMIMETypeRegistered here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago build fix -- forgot to svn add this file
ggaren [Tue, 13 Jun 2006 06:37:21 +0000 (06:37 +0000)]
    build fix -- forgot to svn add this file

        * ForwardingHeaders/kjs/SavedBuiltins.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago build fix
ggaren [Tue, 13 Jun 2006 06:27:30 +0000 (06:27 +0000)]
    build fix

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]): Restore assignment I accidentally
        deleted in previous commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
beidson [Tue, 13 Jun 2006 06:10:56 +0000 (06:10 +0000)]
    Reviewed by Maciej.

        Fixed a bug in append(char) and append(UChar) where our intended copy-on-write semantics was ignored!

        * platform/String.cpp:
        (WebCore::String::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Tue, 13 Jun 2006 06:08:52 +0000 (06:08 +0000)]
JavaScriptCore:

        Reviewed by TimO, Maciej.

        - Merged InterpreterImp code into Interpreter, which implements
        all interpreter functionality now. This is part of my continuing quest
        to create an external notion of JS "execution context" that is unified and simple --
        something to replace the mix of Context, ContextImp, ExecState, Interpreter,
        InterpreterImp, and JSRun.

        All tests pass. Leaks test has not regressed from its baseline ~207 leaks
        with ~3460 leaked nodes.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/NP_jsobject.cpp:
        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]):
        * bindings/runtime_root.cpp:
        * bindings/runtime_root.h:
        * kjs/Context.cpp:
        (KJS::Context::Context):
        * kjs/ExecState.cpp: Added.
        (KJS::ExecState::lexicalInterpreter):
        * kjs/ExecState.h: Added.
        (KJS::ExecState::dynamicInterpreter):
        * kjs/SavedBuiltins.h: Added.
        * kjs/bool_object.cpp:
        (BooleanPrototype::BooleanPrototype):
        * kjs/collector.cpp:
        (KJS::Collector::collect):
        (KJS::Collector::numInterpreters):
        * kjs/context.h:
        * kjs/debugger.cpp:
        (Debugger::attach):
        (Debugger::detach):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/function_object.cpp:
        (FunctionObjectImp::construct):
        * kjs/internal.cpp:
        * kjs/internal.h:
        * kjs/interpreter.cpp:
        (KJS::interpreterMap):
        (KJS::Interpreter::Interpreter):
        (KJS::Interpreter::init):
        (KJS::Interpreter::~Interpreter):
        (KJS::Interpreter::globalObject):
        (KJS::Interpreter::initGlobalObject):
        (KJS::Interpreter::globalExec):
        (KJS::Interpreter::checkSyntax):
        (KJS::Interpreter::evaluate):
        (KJS::Interpreter::builtinObject):
        (KJS::Interpreter::builtinFunction):
        (KJS::Interpreter::builtinArray):
        (KJS::Interpreter::builtinBoolean):
        (KJS::Interpreter::builtinString):
        (KJS::Interpreter::builtinNumber):
        (KJS::Interpreter::builtinDate):
        (KJS::Interpreter::builtinRegExp):
        (KJS::Interpreter::builtinError):
        (KJS::Interpreter::builtinObjectPrototype):
        (KJS::Interpreter::builtinFunctionPrototype):
        (KJS::Interpreter::builtinArrayPrototype):
        (KJS::Interpreter::builtinBooleanPrototype):
        (KJS::Interpreter::builtinStringPrototype):
        (KJS::Interpreter::builtinNumberPrototype):
        (KJS::Interpreter::builtinDatePrototype):
        (KJS::Interpreter::builtinRegExpPrototype):
        (KJS::Interpreter::builtinErrorPrototype):
        (KJS::Interpreter::builtinEvalError):
        (KJS::Interpreter::builtinRangeError):
        (KJS::Interpreter::builtinReferenceError):
        (KJS::Interpreter::builtinSyntaxError):
        (KJS::Interpreter::builtinTypeError):
        (KJS::Interpreter::builtinURIError):
        (KJS::Interpreter::builtinEvalErrorPrototype):
        (KJS::Interpreter::builtinRangeErrorPrototype):
        (KJS::Interpreter::builtinReferenceErrorPrototype):
        (KJS::Interpreter::builtinSyntaxErrorPrototype):
        (KJS::Interpreter::builtinTypeErrorPrototype):
        (KJS::Interpreter::builtinURIErrorPrototype):
        (KJS::Interpreter::mark):
        (KJS::Interpreter::interpreterWithGlobalObject):
        (KJS::Interpreter::saveBuiltins):
        (KJS::Interpreter::restoreBuiltins):
        * kjs/interpreter.h:
        (KJS::Interpreter::setCompatMode):
        (KJS::Interpreter::compatMode):
        (KJS::Interpreter::firstInterpreter):
        (KJS::Interpreter::nextInterpreter):
        (KJS::Interpreter::prevInterpreter):
        (KJS::Interpreter::debugger):
        (KJS::Interpreter::setDebugger):
        (KJS::Interpreter::setContext):
        (KJS::Interpreter::context):
        * kjs/nodes.cpp:
        (StatementNode::hitStatement):
        (RegExpNode::evaluate):
        * kjs/protect.h:

JavaScriptGlue:

        Reviewed by TimO, Maciej.

        - JSGlue part of merging InterpreterImp into Interpreter.

        Since there's now a kjs forwarding header, I moved all forwarding
        headers into a "ForwardingHeaders" directory, like in WebCore.

        * ForwardingHeaders: Added.
        * ForwardingHeaders/kjs: Added.
        * ForwardingHeaders/kjs/ExecState.h: Added.
        * ForwardingHeaders/wtf: Added.
        * JavaScriptGlue.xcodeproj/project.pbxproj:
        * config.h:
        * wtf: Removed.
        * wtf/AlwaysInline.h: Removed.
        * wtf/Assertions.h: Removed.
        * wtf/FastMalloc.h: Removed.
        * wtf/Forward.h: Removed.
        * wtf/HashCountedSet.h: Removed.
        * wtf/HashSet.h: Removed.
        * wtf/Noncopyable.h: Removed.
        * wtf/OwnArrayPtr.h: Removed.
        * wtf/OwnPtr.h: Removed.
        * wtf/PassRefPtr.h: Removed.
        * wtf/Platform.h: Removed.
        * wtf/RefPtr.h: Removed.
        * wtf/Vector.h: Removed.

WebCore:

        Reviewed by TimO, Maciej.

        - WebCore part of merging InterpreterImp into Interpreter. No test
        because there's no behavior change.

        A substantive change here is that ScriptInterpreter::mark must now chain to
        Interpreter::mark, since Interpreter needs to mark the things that
        InterpreterImp used to mark.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::put):
        * bridge/mac/WebCoreFrameBridge.mm:
        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame evaluateWebScript:]):
        * kwq/KWQPageState.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix for cocoa exception (whoops)
mjs [Tue, 13 Jun 2006 05:09:15 +0000 (05:09 +0000)]
    - fix for cocoa exception (whoops)

        * WebView/WebView.m:
        (+[WebView _generatedMIMETypeForURLScheme:]): put this back
        * WebView/WebDataSource.m:
        (+[WebDataSource _generatedMIMETypeForURLScheme:]): call WebView

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Tue, 13 Jun 2006 03:36:10 +0000 (03:36 +0000)]
    Reviewed by Darin.

        - remove use of WebView and related from WebMainResourceLoader

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (+[WebDataSource _generatedMIMETypeForURLScheme:]):
        (+[WebDataSource _representationExistsForURLScheme:]):
        (+[WebDataSource _canShowMIMEType:]):
        (-[WebDataSource _handleFallbackContent]):
        (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFrame.m:
        (-[WebFrame _isMainFrame]):
        * WebView/WebFrameInternal.h:
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        (-[WebMainResourceLoader checkContentPolicyForResponse:]):
        (-[WebMainResourceLoader loadWithRequestNow:]):
        * WebView/WebView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
beidson [Tue, 13 Jun 2006 01:04:42 +0000 (01:04 +0000)]
    Reviewed by Maciej.

        Changed String::ascii() to return a Vector<char> instead of const char*
        This allows us to use it "regularly" as the returned vector will destruct
        and not leak memory like the previous approach.
        We can now do a String.ascii().data() to get a char* buffer instead of
        String.deprecatedString().ascii().  It doesn't improve the style much but
        dumping the memory-leak issue is a plus.

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::clearDatabase):
        * icon/SQLDatabase.cpp:
        (SQLDatabase::open):
        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::prepare):
        (WebCore::SQLStatement::step):
        (WebCore::SQLStatement::returnTextResults):
        (WebCore::SQLStatement::returnTextResults16):
        (WebCore::SQLStatement::returnIntResults):
        (WebCore::SQLStatement::returnInt64Results):
        (WebCore::SQLStatement::returnDoubleResults):
        In addition to the changes to the string classes, changed my database code over to the new
        preferred method.

        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::ascii):
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::ascii):
        * platform/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
tomernic [Tue, 13 Jun 2006 00:27:35 +0000 (00:27 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):
        Renamed from -initWithPath:.  Instead of releasing/deallocating self on error, return NO.
        (-[WebNetscapePluginPackage initWithPath:]):
        Call the new -_initWithPath:.  If it returns NO, unload the plugin package before deallocating it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd selection foreground color on Win32.
hyatt [Mon, 12 Jun 2006 23:03:56 +0000 (23:03 +0000)]
Add selection foreground color on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Mon, 12 Jun 2006 23:02:20 +0000 (23:02 +0000)]
    Reviewed by Darin Adler.

        * page/Frame.cpp:
        (WebCore::Frame::markAllMatchesForText):
        Do a "fake" paint here so that the rectangles for the text matches will have been
        computed by the time this method returns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Levi and Tim Omernick.
beidson [Mon, 12 Jun 2006 22:43:46 +0000 (22:43 +0000)]
    Reviewed by Levi and Tim Omernick.

        -Added a skeleton sqlite3 icon database file to IconDatabase
        -Added functionality to validate and recreate this icon.db file
        -Fixed some buggys in SQLDatabase.cpp

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::isValidDatabase):
        (WebCore::IconDatabase::clearDatabase):
        (WebCore::IconDatabase::recreateDatabase):
        * icon/IconDatabase.h:

        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::columnCount):
        (WebCore::SQLStatement::getColumnName):
        (WebCore::SQLStatement::getColumnName16):
        (WebCore::SQLStatement::getColumnText):
        (WebCore::SQLStatement::getColumnText16):
        (WebCore::SQLStatement::getColumnDouble):
        (WebCore::SQLStatement::getColumnInt):
        (WebCore::SQLStatement::getColumnInt64):
        (WebCore::SQLStatement::getColumnBlob):
        -Added checks to make sure we had a valid working sqlite3_statement as the sqlite3_*
        function calls weren't as error-tolerant as documentation advertised
        (maybe differences between the 3.3 docs I looked at and the 3.1.3 version installed on OSX)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win32 build bustage.
hyatt [Mon, 12 Jun 2006 19:53:53 +0000 (19:53 +0000)]
Fix Win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ggaren [Mon, 12 Jun 2006 19:02:59 +0000 (19:02 +0000)]
    Reviewed by Maciej.

        - Have *.lut.h files #include lookup.h to eliminate surprising header
        include order dependency.

        * DerivedSources.make:
        * kjs/array_object.cpp:
        * kjs/date_object.cpp:
        * kjs/date_object.h:
        (KJS::DateProtoFunc::):
        * kjs/lexer.cpp:
        * kjs/math_object.cpp:
        * kjs/number_object.cpp:
        * kjs/regexp_object.cpp:
        * kjs/string_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Levi.
beidson [Mon, 12 Jun 2006 18:07:59 +0000 (18:07 +0000)]
    Reviewed by Levi.

        -Added SQLite helper wrappers to ease use of SQLite in the IconDatabase.
        -Changed the base IconDatabase over to this new framework.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
            -By popular request, removed an annoying log message I'd accidentally left in

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::close):
        (WebCore::IconDatabase::~IconDatabase):
        * icon/IconDatabase.h:
        (WebCore::IconDatabase::isOpen):
            -Changed over IconDatabase from direct sqlite3_* calls to the new SQLDatabase calls

        * icon/SQLDatabase.cpp: Added.
        (SQLDatabase::SQLDatabase):
        (SQLDatabase::open):
        (SQLDatabase::close):
        (SQLDatabase::executeCommand):
        (SQLDatabase::tableExists):
        * icon/SQLDatabase.h: Added.
        (WebCore::SQLDatabase::isOpen):
        (WebCore::SQLDatabase::getPath):
        (WebCore::SQLDatabase::lastError):
        (WebCore::SQLDatabase::lastErrorMsg):
        (WebCore::SQLStatement::isPrepared):
        (WebCore::SQLStatement::lastError):
        (WebCore::SQLStatement::lastErrorMsg):
        * icon/SQLStatement.cpp: Added.
        (WebCore::SQLStatement::SQLStatement):
        (WebCore::SQLStatement::~SQLStatement):
        (WebCore::SQLStatement::prepare):
        (WebCore::SQLStatement::step):
        (WebCore::SQLStatement::finalize):
        (WebCore::SQLStatement::reset):
        (WebCore::SQLStatement::executeCommand):
        (WebCore::SQLStatement::bindBlob):
        (WebCore::SQLStatement::bindText):
        (WebCore::SQLStatement::columnCount):
        (WebCore::SQLStatement::getColumnName):
        (WebCore::SQLStatement::getColumnName16):
        (WebCore::SQLStatement::getColumnText):
        (WebCore::SQLStatement::getColumnText16):
        (WebCore::SQLStatement::getColumnDouble):
        (WebCore::SQLStatement::getColumnInt):
        (WebCore::SQLStatement::getColumnInt64):
        (WebCore::SQLStatement::getColumnBlob):
        (WebCore::SQLStatement::returnTextResults):
        (WebCore::SQLStatement::returnTextResults16):
        (WebCore::SQLStatement::returnIntResults):
        (WebCore::SQLStatement::returnInt64Results):
        (WebCore::SQLStatement::returnDoubleResults):
            -Initial checking of SQLDatabase framework

        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::String):
            -Added an explicit UChar* constructor to our string class as much of sqlite3's UTF16 handling is based on
            null-terminated UTF16 which we didn't yet support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Mon, 12 Jun 2006 04:10:38 +0000 (04:10 +0000)]
WebCore:

        Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9408
        Clean build fails with "make: *** No rule to make target `SVGElementFactory.cpp', needed by `all'. Stop"

        * DerivedSources.make: Fix clean builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - another try at fixing Windows
darin [Mon, 12 Jun 2006 02:03:00 +0000 (02:03 +0000)]
    - another try at fixing Windows

        * loader/CachedResource.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::setData):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoderPrivate::decode):
        (WebCore::GIFImageDecoder::setData):
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::decode):
        (WebCore::JPEGImageDecoder::setData):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):
        (WebCore::PNGImageDecoder::setData):
        * platform/image-decoders/png/PNGImageDecoder.h:
        s/DeprecatedByteArray/Vector<char>/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Mon, 12 Jun 2006 01:37:19 +0000 (01:37 +0000)]
WebCore:

        - try to fix Windows build

        * platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource):
        Use Vector<char> instead of DeprecatedByteArray.

        * platform/win/TemporaryLinkStubs.cpp: (KWQServeSynchronousRequest):
        Don't try to return 0 from a function that returns a Vector<char>.

WebKit:

        - try to fix Windows build

        * COM/WebKitDLL.cpp: (loadResourceIntoArray): Use Vector<char> instead of
        DeprecatedByteArray.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt, tweaked quite a bit and landed by Darin.
darin [Mon, 12 Jun 2006 01:10:17 +0000 (01:10 +0000)]
    Reviewed by Hyatt, tweaked quite a bit and landed by Darin.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8039
          Remove use of DeprecatedArray in favor of new Vector class

        This removes most of the uses of DeprecatedArray and
        DeprecatedByteArray, with the exception of DeprecatedCString.

        No test cases added because there is no change in
        functionality.

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::data):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::bufferData):
        (WebCore::CachedImage::data):
        (WebCore::CachedImage::checkNotify):
        (WebCore::CachedImage::shouldStopAnimation):
        * loader/CachedImage.h:
        * loader/CachedObject.cpp:
        (WebCore::CachedObject::bufferData):
        (WebCore::CachedObject::setExpireDate):
        * loader/CachedObject.h:
        (WebCore::CachedObject::setCharset):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::data):
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        (WebCore::CachedXBLDocument::data):
        (WebCore::CachedXBLDocument::checkNotify):
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::data):
        * loader/CachedXSLStyleSheet.h:
        * loader/Request.cpp:
        (WebCore::Request::Request):
        (WebCore::Request::~Request):
        * loader/Request.h:
        (WebCore::Request::buffer):
        (WebCore::Request::cachedObject):
        (WebCore::Request::docLoader):
        (WebCore::Request::isIncremental):
        (WebCore::Request::setIsIncremental):
        (WebCore::Request::isMultipart):
        (WebCore::Request::setIsMultipart):
        * loader/loader.cpp:
        (WebCore::crossDomain):
        (WebCore::Loader::Loader):
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::receivedAllData):
        (WebCore::Loader::receivedResponse):
        (WebCore::Loader::receivedData):
        (WebCore::Loader::numRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::removeBackgroundDecodingRequest):
        (WebCore::Loader::jobForRequest):
        * platform/Image.cpp:
        (WebCore::Image::setData):
        * platform/Image.h:
        (WebCore::Image::dataBuffer):

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::matchRules):
        (WebCore::CSSStyleSelector::matchRulesForList):
        (WebCore::CSSStyleSelector::sortMatchedRules):
        (WebCore::CSSStyleSelector::initForStyleResolve):
        (WebCore::CSSStyleSelector::createStyleForElement):
        (WebCore::CSSStyleSelector::createPseudoStyleForElement):
        * css/cssstyleselector.h:
        (WebCore::CSSStyleSelector::addMatchedRule):
        (WebCore::CSSStyleSelector::addMatchedDeclaration):
        * dom/xml_tokenizer.cpp:
        (WebCore::OffsetBuffer::OffsetBuffer):
        (WebCore::openFunc):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::index):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::selectedIndex):
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::length):
        (WebCore::HTMLSelectElement::remove):
        (WebCore::HTMLSelectElement::value):
        (WebCore::HTMLSelectElement::setValue):
        (WebCore::HTMLSelectElement::state):
        (WebCore::HTMLSelectElement::restoreState):
        (WebCore::HTMLSelectElement::appendFormData):
        (WebCore::HTMLSelectElement::optionToListIndex):
        (WebCore::HTMLSelectElement::listToOptionIndex):
        (WebCore::HTMLSelectElement::recalcListItems):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::listItems):
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQServeSynchronousRequest):
        * kwq/KWQTextStream.cpp:
        (QTextStream::operator<<):
        * kwq/KWQTextStream.h:
        * loader/FormData.cpp:
        (WebCore::FormData::flatten):
        (WebCore::FormData::flattenToString):
        * loader/FormData.h:
        (WebCore::FormDataElement::FormDataElement):
        * platform/DeprecatedString.cpp:
        * platform/DeprecatedString.h:
        * platform/IntPointArray.cpp: Removed.
        * platform/IntPointArray.h: Removed.
        * platform/TextEncoding.cpp:
        (WebCore::TextEncoding::toUnicode):
        * platform/TextEncoding.h:
        * platform/cairo/pixman/src/pixregion.c:
        * platform/cg/PathCG.cpp:
        (WebCore::Path::Path):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBorder):
        * rendering/RenderTable.h:
        (WebCore::RenderTable::colToEffCol):
        (WebCore::RenderTable::effColToCol):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::ensureRows):
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::setCellWidths):
        * rendering/RenderTableSection.h:
        * rendering/bidi.cpp:
        (WebCore::addMidpoint):
        (WebCore::RenderBlock::layoutInlineChildren):
        * rendering/render_form.cpp:
        (WebCore::RenderSelect::updateFromElement):
        (WebCore::RenderSelect::layout):
        (WebCore::RenderSelect::valueChanged):
        (WebCore::RenderSelect::selectionChanged):
        (WebCore::RenderSelect::updateSelection):
        * rendering/table_layout.cpp:
        (WebCore::FixedTableLayout::layout):
        * rendering/table_layout.h:
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::processSyncLoadResults):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 11 Jun 2006 23:58:53 +0000 (23:58 +0000)]
WebCore:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9394
        Fix no-SVG build

        * DerivedSources.make: Removed tabs. Create empty SVGElementFactory.cpp on no-svg build.
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Added #if SVG_SUPPORT/#endif.
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Ditto.
        * ksvg2/bindings/idl/svg/SVGAElement.idl: Add "Conditional=SVG" to all interfaces.
        * ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimateElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedRect.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedString.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGAnimationElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGCircleElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGClipPathElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGCursorElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGDefsElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGDescElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGElementInstance.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGElementInstanceList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGEllipseElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGEvent.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGException.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEBlendElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFECompositeElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFloodElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEImageElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEMergeElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFETileElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFilterElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGFitToViewBox.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGGElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGGradientElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGICCColor.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGImageElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLangSpace.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLengthList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLineElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGLocatable.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGMarkerElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGNumberList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPaint.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSeg.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPatternElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPointList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPolygonElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPolylineElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGRectElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGRenderingIntent.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGScriptElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGSetElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGStopElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGStringList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGStylable.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGStyleElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGSwitchElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGSymbolElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTSpanElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTests.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTextContentElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTextElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTitleElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTransformList.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGTransformable.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGURIReference.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGUnitTypes.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGUseElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGViewElement.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGZoomAndPan.idl: Ditto.
        * ksvg2/bindings/idl/svg/SVGZoomEvent.idl: Ditto.
        * ksvg2/svg/SVGAngle.idl: Ditto.
        * ksvg2/svg/SVGAnimatedLength.idl: Ditto.
        * ksvg2/svg/SVGColor.idl: Ditto.
        * ksvg2/svg/SVGDocument.idl: Ditto.
        * ksvg2/svg/SVGElement.idl: Ditto.
        * ksvg2/svg/SVGEvent.idl: Ditto.
        * ksvg2/svg/SVGLength.idl: Ditto.
        * ksvg2/svg/SVGMatrix.idl: Ditto.
        * ksvg2/svg/SVGNumber.idl: Ditto.
        * ksvg2/svg/SVGPoint.idl: Ditto.
        * ksvg2/svg/SVGRect.idl: Ditto.
        * ksvg2/svg/SVGSVGElement.idl: Ditto.
        * ksvg2/svg/SVGTransform.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Sun, 11 Jun 2006 23:49:28 +0000 (23:49 +0000)]
WebKitTools:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9395
        Make prepare-ChangeLog faster

        * Scripts/prepare-ChangeLog: Use "svn diff" instead of "svn stat" to find changed files,
        then save the diff output for reuse.  Keep a status variable if changes are made to
        LayoutTests so "svn diff LayoutTests" doesn't have to be run to check for changes when
        WebCore is updated.  Added -h|--help command-line switch and help message.  Move test
        for no changed files closer to the beginning of the program.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoves a hardcoded path I had added for testing.
thatcher [Sun, 11 Jun 2006 20:18:15 +0000 (20:18 +0000)]
Removes a hardcoded path I had added for testing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim H.
thatcher [Sun, 11 Jun 2006 20:10:35 +0000 (20:10 +0000)]
    Reviewed by Tim H.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8672
          Red outline from web inspector reappears after inspector is closed

        * WebInspector/WebInspector.m:
        (-[NSWindow windowWillClose:]): Added a call to setWebFrame to avoid further
        load progress notifications.
        (-[NSWindow setWebFrame:]): Changed to resign the WebView's hostWindow rather
        than its window for close notifications, to avoid resigning from all windows' close
        notifications (including the inspector window's) when the WebView is in a hidden tab.
        Also changed to prevent highlighting the initial focused node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Sun, 11 Jun 2006 19:49:17 +0000 (19:49 +0000)]
WebCore:

2006-06-11  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
        Move full-frame plugins to WebCore

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Add PluginDocument

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::redirectDataToPlugin):
        Call the bridge.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        Add redirectDataToPlugin which is used to redirect incoming data
        to a plugin.

        * bridge/mac/WebCoreViewFactory.h:
        Add pluginSupportsMIMEType which returns whether any plugins support a given MIME type.

        * dom/DOMImplementation.cpp:
        * dom/DOMImplementation.h:
        Get rid of createTextDocument and just create a text document explicitly when needed.

        * dom/Document.h:
        (WebCore::Document::isPluginDocument):
        * loader/PluginDocument.cpp: Added.
        (WebCore::PluginTokenizer::PluginTokenizer):
        (WebCore::PluginTokenizer::wantsRawData):
        (WebCore::PluginTokenizer::write):
        (WebCore::PluginTokenizer::createDocumentStructure):
        (WebCore::PluginTokenizer::writeRawData):
        (WebCore::PluginTokenizer::stopParsing):
        (WebCore::PluginTokenizer::finish):
        (WebCore::PluginTokenizer::isWaitingForScripts):
        (WebCore::PluginDocument::PluginDocument):
        (WebCore::PluginDocument::createTokenizer):
        * loader/PluginDocument.h: Added.
        (WebCore::PluginDocument::isPluginDocument):
        Add PluginDocument.

        * page/Frame.cpp:
        (WebCore::Frame::begin):
        Possibly create a plugin document.

        * page/Frame.h:
        (WebCore::Frame::redirectDataToPlugin):
        Add declaration.

        * platform/PlugInInfoStore.h:
        * platform/mac/PlugInInfoStoreMac.mm:
        (WebCore::PlugInInfoStore::supportsMIMEType):
        Ask WebCoreViewFactory if the MIME type is supported.

WebKit:

2006-06-11  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
        Move full-frame plugins to WebCore

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream instance]):
        Add instance method which returns the plugin instance.

        * Plugins/WebBasePluginPackage.h:
        Add WebPluginManualLoader protocol

        * Plugins/WebNetscapePluginDocumentView.h: Removed.
        * Plugins/WebNetscapePluginDocumentView.m: Removed.

        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:]):
        (-[WebNetscapePluginEmbeddedView dealloc]):
        (-[WebNetscapePluginEmbeddedView didStart]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedResponse:]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedData:]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedError:]):
        (-[WebNetscapePluginEmbeddedView pluginViewFinishedLoading:]):
        (-[WebNetscapePluginEmbeddedView redeliverStream]):
        Make WebNetscapePluginEmbeddedView support the WebPluginManualLoader protocol. It creates a plugin stream and feeds the
        data manually. Much of this code has been copied from WebNetscapePluginRepresentation.

        * Plugins/WebNetscapePluginRepresentation.h: Removed.
        * Plugins/WebNetscapePluginRepresentation.m: Removed.

        * Plugins/WebPluginController.h:
        * Plugins/WebPluginController.m:
        (-[WebPluginController pluginView:receivedResponse:]):
        (-[WebPluginController pluginView:receivedData:]):
        (-[WebPluginController pluginView:receivedError:]):
        (-[WebPluginController pluginViewFinishedLoading:]):
        Make WebPluginController support the WebPluginManualLoader protocol so it can feed data manually to WebKit plugins.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]):
        Use WebHTMLView and WebHTMLRepresentation when registering/unregistering plug-in MIME types.

        * Plugins/WebPluginDocumentView.h: Removed.
        * Plugins/WebPluginDocumentView.m: Removed.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
        Add loadManually argument.

        (-[WebFrameBridge redirectDataToPlugin:]):
        Call down to the HTML representation.

        (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
        Pass NO to loadManually.

        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        Explicitly check if the MIME type is supported by a plug-in instead of checking the view class.

        * WebCoreSupport/WebViewFactory.m:
        (-[WebViewFactory pluginSupportsMIMEType:]):
        New function which returns whether any plugins support a given MIME type.

        * WebKit.xcodeproj/project.pbxproj:
        Update for removed files.

        * WebView/WebFrame.m:
        (-[WebFrame _reloadForPluginChanges]):
        Remove view type checks.

        (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
        (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
        Remove FIXME comments.

        * WebView/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]):
        New function which redirects incoming data to a manual loader.

        (-[WebHTMLRepresentation receivedData:withDataSource:]):
        (-[WebHTMLRepresentation receivedError:withDataSource:]):
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
        Optionally redirect incoming data.

        * WebView/WebHTMLRepresentationPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 11 Jun 2006 04:07:11 +0000 (04:07 +0000)]
LayoutTests:

        Patch by mitzpettel.  Reviewed by hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9334
          Incomplete repaint when changing block from non-positioned to positioned

        * fast/repaint/static-to-positioned-expected.checksum: Added.
        * fast/repaint/static-to-positioned-expected.png: Added.
        * fast/repaint/static-to-positioned-expected.txt: Added.
        * fast/repaint/static-to-positioned.html: Added.

WebCore:

        Patch by mitzpettel.  Reviewed by hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9334
          Incomplete repaint when changing block from non-positioned to positioned

        Test: fast/repaint/static-to-positioned.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): If changing from static to positioned, repaint
        as static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 11 Jun 2006 03:46:22 +0000 (03:46 +0000)]
LayoutTests:

        Reviewed by hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9193
          REGRESSION: setting an opacity on an element with an outline causes the outline to disappear completely

        - test repainting of layer children's outlines that extend beyond the layer

        * fast/layers: Added.
        * fast/layers/opacity-outline-expected.checksum: Added.
        * fast/layers/opacity-outline-expected.png: Added.
        * fast/layers/opacity-outline-expected.txt: Added.
        * fast/layers/opacity-outline.html: Added.
        * fast/repaint/layer-child-outline-expected.checksum: Added.
        * fast/repaint/layer-child-outline-expected.png: Added.
        * fast/repaint/layer-child-outline-expected.txt: Added.
        * fast/repaint/layer-child-outline.html: Added.

WebCore:

        Reviewed by hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9193
          REGRESSION: setting an opacity on an element with an outline causes the outline to disappear completely

        Test: fast/layers/opacity-outline.html

        - fix repainting of layer children's outlines that extend beyond the layer

        Test: fast/repaint/layer-child-outline.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::intersectsDamageRect): Account for outlines.
        (WebCore::RenderLayer::absoluteBoundingBox): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::maximalOutlineSize): Changed to return the view's maximal
        outline size rather than 0 for PaintPhaseChildOutlines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-10 Steve Falkenburg <sfalken@apple.com>
sfalken [Sun, 11 Jun 2006 02:34:24 +0000 (02:34 +0000)]
2006-06-10  Steve Falkenburg  <sfalken@apple.com>

        Fix build break

        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::scale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Sat, 10 Jun 2006 16:09:27 +0000 (16:09 +0000)]
JavaScriptCore:

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515
        Linux porting compile bug

        Fix by Mike Emmel, Reviewed by Darin.

        * JavaScriptCoreSources.bkl:
        * jscore.bkl:
        * wtf/Platform.h:

WebCore:

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515
        Linux porting compile bug

        Fix by Mike Emmel, Reviewed by Darin.

        * Projects/gdk/webcore-gdk.bkl:
        * WebCoreSources.bkl:
        * css/maketokenizer:
        * html/HTMLCanvasElement.cpp:
        * html/HTMLImageElement.h:
        * icon/IconDatabase.cpp:
        * make-generated-sources.sh:
        * page/Frame.h:
        * page/FramePrivate.h:
        * platform/Cursor.h:
        * platform/FontData.h:
        (WebCore::FontData::getGlyphIndex):
        * platform/GlyphBuffer.h:
        (WebCore::GlyphBuffer::glyphAt):
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        * platform/GraphicsContext.h:
        * platform/PlatformKeyboardEvent.h:
        * platform/PlatformMouseEvent.h:
        * platform/PlatformWheelEvent.h:
        * platform/ScrollView.h:
        * platform/TransferJob.h:
        (WebCore::TransferJob::getInternal):
        * platform/TransferJobInternal.h:
        (WebCore::TransferJobInternal::TransferJobInternal):
        * platform/Widget.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::roundToDevicePixels):
        * webcore-base.bkl:
        * xpath/impl/XPathValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick and Dave Hyatt.
sullivan [Sat, 10 Jun 2006 13:42:45 +0000 (13:42 +0000)]
    Reviewed by Tim Omernick and Dave Hyatt.

        WebKit support for computing but not highlighting rects for text matches.

        * WebView/WebHTMLViewPrivate.h:
        added markedTextMatchesAreHighlighted/setMarkedTextMatchesAreHighlighted and
        rectsForTextMatches, and renamed related methods for clarity/consistency
        * WebView/WebHTMLView.m:
        (-[WebHTMLView markAllMatchesForText:caseSensitive:]):
        renamed, calls similarly-renamed method
        (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
        new method, calls through to bridge
        (-[WebHTMLView markedTextMatchesAreHighlighted]):
        ditto
        (-[WebHTMLView unmarkAllTextMatches]):
        renamed
        (-[WebHTMLView rectsForTextMatches]):
        new method, calls through to bridge

        * WebView/WebViewPrivate.h:
        added rectsForTextMatches, renamed other methods (and added highlight: parameter)
        * WebView/WebView.m:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:]):
        renamed for clarity/consistency, and now has highlight: parameter, which is passed down
        (-[WebView unmarkAllTextMatches]):
        renamed for clarity/consistency, and calls similarly-renamed method lower down. diff got
        confused with the end of this and the end of the next method.
        (-[WebView rectsForTextMatches]):
        new method, calls through to WebHTMLView as related methods currently do

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick and Dave Hyatt.
sullivan [Sat, 10 Jun 2006 13:42:23 +0000 (13:42 +0000)]
    Reviewed by Tim Omernick and Dave Hyatt.

        WebCore support for computing but not highlighting rects for text matches.

        * dom/Document.h:
        added setRenderedRectForMarker() and renderedRectsForMarkers(), and redefined
        MarkerMap to be a hashtable of node -> (pair of vectors), one vector of markers
        and one vector of rects

        * dom/Document.cpp:
        (placeholderRectForMarker()):
        new function, returns a recognizable degenerate rect used until a real rect has been set
        (WebCore::Document::addMarker):
        Reworked for new MarkerMap data structure; now adds parallel placeholder rect
        along with marker
        (WebCore::Document::copyMarkers):
        Reworked for new MarkerMap data structure
        (WebCore::Document::removeMarkers):
        Reworked for new MarkerMap data structure; now removed corresponding rect along
        with marker
        (WebCore::Document::markersForNode):
        Reworked for new MarkerMap data structure
        (WebCore::Document::renderedRectsForMarkers):
        New method, returns an array of all non-placeholder rects for the given marker type
        (WebCore::Document::repaintMarkers):
        Reworked for new MarkerMap data structure
        (WebCore::Document::setRenderedRectForMarker):
        New method, sets the rendered rect for a given marker
        (WebCore::Document::shiftMarkers):
        Reworked for new MarkerMap data structure; resets rendered rects to placeholders.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        removed markedTextMatchesAreHighlighted guard; we always want to call paintTextMatchMarker
        now, but sometimes we will end up only computing the rect, not actually highlighting it.
        (Maybe some names should be improved here?)
        (WebCore::InlineTextBox::paintTextMatchMarker):
        Reorganized to move all the code that actually draws into a block that's guarded by
        markedTextMatchesAreHighlighted. The rest of the code computes where the highlight will
        go, and now we always use that computation in order to call setRenderedRectForMarker.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge rectsForTextMatches]):
        New method, returns an array of NSValues representing NSRects. Gets them
        from Document::renderedRectsForMarkers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <http://bugzilla.opendarwin.org/show_bug.cgi?id=9384>
sullivan [Sat, 10 Jun 2006 13:38:38 +0000 (13:38 +0000)]
    <bugzilla.opendarwin.org/show_bug.cgi?id=9384>
        WebView's initWithCoder: method does not set useBackForwardList
        correctly

        Reviewed by John Sullivan.

        * WebView/WebView.m:
        (-[WebView initWithCoder:]):
        Make sure that the function variable useBackForwardList is correctly
        set, so that the copy in the _private ivar is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-10 Mitz Pettel <opendarwin.org@mitzpettel.com>
ap [Sat, 10 Jun 2006 10:24:10 +0000 (10:24 +0000)]
2006-06-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by ap.

        - make DumpRenderTree build

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Changed _updateFocusState to _updateActiveState
        (-[WaitUntilDoneDelegate webViewFocus:]): Ditto.
        (-[LayoutTestController setWindowIsKey:]): Ditto.
        (-[LayoutTestController setMainFrameIsFirstResponder:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-10 Anders Carlsson <acarlsson@apple.com>
andersca [Sat, 10 Jun 2006 09:59:44 +0000 (09:59 +0000)]
2006-06-10  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Eric.

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLElement::put):
        Call WebCore::JSHTMLElement::put so that autogenerated setters will work
        for HTMLElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix -- I think :).
ggaren [Sat, 10 Jun 2006 04:52:43 +0000 (04:52 +0000)]
    Build fix -- I think :).

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/context.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Build fix after last JSC check-in (oops!)
ggaren [Sat, 10 Jun 2006 04:34:00 +0000 (04:34 +0000)]
    - Build fix after last JSC check-in (oops!)

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric (yay!).
ggaren [Sat, 10 Jun 2006 03:57:13 +0000 (03:57 +0000)]
    Reviewed by Eric (yay!).

        - Removed Context wrapper for ContextImp, renamed ContextImp to Context,
        split Context into its own file -- Context.cpp -- renamed _var to m_var,
        change ' *' to '* '.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Context.cpp: Added.
        (KJS::Context::Context):
        (KJS::Context::~Context):
        (KJS::Context::mark):
        * kjs/context.h:
        (KJS::Context::scopeChain):
        (KJS::Context::variableObject):
        (KJS::Context::setVariableObject):
        (KJS::Context::thisValue):
        (KJS::Context::callingContext):
        (KJS::Context::activationObject):
        (KJS::Context::currentBody):
        (KJS::Context::function):
        (KJS::Context::arguments):
        (KJS::Context::pushScope):
        (KJS::Context::seenLabels):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::argumentsGetter):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/internal.cpp:
        (KJS::InterpreterImp::evaluate):
        * kjs/internal.h:
        (KJS::InterpreterImp::setContext):
        (KJS::InterpreterImp::context):
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        (KJS::ExecState::context):
        (KJS::ExecState::ExecState):
        * kjs/nodes.cpp:
        (currentSourceId):
        (currentSourceURL):
        (ThisNode::evaluate):
        (ResolveNode::evaluate):
        (FunctionCallResolveNode::evaluate):
        (PostfixResolveNode::evaluate):
        (DeleteResolveNode::evaluate):
        (TypeOfResolveNode::evaluate):
        (PrefixResolveNode::evaluate):
        (AssignResolveNode::evaluate):
        (VarDeclNode::evaluate):
        (VarDeclNode::processVarDecls):
        (DoWhileNode::execute):
        (WhileNode::execute):
        (ForNode::execute):
        (ForInNode::execute):
        (ContinueNode::execute):
        (BreakNode::execute):
        (ReturnNode::execute):
        (WithNode::execute):
        (SwitchNode::execute):
        (LabelNode::execute):
        (TryNode::execute):
        (FuncDeclNode::processFuncDecl):
        (FuncExprNode::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@14798 268f45cc-cd09-0410...
justing [Sat, 10 Jun 2006 03:09:09 +0000 (03:09 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix win32 build bustage.
hyatt [Sat, 10 Jun 2006 00:01:07 +0000 (00:01 +0000)]
Fix win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename updateFocusState to updateActiveState.
hyatt [Fri, 9 Jun 2006 23:37:58 +0000 (23:37 +0000)]
    Rename updateFocusState to updateActiveState.

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateActiveState]):
        (-[NSArray viewDidMoveToWindow]):
        (-[NSArray windowDidBecomeKey:]):
        (-[NSArray windowDidResignKey:]):
        (-[NSArray becomeFirstResponder]):
        (-[NSArray resignFirstResponder]):
        (-[WebHTMLView _formControlIsBecomingFirstResponder:]):
        (-[WebHTMLView _formControlIsResigningFirstResponder:]):
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename m_isFocused on the frame to m_isActive, since it isn't really
hyatt [Fri, 9 Jun 2006 23:26:57 +0000 (23:26 +0000)]
    Rename m_isFocused on the frame to m_isActive, since it isn't really
        about focus but is instead about whether or not the top-level window is
        active.

        Pull code that was incorrectly factored into Mac-only code out of FrameMac
        and back up into Frame.

        Reviewed by andersca

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        * page/Frame.cpp:
        (WebCore::Frame::setFocusNodeIfNeeded):
        (WebCore::Frame::isActive):
        (WebCore::Frame::setIsActive):
        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win32 build bustage.
hyatt [Fri, 9 Jun 2006 23:07:42 +0000 (23:07 +0000)]
Fix Win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoves some control characters that snuck in.
thatcher [Fri, 9 Jun 2006 21:25:34 +0000 (21:25 +0000)]
Removes some control characters that snuck in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14785 268f45cc-cd09-0410-ab3c-d52691b4dbfc