WebKit-https.git
9 years agoFix tyop.
andersca@apple.com [Sat, 29 Jan 2011 00:08:55 +0000 (00:08 +0000)]
Fix tyop.

* Shared/mac/CoreAnimationRenderer.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 29 Jan 2011 00:06:49 +0000 (00:06 +0000)]
2011-01-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add CoreAnimationRenderer class
        https://bugs.webkit.org/show_bug.cgi?id=53343

        * Shared/mac/CoreAnimationRenderer.h: Added.
        * Shared/mac/CoreAnimationRenderer.mm: Added.

        (WebKit::CoreAnimationRenderer::CoreAnimationRenderer):
        Initialize the underlying CARenderer object and hook up a notification observer.

        (WebKit::CoreAnimationRenderer::~CoreAnimationRenderer):
        Assert that the client is null. It has been set to null by the call to invalidate().

        (WebKit::CoreAnimationRenderer::setBounds):
        Update the bounds on the CARenderer and the root layer.

        (WebKit::CoreAnimationRenderer::render):
        Ask the renderer to render and return the next frame time.

        (WebKit::CoreAnimationRenderer::invalidate):
        Remove the change observer and reset the client.

        (WebKit::CoreAnimationRenderer::rendererDidChange):
        Call the client member function.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 28 Jan 2011 23:42:37 +0000 (23:42 +0000)]
2011-01-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add an OBJC_CLASS macro for forward declaring an Objective-C class
        https://bugs.webkit.org/show_bug.cgi?id=53337

        * Shared/NativeWebKeyboardEvent.h:
        * Shared/PrintInfo.h:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        * UIProcess/LayerBackedDrawingAreaProxy.h:
        * UIProcess/WebInspectorProxy.h:
        * UIProcess/mac/WebContextMenuProxyMac.h:
        * UIProcess/mac/WebPopupMenuProxyMac.h:
        * WebProcess/Downloads/Download.h:
        * WebProcess/Plugins/PluginProxy.h:
        * WebProcess/WebPage/LayerBackedDrawingArea.h:
        * WebProcess/WebPage/WebPage.h:
        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 28 Jan 2011 23:39:54 +0000 (23:39 +0000)]
2011-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Convert markstack to a slot visitor API
        https://bugs.webkit.org/show_bug.cgi?id=53219

        Move the MarkStack over to a slot based marking API.

        In order to avoiding aliasing concerns there are two new types
        that need to be used when holding on to JSValues and JSCell that
        need to be marked: WriteBarrier and DeprecatedPtr.  WriteBarrier
        is expected to be used for any JSValue or Cell that's lifetime and
        marking is controlled by another GC object.  DeprecatedPtr is used
        for any value that we need to rework ownership for.

        The change over to this model has produced a large amount of
        code changes, but they are mostly mechanical (forwarding JSGlobalData,
        etc).

        * API/JSCallbackObject.h:
        (JSC::JSCallbackObjectData::setPrivateProperty):
        (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
        (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
        (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren):
        (JSC::JSCallbackObject::setPrivateProperty):
        * API/JSCallbackObjectFunctions.h:
        (JSC::::put):
        (JSC::::staticFunctionGetter):
        * API/JSObjectRef.cpp:
        (JSObjectMakeConstructor):
        (JSObjectSetPrivateProperty):
        * API/JSWeakObjectMapRefInternal.h:
        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::markAggregate):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::globalObject):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
        (JSC::BytecodeGenerator::findScopedProperty):
        * debugger/DebuggerActivation.cpp:
        (JSC::DebuggerActivation::DebuggerActivation):
        (JSC::DebuggerActivation::markChildren):
        * debugger/DebuggerActivation.h:
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::resolve):
        (JSC::Interpreter::resolveSkip):
        (JSC::Interpreter::resolveGlobalDynamic):
        (JSC::Interpreter::resolveBaseAndProperty):
        (JSC::Interpreter::unwindCallFrame):
        (JSC::appendSourceToError):
        (JSC::Interpreter::execute):
        (JSC::Interpreter::privateExecute):
        * interpreter/Register.h:
        (JSC::Register::jsValueSlot):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::DEFINE_STUB_FUNCTION):
        * jsc.cpp:
        (GlobalObject::GlobalObject):
        * runtime/Arguments.cpp:
        (JSC::Arguments::markChildren):
        (JSC::Arguments::getOwnPropertySlot):
        (JSC::Arguments::getOwnPropertyDescriptor):
        (JSC::Arguments::put):
        * runtime/Arguments.h:
        (JSC::Arguments::setActivation):
        (JSC::Arguments::Arguments):
        * runtime/ArrayConstructor.cpp:
        (JSC::ArrayConstructor::ArrayConstructor):
        (JSC::constructArrayWithSizeQuirk):
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncSplice):
        * runtime/BatchedTransitionOptimizer.h:
        (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
        (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
        * runtime/BooleanConstructor.cpp:
        (JSC::BooleanConstructor::BooleanConstructor):
        (JSC::constructBoolean):
        (JSC::constructBooleanFromImmediateBoolean):
        * runtime/BooleanPrototype.cpp:
        (JSC::BooleanPrototype::BooleanPrototype):
        * runtime/ConservativeSet.h:
        (JSC::ConservativeSet::mark):
        * runtime/DateConstructor.cpp:
        (JSC::DateConstructor::DateConstructor):
        * runtime/DateInstance.cpp:
        (JSC::DateInstance::DateInstance):
        * runtime/DatePrototype.cpp:
        (JSC::dateProtoFuncSetTime):
        (JSC::setNewValueFromTimeArgs):
        (JSC::setNewValueFromDateArgs):
        (JSC::dateProtoFuncSetYear):
        * runtime/ErrorConstructor.cpp:
        (JSC::ErrorConstructor::ErrorConstructor):
        * runtime/ErrorInstance.cpp:
        (JSC::ErrorInstance::ErrorInstance):
        * runtime/ErrorPrototype.cpp:
        (JSC::ErrorPrototype::ErrorPrototype):
        * runtime/FunctionConstructor.cpp:
        (JSC::FunctionConstructor::FunctionConstructor):
        * runtime/FunctionPrototype.cpp:
        (JSC::FunctionPrototype::FunctionPrototype):
        * runtime/GetterSetter.cpp:
        (JSC::GetterSetter::markChildren):
        * runtime/GetterSetter.h:
        (JSC::GetterSetter::GetterSetter):
        (JSC::GetterSetter::getter):
        (JSC::GetterSetter::setGetter):
        (JSC::GetterSetter::setter):
        (JSC::GetterSetter::setSetter):
        * runtime/GlobalEvalFunction.cpp:
        (JSC::GlobalEvalFunction::GlobalEvalFunction):
        (JSC::GlobalEvalFunction::markChildren):
        * runtime/GlobalEvalFunction.h:
        (JSC::GlobalEvalFunction::cachedGlobalObject):
        * runtime/Heap.cpp:
        (JSC::Heap::markProtectedObjects):
        (JSC::Heap::markTempSortVectors):
        (JSC::Heap::markRoots):
        * runtime/InternalFunction.cpp:
        (JSC::InternalFunction::InternalFunction):
        * runtime/JSAPIValueWrapper.h:
        (JSC::JSAPIValueWrapper::value):
        (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::put):
        * runtime/JSArray.cpp:
        (JSC::JSArray::JSArray):
        (JSC::JSArray::getOwnPropertySlot):
        (JSC::JSArray::getOwnPropertyDescriptor):
        (JSC::JSArray::put):
        (JSC::JSArray::putSlowCase):
        (JSC::JSArray::deleteProperty):
        (JSC::JSArray::increaseVectorLength):
        (JSC::JSArray::setLength):
        (JSC::JSArray::pop):
        (JSC::JSArray::push):
        (JSC::JSArray::unshiftCount):
        (JSC::JSArray::sort):
        (JSC::JSArray::fillArgList):
        (JSC::JSArray::copyToRegisters):
        (JSC::JSArray::compactForSorting):
        * runtime/JSArray.h:
        (JSC::JSArray::getIndex):
        (JSC::JSArray::setIndex):
        (JSC::JSArray::uncheckedSetIndex):
        (JSC::JSArray::markChildrenDirect):
        * runtime/JSByteArray.cpp:
        (JSC::JSByteArray::JSByteArray):
        * runtime/JSCell.h:
        (JSC::JSCell::MarkStack::append):
        (JSC::JSCell::MarkStack::appendCell):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):
        (JSC::JSFunction::getOwnPropertySlot):
        * runtime/JSGlobalObject.cpp:
        (JSC::markIfNeeded):
        (JSC::JSGlobalObject::reset):
        (JSC::JSGlobalObject::resetPrototype):
        (JSC::JSGlobalObject::markChildren):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (JSC::JSGlobalObject::regExpConstructor):
        (JSC::JSGlobalObject::errorConstructor):
        (JSC::JSGlobalObject::evalErrorConstructor):
        (JSC::JSGlobalObject::rangeErrorConstructor):
        (JSC::JSGlobalObject::referenceErrorConstructor):
        (JSC::JSGlobalObject::syntaxErrorConstructor):
        (JSC::JSGlobalObject::typeErrorConstructor):
        (JSC::JSGlobalObject::URIErrorConstructor):
        (JSC::JSGlobalObject::evalFunction):
        (JSC::JSGlobalObject::objectPrototype):
        (JSC::JSGlobalObject::functionPrototype):
        (JSC::JSGlobalObject::arrayPrototype):
        (JSC::JSGlobalObject::booleanPrototype):
        (JSC::JSGlobalObject::stringPrototype):
        (JSC::JSGlobalObject::numberPrototype):
        (JSC::JSGlobalObject::datePrototype):
        (JSC::JSGlobalObject::regExpPrototype):
        (JSC::JSGlobalObject::methodCallDummy):
        (JSC::constructArray):
        * runtime/JSONObject.cpp:
        (JSC::Stringifier::Holder::object):
        (JSC::Stringifier::Holder::objectSlot):
        (JSC::Stringifier::markAggregate):
        (JSC::Stringifier::stringify):
        (JSC::Stringifier::Holder::appendNextProperty):
        (JSC::Walker::callReviver):
        (JSC::Walker::walk):
        * runtime/JSObject.cpp:
        (JSC::JSObject::defineGetter):
        (JSC::JSObject::defineSetter):
        (JSC::JSObject::removeDirect):
        (JSC::JSObject::putDirectFunction):
        (JSC::JSObject::putDirectFunctionWithoutTransition):
        (JSC::putDescriptor):
        (JSC::JSObject::defineOwnProperty):
        * runtime/JSObject.h:
        (JSC::JSObject::putDirectOffset):
        (JSC::JSObject::putUndefinedAtDirectOffset):
        (JSC::JSObject::flattenDictionaryObject):
        (JSC::JSObject::putDirectInternal):
        (JSC::JSObject::putDirect):
        (JSC::JSObject::putDirectFunction):
        (JSC::JSObject::putDirectWithoutTransition):
        (JSC::JSObject::putDirectFunctionWithoutTransition):
        (JSC::JSValue::putDirect):
        (JSC::JSObject::allocatePropertyStorageInline):
        (JSC::JSObject::markChildrenDirect):
        * runtime/JSStaticScopeObject.cpp:
        (JSC::JSStaticScopeObject::markChildren):
        * runtime/JSString.cpp:
        (JSC::StringObject::create):
        * runtime/JSValue.h:
        * runtime/JSWrapperObject.cpp:
        (JSC::JSWrapperObject::markChildren):
        * runtime/JSWrapperObject.h:
        (JSC::JSWrapperObject::internalValue):
        (JSC::JSWrapperObject::setInternalValue):
        * runtime/LiteralParser.cpp:
        (JSC::LiteralParser::parse):
        * runtime/Lookup.cpp:
        (JSC::setUpStaticFunctionSlot):
        * runtime/Lookup.h:
        (JSC::lookupPut):
        * runtime/MarkStack.h:
        * runtime/MathObject.cpp:
        (JSC::MathObject::MathObject):
        * runtime/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::NativeErrorConstructor):
        * runtime/NativeErrorPrototype.cpp:
        (JSC::NativeErrorPrototype::NativeErrorPrototype):
        * runtime/NumberConstructor.cpp:
        (JSC::NumberConstructor::NumberConstructor):
        (JSC::constructWithNumberConstructor):
        * runtime/NumberObject.cpp:
        (JSC::constructNumber):
        * runtime/NumberPrototype.cpp:
        (JSC::NumberPrototype::NumberPrototype):
        * runtime/ObjectConstructor.cpp:
        (JSC::ObjectConstructor::ObjectConstructor):
        (JSC::objectConstructorGetOwnPropertyDescriptor):
        * runtime/Operations.h:
        (JSC::normalizePrototypeChain):
        (JSC::resolveBase):
        * runtime/PrototypeFunction.cpp:
        (JSC::PrototypeFunction::PrototypeFunction):
        * runtime/PutPropertySlot.h:
        (JSC::PutPropertySlot::setExistingProperty):
        (JSC::PutPropertySlot::setNewProperty):
        (JSC::PutPropertySlot::base):
        * runtime/RegExpConstructor.cpp:
        (JSC::RegExpConstructor::RegExpConstructor):
        * runtime/ScopeChain.cpp:
        (JSC::ScopeChainNode::print):
        * runtime/ScopeChain.h:
        (JSC::ScopeChainNode::~ScopeChainNode):
        (JSC::ScopeChainIterator::operator*):
        (JSC::ScopeChainIterator::operator->):
        (JSC::ScopeChain::top):
        * runtime/ScopeChainMark.h:
        (JSC::ScopeChain::markAggregate):
        * runtime/SmallStrings.cpp:
        (JSC::isMarked):
        (JSC::SmallStrings::markChildren):
        * runtime/SmallStrings.h:
        (JSC::SmallStrings::emptyString):
        (JSC::SmallStrings::singleCharacterString):
        (JSC::SmallStrings::singleCharacterStrings):
        * runtime/StringConstructor.cpp:
        (JSC::StringConstructor::StringConstructor):
        * runtime/StringObject.cpp:
        (JSC::StringObject::StringObject):
        * runtime/StringObject.h:
        * runtime/StringPrototype.cpp:
        (JSC::StringPrototype::StringPrototype):
        * runtime/Structure.cpp:
        (JSC::Structure::flattenDictionaryStructure):
        * runtime/Structure.h:
        (JSC::Structure::storedPrototypeSlot):
        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::uncheckedGet):
        (JSC::WeakGCMap::uncheckedGetSlot):
        (JSC::::get):
        (JSC::::take):
        (JSC::::set):
        (JSC::::uncheckedRemove):
        * runtime/WriteBarrier.h: Added.
        (JSC::DeprecatedPtr::DeprecatedPtr):
        (JSC::DeprecatedPtr::get):
        (JSC::DeprecatedPtr::operator*):
        (JSC::DeprecatedPtr::operator->):
        (JSC::DeprecatedPtr::slot):
        (JSC::DeprecatedPtr::operator UnspecifiedBoolType*):
        (JSC::DeprecatedPtr::operator!):
        (JSC::WriteBarrierBase::set):
        (JSC::WriteBarrierBase::get):
        (JSC::WriteBarrierBase::operator*):
        (JSC::WriteBarrierBase::operator->):
        (JSC::WriteBarrierBase::slot):
        (JSC::WriteBarrierBase::operator UnspecifiedBoolType*):
        (JSC::WriteBarrierBase::operator!):
        (JSC::WriteBarrier::WriteBarrier):
        (JSC::operator==):
2011-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Convert markstack to a slot visitor API
        https://bugs.webkit.org/show_bug.cgi?id=53219

        There's no reason to recurse here, the value we
        were marking was protected.

        * JSValueWrapper.cpp:
        (JSValueWrapper::JSObjectMark):
2011-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Convert markstack to a slot visitor API
        https://bugs.webkit.org/show_bug.cgi?id=53219

        Update WebCore to the new marking apis, correct bindings
        codegen.

        * ForwardingHeaders/runtime/WriteBarrier.h: Added.
        * WebCore.exp.in:
        * bindings/js/DOMWrapperWorld.h:
        (WebCore::DOMWrapperWorld::globalData):
        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::markDOMNodesForDocument):
        (WebCore::markDOMObjectWrapper):
        (WebCore::markDOMNodeWrapper):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::markChildren):
        (WebCore::JSDOMGlobalObject::setInjectedScript):
        (WebCore::JSDOMGlobalObject::injectedScript):
        * bindings/js/JSDOMGlobalObject.h:
        (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
        (WebCore::getDOMConstructor):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation):
        (WebCore::DialogHandler::dialogCreated):
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::JSDOMWindowShell):
        (WebCore::JSDOMWindowShell::setWindow):
        (WebCore::JSDOMWindowShell::markChildren):
        (WebCore::JSDOMWindowShell::unwrappedObject):
        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::window):
        (WebCore::JSDOMWindowShell::setWindow):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::JSEventListener):
        (WebCore::JSEventListener::markJSFunction):
        * bindings/js/JSEventListener.h:
        (WebCore::JSEventListener::jsFunction):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::setAll):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor):
        * bindings/js/JSImageDataCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeChain):
        (WebCore::JSJavaScriptCallFrame::scopeType):
        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::markAggregate):
        (WebCore::JSNodeFilterCondition::acceptNode):
        * bindings/js/JSNodeFilterCondition.h:
        * bindings/js/JSNodeFilterCustom.cpp:
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor):
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        (WebCore::JSSQLResultSetRowList::item):
        * bindings/js/ScriptCachedFrameData.cpp:
        (WebCore::ScriptCachedFrameData::restore):
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptGlobalObject::set):
        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneDeserializer::putProperty):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.h:
2011-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Convert markstack to a slot visitor API
        https://bugs.webkit.org/show_bug.cgi?id=53219

        Update to new marking api

        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame scopeChain]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 28 Jan 2011 23:33:27 +0000 (23:33 +0000)]
2011-01-28  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: change worker model values to
        "old-inline", "old-threads" in preparation for test_runner2 /
        multiprocessing changes.

        https://bugs.webkit.org/show_bug.cgi?id=53156

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoKeyboard scrolling doesn’t work in WebKit2
weinig@apple.com [Fri, 28 Jan 2011 23:21:00 +0000 (23:21 +0000)]
Keyboard scrolling doesn’t work in WebKit2
<rdar://problem/8909672>

Reviewed by Anders Carlsson.

* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
Add additional necessary delegate methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't put config.h in the message headers.
andersca@apple.com [Fri, 28 Jan 2011 23:12:47 +0000 (23:12 +0000)]
Don't put config.h in the message headers.

Reviewed by Sam Weinig.

* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-land this patch with the missing null check that caused crashes in layout tests.
darin@apple.com [Fri, 28 Jan 2011 23:12:32 +0000 (23:12 +0000)]
Re-land this patch with the missing null check that caused crashes in layout tests.

Reviewed by Dan Bernstein.

Changing cursor style has no effect until the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=14344
rdar://problem/7563712

No tests added because we don't have infrastructure for testing actual cursor
changes (as opposed to cursor style computation) at this time. We might add it later.

* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.
* page/EventHandler.h: Ditto.

* rendering/RenderObject.cpp:
(WebCore::areNonIdenticalCursorListsEqual): Added.
(WebCore::areCursorsEqual): Added.
(WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if
cursor styles changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 28 Jan 2011 23:12:27 +0000 (23:12 +0000)]
2011-01-28  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        committers.py - add an IRC nickname for dpranke
        https://bugs.webkit.org/show_bug.cgi?id=53335

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Fri, 28 Jan 2011 23:03:16 +0000 (23:03 +0000)]
Fix build.

* Shared/mac/ShareableSurface.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to unbreak the Windows build.
andersca@apple.com [Fri, 28 Jan 2011 22:55:13 +0000 (22:55 +0000)]
Try to unbreak the Windows build.

* UIProcess/cf/WebPageProxyCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 28 Jan 2011 22:51:09 +0000 (22:51 +0000)]
2011-01-28  Tony Chang  <tony@chromium.org>

        Unreviewed, a chromium win/linux rebaseline.  The mac result was
        rebaselined in r76735.

        * platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.checksum:
        * platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.png:
        * platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.checksum:
        * platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
        * platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=53330
beidson@apple.com [Fri, 28 Jan 2011 22:48:35 +0000 (22:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53330
Need InjectedBundle API to get the response MIMEType for a URL

Reviewed by John Sullivan.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyMIMETypeForResourceWithURL):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Get the MIMEType from the in-memory cache, or cachedResponseMIMETypeForURL() if not available:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::mimeTypeForResourceWithURL):
* WebProcess/WebPage/WebFrame.h:

Get the MIMEType from the platform's disk cache if available:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::cachedResponseMIMETypeForURL):
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::cachedResponseMIMETypeForURL):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::cachedResponseMIMETypeForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up the mess introduced when config.h was added to the project:
andersca@apple.com [Fri, 28 Jan 2011 22:31:11 +0000 (22:31 +0000)]
Clean up the mess introduced when config.h was added to the project:

Reviewed by Sam Weinig.

- Remove the contents of WebKit2Prefix.h that is now in config.h, to avoid including everything
  twice in each file, probably slowing down compile time.

- Add config.h to all the files that were forgotten in order to keep the build from breaking.

- Added trap to ensure that config.h is included at the top of every implementation file. If this
  had been added it would have caught the previous issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 28 Jan 2011 22:26:19 +0000 (22:26 +0000)]
2011-01-28  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Eric Seidel.

        We should hold RefPtrs to SVG font faces
        https://bugs.webkit.org/show_bug.cgi?id=53270

        * svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Added.
        * svg/custom/use-multiple-on-nested-disallowed-font.html: Added.
2011-01-28  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Eric Seidel.

        We should hold RefPtrs to SVG font faces
        https://bugs.webkit.org/show_bug.cgi?id=53270

        Test: svg/custom/use-multiple-on-nested-disallowed-font.html

        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::getFontData):
        * css/CSSFontFaceSource.h:
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::associatedFontElement):
        * svg/SVGFontFaceElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8857651> Implement unregisterWorld for WebKit2
slewis@apple.com [Fri, 28 Jan 2011 22:26:06 +0000 (22:26 +0000)]
<rdar://problem/8857651> Implement unregisterWorld for WebKit2
Rename unregisterWorld to clearWrappers.  Clearing the wrappers reduces the
memory use of isolated worlds.

Reviewed by Geoff Garen.

* WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldClearWrappers):
* WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
* WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
(WebKit::InjectedBundleScriptWorld::clearWrappers):
* WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 22:20:31 +0000 (22:20 +0000)]
2011-01-28  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        uniformN*v should generate INVALID_VALUE of the array size is not a multiple of N
        https://bugs.webkit.org/show_bug.cgi?id=53306

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
2011-01-28  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        uniformN*v should generate INVALID_VALUE of the array size is not a multiple of N
        https://bugs.webkit.org/show_bug.cgi?id=53306

        * fast/canvas/webgl/gl-uniform-arrays-expected.txt:
        * fast/canvas/webgl/gl-uniform-arrays.html:
        * fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt:
        * fast/canvas/webgl/gl-uniformmatrix4fv.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Tom Sepez <tsepez@chromium.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 22:17:24 +0000 (22:17 +0000)]
2011-01-28  Tom Sepez  <tsepez@chromium.org>

        Reviewed by Eric Seidel.

        NULL pointer crash in TextIterator::handleTextBox()
        https://bugs.webkit.org/show_bug.cgi?id=53267

        * fast/css/rtl-nth-child-first-letter-crash-expected.txt: Added.
        * fast/css/rtl-nth-child-first-letter-crash.html: Added.
2011-01-28  Tom Sepez  <tsepez@chromium.org>

        Reviewed by Eric Seidel.

        NULL pointer crash in TextIterator::handleTextBox()
        https://bugs.webkit.org/show_bug.cgi?id=53267

        Test: fast/css/rtl-nth-child-first-letter-crash.html

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::handleTextBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 22:08:41 +0000 (22:08 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Skip webkitAudioPannerNode from the test. It's not yet implemented across
        all ports/platforms.

        * fast/dom/script-tests/prototype-inheritance.js: Skipped webkitAudioPannerNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 28 Jan 2011 21:55:49 +0000 (21:55 +0000)]
2011-01-28  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Remove a spurious diagnostic CRASH check.
        https://bugs.webkit.org/show_bug.cgi?id=52379

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: <rdar://problem/4761512> <select> can't display right-to-left (rtl...
mitz@apple.com [Fri, 28 Jan 2011 21:34:55 +0000 (21:34 +0000)]
Source/WebCore: <rdar://problem/4761512> <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

Changed <select> pop-up menus on Mac OS X Snow Leopard and later to have their items aligned in the
direction corresponding to the writing direction of the <select> element, with the checkmarks
on the "start" side, and use the <option>'s writing direction rather than "natural". Made the
pop-up button match the menu by adding a Chrome boolean function, selectItemAlignmentFollowsMenuWritingDirection(),
which returns true for this pop-up behavior.

* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
* manual-tests/pop-up-alignment-and-direction.html: Added.
* page/Chrome.cpp:
(WebCore::Chrome::selectItemAlignmentFollowsMenuWritingDirection): Added. Calls through to the
client.
* page/Chrome.h:
* page/ChromeClient.h:
* platform/PopupMenuStyle.h:
(WebCore::PopupMenuStyle::PopupMenuStyle): Added hasTextDirectionOverride parameter and member
variable initialization.
(WebCore::PopupMenuStyle::hasTextDirectionOverride): Added this accessor.
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate): Set the pop-up's layout direction and items' text alignment
to match the menu's writing direction. Set items' writing direction and direction override
according to their styles.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList): Removed unncesaary initialization of a smart pointer.
(WebCore::RenderMenuList::adjustInnerStyle): If the alignment of items in the menu follows the
menu's writing direction, use that alignment for the button as well. Also in this mode, use the
item's writing direction and override setting.
(WebCore::RenderMenuList::setTextFromOption): Store the option element's style.
(WebCore::RenderMenuList::itemStyle): Pass the text direction override value.
(WebCore::RenderMenuList::menuStyle): Ditto. Also use the button's direction, not the inner text's.
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::menuStyle): Pass the text direction override value.

Source/WebKit/chromium: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* src/AutoFillPopupMenuClient.cpp:
(WebKit::AutoFillPopupMenuClient::initialize): Pass hasTextDirectionOverride to the PopupMenuStyle
constructor.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Added.
* src/ChromeClientImpl.h:
* tests/PopupMenuTest.cpp:
(WebKit::TestPopupMenuClient::itemStyle): Pass hasTextDirectionOverride to the PopupMenuStyle
constructor.

Source/WebKit/efl: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.

Source/WebKit/qt: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebKitSupport/ChromeClientWx.h:

Source/WebKit2: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

* Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::WebPopupItem): Added initializers for m_textDirection and m_hasTextDirectionOverride.
(WebKit::WebPopupItem::encode): Encode the item's writing direction and direction override values.
(WebKit::WebPopupItem::decode): Decode the item's writing direction and direction override values.
* Shared/WebPopupItem.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu): Added a parameter for the menu's text direction.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Ditto.
* UIProcess/WebPopupMenuProxy.h:
* UIProcess/mac/WebPopupMenuProxyMac.h:
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::populate): Added a parameter for the menu's text direction.
Set items' text alignment to match the menu's writing direction. Set items' writing direction
and direction override according to their styles.
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Set the pop-up's layout direction.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::populateItems): Initialize items' writing direction and direction override
values.
(WebKit::WebPopupMenu::show): Pass the menu's writing direction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 28 Jan 2011 21:34:02 +0000 (21:34 +0000)]
2011-01-28  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: add a "mock DRT" port implementation
        and a separate class that emulates what we expect the
        DumpRenderTree behavior to be.

        This will eventually replace port/dryrun.py and allow us to get
        better test coverage of the new-run-webkit-tests code as well as
        a reference for what new-run-webkit-tests expects from DRT.

        This is the first attempt at this, and it is pretty bare-boned. It
        really only has been tested on the 'mac' port (and a little on
        the 'chromium-mac' port.

        https://bugs.webkit.org/show_bug.cgi?id=53126

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/port/test.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 28 Jan 2011 21:31:06 +0000 (21:31 +0000)]
2011-01-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Teach XSSFilter how to filter <script> elements
        https://bugs.webkit.org/show_bug.cgi?id=53279

        This patch adds the ability for the XSSFilter to block injected
        <script> elements.  Handling script elements is slightly subtle because
        these elements act very differently depending on whether they have a
        src attribute.

        In the "src case", which check whether the src attribute was present in
        the request.  In the "non-src case", we check whether the start tag and
        the body of the script element was included in the request.  Checking
        for the whole start tag means we miss out on some attribute splitting
        attacks inside of script tags, but that doesn't seem like that big a
        deal.

        This patch also introduces some amount of state into the XSSFilter
        because inline script elements span multiple tokens.  There's a lot of
        tuning and optimization left in these cases, some of which I've noted
        with FIXMEs.

        To test this patch, I played around with some of the existing
        XSSAuditor tests.  Hopefully I'll be able to run the test suite more
        systematically in the future.

        * html/parser/HTMLToken.h:
        (WebCore::HTMLToken::eraseCharacters):
        (WebCore::HTMLToken::eraseValueOfAttribute):
        * html/parser/XSSFilter.cpp:
        (WebCore::HTMLNames::hasName):
        (WebCore::HTMLNames::findAttributeWithName):
        (WebCore::HTMLNames::isNameOfScriptCarryingAttribute):
        (WebCore::XSSFilter::XSSFilter):
        (WebCore::XSSFilter::filterToken):
        (WebCore::XSSFilter::filterTokenAfterScriptStartTag):
        (WebCore::XSSFilter::filterScriptToken):
        (WebCore::XSSFilter::snippetForRange):
        (WebCore::XSSFilter::snippetForAttribute):
        * html/parser/XSSFilter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 28 Jan 2011 21:29:31 +0000 (21:29 +0000)]
2011-01-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Sketch out new XSS filter design (disabled by default)
        https://bugs.webkit.org/show_bug.cgi?id=53205

        This patch adds a basic sketch of the new XSS filter design.  Rather
        than watching scripts as they execute, in this design, we watch tokens
        emitted by the tokenizer.  We then map the tokens directly back into
        input characters, which lets us skip all the complicated logic related
        to HTML entities and double-decoding of JavaScript URLs.

        This patch contains only the bare essentially machinery.  I'll add more
        in future patches and eventually remove the previous code once this
        code is up and running correctly.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        (WebCore::HTMLDocumentParser::sourceForToken):
        * html/parser/HTMLDocumentParser.h:
        * html/parser/XSSFilter.cpp: Added.
        * html/parser/XSSFilter.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 28 Jan 2011 21:29:07 +0000 (21:29 +0000)]
2011-01-28  Martin Robinson  <mrobinson@igalia.com>

        [GTK] Build failure with --enable-indexed-database
        https://bugs.webkit.org/show_bug.cgi?id=50954

        Build fix for IndexedDB support.

        * configure.ac: Change the autogen.sh option --enable-indexeddb to
        --enable-indexed-database to match the build-webkit option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 21:27:34 +0000 (21:27 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Added expectations for a passing test.

        * platform/chromium-mac/fast/dom/isindex-002-expected.checksum: Added.
        * platform/chromium-mac/fast/dom/isindex-002-expected.png: Added.
        * platform/chromium-mac/fast/dom/isindex-002-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 21:22:40 +0000 (21:22 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Updated Chromium baselines for a bug that was fixed.
        https://bugs.webkit.org/show_bug.cgi?id=45527

        * platform/chromium-linux/fast/dom/replaceChild-expected.checksum:
        * platform/chromium-linux/fast/dom/replaceChild-expected.png:
        * platform/chromium-mac/fast/dom/replaceChild-expected.checksum: Added.
        * platform/chromium-mac/fast/dom/replaceChild-expected.png: Added.
        * platform/chromium-win/fast/dom/replaceChild-expected.checksum:
        * platform/chromium-win/fast/dom/replaceChild-expected.png:
        * platform/chromium/test_expectations.txt: Removed expectation of failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows 7 Release Tests] fast/repaint/select-option-background-color.html failing...
jberlin@webkit.org [Fri, 28 Jan 2011 21:04:56 +0000 (21:04 +0000)]
[Windows 7 Release Tests] fast/repaint/select-option-background-color.html failing since introduction in r76826
https://bugs.webkit.org/show_bug.cgi?id=53327

Unreviewed, adding Windows-specific results to get the Windows 7 Release Test bot green.

* platform/win/fast/repaint/select-option-background-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium build fix after r76967
aroben@apple.com [Fri, 28 Jan 2011 20:51:34 +0000 (20:51 +0000)]
Chromium build fix after r76967

* wtf/ThreadingPrimitives.h: Use OS(WINDOWS) instead of PLATFORM(WIN), to match other
similar macros in this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 28 Jan 2011 20:39:53 +0000 (20:39 +0000)]
2011-01-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Add ShareableSurface class
        https://bugs.webkit.org/show_bug.cgi?id=53313

        * Shared/mac/ShareableSurface.cpp: Added.
        (WebKit::ShareableSurface::Handle::Handle):
        Initialize the mach port.

        (WebKit::ShareableSurface::Handle::~Handle):
        Deallocate our send right if needed.

        (WebKit::ShareableSurface::Handle::encode):
        Encode the send right, and then null it out.

        (WebKit::ShareableSurface::Handle::decode):
        Decode the send right.

        (WebKit::createIOSurface):
        Create an IOSurface with the given size.

        (WebKit::ShareableSurface::create):
        Create an IOSurface, either from a size or from a handle.

        (WebKit::ShareableSurface::~ShareableSurface):
        Delete the texture and framebuffer.

        (WebKit::ShareableSurface::createHandle):
        Create a mach port from the surface.

        (WebKit::ShareableSurface::attach):
        Create an FBO if needed and bind it.

        (WebKit::ShareableSurface::detach):
        Unbind the FBO.

        (WebKit::ShareableSurface::textureID):
        Generate a new texture and bind it to the IOSurface.

        * Shared/mac/ShareableSurface.h: Added.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Removing .swp file checked in by mistake.
psolanki@apple.com [Fri, 28 Jan 2011 20:35:10 +0000 (20:35 +0000)]
Unreviewed. Removing .swp file checked in by mistake.

* Scripts/.webkitdirs.pm.swp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 20:33:51 +0000 (20:33 +0000)]
2011-01-28  Adam Klein  <adamk@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Remove deprecated openFileSystem method signature
        https://bugs.webkit.org/show_bug.cgi?id=53262

        Chromium still builds after this patch.

        * public/WebFrameClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Pratik Solanki <psolanki@apple.com>
psolanki@apple.com [Fri, 28 Jan 2011 20:27:22 +0000 (20:27 +0000)]
2011-01-28  Pratik Solanki  <psolanki@apple.com>

        Reviewed by David Kilzer.

        Space not necessary for undefined feature
        https://bugs.webkit.org/show_bug.cgi?id=53317

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 28 Jan 2011 20:26:04 +0000 (20:26 +0000)]
2011-01-28  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines.

        Check in the same result as fast/dom/window-domurl-crash-expected.txt because Windows port
        intentionally added a failing result in http://trac.webkit.org/changeset/76953.

        The Windows port's bug is tracked by https://bugs.webkit.org/show_bug.cgi?id=53310.

        * platform/chromium-win/fast/dom/window-domurl-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 28 Jan 2011 20:21:07 +0000 (20:21 +0000)]
2011-01-28  Michael Saboff  <msaboff@apple.com>

        Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
        https://bugs.webkit.org/show_bug.cgi?id=53271

        Reapplying this this change.  No change from prior patch in
        JavaScriptCore.

        Added new isValid() methods to check if a contained object in
        a WeakGCMap is valid when using an unchecked iterator.

        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::isValid):
2011-01-28  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
        https://bugs.webkit.org/show_bug.cgi?id=53271

        Reapplying this patch with the change that the second ASSERT in
        RootObject::removeRuntimeObject was changed to use
        .uncheckedGet() instead of the failing .get().  The object in question
        could be in the process of being GC'ed.  The get() call will not return
        such an object while the uncheckedGet() call will return the (unsafe)
        object.  This is the behavior we want.

        Precautionary change.
        Changed RootObject to use WeakGCMap instead of HashSet.
        Found will looking for another issue, but can't produce a test case
        that is problematic.  THerefore there aren't any new tests.

        * bridge/runtime_root.cpp:
        (JSC::Bindings::RootObject::invalidate):
        (JSC::Bindings::RootObject::addRuntimeObject):
        (JSC::Bindings::RootObject::removeRuntimeObject):
        * bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNotify CACFLayerTreeHost when the context is flushed
aroben@apple.com [Fri, 28 Jan 2011 20:16:58 +0000 (20:16 +0000)]
Notify CACFLayerTreeHost when the context is flushed

LegacyCACFLayerTreeHost was keeping this a secret, which meant that WebCore's animation
timers were never starting.

Fixes <http://webkit.org/b/53302> [Windows 7 Release Tests] changesets 76853, 76856, and
76858 broke ~36 animations, compositing, and transitions tests

Reviewed by Sam Weinig.

Source/WebCore:

* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
(WebCore::LegacyCACFLayerTreeHost::contextDidChange): Call up to the base class after we
start our render timer.

LayoutTests:

Unskip compositing-related tests that are now fixed

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange BinarySemaphore to wrap an auto-reset Win32 event on Windows
aroben@apple.com [Fri, 28 Jan 2011 20:16:02 +0000 (20:16 +0000)]
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows

Fixes <http://webkit.org/b/53208> <rdar://problem/8922490>.

Reviewed by Dave Hyatt.

Source/WebKit2:

* Platform/CoreIPC/BinarySemaphore.cpp: Wrap this implementation in #if !PLATFORM(WIN).

* Platform/CoreIPC/BinarySemaphore.h: Make the Windows implementation have a single HANDLE
member that holds the event.

* Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.
(CoreIPC::BinarySemaphore::BinarySemaphore): Create our event.
(CoreIPC::BinarySemaphore::~BinarySemaphore): Destory our event.
(CoreIPC::BinarySemaphore::signal): Signal the event.
(CoreIPC::BinarySemaphore::wait): Convert the absolute time to a wait interval, then wait
for the event to be signaled or for the interval to elapse.

* win/WebKit2.vcproj: Added BinarySemaphoreWin.cpp. Also let VS have its way with the file.

Source/JavaScriptCore:

Extract code to convert a WTF absolute time to a Win32 wait interval into a separate
function

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new function.

* wtf/ThreadingPrimitives.h: Declare the new function.

* wtf/ThreadingWin.cpp:
(WTF::ThreadCondition::timedWait): Moved code to convert the absolute time to a wait
interval from here...
(WTF::absoluteTimeToWaitTimeoutInterval): ...to here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove dead code that tried to map from CSS values to parser values
antti@apple.com [Fri, 28 Jan 2011 20:15:28 +0000 (20:15 +0000)]
Remove dead code that tried to map from CSS values to parser values
https://bugs.webkit.org/show_bug.cgi?id=53318

Reviewed by Dan Bernstein.

* css/CSSFunctionValue.cpp:
* css/CSSFunctionValue.h:
* css/CSSPrimitiveValue.cpp:
* css/CSSPrimitiveValue.h:
* css/CSSValue.h:
* css/CSSValueList.cpp:
* css/CSSValueList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows 7 Release Tests] fast/text/justify-ideograph-complex/simple/vertical.html...
jberlin@webkit.org [Fri, 28 Jan 2011 20:14:58 +0000 (20:14 +0000)]
[Windows 7 Release Tests] fast/text/justify-ideograph-complex/simple/vertical.html failing since introduction in r76743.
https://bugs.webkit.org/show_bug.cgi?id=53321

Unreviewed, checking in failing expected results to get the Windows 7 Release Tests bots green.

* platform/win/fast/text/justify-ideograph-complex-expected.txt: Added.
* platform/win/fast/text/justify-ideograph-simple-expected.txt: Added.
* platform/win/fast/text/justify-ideograph-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 20:11:34 +0000 (20:11 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove now-passing test from expectations.

        * platform/chromium/test_expectations.txt: Expectation of failure removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 20:08:10 +0000 (20:08 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Update expectations for prototype-inheritance to match platform/mac.

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 28 Jan 2011 19:48:51 +0000 (19:48 +0000)]
2011-01-27  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Anders Carlsson.

        WebKit2: Page flashes just before accelerated compositing animation
        https://bugs.webkit.org/show_bug.cgi?id=53274

        When switching out of compositing mode, the new ChunkedUpdateDrawingAreaProxy
        is getting created with the current page size. When the setSize() call is
        subsequently made, the sizeDidChange() call is not made (which does the initial
        render of the page) because the old size and new size are the same. The solution
        is to skip the setting of the size in the ctor and let it go through a size
        change sequence.

        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit::DrawingAreaProxy::DrawingAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSome drag and drop tests fail since r76824
enrica@apple.com [Fri, 28 Jan 2011 19:46:19 +0000 (19:46 +0000)]
Some drag and drop tests fail since r76824
https://bugs.webkit.org/show_bug.cgi?id=53304

Reviewed by Adam Roben.

Source/WebCore:

There were '||' instead of '&&' in the checks for valid
clipboard content.

* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):

LayoutTests:

Removing platform-specific tests after fixing the cause of the failure.

* platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt: Removed.
* platform/win/editing/pasteboard/onpaste-text-html-expected.txt: Removed.
* platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Removed.
* platform/win/fast/events/ondrop-text-html-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 28 Jan 2011 19:29:02 +0000 (19:29 +0000)]
2011-01-28  Martin Robinson  <mrobinson@igalia.com>

        [GTK] AudioProcessingEvent.h and JSJavaScriptAudioNode.h: No such file or directory
        https://bugs.webkit.org/show_bug.cgi?id=52889

        Build fix for WebAudio. Include WebAudio source files on the source
        list when WebAudio is enabled.

        * GNUmakefile.am: Include missing source files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the Windows-specific failing results for media/audio-data-url.html, since...
jberlin@webkit.org [Fri, 28 Jan 2011 19:18:47 +0000 (19:18 +0000)]
Remove the Windows-specific failing results for media/audio-data-url.html, since it appears
to be passing on the bots now. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51518

* platform/win/media/audio-data-url-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Fri, 28 Jan 2011 19:16:18 +0000 (19:16 +0000)]
2011-01-28  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Andreas Kling.

        Unskipp auth.html after fix.
        https://bugs.webkit.org/show_bug.cgi?id=36688

        * platform/qt/Skipped:
2011-01-28  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Andreas Kling.

        Reset NetworkAccessManager to clean up credentials from previous tests.
        This change causes no performance overhead either.
        https://bugs.webkit.org/show_bug.cgi?id=36688

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        (WebCore::DumpRenderTree::open):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 19:06:46 +0000 (19:06 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Added newly-failing tests to expectations, will be fixing them shortly.
        https://bugs.webkit.org/show_bug.cgi?id=53314

        * platform/chromium/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd basic rubber banding support
weinig@apple.com [Fri, 28 Jan 2011 19:05:43 +0000 (19:05 +0000)]
Add basic rubber banding support
<rdar://problem/8219429>
https://bugs.webkit.org/show_bug.cgi?id=53277

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

* wtf/Platform.h: Add ENABLE for rubber banding.

Source/WebCore:

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
Pass gesture events to the FrameView.

* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleGestureEvent):
* platform/ScrollAnimator.h:
Add stubbed out implementation.

* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::handleGestureEvent):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::constrainsScrollingToContentEdge):
(WebCore::ScrollableArea::setConstrainsScrollingToContentEdge):
Move constrains scrolling bit to ScrollableArea from ScrollView.

(WebCore::ScrollableArea::contentsSize):
(WebCore::ScrollableArea::overhangAmount):
Add additional virtual functions for information needed by the animator.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::handleGestureEvent):
(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Implement basic rubber banding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding tests broken on Windows 7 Release in 76853,76856,76858 to the Skipped list...
jberlin@webkit.org [Fri, 28 Jan 2011 19:05:35 +0000 (19:05 +0000)]
Adding tests broken on Windows 7 Release in 76853,76856,76858 to the Skipped list to get the
Windows 7 Release Bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53302

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChanging unicode-bidi doesn’t force layout
mitz@apple.com [Fri, 28 Jan 2011 18:46:38 +0000 (18:46 +0000)]
Changing unicode-bidi doesn’t force layout
https://bugs.webkit.org/show_bug.cgi?id=53311

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/dynamic/unicode-bidi.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Return a layout difference if unicode-bidi values differ.

LayoutTests:

* fast/dynamic/unicode-bidi-expected.checksum: Added.
* fast/dynamic/unicode-bidi-expected.png: Added.
* fast/dynamic/unicode-bidi-expected.txt: Added.
* fast/dynamic/unicode-bidi.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows expected (failing) results to get the bots green. Unreviewed.
jberlin@webkit.org [Fri, 28 Jan 2011 18:44:04 +0000 (18:44 +0000)]
Add Windows expected (failing) results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53310

* platform/win/fast/dom/window-domurl-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck in Windows-specific expected results to get the bots green. Unreviewed.
jberlin@webkit.org [Fri, 28 Jan 2011 18:16:22 +0000 (18:16 +0000)]
Check in Windows-specific expected results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53307

* platform/win/fast/multicol: Added.
* platform/win/fast/multicol/vertical-rl: Added.
* platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
* platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 17:52:58 +0000 (17:52 +0000)]
2011-01-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Change HTMLInputElement-derived parts of media element shadow DOM to use shadowPseudoId.
        https://bugs.webkit.org/show_bug.cgi?id=53122

        This is the first step in converting HTMLMediaElement to the new shadow DOM.

        Should not regress any existing tests. No observable change in behavior.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId): Removed now-unnecessary hard-coded pseudo-element selectors.
        (WebCore::nameToPseudoTypeMap): Ditto.
        (WebCore::CSSSelector::extractPseudoType): Ditto.
        * css/CSSSelector.h: Ditto.
        * css/mediaControls.css: Added proper initial values, now that elements use the proper selector pipeline.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::MediaControlInputElement): Removed the switch statement,
            which is now replaced with virtual shadowPseudoId on each corresponding class.
        (WebCore::MediaControlInputElement::styleForElement): Changed to use element pipeline.
        (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Changed to set
            display type in constructor.
        (WebCore::MediaControlMuteButtonElement::create): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Added
            to disambiguate from the MediaControlMuteButtonElement.
        (WebCore::MediaControlVolumeSliderMuteButtonElement::create): Added.
        (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Added.
        (WebCore::MediaControlSeekForwardButtonElement::create): Added.
        (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Added.
        (WebCore::MediaControlSeekBackButtonElement::create): Added.
        (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Added.
        (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlTimelineElement::shadowPseudoId): Added.
        (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Added.
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Changed to not take PseudoId as
            constructor argument.
        (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Added.
        * rendering/MediaControlElements.h:
        (WebCore::MediaControlSeekForwardButtonElement::isForwardButton): Added.
        (WebCore::MediaControlSeekBackButtonElement::isForwardButton): Added.
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::createMuteButton): Changed to use new constructor.
        (WebCore::RenderMedia::createSeekBackButton): Ditto.
        (WebCore::RenderMedia::createSeekForwardButton): Ditto.
        (WebCore::RenderMedia::createVolumeSliderMuteButton): Ditto.
        * rendering/style/RenderStyleConstants.h: Removed constants that are no longer used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 17:11:08 +0000 (17:11 +0000)]
2011-01-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Split MediaControls out of RenderMedia.
        https://bugs.webkit.org/show_bug.cgi?id=53252

        Near-mechanical moving of stuff, no change in behavior, thus no new tests.

        * Android.mk: Added MediaControls to build system.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::defaultEventHandler): Changed to forward events to MediaControls.
        * html/shadow/MediaControls.cpp: Copied all controls-related methods from
            Source/WebCore/rendering/RenderMedia.cpp, pulled them into their own class called MediaControls.
        * html/shadow/MediaControls.h: Ditto from Source/WebCore/rendering/RenderMedia.h.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlTimelineElement::defaultEventHandler): Changed to use MediaControls.
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::RenderMedia): Moved relevant constructor initializers out to MediaControls.
        (WebCore::RenderMedia::destroy): Changed to use MediaControls.
        (WebCore::RenderMedia::styleDidChange): Ditto.
        (WebCore::RenderMedia::layout): Ditto.
        (WebCore::RenderMedia::updateFromElement): Ditto.
        * rendering/RenderMedia.h: Updated defs accordingly and removed player() accessor, which
            is only used by sub-class RenderVideo.
        (WebCore::RenderMedia::controls): Added.
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::~RenderVideo): Changed to access MediaPlayer* directly from mediaElement().
        (WebCore::RenderVideo::calculateIntrinsicSize): Ditto.
        (WebCore::RenderVideo::paintReplaced): Ditto.
        (WebCore::RenderVideo::updatePlayer): Ditto.
        (WebCore::RenderVideo::supportsAcceleratedRendering): Ditto.
        (WebCore::RenderVideo::acceleratedRenderingStateChanged): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 17:05:12 +0000 (17:05 +0000)]
2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76942.
        http://trac.webkit.org/changeset/76942
        https://bugs.webkit.org/show_bug.cgi?id=53301

        Unskipped tests keep failing on GTK release bots (Requested by
        svillar on #webkit).

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows expected (failing) results to get the bots green. Unreviewed.
jberlin@webkit.org [Fri, 28 Jan 2011 17:01:14 +0000 (17:01 +0000)]
Add Windows expected (failing) results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53304

* platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
* platform/win/editing/pasteboard/onpaste-text-html-expected.txt: Added.
* platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
* platform/win/fast/events/ondrop-text-html-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 28 Jan 2011 16:56:37 +0000 (16:56 +0000)]
2011-01-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: allow remote debugging with front-end
        served from the cloud.
        https://bugs.webkit.org/show_bug.cgi?id=53303

        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 16:33:03 +0000 (16:33 +0000)]
2011-01-28  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Andreas Kling.

        Setting value of m_PressedPos to make scrolling smooth

        Page scroll popup menu "Scroll here" option not working when cliking above scroll slider/handler.
        https://bugs.webkit.org/show_bug.cgi?id=51349

        The value of m_PressedPos was getting set before moveThumb() call
        in all other scenarios except when "Scroll Here" option is used.
        Hence scrolling with this option was not as expected even in cases
        where scrolling was happening. The thumb would move in unexpected
        direction. m_PressedPos is now set to pressed position so delta is
        calculated.
        Unable to write a test case as the test needs to click on "Scroll
        Here" option of context sensitive menu and QTest is unable to do it.
        Besides no new functionality introduced.

        * platform/qt/ScrollbarQt.cpp:
        (WebCore::Scrollbar::contextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 28 Jan 2011 16:06:07 +0000 (16:06 +0000)]
2011-01-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] add JSON schema for extensions API
        https://bugs.webkit.org/show_bug.cgi?id=53236

        * inspector/front-end/ExtensionAPISchema.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 15:51:09 +0000 (15:51 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Remove _LENGTH enumerants
        https://bugs.webkit.org/show_bug.cgi?id=53259

        * html/canvas/WebGLRenderingContext.cpp: Remove queries for *LENGTH.
        (WebCore::WebGLRenderingContext::getProgramParameter):
        (WebCore::WebGLRenderingContext::getShaderParameter):
        * html/canvas/WebGLRenderingContext.idl: Remove *LENGTH.
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Remove _LENGTH enumerants
        https://bugs.webkit.org/show_bug.cgi?id=53259

        * fast/canvas/webgl/constants.html:
        * fast/canvas/webgl/gl-getshadersource-expected.txt:
        * fast/canvas/webgl/gl-getshadersource.html:
        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
        * fast/canvas/webgl/gl-object-get-calls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 28 Jan 2011 15:48:00 +0000 (15:48 +0000)]
2011-01-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: syntax highlight inline JS and CSS in HTML resources
        https://bugs.webkit.org/show_bug.cgi?id=30831

        * inspector/front-end/SourceHTMLTokenizer.js:
        (WebInspector.SourceHTMLTokenizer):
        (WebInspector.SourceHTMLTokenizer.prototype.set line):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 28 Jan 2011 15:12:27 +0000 (15:12 +0000)]
2011-01-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Unskipped some tests. They're not failing anymore.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 28 Jan 2011 15:07:09 +0000 (15:07 +0000)]
2011-01-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword
        https://bugs.webkit.org/show_bug.cgi?id=53295

        Select the current word suffix before switching to the next suggestion.

        * inspector/front-end/StylesSidebarPane.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 28 Jan 2011 14:34:37 +0000 (14:34 +0000)]
2011-01-28  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix compilation warning
        https://bugs.webkit.org/show_bug.cgi?id=53292

        * webkit/webkitwebframe.cpp:
        (draw_page_callback): Cast the pageCount from size_t to int, it
        should be safe considering page_nr is the number of pages,
        0-based.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 28 Jan 2011 14:19:13 +0000 (14:19 +0000)]
2011-01-28  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix dist compilation for the release
        https://bugs.webkit.org/show_bug.cgi?id=53290

        * GNUmakefile.am: Added inspector files to the extra dist.

2011-01-28  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix dist compilation for the release
        https://bugs.webkit.org/show_bug.cgi?id=53290

        * GNUmakefile.am: Remove a file that is not in the repository
        anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 28 Jan 2011 13:16:31 +0000 (13:16 +0000)]
2011-01-28  Andreas Kling  <kling@webkit.org>

        Rubber-stamped by Simon Hausmann.

        [Qt][WK2] Combine QWKPage::engine{Connected,Disconnected} into one signal.

        Having two signals for this is redundant, combine them into
        QWKPage::engineConnectionChanged(bool connected).

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::didRelaunchProcess):
        (QWKPagePrivate::processDidCrash):
        * UIProcess/API/qt/qwkpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add Zoom Text Only action to MiniBrowser
zoltan@webkit.org [Fri, 28 Jan 2011 13:06:31 +0000 (13:06 +0000)]
[Qt] Add Zoom Text Only action to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53297

Reviewed by Andreas Kling.

Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::resetZoom):
(BrowserWindow::toggleZoomTextOnly):
(BrowserWindow::applyZoom):
* MiniBrowser/qt/BrowserWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 12:46:50 +0000 (12:46 +0000)]
2011-01-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Andreas Kling.

        Const-correct HTMLSelectElement and WebSelectElement
        https://bugs.webkit.org/show_bug.cgi?id=53293

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::value): const.
        * html/HTMLSelectElement.h:
2011-01-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Andreas Kling.

        Const-correct HTMLSelectElement and WebSelectElement
        https://bugs.webkit.org/show_bug.cgi?id=53293

        * public/WebSelectElement.h:
        * src/WebSelectElement.cpp:
        (WebKit::WebSelectElement::value): const.
        (WebKit::WebSelectElement::listItems): const.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 28 Jan 2011 12:45:21 +0000 (12:45 +0000)]
2011-01-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix debugger-scripts.html (broken by r76587).
        https://bugs.webkit.org/show_bug.cgi?id=53112

        * inspector/debugger-scripts-expected.txt:
        * inspector/debugger-scripts.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 28 Jan 2011 11:25:47 +0000 (11:25 +0000)]
2011-01-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Adding media/video-controls-rendering.html to the Skipped list of tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 28 Jan 2011 10:14:13 +0000 (10:14 +0000)]
2011-01-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add webkit-patch roll-chromium-deps
        https://bugs.webkit.org/show_bug.cgi?id=53288

        This command updates the Source/WebKit/chromium/DEPS file with the
        last-known good revision of Chromium (or a revision specified on the
        command line).  I'd eventually like to turn this into a SheriffBot
        command, but this is the first step.

        This patch somewhat sprawled because I needed to move a bunch of code
        out of ChangeLog that should never have been there in the first place.
        Also, I had to fix a bug in MockUser in order to test the new command.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
        * Scripts/webkitpy/common/checkout/deps.py: Added.
        * Scripts/webkitpy/common/config/urls.py:
        * Scripts/webkitpy/tool/commands/__init__.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/commands/roll.py: Added.
        * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/__init__.py:
        * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
        * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
        * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
        * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r76893.
ossy@webkit.org [Fri, 28 Jan 2011 09:10:11 +0000 (09:10 +0000)]
Unreviewed, rolling out r76893.
http://trac.webkit.org/changeset/76893
https://bugs.webkit.org/show_bug.cgi?id=53287

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-28
It made some tests crash on GTK and Qt debug bots (Requested
by Ossy on #webkit).

Source/JavaScriptCore:

* runtime/WeakGCMap.h:

Source/WebCore:

* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-01-28 Commit Queue <commit-queue@webkit.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 08:33:51 +0000 (08:33 +0000)]
2010-01-28  Commit Queue  <commit-queue@webkit.org>

        Unreviewed.  Test commit for commit-queue@webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-01-28 Commit Queue <commit-queue@webkit.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 08:05:52 +0000 (08:05 +0000)]
2010-01-28  Commit Queue  <commit-queue@webkit.org>

        Unreviewed.  Test commit for commit-queue@webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 07:49:51 +0000 (07:49 +0000)]
2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Maciej Stachowiak.

        Build fix for Mac Intel Debug after r76916
        https://bugs.webkit.org/show_bug.cgi?id=53284

        Fix macro redefinition by guarding the redefined macros.

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 07:25:26 +0000 (07:25 +0000)]
2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix for Mac Intel Debug after r76916.

        Fix macro redefinition by guarding the redefined macros.

        Check if the macro is already defined before defininig it.
        c++config.h has the same macros with the same values.

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 28 Jan 2011 07:14:40 +0000 (07:14 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update.

        * platform/chromium/test_expectations.txt: More media test crashes due to crbug.com/71087.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 06:42:23 +0000 (06:42 +0000)]
2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Adam Barth.

        Update the expected results for test-webkitpy after r76916.

        Include "config.h" in the expected results as well.

        * Scripts/webkit2/messages_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 28 Jan 2011 06:34:36 +0000 (06:34 +0000)]
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Skip some tests that fail due to missing DRT API
        https://bugs.webkit.org/show_bug.cgi?id=53283

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 06:09:54 +0000 (06:09 +0000)]
2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed buildfix for SnowLeopard Intel Debug.

        Fix macro redefinition by not including config.h.

        Revert previous change in WebPageProxyCF.cpp.

        * UIProcess/cf/WebPageProxyCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Greg Coletta <greg.coletta@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 28 Jan 2011 05:37:44 +0000 (05:37 +0000)]
2011-01-27  Greg Coletta  <greg.coletta@nokia.com>

        Reviewed by Laszlo Gombos.

        Get rid of prefix header dependency for WebKit2 build system
        https://bugs.webkit.org/show_bug.cgi?id=50174

        Change the style checker so that it enforces config.h include for
        WebKit2.

        * Scripts/webkitpy/style/checker.py:

2011-01-27  Greg Coletta  <greg.coletta@nokia.com>

        Reviewed by Laszlo Gombos.

        Get rid of prefix header dependency for WebKit2 build system
        https://bugs.webkit.org/show_bug.cgi?id=50174

        Guard EmptyProtocalDefinitions.h to make sure it's not included twice.

        * platform/mac/EmptyProtocolDefinitions.h:

2011-01-27  Greg Coletta  <greg.coletta@nokia.com>

        Reviewed by Laszlo Gombos.

        Get rid of prefix header dependency for WebKit2 build system.
        https://bugs.webkit.org/show_bug.cgi?id=50174

        Add config.h include explicitelly.

        * Platform/CoreIPC/ArgumentDecoder.cpp:
        * Platform/CoreIPC/ArgumentEncoder.cpp:
        * Platform/CoreIPC/Attachment.cpp:
        * Platform/CoreIPC/BinarySemaphore.cpp:
        * Platform/CoreIPC/Connection.cpp:
        * Platform/CoreIPC/DataReference.cpp:
        * Platform/CoreIPC/gtk/ConnectionGtk.cpp:
        * Platform/CoreIPC/mac/ConnectionMac.cpp:
        * Platform/CoreIPC/qt/ConnectionQt.cpp:
        * Platform/CoreIPC/win/ConnectionWin.cpp:
        * Platform/Logging.cpp:
        * Platform/Module.cpp:
        * Platform/Region.cpp:
        * Platform/RunLoop.cpp:
        * Platform/WorkQueue.cpp:
        * Platform/cg/CGUtilities.cpp:
        * Platform/gtk/RunLoopGtk.cpp:
        * Platform/gtk/SharedMemoryGtk.cpp:
        * Platform/gtk/WorkQueueGtk.cpp:
        * Platform/mac/MachUtilities.cpp:
        * Platform/mac/SharedMemoryMac.cpp:
        * Platform/mac/WorkQueueMac.cpp:
        * Platform/qt/MappedMemoryPool.cpp:
        * Platform/qt/ModuleQt.cpp:
        * Platform/qt/RunLoopQt.cpp:
        * Platform/qt/WorkQueueQt.cpp:
        * Platform/win/ModuleWin.cpp:
        * Platform/win/RunLoopWin.cpp:
        * Platform/win/SharedMemoryWin.cpp:
        * Platform/win/WorkQueueWin.cpp:
        * PluginProcess/PluginControllerProxy.cpp:
        * PluginProcess/PluginProcess.cpp:
        * PluginProcess/WebProcessConnection.cpp:
        * Scripts/webkit2/messages.py:
        * Shared/API/c/WKArray.cpp:
        * Shared/API/c/WKCertificateInfo.cpp:
        * Shared/API/c/WKContextMenuItem.cpp:
        * Shared/API/c/WKData.cpp:
        * Shared/API/c/WKDictionary.cpp:
        * Shared/API/c/WKError.cpp:
        * Shared/API/c/WKImage.cpp:
        * Shared/API/c/WKMutableArray.cpp:
        * Shared/API/c/WKMutableDictionary.cpp:
        * Shared/API/c/WKNumber.cpp:
        * Shared/API/c/WKSecurityOrigin.cpp:
        * Shared/API/c/WKSerializedScriptValue.cpp:
        * Shared/API/c/WKString.cpp:
        * Shared/API/c/WKType.cpp:
        * Shared/API/c/WKURL.cpp:
        * Shared/API/c/WKURLRequest.cpp:
        * Shared/API/c/WKURLResponse.cpp:
        * Shared/API/c/WKUserContentURLPattern.cpp:
        * Shared/API/c/cf/WKStringCF.cpp:
        * Shared/API/c/cf/WKURLCF.cpp:
        * Shared/API/c/cf/WKURLRequestCF.cpp:
        * Shared/API/c/cf/WKURLResponseCF.cpp:
        * Shared/API/c/cg/WKImageCG.cpp:
        * Shared/API/c/win/WKCertificateInfoWin.cpp:
        * Shared/ChildProcess.cpp:
        * Shared/ImmutableArray.cpp:
        * Shared/ImmutableDictionary.cpp:
        * Shared/MutableArray.cpp:
        * Shared/MutableDictionary.cpp:
        * Shared/OriginAndDatabases.cpp:
        * Shared/PlatformPopupMenuData.cpp:
        * Shared/Plugins/NPIdentifierData.cpp:
        * Shared/Plugins/NPObjectMessageReceiver.cpp:
        * Shared/Plugins/NPObjectProxy.cpp:
        * Shared/Plugins/NPRemoteObjectMap.cpp:
        * Shared/Plugins/NPVariantData.cpp:
        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        * Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
        * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
        * Shared/Plugins/PluginProcessCreationParameters.cpp:
        * Shared/PrintInfo.cpp:
        * Shared/SessionState.cpp:
        * Shared/ShareableBitmap.cpp:
        * Shared/UpdateInfo.cpp:
        * Shared/VisitedLinkTable.cpp:
        * Shared/WebBackForwardListItem.cpp:
        * Shared/WebContextMenuItem.cpp:
        * Shared/WebContextMenuItemData.cpp:
        * Shared/WebError.cpp:
        * Shared/WebEvent.cpp:
        * Shared/WebEventConversion.cpp:
        * Shared/WebGeolocationPosition.cpp:
        * Shared/WebImage.cpp:
        * Shared/WebKeyboardEvent.cpp:
        * Shared/WebMemorySampler.cpp:
        * Shared/WebMouseEvent.cpp:
        * Shared/WebOpenPanelParameters.cpp:
        * Shared/WebPageCreationParameters.cpp:
        * Shared/WebPageGroupData.cpp:
        * Shared/WebPlatformTouchPoint.cpp:
        * Shared/WebPopupItem.cpp:
        * Shared/WebPreferencesStore.cpp:
        * Shared/WebProcessCreationParameters.cpp:
        * Shared/WebTouchEvent.cpp:
        * Shared/WebURLRequest.cpp:
        * Shared/WebURLResponse.cpp:
        * Shared/WebWheelEvent.cpp:
        * Shared/cairo/ShareableBitmapCairo.cpp:
        * Shared/cf/ArgumentCodersCF.cpp:
        * Shared/cg/ShareableBitmapCG.cpp:
        * Shared/gtk/ShareableBitmapGtk.cpp:
        * Shared/gtk/WebCoreArgumentCodersGtk.cpp:
        * Shared/mac/CommandLineMac.cpp:
        * Shared/mac/UpdateChunk.cpp:
        * Shared/qt/CleanupHandler.cpp:
        * Shared/qt/NativeWebKeyboardEventQt.cpp:
        * Shared/qt/ShareableBitmapQt.cpp:
        * Shared/qt/UpdateChunk.cpp:
        * Shared/qt/WebCoreArgumentCodersQt.cpp:
        * Shared/qt/WebEventFactoryQt.cpp:
        * Shared/qt/WebURLRequestQt.cpp:
        * Shared/qt/WebURLResponseQt.cpp:
        * Shared/win/CommandLineWin.cpp:
        * Shared/win/NativeWebKeyboardEventWin.cpp:
        * Shared/win/PlatformCertificateInfo.cpp:
        * Shared/win/UpdateChunk.cpp:
        * Shared/win/WebCoreArgumentCodersWin.cpp:
        * Shared/win/WebEventFactory.cpp:
        * Shared/win/WebURLRequestWin.cpp:
        * Shared/win/WebURLResponseWin.cpp:
        * UIProcess/API/C/WKAuthenticationChallenge.cpp:
        * UIProcess/API/C/WKAuthenticationDecisionListener.cpp:
        * UIProcess/API/C/WKBackForwardList.cpp:
        * UIProcess/API/C/WKBackForwardListItem.cpp:
        * UIProcess/API/C/WKContext.cpp:
        * UIProcess/API/C/WKCredential.cpp:
        * UIProcess/API/C/WKDatabaseManager.cpp:
        * UIProcess/API/C/WKDownload.cpp:
        * UIProcess/API/C/WKFormSubmissionListener.cpp:
        * UIProcess/API/C/WKFrame.cpp:
        * UIProcess/API/C/WKFramePolicyListener.cpp:
        * UIProcess/API/C/WKGeolocationManager.cpp:
        * UIProcess/API/C/WKGeolocationPermissionRequest.cpp:
        * UIProcess/API/C/WKGeolocationPosition.cpp:
        * UIProcess/API/C/WKInspector.cpp:
        * UIProcess/API/C/WKNavigationData.cpp:
        * UIProcess/API/C/WKOpenPanelParameters.cpp:
        * UIProcess/API/C/WKOpenPanelResultListener.cpp:
        * UIProcess/API/C/WKPage.cpp:
        * UIProcess/API/C/WKPageGroup.cpp:
        * UIProcess/API/C/WKPreferences.cpp:
        * UIProcess/API/C/WKProtectionSpace.cpp:
        * UIProcess/API/C/win/WKContextWin.cpp:
        * UIProcess/API/C/win/WKView.cpp:
        * UIProcess/API/C/win/WKViewPrivate.cpp:
        * UIProcess/API/cpp/qt/WKStringQt.cpp:
        * UIProcess/API/cpp/qt/WKURLQt.cpp:
        * UIProcess/API/qt/ClientImpl.cpp:
        * UIProcess/API/qt/qgraphicswkview.cpp:
        * UIProcess/API/qt/qwkcontext.cpp:
        * UIProcess/API/qt/qwkpage.cpp:
        * UIProcess/API/qt/qwkpreferences.cpp:
        * UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
        * UIProcess/Authentication/AuthenticationDecisionListener.cpp:
        * UIProcess/Authentication/WebCredential.cpp:
        * UIProcess/Authentication/WebProtectionSpace.cpp:
        * UIProcess/BackingStore.cpp:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        * UIProcess/Downloads/DownloadProxy.cpp:
        * UIProcess/DrawingAreaProxy.cpp:
        * UIProcess/DrawingAreaProxyImpl.cpp:
        * UIProcess/FindIndicator.cpp:
        * UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
        * UIProcess/GeolocationPermissionRequestProxy.cpp:
        * UIProcess/Launcher/ProcessLauncher.cpp:
        * UIProcess/Launcher/ThreadLauncher.cpp:
        * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
        * UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
        * UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
        * UIProcess/Launcher/win/ProcessLauncherWin.cpp:
        * UIProcess/Launcher/win/ThreadLauncherWin.cpp:
        * UIProcess/LayerBackedDrawingAreaProxy.cpp:
        * UIProcess/Plugins/PluginInfoStore.cpp:
        * UIProcess/Plugins/PluginProcessManager.cpp:
        * UIProcess/Plugins/PluginProcessProxy.cpp:
        * UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
        * UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:
        * UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
        * UIProcess/ResponsivenessTimer.cpp:
        * UIProcess/TiledDrawingAreaProxy.cpp:
        * UIProcess/VisitedLinkProvider.cpp:
        * UIProcess/WebBackForwardList.cpp:
        * UIProcess/WebContext.cpp:
        * UIProcess/WebContextInjectedBundleClient.cpp:
        * UIProcess/WebContextMenuProxy.cpp:
        * UIProcess/WebDatabaseManagerProxy.cpp:
        * UIProcess/WebDatabaseManagerProxyClient.cpp:
        * UIProcess/WebDownloadClient.cpp:
        * UIProcess/WebEditCommandProxy.cpp:
        * UIProcess/WebFindClient.cpp:
        * UIProcess/WebFormClient.cpp:
        * UIProcess/WebFormSubmissionListenerProxy.cpp:
        * UIProcess/WebFrameListenerProxy.cpp:
        * UIProcess/WebFramePolicyListenerProxy.cpp:
        * UIProcess/WebFrameProxy.cpp:
        * UIProcess/WebGeolocationManagerProxy.cpp:
        * UIProcess/WebGeolocationProvider.cpp:
        * UIProcess/WebHistoryClient.cpp:
        * UIProcess/WebInspectorProxy.cpp:
        * UIProcess/WebLoaderClient.cpp:
        * UIProcess/WebNavigationData.cpp:
        * UIProcess/WebOpenPanelResultListenerProxy.cpp:
        * UIProcess/WebPageContextMenuClient.cpp:
        * UIProcess/WebPageGroup.cpp:
        * UIProcess/WebPageProxy.cpp:
        * UIProcess/WebPolicyClient.cpp:
        * UIProcess/WebPreferences.cpp:
        * UIProcess/WebProcessManager.cpp:
        * UIProcess/WebProcessProxy.cpp:
        * UIProcess/WebResourceLoadClient.cpp:
        * UIProcess/WebUIClient.cpp:
        * UIProcess/cf/WebBackForwardListCF.cpp:
        * UIProcess/cf/WebPageProxyCF.cpp:
        * UIProcess/cf/WebPreferencesCF.cpp:
        * UIProcess/gtk/TextCheckerGtk.cpp:
        * UIProcess/gtk/WebInspectorGtk.cpp:
        * UIProcess/gtk/WebPageProxyGtk.cpp:
        * UIProcess/gtk/WebPreferencesGtk.cpp:
        * UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
        * UIProcess/qt/TextCheckerQt.cpp:
        * UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
        * UIProcess/qt/TiledDrawingAreaTileQt.cpp:
        * UIProcess/qt/WebContextMenuProxyQt.cpp:
        * UIProcess/qt/WebContextQt.cpp:
        * UIProcess/qt/WebInspectorProxyQt.cpp:
        * UIProcess/qt/WebPageProxyQt.cpp:
        * UIProcess/qt/WebPopupMenuProxyQt.cpp:
        * UIProcess/qt/WebPreferencesQt.cpp:
        * UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
        * UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp:
        * UIProcess/win/TextCheckerWin.cpp:
        * UIProcess/win/WebContextMenuProxyWin.cpp:
        * UIProcess/win/WebContextWin.cpp:
        * UIProcess/win/WebInspectorProxyWin.cpp:
        * UIProcess/win/WebPageProxyWin.cpp:
        * UIProcess/win/WebPopupMenuProxyWin.cpp:
        * UIProcess/win/WebView.cpp:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Authentication/AuthenticationManager.cpp:
        * WebProcess/Downloads/Download.cpp:
        * WebProcess/Downloads/DownloadManager.cpp:
        * WebProcess/Downloads/cf/DownloadCFNet.cpp:
        * WebProcess/Downloads/curl/DownloadCurl.cpp:
        * WebProcess/Downloads/qt/DownloadQt.cpp:
        * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
        * WebProcess/Geolocation/WebGeolocationManager.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundlePageGroup.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
        * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        * WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
        * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
        * WebProcess/InjectedBundle/InjectedBundleClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
        * WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
        * WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
        * WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
        * WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
        * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
        * WebProcess/Plugins/Netscape/JSNPObject.cpp:
        * WebProcess/Plugins/Netscape/NPJSObject.cpp:
        * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
        * WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
        * WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
        * WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
        * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
        * WebProcess/Plugins/Plugin.cpp:
        * WebProcess/Plugins/PluginProcessConnection.cpp:
        * WebProcess/Plugins/PluginProcessConnectionManager.cpp:
        * WebProcess/Plugins/PluginProxy.cpp:
        * WebProcess/Plugins/PluginView.cpp:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
        * WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
        * WebProcess/WebCoreSupport/WebDragClient.cpp:
        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        * WebProcess/WebCoreSupport/WebPopupMenu.cpp:
        * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
        * WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
        * WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
        * WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
        * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
        * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
        * WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:
        * WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp:
        * WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
        * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
        * WebProcess/WebKitMain.cpp:
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        * WebProcess/WebPage/DecoderAdapter.cpp:
        * WebProcess/WebPage/DrawingArea.cpp:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        * WebProcess/WebPage/EncoderAdapter.cpp:
        * WebProcess/WebPage/FindController.cpp:
        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
        * WebProcess/WebPage/PageOverlay.cpp:
        * WebProcess/WebPage/TiledDrawingArea.cpp:
        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        * WebProcess/WebPage/WebContextMenu.cpp:
        * WebProcess/WebPage/WebEditCommand.cpp:
        * WebProcess/WebPage/WebFrame.cpp:
        * WebProcess/WebPage/WebInspector.cpp:
        * WebProcess/WebPage/WebOpenPanelResultListener.cpp:
        * WebProcess/WebPage/WebPage.cpp:
        * WebProcess/WebPage/WebPageGroupProxy.cpp:
        * WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
        * WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
        * WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp:
        * WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp:
        * WebProcess/WebPage/qt/WebInspectorQt.cpp:
        * WebProcess/WebPage/qt/WebPageQt.cpp:
        * WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp:
        * WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp:
        * WebProcess/WebPage/win/WebInspectorWin.cpp:
        * WebProcess/WebPage/win/WebPageWin.cpp:
        * WebProcess/WebProcess.cpp:
        * WebProcess/gtk/WebProcessGtk.cpp:
        * WebProcess/gtk/WebProcessMainGtk.cpp:
        * WebProcess/qt/WebProcessMainQt.cpp:
        * WebProcess/qt/WebProcessQt.cpp:
        * WebProcess/win/WebProcessMainWin.cpp:
        * WebProcess/win/WebProcessWin.cpp:
        * config.h: Copied from Source/WebKit2/WebKit2Prefix.h.
        * win/WebKit2Common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 28 Jan 2011 05:30:10 +0000 (05:30 +0000)]
2011-01-27  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Recalc table sections if needed before calculating the first line
        box baseline.
        https://bugs.webkit.org/show_bug.cgi?id=53265

        When we try to calculate the baseline position of a table cell,
        we recurse through all the child sibling boxes (when children are
        non inline) and add their first linebox baseline values. If one of
        the children is a table with pending section recalc, we will access
        wrong table section values. We recalc table sections if it is needed.

        Test: fast/table/recalc-section-first-body-crash-main.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::firstLineBoxBaseline):
2011-01-27  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Tests that we do not crash when calculating the first line box
        baseline for the table.
        https://bugs.webkit.org/show_bug.cgi?id=53265

        * fast/table/recalc-section-first-body-crash-main-expected.txt: Added.
        * fast/table/recalc-section-first-body-crash-main.html: Added.
        * fast/table/resources/recalc-section-first-body-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 28 Jan 2011 04:26:02 +0000 (04:26 +0000)]
2011-01-27  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Add CRASH calls to further debug tiled compositor memcpy crash.
        https://bugs.webkit.org/show_bug.cgi?id=52379

        Test: LayoutTests/compositing (to verify these weren't triggered)

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::invalidateRect):
        (WebCore::LayerTilerChromium::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 28 Jan 2011 04:14:43 +0000 (04:14 +0000)]
2011-01-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact
        https://bugs.webkit.org/show_bug.cgi?id=53242

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 03:42:56 +0000 (03:42 +0000)]
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76891.
        http://trac.webkit.org/changeset/76891
        https://bugs.webkit.org/show_bug.cgi?id=53280

        Makes every layout test crash (Requested by othermaciej on
        #webkit).

        * page/EventHandler.cpp:
        * page/EventHandler.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleDidChange):
2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76891.
        http://trac.webkit.org/changeset/76891
        https://bugs.webkit.org/show_bug.cgi?id=53280

        Makes every layout test crash (Requested by othermaciej on
        #webkit).

        * Misc/WebIconDatabase.mm:
        (-[ThreadEnabler threadEnablingSelector:]):
        (importToWebCoreFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 28 Jan 2011 03:30:24 +0000 (03:30 +0000)]
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed, rolling out r76839.
        http://trac.webkit.org/changeset/76839
        https://bugs.webkit.org/show_bug.cgi?id=49744

        broke pixel tests

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::localCaretRect):
2011-01-27  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed, rolling out r76839.
        http://trac.webkit.org/changeset/76839
        https://bugs.webkit.org/show_bug.cgi?id=49744

        broke pixel tests

        * editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
        * editing/selection/caret-painting-after-paste-undo.html: Removed.
        * platform/mac/editing/deleting/5408255-expected.png:
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 28 Jan 2011 03:09:48 +0000 (03:09 +0000)]
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        execCommand("Paste") doesn't work in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52785

        Unskip paste tests, except the ones that still fail.

        * platform/mac-wk2/Skipped:
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        execCommand("Paste") doesn't work in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52785

        Thread through the new JavaScriptCanAccessClipboard setting.

        * Shared/WebPreferencesStore.h:
        * UIProcess/API/C/WKPreferences.cpp:
        (WKPreferencesSetJavaScriptCanAccessClipboard):
        (WKPreferencesGetJavaScriptCanAccessClipboard):
        * UIProcess/API/C/WKPreferences.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::updatePreferences):
2011-01-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        execCommand("Paste") doesn't work in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52785

        Enable both of the settings needed to allow paste.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Emil A Eklund <eae@chromium.org>
commit-queue@webkit.org [Fri, 28 Jan 2011 02:41:33 +0000 (02:41 +0000)]
2011-01-27  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        contentEditable formatBlock crashes on divs with contenteditable="false"
        https://bugs.webkit.org/show_bug.cgi?id=53263

        Add test for executing a formatBlock command on a selection containing an
        element with contenteditable=false.

        * editing/execCommand/format-block-contenteditable-false-expected.txt: Added.
        * editing/execCommand/format-block-contenteditable-false.html: Added.
2011-01-27  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        contentEditable formatBlock crashes on divs with contenteditable="false"
        https://bugs.webkit.org/show_bug.cgi?id=53263

        Check if editableRootForPosition returns null for position.

        Test: editing/execCommand/format-block-contenteditable-false.html

        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::formatRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 28 Jan 2011 02:26:02 +0000 (02:26 +0000)]
2011-01-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Remove RenderMedia members that aren't used.
        https://bugs.webkit.org/show_bug.cgi?id=53245

        Refactoring, no change in behavior, so no new tests.

        * rendering/RenderMedia.h: Removed unused member variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 28 Jan 2011 02:20:47 +0000 (02:20 +0000)]
2011-01-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add WTFString method to compare equality with Vector<UChar>
        https://bugs.webkit.org/show_bug.cgi?id=53266

        I'm planning to use this method in the new XSS filter implementation,
        but it seems generally useful.

        * wtf/text/StringImpl.h:
        (WTF::equalIgnoringNullity):
        * wtf/text/WTFString.h:
        (WTF::equalIgnoringNullity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 28 Jan 2011 02:18:02 +0000 (02:18 +0000)]
2011-01-27  Michael Saboff  <msaboff@apple.com>

        Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
        https://bugs.webkit.org/show_bug.cgi?id=53271

        Added new isValid() methods to check if a contained object in
        a WeakGCMap is valid when using an unchecked iterator.

        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::isValid):
2011-01-27  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
        https://bugs.webkit.org/show_bug.cgi?id=53271

        Precautionary change.
        Changed RootObject to use WeakGCMap instead of HashSet.
        Found will looking for another issue, but can't produce a test case
        that is problematic.  THerefore there aren't any new tests.

        * bridge/runtime_root.cpp:
        (JSC::Bindings::RootObject::invalidate):
        (JSC::Bindings::RootObject::addRuntimeObject):
        (JSC::Bindings::RootObject::removeRuntimeObject):
        * bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 28 Jan 2011 02:15:13 +0000 (02:15 +0000)]
2011-01-27  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Rename Typed Array slice() to subset()
        https://bugs.webkit.org/show_bug.cgi?id=53273

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::constructArrayBufferView):
        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
        (WebCore::constructWebGLArray):
        * html/canvas/Float32Array.cpp:
        (WebCore::Float32Array::subset):
        * html/canvas/Float32Array.h:
        * html/canvas/Float32Array.idl:
        * html/canvas/Int16Array.cpp:
        (WebCore::Int16Array::subset):
        * html/canvas/Int16Array.h:
        * html/canvas/Int16Array.idl:
        * html/canvas/Int32Array.cpp:
        (WebCore::Int32Array::subset):
        * html/canvas/Int32Array.h:
        * html/canvas/Int32Array.idl:
        * html/canvas/Int8Array.cpp:
        (WebCore::Int8Array::subset):
        * html/canvas/Int8Array.h:
        * html/canvas/Int8Array.idl:
        * html/canvas/TypedArrayBase.h:
        (WebCore::TypedArrayBase::subsetImpl):
        * html/canvas/Uint16Array.cpp:
        (WebCore::Uint16Array::subset):
        * html/canvas/Uint16Array.h:
        * html/canvas/Uint16Array.idl:
        * html/canvas/Uint32Array.cpp:
        (WebCore::Uint32Array::subset):
        * html/canvas/Uint32Array.h:
        * html/canvas/Uint32Array.idl:
        * html/canvas/Uint8Array.cpp:
        (WebCore::Uint8Array::subset):
        * html/canvas/Uint8Array.h:
        * html/canvas/Uint8Array.idl:
2011-01-27  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Rename Typed Array slice() to subset()
        https://bugs.webkit.org/show_bug.cgi?id=53273

        * fast/canvas/webgl/array-setters.html:
        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
        * fast/canvas/webgl/draw-elements-out-of-bounds.html:
        * fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
        * fast/canvas/webgl/webgl-array-invalid-ranges.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 28 Jan 2011 02:12:39 +0000 (02:12 +0000)]
2011-01-27  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Changing cursor style has no effect until the mouse moves
        https://bugs.webkit.org/show_bug.cgi?id=14344
        rdar://problem/7563712

        No tests added because we don't have infrastructure for testing actual cursor
        changes (as opposed to cursor style computation) at this time. We might add it later.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.
        * page/EventHandler.h: Ditto.

        * rendering/RenderObject.cpp:
        (WebCore::areNonIdenticalCursorListsEqual): Added.
        (WebCore::areCursorsEqual): Added.
        (WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if
        cursor styles changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Finnur Thorarinsson <finnur.webkit@gmail.com>
commit-queue@webkit.org [Fri, 28 Jan 2011 02:03:58 +0000 (02:03 +0000)]
2011-01-27  Finnur Thorarinsson  <finnur.webkit@gmail.com>

        Reviewed by Ojan Vafai.

        This addresses a regression introduced by r75784, as described in:
        https://bugs.webkit.org/show_bug.cgi?id=53176

        The problem is that originalEndContainer and originalEndOffset was
        meant to capture the end of the document, but was being assigned after
        a call to searchRange->setStart() (when scoping is restarted), which can
        result in the Range being collapsed to start (thereby assigning the
        wrong value to the Container/Offset pair).

        This code is never triggered by layout tests, but I'm adding a regressiono
        test on the Chromium side for this.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::scopeStringMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Fri, 28 Jan 2011 01:51:51 +0000 (01:51 +0000)]
2011-01-27  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        SVG Use Cycle is not detected
        https://bugs.webkit.org/show_bug.cgi?id=52544

        Test for indirect <use> recursion. This test passes if
        no crash occurs.

        * svg/custom/recursive-use2-expected.txt: Added.
        * svg/custom/recursive-use2.svg: Added.
2011-01-27  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        SVG Use Cycle is not detected
        https://bugs.webkit.org/show_bug.cgi?id=52544

        We should check if SVGUseElement::buildInstanceTree finds problem
        for every child node. If it finds problem for any children we must
        return immediately because otherwise the foundProblem variable may
        be rewritten to false.

        Test: svg/custom/recursive-use2.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildInstanceTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 01:29:16 +0000 (01:29 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Define GC3D types to match GL types and use them in WebGraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=51947

        * public/WebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 28 Jan 2011 01:26:12 +0000 (01:26 +0000)]
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
        https://bugs.webkit.org/show_bug.cgi?id=53054

        * fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt: Added.
        * fast/canvas/webgl/tex-sub-image-2d-bad-args.html: Added.
2011-01-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
        https://bugs.webkit.org/show_bug.cgi?id=53054

        Test: fast/canvas/webgl/tex-sub-image-2d-bad-args.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::texSubImage2DBase): Check format/type match.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia...
commit-queue@webkit.org [Fri, 28 Jan 2011 01:23:22 +0000 (01:23 +0000)]
2011-01-27  Yi Shen  <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Add fullscreen media control button for html video
        https://bugs.webkit.org/show_bug.cgi?id=51543

        Implement media control fullscreen button for QtWebKit html5 video.

        * css/mediaControlsQt.css:
        (video::-webkit-media-controls-fullscreen-button):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintMediaFullscreenButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-27 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 28 Jan 2011 01:22:16 +0000 (01:22 +0000)]
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Remove FrameLoader::url() and update callers to use
        Document::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        Refactor, no new tests.

        * WebCore.exp.in:
        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        (WebCore::Document::removePendingSheet):
        * history/CachedFrame.cpp:
        (WebCore::CachedFrameBase::CachedFrameBase):
        * history/PageCache.cpp:
        (WebCore::logCanCacheFrameDecision):
        (WebCore::PageCache::canCachePageContainingThisFrame):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::inspectedURL):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForFrame):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::replaceDocument):
        (WebCore::DocumentWriter::deprecatedFrameEncoding):
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::updateForStandardLoad):
        (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
        (WebCore::HistoryController::updateForSameDocumentNavigation):
        * loader/NavigationScheduler.cpp:
        (WebCore::ScheduledHistoryNavigation::fire):
        (WebCore::NavigationScheduler::scheduleLocationChange):
        (WebCore::NavigationScheduler::scheduleRefresh):
        * page/FrameView.cpp:
        (WebCore::FrameView::updateControlTints):
        * page/Location.cpp:
        (WebCore::Location::url):
        (WebCore::Location::setProtocol):
        (WebCore::Location::setHost):
        (WebCore::Location::setHostname):
        (WebCore::Location::setPort):
        (WebCore::Location::setPathname):
        (WebCore::Location::setSearch):
        (WebCore::Location::setHash):
        (WebCore::Location::reload):
        * page/Page.cpp:
        (WebCore::Page::goToItem):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * ewk/ewk_frame.cpp:
        (ewk_frame_uri_changed):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_icon_uri):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::dispatchDidFinishDocumentLoad):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebView/WebView.mm:
        (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * Api/qwebframe.cpp:
        (QWebFrame::url):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebFrame.cpp:
        (WebFrame::url):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::dispatchDidFinishDocumentLoad):
2011-01-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Use Document::url() instead of FrameLoader::url().
        https://bugs.webkit.org/show_bug.cgi?id=41165

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
        (WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
        (WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix scrollbars in Safari's Downloads window and Bookmarks view by implementing two...
aroben@apple.com [Fri, 28 Jan 2011 01:19:27 +0000 (01:19 +0000)]
Fix scrollbars in Safari's Downloads window and Bookmarks view by implementing two needed functions from ScrollableArea.

Patch by Sam Weinig <sam@webkit.org> on 2011-01-27
Reviewed by Adam Roben.

* WebScrollBar.cpp:
(WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
we are a horizontal scrollbar.
(WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
are a vertical scrollbar.
* WebScrollBar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76871 268f45cc-cd09-0410-ab3c-d52691b4dbfc