WebKit-https.git
9 years ago2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 15 Oct 2010 20:53:46 +0000 (20:53 +0000)]
2010-10-15  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
        https://bugs.webkit.org/show_bug.cgi?id=47712

        Extended queryCommandValue('formatBlock', false, null) to support article, aside, blockquote, dd, dl,
        div, dl, dt, dl, footer, header, hgroup, nav, and section. Because this makes isElementForFormatBlockCommand
        in Editor.cpp and FormatBlockCommand::isElementToApplyInFormatBlockCommand identical, they are merged and moved
        to FormatBlockCommand.cpp

        Tests are added to editing/execCommand/query-format-block.html

        * editing/Editor.cpp: Removed isElementForFormatBlockCommand and Editor::elementForFormatBlockCommand.
        * editing/Editor.h:
        * editing/EditorCommand.cpp:
        (WebCore::executeFormatBlock): Removed the check of tag name; the check is moved into FormatBlockCommand.
        (WebCore::valueFormatBlock): Calls FormatBlockCommand::elementForFormatBlockCommand.
        * editing/FormatBlockCommand.cpp:
        (WebCore::isElementForFormatBlock):
        (WebCore::FormatBlockCommand::FormatBlockCommand):
        (WebCore::FormatBlockCommand::formatSelection): Added to check the tag name. Exit early if the specified tag name
        is not what FormatBlock should apply. Set m_didApply true if m_didApply did apply the element.
        (WebCore::FormatBlockCommand::formatRange): Moved from Editor.cpp.  Takes Range* instead of accessing selection directly.
        (WebCore::FormatBlockCommand::elementForFormatBlockCommand): Moved from Editor.cpp
        (WebCore::enclosingBlockToSplitTreeTo): Calls isElementForFormatBlock.
        * editing/FormatBlockCommand.h:
        (WebCore::FormatBlockCommand::didApply): Added.
2010-10-15  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
        https://bugs.webkit.org/show_bug.cgi?id=47712

        Added queryCommandValue('formatBlock') tests for support article, aside, blockquote, dd, dl, div,
        dl, dt, dl, footer, header, hgroup, nav, and section.

        Also added tests to ensure we don't return tag name for a subset of unsupported elements.

        * editing/execCommand/query-format-block-expected.txt:
        * editing/execCommand/script-tests/query-format-block.js:
        (queryFormatBlock):
        (selectFirstPosition):
        (selectMiddleOfHelloWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 15 Oct 2010 20:39:08 +0000 (20:39 +0000)]
2010-10-15  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline two GTK+ tests.

        * platform/gtk/fast/forms/mailto/advanced-get-expected.txt:
        * platform/gtk/fast/forms/mailto/advanced-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 15 Oct 2010 20:02:34 +0000 (20:02 +0000)]
2010-10-15  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        carto.net Dock example redraws *way* too often
        https://bugs.webkit.org/show_bug.cgi?id=16090

        Setting the attributes x, y, width or height shouldn't cause a repaint if the image boundaries don't change.
        Added updateFromElement() to RenderSVGImage that checks if the old boundaries match the new boundaries after
        setting one of the attributes of above. Mark renderer for layout (and therefore repaint) if the boundaries
        differ, do nothing if not.
        Also added caching of the repaint rect to avoid multiple calculations.

        Test: svg/custom/repaint-on-constant-size-change.svg

        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::RenderSVGImage):
        (WebCore::RenderSVGImage::layout): Update repaint rect on layout.
        (WebCore::RenderSVGImage::updateFromElement): Check SVGImageElement for boundaries update.
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): Return the cached repaint rect.
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::svgAttributeChanged): Call updateFromElement() on changes to x, y, width or height.
2010-10-15  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        carto.net Dock example redraws *way* too often
        https://bugs.webkit.org/show_bug.cgi?id=16090

        Added a repaint example to make sure that setting the attributes x, y, width or height
        doens't cause a repaint if the boundaries don't change.

        * platform/mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
        * platform/mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
        * platform/mac/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
        * svg/custom/repaint-on-constant-size-change.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 15 Oct 2010 19:57:09 +0000 (19:57 +0000)]
2010-10-15  Martin Robinson  <mrobinson@igalia.com>

        Build fix for GTK+.

        * platform/network/soup/cache/webkit/soup-cache.h: Do not use PLATFORM(...) macro
        in a file that does not include config.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 15 Oct 2010 19:46:15 +0000 (19:46 +0000)]
2010-10-15  Dirk Schulze  <krit@webkit.org>

        Unreviewed rebaseline of Snow Leopard.

        Moved current results for SVGFEConvolveMatrixElement to mac-leopard.

        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
        * platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd FindIndicatorWindow class
andersca@apple.com [Fri, 15 Oct 2010 19:16:43 +0000 (19:16 +0000)]
Add FindIndicatorWindow class
https://bugs.webkit.org/show_bug.cgi?id=47731

Reviewed by Sam Weinig.

WebCore:

Export symbols needed by the FindIndicator in WebKit2.

* WebCore.exp.in:

WebKit2:

* UIProcess/API/mac/FindIndicatorWindow.h: Added.
* UIProcess/API/mac/FindIndicatorWindow.mm: Added.
(-[WebFindIndicatorView _initWithFindIndicator:WebKit::]):
Initialize the find indicator view.

(-[WebFindIndicatorView drawRect:]):
Ask the find indicator to draw.

(-[WebFindIndicatorView isFlipped]):
Return YES.

(WebKit::FindIndicatorWindow::~FindIndicatorWindow):
Make sure to close the window.

(WebKit::FindIndicatorWindow::setFindIndicator):
Update the find indicator window.

(WebKit::FindIndicatorWindow::closeWindow):
Close and release the window.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
Create a find indicator window.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 15 Oct 2010 18:48:09 +0000 (18:48 +0000)]
2010-10-15  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] compile TestNetscapePlugIn on Chromium mac
        https://bugs.webkit.org/show_bug.cgi?id=47633

        * WebKit.gyp:  Add a mac specific target for compiling TestNetscapePlugIn
            Fix an include dir so we can compile in a chromium checkout.
2010-10-15  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] compile TestNetscapePlugIn on Chromium mac
        https://bugs.webkit.org/show_bug.cgi?id=47633

        * DumpRenderTree/DumpRenderTree.gypi: files to compile
        * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
        (NP_GetEntryPoints):
        (NPP_New):
        (NPP_Destroy):
        (NPP_HandleEvent):
        (NPP_GetValue):
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Fri, 15 Oct 2010 18:42:11 +0000 (18:42 +0000)]
2010-10-15  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed. Build fix.

        Add new files needed by the Soup network backend, and #ifdef a
        GTK+-port only include in soup-cache.h.

        * CMakeListsEfl.txt:
        * platform/network/soup/cache/webkit/soup-cache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 15 Oct 2010 18:30:37 +0000 (18:30 +0000)]
2010-10-14  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Use more specific types for node pointers, especially when calling node insertion and removal functions
        https://bugs.webkit.org/show_bug.cgi?id=47702

        Refactoring. No new tests.

        While developing this patch I temporarily removed the node insertion and
        removal member functions from the Node class and fixed almost all call sites
        so they call it directly on the ContainerNode class, which will be important
        once we make the functions non-virtual.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::appendChild):
        * dom/Document.cpp:
        (WebCore::Document::caretRangeFromPoint):
        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::itemWithName):
        * dom/Position.cpp:
        (WebCore::Position::previous):
        (WebCore::Position::next):
        * dom/Text.cpp:
        (WebCore::Text::replaceWholeText):
        * dom/TreeWalker.cpp:
        (WebCore::TreeWalker::firstChild):
        (WebCore::TreeWalker::lastChild):
        (WebCore::TreeWalker::previousNode):
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply):
        * editing/CompositeEditCommand.h:
        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::doApply):
        * editing/JoinTextNodesCommand.cpp:
        (WebCore::JoinTextNodesCommand::doApply):
        (WebCore::JoinTextNodesCommand::doUnapply):
        * editing/MergeIdenticalElementsCommand.cpp:
        (WebCore::MergeIdenticalElementsCommand::doUnapply):
        * editing/RemoveNodeCommand.cpp:
        (WebCore::RemoveNodeCommand::doApply):
        (WebCore::RemoveNodeCommand::doUnapply):
        * editing/RemoveNodeCommand.h:
        * editing/SplitElementCommand.cpp:
        (WebCore::SplitElementCommand::executeApply):
        * editing/SplitTextNodeCommand.cpp:
        (WebCore::SplitTextNodeCommand::doApply):
        (WebCore::SplitTextNodeCommand::doReapply):
        * editing/TextIterator.cpp:
        (WebCore::parentCrossingShadowBoundaries):
        * editing/htmlediting.cpp:
        (WebCore::enclosingList):
        * editing/markup.cpp:
        (WebCore::serializeNodes):
        (WebCore::ancestorToRetainStructureAndAppearance):
        (WebCore::createMarkup):
        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::updateFocusAppearance):
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::rendererIsNeeded):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::rendererIsNeeded):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::attach):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::insertedIntoTree):
        * html/HTMLLegendElement.cpp:
        (WebCore::HTMLLegendElement::associatedControl):
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::recalcSelectOptions):
        (WebCore::HTMLOptGroupElement::ownerSelectElement):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::ownerSelectElement):
        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::insertRow):
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::rowIndex):
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::getRangeAt):
        (WebCore::DOMSelection::containsNode):
        * rendering/RenderSVGGradientStop.cpp:
        (WebCore::RenderSVGGradientStop::gradientElement):
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::ownerSVGElement):
        (WebCore::SVGElement::viewportElement):
        * svg/SVGFELightElement.cpp:
        (WebCore::SVGFELightElement::svgAttributeChanged):
        (WebCore::SVGFELightElement::childrenChanged):
        * svg/SVGFEMergeNodeElement.cpp:
        (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
        * svg/SVGFontFaceFormatElement.cpp:
        (WebCore::SVGFontFaceFormatElement::childrenChanged):
        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::childrenChanged):
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::invalidateGlyphCache):
        * svg/SVGHKernElement.cpp:
        (WebCore::SVGHKernElement::insertedIntoDocument):
        (WebCore::SVGHKernElement::removedFromDocument):
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::nearestViewportElement):
        (WebCore::SVGLocatable::farthestViewportElement):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::updateContainerOffsets):
        * svg/SVGVKernElement.cpp:
        (WebCore::SVGVKernElement::insertedIntoDocument):
        (WebCore::SVGVKernElement::removedFromDocument):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::targetElement):
        * wml/WMLDoElement.cpp:
        (WebCore::WMLDoElement::insertedIntoDocument):
        (WebCore::WMLDoElement::removedFromDocument):
        * wml/WMLNoopElement.cpp:
        (WebCore::WMLNoopElement::insertedIntoDocument):
        * wml/WMLOptionElement.cpp:
        (WebCore::ownerSelectElement):
        * wml/WMLPostfieldElement.cpp:
        (WebCore::WMLPostfieldElement::insertedIntoDocument):
        (WebCore::WMLPostfieldElement::removedFromDocument):
        * wml/WMLSetvarElement.cpp:
        (WebCore::WMLSetvarElement::insertedIntoDocument):
        (WebCore::WMLSetvarElement::removedFromDocument):
        * wml/WMLTaskElement.cpp:
        (WebCore::WMLTaskElement::insertedIntoDocument):
        (WebCore::WMLTaskElement::removedFromDocument):
        * wml/WMLTimerElement.cpp:
        (WebCore::WMLTimerElement::insertedIntoDocument):
        (WebCore::WMLTimerElement::removedFromDocument):
        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodesInAxis):
        Use ContainerNode* for the result of the parentNode function now that
        it returns a ContainerNode*. In the past it used to return just Node*.

        * dom/ContainerNode.h: Added toContainerNode.

        * dom/Element.h: Use ContainerNode*. Added toElement.

        * dom/Element.cpp:
        (WebCore::Element::deprecatedCreateContextualFragment): Explcitly
        cast to HTMLElement* in the case that handles <html> and <body>
        elements.
        (WebCore::Element::baseURI): Use ContainerNode*.

        * dom/Node.cpp:
        (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Use ContainerNode*.
        (WebCore::Node::isDescendantOf): Ditto.
        (WebCore::Node::createRendererIfNeeded): Ditto.
        (WebCore::Node::setTextContent): Use already-typecast pointer in a call to
        appendChild.
        (WebCore::Node::ancestorElement): Use ContainerNode*.

        * dom/Range.cpp:
        (WebCore::Range::compareNode): Use ContainerNode*.
        (WebCore::Range::intersectsNode): Ditto.
        (WebCore::Range::processContents): Cast to ContainerNode* in a couple cases
        where we previously checked that the node in question has a child. Any node
        that returns a non-zero value for firstChild is a ContainerNode.
        (WebCore::Range::checkNodeBA): Ditto.
        (WebCore::Range::selectNode): Ditto.
        (WebCore::Range::surroundContents): Ditto.

        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::insertErrorMessageBlock): Rewrote code to use
        more specific types, document instead of doc, and paragraph instead of par.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
        Use ContainerNode*.
        (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
        Use replaceElementWithSpanPreservingChildrenAndAttributes; the old function
        took a Node argument and had Node in its name.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Use ContainerNode.
        (WebCore::CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes):
        Renamed and changed to take HTMLElement. Also use ContainerNode.
        (WebCore::CompositeEditCommand::prune): Ditto.
        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Ditto.

        * editing/ReplaceNodeWithSpanCommand.cpp:
        (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand): Take an
        HTMLElement instead of a Node. Call it m_elementToReplace instead of m_node.
        (WebCore::swapInNodePreservingAttributesAndChildren): Take HTMLElement.
        (WebCore::ReplaceNodeWithSpanCommand::doApply): Updated for name changes.
        (WebCore::ReplaceNodeWithSpanCommand::doUnapply): Ditto.
        * editing/ReplaceNodeWithSpanCommand.h: Ditto.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment): Use StyledElement for result
        of insertFragmentForTestRendering since that's what it returns.
        (WebCore::ReplacementFragment::removeNode): Use ContainerNode.
        (WebCore::ReplacementFragment::insertNodeBefore): Ditto.
        (WebCore::ReplacementFragment::insertFragmentForTestRendering): Return StyledElement.
        Use HTMLElement for body.
        (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): Take
        StyledElement.
        (WebCore::ReplaceSelectionCommand::handleStyleSpans): Use ContainerNode.
        (WebCore::ReplaceSelectionCommand::copyStyleToChildren): Use HTMLElement for
        the cloned span, since the clone will be a sspan too.
        (WebCore::ReplaceSelectionCommand::insertAsListItems): Use ContainerNode since
        the list item has a child, and that proves it is a ContainerNode.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        Use ContainerNode and also removed an unnneded local variable.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setOuterText): Use ContainerNode.
        (WebCore::HTMLElement::insertAdjacent): Use ContainerNode and also use && to make
        the logic a little simpler.
        (WebCore::contextElementForInsertion): Use ContainerNode.
        (WebCore::HTMLElement::findFormAncestor): Ditto.

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::removeNode): Use ContainerNode.
        (WebCore::InspectorDOMAgent::changeTagName): Ditto.
        (WebCore::InspectorDOMAgent::setOuterHTML): Ditto.
        (WebCore::InspectorDOMAgent::innerParentNode): Use isDocumentNode instead of
        nodeType. We should almost never use nodeType inside the engine.
        (WebCore::InspectorDOMAgent::didInsertDOMNode): Use ContainerNode.
        (WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.

        * wml/WMLOptGroupElement.cpp: Removed unneeded overrides of insertBefore,
        replaceChild, removeChild, appendChild, and removeChildren functions.
        Ths already overrides childrenChanged, that is called by all of the above,
        and it does the same thing these functions did.
        (WebCore::ownerSelectElement): Use ContainerNode.
        * wml/WMLOptGroupElement.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix introspection support
andersca@apple.com [Fri, 15 Oct 2010 18:12:36 +0000 (18:12 +0000)]
[GTK] Fix introspection support
https://bugs.webkit.org/show_bug.cgi?id=47723

Patch by Sergio Villar Senin <svillar@igalia.com> on 2010-10-15
Reviewed by Martin Robinson.

Added HTTP cache directory to the WebkitGtk+ GIR sources.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 15 Oct 2010 18:05:40 +0000 (18:05 +0000)]
2010-10-15  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Crash in WebCore::ApplyStyleCommand::applyBlockStyle
        https://bugs.webkit.org/show_bug.cgi?id=47699

        The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
        Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.

        Test: editing/style/block-style-progress-crash.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
2010-10-15  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Crash in WebCore::ApplyStyleCommand::applyBlockStyle
        https://bugs.webkit.org/show_bug.cgi?id=47699

        Added a test to ensure WebKit does not crash when the body is content editable
        and justifying a progress element and '>' following the element to the right.

        * editing/style/block-style-progress-crash-expected.txt: Added.
        * editing/style/block-style-progress-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 15 Oct 2010 17:53:55 +0000 (17:53 +0000)]
2010-10-15  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skipped flaky tests, added followup bug:
        https://bugs.webkit.org/show_bug.cgi?id=47727

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Leandro Pereira <leandro@profusion.mobi>
commit-queue@webkit.org [Fri, 15 Oct 2010 17:37:13 +0000 (17:37 +0000)]
2010-10-15  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        build-webkit: Should die when make fails when build a CMake project
        https://bugs.webkit.org/show_bug.cgi?id=47726

        * Scripts/webkitdirs.pm: If make fails, die immediately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a FindIndicator class
andersca@apple.com [Fri, 15 Oct 2010 17:27:12 +0000 (17:27 +0000)]
Add a FindIndicator class
https://bugs.webkit.org/show_bug.cgi?id=47635

Reviewed by Sam Weinig.

WebCore:

Make Gradient.h and Generator.h private headers; they're used by WebKit2.

* WebCore.xcodeproj/project.pbxproj:

WebKit2:

* Shared/BackingStore.h:
(WebKit::BackingStore::bounds):
New function that returns the bounds of the backing store.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
Add stub.

* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::setFindIndicator):
Add stub.

* UIProcess/FindIndicator.cpp: Added.
* UIProcess/FindIndicator.h:

* UIProcess/PageClient.h:
Add setFindIndicator client member function.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
Call PageClient::setFindIndicator.

* UIProcess/WebPageProxy.messages.in:
Add a fadeOut boolean to the message.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator):
Add stub.

* UIProcess/win/WebView.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::resetFindIndicator):
* WebProcess/WebPage/FindController.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Fri, 15 Oct 2010 17:12:46 +0000 (17:12 +0000)]
2010-10-15  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [Soup] Should not ignore body for redirection responses
        https://bugs.webkit.org/show_bug.cgi?id=29299

        Tests that 302 redirections without Location do not ignore the
        body for redirection purpouses (the body could have a meta
        http-equiv=refresh)

        * http/tests/navigation/redirect302-metaredirect-expected.txt: Added.
        * http/tests/navigation/redirect302-metaredirect.html: Added.
        * http/tests/navigation/resources/redirect302-metaredirect.html: Added.
        * http/tests/navigation/resources/redirect302-metaredirect.pl: Added.
2010-10-15  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [Soup] Should not ignore body for redirection responses
        https://bugs.webkit.org/show_bug.cgi?id=29299

        Body is now provided to WebKitGtk+ in some redirections (like 302)
        because it could be used by servers to perform clunky redirections
        for example using http-equiv=REFRESH

        Test: http/tests/navigation/redirect302-metaredirect.html

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotHeadersCallback):
        (WebCore::finishedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 15 Oct 2010 17:06:53 +0000 (17:06 +0000)]
2010-10-15  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium expectations tweak.

        Add failing tests from r69824 and r69833.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Fri, 15 Oct 2010 16:48:06 +0000 (16:48 +0000)]
2010-10-15  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix introspection support
        https://bugs.webkit.org/show_bug.cgi?id=47723

        Added HTTP cache directory to the WebkitGtk+ GIR sources.

        * GNUmakefile.am:
2010-10-15  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix introspection support
        https://bugs.webkit.org/show_bug.cgi?id=47723

        WebKitSoupCacheType was incorrectly registered twice. Renamed to
        WebKitSoupCacheTypeType for the enumerated type.

        * platform/network/soup/cache/webkit/soup-cache.c:
        (webkit_soup_cache_type_get_type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 15 Oct 2010 16:30:01 +0000 (16:30 +0000)]
2010-10-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r69809.
        http://trac.webkit.org/changeset/69809
        https://bugs.webkit.org/show_bug.cgi?id=47725

        Broke chromium mac compile (Requested by japhet on #webkit).

        * WebKit.gyp:
2010-10-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r69809.
        http://trac.webkit.org/changeset/69809
        https://bugs.webkit.org/show_bug.cgi?id=47725

        Broke chromium mac compile (Requested by japhet on #webkit).

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NP_GetEntryPoints):
        (NPP_New):
        (NPP_Destroy):
        (NPP_HandleEvent):
        (NPP_GetValue):
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Qi Zhang <qi.2.zhang@nokia.com>
commit-queue@webkit.org [Fri, 15 Oct 2010 16:27:27 +0000 (16:27 +0000)]
2010-10-15  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] window.close() doesn't work in qt
        https://bugs.webkit.org/show_bug.cgi?id=46186

        Introduce new attribute in QWebSettings to trigger "setAllowScriptsToCloseWindow"

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 15 Oct 2010 15:56:18 +0000 (15:56 +0000)]
2010-10-15  Martin Robinson  <mrobinson@igalia.com>

        Fix my rebaseline sanfu.

        * fast/forms/mailto/advanced-get.html:
        * fast/forms/mailto/advanced-put.html:
        * platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-get-expected.txt.
        * platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-put-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 15 Oct 2010 15:34:43 +0000 (15:34 +0000)]
2010-10-15  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline a few other failing tests. They differ because
        dumpAsText output depends on whether or not certain content
        reaches the edge of the view and wraps.

        * fast/forms/mailto/advanced-get.html:
        * fast/forms/mailto/advanced-put.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 15 Oct 2010 15:20:36 +0000 (15:20 +0000)]
2010-10-15  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extract consoleMessages related stuff from populateScriptObjects into separate function.

        This is a part of Inspector protocol sanitization activity.
        We want to populate console messages only if it is required by frontend.

        https://bugs.webkit.org/show_bug.cgi?id=46802

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setConsoleMessagesEnabled):
        (WebCore::InspectorController::addConsoleMessage):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::populateScriptObjects):
        * inspector/InspectorController.h:
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/inspector.js:
        (WebInspector.doLoadedDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix. Unreviewed.
jberlin@webkit.org [Fri, 15 Oct 2010 15:11:12 +0000 (15:11 +0000)]
Windows build fix. Unreviewed.

* WebCoreSupport/WebInspectorClient.cpp:
Add a missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 15 Oct 2010 13:56:24 +0000 (13:56 +0000)]
2010-10-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Unbreak scrolling the ContentsLayer with QWebView

        r69777 broke scrolling the contents layer in QWebView by not restoring
        the painter clip after painting each part of the dirty region.

        * Api/qwebframe.cpp:
        (QWebFramePrivate::renderRelativeCoords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 15 Oct 2010 12:29:56 +0000 (12:29 +0000)]
2010-10-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Replace some String::format() usages by StringConcatenate in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=47714

        * wtf/text/StringConcatenate.h: Add UChar specific StringTypeAdapter, to accept single UChars in makeString().
2010-10-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Replace some String::format() usages by StringConcatenate in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=47714

        * src/BackForwardListClientImpl.cpp:
        (WebKit::BackForwardListClientImpl::itemAtIndex):
        * src/DebuggerAgentManager.cpp:
        (WebKit::DebuggerAgentManager::debugDetach):
        * src/LocalizedStrings.cpp:
        (WebCore::imageTitle):
        * src/WebPageSerializer.cpp:
        (WebKit::WebPageSerializer::generateMetaCharsetDeclaration):
        (WebKit::WebPageSerializer::generateBaseTagDeclaration):
2010-10-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Replace some String::format() usages by StringConcatenate in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=47714

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidFailLoad):
        * webkit/webkitwebsettings.cpp:
        (webkitOSVersion):
        (webkitUserAgent):
2010-10-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Replace some String::format() usages by StringConcatenate in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=47714

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorFrontendClient::updateWindowTitle):
        * WebView.cpp:
        (WebView::standardUserAgentWithApplicationName):
        (osVersion):
2010-10-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Replace some String::format() usages by StringConcatenate in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=47714

        * WebCoreSupport/PlatformStrategiesWinCE.cpp:
        (PlatformStrategiesWinCE::imageTitle):
        (PlatformStrategiesWinCE::multipleFileUploadText):
2010-10-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Replace some String::format() usages by StringConcatenate in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=47714

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::agentOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 15 Oct 2010 12:23:36 +0000 (12:23 +0000)]
2010-10-15  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Nikolas Zimmermann.

        [EFL] REGRESSION(69798) UCHAR can't be converted to String.
        https://bugs.webkit.org/show_bug.cgi?id=47698

        Create String value using String(const char*, 1) instead of operator[].

        No tests. No functionality changed.

        * platform/efl/PlatformKeyboardEventEfl.cpp:
        (WebCore::createWindowsKeyMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Fri, 15 Oct 2010 10:39:07 +0000 (10:39 +0000)]
2010-10-15  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Do a stricter check for invalid base64 dataURLs
        https://bugs.webkit.org/show_bug.cgi?id=47717

        Restore the strict base64 decoding we added in
        https://bugs.webkit.org/show_bug.cgi?id=44261 and then rolled back
        in https://bugs.webkit.org/show_bug.cgi?id=47666 due to a failing
        test. The actual issue was that we were not finishing the load of
        the resource gracefully when an error happened.

        Loading invalid base64-encoded data:// URLs are now handled
        properly.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::parseDataUrl):
        * platform/network/soup/cache/soup-request-data.c:
        (webkit_soup_request_data_send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 15 Oct 2010 09:04:22 +0000 (09:04 +0000)]
2010-10-15  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix for Debug Leopard which is failng to compile after r69842.

        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::ByteCompiler::emitDisjunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 15 Oct 2010 08:47:17 +0000 (08:47 +0000)]
2010-10-15  Alejandro G. Castro  <alex@igalia.com>

        Rebaseline some failing tests to the former results, apparently
        they are flaky, skip if they continue failing.

        * platform/gtk/mathml/presentation/fenced-expected.txt:
        * platform/gtk/mathml/presentation/subsup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 15 Oct 2010 08:33:53 +0000 (08:33 +0000)]
2010-10-15  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        compile fail with gtk >= 2.22
        https://bugs.webkit.org/show_bug.cgi?id=47483

        * platform/graphics/gtk/FontGtk.cpp: Removed the shrink operation,
        it was added long time ago and currently it is not adding any real
        area to the clip vertically, actually the gtk3 shrink version did
        not work.
        (WebCore::Font::drawComplexText):
        * platform/gtk/gtk2drawing.c: Undef the deprecation flags, this
        file is full of gtk2 stuff, and it does not seem interesting to
        upgrade because we are already creating a new version of the file
        for gtk3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 15 Oct 2010 08:31:03 +0000 (08:31 +0000)]
2010-10-14  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: inspector settings/properties/states management
        should be extracted into separate class.

        We have a lot of flags/values in InspectorController.
        Some flags are persisting into profile.
        Others are part of inspector state for frontend.
        All these flags should keep their values after navigation.
        It'd be better to extract these flags/values into separate
        class which will care about theirs lifetime.

        https://bugs.webkit.org/show_bug.cgi?id=47275

        WebCore:

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::inspectorStartsAttached):
        (WebCore::InspectorController::setInspectorStartsAttached):
        (WebCore::InspectorController::setInspectorAttachedHeight):
        (WebCore::InspectorController::inspectorAttachedHeight):
        (WebCore::InspectorController::searchingForNodeInPage):
        (WebCore::InspectorController::resourceTrackingEnabled):
        (WebCore::InspectorController::saveApplicationSettings):
        (WebCore::InspectorController::getInspectorState):
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::getSettings):
        (WebCore::InspectorController::storeLastActivePanel):
        (WebCore::InspectorController::mouseDidMoveOverElement):
        (WebCore::InspectorController::handleMousePress):
        (WebCore::InspectorController::setSearchingForNode):
        (WebCore::InspectorController::setMonitoringXHREnabled):
        (WebCore::InspectorController::showPanel):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::restoreDebugger):
        (WebCore::InspectorController::restoreProfiler):
        (WebCore::InspectorController::getTrackedResource):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        (WebCore::InspectorController::setResourceTrackingEnabled):
        (WebCore::InspectorController::ensureSettingsLoaded):
        (WebCore::InspectorController::startTimelineProfiler):
        (WebCore::InspectorController::stopTimelineProfiler):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::loadBreakpoints):
        (WebCore::InspectorController::saveBreakpoints):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
        (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
        * inspector/InspectorState.cpp: Added.
        (WebCore::InspectorState::InspectorState):
        (WebCore::InspectorState::restoreFromInspectorCookie):
        (WebCore::InspectorState::generateStateObjectForFrontend):
        (WebCore::InspectorState::loadFromSettings):
        (WebCore::InspectorState::updateCookie):
        (WebCore::InspectorState::setValue):
        (WebCore::InspectorState::getBoolean):
        (WebCore::InspectorState::getString):
        (WebCore::InspectorState::getLong):
        (WebCore::InspectorState::registerBoolean):
        (WebCore::InspectorState::registerString):
        (WebCore::InspectorState::registerLong):
        (WebCore::InspectorState::Property::create):
        * inspector/InspectorState.h: Added.
        (WebCore::InspectorState::setBoolean):
        (WebCore::InspectorState::setString):
        (WebCore::InspectorState::setLong):

        WebKit/mac:

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController showWindow:]):
        (-[WebInspectorWindowController attach]):
        (-[WebInspectorWindowController detach]):

        WebKit/win:

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorFrontendClient::attachWindow):
        (WebInspectorFrontendClient::detachWindow):
        (WebInspectorFrontendClient::showWindowWithoutNotifications):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 15 Oct 2010 08:20:54 +0000 (08:20 +0000)]
2010-10-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Adam Barth.

        test-webkitpy fails on Linux
        https://bugs.webkit.org/show_bug.cgi?id=47713

        The old code failed on Linux because the MacPort tries to read
        something out of platform that doesn't make sense on Linux.

        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe parenthetical assertion checking isn't working in some cases with YARR
zoltan@webkit.org [Fri, 15 Oct 2010 07:59:17 +0000 (07:59 +0000)]
The parenthetical assertion checking isn't working in some cases with YARR
Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46893

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-10-15
Reviewed by Gavin Barraclough.

Calculate the countToCheck value of a TypeParentheticalAssertion by
subtracting the number of characters which follows
a TypeParentheticalAssertion term with the number of characters which should
be matched by terms which are contained
in the TypeParentheticalAssertion term (minimumSize).

* yarr/RegexInterpreter.cpp:
(JSC::Yarr::ByteCompiler::emitDisjunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Fri, 15 Oct 2010 06:52:54 +0000 (06:52 +0000)]
2010-10-14  Jia Pu  <jpu@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word
        https://bugs.webkit.org/show_bug.cgi?id=47689
        <rdar://problem/8552250>

        The test requires using setTimeout(). So we put it in manual-tests.

        * editing/Editor.cpp:
        (WebCore::Editor::markMisspellingsAfterTypingToPosition): Relpace release() with clear().
        (WebCore::Editor::startCorrectionPanelTimer): Release previously set correction range before
          start timer for next autocorrection check.
        * manual-tests/autocorrection: Added.
        * manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Wei Jia <wjia@chromium.org>
commit-queue@webkit.org [Fri, 15 Oct 2010 06:33:46 +0000 (06:33 +0000)]
2010-10-14  Wei Jia  <wjia@chromium.org>

        Reviewed by Darin Fisher.

        Retrieve info of lock keys from stashed currentInputEvent which
        is stored by chromium when it passes input event to WebCore.
        Retrieving only when stashed event is a keyboard event, which
        means synthetic KeyboardEvent inherits lock key state from real
        keyboard event.
        https://bugs.webkit.org/show_bug.cgi?id=46518

        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Balazs Kelemen <kbalazs@webkit.org>
ossy@webkit.org [Fri, 15 Oct 2010 06:31:53 +0000 (06:31 +0000)]
2010-10-14  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] WTR is sloooow
        https://bugs.webkit.org/show_bug.cgi?id=47695

        * WebKitTestRunner/qt/TestControllerQt.cpp:
        Change the timer interval of RunUntilConditionLoop from
        50 milliseconds to 1 to avoid wasting time after the
        test had been finished.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 15 Oct 2010 06:17:31 +0000 (06:17 +0000)]
2010-10-14  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline some failing tests.

        * platform/gtk/fast/events/keydown-1-expected.txt:
        * platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
        * platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
        * platform/gtk/mathml/presentation/fenced-expected.txt:
        * platform/gtk/mathml/presentation/subsup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd guideline for constructors doing implicit type conversion to coding style.
levin@chromium.org [Fri, 15 Oct 2010 05:14:35 +0000 (05:14 +0000)]
Add guideline for constructors doing implicit type conversion to coding style.
https://bugs.webkit.org/show_bug.cgi?id=47646

Reviewed by Darin Adler.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 15 Oct 2010 04:09:48 +0000 (04:09 +0000)]
2010-10-14  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang and Darin Adler.

        execCommand FormatBlock creates lots of blockquotes
        https://bugs.webkit.org/show_bug.cgi?id=19795

        The bug was caused by WebKit's not reusing the block node added by previous iteration
        and its inserting block node at wrong places.

        Fixed the bug by rewriting FormatBlockCommand::formatRange.  New code resembles that of
        IndentOutdentCommand::indentIntoBlockquote.  The difference between two is that formatRange
        avoids the existing block elements when replacing blocks and it also adds a placeholder
        when removing the existing block caused paragraphs to collapse.

        Also fixed a bug in moveParagraphWithClones where erroneous br is added to the start of
        the block element to which the paragraph is moved if the block element is the start of a paragraph
        and not the end of a paragraph.

        Tests: editing/execCommand/format-block-multiple-paragraphs.html
               editing/execCommand/format-block-table.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphWithClones): No longer adds erroneous br.
        * editing/EditorCommand.cpp:
        (WebCore::executeFormatBlock):
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::formatRange): Rewritten; see above.
        (WebCore::FormatBlockCommand::isElementToApplyInFormatBlockCommand): Renamed from validBlockElement
        and moved from htmlediting.cpp.
        (WebCore::enclosingBlockToSplitTreeTo): Added.
        * editing/FormatBlockCommand.h:
        * editing/VisiblePosition.cpp:
        (WebCore::enclosingBlockFlowElement): Changed the return type to Element*
        * editing/VisiblePosition.h:
2010-10-14  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang and Darin Adler.

        execCommand FormatBlock creates lots of blockquotes
        https://bugs.webkit.org/show_bug.cgi?id=19795

        Added tests to ensure WebKit does not add multiple block elements when applying block element to
        multiple paragraphs.  Also added a test to ensure formatBlock works with tables.

        * fast/html/nav-element-expected.txt: Preserved new lines and removed redundant br.
        * editing/execCommand/format-block-expected.txt: Preserved span and removed erroneous br.
        * editing/execCommand/format-block-from-range-selection-expected.txt: Merged dl's and removed erroneous br.
        * editing/execCommand/format-block-multiple-paragraphs-expected.txt: Added.
        * editing/execCommand/format-block-multiple-paragraphs.html: Added.
        * editing/execCommand/format-block-table-expected.txt: Added.
        * editing/execCommand/format-block-table.html: Added.
        * editing/execCommand/format-block-with-braces-expected.txt: Removed erroneous br.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 15 Oct 2010 03:08:27 +0000 (03:08 +0000)]
2010-10-14  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed, asssigned a bug number to failing filesystem tests.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Fri, 15 Oct 2010 02:54:40 +0000 (02:54 +0000)]
2010-10-14  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Tony Chang.

        [chromium] null check the widget before sending it data as calling didReceiveData might delete it
        https://bugs.webkit.org/show_bug.cgi?id=47708

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::committedLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Nathan Vander Wilt <nate@andyet.net>
commit-queue@webkit.org [Fri, 15 Oct 2010 02:45:03 +0000 (02:45 +0000)]
2010-10-14  Nathan Vander Wilt  <nate@andyet.net>

        Reviewed by Darin Adler.

        Added parser for ECMAScript 5 standard date format, so Date.parse can handle RFC 3339 timestamps: https://bugs.webkit.org/show_bug.cgi?id=44632

        * runtime/DateConversion.cpp:
        (JSC::parseDate):
        * wtf/DateMath.cpp:
        (WTF::ymdhmsToSeconds):
        (WTF::parseES5DateFromNullTerminatedCharacters):
        * wtf/DateMath.h:
2010-10-14  Nathan Vander Wilt  <nate@andyet.net>

        Reviewed by Darin Adler.

        Added tests for https://bugs.webkit.org/show_bug.cgi?id=44632

        * fast/js/date-parse-test-expected.txt:
        * fast/js/script-tests/date-parse-test.js:
        (testDateParseExact):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 15 Oct 2010 01:54:24 +0000 (01:54 +0000)]
2010-10-14  Eric Seidel  <eric@webkit.org>

        Unreviewed, just fixing an exception seen on the commit-queue.

        I should have unit tested this function before.

        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 15 Oct 2010 01:50:40 +0000 (01:50 +0000)]
2010-10-14  Justin Schuh  <jschuh@chromium.org>

        Reviewed by James Robinson.

        Crash in HTMLTextFormControlElement::selection()
        https://bugs.webkit.org/show_bug.cgi?id=47522

        Patch by Ryosuke Niwa  <rniwa@webkit.org>

        The bug was caused by our triggering layout inside RenderTextControl::selection.
        Fixed it by changing the return type of RenderTextControl::selection to PassRefPtr<Range> from VisibleSelection.

        Test: fast/forms/render-text-crash.html

        * editing/Editor.cpp:
        (WebCore::Editor::selectionForCommand): Calls HTMLTextFormControlElement::selection.
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::selection): Calls RenderTextControl::selection.
        * html/HTMLFormControlElement.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::selection): Changed the return type.
        * rendering/RenderTextControl.h:
2010-10-14  Justin Schuh  <jschuh@chromium.org>

        Reviewed by James Robinson.

        Crash in HTMLTextFormControlElement::selection()
        https://bugs.webkit.org/show_bug.cgi?id=47522

        Patch by Ryosuke Niwa  <rniwa@webkit.org>

        Added a test to ensure WebKit does not crash when moving selection between input elements.

        * fast/forms/render-text-crash-expected.txt: Added.
        * fast/forms/render-text-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 15 Oct 2010 00:51:07 +0000 (00:51 +0000)]
2010-10-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should not fail patches due to flaky tests
        https://bugs.webkit.org/show_bug.cgi?id=47647

        This patch makes it so that the *same* flaky test has to fail
        twice in a row to have a false negative from a flaky test.

        If different flaky tests fail (or if a test fails and then passes
        in a second run) then we will warn in the bug that we encountered
        a flaky test.

        This patch grew to include moving port off of steps onto tool
        (which Adam wrote and then I integrated), as well as removing the
        use of tool from CommitQueueTask.

        * Scripts/webkitpy/common/config/ports.py:
         - Added a layout_test_results_path method.  This covers old-run-webkit-tests
           but doesn't cover NRWT.  This is probably not the long term solution, but
           putting this knowledge on port makes more sense than in LayoutTestResults.
        * Scripts/webkitpy/common/net/buildbot.py:
         - LayoutTestResults shouldn't know how to fetch from the network, make
           the Build code do that instead.
        * Scripts/webkitpy/common/net/buildbot_unittest.py:
         - Code style fix.
        * Scripts/webkitpy/common/net/layouttestresults.py:
         - Remove code for reading from the network.
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
         - Test the new entrypoint.
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
         - Make the delegate interface explicit.
         - Remove the _tool member, since using the delegate for
           everything is cleaner.
         - Teach the testing logic how to deal with flaky tests.
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
         - Update to match the CommitQueueTask changes.
        * Scripts/webkitpy/tool/commands/queues.py:
         - Use the new CommitQueueTaskDelegate interface.
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
         - Fix the SecondThoughtsCommitQueue test which was broken.
         - Add a new test to make sure the flaky test reporting works.
        * Scripts/webkitpy/tool/main.py:
         - Store the port on the tool object.
        * Scripts/webkitpy/tool/mocktool.py:
         - Add a port() accessor to MockTool
        * Scripts/webkitpy/tool/steps/abstractstep.py:
         - Move port() off of Step and onto Tool.
        * Scripts/webkitpy/tool/steps/build.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:
        * Scripts/webkitpy/tool/steps/runtests.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
         - Two tests with the same name!  only the latter was being run.
        * Scripts/webkitpy/tool/steps/update.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 15 Oct 2010 00:47:23 +0000 (00:47 +0000)]
2010-10-14  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        SelectElement should check if its renderer exists after calling Element::focus()
        https://bugs.webkit.org/show_bug.cgi?id=47696

        Tests that clicking on a listbox select with an element has a blur listener that causes
        the listbox to become display:none does not crash.

        * fast/forms/select-listbox-focus-displaynone.html: Added.
2010-10-14  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        SelectElement should check if its renderer exists after calling Element::focus()
        https://bugs.webkit.org/show_bug.cgi?id=47696

        Adds null checks for element->renderer() after calling element->focus(), since focus()
        can dispatch an event and run arbitrary javascript that may cause the select element
        to lose its renderer.

        Test: fast/forms/select-listbox-focus-displaynone.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):
        (WebCore::SelectElement::listBoxDefaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 15 Oct 2010 00:35:45 +0000 (00:35 +0000)]
2010-10-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Plumb accelerated compositing prefs through WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=46860
        <rdar://problem/8495312>

        Wire up the prefs to enable accelerated compositing, and
        show debug borders and repaint counters.

        * Shared/WebPreferencesStore.cpp:
        (WebKit::WebPreferencesStore::WebPreferencesStore):
        (WebKit::WebPreferencesStore::encode):
        (WebKit::WebPreferencesStore::decode):
        * Shared/WebPreferencesStore.h:
        * UIProcess/API/C/WKPreferencesPrivate.cpp:
        (WKPreferencesSetAcceleratedCompositingEnabled):
        (WKPreferencesGetAcceleratedCompositingEnabled):
        (WKPreferencesSetCompositingBordersVisible):
        (WKPreferencesGetCompositingBordersVisible):
        (WKPreferencesSetCompositingRepaintCountersVisible):
        (WKPreferencesGetCompositingRepaintCountersVisible):
        * UIProcess/API/C/WKPreferencesPrivate.h:
        * UIProcess/WebPreferences.cpp:
        (WebKit::WebPreferences::setAcceleratedCompositingEnabled):
        (WebKit::WebPreferences::acceleratedCompositingEnabled):
        (WebKit::WebPreferences::setCompositingBordersVisible):
        (WebKit::WebPreferences::compositingBordersVisible):
        (WebKit::WebPreferences::setCompositingRepaintCountersVisible):
        (WebKit::WebPreferences::compositingRepaintCountersVisible):
        * UIProcess/WebPreferences.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        (WebKit::WebPage::preferencesDidChange):
        (WebKit::WebPage::updatePreferences):
        * WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-27 Dawit Alemayehu <adawit@kde.org>
commit-queue@webkit.org [Fri, 15 Oct 2010 00:27:26 +0000 (00:27 +0000)]
2010-09-27 Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Andreas Kling.

        [Qt] Added functions for obtaining and checking the supported content types.
        http://webkit.org/b/37880

        * Api/qwebpage.cpp:
        (extractContentTypeFromHash):
        (extractContentTypeFromPluginVector):
        (QWebPage::supportedContentTypes):
        (QWebPage::supportsContentType):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::supportedContentType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Steve Block <steveblock@google.com>
steveblock@google.com [Fri, 15 Oct 2010 00:24:01 +0000 (00:24 +0000)]
2010-10-14  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Document behaviour of href when document base URI is changed after href atribute has been set
        https://bugs.webkit.org/show_bug.cgi?id=47665

        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-prevents-rebase.js: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase-expected.txt: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThis patch lays the groundwork for
bdakin@apple.com [Thu, 14 Oct 2010 23:35:36 +0000 (23:35 +0000)]
This patch lays the groundwork for
https://bugs.webkit.org/show_bug.cgi?id=47514 CSS transforms should
affect scrolling
by adding topmostPosition().

Reviewed by Dave Hyatt.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::topmostPosition):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::topmostPosition):
* rendering/RenderBox.h:
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::topmostPosition):
* rendering/RenderMedia.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::topmostPosition):
* rendering/RenderTableSection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Thu, 14 Oct 2010 23:24:46 +0000 (23:24 +0000)]
2010-10-14  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] fix compilation warnings in imported libsoup code
        https://bugs.webkit.org/show_bug.cgi?id=47674

        Fixed some warnings caused by comparisons between signed and
        unsigned integer expressions

        * platform/network/soup/cache/soup-directory-input-stream.c:
        (webkit_soup_directory_input_stream_read):
        * platform/network/soup/cache/soup-request-data.c:
        (webkit_soup_request_data_send):
        * platform/network/soup/cache/soup-request-file.c:
        (webkit_soup_request_file_ensure_file):
        * platform/network/soup/cache/webkit/soup-cache.c:
        (webkit_soup_cache_entry_is_fresh_enough):
        (webkit_soup_cache_has_response):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 14 Oct 2010 23:22:53 +0000 (23:22 +0000)]
2010-10-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests will now handle missing Ruby installs (or
        missing PrettyPatch scripts) more cleanly - previously this
        would be detected when we actually tried to create the diff, and
        the error message was obscure. Now we'll log a warning up front
        and otherwise be silent.

        This change also refactors some global variables to be class or
        instance variables to be slightly more testable and more
        modular. There are no cases where we create lots of port objects
        and can't afford to test for configurations repeatedly, so
        there's no performance concern here.

        https://bugs.webkit.org/show_bug.cgi?id=47466

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 14 Oct 2010 23:20:03 +0000 (23:20 +0000)]
2010-10-14  Andreas Kling  <kling@webkit.org>

        Unreviewed buildfix, RetainPtr is a mac thing..

        * platform/network/soup/ProxyServerSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 14 Oct 2010 23:18:09 +0000 (23:18 +0000)]
2010-10-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Form controls do not respect GTK+ font size
        https://bugs.webkit.org/show_bug.cgi?id=47134

        Rebaseline tests which depend on form control font size.

        * platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
        * platform/gtk/editing/selection/drag-select-1-expected.txt:
        * platform/gtk/editing/selection/drag-text-delay-expected.txt:
        * platform/gtk/editing/selection/select-box-expected.txt:
        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/gtk/fast/events/keydown-1-expected.txt:
        * platform/gtk/fast/forms/box-shadow-override-expected.txt:
        * platform/gtk/fast/forms/button-style-color-expected.txt:
        * platform/gtk/fast/forms/input-button-sizes-expected.txt:
        * platform/gtk/fast/forms/input-text-drag-down-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
        * platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
        * platform/gtk/transforms/2d/zoom-menulist-expected.txt:
2010-10-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Form controls do not respect GTK+ font size
        https://bugs.webkit.org/show_bug.cgi?id=47134

        Have form controls use the font specified in GtkSettings. This font is
        the default control font in GTK+ applications and Firefox. We need to
        pass the string through Pango to get a valid font name and size.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::getScreenDPI): A helper function which returns
        the DPI of the default screen or 96 as a fallback.
        (WebCore::RenderThemeGtk::systemFont): Calculate the system font
        by looking at the GtkSettings value and pushing it through Pango
        to get the font family and font size.
2010-10-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Form controls do not respect GTK+ font size
        https://bugs.webkit.org/show_bug.cgi?id=47134

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (initializeGtkFontSettings): Initialize the font control size when running
        DumpRenderTree to a standard value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 14 Oct 2010 23:12:21 +0000 (23:12 +0000)]
2010-10-14  Andreas Kling  <kling@webkit.org>

        Soup buildfix for r69808: add ProxyServer stub.

        * GNUmakefile.am:
        * platform/network/soup/ProxyServerSoup.cpp: Added.
        (WebCore::proxyServersForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 14 Oct 2010 23:04:26 +0000 (23:04 +0000)]
2010-10-14  Andreas Kling  <kling@webkit.org>

        Fix GTK+ build after r69808.

        * GNUmakefile.am:
        * platform/network/curl/ProxyServerCurl.cpp:
        (WebCore::proxyServersForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Oct 2010 23:02:39 +0000 (23:02 +0000)]
2010-10-14  Simon Fraser  <simon.fraser@apple.com>

        Another build fix. Export FrameLoader::networkingContext()

        * WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Oct 2010 22:56:16 +0000 (22:56 +0000)]
2010-10-14  Simon Fraser  <simon.fraser@apple.com>

        Fix the build after r69808.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/cf/ProxyServerCFNet.cpp:
        (WebCore::proxyServersForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix following r69806.
barraclough@apple.com [Thu, 14 Oct 2010 22:46:47 +0000 (22:46 +0000)]
Windows build fix following r69806.

* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::markupToCFHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 14 Oct 2010 22:32:49 +0000 (22:32 +0000)]
2010-10-14  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] compile TestNetscapePlugIn on Chromium mac
        https://bugs.webkit.org/show_bug.cgi?id=47633

        * WebKit.gyp:  Add a mac specific target for compiling TestNetscapePlugIn
2010-10-14  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] compile TestNetscapePlugIn on Chromium mac
        https://bugs.webkit.org/show_bug.cgi?id=47633

        * DumpRenderTree/DumpRenderTree.gypi: files to compile
        * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
        (NP_GetEntryPoints):
        (NPP_New):
        (NPP_Destroy):
        (NPP_HandleEvent):
        (NPP_GetValue):
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
        * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Dawit Alemayehu <adawit@kde.org>
commit-queue@webkit.org [Thu, 14 Oct 2010 22:16:34 +0000 (22:16 +0000)]
2010-10-14  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Andreas Kling

        Implemented NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo.
        https://bugs.webkit.org/show_bug.cgi?id=34539

        These missing NPN functions cause Java applets to crash in ports such
        as QtWebkit that rely on webkit for Java applet support.

        * plugins/PluginDebug.cpp:
        (WebCore::prettyNameForNPNURLVariable):
        * plugins/PluginDebug.h:
        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::initializeBrowserFuncs):
        * plugins/PluginView.cpp:
        (WebCore::PluginView::getValueForURL):
        (WebCore::PluginView::setValueForURL):
        (WebCore::PluginView::getAuthenticationInfo):
        * plugins/PluginView.h:
        * plugins/npapi.cpp:
        (NPN_GetValueForURL):
        (NPN_SetValueForURL):
        (NPN_GetAuthenticationInfo):
        * platform/network/ProxyServer.h:
        * platform/network/cf/ProxyServerCFNet.cpp:
        (WebCore::proxyServersForURL):
        * platform/network/qt/ProxyServerQt.cpp:
        (WebCore::proxyServersForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix following r69806.
barraclough@apple.com [Thu, 14 Oct 2010 21:56:25 +0000 (21:56 +0000)]
Windows build fix following r69806.

* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::markupToCFHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Thu, 14 Oct 2010 21:45:01 +0000 (21:45 +0000)]
2010-10-14  Victor Wang  <victorw@chromium.org>

        Reviewed by Nate Chapin.

        [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.

        https://bugs.webkit.org/show_bug.cgi?id=47686

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 14 Oct 2010 21:18:03 +0000 (21:18 +0000)]
2010-10-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        test-webkitpy spews Delegate terminated queue messages
        https://bugs.webkit.org/show_bug.cgi?id=47678

        * Scripts/webkitpy/tool/bot/queueengine_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 14 Oct 2010 21:11:52 +0000 (21:11 +0000)]
2010-10-14  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Cache link status at linkProgram and use it in useProgram instead of querying GPU
        https://bugs.webkit.org/show_bug.cgi?id=47685

        * html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query.
        (WebCore::WebGLProgram::WebGLProgram):
        * html/canvas/WebGLProgram.h: Ditto.
        (WebCore::WebGLProgram::getLinkStatus):
        (WebCore::WebGLProgram::setLinkStatus):
        * html/canvas/WebGLRenderingContext.cpp: Ditto.
        (WebCore::WebGLRenderingContext::getProgramParameter):
        (WebCore::WebGLRenderingContext::linkProgram):
        (WebCore::WebGLRenderingContext::useProgram):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 14 Oct 2010 21:05:38 +0000 (21:05 +0000)]
2010-10-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r69795.
        http://trac.webkit.org/changeset/69795
        https://bugs.webkit.org/show_bug.cgi?id=47687

        'See discussion at webkit.org/b/47609' (Requested by mwenge on
        #webkit).

        * platform/qt/Skipped:
2010-10-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r69795.
        http://trac.webkit.org/changeset/69795
        https://bugs.webkit.org/show_bug.cgi?id=47687

        'See discussion at webkit.org/b/47609' (Requested by mwenge on
        #webkit).

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::canHandleRequest):
        (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Sam Weinig.
adachan@apple.com [Thu, 14 Oct 2010 21:03:49 +0000 (21:03 +0000)]
    Reviewed by Sam Weinig.

        WebKit2: Store the certificate chain in PlatformCertificateInfo.
        https://bugs.webkit.org/show_bug.cgi?id=47603

        * Shared/API/c/win/WKCertificateInfoWin.cpp:
        (WKCertificateInfoGetCertificateChainLength):
        (WKCertificateInfoGetCertificateContextAtIndex):
        * Shared/API/c/win/WKCertificateInfoWin.h:
        * Shared/win/PlatformCertificateInfo.cpp:
        (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Get the chain context from the response and duplicate the certificate contexts
        in the chain to store in m_certificateChain.
        (WebKit::PlatformCertificateInfo::~PlatformCertificateInfo): Free all the certificate contexts in the chain.
        (WebKit::PlatformCertificateInfo::operator=): Duplicate the certificate contexts from the other PlatformCertificateInfo's certificate chain
        to store in m_certificateChain.
        (WebKit::PlatformCertificateInfo::encode):
        (WebKit::PlatformCertificateInfo::decode):
        (WebKit::PlatformCertificateInfo::clearCertificateChain): Free all the certificate contexts in the chain and clear the vector.
        * Shared/win/PlatformCertificateInfo.h:
        (WebKit::PlatformCertificateInfo::certificateChain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 14 Oct 2010 20:48:18 +0000 (20:48 +0000)]
2010-10-14  Justin Schuh  <jschuh@chromium.org>

        Reviewed by James Robinson.

        Style fix for r69735
        https://bugs.webkit.org/show_bug.cgi?id=47684

        No logic change. Existing tests apply.

        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::alignBoxesInBlockDirection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 14 Oct 2010 19:52:41 +0000 (19:52 +0000)]
2010-10-14  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: encapsulate ScriptState into ConsoleMessage instead of passing it as additional parameter
        https://bugs.webkit.org/show_bug.cgi?id=47675

        No new tests. This refactoring is covered by existing inspector tests.

        * bindings/js/JSConsoleCustom.cpp:
        * bindings/js/ScriptCallFrame.cpp:
        * bindings/js/ScriptCallFrame.h:
        (WebCore::ScriptCallFrame::functionName):
        (WebCore::ScriptCallFrame::sourceURL):
        (WebCore::ScriptCallFrame::lineNumber):
        (WebCore::ScriptCallFrame::argumentCount):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::addConsoleMessage):
        (WebCore::InspectorController::startGroup):
        (WebCore::InspectorController::endGroup):
        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 14 Oct 2010 19:48:45 +0000 (19:48 +0000)]
2010-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Gavin Barraclough.

        Replace lots of String::format() usages by StringConcatenate
        https://bugs.webkit.org/show_bug.cgi?id=47664

        Add StringTypeAdapter<char> to accept single characters for makeString().

        * wtf/text/StringConcatenate.h:
        (WTF::makeString):
2010-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Gavin Barraclough.

        Replace lots of String::format() usages by StringConcatenate
        https://bugs.webkit.org/show_bug.cgi?id=47664

        * ForwardingHeaders/wtf/text/StringConcatenate.h: Added.
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::reportUnsafeAccessTo):
        * dom/ExceptionBase.cpp:
        (WebCore::ExceptionBase::ExceptionBase):
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::handleError):
        * history/PageCache.cpp:
        (WebCore::logCanCacheFrameDecision):
        * html/FTPDirectoryDocument.cpp:
        (WebCore::processFileDateString):
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::count):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::createBreakpointId):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::formatBreakpointId):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
        (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
        (WebCore::InspectorProfilerAgent::getCurrentUserInitiatedProfileName):
        (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
        * loader/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::printAccessDeniedMessage):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkIfDisplayInsecureContent):
        (WebCore::FrameLoader::checkIfRunInsecureContent):
        (WebCore::FrameLoader::shouldAllowNavigation):
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::createFromSelection):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageProperty):
        (WebCore::PrintContext::pageSizeAndMarginsInPixels):
        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadObject):
        * platform/efl/PlatformKeyboardEventEfl.cpp:
        (WebCore::createKeyMap):
        (WebCore::createWindowsKeyMap):
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::animationNameForTransition):
        * platform/graphics/brew/ImageBrew.cpp:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/efl/ImageEfl.cpp:
        (WebCore::loadResourceSharedBuffer):
        * platform/graphics/gtk/ImageBufferGtk.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/haiku/ImageBufferHaiku.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::animationIdentifier):
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/win/WebLayer.cpp:
        (WebCore::WebLayer::drawInContext):
        * platform/network/CredentialStorage.cpp:
        (WebCore::originStringFromURL):
        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::setSynchronous):
        * platform/text/wince/TextCodecWinCE.cpp:
        (WebCore::LanguageManager::LanguageManager):
        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::markupToCFHTML):
        * platform/win/Language.cpp:
        (WebCore::defaultLanguage):
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream):
        * svg/SVGUseElement.cpp:
        (WebCore::dumpInstanceTree):
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::connect):
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::appendToBuffer):
        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readServerHandshake):
2010-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Gavin Barraclough.

        Replace lots of String::format() usages by StringConcatenate
        https://bugs.webkit.org/show_bug.cgi?id=47664

        Rebaseline two xssAuditor tests, that have been changed, after switching from String::format() -> makeString().

        * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Rubber-stamped by Adam Roben.
adachan@apple.com [Thu, 14 Oct 2010 19:47:32 +0000 (19:47 +0000)]
    Rubber-stamped by Adam Roben.

        Fix Windows build.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Joone Hur <joone@kldp.org>
commit-queue@webkit.org [Thu, 14 Oct 2010 19:40:54 +0000 (19:40 +0000)]
2010-10-14  Joone Hur  <joone@kldp.org>

        Reviewed by Andreas Kling.

        [GTK] google.co.kr was missed when checking Google domains
        https://bugs.webkit.org/show_bug.cgi?id=47652

        WebKitGtk+ maintains a list of Google domains for working well with Google sites.
        Add google.co.kr also to the list to be checked with other Google domains.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::initializeDomainsList): Added google.co.kr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 14 Oct 2010 19:38:24 +0000 (19:38 +0000)]
2010-10-14  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Fix http/tests/misc/redirect-to-external-url.html

        Support the test in FrameLoaderClientQt and unskip.

        https://bugs.webkit.org/show_bug.cgi?id=47609

        * platform/qt/Skipped:
2010-10-14  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Fix http/tests/misc/redirect-to-external-url.html

        Support the test in FrameLoaderClientQt and unskip.

        https://bugs.webkit.org/show_bug.cgi?id=47609

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::canHandleRequest):
        (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Xan Lopez <xlopez@igalia.com>
commit-queue@webkit.org [Thu, 14 Oct 2010 19:29:25 +0000 (19:29 +0000)]
2010-10-14  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Small cleanup in PluginViewGtk
        https://bugs.webkit.org/show_bug.cgi?id=47588

        Remove some dead code and use PlatformRefPtr for cairo surfaces.

        No new tests, only refactoring.

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Thu, 14 Oct 2010 19:23:10 +0000 (19:23 +0000)]
2010-10-14  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Eric Seidel.

        [EFL] Use data_set after data_get to keep refcount correct.
        https://bugs.webkit.org/show_bug.cgi?id=47110

        The call to evas_object_image_data_set was missed in this function,
        which caused the refcount of the data being always increased on every
        scroll.

        * ewk/ewk_view_single.c:
        (_ewk_view_single_smart_scrolls_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Dawit Alemayehu <adawit@kde.org>
commit-queue@webkit.org [Thu, 14 Oct 2010 19:22:38 +0000 (19:22 +0000)]
2010-10-14  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Andreas Kling.

        Fix compile error when bulding webkit's Qt port using the "--v8" option.
        https://bugs.webkit.org/show_bug.cgi?id=47455

        * platform/qt/PlatformBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake sure WebKit2 only loads each plugin once
aroben@apple.com [Thu, 14 Oct 2010 19:22:27 +0000 (19:22 +0000)]
Make sure WebKit2 only loads each plugin once

Fixes <http://webkit.org/b/47677> <rdar://problem/8552178> WebKit2 can
load the same plugin multiple times

Reviewed by Sam Weinig.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::addFromVector): Helper function that adds all the elements
from a Vector to a HashSet.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Put all the plugin
paths into a HashSet, then load the plugins specified in the HashSet.
On Windows, the HashSet is case-insensitive, just like the file
system.

* UIProcess/Plugins/PluginInfoStore.h: Removed loadPluginsInDirectory,
which is no longer used.

* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Changed to store the paths in a Vector instead of a HashSet now that
loadPluginsIfNecessary will handle duplicates for us.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLoad plugins that are specified in the MozillaPlugins registry key
aroben@apple.com [Thu, 14 Oct 2010 19:22:08 +0000 (19:22 +0000)]
Load plugins that are specified in the MozillaPlugins registry key

Fixes <http://webkit.org/b/44271> <rdar://problem/8329750> WebKit2
should load plugins specified in the MozillaPlugins registry key (like
old WebKit does)

I couldn't think of a good way to test this.

Reviewed by Steve Falkenburg.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Also load plugins
specified by individualPluginPaths.

* UIProcess/Plugins/PluginInfoStore.h: Added individualPluginPaths and
some comments.

* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::individualPluginPaths):
* UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:
(WebKit::PluginInfoStore::individualPluginPaths):
Stubbed out.

* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Ported this code from WebCore's PluginDatabaseWin.cpp. I slightly
cleaned it up and changed it to use a case-insensitive hash, since
paths on Windows are case-insensitive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCall ::DefWindowProcW for unhandled key events
aroben@apple.com [Thu, 14 Oct 2010 19:21:32 +0000 (19:21 +0000)]
Call ::DefWindowProcW for unhandled key events

::DefWindowProcW does important things for at least some key events
(e.g., it generates a WM_SYSCOMMAND message when the Alt key is
released), so we need to make sure to call it when we don't handle key
events.

Fixes <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
the Alt key when MiniBrowser's WKView is focused doesn't send focus to
the menu bar

Reviewed by Steve Falkenburg.

WebKit2:

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didNotHandleKeyEvent):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::didNotHandleKeyEvent):
* UIProcess/API/qt/qwkpage_p.h:
Stubbed out didNotHandleKeyEvent.

* UIProcess/PageClient.h: Added didNotHandleKeyEvent.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Tell the PageClient about the
unhandled event.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::onKeyEvent): Added a comment.
(WebKit::WebView::didNotHandleKeyEvent): Pass the event to
::DefWindowProcW.

* UIProcess/win/WebView.h: Added didNotHandleKeyEvent.

WebKitTools:

Test that pressing the Alt key generates a WM_SYSCOMMAND message

* TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
TestWebKitAPI/win to the include path so that WindowMessageObserver
can be found.

* TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
Windows-specific members.
(TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
Added this simple setter.

* TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
(TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
Initialize our lone data member.
(TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
Simple getter.
(TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
when a WM_SYSCOMMAND message is received.
(TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
WM_SYSKEYUP message is not handled.
(TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
pressing the Alt key and check that a WM_SYSCOMMAND message got sent
to the WKView's parent window.

* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
member function so it could access PlatformWebView::wndProc. Use
PlatformWebView::wndProc as the WNDPROC.
(TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
data member and pass the this pointer to CreateWindowEx so we can
store it on the HWND.
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
constants from here to the top of the file.
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
the same messages that Notepad receives when you press the Alt key.
(TestWebKitAPI::PlatformWebView::wndProc): Added.
  - When WM_CREATE is received, we set the PlatformWebView instance
    pointer as a property on the HWND so we can access it later.
  - For other messages, we try to get the PlatformWebView instance
    pointer from the HWND property.
  - When WM_NCDESTROY is received (which is the last message we will
    receive), we remove the PlatformWebView instance property.
  - Pass messages to the parent window's message observer, if there is
    one.
  - Pass all messages through to ::DefWindowProcW.

* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
and AltKeyGeneratesWMSysCommand.

* TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
used to observe messages sent to one or more windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoneed way to measure size of JITed ARM code
ggaren@apple.com [Thu, 14 Oct 2010 19:19:17 +0000 (19:19 +0000)]
need way to measure size of JITed ARM code
https://bugs.webkit.org/show_bug.cgi?id=47121

Patch by David Goodwin <david_goodwin@apple.com> on 2010-10-14
Reviewed by Darin Adler.

* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::dumpLinkStats):
(JSC::LinkBuffer::dumpCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 14 Oct 2010 18:52:52 +0000 (18:52 +0000)]
2010-10-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Holger Freyther.

        [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
        https://bugs.webkit.org/show_bug.cgi?id=47033

        Added a platform-specific test which verifies that if XSettings
        specifies subpixel aliasing, it is the default rendering style.

        * platform/gtk/fonts/xsettings_antialias_settings-expected.checksum: Added.
        * platform/gtk/fonts/xsettings_antialias_settings-expected.png: Added.
        * platform/gtk/fonts/xsettings_antialias_settings-expected.txt: Added.
        * platform/gtk/fonts/xsettings_antialias_settings.html: Added.
2010-10-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Holger Freyther.

        [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
        https://bugs.webkit.org/show_bug.cgi?id=47033

        Fix logic that merges XSettings defaults and FontConfig settings. If
        FontConfig or XSettings specifies a subpixel order, we force subpixel
        anti-aliasing on. If anti-aliasing is turned on explicitly, only
        override the setting if it was previously off, otherwise we ignore
        the user's preference for subpixel or gray antialiasing.

        Test: platform/gtk/fonts/xsettings_antialias_settings.html

        * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
        (WebCore::setCairoFontOptionsFromFontConfigPattern): Fix merging of XSettings
        and FontConfig anti-aliasing settings.
        (WebCore::getDefaultFontOptions): Added this helper.
        (WebCore::FontPlatformData::FontPlatformData): Use the getDefaultFontOptions helper.
2010-10-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Holger Freyther.

        [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
        https://bugs.webkit.org/show_bug.cgi?id=47033

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (initializeGtkFontSettings): Added this method which initializes XSettings
        font settings to consistent values before running a test. For the one test
        in which we need subpixel aliasing turned on, do that.
        (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
        (runTest): Pass the testURL to initializeFonts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 14 Oct 2010 18:50:55 +0000 (18:50 +0000)]
2010-10-14  Nate Chapin  <japhet@chromium.org>

        Unreviewed, test tweaks.

        Add Chromium win/linux results for http://trac.webkit.org/changeset/69774.

        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Steve Falkenburg.
adachan@apple.com [Thu, 14 Oct 2010 18:45:16 +0000 (18:45 +0000)]
    Reviewed by Steve Falkenburg.

        Add wkGetSSLCertificateChainContext for fetching the certificate chain.
        Needed for https://bugs.webkit.org/show_bug.cgi?id=47603.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Thu, 14 Oct 2010 18:36:47 +0000 (18:36 +0000)]
2010-10-14  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Eric Seidel.

        [EFL] Add setting api for enabling encoding detector
        https://bugs.webkit.org/show_bug.cgi?id=45427

        Add settings api for enabling encoding detector.

        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):
        (ewk_view_setting_encoding_detector_set):
        (ewk_view_setting_encoding_detector_get):
        * ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport typed arrays in workers
jianli@chromium.org [Thu, 14 Oct 2010 18:30:00 +0000 (18:30 +0000)]
Support typed arrays in workers
https://bugs.webkit.org/show_bug.cgi?id=47616

Reviewed by David Levin.

To support typed arrays in workers, we need to expose constructors in
WorkerContext and add NoStaticTables attribute.

I also add File API feature guard to the constructors defined in
DOMWindow.

* bindings/js/JSDOMWindowCustom.cpp: Add File API feature guard to the
constructors defined in DOMWindow.
* html/canvas/ArrayBuffer.idl: Add NoStaticTables attribute.
* html/canvas/ArrayBufferView.idl: Add NoStaticTables attribute.
* html/canvas/Float32Array.idl: Add NoStaticTables attribute.
* html/canvas/Int16Array.idl: Add NoStaticTables attribute.
* html/canvas/Int32Array.idl: Add NoStaticTables attribute.
* html/canvas/Int8Array.idl: Add NoStaticTables attribute.
* html/canvas/Uint16Array.idl: Add NoStaticTables attribute.
* html/canvas/Uint32Array.idl: Add NoStaticTables attribute.
* html/canvas/Uint8Array.idl: Add NoStaticTables attribute.
* page/DOMWindow.idl: Add File API feature guard to the constructors
defined in DOMWindow.
* workers/WorkerContext.idl: Expose type array constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Peter Varga <pvarga@inf.u-szeged.hu>
commit-queue@webkit.org [Thu, 14 Oct 2010 18:00:55 +0000 (18:00 +0000)]
2010-10-14  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        The backreference checking isn't working in some cases with YARR Interpreter
        https://bugs.webkit.org/show_bug.cgi?id=46904

        The Interpreter::matchBackReference() function returns true without matching
        when a backreference points to the same parentheses where it is.

        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::matchBackReference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd baselines and pixel results for some new tests.
mrobinson@webkit.org [Thu, 14 Oct 2010 17:47:28 +0000 (17:47 +0000)]
Add baselines and pixel results for some new tests.

* platform/gtk/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/gtk/fast/forms/textfield-focus-ring-expected.png: Added.
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt: Added.
* platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Added.
* platform/gtk/fast/images/imagemap-focus-ring-expected.png: Added.
* platform/gtk/fast/images/imagemap-focus-ring-expected.txt: Added.
* platform/gtk/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/gtk/fast/inline/inline-focus-ring-expected.png: Added.
* platform/gtk/fast/inline/inline-focus-ring-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 14 Oct 2010 17:45:51 +0000 (17:45 +0000)]
2010-10-14  Andreas Kling  <kling@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] Avoid creating empty transparency layers in ImageBuffer::clip()

        We were creating empty layers for sub-1 height/width clips due to
        using IntRect(FloatRect) instead of enclosingIntRect().
        This lead to a bunch of QPainter warnings on the console since you
        can't draw on an empty QPixmap.

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::clip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 14 Oct 2010 17:31:47 +0000 (17:31 +0000)]
2010-10-14  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium test fix.

        Expected results for tests added in http://trac.webkit.org/changeset/69766.

        * platform/chromium-linux/fast/forms/textfield-focus-ring-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png: Added.
        * platform/chromium-linux/fast/images/imagemap-focus-ring-expected.checksum: Added.
        * platform/chromium-linux/fast/images/imagemap-focus-ring-expected.png: Added.
        * platform/chromium-linux/fast/inline/inline-focus-ring-expected.checksum: Added.
        * platform/chromium-linux/fast/inline/inline-focus-ring-expected.png: Added.
        * platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
        * platform/chromium-mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
        * platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Added.
        * platform/chromium-win/fast/forms/textfield-focus-ring-expected.checksum: Added.
        * platform/chromium-win/fast/forms/textfield-focus-ring-expected.png: Added.
        * platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt: Added.
        * platform/chromium-win/fast/images/imagemap-focus-ring-expected.checksum: Added.
        * platform/chromium-win/fast/images/imagemap-focus-ring-expected.png: Added.
        * platform/chromium-win/fast/images/imagemap-focus-ring-expected.txt: Added.
        * platform/chromium-win/fast/inline/inline-focus-ring-expected.checksum: Added.
        * platform/chromium-win/fast/inline/inline-focus-ring-expected.png: Added.
        * platform/chromium-win/fast/inline/inline-focus-ring-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Thu, 14 Oct 2010 17:31:13 +0000 (17:31 +0000)]
2010-10-14  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Texmap] [Qt] Texture mapper initial implementation
        https://bugs.webkit.org/show_bug.cgi?id=47070

        Allow rendering of accelerated-compositing with TextureMapper, inside a QWebFrame. The frame will render the regular content,
        either normally or through tiled backingstore, then let the TextureMapper layer render itself to the active context, and
        then render the scrollbar and pan icon. This is different from the current implementation, which uses additional QGraphicsItems for AC
        and the scrollbar overlay.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebView::paint):
        * Api/qwebframe.cpp:
        (QWebFramePrivate::renderFromTiledBackingStore):
        (QWebFramePrivate::renderRelativeCoords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[cairo] Typo in determining fixed width fonts
zecke@webkit.org [Thu, 14 Oct 2010 17:23:55 +0000 (17:23 +0000)]
[cairo] Typo in determining fixed width fonts
https://bugs.webkit.org/show_bug.cgi?id=47470

It must be a single ampersand otherwise the
&& FT_FACE_FLAG_FIXED_WIDTH will always be true.

* platform/graphics/cairo/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Thu, 14 Oct 2010 17:13:59 +0000 (17:13 +0000)]
2010-10-14  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Failing test LayoutTests/editing/undo/orphaned-selection-crash-bug32823-2.html
        https://bugs.webkit.org/show_bug.cgi?id=47666

        Do a less strict decoding of base64 data url's as it was done
        before. The actual problem is most likely
        https://bugs.webkit.org/show_bug.cgi?id=47661 tough.

        * platform/network/soup/cache/soup-request-data.c:
        (webkit_soup_request_data_send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Renata Hodovan <reni@inf.u-szeged.hu>
commit-queue@webkit.org [Thu, 14 Oct 2010 17:12:38 +0000 (17:12 +0000)]
2010-10-14  Renata Hodovan  <reni@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
        https://bugs.webkit.org/show_bug.cgi?id=47660

        Adding layout tests for feConvolveMatrix dynamic DOM changes. SVGDOM tests cases will be in the following patch because of patch-size limitation (2M in bugzilla).

        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html: Added.
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-edgeMode-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js: Added.
        (executeTest):
2010-10-14  Renata Hodovan  <reni@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
        https://bugs.webkit.org/show_bug.cgi?id=47660

        The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.
        The patch also implements the simple setOrder and setKernelUnitLength methods.

        Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html
               svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html

        * svg/SVGFEConvolveMatrixElement.cpp:
        (WebCore::SVGFEConvolveMatrixElement::setOrder):
        (WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength):
        (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
        * svg/SVGFEConvolveMatrixElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Thu, 14 Oct 2010 16:57:00 +0000 (16:57 +0000)]
2010-10-14  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Text breaking is slow: enable ICU as an opt-in
        https://bugs.webkit.org/show_bug.cgi?id=40332

        Added a config flag that enables ICU as an opt-in instead of the Qt specific code.
        Because of the inclusion of ICU headers, some explicit casting was necessary in UnicodeQt4.h

        * JavaScriptCore.pri:
        * wtf/unicode/qt4/UnicodeQt4.h:
        (WTF::Unicode::toLower):
        (WTF::Unicode::toUpper):
        (WTF::Unicode::toTitleCase):
        (WTF::Unicode::foldCase):
        (WTF::Unicode::isPrintableChar):
        (WTF::Unicode::isSeparatorSpace):
        (WTF::Unicode::isPunct):
        (WTF::Unicode::isLower):
        (WTF::Unicode::mirroredChar):
        (WTF::Unicode::combiningClass):
        (WTF::Unicode::direction):
        (WTF::Unicode::category):
2010-10-14  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Text breaking is slow: enable ICU as an opt-in
        https://bugs.webkit.org/show_bug.cgi?id=40332

        Added a config flag that enables ICU as an opt-in instead of the Qt specific code.

        No new tests, this should be covered by existing tests.

        * WebCore.pro:
        * platform/text/qt/TextBreakIteratorQt.cpp:
        (WebCore::currentTextBreakLocaleID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Thu, 14 Oct 2010 16:52:57 +0000 (16:52 +0000)]
2010-10-14  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Texmap] [Qt] Texture mapper initial implementation
        https://bugs.webkit.org/show_bug.cgi?id=47070

        This patch enables compilation of TextureMapper with Media. It has an initial non-working implementation of a video layer, to be integrated
        once other parts of TextureMapper are fully working.

        No new tests: this is new implementation that's not enabled yet.

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::TextureMapperVideoLayerQt::TextureMapperVideoLayerQt):
        (WebCore::TextureMapperVideoLayerQt::setPlatformLayerClient):
        (WebCore::TextureMapperVideoLayerQt::paint):
        (WebCore::TextureMapperVideoLayerQt::size):
        (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged):
        (WebCore::MediaPlayerPrivateQt::platformLayer):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering):
        (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged):
        (WebCore::MediaPlayerPrivateQt::platformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 14 Oct 2010 16:40:59 +0000 (16:40 +0000)]
2010-10-14  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 14 Oct 2010 16:40:08 +0000 (16:40 +0000)]
2010-10-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
        https://bugs.webkit.org/show_bug.cgi?id=47655

        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/common/config/ports_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 14 Oct 2010 16:18:31 +0000 (16:18 +0000)]
2010-10-14  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update expectations for some inspector tests.

        * inspector/debugger-pause-in-eval-script-expected.txt:
        * inspector/extensions-events-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 14 Oct 2010 16:13:06 +0000 (16:13 +0000)]
2010-10-14  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Fixed crashes in the GTK 64bits bot, we have to use NULL instead
        of 0 when calling these glib APIs, 0 is compiled as a char and in
        64bits systems it is not correct.

        * platform/network/soup/cache/soup-requester.c:
        (webkit_soup_requester_new):
        (webkit_soup_requester_request_uri):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-14 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 14 Oct 2010 16:00:52 +0000 (16:00 +0000)]
2010-10-14  Daniel Bates  <dbates@rim.com>

        Attempt to fix the Qt and GTK builds based on the build bot results from <http://webkit.sed.hu>.

        * rendering/RenderInline.cpp: Include header "RenderTheme.h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69767 268f45cc-cd09-0410-ab3c-d52691b4dbfc