WebKit-https.git
8 years agorun-webkit-tests should have ability to add description to its JSON output
rniwa@webkit.org [Mon, 6 Aug 2012 21:59:06 +0000 (21:59 +0000)]
run-webkit-tests should have ability to add description to its JSON output
https://bugs.webkit.org/show_bug.cgi?id=93296

Reviewed by Dirk Pranke.

PerformanceTests:

Parse description and show it with the WebKit revision on the results page. Also use bar graphs
instead of line graphs since we're not depicting the time series here per arv's suggestion.
Finally, add the ability to adjust y-axis between the adjusted value and 0 (plot even doesn't adjust
y-axis automatically now) by a mouse click.

* resources/results-template.html:

Tools:

Add --description option.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._generate_results_dict):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_with_description):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: handle errors from image diff better
dpranke@chromium.org [Mon, 6 Aug 2012 21:00:29 +0000 (21:00 +0000)]
nrwt: handle errors from image diff better
https://bugs.webkit.org/show_bug.cgi?id=92934

Reviewed by Ojan Vafai.

Currently if ImageDiff crashes, returns a weird exit code, or
produces any stderr output, it's basically swallowed. This
change ensures that we log errors to stderr, and also appends
the error to the stderr for the test (so it'll show up in
results.html).

Most importantly, it'll cause diff_image() to fail and we'll
report ImageHashMismatch ... this may be kinda untrue, but I
think it's better than ignoring the error.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
(TestResultWriterTest):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_image):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.diff_image):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_diff_image_crashed):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
* Scripts/webkitpy/layout_tests/port/image_diff.py:
(ImageDiffer.diff_image):
(ImageDiffer._read):
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
(TestImageDiffer.test_diff_image):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_diff_image_crashed):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_image):
(PortTestCase):
(PortTestCase.test_diff_image_crashed):
(PortTestCase.test_diff_image_crashed.make_proc):
* Scripts/webkitpy/layout_tests/port/server_process_mock.py:
(MockServerProcess.__init__):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.diff_image):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_tolerance.ImageDiffTestPort.diff_image):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up printing.py
dpranke@chromium.org [Mon, 6 Aug 2012 20:46:30 +0000 (20:46 +0000)]
nrwt: clean up printing.py
https://bugs.webkit.org/show_bug.cgi?id=93026

Reviewed by Dirk Pranke.

This patch cleans up the implementation of printing.py now
that we're not using all the original complexity.

There should be no changes in functionality and everything
should be covered by the existing tests.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.__init__):
(Printer.__del__):
(Printer.print_config):
(Printer.print_found):
(Printer.print_expected):
(Printer.print_workers_and_shards):
(Printer):
(Printer._print_expected_results_of_type):
(Printer.print_results):
(Printer._print_timing_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_test_list_timing):
(Printer._print_directory_timings):
(Printer._print_statistics_for_test_timings):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
(Printer._print_one_line_summary):
(Printer.print_finished_test):
(Printer._print_test_result):
(Printer._print_test_trace):
(Printer._print_baseline):
(Printer._print_unexpected_test_result):
(Printer._print_progress):
(Printer._print_unexpected_results):
(Printer._print_unexpected_results.add_result):
(Printer._print_quiet):
(Printer._print_default):
(Printer._print_debug):
(Printer._print_for_bot):
(Printer.write_update):
(Printer.writeln):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_printer):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_unexpected_results):
(test_details):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIf the Apple Java plug-in is blocked and no runtime is installed, don't load it
andersca@apple.com [Mon, 6 Aug 2012 20:42:01 +0000 (20:42 +0000)]
If the Apple Java plug-in is blocked and no runtime is installed, don't load it
https://bugs.webkit.org/show_bug.cgi?id=93289
<rdar://problem/11730092>

Reviewed by Dan Bernstein.

Source/WebKit2:

If the Apple Java plug-in is blocked, but there's no Java runtime installed (or the Java plug-in is disabled),
don't even include it in the plug-in info store.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::shouldBlockPlugin):
Since this is static now, it shouldn't be const.

* UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
shouldBlockPlugin can be static.

* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
Return false if the Apple Java plug-in is blocked but Java isn't installed or enabled.

(WebKit::PluginInfoStore::shouldBlockPlugin):
Since this is static now, it shouldn't be const.

WebKitLibraries:

Add WKJLIsRuntimeAndWebComponentsInstalled().

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaSource should use it's own list of source URLs
annacc@chromium.org [Mon, 6 Aug 2012 20:41:20 +0000 (20:41 +0000)]
MediaSource should use it's own list of source URLs
https://bugs.webkit.org/show_bug.cgi?id=93285

Reviewed by Eric Carlson.

r124780 added MediaSource objects to PublicURLManager's streamURLs list,
piggy-backing on MEDIA_STREAM.  This patch creates a sourceURLs list so
that MediaSource can stand on its own.

Test: builds on Andriod even when MEDIA_STREAM is disabled.

* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
* html/PublicURLManager.h:
(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):
(WebCore::PublicURLManager::sourceURLs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium/mac] Unbreak debug builds with the 10.7 SDK
thakis@chromium.org [Mon, 6 Aug 2012 20:31:29 +0000 (20:31 +0000)]
[chromium/mac] Unbreak debug builds with the 10.7 SDK
https://bugs.webkit.org/show_bug.cgi?id=93202

Reviewed by James Robinson.

FMGetATSFontRefFromFont() is not available with the 10.7 SDK
when targetting 10.6. Don't delete this code completely yet,
it's still used with the 10.6 SDK when targetting 10.6 (which
chromium's build bots use).

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agochange bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
dpranke@chromium.org [Mon, 6 Aug 2012 20:22:05 +0000 (20:22 +0000)]
change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=93043

Reviewed by Ryosuke Niwa.

in preparation for the cleanup of the logging flags in new-run-webkit-tests.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test: Windows specific tests needed for fast/css/getComputedStyle/computed...
commit-queue@webkit.org [Mon, 6 Aug 2012 19:56:45 +0000 (19:56 +0000)]
Layout Test: Windows specific tests needed for fast/css/getComputedStyle/computed-style.html & computed-style-without-renderer.html
https://bugs.webkit.org/show_bug.cgi?id=93033

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.

Windows specific computed-style and computed-style-without-renderer tests are needed since CSS3 Flexbox is disabled on windows,
see https://bugs.webkit.org/show_bug.cgi?id=92047, new CSS3 Flexbox properties no longer used.

* platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Added.
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoneed tests to ensure flexboxes play nicely with box-sizing
ojan@chromium.org [Mon, 6 Aug 2012 19:17:20 +0000 (19:17 +0000)]
need tests to ensure flexboxes play nicely with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=70771

Reviewed by Tony Chang.

Source/WebCore:

Anytime we grab the width/height off of the RenderStyle, we need to adjust
it for box-sizing. Fortunately, we only do this two places in RenderFlexibleBox.
Also, delete crossAxisLength since it's unused.

Test: css3/flexbox/box-sizing.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/box-sizing-expected.txt: Added.
* css3/flexbox/box-sizing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber
commit-queue@webkit.org [Mon, 6 Aug 2012 19:04:31 +0000 (19:04 +0000)]
Web Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber
https://bugs.webkit.org/show_bug.cgi?id=93019

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-06
Reviewed by Pavel Feldman.

Source/WebCore:

Add test for WebInspector.linkifyStringAsFragment()

* inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

LayoutTests:

parseInt the RegExp match for lineNumber
New test case added to linkify.html

* inspector/debugger/linkifier-expected.txt:
* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Not reviewed, linting TestExpectations.
dimich@chromium.org [Mon, 6 Aug 2012 18:46:31 +0000 (18:46 +0000)]
[Chromium] Not reviewed, linting TestExpectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.
commit-queue@webkit.org [Mon, 6 Aug 2012 18:42:04 +0000 (18:42 +0000)]
Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=93127

Patch by Nasko Oskov <nasko@chromium.org> on 2012-08-06
Reviewed by Adam Barth.

Add support in the API to monitor and create frame hierarchy to allow replicating it
across different instances of WebKit.

* public/WebDocument.h:
(WebDocument): Added createElement.
* public/WebFrame.h: Added assignedName.
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didCreateFrame): Added to allow embedders to know when frames are created.
(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): Added the target frame as a parameter.
* public/WebNode.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):
* src/WebDocument.cpp:
(WebKit::WebDocument::createElement): Added to allow for creating frame elements.
(WebKit):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::uniqueName): Added to migrate callers to the matching WebCore API.
(WebKit):
(WebKit::WebFrameImpl::assignedName): Returns the name given to a frame, as opposed
to the unique name, generated by WebKit.
(WebKit::WebFrameImpl::createChildFrame): Added call to the frame client's didCreateFrame.
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebNode.cpp:
(WebKit::WebNode::appendChild): Added to allow for adding elements to the DOM.
(WebKit):
* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up logging, part 1
dpranke@chromium.org [Mon, 6 Aug 2012 18:31:44 +0000 (18:31 +0000)]
nrwt: clean up logging, part 1
https://bugs.webkit.org/show_bug.cgi?id=93018

Reviewed by Ojan Vafai.

remove --print, --help-printing from nrwt, add three new options:
--quiet, which just logs warnings,errors, and unexpected results
--debug-rwt-logging, a new name for --verbose
--details, to get the old --print trace-everything behavior

This patch does not implement the new "one line per test"
--verbose behavior specified in bug 88702, and there's a bunch
of internal cleanup I can do in printing.py that I'll defer to
a later patch to make things easier to review.

This patch deletes a lot of unit tests that are no longer
necessary since there aren't so many logging combinations.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(parse_args):
(passing_run):
(StreamTestingMixin.assertContains):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_full_results_html):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_additional_platform_directory):
(RebaselineTest.assertBaselines):
* Scripts/webkitpy/layout_tests/views/printing.py:
(print_options):
(Printer.__init__):
(Printer.enabled):
(Printer.print_unexpected_results):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(TestUtilityFunctions.test_print_options):
(Testprinter.get_result_summary):
(Testprinter.test_configure_and_cleanup):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_unexpected_results):
(test_details):
(test_default):
(test_quiet):
(test_verbose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium-Android] Store test executable, data and fonts in /data/local/tmp
wangxianzhu@chromium.org [Mon, 6 Aug 2012 18:29:31 +0000 (18:29 +0000)]
[Chromium-Android] Store test executable, data and fonts in /data/local/tmp
https://bugs.webkit.org/show_bug.cgi?id=91910

/data/local/tmp is a directory with permission 0777 by default.
Place DumpRenderTree resources here so that both the native test app and
the NRWT script can access them even if adb shell isn't running as root.

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestShellAndroid.cpp:
(createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.driver_cmd_line):
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._push_executable):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.make_port):
(ChromiumAndroidPortTest.test_expectations_files):
(ChromiumAndroidDriverTest.test_drt_cmd_line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Re-expose layoutTestController as various fuzzers depend on it
inferno@chromium.org [Mon, 6 Aug 2012 18:15:15 +0000 (18:15 +0000)]
[Chromium] Re-expose layoutTestController as various fuzzers depend on it
https://bugs.webkit.org/show_bug.cgi?id=93282

Reviewed by Ryosuke Niwa.

Unfortunately, various fuzzers used in the Chromium project still depends on
window.layoutTestController. Re-expose the object while they're making the transition.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController.
commit-queue@webkit.org [Mon, 6 Aug 2012 17:59:04 +0000 (17:59 +0000)]
[Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController.
https://bugs.webkit.org/show_bug.cgi?id=92596

Patch by David Reveman <reveman@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.

Source/WebCore:

The CCTextureUpdater interface is used by the main thread to queue
texture updates. The CCTextureUpdateController constructor takes a
CCTextureUpdater and contains the logic required to perform texture
uploads and texture copies. This class is only used by the impl thread.

No new tests.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::updatePart):
* platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::copyTexture):
* platform/graphics/chromium/TextureCopier.h:
(Parameters):
(TextureCopier):
(AcceleratedTextureCopier):
* platform/graphics/chromium/TextureUploader.h:
(Parameters):
(TextureUploader):
* platform/graphics/chromium/ThrottledTextureUploader.cpp:
(WebCore::ThrottledTextureUploader::uploadTexture):
* platform/graphics/chromium/ThrottledTextureUploader.h:
(ThrottledTextureUploader):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCTextureUpdateController.cpp: Added.
(WebCore):
(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::updateTextures):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::~CCTextureUpdateController):
(WebCore::CCTextureUpdateController::hasMoreUpdates):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):
* platform/graphics/chromium/cc/CCTextureUpdateController.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
(WebCore):
(CCTextureUpdateController):
(WebCore::CCTextureUpdateController::create):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::appendFullUpload):
(WebCore::CCTextureUpdater::appendPartialUpload):
(WebCore::CCTextureUpdater::appendCopy):
(WebCore::CCTextureUpdater::takeFirstFullUpload):
(WebCore::CCTextureUpdater::takeFirstPartialUpload):
(WebCore::CCTextureUpdater::takeFirstCopy):
(WebCore::CCTextureUpdater::hasMoreUpdates):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
(WebCore::CCTextureUpdater::fullUploadSize):
(WebCore::CCTextureUpdater::partialUploadSize):
(WebCore::CCTextureUpdater::copySize):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::maxPartialTextureUpdates):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):
(CCThreadProxy):

Source/WebKit/chromium:

* WebKit.gypi:
* src/WebExternalTextureLayer.cpp:
* tests/CCTextureUpdateControllerTest.cpp: Renamed from Source/WebKit/chromium/tests/CCTextureUpdaterTest.cpp.
* tests/CCTiledLayerTestCommon.h:
(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureUploader::uploadTexture):
* tests/TextureCopierTest.cpp:
(TEST):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in WebCore::RenderListItem::updateMarkerLocation
inferno@chromium.org [Mon, 6 Aug 2012 17:46:32 +0000 (17:46 +0000)]
Crash in WebCore::RenderListItem::updateMarkerLocation
https://bugs.webkit.org/show_bug.cgi?id=90476

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-06
Reviewed by Abhishek Arya.

Source/WebCore:

In some cases an anonymous block is destroyed when its last child is
removed. RenderListItem did not expect this and has it's own logic for
cleaning up such blocks when the list marker is removed. Detect this
case in RenderBlock::removeChild to defer to the logic in RenderListItem::updateListMarker.

Test: fast/lists/list-marker-remove-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):

LayoutTests:

* fast/lists/list-marker-remove-crash-expected.txt: Added.
* fast/lists/list-marker-remove-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Non-preserves-3d requires explicit flattening of screen-space transform.
shawnsingh@chromium.org [Mon, 6 Aug 2012 17:43:02 +0000 (17:43 +0000)]
[chromium] Non-preserves-3d requires explicit flattening of screen-space transform.
https://bugs.webkit.org/show_bug.cgi?id=85808

Reviewed by Adrienne Walker.

Source/WebCore:

When computing the screen-space transforms, z values were not
being flattened when they should be. This caused incorrect
clipping due to occlusion tracking that relied on the screen-space
transform. The fix is to flatten the screen-space transform just
like the "sublayerMatrix" is flattened, when the layer does not
preserve-3d.

In addition to making the simple fix, it was convenient to make a
helper function for the flattening code.

Additional unit test added to exercise that flattening code:
  CCLayerTreeHostCommonTest.verifyTransformsForFlatteningLayer

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::flattenTransformTo2d):
(WebCore):
* platform/graphics/chromium/cc/CCMathUtil.h:
(CCMathUtil):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable...
ossy@webkit.org [Mon, 6 Aug 2012 17:37:12 +0000 (17:37 +0000)]
Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error
https://bugs.webkit.org/show_bug.cgi?id=92545

Unreviewed trivial test fix after r124765.

* http/tests/inspector-enabled/dedicated-workers-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCreate a MediaSource object.
annacc@chromium.org [Mon, 6 Aug 2012 17:28:12 +0000 (17:28 +0000)]
Create a MediaSource object.
https://bugs.webkit.org/show_bug.cgi?id=91773

Reviewed by Eric Carlson.

MediaSource object is needed in order to implement the new
object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing:
https://bugs.webkit.org/show_bug.cgi?id=91775

Adding new files to build files:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

New MediaSource object:
* Modules/mediasource/MediaSource.cpp: Added.
* Modules/mediasource/MediaSource.h: Added.
* Modules/mediasource/MediaSource.idl: Added.

Create a registry for the blob storage and lookup:
* Modules/mediasource/MediaSourceRegistry.cpp: Added.
* Modules/mediasource/MediaSourceRegistry.h: Added.

Connect SourceBuffer to MediaSource:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered): Forward call to MediaSource.
(WebCore::SourceBuffer::append): Ditto.
(WebCore::SourceBuffer::abort): Ditto.
* Modules/mediasource/SourceBuffer.h:
(WebCore::SourceBuffer::create): Add a MediaSource to the constructor.
(WebCore::SourceBuffer::clear): Clear the MediaSource.
(SourceBuffer):
* Modules/mediasource/SourceBufferList.cpp: include SourceBuffer.h
* Modules/mediasource/SourceBufferList.h:

Make MediaSource an EventTarget:
* dom/EventTarget.h:
(WebCore):
* dom/EventTargetFactory.in:

Enable creation of MediaSource object URL from JavaScript:
* html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL):
* html/DOMURL.h:
(WebCore):
(DOMURL):
* html/DOMURL.idl:

New MediaSource constructor:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify CSSOM style declaration's grabbing at internals.
kling@webkit.org [Mon, 6 Aug 2012 17:04:28 +0000 (17:04 +0000)]
Simplify CSSOM style declaration's grabbing at internals.
<http://webkit.org/b/93261>

Reviewed by Antti Koivisto.

It was already the case that StylePropertySets exposed in CSSOM were guaranteed mutable,
so remove the mechanism to convert immutable backing objects to mutable ones.

Made ensureCSSStyleDeclaration() non-const to prevent callers that may have an
immutable StylePropertySet from wrapping a CSSOM object around it.

* css/PropertySetCSSStyleDeclaration.h:
(PropertySetCSSStyleDeclaration):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

    Remove indirection and access StylePropertySet member directly.

* css/StylePropertySet.h:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):

    Made these two non-const. CSSOM wrappers should only ever be constructed around
    mutable StylePropertySets.
    Also added ASSERT(isMutable()).

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

    Cast away the constness of StyledElement::attributeStyle(). It's not pretty,
    but these objects are guaranteed mutable, and there's an assertion to protect
    us in ensureCSSStyleDeclaration() if something changes in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Protocol: Add "namedFlowCreated" and "namedFlowRemoved" events
commit-queue@webkit.org [Mon, 6 Aug 2012 16:39:56 +0000 (16:39 +0000)]
Web Inspector: Protocol: Add "namedFlowCreated" and "namedFlowRemoved" events
https://bugs.webkit.org/show_bug.cgi?id=92739

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-08-06
Reviewed by Pavel Feldman.

Source/WebCore:

Implemented "namedFlowCreated" and "namedFlowRemoved" events.

Modified test: inspector/styles/protocol-css-regions-commands.html.

* dom/WebKitNamedFlowCollection.cpp:
(WebCore::WebKitNamedFlowCollection::ensureFlowWithName):
(WebCore::WebKitNamedFlowCollection::discardNamedFlow):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.styleSheetChanged):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):

LayoutTests:

Modified test so that it validates the implemented events.

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in FrameLoader::stopAllLoaders.
inferno@chromium.org [Mon, 6 Aug 2012 16:30:40 +0000 (16:30 +0000)]
Crash in FrameLoader::stopAllLoaders.
https://bugs.webkit.org/show_bug.cgi?id=90805

Reviewed by Nate Chapin.

Calling m_provisionalDocumentLoader->stopLoading() can blow away the frame
from underneath. Protect it with a RefPtr.

No new tests. We don't have a reliable testcase to reproduce this. However,
the crash and free stack from ClusterFuzz point clearly at the bug.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopAllLoaders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening, rebaselining a few HTMLProgressElement tests
zandobersek@gmail.com [Mon, 6 Aug 2012 16:07:28 +0000 (16:07 +0000)]
Unreviewed GTK gardening, rebaselining a few HTMLProgressElement tests
after changes in r124754.

* platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
* platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
* platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r124692): webarchive/loading/javascript-url-iframe-crash.html fails
rniwa@webkit.org [Mon, 6 Aug 2012 15:53:01 +0000 (15:53 +0000)]
REGRESSION(r124692): webarchive/loading/javascript-url-iframe-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=93190

Reviewed by Adam Barth.

Apparently we can't just edit the markup in a webarchive file. Re-generated webarchive file
from a locally copied markup.

* webarchive/loading/resources/javascript-url-iframe-crash.webarchive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Rolling out my r123067 and r123572
hbono@chromium.org [Mon, 6 Aug 2012 15:29:32 +0000 (15:29 +0000)]
Source/WebCore: Rolling out my r123067 and r123572
https://bugs.webkit.org/show_bug.cgi?id=93234

Reviewed by Ryosuke Niwa.

This change manually rolls out my r123067 and r123572 (except layout tests)
because it renders RTL text to a wrong place when an RTL element shows a
vertical scrollbar at its left side.

No new tests because this change rolls out my changes.

* dom/Element.cpp:
(WebCore::Element::clientLeft):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::paintObject):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::topLeftLocationOffset):

LayoutTests: Rolling out for r123067 and r123572
https://bugs.webkit.org/show_bug.cgi?id=93234

Reviewed by Ryosuke Niwa.

This change marks tests that fail when rolling out my r123067 and r123572.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Regions] Add the NamedFlow.getRegions() API
commit-queue@webkit.org [Mon, 6 Aug 2012 15:24:17 +0000 (15:24 +0000)]
[CSS Regions] Add the NamedFlow.getRegions() API
https://bugs.webkit.org/show_bug.cgi?id=93240

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-06
Reviewed by Andreas Kling.

Source/WebCore:

This patch adds the NamedFlow.getRegions() API call as specified by http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-named-flow .
For now, WebKit supports only one type of regions, Element. The Region interface will be introduced when other interfaces will be capable
of becoming regions.

New test: fast/regions/webkit-named-flow-get-regions.html

* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent): Add a check not to include the pseudo-elements that are regions; those don't have a node attached.
(WebCore::WebKitNamedFlow::getRegions):
(WebCore):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:

LayoutTests:

Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-named-flow
The test also verifies the regions are returned in document order.

* fast/regions/webkit-named-flow-get-regions-expected.txt: Added.
* fast/regions/webkit-named-flow-get-regions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Regions] Rename regionOverflow to regionOverset
commit-queue@webkit.org [Mon, 6 Aug 2012 15:21:53 +0000 (15:21 +0000)]
[CSS Regions] Rename regionOverflow to regionOverset
https://bugs.webkit.org/show_bug.cgi?id=93256

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-06
Reviewed by Andreas Kling.

Source/WebCore:

Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-region-regionoverset
The regionOverflow property has been renamed to regionOverset in the latest working draft. This patch applies the change both externally and
internally in the code.

Tests: No new tests because this is not a functional change.

* dom/Element.cpp:
(WebCore::Element::renderRegion): Convenience method to access the renderer for a region element.
(WebCore):
(WebCore::Element::webkitRegionOverset):
* dom/Element.h:
(WebCore):
* dom/Element.idl:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOversetRect):
* rendering/RenderRegion.h:
(RenderRegion):

LayoutTests:

Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-region-regionoverset

The tests have been adapted to use webkitRegionOverset rather than webkitRegionOverflow.

* fast/regions/element-region-overflow-state-expected.txt: Removed.
* fast/regions/element-region-overflow-state-vertical-rl-expected.txt: Removed.
* fast/regions/element-region-overset-state-expected.txt: Added.
* fast/regions/element-region-overset-state-vertical-rl-expected.txt: Added.
* fast/regions/element-region-overset-state-vertical-rl.html: Renamed from LayoutTests/fast/regions/element-region-overflow-state-vertical-rl.html.
* fast/regions/element-region-overset-state.html: Renamed from LayoutTests/fast/regions/element-region-overflow-state.html.
* fast/regions/webkit-named-flow-first-empty-region-index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWTR should be able to load external resources
kbalazs@webkit.org [Mon, 6 Aug 2012 14:54:58 +0000 (14:54 +0000)]
WTR should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=89382

Reviewed by Ryosuke Niwa.

Allow to load an external resource as the main frame
and allow all subsequent external loads for such a main
frame. This behavior is necessary for being able to run
performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::isLocalHost):
(WTR):
(WTR::isHTTPOrHTTPSScheme):
(WTR::InjectedBundlePage::willSendRequestForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: a tiny refactoring of Highlighter in InspectorDOMAgent
commit-queue@webkit.org [Mon, 6 Aug 2012 14:14:24 +0000 (14:14 +0000)]
Web Inspector: a tiny refactoring of Highlighter in InspectorDOMAgent
https://bugs.webkit.org/show_bug.cgi?id=93257

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-06
Reviewed by Pavel Feldman.

Moving error string setting inside highlightConfigFromInspectorObject.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::highlightNode):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add memory instrumentation for CSSValue and its descendants
yurys@chromium.org [Mon, 6 Aug 2012 14:09:59 +0000 (14:09 +0000)]
Web Inspector: add memory instrumentation for CSSValue and its descendants
https://bugs.webkit.org/show_bug.cgi?id=93130

Reviewed by Pavel Feldman.

Added memory footprint reporting routine to CSSValue and its descendants.

Memory reporing for CSSValue is organized in a following way:
- CSSValue implements reportMemoryUsage method that switches by the value
  type and calls reportDescendantMemoryUsage on the concrete type
- There may be some intermediate classes in the inheritance chain between
  CSSValue and the leaf class implementing reportDescendantMemoryUsage. Those
  intermediate classes implement reportBaseClassMemoryUsage method that can
  be called from a descendant to collect memory information for the base class
  members. Having reportDescendantMemoryUsage only on the leaf classes prevents
  us from accidentally adding the intermediate classes to the switch block
  in the CSSValue::reportMemoryUsage.

* css/CSSAspectRatioValue.cpp:
(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSAspectRatioValue.h:
(CSSAspectRatioValue):
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSBorderImageSliceValue.h:
(CSSBorderImageSliceValue):
* css/CSSCalculationValue.cpp:
(WebCore):
(WebCore::CSSCalcValue::reportDescendantMemoryUsage):
(CSSCalcPrimitiveValue):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(CSSCalcValue):
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSCanvasValue.h:
(CSSCanvasValue):
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSCursorImageValue.h:
(CSSCursorImageValue):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSFunctionValue.h:
(CSSFunctionValue):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
* css/CSSGradientValue.h:
(CSSGradientColorStop):
(CSSGradientValue):
(CSSLinearGradientValue):
(CSSRadialGradientValue):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
(WebCore):
* css/CSSImageGeneratorValue.h:
(CSSImageGeneratorValue):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
* css/CSSImageSetValue.h:
(ImageWithScale):
(CSSImageSetValue):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSImageValue.h:
(CSSImageValue):
* css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSInheritedValue.h:
(CSSInheritedValue):
* css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSInitialValue.h:
(CSSInitialValue):
* css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSLineBoxContainValue.h:
(CSSLineBoxContainValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSReflectValue.h:
(CSSReflectValue):
* css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):
* css/CSSTimingFunctionValue.h:
(CSSLinearTimingFunctionValue):
(CSSCubicBezierTimingFunctionValue):
(CSSStepsTimingFunctionValue):
* css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):
(WebCore):
* css/CSSUnicodeRangeValue.h:
(CSSUnicodeRangeValue):
* css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
(TextCloneCSSValue):
(WebCore::CSSValue::reportMemoryUsage):
(WebCore):
* css/CSSValue.h:
(WebCore):
(CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
(WebCore):
* css/CSSValueList.h:
(CSSValueList):
* css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
(CSSVariableValue):
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
(WebCore):
* css/FontFeatureValue.h:
(FontFeatureValue):
* css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
(WebCore):
* css/FontValue.h:
(FontValue):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
* css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
(WebCore):
* css/ShadowValue.h:
(ShadowValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):
(WebCore):
* css/WebKitCSSFilterValue.h:
(WebKitCSSFilterValue):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
(WebCore):
* css/WebKitCSSSVGDocumentValue.h:
(WebKitCSSSVGDocumentValue):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
(WebCore):
* css/WebKitCSSShaderValue.h:
(WebKitCSSShaderValue):
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):
(WebCore):
* css/WebKitCSSTransformValue.h:
(WebKitCSSTransformValue):
* dom/MemoryInstrumentation.cpp:
(WebCore::MemoryInstrumentation::addString):
(WebCore):
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addHashCountedSet):
(WebCore::MemoryClassInfo::addMember):
* svg/SVGColor.cpp:
(WebCore::SVGColor::reportDescendantMemoryUsage):
(WebCore):
* svg/SVGColor.h:
(SVGColor):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
(WebCore):
* svg/SVGPaint.h:
(SVGPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline for Mac10.6 against r124752
toyoshim@chromium.org [Mon, 6 Aug 2012 14:09:53 +0000 (14:09 +0000)]
Unreviewed, rebaseline for Mac10.6 against r124752

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

* platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline for r124754.
toyoshim@chromium.org [Mon, 6 Aug 2012 14:05:32 +0000 (14:05 +0000)]
Unreviewed, rebaseline for r124754.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

* fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
* platform/chromium-mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
* platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
* platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Removed.
* platform/efl/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Removed.
* platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
* platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable...
yurys@chromium.org [Mon, 6 Aug 2012 13:51:44 +0000 (13:51 +0000)]
Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error
https://bugs.webkit.org/show_bug.cgi?id=92545

Reviewed by Pavel Feldman.

Source/WebCore:

- Replaced WorkerAgent.setWorkerInspectionEnabled with WorkerAgent.enable/disable
- Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers()
  that tells if inspector front-end on the given platform can launch dedicated worker
  front-end.

* inspector/Inspector.json:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.h:
(WebCore::InspectorFrontendClientLocal::canInspectWorkers):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::canInspectWorkers):
(WebCore):
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::enable):
(WebCore):
(WebCore::InspectorWorkerAgent::disable):
* inspector/InspectorWorkerAgent.h:
(InspectorWorkerAgent):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.setZoomFactor):
(.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/Settings.js:

Source/WebKit/chromium:

Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers()
that tells if inspector front-end on the given platform can launch dedicated worker
front-end.

* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::canInspectWorkers):
(WebKit):
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
* src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Update NEWS and configure.ac for 1.9.6 release
carlosgc@webkit.org [Mon, 6 Aug 2012 13:45:44 +0000 (13:45 +0000)]
Unreviewed. Update NEWS and configure.ac for 1.9.6 release

.:

* configure.ac: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 1.9.6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][GTK] Improvements for the new spell-checking API
mario@webkit.org [Mon, 6 Aug 2012 13:43:07 +0000 (13:43 +0000)]
[WK2][GTK] Improvements for the new spell-checking API
https://bugs.webkit.org/show_bug.cgi?id=93262

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Provide a way to ask TextCheckerEnchant helper class for the list
of languages currently available for the spell checking feature.

* platform/text/gtk/TextCheckerEnchant.cpp:
(enchantDictDescribeCallback): Renamed from
getAvailableDictionariesCallback, for consistency.
(TextCheckerEnchant::updateSpellCheckingLanguages): Updated usage
of getAvailableDictionariesCallback to enchantDictDescribeCallback.
(TextCheckerEnchant::getSpellCheckingLanguages): New. Will build
and return a String with a comma-separated list of languages
currently in use by the spell checking feature.
* platform/text/gtk/TextCheckerEnchant.h:
(TextCheckerEnchant): Added new function getSpellCheckingLanguages.

Source/WebKit2:

Improve the way the new spell-checking API is implemented, by
using better internal representations for data, documenting better
the new functions and using better unit tests.

* UIProcess/API/gtk/WebKitTextChecker.cpp:
(WebKitTextChecker::getSpellCheckingLanguages): Just return the
value previously cached when calling to the setter function.
(WebKitTextChecker::setSpellCheckingLanguages): Update the text
checker in WebCore and cache the value returned from it.
* UIProcess/API/gtk/WebKitTextChecker.h:
(WebKitTextChecker): Use a CString instead of an String to cache
the list of spell checking languages. Update getter and setter.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): No need to cache the spell checking
languages here anymore.
(webkit_web_context_get_spell_checking_languages): Improve
both implementation and documentation to be more consistent.
(webkit_web_context_set_spell_checking_languages): Make
'languages' a mandatory (non-NULL) parameter. Update documentation.
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSpellChecker): Test even more situations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
kbalazs@webkit.org [Mon, 6 Aug 2012 13:35:09 +0000 (13:35 +0000)]
[WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
https://bugs.webkit.org/show_bug.cgi?id=93120

Reviewed by Csaba Osztrogonác.

Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
so it will be able to detect an unresponsive web process.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_timeout_ms):
* WebKitTestRunner/TestController.cpp:
(WTR):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Mon, 6 Aug 2012 13:30:47 +0000 (13:30 +0000)]
[Qt] Unreviewed gardening.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-06

* platform/qt/Skipped: Skip new SHADOW_DOM tests.
* platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Rebase after r124754.
* platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Rebase after r124754.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPass presentational attribute StylePropertySets by const pointer where possible.
kling@webkit.org [Mon, 6 Aug 2012 13:14:04 +0000 (13:14 +0000)]
Pass presentational attribute StylePropertySets by const pointer where possible.
<http://webkit.org/b/93187>

Reviewed by Antti Koivisto.

Minor cleanup to enforce (at compile time) the fact that no methods that have the
side-effect of incurring immutable-to-mutable-StylePropertySet conversion.

This was already covered by assertions, we're just making it stricter and adding
some documentational flavor.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::attributeStyle):
* dom/StyledElement.h:
(WebCore::StyledElement::additionalAttributeStyle):
(StyledElement):
(WebCore::StyledElement::attributeStyle):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
* html/HTMLTableCellElement.h:
(HTMLTableCellElement):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
* html/HTMLTableColElement.h:
(HTMLTableColElement):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
* html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd DeviceProximityEvent interface
commit-queue@webkit.org [Mon, 6 Aug 2012 13:04:03 +0000 (13:04 +0000)]
Add DeviceProximityEvent interface
https://bugs.webkit.org/show_bug.cgi?id=92942

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-06
Reviewed by Kentaro Hara.

Source/WebCore:

Spec : http://www.w3.org/TR/proximity/#idl-def-DeviceProximityEvent

Add DeviceProximityEvent interface of Proximity Events.
And add onwebkitdeviceproximity event handler to the DOMWindow.

Tests: fast/dom/Proximity/check-event-deviceproximity.html
       fast/dom/Proximity/create-event-deviceproximity.html
       fast/events/constructors/device-proximity-event-constructor.html

* CMakeLists.txt:
* Modules/proximity/DeviceProximityEvent.cpp: Added.
(WebCore):
(WebCore::DeviceProximityEvent::DeviceProximityEvent):
* Modules/proximity/DeviceProximityEvent.h: Added.
(WebCore):
(WebCore::DeviceProximityEventInit::DeviceProximityEventInit):
(DeviceProximityEventInit):
(DeviceProximityEvent):
(WebCore::DeviceProximityEvent::~DeviceProximityEvent):
(WebCore::DeviceProximityEvent::create):
(WebCore::DeviceProximityEvent::value):
(WebCore::DeviceProximityEvent::min):
(WebCore::DeviceProximityEvent::max):
(WebCore::DeviceProximityEvent::interfaceName):
* Modules/proximity/DeviceProximityEvent.idl: Added.
* dom/EventNames.h:
(WebCore):
* dom/EventNames.in:
* page/DOMWindow.h:
(DOMWindow):
* page/DOMWindow.idl:

LayoutTests:

Add tests for creating and handling the DeviceProximityEvent.

* fast/dom/Proximity/check-event-deviceproximity-expected.txt: Added.
* fast/dom/Proximity/check-event-deviceproximity.html: Added.
* fast/dom/Proximity/create-event-deviceproximity-expected.txt: Added.
* fast/dom/Proximity/create-event-deviceproximity.html: Added.
* fast/events/constructors/device-proximity-event-constructor-expected.txt: Added.
* fast/events/constructors/device-proximity-event-constructor.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Remove workarounds from input event handling
abecsi@webkit.org [Mon, 6 Aug 2012 13:03:42 +0000 (13:03 +0000)]
[Qt][WK2] Remove workarounds from input event handling
https://bugs.webkit.org/show_bug.cgi?id=93125

Reviewed by Jocelyn Turcotte.

Since input event propagation in Qt5 has been fixed we can remove
the workarounds introduced to prevent the QML WebView from receiving
input events targeting a child dialog.
To do this the childMouseEventFilter function has to be changed to
force touch and mouse events through the default propagation path.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebView::childMouseEventFilter):
(QQuickWebView::touchEvent):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate):
* UIProcess/qt/QtDialogRunner.cpp:
(WebKit::QtDialogRunner::run):
* UIProcess/qt/WebColorChooserProxyQt.cpp:
(WebKit::WebColorChooserProxyQt::createItem):
(WebKit::WebColorChooserProxyQt::endChooser):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 6 Aug 2012 12:35:28 +0000 (12:35 +0000)]
Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing header file.

Source/WebCore:

* GNUmakefile.list.am: Remove unexistent header file.

Tools:

* GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
commit-queue@webkit.org [Mon, 6 Aug 2012 12:27:03 +0000 (12:27 +0000)]
[EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
https://bugs.webkit.org/show_bug.cgi?id=82724

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-06
Reviewed by Csaba Osztrogonác.

Tools:

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::removeAllVisitedLinks):

LayoutTests:

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Remove custom JSBindings for constructArrayBufferView()
commit-queue@webkit.org [Mon, 6 Aug 2012 12:02:34 +0000 (12:02 +0000)]
[JSC] Remove custom JSBindings for constructArrayBufferView()
https://bugs.webkit.org/show_bug.cgi?id=93097

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-08-06
Reviewed by Kentaro Hara.

Currently TypedArray files have the custom implementation of constructArrayBufferView().
We can can remove these modifying CodeGeneratorJS.pm

Tests: TestTypedArray.idl

* bindings/js/JSFloat32ArrayCustom.cpp: Removed custom call constructArrayBufferView().
* bindings/js/JSFloat64ArrayCustom.cpp: Ditto.
* bindings/js/JSInt16ArrayCustom.cpp: Ditto.
* bindings/js/JSInt32ArrayCustom.cpp: Ditto.
* bindings/js/JSUint16ArrayCustom.cpp: Ditto.
* bindings/js/JSUint32ArrayCustom.cpp: Ditto.
* bindings/scripts/CodeGeneratorJS.pm: Modified Generator code to generate bindings for
constructArrayBufferView()
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.txt: Added [TypedArray] attribute.
* bindings/scripts/test/JS/JSFloat64Array.cpp: Tests result.
(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):
* bindings/scripts/test/TestTypedArray.idl: Test.
* html/canvas/Float32Array.idl: Using [TypedArray].
* html/canvas/Float64Array.idl: Ditto.
* html/canvas/Int16Array.idl: Ditto.
* html/canvas/Int32Array.idl: Ditto.
* html/canvas/Uint16Array.idl: Ditto.
* html/canvas/Uint32Array.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAuthorShadowDOM for progress element
shinyak@chromium.org [Mon, 6 Aug 2012 12:00:14 +0000 (12:00 +0000)]
AuthorShadowDOM for progress element
https://bugs.webkit.org/show_bug.cgi?id=91969

Reviewed by Hajime Morita.

Source/WebCore:

We add support for AuthorShadowDOM for progress element.

According to the Shadow DOM spec, a progress element should behave like having a UserAgentShadowRoot and
an element in UserAgentShadowRoot draws a real 'progress' bar. In this patch, we change the inner structure
of a progress element so that we can distribute an element having RenderProgress to AuthorShadowDOM.

Before this patch, a progress element has the following inner structure.

    <progress>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot
                       |
                       +-- ProgressBarElement
                       |
                       +-- ProgressValueElement

After this patch, a progress element will have the following inner structure.

    <progress>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot
                       |
                       +-- ProgressInnerElement
                                   |
                                   +-- ProgressBarElement
                                   |
                                   +-- ProgressValueElement

Tests: fast/dom/shadow/shadowdom-for-progress-dynamic.html
       fast/dom/shadow/shadowdom-for-progress-multiple.html
       fast/dom/shadow/shadowdom-for-progress-with-style.html
       fast/dom/shadow/shadowdom-for-progress-without-appearance.html
       fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html
       fast/dom/shadow/shadowdom-for-progress.html

* css/html.css:
(progress::-webkit-progress-inner-element):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::createRenderer):
(WebCore::HTMLProgressElement::renderProgress): Returns RenderProgress gotten from UserAgentShadowDOM.
(WebCore):
(WebCore::HTMLProgressElement::willAddAuthorShadowRoot):
(WebCore::HTMLProgressElement::didElementStateChange):
(WebCore::HTMLProgressElement::createShadowSubtree): Creates a new Shadow DOM structure.
* html/HTMLProgressElement.h:
(WebCore):
(WebCore::HTMLProgressElement::hasAuthorShadowRoot):
(HTMLProgressElement):
(WebCore::isHTMLProgressElement):
(WebCore::toHTMLProgressElement):
* html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressShadowElement::ProgressShadowElement):
(WebCore::ProgressShadowElement::progressElement):
(WebCore::ProgressInnerElement::ProgressInnerElement): We introduce a new element having RenderProgress
so that we can distribute an element having RenderProgress to AuthorShadowDOM.
(WebCore):
(WebCore::ProgressInnerElement::create):
(WebCore::ProgressInnerElement::shadowPseudoId):
(WebCore::ProgressInnerElement::createRenderer):
(WebCore::ProgressInnerElement::rendererIsNeeded):
* html/shadow/ProgressShadowElement.h:
(ProgressShadowElement):
(WebCore):
(ProgressInnerElement):
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::progressElement):
* rendering/RenderProgress.h:
(RenderProgress):

LayoutTests:

Contains the following tests:
  (1) progress element with AuthorShadowDOM
  (2) progress element with multiple AuthorShadowDOM with a shadow element
  (3) progress element with multiple AuthorShadowDOM without a shadow element
  (4) progress element with AuthorShadowDOM with dynamic value update
  (5) progress element with AuthorShadowDOM with style
  (6) progress element with AuthorShadowDOM with -webkit-appearance: none

* fast/dom/HTMLProgressElement/progress-clone-expected.txt:
* fast/dom/HTMLProgressElement/progress-clone.html:
* fast/dom/HTMLProgressElement/progress-element-markup-expected.txt:
* fast/dom/shadow/resources/replaced-element-styles.css: Added.
(.progress-like):
(.progress-inner-element-like):
* fast/dom/shadow/shadowdom-for-progress-dynamic-expected.html: Added.
* fast/dom/shadow/shadowdom-for-progress-dynamic.html: Added.
* fast/dom/shadow/shadowdom-for-progress-expected.html: Added.
* fast/dom/shadow/shadowdom-for-progress-multiple-expected.html: Added.
* fast/dom/shadow/shadowdom-for-progress-multiple.html: Added.
* fast/dom/shadow/shadowdom-for-progress-with-style-expected.html: Added.
* fast/dom/shadow/shadowdom-for-progress-with-style.html: Added.
* fast/dom/shadow/shadowdom-for-progress-without-appearance-expected.html: Added.
* fast/dom/shadow/shadowdom-for-progress-without-appearance.html: Added.
* fast/dom/shadow/shadowdom-for-progress-without-shadow-element-expected.html: Added.
* fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html: Added.
* fast/dom/shadow/shadowdom-for-progress.html: Added.
* platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
* platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
* platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove minimum window size for PagePopup
keishi@webkit.org [Mon, 6 Aug 2012 11:37:50 +0000 (11:37 +0000)]
Remove minimum window size for PagePopup
https://bugs.webkit.org/show_bug.cgi?id=93100

Reviewed by Kent Tamura.

Source/WebCore:

DOMWindow had a minimum size of 100x100 pixels. We need to remove that limit for PagePopup window.

No new tests. Covered in platform/chromium/fast/forms/color/color-suggestion-picker-{one,two}-row-appearance.html.

* Resources/colorSuggestionPicker.css:
(.color-swatch-container):
* page/ChromeClient.h:
(WebCore::ChromeClient::minimumWindowSize):
(ChromeClient):
* page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::adjustWindowRect): Asks Chrome::minimumWindowSize for minimum window size.
* page/DOMWindow.h:
(DOMWindow):

Source/WebKit/chromium:

* src/WebPagePopupImpl.cpp: Returns 0x0 so the page popup can be smaller than 100x100.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html: Added background color so we can check that we don't have extra white area.
* platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline for r124745.
toyoshim@chromium.org [Mon, 6 Aug 2012 11:06:43 +0000 (11:06 +0000)]
Unreviewed, rebaseline for r124745.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

* platform/chromium-mac/fast/block/float/032-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip new asserting tests to paint the bots green.
ossy@webkit.org [Mon, 6 Aug 2012 10:30:51 +0000 (10:30 +0000)]
Unreviewed gardening, skip new asserting tests to paint the bots green.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMicrodata: document.getItems() must treat no token as no parameter.
arko@motorola.com [Mon, 6 Aug 2012 10:29:39 +0000 (10:29 +0000)]
Microdata: document.getItems() must treat no token as no parameter.
https://bugs.webkit.org/show_bug.cgi?id=93071

Reviewed by Ryosuke Niwa.

Source/WebCore:

document.getItems() must return all top-level microdata items in the
document when no tokens specified in the argument.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#dom-document-getitems

Test: fast/dom/MicroData/getitems-empty-string-as-arg.html

* dom/Document.cpp:
(WebCore::Document::getItems): Create an empty string identifier when typeNames is null string
to map such request in the cache.
* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::undefinedItemType): Changed undefinedItemType() to empty string.
(WebCore::MicroDataItemList::nodeMatches): Return true if m_typeNames contains no token.

LayoutTests:

Added test to verify that document.getItems() returns all top-level
microdata items in the document when no tokens specified in the argement.

* fast/dom/MicroData/getitems-empty-string-as-arg-expected.txt: Added.
* fast/dom/MicroData/getitems-empty-string-as-arg.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter
commit-queue@webkit.org [Mon, 6 Aug 2012 10:19:53 +0000 (10:19 +0000)]
Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=91632

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-06
Reviewed by Pavel Feldman.

Extracted struct HighlightInfo from struct HighlightData in DOMNodeHighlighter.
Now InspectorOverlay receives node or rect to highlight together with highlightInfo.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::highlightRect):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore):
(WebCore::InspectorOverlay::drawRectHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):
* inspector/DOMNodeHighlighter.h:
(HighlightConfig):
(WebCore::Highlight::setColors):
(Highlight):
(InspectorOverlay):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::inspect):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
* inspector/InspectorDOMAgent.h:
(WebCore):
(InspectorDOMAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused png files from platform/chromium-linux/fast/css/variables.
hayato@chromium.org [Mon, 6 Aug 2012 10:17:49 +0000 (10:17 +0000)]
Remove unused png files from platform/chromium-linux/fast/css/variables.
https://bugs.webkit.org/show_bug.cgi?id=93232

Reviewed by Tony Chang.

* platform/chromium-linux/fast/css/variables/block-cycle-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/colors-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/declaration-block-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/font-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/image-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/import-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/inline-style-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/invalid-variable-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/margin-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/misplaced-import-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/misplaced-variables-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/multiple-blocks-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/multiple-term-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/override-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/print-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/remove-variable-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/set-variable-test-expected.png: Removed.
* platform/chromium-linux/fast/css/variables/shorthand-test-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: Web Inspector: single line test fix for r124744.
loislo@chromium.org [Mon, 6 Aug 2012 09:57:42 +0000 (09:57 +0000)]
Unreviewed: Web Inspector: single line test fix for r124744.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124739.
commit-queue@webkit.org [Mon, 6 Aug 2012 09:44:28 +0000 (09:44 +0000)]
Unreviewed, rolling out r124739.
http://trac.webkit.org/changeset/124739
https://bugs.webkit.org/show_bug.cgi?id=93241

newly added test crash on chromium linux debug (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):

LayoutTests:

* fast/lists/list-marker-remove-crash-expected.txt: Removed.
* fast/lists/list-marker-remove-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix layoutMod in fractional layout units.
allan.jensen@nokia.com [Mon, 6 Aug 2012 09:38:14 +0000 (09:38 +0000)]
Fix layoutMod in fractional layout units.
https://bugs.webkit.org/show_bug.cgi?id=92374

Reviewed by Levi Weintraub.

Source/WebCore:

The modulo operation is upgraded from only being performed in integer to
being performed in fractionalLayoutUnits, so that it returns an accurate
remainder for fractionalLayoutUnit division.

An alternative modulo operation is added and used to find the remainder
after division with natural integer results, for instance, the remainding
height after pagination.

No new functionality. No new tests.

* platform/FractionalLayoutUnit.h:
(WebCore::intMod):
(WebCore::operator%):
* rendering/LayoutTypes.h:
(WebCore::layoutMod):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):

LayoutTests:

Mark minor pixel changes in the baseline as expected failures.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: native memory instrumentation: cover MemoryCache with MemoryInstrument...
loislo@chromium.org [Mon, 6 Aug 2012 09:12:01 +0000 (09:12 +0000)]
Web Inspector: native memory instrumentation: cover MemoryCache with MemoryInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=91734

Reviewed by Yury Semikhatsky.

Old version of native memory instrumentation doesn't mark the memory cache objects as visited.
As a result MI could count the same objects multiple times.
The new version just traverses through MemoryCache the same way as through DOM.
Also not all the cached resource types were counted.

* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/MemoryInstrumentation.h:
* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
(WebCore):
* loader/cache/CachedCSSStyleSheet.h:
(WebCore):
(CachedCSSStyleSheet):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
(WebCore):
* loader/cache/CachedFont.h:
(CachedFont):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
(WebCore):
* loader/cache/CachedImage.h:
(CachedImage):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::reportMemoryUsage):
(WebCore):
* loader/cache/CachedRawResource.h:
(WebCore):
(CachedRawResource):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
(WebCore):
* loader/cache/CachedResource.h:
(WebCore):
(CachedResource):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
(WebCore):
* loader/cache/CachedResourceHandle.h:
(WebCore):
(CachedResourceHandleBase):
* loader/cache/CachedResourceLoader.cpp:
(WebCore):
(WebCore::CachedResourceLoader::reportMemoryUsage):
* loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
(WebCore):
* loader/cache/CachedSVGDocument.h:
(CachedSVGDocument):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
(WebCore):
* loader/cache/CachedScript.h:
(WebCore):
(CachedScript):
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
(WebCore):
* loader/cache/CachedShader.h:
(WebCore):
(CachedShader):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
(WebCore):
* loader/cache/CachedXSLStyleSheet.h:
(WebCore):
(CachedXSLStyleSheet):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
(WebCore):
* loader/cache/MemoryCache.h:
(WebCore):
(MemoryCache):
* platform/PurgeableBuffer.h:
(WebCore):
(PurgeableBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] fast/forms/range/slider-mouse-events.html and fast/forms/range/slider-oncha...
kkristof@inf.u-szeged.hu [Mon, 6 Aug 2012 08:27:35 +0000 (08:27 +0000)]
[Qt][WK2] fast/forms/range/slider-mouse-events.html and fast/forms/range/slider-onchange-event.html fail after r124625
https://bugs.webkit.org/show_bug.cgi?id=93231

Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-08-06

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] [GTK] Register Protocol Handler Client is never deleted
commit-queue@webkit.org [Mon, 6 Aug 2012 08:02:18 +0000 (08:02 +0000)]
[EFL] [GTK] Register Protocol Handler Client is never deleted
https://bugs.webkit.org/show_bug.cgi?id=92745

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-06
Reviewed by Gustavo Noronha Silva.

Added usage of OwnPtr to manage register protocol handler client pointer.

Source/WebKit/efl:

* WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:
(WebCore::RegisterProtocolHandlerClientEfl::create): Factory function returning smart pointer.
(WebCore):
* WebCoreSupport/RegisterProtocolHandlerClientEfl.h:
(RegisterProtocolHandlerClientEfl):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Source/WebKit/gtk:

* WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp:
(WebKit::RegisterProtocolHandlerClient::create): Factory function returning smart pointer.
(WebKit):
* WebCoreSupport/RegisterProtocolHandlerClientGtk.h:
(RegisterProtocolHandlerClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
* webkit/webkitwebviewprivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][GTK] Implement a new spell checker API for WebKit2GTK+
mario@webkit.org [Mon, 6 Aug 2012 08:00:02 +0000 (08:00 +0000)]
[WK2][GTK] Implement a new spell checker API for WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=90268

Reviewed by Martin Robinson.

Source/WebKit2:

Add a simple spell checking API to WK2, allowing to enable/disable
this feature and to define a list of languages associated to it.

* GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
* GNUmakefile.list.am: Added new files

Added new internal class that will act both as the implementation
of TextCheckerClient and as the object WebKitWebContext will
depend on to implement the newly added API.

* UIProcess/API/gtk/WebKitTextChecker.cpp: Added.
(toTextChecker):
(continuousSpellCheckingEnabledCallback):
(setContinuousSpellCheckingEnabledCallback):
(checkSpellingOfStringCallback):
(guessesForWordCallback):
(learnWordCallback):
(ignoreWordCallback):
(WebKitTextChecker::~WebKitTextChecker):
(WebKitTextChecker::create):
(WebKitTextChecker::WebKitTextChecker):
(WebKitTextChecker::checkSpellingOfString):
(WebKitTextChecker::getGuessesForWord):
(WebKitTextChecker::learnWord):
(WebKitTextChecker::ignoreWord):
(WebKitTextChecker::setSpellCheckingEnabled):
(WebKitTextChecker::setSpellCheckingLanguages):
* UIProcess/API/gtk/WebKitTextChecker.h: Added.
(WebKitTextChecker):
(WebKitTextChecker::isSpellCheckingEnabled):
(WebKitTextChecker::getSpellCheckingLanguages):

Added WKTextChecker to WebKitPrivate.h, needed in WebKitTextChecker.

* UIProcess/API/gtk/WebKitPrivate.h:

Add new API to WebKitWebContext to allow enabling/disabling this
spell checking feature, and to set/get the list of languages used
to decide which dictionaries will be consulted.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(createDefaultWebContext):
(webkit_web_context_get_spell_checking_enabled): New API.
(webkit_web_context_set_spell_checking_enabled): Ditto.
(webkit_web_context_get_spell_checking_languages): Ditto.
(webkit_web_context_set_spell_checking_languages): Ditto.
* UIProcess/API/gtk/WebKitWebContext.h:

New tests for checking the new API added to WebKitWebContext.

* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSpellChecker):
(beforeAll):

Update documentation with new sections and symbols.

* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:

Ignore WebKitTextChecker.* private files for gtk-doc.

* gtk/generate-gtkdoc:
(get_webkit2_options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline for chromium gardening.
toyoshim@chromium.org [Mon, 6 Aug 2012 07:57:14 +0000 (07:57 +0000)]
Unreviewed, rebaseline for chromium gardening.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

* platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/chromium-mac/fast/css/text-overflow-input-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in WebCore::RenderListItem::updateMarkerLocation
commit-queue@webkit.org [Mon, 6 Aug 2012 07:50:14 +0000 (07:50 +0000)]
Crash in WebCore::RenderListItem::updateMarkerLocation
https://bugs.webkit.org/show_bug.cgi?id=90476

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-06
Reviewed by Abhishek Arya.

Source/WebCore:

In some cases an anonymous block is destroyed when its last child is
removed. RenderListItem did not expect this and has it's own logic for
cleaning up such blocks when the list marker is removed. Detect this
case in RenderBlock::removeChild to defer to the logic in RenderListItem::updateListMarker.

Test: fast/lists/list-marker-remove-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):

LayoutTests:

* fast/lists/list-marker-remove-crash-expected.txt: Added.
* fast/lists/list-marker-remove-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Roll out r124728 because of build bot test fail.
gyuyoung.kim@samsung.com [Mon, 6 Aug 2012 07:33:49 +0000 (07:33 +0000)]
Unreviewed. Roll out r124728 because of build bot test fail.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skip the failing tests.
kkristof@inf.u-szeged.hu [Mon, 6 Aug 2012 07:27:12 +0000 (07:27 +0000)]
[Qt] Unreviewed gardening. Skip the failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: NMI: replace addString with addMember overload function.
loislo@chromium.org [Mon, 6 Aug 2012 07:13:35 +0000 (07:13 +0000)]
Web Inspector: NMI: replace addString with addMember overload function.
https://bugs.webkit.org/show_bug.cgi?id=93201

Reviewed by Yury Semikhatsky.

It is impossible to implement nice instrumentation for template containers
content when we have different function names for different types.

Drive by: fix the most annoing warning in Element.h detected by our clang plugin.

* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
* dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/Element.h:
(WebCore::Element::reportMemoryUsage):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/MemoryInstrumentation.cpp:
(WebCore::MemoryInstrumentation::addObject):
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addMember):
* dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium-win] Use system locale for number representation
tkent@chromium.org [Mon, 6 Aug 2012 06:39:49 +0000 (06:39 +0000)]
[Chromium-win] Use system locale for number representation
https://bugs.webkit.org/show_bug.cgi?id=93085

Reviewed by Hajime Morita.

Source/WebCore:

We have used LocaleICU for number localization (presentation of <input
type=number>) even on Windows. This patch introduces number localization
feature with Windows API to LocaleWin, and we stop using LocaleICU on
Windows.

Tests: Add new test cases to WebKit/chromium/tests/LocaleWinTest.cpp.

* WebCore.gyp/WebCore.gyp:
- Stop using LocaleICU.{cpp,h} and LocalizedNumberICU.cpp.
- Add LocalizedNumberWin.cpp.
* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::LocaleWin):
 - Initialize m_didInitializeNumberData.
 - Use getLocaleInfo() to obtain LOCALE_IFIRSTDAYOFWEEK.
(WebCore::LocaleWin::getLocaleInfo):
Added. A helper to obtain integer locale value.
(WebCore::LocaleWin::initializeNumberLocalizerData):
Added. Prepare data for number localization, and pass it to NumberLocalizer.
* platform/text/LocaleWin.h:
(LocaleWin): Inherit NumberLocalizer, and declare some new members.
* platform/text/win/LocalizedNumberWin.cpp: Added.
(WebCore::convertToLocalizedNumber):
Forward to the corresponding function of LocaleWin.
(WebCore::convertFromLocalizedNumber): ditto.
(WebCore::localizedDecimalSeparator): ditto.

Source/WebKit/chromium:

* WebKit.gypi:
Don't include Localized*ICUTest.cpp in Windows and OSX. They are unnecessary.
* tests/LocaleWinTest.cpp:
(LocaleWinTest): Add some LCID symbols.
(LocaleWinTest::decimalSeparator):
A helper for LocaleWinTest.decimalSeparator.
(TEST_F(LocaleWinTest, decimalSeparator)):
A test for LocaleWin::localizedDecimalSeparator(). This is a copy of the
corresponding test in LocalizedNumberICUTest.cpp.
(testNumberIsReversible):
A test helper LocaleWinTest.localizedNumberRoundTrip. This is a copy of
the corresponding test in LocalizedNumberICUTest.cpp.
(testNumbers): ditto.
(TEST_F(LocaleWinTest, localizedNumberRoundTrip)):
Tests for LocaleWin changes. This is a copy of the corresponding tests
in LocalizedNumberICUTest.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] form tests are flaky, mostly on Linux
yosin@chromium.org [Mon, 6 Aug 2012 06:35:32 +0000 (06:35 +0000)]
[chromium] form tests are flaky, mostly on Linux
https://bugs.webkit.org/show_bug.cgi?id=78620

Unreviewed. Update test expecations for
  fast/forms/formaction-attribute.html
  fast/forms/formmethod-attribute-button-html.html
  fast/forms/formmethod-attribute-input-html.html
based on the latest dashboard.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix assertion during detach of SVG wrappers without baseVal
pdr@google.com [Mon, 6 Aug 2012 06:31:39 +0000 (06:31 +0000)]
Fix assertion during detach of SVG wrappers without baseVal
https://bugs.webkit.org/show_bug.cgi?id=93063

Reviewed by Nikolas Zimmermann.

Source/WebCore:

r131583 introduced a change where SVGAnimatedListPropertyTearOff required
a baseVal to be set before detaching wrappers. This caused an assertion
to be hit if no baseVal was set.
This patch changes this behavior so that wrappers are detached even if
no baseVal is set.

Test: svg/animations/dynamic-modify-transform-without-baseval.html

* svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
* svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::detachListWrappersAndResize): Extracted this static method for detaching wrappers without needing an SVGListProperty.
(SVGListProperty):
(WebCore::SVGListProperty::detachListWrappers):

LayoutTests:

* svg/animations/dynamic-modify-transform-without-baseval-expected.txt: Added.
* svg/animations/dynamic-modify-transform-without-baseval.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove DeviceMotionEvent.h and DeviceOrientationEvent.h from Document.cpp
commit-queue@webkit.org [Mon, 6 Aug 2012 06:09:14 +0000 (06:09 +0000)]
Remove DeviceMotionEvent.h and DeviceOrientationEvent.h from Document.cpp
https://bugs.webkit.org/show_bug.cgi?id=93224

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-05
Reviewed by Kentaro Hara.

Need to remove DeviceMotionEvent.h and DeviceOrientationEvent.h from Document.cpp.
They are not used anymore in that file.

No new tests. No change in behavior.

* dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] fast/forms/focus2.html fails
yosin@chromium.org [Mon, 6 Aug 2012 05:10:53 +0000 (05:10 +0000)]
[chromium] fast/forms/focus2.html fails
https://bugs.webkit.org/show_bug.cgi?id=45061

Unreviewed. Chromium DRT sets tabsToLink to false. So, Chrimium DRT doesn't set focus to anchor.

* platform/chromium/TestExpectations: Removed fast/forms/focus2.html
* platform/chromium/fast/forms/focus2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMAKE] Move media source files from #ifdef ENABLE(MEDIA_SOURCE) to existing file...
gyuyoung.kim@samsung.com [Mon, 6 Aug 2012 03:27:18 +0000 (03:27 +0000)]
[CMAKE] Move media source files from #ifdef ENABLE(MEDIA_SOURCE) to existing file list
https://bugs.webkit.org/show_bug.cgi?id=93219

Reviewed by Hajime Morita.

r122688 removed duplicating #ifdef guards from CMakeLists.txt. But, ENABLE_MEDIA_SOURCE is added to
CMakeList using duplicating #ifdef again.

No new tests. No change in behavior.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [JSC] implement setting breakpoints by line:column
commit-queue@webkit.org [Mon, 6 Aug 2012 03:16:46 +0000 (03:16 +0000)]
Web Inspector: [JSC] implement setting breakpoints by line:column
https://bugs.webkit.org/show_bug.cgi?id=53003

Source/JavaScriptCore:

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05
Reviewed by Geoffrey Garen.

Add a counter to Lexer to record the column info of each Token. Add a column parameter to
op_debug, cti_op_debug, and _llint_op_debug byte-code command.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::emitDebugHook):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
* debugger/Debugger.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(Interpreter):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter.asm:
* parser/ASTBuilder.h:
(ASTBuilder):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
* parser/Lexer.h:
(Lexer):
(JSC::Lexer::currentColumnNumber):
(JSC::::lexExpectIdentifier):
* parser/NodeConstructors.h:
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):
* parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(Node):
(JSC::Node::columnNo):
(ExpressionNode):
(StatementNode):
(JSC::StatementNode::column):
(NullNode):
(BooleanNode):
(NumberNode):
(StringNode):
(RegExpNode):
(ThisNode):
(ResolveNode):
(ArrayNode):
(PropertyListNode):
(ObjectLiteralNode):
(BracketAccessorNode):
(DotAccessorNode):
(ArgumentListNode):
(NewExprNode):
(EvalFunctionCallNode):
(FunctionCallValueNode):
(FunctionCallResolveNode):
(FunctionCallBracketNode):
(FunctionCallDotNode):
(CallFunctionCallDotNode):
(ApplyFunctionCallDotNode):
(PrePostResolveNode):
(PostfixResolveNode):
(PostfixBracketNode):
(PostfixDotNode):
(PostfixErrorNode):
(DeleteResolveNode):
(DeleteBracketNode):
(DeleteDotNode):
(DeleteValueNode):
(VoidNode):
(TypeOfResolveNode):
(TypeOfValueNode):
(PrefixResolveNode):
(PrefixBracketNode):
(PrefixDotNode):
(PrefixErrorNode):
(UnaryOpNode):
(UnaryPlusNode):
(NegateNode):
(BitwiseNotNode):
(LogicalNotNode):
(BinaryOpNode):
(MultNode):
(DivNode):
(ModNode):
(AddNode):
(SubNode):
(LeftShiftNode):
(RightShiftNode):
(UnsignedRightShiftNode):
(LessNode):
(GreaterNode):
(LessEqNode):
(GreaterEqNode):
(ThrowableBinaryOpNode):
(InstanceOfNode):
(InNode):
(EqualNode):
(NotEqualNode):
(StrictEqualNode):
(NotStrictEqualNode):
(BitAndNode):
(BitOrNode):
(BitXOrNode):
(LogicalOpNode):
(ConditionalNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(ReadModifyBracketNode):
(AssignBracketNode):
(AssignDotNode):
(ReadModifyDotNode):
(AssignErrorNode):
(CommaNode):
(ConstDeclNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ScopeNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncExprNode):
(FuncDeclNode):
(SwitchNode):
* parser/Parser.cpp:
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
* parser/Parser.h:
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::tokenLocation):
(Parser):
(JSC::Parser::getTokenName):
(JSC::::parse):
* parser/ParserTokens.h:
(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):
(JSToken):
* parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::closeBraceToken):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):

Source/WebCore:

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05
Reviewed by Geoffrey Garen.

Since JSC can provide column info now, ScriptDebugServer can use it to support "Pretty Print"
debug mode. The related interfaces derived from JSC::Debugger was added a parameter.

No new tests for this patch.

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore):
(WebCore::ScriptDebugServer::updateCurrentStatementPosition):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
* bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):

Source/WebKit/mac:

Unreviewed, just changed the interface according the changes of base class JSC::Debugger.

No JSC can provide the column info of current JS statement, mac porting can use it to support
"Pretty Print" debug mode.

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05

* WebView/WebScriptDebugger.h:
(WebScriptDebugger):
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::exception):
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
(WebScriptDebugger::didReachBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Change my email address for watch list.
gyuyoung.kim@samsung.com [Mon, 6 Aug 2012 02:45:51 +0000 (02:45 +0000)]
Unreviewed. Change my email address for watch list.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test expectation updates.
ukai@chromium.org [Mon, 6 Aug 2012 02:40:39 +0000 (02:40 +0000)]
Unreviewed test expectation updates.

* platform/chromium/TestExpectations: assign bug for fast/text/international/bold-bengali.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable fast/css/variables tests by default for chromium.
macpherson@chromium.org [Mon, 6 Aug 2012 02:35:53 +0000 (02:35 +0000)]
Enable fast/css/variables tests by default for chromium.
https://bugs.webkit.org/show_bug.cgi?id=92610

Reviewed by Tony Chang.

Since variables are now compiled in by default on chromium there is no reason not to run these tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
joone@webkit.org [Mon, 6 Aug 2012 01:50:27 +0000 (01:50 +0000)]
Unreviewed EFL gardening.

Marked the following test cases as known failures
tracked by the bug 93213, 93214, 92956, 93212.

fast/text/international/text-spliced-font.html
http/tests/loading/307-after-303-after-post.html
http/tests/security/contentSecurityPolicy/object-src-url-blocked.html
http/tests/incremental/slow-utf8-text.pl

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssert in checkValidity() in hashtable.h from WebGeolocationManager::didFailToDetermi...
benjamin@webkit.org [Mon, 6 Aug 2012 01:36:00 +0000 (01:36 +0000)]
Assert in checkValidity() in hashtable.h from WebGeolocationManager::didFailToDeterminePosition() when fetching html5demos.com/geo
https://bugs.webkit.org/show_bug.cgi?id=80386

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-05
Reviewed by Alexey Proskuryakov.

Source/WebKit2:

WebKit2's WebGeolocationManager was delivering events without accounting that each event
can modify the list of page that need delivery.
Any page can remove itself by invoking clearWatch() from the callback function. A page can also cause another
page to be removed.

This patch solves the issue by taking a copy of the list of page before delivery. Each page is
referenced as it can be deleted during the delivery.

Unfortunately, this cannot be tested due to missing features of WebKitTestRunner.

* WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

LayoutTests:

Add tests for clearing the Geolocation as a listener from a callback originated from the GeolocationController.

* fast/dom/Geolocation/error-clear-watch-expected.txt: Added.
* fast/dom/Geolocation/error-clear-watch.html: Added.
* fast/dom/Geolocation/success-clear-watch-expected.txt: Added.
* fast/dom/Geolocation/success-clear-watch.html: Added.
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix null pointer dereference when CSSParser::sinkFloatingValueList() returns null...
macpherson@chromium.org [Mon, 6 Aug 2012 01:22:40 +0000 (01:22 +0000)]
Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is passed to storeVariableDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=92461

Reviewed by Eric Seidel.

Source/WebCore:

Invalid variable lists could cause CSSGrammar.y to pass null as value to storeVariableDeclaration, so we now check for null.

Test: fast/css/variables/invalid-value-list-crash.html

* css/CSSParser.cpp:
(WebCore::CSSParser::storeVariableDeclaration):

LayoutTests:

Test case that causes CSSParser::storeVariableDeclaration to be passed a null value.

* fast/css/variables/invalid-value-list-crash-expected.txt: Added.
* fast/css/variables/invalid-value-list-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Updte text expectation.
tkent@chromium.org [Mon, 6 Aug 2012 01:19:58 +0000 (01:19 +0000)]
[Chromium] Updte text expectation.

Remove an entry for media/media-fragments/TC0010-TC0019.html.
It doesn't exist any more.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium-win] Use the default locale only if the browser locale matches to it
tkent@chromium.org [Mon, 6 Aug 2012 01:12:43 +0000 (01:12 +0000)]
[Chromium-win] Use the default locale only if the browser locale matches to it
https://bugs.webkit.org/show_bug.cgi?id=93083

Reviewed by Hajime Morita.

For a calendar picker, we have used month names and day-of-week names
obtained from the OS default locale. However, the year-month format and
[Today] [Clear] labels are decided with the browser locale. It made
calendar pickers with mixed languages.

To make calendar pickers with a single language, we use the OS default
locale only if the browser locale matches to it.
This patch changes the behavior for Windows Vista or later. No change
for Windows XP because of API support limitation.

No new tests.  Behavior for locale setting is not testable in WebKit.

* platform/text/LocaleWin.cpp:
(determineCurrentLCID):
Added. If the system has no LocaleNameToLCID API, just returns
LOCALE_USER_DEFAULT. Otherwise, if the system locale matches to the
browser locale, it returns LOCALE_USER_DEFAULT, otherwise it returns the
LCID for the browser locale.
(WebCore::LocaleWin::currentLocale): Uses determineCurrentLCID().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't reuse cached stylesheet with failed or canceled resource loads
antti@apple.com [Sun, 5 Aug 2012 21:03:42 +0000 (21:03 +0000)]
Don't reuse cached stylesheet with failed or canceled resource loads
https://bugs.webkit.org/show_bug.cgi?id=93203

Reviewed by Simon Fraser.

1) Go to apple.com
2) Reload repeatedly

Eventually you can get into state where some images don't load.

The problem is that a cached stylesheet may end up pointing to image resources that have been canceled (by the reload).
If this happens they stay in the canceled state even when the stylesheet is applied to a new document.

Fix by checking if all loads are complete (or pending) when restoring a cached stylesheet. The sheet is only used
if there are no failed or canceled loads. There are potential more sophisticated fixes but this is simple and safe.
Walking the sheet is fast and since it is only done on cache restore the cost is minimal.

No regression test yet though the new code does get exercised by the existing tests.

* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::hasFailedOrCanceledSubresources):
(WebCore):
* css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::hasFailedOrCanceledSubresources):
(WebCore):
* css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::hasFailedOrCanceledSubresources):
(WebCore):
* css/CSSImageSetValue.h:
(CSSImageSetValue):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::hasFailedOrCanceledSubresources):
(WebCore):
* css/CSSImageValue.h:
(CSSImageValue):
* css/CSSValue.cpp:
(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore):
* css/CSSValue.h:
(CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::hasFailedOrCanceledSubresources):
(WebCore):
* css/CSSValueList.h:
(CSSValueList):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::hasFailedOrCanceledSubresources):
(WebCore):
* css/StylePropertySet.h:
(StylePropertySet):
* css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
(WebCore):
(WebCore::StyleSheetContents::hasFailedOrCanceledSubresources):
* css/StyleSheetContents.h:
(StyleSheetContents):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::loadFailedOrCanceled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WIN] Use sizeof() for cbWndExtra values
paroga@webkit.org [Sun, 5 Aug 2012 20:55:48 +0000 (20:55 +0000)]
[WIN] Use sizeof() for cbWndExtra values
https://bugs.webkit.org/show_bug.cgi?id=93179

Reviewed by Eric Carlson.

Using sizof() instead of hardcoding the pointer size of
the 32bit platform allows us to use the code on 64bit too.

* FullscreenVideoController.cpp:
(FullscreenVideoController::registerHUDWindowClass):
* WebView.cpp:
(WebView::registerWebViewWindowClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Move V8Proxy methods that set DOM attributes/callbacks to V8Binding
haraken@chromium.org [Sun, 5 Aug 2012 18:40:23 +0000 (18:40 +0000)]
[V8] Move V8Proxy methods that set DOM attributes/callbacks to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=93103

Reviewed by Adam Barth.

To remove V8Proxy, we can move V8Proxy methods that set DOM
attributes/callbacks to V8Binding.

No tests. No change in behavior.

* bindings/v8/V8Binding.cpp:
(WebCore::batchConfigureAttributes):
(WebCore):
(WebCore::batchConfigureCallbacks):
(WebCore::batchConfigureConstants):
* bindings/v8/V8Binding.h:
(BatchedAttribute):
(WebCore):
(WebCore::configureAttribute):
(BatchedConstant):
(BatchedCallback):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agomedia/video-poster-blocked-by-willsendrequest.html isn't blocking poster on willsendr...
fischman@chromium.org [Sun, 5 Aug 2012 16:28:42 +0000 (16:28 +0000)]
media/video-poster-blocked-by-willsendrequest.html isn't blocking poster on willsendrequest
https://bugs.webkit.org/show_bug.cgi?id=92824

Reviewed by Ryosuke Niwa.

Chromium/Mac/GTK DRTs appear not to clear the cache between tests so append a unique query-string param to avoid a cache hit in this test.
Filed 93195 for the chromium port, Mac has 82976, and GTK has 79760.

* media/video-poster-blocked-by-willsendrequest.html:
* platform/chromium/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Remove V8Proxy::registerExtensionWithV8()
haraken@chromium.org [Sun, 5 Aug 2012 15:39:28 +0000 (15:39 +0000)]
[V8] Remove V8Proxy::registerExtensionWithV8()
https://bugs.webkit.org/show_bug.cgi?id=93115

Reviewed by Adam Barth.

V8Proxy::registerExtensionWithV8() is used by V8Proxy::registerExtension()
only. We can remove the redundant method.

In a follow-up patch, I will implement V8Proxy::registerExtentionIfNeeded()
and remove registerExtensionWithV8() and registerExtension().

No tests. No change in behavior.

* bindings/v8/V8Proxy.cpp:
(WebCore::staticExtensionsList): Just moved to near related methods.
(WebCore):
(WebCore::V8Proxy::extensions):
(WebCore::V8Proxy::registerExtension):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Remove unused enum and typedefs in V8Proxy
haraken@chromium.org [Sun, 5 Aug 2012 15:37:01 +0000 (15:37 +0000)]
[V8] Remove unused enum and typedefs in V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93105

Reviewed by Adam Barth.

In preparation for removing V8Proxy, we can remove unused enum
and typedefs in V8Proxy.

No tests. No change in behavior.

* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
(WebCore::throwError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with...
mitz@apple.com [Sun, 5 Aug 2012 05:55:05 +0000 (05:55 +0000)]
<rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
https://bugs.webkit.org/show_bug.cgi?id=91348

Reviewed by Andy Estes.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged): Changed to call notifyContentAreaScrolled()
only if the scroll position after the change differs from what it was before the change.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollPosition): Added an override of this ScrollableArea function.
* rendering/RenderListBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLMediaElement may fire the seeked event before currentTime reaches the seek time
fischman@chromium.org [Sun, 5 Aug 2012 03:23:50 +0000 (03:23 +0000)]
HTMLMediaElement may fire the seeked event before currentTime reaches the seek time
https://bugs.webkit.org/show_bug.cgi?id=92881

Reviewed by Eric Carlson.

Source/WebCore:

Testing provided by media/video-seek-past-end-paused.html, hopefully demonstrating lack of redness on all ports/bots this time.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): don't finishSeek() until the media player is no longer seeking.

LayoutTests:

This is mostly a re-land of r114005, alongside a fix for HTMLMediaElement.

* media/video-seek-past-end-paused-expected.txt:
* media/video-seek-past-end-paused.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium Mac] Tests are exiting early due to failures to load missingImage.png
thakis@chromium.org [Sun, 5 Aug 2012 02:30:53 +0000 (02:30 +0000)]
[Chromium Mac] Tests are exiting early due to failures to load missingImage.png
https://bugs.webkit.org/show_bug.cgi?id=93186

Reviewed by Ryosuke Niwa.

Add missingImage.png to DumpRenderTree.app's Resource folder.
Depends on http://crrev.com/150037 rolling into webkit first.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
rniwa@webkit.org [Sun, 5 Aug 2012 02:13:37 +0000 (02:13 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-04

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother test fix after r124708.
rniwa@webkit.org [Sun, 5 Aug 2012 01:24:06 +0000 (01:24 +0000)]
Another test fix after r124708.

* platform/mac/editing/selection/word-thai.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline fast/css-grid-layout/place-cell-by-index.html on Qt after r124671
rniwa@webkit.org [Sun, 5 Aug 2012 01:21:16 +0000 (01:21 +0000)]
Rebaseline fast/css-grid-layout/place-cell-by-index.html on Qt after r124671
since the test now passes (yay!).

Skip a test added by r124673 on Qt since it uses gestureTap (tracked by the bug 66272).

* platform/qt/Skipped:
* platform/qt/fast/css-grid-layout: Removed.
* platform/qt/fast/css-grid-layout/place-cell-by-index-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother test fixes after r124705. Revert erroneous changes in r124707 using binary...
rniwa@webkit.org [Sun, 5 Aug 2012 00:44:12 +0000 (00:44 +0000)]
Another test fixes after r124705. Revert erroneous changes in r124707 using binary editor.

* fast/parser/test-unicode-characters-in-attribute-name.html:
* http/tests/misc/submit-post-in-utf16be.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest fixes after r124705. There were still few tests that used layoutTestController...
rniwa@webkit.org [Sun, 5 Aug 2012 00:30:52 +0000 (00:30 +0000)]
Test fixes after r124705. There were still few tests that used layoutTestController because
they were encoded in UTF-16 and UTF-32 and neither spot light nor grep could search through.

* editing/pasteboard/copy-paste-float.html:
* editing/selection/thai-word-at-document-end.html:
* fast/css/hexColor-isDigit-assert.html:
* fast/encoding/bom-in-content-utf16.html:
* fast/encoding/utf-32-big-endian-bom.html:
* fast/encoding/utf-32-big-endian-nobom.xml:
* fast/encoding/utf-32-little-endian-bom.html:
* fast/encoding/utf-32-little-endian-nobom.xml:
* fast/parser/test-unicode-characters-in-attribute-name.html:
* fast/ruby/text-emphasis.html:
* fast/text/offsetForPosition-cluster-at-zero.html:
* http/tests/misc/submit-get-in-utf16be.html:
* http/tests/misc/submit-get-in-utf16le.html:
* http/tests/misc/submit-get-in-utf32be.html:
* http/tests/misc/submit-get-in-utf32le.html:
* http/tests/misc/submit-post-in-utf16be.html:
* http/tests/misc/submit-post-in-utf16le.html:
* http/tests/misc/submit-post-in-utf32be.html:
* http/tests/misc/submit-post-in-utf32le.html:
* http/tests/misc/url-in-utf16be.html:
* http/tests/misc/url-in-utf16le.html:
* http/tests/misc/url-in-utf32be.html:
* http/tests/misc/url-in-utf32le.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTried to fix the Qt Windows build after r124654.
mitz@apple.com [Sat, 4 Aug 2012 23:49:45 +0000 (23:49 +0000)]
Tried to fix the Qt Windows build after r124654.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::glyphForCharacter): Enclosed this function in
#if !(PLATFORM(QT) && !HAVE(QRAWFONT)).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop exposing window.layoutTestController in layout tests in favor of window.testRunner
rniwa@webkit.org [Sat, 4 Aug 2012 22:58:30 +0000 (22:58 +0000)]
Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
https://bugs.webkit.org/show_bug.cgi?id=93173

Reviewed by Adam Barth.

Don't expose window.layoutTestController since all layout tests use window.testRunner
instead of window.layoutTestController as of r124685.

We can safely rename classes and files to use TestRunner once this patch is landed.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::makeWindowObject):
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(notifyTestCompletion):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::waitUntilDone):
(PluginTest::notifyDone):
* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
(ConvertPoint::NPP_SetWindow):
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):
(handleEventCocoa):
(handleEventWin):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initJSObjects):
* Scripts/bencher:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::makeWindowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor SubframeLoader::requestPlugin/loadPlugin for clarity.
commit-queue@webkit.org [Sat, 4 Aug 2012 22:49:18 +0000 (22:49 +0000)]
Refactor SubframeLoader::requestPlugin/loadPlugin for clarity.
https://bugs.webkit.org/show_bug.cgi?id=93138

Patch by Mike West <mkwst@chromium.org> on 2012-08-04
Reviewed by Adam Barth.

SubframeLoader::requestPlugin and SubframeLoader::loadPlugin both do a
variety of checks to determine whether or not a specific resource ought
to instantiate a plugin in a specific context. r124636[1] moved one of
those checks, but there doesn't seem to be a clear way to determine
which checks should be performed where.

This patch refactors the checks out of those two methods for clarity,
moving them all into a new method: SubframeLoader::pluginIsLoadable.
That method requires the resource URL and MIME type, as well as the
`object` or `embed` element that owns this bit of rendering. The URL
and type are used directly to determine availability, while the element
is currently used only to create a renderer on which
setPluginUnavailabilityReason can be called if the plugin is blocked by
Content Security Policy.

This patch introduces no new tests, as it shouldn't change the code's
behavior: it should be a straightforward refactoring without web-visible
side-effects.

[1]: http://trac.webkit.org/changeset/124636

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::pluginIsLoadable):
    A new method that extracts the various 'Should we allow this plugin
    in this context?' checks from requestPlugin and loadPlugin into ine
    location, rather than spreading them across both.
(WebCore):
(WebCore::SubframeLoader::requestPlugin):
(WebCore::SubframeLoader::loadPlugin):
* loader/SubframeLoader.h:
(SubframeLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: filteredItemSelectionDialog.css has wrong selector for highlights
commit-queue@webkit.org [Sat, 4 Aug 2012 22:08:58 +0000 (22:08 +0000)]
Web Inspector: filteredItemSelectionDialog.css has wrong selector for highlights
https://bugs.webkit.org/show_bug.cgi?id=93168

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-04
Reviewed by Pavel Feldman.

Selector required span to be a child, but highlights are themselves span. Used descendent selector.
No new tests: I'll make one next week, to go with bug 93166

* inspector/front-end/filteredItemSelectionDialog.css:
(.js-outline-dialog > .container > div.item span.highlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse testRunner instead of layoutTestController in performance tests
rniwa@webkit.org [Sat, 4 Aug 2012 21:12:36 +0000 (21:12 +0000)]
Use testRunner instead of layoutTestController in performance tests
https://bugs.webkit.org/show_bug.cgi?id=93184

Reviewed by Adam Barth.

* Animation/balls.html:
* Dromaeo/resources/dromaeorunner.js:
* inspector/console-300-lines.html:
* inspector/inspector-startup-time.html:
* inspector/network-append-30-requests.html.broken:
* inspector/show-panel.html.broken:
* resources/runner.js:
(PerfTestRunner.logInfo):
(PerfTestRunner.initAndStartLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] UI_SIDE_COMPOSITING code has confusing names
noam.rosenthal@nokia.com [Sat, 4 Aug 2012 17:52:35 +0000 (17:52 +0000)]
[Qt] UI_SIDE_COMPOSITING code has confusing names
https://bugs.webkit.org/show_bug.cgi?id=93164

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Renamed and consolidated code guarded under UI_SIDE_COMPOSITING, now under
USE(COORDINATED_GRAPHICS) guard and CoordinatedGraphics folders.

* CMakeLists.txt:
* DerivedSources.pri:
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebLayerTreeInfo.cpp:
* Shared/WebLayerTreeInfo.h:
* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::updatePaintNode):
* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::paint):
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp.
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h: Renamed from Source/WebKit2/UIProcess/texmap/LayerBackingStore.h.
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp: Renamed from Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp.
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h: Renamed from Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.h.
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in: Renamed from Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.messages.in.
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp: Renamed from Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp.
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h: Renamed from Source/WebKit2/UIProcess/WebLayerTreeRenderer.h.
* UIProcess/DrawingAreaProxy.cpp:
(WebKit):
* UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit):
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::ContentsSGNode):
(WebKit::ContentsSGNode::layerTreeRenderer):
(ContentsSGNode):
(WebKit::QtWebPageSGNode::setRenderer):
* UIProcess/qt/QtWebPageSGNode.h:
(WebKit):
(QtWebPageSGNode):
* WebKit2.pri:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scheduleAnimation):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h: Renamed from Source/WebKit2/WebProcess/WebPage/TiledBackingStoreRemoteTile.h.
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp.
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h.
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.messages.in: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.messages.in.
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
* WebProcess/WebPage/UpdateAtlas.cpp:
* WebProcess/WebPage/UpdateAtlas.h:
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):

Source/WTF:

Renamed UI_SIDE_COMPOSITING to COORDINATED_GRAPHICS.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage...
loislo@chromium.org [Sat, 4 Aug 2012 14:23:27 +0000 (14:23 +0000)]
Unreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage clang plugin
Three methods addString, addVectorPtr and addInstrumentedVectorPtr were added to the list of instrumentation methods.

* clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
(clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline Chromium results after r124697
robert@webkit.org [Sat, 4 Aug 2012 11:13:53 +0000 (11:13 +0000)]
Rebaseline Chromium results after r124697

Unreviewed, gardening.

* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Added.
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124699 268f45cc-cd09-0410-ab3c-d52691b4dbfc