WebKit-https.git
5 years agoGenerate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeH...
gyuyoung.kim@samsung.com [Mon, 7 Jul 2014 01:22:33 +0000 (01:22 +0000)]
Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
https://bugs.webkit.org/show_bug.cgi?id=134647

Reviewed by Andreas Kling.

Use type cast macro and generation tag for isFoo() and toFoo() in some MathML classes.

No new tests, no behavior change.

* mathml/MathMLElement.h: Place MathMLElementTypeHelpers.h to the bottom of the
file so that functions from that file can use the Element|Node classes and other things defined in this file.
* mathml/MathMLMencloseElement.h:
(WebCore::toMathMLMencloseElement): Deleted.
* mathml/mathtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS JIT: Ensure resolvingMode size is 1 byte
utatane.tea@gmail.com [Mon, 7 Jul 2014 01:18:17 +0000 (01:18 +0000)]
CSS JIT: Ensure resolvingMode size is 1 byte
https://bugs.webkit.org/show_bug.cgi?id=134662

Reviewed by Benjamin Poulain.

Since selector compiler uses MacroAssembler::branch8 for SelectorChecker::Mode,
we should ensure sizeof(SelectorChecker::Mode) == 1.
Old implementation works only in little endianness environments.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchedResult):
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
* css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::ElementRuleCollector):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
* css/SelectorChecker.h:
* css/StyleInvalidationAnalysis.cpp:
(WebCore::invalidateStyleRecursively):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::pseudoStyleRulesForElement):
* css/StyleResolver.h:
(WebCore::checkRegionSelector):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::jumpIfNotResolvingStyle):
(WebCore::SelectorCompiler::elementIsActiveForStyleResolution):
(WebCore::SelectorCompiler::elementIsHoveredForStyleResolution):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSpeculative fix for: NetworkProcess sometimes hangs under copyDefaultCredentialForPro...
beidson@apple.com [Mon, 7 Jul 2014 00:01:23 +0000 (00:01 +0000)]
Speculative fix for: NetworkProcess sometimes hangs under copyDefaultCredentialForProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=134666

Reviewed by Tim Horton.

* Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::encode): Encode whether or not the query dictionary exists.
(WebKit::SecItemRequestData::decode): Only fail when query dictionary fails to decode if we expect one.

* UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::secItemRequest): If the request is of type Invalid, log an error message asking
  for a bug, and respond with an "invalid parameter" error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't throttle layer flushes when the main resource is a GIF
antti@apple.com [Sun, 6 Jul 2014 20:05:03 +0000 (20:05 +0000)]
Don't throttle layer flushes when the main resource is a GIF
https://bugs.webkit.org/show_bug.cgi?id=134650

Source/WebCore:
<rdar://problem/17490712>

Reviewed by Simon Fraser.

Avoid throttling big image animations.

* page/FrameView.cpp:
(WebCore::determineLayerFlushThrottleState):

    Disable for image documents.

(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayerFlushThrottling):

    Refactor a bit.

* page/LayerFlushThrottleState.h:

    Rename the flag.

Source/WebKit2:

Reviewed by Simon Fraser.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::adjustLayerFlushThrottling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInline NodeListsNodeData helpers more aggressively.
akling@apple.com [Sun, 6 Jul 2014 18:03:06 +0000 (18:03 +0000)]
Inline NodeListsNodeData helpers more aggressively.
<https://webkit.org/b/134654>

Get rid of call overhead costs when retrieving NodeLists and
HTMLCollections from Document. These functions have very few clients,
so there's no real reason to keep them out of line.

Reviewed by Antti Koivisto.

* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInline Node's rare data getters.
akling@apple.com [Sun, 6 Jul 2014 18:01:06 +0000 (18:01 +0000)]
Inline Node's rare data getters.
<https://webkit.org/b/134652>

There was a fair bit of overhead when calling Node::ensureRareData()
from Document's collection getters. This patch inlines the case where
we've already materialized the rare data.

Reviewed by Antti Koivisto.

* dom/Node.cpp:
(WebCore::Node::materializeRareData):
(WebCore::Node::rareData): Deleted.
(WebCore::Node::ensureRareData): Deleted.
* dom/Node.h:
* dom/NodeRareData.h:
(WebCore::Node::rareData):
(WebCore::Node::ensureRareData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] MediaDocument should set a viewport
dino@apple.com [Sun, 6 Jul 2014 00:03:15 +0000 (00:03 +0000)]
[iOS] MediaDocument should set a viewport
https://bugs.webkit.org/show_bug.cgi?id=134658
<rdar://problem/17552339>

Reviewed by Zalan Bujtas.

A MediaDocument should fill the viewport, so set its
initial-scale to 1 and make it non-zoomable.

* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure): Create
a <head> element and a <meta> element with a 1:1 viewport.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r170825.
commit-queue@webkit.org [Sat, 5 Jul 2014 17:56:58 +0000 (17:56 +0000)]
Unreviewed, rolling out r170825.
https://bugs.webkit.org/show_bug.cgi?id=134653

broke debug builds (Requested by kling on #webkit).

Reverted changeset:

"Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS
macro and generateTypeHelpers"
https://bugs.webkit.org/show_bug.cgi?id=134647
http://trac.webkit.org/changeset/170825

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGenerate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeH...
gyuyoung.kim@samsung.com [Sat, 5 Jul 2014 17:36:03 +0000 (17:36 +0000)]
Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
https://bugs.webkit.org/show_bug.cgi?id=134647

Reviewed by Andreas Kling.

Use type cast macro and generation tag for isFoo() and toFoo() in some MathML classes.

No new tests, no behavior change.

* mathml/MathMLElement.h: Place MathMLElementTypeHelpers.h to the bottom of the
file so that functions from that file can use the Element|Node classes and other things defined in this file.
(WebCore::isMathMLElement): Deleted.
* mathml/MathMLMencloseElement.h:
(WebCore::toMathMLMencloseElement): Deleted.
* mathml/mathtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
commit-queue@webkit.org [Sat, 5 Jul 2014 10:29:22 +0000 (10:29 +0000)]
[EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
https://bugs.webkit.org/show_bug.cgi?id=134648

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-05
Reviewed by Gyuyoung Kim.

As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.

* efl/install-dependencies:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Support Geolocation
gyuyoung.kim@samsung.com [Sat, 5 Jul 2014 06:33:16 +0000 (06:33 +0000)]
[EFL] Support Geolocation
https://bugs.webkit.org/show_bug.cgi?id=134439

Reviewed by Antonio Gomes.

.:
* Source/cmake/OptionsEfl.cmake: Turn on ENABLE_GEOLOCATION.

Source/WebCore:
Add geoclue files in order to enable geolocation for EFL port.

* PlatformEfl.cmake:

Tools:
* Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.

LayoutTests:
* platform/efl/TestExpectations: Unskip geolocation tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS JIT: compile :in-range and :out-of-range
benjamin@webkit.org [Sat, 5 Jul 2014 05:25:58 +0000 (05:25 +0000)]
CSS JIT: compile :in-range and :out-of-range
https://bugs.webkit.org/show_bug.cgi?id=134639

Reviewed by Andreas Kling.

The pseudo class :in-range and :out-of-range are trivial non-inlined selectors.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorCheckerTestFunctions.h:
(WebCore::isInRange):
(WebCore::isOutOfRange):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar...
commit-queue@webkit.org [Sat, 5 Jul 2014 04:28:02 +0000 (04:28 +0000)]
[EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
https://bugs.webkit.org/show_bug.cgi?id=134485

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-07-04
Reviewed by Gyuyoung Kim.

Use script_execute_callback to get selected/highlighted text and show in search bar.

* MiniBrowser/efl/main.c:
(script_execute_callback):
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFast path for jsStringWithCache() when asked for the same string repeatedly.
akling@apple.com [Sat, 5 Jul 2014 03:36:36 +0000 (03:36 +0000)]
Fast path for jsStringWithCache() when asked for the same string repeatedly.
<https://webkit.org/b/134635>

Source/JavaScriptCore:
Also moved the whole thing from WebCore to JavaScriptCore since it
makes more sense here, and inline the lightweight checks, leaving only
the hashmap stuff out of line.

Reviewed by Darin Adler.

* runtime/JSString.cpp:
(JSC::jsStringWithCacheSlowCase):
* runtime/JSString.h:
(JSC::jsStringWithCache):
* runtime/VM.h:

Source/WebCore:
Reviewed by Darin Adler.

* WebCore.exp.in:
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringWithCache): Deleted.
* bindings/js/JSDOMBinding.h:
(WebCore::JSValueTraits<String>::arrayJSValue):
(WebCore::jsStringWithCache): Deleted.
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertNPVariantToValue):
* loader/cache/CachedResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSubpixel rendering: ebay.com rotating billboard on the main page has cut off buttons.
zalan@apple.com [Sat, 5 Jul 2014 03:03:01 +0000 (03:03 +0000)]
Subpixel rendering: ebay.com rotating billboard on the main page has cut off buttons.
https://bugs.webkit.org/show_bug.cgi?id=134636
<rdar://problem/17529112>

Reviewed by Darin Adler.

Missing pixel snapping when clipping the transparency layer for BackgroundBleedUseTransparencyLayer.
Clipping needs to take the same snapping strategy as the rest of the painting code.

Source/WebCore:
Test: fast/borders/border-radius-on-subpixel-position-non-hidpi.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):

LayoutTests:
* fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html: Added.
* fast/borders/border-radius-on-subpixel-position-non-hidpi.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoQualifiedName should use RefPtr<QualifiedNameImpl> internally.
akling@apple.com [Sat, 5 Jul 2014 01:29:55 +0000 (01:29 +0000)]
QualifiedName should use RefPtr<QualifiedNameImpl> internally.
<https://webkit.org/b/132796>

We were not inlining ~QualifiedName() and it was showing up in some
profiles (over 1% on dom-attr.html.)

This patch modernizes QualifiedName a bit by using RefPtr to store
the QualifiedNameImpl instead of doing manual ref() and deref()
in out-of-line functions.

Reviewed by Darin Adler.

* WebCore.exp.in:
* dom/QualifiedName.cpp:
(WebCore::QNameComponentsTranslator::translate):
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::~QualifiedName): Deleted.
(WebCore::QualifiedName::deref): Deleted.
* dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::create):
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::isHashTableDeletedValue):
(WebCore::QualifiedName::~QualifiedName):
(WebCore::QualifiedName::operator=):
(WebCore::QualifiedName::impl):
(WebCore::QualifiedName::ref): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] [Media] Prevent page zoom if it started in the video element
dino@apple.com [Fri, 4 Jul 2014 23:03:24 +0000 (23:03 +0000)]
[iOS] [Media] Prevent page zoom if it started in the video element
https://bugs.webkit.org/show_bug.cgi?id=134640
<rdar://problem/16630794>

Reviewed by Sam Weinig.

In r170572 I attempted to prevent the page zoom from happening
when the user was attempting to fullscreen the video. That fix was
not complete, because it relied on the touchstart event being
sent before a gesture event. It turns out this doesn't always happen,
so we need to apply the same check in the gesture event - if the
gesture began with two fingers on the media, don't do a page zoom.
The exception is zooming out, if you've managed to make the video
cover the entire screen (also, the pinch-out-of-fullscreen gesture
does not get handled by WebKit).

* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handleBaseGestureChange): Add a check to
make sure our pinch didn't start in the video element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2]Fix build break in EFL WK2
ryuan.choi@samsung.com [Fri, 4 Jul 2014 22:27:14 +0000 (22:27 +0000)]
[EFL][WK2]Fix build break in EFL WK2
https://bugs.webkit.org/show_bug.cgi?id=134629

Unreviewed build fix.

Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-07-04

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::scheduleCompositingLayerFlushImmediately):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CoordinatedGraphics] Use the C++11 syntax to clean-up for loops
commit-queue@webkit.org [Fri, 4 Jul 2014 22:26:09 +0000 (22:26 +0000)]
[CoordinatedGraphics] Use the C++11 syntax to clean-up for loops
https://bugs.webkit.org/show_bug.cgi?id=134594

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2014-07-04
Reviewed by Darin Adler.

Convert a couple of loops to range-based for

No change in functionality, no new tests.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::purgeBackingStores):
* platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStore::removeAllTiles):
(WebCore::CoordinatedBackingStore::paintToTextureMapper):
(WebCore::CoordinatedBackingStore::drawBorder):
(WebCore::CoordinatedBackingStore::drawRepaintCounter):
(WebCore::CoordinatedBackingStore::commitTileOperations):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
(WebCore::CoordinatedGraphicsScene::commitPendingBackingStoreOperations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix after r170811.
mitz@apple.com [Fri, 4 Jul 2014 21:54:48 +0000 (21:54 +0000)]
Build fix after r170811.

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController reload:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Cocoa] -[WKWebView _reload] is unused
mitz@apple.com [Fri, 4 Jul 2014 21:00:41 +0000 (21:00 +0000)]
[Cocoa] -[WKWebView _reload] is unused
https://bugs.webkit.org/show_bug.cgi?id=134638

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _reload]): Deleted.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Take TopContentInset into account when sending dictionary lookup point to Plugi...
timothy_horton@apple.com [Fri, 4 Jul 2014 20:49:47 +0000 (20:49 +0000)]
[WK2] Take TopContentInset into account when sending dictionary lookup point to PluginView
https://bugs.webkit.org/show_bug.cgi?id=134624
<rdar://problem/17222041>

Reviewed by Sam Weinig.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
Perform the same coordinate conversion we use for mouse events, which happens
to take the top content inset into account.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCTTE: ScriptElement always has a HTTPScriptElement or SVGScriptElement.
akling@apple.com [Fri, 4 Jul 2014 19:54:43 +0000 (19:54 +0000)]
CTTE: ScriptElement always has a HTTPScriptElement or SVGScriptElement.
<https://webkit.org/b/134637>

Have ScriptElement store the pointer to the more specific subclass
element as a reference. Also made the constructor protected since
nobody should instantiate ScriptElement directly.

Reviewed by Antti Koivisto.

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::childrenChanged):
(WebCore::ScriptElement::dispatchErrorEvent):
(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::notifyFinished):
(WebCore::ScriptElement::ignoresLoadRequest):
(WebCore::ScriptElement::scriptContent):
* dom/ScriptElement.h:
(WebCore::ScriptElement::element):
* dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::HTMLScriptElement):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoinput type=range element should only fire change events after committing a value
commit-queue@webkit.org [Fri, 4 Jul 2014 19:12:25 +0000 (19:12 +0000)]
input type=range element should only fire change events after committing a  value
https://bugs.webkit.org/show_bug.cgi?id=134545

Patch by Julien Quint <pom@graougraou.com> on 2014-07-04
Reviewed by Dean Jackson.

Source/WebCore:
A "change" event was fired every time the slider thumb element was dragged
by the user. The "change" event is now fired only after the thumb
element has stopped moving; previously, both "input" and "change" events
where dispatched while changes were being made. This new behavior is
consistent with the specification (cf.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#event-input-change),
as well as other implementations such as Firefox and Chrome.

* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls): Listen to the "input" event
rather than the "change" event for the timeline control in order to
keep track of value changes when the user is dragging the thumb.
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::setValue): Dispatch "change" event while
setting the new value rather than dispatching later, since setting the
value now clears the change flag.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::setValue): Update the text value of the
control in the case when no event is to be dispatched, so that this
value can be checked the next time a "change" event dispatch is
requested.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint): Removed the
dispatch of the "change" event, and no longer track the text value of
the element as a result of dispatching a "change" event.
(WebCore::SliderThumbElement::stopDragging): Dispatch the "change" event
on completing the drag.

LayoutTests:
Two existing tests are updated to count "input" events as well as
"change" events. The tests now verify that "change" is only fired once
after every slider drag completes, whereas "input" may be fired more
than once.

* fast/forms/range/range-drag-expected.txt:
* fast/forms/range/range-drag-when-toggled-disabled-expected.txt:
* fast/forms/range/range-drag-when-toggled-disabled.html:
* fast/forms/range/range-drag.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCTTE: ApplicationCacheHost always has a DocumentLoader.
akling@apple.com [Fri, 4 Jul 2014 18:07:26 +0000 (18:07 +0000)]
CTTE: ApplicationCacheHost always has a DocumentLoader.
<https://webkit.org/b/b/128435>

Have ApplicationCacheHost store the backpointer to its owning
DocumentLoader as a reference.

Reviewed by Sam Weinig.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::ApplicationCacheHost):
(WebCore::ApplicationCacheHost::~ApplicationCacheHost):
(WebCore::ApplicationCacheHost::selectCacheWithoutManifest):
(WebCore::ApplicationCacheHost::selectCacheWithManifest):
(WebCore::ApplicationCacheHost::maybeLoadMainResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError):
(WebCore::ApplicationCacheHost::failedLoadingMainResource):
(WebCore::ApplicationCacheHost::finishedLoadingMainResource):
(WebCore::ApplicationCacheHost::maybeLoadResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):
(WebCore::ApplicationCacheHost::maybeLoadSynchronously):
(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::stopDeferringEvents):
(WebCore::ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::update):
(WebCore::ApplicationCacheHost::swapCache):
(WebCore::ApplicationCacheHost::abort):
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
* loader/appcache/ApplicationCacheHost.h:
(WebCore::ApplicationCacheHost::documentLoader): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobuildAccessibilityTree() needs to be removed from individual layout tests
mario.prada@samsung.com [Fri, 4 Jul 2014 15:31:57 +0000 (15:31 +0000)]
buildAccessibilityTree() needs to be removed from individual layout tests
https://bugs.webkit.org/show_bug.cgi?id=95286

Reviewed by Chris Fleizach.

Extracted two functions to 'dump' and 'touch' the accessibility
hierarchies out of different layout tests and into a single file,
living in LayoutTests/resources/accessibility-helper.js

* resources/accessibility-helper.js: Added.
(dumpAccessibilityTree): New, based on buildAccessibilityTree()
for the cases where it was used to actually 'dump' it into the output.
(touchAccessibilityTree): Same, but for the cases where we don't
want to dump the accessibility tree, just to make sure is generated.

Updated affected layout tests to use the newly added helper functions.

* accessibility/adjacent-continuations-cause-assertion-failure.html: Updated.
* accessibility/children-changed-sends-notification.html: Ditto.
* accessibility/deleting-iframe-destroys-axcache.html: Ditto.
* accessibility/div-within-anchors-causes-crash.html: Ditto.
* accessibility/first-letter-text-transform-causes-crash.html: Ditto.
* accessibility/image-map-update-parent-crash.html: Ditto.
* accessibility/table-with-empty-thead-causes-crash.html: Ditto.
* platform/efl/accessibility/media-emits-object-replacement.html: Ditto.
* platform/gtk/accessibility/entry-and-password.html: Ditto.
* platform/gtk/accessibility/media-emits-object-replacement.html: Ditto.
* platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Ditto.

Updated Mac specific expectations not to print the "End of test" element.

* platform/mac-wk2/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated.
* platform/mac/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Ditto.
* platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Ditto.
* platform/mac/accessibility/div-within-anchors-causes-crash-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r159345): Lines are clipped between pages when printing web content from...
antti@apple.com [Fri, 4 Jul 2014 13:55:55 +0000 (13:55 +0000)]
REGRESSION(r159345): Lines are clipped between pages when printing web content from Safari
https://bugs.webkit.org/show_bug.cgi?id=134633

Source/WebCore:
<rdar://problem/17088936>

Reviewed by Zalan Bujtas.

Test: printing/simple-lines-break.html

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

    Disable simple lines if global pagination is enabled.
    Printing does not currently use flow threads which we already test for.

LayoutTests:

Reviewed by Zalan Bujtas.

* printing/simple-lines-break-expected.html: Added.
* printing/simple-lines-break.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTypo in watchlist config means four specific people get Cc'd on everything
timothy_horton@apple.com [Fri, 4 Jul 2014 10:33:24 +0000 (10:33 +0000)]
Typo in watchlist config means four specific people get Cc'd on everything
https://bugs.webkit.org/show_bug.cgi?id=134626

Reviewed by Gyuyoung Kim.

* Scripts/webkitpy/common/config/watchlist:
Remove leading pipe, which meant that this rule matched everything!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago2014-07-04 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 4 Jul 2014 09:58:22 +0000 (09:58 +0000)]
2014-07-04  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK WK2 build fix after r170787.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scheduleCompositingLayerFlushImmediately):
        * WebProcess/WebPage/DrawingAreaImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/WebCore: Unreviewed. Fixing the build after r170795.
zandobersek@gmail.com [Fri, 4 Jul 2014 08:50:56 +0000 (08:50 +0000)]
Source/WebCore: Unreviewed. Fixing the build after r170795.

Mac didn't like that change as it seems to properly typedef long long to int64_t.
That's not the case on 64-bit Linux (for some reason), so I'm changing the type of
the two long long variables in FormDataElement to int64_t to avoid any further trouble.

* platform/network/FormData.h:

Source/WebKit2: Unreviewed. Reverting the bad changes introduced in r170795.

* Platform/IPC/ArgumentDecoder.cpp:
(IPC::ArgumentDecoder::decode): Deleted.
* Platform/IPC/ArgumentDecoder.h:
* Platform/IPC/ArgumentEncoder.cpp:
(IPC::ArgumentEncoder::encode): Deleted.
* Platform/IPC/ArgumentEncoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Fixing the build for ports on 64-bit Linux.
zandobersek@gmail.com [Fri, 4 Jul 2014 08:23:44 +0000 (08:23 +0000)]
Unreviewed. Fixing the build for ports on 64-bit Linux.

Add IPC encoding and decoding overloads for the long long type, needed
after r170755 started encoding and decoding long long variables in
FormDataElement.

* Platform/IPC/ArgumentDecoder.cpp:
(IPC::ArgumentDecoder::decode):
* Platform/IPC/ArgumentDecoder.h:
* Platform/IPC/ArgumentEncoder.cpp:
(IPC::ArgumentEncoder::encode):
* Platform/IPC/ArgumentEncoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] Black web view after un-suspending process
timothy_horton@apple.com [Fri, 4 Jul 2014 07:10:10 +0000 (07:10 +0000)]
[iOS][WK2] Black web view after un-suspending process
https://bugs.webkit.org/show_bug.cgi?id=134623
<rdar://problem/17513223>

Reviewed by Simon Fraser.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
Add an argument to viewStateDidChange that allows callers (-[WKContentView _applicationWillEnterForeground:])
to force us to wait for a synchronous reply from the Web process after performing a view state change.

(WebKit::WebPageProxy::dispatchViewStateChange):
Move the has-been-in-window-and-now-is-newly-in-window check into dispatchViewStateChange.
Adjust the logic surrounding going into/out of window by factoring out the IsInWindow-did-change check, for clarity.

* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _applicationWillEnterForeground:]):
As previously mentioned, wait for a reply when foregrounding.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlushImmediately):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
(WebKit::RemoteLayerTreeDrawingArea::viewStateDidChange):
Make sure to schedule a commit immediately if the UI process is waiting for a reply.
Previously we assumed that a commit would be scheduled anyway because we would have to reparent the
layer tree, but that doesn't happen in the suspension-without-unparenting case. Also, we want to skip
all throttling in this case.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlushImmediately):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
commit-queue@webkit.org [Fri, 4 Jul 2014 05:38:20 +0000 (05:38 +0000)]
[EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
https://bugs.webkit.org/show_bug.cgi?id=134486

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-07-03
Reviewed by Gyuyoung Kim.

Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.

* MiniBrowser/efl/main.c:
(search_box_show):
(search_box_hide):
(on_search_close_button_clicked):
(on_search_text_found):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoShould not take background task assertion for NetworkProcess
barraclough@apple.com [Fri, 4 Jul 2014 01:12:45 +0000 (01:12 +0000)]
Should not take background task assertion for NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=134622

Reviewed by Tim Horton.

When the WebContent wants to complete a task in the background we take a process assertion on the child process, and also need to prevent the UI process from suspending.
However for the NetworkProcess we always just hold a process assertion, and don't want this to interfere with UIApp suspension.

* Platform/IPC/mac/ConnectionMac.mm:
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):
    - ProcessAssertion -> ProcessAndUIAssertion
* UIProcess/ProcessAssertion.cpp:
(WebKit::ProcessAssertion::ProcessAssertion):
    - assignment -> initializer list.
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::~ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::setState):
    - added no-op implementation.
(WebKit::ProcessAssertion::~ProcessAssertion): Deleted.
* UIProcess/ProcessAssertion.h:
    - removed ~ProcessAssertion, added ProcessAndUIAssertion class.
* UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::didConnnectToProcess):
    - ProcessAssertion -> ProcessAndUIAssertion
* UIProcess/ProcessThrottler.h:
    - ProcessAssertion -> ProcessAndUIAssertion
* UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::ProcessAssertion):
    - assignment -> initializer list.
    - moved code to manage WKProcessAssertionBackgroundTaskManager
(WebKit::ProcessAssertion::setState):
    - moved code to manage WKProcessAssertionBackgroundTaskManager
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::~ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::setState):
    - moved code to manage WKProcessAssertionBackgroundTaskManager from ProcessAssertion.
(WebKit::ProcessAssertion::~ProcessAssertion): Deleted.
    - delete - moved code to manage WKProcessAssertionBackgroundTaskManager

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up Brady's mess on iOS.
simon.fraser@apple.com [Fri, 4 Jul 2014 01:09:35 +0000 (01:09 +0000)]
Clean up Brady's mess on iOS.

* Platform/mac/StringUtilities.h:
* Platform/mac/StringUtilities.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WK2] Compositing layers draw outside page bounds
simon.fraser@apple.com [Fri, 4 Jul 2014 00:48:14 +0000 (00:48 +0000)]
[iOS WK2] Compositing layers draw outside page bounds
https://bugs.webkit.org/show_bug.cgi?id=134619
<rdar://problem/16953222>

Reviewed by Benjamin Poulain.

With the new rubber-banding behavior, we no longer have the root content layer clipping all
the web layers, but this resulted in web layers which were moved outside the viewport by CSS
transforms not being clipped.

Fix by adding a clipping layer inside the scroll view, above _rootContentView. This layer
normally has the same bounds as the content, but when rubber-banding or pinching,
it takes the union of the content bounds and the rect used for fixed positioning.
To make scrolling work as expected in this scenario, when it has non-zero offset, it
has to compensate by setting its bounds origin.

The bounds of the clipping layer are updated on scrolling/zooming, and when the
layer commit tells us that the content size changed.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateScrollViewBackground]):
* UIProcess/ios/WKContentView.mm:
(-[WKContentView initWithFrame:context:configuration:webView:]):
(-[WKContentView updateFixedClippingView:]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
(-[WKContentView _didCommitLayerTree:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWhen showing the selection menu, include menu options for all selected phone numbers.
beidson@apple.com [Fri, 4 Jul 2014 00:39:41 +0000 (00:39 +0000)]
When showing the selection menu, include menu options for all selected phone numbers.
<rdar://problem/16983434>, <rdar://problem/16874568>, and https://bugs.webkit.org/show_bug.cgi?id=134613

Reviewed by Tim Horton.

Source/WebCore:
* English.lproj/Localizable.strings:

* dom/Range.cpp:
(WebCore::rangesOverlap): Fix reversed arguments that caused some types of overlaps to not be detected.

Source/WebKit2:
Move some telephone number menu logic from WebKitSystemInterface here.
Also provide utility to get just the one menu item relevant to a telephone number.
* Platform/mac/MenuUtilities.h:
* Platform/mac/MenuUtilities.mm: Added.
(WebKit::menuItemForTelephoneNumber):
(WebKit::menuItemsForTelephoneNumber):

* Platform/mac/StringUtilities.h:
* Platform/mac/StringUtilities.mm:
(WebKit::formattedPhoneNumberString): Return a localized formatted phone number.

Add a member to track the selected phone numbers:
* Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::selectedTelephoneNumbers):

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu): Also add menu items for each phone number that is
  in the selection.

Switch away from a WKSI method, and remove a lot of unneeded forward declarations and soft linking:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showTelephoneNumberMenu):
(WebKit::WebPageProxy::showSelectionServiceMenu):

* WebKit2.xcodeproj/project.pbxproj:

* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::drawSelectionHighlight):
(WebKit::ServicesOverlayController::handleClick): Pass the phone numbers along.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleSelectionServiceClick): Pass the phone numbers along.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKProcessAssertionBackgroundTaskManager should clear member if task expires
barraclough@apple.com [Fri, 4 Jul 2014 00:36:07 +0000 (00:36 +0000)]
WKProcessAssertionBackgroundTaskManager should clear member if task expires
https://bugs.webkit.org/show_bug.cgi?id=134618

Reviewed by Anders Carlson.

Failure to do so results in a warning, and could result in us erroneously completing a background task too soon.

* UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
    - remove local variable, _backgroundTask = UIBackgroundTaskInvalid;

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed iOS build fix for r170774.
joepeck@webkit.org [Fri, 4 Jul 2014 00:15:19 +0000 (00:15 +0000)]
Unreviewed iOS build fix for r170774.

Remove some unnecessary WTF::moves on iOS:
error: static_assert failed "T is not an lvalue reference; move() is unnecessary."

* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::getQueuedTouchEventsForPage):
(WebKit::EventDispatcher::touchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry to fix the iOS build.
andersca@apple.com [Fri, 4 Jul 2014 00:08:36 +0000 (00:08 +0000)]
Try to fix the iOS build.

Add WebPageProxyCocoa.mm for code shared between iOS and OS X. Put the recent searches save/restore code there.

* UIProcess/Cocoa/WebPageProxyCocoa.mm: Added.
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
* UIProcess/mac/WebPageProxyMac.mm:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreivewed, fix build break on EFL and GTK since r170767.
gyuyoung.kim@samsung.com [Thu, 3 Jul 2014 23:47:59 +0000 (23:47 +0000)]
Unreivewed, fix build break on EFL and GTK since r170767.

* wtf/CMakeLists.txt: Exclude Decoder.h and Encoder.h because those files were removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVersioning.
lforschler@apple.com [Thu, 3 Jul 2014 23:46:34 +0000 (23:46 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<rdar://problem/16337741> The UI process needs to track the number of HTTP subresourc...
mitz@apple.com [Thu, 3 Jul 2014 23:31:15 +0000 (23:31 +0000)]
<rdar://problem/16337741> The UI process needs to track the number of HTTP subresource loads in progress (or at least whether there are any)
https://bugs.webkit.org/show_bug.cgi?id=134615

Reviewed by Anders Carlsson.

Added a _networkRequestsInProgress boolean property to WKWebView.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm: Added no-op overrides of new
PageLoadStateObserver member functions.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _networkRequestsInProgress]): New getter that gets this state from the
PageLoadState.
* UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared new property.

* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeNetworkRequestsInProgress):: Override this new
PageLoadState::Observer member function by sending the appropriate KVO change message to the
WKWebView.
(WebKit::NavigationState::didChangeNetworkRequestsInProgress): Ditto.

* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Check for changes to networkRequestsInProgress
and call the observers if needed.
(WebKit::PageLoadState::reset): Reset networkRequestsInProgress in the uncommitted state.
(WebKit::PageLoadState::setNetworkRequestsInProgress): Set networkRequestsInProgress in the
uncommitted state.
* UIProcess/PageLoadState.h:
(WebKit::PageLoadState::networkRequestsInProgress): Added this getter.
(WebKit::PageLoadState::Data::Data): Initialize new networkRequestsInProgress member.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setNetworkRequestsInProgress): Added. Updates the PageLoadState.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Added SetNetworkRequestsInProgress message.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): Call
WebPage::addResourceRequest.
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoading): Call
WebPage::removeResourceRequest.
(WebKit::WebFrameLoaderClient::dispatchDidFailLoading): Ditto.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addResourceRequest): Added. If the new request is for an HTTP-family URL,
add its identifier to the set of network resourece request identifiers. If the set was
previously empty, send the WebPageProxy a message.
(WebKit::WebPage::removeResourceRequest): Added. Remove the identifier from the set. If it
becomes empty, send the WebPageProxy a message.
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove two unused functions
andersca@apple.com [Thu, 3 Jul 2014 22:31:26 +0000 (22:31 +0000)]
Remove two unused functions
https://bugs.webkit.org/show_bug.cgi?id=134614

Reviewed by Andreas Kling.

* UIProcess/LegacySessionStateCoding.h:
* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeLegacySessionHistoryEntryData): Deleted.
(WebKit::decodeLegacySessionHistoryEntryData): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd WTF::move()
dbates@webkit.org [Thu, 3 Jul 2014 22:13:54 +0000 (22:13 +0000)]
Add WTF::move()
https://bugs.webkit.org/show_bug.cgi?id=134500

Source/JavaScriptCore:
Rubber-stamped by Anders Carlsson.

Substitute WTF::move() for std::move().

* bytecode/CodeBlock.h:
* bytecode/UnlinkedCodeBlock.cpp:
* bytecompiler/BytecodeGenerator.cpp:
* dfg/DFGGraph.cpp:
* dfg/DFGJITCompiler.cpp:
* dfg/DFGStackLayoutPhase.cpp:
* dfg/DFGWorklist.cpp:
* heap/DelayedReleaseScope.h:
* heap/HeapInlines.h:
[...]

Source/WebCore:
Rubber-stamped by Anders Carlsson.

Substitute WTF::move() for std::move().

* Modules/battery/NavigatorBattery.cpp:
* Modules/encryptedmedia/MediaKeys.cpp:
* Modules/gamepad/NavigatorGamepad.cpp:
* Modules/gamepad/deprecated/NavigatorGamepad.cpp:
* Modules/geolocation/NavigatorGeolocation.cpp:
* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
* Modules/indexeddb/IDBDatabaseBackend.cpp:
* Modules/indexeddb/IDBDatabaseBackend.h:
[...]

Source/WebKit/ios:
Rubber-stamped by Anders Carlsson.

Substitute WTF::move() for std::move().

* WebCoreSupport/WebFixedPositionContent.mm:
(-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
* WebCoreSupport/WebInspectorClientIOS.mm:
(WebInspectorFrontendClient::WebInspectorFrontendClient):

Source/WebKit/mac:
Rubber-stamped by Anders Carlsson.

Substitute WTF::move() for std::move().

* History/WebHistoryItem.mm:
(-[WebHistoryItem initFromDictionaryRepresentation:]):
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
(WebKit::NetscapePluginInstanceProxy::setCurrentReply):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
* WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):

Source/WebKit/win:
Rubber-stamped by Anders Carlsson.

Substitute WTF::move() for std::move().

* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
* WebHistory.cpp:
(createUserInfoFromArray):
* WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
* WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):

Source/WebKit2:
Rubber-stamped by Anders Carlsson.

Substitute WTF::move() for std::move().

* DatabaseProcess/DatabaseProcess.cpp:
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
* Platform/IPC/ArgumentCoders.h:
* Platform/IPC/ArgumentDecoder.cpp:
* Platform/IPC/Connection.cpp:
* Platform/IPC/Connection.h:
[...]

Source/WTF:
Reviewed by Darin Adler.

Substitution of WTF::move() for std::move() rubber-stamped by Anders Carlsson.

Implement WTF::move(), a replacement for std::move(). WTF::move() is less error
prone than std::move() as it compile asserts that its argument is a non-const
lvalue reference before ultimately casting it to a rvalue reference (via std::move).

* wtf/Deque.h: Substitute WTF::move() for std::move().
* wtf/HashMap.h: Ditto.
* wtf/HashSet.h: Ditto.
* wtf/HashTable.h: Ditto.
* wtf/IteratorAdaptors.h: Ditto.
* wtf/IteratorRange.h: Ditto.
* wtf/ListHashSet.h: Ditto.
* wtf/MainThread.cpp: Ditto.
[...]
* wtf/StdLibExtras.h:
(WTF::move): Added.
[...]

Tools:
Rubber-stamped by Anders Carlsson.

Substitute WTF::move() for std::move().

* DumpRenderTree/win/DRTDataObject.cpp:
* TestWebKitAPI/Tests/WTF/HashMap.cpp:
* TestWebKitAPI/Tests/WTF/HashSet.cpp:
* TestWebKitAPI/Tests/WTF/RefPtr.cpp:
* TestWebKitAPI/Tests/WTF/Vector.cpp:
* TestWebKitAPI/Tests/WTF/WTFString.cpp:
* TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
ConstructionFromSameType, and ConstructionFromSimilarType.
* TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inaccuracies...
benjamin@webkit.org [Thu, 3 Jul 2014 22:11:30 +0000 (22:11 +0000)]
[iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inaccuracies in the computed target
https://bugs.webkit.org/show_bug.cgi?id=134582

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-03
Reviewed by Tim Horton.

Source/WebCore:
* WebCore.exp.in:
* platform/ScrollView.h:
(WebCore::ScrollView::unobscuredContentSize):
* platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::unobscuredContentRect):
(WebCore::ScrollView::setUnobscuredContentSize):

Source/WebKit2:
This patch fixes two small bugs that were causing "jumpiness" on animated resize:
1) The new scale was less accurate than the target scale, making the WebProcess force a worse scale on the content.
2) The code putting back the rects in view was ignoring the obscured insets, constraining the scroll position more
   than it should be.

The first problem was cause by a series of rounding issues accumulating to the fact that "scale != targetScale"
was almost never true.

The first issue is that the unobscured content size was stored in integer coordinates. Because of that, it was
impossible to determine accurately how much content is in the view.
The outcome was that visibleHorizontalFraction was very inaccurate compared to what the UIProcess computed.

Another issue affecting the scale is that scaleAfterViewportWidthChange was computing the widthToKeepInView
on floating point. Since ARM64 does all those computations on doubles in the UIProcess, the value would be quite
different from the received targetScale.

Finally, the code uses withinEpsilon() instead of a strict equality to reduce the effect of rounding errors.

For the second issue, the problem was that I was bounding the exposed rect to the page bounds. It is completely
valid to have an exposed rect outside the page bounds, that area is just under the obscured insets.

On the other hand, the unobscured rect needs to be within the bounds as we do not want to rotate to a rubberbanding
position. The fix is simply to put the right rect into bounds, and the horizontal/vertical adjustement applies on
both rects.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::scaleAfterViewportWidthChange):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::updateVisibleContentRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build.
andersca@apple.com [Thu, 3 Jul 2014 21:52:32 +0000 (21:52 +0000)]
Fix build.

* UIProcess/mac/WebPageProxyMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSSA DCE should process blocks in forward order
fpizlo@apple.com [Thu, 3 Jul 2014 21:04:07 +0000 (21:04 +0000)]
SSA DCE should process blocks in forward order
https://bugs.webkit.org/show_bug.cgi?id=134611

Reviewed by Andreas Kling.

* dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
* tests/stress/dead-value-with-mov-hint-in-another-block.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of WebPageProxyCF.cpp
andersca@apple.com [Thu, 3 Jul 2014 21:04:06 +0000 (21:04 +0000)]
Get rid of WebPageProxyCF.cpp
https://bugs.webkit.org/show_bug.cgi?id=134609

Reviewed by Dan Bernstein.

* UIProcess/cf/WebPageProxyCF.cpp: Removed.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of Encoder.h and Decoder.h from WTF
andersca@apple.com [Thu, 3 Jul 2014 20:46:30 +0000 (20:46 +0000)]
Get rid of Encoder.h and Decoder.h from WTF
https://bugs.webkit.org/show_bug.cgi?id=134600

Reviewed by Darin Adler.

* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* WTF.xcodeproj/project.pbxproj:
* wtf/Decoder.h: Removed.
* wtf/Encoder.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJSActivation::symbolTablePut() should invalidate variable watchpoints
fpizlo@apple.com [Thu, 3 Jul 2014 20:22:23 +0000 (20:22 +0000)]
JSActivation::symbolTablePut() should invalidate variable watchpoints
https://bugs.webkit.org/show_bug.cgi?id=134602

Reviewed by Oliver Hunt.

Usually stores to captured variables cause us to invalidate the variable watchpoint because CodeBlock does so
during linking - we essentially assume that if it's at all possible for an inner function to store to a
variable we declare then this variable cannot be a constant. But this misses the dynamic store case, i.e.
JSActivation::symbolTablePut(). Part of the problem here is that JSActivation duplicates
JSSymbolTableObject's symbolTablePut() logic, which did have the invalidation. This patch keeps that code
duplicated, but fixes JSActivation::symbolTablePut() to do the right thing.

* runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTablePut):
* runtime/JSSymbolTableObject.h:
(JSC::symbolTablePut):
* tests/stress/constant-closure-var-with-dynamic-invalidation.js: Added.
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] WebKit1 WebView iframe not responding to scroll gestures
bfulgham@apple.com [Thu, 3 Jul 2014 20:10:33 +0000 (20:10 +0000)]
[Mac] WebKit1 WebView iframe not responding to scroll gestures
https://bugs.webkit.org/show_bug.cgi?id=134569
<rdar://problem/17309008>

Reviewed by Simon Fraser.

Source/WebCore:
New test: platform/mac/fast/scrolling/scroll-iframe-fragment.html

WK1 scrollable areas are implemented on top of PlatformWidget (i.e., NSView) objects. They only
perform a scroll operation if the EventHandler::handleWheelEvent method returns 'false', indicating
that the Cocoa layer should do scrolling work. This is in contrast to WK2, where the scrolling is
handled separately and we return 'true' from EventHandler::handleWheelEvent to indicate that the
scroll event has been handled and that no other work is needed. This mismatch in the meaning of
EventHandler::handleWheelEvent means that WK1 views do not properly handle scroll wheel events.

To correct this, we need to see if we are acting on an Element backed by a PlatformWidget. When we
are (the WK1 case) we want to return 'false' to instruct the Cocoa object to do the scroll operation.
To implement proper latching behavior in WK1, we must return 'true' in the case where we are latched
to a PlatformWidget, and that PlatformWidget did not start the scroll gesture at the edge of
the region in the dominant scroll direction.

Finally, additional logic was needed to determine whether the PlatformWidget is scrolled to the
edge in the dominant scroll direction.

* page/EventHandler.cpp:
(WebCore::EventHandler::platformCompleteWheelEvent): Added stub.
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Added stub.
(WebCore::EventHandler::handleWheelEvent): Call new platformCompletePlatformWidgetWheelEvent if the
event was handled for a PlatformWidget.
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
(WebCore::widgetForEventTarget): Added helper function.
(WebCore::scrollViewForEventTarget): Added helper function.
(WebCore::eventTargetIsPlatformWidget): Added helper function.
(WebCore::EventHandler::platformPrepareForWheelEvents): Check whether we are at a scrolled edge
for the NSView (PlatformWidget) case.
(WebCore::EventHandler::platformCompleteWheelEvent): Return 'false' when handling WK1-style scrolls.
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Added. We generally want to
return false so the PlatformWidget handles scrolling, except in the case where we are latched to
a PlatformWidget, which has already performed its scroll, and we want to avoid propegating a
scroll event to an enclosing region.

LayoutTests:
* platform/mac/fast/scrolling/scroll-iframe-fragment-expected.txt: Added.
* platform/mac/fast/scrolling/scroll-iframe-fragment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBroken build with build-webkit --no-video
ryuan.choi@samsung.com [Thu, 3 Jul 2014 20:06:42 +0000 (20:06 +0000)]
Broken build with build-webkit --no-video
https://bugs.webkit.org/show_bug.cgi?id=134587

Reviewed by Darin Adler.

MEDIA_CONTROLS_SCRIPT requires VIDEO enabled.

.:
* Source/cmake/WebKitFeatures.cmake: Added the dependency for ENABLE_MEDIA_CONTROLS_SCRIPT.

Source/WTF:
* wtf/FeatureDefines.h: Added error message for dependency failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Revise the flat find indicator secondary highlight shadows
timothy_horton@apple.com [Thu, 3 Jul 2014 20:01:28 +0000 (20:01 +0000)]
[WK2] Revise the flat find indicator secondary highlight shadows
https://bugs.webkit.org/show_bug.cgi?id=134607
<rdar://problem/17554828>

Reviewed by Brady Eidson.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::drawRect):
Bring back the secondary highlight shadow, with new constants.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPreserve old behavior of creating an NSURLRequest of the exact same type as passed...
psolanki@apple.com [Thu, 3 Jul 2014 19:48:21 +0000 (19:48 +0000)]
Preserve old behavior of creating an NSURLRequest of the exact same type as passed to us
https://bugs.webkit.org/show_bug.cgi?id=134605
<rdar://problem/17544641>

Reviewed by Andreas Kling.

We have client code that passes us a subclass of NSURLRequest to load resource. Later when
we call willSendRequest, they test to make sure they get an object of the same type. My
optimization in r170642 broke this path when I cleared out the NSURLRequest object. We
already had code in updateNSURLRequest() that was taking this quirk into account but I broke
that. Fix it by reverting to old behavior for such clients.

No new tests though we need one. I will add it later.

* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):
* platform/network/ios/ResourceRequestIOS.mm:
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::clearOrUpdateNSURLRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] Sometimes the swipe snapshot stays up too long
timothy_horton@apple.com [Thu, 3 Jul 2014 19:30:28 +0000 (19:30 +0000)]
[iOS][WK2] Sometimes the swipe snapshot stays up too long
https://bugs.webkit.org/show_bug.cgi?id=134506
<rdar://problem/17496803>

Reviewed by Simon Fraser.

Implement a transaction callback mechanism.
The UI process can register a callback at any point, generally immediately after sending a message to the Web process.
It will then send another message (in-order) with the callback ID to the Web process, which will put it into the next transaction
(scheduling a new one if needed). When the transaction comes back to the UI process, the callbacks are performed.
This ensures that the callback fires alongside a commit that includes the results of whatever messages were sent before it was registered.
For now, all callbacks are fired just before committing layer changes, but it's possible future patches will want post-commit callbacks.

Make use of this to remove the ViewGestureControllerIOS snapshots at the right time.

* Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::callbackIDs):
(WebKit::RemoteLayerTreeTransaction::setCallbackIDs):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
Add a vector of callback IDs to the transaction; encode and decode as appropriate.

* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::DrawingAreaProxy::lastVisibleTransactionID): Deleted.
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::~RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::dispatchAfterEnsuringDrawing):
Add dispatchAfterEnsuringDrawing, which takes a function.
When a callback is added, we send the callback ID to the Web process via the AddTransactionCallbackID message.
Perform callbacks listed in the incoming transaction's vector of callback IDs.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::addTransactionCallbackID):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::addTransactionCallbackID):
Keep track of the pending callback IDs on the drawing area, and move them into the transaction.
We schedule a flush when installing a transaction callback on the premise that
sometimes the action (goToBackForwardListItem in the swipe case) might have already occurred
and been committed by the time the Web process receives AddTransactionCallbackID, so we need
to cause another commit to send the callbacks across. If said commit is still pending, this is a no-op.

* UIProcess/ios/ViewGestureControllerIOS.mm:
(allViewGestureControllers):
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::willCommitPostSwipeTransitionLayerTree):
(WebKit::ViewGestureController::setRenderTreeSize):
* UIProcess/mac/ViewGestureController.h:
Keep a side-map of page IDs to ViewGestureControllers, so that we can safely get back to
our ViewGestureController from the callback.

When the callback fires, if it succeeded, set m_shouldRemoveSnapshotWhenTargetRenderTreeSizeHit,
so that the commit (which is about to occur immediately after the callback returns) which calls
setRenderTreeSize will (perhaps) remove the snapshot.

If it failed, we remove the snapshot immediately, as this usually happens if the Web process crashed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFollowup to "rects sent to ServicesOverlayController are wrong"
beidson@apple.com [Thu, 3 Jul 2014 19:16:27 +0000 (19:16 +0000)]
Followup to "rects sent to ServicesOverlayController are wrong"
https://bugs.webkit.org/show_bug.cgi?id=134568

Rubberstamped by Tim Horton.

* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::drawSelectionHighlight): Don’t check to see if the
  proposed rect intersects the dirty rect. We always need to include all rects that form
  the selection when creating the DDHighlight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] RemoteLayerTreeDrawingAreaProxy re-checks a preference every commit for no...
timothy_horton@apple.com [Thu, 3 Jul 2014 19:04:34 +0000 (19:04 +0000)]
[WK2] RemoteLayerTreeDrawingAreaProxy re-checks a preference every commit for no reason
https://bugs.webkit.org/show_bug.cgi?id=134586

Reviewed by Benjamin Poulain.

* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setShouldShowDebugIndicator):
(WebKit::DrawingAreaProxy::showDebugIndicator): Deleted.
(WebKit::DrawingAreaProxy::isShowingDebugIndicator): Remove this, nobody is using it.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::preferencesDidChange):
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::setShouldShowDebugIndicator):
(WebKit::RemoteLayerTreeDrawingAreaProxy::showDebugIndicator): Deleted.
Check the debug indicator pref at construction time, and update the state when it changes.
Checking it every commit was surprisingly expensive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSelection rects sent to ServicesOverlayController are wrong.
beidson@apple.com [Thu, 3 Jul 2014 17:56:38 +0000 (17:56 +0000)]
Selection rects sent to ServicesOverlayController are wrong.
<rdar://problem/16727796> and https://bugs.webkit.org/show_bug.cgi?id=134568

Reviewed by Darin Adler (and Tim Horton and Ryosuke Niwa).

Source/WebCore:
* WebCore.exp.in:

Update the gatherer to keep GapRects separate from LayoutRects:
* editing/SelectionRectGatherer.cpp:
(WebCore::SelectionRectGatherer::addRects):
(WebCore::SelectionRectGatherer::Notifier::~Notifier):
(WebCore::SelectionRectGatherer::clearAndCreateNotifier):
* editing/SelectionRectGatherer.h:

* page/EditorClient.h:
(WebCore::EditorClient::selectionRectsDidChange): Updated to take LayoutRects and GapRects separately.

Change RenderSelectionInfo to also hang on to the individual rects that formed the final bounding rect:
* rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::RenderSelectionInfo): If the RenderObject is a RenderText, then call
  collectSelectionRectsForLineBoxes instead of selectionRectForRepaint.
(WebCore::RenderSelectionInfo::rects):

* rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionRectsForLineBoxes): Added
(WebCore::RenderText::selectionRectForRepaint):
* rendering/RenderText.h:

* rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::collectSelectionRectsForRange): Added
* rendering/RenderTextLineBoxes.h:

* rendering/RenderView.cpp:
(WebCore::RenderView::setSubtreeSelection): Add the list of rects to the gatherer instead of just
  the bounding rect.

Source/WebKit2:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectionRectsDidChange): Also pass the GapRects to the ServicesOverlayController.
* WebProcess/WebCoreSupport/WebEditorClient.h:

* WebProcess/WebPage/ServicesOverlayController.h:
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::expandForGap):
(WebKit::compactRectsWithGapRects): Combine 3+ rects down to exactly 3 rects, then expand them based on GapRects.
(WebKit::ServicesOverlayController::selectionRectsDidChange): Call compactRectsWithGapRects, then reverse the list.
(WebKit::ServicesOverlayController::drawSelectionHighlight): Tell data detectors to flip this.
(WebKit::ServicesOverlayController::drawTelephoneNumberHighlight): Tell data detectors to flip this.
(WebKit::ServicesOverlayController::drawCurrentHighlight): No need to flip this anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEnsure frame creation messages get through to UI process
antti@apple.com [Thu, 3 Jul 2014 17:13:02 +0000 (17:13 +0000)]
Ensure frame creation messages get through to UI process
https://bugs.webkit.org/show_bug.cgi?id=134591
<rdar://problem/16918218>

Reviewed by Anders Carlsson.

If we are middle of handling a synchronous message from UI process a frame creation message back gets delayed.
The subsequent synchronous DecidePolicyForNavigationAction message expects that the frame creation
message has arrived first and fails.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):

    Send messages with DispatchMessageEvenWhenWaitingForSyncReply so they always go through in order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of DecoderAdapter and EncoderAdapter
andersca@apple.com [Thu, 3 Jul 2014 17:09:42 +0000 (17:09 +0000)]
Get rid of DecoderAdapter and EncoderAdapter
https://bugs.webkit.org/show_bug.cgi?id=134598

Reviewed by Andreas Kling.

* CMakeLists.txt:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DecoderAdapter.cpp: Removed.
* WebProcess/WebPage/DecoderAdapter.h: Removed.
* WebProcess/WebPage/EncoderAdapter.cpp: Removed.
* WebProcess/WebPage/EncoderAdapter.h: Removed.
* WebProcess/WebPage/WebPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStop using EncoderAdapter/DecoderAdapter for FormData
andersca@apple.com [Thu, 3 Jul 2014 17:05:41 +0000 (17:05 +0000)]
Stop using EncoderAdapter/DecoderAdapter for FormData
https://bugs.webkit.org/show_bug.cgi?id=134571

Reviewed by Andreas Kling.

Source/WebCore:
* WebCore.exp.in:
* platform/network/FormData.cpp:
(WebCore::encodeElement): Deleted.
(WebCore::decodeElement): Deleted.
(WebCore::FormData::encode): Deleted.
(WebCore::FormData::decode): Deleted.
* platform/network/FormData.h:
(WebCore::FormDataElement::encode):
(WebCore::FormDataElement::decode):
(WebCore::FormData::encode):
(WebCore::FormData::decode):

Source/WebKit2:
* Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPossible crash in IconDatabase in WebCore::IconDatabase::dispatchDidRemoveAllIconsOnM...
beidson@apple.com [Thu, 3 Jul 2014 16:19:07 +0000 (16:19 +0000)]
Possible crash in IconDatabase in WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread
<rdar://problem/17437687> and https://bugs.webkit.org/show_bug.cgi?id=134517

Reviewed by Eric Carlson.

Source/WebCore:
Since WebCore::IconDatabase is not RefCounted there’s no obvious way to keep it alive until it is
truly no longer needed.

This isn’t generally a problem because they are usually a singleton that lasts the lifetime of the process.

In the WebKit2 case, WebCore::IconDatabases can come and go as their owning WebIconDatabases come and go.

So we can rely on WebIconDatabase to handle the lifetime appropriately.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::close): If the database is actually closed, notify the client.
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::isOpen): Take into account whether there’s any main thread callbacks, plus what
  is covered by isOpenBesidesMainThreadCallbacks.
(WebCore::IconDatabase::isOpenBesidesMainThreadCallbacks): Take into account whether the sync thread
  is still running and whether or not the database file is still open.
(WebCore::IconDatabase::checkClosedAfterMainThreadCallback): Checks to see if the database has just
  become 100% closed and - if so - notify the client.
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread): Updated to increment the main thread
  callback count and to call checkClosedAfterMainThreadCallback when done.
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread): Ditto.
(WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread): Ditto.
(WebCore::IconDatabase::dispatchDidFinishURLImportOnMainThread): Ditto.
* loader/icon/IconDatabase.h:

* loader/icon/IconDatabaseClient.h:
(WebCore::IconDatabaseClient::didClose): Added. For the IconDatabase to tell its client it is 100% closed.

Source/WebKit2:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext): Instead of directly deref’ing the WebIconDatabase, ask it to
  deref itself when appropriate.

* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::didClose): If this WebIconDatabase is supposed to deref itself when
  appropriate, do so now.
(WebKit::WebIconDatabase::derefWhenAppropriate): If the WebCore::IconDatabase is still open then
  defer this deref.
* UIProcess/WebIconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: VoiceOver does not read aria-expanded attribute on controls in Safari
cfleizach@apple.com [Thu, 3 Jul 2014 15:46:36 +0000 (15:46 +0000)]
AX: VoiceOver does not read aria-expanded attribute on controls in Safari
https://bugs.webkit.org/show_bug.cgi?id=134527

Reviewed by Mario Sanchez Prada.

Expose whether the ARIA expanded property is present or not.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAExpanded]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[JavaScriptCore] Add --cmakeargs option to build-jsc.
llango.u-szeged@partner.samsung.com [Thu, 3 Jul 2014 14:55:50 +0000 (14:55 +0000)]
[JavaScriptCore] Add --cmakeargs option to build-jsc.
https://bugs.webkit.org/show_bug.cgi?id=134590

Reviewed by Ryosuke Niwa.

* Scripts/build-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] The list of features shown by cmake is not accurate
carlosgc@webkit.org [Thu, 3 Jul 2014 13:36:45 +0000 (13:36 +0000)]
[GTK] The list of features shown by cmake is not accurate
https://bugs.webkit.org/show_bug.cgi?id=134588

Reviewed by Gustavo Noronha Silva.

The problem is that some options might change after the feature
list has been printed.

* Source/cmake/OptionsGTK.cmake: Find package dependencies before
setting the default values of features and set WEBGL value
depending on the dependencies, and API_TEST depending on whether
developer mode is enabled or not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd option to specify jsc args in run-sunspider.
commit-queue@webkit.org [Thu, 3 Jul 2014 12:49:32 +0000 (12:49 +0000)]
Add option to specify jsc args in run-sunspider.
https://bugs.webkit.org/show_bug.cgi?id=134341

Patch by Gergo Balogh <gbalogh.u-szeged@partner.samsung.com> on 2014-07-03
Reviewed by Csaba Osztrogonác.

* Scripts/run-sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMAKE] Add WEBKIT_OPTION_DEPEND macro to resolve macro dependency
ryuan.choi@samsung.com [Thu, 3 Jul 2014 08:04:38 +0000 (08:04 +0000)]
[CMAKE] Add WEBKIT_OPTION_DEPEND macro to resolve macro dependency
https://bugs.webkit.org/show_bug.cgi?id=134578

Reviewed by Gyuyoung Kim.

Some options depend on another option such as ENABLE_VIDEO_TRACK and ENABLE_VIDEO.
This patch adds WEBKIT_OPTION_DEPEND to check the depending option and
disable related option if it is not ON.

* Source/cmake/OptionsEfl.cmake: Removed hack for option dependency.
* Source/cmake/OptionsGTK.cmake: Ditto.
* Source/cmake/WebKitFeatures.cmake: Added WEBKIT_OPTION_DEPEND macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r170676): [GTK] UI process crashes when the Web Process crashes
carlosgc@webkit.org [Thu, 3 Jul 2014 07:56:28 +0000 (07:56 +0000)]
REGRESSION(r170676): [GTK] UI process crashes when the Web Process crashes
https://bugs.webkit.org/show_bug.cgi?id=134541

Reviewed by Gyuyoung Kim.

It happens when attaching a new web process, because it tries to
encode a null SessionState.

* UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::encodeLegacySessionState): Return an empty API::Data
object instead of nullptr.
(WebKit::encodeLegacySessionHistoryEntryData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r170743): [GTK] [EFL] Build broken.
carlosgc@webkit.org [Thu, 3 Jul 2014 07:53:23 +0000 (07:53 +0000)]
REGRESSION(r170743): [GTK] [EFL] Build broken.
https://bugs.webkit.org/show_bug.cgi?id=134585

Reviewed by Philippe Normand.

Add ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC) guards where needed.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoving an element with CSS -webkit-overflow-scrolling: touch breaks
jhoneycutt@apple.com [Thu, 3 Jul 2014 04:25:27 +0000 (04:25 +0000)]
Removing an element with CSS -webkit-overflow-scrolling: touch breaks
subsequent touch events

<https://bugs.webkit.org/show_bug.cgi?id=134584>
<rdar://problem/17202021>

This issue is caused by the order of teardown for RenderLayers.

RenderLayer clears its m_backing in its destructor, calling the
RenderLayerBacking destructor. The RenderLayerBacking destructor calls
RenderLayerCompositor::willRemoveScrollingLayer(), which tries to
access the RenderLayer's backing that has already been cleared. This
causes us to skip the call to ChromeClient::removeScrollingLayer(),
resulting in a stale view that can block touch events.

Reviewed by Simon Fraser.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateScrollingLayers):
When calling willRemoveScrollingLayerWithBacking(), pass both the layer
and the RenderLayerBacking.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
Renamed. Use the passed RenderLayerBacking, as the RenderLayer's
backing might have already been cleared.
(WebCore::RenderLayerCompositor::willRemoveScrollingLayer): Deleted.

* rendering/RenderLayerCompositor.h:
Renamed willRemoveScrollingLayer() to
willRemoveScrollingLayerWithBacking() and added a parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTools: [GTK] Unreviewed gardening.
commit-queue@webkit.org [Thu, 3 Jul 2014 04:03:32 +0000 (04:03 +0000)]
Tools: [GTK] Unreviewed gardening.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-02

* Scripts/run-gtk-tests:
(TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage

LayoutTests: Unreviewed gardening.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-02

* platform/gtk/TestExpectations: Report and mark several flaky tests.
* platform/gtk/fast/text/indic-expected.txt: Added. Add baseline for GTK.
* platform/mac-wk2/TestExpectations: Report and mark flaky test http/tests/cache/iframe-304-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] Make is safe/fast to use the animated resize API without resizing anything
benjamin@webkit.org [Thu, 3 Jul 2014 03:52:21 +0000 (03:52 +0000)]
[iOS][WK2] Make is safe/fast to use the animated resize API without resizing anything
https://bugs.webkit.org/show_bug.cgi?id=134570

Reviewed by Enrica Casucci.

Today, if someone calls _beginAnimatedResizeWithUpdates-_endAnimatedResize, it is always a very heavy process
forcing a relayout and can cause synchronous operations.

We should not force the caller of the API to maintain their own state tracking, we should do that for them.

With this patch, we track everything we need for a resize and only do the heavy lifting if anything has actually changed.

* UIProcess/API/Cocoa/WKWebView.mm:
(activeMinimumLayoutSize):
(activeMinimumLayoutSizeForMinimalUI):
(activeMaximumUnobscuredSize):
(activeOrientation):
This code is used in both _didRelaunchProcess and _beginAnimatedResizeWithUpdates. It is moved to static functions
to avoid having it in two places.

(-[WKWebView _didRelaunchProcess]):

(-[WKWebView _beginAnimatedResizeWithUpdates:]):
The updates now goes like this:
1) Set _isAnimatingResize to prevent the undesired side effects updateBlock() if we really need to resize.
2) Get all the original values before calling the update block.
3) Call the update block.
4a) If nothing useful for resize has changed, reset _isAnimatingResize to false.
    We also need to update the visible content rect because the update block may have changed something unrelated
    to the view size (scale, scroll position, etc).
4b) If we really need to resize, proceed as usual.

(-[WKWebView _endAnimatedResize]):
With the changes in _beginAnimatedResizeWithUpdates:, _isAnimatingResize is only set for real cases of animated resize,
bail out early if that flag isn't set.

The remaining code is unchanged, it is just not indented due to the removal of the if() branch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImprove handling of primary offscreen plugins.
roger_fong@apple.com [Thu, 3 Jul 2014 03:31:05 +0000 (03:31 +0000)]
Improve handling of primary offscreen plugins.
https://bugs.webkit.org/show_bug.cgi?id=134528.
<rdar://problem/17471864>

Reviewed by Dean Jackson.

* WebProcess/Plugins/PluginView.cpp:
Determine whether or not the plugin starts offscreen when the plugin is initialized.
(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Use the PluginProcessTypeNormal for offscreen plugins that are potentially primary plugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
gyuyoung.kim@samsung.com [Thu, 3 Jul 2014 02:31:53 +0000 (02:31 +0000)]
Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
https://bugs.webkit.org/show_bug.cgi?id=134581

Reviewed by Tim Horton.

Should be removed unused EFL bot info.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
(EWS):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* TestResultServer/static-dashboards/builders.jsonp:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(WK2): Undo does not work in text fields in Safari.
enrica@apple.com [Thu, 3 Jul 2014 00:59:30 +0000 (00:59 +0000)]
REGRESSION(WK2): Undo does not work in text fields in Safari.
https://bugs.webkit.org/show_bug.cgi?id=134572
<rdar://problem/17542238>

Reviewed by Benjamin Poulain.

This patch adds for iOS the same implementation we have already for OS X.

* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(-[WKEditCommandObjC initWithWebEditCommandProxy:]):
(-[WKEditCommandObjC command]):
(-[WKEditorUndoTargetObjC undoEditing:]):
(-[WKEditorUndoTargetObjC redoEditing:]):
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoProcessAssertion should also prevent UIApp suspension
barraclough@apple.com [Thu, 3 Jul 2014 00:55:37 +0000 (00:55 +0000)]
ProcessAssertion should also prevent UIApp suspension
https://bugs.webkit.org/show_bug.cgi?id=134563

Reviewed by Dan Bernstein.

If the application suspends then the child processes will, too.
Use beginBackgroundTaskWithName:expirationHandler: to request that the application remain runnable
while waiting for background tasks to complete.

* UIProcess/ProcessAssertion.cpp:
(WebKit::ProcessAssertion::~ProcessAssertion):
    - Added destructor.
* UIProcess/ProcessAssertion.h:
    - Added destructor.
* UIProcess/ios/ProcessAssertionIOS.mm:
(+[WKProcessAssertionBackgroundTaskManager shared]):
    - singleton WKProcessAssertionBackgroundTaskManager.
(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager dealloc]):
    - register/remove notification handlers.
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
    - if we need to be runnable make sure we're holding a BackgroundTask, if not release it.
(-[WKProcessAssertionBackgroundTaskManager _applicationDidEnterBackgroundOrWillEnterForeground:]):
    - detect when the app enters/leaves foreground; calls to _updateBackgroundTask.
(-[WKProcessAssertionBackgroundTaskManager incrementNeedsToRunInBackgroundCount]):
(-[WKProcessAssertionBackgroundTaskManager decrementNeedsToRunInBackgroundCount]):
    - interface to update the count; calls to _updateBackgroundTask.
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::~ProcessAssertion):
    - count ProcessAssertions in and out of existance.
(WebKit::ProcessAssertion::setState):
    - count when the state changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEnsure that the WebKit bundle version in the user agent string continues to match...
mrowe@apple.com [Wed, 2 Jul 2014 23:02:45 +0000 (23:02 +0000)]
Ensure that the WebKit bundle version in the user agent string continues to match the current format.
<https://webkit.org/b/134524> / <rdar://problem/17447771>

Reviewed by Simon Fraser.

* page/cocoa/UserAgent.h:
* page/cocoa/UserAgent.mm:
(WebCore::userVisibleWebKitBundleVersionFromFullVersion): Updated to take an NSString now that it's internal
to the file.
(WebCore::userAgentBundleVersionFromFullVersionString): Limit the bundle version included in the user agent
string to three components.
* page/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName): Update to call userAgentBundleVersionFromFullVersionString.
* page/mac/UserAgentMac.mm:
(WebCore::standardUserAgentWithApplicationName): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<https://webkit.org/b/134522> Remove duplication in code that prepares the user agent...
mrowe@apple.com [Wed, 2 Jul 2014 23:02:43 +0000 (23:02 +0000)]
<https://webkit.org/b/134522> Remove duplication in code that prepares the user agent string on Mac and iOS

Reviewed by Simon Fraser.

Source/WebCore:
* page/cocoa/UserAgent.h:
* page/cocoa/UserAgent.mm:
(WebCore::userVisibleWebKitBundleVersionFromFullVersion): Moved from WebKit2.
* page/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName): Pass the WebKit bundle version through userVisibleWebKitBundleVersionFromFullVersion
before including it in the user agent string.
* page/mac/UserAgentMac.mm:
(WebCore::standardUserAgentWithApplicationName): Ditto.

Source/WebKit/mac:
* WebView/WebView.mm:
(webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it.
(+[WebView _standardUserAgentWithApplicationName:]):

Source/WebKit2:
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it.
(WebKit::WebPageProxy::standardUserAgent):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::webKitBundleVersionString): Ditto.
(WebKit::WebPageProxy::standardUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago Restrict network process sandbox
oliver@apple.com [Wed, 2 Jul 2014 22:54:32 +0000 (22:54 +0000)]
   Restrict network process sandbox
       https://bugs.webkit.org/show_bug.cgi?id=134360

       Reviewed by Sam Weinig.

       Add more restrictions to the network process sandbox.

       * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
       (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
 Always use the cache directory provided in the initialization parameters,
 and make sure we consume the cookie directory extension.
       * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
 Make the sandbox profile much more restrictive.
       * Shared/Network/NetworkProcessCreationParameters.cpp:
       (WebKit::NetworkProcessCreationParameters::encode):
       (WebKit::NetworkProcessCreationParameters::decode):
       * Shared/Network/NetworkProcessCreationParameters.h:
 The network process now requires an extension to access
 its cookie storage.
       * Shared/mac/SandboxUtilities.cpp:
       (WebKit::pathForProcessContainer):
       * Shared/mac/SandboxUtilities.h:
 We need to be able to get hold of our container so
 that we can get the correct cookie storage directory.
       * UIProcess/WebContext.cpp:
       (WebKit::WebContext::ensureNetworkProcess):
 We have to pass in the an extension for the cookie storage directory when
       initalising the network process
       * UIProcess/mac/WebContextMac.mm:
       (WebKit::WebContext::platformDefaultCookieStorageDirectory):
 Make sure we provide the correct location on IOS
       * WebProcess/cocoa/WebProcessCocoa.mm:
       (WebKit::WebProcess::platformInitializeWebProcess):
 Consume the cookie storage extension

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r170725.
ossy@webkit.org [Wed, 2 Jul 2014 22:52:41 +0000 (22:52 +0000)]
URTBF after r170725.

* CMakeLists.txt: Removed Shared/LegacySessionState.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r170719 for !CF platforms.
ossy@webkit.org [Wed, 2 Jul 2014 22:52:21 +0000 (22:52 +0000)]
URTBF after r170719 for !CF platforms.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionStateData): Deleted.
(WebKit::WebPageProxy::restoreFromSessionStateData): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<https://webkit.org/b/134521> iOS should use shared code to determine the system...
mrowe@apple.com [Wed, 2 Jul 2014 22:38:41 +0000 (22:38 +0000)]
<https://webkit.org/b/134521> iOS should use shared code to determine the system marketing version

Reviewed by Simon Fraser.

Source/WebCore:
* WebCore.xcodeproj/project.pbxproj: Add the new files, and sort the groups they're in.
* page/cocoa/UserAgent.h: Copied from Source/WebCore/page/mac/UserAgent.h.
* page/cocoa/UserAgent.mm: Renamed from Source/WebCore/page/mac/UserAgent.h.
Move systemMarketingVersionForUserAgentString to a location where it can be shared between
Mac and iOS.
* page/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName): Switch to systemMarketingVersionForUserAgentString.
* page/mac/UserAgentMac.mm:
* platform/cocoa/SystemVersion.h: Renamed from Source/WebCore/platform/mac/SystemVersionMac.h.
* platform/cocoa/SystemVersion.mm: Renamed from Source/WebCore/platform/mac/SystemVersionMac.mm.
Move to a location that makes it clear this is shared between Mac and iOS. Enable the modern Mac
codepath for iOS as well.

Source/WebKit2:
* Shared/ios/ChildProcessIOS.mm: Update #import.
* Shared/mac/ChildProcessMac.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove keyed coding from FormData
andersca@apple.com [Wed, 2 Jul 2014 22:12:32 +0000 (22:12 +0000)]
Remove keyed coding from FormData
https://bugs.webkit.org/show_bug.cgi?id=134565

Reviewed by Tim Horton.

* platform/network/FormData.cpp:
(WebCore::encodeElement): Deleted.
(WebCore::decodeElement): Deleted.
(WebCore::FormData::encode): Deleted.
(WebCore::FormData::decode): Deleted.
* platform/network/FormData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of the HistoryItem encoding/decoding in WebCore
andersca@apple.com [Wed, 2 Jul 2014 22:04:49 +0000 (22:04 +0000)]
Get rid of the HistoryItem encoding/decoding in WebCore
https://bugs.webkit.org/show_bug.cgi?id=134564

Reviewed by Beth Dakin.

* WebCore.exp.in:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree): Deleted.
(WebCore::encodeRect): Deleted.
(WebCore::encodeSize): Deleted.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Deleted.
(WebCore::DecodeRecursionStackElement::DecodeRecursionStackElement): Deleted.
(WebCore::decodeRect): Deleted.
(WebCore::decodeSize): Deleted.
(WebCore::HistoryItem::decodeBackForwardTree): Deleted.
* history/HistoryItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRip out more dead code
andersca@apple.com [Wed, 2 Jul 2014 21:49:33 +0000 (21:49 +0000)]
Rip out more dead code
https://bugs.webkit.org/show_bug.cgi?id=134562

Reviewed by Andreas Kling.

* Shared/LegacySessionState.cpp: Removed.
* Shared/LegacySessionState.h: Removed.
* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem): Deleted.
(WebKit::WebBackForwardListItem::backForwardData): Deleted.
(WebKit::WebBackForwardListItem::setBackForwardData): Deleted.
(WebKit::WebBackForwardListItem::encode): Deleted.
(WebKit::WebBackForwardListItem::decode): Deleted.
* Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create): Deleted.
(WebKit::WebBackForwardListItem::setOriginalURL): Deleted.
(WebKit::WebBackForwardListItem::setURL): Deleted.
(WebKit::WebBackForwardListItem::setTitle): Deleted.
* UIProcess/WebPageProxy.cpp:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRestoreSession should take a vector of BackForwardListItemStates
andersca@apple.com [Wed, 2 Jul 2014 21:31:23 +0000 (21:31 +0000)]
RestoreSession should take a vector of BackForwardListItemStates
https://bugs.webkit.org/show_bug.cgi?id=134558

Reviewed by Tim Horton.

* Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::itemStates):
* UIProcess/WebBackForwardList.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::creationParameters):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::restoreSession):
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem): Deleted.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStore the back forward list item id inside BackForwardListItemState
andersca@apple.com [Wed, 2 Jul 2014 21:13:23 +0000 (21:13 +0000)]
Store the back forward list item id inside BackForwardListItemState
https://bugs.webkit.org/show_bug.cgi?id=134557

Reviewed by Tim Horton.

* Shared/SessionState.cpp:
(WebKit::BackForwardListItemState::encode):
(WebKit::BackForwardListItemState::decode):
* Shared/SessionState.h:
* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::encode):
* Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::itemID):
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::restoreFromState):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. EFL and GTK build fix after r170716.
rego@igalia.com [Wed, 2 Jul 2014 21:05:14 +0000 (21:05 +0000)]
Unreviewed. EFL and GTK build fix after r170716.

* UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::decodeLegacySessionState): Update method signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBegin ripping out the old session state code
andersca@apple.com [Wed, 2 Jul 2014 20:43:17 +0000 (20:43 +0000)]
Begin ripping out the old session state code
https://bugs.webkit.org/show_bug.cgi?id=134556

Reviewed by Andreas Kling.

* UIProcess/WebBackForwardList.h:
* UIProcess/WebPageProxy.h:
* UIProcess/cf/WebBackForwardListCF.cpp: Removed.
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData): Deleted.
(WebKit::WebPageProxy::restoreFromSessionStateData): Deleted.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WebGL] Fix crash when glsl expressions are too complex.
achristensen@apple.com [Wed, 2 Jul 2014 20:29:42 +0000 (20:29 +0000)]
[WebGL] Fix crash when glsl expressions are too complex.
https://bugs.webkit.org/show_bug.cgi?id=134554
<rdar://problem/17540462>

Reviewed by Dean Jackson.

This fixes the Khronos test conformance/glsl/bugs/long-expressions-should-not-crash.html.

* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
Add SH_LIMIT_EXPRESSION_COMPLEXITY to the ANGLE compile options.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(160908): vube.com video won't play after going into and out of fullscreen
antti@apple.com [Wed, 2 Jul 2014 20:22:04 +0000 (20:22 +0000)]
REGRESSION(160908): vube.com video won't play after going into and out of fullscreen
https://bugs.webkit.org/show_bug.cgi?id=134489

Reviewed by Zalan Bujtas.

* fullscreen/full-screen-plugin-expected.txt: Added.
* fullscreen/full-screen-plugin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse legacy state coding directly in WKWebView
andersca@apple.com [Wed, 2 Jul 2014 20:19:06 +0000 (20:19 +0000)]
Use legacy state coding directly in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=134553

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.cpp:
(WKPageRestoreFromSessionState):
* UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCreateFromData):
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _sessionStateData]):
(-[WKWebView _sessionState]):
(-[WKWebView _restoreFromSessionStateData:]):
(-[WKWebView _restoreFromSessionState:]):
(releaseNSData): Deleted.
* UIProcess/LegacySessionStateCoding.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::restoreFromState): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeLegacySessionState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Moved self to reviewers list.
achristensen@apple.com [Wed, 2 Jul 2014 19:55:22 +0000 (19:55 +0000)]
Unreviewed.  Moved self to reviewers list.

* Scripts/webkitpy/common/config/contributors.json:
Moved self to reviewers list, added WebGL to expertise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebCore JIT: rename registerCount to something less generic and add new types for...
benjamin@webkit.org [Wed, 2 Jul 2014 19:48:16 +0000 (19:48 +0000)]
WebCore JIT: rename registerCount to something less generic and add new types for lists of registers and lists of stack references
https://bugs.webkit.org/show_bug.cgi?id=134552

Reviewed by Alex Christensen.

Little cleanup:
-The name registerCount was a little too generic. Rename that to "maximumRegisterCount" to avoid confusion.
-Add a new type RegisterVector for any vector holding registers. This is just to avoid repeating the inline
 size everywhere, no functional change.
-Same idea for the stack: welcome StackReferenceVector!

* cssjit/FunctionCall.h:
(WebCore::FunctionCall::saveAllocatedCallerSavedRegisters):
Remove the appendVector here. It was unnecessarily cautious, StackAllocator already protect us
from mistakes.

* cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::allocatedRegisters):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Changing from the count of "calleeSavedRegisterCount" to "maximumRegisterCount" will cause
calleeSavedRegisterStackReferences to always overallocate.
The code generator is never on the heap, so that should not change anything.

* cssjit/StackAllocator.h:
(WebCore::StackAllocator::push):
(WebCore::StackAllocator::pop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoiOS build fix after http://trac.webkit.org/changeset/170697.
enrica@apple.com [Wed, 2 Jul 2014 19:40:52 +0000 (19:40 +0000)]
iOS build fix after trac.webkit.org/changeset/170697.

Unreviewed.

* wtf/Deque.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSkip fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image...
dino@apple.com [Wed, 2 Jul 2014 18:30:03 +0000 (18:30 +0000)]
Skip fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image.html
on Mountain Lion. It doesn't support such large textures (or at least our
bots don't).

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd -[WKWebView _sessionStateData] and -[WKWebView _restoreFromSessionStateData:]
andersca@apple.com [Wed, 2 Jul 2014 17:40:38 +0000 (17:40 +0000)]
Add -[WKWebView _sessionStateData] and -[WKWebView _restoreFromSessionStateData:]
https://bugs.webkit.org/show_bug.cgi?id=134549

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _sessionState]):
(-[WKWebView _sessionStateData]):
(-[WKWebView _restoreFromSessionState:]):
(-[WKWebView _restoreFromSessionStateData:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove some code only needed for versions of Safari that are no longer supported
mitz@apple.com [Wed, 2 Jul 2014 17:33:32 +0000 (17:33 +0000)]
Remove some code only needed for versions of Safari that are no longer supported
https://bugs.webkit.org/show_bug.cgi?id=134537

Reviewed by Anders Carlsson.

Source/WebCore:
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _rectOnScreen]): Deleted.
(-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): Deleted.
(-[DOMHTMLInputElement _selectedRange]): Deleted.
* bindings/objc/DOMPrivate.h:
* editing/EditorCommand.cpp:
(WebCore::createCommandMap):

Source/WebKit/mac:
* History/WebHistoryItem.mm:
* Misc/WebKitVersionChecks.h:
* WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin domain]): Deleted.
* WebInspector/WebInspector.mm:
(-[WebInspector showTimeline:]): Deleted.
(+[WebInspector webInspector]): Deleted.
(-[WebInspector setWebFrame:]): Deleted.
(-[WebInspector window]): Deleted.
(-[WebInspector showWindow:]): Deleted.
* WebView/WebFrame.mm:
(-[WebFrame reload]):
* WebView/WebPDFView.mm:
(-[WebPDFView menuForEvent:]):
(-[WebPDFView _anyPDFTagsFoundInMenu:]): Deleted.
* WebView/WebView.mm:
(-[WebView _initWithFrame:frameName:groupName:]):
(-[WebView _preferencesChanged:]):
(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): Deleted.
(+[WebView _setAlwaysUseATSU:]): Deleted.
(-[WebView _needsUnrestrictedGetMatchedCSSRules]): Deleted.
* WebView/WebViewPrivate.h:

Source/WTF:
* wtf/Assertions.cpp:
* wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] MediaPlayerPrivateGStreamer.cpp fails to build when VIDEO_TRACK is enable...
carlosgc@webkit.org [Wed, 2 Jul 2014 16:02:55 +0000 (16:02 +0000)]
[GStreamer] MediaPlayerPrivateGStreamer.cpp fails to build when VIDEO_TRACK is enabled and using GSTREAMER_MPEGTS
https://bugs.webkit.org/show_bug.cgi?id=134548

Reviewed by Philippe Normand.

Include AtomicStringHash.h when ENABLE(VIDEO_TRACK) && USE(GSTREAMER_MPEGTS)
since it's used by HashMap<AtomicString, RefPtr<InbandMetadataTextTrackPrivateGStreamer>>

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170709 268f45cc-cd09-0410-ab3c-d52691b4dbfc