WebKit-https.git
6 weeks ago[ iOS Release ] imported/w3c/web-platform-tests/websockets/Secure-Close-Reason-Unpair...
weinig@apple.com [Wed, 24 Jun 2020 01:17:05 +0000 (01:17 +0000)]
[ iOS Release ] imported/w3c/web-platform-tests/websockets/Secure-Close-Reason-Unpaired-surrogates.any.html & imported/w3c/web-platform-tests/websockets/Secure-Close-Reason-Unpaired-surrogates.any.worker.html are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=213516
<rdar://problem/64642790>

* platform/ios/TestExpectations:
Mark a few WebSocket tests as flakey on iOS test runners.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoRemove WTF::setMainThreadCallbacksPaused
ggaren@apple.com [Wed, 24 Jun 2020 00:27:44 +0000 (00:27 +0000)]
Remove WTF::setMainThreadCallbacksPaused
https://bugs.webkit.org/show_bug.cgi?id=213112

Reviewed by Tim Horton.

Source/WebCore:

* inspector/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::setJavaScriptPaused):

Source/WTF:

setMainThreadCallbacksPaused pauses all uses of callOnMainThread. That
has too many side-effects. For example, you can scroll, but you can't
paint any large images (since they do async image decoding).

Meanwhile, setMainThreadCallbacksPaused doesn't pause RunLoop::dispatch.
So, other things don't get paused.

Let's just rely on suspending the ScriptExecutionContext and document
event queue. That should suspend JavaScript-visible stuff without
suspending engine-critical stuff.

* wtf/MainThread.cpp:
(WTF::dispatchFunctionsFromMainThread):
(WTF::setMainThreadCallbacksPaused): Deleted.
* wtf/MainThread.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[Big Sur] Add 11.0 version to scripts
jbedard@apple.com [Tue, 23 Jun 2020 23:35:04 +0000 (23:35 +0000)]
[Big Sur] Add 11.0 version to scripts
https://bugs.webkit.org/show_bug.cgi?id=213532
<rdar://problem/64663032>

Reviewed by Tim Horton.

* Scripts/run-javascriptcore-tests:
(configurationForUpload): Make version checks more explicit, add Big Sur.
* Scripts/webkitpy/common/version_name_map.py:
(VersionNameMap.__init__): Add Big Sur.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agocanvas/philip/tests/2d.gradient.interpolate.solid.html is no longer failing - remove...
tsavell@apple.com [Tue, 23 Jun 2020 23:24:15 +0000 (23:24 +0000)]
canvas/philip/tests/2d.gradient.interpolate.solid.html is no longer failing - remove expectations.
https://bugs.webkit.org/show_bug.cgi?id=213537

Unreviewed test gardening.

Patch by Karl Rackler <rackler@apple.com> on 2020-06-23

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWeb Inspector: add a tooltip to the icon of overridden resources to clarify meaning
drousso@apple.com [Tue, 23 Jun 2020 23:21:39 +0000 (23:21 +0000)]
Web Inspector: add a tooltip to the icon of overridden resources to clarify meaning
https://bugs.webkit.org/show_bug.cgi?id=213531

Reviewed by Brian Burg.

* UserInterface/Views/LocalResourceOverrideWarningView.js:
(WI.LocalResourceOverrideWarningView.prototype.initialLayout):
* UserInterface/Views/ResourceHeadersContentView.js:
(WI.ResourceHeadersContentView.prototype._responseSourceDisplayString):
Rephrase "local resource override" to just "local override" to match the reference page name.

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateNameCell.createIconElement):
(WI.NetworkTableContentView.prototype._populateNameCell):
(WI.NetworkTableContentView.prototype._populateTransferSizeCell):
Add a `title` for the special transfer size cases, such as for `(local override)`.

* UserInterface/Views/ResourceTreeElement.js:
(WI.ResourceTreeElement.prototype._updateIcon):
* UserInterface/Views/ResourceSizesContentView.js:
(WI.ResourceSizesContentView.prototype.initialLayout):
* UserInterface/Views/TimelineDataGridNode.js:
(WI.TimelineDataGridNode.prototype.createCellContent):
(WI.TimelineDataGridNode.prototype.generateIconTitle): Added.
* UserInterface/Views/ResourceTimelineDataGridNode.js:
(WI.ResourceTimelineDataGridNode.prototype.get data):
(WI.ResourceTimelineDataGridNode.prototype.generateIconTitle): Added.
Add a `title` to the overridden resource icon that clarifies the fact that the resource was
overridden by a local override.

* UserInterface/Views/LayoutTimelineDataGridNode.js:
(WI.LayoutTimelineDataGridNode.prototype.get data):
Cache the `initiatorCallFrame` in the `source` column as well as the `initiator` column, as
it is used by the general timeline overview table.

* UserInterface/Views/DataGridNode.js:
(WI.DataGridNode.prototype.createCell):
(WI.DataGridNode.prototype.generateIconTitle): Added.
Provide a way to set a `title` on just the icon.

* Localizations/en.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoREGRESSION (r244633): Mail flashes when copying text in an email
wenson_hsieh@apple.com [Tue, 23 Jun 2020 22:52:30 +0000 (22:52 +0000)]
REGRESSION (r244633): Mail flashes when copying text in an email
https://bugs.webkit.org/show_bug.cgi?id=213529
<rdar://problem/55025522>

Reviewed by Tim Horton.

Source/WebKit:

When copying a text selection in Mail conversation view, Mail uses injected bundle hooks to supply additional
metadata before writing to the pasteboard. Grabbing this data involves temporarily expanding any collapsed
blockquotes that appear in the mail message, before re-collapsing them after we finish gathering data to be
written to the pasteboard.

Prior to r244633, the size of the document while expanding collapsed content would not be propagated to the
WKWebView, since intrinsic content size changes were batched and sent ahead of the next drawing area flush.
After r244633, however, updates are now sent every time the layout size changes. This was done to ensure that
the intrinsic content size was always up to date before sending the first layout milestone to the UI process.

To preserve the intent of r244633 (with respect to the first layout milestone) as well as intrinsic content size
behavior prior to r244633 after performing layout, we reintroduce the mechanism for batching intrinsic size
updates until the next flush, but keep the out-of-band mechanism for immediately sending an up-to-date intrinsic
size to the UI process before firing the first layout milestone.

Test: WebKit.AutoLayoutBatchesUpdatesWhenInvalidatingIntrinsicContentSize

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::intrinsicContentsSizeChanged const):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateIntrinsicContentSizeIfNeeded):

If we have a pending intrinsic content size update, clear it out here so that an out-of-band call to
updateIntrinsicContentSizeIfNeeded doesn't get overridden by an older intrinsic content size that was previously
scheduled.

(WebKit::WebPage::flushPendingIntrinsicContentSizeUpdate):

Add a helper method to send any pending intrinsic content size update.

(WebKit::WebPage::scheduleIntrinsicContentSizeUpdate):

Add a helper method to schedule an intrinsic content size update for the next tiled drawing area flush.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateRendering):

Tools:

Add an API test to verify that temporarily changing the height of the document before restoring it to the
original value does not cause intrinsic content size to be invalidated.

* TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
(-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
(-[AutoLayoutWKWebView setInvalidatedIntrinsicContentSizeBlock:]):
(-[AutoLayoutWKWebView invalidatedIntrinsicContentSizeBlock]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoUnreviewed, update xcfilelist files after some recent WebXR changes.
cdumez@apple.com [Tue, 23 Jun 2020 22:50:15 +0000 (22:50 +0000)]
Unreviewed, update xcfilelist files after some recent WebXR changes.

* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[Apple Pay] WebPaymentCoordinatorProxy can be destroyed without dismissing its author...
aestes@apple.com [Tue, 23 Jun 2020 22:47:54 +0000 (22:47 +0000)]
[Apple Pay] WebPaymentCoordinatorProxy can be destroyed without dismissing its authorization presenter
https://bugs.webkit.org/show_bug.cgi?id=213423
<rdar://problem/60416221>

Reviewed by Youenn Fablet.

When a website completes a payment session, WebPaymentCoordinatorProxy would set its m_state
to Idle by calling didReachFinalState, but would wait to call hidePaymentUI until the
payment authorization presenter calls its presenterDidFinish callback. This allows the
presenter to display a final message to the user before dismissing. As a catch-all,
~WebPaymentCoordinatorProxy would call hidePaymentUI, but only if m_state wasn't Idle. If a
WebPaymentCoordinatorProxy was destroyed after a website completed a payment session but
before the presenter called presenterDidFinish, hidePaymentUI would never be called.

This patch addresses this by simplifying the logic for completing or canceling a payment
session. It's based on the following observations:

1. With the exception of the case described above, every caller of didReachFinalState would
   also call hidePaymentUI immediately beforehand. That means that we can move the calls to
   hidePaymentUI inside didReachFinalState. For the completePaymentSession case, rather than
   call didReachFinalState without dismissing the UI, we enter a new Completing state, then
   call didReachFinalState either in ~WebPaymentCoordinatorProxy or presenterDidFinish.

2. didCancelPaymentSession is really a special case of didReachFinalState that also sends
   the DidCancelPaymentSession message to cancel active sessions in the web process. We can
   teach didReachFinalState to send this message when necessary and remove
   didCancelPaymentSession.

3. PaymentAuthorizationPresenter stored a "did reach final state" boolean on payment
   completion and passed this value back to the client in the presenterDidFinish callback.
   WebPaymentCoordinatorProxy used this to determine whether to cancel an active session by
   calling didCancelPaymentSession or clean up a completed session by calling hidePaymentUI.
   With the addition of the Completing state and the merging of didCancelPaymentSession and
   hidePaymentUI into didReachFinalState, we can get rid of this final state tracking in
   PaymentAuthorizationPresenter and unconditionally call didReachFinalState in the
   presenterDidFinish callback.

No new tests possible. A manual test case is described in <rdar://problem/60416221>.

* Platform/cocoa/PaymentAuthorizationPresenter.h: Removed the didReachFinalState argument
from Client::presenterDidFinish.

* Platform/cocoa/PaymentAuthorizationPresenter.mm:
(WebKit::PaymentAuthorizationPresenter::completePaymentSession): Changed to call
-[WKPaymentAuthorizationDelegate completePaymentSession:errors:].

* Platform/cocoa/WKPaymentAuthorizationDelegate.h:
* Platform/cocoa/WKPaymentAuthorizationDelegate.mm: Removed the _didReachFinalState ivar.
(-[WKPaymentAuthorizationDelegate completePaymentSession:errors:]): Renamed from
-completePaymentSession:errors:didReachFinalState:. Stopped setting _didReachFinalState.
(-[WKPaymentAuthorizationDelegate invalidate]): Changed to call
-completePaymentSession:errors:.
(-[WKPaymentAuthorizationDelegate _didAuthorizePayment:completion:]): Ditto.
(-[WKPaymentAuthorizationDelegate _didFinish]): Stopped passing the value of
_didReachFinalState to PaymentAuthorizationPresenter::Client::presenterDidFinish.
(-[WKPaymentAuthorizationDelegate completePaymentSession:errors:didReachFinalState:]):
Renamed to -completePaymentSession:errors:.

* Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:
(WebKit::WebPaymentCoordinatorProxy::showPaymentUI): Replaced calls to
didCancelPaymentSession with didReachFinalState.
(WebKit::WebPaymentCoordinatorProxy::completePaymentSession): Set m_state to Completing
rather than call didReachFinalState.
(WebKit::WebPaymentCoordinatorProxy::abortPaymentSession): Removed call to hidePaymentUI
since didReachFinalState was already being called.
(WebKit::WebPaymentCoordinatorProxy::cancelPaymentSession): Replaced call to
didCancelPaymentSession with didReachFinalState.
(WebKit::WebPaymentCoordinatorProxy::presenterDidFinish): Called didReachFinalState
unconditionally now that the didReachFinalState boolean has been removed.
(WebKit::WebPaymentCoordinatorProxy::canBegin const): Returned false for State::Completing.
(WebKit::WebPaymentCoordinatorProxy::canCancel const): Ditto.
(WebKit::WebPaymentCoordinatorProxy::canCompletePayment const): Ditto.
(WebKit::WebPaymentCoordinatorProxy::canAbort const): Ditto.
(WebKit::WebPaymentCoordinatorProxy::didReachFinalState): Added an early return if m_state
is already Idle. Sent the DidCancelPaymentSession message if canCancel is true. Called
platformHidePaymentUI before clearing m_authorizationPresenter and setting m_state to Idle.
(WebKit::WebPaymentCoordinatorProxy::didCancelPaymentSession): Deleted.

* Shared/ApplePay/WebPaymentCoordinatorProxy.h:
(WebKit::WebPaymentCoordinatorProxy::didReachFinalState): Added a PaymentSessionError&& arg.
(WebKit::WebPaymentCoordinatorProxy::didCancelPaymentSession): Deleted.

* Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::~WebPaymentCoordinatorProxy): Replaced call to
hidePaymentUI with didReachFinalState.

* Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:
(WebKit::WebPaymentCoordinatorProxy::platformHidePaymentUI): Renamed from hidePaymentUI.
Stopped clearing m_authorizationPresenter since didReachFinalState now does that.
(WebKit::WebPaymentCoordinatorProxy::hidePaymentUI): Renamed to platformHidePaymentUI.

* Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): Removed call to hidePaymentUI
since didReachFinalState was already being called.
(WebKit::WebPaymentCoordinatorProxy::platformHidePaymentUI): Renamed from hidePaymentUI.
Stopped clearing m_authorizationPresenter since didReachFinalState now does that.
(WebKit::WebPaymentCoordinatorProxy::hidePaymentUI): Renamed to platformHidePaymentUI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoVersioning.
alancoon@apple.com [Tue, 23 Jun 2020 22:32:47 +0000 (22:32 +0000)]
Versioning.

WebKit-610.1.20

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoRemove a lot of unnecessary calls to Ref::copyRef()
cdumez@apple.com [Tue, 23 Jun 2020 22:02:24 +0000 (22:02 +0000)]
Remove a lot of unnecessary calls to Ref::copyRef()
https://bugs.webkit.org/show_bug.cgi?id=213533

Reviewed by Darin Adler.

Remove a lot of unnecessary calls to Ref::copyRef() now that Ref is copyable.

Source/WebCore:

* Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::addAll):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBTransaction::requestGetAllObjectStoreRecords):
(WebCore::IDBTransaction::requestGetAllIndexRecords):
(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::requestCount):
(WebCore::IDBTransaction::requestDeleteRecord):
(WebCore::IDBTransaction::requestClearObjectStore):
(WebCore::IDBTransaction::requestPutOrAdd):
* Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::create):
* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::Source::create):
* Modules/webdatabase/Database.cpp:
(WebCore::Database::scheduleTransactionCallback):
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpgradeURL):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeAsynchronousUserAgentScriptInWorld):
* crypto/SubtleCrypto.cpp:
(WebCore::SubtleCrypto::wrapKey):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::create):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::startAsyncDecodingQueue):
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
* platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::wrapCryptoKey):
(WebCore::WorkerGlobalScope::unwrapCryptoKey):
* workers/service/WorkerSWClientConnection.cpp:
(WebCore::WorkerSWClientConnection::matchRegistration):
(WebCore::WorkerSWClientConnection::getRegistrations):
(WebCore::WorkerSWClientConnection::whenRegistrationReady):
(WebCore::WorkerSWClientConnection::scheduleUnregisterJobInServer):
* workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFireFetchEvent):
(WebCore::ServiceWorkerThread::queueTaskToPostMessage):
(WebCore::ServiceWorkerThread::queueTaskToFireInstallEvent):
(WebCore::ServiceWorkerThread::queueTaskToFireActivateEvent):

Source/WebDriver:

* Session.cpp:
(WebDriver::Session::go):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::getTitle):
(WebDriver::Session::newWindow):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::setWindowRect):
(WebDriver::Session::maximizeWindow):
(WebDriver::Session::minimizeWindow):
(WebDriver::Session::fullscreenWindow):
(WebDriver::Session::findElements):
(WebDriver::Session::getActiveElement):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::getElementRect):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::getElementProperty):
(WebDriver::Session::getElementCSSValue):
(WebDriver::Session::elementClick):
(WebDriver::Session::elementClear):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::getPageSource):
(WebDriver::Session::executeScript):
(WebDriver::Session::getAllCookies):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
(WebDriver::Session::performActions):
(WebDriver::Session::takeScreenshot):

Source/WebKit:

* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::requestResource):
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::CompletionHandler<void):
* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::hasStorageAccess):
(WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsMemoryStore::clear):
(WebKit::ResourceLoadStatisticsMemoryStore::updateCookieBlocking):
* NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::removeDataRecords):
(WebKit::ResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::ResourceLoadStatisticsStore::updateCookieBlockingForDomains):
(WebKit::ResourceLoadStatisticsStore::removeAllStorageAccess):
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::renameOriginInWebsiteData):
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::fetchDirectoryEntries):
(WebKit::CacheStorage::Engine::clearAllCaches):
(WebKit::CacheStorage::Engine::clearCachesForOrigin):
(WebKit::CacheStorage::Engine::clearCachesForOriginFromDirectories):
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::clearDiskCache):
* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::clearDiskCache):
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreStatisticsResetToConsistentState):
* UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _takeViewSnapshot]):
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::resolveChildFrameHandle):
(WebKit::WebAutomationSession::resolveParentFrameHandle):
(WebKit::WebAutomationSession::computeElementLayout):
(WebKit::WebAutomationSession::selectOptionElement):
(WebKit::WebAutomationSession::setFilesForInputFileUpload):
(WebKit::WebAutomationSession::getAllCookies):
(WebKit::WebAutomationSession::deleteSingleCookie):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::takeScreenshot):
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleSynchronousMessage):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
(WebKit::WebPageProxy::didReceiveAuthenticationChallengeProxy):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigationInternal):
(WebKit::WebProcessPool::seedResourceLoadStatisticsForTesting):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setMaxStatisticsEntries):
(WebKit::WebsiteDataStore::setPruneEntriesDownTo):
(WebKit::WebsiteDataStore::setGrandfatheringTime):
(WebKit::WebsiteDataStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebsiteDataStore::setPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResourceForDebugMode):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameDomain):
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameDomain):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectTo):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectTo):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebsiteDataStore::clearPrevalentResource):
(WebKit::WebsiteDataStore::resetParametersToDefaultValues):
(WebKit::WebsiteDataStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
(WebKit::WebsiteDataStore::scheduleCookieBlockingUpdate):
(WebKit::WebsiteDataStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebsiteDataStore::setLastSeen):
(WebKit::WebsiteDataStore::mergeStatisticForTesting):
(WebKit::WebsiteDataStore::insertExpiredStatisticForTesting):
(WebKit::WebsiteDataStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebsiteDataStore::setIsRunningResourceLoadStatisticsTest):
(WebKit::WebsiteDataStore::setNotifyPagesWhenTelemetryWasCaptured):
(WebKit::WebsiteDataStore::setTimeToLiveUserInteraction):
(WebKit::WebsiteDataStore::logUserInteraction):
(WebKit::WebsiteDataStore::clearUserInteraction):
(WebKit::WebsiteDataStore::setGrandfathered):
(WebKit::WebsiteDataStore::setUseITPDatabase):
(WebKit::WebsiteDataStore::setCrossSiteLoadWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::resetCrossSiteLoadsWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::deleteCookiesForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldDowngradeReferrerForTesting):
(WebKit::WebsiteDataStore::setThirdPartyCookieBlockingMode):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldEnbleSameSiteStrictEnforcementForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsToSameSiteStrictCookiesForTesting):
(WebKit::WebsiteDataStore::setCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::resetCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebsiteDataStore::resetQuota):
(WebKit::WebsiteDataStore::clearAppBoundSession):
(WebKit::WebsiteDataStore::renameOriginInWebsiteData):
(WebKit::WebsiteDataStore::forwardAppBoundDomainsToITPIfInitialized):
(WebKit::WebsiteDataStore::setAppBoundDomainsForITP):
(WebKit::WebsiteDataStore::updateBundleIdentifierInNetworkProcess):
(WebKit::WebsiteDataStore::clearBundleIdentifierInNetworkProcess):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::markAllLayersVolatile):

Source/WTF:

* wtf/glib/SocketConnection.cpp:
(WTF::SocketConnection::waitForSocketWritability):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoRemove expectation for animations/missing-values-first-keyframe.html and animations...
tsavell@apple.com [Tue, 23 Jun 2020 21:38:43 +0000 (21:38 +0000)]
Remove expectation for animations/missing-values-first-keyframe.html and animations/missing-values-last-keyframe.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=190032

Unreviewed test gardening.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[curl] Unreviewed build fix for r263407
Hironori.Fujii@sony.com [Tue, 23 Jun 2020 21:06:16 +0000 (21:06 +0000)]
[curl] Unreviewed build fix for r263407
https://bugs.webkit.org/show_bug.cgi?id=213409
<rdar://problem/64654646>

* NetworkProcess/curl/NetworkDataTaskCurl.h: Include <wtf/MonotonicTime.h>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoRemove WKkIsTranslated once our bots are updated to the needed SDK
sbarati@apple.com [Tue, 23 Jun 2020 20:11:37 +0000 (20:11 +0000)]
Remove WKkIsTranslated once our bots are updated to the needed SDK
https://bugs.webkit.org/show_bug.cgi?id=213489

Reviewed by Tim Horton.

We can use the "sysctl.proc_translated" sysctl instead.

* WTF.xcodeproj/project.pbxproj:
* wtf/TranslatedProcess.cpp: Added.
(WTF::isX86BinaryRunningOnARM):
* wtf/TranslatedProcess.h:
(WTF::isX86BinaryRunningOnARM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ews] Allow archiving 'jsc' product
dpino@igalia.com [Tue, 23 Jun 2020 19:51:54 +0000 (19:51 +0000)]
[ews] Allow archiving 'jsc' product
https://bugs.webkit.org/show_bug.cgi?id=213518

Reviewed by Aakash Jain.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoVersioning.
alancoon@apple.com [Tue, 23 Jun 2020 19:34:23 +0000 (19:34 +0000)]
Versioning.

WebKit-610.1.19

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoExpose already-available WKNavigationAction.request.HTTPBody through the API
commit-queue@webkit.org [Tue, 23 Jun 2020 19:00:10 +0000 (19:00 +0000)]
Expose already-available WKNavigationAction.request.HTTPBody through the API
https://bugs.webkit.org/show_bug.cgi?id=179077

Patch by Alex Christensen <achristensen@webkit.org> on 2020-06-23
Reviewed by Brady Eidson.

Source/WebKit:

When this bug was written, we needed to serialize the HTTP body to the UI process to expose it through the API.
The controversial part of this was done in r237639, so this just exposes the data that is already available.

Verified by an API test.

* UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction request]):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoDrop AudioContextBase class
cdumez@apple.com [Tue, 23 Jun 2020 18:59:47 +0000 (18:59 +0000)]
Drop AudioContextBase class
https://bugs.webkit.org/show_bug.cgi?id=213522

Reviewed by Geoffrey Garen.

Drop AudioContextBase class and have WebKitAudioContext subclass the new BaseAudioContext class instead.
We recently introduced BaseAudioContext to match the specification and keeping AudioContextBase is now confusing.

No new tests, this simplifies our code but there is no Web-facing behavior change.

* Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::AnalyserNode):
* Modules/webaudio/AnalyserNode.h:
* Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
* Modules/webaudio/AudioBasicInspectorNode.h:
* Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
* Modules/webaudio/AudioBasicProcessorNode.h:
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::setBuffer):
* Modules/webaudio/AudioBufferSourceNode.h:
* Modules/webaudio/AudioContext.cpp:
* Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
* Modules/webaudio/AudioDestinationNode.h:
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::enableOutputsIfNecessary):
* Modules/webaudio/AudioNode.h:
(WebCore::AudioNode::context):
(WebCore::AudioNode::context const):
* Modules/webaudio/AudioNode.idl:
* Modules/webaudio/AudioNodeOutput.h:
(WebCore::AudioNodeOutput::context):
* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::AudioParam):
* Modules/webaudio/AudioParam.h:
* Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valueForContextTime):
* Modules/webaudio/AudioParamTimeline.h:
* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
* Modules/webaudio/AudioScheduledSourceNode.h:
* Modules/webaudio/AudioSummingJunction.cpp:
(WebCore::AudioSummingJunction::AudioSummingJunction):
* Modules/webaudio/AudioSummingJunction.h:
(WebCore::AudioSummingJunction::context):
* Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::BaseAudioContext):
(WebCore::BaseAudioContext::document const):
(WebCore::BaseAudioContext::scriptExecutionContext const):
* Modules/webaudio/BaseAudioContext.h:
(WebCore::BaseAudioContext::isOfflineContext const):
(WebCore::BaseAudioContext::isWebKitAudioContext const):
(WebCore::BaseAudioContext::currentSampleFrame const):
(WebCore::BaseAudioContext::currentTime const):
(WebCore::BaseAudioContext::sampleRate const):
(WebCore::BaseAudioContext::incrementConnectionCount):
(WebCore::BaseAudioContext::setAudioThread):
(WebCore::BaseAudioContext::isAudioThreadFinished):
(WebCore::BaseAudioContext::behaviorRestrictions const):
(WebCore::BaseAudioContext::addBehaviorRestriction):
(WebCore::BaseAudioContext::removeBehaviorRestriction):
(WebCore::BaseAudioContext::nextAudioNodeLogIdentifier):
(WebCore::BaseAudioContext::nextAudioParameterLogIdentifier):
(WebCore::BaseAudioContext::isStopped const):
(WebCore::BaseAudioContext::AutoLocker::AutoLocker):
(WebCore::BaseAudioContext::AutoLocker::~AutoLocker):
* Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
* Modules/webaudio/BiquadFilterNode.h:
* Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
* Modules/webaudio/BiquadProcessor.h:
* Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::create):
(WebCore::ChannelMergerNode::ChannelMergerNode):
* Modules/webaudio/ChannelMergerNode.h:
* Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::create):
(WebCore::ChannelSplitterNode::ChannelSplitterNode):
* Modules/webaudio/ChannelSplitterNode.h:
* Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
* Modules/webaudio/ConvolverNode.h:
* Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
* Modules/webaudio/DefaultAudioDestinationNode.h:
* Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
(WebCore::DelayNode::create):
* Modules/webaudio/DelayNode.h:
* Modules/webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor):
* Modules/webaudio/DelayProcessor.h:
* Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
* Modules/webaudio/DynamicsCompressorNode.h:
* Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
* Modules/webaudio/GainNode.h:
* Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::setFormat):
* Modules/webaudio/MediaElementAudioSourceNode.h:
* Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::create):
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
* Modules/webaudio/MediaStreamAudioDestinationNode.h:
* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
* Modules/webaudio/MediaStreamAudioSourceNode.h:
* Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
* Modules/webaudio/OfflineAudioDestinationNode.h:
* Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::create):
(WebCore::OscillatorNode::OscillatorNode):
* Modules/webaudio/OscillatorNode.h:
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNodeBase::PannerNodeBase):
* Modules/webaudio/PannerNode.h:
* Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::create):
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
* Modules/webaudio/ScriptProcessorNode.h:
* Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
* Modules/webaudio/WaveShaperNode.h:
* Modules/webaudio/WebKitAudioContext.cpp:
(WebCore::WebKitAudioContext::WebKitAudioContext):
(WebCore::WebKitAudioContext::createMediaElementSource):
(WebCore::WebKitAudioContext::createMediaStreamSource):
(WebCore::WebKitAudioContext::createMediaStreamDestination):
(WebCore::WebKitAudioContext::createWebKitPanner):
(WebCore::WebKitAudioContext::close):
* Modules/webaudio/WebKitAudioContext.h:
(isType):
* Modules/webaudio/WebKitAudioContext.idl:
* dom/EventTargetFactory.in:
* testing/Internals.cpp:
(WebCore::Internals::setAudioContextRestrictions):
* testing/Internals.h:
* testing/Internals.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoHandle string overflow in DFG graph dump while validating AI.
mark.lam@apple.com [Tue, 23 Jun 2020 18:49:03 +0000 (18:49 +0000)]
Handle string overflow in DFG graph dump while validating AI.
https://bugs.webkit.org/show_bug.cgi?id=213524
<rdar://problem/64635620>

Not reviewed.

Applying refinement suggested by Darin in https://bugs.webkit.org/show_bug.cgi?id=213524#c3.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::validateAIState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoRemove unnecessary Timer from NetworkDataTask
commit-queue@webkit.org [Tue, 23 Jun 2020 18:41:06 +0000 (18:41 +0000)]
Remove unnecessary Timer from NetworkDataTask
https://bugs.webkit.org/show_bug.cgi?id=213409

Patch by Alex Christensen <achristensen@webkit.org> on 2020-06-23
Reviewed by Youenn Fablet.

* NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::NetworkDataTask):
(WebKit::NetworkDataTask::scheduleFailure):
(WebKit::NetworkDataTask::failureTimerFired): Deleted.
* NetworkProcess/NetworkDataTask.h:
* NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::resume):
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::resume):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoHandle string overflow in DFG graph dump while validating AI.
mark.lam@apple.com [Tue, 23 Jun 2020 18:15:49 +0000 (18:15 +0000)]
Handle string overflow in DFG graph dump while validating AI.
https://bugs.webkit.org/show_bug.cgi?id=213524
<rdar://problem/64635620>

Reviewed by Saam Barati.

JSTests:

* stress/string-overflow-in-dfg-graph-dump.js: Added.

Source/JavaScriptCore:

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::validateAIState):

Source/WTF:

* wtf/StringPrintStream.cpp:
(WTF::StringPrintStream::tryToString):
* wtf/StringPrintStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WPE] Unreviewed test gardening. Move flaky failures happening in WPE from GTK to...
dpino@igalia.com [Tue, 23 Jun 2020 18:01:29 +0000 (18:01 +0000)]
[WPE] Unreviewed test gardening. Move flaky failures happening in WPE from GTK to GLIB after r263402.

* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WebXR] Introducing XRLayer
svillar@igalia.com [Tue, 23 Jun 2020 16:36:02 +0000 (16:36 +0000)]
[WebXR] Introducing XRLayer
https://bugs.webkit.org/show_bug.cgi?id=213462

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/webxr/idlharness.https.window-expected.txt: Replace FAIL by PASS expectations
for XRLayer interface.

Source/WebCore:

The most recent drafts of the WebXR spec have added a new object called XRLayer which is the base class
of the already known XRWebGLLayer. The spec only defines the latter but future extensions might define
some other layer subclasses.

This patch fixes several checks in the IDL tests.

* CMakeLists.txt: Added new files.
* DerivedSources.make: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* Modules/webxr/WebXRLayer.cpp: Added.
(WebCore::WebXRLayer::WebXRLayer):
* Modules/webxr/WebXRLayer.h: Ditto.
* Modules/webxr/WebXRLayer.idl:  Ditto.
* Modules/webxr/WebXRSession.h: Export scriptExecutionContext() so it could be used from the outside.
* Modules/webxr/WebXRWebGLLayer.cpp:
(WebCore::WebXRWebGLLayer::WebXRWebGLLayer): Call the superclass.
* Modules/webxr/WebXRWebGLLayer.h: Inherit from WebXRLayer.
* Modules/webxr/WebXRWebGLLayer.idl: Ditto.
* Sources.txt: Added new files.
* bindings/js/WebCoreBuiltinNames.h: Added XRLayer.
* dom/EventTargetFactory.in: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWeb Inspector: adjust height of undocked title area to match macOS Big Sur
drousso@apple.com [Tue, 23 Jun 2020 16:15:04 +0000 (16:15 +0000)]
Web Inspector: adjust height of undocked title area to match macOS Big Sur
https://bugs.webkit.org/show_bug.cgi?id=213490

Reviewed by Brian Burg.

* UserInterface/Views/Variables.css:
(body.mac-platform.big-sur:not(.docked)):
The title bar height is based on the close/minimize/maximize buttons, not the title text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[GStreamer] Add GStreamer patch to fix EWS glupload racy crash
aboya@igalia.com [Tue, 23 Jun 2020 16:14:45 +0000 (16:14 +0000)]
[GStreamer] Add GStreamer patch to fix EWS glupload racy crash
https://bugs.webkit.org/show_bug.cgi?id=210498

Reviewed by Philippe Normand.

This WebKit patch backports a patch from GStreamer 1.17 that prevents
the crashes in the attached bug to our flatpak build.

* buildstream/elements/sdk/gst-plugins-base.bst:
* buildstream/patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoKeyframe animation doesn't 't show up in the Animations timeline
drousso@apple.com [Tue, 23 Jun 2020 16:12:36 +0000 (16:12 +0000)]
Keyframe animation doesn't 't show up in the Animations timeline
https://bugs.webkit.org/show_bug.cgi?id=213441

Reviewed by Brian Burg.

Source/JavaScriptCore:

* inspector/protocol/Animation.json:
An `interationCount` of `Infinity` is not JSON serializable, so represent it as `-1` instead.

Source/WebCore:

Test: inspector/animation/lifecycle-css-animation.html

* inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::buildObjectForEffect):

Source/WebInspectorUI:

* UserInterface/Models/Animation.js:
(WI.Animation):
(WI.Animation.prototype._updateEffect):
An `interationCount` of `Infinity` is not JSON serializable, so represent it as `-1` instead.

* UserInterface/Models/MediaTimelineRecord.js:
(WI.MediaTimelineRecord):
* UserInterface/Views/MediaTimelineDataGridNode.js:
(WI.MediaTimelineDataGridNode.prototype.createCellContent):
(WI.MediaTimelineDataGridNode.prototype.filterableDataForColumn):
The DOM node may not be able to be instrumented if the timeline recording starts before the
frontend has had a chance to request the main document, so it's possible for the DOM node
to not be set.

LayoutTests:

* inspector/animation/resources/lifecycle-utilities.js:
* inspector/animation/lifecycle-css-animation.html:
* inspector/animation/lifecycle-css-animation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[css-flex] Allow indefinite size flex items to be definite wrt resolving percentages...
svillar@igalia.com [Tue, 23 Jun 2020 15:56:18 +0000 (15:56 +0000)]
[css-flex] Allow indefinite size flex items to be definite wrt resolving percentages inside them
https://bugs.webkit.org/show_bug.cgi?id=212264

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-flexbox/percentage-heights-003-expected.txt: There were 3 subtests
marked as failures. All of them work fine now.

Source/WebCore:

Implement https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8 which modified
the way percentages were resolved in flexible items with indefinite sizes. From now on we can pretend that
they're really definite.

This allows us to mark 3 tests which were testing percentages in flex items as correct.

Based on Blink's crrev.com/1247184 by <cbiesinger@chromium.org>

This is a reland of r262124 which got reverted due to the bug fixed in r263389.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution): Do only check flex container main size
definiteness when computing the main size for percentage resolution, no need to check flex basis at all.

LayoutTests:

* css3/flexbox/definite-main-size-expected.txt: Updated expectation.
* css3/flexbox/definite-main-size.html: Updated comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ iOS ] REGRESSION: perf/htmlcollection-backwards-iteration.html is a flaky failure
jacob_uphoff@apple.com [Tue, 23 Jun 2020 15:50:57 +0000 (15:50 +0000)]
[ iOS ] REGRESSION: perf/htmlcollection-backwards-iteration.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213520

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[flatpak] Ensure en_US.UTF-8 locale
aboya@igalia.com [Tue, 23 Jun 2020 15:48:20 +0000 (15:48 +0000)]
[flatpak] Ensure en_US.UTF-8 locale
https://bugs.webkit.org/show_bug.cgi?id=212459

Reviewed by Philippe Normand.

When developing WebKit we want as few system differences as possible
to make tests reproducible.

en_US.UTF-8 is indeed the only locale installed in our development
flatpak, but our scripts were not correctly clearing most locale
environment variables, which resulted in warnings when running some
tools (notably perl) when the user OS has a different locale.

This patch ensures all locale environment variables are cleared and
LANG is set to en_US.UTF-8. It also removes now redundant code from
flatpakutils.py.

* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
* flatpak/webkit-bwrap:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a...
simon.fraser@apple.com [Tue, 23 Jun 2020 15:14:11 +0000 (15:14 +0000)]
[ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213351
<rdar://problem/64502429>

Reviewed by Tim Horton.

Tools:

The variadic CGEventCreateScrollWheelEvent() seems to have an issue that causes the resulting event
to rarely put the x value into the deltaY. Change to the non-variadic CGEventCreateScrollWheelEvent2()
to avoid this.

* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):

LayoutTests:

Fix the test to use eventSender.monitorWheelEvents(). Also remove an initial 100ms timeout and
some ugly uses of "window.", and make it a proper js-test-pre/js-test-post test.

* fast/events/platform-wheelevent-in-scrolling-div-expected.txt:
* fast/events/platform-wheelevent-in-scrolling-div.html:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ iOS ] fast/backgrounds/size/backgroundSize-in-background-shorthand.html is a flaky...
jacob_uphoff@apple.com [Tue, 23 Jun 2020 14:00:29 +0000 (14:00 +0000)]
[ iOS ] fast/backgrounds/size/backgroundSize-in-background-shorthand.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213511

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WPE] Unreviewed test gardening. Move flaky failures happening in WPE from GTK to...
dpino@igalia.com [Tue, 23 Jun 2020 13:29:34 +0000 (13:29 +0000)]
[WPE] Unreviewed test gardening. Move flaky failures happening in WPE from GTK to GLIB.

* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ews] Rename 'JSCTestsFactory' to 'JSCBuildAndTestsFactory'
dpino@igalia.com [Tue, 23 Jun 2020 12:51:23 +0000 (12:51 +0000)]
[ews] Rename 'JSCTestsFactory' to 'JSCBuildAndTestsFactory'
https://bugs.webkit.org/show_bug.cgi?id=213503

Reviewed by Aakash Jain.

* BuildSlaveSupport/ews-build/config.json:
* BuildSlaveSupport/ews-build/factories.py:
(JSCBuildAndTestsFactory):
(JSCTestsFactory): Deleted.
(JSCTestsFactory.__init__): Deleted.
* BuildSlaveSupport/ews-build/loadConfig.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ews] Add JSC-Only builders for MIPS and ARMv7 architectures (follow-up fix)
aakash_jain@apple.com [Tue, 23 Jun 2020 12:05:30 +0000 (12:05 +0000)]
[ews] Add JSC-Only builders for MIPS and ARMv7 architectures (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=213366

Unreviewed follow-up fix.

Remove unused runTests parameter.
* BuildSlaveSupport/ews-build/factories.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WPE] Unreviewed test gardening. Update test expectations after r263390.
dpino@igalia.com [Tue, 23 Jun 2020 11:09:36 +0000 (11:09 +0000)]
[WPE] Unreviewed test gardening. Update test expectations after r263390.

Garden latest failures from test bot.

* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[Flatpak SDK] relax restriction on build-webkit script name
commit-queue@webkit.org [Tue, 23 Jun 2020 09:15:41 +0000 (09:15 +0000)]
[Flatpak SDK] relax restriction on build-webkit script name
https://bugs.webkit.org/show_bug.cgi?id=213432

Patch by Philippe Normand <pnormand@igalia.com> on 2020-06-23
Reviewed by Žan Doberšek.

* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): Match the build-webkit string in the whole command-line
argument and thus allow alternative implementations of build-webkit. Also let the
MAX_CPU_LOAD env var in the sandbox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoREGRESSION (r262124): Twitter videos go blank after exiting fullscreen
svillar@igalia.com [Tue, 23 Jun 2020 07:27:29 +0000 (07:27 +0000)]
REGRESSION (r262124): Twitter videos go blank after exiting fullscreen
https://bugs.webkit.org/show_bug.cgi?id=213110

Reviewed by Darin Adler.

Source/WebCore:

Test: fullscreen/video-inside-flex-item.html

Setting/unsetting position:absolute on a flex/grid item can potentially create/remove flex/grid items because
absolutely positioned children of those containers are out-of-flow and thus, do not generate flex/grid items.
Flex/grid items are potentially stretched by their containers so the style recalculation is not enough to get
a correct layout because the override size set by flex/grid containers is not reset.
In the particular case of this bug we had this hierarchy (highly simplified from twitter page):

Flexbox container
|___DIV (absolutelly positioned)
    |___<video> (height: 100% width: 100%)

When the <video> goes fullscreen the FullscreenManager replaces the
style of the DIV because it inserts a RenderFullScreen object in between
the DIV and the <video> (along with some anonymous blocks). This means
that the DIV which was not a flex item (as it was absolutely positioned)
became a flex item and thus its size is stretched as the flexbox
container mandates. When exiting fullscreen, the original style is
restored (and thus the position absolute). The DIV is then no longer a
flex item but the stretched size (overrideContentSize) is still set,
causing issues with the sizes of the <video>.

Note that it isn't possible to reproduce this bug with the current trunk because there is a bug in the flexbox
implementation (see bug 212264) preventing this to happen. However it becomes 100% reproducible with the patch for bug 212264
which is correct and fixes several tests related to wrapping in flexbox. It's also reproducible when the FULLSCREEN_API is
enabled, otherwise the codepath for full screen is totally different (there are no placeholders).

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange): clear the override sizes for grid/flex when flex/grid items become out-of-flow,
for example by changing position to absolute.

LayoutTests:

* fullscreen/video-inside-flex-item-expected.txt: Added.
* fullscreen/video-inside-flex-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoREGRESSION(r258741): [GTK] anchor-file-blob-download-includes-backslash.html is failing
carlosgc@webkit.org [Tue, 23 Jun 2020 05:55:21 +0000 (05:55 +0000)]
REGRESSION(r258741): [GTK] anchor-file-blob-download-includes-backslash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=209329

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Sanitize the suggested filename. We replace characters that can be problematic in filenames with '_' to match
what Chromium and Firefox do.

* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::sanitizeFilename):
(WebCore::ResourceResponse::platformSuggestedFilename const):

LayoutTests:

Rebaseline tests.

* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash-expected.txt: Added.
* platform/gtk/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote-expected.txt: Added.
* platform/gtk/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[GTK] MiniBrowser: set a base directory for website data and cache
carlosgc@webkit.org [Tue, 23 Jun 2020 05:51:38 +0000 (05:51 +0000)]
[GTK] MiniBrowser: set a base directory for website data and cache
https://bugs.webkit.org/show_bug.cgi?id=213368

Reviewed by Michael Catanzaro.

Stop using the default ones.

* MiniBrowser/gtk/main.c:
(activate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[GTK][WPE] Add API to configure and handle DOM cache to WebKitWebsiteDataManager
carlosgc@webkit.org [Tue, 23 Jun 2020 05:49:25 +0000 (05:49 +0000)]
[GTK][WPE] Add API to configure and handle DOM cache to WebKitWebsiteDataManager
https://bugs.webkit.org/show_bug.cgi?id=213337

Reviewed by Adrian Perez de Castro.

Source/WebKit:

The default path is always used even for apps setting a base data directory. We should handle
WebsiteDataType::DOMCache to configure the directory and allow to fetch and clear it.

* UIProcess/API/glib/WebKitWebsiteData.cpp:
(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):
* UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkitWebsiteDataManagerGetProperty):
(webkitWebsiteDataManagerSetProperty):
(webkitWebsiteDataManagerConstructed):
(webkit_website_data_manager_class_init):
(webkitWebsiteDataManagerGetDataStore):
(webkit_website_data_manager_get_dom_cache_directory):
(toWebsiteDataTypes):
* UIProcess/API/gtk/WebKitWebsiteData.h:
* UIProcess/API/gtk/WebKitWebsiteDataManager.h:
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
* UIProcess/API/wpe/WebKitWebsiteData.h:
* UIProcess/API/wpe/WebKitWebsiteDataManager.h:
* UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::websiteDataStoreFromSessionID): GTK and WPE ports don't use the default website
data store, so only use it when it already exists. Use the process pool website data store instead.

Tools:

Handle new website data in MiniBrowser and add a unit test.

* MiniBrowser/gtk/main.c:
(gotWebsiteDataCallback):
* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration):
(testWebsiteDataDOMCache):
(beforeAll):
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::Test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoAttempt to fix watchOS simulator build.
sbarati@apple.com [Tue, 23 Jun 2020 05:27:25 +0000 (05:27 +0000)]
Attempt to fix watchOS simulator build.

* assembler/FastJITPermissions.h:
(threadSelfRestrictRWXToRW):
(threadSelfRestrictRWXToRX):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ews] Add JSC-Only builders for MIPS and ARMv7 architectures
dpino@igalia.com [Tue, 23 Jun 2020 05:04:56 +0000 (05:04 +0000)]
[ews] Add JSC-Only builders for MIPS and ARMv7 architectures
https://bugs.webkit.org/show_bug.cgi?id=213366

Reviewed by Aakash Jain.

In a follow-up patch the built product of these bots will be consumed
by the EWS JSC-Only testing bots.

* BuildSlaveSupport/ews-build/config.json:
* BuildSlaveSupport/ews-build/factories.py:
(JSCBuildFactory):
(JSCBuildFactory.__init__):
* BuildSlaveSupport/ews-build/factories_unittest.py:
(TestBuildFactory):
(TestBuildFactory.test_jsc_mipsel_factory):
(TestBuildFactory.test_jsc_armv7_factory):
* BuildSlaveSupport/ews-build/loadConfig.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoStorage Access API: Add the capability to call the Storage Access API as a quirk...
wilander@apple.com [Tue, 23 Jun 2020 04:13:24 +0000 (04:13 +0000)]
Storage Access API: Add the capability to call the Storage Access API as a quirk, on behalf of websites that should be doing it themselves
https://bugs.webkit.org/show_bug.cgi?id=213418
<rdar://problem/64549429>

Reviewed by Alex Christensen.

Source/WebCore:

No new tests. This patch adds quirks for specific websites.
The general functionality that's touched has tests under
LayoutTests/http/tests/storageAccess/.

* dom/Document.h:
(WebCore::Document::isTopDocument const):
    New convenience function.
(WebCore::Document::setUserDidInteractWithPage):
    Use of the new convenience function.
(WebCore::Document::userDidInteractWithPage const):
    Use of the new convenience function.
* dom/DocumentStorageAccess.cpp:
(WebCore::DocumentStorageAccess::hasStorageAccessQuickCheck):
(WebCore::DocumentStorageAccess::hasStorageAccess):
(WebCore::DocumentStorageAccess::hasStorageAccessForDocumentQuirk):
(WebCore::DocumentStorageAccess::requestStorageAccess):
(WebCore::DocumentStorageAccess::requestStorageAccessQuickCheck):
(WebCore::DocumentStorageAccess::requestStorageAccessForDocumentQuirk):
(WebCore::DocumentStorageAccess::requestStorageAccessForNonDocumentQuirk):
(WebCore::DocumentStorageAccess::requestStorageAccessQuirk):
    These functions are split up to allow quirks to call directly into the
    implementation of the Storage Access API without the JavaScript
    promise that goes with the web API. It also allows for quirks to call
    the API without an iframe document.
* dom/DocumentStorageAccess.h:
* dom/Element.cpp:
(WebCore::Element::dispatchMouseEvent):
    The two existing quirks are for click events.
* loader/ResourceLoadObserver.h:
(WebCore::ResourceLoadObserver::setDomainsWithUserInteraction):
(WebCore::ResourceLoadObserver::hasHadUserInteraction const):
    These two new functions allow the Storage Access API quirks
    to synchronously check if it's worth calling the API or not.
    If there has been no user interaction for the requesting
    domain, there is no need to call the API.
* page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
    This is the new quirks function, hiding the specifics of
    certain elements clicked and for which websites. It also
    calls the Storage Access API.
* page/Quirks.h:

Source/WebKit:

These changes are for forwarding ITP's knowledge of user interaction
for specific quirks domains to the WebKit::WebProcessPool where it in
turn can be distributed to all existing and new Web Content processes.

* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::needsUserInteractionQuirk const):
(WebKit::WebResourceLoadStatisticsStore::callUpdatePrevalentDomainsToBlockCookiesForHandler):
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
* Shared/WebProcessDataStoreParameters.h:
(WebKit::WebProcessDataStoreParameters::encode const):
(WebKit::WebProcessDataStoreParameters::decode):
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::setDomainsWithUserInteraction):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::webProcessDataStoreParameters):
(WebKit::WebProcessPool::setDomainsWithUserInteraction):
* UIProcess/WebProcessPool.h:
* WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
(WebKit::WebResourceLoadObserver::hasHadUserInteraction const):
* WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setWebsiteDataStoreParameters):
(WebKit::WebProcess::setDomainsWithUserInteraction):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WebDriver][GTK] Mark two scrolling tests as fail
lmoura@igalia.com [Tue, 23 Jun 2020 04:00:42 +0000 (04:00 +0000)]
[WebDriver][GTK] Mark two scrolling tests as fail

Unreviewed test gardening.

They are failing because element.location expects Get_Element_Rect to
return page coordinates instead of the browsing context coordinates.
There an open issue at https://github.com/w3c/webdriver/issues/1533
to clarify the correct behavior. Meanwhile, we should mark them as
failure.

The change that introduced this new behavior was r262997, and its bug
is used as the reference bug for these expectations.

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoIntroduce BaseAudioContext interface
cdumez@apple.com [Tue, 23 Jun 2020 03:25:56 +0000 (03:25 +0000)]
Introduce BaseAudioContext interface
https://bugs.webkit.org/show_bug.cgi?id=213491

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

* web-platform-tests/webaudio/idlharness.https.window-expected.txt:

Source/WebCore:

Introduce BaseAudioContext interface as per W3C WebAudio specification:
- https://www.w3.org/TR/webaudio/#BaseAudioContext

No new tests, rebaselined existing test.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::close):
(WebCore::AudioContext::createMediaElementSource):
(WebCore::AudioContext::createMediaStreamSource):
(WebCore::AudioContext::createMediaStreamDestination):
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::contextForBindings const):
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/AudioNode.idl:
* Modules/webaudio/BaseAudioContext.cpp: Copied from Source/WebCore/Modules/webaudio/AudioContext.cpp.
(WebCore::BaseAudioContext::isSampleRateRangeGood):
(WebCore::AudioContextBase::AudioContextBase):
(WebCore::BaseAudioContext::BaseAudioContext):
(WebCore::BaseAudioContext::constructCommon):
(WebCore::BaseAudioContext::~BaseAudioContext):
(WebCore::BaseAudioContext::lazyInitialize):
(WebCore::BaseAudioContext::clear):
(WebCore::BaseAudioContext::uninitialize):
(WebCore::BaseAudioContext::isInitialized const):
(WebCore::BaseAudioContext::addReaction):
(WebCore::BaseAudioContext::setState):
(WebCore::BaseAudioContext::stop):
(WebCore::BaseAudioContext::suspend):
(WebCore::BaseAudioContext::resume):
(WebCore::BaseAudioContext::activeDOMObjectName const):
(WebCore::AudioContextBase::document const):
(WebCore::BaseAudioContext::hostingDocumentIdentifier const):
(WebCore::BaseAudioContext::isSuspended const):
(WebCore::BaseAudioContext::visibilityStateChanged):
(WebCore::BaseAudioContext::wouldTaintOrigin const):
(WebCore::BaseAudioContext::createBuffer):
(WebCore::BaseAudioContext::decodeAudioData):
(WebCore::BaseAudioContext::createBufferSource):
(WebCore::BaseAudioContext::createScriptProcessor):
(WebCore::BaseAudioContext::createBiquadFilter):
(WebCore::BaseAudioContext::createWaveShaper):
(WebCore::BaseAudioContext::createPanner):
(WebCore::BaseAudioContext::createConvolver):
(WebCore::BaseAudioContext::createDynamicsCompressor):
(WebCore::BaseAudioContext::createAnalyser):
(WebCore::BaseAudioContext::createGain):
(WebCore::BaseAudioContext::createDelay):
(WebCore::BaseAudioContext::createChannelSplitter):
(WebCore::BaseAudioContext::createChannelMerger):
(WebCore::BaseAudioContext::createOscillator):
(WebCore::BaseAudioContext::createPeriodicWave):
(WebCore::BaseAudioContext::notifyNodeFinishedProcessing):
(WebCore::BaseAudioContext::derefFinishedSourceNodes):
(WebCore::BaseAudioContext::refNode):
(WebCore::BaseAudioContext::derefNode):
(WebCore::BaseAudioContext::derefUnfinishedSourceNodes):
(WebCore::BaseAudioContext::lock):
(WebCore::BaseAudioContext::tryLock):
(WebCore::BaseAudioContext::unlock):
(WebCore::BaseAudioContext::isAudioThread const):
(WebCore::BaseAudioContext::isGraphOwner const):
(WebCore::BaseAudioContext::addDeferredFinishDeref):
(WebCore::BaseAudioContext::handlePreRenderTasks):
(WebCore::BaseAudioContext::handlePostRenderTasks):
(WebCore::BaseAudioContext::handleDeferredFinishDerefs):
(WebCore::BaseAudioContext::markForDeletion):
(WebCore::BaseAudioContext::scheduleNodeDeletion):
(WebCore::BaseAudioContext::deleteMarkedNodes):
(WebCore::BaseAudioContext::markSummingJunctionDirty):
(WebCore::BaseAudioContext::removeMarkedSummingJunction):
(WebCore::BaseAudioContext::eventTargetInterface const):
(WebCore::BaseAudioContext::markAudioNodeOutputDirty):
(WebCore::BaseAudioContext::handleDirtyAudioSummingJunctions):
(WebCore::BaseAudioContext::handleDirtyAudioNodeOutputs):
(WebCore::BaseAudioContext::addAutomaticPullNode):
(WebCore::BaseAudioContext::removeAutomaticPullNode):
(WebCore::BaseAudioContext::updateAutomaticPullNodes):
(WebCore::BaseAudioContext::processAutomaticPullNodes):
(WebCore::AudioContextBase::scriptExecutionContext const):
(WebCore::BaseAudioContext::nodeWillBeginPlayback):
(WebCore::shouldDocumentAllowWebAudioToAutoPlay):
(WebCore::BaseAudioContext::willBeginPlayback):
(WebCore::BaseAudioContext::willPausePlayback):
(WebCore::BaseAudioContext::startRendering):
(WebCore::BaseAudioContext::mediaCanStart):
(WebCore::BaseAudioContext::mediaState const):
(WebCore::BaseAudioContext::pageMutedStateDidChange):
(WebCore::BaseAudioContext::isPlayingAudioDidChange):
(WebCore::BaseAudioContext::finishedRendering):
(WebCore::BaseAudioContext::dispatchEvent):
(WebCore::BaseAudioContext::incrementActiveSourceCount):
(WebCore::BaseAudioContext::decrementActiveSourceCount):
(WebCore::BaseAudioContext::suspendRendering):
(WebCore::BaseAudioContext::resumeRendering):
(WebCore::BaseAudioContext::suspendPlayback):
(WebCore::BaseAudioContext::mayResumePlayback):
(WebCore::BaseAudioContext::postTask):
(WebCore::BaseAudioContext::origin const):
(WebCore::BaseAudioContext::addConsoleMessage):
(WebCore::BaseAudioContext::clearPendingActivity):
(WebCore::BaseAudioContext::makePendingActivity):
(WebCore::BaseAudioContext::logChannel const):
* Modules/webaudio/BaseAudioContext.h: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.
(WebCore::AudioContextBase::AutoLocker::AutoLocker):
(WebCore::AudioContextBase::AutoLocker::~AutoLocker):
(WebCore::BaseAudioContext::destination):
(WebCore::BaseAudioContext::activeSourceCount const):
(WebCore::BaseAudioContext::listener):
(WebCore::BaseAudioContext::state const):
(WebCore::BaseAudioContext::isClosed const):
(WebCore::BaseAudioContext::connectionCount const):
(WebCore::BaseAudioContext::audioThread const):
(WebCore::BaseAudioContext::maxNumberOfChannels):
(WebCore::BaseAudioContext::destinationNode const):
(WebCore::BaseAudioContext::userGestureRequiredForAudioStart const):
(WebCore::BaseAudioContext::pageConsentRequiredForAudioStart const):
(isType):
* Modules/webaudio/BaseAudioContext.idl: Copied from Source/WebCore/Modules/webaudio/AudioContext.idl.
* Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::OfflineAudioContext):
* Modules/webaudio/OfflineAudioContext.h:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
* Modules/webaudio/PannerNode.h:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* dom/EventTargetFactory.in:
* testing/Internals.cpp:
(WebCore::Internals::setAudioContextRestrictions):
* testing/Internals.h:
* testing/Internals.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoAllow building JavaScriptCore Mac+arm64 in public SDK build
sbarati@apple.com [Tue, 23 Jun 2020 01:28:17 +0000 (01:28 +0000)]
Allow building JavaScriptCore Mac+arm64 in public SDK build
https://bugs.webkit.org/show_bug.cgi?id=213472

Reviewed by Sam Weinig.

.:

* Source/cmake/OptionsFTW.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

We used to only builld code for fast permission switching when using the
Apple internal SDK. However, with arm64 on macOS, this is no longer a viable
implementation strategy.

This patch makes it so we can build JSC on macOS+arm64 using the public Xcode
SDK.

- ENABLE_FAST_JIT_PERMISSIONS is removed. We now use runtime checks instead.
- In the new suite of OS betas, pthreads has added API for fast permissions
  switching. We now use this API instead of using the non-public SDK found in
  the kernel headers.
- We fall back to the separated W/X heaps when fast permissions checking is
  not supported. This all happens at runtime.

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::fillNops):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::fillNops):
* assembler/FastJITPermissions.h: Added.
(useFastJITPermissions):
(threadSelfRestrictRWXToRW):
(threadSelfRestrictRWXToRX):
(fastJITPermissionsIsSupported):
* assembler/LinkBuffer.cpp:
(JSC::memcpyWrapper):
(JSC::LinkBuffer::copyCompactAndLinkCode):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::fillNops):
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::link):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::link):
* jit/ExecutableAllocator.cpp:
(JSC::initializeJITPageReservation):
* jit/ExecutableAllocator.h:
(JSC::performJITMemcpy):
(JSC::useFastJITPermissions): Deleted.
* runtime/JSCConfig.h:
* runtime/Options.cpp:
(JSC::Options::recomputeDependentOptions):
* runtime/OptionsList.h:

Source/WTF:

* wtf/PlatformEnable.h:
* wtf/PlatformEnableCocoa.h:
* wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[Win] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html...
Hironori.Fujii@sony.com [Tue, 23 Jun 2020 01:23:10 +0000 (01:23 +0000)]
[Win] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=213452

Reviewed by Yusuke Suzuki.

Tools:

If window.alert() was given an invalid UTF-16 sequence, Windows
DumpRenderTree output it without any conversions. It should output
"(null)" to match with WebKitTestRunner behavior.

* DumpRenderTree/win/UIDelegate.cpp:
(toMessage): Added
(UIDelegate::runJavaScriptAlertPanelWithMessage):
(UIDelegate::runJavaScriptConfirmPanelWithMessage):
(UIDelegate::runJavaScriptTextInputPanelWithPrompt):
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
(UIDelegate::setStatusText):

LayoutTests:

* platform/win/fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash-expected.txt: Removed.
* platform/wincairo/fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoAXIsolatedTree::generateSubtree should properly assign the generated subtree to its...
andresg_22@apple.com [Mon, 22 Jun 2020 23:54:58 +0000 (23:54 +0000)]
AXIsolatedTree::generateSubtree should properly assign the generated subtree to its parent node.
https://bugs.webkit.org/show_bug.cgi?id=213435

Reviewed by Darin Adler.

AXIsolatedTree::generateSubtree now properly updates the children IDs
of the parent node of the subtree being generated.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::generateIsolatedTree):
* accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildrenIDs):
(WebCore::AXIsolatedTree::generateSubtree): Takes the parent object
instead of the parent ID. This allows to retrieve the children IDs of
the parent object.
(WebCore::AXIsolatedTree::createSubtree):
(WebCore::AXIsolatedTree::updateSubtree):
(WebCore::AXIsolatedTree::updateChildren):
(WebCore::AXIsolatedTree::setRootNode):
(WebCore::AXIsolatedTree::removeSubtree):
(WebCore::AXIsolatedTree::appendNodeChanges): R-value parameter instead
of by reference.
* accessibility/isolatedtree/AXIsolatedTree.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWeb Inspector: adjust height of undocked title area to match macOS Big Sur
drousso@apple.com [Mon, 22 Jun 2020 23:44:22 +0000 (23:44 +0000)]
Web Inspector: adjust height of undocked title area to match macOS Big Sur
https://bugs.webkit.org/show_bug.cgi?id=213490

Reviewed by Timothy Hatcher.

* UserInterface/Views/Variables.css:
(body.mac-platform:not(.big-sur):not(.docked)): Added.
(body.mac-platform.big-sur:not(.docked)): Added.
(body.mac-platform:not(.docked)): Deleted.

* UserInterface/Base/Platform.js:
Add logic for detecting macOS Big Sur (and Catalina).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWeb Inspector: Elements: Node: use a `WI.ContextMenu` instead of a `<select>` for...
drousso@apple.com [Mon, 22 Jun 2020 23:43:47 +0000 (23:43 +0000)]
Web Inspector: Elements: Node: use a `WI.ContextMenu` instead of a `<select>` for listener filtering
https://bugs.webkit.org/show_bug.cgi?id=213492

Reviewed by Timothy Hatcher.

* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WI.DOMNodeDetailsSidebarPanel.prototype.initialLayout):
(WI.DOMNodeDetailsSidebarPanel.prototype._populateEventListenersFilterContextMenu): Added.
* UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter > select): Deleted.

* Localizations/en.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agolibwebrtc fails to build on arm64
timothy_horton@apple.com [Mon, 22 Jun 2020 23:42:01 +0000 (23:42 +0000)]
libwebrtc fails to build on arm64
https://bugs.webkit.org/show_bug.cgi?id=213476

Reviewed by Maciej Stachowiak.

* Configurations/libvpx.xcconfig:
* Configurations/libwebrtc.xcconfig:
* Configurations/opus.xcconfig:
Use architecture conditionals instead of SDK conditionals for code that is
architecture-dependent.

Remove an macOS-version-dependent definition of EXCLUDED_SOURCE_FILE_NAMES
which is no longer used after r232665.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[macOS] WebPageProxy::setPromisedDataForImage should sanitize its filename
wenson_hsieh@apple.com [Mon, 22 Jun 2020 23:01:51 +0000 (23:01 +0000)]
[macOS] WebPageProxy::setPromisedDataForImage should sanitize its filename
https://bugs.webkit.org/show_bug.cgi?id=213486
<rdar://problem/56522262>

Reviewed by Megan Gardner.

Ensure that the filename passed into WebPageProxy::setPromisedDataForImage is sanitized in the UI process prior
to being used as a suggested filename when writing a dragged image to the pasteboard.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setPromisedDataForImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWebEx can not share video from Safari on arm64
timothy_horton@apple.com [Mon, 22 Jun 2020 22:25:43 +0000 (22:25 +0000)]
WebEx can not share video from Safari on arm64
https://bugs.webkit.org/show_bug.cgi?id=213481

Reviewed by Dean Jackson.

* UIProcess/UserMediaProcessManager.cpp:
(WebKit::needsAppleCameraService):
(WebKit::UserMediaProcessManager::willCreateMediaStream):
(WebKit::UserMediaProcessManager::revokeSandboxExtensionsIfNeeded):
Pass sandbox extension for "com.apple.applecamerad" to the Web Content
process after the user allows camera access, when running on hardware which requires it.

* WebProcess/com.apple.WebProcess.sb.in:
Make it possible to dynamically extend the sandbox as above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoCannot play back encrypted media on arm64
timothy_horton@apple.com [Mon, 22 Jun 2020 22:17:58 +0000 (22:17 +0000)]
Cannot play back encrypted media on arm64
https://bugs.webkit.org/show_bug.cgi?id=213483

Reviewed by Jer Noble and Per Arne Vollan.

* WebProcess/com.apple.WebProcess.sb.in:
Extend the sandbox as necessary for encrypted media support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoOnly use vm_kernel_page_size on arm architectures
sbarati@apple.com [Mon, 22 Jun 2020 22:17:57 +0000 (22:17 +0000)]
Only use vm_kernel_page_size on arm architectures
https://bugs.webkit.org/show_bug.cgi?id=213474

Reviewed by Sam Weinig.

We don't want to use this under catalyst.

* bmalloc/VMAllocate.h:
(bmalloc::vmPageSizePhysical):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoFix the build
timothy_horton@apple.com [Mon, 22 Jun 2020 22:17:32 +0000 (22:17 +0000)]
Fix the build

* wtf/TranslatedProcess.h:
(WTF::isX86BinaryRunningOnARM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WPE][GTK] Public API should not allow trying to register a special URI scheme
commit-queue@webkit.org [Mon, 22 Jun 2020 21:57:20 +0000 (21:57 +0000)]
[WPE][GTK] Public API should not allow trying to register a special URI scheme
https://bugs.webkit.org/show_bug.cgi?id=209900
<rdar://problem/61200217>

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2020-06-22
Reviewed by Adrian Perez de Castro

Epiphany prior to 3.36 registers a scheme handler for ftp. This introduced criticals. Let's
use g_warning() instead, and avoid hardcoding the list of disallowed schemes.

* UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_register_uri_scheme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ macOS iOS ] (r263321): TestWebKitAPI.SleepDisabler.Load & TestWebKitAPI.SleepDisabl...
jer.noble@apple.com [Mon, 22 Jun 2020 21:55:36 +0000 (21:55 +0000)]
[ macOS iOS ] (r263321): TestWebKitAPI.SleepDisabler.Load & TestWebKitAPI.SleepDisabler.Reload are constant failures
https://bugs.webkit.org/show_bug.cgi?id=213475
<rdar://problem/64603555>

Reviewed by Eric Carlson.

Looks like the SleepDisabler can come and go while the TestWebKitAPI process is spinning, so make the
Reload and Load tests more deterministic by only checking SleepDisabler after getting a "playing" message
from the WebContent process.

* TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
(SleepDisabler::runAndWaitUntilPlaying):
(SleepDisabler::loadPlayingPage):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoresultsdbpy: Make architecture differences explicit
jbedard@apple.com [Mon, 22 Jun 2020 21:53:39 +0000 (21:53 +0000)]
resultsdbpy: Make architecture differences explicit
https://bugs.webkit.org/show_bug.cgi?id=213473
<rdar://problem/64602736>

Rubber-stamped by Aakash Jain.

* resultsdbpy/resultsdbpy/view/static/js/configuration.js:
(Configuration.prototype.toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agodlopen() always fails on arm64, cannot load soft-linked libraries
timothy_horton@apple.com [Mon, 22 Jun 2020 21:24:17 +0000 (21:24 +0000)]
dlopen() always fails on arm64, cannot load soft-linked libraries
https://bugs.webkit.org/show_bug.cgi?id=213480

Reviewed by Alexey Proskuryakov and Per Arne Vollan.

* Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::initializeSandboxParameters):
Expose the auxiliary process' CPU family as a parameter to the sandbox profile,
so that it can be used to predicate sandbox expressions.

* WebProcess/com.apple.WebProcess.sb.in:
Allow mremap_encrypted from the Web Content process, because the arm64 dlopen() needs it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoDisable the JS JIT when running in a translated process
timothy_horton@apple.com [Mon, 22 Jun 2020 21:05:09 +0000 (21:05 +0000)]
Disable the JS JIT when running in a translated process
https://bugs.webkit.org/show_bug.cgi?id=213478

Reviewed by Saam Barati.

Source/JavaScriptCore:

* runtime/Options.cpp:
(JSC::Options::recomputeDependentOptions):
Based on our performance experiements, disable the JavaScript JIT
(but not the regular expression, DOM, or Wasm JIT) when running
in a translated process.

Source/WTF:

* wtf/PlatformHave.h:
* wtf/TranslatedProcess.h: Added.
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
Add a helper function that can be used to determine that the current process
is being translated; currently the only case is an x86_64 process running on arm64e.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoUpdate macOS version macros
timothy_horton@apple.com [Mon, 22 Jun 2020 20:48:59 +0000 (20:48 +0000)]
Update macOS version macros
https://bugs.webkit.org/show_bug.cgi?id=213484

Reviewed by Alexey Proskuryakov.

Source/bmalloc:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:

Source/JavaScriptCore:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/DebugProject.xcconfig:
* gtest/xcode/Config/ReleaseProject.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/ThirdParty/libwebrtc:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebCore/PAL:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebInspectorUI:

* Configurations/DebugRelease.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKit:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:

Tools:

* ContentExtensionTester/Configurations/Base.xcconfig:
* ContentExtensionTester/Configurations/DebugRelease.xcconfig:
* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
* ImageDiff/cg/Configurations/Base.xcconfig:
* ImageDiff/cg/Configurations/DebugRelease.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/DebugRelease.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/DebugRelease.xcconfig:
* WebEditingTester/Configurations/Base.xcconfig:
* WebEditingTester/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
* lldb/lldbWebKitTester/Configurations/Base.xcconfig:
* lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agosysctl() fails due to sandbox violation
timothy_horton@apple.com [Mon, 22 Jun 2020 20:46:51 +0000 (20:46 +0000)]
sysctl() fails due to sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=213482

Reviewed by Maciej Stachowiak.

* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* WebProcess/com.apple.WebProcess.sb.in:
Extend the sandbox as necessary to make sysctl calls work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWebGL cannot create a context if there is no GPU on the PCIe bus
timothy_horton@apple.com [Mon, 22 Jun 2020 20:24:48 +0000 (20:24 +0000)]
WebGL cannot create a context if there is no GPU on the PCIe bus
https://bugs.webkit.org/show_bug.cgi?id=213479

Reviewed by Maciej Stachowiak and Dean Jackson.

* src/gpu_info_util/SystemInfo_macos.mm:
(angle::GetSystemInfo):
Do not bail from WebGL initialization if there are no GPUs on the PCIe bus.
Instead, continue on to context creation, and allow the system frameworks
to return an error if there truly is no GPU.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoAPI Test WeakLinking.WeakImport fails on arm64
timothy_horton@apple.com [Mon, 22 Jun 2020 20:22:35 +0000 (20:22 +0000)]
API Test WeakLinking.WeakImport fails on arm64
https://bugs.webkit.org/show_bug.cgi?id=213477

Reviewed by Alexey Proskuryakov.

* TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
* TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd:
* TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd:
* TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd:
Add this architecture to the TBD files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoREGRESSION (r263121): [ Catalina Debug ] media/video-fullscreen-only-playback.html...
eric.carlson@apple.com [Mon, 22 Jun 2020 19:59:20 +0000 (19:59 +0000)]
REGRESSION (r263121): [ Catalina Debug ] media/video-fullscreen-only-playback.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213407
<rdar://problem/64545587>

Unreviewed speculative change as I have not been able to reproduce the reported bug.

* media/video-fullscreen-only-playback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoAdded getFloatTimeDomainData method to AnalyserNode
commit-queue@webkit.org [Mon, 22 Jun 2020 19:26:44 +0000 (19:26 +0000)]
Added getFloatTimeDomainData method to AnalyserNode
https://bugs.webkit.org/show_bug.cgi?id=213393

Patch by Clark Wang <clark_wang@apple.com> on 2020-06-22
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined test to show a new passing test.

* web-platform-tests/webaudio/idlharness.https.window-expected.txt:

Source/WebCore:

Added getFloatTimeDomainData method, as per spec: https://www.w3.org/TR/webaudio/#analysernode.
Implementation of RealtimeAnalyser::getFloatTimeDomainData(Float32Array* destinationArray) is based on:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/webaudio/realtime_analyser.cc.
Removed nullable option from some AnalyserNode methods.

Re-baselined existing tests to show new passing test.

* Modules/webaudio/AnalyserNode.h:
* Modules/webaudio/AnalyserNode.idl:
* Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
(WebCore::RealtimeAnalyser::getByteFrequencyData):
(WebCore::RealtimeAnalyser::getFloatTimeDomainData):
(WebCore::RealtimeAnalyser::getByteTimeDomainData):
* Modules/webaudio/RealtimeAnalyser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoBring up watchOS/tvOS on build.webkit.org (Follow-up fix x3)
jbedard@apple.com [Mon, 22 Jun 2020 18:58:22 +0000 (18:58 +0000)]
Bring up watchOS/tvOS on build.webkit.org (Follow-up fix x3)
https://bugs.webkit.org/show_bug.cgi?id=213402
<rdar://problem/64542588>

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): 64 bit is more correct for watchOS embedded builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoUnreviewed, re-landing r262904.
ggaren@apple.com [Mon, 22 Jun 2020 17:43:31 +0000 (17:43 +0000)]
Unreviewed, re-landing r262904.

r263223 should fix the test flakiness we saw.

Re-landed changeset:

"[Cocoa] Build callOnMainThread on WTF::RunLoop rather than on
a timer"
https://bugs.webkit.org/show_bug.cgi?id=213063
https://trac.webkit.org/changeset/262904

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoAdd referrerpolicy attribute support for <link>
commit-queue@webkit.org [Mon, 22 Jun 2020 17:20:50 +0000 (17:20 +0000)]
Add referrerpolicy attribute support for <link>
https://bugs.webkit.org/show_bug.cgi?id=213342

Patch by Rob Buis <rbuis@igalia.com> on 2020-06-22
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Fix wrong resource file name usage.

* web-platform-tests/referrer-policy/generic/multiple-headers-and-values.html:
* web-platform-tests/referrer-policy/generic/multiple-headers-combined.html:
* web-platform-tests/referrer-policy/generic/multiple-headers-one-invalid.html:
* web-platform-tests/referrer-policy/generic/multiple-headers-one-unknown-token.html:
* web-platform-tests/referrer-policy/generic/multiple-headers.html:

Source/WebCore:

Add support for referrerpolicy attribute handling on
link prefetch/preload/stylesheet.

Tests: http/tests/security/referrer-policy-attribute-style-no-referrer.html
       http/wpt/preload/refferer-policy.html

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::setReferrerPolicyForBindings):
(WebCore::HTMLLinkElement::referrerPolicyForBindings const):
(WebCore::HTMLLinkElement::referrerPolicy const):
* html/HTMLLinkElement.h:
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
* html/parser/HTMLResourcePreloader.cpp:
(WebCore::PreloadRequest::resourceRequest):
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLinksFromHeader):
(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::prefetchIfNeeded):
* loader/LinkLoader.h:

LayoutTests:

Add a tests for <link rel="stylesheet">, <link rel="preload"> and the
referrerpolicy attribute.
Unskip the referrer-policy/generic/link-rel-prefetch.html test.

* TestExpectations:
* http/tests/security/referrer-policy-attribute-style-no-referrer-expected.html: Added.
* http/tests/security/referrer-policy-attribute-style-no-referrer.html: Added.
* http/tests/security/resources/green-background.css: Added.
(body):
* http/tests/security/resources/green-if-no-referrer-css.php: Added.
* http/tests/security/resources/pass-if-no-referrer.php: Added.
* http/wpt/preload/refferer-policy-expected.txt: Added.
* http/wpt/preload/refferer-policy.html: Added.
* http/wpt/preload/resources/referrer-img.py: Added.
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoFix build error with release build and "#define LOG_DISABLED 0"
simon.fraser@apple.com [Mon, 22 Jun 2020 17:01:18 +0000 (17:01 +0000)]
Fix build error with release build and "#define LOG_DISABLED 0"
https://bugs.webkit.org/show_bug.cgi?id=213420

Reviewed by Sam Weinig.

AnimationBase::updateStateMachine() uses LOG_ERROR so needs to test ERROR_DISABLED not LOG_DISABLED.

* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoREGRESSION (r263150): http/tests/ssl/applepay/ApplePayInstallmentItems.https.html...
aestes@apple.com [Mon, 22 Jun 2020 16:58:57 +0000 (16:58 +0000)]
REGRESSION (r263150): http/tests/ssl/applepay/ApplePayInstallmentItems.https.html is failing
https://bugs.webkit.org/show_bug.cgi?id=213466
<rdar://problem/64537600>

Reviewed by Tim Horton.

* http/tests/ssl/applepay/ApplePayInstallmentItems.https.html: Restored two lines of code
that were accidentally removed in r263150 and are necessary for the test to pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoFix the case of "null type Blob slice" in wpt/FileAPI/blob/Blob-slice.html
commit-queue@webkit.org [Mon, 22 Jun 2020 16:34:13 +0000 (16:34 +0000)]
Fix the case of "null type Blob slice" in wpt/FileAPI/blob/Blob-slice.html
https://bugs.webkit.org/show_bug.cgi?id=213370

Patch by Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> on 2020-06-22
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/FileAPI/blob/Blob-slice-expected.txt:

Source/WebCore:

* fileapi/Blob.h:
(WebCore::Blob::slice const):
Remove unnecessary default arguments
These default arguments are introduced in r83873
but we don't need them because WebIDL binding handles them.

* fileapi/Blob.idl:
- Update the definition of `Blob.slice()` to match the latest spec.
  https://w3c.github.io/FileAPI/#blob-section

- We should use empty string as a default value by step 4-a of
  https://w3c.github.io/FileAPI/#dfn-slice

- In the previous code, we use `optional DOMString?` for the
  _contentType_ arguments for `Blob.slice()`.
  Then, our codegen generates a code which uses `convert<IDLNullable<IDLDOMString>>`
  and it returns `String()` if the JS value is `null`.
  This caused the failure case in this change.

LayoutTests:

* http/tests/local/fileapi/send-sliced-dragged-file-expected.txt:
* http/tests/local/fileapi/send-sliced-dragged-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoCode cleanup in WebAccessibilityObjectWrapper updateObjectBackingStore and position.
andresg_22@apple.com [Mon, 22 Jun 2020 16:31:54 +0000 (16:31 +0000)]
Code cleanup in WebAccessibilityObjectWrapper updateObjectBackingStore and position.
https://bugs.webkit.org/show_bug.cgi?id=213438

Reviewed by Darin Adler.

* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):
Removed unnecessary call to axBackingObject.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper position]):
Check for isIsolatedTreeEnabled instead of for the request thread,
since isolated tree mode = 1 runs on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WebRTC] Add support for freeze/pause receiver stats
youenn@apple.com [Mon, 22 Jun 2020 16:15:08 +0000 (16:15 +0000)]
[WebRTC] Add support for freeze/pause receiver stats
https://bugs.webkit.org/show_bug.cgi?id=212938
<rdar://problem/64141493>

Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated tests.

Receiver stats are useful to check for freezes.
Let's introduce it in 'track' stats for now, we will later on move all
'receiver' stats to its own object once we fully align with spec.

* Modules/mediastream/RTCStatsReport.h:
* Modules/mediastream/RTCStatsReport.idl:
* Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
(WebCore::fillRTCMediaStreamTrackStats):

LayoutTests:

* webrtc/video-mediastreamtrack-stats.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoImage `crossorigin` mutations should be considered "relevant mutations"
commit-queue@webkit.org [Mon, 22 Jun 2020 16:09:37 +0000 (16:09 +0000)]
Image `crossorigin` mutations should be considered "relevant mutations"
https://bugs.webkit.org/show_bug.cgi?id=213335

Patch by Rob Buis <rbuis@igalia.com> on 2020-06-22
Reviewed by Darin Adler.

As follow up to r263345, this check is not needed after all since the for loop
already does the same check.

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoUnreviewed, reverting r263331.
lawrence.j@apple.com [Mon, 22 Jun 2020 15:26:32 +0000 (15:26 +0000)]
Unreviewed, reverting r263331.

This commit was causing 50+ iOS debug tests to crash.

Reverted changeset:

"Convert DateComponents parsing code to use Optional based
return values rather than out-parameters"
https://bugs.webkit.org/show_bug.cgi?id=213440
https://trac.webkit.org/changeset/263331

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ macOS iOS ] REGRESSION: fast/mediastream/mediastrea mtrack-video-frameRate-clon...
jacob_uphoff@apple.com [Mon, 22 Jun 2020 15:06:38 +0000 (15:06 +0000)]
[ macOS iOS ] REGRESSION: fast/mediastream/mediastrea mtrack-video-frameRate-clon e-increasing.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213461

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[ews] Switch contributors.json url from trac to svn server
aakash_jain@apple.com [Mon, 22 Jun 2020 14:32:38 +0000 (14:32 +0000)]
[ews] Switch contributors.json url from trac to svn server
https://bugs.webkit.org/show_bug.cgi?id=213457

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(ValidateCommiterAndReviewer):
(ValidateCommiterAndReviewer.load_contributors_from_trac):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WebXR] Add a preliminary implementation of XRWebGLLayer
svillar@igalia.com [Mon, 22 Jun 2020 12:28:08 +0000 (12:28 +0000)]
[WebXR] Add a preliminary implementation of XRWebGLLayer
https://bugs.webkit.org/show_bug.cgi?id=213022

Reviewed by Carlos Garcia Campos.

LayoutTests/imported/w3c:

Added new expectations.

* web-platform-tests/webxr/xrWebGLLayer_constructor.https-expected.txt: Added.
* web-platform-tests/webxr/xrWebGLLayer_framebuffer_sameObject.https-expected.txt: Added.

Source/WebCore:

Added a preliminary implementation of XRWebGLLayer. It does not have any functionality at the moment so
it cannot be used to render WebXR stuff. This patch adds all the machinery required to create and properly
initialize the layer according to the spec.

Two new wpt tests are passing now.

* Modules/webxr/WebXRSession.h: Expose session mode.
* Modules/webxr/WebXRWebGLLayer.cpp:
(WebCore::WebXRWebGLLayer::create): Implemented spec for XRWebGLLayer creation.
(WebCore::WebXRWebGLLayer::computeNativeWebGLFramebufferResolution): Added with mock implementation.
(WebCore::WebXRWebGLLayer::computeRecommendedWebGLFramebufferResolution): Added.
(WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
(WebCore::WebXRWebGLLayer::framebuffer const): Returned type should be a pointer.
(WebCore::WebXRWebGLLayer::framebufferWidth const): Return framebuffer width if available, otherwise return
the base context width.
(WebCore::WebXRWebGLLayer::framebufferHeight const): Ditto but with heights.
(WebCore::WebXRWebGLLayer::getNativeFramebufferScaleFactor): Implemented.
* Modules/webxr/WebXRWebGLLayer.h: New methods and type adjustments.

LayoutTests:

* platform/wpe/TestExpectations: Added 2 more tests that are passing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoImage `crossorigin` mutations should be considered "relevant mutations"
commit-queue@webkit.org [Mon, 22 Jun 2020 10:49:20 +0000 (10:49 +0000)]
Image `crossorigin` mutations should be considered "relevant mutations"
https://bugs.webkit.org/show_bug.cgi?id=213335

Patch by Rob Buis <rbuis@igalia.com> on 2020-06-22
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test result.

* web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/drawimage_crossorigin.sub-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations-expected.txt:

Source/WebCore:

Make crossorigin attribute's state changes relevant mutations [1]. This change
also fixes several picture related mutations to be relevant [2].

Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html

[1] https://html.spec.whatwg.org/#reacting-to-dom-mutations:attr-img-crossorigin
[2] https://html.spec.whatwg.org/#reacting-to-dom-mutations

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::evaluateDynamicMediaQueryDependencies):
(WebCore::HTMLImageElement::selectImageSource):
(WebCore::parseCrossoriginState):
(WebCore::HTMLImageElement::attributeChanged):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedIntoAncestor):
(WebCore::HTMLImageElement::removedFromAncestor):
* html/HTMLImageElement.h:
* html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::sourcesChanged):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedIntoAncestor):
(WebCore::HTMLSourceElement::removedFromAncestor):
(WebCore::HTMLSourceElement::parseAttribute):
* html/HTMLSourceElement.h:
* loader/ImageLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[Flatpak SDK] Persist sccache auth token across flatpak updates
commit-queue@webkit.org [Mon, 22 Jun 2020 09:23:19 +0000 (09:23 +0000)]
[Flatpak SDK] Persist sccache auth token across flatpak updates
https://bugs.webkit.org/show_bug.cgi?id=213427

Patch by Philippe Normand <pnormand@igalia.com> on 2020-06-22
Reviewed by Žan Doberšek.

After a successful flatpak update check if an sccache auth token exists and reuse it when
updating the sccache config file.

* flatpak/flatpakutils.py:
(WebkitFlatpak.save_config):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[GTK] Ping attribute tests have been timeout since r204720
carlosgc@webkit.org [Mon, 22 Jun 2020 07:50:59 +0000 (07:50 +0000)]
[GTK] Ping attribute tests have been timeout since r204720
https://bugs.webkit.org/show_bug.cgi?id=162017

Reviewed by Adrian Perez de Castro.

The tests are using "TouchEvent" in window to check whether it's a touch screen and use
uiController.singleTapAtPoint() instead of the eventSender. TouchEvent is always added to the window object when
building with touch events enabled, which is the case of the GTK port. However, the ontouch event handlers are
added at runtime only when there's an actual touch screen (EnabledAtRuntime=TouchEvents). So, we can check
"ontouchstart" in window instead.

* http/tests/inspector/network/ping-type.html:
* http/tests/navigation/ping-attribute/resources/utilities.js:
(clickElement):
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWebKit fails to leave audio routing arbitration during navigation, closing.
graouts@webkit.org [Mon, 22 Jun 2020 07:18:56 +0000 (07:18 +0000)]
WebKit fails to leave audio routing arbitration during navigation, closing.
https://bugs.webkit.org/show_bug.cgi?id=213426
<rdar://problem/64395051>

Unreviewed build fix for an unannotated switch fall-through between switch labels.

* UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _audioRoutingArbitrationStatus]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WTF] Ensure ASCIILiteral is ASCII characters at compile time
ysuzuki@apple.com [Mon, 22 Jun 2020 06:51:27 +0000 (06:51 +0000)]
[WTF] Ensure ASCIILiteral is ASCII characters at compile time
https://bugs.webkit.org/show_bug.cgi?id=213449

Reviewed by Ross Kirsling.

The purpose of ASCIILiteral is ensure that this is compile-time (do not need to consider about ownership) ASCII characters.
By using `isASCII` and `ASSERT_UNDER_CONSTEXPR_CONTEXT`, we can make sure that this C string does not include non ASCII characters.
For example,

    auto globalVariable = "ラーメン (Ramen in Japanese)"_s;

becomes compile error.

* wtf/ASCIICType.h:
(WTF::isASCII):
* wtf/text/ASCIILiteral.h:
(WTF::StringLiterals::operator _s):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WTF] URL should support dataLog
ysuzuki@apple.com [Mon, 22 Jun 2020 06:50:21 +0000 (06:50 +0000)]
[WTF] URL should support dataLog
https://bugs.webkit.org/show_bug.cgi?id=213450

Reviewed by Mark Lam.

Source/WTF:

Add URL::dump(PrintStream&) to support `dataLog(url)` which is extremely useful for WTF / JSC developers.

* wtf/URL.cpp:
(WTF::URL::dump const):
* wtf/URL.h:

Tools:

Add test for URL::dump.

* TestWebKitAPI/Tests/WTF/URL.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WebDriver][GTK] Some executing_async_javascript_tests.py tests are failing with...
lmoura@igalia.com [Mon, 22 Jun 2020 04:43:09 +0000 (04:43 +0000)]
[WebDriver][GTK] Some executing_async_javascript_tests.py tests are failing with TimeoutExceptions
https://bugs.webkit.org/show_bug.cgi?id=211496

Unreviewed test gardening.

The two tests started passing with the updated selenium imported
tests from r263264;

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWebDriver: several tests in imported/selenium/py/test/selenium/webdriver/common/visib...
lmoura@igalia.com [Mon, 22 Jun 2020 04:41:22 +0000 (04:41 +0000)]
WebDriver: several tests in imported/selenium/py/test/selenium/webdriver/common/visibility_tests.py fail
https://bugs.webkit.org/show_bug.cgi?id=182334

Unreviewed test gardening.

The last two remaining tests from this bug started passing after the
imported selenium tests were updated in r263264.

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoWebDriver: two selenium alert tests are failing
lmoura@igalia.com [Mon, 22 Jun 2020 04:39:33 +0000 (04:39 +0000)]
WebDriver: two selenium alert tests are failing
https://bugs.webkit.org/show_bug.cgi?id=181727

Unreviewed test gardening.

These tests also have been passing since r262861.

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[WebDriver][GTK] Gardening failures related to missing selenium files
lmoura@igalia.com [Mon, 22 Jun 2020 04:38:12 +0000 (04:38 +0000)]
[WebDriver][GTK] Gardening failures related to missing selenium files

Unreviewed test gardening.

The relative_by_tests require some JS fragments built by Bazel,
Selenium's build tool.

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoAttempt to unskip stress test array-buffer-view-watchpoint-can-be-fired-really-add...
commit-queue@webkit.org [Sun, 21 Jun 2020 22:58:17 +0000 (22:58 +0000)]
Attempt to unskip stress test array-buffer-view-watchpoint-can-be-fired-really-add-in-dfg.js on most architectures
https://bugs.webkit.org/show_bug.cgi?id=213433

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2020-06-21
Reviewed by Darin Adler.

* stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoConvert much of the SVG string parsing code to use Optional based return values rathe...
weinig@apple.com [Sun, 21 Jun 2020 22:47:09 +0000 (22:47 +0000)]
Convert much of the SVG string parsing code to use Optional based return values rather than out-parameters
https://bugs.webkit.org/show_bug.cgi?id=213416

Reviewed by Darin Adler.

Update SVG parsers to use Optional style return programming rather than out parameters.
To make things even nicer, SVGPathSource based parsers now have a type per-parse function,
which makes working with them much easier. In the future, we should consider exanding these
new types to be used by SVGPathConsumer family of classes as well.

* WebCore.xcodeproj/project.pbxproj:
Add SVGPathSegValue.h, which was missing from the Xcode project.

* svg/SVGAngleValue.cpp:
(WebCore::parseAngleType):
(WebCore::SVGAngleValue::setValueAsString):
Adopt updated parseNumber() function, and do a drive by removal of an easy to remove
upconvertedCharacters.

* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues):
(WebCore::SVGAnimateMotionElement::calculateDistance):
Now uses new parsePoint() function. Using Optional.valueOr() where
the old code would have had parsePoint() doing the clearing.

* svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines):
Now returns an Optional<Vector<UnitBezier>>.
(WebCore::SVGAnimationElement::parseAttribute):
Now uses new parseKeySplines, and does an explicit clear on parse failure (old code
did it implicitly in the parse function).

* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::parseAttribute):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::parseAttribute):
* svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::parseAttribute):
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::parseAttribute):
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::parseAttribute):
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::parseAttribute):
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::parseAttribute):
Adopt Optional based parseNumberOptionalNumber.

* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::parseAttribute):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseAttribute):
Simplify by using the SVGPreserveAspectRatioValue constructor
which calls parse. No need for three lines.

* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseAttribute):
Adopt new Optional based parseViewBox.
Simplify by using the SVGPreserveAspectRatioValue constructor
which calls parse. No need for three lines.

(WebCore::SVGFitToViewBox::parseViewBox):
Convert to be Optional based, and adopt new parseNumber functions.

* svg/SVGFitToViewBox.h:
Updated signatures for new Optional based functions.

* svg/SVGGlyphRefElement.cpp:
(WebCore::parseFloat):
Adopt Optional based parseNumber.

* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::buildHorizontalKerningPair const):
* svg/SVGHKernElement.h:
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::buildVerticalKerningPair const):
* svg/SVGVKernElement.h:
Convert to be Optional based. Update a few callers to use makeString.

* svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::addKerningPair const):
(WebCore::SVGToOTFFontConverter::appendKERNSubtable):
Adopt new Optional based kerning pair builders. Add some moves
to avoid some copies.

* svg/SVGLengthValue.cpp:
(WebCore::SVGLengthValue::setValueAsString):
Adopt Optional based parseNumber.

* svg/SVGNumberList.h:
(WebCore::SVGNumberList::parse):
Adopt Optional based parseNumber.

* svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber):
(WebCore::parseNumber):
(WebCore::genericParseArcFlag):
(WebCore::parseArcFlag):
(WebCore::parseNumberOptionalNumber):
(WebCore::parsePoint):
(WebCore::parseRect):
(WebCore::parseGlyphName):
(WebCore::parseUnicodeRange):
(WebCore::parseKerningUnicodeString):
(WebCore::genericParseFloatPoint):
(WebCore::parseFloatPoint):
(WebCore::parseSVGNumber): Deleted.
(WebCore::parseNumberFromString): Deleted.
(WebCore::parseDelimitedString): Deleted.
(WebCore::parseFloatPoint2): Deleted.
(WebCore::parseFloatPoint3): Deleted.
* svg/SVGParserUtilities.h:
(WebCore::isSVGSpace):
(WebCore::skipOptionalSVGSpaces):
(WebCore::skipOptionalSVGSpacesOrDelimiter):
- Converts parse* functions to return Optional values rather than using outparameters.
- Removes unused parseSVGNumber and parseDelimitedString.
- Removes parseFloatPoint2 and parseFloatPoint3. They weren't useful enough to keep around.
- Renames parseNumberFromString to parseNumber. The argument is a String, it's clear enough.
- Replace boolean skip parameters with new enum SuffixSkippingPolicy.
- Make parseFloatPoint have two overloads rather than being templatized to be consistent.

* svg/SVGPathBlender.cpp:
(WebCore::pullFromSources):
(WebCore::SVGPathBlender::blendMoveToSegment):
(WebCore::SVGPathBlender::blendLineToSegment):
(WebCore::SVGPathBlender::blendLineToHorizontalSegment):
(WebCore::SVGPathBlender::blendLineToVerticalSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
(WebCore::SVGPathBlender::blendArcToSegment):
(WebCore::SVGPathBlender::canBlendPaths):
(WebCore::SVGPathBlender::blendAnimatedPath):
Update to adopt new SVGPathSource interface. Added pullFromSources helper
which substantially simplifies pulling from both the from and to source at
the same time and is now possible due to all the SVGPathSource functions
returning the segment types rather than taking them as out parameters.

* svg/SVGPathByteStreamSource.cpp:
(WebCore::SVGPathByteStreamSource::nextCommand):
(WebCore::SVGPathByteStreamSource::parseSVGSegmentType):
(WebCore::SVGPathByteStreamSource::parseMoveToSegment):
(WebCore::SVGPathByteStreamSource::parseLineToSegment):
(WebCore::SVGPathByteStreamSource::parseLineToHorizontalSegment):
(WebCore::SVGPathByteStreamSource::parseLineToVerticalSegment):
(WebCore::SVGPathByteStreamSource::parseCurveToCubicSegment):
(WebCore::SVGPathByteStreamSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathByteStreamSource::parseArcToSegment):
* svg/SVGPathByteStreamSource.h:
Adopt new SVGPathSource interface.

* svg/SVGPathParser.cpp:
(WebCore::SVGPathParser::parseMoveToSegment):
(WebCore::SVGPathParser::parseLineToSegment):
(WebCore::SVGPathParser::parseLineToHorizontalSegment):
(WebCore::SVGPathParser::parseLineToVerticalSegment):
(WebCore::SVGPathParser::parseCurveToCubicSegment):
(WebCore::SVGPathParser::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathParser::parseArcToSegment):
(WebCore::SVGPathParser::parsePathData):
Adapt to new SVGPathSource interface. Code reads a bit nicer now
that we don't have a ton of local variables in each method. Could
be made nicer in the future by adopting Segment types in the path
consumer code.

* svg/SVGPathSegListSource.cpp:
(WebCore::SVGPathSegListSource::nextCommand):
(WebCore::SVGPathSegListSource::parseSVGSegmentType):
(WebCore::SVGPathSegListSource::parseMoveToSegment):
(WebCore::SVGPathSegListSource::parseLineToSegment):
(WebCore::SVGPathSegListSource::parseLineToHorizontalSegment):
(WebCore::SVGPathSegListSource::parseLineToVerticalSegment):
(WebCore::SVGPathSegListSource::parseCurveToCubicSegment):
(WebCore::SVGPathSegListSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathSegListSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathSegListSource::parseArcToSegment):
* svg/SVGPathSegListSource.h:
Adopt new SVGPathSource interface.

* svg/SVGPathSource.h:
Update interface to return Optionals, with a specific type for
segment kind that be parsed.

* svg/SVGPathStringSource.cpp:
(WebCore::nextCommandHelper):
(WebCore::SVGPathStringSource::nextCommand):
(WebCore::parseSVGSegmentTypeHelper):
(WebCore::SVGPathStringSource::parseSVGSegmentType):
(WebCore::SVGPathStringSource::parseMoveToSegment):
(WebCore::SVGPathStringSource::parseLineToSegment):
(WebCore::SVGPathStringSource::parseLineToHorizontalSegment):
(WebCore::SVGPathStringSource::parseLineToVerticalSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathStringSource::parseArcToSegment):
(WebCore::parseArcToSegmentHelper): Deleted.
* svg/SVGPathStringSource.h:
Adopt new SVGPathSource interface. Replace out of line helpers (or use of things
like parseFloatPoint2) with generic lambda helpers, helping to keep the code more
localized.

* svg/SVGPointList.h:
(WebCore::SVGPointList::parse):
Adopt Optional based parseNumber.

* svg/SVGTransformList.h:
* svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList):
(WebCore::SVGTransformable::parseTransformValue):
(WebCore::SVGTransformable::parseAndSkipType):
(WebCore::SVGTransformable::parseTransformType):
* svg/SVGTransformable.h:
Convert parseTransformValue/parseAndSkipType to be Optional based.

* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
Adopt Optional based parseViewBox.

* svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:
Adopt Optional based parseNumber.

* svg/properties/SVGPropertyTraits.h:
(WebCore::SVGPropertyTraits<float>::fromString):
(WebCore::SVGPropertyTraits<float>::parse):
(WebCore::SVGPropertyTraits<FloatPoint>::fromString):
(WebCore::SVGPropertyTraits<FloatPoint>::parse):
(WebCore::SVGPropertyTraits<FloatRect>::fromString):
(WebCore::SVGPropertyTraits<FloatRect>::parse):
Adopt Optional based parsers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[Flatpak] Nightly runner fails to extract zip files
commit-queue@webkit.org [Sun, 21 Jun 2020 20:33:33 +0000 (20:33 +0000)]
[Flatpak] Nightly runner fails to extract zip files
https://bugs.webkit.org/show_bug.cgi?id=213445

Patch by Philippe Normand <pnormand@igalia.com> on 2020-06-21
Reviewed by Darin Adler.

* Scripts/webkit-flatpak-run-nightly: Ensure the buffered zip data is written to disk before
extraction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agocompositing/video/video-border-radius-clipping.html was a flaky failure after r263223
ggaren@apple.com [Sun, 21 Jun 2020 20:20:23 +0000 (20:20 +0000)]
compositing/video/video-border-radius-clipping.html was a flaky failure after r263223
https://bugs.webkit.org/show_bug.cgi?id=213424

Reviewed by Darin Adler.

The last attempt to unflake this test was r253310. Let's try again.

I took a screen recording of a few hundred loads of this test @ r263222,
and it looks like it was always possible for canplaythrough and seeked
to fire before the video had rendered its first frame. So, this is a
test issue.

The screen recording seems to show that waiting for
requestAnimationFrame ensures that the video renders its first frame.
This might be for a principled system vsync reason, or just a lucky
delay. Either way, the test seems less flaky now.

This might mean that we can remove the previous seeked event workaround,
but I chose not to tempt fate, and left it in place.

* compositing/video/video-border-radius-clipping-expected.html:
* compositing/video/video-border-radius-clipping.html:
* media/video-test.js:
(_eventCallback):
(waitForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agoConvert DateComponents parsing code to use Optional based return values rather than...
weinig@apple.com [Sun, 21 Jun 2020 19:58:25 +0000 (19:58 +0000)]
Convert DateComponents parsing code to use Optional based return values rather than out-parameters
https://bugs.webkit.org/show_bug.cgi?id=213440

Reviewed by Darin Adler.

Rework DateComponents and Date/Time related InputTypes to use Optional based programming
for parsing results. Also take the opportunity to remove unicode upconversion from
DateComponent parsing and instead separate UChar and LChar variants via templates.

* html/BaseDateAndTimeInputType.cpp:
* html/BaseDateAndTimeInputType.h:
* html/DateInputType.cpp:
* html/DateInputType.h:
* html/DateTimeInputType.cpp:
* html/DateTimeInputType.h:
* html/DateTimeLocalInputType.cpp:
* html/DateTimeLocalInputType.h:
* html/HTMLInputElement.cpp:
* html/HTMLInputElement.h:
* html/InputType.cpp:
* html/InputType.h:
* html/MonthInputType.cpp:
* html/MonthInputType.h:
* html/TimeInputType.cpp:
* html/TimeInputType.h:
* html/WeekInputType.cpp:
* html/WeekInputType.h:
    - Removes parseToDateComponentsInternal. No need it and parseToDateComponents.
    - Makes parseToDateComponents pure virtual. The old code had a default implementations
      down in InputType, but it had no callers.
    - Remove iOS vs. non-iOS difference for dateType(). It is now available on InputType
      on all platforms.
    - Make setMillisecondToDateComponents and parseToDateComponents return an Optional.

* platform/DateComponents.cpp:
* platform/DateComponents.h:
    - Replace member function based interfaces for parsing/setting explicit time offsets
      with new factory functions that return Optional<DateComponents>.
    - These factories are implemented using the existing member functions, which are
      now private.
    - Make max/min constants constexpr.
    - Make parse* member functions templates to allow factory parse functions to
      call them without upconverting.
    - Replace header guard with #pragma once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks agofast/text/international/system-language/navigator-language/navigator-language tests...
mmaxfield@apple.com [Sun, 21 Jun 2020 18:43:40 +0000 (18:43 +0000)]
fast/text/international/system-language/navigator-language/navigator-language tests are failing on Mojave
<rdar://problem/64468227>

Unreviewed test gardening.

* platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt: Added.
* platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt: Added.
* platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 weeks ago[LFC] Add basic support for width: fit-content
zalan@apple.com [Sun, 21 Jun 2020 17:13:47 +0000 (17:13 +0000)]
[LFC] Add basic support for width: fit-content
https://bugs.webkit.org/show_bug.cgi?id=213444

Reviewed by Antti Koivisto.

Source/WebCore:

At this point this is just a shrink-to-fit sizing (missing the case when the available horizontal space is not specified).

Test: fast/layoutformattingcontext/fit-content-width-simple.html

* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedWidthValue):

LayoutTests:

* fast/layoutformattingcontext/fit-content-width-simple-expected.html: Added.
* fast/layoutformattingcontext/fit-content-width-simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 weeks agoWebKit fails to leave audio routing arbitration during navigation, closing.
jer.noble@apple.com [Sun, 21 Jun 2020 15:34:12 +0000 (15:34 +0000)]
WebKit fails to leave audio routing arbitration during navigation, closing.
https://bugs.webkit.org/show_bug.cgi?id=213426
<rdar://problem/64395051>

Reviewed by Eric Carlson.

Source/WebCore:

When setting the AudioSession category, make sure to leave routing arbitration before bailing out early. Also,
HTMLMediaElement::canProduceAudio() should return `false` when the element's document is suspended or stopped.
Otherwise, the AudioSession will continue in the `MediaPlayback` category indefinitely, and routing arbitration
will remain active.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canProduceAudio const):
* platform/audio/mac/AudioSessionMac.mm:
(WebCore::AudioSession::setCategory):

Source/WebKit:

Add testing SPIs to verify whether a WebPage successfully entered or left audio routing
arbitration. Notify the Arbitration proxy when the page is shut down, which ensures arbitration
will end if the client closes the WKWebView.

* UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _audioRoutingArbitrationStatus]):
* UIProcess/API/mac/WKWebViewTestingMac.mm:
* UIProcess/Media/AudioSessionRoutingArbitratorProxy.h:
(WebKit::AudioSessionRoutingArbitratorProxy::arbitrationStatus const):
* UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm:
(WebKit::AudioSessionRoutingArbitratorProxy::processDidTerminate):
(WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):
(WebKit::AudioSessionRoutingArbitratorProxy::endRoutingArbitration):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::shutDown):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::audioSessionRoutingArbitrator):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: Added.
(AudioRoutingArbitration::statusShouldBecomeEqualTo):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 weeks ago[LFC][TFC] Add support for percentage min/max-width
zalan@apple.com [Sun, 21 Jun 2020 13:51:01 +0000 (13:51 +0000)]
[LFC][TFC] Add support for percentage min/max-width
https://bugs.webkit.org/show_bug.cgi?id=213436

Reviewed by Antti Koivisto.

Source/WebCore:

1. The table generates a principal block container box called the table wrapper box that contains the table box itself and any caption boxes.
2. The table wrapper box establishes a block formatting context, and the table box establishes a table formatting context.
3. The computed values of properties 'position', 'float', 'margin-*', 'top', 'right', 'bottom', and 'left' on
   the table element are used on the table wrapper box and not the table box; all other values of non-inheritable
   properties are used on the table box and not the table wrapper box.
4. In a block formatting context, each box's left outer edge touches the left edge of the containing block.
   This is true even in the presence of floats, unless the box establishes a new block formatting context (in which case the
   box itself may become narrower due to the floats)

Now consider the following case:
<div style="display: block; width: 500px;">
    <div style="float: left; width: 100px;"></div>
    <div style="display: table; width: 10%;"></div>
</div>
1. We create a table wrapper box to wrap the "display: table" block level box (#1).
2. The table wrapper box's width property is set to auto (#3).
3. Since it establishes a new block formatting context, the available horizontal space gets shrunk by the float (#4)
4. The table wrapper box's used width computes to 500px - 100px -> 400px;

Now we are inside the BFC established by the table wrapper box and try to resolve the table's width -> %10.
According to the normal BFC rules, it should compute to 10% of the containing block's logical width: 400px -> 40px.
However in practice it computes to 50px (10% of 500px).

Similar setup with non-table content would resolve the inner block level box's width to 40px;
<div style="display: block; width: 500px">
    <div style="float: left; width: 100px;"></div>
    <div style="display: block; overflow: hidden;">
        <div style="display: block; width: 10%"></div>
    </div>
</div>
This needs clarification.

Test: fast/layoutformattingcontext/float-avoider-available-horizontal-space3.html

* layout/FormattingContext.h:
(WebCore::Layout::FormattingContext::isTableWrapperBlockFormattingContext const):
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
* layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:
(WebCore::Layout::TableWrapperBlockFormattingContext::computeWidthAndMarginForTableBox):
* layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.h:

LayoutTests:

* fast/layoutformattingcontext/float-avoider-available-horizontal-space3-expected.html: Added.
* fast/layoutformattingcontext/float-avoider-available-horizontal-space3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 weeks ago[WPE][GTK] Specify underlying storage type for InputMethodState::Hint
commit-queue@webkit.org [Sun, 21 Jun 2020 09:13:04 +0000 (09:13 +0000)]
[WPE][GTK] Specify underlying storage type for InputMethodState::Hint
https://bugs.webkit.org/show_bug.cgi?id=213401

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2020-06-21
Reviewed by Carlos Garcia Campos.

Using unsigned types for flags enums seems nice to do.

* Shared/glib/InputMethodState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 weeks ago[WPE][GTK] Add autocleanup for WebKitWebsitePolicies
commit-queue@webkit.org [Sun, 21 Jun 2020 09:11:04 +0000 (09:11 +0000)]
[WPE][GTK] Add autocleanup for WebKitWebsitePolicies
https://bugs.webkit.org/show_bug.cgi?id=213399

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2020-06-21
Reviewed by Carlos Garcia Campos.

Add missing autocleanups.

* UIProcess/API/gtk/WebKitAutocleanups.h:
* UIProcess/API/wpe/WebKitAutocleanups.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263325 268f45cc-cd09-0410-ab3c-d52691b4dbfc