WebKit-https.git
11 years agoImplement test-result-archive for GTK.
mrowe@apple.com [Wed, 29 Apr 2009 21:54:57 +0000 (21:54 +0000)]
Implement test-result-archive for GTK.

* BuildSlaveSupport/test-result-archive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
eric@webkit.org [Wed, 29 Apr 2009 21:38:14 +0000 (21:38 +0000)]
2009-03-27  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by Simon Hausmann.

        Update the page actions when a finishing loading even if the frame is
        not the top frame such as when browsing inside of a website with frames.
        https://bugs.webkit.org/show_bug.cgi?id=24890

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
        * tests/qwebpage/frametest/frame_a.html: Added.
        * tests/qwebpage/frametest/index.html: Added.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::backActionUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Mike Belshe <mike@belshe.com>
eric@webkit.org [Wed, 29 Apr 2009 21:31:41 +0000 (21:31 +0000)]
2009-04-29  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Update location while page is loading.
        https://bugs.webkit.org/show_bug.cgi?id=21597

        Tested by:
        - fast/dom/location-new-window-no-crash
        - fast/dom/Window/window-open-pending-url

        * page/Location.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 29 Apr 2009 21:28:25 +0000 (21:28 +0000)]
2009-04-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Mark Rowe.

        Disable failing tests to make the bot green for its new debut, so
        that we can more easily track regressions.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Feng Qian <feng@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:25:45 +0000 (21:25 +0000)]
2009-04-29  Feng Qian  <feng@chromium.org>

        Reviewed by Darin Adler.

        Add Android port files to WebCore/platform.
        https://bugs.webkit.org/show_bug.cgi?id=23296

        * platform/android: Added.
        * platform/android/ClipboardAndroid.cpp: Added.
        * platform/android/ClipboardAndroid.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Feng Qian <feng@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:23:31 +0000 (21:23 +0000)]
2009-04-29  Feng Qian  <feng@chromium.org>

        Reviewed by Darin Adler.

        Add Android-specific files to the WebCore/page directory.
        https://bugs.webkit.org/show_bug.cgi?id=23295

        * page/android: Added.
        * page/android/DragControllerAndroid.cpp: Added.
        * page/android/EventHandlerAndroid.cpp: Added.
        * page/android/InspectorControllerAndroid.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:00:42 +0000 (21:00 +0000)]
2009-04-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Extract PageGroupLoadDeferrer from Chrome.cpp

        * GNUmakefile.am: added PageGroupLoadDeferrer
        * WebCore.pro: ditto
        * WebCore.scons: ditto
        * WebCore.vcproj/WebCore.vcproj: ditto
        * WebCore.xcodeproj/project.pbxproj: ditto
        * WebCoreSources.bkl: ditto
        * page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
        * page/PageGroupLoadDeferrer.cpp: Added.
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        * page/PageGroupLoadDeferrer.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlson.
kdecker@apple.com [Wed, 29 Apr 2009 20:55:39 +0000 (20:55 +0000)]
    Reviewed by Anders Carlson.

        Allow WKN_CheckIfAllowedToLoadURL() to take an optional void* context parameter.

        * Plugins/WebNetscapeContainerCheckContextInfo.h:
        * Plugins/WebNetscapeContainerCheckContextInfo.mm:
        (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
        (-[WebNetscapeContainerCheckContextInfo callback]):
        (-[WebNetscapeContainerCheckContextInfo context]):
        * Plugins/WebNetscapeContainerCheckPrivate.h:
        * Plugins/WebNetscapeContainerCheckPrivate.mm:
        (browserContainerCheckFuncs):
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
        (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
        * Plugins/npapi.mm:
        (WKN_CheckIfAllowedToLoadURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 29 Apr 2009 20:43:34 +0000 (20:43 +0000)]
2009-04-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25334

        Fix Qt build when ENABLE_JIT is explicitly set to 1
        to overrule defaults.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ojan@chromium.org [Wed, 29 Apr 2009 20:31:53 +0000 (20:31 +0000)]
    Reviewed by Dan Bernstein.

        Make textarea and text input metrics more closely match IEs.

        This involves:
        -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
        -set textarea width to cols*avgCharWidth
        -Make default CSS match IEs
        -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.

        Those values for textarea and inputs were derived by doing a ton of manual
        testing of IE's width values for various textareas and fonts. On Windows we match
        IE exactly except for a couple fonts of the ~12 tested.

        To get the average and max character width of a font, we do the following
        for each platform:
        -Win: TextMetrics expose avgCharWidth and maxCharWidth
        -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
            maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
        -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
            maxCharWidth = max of avgCharWidth and m_ascent
        -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
            If either one is non-positive, then calculate the value using the Linux approach.

        Tests: fast/forms/text-control-intrinsic-widths.html
               fast/forms/textarea-metrics.html
               svg/custom/svg-fonts-in-text-controls.html

        * css/html4.css:
        * css/themeWin.css:
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData):
        (WebCore::SimpleFontData::initCharWidths):
        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::maxCharWidth):
        (WebCore::SimpleFontData::avgCharWidth):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::initGDIFont):
        * platform/graphics/wx/SimpleFontDataWx.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::calcPrefWidths):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::preferredContentWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash in profiler due to incorrect assuming displayName would be a string.
oliver@apple.com [Wed, 29 Apr 2009 20:25:09 +0000 (20:25 +0000)]
Crash in profiler due to incorrect assuming displayName would be a string.

Reviewed by Steve Falkenburg

Fixed by adding a type guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Apr 2009 20:23:22 +0000 (20:23 +0000)]
2009-04-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        * bindings/objc/DOMCSS.mm:
        (kitClass):  Added CSS_INITIAL to the switch statement, and changed to use the WebCore
          type and not the binding type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 John Abd-El-Malek <jam@google.com>
eric@webkit.org [Wed, 29 Apr 2009 20:21:48 +0000 (20:21 +0000)]
2009-04-29  John Abd-El-Malek  <jam@google.com>

        Reviewed by Dimitri Glazkov.

        Reverted my previous change to add resetChromiumPluginCache().
        https://bugs.webkit.org/show_bug.cgi?id=25318

        * plugins/chromium/PluginDataChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Apr 2009 20:21:03 +0000 (20:21 +0000)]
2009-04-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail

        Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>

        Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Remove the preload referenced check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 20:14:25 +0000 (20:14 +0000)]
2009-04-29  Alpha Lam  <hclam@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25430

        Provide style sheet for UI controls of media elements for Chromium port.

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 John Abd-El-Malek <jam@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 20:12:54 +0000 (20:12 +0000)]
2009-04-29  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Adler.

        Expose sudden termination to Chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=25457

        * platform/SuddenTermination.h:
        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/SuddenTerminationChromium.cpp: Added.
        (WebCore::disableSuddenTermination):
        (WebCore::enableSuddenTermination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 29 Apr 2009 20:00:08 +0000 (20:00 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Dimitri Glazkov.

        Remove unused EventListeners.

        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 29 Apr 2009 18:38:35 +0000 (18:38 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by John Sullivan.

        Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized.  Make sure
        not to resize the interior views of a WebView in response to its bounds changing when not using
        viewless WebKit.  Auto-resizing rules were already in place to handle size adjustments for us.
        Just mark as needing layout and do nothing else.

        This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
        Safari change (using a new API that will enable clients to define the edges of the content area as offsets
        from the sides of the WebView).

        * WebView/WebView.mm:
        (-[WebView _boundsChanged]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 29 Apr 2009 17:41:11 +0000 (17:41 +0000)]
2009-04-29  Eric Carlson  <eric.carlson@apple.com>

        Disable media/video-zoom-controls.html on Windows for now.

        * platform/win/Skipped: add media/video-zoom-controls.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reveal current execution line once SourceFrame content is loaded.
timothy@apple.com [Wed, 29 Apr 2009 17:38:15 +0000 (17:38 +0000)]
    Reveal current execution line once SourceFrame content is loaded.

        https://bugs.webkit.org/show_bug.cgi?id=25448

        Reviewed by Timothy Hatcher.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ariya@webkit.org [Wed, 29 Apr 2009 17:27:14 +0000 (17:27 +0000)]
WebCore:

2009-04-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Fraser.

        [Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
        the default values of canvas attributes.

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBufferData::ImageBufferData):

LayoutTests:

2009-04-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Fraser.

        Updated expected results after Qt's GraphicsContext fixes.

        * platform/qt/fast/canvas/set-colors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Wed, 29 Apr 2009 13:55:38 +0000 (13:55 +0000)]
2009-04-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        Implement QWebElement::evaluateScript.

        * Api/qwebelement.cpp:
        (setupScriptContext):
        (QWebElement::evaluateScript):
        * Api/qwebelement.h:
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::evaluateScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 29 Apr 2009 13:46:46 +0000 (13:46 +0000)]
2009-04-29  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Replaced QWebElementCollection with QList<QWebElement>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Qt build
hausmann@webkit.org [Wed, 29 Apr 2009 06:38:48 +0000 (06:38 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix the test for <https://bugs.webkit.org/show_bug.cgi?id=25420> - I broke...
ap@webkit.org [Wed, 29 Apr 2009 06:31:38 +0000 (06:31 +0000)]
    Fix the test for <https://bugs.webkit.org/show_bug.cgi?id=25420> - I broke it when
        experimenting with other aspects of the issue, so it didn't check what it should have checked.

        * http/tests/xmlhttprequest/detaching-frame-2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 29 Apr 2009 06:19:46 +0000 (06:19 +0000)]
2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Missed one.

        * UserObjectImp.cpp:
        (UserObjectImp::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 29 Apr 2009 06:08:37 +0000 (06:08 +0000)]
2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Missed one.

        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ggaren@apple.com [Wed, 29 Apr 2009 06:07:26 +0000 (06:07 +0000)]
JavaScriptCore:

2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Removed scaffolding supporting dynamically converting between 32bit and
        64bit value representations.

        * API/JSCallbackConstructor.cpp:
        (JSC::constructJSCallback):
        * API/JSCallbackFunction.cpp:
        (JSC::JSCallbackFunction::call):
        * API/JSCallbackObjectFunctions.h:
        (JSC::::construct):
        (JSC::::call):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::getConstant):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitEqualityOp):
        * interpreter/CallFrame.cpp:
        (JSC::CallFrame::thisValue):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::callEval):
        (JSC::Interpreter::throwException):
        (JSC::Interpreter::createExceptionScope):
        (JSC::Interpreter::privateExecute):
        (JSC::Interpreter::retrieveArguments):
        * interpreter/Register.h:
        (JSC::Register::):
        (JSC::Register::Register):
        (JSC::Register::jsValue):
        (JSC::Register::marked):
        (JSC::Register::mark):
        (JSC::Register::i):
        (JSC::Register::activation):
        (JSC::Register::arguments):
        (JSC::Register::callFrame):
        (JSC::Register::codeBlock):
        (JSC::Register::function):
        (JSC::Register::propertyNameIterator):
        (JSC::Register::scopeChain):
        (JSC::Register::vPC):
        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_op_call_NotJSFunction):
        (JSC::JITStubs::cti_op_load_varargs):
        (JSC::JITStubs::cti_op_call_eval):
        * jsc.cpp:
        (functionPrint):
        (functionDebug):
        (functionRun):
        (functionLoad):
        * runtime/ArgList.h:
        (JSC::ArgList::at):
        * runtime/Arguments.cpp:
        (JSC::Arguments::copyToRegisters):
        (JSC::Arguments::fillArgList):
        (JSC::Arguments::getOwnPropertySlot):
        * runtime/ArrayConstructor.cpp:
        (JSC::constructArrayWithSizeQuirk):
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncJoin):
        (JSC::arrayProtoFuncConcat):
        (JSC::arrayProtoFuncPush):
        (JSC::arrayProtoFuncSlice):
        (JSC::arrayProtoFuncSort):
        (JSC::arrayProtoFuncSplice):
        (JSC::arrayProtoFuncUnShift):
        (JSC::arrayProtoFuncFilter):
        (JSC::arrayProtoFuncMap):
        (JSC::arrayProtoFuncEvery):
        (JSC::arrayProtoFuncForEach):
        (JSC::arrayProtoFuncSome):
        (JSC::arrayProtoFuncReduce):
        (JSC::arrayProtoFuncReduceRight):
        (JSC::arrayProtoFuncIndexOf):
        (JSC::arrayProtoFuncLastIndexOf):
        * runtime/BooleanConstructor.cpp:
        (JSC::constructBoolean):
        (JSC::callBooleanConstructor):
        * runtime/DateConstructor.cpp:
        (JSC::constructDate):
        (JSC::dateParse):
        (JSC::dateUTC):
        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):
        (JSC::fillStructuresUsingTimeArgs):
        (JSC::fillStructuresUsingDateArgs):
        (JSC::dateProtoFuncSetTime):
        (JSC::dateProtoFuncSetYear):
        * runtime/ErrorConstructor.cpp:
        (JSC::constructError):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * runtime/FunctionPrototype.cpp:
        (JSC::functionProtoFuncApply):
        (JSC::functionProtoFuncCall):
        * runtime/JSArray.cpp:
        (JSC::JSArray::JSArray):
        (JSC::constructArray):
        * runtime/JSArray.h:
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::encode):
        (JSC::decode):
        (JSC::globalFuncEval):
        (JSC::globalFuncParseInt):
        (JSC::globalFuncParseFloat):
        (JSC::globalFuncIsNaN):
        (JSC::globalFuncIsFinite):
        (JSC::globalFuncEscape):
        (JSC::globalFuncUnescape):
        (JSC::globalFuncJSCPrint):
        * runtime/MathObject.cpp:
        (JSC::mathProtoFuncAbs):
        (JSC::mathProtoFuncACos):
        (JSC::mathProtoFuncASin):
        (JSC::mathProtoFuncATan):
        (JSC::mathProtoFuncATan2):
        (JSC::mathProtoFuncCeil):
        (JSC::mathProtoFuncCos):
        (JSC::mathProtoFuncExp):
        (JSC::mathProtoFuncFloor):
        (JSC::mathProtoFuncLog):
        (JSC::mathProtoFuncMax):
        (JSC::mathProtoFuncMin):
        (JSC::mathProtoFuncPow):
        (JSC::mathProtoFuncRound):
        (JSC::mathProtoFuncSin):
        (JSC::mathProtoFuncSqrt):
        (JSC::mathProtoFuncTan):
        * runtime/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::construct):
        * runtime/NumberConstructor.cpp:
        (JSC::constructWithNumberConstructor):
        (JSC::callNumberConstructor):
        * runtime/NumberPrototype.cpp:
        (JSC::numberProtoFuncToString):
        (JSC::numberProtoFuncToFixed):
        (JSC::numberProtoFuncToExponential):
        (JSC::numberProtoFuncToPrecision):
        * runtime/ObjectConstructor.cpp:
        (JSC::constructObject):
        * runtime/ObjectPrototype.cpp:
        (JSC::objectProtoFuncHasOwnProperty):
        (JSC::objectProtoFuncIsPrototypeOf):
        (JSC::objectProtoFuncDefineGetter):
        (JSC::objectProtoFuncDefineSetter):
        (JSC::objectProtoFuncLookupGetter):
        (JSC::objectProtoFuncLookupSetter):
        (JSC::objectProtoFuncPropertyIsEnumerable):
        * runtime/PropertySlot.h:
        (JSC::PropertySlot::getValue):
        * runtime/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::match):
        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncCompile):
        * runtime/StringConstructor.cpp:
        (JSC::stringFromCharCodeSlowCase):
        (JSC::stringFromCharCode):
        (JSC::constructWithStringConstructor):
        (JSC::callStringConstructor):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):
        (JSC::stringProtoFuncCharAt):
        (JSC::stringProtoFuncCharCodeAt):
        (JSC::stringProtoFuncConcat):
        (JSC::stringProtoFuncIndexOf):
        (JSC::stringProtoFuncLastIndexOf):
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
        (JSC::stringProtoFuncSlice):
        (JSC::stringProtoFuncSplit):
        (JSC::stringProtoFuncSubstr):
        (JSC::stringProtoFuncSubstring):
        (JSC::stringProtoFuncLocaleCompare):
        (JSC::stringProtoFuncFontcolor):
        (JSC::stringProtoFuncFontsize):
        (JSC::stringProtoFuncAnchor):
        (JSC::stringProtoFuncLink):

WebCore:

2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Removed scaffolding supporting dynamically converting between 32bit and
        64bit value representations.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::setFillColor):
        (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
        (WebCore::JSCanvasRenderingContext2D::strokeRect):
        (WebCore::JSCanvasRenderingContext2D::drawImage):
        (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
        (WebCore::JSCanvasRenderingContext2D::setShadow):
        (WebCore::JSCanvasRenderingContext2D::createPattern):
        (WebCore::JSCanvasRenderingContext2D::putImageData):
        (WebCore::JSCanvasRenderingContext2D::fillText):
        (WebCore::JSCanvasRenderingContext2D::strokeText):
        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::clearData):
        (WebCore::JSClipboard::getData):
        (WebCore::JSClipboard::setData):
        (WebCore::JSClipboard::setDragImage):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::hasItem):
        (WebCore::JSDOMApplicationCache::add):
        (WebCore::JSDOMApplicationCache::remove):
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMStringListCustom.cpp:
        (WebCore::JSDOMStringList::item):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::open):
        (WebCore::JSDOMWindow::showModalDialog):
        (WebCore::JSDOMWindow::postMessage):
        (WebCore::JSDOMWindow::setTimeout):
        (WebCore::JSDOMWindow::setInterval):
        (WebCore::JSDOMWindow::atob):
        (WebCore::JSDOMWindow::btoa):
        (WebCore::JSDOMWindow::addEventListener):
        (WebCore::JSDOMWindow::removeEventListener):
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::setAttribute):
        (WebCore::JSElement::setAttributeNode):
        (WebCore::JSElement::setAttributeNS):
        (WebCore::JSElement::setAttributeNodeNS):
        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::callHTMLCollection):
        (WebCore::JSHTMLCollection::item):
        (WebCore::JSHTMLCollection::namedItem):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::documentWrite):
        * bindings/js/JSHTMLInputElementCustom.cpp:
        (WebCore::JSHTMLInputElement::setSelectionRange):
        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
        (WebCore::JSHTMLOptionsCollection::add):
        * bindings/js/JSHTMLSelectElementCustom.cpp:
        (WebCore::JSHTMLSelectElement::remove):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::constructImage):
        * bindings/js/JSInspectorControllerCustom.cpp:
        (WebCore::JSInspectorController::highlightDOMNode):
        (WebCore::JSInspectorController::addResourceSourceToFrame):
        (WebCore::JSInspectorController::addSourceToFrame):
        (WebCore::JSInspectorController::getResourceDocumentNode):
        (WebCore::JSInspectorController::search):
        (WebCore::JSInspectorController::databaseTableNames):
        (WebCore::JSInspectorController::setting):
        (WebCore::JSInspectorController::setSetting):
        (WebCore::JSInspectorController::wrapCallback):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::evaluate):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::replace):
        (WebCore::JSLocation::assign):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::startConversation):
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::insertBefore):
        (WebCore::JSNode::replaceChild):
        (WebCore::JSNode::removeChild):
        (WebCore::JSNode::appendChild):
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::JSNodeFilter::acceptNode):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::callNodeList):
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::constructHTMLOptionElement):
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::construct):
        (WebCore::JSQuarantinedObjectWrapper::call):
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        (WebCore::JSSQLResultSetRowList::item):
        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        (WebCore::JSSVGElementInstance::removeEventListener):
        * bindings/js/JSSVGLengthCustom.cpp:
        (WebCore::JSSVGLength::convertToSpecifiedUnits):
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::rotateFromVector):
        * bindings/js/JSSVGPathSegListCustom.cpp:
        (WebCore::JSSVGPathSegList::initialize):
        (WebCore::JSSVGPathSegList::getItem):
        (WebCore::JSSVGPathSegList::insertItemBefore):
        (WebCore::JSSVGPathSegList::replaceItem):
        (WebCore::JSSVGPathSegList::removeItem):
        (WebCore::JSSVGPathSegList::appendItem):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::JSSVGPointList::initialize):
        (WebCore::JSSVGPointList::getItem):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::removeItem):
        (WebCore::JSSVGPointList::appendItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::JSSVGTransformList::initialize):
        (WebCore::JSSVGTransformList::getItem):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::removeItem):
        (WebCore::JSSVGTransformList::appendItem):
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::constructWebKitCSSMatrix):
        * bindings/js/JSWebKitPointConstructor.cpp:
        (WebCore::constructWebKitPoint):
        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::constructWorker):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::importScripts):
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        (WebCore::JSWorkerContext::setTimeout):
        (WebCore::JSWorkerContext::setInterval):
        * bindings/js/JSWorkerCustom.cpp:
        (WebCore::JSWorker::addEventListener):
        (WebCore::JSWorker::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::open):
        (WebCore::JSXMLHttpRequest::setRequestHeader):
        (WebCore::JSXMLHttpRequest::send):
        (WebCore::JSXMLHttpRequest::getResponseHeader):
        (WebCore::JSXMLHttpRequest::overrideMimeType):
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/js/JSXSLTProcessorCustom.cpp:
        (WebCore::JSXSLTProcessor::importStylesheet):
        (WebCore::JSXSLTProcessor::transformToFragment):
        (WebCore::JSXSLTProcessor::transformToDocument):
        (WebCore::JSXSLTProcessor::setParameter):
        (WebCore::JSXSLTProcessor::getParameter):
        (WebCore::JSXSLTProcessor::removeParameter):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):
        (WebCore::ScheduledAction::ScheduledAction):
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptCallFrame.cpp:
        (WebCore::ScriptCallFrame::ScriptCallFrame):
        * bindings/js/ScriptCallFrame.h:
        * bindings/js/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::ScriptCallStack):
        (WebCore::ScriptCallStack::initialize):
        * bridge/c/c_instance.cpp:
        (JSC::Bindings::CInstance::invokeMethod):
        (JSC::Bindings::CInstance::invokeDefaultMethod):
        (JSC::Bindings::CInstance::invokeConstruct):
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        (ObjcInstance::invokeDefaultMethod):

WebKit/mac:

2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Removed scaffolding supporting dynamically converting between 32bit and
        64bit value representations.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::marshalValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago A little more hardening for UString
ddkilzer@apple.com [Wed, 29 Apr 2009 05:56:18 +0000 (05:56 +0000)]
    A little more hardening for UString

        Reviewed by Maciej Stachowiak.

        Revised fix for <rdar://problem/5861045> in r42644.

        * runtime/UString.cpp:
        (JSC::newCapacityWithOverflowCheck): Added.
        (JSC::concatenate): Used newCapacityWithOverflowCheck().
        (JSC::UString::append): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 David Carson <dacarson@apple.com>
ddkilzer@apple.com [Wed, 29 Apr 2009 05:52:23 +0000 (05:52 +0000)]
2009-04-28  David Carson  <dacarson@apple.com>

        Reviewed by David Hyatt.

        Restore alignment to device pixel boundaries.
        https://bugs.webkit.org/show_bug.cgi?id=25458

        Adjust the adjusted destination rect to be device pixel aligned.

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

2009-04-28  David Carson  <dacarson@apple.com>

        Reviewed by David Kilzer.

        Restore alignment to device pixel boundaries.
        https://bugs.webkit.org/show_bug.cgi?id=25458

        Updated test results with progressions.

        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        Yin-yang image shifted slightly to pixel boundaries.

        * platform/mac/svg/custom/focus-ring-expected.checksum:
        * platform/mac/svg/custom/focus-ring-expected.png:
        Focus rings drawn around rotated "focus text" and checkered
        images shifted slightly to pixel boundaries.

        * platform/mac/svg/custom/image-small-width-height-expected.checksum:
        * platform/mac/svg/custom/image-small-width-height-expected.png:
        Checkered images shifted slightly to pixel boundaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added missing pixel test results.
ddkilzer@apple.com [Wed, 29 Apr 2009 05:49:24 +0000 (05:49 +0000)]
    Added missing pixel test results.

        * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.png: Added.
        * platform/mac/fast/table/cell-coalescing-expected.checksum: Added.
        * platform/mac/fast/table/cell-coalescing-expected.png: Added.
        * platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.checksum: Added.
        * platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
        * platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.checksum: Added.
        * platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.png: Added.
        * platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.checksum: Added.
        * platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 29 Apr 2009 05:39:21 +0000 (05:39 +0000)]
2009-04-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Move unimplemented captureEvents and releaseEvents from JSDOMWindow
        to DOMWindow.

        * bindings/js/JSDOMWindowCustom.cpp:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::captureEvents):
        (WebCore::DOMWindow::releaseEvents):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrecting ChangeLogs - Sam talked to me about the patch, but it was Darin who review...
ap@webkit.org [Wed, 29 Apr 2009 05:30:46 +0000 (05:30 +0000)]
Correcting ChangeLogs - Sam talked to me about the patch, but it was Darin who reviewed it!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
ap@webkit.org [Wed, 29 Apr 2009 05:25:31 +0000 (05:25 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25420
        <rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin

        Test: http/tests/xmlhttprequest/detaching-frame-2.html

        This was caused by faulty DOMWindow::document(), which could return a new document from
        the window's frame after navigation.

        * bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
        Removed an obsolete check that allowed access when document was null. Contrary to what a
        comment said, that can happen for a window that is no longer in frame, not to one whose
        document is not constructed yet.

        * bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail
        out if context was not found. This currently happens due to a shortcoming in
        DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression
        test will be constructed successfully, but won't be sent, because its context will be
        frameless.

        * page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't
        been replaced yet. Added FIXME comments about how this may be better fixed in the future.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::document):
        (WebCore::constructAudio):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::document):
        (WebCore::constructImage):
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::construct):
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::document):
        (WebCore::constructHTMLOptionElement):
        Make matching changes to other constructors that hold a reference to global object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBring back r42969, this time with correct codegen
oliver@apple.com [Wed, 29 Apr 2009 04:54:47 +0000 (04:54 +0000)]
Bring back r42969, this time with correct codegen

Reviewed by Gavin Barraclough.

Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowxMSW build fix. Switch JSCore build back to static.
kevino@webkit.org [Wed, 29 Apr 2009 04:02:54 +0000 (04:02 +0000)]
wxMSW build fix. Switch JSCore build back to static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
ddkilzer@apple.com [Wed, 29 Apr 2009 03:03:12 +0000 (03:03 +0000)]
2009-04-28  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=25462

        Make sure "--pixel --add-platform-exceptions" produces platform
        specific pixel test results.

        * Scripts/run-webkit-tests: Support "--pixel
        --add-platform-exceptions"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoll out r42969, due to hangs in build bot.
oliver@apple.com [Wed, 29 Apr 2009 01:24:00 +0000 (01:24 +0000)]
Roll out r42969, due to hangs in build bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Wed, 29 Apr 2009 01:00:31 +0000 (01:00 +0000)]
    Reviewed by Simon Fraser.

        Add a couple table hit tests
        https://bugs.webkit.org/show_bug.cgi?id=21892

        * svg/hittest/svg-inside-display-table-expected.txt: Added.
        * svg/hittest/svg-inside-display-table.xhtml: Added.
        * svg/hittest/svg-inside-table-expected.txt: Added.
        * svg/hittest/svg-inside-table.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove performance of string indexing
oliver@apple.com [Wed, 29 Apr 2009 00:38:23 +0000 (00:38 +0000)]
Improve performance of string indexing

Reviewed by Geoff Garen

Add a cti_get_by_val_string function to specialise indexing into a string object.
This gives us a slight performance win on a number of string tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
eric.carlson@apple.com [Wed, 29 Apr 2009 00:29:21 +0000 (00:29 +0000)]
2009-04-28  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6834830>

        Make sure we cover the two possible values reported by event.total that are playback engine
        specific.

        * media/progress-event-total-expected.txt: Match the new test.
        * media/progress-event-total.html: Test the two values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
timothy@apple.com [Wed, 29 Apr 2009 00:17:07 +0000 (00:17 +0000)]
    Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
        collects the individual rects, making sure to only include RenderText.

        <rdar://problem/6810061>

        Reviewed by Sam Weinig.

        * bindings/objc/DOM.mm:
        (-[DOMNode textRects]): Added. Make a Range and call textRects.
        (-[DOMNode lineBoxRects]): Call textRects method.
        (-[DOMRange textRects]): Call Range::textRects.
        (-[DOMRange lineBoxRects]): Call textRects method.
        * bindings/objc/DOMPrivate.h: Add the new methods and a comment
        about lineBoxRects being deprecated.
        * dom/Range.cpp:
        (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects).
        (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the
        nodes instead of the RenderObjects to correctly account for offsets. Also
        only call absoluteRectsForRange on RenderText.
        * dom/Range.h: Renamed addLineBoxRects to textRects.
        * page/Frame.cpp:
        (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this
        function very specific for the lineBoxRects API. These functions are still used
        by the InspectorController, and this change improves what the Inspector shows.
        (WebCore::RenderObject::absoluteQuadsForRange): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove the topLevel boolean argument from absolute{Rects,Quads}.
timothy@apple.com [Wed, 29 Apr 2009 00:11:15 +0000 (00:11 +0000)]
    Remove the topLevel boolean argument from absolute{Rects,Quads}.
        This argument was default to true and no one ever passed false.

        Reviewed by Sam Weinig.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::absoluteRects):
        (WebCore::RenderBlock::absoluteQuads):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absoluteRects):
        (WebCore::RenderBox::absoluteQuads):
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::absoluteQuads):
        * rendering/RenderInline.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::absoluteRects):
        (WebCore::RenderObject::absoluteQuads):
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::absoluteRects):
        (WebCore::RenderSVGHiddenContainer::absoluteQuads):
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::absoluteRects):
        (WebCore::RenderSVGImage::absoluteQuads):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::absoluteRects):
        (WebCore::RenderSVGInlineText::absoluteQuads):
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::absoluteRects):
        (WebCore::RenderSVGModelObject::absoluteQuads):
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGTSpan.cpp:
        (WebCore::RenderSVGTSpan::absoluteRects):
        (WebCore::RenderSVGTSpan::absoluteQuads):
        * rendering/RenderSVGTSpan.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::absoluteQuads):
        * rendering/RenderSVGText.h:
        * rendering/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::absoluteQuads):
        * rendering/RenderSVGTextPath.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::absoluteRects):
        * rendering/RenderText.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::absoluteRects):
        (WebCore::RenderView::absoluteQuads):
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 28 Apr 2009 23:50:42 +0000 (23:50 +0000)]
2009-04-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6794691> Media documents and <video controls> never show controls on Windows

        RenderThemeWin doesn't implement the media element controller rendering methods, so media
        controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
        of the code in both places, the logic is in a new class that is called from both.

        * WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.

        * rendering/RenderMediaControls.cpp: Added.
        (WebCore::determineState): Translate renderer state to ThemeControlState.
        (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb.
        (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element.
        (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
        * rendering/RenderMediaControls.h: Added.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never
        called for the media slider.
        (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function.
        (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto.
        (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto.
        (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto.
        (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Tue, 28 Apr 2009 23:12:12 +0000 (23:12 +0000)]
2009-04-28  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
        images with % height are collapsed when printing

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHeight): Make sure we don't ignore
        printing here!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 22:36:21 +0000 (22:36 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: fix distcheck build, add (even more) missing files to list.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove performance of right shifts of large or otherwise floating point values.
oliver@apple.com [Tue, 28 Apr 2009 22:22:35 +0000 (22:22 +0000)]
Improve performance of right shifts of large or otherwise floating point values.

Reviewed by Geoff Garen.

Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Tue, 28 Apr 2009 22:17:29 +0000 (22:17 +0000)]
WebCore:

2009-04-28  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line

        Test: editing/deleting/type-delete-after-quote.html

        When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
        since it is unclear to most users that such a selection actually ends at the start of the next paragraph.  However, when a user hits delete
        with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it.  We can tell that
        we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection.  So we can tell
        that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior
        from deleting a range they selected.

        * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):

LayoutTests:

2009-04-28  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line

        * editing/deleting/type-delete-after-quote.html: Added.
        * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done,
          but the document structure remains the same, and there are no visible changes to the result.
        * platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
        * platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
        * platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 22:15:28 +0000 (22:15 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: fix distcheck build, add (more) missing files to list.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 28 Apr 2009 22:12:13 +0000 (22:12 +0000)]
    Reviewed by Simon Fraser.

        Add text gradient test to cover
        https://bugs.webkit.org/show_bug.cgi?id=25403

        * platform/mac/svg/text/text-gradient-positioning-expected.checksum: Added.
        * platform/mac/svg/text/text-gradient-positioning-expected.png: Added.
        * platform/mac/svg/text/text-gradient-positioning-expected.txt: Added.
        * svg/text/text-gradient-positioning.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 28 Apr 2009 22:09:56 +0000 (22:09 +0000)]
2009-04-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker and Darin Adler.

        Fix <rdar://problem/6836132>.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCCheckIfAllowedToLoadURL):
        Call the instance proxy.

        (WKPCCancelCheckIfAllowedToLoadURL):
        Ditto.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Initialize the check ID counter.

        (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL):
        Create a WebPluginContainerCheck, add it to the map, and start it.

        (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):
        Remove the check from the map.

        (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult):
        Call the WKPH MIG callback.

        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
        Call the instance proxy.

        (-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]):
        Ditto.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add MIG declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Hyatt.
eric@webkit.org [Tue, 28 Apr 2009 21:59:32 +0000 (21:59 +0000)]
    Reviewed by David Hyatt.

        Add text repaint test to cover
        https://bugs.webkit.org/show_bug.cgi?id=16188

        * platform/mac/svg/text/text-repaint-rects-expected.checksum: Added.
        * platform/mac/svg/text/text-repaint-rects-expected.png: Added.
        * platform/mac/svg/text/text-repaint-rects-expected.txt: Added.
        * svg/text/text-repaint-rects.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
xan@webkit.org [Tue, 28 Apr 2009 21:38:05 +0000 (21:38 +0000)]
WebCore:

2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: fix distcheck build, add missing header to file list.

        * GNUmakefile.am:

JavaScriptCore:

2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: fix distcheck build, add missing header to file list.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 28 Apr 2009 21:27:53 +0000 (21:27 +0000)]
2009-04-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Update gtk-doc control and base sgml files for 1.1.6.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
eric@webkit.org [Tue, 28 Apr 2009 20:59:07 +0000 (20:59 +0000)]
    Reviewed by Sam Weinig.

        Fix foreignObject transform order
        https://bugs.webkit.org/show_bug.cgi?id=25433

        Transforms were being applied in the wrong order.
        When mapping from local to parent, first apply the viewport transform
        then map from the viewport box to the parent box.

        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::localToParentTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 28 Apr 2009 20:56:14 +0000 (20:56 +0000)]
    Reviewed by Simon Fraser.

        Simplify nodeAtPoint for SVG
        https://bugs.webkit.org/show_bug.cgi?id=25432

        Added a new nodeAtFloatPoint method which takes a FloatPoint
        instead of the *super confusing* x/y tx/ty pairs that HTML uses.
        Mostly this is just lots of minus-lines as the new code is *much* simpler.

        I made all the SVG renderers use the new nodeAtFloatPoint and ASSERT_NOT_REACHED
        for the nodeAtPoint HTML/CSS int x/y version.

        Eventually the rest of CSS/HTML render objects will follow suit
        and move to nodeAtFloatPoint (possibly renamed back to nodeAtPoint), but changing them
        over was well outside the scope of this change.

        SVG hit testing is not actually floating point precise yet, since its still
        passed in an integer x/y.  Certain transform hit-test edge cases are likely fixed
        by moving to FloatPoint here, but I didn't try to find one.

        This should not cause functional changes for common-case hit testing, thus
        no tests changed, nor should new tests be needed.

        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::translationForAttributes):
        (WebCore::RenderForeignObject::paint):
        (WebCore::RenderForeignObject::computeRectForRepaint):
        (WebCore::RenderForeignObject::localToParentTransform):
        (WebCore::RenderForeignObject::layout):
        (WebCore::RenderForeignObject::nodeAtFloatPoint):
        * rendering/RenderForeignObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::nodeAtFloatPoint):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::nodeAtFloatPoint):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::nodeAtFloatPoint):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::pointIsInsideViewportClip):
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::nodeAtFloatPoint):
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        (WebCore::RenderSVGImage::nodeAtFloatPoint):
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::localToParentTransform):
        (WebCore::RenderSVGImage::localTransform):
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::nodeAtFloatPoint):
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::nodeAtFloatPoint):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::nodeAtFloatPoint):
        * rendering/RenderSVGText.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip):
        * rendering/RenderSVGViewportContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 28 Apr 2009 20:42:47 +0000 (20:42 +0000)]
2009-04-28  Eric Carlson  <eric.carlson@apple.com>

        - fix the Tiger build

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::cacheMovieScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 28 Apr 2009 20:30:52 +0000 (20:30 +0000)]
2009-04-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Beth Dakin.

        Consolidate ScheduleAction creation into ScheduledAction::create.
        Autogenerate JSWorkerContext.clearTimeout and clearInterval.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setTimeout):
        (WebCore::JSDOMWindow::setInterval):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::setTimeout):
        (WebCore::JSWorkerContext::setInterval):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):
        (WebCore::ScheduledAction::ScheduledAction):
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * workers/WorkerContext.cpp:
        (WebCore::DOMWindow::setTimeout):
        (WebCore::DOMWindow::clearTimeout):
        (WebCore::DOMWindow::setInterval):
        (WebCore::DOMWindow::clearInterval):
        * workers/WorkerContext.h:
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix link warnings building TestNetscapePlugin on Windows due to mismatched
sfalken@apple.com [Tue, 28 Apr 2009 20:22:03 +0000 (20:22 +0000)]
    Fix link warnings building TestNetscapePlugin on Windows due to mismatched
        DLL name vs. LIBRARY directive name.

        Reviewed by Jon Honeycutt.

        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 28 Apr 2009 20:21:24 +0000 (20:21 +0000)]
2009-04-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

Updated with news for the 1.1.6 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Tue, 28 Apr 2009 20:14:39 +0000 (20:14 +0000)]
WebCore:

2009-04-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed

        When moving Nodes between documents we weren't properly updating style declarations.  Certain operations, such
        as creating webarchives, would tickle this bug.

        Tests: webarchive/adopt-attribute-styled-body-webarchive.html
               webarchive/adopt-attribute-styled-node-webarchive.html
               webarchive/adopt-inline-styled-node-webarchive.html

        * dom/Node.cpp:  Add a debug-only mechanism to insure that anyone who overrides (did/will)MoveToNewOwnerDocument
          calls their parent-class implementation after they've done their own work.
        (WebCore::setWillMoveToNewOwnerDocumentWasCalled):
        (WebCore::setDidMoveToNewOwnerDocumentWasCalled):
        (WebCore::Node::setDocument):
        (WebCore::Node::willMoveToNewOwnerDocument):
        (WebCore::Node::didMoveToNewOwnerDocument):

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::attributeChanged): Add a comment explaining why we don't need to walk the nameAttrMap
          to update style declarations.
        (WebCore::StyledElement::didMoveToNewOwnerDocument): Update the parent pointer for the inline style declaration.
        * dom/StyledElement.h:

        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): Update the parent pointer for the link declaration.
        * html/HTMLBodyElement.h:

LayoutTests:

2009-04-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed

        * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive: Added.
        * webarchive/adopt-attribute-styled-body-webarchive.html: Added.
        * webarchive/resources/adopt-attribute-styled-body-iframe.html: Added.
        * webarchive/resources/adopt-attribute-styled-body-second-window.html: Added.

        * webarchive/adopt-attribute-styled-node-webarchive-expected.webarchive: Added.
        * webarchive/adopt-attribute-styled-node-webarchive.html: Added.
        * webarchive/resources/adopt-attribute-styled-node-second-window.html: Added.

        * webarchive/adopt-inline-styled-node-webarchive-expected.webarchive: Added.
        * webarchive/adopt-inline-styled-node-webarchive.html: Added.
        * webarchive/resources/adopt-inline-styled-node-second-window.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix warnings about PRODUCTION and ARCHIVE_BUILD on Windows builds
sfalken@apple.com [Tue, 28 Apr 2009 19:48:05 +0000 (19:48 +0000)]
    Fix warnings about PRODUCTION and ARCHIVE_BUILD on Windows builds
        of ImageDiff and DumpRenderTree.

        Rubber stamped by Adam Roben.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 28 Apr 2009 19:46:04 +0000 (19:46 +0000)]
2009-04-28  Eric Carlson  <eric.carlson@apple.com>

         Reviewed by Darin Adler.

        <rdar://problem/6834876> Don't use BlockExceptions macros until QTKit supports
        QTMoviePreferredTransformAttribute

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::cacheMovieScale): use @try and @catch instead of
        BEGIN_BLOCK_OBJC_EXCEPTIONS and END_BLOCK_OBJC_EXCEPTIONS for builds of QTKit
        that throw an exception on QTMovieCurrentSizeAttribute but don't support
        QTMoviePreferredTransformAttribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 28 Apr 2009 19:43:29 +0000 (19:43 +0000)]
2009-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText): Streamline code path to avoid a bit of reference count
        churn and remove a strange unneeeded PassRefPtr typecast. Also added a comment.
        (WebCore::RenderText::setTextInternal): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 28 Apr 2009 19:37:32 +0000 (19:37 +0000)]
    Reviewed by Simon Fraser.

        Simplify how SVG containers paint
        https://bugs.webkit.org/show_bug.cgi?id=25431

        Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
        Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
        RenderSVGText now applies transforms at paint() time instead of during chunk draw time
        this should be much more efficient.

        Fixed the order in which RenderSVGViewportContainer applied
        transforms and clips.  We now clip to the viewport first and apply
        all transforms at once.  Also since the viewport logic is now only
        inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
        we always know we have a viewport.  We now use only viewportSize instead of
        viewport() since RenderSVGViewportContainers can't have x/y offsets.

        We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
        This allowed us to apply the transform during text paint() instead of at chunk paint
        time. Previously we had to apply the transform during chunk paint time because
        RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
        before telling any of the inlines to draw.  Now that we adjust the damage rect correctly
        we pass the intersection check correctly!  (This probably fixed some <text> redraw bugs
        but since I still have a bunch of those to fix, I've not tried to write additional tests
        to cover these potential fixes yet.)

        SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::repaintRectInLocalCoordinates):
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::applyViewportClip):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout):
        (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
        (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGImage::computeRectForRepaint):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGModelObject.cpp:
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):
        (WebCore::RenderSVGRoot::selfWillPaint):
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::viewportSize):
        (WebCore::RenderSVGRoot::calcViewport):
        (WebCore::RenderSVGRoot::localToBorderBoxTransform):
        (WebCore::RenderSVGRoot::parentOriginToBorderBox):
        (WebCore::RenderSVGRoot::borderOriginToContentBox):
        (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
        (WebCore::RenderSVGRoot::localToParentTransform):
        (WebCore::RenderSVGRoot::computeRectForRepaint):
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGText::computeRectForRepaint):
        (WebCore::RenderSVGText::paint):
        (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
        * rendering/RenderSVGText.h:
        (WebCore::RenderSVGText::localToParentTransform):
        (WebCore::RenderSVGText::localTransform):
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::applyViewportClip):
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::filterBoundingBoxForRenderer):
        (WebCore::applyTransformToPaintInfo):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
        (WebCore::SVGRootInlineBox::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25453: AX: fall back to PLACEHOLDER attr if form element is not labeled
cfleizach@apple.com [Tue, 28 Apr 2009 19:37:09 +0000 (19:37 +0000)]
Bug 25453: AX: fall back to PLACEHOLDER attr if form element is not labeled
https://bugs.webkit.org/show_bug.cgi?id=25453

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25452: AX: Don't create addition space AXStaticText element for every bold or...
cfleizach@apple.com [Tue, 28 Apr 2009 19:14:05 +0000 (19:14 +0000)]
Bug 25452: AX: Don't create addition space AXStaticText element for every bold or link tag
https://bugs.webkit.org/show_bug.cgi?id=25452

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWork around <rdar://problem/6833240> by relying on static initialization to zero...
mrowe@apple.com [Tue, 28 Apr 2009 18:57:58 +0000 (18:57 +0000)]
Work around <rdar://problem/6833240> by relying on static initialization to zero the entire struct.
This removes the need for us to explicitly initialize all of the members, which have a tendency
to change in meaning and number between versions of libxml2.

Reviewed by Sam Weinig.

* dom/XMLTokenizerLibxml2.cpp:
(WebCore::):
(WebCore::sharedXHTMLEntity):
(WebCore::getXHTMLEntity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix extraneous warning about AnalyzeWithLargeStack not being defined in Windo...
sfalken@apple.com [Tue, 28 Apr 2009 18:56:53 +0000 (18:56 +0000)]
    Fix extraneous warning about AnalyzeWithLargeStack not being defined in Windows builds.
        Indirected definition through a UserMacro.

        Reviewed by Mark Rowe.

        * win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix linker warning by specifying /NODEFAULTLIB:LIBCMT for QTMovieWin.
sfalken@apple.com [Tue, 28 Apr 2009 18:52:46 +0000 (18:52 +0000)]
    Fix linker warning by specifying /NODEFAULTLIB:LIBCMT for QTMovieWin.

        Reviewed by Mark Rowe.

        * WebCore.vcproj/QTMovieWin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25449: AX: Respect the alt tag of ARIA button as AXDescription
cfleizach@apple.com [Tue, 28 Apr 2009 18:32:40 +0000 (18:32 +0000)]
Bug 25449: AX: Respect the alt tag of ARIA button as AXDescription
https://bugs.webkit.org/show_bug.cgi?id=25449

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix extraneous warning about PRODUCTION not being defined in Windows builds.
sfalken@apple.com [Tue, 28 Apr 2009 18:29:58 +0000 (18:29 +0000)]
    Fix extraneous warning about PRODUCTION not being defined in Windows builds.
        Indirected definition for __PRODUCTION__ through a UserMacro.

        Reviewed by Mark Rowe.

        * win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by John Sullivan.
mitz@apple.com [Tue, 28 Apr 2009 18:16:16 +0000 (18:16 +0000)]
    Reviewed by John Sullivan.

        - formatting cleanup

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHeight): Corrected indentation and added braces
        around a multi-line "else" clause.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 28 Apr 2009 18:05:52 +0000 (18:05 +0000)]
2009-04-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben

        <rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
        https://bugs.webkit.org/show_bug.cgi?id=25094

        Display movies saved with a non-identity matrix at the correct size.

        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWinPrivate::QTMovieWinPrivate): Initialize m_widthScaleFactor and m_heightScaleFactor.
        (QTMovieWinPrivate::cacheMovieScale): New, calculate difference between initial
        size and natural size so naturalSize() accounts for non-identity movie matrix.
        (QTMovieWinPrivate::task):Call cacheMovieScale when load state reaches
        kMovieLoadStateLoaded for the first time. kMovieLoadState -> QTMovieLoadState.
        (QTMovieWinPrivate::drawingComplete): kMovieLoadState -> QTMovieLoadState.
        (QTMovieWinPrivate::createGWorld): Don't bother creating gworld until load state reaches
        kMovieLoadStateLoaded because we do not try to draw it before that point.
        (QTMovieWinPrivate::setSize): Do not change movie box before reaching kMovieLoadStateLoaded
        because we need to get the movie's initial size in cacheMovieScale.
        (QTMovieWin::getNaturalSize): Multiply width and height by initial scale.

2009-04-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben

        <rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
        https://bugs.webkit.org/show_bug.cgi?id=25094

        * platform/win/Skipped: Re-enable video-size-intrinsic-scale.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 28 Apr 2009 17:43:15 +0000 (17:43 +0000)]
2009-04-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Move timer code from JSDOMWindow to DOMWindow. clearTimeout and
        clearInterval can now be autogenerated.

        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::createScheduledAction):
        (WebCore::JSDOMWindow::setTimeout):
        (WebCore::JSDOMWindow::setInterval):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setTimeout):
        (WebCore::DOMWindow::clearTimeout):
        (WebCore::DOMWindow::setInterval):
        (WebCore::DOMWindow::clearInterval):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 28 Apr 2009 17:06:24 +0000 (17:06 +0000)]
Reviewed by Kevin Ollivier.

Small optimization, don't get the widget's handle twice in one method.

https://bugs.webkit.org/show_bug.cgi?id=25446

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by John Sullivan.
mitz@apple.com [Tue, 28 Apr 2009 16:46:49 +0000 (16:46 +0000)]
    Reviewed by John Sullivan.

        - fix <rdar://problem/6786360> Make PDF an insertable pasteboard type

        * WebCoreSupport/WebPasteboardHelper.mm:
        (WebPasteboardHelper::insertablePasteboardTypes):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
        (+[WebHTMLView _insertablePasteboardTypes]):
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 28 Apr 2009 16:31:55 +0000 (16:31 +0000)]
Reviewed by Kevin Ollivier.

ScrollView copy and paste typo fix.

https://bugs.webkit.org/show_bug.cgi?id=25445

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 28 Apr 2009 16:27:12 +0000 (16:27 +0000)]
2009-04-28  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        QWebElement API changes after another round of API review:

        * Fix argument names of findAll/findFirst
        * Split up toXml into innerXml and outerXml
        * Removed confusing toggleClass overload
        * Fixed casing of namespaceUri to follow QXmlStreamReader
        * Removed tagName from firstChild/nextSibling/etc.
        * Renamed append/prepend/insertAfter/insertBefore to [append|prepend][Inside|Outside]
        * Renamed wrapWith() back to wrap()
        * Made clone() const
        * Renamed remove() to takeFromDocument(), added removeFromDocument()
        * Renamed clear() to removeChildren()
        * Renamed scriptsFunctions/callScriptFunction to functions()/callFunction()
        * Renamed scriptProperty to scriptableProperty

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 16:09:41 +0000 (16:09 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: bump versions in preparation for 1.1.6 release.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 16:06:21 +0000 (16:06 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Leave a bit of space from the previous page when advacing a whole
        page. This matches the behavior of our scrollbar scrolling code
        and is just nicer in general.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 28 Apr 2009 15:55:23 +0000 (15:55 +0000)]
Reviewed by Kevin Ollivier.

Add a function for resetting the zoom factor to 1.0.

https://bugs.webkit.org/show_bug.cgi?id=25447

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Tue, 28 Apr 2009 14:01:49 +0000 (14:01 +0000)]
2009-04-28  John Sullivan  <sullivan@apple.com>

        <rdar://problem/6820221> REGRESSION: 2-byte character names of images are displayed as %-encoded ASCII

        Reviewed by Adam Roben

        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finish):
        decode the filename before processing it as part of the image name that's passed to the client

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 28 Apr 2009 13:51:28 +0000 (13:51 +0000)]
2009-04-28  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Fix some qdoc warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 28 Apr 2009 09:59:08 +0000 (09:59 +0000)]
2009-04-28  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed, build fix.

        - fix initialization order to match declaration order to fix release build

        * page/Settings.cpp:
        (WebCore::Settings::Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 08:55:57 +0000 (08:55 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: committed a few bits by mistake, remove them.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::handleEditingKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 08:45:06 +0000 (08:45 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=16135
        [GTK] Support caret browsing

        Refactor keyboard event handling to work properly under caret
        browsing mode. Most of the code comes from the Windows port.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::):
        (WebKit::interpretKeyEvent):
        (WebKit::handleEditingKeyboardEvent):
        (WebKit::EditorClient::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 08:44:54 +0000 (08:44 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=16135
        [GTK] Support caret browsing

        Based on a patch by Alp Toker.

        Add enable-caret-browsing setting to WebKitWebView.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 08:44:40 +0000 (08:44 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Justin Garcia.

        https://bugs.webkit.org/show_bug.cgi?id=16135
        [GTK] Support caret browsing

        Based on a patch by Alp Toker.

        Implement basic support for caret browsing, active only when the
        corresponding setting is enabled.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseReleaseEvent):
        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocus):
        (WebCore::clearSelectionIfNeeded):
        (WebCore::FocusController::setFocusedNode):
        * page/Frame.cpp:
        (WebCore::Frame::setFocusedNodeIfNeeded):
        (WebCore::Frame::setSelectionFromNone):
        (WebCore::Frame::respondToChangedSelection):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 28 Apr 2009 08:08:07 +0000 (08:08 +0000)]
2009-04-28  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Maciej "Henry Morgan" Stachowiak.

        Enable YARR.
        (Again.)

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-27 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 28 Apr 2009 07:10:34 +0000 (07:10 +0000)]
2009-04-27  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Maciej Stachowiak.

        Tweak a loop condition to keep GCC happy,
        some GCCs seem to be having issues with this. :-/

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::breakTarget):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-27 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 28 Apr 2009 06:05:03 +0000 (06:05 +0000)]
2009-04-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Disable test intermittent failing test.

        * svg/custom/filter-source-alpha.svg: Removed.
        * svg/custom/filter-source-alpha.svg-disabled: Copied from svg/custom/filter-source-alpha.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-27 Pierre d'Herbemont <pdherbemont@apple.com>
simon.fraser@apple.com [Tue, 28 Apr 2009 05:14:16 +0000 (05:14 +0000)]
2009-04-27  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser

        Fix video-played.html layout test.

        https://bugs.webkit.org/show_bug.cgi?id=25424

        We implement playForMillisecs() which makes sure the video
        will have been playing for a minimum time.

        Note, this does not ensure a strict synchronization between the time
        asked and the media playback. But given that media playback is the
        slow part we just need to compensate for the delay involved by playback.
        (And not the other way around.)

        Moreover, we split the test in 3 in order to be more gentle which
        slower machines that may tend to timeout more easily on those tests.

        * media/video-played-collapse-expected.txt: Added.
        * media/video-played-collapse.html: Added.
        * media/video-played-expected.txt:
        * media/video-played-reset-expected.txt: Added.
        * media/video-played-reset.html: Added.
        * media/video-played.html:
        - Split tests in multiple files.
        - Makes sure we always play as much as requested by using
        playForMillisecs();
        * media/video-played.js: Added.
        (testRanges):
        (nextTest):
        (pause):
        (canplay):
        (willCreateNewRange):
        (startPlayingInNewRange):
        (startPlaying):
        (secToMilli):
        (milliToSecs):
        (playForMillisecs.callPauseIfTimeIsReached):
        (playForMillisecs):
        (videoPlayedMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-27 Eric Roman <eroman@chromium.org>
dglazkov@chromium.org [Tue, 28 Apr 2009 03:39:20 +0000 (03:39 +0000)]
2009-04-27  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Fisher.

        Fix a compile breakage.
        <https://bugs.webkit.org/show_bug.cgi?id=25384>

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-27 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 28 Apr 2009 01:01:00 +0000 (01:01 +0000)]
2009-04-27  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception and will crash

        QTMovieCurrentSizeAttribute generates an exception with some versions of QTKit, so calculate a
        multiplier to scale from natural size to current size when a movie is opened and use that to
        return the correct value from the naturalSize() method.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_scaleFactor.
        (WebCore::MediaPlayerPrivate::naturalSize): Return naturalSize transformed by initial scale.
        (WebCore::MediaPlayerPrivate::cacheMovieScale): New, calculate difference between initial
        size and natural size so naturalSize() accounts for non-identity movie matrix.
        (WebCore::MediaPlayerPrivate::updateStates): Call cacheMovieScale when load state reaches
        QTMovieLoadStateLoaded for the first time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Tue, 28 Apr 2009 00:54:57 +0000 (00:54 +0000)]
WebCore:

2009-04-27  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Fix for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work

        The problem here is that we had a self-painting layer nested inside
        a non-self-painting layer. We ended up ignoring the self-painting
        layer both during painting and hit-testing. This patch corrects
        that.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):

LayoutTests:

2009-04-27  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Test for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work

        * fast/css/nested-layers-with-hover.html: Added.
        * platform/mac/fast/css/nested-layers-with-hover-expected.checksum: Added.
        * platform/mac/fast/css/nested-layers-with-hover-expected.png: Added.
        * platform/mac/fast/css/nested-layers-with-hover-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago If it has been set to allow any HTTPS certificates for this host, set
adachan@apple.com [Tue, 28 Apr 2009 00:23:03 +0000 (00:23 +0000)]
    If it has been set to allow any HTTPS certificates for this host, set
        kCFStreamSSLAllowsExpiredCertificates to true to allow expired
        certificate, and set kCFStreamSSLValidatesCertificateChain false to skip
        certificate chain validation. (<rdar://problem/6382059>)

        Reviewed by John Sullivan.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::makeFinalRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 28 Apr 2009 00:12:31 +0000 (00:12 +0000)]
2009-04-23  Simon Fraser  <simon.fraser@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=22242

        Add pixel test for zoomed video with controls, with and without a transform.

        * media/video-zoom-controls.html: Added.
        * platform/mac/media/video-zoom-controls-expected.checksum: Added.
        * platform/mac/media/video-zoom-controls-expected.png: Added.
        * platform/mac/media/video-zoom-controls-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 28 Apr 2009 00:08:33 +0000 (00:08 +0000)]
2009-04-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson

        <rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well

        Fix a 'size changed' notification thrash that caused standalone video elements
        to continually resize after full page zooming, by using the movie's natual size (which is independent
        of zooming), rather than its current size (which is not).

        Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
        disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
        QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
        <rdar://problem/6822344>.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::naturalSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 27 Apr 2009 23:58:18 +0000 (23:58 +0000)]
2009-04-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6642221> REGRESSION: With the Movie widget, movie trailer fails to
        load if movie had been previously viewed

        Fix the Dashboard quirk for display:none plug-ins by moving the code from HTMLObjectElement
        to HTMLEmebedElement. It has to be in HTMLEmbedElement because the content we care about uses <embed>.

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::rendererIsNeeded):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::rendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42913 268f45cc-cd09-0410-ab3c-d52691b4dbfc