WebKit-https.git
10 years ago2010-01-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 7 Jan 2010 12:13:53 +0000 (12:13 +0000)]
2010-01-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Holger Freyther.

        [Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
        https://bugs.webkit.org/show_bug.cgi?id=33312

        Using of operator += cause compile error on Mac, so it is changed to
        "= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".

        * wtf/FastMalloc.cpp:
        (WTF::TCMallocStats::realloc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReworked r52853 after r52876 rolled it out.
ossy@webkit.org [Thu, 7 Jan 2010 12:12:32 +0000 (12:12 +0000)]
Reworked r52853 after r52876 rolled it out.
Chomp the pid variable before passing it to kill and read the contents of
the pidfile in a platform independent manner.
First pach of https://bugs.webkit.org/show_bug.cgi?id=33153.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 11:50:44 +0000 (11:50 +0000)]
2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Adam Barth.

        Created a module that runs the style package unit tests.

        https://bugs.webkit.org/show_bug.cgi?id=32973

        * Scripts/test-webkitpy:
        * Scripts/webkitpy/style/unittests.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 7 Jan 2010 11:35:40 +0000 (11:35 +0000)]
2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Some IDL files lack "," separators for extended attributes.
        https://bugs.webkit.org/show_bug.cgi?id=33190

        To find such mistakes, IDLParser.pm rejects whitespace characters in
        extended attribute names.

        * bindings/scripts/IDLParser.pm:
          parseExtendedAttributes rejects whitespace in a name.
        * css/WebKitCSSTransformValue.idl: Add missing ",".
        * dom/EventTarget.idl: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] need an API to suspend and resume active Javascript DOM objects.
hausmann@webkit.org [Thu, 7 Jan 2010 11:24:15 +0000 (11:24 +0000)]
[Qt] need an API to suspend and resume active Javascript DOM objects.
https://bugs.webkit.org/show_bug.cgi?id=31673

Patch by Yongjun Zhang  <yongjun.zhang@nokia.com>, Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2010-01-07
Reviewed by Simon Hausmann.

Add suspend and resume DOM objects private API to QWebFrame.

* Api/qwebframe.cpp:
(qt_suspendActiveDOMObjects):
(qt_resumeActiveDOMObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 7 Jan 2010 10:52:04 +0000 (10:52 +0000)]
2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
        WebKitCSSTransformValue.idl correctly.
        https://bugs.webkit.org/show_bug.cgi?id=33193

        CodeGeneratorV8.pm doesn't handle inheritance very well and it
        tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
        which does not exist. Because WebKitCSSTransformValue inherits
        CSSValueList and CSSValueList already has HadIndexGetter, we don't
        need to do anything for WebKitCSSTransformValue about HasIndexGetter.

        * bindings/scripts/CodeGeneratorV8.pm:
          Reset $hasGetter for WebKitCSSTransformValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 10:22:40 +0000 (10:22 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Don't print a redundant message when confirming a diff
        https://bugs.webkit.org/show_bug.cgi?id=33315

        Instead of saying "ERROR: User declined" we should just exit because
        the use knows they just declined!

        * Scripts/webkitpy/steps/confirmdiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 7 Jan 2010 10:19:38 +0000 (10:19 +0000)]
2010-01-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Holger Freyther.

        [Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
        https://bugs.webkit.org/show_bug.cgi?id=33312

        Remove pByte (committed in r42344 from #20422), because pByte doesn't
        exist and it is unnecessary.

        * wtf/FastMalloc.cpp:
        (WTF::TCMallocStats::realloc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 10:12:54 +0000 (10:12 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Check style before uploading a patch
        https://bugs.webkit.org/show_bug.cgi?id=33314

        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/steps/checkstyle.py:
        * Scripts/webkitpy/steps/options.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 09:51:01 +0000 (09:51 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Add prepare and post to webkit-patch main help
        https://bugs.webkit.org/show_bug.cgi?id=33313

        * Scripts/webkitpy/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 08:57:10 +0000 (08:57 +0000)]
2010-01-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
        https://bugs.webkit.org/show_bug.cgi?id=33290

        Add the Chromium builders to our list of core builders and test that our regexps work.
        I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.

        * Scripts/webkitpy/buildbot.py:
        * Scripts/webkitpy/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 08:49:25 +0000 (08:49 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool needs a new name
        https://bugs.webkit.org/show_bug.cgi?id=28459

        Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
        make more sense with the new name.

        * Scripts/bugzilla-tool: Removed.
        * Scripts/webkit-patch: Added.
        * Scripts/webkit-tools-completion.sh:
        * Scripts/webkitpy/bugzilla_unittest.py:
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/download_unittest.py:
        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commands/queues.py:
        * Scripts/webkitpy/commands/queues_unittest.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:
        * Scripts/webkitpy/queueengine.py:
        * Scripts/webkitpy/steps/completerollout.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 08:36:52 +0000 (08:36 +0000)]
2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Eric Seidel.

        Moved style-related modules to webkitpy.style sub-package.

        https://bugs.webkit.org/show_bug.cgi?id=32971

        * Scripts/check-webkit-style:
          - Updated import statement.

        * Scripts/test-webkitpy:
          - Updated import statements.

        * Scripts/webkitpy/cpp_style.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/cpp_style_unittest.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/style.py: Removed.
          - Moved to webkitpy/style/checker.py.

        * Scripts/webkitpy/style/__init__.py: Added.
          - Added containing webkitpy directory to package search path.

        * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
        * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
          - Updated import statement.

        * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
        * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
          - Update import statement.

        * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
        * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
        * Scripts/webkitpy/style_unittest.py: Removed.
          - Moved to webkitpy/style/checker_unittest.py.

        * Scripts/webkitpy/text_style.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/text_style_unittest.py: Removed.
          - Moved to webkitpy/style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 7 Jan 2010 08:22:04 +0000 (08:22 +0000)]
2010-01-07  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Do not return strings whose handles are in near death state (that means
        they might be GCed) or just empty.
        https://bugs.webkit.org/show_bug.cgi?id=31180

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8ExternalString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 MORITA Hajime <morrita@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 08:06:01 +0000 (08:06 +0000)]
2010-01-06  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Nikolas Zimmermann.

        SVG background color on selected text goes wrong when text has
        gradient stroke.
        https://bugs.webkit.org/show_bug.cgi?id=33069

        Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
        and paint background and foreground in separate subphase.

        * svg/text/selection-background-color.xhtml: Added.
        * platform/mac/svg/text/selection-background-color-expected.checksum: Added.
        * platform/mac/svg/text/selection-background-color-expected.png: Added.
        * platform/mac/svg/text/selection-background-color-expected.txt: Added.

        * platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
        * platform/mac/svg/batik/text/textDecoration2-expected.checksum:
        * platform/mac/svg/batik/text/textDecoration2-expected.png:
        * platform/mac/svg/text/text-deco-01-b-expected.checksum:
        * platform/mac/svg/text/text-deco-01-b-expected.png:
        * platform/mac/svg/text/text-spacing-01-b-expected.checksum:
        * platform/mac/svg/text/text-spacing-01-b-expected.png:
        * platform/mac/svg/text/text-text-03-b-expected.checksum:
        * platform/mac/svg/text/text-text-03-b-expected.png:
        * platform/mac/svg/text/text-text-08-b-expected.checksum:
        * platform/mac/svg/text/text-text-08-b-expected.png:
        Re-baselined due to painting algorithm change.
2010-01-06  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Nikolas Zimmermann.

        SVG background color on selected text goes wrong when text has
        gradient stroke.
        https://bugs.webkit.org/show_bug.cgi?id=33069

        Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
        and paint background and foreground in separate subphase.

        Test: svg/text/selection-background-color.xhtml

        * rendering/SVGCharacterLayoutInfo.h:
        (WebCore::SVGTextChunkWalker::SVGTextChunkWalker):
        Added m_setupBackgroundCallback, m_setupForegroundCallback
        (WebCore::SVGTextChunkWalker::setupBackground):
        (WebCore::SVGTextChunkWalker::setupForeground):
        Added.
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::paintCharacters):
        pass SVGTextPaintInfo instead of SVGPaintServer
        * rendering/SVGInlineTextBox.h:
        (WebCore::SVGTextPaintSubphase):
        (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
        Added.
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::walkTextChunks):
        Invoke setupBackground() and setupForeground()
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupBackgroundCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupForegroundCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer):
        Added.
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
        (WebCore::SVGRootInlineBox::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Thu, 7 Jan 2010 07:07:54 +0000 (07:07 +0000)]
2010-01-06  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Return an invalid Qt::ImMicroFocus if queried while the view needs to layout.

        https://bugs.webkit.org/show_bug.cgi?id=33204

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Kinuko Yasuda <kinuko@chromium.org>
tkent@chromium.org [Thu, 7 Jan 2010 06:12:53 +0000 (06:12 +0000)]
2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        Remove fast/events/keydown-numpad-key.html from the Skipped list.
        https://bugs.webkit.org/show_bug.cgi?id=33250

        * platform/qt/Skipped:

2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        Make windowsKeyCodeForKeyEvent() return correct key code for
        numeric-pad arrow keys.
        https://bugs.webkit.org/show_bug.cgi?id=33250

        Test: fast/events/keydown-numpad-keys.html

        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::windowsKeyCodeForKeyEvent):

2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        [Qt] Support the 3rd argument of EventSender.keyDown that
        has been recently added to report keyLocation
        (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
        https://bugs.webkit.org/show_bug.cgi?id=33250

        Test: fast/events/keydown-numpad-keys.html

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::keyDown):
        * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 06:00:23 +0000 (06:00 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add long_help for all common commands.
        https://bugs.webkit.org/show_bug.cgi?id=33261

        For now these long_helps are pretty basic.
        These were all written to just explain the steps
        that each command runs.  This style long_help could
        be made easier by using:
        https://bugs.webkit.org/show_bug.cgi?id=33257

        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/queries.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-18 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Thu, 7 Jan 2010 05:30:26 +0000 (05:30 +0000)]
2009-10-18 Patrick Gansterer <paroga@paroga.com>

        Reviewed by Dirk Schulze.

        Improve DOM performance in large SVG files.
        Check the dirty area before painting a path, which prevents unnecessary
        clipping and changes to the GraphicsContext.
        https://bugs.webkit.org/show_bug.cgi?id=30055

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Jan 2010 04:45:10 +0000 (04:45 +0000)]
2010-01-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Use a static HashMap for HTMLElement::tagPriority().
        https://bugs.webkit.org/show_bug.cgi?id=33269

        The prior code compares AtomicStringImpl pointers 18 times at
        worst. This change avoids it.

        No new tests because this is just a refactoring.

        * html/HTMLElement.cpp:
        (WebCore::Empty1IntHashTraits): A HashTraits to return 1 as the empty value.
        (WebCore::initializeTagPriorityMap): Initialization of a static HashMap.
        (WebCore::HTMLElement::tagPriority): Use the static HashMap created by initializeTagPriorityMap().
        * html/HTMLElement.h:
        (WebCore::HTMLElement::HTMLElement): Add an assertion about non-null localName().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Mike Belshe <mike@belshe.com>
eric@webkit.org [Thu, 7 Jan 2010 04:06:25 +0000 (04:06 +0000)]
2010-01-06  Mike Belshe  <mike@belshe.com>

        Add a flag to the ResourceResponse for tracking if a request was
        fetched via SPDY.  This is plumbed through so that we can inform
        a webpage via JavaScript if it was fecthed via the experimental
        SPDY protocol.

        https://bugs.webkit.org/show_bug.cgi?id=33186

        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::wasFetchedViaSpdy):
        (WebCore::ResourceResponse::setWasFetchedViaSpdy):
2010-01-06  Mike Belshe  <mike@belshe.com>

        Add a flag to the ResourceResponse for tracking if a request was
        fetched via SPDY.  This is plumbed through so that we can inform
        a webpage via JavaScript if it was fecthed via the experimental
        SPDY protocol.

        https://bugs.webkit.org/show_bug.cgi?id=33186

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::wasFetchedViaSpdy):
        (WebKit::WebURLResponse::setWasFetchedViaSpdy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add page zooming support to Qt DumpRenderTree
tonikitoo@webkit.org [Thu, 7 Jan 2010 04:01:26 +0000 (04:01 +0000)]
[Qt] Add page zooming support to Qt DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=32898

Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
         Diego Gonzalez <diego.gonzalez@openbossa.org> and
         Afonso Costa <afonso.costa@openbossa.org> on 2010-01-06
Reviewed by Kenneth Christiansen.

WebKitTools:

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::zoomPageIn):
(EventSender::zoomPageOut):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 03:37:50 +0000 (03:37 +0000)]
2010-01-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Adam Treat.

        [Qt] RenderTheme: Missing support for native sliders

        https://bugs.webkit.org/show_bug.cgi?id=33122

        Implement painting of native slider controls in RenderTheme
        and unskip a couple of layout tests that are passing after
        this change.

        * platform/qt/Skipped:
2010-01-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Adam Treat.

        [Qt] RenderTheme: Missing support for native sliders

        https://bugs.webkit.org/show_bug.cgi?id=33122

        Implement painting of native slider controls in RenderTheme
        and unskip a couple of layout tests that are passing after
        this change.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintSliderTrack):
        (WebCore::RenderThemeQt::adjustSliderTrackStyle):
        (WebCore::RenderThemeQt::paintSliderThumb):
        (WebCore::RenderThemeQt::adjustSliderThumbStyle):
        (WebCore::RenderThemeQt::supportsFocus):
        (WebCore::RenderThemeQt::adjustSliderThumbSize):
        * platform/qt/RenderThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Thu, 7 Jan 2010 03:23:16 +0000 (03:23 +0000)]
2010-01-06  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Darin Adler.

        Adjust incorrect comments after r40534.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::markActiveObjectsForContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for chromium.
ukai@chromium.org [Thu, 7 Jan 2010 02:57:53 +0000 (02:57 +0000)]
Unreviewed build fix for chromium.
Add "bool V8WorkerContext::WebSocketEnabled()"

* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::WebSocketEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
ukai@chromium.org [Thu, 7 Jan 2010 02:45:24 +0000 (02:45 +0000)]
Unreviewed build fix.
remove wrong assertion

* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 7 Jan 2010 02:33:35 +0000 (02:33 +0000)]
2010-01-06  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin

        Add WebSocket feature in Worker
        https://bugs.webkit.org/show_bug.cgi?id=32214

        * websocket/tests/workers/resources/simple_wsh.py: Copied from LayoutTests/websocket/tests/simple_wsh.py.
        * websocket/tests/workers/resources/worker-simple.js: Added.
        * websocket/tests/workers/worker-simple-expected.txt: Added.
        * websocket/tests/workers/worker-simple.html: Added.
2010-01-06  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        Add WebSocket feature in Worker
        https://bugs.webkit.org/show_bug.cgi?id=32214

        Introduce ThreadableWebSocketChannel interface and add
        WorkerThreadableWebSocketChannel for Worker.
        WorkerThreadableWebSocketChannel uses WebSocketChannel in the
        main thread, which is managed by Peer and communicated via Bridge.

        Test: websocket/tests/workers/worker-simple.html

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSWebSocketConstructor.h:
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::webSocket):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        (WebCore::V8Custom::v8WebSocketConstructorCallback):
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        * platform/CrossThreadCopier.cpp:
        (WebCore::::copy):
        * platform/CrossThreadCopier.h:
        (WebCore::):
        * websockets/ThreadableWebSocketChannel.cpp: Added.
        * websockets/ThreadableWebSocketChannel.h: Added.
        * websockets/ThreadableWebSocketChannelClientWrapper.h: Added.
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::connect):
        (WebCore::WebSocket::didReceiveMessage):
        * websockets/WebSocket.h:
        * websockets/WebSocketChannel.h:
        (WebCore::WebSocketChannel::refThreadableWebSocketChannel):
        (WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
        * websockets/WebSocketChannelClient.h:
        * websockets/WebSocketHandshake.h:
        * websockets/WorkerThreadableWebSocketChannel.cpp: Added.
        * websockets/WorkerThreadableWebSocketChannel.h: Added.
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Adam Bergkvist <adam.bergkvist@ericsson.com>
eric@webkit.org [Thu, 7 Jan 2010 02:20:02 +0000 (02:20 +0000)]
2010-01-06  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        Reviewed by Darin Adler.

        Modified EventSource event-stream parser to support a single CR as line ending.
        Updated test accordingly.
        https://bugs.webkit.org/show_bug.cgi?id=33207

        * http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
        * http/tests/eventsource/eventsource-parse-event-stream.html:
        * http/tests/eventsource/resources/event-stream.php:
2010-01-06  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        Reviewed by Darin Adler.

        Modified EventSource event-stream parser to support a single CR as line ending.
        https://bugs.webkit.org/show_bug.cgi?id=33207

        * page/EventSource.cpp:
        (WebCore::EventSource::EventSource):
        (WebCore::EventSource::parseEventStream):
        * page/EventSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 02:05:01 +0000 (02:05 +0000)]
2010-01-06  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30883
        [Gtk] Implement AtkText for HTML elements which contain text

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (getInterfaceMaskFromObject):
        (getPangoLayoutForAtk):
        (webkit_accessible_text_get_text):
        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (AccessibilityObject::accessibilityPlatformIncludesObject):
2010-01-06  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30883
        [Gtk] Implement AtkText for HTML elements which contain text

        * tests/testatk.c
        (test_webkit_atk_get_text_at_offset):
        (test_webkit_atk_get_text_at_offset_forms):
        (test_webkit_atk_get_text_at_offset_newlines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines...
mitz@apple.com [Thu, 7 Jan 2010 01:41:32 +0000 (01:41 +0000)]
<rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines run too long
https://bugs.webkit.org/show_bug.cgi?id=32794

Reviewed by Sam Weinig.

WebCore:

Test: platform/mac/fast/text/line-breaking-with-kerning.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): When kerning is enabled, include
the trailing space when measuring a word, then subtract its width. This
accounts for kerning between the last glyph of the word and the following space.

LayoutTests:

* platform/mac/fast/text/line-breaking-with-kerning-expected.checksum: Added.
* platform/mac/fast/text/line-breaking-with-kerning-expected.png: Added.
* platform/mac/fast/text/line-breaking-with-kerning-expected.txt: Added.
* platform/mac/fast/text/line-breaking-with-kerning.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
ojan@chromium.org [Thu, 7 Jan 2010 01:33:46 +0000 (01:33 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review.

        REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
        https://bugs.webkit.org/show_bug.cgi?id=33256

        I am unable to reproduce this failure locally, so this fix is only speculative.
        Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Simon Fraser.
kdecker@apple.com [Thu, 7 Jan 2010 01:29:55 +0000 (01:29 +0000)]
    Reviewed by Simon Fraser.

        Third step of:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView getVariable:value:]): Add case for WKNVSupportsCompositingCoreAnimationPluginsBool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 01:14:52 +0000 (01:14 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review, just adding Mike Belshe's new bugzilla email at his request.

        * Scripts/webkitpy/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Simon Fraser
kdecker@apple.com [Thu, 7 Jan 2010 01:01:10 +0000 (01:01 +0000)]
    Reviewed by Simon Fraser

        Second step of:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        * Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView pluginLayer]): Added.
        * Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView pluginLayer]): Added.
        Reviewed by Simon Fraser.

        Second step of:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        * Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView pluginLayer]): Added.
        * Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView pluginLayer]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix screwed up ChangeLog about screwing up... Sigh.
abarth@webkit.org [Thu, 7 Jan 2010 00:50:06 +0000 (00:50 +0000)]
Fix screwed up ChangeLog about screwing up...  Sigh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 00:48:13 +0000 (00:48 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review.

        REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
        https://bugs.webkit.org/show_bug.cgi?id=33256

        I am unable to reproduce this failure locally, so this fix is only speculative.
        Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 00:47:00 +0000 (00:47 +0000)]
2010-01-06  Adam Barth  <abarth@webkit.org>

        No review, rolling out r52877.
        http://trac.webkit.org/changeset/52877
        https://bugs.webkit.org/show_bug.cgi?id=33243

        I screwedd up landing this patch and only partially applied the patch I
        was trying to land.

        * bindings/ScriptControllerBase.cpp:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::executeScriptInWorld):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::haveInterpreter):
        (WebCore::ScriptController::mainWorldWindowShell):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::clearForClose):
        (WebCore::ScriptController::destroyWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::proxy):
        (WebCore::ScriptController::windowShell):
        (WebCore::ScriptController::existingWindowShell):
        (WebCore::ScriptController::evaluateInWorld):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::create):
        (WebCore::V8DOMWindowShell::V8DOMWindowShell):
        (WebCore::V8DOMWindowShell::initContextIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 7 Jan 2010 00:30:40 +0000 (00:30 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Carlson.

        media/video-seeking.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33273

        Removed setTimeouts from this test. It kind of looks
        like they were intentional, but I don't see how they add
        anything to this test (other than race conditions).

        * media/video-seeking-expected.txt:
        * media/video-seeking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 00:26:46 +0000 (00:26 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Rolling back in a change I should not have rolled out.

        The original commit http://trac.webkit.org/changeset/52862
        was rolled out again in http://trac.webkit.org/changeset/52871
        but I now believe that rollout to be in error.
        My sincerest apologies for the churn.

        Fix the bug in previous commit: we shouldn't finish
        decoding if "sizeOnly" is true.
        https://bugs.webkit.org/show_bug.cgi?id=33258

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 7 Jan 2010 00:24:56 +0000 (00:24 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        fast/css/transition-color-unspecified.html and fast/dom/HTMLObjectElement/object-as-frame.html are flaky
        https://bugs.webkit.org/show_bug.cgi?id=33270

        These both rely on setTimeouts where they should be using events.

        * fast/css/transition-color-unspecified.html:
        * fast/dom/HTMLObjectElement/object-as-frame.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 7 Jan 2010 00:21:28 +0000 (00:21 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        platform/chromium/fast/dom/interval.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33274

        We're seeing the debug bots take >100000 microseconds to stop
        and Interval.

        * platform/chromium/fast/dom/interval.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 00:16:00 +0000 (00:16 +0000)]
2010-01-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [v8] Let ScriptController have more than one windowShell
        https://bugs.webkit.org/show_bug.cgi?id=33243

        This patch lets ScriptController have more than one windowShell.  We're
        currently only using one of them (for the main world), but this patch
        lets us use other ones for isolated worlds soon.

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeScriptInWorld):
        * bindings/js/ScriptController.cpp:
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::createWorld):
        (WebCore::ScriptController::initScript):
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::evaluateInWorld):
        (WebCore::ScriptController::mainWorldWindowShell):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::clearForClose):
        (WebCore::ScriptController::destroyWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::windowShell):
        (WebCore::ScriptController::existingWindowShell):
        (WebCore::ScriptController::globalObject):
        (WebCore::ScriptController::proxy):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::create):
        (WebCore::V8DOMWindowShell::V8DOMWindowShell):
        (WebCore::V8DOMWindowShell::initContextIfNeeded):
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 23:56:15 +0000 (23:56 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Rolling out r52869 and r52853 due to bot
        and local run-webkit-test failures

        REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
        https://bugs.webkit.org/show_bug.cgi?id=33256

        The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Mac build.
mrowe@apple.com [Wed, 6 Jan 2010 23:20:53 +0000 (23:20 +0000)]
Fix the Mac build.

* WebCore.base.exp: Export symbols WebKit would like to use.
* plugins/PluginWidget.h:
(WebCore::PluginWidget::PluginWidget): Redeclare a constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to fix non-Snow Leopard Mac build.
weinig@apple.com [Wed, 6 Jan 2010 23:09:28 +0000 (23:09 +0000)]
Attempt to fix non-Snow Leopard Mac build.

* WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:25:27 +0000 (22:25 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Unreviewed "build" fix.  Just adding missing include.

        bugzilla-tool rollout --complete-rollout should make a nicer bug comment
        https://bugs.webkit.org/show_bug.cgi?id=29212

        * Scripts/webkitpy/steps/completerollout.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Eric Carlson.
kdecker@apple.com [Wed, 6 Jan 2010 22:23:39 +0000 (22:23 +0000)]
    Reviewed by Eric Carlson.

        First step toward:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        Small refactoring moving the PluginWidget class from WebKit to WebCore.
        * WebCore.xcodeproj/project.pbxproj: Added new source files and a "mac" group; exposes PluginWidget.h as a "Private" role
        * platform/Widget.h: Added isPluginWidget().
        (WebCore::Widget::isPluginWidget):
        * plugins/PluginWidget.h: Added.
        (WebCore::PluginWidget::isPluginWidget): Added as an interim solution until Mac plug-ins inheirt from PluginView.
        * plugins/mac/PluginWidgetMac.mm: Added.
        (WebCore::PluginWidget::invalidateRect): Added. Extracted from the old WebKit/FrameLoaderClientMac version of PluginWidget

        Reviewed by Eric Carlson.

        First step toward:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        Small refactoring moving the PluginWidget class from WebKit to WebCore.

        * WebCoreSupport/WebFrameLoaderClient.mm: Use the WebCore version of PluginWidget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:20:39 +0000 (22:20 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52862.
        http://trac.webkit.org/changeset/52862
        https://bugs.webkit.org/show_bug.cgi?id=33258

        Caused svg/W3C-SVG-1.1/linking-a-01-b.svg to crash on the
        Leopard Release builder.

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:14:10 +0000 (22:14 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool rollout --complete-rollout should make a nicer bug comment
        https://bugs.webkit.org/show_bug.cgi?id=29212

        * Scripts/webkitpy/bugzilla.py:
         - Make reopen_bug robust against the bug already being open.
        * Scripts/webkitpy/commands/download.py:
         - Remove dead code from Rollout.
        * Scripts/webkitpy/steps/completerollout.py:
         - Improve the rollout comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
eric@webkit.org [Wed, 6 Jan 2010 22:12:48 +0000 (22:12 +0000)]
2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Set isHttpdOpen to 0 if pidfile does not exist for some reason.
        Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 6 Jan 2010 22:04:06 +0000 (22:04 +0000)]
2010-01-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Revert the part of my last commit touching Base.xcconfig, was not meant to be commited.

        * Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 6 Jan 2010 21:37:09 +0000 (21:37 +0000)]
2010-01-05  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Generate header declarations for V8 binding security checks
        and delete V8CustomBinding.cpp

        * Android.v8bindings.mk: Removed V8CustomBinding.cpp.
        * WebCore.gypi: Removed V8CustomBinding.cpp.
        * bindings/scripts/CodeGeneratorV8.pm: Generate security check declarations.
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::getTargetFrame): Moved from V8CustomBinding.cpp.
        (WebCore::reportUnsafeJavaScriptAccess):
        (WebCore::V8DOMWindowShell::createNewContext):
        (WebCore::V8DOMWindowShell::setLocation): Moved from V8CustomBinding.cpp.
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::downcastSVGPathSeg): Moved from V8CustomBinding.cpp.
        (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object):
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/custom/V8CustomBinding.cpp: Removed.
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::locationAccessorSetter):
        (WebCore::V8DOMWindow::namedSecurityCheck):
        (WebCore::V8DOMWindow::indexedSecurityCheck):
        * bindings/v8/custom/V8DocumentLocationCustom.cpp:
        (WebCore::V8Document::locationAccessorSetter):
        * bindings/v8/custom/V8HistoryCustom.cpp:
        (WebCore::V8History::indexedSecurityCheck):
        (WebCore::V8History::namedSecurityCheck):
        * bindings/v8/custom/V8LocationCustom.cpp:
        (WebCore::V8Location::indexedSecurityCheck):
        (WebCore::V8Location::namedSecurityCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 6 Jan 2010 21:26:59 +0000 (21:26 +0000)]
2010-01-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Marker code is buggy: referencePoint translation is off
        https://bugs.webkit.org/show_bug.cgi?id=33012

        Rewrite marker code, as it had many issues:
        - Correct refX/refY handling (covered by new marker-referencePoint.svg test)
        - Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
        - Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
        - Fix SVGResource assuming that there is only one resource per resource type per element. Markers
          can have three different resources of the same type (three markers, start/mid/end markers)

        Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.

        Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
        Test: svg/custom/marker-referencePoint.svg
              svg/custom/marker-opacity.svg
              svg/custom/marker-strokeWidth-changes.svg

        * Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML.
        (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase.
        (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time.
        (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes.
        (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now.
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
        * rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency.
        (WebCore::RenderPath::path): Inline this accessor.
        * rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
        * rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated.
        (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code).
        (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
        * rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
        * rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights.
        (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo.
        (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker.
        (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout.
        (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values.
        (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method.
        (WebCore::SVGMarkerData::updateOutslope): Ditto.
        (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation.
        (WebCore::SVGMarkerData::updateInslope): Helper method.
        * rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time.
        (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo):
        (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo):
        (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles)
        (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers().
        (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers.
        (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
        * rendering/SVGMarkerLayoutInfo.h: Added.
        (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix.
        (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers.
        (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto.
        (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
        * svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer()
        (WebCore::SVGMarkerElement::~SVGMarkerElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
        (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::~SVGSVGElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
        * svg/SVGUseElement.cpp: Rework buildPendingResource() to remove SVGSVGElement/SVGMarkerElement detach() hacks (called manually from destructors), see below.
        (WebCore::SVGUseElement::buildPendingResource): Always detach() the shadow tree root element, before destructing it - this caused the regression with this patch before.
        * svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources
                                        and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
                                        ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
                                        per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.
        (WebCore::resourceSet): Add global static HashSet<SVGResource*>.
        (WebCore::SVGResource::SVGResource): Add us to the resourceSet.
        (WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
        (WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
        (WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::SVGResourceMarker):
        (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker.
        (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer.
        (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
        * svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values.
        (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker().
        (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef().
        (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 6 Jan 2010 21:10:35 +0000 (21:10 +0000)]
2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        This implements the SVG Filter effect feImage with support of fragment urls.
        It also includes a bug fix for feComposite. feComposite didn't cover values
        bigger than 255 correctly on composite oeprator arithmetic.

        Tests: There are already many feImage tests in trunk. They just needed updated
               pixel test results.
               The feComposite bug is covered by svg/W3C-SVG-1.1/filters-composite-02-b.svg
               and depends on feImage.

        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::arithmetic):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGImage.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource):
        (WebCore::SVGFEImageElement::parseMappedAttribute):
        (WebCore::SVGFEImageElement::notifyFinished):
        (WebCore::SVGFEImageElement::build):
        * svg/SVGFEImageElement.h:
        * svg/SVGFEImageElement.idl:
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::transformRect):
        * svg/SVGPreserveAspectRatio.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::FEImage):
        (WebCore::FEImage::create):
        (WebCore::FEImage::apply):
        * svg/graphics/filters/SVGFEImage.h:

2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        The implementation of feImage requires pixel test result updates of the already
        available tests.

        There is also an update for svg/filters/feComposite.svg, since the patch also
        fixed a bug in feComposite.

        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.checksum:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.png:
        * platform/mac/svg/filters/feComposite-expected.checksum:
        * platform/mac/svg/filters/feComposite-expected.png:
        * platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
        * platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:

2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        Update SVG status page. We support feDisplacementMap and feImage now.

        * projects/svg/status.xml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded file James Robinson provided to go with his fix for
darin@apple.com [Wed, 6 Jan 2010 20:26:04 +0000 (20:26 +0000)]
Added file James Robinson provided to go with his fix for
https://bugs.webkit.org/show_bug.cgi?id=32295

* platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome script tests have wrappers that don't match their templates
darin@apple.com [Wed, 6 Jan 2010 20:24:29 +0000 (20:24 +0000)]
Some script tests have wrappers that don't match their templates
https://bugs.webkit.org/show_bug.cgi?id=33239

Reviewed by Eric Seidel.

* fast/dom/StyleSheet/get-stylesheet-byname.html: Updated to use
a standard test wrapper instead of a custom one.
* fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js:
Changed test to not depend on a non-standard wrapper.
* fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Updated
results since I changed the test around.

* platform/mac/editing/selection/script-tests/TEMPLATE.html: Fix
incorrect path in template that broke the test when we called
make-script-test-wrappers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Wed, 6 Jan 2010 20:15:35 +0000 (20:15 +0000)]
2010-01-06  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Fix the bug in previous commit: we shouldn't finish
        decoding if "sizeOnly" is true.
        https://bugs.webkit.org/show_bug.cgi?id=33258

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShould be last part of Windows Build fix.
bweinstein@apple.com [Wed, 6 Jan 2010 19:59:57 +0000 (19:59 +0000)]
Should be last part of Windows Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 19:58:15 +0000 (19:58 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52855.
        http://trac.webkit.org/changeset/52855
        https://bugs.webkit.org/show_bug.cgi?id=33222

        Caused 6 layout tests to fail on Mac

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQT build fix.
barraclough@apple.com [Wed, 6 Jan 2010 19:51:26 +0000 (19:51 +0000)]
QT build fix.

* runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecific):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix part I.
barraclough@apple.com [Wed, 6 Jan 2010 19:45:14 +0000 (19:45 +0000)]
Windows build fix part I.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
mitz@apple.com [Wed, 6 Jan 2010 19:38:52 +0000 (19:38 +0000)]
Build fix

* runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecificCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=33236
barraclough@apple.com [Wed, 6 Jan 2010 19:33:29 +0000 (19:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33236
Remove m_identifierTable pointer from UString

Reviewed by Sam Weinig.

JavaScriptCore:

Currently every string holds a pointer so that during destruction,
if a string has been used as an identifier, it can remove itself
from the table.  By instead accessing the identifierTable via a
thread specific tracking the table associated with the current
globaldata, we can save the memory cost of this pointer.

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

    - change the API shims to track the identifierTable of the current JSGlobalData.

* API/JSContextRef.cpp:
(JSContextGroupCreate):

    - update creation of JSGlobalData for API usage to use new create method.
    - fix shim instanciation bug in JSGlobalContextCreateInGroup.

* JavaScriptCore.exp:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):

    - add asserts to check the identifierTable is being tracked correctly.

* runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::Identifier::remove):
(JSC::Identifier::checkSameIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
(JSC::createDefaultDataSpecific):

    - Use currentIdentifierTable() instead of UStringImpl::m_identifierTable.
    - Define methods to access the thread specific identifier tables.

* runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):

    - Declare methods to access the thread specific identifier tables.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):

    - creation of JSGlobalData objects, other than for API usage, associate themselves with the current thread.

* runtime/JSGlobalData.h:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::destroy):

    - destroy() method should be using isIdentifier().

* runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):

    - replace m_identifierTable with a single m_isIdentifier bit.

* wtf/StringHashFunctions.h:
(WTF::stringHash):

    - change string hash result from 32-bit to 31-bit, to free a bit in UStringImpl for m_isIdentifier.

JavaScriptGlue:

Add API shims similar to those used in the JSC API to track the current identifierTable.

* JSBase.cpp:
(JSBase::Release):
* JSUtils.cpp:
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(unprotectGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):
* JSUtils.h:
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):
* JavaScriptGlue.cpp:
(JSRunCreate):
(JSRunEvaluate):
(JSRunCheckSyntax):
(JSCollect):
* JavaScriptGlue.xcodeproj/project.pbxproj:
* UserObjectImp.cpp:
(UserObjectImp::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Wed, 6 Jan 2010 18:25:46 +0000 (18:25 +0000)]
2010-01-06  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Let ReourceLoader deliver segmented data
        when loading resource from a SharedBuffer object.
        https://bugs.webkit.org/show_bug.cgi?id=33222

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didReceiveData):
        * loader/ResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial Qt build fix.
hausmann@webkit.org [Wed, 6 Jan 2010 11:14:48 +0000 (11:14 +0000)]
Unreviewed trivial Qt build fix.

Prefix the phonon includes with phonon/ to avoid conflicts with the S60
audio routing API ( http://wiki.forum.nokia.com/index.php/Audio_Routing_API ).

* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
loki@webkit.org [Wed, 6 Jan 2010 10:02:41 +0000 (10:02 +0000)]
2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
        and remove the httpd's pidfile directory if httpd terminated.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 6 Jan 2010 08:24:15 +0000 (08:24 +0000)]
2010-01-06  Darin Fisher  <darin@chromium.org>

        Fix release build bustage.

        * src/WebKit.cpp: Need to include Logging.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 6 Jan 2010 07:56:06 +0000 (07:56 +0000)]
2010-01-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Expose more APIs to eliminate WebCore usage in Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=33249

        * WebKit.gyp:
        * public/WebFrame.h:
        * public/WebGlyphCache.h: Added.
        * public/WebKit.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrame::instanceCount):
        (WebKit::WebFrameImpl::WebFrameImpl):
        (WebKit::WebFrameImpl::~WebFrameImpl):
        * src/WebFrameImpl.h:
        * src/WebGlyphCache.cpp: Added.
        (WebKit::WebGlyphCache::pageCount):
        * src/WebKit.cpp:
        (WebKit::enableLogChannel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 6 Jan 2010 07:31:28 +0000 (07:31 +0000)]
2010-01-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        Moving v8::HandleScope up above declaration of v8::Local to fix a
        Chromium startup crash.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setContextDebugId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Wed, 6 Jan 2010 06:37:56 +0000 (06:37 +0000)]
2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by David Levin.

        Refactored check-webkit-style's argument parser to not rely
        on global state, and improved its error handling and unit
        test coverage.

        https://bugs.webkit.org/show_bug.cgi?id=32966

        * Scripts/check-webkit-style:
          - Adjusted to use new argument parser.

        * Scripts/webkitpy/cpp_style.py:
          - Changed _CppStyleState to accept an array of filter rules
            instead of a comma-delimited string.
          - Eliminated cpp_style._DEFAULT_FILTER_RULES.
          - Eliminated cpp_style._USAGE.

        * Scripts/webkitpy/cpp_style_unittest.py:
          - Updated test_filter() and test_default_filter().

        * Scripts/webkitpy/style.py:
          - Converted style._USAGE to create_usage().
          - Corrected usage instructions by removing 0 as a valid
            --verbose flag value.
          - Removed use_webkit_styles().
          - Added ProcessorOptions class.
          - Added ArgumentDefaults class.
          - Added ArgumentPrinter class.
          - Removed parse_arguments and added ArgumentParser class.
          - Moved exit_with_usage() and exit_with_categories() into
            ArgumentParser.
          - Refactored parse_arguments() as ArgumentParser.parse().
          - Improved parser error handling.

        * Scripts/webkitpy/style_unittest.py:
          - Added DefaultArgumentsTest class.
          - Addressed FIXME to check style.WEBKIT_FILTER_RULES
            against style.STYLE_CATEGORIES.
          - Added ArgumentPrinterTest class.
          - Added ArgumentParserTest class and rewrote parser unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-enable plug-in halting on Mac after r51953
mitz@apple.com [Wed, 6 Jan 2010 05:11:23 +0000 (05:11 +0000)]
Re-enable plug-in halting on Mac after r51953

Reviewed by Mark Rowe.

* WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::enabled): Test for the correct selector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 6 Jan 2010 03:09:24 +0000 (03:09 +0000)]
2010-01-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [v8] Move V8DOMWindowShell to ScriptController
        https://bugs.webkit.org/show_bug.cgi?id=33232

        This patch moves V8DOMWindow shell to ScriptController, where the
        window shells live in JSC land.  The next step will be to allow for
        more than one window shell per script controller.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::haveInterpreter):
        (WebCore::ScriptController::mainWorldWindowShell):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::clearForClose):
        (WebCore::ScriptController::destroyWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::~V8DOMWindowShell):
        * bindings/v8/V8DOMWindowShell.h:
        (WebCore::V8DOMWindowShell::localHandleForContext):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertDocumentToV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
        * bindings/v8/V8IsolatedContext.cpp:
        (WebCore::V8IsolatedContext::V8IsolatedContext):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::V8Proxy):
        (WebCore::V8Proxy::~V8Proxy):
        (WebCore::V8Proxy::handleOutOfMemory):
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::setInjectedScriptContextDebugId):
        (WebCore::V8Proxy::context):
        (WebCore::V8Proxy::mainWorldContext):
        (WebCore::V8Proxy::currentContext):
        (WebCore::V8Proxy::setContextDebugId):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/WorldContextHandle.cpp:
        (WebCore::WorldContextHandle::adjustedContext):
2010-01-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [v8] Move V8DOMWindowShell to ScriptController
        https://bugs.webkit.org/show_bug.cgi?id=33232

        Update FrameLoaderClientImpl.cpp to call clearForClose on
        ScriptController instead of on V8Proxy.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::detachedFromParent3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Wed, 6 Jan 2010 02:57:02 +0000 (02:57 +0000)]
2010-01-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <header> and <footer> elements.
        https://bugs.webkit.org/show_bug.cgi?id=32943

        These test:
        - <p> closing,
        - No nesting restriction,
        - Residual style, and
        - FormatBlock.

        * fast/html/footer-element-expected.txt: Added.
        * fast/html/footer-element.html: Added.
        * fast/html/header-element-expected.txt: Added.
        * fast/html/header-element.html: Added.
        * fast/html/script-tests/footer-element.js: Added.
        * fast/html/script-tests/header-element.js: Added.
2010-01-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <header> and <footer> elements.
        https://bugs.webkit.org/show_bug.cgi?id=32943

        <header> and <footer> should behave the same as <nav>, <section>,
        <article>, and <aside>. The HTML parser doesn't need to restrict
        the nesting of header/footer elements.

        Tests: fast/html/footer-element.html
               fast/html/header-element.html

        * css/html.css: Add header/footer as block elements.
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag): Add headerTag and footerTag.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::tagPriority): Returns 5 for headerTag and footerTag.
        (WebCore::blockTagList): Add headerTag and footerTag.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Rename isHeaderTag() to isHeadingTag()
        (WebCore::HTMLParser::getNode): Add headerTag and footerTag.
        (WebCore::HTMLParser::isHeadingTag): Renamed from isHeaderTag().
        * html/HTMLParser.h:
          - Rename isHeaderTag() to isHeadingTag()
          - Remove non-existing popNestedHeaderTag().
        * html/HTMLTagNames.in: Add header and footer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Rachel Petterson <rlp@google.com>
abarth@webkit.org [Wed, 6 Jan 2010 02:46:25 +0000 (02:46 +0000)]
2010-01-05  Rachel Petterson  <rlp@google.com>

        Reviewed by Adam Barth.

        Matches the texImage2D and texSubImage2D functions to their
        declarations. Elminates uncessary versions of those functions.
        https://bugs.webkit.org/show_bug.cgi?id=31562
        Also bug: https://bugs.webkit.org/show_bug.cgi?id=31493

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Adler <darin@apple.com>
ojan@chromium.org [Wed, 6 Jan 2010 02:07:04 +0000 (02:07 +0000)]
2010-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        CDATA sections are merged into Text nodes when normalize() is used
        https://bugs.webkit.org/show_bug.cgi?id=33191

        * fast/dom/Node/normalize-with-cdata-expected.txt: Added.
        * fast/dom/Node/normalize-with-cdata.html: Added.
        * fast/dom/Node/script-tests/normalize-with-cdata.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Adler <darin@apple.com>
ojan@chromium.org [Wed, 6 Jan 2010 02:06:11 +0000 (02:06 +0000)]
2010-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        CDATA sections are merged into Text nodes when normalize() is used
        https://bugs.webkit.org/show_bug.cgi?id=33191

        * fast/dom/Node/normalize-with-cdata-expected.txt: Added.
        * fast/dom/Node/normalize-with-cdata.html: Added.
        * fast/dom/Node/script-tests/normalize-with-cdata.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Adler <darin@apple.com>
ojan@chromium.org [Wed, 6 Jan 2010 02:05:13 +0000 (02:05 +0000)]
2010-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        CDATA sections are merged into Text nodes when normalize() is used
        https://bugs.webkit.org/show_bug.cgi?id=33191

        * fast/dom/Node/normalize-with-cdata-expected.txt: Added.
        * fast/dom/Node/normalize-with-cdata.html: Added.
        * fast/dom/Node/script-tests/normalize-with-cdata.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 6 Jan 2010 02:03:52 +0000 (02:03 +0000)]
2010-01-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        animations/animation-drt-api-multiple-keyframes.html and animations/animation-drt-api.html are flaky
        https://bugs.webkit.org/show_bug.cgi?id=33244

        Both these tests have a race condition. They start looking
        for the animation start after the node is already rendered.
        Instead, set the animation just before looking for the animation
        start.

        * animations/animation-drt-api-multiple-keyframes.html:
        * animations/animation-drt-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCDATA sections are merged into Text nodes when normalize() is used
darin@apple.com [Wed, 6 Jan 2010 01:35:52 +0000 (01:35 +0000)]
CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191

Reviewed by Dan Bernstein.

WebCore:

Test: fast/dom/Node/normalize-with-cdata.html

* dom/Node.cpp:
(WebCore::Node::normalize): Use nodeType instead of isTextNode.

LayoutTests:

* fast/dom/Node/normalize-with-cdata-expected.txt: Added.
* fast/dom/Node/normalize-with-cdata.html: Added.
* fast/dom/Node/script-tests/normalize-with-cdata.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 James Robinson <jamesr@google.com>
eric@webkit.org [Wed, 6 Jan 2010 01:13:11 +0000 (01:13 +0000)]
2010-01-05  James Robinson  <jamesr@google.com>

        Reviewed by Eric Seidel.

        Typing in Google Wave repaints the whole screen
        https://bugs.webkit.org/show_bug.cgi?id=32295

        Add a repaint test to make sure that when mutations happen in a grandchild of a block element that has no in-flow children
        the entire block element is not unnecessarily repainted.
        The bug only shows up when running pixel tests.

        * fast/repaint/block-no-inflow-children.html: Added.
        * platform/mac/fast/repaint/block-no-inflow-children-expected.checksum: Added.
        * platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
        * platform/mac/fast/repaint/block-no-inflow-children-expected.txt: Added.
2010-01-05  James Robinson  <jamesr@google.com>

        Reviewed by Eric Seidel.

        Typing in Google Wave repaints the whole screen
        https://bugs.webkit.org/show_bug.cgi?id=32295

        Marks a RenderBlock without block children for layout and painting when it has no line boxes only if it has inline immediate children.
        The existing logic uses the existence of line boxes as a dirty flag to indicate that line boxes need to be regenerated.  This heuristic
        fails when the RenderBlock does not have any in-flow children at all, causing the RenderBlock to get unnecessarily marked for layout and
        painting.  This is particularly bad for common scrollbar manipulation tricks like putting one positioned div inside another - this
        structure caused the entire outer div's bounds to get scheduled for a paint whenever there was any mutation of any descendant.

        Test: LayoutTests/fast/repaint/block-no-inline-children.html (only shows up in pixel tests)

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 James Robinson <jamesr@chromium.org>
eric@webkit.org [Wed, 6 Jan 2010 00:07:56 +0000 (00:07 +0000)]
2010-01-05  James Robinson  <jamesr@chromium.org>

        Reviewed by David Hyatt.

        Cleans up line box clearing when a RenderBlock loses its last child.
        https://bugs.webkit.org/show_bug.cgi?id=33228

        The 'fullLayout' flag in RenderBlock::layoutInlineChildren() is pretty vague, hopefully this will be easier for the next person to figure out.

        No new tests.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 5 Jan 2010 23:57:39 +0000 (23:57 +0000)]
2010-01-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        LayoutTests/animations/change-keyframes.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33233

        The timing calculation was just off. It was starting the
        second animation at 600ms and then checking to be half-way
        done with the 1 second animation at 1000ms. Instead, just
        modify the animation to run a bit earlier.

        * animations/change-keyframes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 5 Jan 2010 23:53:00 +0000 (23:53 +0000)]
2010-01-05  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Provide the "documentURL" property for documents and frame owner elements

        This is necessary to determine owner document URLs for nodes (all nodes have
        the top-level document set as ownerDocument).
        https://bugs.webkit.org/show_bug.cgi?id=33025

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fixed a bug in testcase. Passing an empty array to texImage2D
cmarrin@apple.com [Tue, 5 Jan 2010 23:51:00 +0000 (23:51 +0000)]
    Fixed a bug in testcase. Passing an empty array to texImage2D
        now must be done with 'null' not '0'.

        * fast/canvas/webgl/script-tests/texImageTest.js:
        * fast/canvas/webgl/texImageTest-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago New test for texImage2d and texSubImage2d cases
cmarrin@apple.com [Tue, 5 Jan 2010 23:42:03 +0000 (23:42 +0000)]
    New test for texImage2d and texSubImage2d cases
        New test for texImage2d using ImageData which tests rendering.
        https://bugs.webkit.org/show_bug.cgi?id=31562
        Also bug: https://bugs.webkit.org/show_bug.cgi?id=31493

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPublic GIF decoder should stop decoding when allocation fails
pkasting@chromium.org [Tue, 5 Jan 2010 23:22:47 +0000 (23:22 +0000)]
Public GIF decoder should stop decoding when allocation fails
https://bugs.webkit.org/show_bug.cgi?id=33231

Reviewed by Adam Barth.

* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::output_row):
(GIFImageReader::do_lzw):
(GIFImageReader::read):
* platform/image-decoders/gif/GIFImageReader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing Radar numbers
aroben@apple.com [Tue, 5 Jan 2010 23:13:18 +0000 (23:13 +0000)]
Add missing Radar numbers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Tue, 5 Jan 2010 23:08:32 +0000 (23:08 +0000)]
2010-01-05  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Make PNG image decoder work with segmented SharedBuffer
        https://bugs.webkit.org/show_bug.cgi?id=33213

        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageDecoder::create):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::ImageDecoder):
        (WebCore::ImageDecoder::isAllDataReceived):
        (WebCore::ImageDecoder::setData):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::PNGImageReader):
        (WebCore::PNGImageReader::close):
        (WebCore::PNGImageReader::currentBufferSize):
        (WebCore::PNGImageReader::setComplete):
        (WebCore::PNGImageReader::decode):
        (WebCore::PNGImageDecoder::decode):
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::pngComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake IWebView::close and destroying a WebView's HWND optional for WebKit clients
aroben@apple.com [Tue, 5 Jan 2010 23:07:33 +0000 (23:07 +0000)]
Make IWebView::close and destroying a WebView's HWND optional for WebKit clients

WebView will now take care of these operations itself when its last
reference is released, if they haven't already been done.

IWebView::close now also destroys the WebView's HWND. All WebKit
clients were already performing these operations in succession anyway,
or were attempting to by calling IWebView::close then destroying the
WebView's host window (which actually resulted in the WebView's HWND
leaking, and the crash in the below bug).

Fixes <http://webkit.org/b/32827> Crash when calling IWebView::close,
then releasing the WebView, without calling DestroyWindow

Fixes a few WebViewDestruction tests, too.

Reviewed by Steve Falkenburg.

* WebView.cpp:
(WebView::~WebView): Don't try to destroy m_viewWindow here. That
should already have happened. Assert that this is the case.
(WebView::close): If m_viewWindow isn't already being destroyed,
destroy it now. Moved the call to revokeDragDrop() here from our
WM_DESTROY handler because it needs to be done before m_viewWindow is
nulled out.
(WebView::WebViewWndProc): Removed call to revokeDragDrop() that
close() now performs.
(WebView::Release): If our last reference is being released, call
close() so that clients don't have to. (It's harmless to call close()
multiple times.) We do this here instead of in the destructor because
close() can cause AddRef() and Release() to be called, and calling
those from within the destructor leads to double-destruction.
(WebView::setHostWindow): Removed an unnecessary (and now harmful)
null-check.
(WebView::revokeDragDrop): Changed an assertion into a run-time check,
since this will now sometimes be called when m_viewWindow hasn't been
created yet. Changed the IsWindow call to a null-check because we
never hold onto a destroyed m_viewWindow.
(WebView::windowAncestryDidChange): If we don't have a view window,
stop tracking changes to our parent's active state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake it safe to call IWebView::close when IWebView::initWithFrame hasn't been called
aroben@apple.com [Tue, 5 Jan 2010 23:07:21 +0000 (23:07 +0000)]
Make it safe to call IWebView::close when IWebView::initWithFrame hasn't been called

Part of <http://webkit.org/b/32827> Crash when calling
IWebView::close, then releasing the WebView, without calling
DestroyWindow

Reviewed by Steve Falkenburg.

WebKit/win:

* WebView.cpp:
(WebView::close): Null-check m_page and m_preferences before using
them. They will be null if initWithFrame was never called.

WebKitTools:

Test that it's safe to call IWebView::close when IWebView::initWithFrame
hasn't been called

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
without ever calling IWebView::initWithFrame and tests that we don't
crash or leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd assertions to catch double-destruction of WebViews earlier
aroben@apple.com [Tue, 5 Jan 2010 23:07:08 +0000 (23:07 +0000)]
Add assertions to catch double-destruction of WebViews earlier

I basically copied the m_deletionHasBegun logic from WTF::RefCounted.

Fixes <http://webkit.org/b/33219>.

Reviewed by Darin Adler.

* WebView.cpp:
(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.

* WebView.h: Added m_deletionHasBegun.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove dead code in WebViewWndProc
aroben@apple.com [Tue, 5 Jan 2010 23:06:57 +0000 (23:06 +0000)]
Remove dead code in WebViewWndProc

Fixes <http://webkit.org/b/33218>.

Reviewed by Darin Adler.

* WebView.cpp:
(WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
We bail out much earlier in this function if isBeingDestroyed is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd more WebViewDestruction tests
aroben@apple.com [Tue, 5 Jan 2010 23:06:44 +0000 (23:06 +0000)]
Add more WebViewDestruction tests

Fixes <http://webkit.org/b/33216>.

Reviewed by Eric Seidel.

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::NoInitWithFrame):
(WebKitAPITest::CloseThenDestroyViewWindow):
(WebKitAPITest::DestroyViewWindowThenClose):
(WebKitAPITest::DestroyHostWindow):
(WebKitAPITest::DestroyHostWindowThenClose):
(WebKitAPITest::CloseThenDestroyHostWindow):
Added these tests that exercise tearing down a WebView in various
ways, all of which we eventually want to have work. Some of them
currently crash or leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Tue, 5 Jan 2010 22:45:01 +0000 (22:45 +0000)]
2010-01-05  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT

        If you're working from a --minimal or --no-svg build and make changes to the
        DRT, then recompile, the build will fail.

        This is because the current behavior at build time is to assume that the
        previous Qt build supported SVG and consequently delete libQtWebKit.so.
        Unfortunately, just deleting libQtWebKit.so will not cause the library to
        re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
        linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
        results in a link failure on the DRT.

        Since re-linking libQtWebKit can take up to ten minutes and should be avoided
        in cases where not actually required, remove the assumption that
        the previous Qt build supported SVG, and amend the symbol detection to look for
        a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
        for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.

        https://bugs.webkit.org/show_bug.cgi?id=32992

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-25 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Tue, 5 Jan 2010 22:30:16 +0000 (22:30 +0000)]
2009-12-25 Patrick Gansterer <paroga@paroga.com>

        Reviewed by Eric Seidel.

        Buildfix for WinCE + style fixes.
        https://bugs.webkit.org/show_bug.cgi?id=32939

        * jsc.cpp:
        (functionPrint):
        (functionQuit):
        (parseArguments):
        (fillBufferWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 5 Jan 2010 21:18:25 +0000 (21:18 +0000)]
2010-01-05  Adam Barth  <abarth@webkit.org>

        Rubber stamped by Dimitri Glazkov.

        Fix namespace indent for ScriptController.

        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::proxy):
        (WebCore::ScriptController::windowShell):
        (WebCore::ScriptController::existingWindowShell):
        (WebCore::ScriptController::xssAuditor):
        (WebCore::ScriptController::setProcessingTimerCallback):
        (WebCore::ScriptController::setPaused):
        (WebCore::ScriptController::isPaused):
        (WebCore::ScriptController::sourceURL):
        (WebCore::ScriptController::evaluateInWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Tue, 5 Jan 2010 20:48:14 +0000 (20:48 +0000)]
2010-01-05  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        WinCE buildfix after r52791 (renamed PLATFORM(WINCE) to OS(WINCE)).
        https://bugs.webkit.org/show_bug.cgi?id=33205

        * jit/ExecutableAllocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Implement most cases of texImage2D and texSubImage2D
cmarrin@apple.com [Tue, 5 Jan 2010 20:40:45 +0000 (20:40 +0000)]
    Implement most cases of texImage2D and texSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=31562

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of <https://bugs.webkit.org/show_bug.cgi?id=32568>.
bweinstein@apple.com [Tue, 5 Jan 2010 20:37:39 +0000 (20:37 +0000)]
Part of <https://bugs.webkit.org/show_bug.cgi?id=32568>.
Web Inspector: Context Menus should be used in more places.

Reviewed by Tim Hatcher.

Add context menus to handle the interaction with breakpoints in the Source Frame. Currently
we use left click to add/disable/remove breakpoints, and left click to edit (for conditional
breakpoints), but this is hard to discover and behaves differently than Xcode.

Change the behavior to be more like Xcode, left click adds a breakpoint if there isn't one, and
removes it if there is one.

On the context menu, if there is no breakpoint there, we have Add Breakpoint, and Add Conditional
Breakpoint. If there is a breakpoint there, we add entries for Edit Breakpoint (edit
the condition), Remove Breakpoint, and Enable/Disable Breakpoint (based on the current state).

* English.lproj/localizedStrings.js: Added localized context menu entries.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._documentContextMenu.addAndEditBreakpoint):
(WebInspector.SourceFrame.prototype._documentContextMenu): Added context menu entries and handlers.
(WebInspector.SourceFrame.prototype._documentMouseDown): Changed left click behavior (Add -> Remove).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: need a way to get the progress of a webpage load
cfleizach@apple.com [Tue, 5 Jan 2010 20:32:37 +0000 (20:32 +0000)]
AX: need a way to get the progress of a webpage load
https://bugs.webkit.org/show_bug.cgi?id=33221

Reviewed by Eric Seidel.

WebCore:

Test: platform/mac/accessibility/estimated-progress.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::estimatedLoadingProgress):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::estimatedLoadingProgress):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

* platform/mac/accessibility/document-attributes-expected.txt:
* platform/mac/accessibility/estimated-progress-expected.txt: Added.
* platform/mac/accessibility/estimated-progress.html: Added.
* platform/mac/accessibility/frame-with-title-expected.txt:
* platform/mac/accessibility/frame-with-title.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52819 268f45cc-cd09-0410-ab3c-d52691b4dbfc