WebKit-https.git
7 years agoSource/WebCore: IndexedDB: Propagate more leveldb errors to IDBIndex and IDBObjectStore
dgrogan@chromium.org [Wed, 5 Dec 2012 00:36:59 +0000 (00:36 +0000)]
Source/WebCore: IndexedDB: Propagate more leveldb errors to IDBIndex and IDBObjectStore
https://bugs.webkit.org/show_bug.cgi?id=103782

Reviewed by Tony Chang.

index.get[Key]() and objectStore.get() will receive more error events.

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::getRecord):
(WebCore::versionExists):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore):

Source/WebKit/chromium: Unreviewed.  Rolled DEPS.

Patch by Stephen White <senorblanco@chromium.org> on 2012-12-04

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt is not returning the exit status properly
dpranke@chromium.org [Wed, 5 Dec 2012 00:32:46 +0000 (00:32 +0000)]
nrwt is not returning the exit status properly
https://bugs.webkit.org/show_bug.cgi?id=103830

Unreviewed, build fix.

The fix in r136474 wasn't quite right either, and would return
the correct exceptional status, but not the correct failing status.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove IntegerCache::m_initialized
haraken@chromium.org [Wed, 5 Dec 2012 00:32:32 +0000 (00:32 +0000)]
[V8] Remove IntegerCache::m_initialized
https://bugs.webkit.org/show_bug.cgi?id=103978

Reviewed by Adam Barth.

Thanks to r136479, we can now initialize V8 integers in IntegerCache's
constructor. We can remove IntegerCache::m_initialized, which slightly
improves performance.

[Bindings/scroll-top.html in Chromium/Linux]
Before this patch: 285 runs/sec, 281 runs/sec, 281 runs/sec, 280 runs/sec
After this patch : 290 runs/sec, 291 runs/sec, 297 runs/sec, 291 runs/sec

No tests. No change in behavior.

* bindings/v8/V8ValueCache.cpp:
(WebCore::IntegerCache::IntegerCache):
(WebCore::IntegerCache::~IntegerCache):
* bindings/v8/V8ValueCache.h:
(IntegerCache):
(WebCore::IntegerCache::v8Integer):
(WebCore::IntegerCache::v8UnsignedInteger):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace String::New("symbol") with String::NewSymbol("symbol")
haraken@chromium.org [Wed, 5 Dec 2012 00:27:50 +0000 (00:27 +0000)]
[V8] Replace String::New("symbol") with String::NewSymbol("symbol")
https://bugs.webkit.org/show_bug.cgi?id=103989

Reviewed by Adam Barth.

In V8, a symbol lookup is faster than a string lookup. We should use
String::NewSymbol("symbol") for symbols.

No tests. No change in behavior.

* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::typeCallback):
(WebCore::V8InjectedScriptHost::functionDetailsCallback):
(WebCore::getJSListenerFunctions):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::populateContextMenuItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Implement CSS parsing and handling for <track-minmax>
jchaffraix@webkit.org [Wed, 5 Dec 2012 00:25:44 +0000 (00:25 +0000)]
[CSS Grid Layout] Implement CSS parsing and handling for <track-minmax>
https://bugs.webkit.org/show_bug.cgi?id=103799

Reviewed by Tony Chang.

Source/WebCore:

This change adds support for:
<track-minmax> => minmax( <track-breadth> , <track-breadth> ) | auto | <track-breadth>
(note that we already supported auto | <track-breadth>).

The change is mostly mechanical, the only newness is that GridTrackSize was updated to
hold 2 Lengths internally and we map the single Length case to 2 by duplicating the value
as this matches the rendering algorithm in the spec.

Tests: fast/css-grid-layout/grid-columns-rows-get-set-multiple.html
       fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackBreadth):
Changed the function to do the conversion of one track breadth (one Length).
This was forgotten in the preparatory change in bug 103703.

(WebCore::valueForGridTrackMinMax):
Convert the value back using valueForGridTrackBreadth.

* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::CSSFunctionValue):
* css/CSSFunctionValue.h:
(WebCore::CSSFunctionValue::create):
(CSSFunctionValue):
Added a new constructor. This enables us to return minmax(..., ...) when queried
from JavaScript. I couldn't find a better way to serialize inside CSSComputedStyleDeclaration
so that it properly match the function output.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackMinMax):
Added parsing for the new syntax. We convert the 2 values into a Pair if we manage to
parse both values correctly.

* css/StyleResolver.cpp:
(WebCore::createGridTrackMinMax):
Updated to handle a Pair - for minmax - and set the 2 values on GridTrackSize.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Updated to check the style. For now, we don't handle minmax values.

* rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::GridTrackSize):
(WebCore::GridTrackSize::length):
(WebCore::GridTrackSize::setLength):
(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
(WebCore::GridTrackSize::setMinMax):
(WebCore::GridTrackSize::operator==):
Updated the class to handle minmax values. This means that we now always store
2 values (the <length> case being a subset of minmax, however we kept the distinction
to be able to reconstruct a <length> for getComputedStyle).

LayoutTests:

* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
Extended the following tests to cover the new grammar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse sticky positioning for the code review toolbar
ojan@chromium.org [Wed, 5 Dec 2012 00:06:02 +0000 (00:06 +0000)]
Use sticky positioning for the code review toolbar
https://bugs.webkit.org/show_bug.cgi?id=104056

Reviewed by Adam Barth.

This simplifies the code and gives a nicer user-experience.
Also, while here, I fixed up the CSS to not have toolbar items
overlap when you make the window too small.

* PrettyPatch/PrettyPatch.rb:
* code-review-test.html:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening - add missing js-test-pre.js include to avoid use-href-update...
fmalita@chromium.org [Tue, 4 Dec 2012 23:49:51 +0000 (23:49 +0000)]
Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
failures on platforms that do not define gc().

* svg/custom/use-href-update-crash.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
dpranke@chromium.org [Tue, 4 Dec 2012 23:41:37 +0000 (23:41 +0000)]
nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
https://bugs.webkit.org/show_bug.cgi?id=104047

Reviewed by Eric Seidel.

The code becomes cleaner if we are just passing values around rather
than hanging them off the manager object, helps move _prepare_lists()
to a pure function, and is needed to eventually make the
result_summary object something returned from runner.run_tests()
(note that two more patches are needed for that to happen).

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.__init__):
(Manager._http_tests):
(Manager._prepare_lists):
(Manager.needs_servers):
(Manager._set_up_run):
(Manager.run):
(Manager._run_tests):
(Manager._upload_json_files):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_needs_servers.get_manager):
(ManagerTest.test_needs_servers):
(ManagerTest.integration_test_needs_servers.get_manager):
(ManagerTest.integration_test_needs_servers):
(ManagerTest.test_look_for_new_crash_logs.get_manager):
(ManagerTest):
(ManagerTest.test_look_for_new_crash_logs):
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.__init__):
(JSONLayoutResultsGenerator._get_modifier_char):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoparser* methods in ContainerNode should not support DocumentFragment
dpranke@chromium.org [Tue, 4 Dec 2012 23:04:04 +0000 (23:04 +0000)]
parser* methods in ContainerNode should not support DocumentFragment
https://bugs.webkit.org/show_bug.cgi?id=103965

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Darin Adler.

Only parserInsertBefore ever supported DocumentFragment and this feature
is never used. It appears this code ended up in parserInsertBefore when
it was created as a copy of insertBefore that didn't fire events. This
patch removes that code and adds assertions that we never pass
DocumentFragments since doing so would cause a corrupted tree as we never
check checkAcceptChild or do other validation in the parser methods.

No new tests, just refactoring.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocommit-queue can get stuck with a local commit
abarth@webkit.org [Tue, 4 Dec 2012 23:01:32 +0000 (23:01 +0000)]
commit-queue can get stuck with a local commit
https://bugs.webkit.org/show_bug.cgi?id=104032

Reviewed by Dirk Pranke.

Previously the commit-queue would only clean down to HEAD. If the
commit-queue gets interrupted in the middle of a commit (e.g., after
the local commit but before the dcommit), then it can end up with a
patch locally committed. That patch will then prevent the commit-queue
from functioning.

This patch teaches the commit-queue to clean down to the merge base,
which will remove any local commits.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.working_directory_is_clean):
(Git.clean_working_directory):
* Scripts/webkitpy/tool/commands/roll_unittest.py:
* Scripts/webkitpy/tool/steps/commit.py:
(Commit._commit_warning):
(Commit.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: store only the total number of tests in the result summary
dpranke@chromium.org [Tue, 4 Dec 2012 22:55:56 +0000 (22:55 +0000)]
nrwt: store only the total number of tests in the result summary
https://bugs.webkit.org/show_bug.cgi?id=103963

Reviewed by Ryosuke Niwa.

The result summary only needs the total number of tests that will
be run (including repetitions) in order to provide the correct stats;
it doesn't actually need to know how many unique tests there are, or
or how many repetitions there are.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests._result_summary):
(LayoutTestRunnerTests.test_update_summary_with_result):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._prepare_lists):
(Manager.run):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.get_result_summary):
* Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.__init__):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_result_summary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: do less work when ctrl-c'ed
dpranke@chromium.org [Tue, 4 Dec 2012 22:54:01 +0000 (22:54 +0000)]
nrwt: do less work when ctrl-c'ed
https://bugs.webkit.org/show_bug.cgi?id=103961

Reviewed by Ryosuke Niwa.

Do less work when we are ctrl-c'ed, because the statistics aren't
that useful anyway. While we're at it, modify summarize_results
to be aware that we don't always retry results (instead of pretending
that the retry produced the same results the initial run did).

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
(Manager.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: result summaries should not require a list of tests to skip
dpranke@chromium.org [Tue, 4 Dec 2012 22:51:45 +0000 (22:51 +0000)]
nrwt: result summaries should not require a list of tests to skip
https://bugs.webkit.org/show_bug.cgi?id=103951

Reviewed by Ryosuke Niwa.

We shouldn't really be passing a list of tests to skip to the
ResultSummary objects; they should be handled like any other
test result as much as possible.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests._result_summary):
(LayoutTestRunnerTests.test_update_summary_with_result):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._prepare_lists):
(Manager.run):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.get_result_summary):
* Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.__init__):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_result_summary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: derive per-thread, per-worker stats from result summaries
dpranke@chromium.org [Tue, 4 Dec 2012 22:50:24 +0000 (22:50 +0000)]
nrwt: derive per-thread, per-worker stats from result summaries
https://bugs.webkit.org/show_bug.cgi?id=103943

Reviewed by Ojan Vafai.

This patch changes the manager and printing code to pull more
information from the ResultSummary object rather than tracking
additional statistics on the side. This allows us to consolidate
a bunch of logic and remove a bunch of free-floating lists and dicts of
of values. We add the shard_name and worker_name to each TestResult,
and then modify print_timing_statistics() and upload_json_files()
to just need the result summaries.

Note that this patch also changes the timing statistics slightly
so that the individual test times are the times to run just the
tests themselves (TestResult.test_run_time) and do not include the
times taken to run the ref tests, compute diffs, etc. The aggregated
per-worker and per-shard statistics still use the total time to
process each test (TestResult.total_run_time).

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.__init__):
(LayoutTestRunner.run_tests):
(LayoutTestRunner._handle_finished_test_list):
(LayoutTestRunner._handle_finished_test):
(Worker.handle):
(Worker._run_test):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
(Manager.run):
(Manager._upload_json_files):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.summarized_results):
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.__init__):
(JSONLayoutResultsGenerator._get_test_timing):
* Scripts/webkitpy/layout_tests/models/test_results.py:
(TestResult.__init__):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_results):
(Printer._print_timing_statistics):
(Printer):
(Printer._print_worker_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_directory_timings):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_unexpected_results.get_unexpected_results):
(Testprinter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProperly create the header links in the code review tool
ojan@chromium.org [Tue, 4 Dec 2012 22:47:59 +0000 (22:47 +0000)]
Properly create the header links in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=104037

Reviewed by Adam Barth.

Right now, we just prepend "header" to the two existing links and change
the first link to point to the header. The problem is that jQuery's prepend
method just prepends to each item in the jQuery object instead of adding
the item to the beginning of the list as this code assumed.

* code-review-test.html:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify ShadowRoot::cloneNode(bool,ExceptionCode)
dpranke@chromium.org [Tue, 4 Dec 2012 22:44:02 +0000 (22:44 +0000)]
Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
https://bugs.webkit.org/show_bug.cgi?id=103928

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-12-04
Reviewed by Dimitri Glazkov.

ShadowRoot can never be cloned and ShadowRoot::cloneNode(bool) always
returns null so there's no reason to have code in the cloneNode method
for script that acts as if it may not return null.

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, mark css3/filters/effect-reference-hw.html as failing rather than crashing.
eae@chromium.org [Tue, 4 Dec 2012 22:43:42 +0000 (22:43 +0000)]
Unreviewed, mark css3/filters/effect-reference-hw.html as failing rather than crashing.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosetIsInTopLayer is not really a setter
dpranke@chromium.org [Tue, 4 Dec 2012 22:43:26 +0000 (22:43 +0000)]
setIsInTopLayer is not really a setter
https://bugs.webkit.org/show_bug.cgi?id=103912

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Eric Seidel.

Element::setInTopLayer isn't just a setter, it also adds the element
to the top layer vector in the document which changes it's display and
causes a reattach.

To make this more obvious make HTMLDialogElement use the methods on
Document and make those update the state boolean.

There also doesn't seem to be any reason for setInTopLayer
or isInTopLayer to be virtual, it appears it was a typo.

No new tests, just refactoring.

* dom/Document.cpp:
(WebCore::Document::addToTopLayer):
(WebCore::Document::removeFromTopLayer):
* dom/Element.cpp:
(WebCore::Element::setIsInTopLayer):
* dom/Element.h:
* html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::showModal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAutomatically handle suspend and resume of post attach callbacks
dpranke@chromium.org [Tue, 4 Dec 2012 22:42:57 +0000 (22:42 +0000)]
Automatically handle suspend and resume of post attach callbacks
https://bugs.webkit.org/show_bug.cgi?id=103910

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Eric Seidel.

Use RAII to handle suspend and resume of post attach callbacks since
they should always be called in pairs.

No new tests, just refactoring.

* dom/ContainerNode.h:
(PostAttachCallbackDisabler):
(WebCore::PostAttachCallbackDisabler::PostAttachCallbackDisabler):
(WebCore::PostAttachCallbackDisabler::~PostAttachCallbackDisabler):
(ContainerNode):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::attach):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::attach):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::attach):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocreateRareData should return a PassOwnPtr
dpranke@chromium.org [Tue, 4 Dec 2012 22:42:23 +0000 (22:42 +0000)]
createRareData should return a PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=103851

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Eric Seidel.

createRareData should return a PassOwnPtr, not an OwnPtr since it's
transfering ownership.

* dom/Element.cpp:
(WebCore::Element::createRareData):
* dom/Element.h:
(Element):
* dom/Node.cpp:
(WebCore::Node::createRareData):
* dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename Profiler to LegacyProfiler
fpizlo@apple.com [Tue, 4 Dec 2012 22:30:28 +0000 (22:30 +0000)]
Rename Profiler to LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=104031

Rubber stamped by Mark Hahnenberg

Source/JavaScriptCore:

Make room in the namespace for https://bugs.webkit.org/show_bug.cgi?id=102999.

* API/JSProfilerPrivate.cpp:
(JSStartProfiling):
(JSEndProfiling):
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
* jit/JIT.h:
* jit/JITCode.h:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* profiler/LegacyProfiler.cpp: Added.
(JSC):
(JSC::LegacyProfiler::profiler):
(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):
(JSC::dispatchFunctionToProfiles):
(JSC::LegacyProfiler::willExecute):
(JSC::LegacyProfiler::didExecute):
(JSC::LegacyProfiler::exceptionUnwind):
(JSC::LegacyProfiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
* profiler/LegacyProfiler.h: Added.
(JSC):
(LegacyProfiler):
(JSC::LegacyProfiler::currentProfiles):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
* profiler/ProfileNode.cpp:
* profiler/Profiler.cpp: Removed.
* profiler/Profiler.h: Removed.
* runtime/JSGlobalData.h:
(JSC):
(JSC::JSGlobalData::enabledProfiler):
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):

Source/WebCore:

Just renaming, no new tests.

* ForwardingHeaders/profiler/LegacyProfiler.h: Copied from Source/WebCore/ForwardingHeaders/profiler/Profiler.h.
* ForwardingHeaders/profiler/Profiler.h: Removed.
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Layout test inspector-protocol/debugger-pause-dedicated-worker.html is...
yurys@chromium.org [Tue, 4 Dec 2012 22:29:27 +0000 (22:29 +0000)]
[chromium] Layout test inspector-protocol/debugger-pause-dedicated-worker.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101229

Reviewed by Vsevolod Vlasov.

Removed unnecessary logging that introduced flakiness to the tests.

* inspector-protocol/debugger-pause-dedicated-worker-expected.txt:
* inspector-protocol/debugger-pause-dedicated-worker.html:
* inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt:
* inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium rebaselines.
eae@chromium.org [Tue, 4 Dec 2012 22:17:00 +0000 (22:17 +0000)]
Unreviewed chromium rebaselines.

* platform/chromium-mac-snowleopard/fast/parser/document-write-ignores-later-network-bytes-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/parser/document-write-ignores-later-network-bytes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSet the visible process name before entering the sandbox
andersca@apple.com [Tue, 4 Dec 2012 22:16:36 +0000 (22:16 +0000)]
Set the visible process name before entering the sandbox
https://bugs.webkit.org/show_bug.cgi?id=104030
<rdar://problem/12800317>

Reviewed by Sam Weinig.

Pass the UI process name along as a process initialization parameter so we can set it
before entering the sandbox. Remove the UI process name from WebProcessCreationParameters.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessService):
(WebKit::createProcess):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/mac/WebProcessInitialization.h:
(WebProcessInitializationParameters):
* WebProcess/mac/WebProcessInitialization.mm:
(WebKit::initializeWebProcess):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
* WebProcess/mac/WebProcessServiceEntryPoints.h:
* WebProcess/mac/WebProcessServiceEntryPoints.mm:
(WebKit::WebProcessServiceEventHandler):
(initializeWebProcessForWebProcessServiceForWebKitDevelopment):
* WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:
(WebProcessServiceForWebKitDevelopmentEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[User Timing] Fix clang build by removing need for exit time destructor
simonjam@chromium.org [Tue, 4 Dec 2012 22:04:41 +0000 (22:04 +0000)]
[User Timing] Fix clang build by removing need for exit time destructor
https://bugs.webkit.org/show_bug.cgi?id=104036

Reviewed by Tony Gentilcore.

Modeled after r99588.

No new tests. No change in functionality.

* page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::UserTiming):
(WebCore::UserTiming::mark):
(WebCore::UserTiming::findExistingMarkStartTime):
* page/PerformanceUserTiming.h:
(UserTiming):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations update.
eae@chromium.org [Tue, 4 Dec 2012 22:04:22 +0000 (22:04 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI introduce heap graph recording API
yurys@chromium.org [Tue, 4 Dec 2012 22:02:12 +0000 (22:02 +0000)]
Web Inspector: NMI introduce heap graph recording API
https://bugs.webkit.org/show_bug.cgi?id=103232

Reviewed by Vsevolod Vlasov.

MemoryInstrumentationClient is extended with several methods for reporting
heap graph vertices and edges. Edge source is always idenfied by heap object
address. Target node might be either a destination object address(either real
or adjusted if the edge was retrieved from a pointer to a base class) or a
MemoryObjectInfo in case of internal buffers.

* wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::reportEdge):
(WTF):
(WTF::MemoryInstrumentation::reportLinkToBuffer): report edge between the object
and a buffer which it owns.
(WTF::MemoryInstrumentation::InstrumentedPointerBase::process):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
* wtf/MemoryInstrumentation.h:
(MemoryInstrumentationClient):
(WTF::MemoryInstrumentationClient::reportNode):
(WTF::MemoryInstrumentationClient::reportEdge):
(WTF::MemoryInstrumentationClient::reportLeaf):
(WTF::MemoryInstrumentationClient::reportBaseAddress): if we found an object by a pointer
to base class it may have different value than real object address. Report both real and
adjusted addresses so that they both can be used for identifying corresponding heap graph
node.
(WTF::MemoryInstrumentation::addRootObject):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addObject):
(WTF::MemoryInstrumentation::addRawBuffer):
(WTF::MemoryInstrumentation::OwningTraits::addObject):
(WTF::MemoryClassInfo::addMember):
(MemoryClassInfo):
(WTF::MemoryInstrumentation::addObjectImpl):
* wtf/MemoryObjectInfo.h: added methods for repoting class name and some name string.
(WTF::MemoryObjectInfo::setClassName):
(WTF::MemoryObjectInfo::setName):
(MemoryObjectInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Tue, 4 Dec 2012 22:01:11 +0000 (22:01 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[User Timing] Fix negative durations
simonjam@chromium.org [Tue, 4 Dec 2012 22:00:00 +0000 (22:00 +0000)]
[User Timing] Fix negative durations
https://bugs.webkit.org/show_bug.cgi?id=104038

Reviewed by Tony Gentilcore.

At some point, we went from passing in a duration to passing in the end time. User Timing
wasn't updated.

Tests: http/tests/w3c/webperf/submission/Intel/user-timing

* page/PerformanceMark.h:
(WebCore::PerformanceMark::PerformanceMark):
* page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::measure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHeap-use-after-free in WebCore::StyleCachedImageSet::cssValue
inferno@chromium.org [Tue, 4 Dec 2012 21:50:18 +0000 (21:50 +0000)]
Heap-use-after-free in WebCore::StyleCachedImageSet::cssValue
https://bugs.webkit.org/show_bug.cgi?id=100621

Reviewed by Eric Seidel.

Source/WebCore:

r115639 fixed a memory leak caused by reference cycle between StyleCachedImageSet
and its owner CSSImageSetValue. The fix caused StyleCachedImageSet to maintain
a weak pointer to CSSImageSetValue. This patch makes sure that the weak pointer
is cleared when CSSImageSetValue is going away.

Test: fast/css/image-set-value-not-removed-crash.html

* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::~CSSImageSetValue):
* rendering/style/StyleCachedImageSet.h:
(WebCore::StyleCachedImageSet::clearImageSetValue):
(StyleCachedImageSet):

LayoutTests:

* fast/css/image-set-value-not-removed-crash-expected.txt: Added.
* fast/css/image-set-value-not-removed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNodeFilter leaks memory in V8
abarth@webkit.org [Tue, 4 Dec 2012 21:46:07 +0000 (21:46 +0000)]
NodeFilter leaks memory in V8
https://bugs.webkit.org/show_bug.cgi?id=104027

Reviewed by Eric Seidel.

NodeFilter holds a RefPtr to NodeFilterCondition, which holds a
ScopedPersistent to its callback function. If the callback function can
see the NodeFilter wrapper, we have a cycle and a leak.

This patch makes the NodeFilterCondition hold a weak pointer to the
callback function and ties the lifetime of that callback function to
the NodeFilter wrapper (so they live and die together).

* bindings/v8/V8GCController.cpp:
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::weakCallback):
(WebCore):
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8NodeFilterCondition.h:
(WebCore::V8NodeFilterCondition::create):
(V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::callback):
* dom/NodeFilter.h:
(WebCore::NodeFilter::condition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in CachedResource::checkNotify due to -webkit-crossfade.
inferno@chromium.org [Tue, 4 Dec 2012 21:29:22 +0000 (21:29 +0000)]
Crash in CachedResource::checkNotify due to -webkit-crossfade.
https://bugs.webkit.org/show_bug.cgi?id=98068

Reviewed by Nate Chapin.

Source/WebCore:

Make sure to not re-add the same client again for |m_cachedFromImage|
and |m_cachedToImage|. This would otherwise cause the CSSCrossfadeValue
client to not get removed from its cached image resource (when it is
going away).

Test: fast/images/crossfade-client-not-removed-crash.html

* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::loadSubimages):

LayoutTests:

* fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
* fast/images/crossfade-client-not-removed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skip flaky "fake mouse move tests" on Windows port.
roger_fong@apple.com [Tue, 4 Dec 2012 21:19:25 +0000 (21:19 +0000)]
Unreviewed. Skip flaky "fake mouse move tests" on Windows port.
https://bugs.webkit.org/show_bug.cgi?id=103043.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCan't add followup comment to a previous comment
ojan@chromium.org [Tue, 4 Dec 2012 21:11:01 +0000 (21:11 +0000)]
Can't add followup comment to a previous comment
https://bugs.webkit.org/show_bug.cgi?id=104025

Reviewed by Adam Barth.

If we side-by-sidify a shared diff line, and then apply
a previous comment, we would incorrectly put the comment
on the Line instead of the LineContainer.

Also, get rid of global next_line_id to simplify testing.

* code-review-test.html:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove obsolete code from webkitpy
abarth@webkit.org [Tue, 4 Dec 2012 21:10:38 +0000 (21:10 +0000)]
Remove obsolete code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=104029

Reviewed by Eric Seidel.

* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):
* Scripts/webkitpy/tool/steps/commit.py:
(Commit.options):
* Scripts/webkitpy/tool/steps/options.py:
(Options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHeap-use-after-free in WebCore::RenderLayer::paintList [MathML]
jchaffraix@webkit.org [Tue, 4 Dec 2012 21:10:03 +0000 (21:10 +0000)]
Heap-use-after-free in WebCore::RenderLayer::paintList [MathML]
https://bugs.webkit.org/show_bug.cgi?id=100764

Reviewed by Eric Seidel.

Source/WebCore:

Test: mathml/mfenced-root-layer.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::stackingContext):
Fixed this function to ensure that it always returns a stacking context, the bug
was that the document element's layer wasn't guaranteed to be a stacking context.

LayoutTests:

* mathml/mfenced-root-layer-expected.txt: Added.
* mathml/mfenced-root-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Skip fast/loader/non-deferred-substitute-load.html on Windows...
roger_fong@apple.com [Tue, 4 Dec 2012 21:07:45 +0000 (21:07 +0000)]
Unreviewed gardening. Skip fast/loader/non-deferred-substitute-load.html on Windows port.
https://bugs.webkit.org/show_bug.cgi?id=103968

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move WebPreferences and methods for modifying them to the TestRunner library
jochen@chromium.org [Tue, 4 Dec 2012 21:00:36 +0000 (21:00 +0000)]
[chromium] move WebPreferences and methods for modifying them to the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=103841

Reviewed by Darin Fisher.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
(WebKit):
(WebTestRunner):
(WebPreferences):
(WebTestRunner::WebPreferences::WebPreferences):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner):
(WebTestDelegate):
(WebTestRunner::WebTestDelegate::localFileToDataURL):
(WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
(WebTestRunner::WebTestDelegate::preferences):
(WebTestRunner::WebTestDelegate::applyPreferences):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setUserStyleSheetEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::setUserStyleSheetLocation):
(WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
(WebTestRunner::TestRunner::setPopupBlockingEnabled):
(WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
(WebTestRunner::TestRunner::setXSSAuditorEnabled):
(WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
(WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::setPluginsEnabled):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
(WebTestRunner::WebPreferences::reset):
(WebTestRunner):
(WebTestRunner::WebPreferences::applyTo):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::preferences):
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::localFileToDataURL):
(WebViewHost::rewriteLayoutTestsURL):
(WebViewHost::preferences):
(WebViewHost::applyPreferences):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] GetNativeType in CodeGeneratorV8.pm needs a bath
abarth@webkit.org [Tue, 4 Dec 2012 20:47:49 +0000 (20:47 +0000)]
[V8] GetNativeType in CodeGeneratorV8.pm needs a bath
https://bugs.webkit.org/show_bug.cgi?id=104022

Reviewed by Eric Seidel.

This change shouldn't have any effect on the generated code.

* bindings/scripts/CodeGeneratorV8.pm:
(GetNativeType):
    - DOMUserData was removed in 2005. There's no need for the code
      generator to still know about it.
(JSValueToNative):
(ConvertToV8StringResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] EventTarget shouldn't be a special snowflake
abarth@webkit.org [Tue, 4 Dec 2012 20:47:30 +0000 (20:47 +0000)]
[V8] EventTarget shouldn't be a special snowflake
https://bugs.webkit.org/show_bug.cgi?id=104018

Reviewed by Eric Seidel.

Previously we special-cased the toV8 operation for event targets.
There's no need for that. We can use IDL attribute to handle
EventTarget using the same general-purpose code that we use for other
interfaces.

* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::getReceiverObject):
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::getReceiverObject):
* bindings/v8/custom/V8EventTargetCustom.cpp: Added.
(WebCore):
(WebCore::toV8):
* dom/EventTarget.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed followup to r136548, manually removing the unnecessary executable bit...
zandobersek@gmail.com [Tue, 4 Dec 2012 20:37:28 +0000 (20:37 +0000)]
Unreviewed followup to r136548, manually removing the unnecessary executable bit from the related files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMany webkitpy unit tests can be run standalone, are executable
zandobersek@gmail.com [Tue, 4 Dec 2012 20:34:15 +0000 (20:34 +0000)]
Many webkitpy unit tests can be run standalone, are executable
https://bugs.webkit.org/show_bug.cgi?id=103900

Reviewed by Eric Seidel.

There's no need anymore to run unit tests in standalone mode as they
are now handled by test-webkitpy in a formidable fashion. This makes
it possible for this patch to remove the following unnecessary bits:
- remove shebang lines from unit test files,
- remove calls to unittest.main(),
- make unit test files non-executable.

* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
(DiffParserTest.test_git_mnemonicprefix):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest.test_should_build):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_chromium_xvfb_port):
* Scripts/webkitpy/common/find_files_unittest.py:
(TestWinNormalize.test_win):
* Scripts/webkitpy/common/lru_cache_unittest.py:
(LRUCacheTest.test_set_again):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_results_zip_url):
* Scripts/webkitpy/common/net/credentials_unittest.py:
(test_keyring_without_git_repo_nor_keychain):
* Scripts/webkitpy/common/net/omahaproxy_unittest.py:
(OmahaProxyTest.test_get_revisions):
* Scripts/webkitpy/common/net/unittestresults_unittest.py:
* Scripts/webkitpy/common/newstringio_unittest.py:
(NewStringIOTest.test_with):
* Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
(ReadChecksumFromPngTest.test_read_checksum):
* Scripts/webkitpy/common/system/file_lock_integrationtest.py:
* Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
(MockFileSystemTest.test_normpath):
* Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_sep):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_total_bytes_memory):
* Scripts/webkitpy/common/system/zipfileset_unittest.py:
(ZipFileSetTest.test_namelist):
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.test_test_timings_trie):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(TestExpectationSerializationTests.test_string_whitespace_stripping):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(KeyCompareTest.test_test_key):
* Scripts/webkitpy/layout_tests/port/builders_unittest.py:
(BuildersTest.test_path_from_name):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortLoggingTest.test_check_sys_deps):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortLoggingTest.test_check_sys_deps):
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.test_default_configuration__scripterror):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_start_actually_starts):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_get_from_builder_name):
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
* Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_mac_lion):
* Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(VerboseTest.test_log_args):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(test_details):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestFactory.test_inspector_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_parse_args):
* Scripts/webkitpy/style/checker_unittest.py:
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_no_error):
* Scripts/webkitpy/style/checkers/common_unittest.py:
(TabCheckerTest.test_tab):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppCheckerTest.test_ne):
* Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
* Scripts/webkitpy/style/checkers/text_unittest.py:
(TextCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/watchlist_unittest.py:
* Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
(XcodeProjectFileCheckerTest.test_detect_development_region):
* Scripts/webkitpy/style/checkers/xml_unittest.py:
(XMLCheckerTest.test_no_error):
* Scripts/webkitpy/style/patchreader_unittest.py:
* Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.test_paths):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_run):
* Scripts/webkitpy/test/skip_unittest.py:
(SkipTest.test_skip_if_true):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_imports):
* Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
(TestTranslation.test_include_rewriting):
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(QueueEngineTest.tearDown):
* Scripts/webkitpy/tool/grammar_unittest.py:
(GrammarTest.test_join_with_separators):
* Scripts/webkitpy/tool/mocktool_unittest.py:
(MockOptionsTest.test_kwarg__set):
* Scripts/webkitpy/tool/multicommandtool_unittest.py:
(test_command_help):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed followup to r136545, manually removing the unnecessary executable bit...
zandobersek@gmail.com [Tue, 4 Dec 2012 20:31:15 +0000 (20:31 +0000)]
Unreviewed followup to r136545, manually removing the unnecessary executable bit from the related files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should inline code blocks that use scoped variable access
fpizlo@apple.com [Tue, 4 Dec 2012 20:25:24 +0000 (20:25 +0000)]
DFG should inline code blocks that use scoped variable access
https://bugs.webkit.org/show_bug.cgi?id=103974

Reviewed by Oliver Hunt.

This mostly just turns on something we could have done all along, but also adds a few key
necessities to make this right:

1) Constant folding of SkipScope, since if we inline with a known JSFunction* then the
   scope is constant.

2) Interference analysis for GetLocal<->PutScopedVar and SetLocal<->GetScopedVar.

This is not meant to be a speed-up on major benchmarks since we don't yet inline most
closure calls for entirely unrelated reasons. But on toy programs it can be >2x faster.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
* dfg/DFGCapabilities.h:
(JSC::DFG::canInlineResolveOperations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMany webkitpy module files are executable, have shebang line
zandobersek@gmail.com [Tue, 4 Dec 2012 20:17:55 +0000 (20:17 +0000)]
Many webkitpy module files are executable, have shebang line
https://bugs.webkit.org/show_bug.cgi?id=103985

Reviewed by Dirk Pranke.

Remove the executable bit from webkitpy module files that are
unnecessarily executable. Remove the shebang line from webkitpy
module files, they are of no use. Only non-third-party files are
changed.

* Scripts/webkitpy/bindings/main.py:
* Scripts/webkitpy/common/config/watchlist:
* Scripts/webkitpy/common/find_files.py:
* Scripts/webkitpy/common/lru_cache.py:
* Scripts/webkitpy/common/multiprocessing_bootstrap.py:
* Scripts/webkitpy/common/net/file_uploader.py:
* Scripts/webkitpy/common/newstringio.py:
* Scripts/webkitpy/common/read_checksum_from_png.py:
* Scripts/webkitpy/common/system/autoinstall.py:
* Scripts/webkitpy/common/system/file_lock.py:
* Scripts/webkitpy/common/system/file_lock_mock.py:
* Scripts/webkitpy/common/version_check.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/models/test_failures.py:
* Scripts/webkitpy/layout_tests/models/test_input.py:
* Scripts/webkitpy/layout_tests/port/__init__.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/config.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/http_lock.py:
* Scripts/webkitpy/layout_tests/port/image_diff.py:
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
* Scripts/webkitpy/layout_tests/servers/http_server.py:
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
* Scripts/webkitpy/layout_tests/servers/websocket_server.py:
* Scripts/webkitpy/layout_tests/views/metered_stream.py:
* Scripts/webkitpy/layout_tests/views/printing.py:
* Scripts/webkitpy/performance_tests/perftest.py:
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
* Scripts/webkitpy/style/checkers/changelog.py:
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/xcodeproj.py:
* Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
(main): There's no need to run this module in standalone because
it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/comments.py:
* Scripts/webkitpy/tool/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled DEPS (w/Linux build fix). Unreviewed.
senorblanco@chromium.org [Tue, 4 Dec 2012 19:47:55 +0000 (19:47 +0000)]
Rolled DEPS (w/Linux build fix).  Unreviewed.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, mark fast/dom/HTMLTemplateElement/inertContents.html as flaky on mac...
eae@chromium.org [Tue, 4 Dec 2012 19:38:55 +0000 (19:38 +0000)]
Unreviewed, mark fast/dom/HTMLTemplateElement/inertContents.html as flaky on mac debug.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136530.
senorblanco@chromium.org [Tue, 4 Dec 2012 19:35:56 +0000 (19:35 +0000)]
Unreviewed, rolling out r136530.
http://trac.webkit.org/changeset/136530

Broke build.webkit.org linux build

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStale SVGUseElement reference in CachedResource::checkNotify()
fmalita@chromium.org [Tue, 4 Dec 2012 19:35:30 +0000 (19:35 +0000)]
Stale SVGUseElement reference in CachedResource::checkNotify()
https://bugs.webkit.org/show_bug.cgi?id=104004

Reviewed by Eric Seidel.

Source/WebCore:

SVGUseElement tracks one CachedSVGDocument at a time (for external references), but when
the href attribute is updated it fails to unregister with the current CachedSVGDocument
and only updates its CachedSVGDocument with the new instance. This leaves an untracked
reference with the original CachedSVGDocument.

The patch adds the missing removeClient() call on href change, and encapsulates the
CachedSVGDocument manipulation in a helper method which handles the necessary cleanup.

Test: svg/custom/use-href-update-crash.svg

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::setCachedDocument):
(WebCore):
* svg/SVGUseElement.h:
(SVGUseElement):

LayoutTests:

* svg/custom/use-href-update-crash-expected.txt: Added.
* svg/custom/use-href-update-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Can't take a heap snapshot in chromium ("Uncaught ReferenceError")
alexis@webkit.org [Tue, 4 Dec 2012 19:29:48 +0000 (19:29 +0000)]
Web Inspector: Can't take a heap snapshot in chromium ("Uncaught ReferenceError")
https://bugs.webkit.org/show_bug.cgi?id=103997

Patch by Yury Semikhatsky <yurys@chromium.org> on 2012-12-04
Reviewed by Pavel Feldman.

utilities.js used in both page and worker contexts should not access window
object as there is no one in case of workers. NonLeakingMutationObserver implementation
has moved to DOMExtension.js

* inspector/front-end/DOMExtension.js:
(NonLeakingMutationObserver.NonLeakingMutationObserver._unloadListener):
(NonLeakingMutationObserver):
(NonLeakingMutationObserver.prototype.observe):
(NonLeakingMutationObserver.prototype.disconnect):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace JSValue::description() with JSValue::dump(PrintStream&)
fpizlo@apple.com [Tue, 4 Dec 2012 19:29:13 +0000 (19:29 +0000)]
Replace JSValue::description() with JSValue::dump(PrintStream&)
https://bugs.webkit.org/show_bug.cgi?id=103866

Reviewed by Darin Adler.

Source/JavaScriptCore:

JSValue now has a dump() method. Anywhere that you would have wanted to use
description(), you can either do toCString(value).data(), or if the callee
is a print()/dataLog() method then you just pass the value directly.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/CodeBlock.cpp:
(JSC::valueToSourceString):
(JSC::CodeBlock::finalizeUnconditionally):
* bytecode/ValueProfile.h:
(JSC::ValueProfileBase::dump):
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dump):
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::dump):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
* jsc.cpp:
(functionDescribe):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_trace_value):
* runtime/JSValue.cpp:
(JSC::JSValue::dump):
* runtime/JSValue.h:

Source/WTF:

Make it easier to get a String from a StringPrintStream.

* wtf/StringPrintStream.cpp:
(WTF::StringPrintStream::toString):
* wtf/StringPrintStream.h:
(StringPrintStream):
(WTF::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agojsc command line tool's support for typed arrays should be robust against array buffe...
fpizlo@apple.com [Tue, 4 Dec 2012 19:25:38 +0000 (19:25 +0000)]
jsc command line tool's support for typed arrays should be robust against array buffer allocation errors
https://bugs.webkit.org/show_bug.cgi?id=104020
<rdar://problem/12802478>

Reviewed by Mark Hahnenberg.

Check for null buffers, since that's what typed array allocators are supposed to do. WebCore does it,
and that is indeed the contract of ArrayBuffer and TypedArrayBase.

* JSCTypedArrayStubs.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Can't take a heap snapshot in chromium ("Uncaught ReferenceError")
yurys@chromium.org [Tue, 4 Dec 2012 19:04:38 +0000 (19:04 +0000)]
Web Inspector: Can't take a heap snapshot in chromium ("Uncaught ReferenceError")
https://bugs.webkit.org/show_bug.cgi?id=103997

Reviewed by Pavel Feldman.

utilities.js used in both page and worker contexts should not access window
object as there is no one in case of workers. NonLeakingMutationObserver implementation
has moved to DOMExtension.js

* inspector/front-end/DOMExtension.js:
(NonLeakingMutationObserver.NonLeakingMutationObserver._unloadListener):
(NonLeakingMutationObserver):
(NonLeakingMutationObserver.prototype.observe):
(NonLeakingMutationObserver.prototype.disconnect):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Track private browsing session explicitly
ap@apple.com [Tue, 4 Dec 2012 18:59:15 +0000 (18:59 +0000)]
    [WK2] Track private browsing session explicitly
        <rdar://problem/12714532>
        https://bugs.webkit.org/show_bug.cgi?id=103953

        Reviewed by Jessie Berlin.

        * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode):
        Fixed a confusing ifdef - this code is inside PLATFORM(WIN), so PLATFORM(MAC)
        makes no sense.

        * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPrivateBrowsingEnabled):
        This is the only place in WK2 where we can learn that private browsing got disabled -
        no other functions are called when there are no pages open.

        * UIProcess/WebContext.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::willStartUsingPrivateBrowsing):
        (WebKit::WebContext::willStopUsingPrivateBrowsing):
        Count the number of API calls. We only implement a single shared private browsing
        session, not one per page group as API implies. When private browsing gets disabled,
        we want to destroy its session.

        * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
        Ensure a private browsing session if the current page needs it.

        * WebProcess/WebProcess.h:
        * WebProcess/WebProcess.messages.in:
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::ensurePrivateBrowsingSession):
        (WebKit::WebProcess::destroyPrivateBrowsingSession):
        Call through to WebFrameNetworkingContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMissing -expected.txt files for new <track> tests
commit-queue@webkit.org [Tue, 4 Dec 2012 18:58:14 +0000 (18:58 +0000)]
Missing -expected.txt files for new <track> tests
https://bugs.webkit.org/show_bug.cgi?id=104006

Patch by Antoine Quint <graouts@apple.com> on 2012-12-04
Reviewed by Eric Carlson.

Add the missing -expected.txt files.

* media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Added.
* media/track/opera/interfaces/TextTrack/kind-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136509.
commit-queue@webkit.org [Tue, 4 Dec 2012 18:52:10 +0000 (18:52 +0000)]
Unreviewed, rolling out r136509.
http://trac.webkit.org/changeset/136509
https://bugs.webkit.org/show_bug.cgi?id=104015

broke layout tests (Requested by eae on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-04

Source/WebCore:

* platform/graphics/IntSize.h:
(WebCore::IntSize::scale):

LayoutTests:

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Tue, 4 Dec 2012 18:49:51 +0000 (18:49 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] fix showFPScounter and showPaintRects not toggleable after page change
commit-queue@webkit.org [Tue, 4 Dec 2012 18:47:50 +0000 (18:47 +0000)]
[chromium] fix showFPScounter and showPaintRects not toggleable after page change
https://bugs.webkit.org/show_bug.cgi?id=103937

Patch by Eberhard Graether <egraether@google.com> on 2012-12-04
Reviewed by Pavel Feldman.

This change avoids updating the WebSettings and uses fields for showFPSCounter and
showPaintRects in WebViewImpl instead, which hold the values between InspectorPageAgent::restore()
and WebViewImpl::setIsAcceleratedCompositingActive().

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit::WebViewImpl::setShowPaintRects):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoINVALID_STATE_ERR error upon calling .addCue() for an already-in-use cue
dino@apple.com [Tue, 4 Dec 2012 18:47:31 +0000 (18:47 +0000)]
INVALID_STATE_ERR error upon calling .addCue() for an already-in-use cue
https://bugs.webkit.org/show_bug.cgi?id=103264

Patch by Antoine Quint <graouts@apple.com> on 2012-12-04
Reviewed by Eric Carlson.

Source/WebCore:

Adhere to the latest spec for TextTrack's .addCue() method. This also fixes
https://bugs.webkit.org/show_bug.cgi?id=103265 and we've removed
media/track/opera/interfaces/TextTrack/addCue.html from the Skipped list.

* html/track/TextTrack.cpp:
(WebCore::TextTrack::addCue):
* html/track/TextTrack.h:
(TextTrack):
* html/track/TextTrack.idl:

LayoutTests:

Stop skipping media/track/opera/interfaces/TextTrack/addCue.html as it now mostly passes, the remaining issue
being tracked by https://bugs.webkit.org/show_bug.cgi?id=103258.

* media/track/opera/interfaces/TextTrack/addCue-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLog to console when forms and popups are blocked by 'sandbox'.
mkwst@chromium.org [Tue, 4 Dec 2012 18:34:27 +0000 (18:34 +0000)]
Log to console when forms and popups are blocked by 'sandbox'.
https://bugs.webkit.org/show_bug.cgi?id=103615

Reviewed by Adam Barth.

Source/WebCore:

Adds two console messages to cover form submissions blocked by a
sandboxed frame lacking the 'allow-forms' permission, and window
creation blocked by a sandboxed frame lacking the 'allow-popups'
permission.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
    Log a warning when form submission is blocked by sandboxing flags.
(WebCore::createWindow):
    Log a warning when window.open is blocked due to sandboxing flags.

LayoutTests:

* fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
* fast/frames/sandboxed-iframe-forms-dynamic-expected.txt:
* fast/frames/sandboxed-iframe-forms-expected.txt:
* fast/frames/sandboxed-iframe-navigation-top-by-name-denied-expected.txt:
* fast/frames/sandboxed-iframe-navigation-windowopen-expected.txt:
* http/tests/security/no-popup-from-sandbox.html:
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html:
    Updating effected tests with new console warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make v8::Null(isolate) faster by caching the value in V8 bindings
haraken@chromium.org [Tue, 4 Dec 2012 18:28:32 +0000 (18:28 +0000)]
[V8] Make v8::Null(isolate) faster by caching the value in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=103862

Reviewed by Adam Barth.

Performance comparison between V8 and JSC revealed that DOM attributes
that return v8::Null(isolate) are much slower than JSC.
(https://docs.google.com/a/chromium.org/spreadsheet/ccc?key=0AlobCOyvTnPKdDg5S0dMdGRGRTRSaW53V1ppVzh6eXc#gid=2)

We can optimize v8::Null(isolate) by caching the value to V8PerIsolateData.
(Although I don't like the optimization, it looks difficult to optimize
v8::Null(isolate) more.)

[Bindings/undefined-first-child.html]
Before: 969 runs/sec, 970 runs/sec, 962 runs/sec
After:  1086 runs/sec, 1085 runs/sec, 1086 runs/sec

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8Fast):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::v8Null):
(WebCore::v8NullWithCheck):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::V8PerIsolateData):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::v8Null):
(V8PerIsolateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd an helper function in CSSParser to check for '/' character.
alexis@webkit.org [Tue, 4 Dec 2012 18:24:45 +0000 (18:24 +0000)]
Add an helper function in CSSParser to check for '/' character.
https://bugs.webkit.org/show_bug.cgi?id=104009

Reviewed by Ryosuke Niwa.

I'm about to add the same pattern in a following patch. Let's do an
helper function first. We also did that for the comma. The slash
character is pretty used in shorthands definitions.

No new tests : just a refactor, existing tests should cover.

* css/CSSParser.cpp:
(WebCore::isForwardSlashOperator):
(WebCore):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseAspectRatio):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a Chromium Android Release (Perf) to the list of perf. bots.
rniwa@webkit.org [Tue, 4 Dec 2012 18:22:55 +0000 (18:22 +0000)]
Add a Chromium Android Release (Perf) to the list of perf. bots.

* BuildSlaveSupport/build.webkit.org-config/templates/root.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium rebaseline for r136508.
eae@chromium.org [Tue, 4 Dec 2012 18:13:55 +0000 (18:13 +0000)]
Unreviewed chromium rebaseline for r136508.

* platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac-lion/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac-snowleopard/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-win/compositing/masks/masked-ancestor-expected.png:
* platform/efl-wk1/compositing/masks: Added.
* platform/efl-wk1/compositing/masks/masked-ancestor-expected.png: Added.
* platform/efl/compositing/masks/masked-ancestor-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Insert the jhbuild wrapper command at the beginning of the command list
zandobersek@gmail.com [Tue, 4 Dec 2012 18:12:59 +0000 (18:12 +0000)]
[GTK] Insert the jhbuild wrapper command at the beginning of the command list
https://bugs.webkit.org/show_bug.cgi?id=103991

Reviewed by Martin Robinson.

Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
command that's being formed in multiprocessing bootstrap. The wrapper is
an executable Python script while the command being wrapped perhaps isn't
and therefore requires the Python interpreter to be listed at the beginning
of the command sublist that is then executed by the wrapper.

Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
is about to lose the executable bit and the Python-signaling shebang line.
The Jhbuild wrapper simply executes the command that's passed, but that errs
in this case unless the Python executable is executed and the module file
is passed to it as an argument.

* Scripts/webkitpy/common/multiprocessing_bootstrap.py:
(run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInspector: Introduce Input.dispatchKeyEvent and DOM.focus for typing simulation.
commit-queue@webkit.org [Tue, 4 Dec 2012 18:04:21 +0000 (18:04 +0000)]
Inspector: Introduce Input.dispatchKeyEvent and DOM.focus for typing simulation.
https://bugs.webkit.org/show_bug.cgi?id=103530

Patch by Ken Kania <kkania@chromium.org> on 2012-12-04
Reviewed by Yury Semikhatsky.

Input.dispatchKeyEvent simply calls EventHandler::keyEvent with the key event data
from the command parameters. The client will be responsible for providing proper
events to simulate desired typing behavior.
DOM.focus calls focus on a dom element.

Source/WebCore:

Tests: inspector-protocol/dom-focus.html
       inspector-protocol/input-dispatchKeyEvent.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::focus):
(WebCore):
(WebCore::InspectorDOMAgent::resolveNode):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorInputAgent.cpp: Added.
(WebCore):
(WebCore::InspectorInputAgent::InspectorInputAgent):
(WebCore::InspectorInputAgent::~InspectorInputAgent):
(WebCore::InspectorInputAgent::dispatchKeyEvent):
* inspector/InspectorInputAgent.h: Added.
(WebCore):
(InspectorInputAgent):
(WebCore::InspectorInputAgent::create):

LayoutTests:

* inspector-protocol/dom-focus-expected.txt: Added.
* inspector-protocol/dom-focus.html: Added.
* inspector-protocol/input/dispatchKeyEvent-expected.txt: Added.
* inspector-protocol/input/dispatchKeyEvent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFontPlatformData has unnecessary m_textOrientation member
mitz@apple.com [Tue, 4 Dec 2012 17:58:44 +0000 (17:58 +0000)]
FontPlatformData has unnecessary m_textOrientation member
https://bugs.webkit.org/show_bug.cgi?id=103971

Reviewed by Darin Adler.

Nothing in SimpleFontData depends on the FontPlatformData’s textOrientation, so we don’t
need separate data for vertical-right and upright. We simply choose between
verticalRightOrientationFontData() and uprightOrientationFontData() based on the
textOrientation in the FontDescription.

* WebCore.exp.in: Updated FontPlatformData constructor exports.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Removed the text orientation bit from the hash key,
and updated for the removal of the TextOrientation parameter to
CachedFont::platformDataFromCustomData().

* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::platformDataFromCustomData): Removed the TextOrientation parameter.
* loader/cache/CachedFont.h:

* platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): Removed the TextOrientation
parameter and initializer.
(WebCore::FontPlatformDataCacheKey::operator==): Updated for removal of m_textOrientation
member variable.
(FontPlatformDataCacheKey): Removed m_textOrientation member variable.
(WebCore::computeHash): Removed text orientation bit from the hash.
(WebCore::FontCache::getCachedFontPlatformData): Updated for FontPlatformDataCacheKey
change.

* platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData): Removed TextOrientation parameters and
initializers.
(WebCore::FontPlatformData::operator=): Updated for removal of m_textOrientation
member variable.
* platform/graphics/FontPlatformData.h:
(FontPlatformData): Removed m_textOrientation member variable, removed TextOrientation
parameters from constructors.
(WebCore::FontPlatformData::hash): Removed text orientation bit.
(WebCore::FontPlatformData::operator==): Updated for removed member variable.

* platform/graphics/cairo/FontCustomPlatformData.h:
(FontCustomPlatformData::fontPlatformData): Removed TextOrientation parameter.

* platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::createFontPlatformData): Updated for FontPlatformData change.

* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData): Removed TextOrientation parameter and
initializer.

* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Removed TextOrientation parameter.
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::FontPlatformData): Removed TextOrientation parameter and
initializers.
(WebCore::FontPlatformData::operator=): Updated for removed member variable.
(WebCore::FontPlatformData::operator==): Ditto.
(WebCore::FontPlatformData::hash): Removed text orientation bit.

* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData): Removed TextOrientation parameter from the constructor declaration.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData): Updated for FontPlatformData change.

* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Removed TextOrientation parameter.

* platform/graphics/mac/FontCustomPlatformData.h:
(FontCustomPlatformData): Removed TextOrientation parameter from declaration of
fontPlatformData().

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCompositeFontReferenceFontData): Updated for FontPlatformData
change.

* platform/graphics/pango/FontCustomPlatformDataPango.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Removed TextOrientation parameter.
* platform/graphics/qt/FontCustomPlatformData.h:

* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Ditto.

* platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::createFontPlatformData): Updated for FontPlatformData change.

* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Removed TextOrientation parameter.
* platform/graphics/skia/FontCustomPlatformData.h:

* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Removed TextOrientation parameter.
* platform/graphics/win/FontCustomPlatformData.h:

* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Removed TextOrientation parameter.
* platform/graphics/win/FontCustomPlatformDataCairo.h:

* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Removed m_textOrientation initializer.

* platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.

* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.

* platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Removed TextOrientation parameter.
* platform/graphics/wince/FontCustomPlatformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed mathml rebaseline.
eae@chromium.org [Tue, 4 Dec 2012 17:54:14 +0000 (17:54 +0000)]
Unreviewed mathml rebaseline.

* platform/chromium-linux-x86/mathml/presentation/sub-expected.txt: Removed.
* platform/chromium-mac-lion/mathml/presentation/sub-expected.txt: Removed.
* platform/chromium/mathml/presentation/sub-expected.txt: Removed.
* platform/efl-wk1/mathml: Added.
* platform/efl-wk1/mathml/presentation: Added.
* platform/efl-wk1/mathml/presentation/roots-expected.txt: Added.
* platform/efl-wk1/mathml/presentation/row-alignment-expected.txt: Added.
* platform/efl-wk1/mathml/presentation/sub-expected.txt: Added.
* platform/efl-wk1/mathml/presentation/subsup-expected.txt: Added.
* platform/efl/mathml/presentation/roots-expected.txt: Removed.
* platform/efl/mathml/presentation/row-alignment-expected.txt: Removed.
* platform/efl/mathml/presentation/sub-expected.txt: Removed.
* platform/efl/mathml/presentation/subsup-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skip new broken tests in chromium.
eae@chromium.org [Tue, 4 Dec 2012 17:47:46 +0000 (17:47 +0000)]
Unreviewed, skip new broken tests in chromium.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations update, mark unskipped svg tests as slow.
eae@chromium.org [Tue, 4 Dec 2012 17:41:03 +0000 (17:41 +0000)]
Unreviewed chromium expectations update, mark unskipped svg tests as slow.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd FrameLoaderClient::didDisownOpener
creis@chromium.org [Tue, 4 Dec 2012 17:39:26 +0000 (17:39 +0000)]
Add FrameLoaderClient::didDisownOpener
https://bugs.webkit.org/show_bug.cgi?id=103789

Reviewed by Darin Fisher.

Source/WebCore:

Adds a didDisownOwner notification when a frame's opener is cleared,
so that FrameLoaderClients can react.

No new tests.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOpener): Calls didDisownOpener if opener is cleared.
* loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::didDisownOpener):

Source/WebKit/chromium:

Forwards the didDisownOpener notification to the WebFrameClient.

* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didDisownOpener):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didDisownOpener):
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd the Chromium Android Release (Perf) bot
peter@chromium.org [Tue, 4 Dec 2012 17:39:03 +0000 (17:39 +0000)]
Add the Chromium Android Release (Perf) bot
https://bugs.webkit.org/show_bug.cgi?id=103891

Reviewed by Eric Seidel.

Add configuration for the bot itself. It will be triggered by the Chromium
Android Release builder. When running for Android, the DownloadAndPerfTest
factory will also add the OutputAndroidDeviceStatus step.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadAndPerfTestFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium rebaseline for r136506 and 136502.
eae@chromium.org [Tue, 4 Dec 2012 17:32:01 +0000 (17:32 +0000)]
Unreviewed chromium rebaseline for r136506 and 136502.

* platform/chromium-linux/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Removed.
* platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Removed.
* platform/chromium-linux/media/track/opera: Added.
* platform/chromium-linux/media/track/opera/interfaces: Added.
* platform/chromium-linux/media/track/opera/interfaces/HTMLElement: Added.
* platform/chromium-linux/media/track/opera/interfaces/HTMLElement/HTMLMediaElement: Added.
* platform/chromium-linux/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Added.
* platform/chromium-linux/media/track/opera/interfaces/TextTrack: Added.
* platform/chromium-linux/media/track/opera/interfaces/TextTrack/kind-expected.txt: Added.
* platform/chromium-mac-lion/media/track/opera: Added.
* platform/chromium-mac-lion/media/track/opera/interfaces: Added.
* platform/chromium-mac-lion/media/track/opera/interfaces/HTMLElement: Added.
* platform/chromium-mac-lion/media/track/opera/interfaces/HTMLElement/HTMLMediaElement: Added.
* platform/chromium-mac-lion/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Added.
* platform/chromium-mac-lion/media/track/opera/interfaces/TextTrack: Added.
* platform/chromium-mac-lion/media/track/opera/interfaces/TextTrack/kind-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Removed.
* platform/chromium-mac-snowleopard/media/track/opera: Added.
* platform/chromium-mac-snowleopard/media/track/opera/interfaces: Added.
* platform/chromium-mac-snowleopard/media/track/opera/interfaces/HTMLElement: Added.
* platform/chromium-mac-snowleopard/media/track/opera/interfaces/HTMLElement/HTMLMediaElement: Added.
* platform/chromium-mac-snowleopard/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Added.
* platform/chromium-mac-snowleopard/media/track/opera/interfaces/TextTrack: Added.
* platform/chromium-mac-snowleopard/media/track/opera/interfaces/TextTrack/kind-expected.txt: Added.
* platform/chromium-mac/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png:
* platform/chromium-mac/compositing/repaint/newly-composited-on-scroll-expected.png:
* platform/chromium-mac/media/track/opera: Added.
* platform/chromium-mac/media/track/opera/interfaces: Added.
* platform/chromium-mac/media/track/opera/interfaces/HTMLElement: Added.
* platform/chromium-mac/media/track/opera/interfaces/HTMLElement/HTMLMediaElement: Added.
* platform/chromium-mac/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Added.
* platform/chromium-mac/media/track/opera/interfaces/TextTrack: Added.
* platform/chromium-mac/media/track/opera/interfaces/TextTrack/kind-expected.txt: Added.
* platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Removed.
* platform/chromium-win-xp/media/track/opera: Added.
* platform/chromium-win-xp/media/track/opera/interfaces: Added.
* platform/chromium-win-xp/media/track/opera/interfaces/HTMLElement: Added.
* platform/chromium-win-xp/media/track/opera/interfaces/HTMLElement/HTMLMediaElement: Added.
* platform/chromium-win-xp/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Added.
* platform/chromium-win-xp/media/track/opera/interfaces/TextTrack: Added.
* platform/chromium-win-xp/media/track/opera/interfaces/TextTrack/kind-expected.txt: Added.
* platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Removed.
* platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png:
* platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-win/compositing/reflections/reflection-in-composited-expected.png:
* platform/chromium-win/media/track/opera: Added.
* platform/chromium-win/media/track/opera/interfaces: Added.
* platform/chromium-win/media/track/opera/interfaces/HTMLElement: Added.
* platform/chromium-win/media/track/opera/interfaces/HTMLElement/HTMLMediaElement: Added.
* platform/chromium-win/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Added.
* platform/chromium-win/media/track/opera/interfaces/TextTrack: Added.
* platform/chromium-win/media/track/opera/interfaces/TextTrack/kind-expected.txt: Added.
* platform/efl-wk1/compositing/iframes: Added.
* platform/efl-wk1/compositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/efl-wk1/compositing/reflections/reflection-in-composited-expected.png: Added.
* platform/efl-wk1/compositing/repaint/newly-composited-on-scroll-expected.png: Added.
* platform/efl/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
* platform/efl/compositing/reflections/reflection-in-composited-expected.png: Removed.
* platform/efl/compositing/repaint/newly-composited-on-scroll-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRedrawing issue with inserting new inline element between existing inline elements
robert@webkit.org [Tue, 4 Dec 2012 16:58:07 +0000 (16:58 +0000)]
Redrawing issue with inserting new inline element between existing inline elements
https://bugs.webkit.org/show_bug.cgi?id=50315

Reviewed by Levi Weintraub.

Source/WebCore:

When inserting an element such as '<span>text<br></span>' between two lineboxes, the second of which has leading space
collapsed away after a line-break, dirtyLinesFromChangeChild() needs to ensure that the linebox the fragment is inserted into (the second
of the two lineboxes) gets dirtied.

Since the element has been inserted before the first element in the linebox, but after the collapsed leading
space, the search for the new element's linebox will go past the leading space to the previous linebox and select that
one by mistake.

So in order to ensure the element's linebox is dirtied make sure its previous sibling is not the line-break object of the
linebox we selected when searching for a linebox to dirty. If the previous sibling is the linebox's line-break object then
the element is in the one after the one we selected and we should dirty that linebox too.

Test: fast/inline/layout-after-inserting-nested-br.html

* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

LayoutTests:

* fast/inline/layout-after-inserting-nested-br-expected.html: Added.
* fast/inline/layout-after-inserting-nested-br.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove assert and fix conditional for out of bounds requests in InputHan...
mifenton@rim.com [Tue, 4 Dec 2012 16:53:42 +0000 (16:53 +0000)]
[BlackBerry] Remove assert and fix conditional for out of bounds requests in InputHandler::spannableTextInRange
https://bugs.webkit.org/show_bug.cgi?id=104001

Reviewed by Rob Buis.

PR 257723.

Remove assert and update early return to allow out of bounds
request at end of field.

Reviewed Internally by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spannableTextInRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGut WebRenderingStats since we no longer use its member variables.
commit-queue@webkit.org [Tue, 4 Dec 2012 16:52:01 +0000 (16:52 +0000)]
Gut WebRenderingStats since we no longer use its member variables.
https://bugs.webkit.org/show_bug.cgi?id=103460

Patch by Glenn Hartmann <hartmanng@chromium.org> on 2012-12-04
Reviewed by Darin Fisher.

This was used as an intermediate location to move stats from
chromium's RenderStats. The chromium code has been updated to
remove this dependency (see https://codereview.chromium.org/11364221/).

* chromium/public/WebRenderingStats.h:
(WebKit::WebRenderingStats::WebRenderingStats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
peter@chromium.org [Tue, 4 Dec 2012 16:25:22 +0000 (16:25 +0000)]
[Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
https://bugs.webkit.org/show_bug.cgi?id=103758

Reviewed by Eric Seidel.

Lazily initialize the adb command parameters rather than initializing it in the
constructor now that there is an assert if adb is not available on the system and
we're not in a Chromium Android checkout.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._push_file_if_needed):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver.cmd_line):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._read_prompt):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver._adb_command):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntSize::scale() should return rounded value
commit-queue@webkit.org [Tue, 4 Dec 2012 15:41:44 +0000 (15:41 +0000)]
IntSize::scale() should return rounded value
https://bugs.webkit.org/show_bug.cgi?id=103984

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-12-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

IntSize::scale() is now rounding float value to the nearest integer instead of blind type casting.

Test: css3/device-adapt/viewport-width-not-affecting-next-page.html

* platform/graphics/IntSize.h:
(WebCore::IntSize::scale):

LayoutTests:

Test css3/device-adapt/viewport-width-not-affecting-next-page.html is not flaky any more.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Turn on the new Skia mask blur algorithm.
schenney@chromium.org [Tue, 4 Dec 2012 15:19:32 +0000 (15:19 +0000)]
[chromium] Turn on the new Skia mask blur algorithm.
https://bugs.webkit.org/show_bug.cgi?id=103906

Unreviewed roll out.

The previous patch was premature and is causing issues rolling skia deps and Chromium deps.

Source/WebKit/chromium:

* skia_webkit.gyp:

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd support for generic types in arrays and sequences to the code generators
adam.bergkvist@ericsson.com [Tue, 4 Dec 2012 14:56:21 +0000 (14:56 +0000)]
Add support for generic types in arrays and sequences to the code generators
https://bugs.webkit.org/show_bug.cgi?id=103642

Reviewed by Kentaro Hara.

Updated the bindings generators to support arrays and sequences of host objects.

- Arrays and sequences of host objects are mapped to Vector<RefPtr<%RefPtrType%> >.
- Fixed issue where "sequence<String>" was used in IDL files instead of "sequence<DOMString>".

Updated existing test results.

* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/mediastream/RTCStatsElement.idl:
* Modules/websockets/WebSocket.idl:
* bindings/js/JSDOMBinding.h:
(WebCore::toRefPtrNativeArray):
(WebCore):
* bindings/scripts/CodeGenerator.pm:
(IsRefPtrType):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(GetNativeType):
(GetNativeVectorInnerType):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateFunctionCallString):
(GetNativeType):
(JSValueToNative):
(CreateCustomSignature):
(NativeToJSValue):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::longLongAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
* bindings/v8/V8Binding.h:
(WebCore::toRefPtrNativeArray):
* testing/Internals.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTextTrack's .kind property should return lower-case values
commit-queue@webkit.org [Tue, 4 Dec 2012 13:38:57 +0000 (13:38 +0000)]
TextTrack's .kind property should return lower-case values
https://bugs.webkit.org/show_bug.cgi?id=103411

Patch by Antoine Quint <graouts@apple.com> on 2012-12-04
Reviewed by Eric Carlson.

Source/WebCore:

While the HTML "kind" attribute on the <track> element allows upper-case values, the related APIs
on HTMLMediaElement and TextTrack expect only to deal with lower-case values. As such, we're updating
TextTrack::isValidKindKeyword() to be case-sensitive and ensure that values fed from the DOM (the values
read from HTML attributes) are lower-case'd.

Thanks to this fix, we're no longer skipping media/track/opera/interfaces/TextTrack/kind.html and
media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack.html

This patch also fixes https://bugs.webkit.org/show_bug.cgi?id=103256.

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute):
(WebCore::HTMLTrackElement::ensureTrack):
* html/track/TextTrack.cpp:
(WebCore::TextTrack::isValidKindKeyword):

LayoutTests:

Stop skipping passing tests.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136498.
commit-queue@webkit.org [Tue, 4 Dec 2012 13:30:08 +0000 (13:30 +0000)]
Unreviewed, rolling out r136498.
http://trac.webkit.org/changeset/136498
https://bugs.webkit.org/show_bug.cgi?id=103992

Patch causes a lot of tests to crash in GTK+ bots (Requested
by KaL on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-04

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperties):
(GenerateHeader):
(GenerateCFile):
(GenerateEventTargetIface):
(WriteData):
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit::core):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_class_init):
(webkit_dom_float64array_init):
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(WebKit::core):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_finalize):
(webkit_dom_test_active_dom_object_class_init):
(webkit_dom_test_active_dom_object_init):
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_class_init):
(webkit_dom_test_callback_init):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
(WebKit::core):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(WebKit::core):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_dispatch_event):
(webkit_dom_test_event_target_add_event_listener):
(webkit_dom_test_event_target_remove_event_listener):
(webkit_dom_test_event_target_finalize):
(webkit_dom_test_event_target_class_init):
(webkit_dom_test_event_target_init):
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):
* bindings/scripts/test/GObject/WebKitDOMTestException.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_finalize):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_init):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
(WebKit::core):
(WebKit::wrapTestMediaQueryListListener):
(webkit_dom_test_media_query_list_listener_finalize):
(webkit_dom_test_media_query_list_listener_class_init):
(webkit_dom_test_media_query_list_listener_init):
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
(WebKit::core):
(WebKit::wrapTestNamedConstructor):
(webkit_dom_test_named_constructor_finalize):
(webkit_dom_test_named_constructor_class_init):
(webkit_dom_test_named_constructor_init):
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::core):
(WebKit::wrapTestNode):
(webkit_dom_test_node_dispatch_event):
(webkit_dom_test_node_add_event_listener):
(webkit_dom_test_node_remove_event_listener):
(webkit_dom_test_node_finalize):
(webkit_dom_test_node_class_init):
(webkit_dom_test_node_init):
* bindings/scripts/test/GObject/WebKitDOMTestNode.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_finalize):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
(WebKit::core):
(WebKit::wrapTestOverloadedConstructors):
(webkit_dom_test_overloaded_constructors_finalize):
(webkit_dom_test_overloaded_constructors_class_init):
(webkit_dom_test_overloaded_constructors_init):
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_finalize):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_init):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add APIs to toggle plug-ins support.
commit-queue@webkit.org [Tue, 4 Dec 2012 13:15:01 +0000 (13:15 +0000)]
[EFL][WK2] Add APIs to toggle plug-ins support.
https://bugs.webkit.org/show_bug.cgi?id=101920

Patch by Yuni Jeong <yhnet.jung@samsung.com> on 2012-12-04
Reviewed by Gyuyoung Kim.

Add setting APIs to toggle plug-ins support and add corresponding API tests.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_plugins_enabled_set):
(ewk_settings_plugins_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Store rendered regions in pixel contents coordinates.
jpetsovits@rim.com [Tue, 4 Dec 2012 13:05:41 +0000 (13:05 +0000)]
[BlackBerry] Store rendered regions in pixel contents coordinates.
https://bugs.webkit.org/show_bug.cgi?id=103930
PR 253496

Reviewed by Rob Buis.
Internally reviewed by Adam Treat.

Previously, the rendered region of a tile used to be
stored in coordinates relative to the tile origin.
This brings no benefits whatsoever and causes a lot
of unnecessary transformations, together with the
potential of incorrectly transforming rendered regions.

By storing the rendered region as what it is,
everything is more compact, easier to understand
and easier to use with other existing functionality.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToTileBuffer):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
(BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
(BlackBerry::WebKit::BackingStorePrivate::isTileVisible):
(BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
(BlackBerry::WebKit::BackingStorePrivate::tileVisibleContentsRect):
(BlackBerry::WebKit::BackingStorePrivate::tileContentsRect):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::mapFromPixelContentsToTiles):
(BlackBerry::WebKit::BackingStorePrivate::transformChanged):
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::surfaceRect):
(BlackBerry::WebKit::TileBuffer::pixelContentsRect):
(WebKit):
(BlackBerry::WebKit::TileBuffer::isRendered):
(BlackBerry::WebKit::TileBuffer::notRenderedRegion):
* WebKitSupport/BackingStoreTile.h:
(TileBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Web Inspector: Viewport console warnings cleanup.
commit-queue@webkit.org [Tue, 4 Dec 2012 12:34:41 +0000 (12:34 +0000)]
Source/WebCore: Web Inspector: Viewport console warnings cleanup.
https://bugs.webkit.org/show_bug.cgi?id=102890

Patch by Markus Heintz <markusheintz@chromium.org> on 2012-12-04
Reviewed by Jochen Eisinger.

Improve the console message text for a viewport console warning and
change the log level to warning.

No new tests added, as this change is covered by updates to existing
test expectations.

* dom/ViewportArguments.cpp:
(WebCore::viewportErrorMessageTemplate):
    Improve the console message text for invalid values.
(WebCore::viewportErrorMessageLevel):
    Upgraded the TruncatedViewportArgumentValueError and the
    TargetDensityDpiUnsupported messages's MessageLeval to warning.
(WebCore::reportViewportWarning):
    Adding only a comment for a FIXIT reminder.

LayoutTests: Web Inspector: Updating test expectations after viewport console warnings cleanup.
https://bugs.webkit.org/show_bug.cgi?id=102890

Patch by Markus Heintz <markusheintz@chromium.org> on 2012-12-04
Reviewed by Jochen Eisinger.

Updating test expectations after improving the console message text
for a viewport console warning and change the log level to warning.

* fast/viewport/viewport-121-expected.txt:
* fast/viewport/viewport-122-expected.txt:
* fast/viewport/viewport-125-expected.txt:
* fast/viewport/viewport-126-expected.txt:
* fast/viewport/viewport-127-expected.txt:
* fast/viewport/viewport-134-expected.txt:
* fast/viewport/viewport-52-expected.txt:
* fast/viewport/viewport-53-expected.txt:
* fast/viewport/viewport-54-expected.txt:
* fast/viewport/viewport-55-expected.txt:
* fast/viewport/viewport-77-expected.txt:
* fast/viewport/viewport-83-expected.txt:
* fast/viewport/viewport-84-expected.txt:
* fast/viewport/viewport-87-expected.txt:
* fast/viewport/viewport-warnings-3-expected.txt:
* fast/viewport/viewport-warnings-5-expected.txt:
* fast/viewport/viewport-warnings-6-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Tue, 4 Dec 2012 11:59:34 +0000 (11:59 +0000)]
Unreviewed, WebKit gardening.

* platform/chromium/TestExpectations:
Update flaky tests' expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Do not override previously set flags of QQuickWebView when enabling drag...
abecsi@webkit.org [Tue, 4 Dec 2012 11:40:15 +0000 (11:40 +0000)]
[Qt][WK2] Do not override previously set flags of QQuickWebView when enabling drag&drop
https://bugs.webkit.org/show_bug.cgi?id=103901

Reviewed by Jocelyn Turcotte.

Setting the specific flag instead of resetting all the flags
when enabling QQuickItem::ItemAcceptsDrops.
This fixes clipping of the contents of QQuickWebView.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Tue, 4 Dec 2012 11:36:33 +0000 (11:36 +0000)]
Unreviewed, WebKit gardening.

* platform/chromium/TestExpectations:
Mark css3/filters/effect-reference-hw.html and
css3/filters/effect-reference-ordering-hw.html as crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Use a private struct and placement new syntax in GObject DOM bindings
carlosgc@webkit.org [Tue, 4 Dec 2012 11:10:35 +0000 (11:10 +0000)]
[GTK] Use a private struct and placement new syntax in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=101074

Reviewed by Xan Lopez.

It allows to use RefPtr for the wrapped object and it simplifies
the code.

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperties):
(GenerateHeader):
(GenerateCFile):
(GenerateEventTargetIface):
(WriteData):
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(_WebKitDOMFloat64ArrayPrivate):
(WebKit::core):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_constructor):
(webkit_dom_float64array_class_init):
(webkit_dom_float64array_init):
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
(_WebKitDOMFloat64Array):
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(_WebKitDOMTestActiveDOMObjectPrivate):
(WebKit::core):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_finalize):
(webkit_dom_test_active_dom_object_constructor):
(webkit_dom_test_active_dom_object_class_init):
(webkit_dom_test_active_dom_object_init):
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
(_WebKitDOMTestActiveDOMObject):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(_WebKitDOMTestCallbackPrivate):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_constructor):
(webkit_dom_test_callback_class_init):
(webkit_dom_test_callback_init):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
(_WebKitDOMTestCallback):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
(_WebKitDOMTestCustomNamedGetterPrivate):
(WebKit::core):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_constructor):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
(_WebKitDOMTestCustomNamedGetter):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(_WebKitDOMTestEventConstructorPrivate):
(WebKit::core):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_constructor):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
(_WebKitDOMTestEventConstructor):
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(_WebKitDOMTestEventTargetPrivate):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_dispatch_event):
(webkit_dom_test_event_target_add_event_listener):
(webkit_dom_test_event_target_remove_event_listener):
(webkit_dom_test_event_target_finalize):
(webkit_dom_test_event_target_constructor):
(webkit_dom_test_event_target_class_init):
(webkit_dom_test_event_target_init):
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
(_WebKitDOMTestEventTarget):
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(_WebKitDOMTestExceptionPrivate):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_constructor):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):
* bindings/scripts/test/GObject/WebKitDOMTestException.h:
(_WebKitDOMTestException):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(_WebKitDOMTestInterfacePrivate):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_finalize):
(webkit_dom_test_interface_constructor):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_init):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
(_WebKitDOMTestInterface):
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
(_WebKitDOMTestMediaQueryListListenerPrivate):
(WebKit::core):
(WebKit::wrapTestMediaQueryListListener):
(webkit_dom_test_media_query_list_listener_finalize):
(webkit_dom_test_media_query_list_listener_constructor):
(webkit_dom_test_media_query_list_listener_class_init):
(webkit_dom_test_media_query_list_listener_init):
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
(_WebKitDOMTestMediaQueryListListener):
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
(_WebKitDOMTestNamedConstructorPrivate):
(WebKit::core):
(WebKit::wrapTestNamedConstructor):
(webkit_dom_test_named_constructor_finalize):
(webkit_dom_test_named_constructor_constructor):
(webkit_dom_test_named_constructor_class_init):
(webkit_dom_test_named_constructor_init):
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
(_WebKitDOMTestNamedConstructor):
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(_WebKitDOMTestNodePrivate):
(WebKit::core):
(WebKit::wrapTestNode):
(webkit_dom_test_node_dispatch_event):
(webkit_dom_test_node_add_event_listener):
(webkit_dom_test_node_remove_event_listener):
(webkit_dom_test_node_finalize):
(webkit_dom_test_node_constructor):
(webkit_dom_test_node_class_init):
(webkit_dom_test_node_init):
* bindings/scripts/test/GObject/WebKitDOMTestNode.h:
(_WebKitDOMTestNode):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(_WebKitDOMTestObjPrivate):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_finalize):
(webkit_dom_test_obj_constructor):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
(_WebKitDOMTestObj):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(_WebKitDOMTestSerializedScriptValueInterfacePrivate):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_finalize):
(webkit_dom_test_serialized_script_value_interface_constructor):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_init):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
(_WebKitDOMTestSerializedScriptValueInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Make leveldb histogram entries more fine-grained
dgrogan@chromium.org [Tue, 4 Dec 2012 11:04:48 +0000 (11:04 +0000)]
IndexedDB: Make leveldb histogram entries more fine-grained
https://bugs.webkit.org/show_bug.cgi?id=103688

Reviewed by Tony Chang.

Allow us better insight into which functions the IO errors originate
from.

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::setUpMetadata):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::getRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::loadCurrentRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 4 Dec 2012 10:49:31 +0000 (10:49 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for the sixth and seventh SVG viewspec tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Yet another unreviewed speculative windows build fix.
pierre.rossi@gmail.com [Tue, 4 Dec 2012 10:33:56 +0000 (10:33 +0000)]
[Qt] Yet another unreviewed speculative windows build fix.

WebKit2 relies on the QWEBKIT_EXPORT macro from WebKit1 as well.

* Api/qwebkitglobal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Avoid unnecessary heap allocations during drag and drop operations
carlosgc@webkit.org [Tue, 4 Dec 2012 10:32:55 +0000 (10:32 +0000)]
[GTK] Avoid unnecessary heap allocations during drag and drop operations
https://bugs.webkit.org/show_bug.cgi?id=87938

Reviewed by Martin Robinson.

Source/WebCore:

* platform/gtk/GtkDragAndDropHelper.cpp:
(WebCore::GtkDragAndDropHelper::handleDragMotion): Return a
pointer to the DataObjectGtk so that the caller can create the
DragData object in the stack.
(WebCore::GtkDragAndDropHelper::handleDragDataReceived): Ditto.
(WebCore::GtkDragAndDropHelper::handleDragDrop): Ditto.
* platform/gtk/GtkDragAndDropHelper.h:

Source/WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_drag_motion): Create DragData for the given
DataObjectGtk in the stack.
(webkit_web_view_drag_data_received): Ditto.
(webkit_web_view_drag_drop): Ditto.

Source/WebKit2:

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDragDataReceived): Create DragData for the given
DataObjectGtk in the stack.
(webkitWebViewBaseDragMotion): Ditto.
(webkitWebViewBaseDragDrop): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Overrides] Add ability to override the page CSS media type
apavlov@chromium.org [Tue, 4 Dec 2012 10:25:44 +0000 (10:25 +0000)]
Web Inspector: [Overrides] Add ability to override the page CSS media type
https://bugs.webkit.org/show_bug.cgi?id=103752

Reviewed by Pavel Feldman.

Source/WebCore:

This change emulates the CSS media types through the instrumentation of FrameView::mediaType().
Even though it already checks the associated FrameLoaderClient::overrideMediaType(), instrumenting
every single platform FrameLoaderClient implementation out there seems wrong.

Test: inspector/styles/media-emulation.html

* English.lproj/localizedStrings.js:
* inspector/Inspector.json: Add Page.setEmulatedMedia().
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::applyEmulatedMediaImpl): Added.
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::applyEmulatedMedia): Added.
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::restore): Restores the media emulation state.
(WebCore::InspectorPageAgent::disable): Resets the media emulation state.
(WebCore::InspectorPageAgent::setEmulatedMedia): Added.
(WebCore::InspectorPageAgent::applyEmulatedMedia): Applies the emulated CSS media if needed.
* inspector/InspectorPageAgent.h:
* inspector/front-end/CSSStyleModel.js: Add the list of media types.
* inspector/front-end/OverridesView.js: Add the CSS media type override UI.
(WebInspector.OverridesView):
(WebInspector.OverridesView.prototype._createMediaEmulationElement): Builds the UI.
(WebInspector.OverridesView.prototype._emulateMediaChanged): Handles the control value changes.
* inspector/front-end/Settings.js: Add the "emulatedCSSMedia" setting.
* page/FrameView.cpp:
(WebCore::FrameView::mediaType):
  Uses InspectorInstrumentation::applyEmulatedMedia() to provide the emulated value.

LayoutTests:

The test invokes PageAgent.setEmulatedMedia() and emits the WebInspector.cssModel.mediaQueryResultChanged() signal.

* inspector/styles/media-emulation-expected.txt: Added.
* inspector/styles/media-emulation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerformanceTests: Dromaeo should report individual test result
rniwa@webkit.org [Tue, 4 Dec 2012 10:00:54 +0000 (10:00 +0000)]
PerformanceTests: Dromaeo should report individual test result
https://bugs.webkit.org/show_bug.cgi?id=99800

Reviewed by Eric Seidel.

Made one small modification to Droameo's webrunner.js so that it reports individual runs/s values
for each subtest. This allows us to compute the aggregated run/s for each iteration like other
performance tests.

Also stop measuring memory usage in Dromaeo tests because some Dromaeo tests (e.g. jslib-modify-jquery)
have unrealistic memory usage, and measuring them at the time of teardown doesn't make much sense.

* Animation/balls.html: Fixed typo: measureValueAync.
* Dromaeo/resources/dromaeo/web/webrunner.js:

* Dromaeo/resources/dromaeorunner.js:
(DRT.setup): Call prepareToMeasureValuesAsync so that DRT.teardown can use meausreValueAsync, and log
"Running 5 times". Since the log container will be inserted before iframe, we need to explicitly insert
the iframe as the first child of the body element to avoid logs from affecting the iframe's position.
Also specify the number of iterations by calling PerfTestRunner.iterationCount() so that we may adjust
the number of iterations in PerfTestRunner.

(DRT.progress): Log individual measurement for each subtest.
(DRT.teardown): Compute the aggregated result for each iteration, and log them using measureValueAsync.

* resources/runner.js:
(PerfTestRunner.logStatistics): Merged printStatistics since it's no longer needed after r131638.
(PerfTestRunner): Removed getAndPrintMemoryStatistics since it was used only in Dromaeo tests but
we no longer measure memory usage in Dromaeo tests.

(start): Increment completedRuns from -1 to 0 for Dromaeo tests where we don't want to ignore the initial
measurement. Note that ignoreWarmUpAndLog ignores the measurements for which completedRuns is negative.

(ignoreWarmUpAndLog): We don't measure memory usage in Dromaeo tests. See above.
(PerfTestRunner.iterationCount): Added. This abstraction allows us to auto-adjust the number of iterations from
run-perf-tests in near future.
(PerfTestRunner.measureValueAsync): Renamed from measureValueAync.

Tools: Dromaeo should report individual test result
https://bugs.webkit.org/show_bug.cgi?id=99800

Reviewed by Eric Seidel.

Ignore subtest results spit out by Dromaeo tests.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest): Added a line to ignore.
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output_with_subtests): Added.

LayoutTests: Fix a test and re-enable fast/harness/perftests on Chromium.

* fast/harness/perftests/runs-per-second-log.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Simplify GObject DOM bindings code for handling properties
carlosgc@webkit.org [Tue, 4 Dec 2012 09:42:07 +0000 (09:42 +0000)]
[GTK] Simplify GObject DOM bindings code for handling properties
https://bugs.webkit.org/show_bug.cgi?id=101072

Reviewed by Xan Lopez.

Do not override GObjectClass::set_property if the wrapped object
doesn't have writable properties, and don't override
GObjectClass::get_property if the wrapped object doesn't have
properties at all. It reduces some GObject boilerplate in
generated code for some objects.

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperties):
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(webkit_dom_float64array_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(webkit_dom_test_active_dom_object_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(webkit_dom_test_callback_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
(webkit_dom_test_custom_named_getter_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(webkit_dom_test_event_constructor_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(webkit_dom_test_exception_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
(webkit_dom_test_media_query_list_listener_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
(webkit_dom_test_named_constructor_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(webkit_dom_test_node_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined run-bindings-tests.
haraken@chromium.org [Tue, 4 Dec 2012 09:35:04 +0000 (09:35 +0000)]
Unreviewed. Rebaselined run-bindings-tests.

* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNode::visitChildren):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Tue, 4 Dec 2012 09:33:22 +0000 (09:33 +0000)]
Unreviewed, WebKit gardening.

* platform/chromium/TestExpectations:
Updated about 200 tests' expectations, because the tests were
reported as "expected to XXX, but YYY".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [REGRESSION] [Styles] Rule disappears if edited selector does not...
apavlov@chromium.org [Tue, 4 Dec 2012 09:18:20 +0000 (09:18 +0000)]
Web Inspector: [REGRESSION] [Styles] Rule disappears if edited selector does not affect selected node
https://bugs.webkit.org/show_bug.cgi?id=103059

Reviewed by Pavel Feldman.

Source/WebCore:

This change effectively turns WebInspector.cssModel.setRuleSelector() into a _userOperation
(in terms of StylesSidebarPane), which finishes upon the _finishOperationAndMoveEditor() invocation.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule): Fix selectorText now that r136370 has landed.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.update): Update the selector text from the model.
(WebInspector.StylePropertiesSection.prototype._markSelectorMatches): Set the "selector" className regardless of the matched selectors presence.
(WebInspector.StylePropertiesSection.prototype.successCallback): Make use of the _userOperation flag.
(WebInspector.StylePropertiesSection.prototype.finishOperationAndMoveEditor): Delete the _userOperation flag.
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): Make use of the _userOperation flag.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): Mark selector matches.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled): Delete the _userOperation flag.

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):
  Add dumping of the [no-affect] flag for rules not affecting the currently selected element.
* inspector/styles/commit-selector-expected.txt: Rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender...
commit-queue@webkit.org [Tue, 4 Dec 2012 09:12:00 +0000 (09:12 +0000)]
[EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found.
https://bugs.webkit.org/show_bug.cgi?id=103710.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-04
Reviewed by Kenneth Rohde Christiansen.

When using GLX back-end we are dependent on GLX support, Xcomposite and Xrender extensions.
In this case, GraphicsSurface usage depends on Xcomposite and Xrender extensions.
USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found.

.:

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

* platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createTransportSurface):
* platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore):
* platform/graphics/surfaces/glx/GLXSurface.h:
(WebCore::SharedX11Resources::createConfig):
(SharedX11Resources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136487 268f45cc-cd09-0410-ab3c-d52691b4dbfc