WebKit-https.git
6 years agoTextureUnit code optimization
commit-queue@webkit.org [Wed, 3 Jul 2013 12:59:55 +0000 (12:59 +0000)]
TextureUnit code optimization
https://bugs.webkit.org/show_bug.cgi?id=117868

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-07-03
Reviewed by Noam Rosenthal.

According to OpenGL ES 2.0 specification it is not possible to use both
texture2D and textureCubeMap in one texture unit.
This patch reduces amount of code, slightly increases rendering performance
and makes WebKit more consistent with OpenGL.

No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/textures/tex-image-webgl.html
LayoutTests/webgl/conformance/textures/texture-complete.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
* html/canvas/WebGLRenderingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop inheriting SVGFilterPrimitiveStandardAttributes in SVG
ch.dumez@sisa.samsung.com [Wed, 3 Jul 2013 10:50:17 +0000 (10:50 +0000)]
Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG
https://bugs.webkit.org/show_bug.cgi?id=118305

Reviewed by Kentaro Hara.

Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG and use
Web IDL implements instead to get rid of multiple inheritance and
follow the latest specification:
- http://www.w3.org/TR/filter-effects/#DOMInterfaces

No new tests, no behavior change.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.list.am:
* svg/SVGFEBlendElement.idl:
* svg/SVGFEColorMatrixElement.idl:
* svg/SVGFEComponentTransferElement.idl:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* svg/SVGFEDiffuseLightingElement.idl:
* svg/SVGFEDisplacementMapElement.idl:
* svg/SVGFEDropShadowElement.idl:
* svg/SVGFEFloodElement.idl:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEImageElement.idl:
* svg/SVGFEMergeElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFEOffsetElement.idl:
* svg/SVGFESpecularLightingElement.idl:
* svg/SVGFETileElement.idl:
* svg/SVGFETurbulenceElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix cast-align warnings in FastMalloc.cpp
ossy@webkit.org [Wed, 3 Jul 2013 10:19:14 +0000 (10:19 +0000)]
Fix cast-align warnings in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=117991

Reviewed by Mark Hahnenberg.

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoH&R Block 2010 Help window can not be reopened.
commit-queue@webkit.org [Wed, 3 Jul 2013 10:13:34 +0000 (10:13 +0000)]
H&R Block 2010 Help window can not be reopened.
https://bugs.webkit.org/show_bug.cgi?id=118342

Patch by Zalan Bujtas <zalan@apple.com> on 2013-07-03
Reviewed by Antti Koivisto.

http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
only the opener can (re)focus() a particular window.
H&R Block app relies on the relaxed window.focus() rules.

Source/WebCore:

* WebCore.exp.in:
* platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsHRBlock):
* platform/RuntimeApplicationChecks.h:

Source/WebKit/mac:

* WebView/WebView.mm:
(shouldRestrictWindowFocus):
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFurther build fixing for build configurations that disable CSS regions support.
zandobersek@gmail.com [Wed, 3 Jul 2013 10:06:14 +0000 (10:06 +0000)]
Further build fixing for build configurations that disable CSS regions support.

* dom/PseudoElement.h: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r152320 and r152345 for build configurations that enable
zandobersek@gmail.com [Wed, 3 Jul 2013 10:00:59 +0000 (10:00 +0000)]
Unreviewed build fix after r152320 and r152345 for build configurations that enable
SVG support but disable CSS regions support.

* svg/SVGElement.cpp: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
* svg/SVGElement.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Improve implementation of elements in region being flowed to another...
ossy@webkit.org [Wed, 3 Jul 2013 09:02:43 +0000 (09:02 +0000)]
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300

Based on patch by Zoltán Árvai <zarvai@inf.u-szeged.hu>

Patch by Radu Stavila <stavila@adobe.com> on 2013-07-03
Reviewed by Csaba Osztrogonác.

Fixed CSS_REGIONS guard.

* dom/Element.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Migrate WebKitWebContext to GTask
carlosgc@webkit.org [Wed, 3 Jul 2013 08:43:41 +0000 (08:43 +0000)]
[GTK] Migrate WebKitWebContext to GTask
https://bugs.webkit.org/show_bug.cgi?id=117153

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetPluginThread):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove SVGTests attributes parsing to SVGGraphicsElement
ch.dumez@sisa.samsung.com [Wed, 3 Jul 2013 08:03:53 +0000 (08:03 +0000)]
Move SVGTests attributes parsing to SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118292

Reviewed by Darin Adler.

Move SVGTests attributes parsing to SVGGraphicsElement instead of doing
this in each of its subclasses. SVGGraphicsElement is now the one
subclassing SVGTests after r152167.

No new tests, no behavior change.

* svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
(WebCore::SVGAElement::parseAttribute):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
(WebCore::SVGClipPathElement::parseAttribute):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
* svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged): Fall back to calling
SVGGraphicsElement::svgAttributeChanged() instead of
SVGStyledElement::svgAttributeChanged() as SVGGraphicsElement is the
parent class and it takes care of parsing SVGTests attributes now.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skipping test to paint the debug bot green.
zarvai@inf.u-szeged.hu [Wed, 3 Jul 2013 07:44:23 +0000 (07:44 +0000)]
[Qt] Unreviewed gardening. Skipping test to paint the debug bot green.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-03

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Let F5 refresh the page in MiniBrowser
commit-queue@webkit.org [Wed, 3 Jul 2013 07:30:29 +0000 (07:30 +0000)]
[GTK] Let F5 refresh the page in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=117638

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-07-03
Reviewed by Carlos Garcia Campos.

Also use the correct icon for the refresh button that was already there.

* MiniBrowser/gtk/BrowserWindow.c:
(browser_window_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination...
zandobersek@gmail.com [Wed, 3 Jul 2013 05:54:31 +0000 (05:54 +0000)]
[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
https://bugs.webkit.org/show_bug.cgi?id=118280

Reviewed by Darin Adler.

Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModernize QualifiedName by wrapping gNameCache in a function and using more early...
rniwa@webkit.org [Wed, 3 Jul 2013 05:07:45 +0000 (05:07 +0000)]
Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299

Reviewed by Andreas Kling.

Did cleanups.

* dom/QualifiedName.cpp:
(WebCore::qualifiedNameCache): Added to wrap gNameCache.
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::QualifiedNameImpl::~QualifiedNameImpl):
(WebCore::QualifiedName::toString): Use early exit and StringBuilder.
(WebCore::QualifiedName::init): Use early exit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
simon.fraser@apple.com [Wed, 3 Jul 2013 03:19:06 +0000 (03:19 +0000)]
Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=118337

Reviewed by Benjamin Poulain.

-webkit-overflow-scrolling: touch is an inherited property that, on iOS, controls
the behavior of overflow scrolling content, and causes overflow scrolling elements
to become CSS stacking contexts.

However, the code was too aggressive in setting style->setZIndex(0), doing so
for any element with overflow != hidden. Since the default for overflow is visible,
that meant almost every element.

Previously, this didn't really matter. However, since r125693, any renderer with non-auto
z-index gets a RenderLayer, and that RenderLayer will become a stacking context. The result
was too many RenderLayers and incorrect stacking context behavior.

Fix by ensuring that -webkit-overflow-scrolling: touch  only affects elements which
are actually scrollable.

Also move the code that does this to below the code that adjust overflow style
for different elements.

* css/StyleResolver.cpp:
(WebCore::isScrollableOverflow):
(WebCore::StyleResolver::adjustRenderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@152334 268f45cc-cd09-0410...
kalyan.kondapally@intel.com [Wed, 3 Jul 2013 02:45:27 +0000 (02:45 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152318.
commit-queue@webkit.org [Wed, 3 Jul 2013 00:48:43 +0000 (00:48 +0000)]
Unreviewed, rolling out r152318.
http://trac.webkit.org/changeset/152318
https://bugs.webkit.org/show_bug.cgi?id=118333

This patch broke media/track/track-automatic-subtitles.html on
Mac (Requested by dfarler on #webkit).

Source/WebCore:

* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore):

LayoutTests:

* media/track/track-legacyapi-with-automatic-mode-expected.txt: Removed.
* media/track/track-legacyapi-with-automatic-mode.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Adding myself to contributors.json.
dfarler@apple.com [Wed, 3 Jul 2013 00:32:26 +0000 (00:32 +0000)]
Unreviewed. Adding myself to contributors.json.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange event should not be dispatched by clicking a scrollbar of select listbox
commit-queue@webkit.org [Wed, 3 Jul 2013 00:20:03 +0000 (00:20 +0000)]
Change event should not be dispatched by clicking a scrollbar of select listbox
https://bugs.webkit.org/show_bug.cgi?id=118019
<rdar://problem/14297760>

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-02
Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/forms/select/listbox-click-on-scrollbar.html

Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f

Previously, a select element with the multiple attribute would dispatch
an onChanged event when the scrollbar is clicked. This patch corrects this
issue by only calling listBoxOnChange(), which fires the onChanged event,
when an actual option is clicked.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged): Updated to clear the list
of selected items when when an <option> element is added to/deleted from its <select> element.
(Without this addition, if a option was selected, and then JavaScript was used to modify
the <select> element, and then the scrollbar was clicked, an onChanged event would fire
because it remembers the previously selected option.)

(WebCore::HTMLSelectElement::listBoxOnChange):

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updated to
only call listBoxOnChange() if at least one option is selected.

LayoutTests:

Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f

* fast/forms/select/listbox-click-on-scrollbar-expected.txt: Added.
* fast/forms/select/listbox-click-on-scrollbar.html: Added.
Tests that an onChange() event is not fired when the scrollbar of a
<select multiple> element is clicked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPreparing Windows WebGL build system.
achristensen@apple.com [Wed, 3 Jul 2013 00:18:39 +0000 (00:18 +0000)]
Preparing Windows WebGL build system.
https://bugs.webkit.org/show_bug.cgi?id=118325

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.vcxproj: Added EGL files, removed unused GraphicsContext3DOpenGL.cpp.
* WebCore.vcxproj/WebCore.vcxproj.filters: Added EGL filter and files, removed unused GraphicsContext3DOpenGL.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe callback for WKPageGetPlugInInformation needs info about whether or not there...
jberlin@webkit.org [Wed, 3 Jul 2013 00:06:13 +0000 (00:06 +0000)]
The callback for WKPageGetPlugInInformation needs info about whether or not there are any
non-playing instances of the plug-in on the page
https://bugs.webkit.org/show_bug.cgi?id=118330

Reviewed by Anders Carlsson.

Source/WebCore:

* WebCore.exp.in:
Expose a symbol so it can be used in WebKit2.

Source/WebKit2:

Add another key value pair to the dictionary passed to the callback.

* Shared/API/c/WKPluginInformation.cpp:
(WKPlugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
* Shared/API/c/WKPluginInformation.h:

* Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
(WebKit::createPlugInInformationDictionary):
Add the information about whether or not the page contains a non-playing instance of that
plug-in to the plug-in information dictionary.
* Shared/Plugins/Netscape/PluginInformation.h:

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::containsPlugInCallback):
Check if any of the MIME types of the plug-in instances that are present on the page but are
not playing match the instance of plug-in being searched for.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::addPlugInMimeTypesFromNodeListForNonPlayingPlugIns):
Based roughly off of addPlugInsFromNodeListMatchingPlugInOrigin in
HTMLPlugInImageElement.cpp.
(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
Based roughly off of HTMLPlugInImageElement::restartSimilarPlugIns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded getProcAddress implementation for Windows in OpenGLShims.
achristensen@apple.com [Tue, 2 Jul 2013 22:18:37 +0000 (22:18 +0000)]
Added getProcAddress implementation for Windows in OpenGLShims.
https://bugs.webkit.org/show_bug.cgi?id=118312

Reviewed by Brent Fulgham.

* platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress): Added for Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agomedia/unsupported-rtsp.html is failing
jer.noble@apple.com [Tue, 2 Jul 2013 22:12:18 +0000 (22:12 +0000)]
media/unsupported-rtsp.html is failing
https://bugs.webkit.org/show_bug.cgi?id=118327

Reviewed by Eric Carlson.

Fixes the media/unsupported-rtsp.html test.

Set the contentType field of contentInformationRequest in order to trigger AVFoundation to
notice that loading failed and generate an error.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed compile error in non-X11 platforms using EGL.
achristensen@apple.com [Tue, 2 Jul 2013 21:58:50 +0000 (21:58 +0000)]
Fixed compile error in non-X11 platforms using EGL.
https://bugs.webkit.org/show_bug.cgi?id=118323

Reviewed by Brent Fulgham.

* platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createPixmapContext): Put all X11-specific code into #if PLATFORM(X11).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed rebaseline of media/video-controls-captions-trackmenu-localized after...
dfarler@apple.com [Tue, 2 Jul 2013 21:45:25 +0000 (21:45 +0000)]
Unreviewed rebaseline of media/video-controls-captions-trackmenu-localized after r151697.

* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
"Unknown SDH" -> "Unknown".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed rebaseline of Mac Lion fast/js/global-constructors-attributes after r151914.
dfarler@apple.com [Tue, 2 Jul 2013 21:24:20 +0000 (21:24 +0000)]
Unreviewed rebaseline of Mac Lion fast/js/global-constructors-attributes after r151914.

* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
WaveTable -> PeriodicWave

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Improve implementation of elements in region being flowed to another...
commit-queue@webkit.org [Tue, 2 Jul 2013 20:43:31 +0000 (20:43 +0000)]
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300

Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by David Hyatt.

Source/WebCore:

Methods that must be const have been turned back into const. Code has been better organized.
Performance is better. Tests have been added to.

* dom/Element.cpp:
(WebCore::Element::detach):
(WebCore::Element::setIsInsideRegion):
(WebCore::Element::isInsideRegion):
(WebCore::Element::shouldMoveToFlowThread):
* dom/Element.h:
* dom/ElementRareData.h:
(WebCore::ElementRareData::isInsideRegion):
(WebCore::ElementRareData::setIsInsideRegion):
(WebCore::ElementRareData::ElementRareData):
* dom/Node.cpp:
(WebCore::Node::isRegisteredWithNamedFlow):
* dom/Node.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
* dom/NodeRenderingContext.h:
* dom/PseudoElement.h:
* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
* dom/Text.h:
* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
* rendering/FlowThreadController.h:
* rendering/RenderObject.h:
* rendering/RenderRegion.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::shouldMoveToFlowThread):
* svg/SVGElement.h:

LayoutTests:

* fast/regions/flow-body-in-html.html:
* fast/regions/region-content-flown-into-region-expected.html:
* fast/regions/region-content-flown-into-region.html:
* fast/regions/universal-selector-children-to-the-same-region.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip cache partitioning tests on Lion.
dfarler@apple.com [Tue, 2 Jul 2013 20:30:22 +0000 (20:30 +0000)]
Skip cache partitioning tests on Lion.

Rubber stamped by Jeffrey Pfau.

* platform/mac-lion/TestExpectations:
http/tests/cache/partitioned-cache.html
http/tests/cache/partitioned-cache-iframe.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
eric.carlson@apple.com [Tue, 2 Jul 2013 20:28:57 +0000 (20:28 +0000)]
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
https://bugs.webkit.org/show_bug.cgi?id=118319

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-legacyapi-with-automatic-mode.html

* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Don't apply "automatic"
    logic when captions were enabled with .webkitClosedCaptionsVisible.

LayoutTests:

* media/track/track-legacyapi-with-automatic-mode-expected.txt: Added.
* media/track/track-legacyapi-with-automatic-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago security/block-test.html fails when NetworkProcess is enabled
ap@apple.com [Tue, 2 Jul 2013 20:07:22 +0000 (20:07 +0000)]
    security/block-test.html fails when NetworkProcess is enabled
        https://bugs.webkit.org/show_bug.cgi?id=118320
        <rdar://problem/14309423>

        Reviewed by Geoff Garen.

        * NetworkProcess/NetworkResourceLoader.cpp:
        (WebKit::NetworkResourceLoader::wasBlocked):
        (WebKit::NetworkResourceLoader::cannotShowURL):
        Implemented missing ResourceHandleClient functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
adachan@apple.com [Tue, 2 Jul 2013 19:51:47 +0000 (19:51 +0000)]
Fix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
https://bugs.webkit.org/show_bug.cgi?id=118268

Reviewed by Beth Dakin.

* WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage): Add some null checks. m_webPage->corePage()
can be null if this method is called after the web page is closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAlways flip the coordinate system before drawing NSViews from Widget::paint
andersca@apple.com [Tue, 2 Jul 2013 19:50:24 +0000 (19:50 +0000)]
Always flip the coordinate system before drawing NSViews from Widget::paint
https://bugs.webkit.org/show_bug.cgi?id=118318
<rdar://problem/13895483>

Reviewed by Beth Dakin.

Undo the change that would not flip on 10.9; turns out the bug was in AppKit. Also remove the
_hasCanDrawSubviewsIntoLayerOrAncestor workaround since drawing works correctly now.

Also, pass flipped:NO when creating the NSGraphicsContext to indicate that the graphics context
is unflipped as far as AppKit knows (since we flipped it earlier).

* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
mhahnenberg@apple.com [Tue, 2 Jul 2013 19:47:53 +0000 (19:47 +0000)]
Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
https://bugs.webkit.org/show_bug.cgi?id=118316

Reviewed by Geoffrey Garen.

This is causing some crashiness in release builds. We should replace it with an ASSERT
until we track down all the places that need fixing in bug 118315.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoempty inlines should not affect line-wrapping
robert@webkit.org [Tue, 2 Jul 2013 19:30:32 +0000 (19:30 +0000)]
empty inlines should not affect line-wrapping
https://bugs.webkit.org/show_bug.cgi?id=25638

Reviewed by David Hyatt.

Source/WebCore:

Don't break on empty inlines if we're in the middle of a word. I took this opportunity to
refactor the series of checks we perform to establish if we can break at the current position.

Test: fast/text/whitespace/inline-whitespace-wrapping-11.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::textBeginsWithBreakablePosition):
(WebCore::canBreakAtThisPosition):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/text/whitespace/inline-whitespace-wrapping-11-expected.html: Added.
* fast/text/whitespace/inline-whitespace-wrapping-11.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement CoordinatedSurface for Threaded Coordinated Graphics
commit-queue@webkit.org [Tue, 2 Jul 2013 19:17:14 +0000 (19:17 +0000)]
Implement CoordinatedSurface for Threaded Coordinated Graphics
https://bugs.webkit.org/show_bug.cgi?id=109661

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-02
Reviewed by Noam Rosenthal.

This is a preparation patch for Threaded Coordianted Graphics.

This patch implements ThreadSafeCoordinatedSurface using ImageBuffer as a
backend. Also, this patch moves common implementation to CoordinatedSurface to
prevent duplication of code.

Source/WebCore:

* platform/graphics/texmap/coordinated/CoordinatedSurface.cpp:
(WebCore::CoordinatedSurface::CoordinatedSurface):
* platform/graphics/texmap/coordinated/CoordinatedSurface.h:
(WebCore::CoordinatedSurface::size):
(WebCore::CoordinatedSurface::flags):
* platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Added.
(WebCore::ThreadSafeCoordinatedSurface::create):
(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::~ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::paintToSurface):
(WebCore::ThreadSafeCoordinatedSurface::copyToTexture):
* platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Added.

Source/WebKit2:

* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoplainText() is O(N^2)
ggaren@apple.com [Tue, 2 Jul 2013 19:09:44 +0000 (19:09 +0000)]
plainText() is O(N^2)
https://bugs.webkit.org/show_bug.cgi?id=118282
<rdar://problem/14284360>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* editing/TextIterator.cpp:
(WebCore::plainText): Linear growth for a vector data type is O(N^2).
Don't do that. Luckily, StringBuilder does the right thing automatically,
so we can just delete code.

Source/WTF:

* wtf/text/StringBuilder.cpp:
(WTF::expandCapacity): Factored out this helper function to simplify
some code that was duplicated in four places.

(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append): Use expandCapacity(). One of the cases
was not doing anything special, and so was O(N^2).

Also, always call expandCapacity() it in a standard way, calling
capacity() first, so it's easy to tell at a glance that you got it right.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoconstrainScrollPositionForOverhang needs to handle scrollOrigin correctly
timothy_horton@apple.com [Tue, 2 Jul 2013 18:14:47 +0000 (18:14 +0000)]
constrainScrollPositionForOverhang needs to handle scrollOrigin correctly
https://bugs.webkit.org/show_bug.cgi?id=118176
<rdar://problem/14301271>

Reviewed by Anders Carlsson.

Test: compositing/geometry/fixed-position-flipped-writing-mode.html

WebCore makes use of constrainScrollPositionForOverhang not only for
constraining fixed- and sticky-positioned elements to the viewport, but
also for clamping the tile cache's visible rect.

Therefore, constrainScrollPositionForOverhang needs to correctly take
the scrollOrigin into account. The easiest way I saw to do this was to
reimplement the function in terms of a pair of rect intersections
between a virtual scrollable "viewport" and the document (with a bit
of complication from headers and footers).

The first intersection is performed, then if the viewport doesn't fit,
it is pushed down and to the right, from the origin. Next, we intersect
again, this time pushing the rect up by the amount it overflowed the document
rect from the bottom right. This performs effectively the same constraint
as previously, but handles the scrollOrigin correctly and is also somewhat
easier to read and understand (with pictures).

* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Subtract the scrollOrigin out of the offset passed to scrollOffsetForFixedPosition,
it's expecting an offset without the origin included.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):
Reimplement the function as described above.

Add a test that ensures that fixed position works with a scrollable document
and direction: rtl, which is one case where scrollOrigin is set.

Disable the test on Mac WebKit1 because of https://bugs.webkit.org/show_bug.cgi?id=118269.

* compositing/geometry/fixed-position-flipped-writing-mode-expected.txt: Added.
* compositing/geometry/fixed-position-flipped-writing-mode.html: Added.
* platform/mac/compositing/geometry/fixed-position-flipped-writing-mode-expected.png: Added.
* platform/mac/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build correction for 'DebugSuffix' target.
bfulgham@apple.com [Tue, 2 Jul 2013 17:53:20 +0000 (17:53 +0000)]
[Windows] Unreviewed build correction for 'DebugSuffix' target.

* JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj: Must pass the
DEBUGSUFFIX definition to the nmake instance to be available during script processing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove SVGStyledLocatableElement class
ch.dumez@sisa.samsung.com [Tue, 2 Jul 2013 17:37:32 +0000 (17:37 +0000)]
Remove SVGStyledLocatableElement class
https://bugs.webkit.org/show_bug.cgi?id=118283

Reviewed by Dirk Schulze.

Remove SVGStyledLocatableElement class and have SVGGraphicsElement
inherit SVGStyledElement directly instead. SVGStyledLocatableElement
is no longer needed and according to the specification, SVGGraphicsElement
should inherit SVGStyledElement (actually SVGElement once we merge
SVGStyledElement into SVGElement).

No new tests, no behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
* svg/SVGAllInOne.cpp:
* svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
* svg/SVGElement.h:
* svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
* svg/SVGGraphicsElement.h:
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
* svg/SVGStyledLocatableElement.cpp: Removed.
* svg/SVGStyledLocatableElement.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Leak: leaks in AccessibilityUIElement
commit-queue@webkit.org [Tue, 2 Jul 2013 16:50:49 +0000 (16:50 +0000)]
[ATK] Leak: leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118297

Fixed memory leak.

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Curl] Crash after download.
commit-queue@webkit.org [Tue, 2 Jul 2013 16:26:03 +0000 (16:26 +0000)]
[Curl] Crash after download.
https://bugs.webkit.org/show_bug.cgi?id=118303

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-02
Reviewed by Brent Fulgham.

We need to make sure that the Curl easy handle is removed from the Curl multi handle before it's freed.

* platform/network/curl/CurlDownload.cpp:
(CurlDownloadManager::updateHandleList): Use addToCurl() and removeFromCurl() methods.
(CurlDownloadManager::addToCurl): Add method to add easy handle to multi handle.
(CurlDownloadManager::removeFromCurl): Add method to remove easy handle from multi handle, and then delete the handle.
(CurlDownloadManager::downloadThread): Use removeFromCurl() method.
(CurlDownload::~CurlDownload):
* platform/network/curl/CurlDownload.h: Avoid deleting Curl easy handle in destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Added new common expectations for test after r151665.
mario@webkit.org [Tue, 2 Jul 2013 16:21:36 +0000 (16:21 +0000)]
Unreviewed gardening. Added new common expectations for test after r151665.

* accessibility/box-styled-lists-expected.txt: Added shared expectation.
* platform/efl/TestExpectations: Removed failure expectation.
* platform/gtk/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix WebKitTestRunner crashes.
bw80.lee@samsung.com [Tue, 2 Jul 2013 16:19:05 +0000 (16:19 +0000)]
Fix WebKitTestRunner crashes.
https://bugs.webkit.org/show_bug.cgi?id=117630

Reviewed by Darin Adler.

Create static function to dump for WebProcess unresponsiveness status,
and use it before calling TestController::runTest().

Accessing TestController::m_currentInvocation before calling
TestController::runTest() can make crash because the invocation
instance will be assigned at the function.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
* WebKitTestRunner/TestInvocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.
mario@webkit.org [Tue, 2 Jul 2013 16:13:53 +0000 (16:13 +0000)]
Unreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.

* accessibility/listitem-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listitem-title-expected.txt.
* platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects...
commit-queue@webkit.org [Tue, 2 Jul 2013 15:00:31 +0000 (15:00 +0000)]
[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects attached
https://bugs.webkit.org/show_bug.cgi?id=118295

Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by Antti Koivisto.

Only the SVGRoot element can be collected in a named flow. As such, no SVG element below the root should
be attached to a RenderBoxRegionInfo object.

A larger patch's test (https://bugs.webkit.org/show_bug.cgi?id=118300) is failing because of this.
This change will be covered by that test.

* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderSVGBlock):
* rendering/svg/RenderSVGBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152233.
commit-queue@webkit.org [Tue, 2 Jul 2013 14:32:45 +0000 (14:32 +0000)]
Unreviewed, rolling out r152233.
http://trac.webkit.org/changeset/152233
https://bugs.webkit.org/show_bug.cgi?id=118304

hopeful attempt to restore windows buildage (Requested by
kling on #webkit).

* win/tools/vsprops/debugsuffix.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Rebaseline background blend mode default test result.
abucur@adobe.com [Tue, 2 Jul 2013 14:04:16 +0000 (14:04 +0000)]
Unreviewed gardening. Rebaseline background blend mode default test result.

* platform/mac/css3/compositing/background-blend-mode-default-value-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agois/toHTMLStyleElement should use Element* for its argument
kangil.han@samsung.com [Tue, 2 Jul 2013 13:48:16 +0000 (13:48 +0000)]
is/toHTMLStyleElement should use Element* for its argument
https://bugs.webkit.org/show_bug.cgi?id=118286

Reviewed by Andreas Kling.

To reduce unnecessary call of isElementNode(), this patch replaces argument
of is/toHTMLStyleElement from Node* to Element*. Plus, use Element::hasTagName
in collectActiveStyleSheets function for minor code refactoring since
its cost is cheaper than Node::hasTagName.

* css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
* dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
* html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid code duplication inside String::append()
mikhail.pozdnyakov@intel.com [Tue, 2 Jul 2013 13:36:09 +0000 (13:36 +0000)]
Avoid code duplication inside String::append()
https://bugs.webkit.org/show_bug.cgi?id=118290

Reviewed by Anders Carlsson.

The implementation of 'append(UChar)' had been repeated inside 'append(LChar)',
this duplication is obviated now.

* wtf/text/WTFString.cpp:
(WTF::String::appendInternal):
(WTF::String::append):
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip fast/dom/timer-throttling-hidden-page.html after r152202.
akling@apple.com [Tue, 2 Jul 2013 13:31:27 +0000 (13:31 +0000)]
Skip fast/dom/timer-throttling-hidden-page.html after r152202.
<http://webkit.org/b/118301>

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip 3 MathML tests that are failing after r152235.
akling@apple.com [Tue, 2 Jul 2013 12:53:57 +0000 (12:53 +0000)]
Skip 3 MathML tests that are failing after r152235.
<http://webkit.org/b/118298>

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnexpose EditingPropertiesToInclude in EditingStyle.h after r151772
rniwa@webkit.org [Tue, 2 Jul 2013 12:20:22 +0000 (12:20 +0000)]
Unexpose EditingPropertiesToInclude in EditingStyle.h after r151772
https://bugs.webkit.org/show_bug.cgi?id=118271

Reviewed by Andreas Kling.

Don't expose EditingPropertiesToInclude in EditingStyle.h and do other cleanups as described below.

No new tests since there should be no behavioral change.

* editing/EditingStyle.cpp:
(WebCore::copyEditingProperties): Use newly defined numAllEditingProperties and numInheritableEditingProperties
instead of a magic number of 2.
(WebCore::copyPropertiesFromComputedStyle): Renamed from editingStyleFromComputedStyle. It now takes ComputedStyleExtractor and
PropertiesToInclude instead of Node* and EditingPropertiesToInclude and handles AllProperties. Also added a helper that takes Node*.
(WebCore::EditingStyle::init): Calls copyPropertiesFromComputedStyle. Unfortunately, we need to special-case EditingPropertiesInEffect
and not set background-color and text-decoration. This is required probably due to a bug elsewhere.
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::extractEditingProperties): Renamed from EditingStyle::removeAllButEditingProperties; takes PropertiesToInclude instead of
EditingPropertiesToInclude since the only caller of this function, EditingStyle::mergeInlineAndImplicitStyleOfElement, was converting
the type.
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
* editing/EditingStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce toSVGInlineTextBox
gyuyoung.kim@samsung.com [Tue, 2 Jul 2013 11:56:29 +0000 (11:56 +0000)]
Introduce toSVGInlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=118289

Reviewed by Andreas Kling.

As a step to change static_cast with toXXX, static_cast<SVGInlineTextBox*> can
be changed with toSVGInlineTextBox().

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153345

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paintSelectionBackground):
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
* rendering/svg/SVGInlineTextBox.h:
(WebCore::toSVGInlineTextBox):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBoxes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify SVGTextContentElement::elementFromRenderer()
ch.dumez@sisa.samsung.com [Tue, 2 Jul 2013 11:50:24 +0000 (11:50 +0000)]
Simplify SVGTextContentElement::elementFromRenderer()
https://bugs.webkit.org/show_bug.cgi?id=118284

Reviewed by Andreas Kling.

Simplify SVGTextContentElement::elementFromRenderer() by leveraging
SVGElement::isTextContent() methods instead of explicitly checking
for tag names.

No new tests, no behavior change.

* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::elementFromRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix cast-align warnings in WebCore/platform/graphics/texmap/TextureMapperGL.cpp
ossy@webkit.org [Tue, 2 Jul 2013 11:19:04 +0000 (11:19 +0000)]
Fix cast-align warnings in WebCore/platform/graphics/texmap/TextureMapperGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=118249

Reviewed by Allan Sandfeld Jensen.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK1] Support WebGL with EGL on Linux
allan.jensen@digia.com [Tue, 2 Jul 2013 11:04:48 +0000 (11:04 +0000)]
[Qt][WK1] Support WebGL with EGL on Linux
https://bugs.webkit.org/show_bug.cgi?id=118251

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Let GraphicsContext3D work without a GraphicsSurface.

* Target.pri:
* platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

Tools:

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
commit-queue@webkit.org [Tue, 2 Jul 2013 07:43:19 +0000 (07:43 +0000)]
[CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
https://bugs.webkit.org/show_bug.cgi?id=118057

Patch by Catalin Badea <badea@adobe.com> on 2013-07-02
Reviewed by David Hyatt.

Source/WebCore:

Remove the use of overrideLogicalContentHeight() from regions and
use a local variable instead. The change was needed to avoid
overlapping with flexbox containers.

Test: fast/regions/autoheight-flexbox.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::applyBreakAfterContent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::computedAutoHeight):
(WebCore::RenderRegion::setComputedAutoHeight):
(WebCore::RenderRegion::clearComputedAutoHeight):
(WebCore::RenderRegion::hasComputedAutoHeight):
* rendering/RenderView.cpp:

LayoutTests:

Add test for auto-height regions and flexbox containers.

* fast/regions/autoheight-flexbox-expected.html: Added.
* fast/regions/autoheight-flexbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[JSC]: Fix maybe-uninitialized gcc 4.8 warning in DFGSpeculativeJIT.cpp
commit-queue@webkit.org [Tue, 2 Jul 2013 06:03:12 +0000 (06:03 +0000)]
[JSC]: Fix maybe-uninitialized gcc 4.8 warning in DFGSpeculativeJIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=118278

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-07-01
Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
Initialize valueGPR with InvalidGPRReg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
commit-queue@webkit.org [Tue, 2 Jul 2013 02:00:40 +0000 (02:00 +0000)]
[Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=118267

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-01
Reviewed by Gyuyoung Kim.

After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.

* efl/jhbuildrc:
* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWindows should be included in the list of platforms that can use OpenGL ES 2.
achristensen@apple.com [Tue, 2 Jul 2013 01:01:42 +0000 (01:01 +0000)]
Windows should be included in the list of platforms that can use OpenGL ES 2.
https://bugs.webkit.org/show_bug.cgi?id=118264

Reviewed by Dean Jackson.

* platform/graphics/GraphicsContext3D.h: Added PLATFORM(WIN) to platforms using OpenGL ES 2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove unsupported AC backends
kov@webkit.org [Tue, 2 Jul 2013 01:00:38 +0000 (01:00 +0000)]
[GTK] Remove unsupported AC backends
https://bugs.webkit.org/show_bug.cgi?id=117362

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-07-01
Reviewed by Martin Robinson.

.:

* Source/autotools/FindDependencies.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
* Source/autotools/ReadCommandLineArguments.m4: remove command line option to select
accelerated backend, it's now auto-detected.
* Source/autotools/SetupAutoconfHeader.m4: no longer defines USE_CLUTTER and
USE_TEXTURE_MAPPER_CAIRO.
* Source/autotools/SetupAutomake.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
* Source/autotools/Versions.m4: no longer check for clutter/clutter-gtk.

Source/WebCore:

* GNUmakefile.am:
* GNUmakefile.list.am:
* Source/WebCore/platform/graphics/PlatformLayer.h: Removed mentions of clutter
and the texmap cairo backend.
* platform/graphics/clutter/DrawingBufferClutter.cpp: Removed.
* platform/graphics/clutter/GraphicsContext3DClutter.cpp: Removed.
* platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Removed.
* platform/graphics/clutter/GraphicsContext3DPrivate.h: Removed.
* platform/graphics/clutter/GraphicsLayerActor.cpp: Removed.
* platform/graphics/clutter/GraphicsLayerActor.h: Removed.
* platform/graphics/clutter/GraphicsLayerClutter.cpp: Removed.
* platform/graphics/clutter/GraphicsLayerClutter.h: Removed.
* platform/graphics/clutter/PlatformClutterAnimation.cpp: Removed.
* platform/graphics/clutter/PlatformClutterAnimation.h: Removed.
* platform/graphics/clutter/PlatformClutterLayerClient.h: Removed.
* platform/graphics/clutter/TransformationMatrixClutter.cpp: Removed.
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: Removed cogl
matrix type conversion.

Source/WebKit/gtk:

* GNUmakefile.am:
* WebCoreSupport/AcceleratedCompositingContext.h: removed clutter and cairo
additions.
* WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Removed.
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Removed.
* webkit/webkitglobals.cpp:
(webkitInit): removed clutter-gtk initialization.

Tools:

* gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
and cogl, so removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Clean up private browsing session tracking
ap@apple.com [Tue, 2 Jul 2013 00:08:56 +0000 (00:08 +0000)]
    Clean up private browsing session tracking
        https://bugs.webkit.org/show_bug.cgi?id=118266
        <rdar://problem/13078036>

        Reviewed by Brady Eidson.

        Instead of counting API calls, we now watch actual WebPreferences objects.

        * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPrivateBrowsingEnabled):
        Removed code that used to notify WebContext. It's now done by WebPreferences.

        * UIProcess/WebContext.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::ensureNetworkProcess): Instead of counting the number of times
        API was called, rely on WebPreferences tracking.
        (WebKit::WebContext::willStartUsingPrivateBrowsing): Ditto. This function is
        now only called when we detect a change in private browsing state.
        (WebKit::WebContext::willStopUsingPrivateBrowsing): Ditto.
        (WebKit::WebContext::createNewWebProcess): Tell the new process to create a private
        browsing session if needed.

        * UIProcess/WebPreferences.h:
        * UIProcess/WebPreferences.cpp:
        (WebKit::WebPreferences::addPageGroup): Count how many page groups use private
        browsing, and notify WebContext when a session is needed. Note that we don't notify
        WebContext about WebPreferences without any page groups, because it's likely
        that preferences will be updated by the client before groups are associated.
        (WebKit::WebPreferences::removePageGroup): Ditto.
        (WebKit::WebPreferences::updateBoolValueForKey): Perform special handling for
        private browsing mode changes.
        (WebKit::WebPreferences::updatePrivateBrowsingValue): Notify WebContext when
        it's time to create or destroy a private browsing session.
        (WebKit::WebPreferences::anyPageGroupsAreUsingPrivateBrowsing): A getter for
        WebContext to know when any page groups are in private browsing mode.

        * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
        Don't create a private browsing session implicitly, UI process takes care of it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDrawingBuffer constructor and destructor were not defined for Windows.
achristensen@apple.com [Mon, 1 Jul 2013 23:21:17 +0000 (23:21 +0000)]
DrawingBuffer constructor and destructor were not defined for Windows.
I moved duplicate code from Cairo and Qt to DrawingBuffer.cpp to be used by Qt, Cairo, and Windows.
https://bugs.webkit.org/show_bug.cgi?id=118262

Reviewed by Dean Jackson.

* platform/graphics/cairo/DrawingBufferCairo.cpp: Removed duplicate DrawingBuffer constructor and destructor.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer): Moved from Cairo and Qt implementation.
* platform/graphics/gpu/qt/DrawingBufferQt.cpp: Removed duplicate DrawingBuffer constructor and destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed unreachable return when GLX or EGL are used with WebGL.
achristensen@apple.com [Mon, 1 Jul 2013 22:44:47 +0000 (22:44 +0000)]
Fixed unreachable return when GLX or EGL are used with WebGL.
https://bugs.webkit.org/show_bug.cgi?id=118263

Reviewed by Noam Rosenthal.

* platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::createOffScreenContext): Fixed unreachable return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLink to WebInspectorUI.framework at build time instead of soft linking.
timothy@apple.com [Mon, 1 Jul 2013 22:23:11 +0000 (22:23 +0000)]
Link to WebInspectorUI.framework at build time instead of soft linking.

https://bugs.webkit.org/show_bug.cgi?id=118261

Reviewed by Joseph Pecoraro.

.:

* Source/Makefile: Build WebInspectorUI before WebKit and WebKit2.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/WebKit.xcconfig:
* WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):

Source/WebKit2:

* Configurations/WebKit2.xcconfig:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):

Tools:

* Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
timothy_horton@apple.com [Mon, 1 Jul 2013 21:47:51 +0000 (21:47 +0000)]
[wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
https://bugs.webkit.org/show_bug.cgi?id=118173
<rdar://problem/14301166>

Reviewed by Anders Carlsson.

Offset the exposed rect passed from the WKView by the main frame's current scroll position
before sending it to our TiledBackings, so that it is in the same coordinate space as their
ordinary visibleRects.

This has the side effect of making clips-to-exposed-rect testable (though useless) in Safari.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add updateScrolledExposedRect() and m_scrolledExposedRect.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Call updateScrolledExposedRect when the main frame scrolls.

(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
Remove a FIXME about this change.
Call updateScrolledExposedRect instead of passing down the unscrolled rect.

(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
Call updateScrolledExposedRect, because that method will short-circuit if
setClipsToExposedRect is false, so we need to update here for correctness
if we get a setExposedRect(), setClipsToExposedRect(true) pair.

(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
Update m_scrolledExposedRect and propagate it to our TiledBackings.

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Use the scrolled exposed rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMaximum scroll position can be negative in some cases
timothy_horton@apple.com [Mon, 1 Jul 2013 21:35:33 +0000 (21:35 +0000)]
Maximum scroll position can be negative in some cases
https://bugs.webkit.org/show_bug.cgi?id=118175
<rdar://problem/14301217>

Reviewed by Anders Carlsson.

Test (API): WebKit2.ResizeReversePaginatedWebView

* page/FrameView.cpp:
(WebCore::FrameView::maximumScrollPosition):
* page/FrameView.h:
Override maximumScrollPosition() in FrameView and don't clamp to zero if
a reverse pagination mode is enabled, as it is possible (and common) to
have a negative maximum scroll position with reverse pagination.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Drive-by adoption of toIntSize().

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
(TestWebKitAPI::didRunJavaScript):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
Add a test that loads a vertical-lr document, paginates it horizontally
from right to left, resizes the view to fit the entire document, and
verifies that the scroll position is negative, as it must be for the
document to be enclosed by the view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoProperly hide the header and footer banners if they are set to null.
adachan@apple.com [Mon, 1 Jul 2013 20:45:17 +0000 (20:45 +0000)]
Properly hide the header and footer banners if they are set to null.
https://bugs.webkit.org/show_bug.cgi?id=118219

Reviewed by Beth Dakin.

Call Page::addFooterWithHeight(0) to remove the parent layer that hosts the banner when
the footer banner is detached. Similarly for the header banner.

* WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved all references to DrawingBuffer methods unused since the removal of Chromium:
achristensen@apple.com [Mon, 1 Jul 2013 19:48:10 +0000 (19:48 +0000)]
Removed all references to DrawingBuffer methods unused since the removal of Chromium:
DrawingBuffer::prepareBackBuffer,
DrawingBuffer::requiresCopyFromBackToFrontBuffer, and
DrawingBuffer::clearPlatformLayer.
https://bugs.webkit.org/show_bug.cgi?id=118257

Reviewed by Darin Adler.

* platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::platformLayer):
* platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build correction.
bfulgham@apple.com [Mon, 1 Jul 2013 19:33:17 +0000 (19:33 +0000)]
[Windows] Unreviewed build correction.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Need to export tag for textarea element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove support for consumable user gestures
jochen@chromium.org [Mon, 1 Jul 2013 19:24:19 +0000 (19:24 +0000)]
Remove support for consumable user gestures
https://bugs.webkit.org/show_bug.cgi?id=118247

Reviewed by Geoffrey Garen.

Source/WebCore:

The features was not enabled on any port, and is meanwhile broken, so we
should delete it.

No new tests, just deleting dead code.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
* dom/UserGestureIndicator.cpp:
(WebCore::isDefinite):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
* dom/UserGestureIndicator.h:
(WebCore::UserGestureIndicator::processingUserGesture):
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
* inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledURLNavigation::didStartTimer):
(WebCore::ScheduledRedirect::fire):
(WebCore::ScheduledRefresh::fire):
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
(WebCore::ScheduledFormSubmission::didStartTimer):
* page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):
* page/DOMTimer.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
* page/EventHandler.h:
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::toggleMediaFullscreenState):
(WebCore::HitTestResult::enterFullscreenForVideo):

Source/WebKit/blackberry:

* WebKitSupport/NotificationManager.cpp:
(BlackBerry::WebKit::NotificationManager::notificationClicked):

Source/WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):

Source/WebKit/qt:

* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::notificationClicked):

Source/WebKit/win:

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):

Source/WebKit2:

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
(WebKit::PluginView::evaluate):
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd screenshot of the inspector color picker for the blog
benjamin@webkit.org [Mon, 1 Jul 2013 18:54:01 +0000 (18:54 +0000)]
Add screenshot of the inspector color picker for the blog

* blog-files/last-week-in-webkit: Added.
* blog-files/last-week-in-webkit/Inspector_color_picker.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Support for mspace element
commit-queue@webkit.org [Mon, 1 Jul 2013 18:41:43 +0000 (18:41 +0000)]
Add Support for mspace element
https://bugs.webkit.org/show_bug.cgi?id=115610

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-01
Reviewed by Chris Fleizach.

Source/WebCore:

This patch adds basic support for the MathML mspace element. This is
important to let people control spacing of mathematical formulas.
Attributes width, height and depth are implemented. For the moment,
only nonnegative width are accepted.

* CMakeLists.txt: add references to the RenderMathMLSpace files.
* GNUmakefile.list.am: ditto.
* Target.pri: ditto.
* WebCore.vcxproj/WebCore.vcxproj: ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* css/mathml.css:
(mtable[columnlines="dashed"] > mtr > mtd + mtd): remove the obsolete linebreaking rule.
* mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createRenderer): map mspaceTag to RenderMathMLSpace.
* mathml/mathattrs.in: add width, height and depth attributes
* mathml/mathtags.in: add mspace element
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::parseMathMLLength): fix int to float conversion.
* rendering/mathml/RenderMathMLBlock.h: declare isRenderMathMLSpace.
(WebCore::RenderMathMLBlock::isRenderMathMLSpace):
* rendering/mathml/RenderMathMLSpace.cpp: Added.
(WebCore::RenderMathMLSpace::RenderMathMLSpace):
(WebCore::RenderMathMLSpace::isChildAllowed):
(WebCore::RenderMathMLSpace::computePreferredLogicalWidths):
(WebCore::RenderMathMLSpace::updateFromElement):
(WebCore::RenderMathMLSpace::updateLogicalWidth):
(WebCore::RenderMathMLSpace::updateLogicalHeight):
(WebCore::RenderMathMLSpace::layout):
(WebCore::RenderMathMLSpace::styleDidChange):
(WebCore::RenderMathMLSpace::firstLineBoxBaseline):
* rendering/mathml/RenderMathMLSpace.h: Added.
(WebCore::RenderMathMLSpace::isRenderMathMLSpace):
(WebCore::RenderMathMLSpace::renderName):
(WebCore::toRenderMathMLSpace):

LayoutTests:

Add a reftest for the mspace element (width, height and depth) and
the parsing of MathML lengths. Import a reftest from Gecko to check
positive namedspace values.

* mathml/presentation/mspace-expected.html: Added.
* mathml/presentation/mspace-units-expected.html: Added.
* mathml/presentation/mspace-units.html: Added.
* mathml/presentation/mspace.html: Added.
* mathml/presentation/positive-namedspace-expected.html: Added.
* mathml/presentation/positive-namedspace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAudio in apps which embed WebViews is corrupted.
jer.noble@apple.com [Mon, 1 Jul 2013 18:40:27 +0000 (18:40 +0000)]
Audio in apps which embed WebViews is corrupted.
https://bugs.webkit.org/show_bug.cgi?id=118163

Reviewed by Maciej Stachowiak.

Source/WebCore:

Add a preference, which defaults to off, which controls whether the
AudioSessionManager will switch to a large audio buffer setting for
power-savings during <video> playback.

* WebCore.exp.in:
* page/Settings.cpp:
(WebCore::Settings::setLowPowerVideoAudioBufferSizeEnabled): Added.  Simple setter.
* page/Settings.h:
(WebCore::Settings::lowPowerVideoAudioBufferSizeEnabled): Added.  Simple getter.
* platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Only set the large audio buffer
    size if lowPowerVideoAudioBufferSize is enabled.

Source/WebKit/mac:

Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit clients.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences lowPowerVideoAudioBufferSizeEnabled]):
(-[WebPreferences setLowPowerVideoAudioBufferSizeEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:

Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit2 clients.

* Shared/WebPreferencesStore.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed correction to DEBUG_ALL target. Target was undefining DEBUG_ALL...
bfulgham@apple.com [Mon, 1 Jul 2013 18:12:31 +0000 (18:12 +0000)]
[Windows] Unreviewed correction to DEBUG_ALL target.  Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
which prevented proper build operation.

* win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL
macros when building with 'debugsuffix' target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Leak: leaks in WebKitAccessibleInterfaceText
commit-queue@webkit.org [Mon, 1 Jul 2013 18:04:34 +0000 (18:04 +0000)]
[ATK] Leak: leaks in WebKitAccessibleInterfaceText
https://bugs.webkit.org/show_bug.cgi?id=118248

Fixed memory leaks.

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-01
Reviewed by Christophe Dumez.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getPangoLayoutForAtk):
(webkitAccessibleTextGetText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's.
roger_fong@apple.com [Mon, 1 Jul 2013 17:53:38 +0000 (17:53 +0000)]
Unreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's.
<rdar://problem/14321403>

* WebCore.vcxproj/WebCore.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWKPageLoadDataWithUserData neglects to set the base URL that is passed in
weinig@apple.com [Mon, 1 Jul 2013 17:45:29 +0000 (17:45 +0000)]
WKPageLoadDataWithUserData neglects to set the base URL that is passed in
<rdar://problem/14306784>
https://bugs.webkit.org/show_bug.cgi?id=118256

Reviewed by Anders Carlsson.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
Pass the baseURL, not blankURL(), and remove an unnecessary multiplication by sizeof(uint8_t) which is always 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Curl] WebDownload init method is not implemented.
commit-queue@webkit.org [Mon, 1 Jul 2013 16:47:45 +0000 (16:47 +0000)]
[Curl] WebDownload init method is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=118241

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.

The WebDownload::init() method called when a normal load is changed to a download
because of a decision by the policy delegate, is not implemented for Curl.

* WebDownloadCurl.cpp:
(WebDownload::init): Implement init() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Crash when scrolling page with images.
commit-queue@webkit.org [Mon, 1 Jul 2013 16:38:05 +0000 (16:38 +0000)]
[Win] Crash when scrolling page with images.
https://bugs.webkit.org/show_bug.cgi?id=117832

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.

Avoid access violation by returning early from method if image frame doesn't have pixel data.

* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::hasPixelData): Added method to check if frame has pixel data.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow): Early return if frame doesn't have pixel data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid calling RenderLayerBacking::resetContentsRect() if possible
commit-queue@webkit.org [Mon, 1 Jul 2013 16:32:07 +0000 (16:32 +0000)]
Avoid calling RenderLayerBacking::resetContentsRect() if possible
https://bugs.webkit.org/show_bug.cgi?id=118217

Patch by Noam Rosenthal <noam@webkit.org> on 2013-07-01
Reviewed by Simon Fraser.

Call resetContentsRect() only if the layer has a contentsLayer.
Otherwise the contentsRect is redundant for the GraphicsLayer.

No new tests - optimization only. This is covered by plenty of existing
tests in webgl/ and compositing/.

* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::hasContentsLayer):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
    Added hasContentsLayer calls for TextureMapper/CoordinatedGraphics

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
commit-queue@webkit.org [Mon, 1 Jul 2013 16:25:21 +0000 (16:25 +0000)]
[EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=117249

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-07-01
Reviewed by Brent Fulgham.

Finish converting all use cases of WEBKITOUTPUTDIR to
WEBKIT_OUTPUTDIR, which seems to be preferred these days.

* DumpRenderTree/efl/FontManagement.cpp:
(getCustomBuildDir):
(getPlatformFontsPath):
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(getOutputDir):
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(usesPerConfigurationBuildDirectory):
* Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
* Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir):
* jhbuild/jhbuildutils.py:
(get_dependencies_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h
ossy@webkit.org [Mon, 1 Jul 2013 15:39:00 +0000 (15:39 +0000)]
Fix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h
https://bugs.webkit.org/show_bug.cgi?id=118242

Reviewed by Mark Hahnenberg.

* heap/HandleBlockInlines.h:
(JSC::HandleBlock::nodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed change of my email address.
rafael.lobo@openbossa.org [Mon, 1 Jul 2013 15:29:02 +0000 (15:29 +0000)]
Unreviewed change of my email address.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUn-break the WebCore ChangeLog after http://trac.webkit.org/changeset/152219.
timothy_horton@apple.com [Mon, 1 Jul 2013 14:36:11 +0000 (14:36 +0000)]
Un-break the WebCore ChangeLog after trac.webkit.org/changeset/152219.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
allan.jensen@digia.com [Mon, 1 Jul 2013 14:29:22 +0000 (14:29 +0000)]
[Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=118244

Reviewed by Noam Rosenthal.

In Qt 5.0 we had to create invisible windows, but in Qt 5.1
we can now create specific offscreen surfaces.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skipping unsupported tests.
kadam@inf.u-szeged.hu [Mon, 1 Jul 2013 13:31:10 +0000 (13:31 +0000)]
[Qt] Unreviewed gardening. Skipping unsupported tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-01

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Remove long unused Qt4 forward definitions
allan.jensen@digia.com [Mon, 1 Jul 2013 13:29:21 +0000 (13:29 +0000)]
[Qt] Remove long unused Qt4 forward definitions

Unreviewed cleanu-up.

* platform/graphics/GraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse DeferrableOneShotTimer for deleting decoded data
antti@apple.com [Mon, 1 Jul 2013 13:27:28 +0000 (13:27 +0000)]
Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150

Reviewed by Andreas Kling.

Adam Barth pointed out that the virtual function for overriding the default delay doesn't work
as expected from base class constructor.

* loader/cache/CachedResource.cpp:
(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::CachedResource):

    Use static function instead of calling a virtual.

* loader/cache/CachedResource.h:
* loader/cache/CachedScript.cpp:
* loader/cache/CachedScript.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt toHTMLTextAreaElement for code cleanup
kangil.han@samsung.com [Mon, 1 Jul 2013 10:43:48 +0000 (10:43 +0000)]
Adopt toHTMLTextAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118226

Reviewed by Andreas Kling.

To enhance readability, this patch adopts toHTMLTextAreaElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::text):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
* html/HTMLTextAreaElement.h:
(WebCore::toHTMLTextAreaElement):
* page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):
(WebCore::RenderTextControlMultiLine::computeControlLogicalHeight):
* testing/Internals.cpp:
(WebCore::Internals::wasLastChangeUserEdit):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textDidChangeInTextArea):

Source/WebKit/win:

* DOMCoreClasses.cpp:
(DOMElement::createInstance):
* DOMHTMLClasses.cpp:
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):

Source/WebKit2:

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textDidChangeInTextArea):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd missing string headers that are used when LOG_DISABLED is 0.
commit-queue@webkit.org [Mon, 1 Jul 2013 08:44:44 +0000 (08:44 +0000)]
Add missing string headers that are used when LOG_DISABLED is 0.
https://bugs.webkit.org/show_bug.cgi?id=118227

Patch by Kwang Yul Seo <skyul@company100.net> on 2013-07-01
Reviewed by Andreas Kling.

Build fix for LOG_DISABLED=0.

No new tests, no behavior change.

* html/track/InbandTextTrack.cpp:
* rendering/RenderLayerCompositor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Use PassOwnPtr for the returned value of createBackingStore
commit-queue@webkit.org [Mon, 1 Jul 2013 08:44:06 +0000 (08:44 +0000)]
[GTK] Use PassOwnPtr for the returned value of createBackingStore
https://bugs.webkit.org/show_bug.cgi?id=118230

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-07-01
Reviewed by Andreas Kling.

It would be better that createBackingStore returns PassOwnPtr instread of OwnPtr
to keep compatibility with c++0x.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::createBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure...
zandobersek@gmail.com [Sun, 30 Jun 2013 17:30:43 +0000 (17:30 +0000)]
Unreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure expectations for other current failures.

* platform/gtk-wk1/TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/editing/selection/user-select-all-image-with-single-click-expected.txt: Added.
* platform/gtk/editing/selection/user-select-all-with-single-click-expected.txt: Added.
* platform/gtk/fast/events/ondragenter-expected.txt: Added.
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid calling into Objective-C every time we get the scrollbar width
simon.fraser@apple.com [Sat, 29 Jun 2013 20:27:08 +0000 (20:27 +0000)]
Avoid calling into Objective-C every time we get the scrollbar width
https://bugs.webkit.org/show_bug.cgi?id=118216

Reviewed by Geoffrey Garen.

Profiling shows that calling Scrollbar::isOverlayScrollbar() is somewhat
expensive, because it calls down into Objective-C. Fix by caching in
ScrollbarThemeMac whether we're using overlay scrollbars. We update this
cache on creation, and when preferences change; ScrollAnimatorMac::updateScrollerStyle()
is the function that gets called when the user changes the setting in System Preferences.

* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::usesOverlayScrollbarsChanged):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::preferencesChanged):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid calling isSimpleContainerCompositingLayer() an extra time
simon.fraser@apple.com [Sat, 29 Jun 2013 20:22:19 +0000 (20:22 +0000)]
Avoid calling isSimpleContainerCompositingLayer() an extra time
https://bugs.webkit.org/show_bug.cgi?id=118218

Reviewed by Tim Horton.

containsPaintedContent() called isSimpleContainerCompositingLayer(), which
is not particularly cheap. But the caller already has this information,
so pass it in.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::containsPaintedContent):
* rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer...
simon.fraser@apple.com [Sat, 29 Jun 2013 20:19:43 +0000 (20:19 +0000)]
Avoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer is this
https://bugs.webkit.org/show_bug.cgi?id=118215

Reviewed by Tim Horton.

When the RenderGeometryMap code path was added, RenderBox::outlineBoundsForRepaint()
actually got slower if no coordinate mapping was needed. So avoid doing work when
we can, including avoiding the FloatQuad construction.

Speeds up scrolling overflow:scroll areas with large numbers of layer children.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLOptGroupElement for code cleanup
kangil.han@samsung.com [Sat, 29 Jun 2013 15:49:55 +0000 (15:49 +0000)]
Adopt is/toHTMLOptGroupElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118213

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLOptGroupElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
* html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
(WebCore::toHTMLOptGroupElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::recalcListItems):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsLabel):

Source/WebKit/blackberry:

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for unguarded SVGGraphicsElement
commit-queue@webkit.org [Sat, 29 Jun 2013 15:15:10 +0000 (15:15 +0000)]
Build fix for unguarded SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118214

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-06-29
Reviewed by Christophe Dumez.

Add the SVG condition to SVGGraphicsElement.idl

No new tests required since no functionality changed.

* svg/SVGGraphicsElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFollow-up to r152206: also update HashFlags8BitBuffer in the LLInt.
akling@apple.com [Sat, 29 Jun 2013 14:59:31 +0000 (14:59 +0000)]
Follow-up to r152206: also update HashFlags8BitBuffer in the LLInt.

* llint/LowLevelInterpreter.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLOptionElement for code cleanup
kangil.han@samsung.com [Sat, 29 Jun 2013 08:18:46 +0000 (08:18 +0000)]
Adopt is/toHTMLOptionElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118212

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLOptionElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setElement):
(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
* html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::index):
* html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
(WebCore::toHTMLOptionElement):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsSelected):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):

Source/WebKit/blackberry:

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
* WebKitSupport/SelectPopupClient.cpp:
(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):

Source/WebKit/win:

* DOMCoreClasses.cpp:
(DOMElement::createInstance):
* DOMHTMLClasses.cpp:
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(151586): multipart/x-mixed-replace images are broken
carlosgc@webkit.org [Sat, 29 Jun 2013 07:25:37 +0000 (07:25 +0000)]
REGRESSION(151586): multipart/x-mixed-replace images are broken
https://bugs.webkit.org/show_bug.cgi?id=118169

Reviewed by Alexey Proskuryakov.

When loading multipart content the resource data will change as
the next part is loaded, so we need to make a copy of the data
before sending it to the resource.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152207 268f45cc-cd09-0410-ab3c-d52691b4dbfc