WebKit-https.git
8 years agoUnreviewed, rolling out r128562.
ossy@webkit.org [Fri, 14 Sep 2012 10:40:40 +0000 (10:40 +0000)]
Unreviewed, rolling out r128562.
http://trac.webkit.org/changeset/128562
https://bugs.webkit.org/show_bug.cgi?id=96747

It broke perf tests on Qt and Chromium (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

* resources/runner.js:
(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add renderTreeAsText API to WebPage
anilsson@rim.com [Fri, 14 Sep 2012 10:22:00 +0000 (10:22 +0000)]
[BlackBerry] Add renderTreeAsText API to WebPage
https://bugs.webkit.org/show_bug.cgi?id=96629

Reviewed by Antonio Gomes.

This will be used for automated testing.

PR #198595

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::renderTreeAsText):
(WebKit):
* Api/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Move globalhistory tests to their correct section in Skipped list
commit-queue@webkit.org [Fri, 14 Sep 2012 10:15:16 +0000 (10:15 +0000)]
[WK2] Move globalhistory tests to their correct section in Skipped list
https://bugs.webkit.org/show_bug.cgi?id=96738

Unreviewed gardening.

Move 2 globalhistory tests to their correct section in WK2
Skipped list.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-14

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: NMI: remove current traits helper class because it is customizing...
loislo@chromium.org [Fri, 14 Sep 2012 10:10:19 +0000 (10:10 +0000)]
Web Inspector: NMI: remove current traits helper class because it is customizing the instrumentation at a wrong place and is not necessary at the moment.
https://bugs.webkit.org/show_bug.cgi?id=96737

Reviewed by Yury Semikhatsky.

* wtf/MemoryInstrumentation.h:
(MemoryInstrumentation):
WTF::MemoryInstrumentationTraits): removed
(WTF::MemoryInstrumentation::OwningTraits::addInstrumentedObject): direct call inserted
(WTF::MemoryInstrumentation::OwningTraits::addObject):direct call inserted

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] multiple fields time input UI should save/restore its value even if it has...
yosin@chromium.org [Fri, 14 Sep 2012 10:09:02 +0000 (10:09 +0000)]
[Forms] multiple fields time input UI should save/restore its value even if it has an empty field.
https://bugs.webkit.org/show_bug.cgi?id=96714

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes multiple fields time input UI to save/restore value
of fields rather than time value. For this change, storage format of
input type "time" is also changed.

Before this patch, if user populates time fiels partially, all fields
are reset to initial value after back/forward navigation.

After this patch, partially populated fields are preserved after
back/forward navigation.

Fields of DateTimeEditElement are represented as 9 elements of
string vector in FormControlState regardless actual fields in
DateTimeEditElement for ease of restoring/saving.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Existing test fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html
convers this change.

* WebCore.gypi: Chagned to add DateTimeFieldsState.{cpp.h}
* html/DateTimeFieldsState.cpp: Added.
(WebCore::getNumberFromFormControlState): Extracts unsigned integer or empty value from FormControlState.
(WebCore::getAMPMFromFormControlState): Extracts AM/PM value or empty value from FormControlState.
(WebCore::DateTimeFieldsState::DateTimeFieldsState): Initializes fields with empty value.
(WebCore::DateTimeFieldsState::restoreFormControlState): Makes DateTimeFieldsState instance from FormControlState.
(WebCore::DateTimeFieldsState::saveFormControlState): Makes FormControlState from DateTimeFieldsState.
* html/DateTimeFieldsState.h: Added.
(DateTimeFieldsState):
(WebCore::DateTimeFieldsState::ampm): Returns AM/PM field value.
(WebCore::DateTimeFieldsState::dayOfMonth): Returns day of month field value.
(WebCore::DateTimeFieldsState::hour): Reutrns hour field value.
(WebCore::DateTimeFieldsState::millisecond): Returns millisecond field value.
(WebCore::DateTimeFieldsState::minute): Returns minute field value.
(WebCore::DateTimeFieldsState::month): Returns month field value.
(WebCore::DateTimeFieldsState::second): Returns second field value.
(WebCore::DateTimeFieldsState::weekOfYear): Returns week of year field.
(WebCore::DateTimeFieldsState::year): Returns year field value.
(WebCore::DateTimeFieldsState::hasAMPM): Returns true if AM/PM field has value.
(WebCore::DateTimeFieldsState::hasDayOfMonth): Returns true if day of month field has value.
(WebCore::DateTimeFieldsState::hasHour): Returns true if hour field has value.
(WebCore::DateTimeFieldsState::hasMillisecond): Returns true if millisecond field has value.
(WebCore::DateTimeFieldsState::hasMinute): Returns true if minute field has value.
(WebCore::DateTimeFieldsState::hasMonth): Returns true if month field has value.
(WebCore::DateTimeFieldsState::hasSecond): Returns true if second field has value.
(WebCore::DateTimeFieldsState::hasWeekOfYear): Returns true if week of year field has value.
(WebCore::DateTimeFieldsState::hasYear): Returns true if year field has value.
(WebCore::DateTimeFieldsState::setAMPM): Sets AM/PM field.
(WebCore::DateTimeFieldsState::setDayOfMonth): Sets day of month field.
(WebCore::DateTimeFieldsState::setHour): Sets hour field.
(WebCore::DateTimeFieldsState::setMillisecond): Sets millisecond field.
(WebCore::DateTimeFieldsState::setMinute): Sets minute field.
(WebCore::DateTimeFieldsState::setMonth): Sets month field.
(WebCore::DateTimeFieldsState::setSecond): Set second field.
(WebCore::DateTimeFieldsState::setWeekOfYear): Sets week of year field.
(WebCore::DateTimeFieldsState::setYear): Sets year field.
* html/FormController.cpp:
(WebCore::formStateSignature): Increment version number to 8 for incompatible change of FormControlState.
* html/TimeInputType.cpp:
(WebCore::TimeInputType::restoreFormControlState): Added to call DateTimeFieldsState::restoreFormControlState().
(WebCore::TimeInputType::saveFormControlState): Added to call DateTimeFieldsState::saveFormControlState().
* html/TimeInputType.h:
(TimeInputType): Added declarations for restoreFormControlState() and saveFormControlState().
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::setValueAsDateTimeFieldsState): Added to set fields from DateTimeFieldsState.
(WebCore::DateTimeEditElement::valueAsDateTimeFieldsState): Added to make DateTimeFieldsState from fields.
* html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Added declarations for setValueAsDateTimeFieldsState() and valueAsDateTimeFieldsState().
* html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Added declarations for populateDateTimeFieldsState() and setValueAsDateTimeFieldsState().
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeAMPMFieldElement::populateDateTimeFieldsState): Added to set AM/PM value to DateTimeFieldsState.
(WebCore::DateTimeAMPMFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): Added to set hour value to DateTimeFieldsState.
(WebCore::DateTimeHourFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeMillisecondFieldElement::populateDateTimeFieldsState): Added to set millisecond value to DateTimeFieldsState.
(WebCore::DateTimeMillisecondFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeMinuteFieldElement::populateDateTimeFieldsState): Added to set minute value to DateTimeFieldsState.
(WebCore::DateTimeMinuteFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeSecondFieldElement::populateDateTimeFieldsState): Added to set second value to DateTimeFieldsState.
(WebCore::DateTimeSecondFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
* html/shadow/DateTimeFieldElements.h:
(DateTimeAMPMFieldElement): Added declarations of populateDateTimeFieldsState() and setValueAsDateTimeFieldsState().
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.
* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Extend accessibility of maximum() and setEmptyValue() to protected.
* html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement): Extend accessibility of hasValue(), setEmptyValue() and valueAsInteger() to protected.

LayoutTests:

This patch changes time-multiple-fields-preserve-value-after-history-back.html
to check partial value is saved and restored rather than resetting value.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updated for new expectation.
* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to check partially populated fields of input element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r128568.
ossy@webkit.org [Fri, 14 Sep 2012 09:37:27 +0000 (09:37 +0000)]
Unreviewed, rolling out r128568.
http://trac.webkit.org/changeset/128568
https://bugs.webkit.org/show_bug.cgi?id=96739

It broke 3 tests everywhere (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::tryGetPropertyAndResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEvas_Object* is a ref'ed structure, so tread it as such
kenneth@webkit.org [Fri, 14 Sep 2012 09:27:28 +0000 (09:27 +0000)]
Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659

Source/WebCore:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

* PlatformEfl.cmake:
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):

Source/WTF:

Reviewed by Gyuyoung Kim.

Remove OwnPtr support for Evas_Object* and add support for it
with RefPtr instead (the latter moved from WebCore).

* wtf/PlatformEfl.cmake:
* wtf/efl/OwnPtrEfl.cpp:
* wtf/efl/RefPtrEfl.cpp: Renamed from Source/WebCore/platform/efl/RefPtrEfl.cpp.
(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* wtf/efl/RefPtrEfl.h: Renamed from Source/WebCore/platform/efl/RefPtrEfl.h.
(WTF):

Tools:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

* DumpRenderTree/efl/ImageDiff.cpp:
(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExtend the coverage of the Custom Allocation Framework in WebCore
zoltan@webkit.org [Fri, 14 Sep 2012 09:12:48 +0000 (09:12 +0000)]
Extend the coverage of the Custom Allocation Framework in WebCore
https://bugs.webkit.org/show_bug.cgi?id=96512

Reviewed by Eric Seidel.

Add WTF_MAKE_FAST_ALLOCATED macro to the following class/struct declarations because these
or their child classes are instantiated by operator new.

Covered by existing tests.

* Modules/websockets/WebSocketDeflateFramer.cpp:
(WebSocketExtensionDeflateFrame):
* Modules/websockets/WebSocketDeflateFramer.h:
(DeflateResultHolder):
(InflateResultHolder):
* Modules/websockets/WebSocketDeflater.h:
(WebSocketDeflater):
(WebSocketInflater):
* Modules/websockets/WebSocketHandshake.h:
(WebSocketHandshake):
* bindings/js/ScriptDebugServer.h:
(Task):
* css/CSSCalculationValue.cpp:
(CSSCalcPrimitiveValue):
* css/CSSParserMode.h:
(CSSParserContext):
* css/CSSValuePool.h:
(CSSValuePool):
* css/StyleBuilder.h:
(StyleBuilder):
* css/StylePropertyShorthand.h:
(StylePropertyShorthand):
* css/StyleResolver.cpp:
(RuleSet):
* css/StyleRule.h:
(StyleRuleBase):
(StyleRule):
* css/StyleRuleImport.h:
(StyleRuleImport):
* css/WebKitCSSKeyframeRule.h:
(StyleKeyframe):
* dom/CheckedRadioButtons.cpp:
(RadioButtonGroup):
* dom/ContextFeatures.h:
(ContextFeaturesClient):
* dom/DOMImplementation.h:
(DOMImplementation):
(XMLMIMETypeRegExp):
* dom/Document.cpp:
(ImmutableAttributeDataCacheKey):
* dom/ElementShadow.h:
(ElementShadow):
* dom/GenericEventQueue.h:
(GenericEventQueue):
* dom/IdTargetObserverRegistry.h:
(IdTargetObserverRegistry):
* dom/NamedNodeMap.h:
(NamedNodeMap):
* dom/ScopedEventQueue.h:
(ScopedEventQueue):
* dom/StyledElement.cpp:
(PresentationAttributeCacheEntry):
(PresentationAttributeCacheCleaner):
* editing/EditingStyle.cpp:
(HTMLElementEquivalent):
* editing/SpellChecker.h:
(SpellChecker):
* fileapi/ThreadableBlobRegistry.cpp:
(BlobRegistryContext):
* html/FormAssociatedElement.cpp:
(FormAttributeTargetObserver):
* html/FormController.h:
(FormController):
* html/HTMLInputElement.cpp:
(ListAttributeTargetObserver):
* html/PublicURLManager.h:
(PublicURLManager):
* html/StepRange.h:
(StepDescription):
* html/ValidationMessage.h:
(ValidationMessage):
* html/canvas/WebGLExtension.h:
(WebGLExtension):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebGLRenderingContextLostCallback):
(WebGLRenderingContextErrorMessageCallback):
* html/parser/HTMLElementStack.h:
(ElementRecord):
* html/parser/HTMLMetaCharsetParser.h:
(HTMLMetaCharsetParser):
* inspector/DOMEditor.h:
(DOMEditor):
* inspector/InjectedScriptHost.h:
(InspectableObject):
* inspector/InjectedScriptManager.h:
(InjectedScriptManager):
* inspector/InspectorCSSAgent.cpp:
(SelectorProfile):
* inspector/InspectorCounters.h:
(ThreadLocalInspectorCounters):
* inspector/InspectorDOMAgent.cpp:
(RevalidateStyleAttributeTask):
* inspector/InspectorFrontendClientLocal.cpp:
(InspectorBackendDispatchTask):
* inspector/InspectorHistory.h:
(InspectorHistory):
(Action):
* inspector/InspectorOverlay.h:
(HighlightConfig):
(InspectorOverlay):
* inspector/InspectorState.h:
(InspectorState):
* inspector/InspectorStyleSheet.cpp:
(ParsedStyleSheet):
* inspector/InspectorWorkerAgent.cpp:
(InspectorWorkerAgent::WorkerFrontendChannel):
* inspector/NetworkResourcesData.h:
(NetworkResourcesData):
(ResourceData):
* inspector/WorkerInspectorController.cpp:
* loader/EmptyClients.h:
(EmptyChromeClient):
* loader/ResourceLoadScheduler.h:
(ResourceLoadScheduler):
(HostInformation):
* loader/icon/IconDatabase.cpp:
(DefaultIconDatabaseClient):
(ClientWorkItem):
* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
* page/ContentSecurityPolicy.h:
(ContentSecurityPolicy):
* page/FrameActionScheduler.h:
(FrameActionScheduler):
* page/MemoryInfo.cpp:
(HeapSizeCache):
* platform/CalculationValue.h:
(CalcExpressionNode):
* platform/Cursor.h:
(Cursor):
* platform/Decimal.h:
(Decimal):
* platform/Length.cpp:
(CalculationValueHandleMap):
* platform/MemoryPressureHandler.h:
(MemoryPressureHandler):
* platform/PlatformKeyboardEvent.h:
(PlatformKeyboardEvent):
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/graphics/GlyphPageTreeNode.h:
(GlyphPageTreeNode):
* platform/graphics/GraphicsContext.h:
(GraphicsContextStateSaver):
* platform/graphics/GraphicsLayer.h:
(AnimationValue):
* platform/graphics/IntRect.h:
(IntRect):
* platform/graphics/ShadowBlur.cpp:
(ScratchBuffer):
* platform/graphics/TextRun.h:
(TextRun):
* platform/graphics/TiledBackingStoreBackend.h:
(TiledBackingStoreBackend):
* platform/graphics/WidthIterator.h:
(WidthIterator):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient):
* platform/graphics/opengl/Extensions3DOpenGL.h:
(Extensions3DOpenGL):
* platform/graphics/texmap/TextureMapper.h:
(TextureMapper):
* platform/graphics/texmap/TextureMapperGL.cpp:
(TextureMapperGLData):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(TextureMapperImageBuffer):
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
* platform/image-decoders/bmp/BMPImageReader.h:
(BMPImageReader):
* platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameReader):
(GIFImageReader):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(JPEGImageReader):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(PNGImageReader):
* platform/network/BlobRegistryImpl.h:
(BlobRegistryImpl):
* platform/network/ResourceResponseBase.h:
(CrossThreadResourceResponseDataBase):
* platform/text/TextCodecICU.h:
(ICUConverterWrapper):
* rendering/FlowThreadController.h:
(FlowThreadController):
* rendering/RenderBoxRegionInfo.h:
(RenderBoxRegionInfo):
* rendering/RenderLayer.h:
(ClipRects):
(ClipRectsCache):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
* rendering/WrapShapeInfo.h:
(WrapShapeInfo):
* rendering/style/NinePieceImage.h:
(NinePieceImageData):
* rendering/svg/RenderSVGResourceFilter.h:
(FilterData):
* rendering/svg/RenderSVGResourceGradient.h:
(GradientData):
* rendering/svg/RenderSVGResourcePattern.h:
(PatternData):
* rendering/svg/SVGResources.h:
(ClipperFilterMaskerData):
(MarkerData):
(FillStrokeData):
* svg/SVGAngle.h:
(SVGAngle):
* svg/SVGLength.h:
(SVGLength):
* svg/SVGPreserveAspectRatio.h:
(SVGPreserveAspectRatio):
* svg/graphics/SVGImageCache.h:
(SVGImageCache):
* svg/properties/SVGPropertyInfo.h:
(SVGPropertyInfo):
* workers/WorkerEventQueue.h:
(WorkerEventQueue):
* xml/parser/MarkupTokenBase.h:
(DoctypeDataBase):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(PendingCallbacks):
(OffsetBuffer):
* xml/parser/XMLToken.h:
(XMLDeclarationData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [WebGL] Refactoring: move the proxy wrapping method up to the base...
commit-queue@webkit.org [Fri, 14 Sep 2012 09:02:07 +0000 (09:02 +0000)]
Web Inspector: [WebGL] Refactoring: move the proxy wrapping method up to the base class
https://bugs.webkit.org/show_bug.cgi?id=96515

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-14
Reviewed by Vsevolod Vlasov.

Move the proxyObject() method up from WebGLRenderingContextResource to the Resource class, so that it could be reused later for wrapping a 2D context.

* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix unused parameter compile warnings in WebCore.
commit-queue@webkit.org [Fri, 14 Sep 2012 08:42:44 +0000 (08:42 +0000)]
Fix unused parameter compile warnings in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=96712

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-14
Reviewed by Ryosuke Niwa.

Fixed unused parameter compile warning messages(-Wunused-parameter) during EFL build.
There are two kinds of stuff related to this warnings.
First one is that the parameter value has not been used anywhere inside the function.
Other one is that usability of parameter value is depended on option, i.e. ACCESSIBILITY.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::postNotification):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setGeolocationOverride):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::registerIntentService):
* page/Frame.cpp:
(WebCore::Frame::layerTreeAsText):
* page/FrameView.cpp:
(WebCore::FrameView::setScrollingPerformanceLoggingEnabled):
* page/efl/EventHandlerEfl.cpp:
(WebCore::EventHandler::tabsToAllFormControls):
(WebCore::EventHandler::passMouseDownEventToWidget):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::scrollLayerForFrameView):
* platform/RuntimeApplicationChecks.cpp:
(WebCore::mainBundleIsEqualTo):
* platform/ScrollView.cpp:
(WebCore::ScrollView::platformSetScrollOrigin):
* platform/cairo/WidgetBackingStoreCairo.cpp:
(WebCore::createSurfaceForBackingStore):
* platform/efl/ContextMenuEfl.cpp:
(WebCore::platformMenuDescription):
* platform/efl/ContextMenuItemEfl.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
* platform/efl/DragDataEfl.cpp:
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
* platform/efl/GamepadsEfl.cpp:
(WebCore::GamepadsEfl::onGamePadChange):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::imageTitle):
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):
* platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::documentFragment):
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::systemFont):
(WebCore::RenderThemeEfl::paintMediaSliderThumb):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeEfl::paintMediaCurrentTime):
* platform/efl/ScrollbarEfl.cpp:
(scrollbarEflEdjeMessage):
* platform/efl/ScrollbarThemeEfl.cpp:
(WebCore::ScrollbarThemeEfl::scrollbarThickness):
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):
* platform/efl/TemporaryLinkStubs.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::setFocus):
(WebCore::Widget::paint):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::orientationAtIndex):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsType):
* platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::drawComplexText):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::adjustFocusRingLineWidth):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::syncContext):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
* platform/graphics/efl/IconEfl.cpp:
(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::gstGWorldSyncMessageCallback):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkMarshalVoidAndMiniObject):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcUriHandlerInit):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
(StreamingClient::didReceiveData):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp:
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzCairoGetTable):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::readColorProfile):
(WebCore::init_source):
(WebCore::fill_input_buffer):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):
* platform/network/soup/CookieStorageSoup.cpp:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
* platform/network/soup/DNSSoup.cpp:
(WebCore::resolvedCallback):
* platform/network/soup/ProxyResolverSoup.cpp:
(soup_proxy_resolver_wk_init):
(soupProxyResolverWkGetProxyURIAsync):
(soupProxyResolverWkGetProxyURISync):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
(WebCore::addFormElementsToSoupMessage):
(WebCore::requestStartedCallback):
(WebCore::closeCallback):
(WebCore::readCallback):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustRepaintRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Tests] Extract a common method for sending XHRs from tests.
vsevik@chromium.org [Fri, 14 Sep 2012 08:36:14 +0000 (08:36 +0000)]
Web Inspector: [Tests] Extract a common method for sending XHRs from tests.
https://bugs.webkit.org/show_bug.cgi?id=96662

Reviewed by Alexander Pavlov.

Extracted InspectorTest.makeXHR() methods to simplify tests.

* http/tests/inspector/appcache/appcache-swap-expected.txt:
* http/tests/inspector/appcache/appcache-swap.html:
* http/tests/inspector/console-xhr-logging-async-expected.txt:
* http/tests/inspector/console-xhr-logging-async.html:
* http/tests/inspector/console-xhr-logging.html:
* http/tests/inspector/network-test.js:
(xhrLoadedCallback):
(initialize_NetworkTest.InspectorTest.makeSimpleXHR):
(initialize_NetworkTest.InspectorTest.makeSimpleXHRWithPayload):
(initialize_NetworkTest.InspectorTest.makeXHR.innerCallback):
(initialize_NetworkTest.InspectorTest.makeXHR):
(doSimpleXHR):
(doSimpleXHRWithPayload):
(doXHR):
(makeXHR):
* http/tests/inspector/network/async-xhr-json-mime-type-expected.txt:
* http/tests/inspector/network/async-xhr-json-mime-type.html:
* http/tests/inspector/network/network-clear-cache.html-disabled:
* http/tests/inspector/network/network-clear-cookies.html-disabled:
* http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
* http/tests/inspector/network/network-content-replacement-xhr.html:
* http/tests/inspector/network/network-cyrillic-xhr-expected.txt:
* http/tests/inspector/network/network-cyrillic-xhr.html:
* http/tests/inspector/network/network-disable-cache-xhrs-expected.txt:
* http/tests/inspector/network/network-disable-cache-xhrs.html:
* http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt:
* http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
* http/tests/inspector/network/network-empty-xhr-expected.txt:
* http/tests/inspector/network/network-empty-xhr.html:
* http/tests/inspector/network/network-sidebar-width-expected.txt:
* http/tests/inspector/network/network-sidebar-width.html:
* http/tests/inspector/network/network-size-sync.html:
* http/tests/inspector/network/network-xhr-async-double-expected.txt:
* http/tests/inspector/network/network-xhr-async-double.html:
* http/tests/inspector/network/network-xhr-async-expected.txt:
* http/tests/inspector/network/network-xhr-async.html:
* http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt:
* http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
* http/tests/inspector/network/network-xhr-sync-expected.txt:
* http/tests/inspector/network/network-xhr-sync.html:
* http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt:
* http/tests/inspector/resource-tree/resource-tree-no-xhrs.html:
* platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNeed to clear exception in JSDictionary for operations that might have.
charles.wei@torchmobile.com.cn [Fri, 14 Sep 2012 08:27:05 +0000 (08:27 +0000)]
Need to clear exception in JSDictionary for operations that might have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Reviewed by Kentaro Hara.

Clear the exception if failed to convert the value inside the JSDictionary.
Otherwise, it might impact the following operations on the dictionary.

No new tests, the existing test at LayoutTest/storage/indexeddb/tutorial.html should work for JSC binding.

* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::tryGetPropertyAndResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd method to get the list of all available dictionaries
g.czajkowski@samsung.com [Fri, 14 Sep 2012 08:09:45 +0000 (08:09 +0000)]
Add method to get the list of all available dictionaries
https://bugs.webkit.org/show_bug.cgi?id=96518

Reviewed by Carlos Garcia Campos.

Source/WebCore:

There is lack of the method in the TextCheckerEnchant class to get
the list of all available/installed dictionaries. To set the
dictionaries the client has to 'guess/hard code' the names of
dictionaries that are not obvious and depend on OS configuration
and installed packages. The list can be used by WebKit's GTK and
EFL API for instance:
webkit_web_context_set_spell_checking_languages(),
ewk_text_checker_setting_spell_checking_languages_set()
to set dictionaries used by Enchant.

To avoid names conflict a new one has been introduced for former
getSpellCheckingLanguages. It has been changed to loadedSpellCheckingLanguages
as it gets the current (in use) dictionaries. Additionally the 'get' prefix
has been removed according to WebKit coding style.

* platform/text/enchant/TextCheckerEnchant.cpp:
(TextCheckerEnchant::loadedSpellCheckingLanguages):
Changed name from getSpellCheckingLanguages and added const modifier.

(TextCheckerEnchant::availableSpellCheckingLanguages):
A newly added method to get available/installed dictionaries.
Its output can be used as input for updateSpellCheckingLanguages().

* platform/text/enchant/TextCheckerEnchant.h:
(TextCheckerEnchant):

Source/WebKit2:

* UIProcess/API/gtk/WebKitTextChecker.cpp:
(WebKitTextChecker::getSpellCheckingLanguages):
Update the method name that is called inside getSpellCheckingLanguages.
This replace doesn't affect any on API changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove V8DOMWindowShell::getEntered
commit-queue@webkit.org [Fri, 14 Sep 2012 07:51:48 +0000 (07:51 +0000)]
Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-09-14
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context but rather a smaller
object.

No new tests. No change in functionality.

* bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):
* bindings/v8/ScopedPersistent.h:
(WebCore::ScopedPersistent::leakHandle):
(ScopedPersistent):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
* bindings/v8/V8Binding.cpp:
(WebCore::perContextDataForCurrentWorld):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::toIsolatedContextData):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::clearIsolatedShell):
(WebCore):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(IsolatedContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::create):
(WebCore::V8DOMWindowShell::IsolatedContextData::world):
(WebCore::V8DOMWindowShell::IsolatedContextData::perContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::setSecurityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::securityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::IsolatedContextData):
(WebCore::V8DOMWindowShell::enteredIsolatedContext):
(WebCore::V8DOMWindowShell::enteredIsolatedContextData):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r128507.
gyuyoung.kim@samsung.com [Fri, 14 Sep 2012 07:12:24 +0000 (07:12 +0000)]
Unreviewed, rolling out r128507.
http://trac.webkit.org/changeset/128507
https://bugs.webkit.org/show_bug.cgi?id=96659

Source/WebCore:

Revert. r128507 makes too many crashes in EFL layout test bots.

* PlatformEfl.cmake:
* platform/efl/RefPtrEfl.cpp: Renamed from Source/WTF/wtf/efl/RefPtrEfl.cpp.
(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* platform/efl/RefPtrEfl.h: Renamed from Source/WTF/wtf/efl/RefPtrEfl.h.
(WTF):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Revert. r128507 makes too many crashes in EFL layout test bots.

* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):

Source/WTF:

Revert. r128507 makes too many crash in EFL layout test bots.

* wtf/PlatformEfl.cmake:
* wtf/efl/OwnPtrEfl.cpp:
(WTF::deleteOwnedPtr):
(WTF):

Tools:

Revert. r128507 makes too many crashes in EFL layout test bots.

* DumpRenderTree/efl/ImageDiff.cpp:
(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReuse floating point formatting of TextStream in [SVG]RenderTreeAsText.cpp
paroga@webkit.org [Fri, 14 Sep 2012 07:09:03 +0000 (07:09 +0000)]
Reuse floating point formatting of TextStream in [SVG]RenderTreeAsText.cpp
https://bugs.webkit.org/show_bug.cgi?id=96264

Reviewed by Benjamin Poulain.

RenderTreeAsText uses the same format for streaming out floats as TextStream
does. Replace formatNumberRespectingIntegers() with a new overload to the
operator<< to reuse the special cases for numbers which take advantage of
StringBuilder::appendNumber() and avoid a temporary StringImpl.

* platform/text/TextStream.cpp:
(WebCore::hasFractions):
(WebCore::TextStream::operator<<):
* platform/text/TextStream.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/RenderTreeAsText.h:
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the Zapped BlockState
mhahnenberg@apple.com [Fri, 14 Sep 2012 07:06:23 +0000 (07:06 +0000)]
Remove the Zapped BlockState
https://bugs.webkit.org/show_bug.cgi?id=96708

Reviewed by Geoffrey Garen.

The Zapped block state is rather confusing. It indicates that a block is in one of two different states that we
can't tell the difference between:

1) I have run all destructors of things that are zapped, and I have not allocated any more objects. This block
   is ready for reclaiming if you so choose.
2) I have run all the destructors of things that are zapped, but I have allocated more stuff since then, so it
   is not safe to reclaim this block.

This state adds a lot of complexity to our state transition model for MarkedBlocks. We should get rid of it.
We can replace this state by making sure mark bits represent all of the liveness information we need when running
our conservative stack scan. Instead of zapping the free list when canonicalizing cell liveness data prior to
a conservative scan, we can instead mark all objects in the block except for those in the free list. This should
incur no performance penalty since we're doing it on a very small O(1) number of blocks at the beginning of the collection.

For the time being we still need to use zapping to determine whether we have run an object's destructor or not.

* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): Renaming stuff.
* heap/MarkedAllocator.h: Renamed zapFreeList to canonicalizeCellLivenessData to match.
(MarkedAllocator):
(JSC::MarkedAllocator::canonicalizeCellLivenessData): Same as old zapFreeList, but just call canonicalize instead.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep): Remove the check for Zapped block stuff. Also change the block state to Marked
instead of Zapped if we're not producing a FreeList since that's the only other state that really makes any sense.
(JSC::MarkedBlock::sweepHelper): Remove Zapped related code.
(SetAllMarksFunctor): Functor to set all the mark bits in the block since there's not a simple function to call on
the Bitmap itself.
(JSC::SetAllMarksFunctor::operator()):
(JSC):
(JSC::MarkedBlock::canonicalizeCellLivenessData): Remove all the stuff for Zapped. For FreeListed, set all the mark bits
and then clear the ones for the objects in the FreeList. This ensures that only the things that were in the FreeList
are considered to be dead by the conservative scan, just like if we were to have zapped the FreeList like before.
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::clearMarked): Add function to clear individual mark bits, since we need that functionality now.
(JSC):
(JSC::MarkedBlock::isLive): Remove code for Zapped stuff. Marked handles all interesting cases now.
(JSC::MarkedBlock::forEachCell): Add new iterator function that iterates over all cells in the block, regardless of
whether they're live or a dead.
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::canonicalizeCellLivenessData): Change to call the renamed canonicalize function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse performance.webkitNow in PerfTestRunner
rniwa@webkit.org [Fri, 14 Sep 2012 07:03:28 +0000 (07:03 +0000)]
Use performance.webkitNow in PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92826

Reviewed by Eric Seidel.

Use performance.webkitNow with Date.now as a fallback for more acurate time measurements.

* resources/runner.js:
(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, remove an unnecessary expected file.
ossy@webkit.org [Fri, 14 Sep 2012 06:45:03 +0000 (06:45 +0000)]
[Qt] Unreviewed gardening, remove an unnecessary expected file.

* platform/qt/fast/events/keyevent-iframe-removed-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove a lot of C'ism from Ewk_Tiled_Matrix
commit-queue@webkit.org [Fri, 14 Sep 2012 06:29:21 +0000 (06:29 +0000)]
[EFL] Remove a lot of C'ism from Ewk_Tiled_Matrix
https://bugs.webkit.org/show_bug.cgi?id=96638

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-13
Reviewed by Gyuyoung Kim.

Remove a lot of C'ism from Ewk_Tiled_Matrix and
fix the code so that it follows coding style.

* ewk/ewk_tiled_matrix.cpp:
(_Ewk_Tile_Matrix):
(ewk_tile_matrix_entry_get):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_entry_new):
(ewk_tile_matrix_invalidate):
(ewk_tile_matrix_free):
(ewk_tile_matrix_resize):
(ewk_tile_matrix_size_get):
(ewk_tile_matrix_unused_cache_get):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_put):
(ewk_tile_matrix_tile_updates_clear):
(_ewk_tile_matrix_slicer_setup):
(ewk_tile_matrix_update):
(ewk_tile_matrix_updates_process):
(ewk_tile_matrix_updates_clear):
(ewk_tile_matrix_dbg):
(ewk_tile_matrix_freeze):
(ewk_tile_matrix_thaw):
* ewk/ewk_tiled_matrix_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r128552.
commit-queue@webkit.org [Fri, 14 Sep 2012 06:17:15 +0000 (06:17 +0000)]
Unreviewed, rolling out r128552.
http://trac.webkit.org/changeset/128552
https://bugs.webkit.org/show_bug.cgi?id=96729

Still breaks the test on chromium linux debug. It's quite
annoying. (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

* WebCore.exp.in:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* rendering/RenderWidget.cpp:
(WebCore):
(WebCore::widgetNewParentMap):
(WebCore::RenderWidget::suspendWidgetHierarchyUpdates):
(WebCore::RenderWidget::resumeWidgetHierarchyUpdates):
(WebCore::moveWidgetToParentSoon):
* rendering/RenderWidget.h:
(RenderWidget):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake compile with both OS(WINCE) and PLATFORM(QT) support
commit-queue@webkit.org [Fri, 14 Sep 2012 05:53:37 +0000 (05:53 +0000)]
Make compile with both OS(WINCE) and PLATFORM(QT) support
https://bugs.webkit.org/show_bug.cgi?id=95536

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-09-13
Reviewed by Simon Hausmann.

Source/JavaScriptCore:

Do not link against advapi32 on wince

* jsc.pro:

Source/WebCore:

* WebCore.pri:
Set defines for the WinCE platform build
* platform/graphics/BitmapImage.cpp:
Use default implementation in BitmapImage::reportMemoryUsage() when Qt support available
* platform/graphics/GraphicsContext.cpp:
Same as above: use default implementation
 * platform/win/ClipboardUtilitiesWin.cpp:
Remove unnecessary include

Source/WTF:

Fixes for Windows CE.

* WTF.pri:
Also include path for mt19937ar.c
* wtf/unicode/icu/CollatorICU.cpp:
Fix undeclared strdup() on CE7
* wtf/Platform.h:

Tools:

Fix wince support in qmake files

* Tools.pro:
* qmake/mkspecs/features/configure.prf:
* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix for WTF fails to compile in thumb mode when llint is enabled.
commit-queue@webkit.org [Fri, 14 Sep 2012 05:51:45 +0000 (05:51 +0000)]
Fix for WTF fails to compile in thumb mode when llint is enabled.
https://bugs.webkit.org/show_bug.cgi?id=96400

Patch by Byungseon Shin <xingri@gmail.com> on 2012-09-13
Reviewed by Filip Pizlo.

When using "+m" with Armv7 cross compiler assume offset range between +/- 4095
(the largest possible offset range).
However, ldrex/strex can only use offset range of 0~1020, so "+m" needed to be changed to "+Q".
Ref. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54480

* wtf/Atomics.h:
(WTF::weakCompareAndSwap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCreate Localizer factory method for LocaleWin
keishi@webkit.org [Fri, 14 Sep 2012 05:50:54 +0000 (05:50 +0000)]
Create Localizer factory method for LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=96667

Reviewed by Kent Tamura.

Preparing to use Localizer instead of LocaleMac/Win/ICU.

No new tests. No behavior change.

* platform/text/LocaleWin.cpp:
(WebCore):
(WebCore::extractLanguageCode): Extract the language code from a locale.
(WebCore::LCIDFromLocaleInternal): Returns LCID for a given locale. Returns 0 when locale is invalid.
(WebCore::LCIDFromLocale): Returns LCID for a given locale. Returns default language LCID when locale is invalid.
(WebCore::Localizer::create):
(WebCore::LocaleWin::currentLocale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] qt-5.0-wk2 Skipped file can be updated after bug #73917 got fixed
commit-queue@webkit.org [Fri, 14 Sep 2012 05:30:02 +0000 (05:30 +0000)]
[Qt][WK2] qt-5.0-wk2 Skipped file can be updated after bug #73917 got fixed
https://bugs.webkit.org/show_bug.cgi?id=96675

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-09-13
Reviewed by Simon Hausmann.

Update Skipped list after userAgent proper support.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update
tkent@chromium.org [Fri, 14 Sep 2012 05:10:53 +0000 (05:10 +0000)]
[Chromium] Test expectation update

* platform/chromium/TestExpectations:
Fix an error in the previous change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Add color picker API support for WebKit2
commit-queue@webkit.org [Fri, 14 Sep 2012 05:08:45 +0000 (05:08 +0000)]
[WK2] Add color picker API support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=95058

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-09-13
Reviewed by Gyuyoung Kim.

Source/WebKit2:

Add support for color picker API to WebKit2.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Shared/API/c/WKBase.h:
* Shared/APIClientTraits.cpp:
(WebKit):
* Shared/APIClientTraits.h:
* Shared/APIObject.h:
* Target.pri:
* UIProcess/API/C/WKAPICast.h:
(WebKit):
* UIProcess/API/C/WKColorPickerResultListener.cpp: Added.
(WKColorPickerResultListenerGetTypeID):
(WKColorPickerResultListenerColorSet):
* UIProcess/API/C/WKColorPickerResultListener.h: Added.
* UIProcess/API/C/WKPage.h:
* UIProcess/API/gtk/WebKitUIClient.cpp:
(attachUIClientToView):
* UIProcess/WebColorChooserProxy.cpp: Added.
(WebKit):
(WebKit::WebColorChooserProxy::WebColorChooserProxy):
(WebKit::WebColorChooserProxy::~WebColorChooserProxy):
(WebKit::WebColorChooserProxy::endChooser):
(WebKit::WebColorChooserProxy::setSelectedColor):
* UIProcess/WebColorChooserProxy.h:
(WebColorChooserProxy):
(WebKit::WebColorChooserProxy::create):
* UIProcess/WebColorPickerResultListenerProxy.cpp: Added.
(WebKit):
(WebKit::WebColorPickerResultListenerProxy::WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::~WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::invalidate):
(WebKit::WebColorPickerResultListenerProxy::setColor):
* UIProcess/WebColorPickerResultListenerProxy.h: Added.
(WebKit):
(WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::create):
(WebKit::WebColorPickerResultListenerProxy::type):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showColorChooser):
(WebKit::WebPageProxy::didEndColorChooser):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
(WebKit):
(WebPageProxy):
* UIProcess/WebUIClient.cpp:
(WebKit):
(WebKit::WebUIClient::showColorPicker):
(WebKit::WebUIClient::hideColorPicker):
* UIProcess/WebUIClient.h:
(WebKit):
(WebUIClient):
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:

Tools:

Initialization code for color picker callbacks in UI client.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosuspend/resumeWidgetHierarchyUpdates should be a RAII object
rniwa@webkit.org [Fri, 14 Sep 2012 05:00:13 +0000 (05:00 +0000)]
suspend/resumeWidgetHierarchyUpdates should be a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

* WebCore.exp.in: Export new symbols.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* rendering/RenderWidget.cpp:
(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):
* rendering/RenderWidget.h:
(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update
tkent@chromium.org [Fri, 14 Sep 2012 04:55:03 +0000 (04:55 +0000)]
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=96725

* platform/chromium/TestExpectations:
http/tests/media/media-source/video-media-source-state-changes.html is flaky

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpgrade yutak to reviewer
yutak@chromium.org [Fri, 14 Sep 2012 03:50:28 +0000 (03:50 +0000)]
Upgrade yutak to reviewer
https://bugs.webkit.org/show_bug.cgi?id=96721

Reviewed by Kent Tamura.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update
tkent@chromium.org [Fri, 14 Sep 2012 03:39:13 +0000 (03:39 +0000)]
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=93589

* platform/chromium/TestExpectations:
script-change-externalResourcesRequired-while-loading.svg is flaky on all platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r128543.
commit-queue@webkit.org [Fri, 14 Sep 2012 03:24:03 +0000 (03:24 +0000)]
Unreviewed, rolling out r128543.
http://trac.webkit.org/changeset/128543
https://bugs.webkit.org/show_bug.cgi?id=96722

Caused LocaleWinTest.localizedNumberRoundTrip to fail
(Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

* platform/text/LocaleWin.cpp:
(WebCore::determineCurrentLCID):
(WebCore):
(WebCore::LocaleWin::currentLocale):

Source/WebKit/chromium:

* tests/LocaleWinTest.cpp:
(testNumberIsReversible):
(testNumbers):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation udpate.
tkent@chromium.org [Fri, 14 Sep 2012 03:20:04 +0000 (03:20 +0000)]
[Chromium] Test expectation udpate.
https://bugs.webkit.org/show_bug.cgi?id=96720

* platform/chromium/TestExpectations:
time-multiple-fields-preserve-value-after-history-back.html is flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r128531.
commit-queue@webkit.org [Fri, 14 Sep 2012 02:29:11 +0000 (02:29 +0000)]
Unreviewed, rolling out r128531.
http://trac.webkit.org/changeset/128531
https://bugs.webkit.org/show_bug.cgi?id=96719

plugins/document-open.html crash on Chromium-Linux (Requested
by tkent1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

* WebCore.exp.in:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* rendering/RenderWidget.cpp:
(WebCore):
(WebCore::widgetNewParentMap):
(WebCore::RenderWidget::suspendWidgetHierarchyUpdates):
(WebCore::RenderWidget::resumeWidgetHierarchyUpdates):
(WebCore::moveWidgetToParentSoon):
* rendering/RenderWidget.h:
(RenderWidget):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the style checker report usage of "unsigned int"
commit-queue@webkit.org [Fri, 14 Sep 2012 02:19:21 +0000 (02:19 +0000)]
Make the style checker report usage of "unsigned int"
https://bugs.webkit.org/show_bug.cgi?id=96693

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-09-13
Reviewed by Dirk Pranke.

Add a rule to check for uses of unsigned int, as the updated coding style recomends.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_language):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactored the DFG to make fewer assumptions about variable capture
ggaren@apple.com [Fri, 14 Sep 2012 02:17:01 +0000 (02:17 +0000)]
Refactored the DFG to make fewer assumptions about variable capture
https://bugs.webkit.org/show_bug.cgi?id=96680

Reviewed by Gavin Barraclough.

A variable capture optimization patch I'm working on broke DFG
correctness and the arguments simplification optimization phase, so I've
refactored both to make fewer assumptions about variable capture.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::isCaptured): This is the new One True Way to find out
if a variable was captured. This gives us a single point of maintenance
as we chagne capture behavior.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::clobberCapturedVars): Don't assume that captured
variables have any particular location. Instead, ask the One True Function.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize): Mechanical
changes to separate being captured from being 'arguments'. What used
to be
        if (captured)
                if (arguments)
                        x
                y
is now
        if (arguments)
                x
                y
        else if (captured)
                y

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile): Use the One True Function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCreate Localizer factory method for LocaleWin
keishi@webkit.org [Fri, 14 Sep 2012 02:02:04 +0000 (02:02 +0000)]
Create Localizer factory method for LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=96667

Reviewed by Kent Tamura.

Source/WebCore:

Preparing to use Localizer instead of LocaleMac/Win/ICU.

No new tests. Covered in LocaleWinTest.cpp.

* platform/text/LocaleWin.cpp:
(WebCore):
(WebCore::extractLanguageCode): Extract the language code from a locale.
(WebCore::LCIDFromLocaleInternal): Returns LCID for a given locale. Returns 0 when locale is invalid.
(WebCore::LCIDFromLocale): Returns LCID for a given locale. Returns default language LCID when locale is invalid.
(WebCore::Localizer::create):
(WebCore::LocaleWin::currentLocale):

Source/WebKit/chromium:

* tests/LocaleWinTest.cpp:
(testNumberIsReversible):
(testNumbers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove the SourceProvider hierarchy
benjamin@webkit.org [Fri, 14 Sep 2012 01:50:17 +0000 (01:50 +0000)]
Improve the SourceProvider hierarchy
https://bugs.webkit.org/show_bug.cgi?id=95635

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-13
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

SourceProvider was designed to have subclasses magically handling the data without
decoding all of it. The virtual methods length() and getRange() were based
on these assumptions.

In practice, the magic was in our head, there is no implementation that takes
advantage of that.

SourceProvider is modified to adopt WebCore's ScriptSourceProvider::source() and base
everything on it.
The code using SourceProvider is also simplified.

* interpreter/Interpreter.cpp:
(JSC::appendSourceToError): Keep a reference to the string instead of querying it for
each time it is used.
* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::sourceCode):
* parser/Parser.h:
(JSC::parse):
* parser/SourceCode.h:
(JSC::SourceCode::SourceCode):
(JSC::SourceCode::subExpression):
* parser/SourceProvider.h:
(SourceProvider):
(JSC::SourceProvider::getRange):

Source/WebCore:

Get rid of ScriptSourceProvider and StringSourceProvider, they have been made
useless by JavaScript updates.

On x86_64, this reduces the binary size by 6kb.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::updateCurrentStatementPosition):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
* bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
(ScriptSourceCode):
* bindings/js/ScriptSourceProvider.h: Removed.
* bindings/js/StringSourceProvider.h: Removed.
* bindings/js/WorkerScriptController.cpp:
* bindings/objc/WebScriptObject.mm:
* bridge/NP_jsobject.cpp:
* bridge/jni/jni_jsobject.mm:

Source/WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm: Fix a #include abuse.
* WebView/WebScriptDebugger.mm:
(toNSString): We can now use the (faster) implicit conversion
from String to NSString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG: Dead GetButterfly's shouldn't be subject to CSE
fpizlo@apple.com [Fri, 14 Sep 2012 01:44:20 +0000 (01:44 +0000)]
DFG: Dead GetButterfly's shouldn't be subject to CSE
https://bugs.webkit.org/show_bug.cgi?id=96707
<rdar://problem/12296311>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

There were a number of cases of this that creeped into the CSE: it would
match something even though it was dead.

* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):

LayoutTests:

Reviewed by Oliver Hunt.

* fast/js/dfg-dead-redundant-get-array-length-expected.txt: Added.
* fast/js/dfg-dead-redundant-get-array-length.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-dead-redundant-get-array-length.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest rebaselines after http://trac.webkit.org/changeset/128517.
ojan@chromium.org [Fri, 14 Sep 2012 01:37:29 +0000 (01:37 +0000)]
Test rebaselines after trac.webkit.org/changeset/128517.

* fast/table/height-percent-test-expected.txt:
* platform/chromium-mac-snowleopard/fast/table/height-percent-test-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/fast/table/height-percent-test-expected.png:
* platform/chromium-mac/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/chromium-win/fast/table/height-percent-test-expected.png:
* platform/chromium-win/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/fast/table/height-percent-test-expected.txt: Removed.
* platform/gtk/TestExpectations:
* platform/gtk/fast/table/height-percent-test-expected.txt: Removed.
* platform/gtk/tables/mozilla/core/cell_heights-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug19526-expected.txt: Removed.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/tables/mozilla/core/cell_heights-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
* platform/qt/TestExpectations:
* platform/qt/fast/table/height-percent-test-expected.txt: Renamed from LayoutTests/platform/mac/fast/table/height-percent-test-expected.txt.
* platform/qt/tables/mozilla/core/cell_heights-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/win-future/fast/table/height-percent-test-expected.txt: Copied from LayoutTests/fast/table/height-percent-test-expected.txt.
* tables/mozilla_expected_failures/bugs/bug19526-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug19526-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/12255720> Fix the build with newer Clang
mrowe@apple.com [Fri, 14 Sep 2012 01:35:46 +0000 (01:35 +0000)]
<rdar://problem/12255720> Fix the build with newer Clang

Reviewed by Sam Weinig.

Clang generates a warning about the inclusion of trailing commas on the final enum item as it's apparently
a C++11 extension. Remove them.

* src/compiler/BaseTypes.h:
* src/compiler/ExtensionBehavior.h:
* src/compiler/ParseHelper.cpp:
(TParseContext::parseVectorFields):
* src/compiler/intermediate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline fast/css/percentage-height-auto-sized-body-quirks.html after
ojan@chromium.org [Fri, 14 Sep 2012 01:30:06 +0000 (01:30 +0000)]
Rebaseline fast/css/percentage-height-auto-sized-body-quirks.html after
http://trac.webkit.org/changeset/128517. The results are now consistent
across platforms.

* platform/efl/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
* platform/gtk/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Implement missing initializeLogChannel function
commit-queue@webkit.org [Fri, 14 Sep 2012 01:15:39 +0000 (01:15 +0000)]
[EFL][WK2] Implement missing initializeLogChannel function
https://bugs.webkit.org/show_bug.cgi?id=96478

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-09-13
Reviewed by Gyuyoung Kim.

Implemented log channel initialization function for EFL platform in WebKit2.

* Platform/Logging.cpp:
(WebKit):
* Platform/Logging.h:
(WebKit):
* Platform/efl/LoggingEfl.cpp: Added.
(WebKit):
(WebKit::initializeLogChannel): Channel is initialized if its name is found in WEBKIT_DEBUG.
* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd gender-neutral form of webkit-patch land-cowboy
pdr@google.com [Fri, 14 Sep 2012 00:52:47 +0000 (00:52 +0000)]
Add gender-neutral form of webkit-patch land-cowboy
https://bugs.webkit.org/show_bug.cgi?id=96709

Reviewed by Adam Barth.

Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.

* Scripts/webkitpy/tool/commands/download.py:
(LandCowhand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove some parameters in browserCreate()
commit-queue@webkit.org [Fri, 14 Sep 2012 00:43:19 +0000 (00:43 +0000)]
[EFL] Remove some parameters in browserCreate()
https://bugs.webkit.org/show_bug.cgi?id=96499

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
And I have moved some parameters into User_Arguments.

* EWebLauncher/main.c:
(_User_Arguments):
(_ELauncher):
(on_key_down):
(browserCreate):
(findThemePath):
(parseUserArguments):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake global const initialisation explicit in the bytecode
oliver@apple.com [Fri, 14 Sep 2012 00:43:04 +0000 (00:43 +0000)]
Make global const initialisation explicit in the bytecode
https://bugs.webkit.org/show_bug.cgi?id=96711

Reviewed by Gavin Barraclough.

Added op_init_global_const to make initialisation of global const
fields explicit.  This will help us keep correct semantics in the
upcoming variable resolution refactoring.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitInitGlobalConst):
(JSC):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::ConstDeclNode::emitCodeSingle):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Consolidate two-phase connection to avoid race conditions
jsbell@chromium.org [Fri, 14 Sep 2012 00:28:38 +0000 (00:28 +0000)]
IndexedDB: Consolidate two-phase connection to avoid race conditions
https://bugs.webkit.org/show_bug.cgi?id=90411

Reviewed by Tony Chang.

Source/WebCore:

Previously, IDB connections were opened by having the front-end (1) call through to
a back-end open() method, eventually receive a success message with a back-end object
handle, and (2) call into the back-end object to register front-end callbacks. This left
the back-end's notion of an open connection in a limbo state between these two calls.
In multi-process ports, a crash of the front-end process could leave the back-end wedged
waiting for this second call (e.g. can't delete until all connections are closed).

Simplify this by having the front-end pass through the callbacks into the back-end
during the initial open() call, which eliminates the limbo state.

No new tests - no functional changes. Chromium port's webkit_unit_tests updated.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase): Db-callbacks is available at creation time.
(WebCore::IDBDatabase::~IDBDatabase):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create): Need to track db-callbacks as well.
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create): Ditto.
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount): Don't need to count limbo connections any more.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnection): No more limbo connections (yay!).
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion): Ditto.
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Style.
(WebCore::IDBDatabaseBackendImpl::close): Resolve FIXME about connectionCount.
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::connect):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
(IDBDatabaseCallbacksImpl):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open): Mint the db-callbacks here...
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open): ...passed through to here...
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create): ...all the way to here...
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): ...and finally hooked up here.
(WebCore::IDBOpenDBRequest::onSuccess): (or here, if no upgrade needed).
* Modules/indexeddb/IDBOpenDBRequest.h:
(WebCore):
(IDBOpenDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort): Tweak event/notification ordering; the
notifying the database that the transaction is finished may unblock closing,
which fires more events, and the delivery matters. Previously the close would
be blocked by the transaction which gave the desired order.
(WebCore::IDBTransaction::onComplete): Ditto.
* inspector/InspectorIndexedDBAgent.cpp: New hookup logic.
(WebCore):

Source/WebKit/chromium:

API plumbing for simplified single-phase connection opening, and tests updated
to exercise the new APIs.

* public/WebIDBDatabase.h:
(WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
* public/WebIDBFactory.h:
(WebKit):
(WebIDBFactory):
(WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
* src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
(WebKit):
(WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
the db-callbacks and hook it up when the onSuccess callback comes through.
* src/IDBCallbacksProxy.h:
(WebKit):
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore):
(WebCore::TEST): Updated connection sequence.
* tests/IDBDatabaseBackendTest.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago https://bugs.webkit.org/show_bug.cgi?id=93654
ap@apple.com [Fri, 14 Sep 2012 00:26:16 +0000 (00:26 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=93654
        REGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert

        Unskipped tests that should not assert any more (there were more than the one in
        bug title). Re-attributed some remaining failures that were tracked together with that.

        * platform/gtk/TestExpectations:
        * platform/mac/Skipped:
        * platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosuspend/resumeWidgetHierarchyUpdates should be a RAII object
rniwa@webkit.org [Fri, 14 Sep 2012 00:20:04 +0000 (00:20 +0000)]
suspend/resumeWidgetHierarchyUpdates should be a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

* WebCore.exp.in: Export new symbols.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* rendering/RenderWidget.cpp:
(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):
* rendering/RenderWidget.h:
(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove lines for fast/table/bad-replaced-sizing-preferred-logical-widths.html
ojan@chromium.org [Fri, 14 Sep 2012 00:11:47 +0000 (00:11 +0000)]
Remove lines for fast/table/bad-replaced-sizing-preferred-logical-widths.html
fixed in http://trac.webkit.org/changeset/128528.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLots of repaints in the top left tile on this site
simon.fraser@apple.com [Fri, 14 Sep 2012 00:02:51 +0000 (00:02 +0000)]
Lots of repaints in the top left tile on this site
https://bugs.webkit.org/show_bug.cgi?id=96698

Reviewed by Anders Carlsson.

When given a rect outside of the current tile coverage rect,
TileCache::setNeedsDisplayInRect() would try to invalidate the
top left tile. This would normally be a no-op, except when repaint
counters are visible, in which case it would invalidate the counter
area.

Fix by doing an early return if the intersection between the repaint
rect and the tile coverage rect is empty.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplayInRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening for r128516/r128517:
jamesr@google.com [Thu, 13 Sep 2012 23:53:20 +0000 (23:53 +0000)]
Unreviewed gardening for r128516/r128517:
  remove the now-unnecessary cr-mac expectations for fast/writing-mode test.
  fix baseline for fast/table/bad-replaced-sizing-preferred-logical-widths.html

* platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/12283706> WebKit looks for some files on the system even when buildin...
mrowe@apple.com [Thu, 13 Sep 2012 23:48:50 +0000 (23:48 +0000)]
<rdar://problem/12283706> WebKit looks for some files on the system even when building against an SDK.

Reviewed by David Kilzer.

If an SDK is being used, pass it through to our custom invocations of the preprocessor.

Source/WebCore:

* DerivedSources.make:

Source/WebKit2:

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPlatformGestureCurveTest compile fix pt 2
jamesr@google.com [Thu, 13 Sep 2012 23:29:55 +0000 (23:29 +0000)]
PlatformGestureCurveTest compile fix pt 2

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Thu, 13 Sep 2012 23:18:24 +0000 (23:18 +0000)]
[WinCairo] Unreviewed build fix.

* WebCookieManagerCurl.cpp: Remove unused 'using WebCore'
declaration that prevented the build from completing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: ASSERT(!eventDispatchForbidden()) fires when removed plugin re-insert...
tsepez@chromium.org [Thu, 13 Sep 2012 23:12:03 +0000 (23:12 +0000)]
Source/WebCore: ASSERT(!eventDispatchForbidden()) fires when removed plugin re-inserted as part of readyStateChange.
https://bugs.webkit.org/show_bug.cgi?id=93639

Reviewed by Ryosuke Niwa.

Removing a plugin causes a detach which can cancel the last remaining load on a page,
resulting in a readyStateChange event during a time when things are inconsisent. Defer
the detach which triggers this chain of events until after the node is fully removed
from the document's elementsById map.

Test: plugins/plugin-remove-readystatechange.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

LayoutTests: ASSERT(!eventDispatchForbidden()) firest when removed plugin re-inserted as part of readyStateChange.
https://bugs.webkit.org/show_bug.cgi?id=93639

Reviewed by Ryosuke Niwa.

Add a new testcase to cover this issue.  Test passes if assert doesn't fire in debug builds.

* plugins/plugin-remove-readystatechange-expected.txt: Added.
* plugins/plugin-remove-readystatechange.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Unreviewed build fix for export declarations.
bfulgham@webkit.org [Thu, 13 Sep 2012 23:09:30 +0000 (23:09 +0000)]
[WinCairo] Unreviewed build fix for export declarations.

New entries were added to the standard Windows export definition
file, but were not added to the WinCairo version, breaking the build.

* win/WebKit2CFLite.def: Incoproate changes from WebKit2.def file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix compile warning/error on windows - literal that isn't exactly representable as...
jamesr@google.com [Thu, 13 Sep 2012 23:07:20 +0000 (23:07 +0000)]
Fix compile warning/error on windows - literal that isn't exactly representable as a float needs "f" suffix.

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd optional debug logging when we fall into/out of threaded scrolling
timothy_horton@apple.com [Thu, 13 Sep 2012 23:04:21 +0000 (23:04 +0000)]
Add optional debug logging when we fall into/out of threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898
<rdar://problem/12089098>

Reviewed by Simon Fraser.

Add logging when we enter and exit the threaded scrolling mode, and logs the reasons we
fall into main-thread scrolling.

The logging output looks like this:
    SCROLLING: Switching to main-thread scrolling mode. Time: 15843.554718 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15844.550866
    SCROLLING: Switching to main-thread scrolling mode. Time: 15845.551214 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15846.552619
    SCROLLING: Switching to main-thread scrolling mode. Time: 15847.553587 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15848.554084

No new tests, as this is just debugging logging.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
Construct a bitfield describing the reasons we fall into main-thread scrolling mode.

* page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::shouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
Use the reasons bitfield instead of a boolean.

* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
Add MainThreadScrollingReasons enum, with the current reasons that we might fallback to main-thread scrolling.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::scrollingPerformanceLoggingEnabled):
Fix a typo (scrollingPeformanceLoggingEnabled -> scrollingPerformanceLoggingEnabled).

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
(WebCore::logThreadedScrollingMode):
Pretty-print the scrolling mode and shouldUpdateScrollLayerPositionOnMainThreadReason.

Update the scrolling tree's scrollingPerformanceLoggingEnabled preference
before the early-return if we don't have layer debugging borders on.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Binding: Generate batched attribute/const/callback struct names can collide
jsbell@chromium.org [Thu, 13 Sep 2012 23:01:34 +0000 (23:01 +0000)]
[V8] Binding: Generate batched attribute/const/callback struct names can collide
https://bugs.webkit.org/show_bug.cgi?id=96700

Reviewed by Kentaro Hara.

The V8 binding code generator spits out static arrays for batched configuration of
consts, attributes, and callbacks. Prior to this patch, it would spit them out
in the WebCore namespace with names like <BaseType>Callbacks which could collide with
other code. This change renames them from <BaseType><Suffix> to V8<BaseType><Suffix>.

Tests: Rebaselined the binding/scripts/test/V8/* results. No functional changes.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(Float64ArrayV8Internal):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(TestActiveDOMObjectV8Internal):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(TestCustomNamedGetterV8Internal):
(WebCore):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(TestEventConstructorV8Internal):
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(TestEventTargetV8Internal):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestException.cpp:
(TestExceptionV8Internal):
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(TestInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(TestMediaQueryListListenerV8Internal):
(WebCore):
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(TestObjV8Internal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Improve string manipulation in EflKeyboardUtilities.cpp
ryuan.choi@samsung.com [Thu, 13 Sep 2012 22:58:42 +0000 (22:58 +0000)]
[EFL] Improve string manipulation in EflKeyboardUtilities.cpp
https://bugs.webkit.org/show_bug.cgi?id=96598

Reviewed by Benjamin Poulain.

Uses ASCIILiteral for static strings as recommended by
http://trac.webkit.org/wiki/EfficientStrings and uses HexNumber to remove
String::format.

No behavior change. Just a refactoring.

* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::addCharactersToKeyMap):
(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Adding myself to the committers list.
mark.lam@apple.com [Thu, 13 Sep 2012 22:58:09 +0000 (22:58 +0000)]
Unreviewed. Adding myself to the committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agopercentage heights in quirks mode with auto-sized body are computed incorrectly
ojan@chromium.org [Thu, 13 Sep 2012 22:56:07 +0000 (22:56 +0000)]
percentage heights in quirks mode with auto-sized body are computed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=96426

Reviewed by Tony Chang.

Source/WebCore:

In quirks mode, for the body element, we need to keep walking up to the html element
if the body's height is auto. Also, we need to subtract the body/html elements
margin/border/padding so that we properly get the body's content height.

This behavior matches IE9, FF and Opera.

None of this applies to standards mode since we don't walk up the
containingBlock chain for auto-sized elements.

Test: fast/css/percentage-height-auto-sized-body-quirks.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

* fast/css/percentage-height-auto-sized-body-quirks-expected.txt: Added.
* fast/css/percentage-height-auto-sized-body-quirks.html: Added.
Verified that this matches IE9, FF15 and Opera12.

* fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt:
* platform/chromium-linux/fast/table/height-percent-test-expected.png:
* platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/tables/mozilla/core/cell_heights-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/mac/fast/table/height-percent-test-expected.txt:
Verified that all the changes match FF15.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chrom...
ojan@chromium.org [Thu, 13 Sep 2012 22:52:22 +0000 (22:52 +0000)]
fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=96594

Reviewed by Tony Chang.

Remove the text so that this test gets metrics the same across platforms.

* fast/table/bad-replaced-sizing-preferred-logical-widths.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Fix lint error in my last TestExpectations patch - whoops!
jamesr@google.com [Thu, 13 Sep 2012 22:50:29 +0000 (22:50 +0000)]
Unreviewed gardening. Fix lint error in my last TestExpectations patch - whoops!

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHide all ancestors of the full screen element when going full screen
enne@google.com [Thu, 13 Sep 2012 22:32:28 +0000 (22:32 +0000)]
Hide all ancestors of the full screen element when going full screen
https://bugs.webkit.org/show_bug.cgi?id=96332

Reviewed by James Robinson.

Source/WebCore:

Since fixed position elements can now sometimes become stacking
contexts, explicitly set position: static on full-screen ancestors so
that there are no stacking context ancestors that could cause the full
screen element to become incorrectly sorted.

Test: fullscreen/full-screen-fixed-pos-parent.html

* css/fullscreen.css:
(:-webkit-full-screen-ancestor:not(iframe)):

LayoutTests:

This test has an all red image that (without this patch) incorrectly
sorts on top of the full screen element. With this patch, the all
green full screen element appears on top.

* fullscreen/full-screen-fixed-pos-parent-expected.png: Added.
* fullscreen/full-screen-fixed-pos-parent-expected.txt: Added.
* fullscreen/full-screen-fixed-pos-parent.html: Added.
* fullscreen/resources/green.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert
abarth@webkit.org [Thu, 13 Sep 2012 22:19:43 +0000 (22:19 +0000)]
REGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert
https://bugs.webkit.org/show_bug.cgi?id=93654

Reviewed by Eric Seidel.

Source/WebCore:

When wrapping a Document, we need to ensure that the global object for
the wrapper actually exists before trying to create the wrapper. In
other cases in the DOM, we always touch the global object before trying
to wrap a given DOM object. For Document, however,
HTMLFrameElement.contentDocument is a rare way to get at a DOM object
for a global object without first touching the Window object.

Rather than writing custom bindings for
HTMLFrameElement.contentDocument, this patch just makes toJS for
Document ensure that toJS for DOMWindow has been called first. The V8
bindings have some similar code.

Test: fast/dom/content-document-prototype.html

* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):

LayoutTests:

* fast/dom/content-document-prototype-expected.txt: Added.
* fast/dom/content-document-prototype.html: Added.
    - Check that HTMLFrameElement.contentDocument ends up with the
      right prototype chain. This is a tricky case because not only the
      prototype chain of the property different from the holder, we
      never actually touch the DOMWindow in this test case so the
      prototype chain leads to a global object that doesn't even exist
      yet!
* fast/events/keyevent-iframe-removed-crash.html:
    - Add a call to gc() so that this test will ASSERT reliabily if we
      cause a similar problem in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build.
andersca@apple.com [Thu, 13 Sep 2012 22:13:07 +0000 (22:13 +0000)]
Fix build.

* platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(Latin1TextIterator):
m_endCharacter is an unused private member variable, so just remove it to appease newer versions of clang.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorun-perf-tests output cryptic error when the config file is missing.
rniwa@webkit.org [Thu, 13 Sep 2012 21:51:59 +0000 (21:51 +0000)]
run-perf-tests output cryptic error when the config file is missing.
https://bugs.webkit.org/show_bug.cgi?id=96453

Reviewed by Tony Chang.

Add a special error message when a configuration file is missing.

Also update the help message of --source-json-path to signify the fact it specifies
the configuration file on performance tests bots.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._merge_slave_config_json):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(_test_run_with_json_output): Make upload to fail by default and assert the result
in the function so that we can return logs instead.
(_test_run_with_json_output.mock_upload_json):
(test_run_with_json_output):
(test_run_with_description):
(test_run_respects_no_results):
(test_run_with_slave_config_json):
(test_run_with_bad_slave_config_json):
(test_run_with_multiple_repositories):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening - upstream some skia_test_expectations.txt entries.
jamesr@google.com [Thu, 13 Sep 2012 21:29:53 +0000 (21:29 +0000)]
Unreviewed gardening - upstream some skia_test_expectations.txt entries.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Cleanup AboutDataEnableFeatures.in
rwlbuis@webkit.org [Thu, 13 Sep 2012 21:21:25 +0000 (21:21 +0000)]
[BlackBerry] Cleanup AboutDataEnableFeatures.in
https://bugs.webkit.org/show_bug.cgi?id=96695

Reviewed by Antonio Gomes.

Remove unused features.

* WebCoreSupport/AboutDataEnableFeatures.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTypo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible
commit-queue@webkit.org [Thu, 13 Sep 2012 21:21:12 +0000 (21:21 +0000)]
Typo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible
https://bugs.webkit.org/show_bug.cgi?id=96679

Patch by Hans Muller <hmuller@adobe.com> on 2012-09-13
Reviewed by Darin Adler.

Fixed a typo in the comment for RenderStyle::isFlippedLinesWritingMode() and refactored the
three RendersStyle::isXXXWritingMode() inlines to use the inlines defined in WritingMode.h.
Moved the comments to WritingMode.h

No new tests needed.

* platform/text/WritingMode.h:
(WebCore):
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEvas_Object* is a ref'ed structure, so tread it as such
kenneth@webkit.org [Thu, 13 Sep 2012 21:19:41 +0000 (21:19 +0000)]
Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659

Reviewed by Adam Barth.

Source/WebCore:

Replace OwnPtr<Evas_Object> with RefPtr.

* PlatformEfl.cmake:
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Replace OwnPtr<Evas_Object> with RefPtr.

* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):

Source/WTF:

Remove OwnPtr support for Evas_Object* and add support for it
with RefPtr instead (the latter moved from WebCore).

* wtf/PlatformEfl.cmake:
* wtf/efl/OwnPtrEfl.cpp:
* wtf/efl/RefPtrEfl.cpp: Renamed from Source/WebCore/platform/efl/RefPtrEfl.cpp.
(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* wtf/efl/RefPtrEfl.h: Renamed from Source/WebCore/platform/efl/RefPtrEfl.h.
(WTF):

Tools:

Replace OwnPtr<Evas_Object> with RefPtr.

* DumpRenderTree/efl/ImageDiff.cpp:
(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother typo fix. Apparently, I "fixed" the wrong line in the previous commit.
rniwa@webkit.org [Thu, 13 Sep 2012 21:07:46 +0000 (21:07 +0000)]
Another typo fix. Apparently, I "fixed" the wrong line in the previous commit.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong...
jchaffraix@webkit.org [Thu, 13 Sep 2012 21:05:54 +0000 (21:05 +0000)]
[Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=96593

Reviewed by Adam Barth.

After r127457, the HitTestResult stored in ContextMenuController is in window coordinates.
Trying to convert it again to window coordinates will result in adding the containing frame's
position twice, thus the wrong placing.

Chromium Mac wasn't impacted by the regression and I manually checked that the fix doesn't impact Mac.

Unfortunately, no test as I don't think we have a way of testing context menu position.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded 8 bit path to WidthIterator::advance()
msaboff@apple.com [Thu, 13 Sep 2012 21:03:55 +0000 (21:03 +0000)]
Added 8 bit path to WidthIterator::advance()
https://bugs.webkit.org/show_bug.cgi?id=96590

Reviewed by Geoffrey Garen.

Source/WebCore:

Added 8 bit path to advance() by adding a templatized advanceInternal private
method and added a simple 8 bit Latin-1 TextIterator.  Updated SurrogatePairAwareTextIterator
by making both consume() and advance() inlined and adding consumeSlowCase() for
surrogate handling.  These changes are a performance progression on the Layout tests.

No new tests because of no behavior changes.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Latin1TextIterator.h: Copied from Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h.
(Latin1TextIterator):
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::consume):
(WebCore::Latin1TextIterator::advance):
(WebCore::Latin1TextIterator::characters):
* platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::consumeSlowCase):
* platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::consume):
(SurrogatePairAwareTextIterator):
(WebCore::SurrogatePairAwareTextIterator::advance):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
* platform/graphics/WidthIterator.h:
(WidthIterator):

Source/WTF:

Added new character constant for Hiragana Letter Small A.

* wtf/unicode/CharacterNames.h:
(Unicode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a typo per Darin's comment.
rniwa@webkit.org [Thu, 13 Sep 2012 20:49:54 +0000 (20:49 +0000)]
Fix a typo per Darin's comment.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
rwlbuis@webkit.org [Thu, 13 Sep 2012 20:43:55 +0000 (20:43 +0000)]
[BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=96689

Reviewed by Antonio Gomes.

Rename to InspectorClientBlackBerry to avoid include problems.

* WebCoreSupport/InspectorClientBlackBerry.h:
* WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.
(WebKit):
(BlackBerry::WebKit::InspectorOverlay::create):
(BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
(BlackBerry::WebKit::InspectorOverlay::paintContents):
(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
(BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::clear):
(BlackBerry::WebKit::InspectorOverlay::update):
* WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.
(WebCore):
(WebKit):
(InspectorOverlay):
(InspectorOverlayClient):
(BlackBerry::WebKit::InspectorOverlay::setClient):
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] alter fling animation parameters.
rjkroege@chromium.org [Thu, 13 Sep 2012 20:26:24 +0000 (20:26 +0000)]
[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666

Reviewed by Adrienne Walker.

Corrected the test to be non-fragile in the presence of altered fling
curve parameters.

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText Autosizing: Add explanations to tests.
commit-queue@webkit.org [Thu, 13 Sep 2012 20:23:13 +0000 (20:23 +0000)]
Text Autosizing: Add explanations to tests.
https://bugs.webkit.org/show_bug.cgi?id=96673

Patch by John Mellor <johnme@chromium.org> on 2012-09-13
Reviewed by Julien Chaffraix.

Replaces some of the lorem ipsum filler text in Text Autosizing tests
with explanations of why the result is expected (and other minor tweaks
to tests).

* fast/text-autosizing/font-scale-factor-expected.html:
* fast/text-autosizing/font-scale-factor.html:
* fast/text-autosizing/narrow-iframe-expected.html:
* fast/text-autosizing/narrow-iframe-flattened-expected.html:
* fast/text-autosizing/narrow-iframe-flattened.html:
* fast/text-autosizing/narrow-iframe.html:
* fast/text-autosizing/nested-em-line-height-expected.html:
* fast/text-autosizing/nested-em-line-height.html:
* fast/text-autosizing/simple-paragraph-expected.html:
* fast/text-autosizing/simple-paragraph.html:
* fast/text-autosizing/span-child-expected.html:
* fast/text-autosizing/span-child.html:
* fast/text-autosizing/various-font-sizes-expected.html:
* fast/text-autosizing/various-font-sizes.html:
* fast/text-autosizing/wide-block-expected.html:
* fast/text-autosizing/wide-block.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a style guide rule for signed and unsigned int
rniwa@webkit.org [Thu, 13 Sep 2012 20:17:42 +0000 (20:17 +0000)]
Add a style guide rule for signed and unsigned int
https://bugs.webkit.org/show_bug.cgi?id=96682

Reviewed by Geoffrey Garen.

Add a rule per http://lists.webkit.org/pipermail/webkit-dev/2012-September/022199.html.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename forEachCell to forEachLiveCell
mhahnenberg@apple.com [Thu, 13 Sep 2012 20:08:53 +0000 (20:08 +0000)]
Rename forEachCell to forEachLiveCell
https://bugs.webkit.org/show_bug.cgi?id=96685

Reviewed by Oliver Hunt.

forEachCell actually only iterates over live cells. We should rename it to
reflect what it actually does. This is also helpful because we want to add a new
forEachCell that actually does iterate each and every cell in a MarkedBlock
regardless of whether or not it is live.

* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* heap/Heap.cpp:
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::forEachLiveCell):
* heap/MarkedSpace.h:
(MarkedSpace):
(JSC::MarkedSpace::forEachLiveCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::releaseExecutableMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] ResourceRequest string optimizations
yoli@rim.com [Thu, 13 Sep 2012 20:02:39 +0000 (20:02 +0000)]
[BlackBerry] ResourceRequest string optimizations
https://bugs.webkit.org/show_bug.cgi?id=96661

Reviewed by Rob Buis.

RIM PR# 207965.
Call PlatformRequest's method to add the Accept-Language header.

No new tests as no functional change.

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r128489.
commit-queue@webkit.org [Thu, 13 Sep 2012 19:57:54 +0000 (19:57 +0000)]
Unreviewed, rolling out r128489.
http://trac.webkit.org/changeset/128489
https://bugs.webkit.org/show_bug.cgi?id=96686

Does not compile on windows (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebCore:

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::registerFrontendCallbacks):
(WebCore):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
(IDBDatabaseCallbacksImpl):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onSuccess):
* Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

Source/WebKit/chromium:

* public/WebIDBDatabase.h:
* public/WebIDBFactory.h:
(WebIDBFactory):
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
* src/IDBCallbacksProxy.h:
(WebKit):
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
(WebKit):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
(WebKit::WebIDBDatabaseImpl::open):
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(WebCore::TEST):
* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOne more unreviewed trivial fix after r128399.
ossy@webkit.org [Thu, 13 Sep 2012 19:52:36 +0000 (19:52 +0000)]
One more unreviewed trivial fix after r128399.

* BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor duplicate code into RenderFlexibleBox::mainAxisContentExtent
tony@chromium.org [Thu, 13 Sep 2012 19:49:34 +0000 (19:49 +0000)]
Refactor duplicate code into RenderFlexibleBox::mainAxisContentExtent
https://bugs.webkit.org/show_bug.cgi?id=96676

Reviewed by Eric Seidel.

There was computeAvailableFreeSpace() and lineBreakLength() shared some very similar code.
Merge this code into mainAxisContentExtent().

No new tests, this is just a refactor.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent): Take contentLogicalHeight as a parameter,
which is needed when determining the logical height.
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use mainAxisContentExtent() and inline.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Use mainAxisContentExtent().
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed trivial fix after r128399.
ossy@webkit.org [Thu, 13 Sep 2012 19:46:07 +0000 (19:46 +0000)]
Unreviewed trivial fix after r128399.

* BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
(getLatestSVNRevision):
(waitForSVNRevision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd new accelerated compositing for overflow scroll setting.
commit-queue@webkit.org [Thu, 13 Sep 2012 19:26:35 +0000 (19:26 +0000)]
Add new accelerated compositing for overflow scroll setting.
https://bugs.webkit.org/show_bug.cgi?id=95885

Patch by Glenn Hartmann <hartmanng@chromium.org> on 2012-09-13
Reviewed by James Robinson.

wkb.ug/91117 introduces RenderLayer::usesCompositedScrolling(), which
currently returns true if we're overflow scrolling and the element has
been styled with '-webkit-overflow-scrolling: touch'. If this is true,
we get promoted to a composited layer, the associated RenderLayerBacking
gets special scrolling layers and in response to RenderLayer::scrollTo()
we no longer have to invalidate everything to get the scrolled content
in the right spot, thereby avoiding very expensive repaints. It's
unfortunate that we require -webkit-overflow-scrolling: touch, though.
It would be nice if RenderLayer::usesCompositedScrolling() returned true
if the page would continue to behave correctly.  This is what
wkb.ug/94743 is intended to do.  Unfortunately, when we become a
composited layer, we switch from subpixel to grayscale anti-aliasing. We
only want to auto-opt into composited scrolling if we don't mind the
change in anti-aliasing, so we need a flag to enable/disable this
feature.

Source/WebCore:

No new tests -- no change in behaviour.

* page/Settings.h:
(WebCore::Settings::setAcceleratedCompositingForOverflowScrollEnabled):
(WebCore::Settings::acceleratedCompositingForOverflowScrollEnabled):
(Settings):

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
commit-queue@webkit.org [Thu, 13 Sep 2012 19:26:12 +0000 (19:26 +0000)]
[WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=96366

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-13
Reviewed by Anders Carlsson.

Source/WebKit2:

Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
by calling shouldClose() on the FrameLoader.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCallShouldCloseOnWebView):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Tools:

Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
by calling shouldClose() on the FrameLoader.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::callShouldCloseOnWebView):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Unskip passing test fast/events/onbeforeunload-focused-iframe.html

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r128453.
zandobersek@gmail.com [Thu, 13 Sep 2012 19:21:26 +0000 (19:21 +0000)]
Unreviewed, rolling out r128453.
http://trac.webkit.org/changeset/128453
https://bugs.webkit.org/show_bug.cgi?id=96681

Having tests use the same appcache directory leads to timeouts
(Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearMemoryCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Consolidate two-phase connection to avoid race conditions
jsbell@chromium.org [Thu, 13 Sep 2012 19:19:44 +0000 (19:19 +0000)]
IndexedDB: Consolidate two-phase connection to avoid race conditions
https://bugs.webkit.org/show_bug.cgi?id=90411

Reviewed by Tony Chang.

Source/WebCore:

Previously, IDB connections were opened by having the front-end (1) call through to
a back-end open() method, eventually receive a success message with a back-end object
handle, and (2) call into the back-end object to register front-end callbacks. This left
the back-end's notion of an open connection in a limbo state between these two calls.
In multi-process ports, a crash of the front-end process could leave the back-end wedged
waiting for this second call (e.g. can't delete until all connections are closed).

Simplify this by having the front-end pass through the callbacks into the back-end
during the initial open() call, which eliminates the limbo state.

No new tests - no functional changes. Chromium port's webkit_unit_tests updated.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase): Db-callbacks is available at creation time.
(WebCore::IDBDatabase::~IDBDatabase):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create): Need to track db-callbacks as well.
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create): Ditto.
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount): Don't need to count limbo connections any more.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnection): No more limbo connections (yay!).
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction): Pass through db-callbacks.
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion): Ditto.
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Style.
(WebCore::IDBDatabaseBackendImpl::close): Resolve FIXME about connectionCount.
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::connect):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
(IDBDatabaseCallbacksImpl):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open): Mint the db-callbacks here...
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open): ...passed through to here...
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h:
(IDBFactoryBackendInterface):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create): ...all the way to here...
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): ...and finally hooked up here.
(WebCore::IDBOpenDBRequest::onSuccess): (or here, if no upgrade needed).
* Modules/indexeddb/IDBOpenDBRequest.h:
(WebCore):
(IDBOpenDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort): Tweak event/notification ordering; the
notifying the database that the transaction is finished may unblock closing,
which fires more events, and the delivery matters. Previously the close would
be blocked by the transaction which gave the desired order.
(WebCore::IDBTransaction::onComplete): Ditto.
* inspector/InspectorIndexedDBAgent.cpp: New hookup logic.
(WebCore):

Source/WebKit/chromium:

API plumbing for simplified single-phase connection opening, and tests updated
to exercise the new APIs.

* public/WebIDBDatabase.h:
(WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
* public/WebIDBFactory.h:
(WebKit):
(WebIDBFactory):
(WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
* src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
(WebKit):
(WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
the db-callbacks and hook it up when the onSuccess callback comes through.
* src/IDBCallbacksProxy.h:
(WebKit):
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
(IDBFactoryBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):
* tests/IDBAbortOnCorruptTest.cpp:
(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore):
(WebCore::TEST): Updated connection sequence.
* tests/IDBDatabaseBackendTest.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
jamesr@google.com [Thu, 13 Sep 2012 19:06:00 +0000 (19:06 +0000)]
[chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
https://bugs.webkit.org/show_bug.cgi?id=96678

Reviewed by Dirk Pranke.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 13 Sep 2012 18:41:49 +0000 (18:41 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFlexitem margins should be based on content width, not width
tony@chromium.org [Thu, 13 Sep 2012 18:39:27 +0000 (18:39 +0000)]
Flexitem margins should be based on content width, not width
https://bugs.webkit.org/show_bug.cgi?id=96674

Reviewed by Ojan Vafai.

Source/WebCore:

Margins should be based on content width. Also remove some calls to
mainAxisContentExtent() when we can use contentLogicalWidth instead.

Tests: css3/flexbox/percent-margins.html has a new testcase.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild): Use contentLogicalWidth instead of
passing in the maximum value (only used in the width case).
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Don't pass in mainAxisContentExtent.
(WebCore::RenderFlexibleBox::computeChildMarginValue): Use contentLogicalWidth and simplify the code.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Remove unnecessary mainAxisContentExtent() call.
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax): Remove unnecessary flexboxAvailableContentExtent.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Remove unnecessary mainAxisContentExtent() call.
(WebCore::RenderFlexibleBox::resolveFlexibleLengths): Remove unnecessary mainAxisContentExtent() call.
* rendering/RenderFlexibleBox.h: Remove unnecessary params.

LayoutTests:

Add a test case where contentWidth != width.

* css3/flexbox/percent-margins-expected.txt:
* css3/flexbox/percent-margins.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Assertion reached on RenderThemeEFL when setting a theme to an invalid path
commit-queue@webkit.org [Thu, 13 Sep 2012 18:33:41 +0000 (18:33 +0000)]
[EFL] Assertion reached on RenderThemeEFL when setting a theme to an invalid path
https://bugs.webkit.org/show_bug.cgi?id=96649

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Keep the consistence by restoring the reference to the old theme path
when the new one cannot be loaded.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::setThemePath):

Source/WebKit2:

Updated the alternative test theme file. It is basically
the default theme with extra padding on the button widget as
specified by the comments on the test case.

* UIProcess/API/efl/tests/resources/big_button_theme.edj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, warning fix left over from r128456 (bug 96645)
commit-queue@webkit.org [Thu, 13 Sep 2012 18:16:59 +0000 (18:16 +0000)]
Unreviewed, warning fix left over from r128456 (bug 96645)

Patch by Antonio Gomes <agomes@rim.com> on 2012-09-13

* Api/InRegionScroller.cpp:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] alter fling animation parameters.
rjkroege@chromium.org [Thu, 13 Sep 2012 18:16:32 +0000 (18:16 +0000)]
[chromium] alter fling animation parameters.
https://bugs.webkit.org/show_bug.cgi?id=96666

Reviewed by Adrienne Walker.

Adjusted configuration parameters for fling animation to have a longer
tail and more similarity between touchpad and touchscreen.

Covered by existing tests.

* platform/TouchFlingPlatformGestureCurve.cpp:
(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Properties of IDBKeyRange should default to undefined
jsbell@chromium.org [Thu, 13 Sep 2012 18:05:03 +0000 (18:05 +0000)]
IndexedDB: Properties of IDBKeyRange should default to undefined
https://bugs.webkit.org/show_bug.cgi?id=96401

Reviewed by Adam Barth.

Source/WebCore:

Per the IndexedDB spec, properties of IDBKeyRange should be |undefined| if
not set (i.e. range.upper if created with lowerBound(), and vice versa), rather
than null.

Test: storage/indexeddb/keyrange.html

* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8): Since IDBKeyRange is the only place where possibly-null
keys are returned to script, change the JS value from null to undefined.
And call v8Undefined(). It's faster.
* bindings/js/custom/JSIDBKeyCustom.cpp:
(WebCore::toJS): Ditto.

LayoutTests:

Update test expectations.

* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/resources/keyrange.js:
(checkLowerBoundKeyRange):
(checkUpperBoundKeyRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed changes to watchlist.
rwlbuis@webkit.org [Thu, 13 Sep 2012 18:03:02 +0000 (18:03 +0000)]
Unreviewed changes to watchlist.

- Add myself to BlackBerry bugs

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd an SVG entry to the watchlist
schenney@chromium.org [Thu, 13 Sep 2012 17:50:03 +0000 (17:50 +0000)]
Add an SVG entry to the watchlist

Unreviewed config change.

* Scripts/webkitpy/common/config/watchlist:
- Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
- Added myself and pdr as watchers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128480 268f45cc-cd09-0410-ab3c-d52691b4dbfc