WebKit-https.git
7 years ago[CSS Shapes] New positioning model: support for stacked floats with shape-outside
bjonesbe@adobe.com [Thu, 1 Aug 2013 23:44:45 +0000 (23:44 +0000)]
[CSS Shapes] New positioning model: support for stacked floats with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=118087

Reviewed by Alexandru Chiculita.

Import new test for stacked floats from the CSSWG's repository to
replace the old tests. The simple horizontal rectangle test is no
longer applicable now that float stacking ignores shapes, so it has
just been removed.

* TestExpectations: Remove skipping for replaced tests.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple-expected.html: Removed.
* fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple.html: Removed.
* fast/shapes/shape-outside-floats/shape-outside-floats-stacked-expected.html: Removed.
* fast/shapes/shape-outside-floats/shape-outside-floats-stacked.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate polygon shape-outside tests for upstream changes
bjonesbe@adobe.com [Thu, 1 Aug 2013 23:17:51 +0000 (23:17 +0000)]
Update polygon shape-outside tests for upstream changes
https://bugs.webkit.org/show_bug.cgi?id=119414

Reviewed by Alexandru Chiculita.

The refs were updated upstream to make them work properly in Blink.
This pulls in that change to keep things in sync.

* csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add an alternative address to show my affiliation in team.html.
changseok.oh@collabora.com [Thu, 1 Aug 2013 22:36:07 +0000 (22:36 +0000)]
Unreviewed. Add an alternative address to show my affiliation in team.html.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLots of leaks under WebContext::pluginInfoStoreDidLoadPlugins()
andersca@apple.com [Thu, 1 Aug 2013 22:27:10 +0000 (22:27 +0000)]
Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins()
https://bugs.webkit.org/show_bug.cgi?id=119412

Reviewed by Simon Fraser.

For some sick reason, the WKContextClient plugInInformationBecameAvailable callback function
expects a +1 reference to the plug-in array. Isolate that hack to WebContextClient so that
we don't leak the array if there is no WKContextClient.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
* UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInInformationBecameAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG is not enforcing correct ordering of ToString conversion in MakeRope
oliver@apple.com [Thu, 1 Aug 2013 22:18:58 +0000 (22:18 +0000)]
DFG is not enforcing correct ordering of ToString conversion in MakeRope
https://bugs.webkit.org/show_bug.cgi?id=119408

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Construct ToString and Phantom nodes in advance of MakeRope
nodes to ensure that ordering is ensured, and correct values
will be reified on OSR exit.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Add tests

* fast/js/dfg-make-rope-side-effects-expected.txt: Added.
* fast/js/dfg-make-rope-side-effects.html: Added.
* fast/js/script-tests/dfg-make-rope-side-effects.js: Added.
(f):
(k.valueOf):
(k.toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG optimizations don't handle neutered arrays properly
fpizlo@apple.com [Thu, 1 Aug 2013 22:14:28 +0000 (22:14 +0000)]
DFG optimizations don't handle neutered arrays properly
https://bugs.webkit.org/show_bug.cgi?id=119409

Reviewed by Mark Hahnenberg and Oliver Hunt.

Source/WebCore:

Test: fast/js/dfg-typed-array-neuter.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::neuterView):
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::create):
* bindings/js/SerializedScriptValue.h:

LayoutTests:

* fast/js/dfg-typed-array-neuter-expected.txt: Added.
* fast/js/dfg-typed-array-neuter.html: Added.
* fast/js/script-tests/dfg-typed-array-neuter.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer
msaboff@apple.com [Thu, 1 Aug 2013 21:57:38 +0000 (21:57 +0000)]
REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer
https://bugs.webkit.org/show_bug.cgi?id=119140

Reviewed by Filip Pizlo.

Ensure that ExceptionHandler is returned by functions in two registers by encoding the value as a 64 bit int.

* jit/JITExceptions.cpp:
(JSC::encode):
* jit/JITExceptions.h:
* jit/JITStubs.cpp:
(JSC::cti_vm_throw_slowpath):
* jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove return statement in void function
kseo@webkit.org [Thu, 1 Aug 2013 21:50:58 +0000 (21:50 +0000)]
Remove return statement in void function
https://bugs.webkit.org/show_bug.cgi?id=119379

Reviewed by Darin Adler.

It does not make sense to return a value in void function.

* WebProcess/WebProcess.cpp:
(WebKit::addCaseFoldedCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Add USE(SOUP) guard in WebProcess::destroyPrivateBrowsingSession
kseo@webkit.org [Thu, 1 Aug 2013 21:48:07 +0000 (21:48 +0000)]
[WK2] Add USE(SOUP) guard in WebProcess::destroyPrivateBrowsingSession
https://bugs.webkit.org/show_bug.cgi?id=119381

Reviewed by Darin Adler.

The is a followup to r153355. I missed to add USE(SOUP) guard in
WebProcess::destroyPrivateBrowsingSession.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::destroyPrivateBrowsingSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being...
simon.fraser@apple.com [Thu, 1 Aug 2013 21:41:22 +0000 (21:41 +0000)]
REGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being copied into the wrong location
https://bugs.webkit.org/show_bug.cgi?id=112833

Reviewed by Sam Weinig.

AutodrainedPool.h and SchedulePair.h should just be project headers, not
private headers, so they get copied into <build dir>/usr/local/include/wtf
not <build dir>/usr/local/include

* WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared
commit-queue@webkit.org [Thu, 1 Aug 2013 21:25:33 +0000 (21:25 +0000)]
REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared
https://bugs.webkit.org/show_bug.cgi?id=113058

Source/WebCore:

Before sharing CSS properties with an element in the cache, we need to
check that the new element is suitable for this, just like we check
elements before inserting them into the cache.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-08-01
Reviewed by Andreas Kling.

Test: fast/css/identical-logical-height-decl.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyMatchedProperties):

LayoutTests:

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-08-01
Reviewed by Andreas Kling.

* fast/css/identical-logical-height-decl-expected.html: Added.
* fast/css/identical-logical-height-decl.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed expected test results for run-bindings-tests after r153532, r153537.
mark.lam@apple.com [Thu, 1 Aug 2013 21:13:11 +0000 (21:13 +0000)]
Fixed expected test results for run-bindings-tests after r153532, r153537.
https://bugs.webkit.org/show_bug.cgi?id=119410.

Reviewed by Simon Fraser.

No new tests.

* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayPrototype::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
* bindings/scripts/test/JS/JSFloat64Array.h:
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertySlot):
(WebCore::JSTestActiveDOMObjectPrototype::getOwnPropertySlot):
(WebCore::JSTestActiveDOMObject::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlotByIndex):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::getOwnPropertySlot):
(WebCore::JSTestEventTargetPrototype::getOwnPropertySlot):
(WebCore::JSTestEventTarget::getOwnPropertySlot):
(WebCore::JSTestEventTarget::getOwnPropertySlotByIndex):
* bindings/scripts/test/JS/JSTestEventTarget.h:
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::getOwnPropertySlot):
(WebCore::JSTestException::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestException.h:
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::getOwnPropertySlot):
(WebCore::JSTestNode::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestNode.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::getOwnPropertySlot):
(WebCore::JSTestOverloadedConstructors::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::getOwnPropertySlot):
(WebCore::JSTestTypedefsPrototype::getOwnPropertySlot):
(WebCore::JSTestTypedefs::getOwnPropertySlot):
* bindings/scripts/test/JS/JSTestTypedefs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark some ref tests that sometimes file becaues of colorspace
simon.fraser@apple.com [Thu, 1 Aug 2013 21:07:16 +0000 (21:07 +0000)]
Mark some ref tests that sometimes file becaues of colorspace
issues as both Pass and ImageOnlyFailure.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r153448) video-controls-captions-trackmenu.html is failing
jer.noble@apple.com [Thu, 1 Aug 2013 20:34:20 +0000 (20:34 +0000)]
REGRESSION (r153448) video-controls-captions-trackmenu.html is failing
https://bugs.webkit.org/show_bug.cgi?id=119376

Reviewed by Simon Fraser.

Call showMenu() before attempting to click on the caption menu items.

* media/video-controls-captions-trackmenu.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCopy eglplatform.h to be found by Windows WebGL build.
achristensen@apple.com [Thu, 1 Aug 2013 20:24:23 +0000 (20:24 +0000)]
Copy eglplatform.h to be found by Windows WebGL build.
https://bugs.webkit.org/show_bug.cgi?id=119299

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCorePreBuild.cmd: Copy eglplatform.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed wrong static_casting in ANGLE from r153064.
achristensen@apple.com [Thu, 1 Aug 2013 20:21:01 +0000 (20:21 +0000)]
Fixed wrong static_casting in ANGLE from r153064.
https://bugs.webkit.org/show_bug.cgi?id=119296

Reviewed by Dean Jackson.

* src/compiler/Intermediate.cpp:
(TIntermediate::promoteConstantUnion):
Undid erroneous static_cast change.
* src/compiler/intermediate.h:
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
Made getters use size_t instead of int.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore:  WebCore::AudioSession::beganAudioInterruption + 62
jer.noble@apple.com [Thu, 1 Aug 2013 20:10:52 +0000 (20:10 +0000)]
Crash in WebCore:  WebCore::AudioSession::beganAudioInterruption + 62
https://bugs.webkit.org/show_bug.cgi?id=119406

Reviewed by Eric Carlson.

Unregister for AudioSession interruption events when being destroyed.

* platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::~AudioDestinationIOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout should force a StyleResolver rebuild if there isn't one at all.
akling@apple.com [Thu, 1 Aug 2013 19:19:42 +0000 (19:19 +0000)]
Layout should force a StyleResolver rebuild if there isn't one at all.
<http://webkit.org/b/119378>

Reviewed by Antti Koivisto.

We can't tell if viewport-dependent media queries have been invalidated at layout,
unless we have a StyleResolver to ask about this.
In case there isn't one, take the same path as we would with an invalidated query
instead of relying on ensureStyleResolver() to build it.

* page/FrameView.cpp:
(WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrashing Test: fast/forms/color/input-color-onchange-event.html
commit-queue@webkit.org [Thu, 1 Aug 2013 18:58:31 +0000 (18:58 +0000)]
Crashing Test: fast/forms/color/input-color-onchange-event.html
<rdar://problem/14621667> and https://bugs.webkit.org/show_bug.cgi?id=119403

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-08-01
Reviewed by Tim Horton.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdding myself to list of reviewers since I am one (see https://www.webkit.org/blog...
graouts@apple.com [Thu, 1 Aug 2013 18:43:13 +0000 (18:43 +0000)]
Adding myself to list of reviewers since I am one (see https://webkit.org/blog/2691/antoine-quint-is-now-a-webkit-reviewer/).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Crash at absoluteClippedOverflowRect() in PluginView::calculateClipRect()
zhajiang@rim.com [Thu, 1 Aug 2013 18:12:57 +0000 (18:12 +0000)]
[BlackBerry] Crash at absoluteClippedOverflowRect() in PluginView::calculateClipRect()
https://bugs.webkit.org/show_bug.cgi?id=119401

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-01.
Reviewed by George Staikos.

JIRA 462881
The renderer of the PluginView's element has been detached due to transition
to a new load. We should return an empty contentRect if there even isn't
a renderer. This is a speculative fix based on the stack trace provided.

* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::calculateClipRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnavailable plug-in indicator arrow should be inside the rounded rect, not in its...
timothy_horton@apple.com [Thu, 1 Aug 2013 17:59:44 +0000 (17:59 +0000)]
Unavailable plug-in indicator arrow should be inside the rounded rect, not in its own circle
https://bugs.webkit.org/show_bug.cgi?id=119400
<rdar://problem/14616012>

Reviewed by Anders Carlsson.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
Shift the arrow in by 9px, and make the text's rounded rect include it,
instead of having the arrow in a separate circle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDuplicate property names can cause test to fail
bjonesbe@adobe.com [Thu, 1 Aug 2013 17:39:43 +0000 (17:39 +0000)]
Duplicate property names can cause test to fail
https://bugs.webkit.org/show_bug.cgi?id=119399

Reviewed by Dirk Pranke.

This problem was noticed when porting the patch for
http://wkb.ug/119357 to Blink: a test would fail because the converted
and test property lists weren't the same length, but they contained
all of the same property names. It looks like this is actually caused
by a bug in converting the HTML, which is being currently rewritten.
In the meantime, as long as this compares the number of unique
properties, it makes the test more robust.

* Scripts/webkitpy/w3c/test_converter_unittest.py:
(verify_prefixed_properties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMerge FrameWinCE into FrameWin
paroga@webkit.org [Thu, 1 Aug 2013 17:07:03 +0000 (17:07 +0000)]
Merge FrameWinCE into FrameWin
https://bugs.webkit.org/show_bug.cgi?id=117988

Reviewed by Brent Fulgham.

Reuse the code from FrameWin.cpp instead of duplicating it.

* PlatformWinCE.cmake:
* page/win/FrameGdiWin.cpp: Added.
(WebCore::imageFromRect):
* page/wince/FrameWinCE.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMade OESTextureHalfFloat work on Windows.
achristensen@apple.com [Thu, 1 Aug 2013 16:53:48 +0000 (16:53 +0000)]
Made OESTextureHalfFloat work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=119298

Reviewed by Christophe Dumez.

* DerivedSources.cpp: Added JSOESTextureHalfFloat.cpp inside of #if ENABLE(WEBGL).
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
Added JSOESTextureHalfFloat.cpp and JSOESTextureHalfFloat.h.
* html/canvas/OESTextureHalfFloat.idl: Added newline to end of file.
* html/canvas/WebGLObject.cpp: Removed unused #includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding my expertise.
bjonesbe@adobe.com [Thu, 1 Aug 2013 16:47:15 +0000 (16:47 +0000)]
Unreviewed. Adding my expertise.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRearrange the code of FrameWin
paroga@webkit.org [Thu, 1 Aug 2013 16:23:14 +0000 (16:23 +0000)]
Rearrange the code of FrameWin
https://bugs.webkit.org/show_bug.cgi?id=117984

Reviewed by Brent Fulgham.

Source/WebCore:

Move code from the CG implementation into the general file so we can
share the code with Windows CE port in a next step. In a first step
it only shares more code between the CG and Cairo implementations.
Also use OwnPtr instead of plain pointers to make ownership more clear.

* page/win/FrameCGWin.cpp:
(WebCore::imageFromRect):
* page/win/FrameCairoWin.cpp:
(WebCore::imageFromRect):
* page/win/FrameWin.cpp:
(WebCore::imageFromSelection):
(WebCore::Frame::dragImageForSelection):
(WebCore::Frame::nodeImage):
* page/win/FrameWin.h:

Source/WebKit/win:

* WebView.cpp:
(WebView::generateSelectionImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp/tests/multipart/invalid-image-data-standalone.html needs to skipped, not
simon.fraser@apple.com [Thu, 1 Aug 2013 15:35:47 +0000 (15:35 +0000)]
http/tests/multipart/invalid-image-data-standalone.html needs to skipped, not
just marked as failing, otherwise it gets listed as a test that times out.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself as a committer. Yoo-hoo! \o/
changseok.oh@collabora.com [Thu, 1 Aug 2013 15:03:05 +0000 (15:03 +0000)]
Unreviewed. Add myself as a committer. Yoo-hoo! \o/

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath.
commit-queue@webkit.org [Thu, 1 Aug 2013 13:28:56 +0000 (13:28 +0000)]
REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath.
https://bugs.webkit.org/show_bug.cgi?id=119391

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-01
Reviewed by Csaba Osztrogonác.

* jit/JITStubsSH4.h: Fix ctiVMThrowTrampolineSlowpath implementation:
    - Call frame is in r14 register.
    - Do not restore registers from JIT stack frame here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomask-repeat: round bug
commit-queue@webkit.org [Thu, 1 Aug 2013 13:03:45 +0000 (13:03 +0000)]
mask-repeat: round bug

Source/WebCore:

Added the round functionality to -webkit-mask-repeat and background-repeat. The tile size of the
image is scaled so that the image can fit a whole number of times in the background.
https://bugs.webkit.org/show_bug.cgi?id=119080

Patch by Andrei Parvu <parvu@adobe.com> on 2013-08-01
Reviewed by Dirk Schulze.

Tests: css3/masking/mask-repeat-round-auto1.html
       css3/masking/mask-repeat-round-auto2.html
       css3/masking/mask-repeat-round-border.html
       css3/masking/mask-repeat-round-content.html
       css3/masking/mask-repeat-round-padding.html
       css3/background/background-repeat-round-auto1.html
       css3/background/background-repeat-round-auto2.html
       css3/background/background-repeat-round-border.html
       css3/background/background-repeat-round-content.html
       css3/background/background-repeat-round-padding.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

Added tests for the -webkit-mask-repeat: round property.
https://bugs.webkit.org/show_bug.cgi?id=119080

Patch by Andrei Parvu <parvu@adobe.com> on 2013-08-01
Reviewed by Dirk Schulze.

* css3/masking/mask-repeat-round-auto1-expected.html: Added.
* css3/masking/mask-repeat-round-auto1.html: Added.
* css3/masking/mask-repeat-round-auto2-expected.html: Added.
* css3/masking/mask-repeat-round-auto2.html: Added.
* css3/masking/mask-repeat-round-border-expected.html: Added.
* css3/masking/mask-repeat-round-border.html: Added.
* css3/masking/mask-repeat-round-content-expected.html: Added.
* css3/masking/mask-repeat-round-content.html: Added.
* css3/masking/mask-repeat-round-padding-expected.html: Added.
* css3/masking/mask-repeat-round-padding.html: Added.
* css3/masking/resources/circle.png: Added.
* css3/background/background-repeat-round-auto1-expected.html: Added.
* css3/background/background-repeat-round-auto1.html: Added.
* css3/background/background-repeat-round-auto2-expected.html: Added.
* css3/background/background-repeat-round-auto2.html: Added.
* css3/background/background-repeat-round-border-expected.html: Added.
* css3/background/background-repeat-round-border.html: Added.
* css3/background/background-repeat-round-content-expected.html: Added.
* css3/background/background-repeat-round-content.html: Added.
* css3/background/background-repeat-round-padding-expected.html: Added.
* css3/background/background-repeat-round-padding.html: Added.
* css3/background/resources/circle.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReduce CSSProperty's StylePropertyMetadata memory footprint by half when used inside...
alexis@webkit.org [Thu, 1 Aug 2013 12:26:44 +0000 (12:26 +0000)]
Reduce CSSProperty's StylePropertyMetadata memory footprint by half when used inside a ImmutableStylePropertySet.
https://bugs.webkit.org/show_bug.cgi?id=117715

Reviewed by Andreas Kling.

Today CSSProperty holds its metadata in the following way :

--------------------------------------------------------------------------------------------
| m_propertyID : 14 We use 14 bits because CSSPropertyIDs start at 1001.                    |
| m_shorthandID : 14 id of the shorthand this property was set, 0 if not part of a shorthand|
| m_important : 1                                                                           |
| m_implicit : 1                                                                            |
| m_inherited : 1                                                                           |
--------------------------------------------------------------------------------------------

The proposal to decrease the memory footprint on CSSProperty's metadata
only stand when stored inside ImmutableStylePropertySet which uses a custom
way to allocate and lay out the StylePropertyMetadata and the CSSValues in
memory because the idea behind is that the content will not change.
The MutableStylePropertySet uses a regular vector to retrieve, remove
and modify the CSSProperties. ImmutableStylePropertySet is used by default
when parsing up until someone start to access the CSSOM like
div.style which will convert the immutable to a mutable set. It is also good
to note that a CSSProperty is created for every single statement inside a block
in a stylesheet so we do have quite a bunch around. Another consideration is
that the only client to the m_shorthandID is the inspector which uses it
to group the longhands into a shorthand drop down list.

The new proposal is the following one :
- Reduce m_propertyID to 10 bits by not starting the CSSPropertyIDs from
1001 but rather 0 (or 3 as two are hardcoded CSSPropertyInvalid and CSSPropertyVariable).
- Use the fact that we statically know which longhand belong to which shorthand. So
we create a static mapping between longhands and shorthands.

Here is the new layout :
------------------------------------------------------------------------------
| m_propertyID : 10 (up to 1024 properties), we have less than 400 today      |
| m_isSetFromShorthand : 1 and then use the mapping in StylePropertyShorthand |
| m_indexInShorthandsVector : 2                                               |
| m_important : 1 (unchanged)                                                 |
| m_implicit : 1  (unchanged)                                                 |
| m_inherited : 1 (unchanged)                                                 |
------------------------------------------------------------------------------

it was set from using the new code in StylePropertyShorthand.
- m_indexInShorthandsVector : 2 bits, unfortunately there are few longhands which belong to multiple
shorthands so we need to store which was this longhand was part at parsing time. Notice
that it does not store the CSSPropertyID of the matching shorthand but rather its position
in the vector of matching shorthands. CSSProperty::m_shorthandID() method make it transparent
for call sites and return the actual CSSPropertyID of the shorthand. So far 2 bits seems
enough as there is only few longhands with ambiguity and they belong to 3 shorthands.

Profiling the benchmark with Intel Vtune to find out the performance regression
showed that copying uint16_t, so StylePropertyMetadata, is not
a fast operation in term of assembly code and has a big penalty on Windows
MSVC over unsigned for example. The latter produces a much faster code
when using unsigned over uint16_t (45% difference in the benchmark).

The patch avoid the copies of StylePropertyMetadata when applicable (by using const ref).

The second part of the fix is avoiding the conversion from an int (enum) to
an uint16_t in a tight loop such as StylePropertySet::findPropertyIndex
(which is the hotspot of the benchmark).

On my Windows 7 64 bits Core i5 machine CSSPropertySetterGetter results are :
- avg : 2714 runs/s with the patch
- avg : 2696 runs/s without the patch

According to Andreas Kling this patch save up ~1.8Mb on membuster.

No new tests : refactor, old ones should cover.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::addPropertyWithPrefixingVariant):
(WebCore::CSSParser::addProperty):
* css/CSSProperty.cpp:
(WebCore::StylePropertyMetadata::shorthandID):
(WebCore::borderDirections):
* css/CSSProperty.h:
(WebCore::StylePropertyMetadata::StylePropertyMetadata): Use uint16_t type for bitfields so sizeof() returns 2 bytes.
(WebCore::CSSProperty::CSSProperty):
(WebCore::CSSProperty::isSetFromShorthand):
(WebCore::CSSProperty::shorthandID):
* css/StylePropertySet.cpp:
(WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
(WebCore::getIndexInShorthandVectorForPrefixingVariant):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::setPrefixingVariantProperty):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::PropertyReference::shorthandID):
* css/StylePropertyShorthand.cpp:
(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::webkitBorderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::markerShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::transitionShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitAnimationShorthandForParsing):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitFlexShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitGridColumnShorthand):
(WebCore::webkitGridRowShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::widthShorthand):
(WebCore::heightShorthand):
(WebCore::matchingShorthandsForLonghand):
(WebCore::indexOfShorthandForLonghand):
* css/StylePropertyShorthand.h:
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::id):
* css/makeprop.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable QML handling of crashed/unresponsive QtWebProcess
commit-queue@webkit.org [Thu, 1 Aug 2013 11:06:42 +0000 (11:06 +0000)]
[Qt] Enable QML handling of crashed/unresponsive QtWebProcess
https://bugs.webkit.org/show_bug.cgi?id=108474

Forward the processDidCrash, didRelaunchProcess, processDidBecomeUnresponsive
and processDidBecomeResponsive signals to QML's WebView.experimental.

Patch by Milian Wolff <milian.wolff@kdab.com> on 2013-08-01
Reviewed by Jocelyn Turcotte.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewPrivate::processDidBecomeUnresponsive):
(QQuickWebViewPrivate::processDidBecomeResponsive):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed expected pixel test result update after r153522.
zarvai@inf.u-szeged.hu [Thu, 1 Aug 2013 09:42:53 +0000 (09:42 +0000)]
[Qt] Unreviewed expected pixel test result update after r153522.

* platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/qt-5.0-wk2/compositing/visibility/visibility-simple-video-layer-expected.png:
* platform/qt-5.0-wk2/css2.1/20110323/replaced-min-max-001-expected.png:
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-14-d-expected.png:
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-24-d-expected.png:
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-34-d-expected.png:
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-44-d-expected.png:
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
* platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Added.
* platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-stacking-expected.png:
* platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize09-expected.png: Added.
* platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize10-expected.png: Added.
* platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize11-expected.png: Added.
* platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-expected.png: Added.
* platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/qt-5.0-wk2/fast/borders/border-image-side-reduction-expected.png:
* platform/qt-5.0-wk2/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
* platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
* platform/qt-5.0-wk2/scrollbars/overflow-scrollbar-combinations-expected.png:
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/qt-5.0-wk2/svg/custom/createImageElement-expected.png:
* platform/qt-5.0-wk2/svg/custom/createImageElement2-expected.png:
* platform/qt-5.0-wk2/svg/custom/image-parent-translation-expected.png:
* platform/qt-5.0-wk2/svg/custom/js-update-image-and-display-expected.png:
* platform/qt-5.0-wk2/svg/custom/js-update-image-and-display2-expected.png:
* platform/qt-5.0-wk2/svg/custom/js-update-image-and-display3-expected.png:
* platform/qt-5.0-wk2/svg/custom/js-update-image-expected.png:
* platform/qt-5.0-wk2/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/qt-5.0-wk2/svg/custom/pointer-events-image-expected.png:
* platform/qt-5.0-wk2/svg/custom/text-image-opacity-expected.png:
* platform/qt-5.0-wk2/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
* platform/qt-5.0-wk2/svg/hixie/perf/004-expected.png:
* platform/qt-5.0-wk2/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug101674-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug11026-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug1188-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug1296-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug1430-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug4284-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug4427-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug56563-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug625-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug97383-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/core/bloomberg-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/core/misc-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/other/cell_widths-expected.png:
* platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug6933-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r153518.
zandobersek@gmail.com [Thu, 1 Aug 2013 09:17:25 +0000 (09:17 +0000)]
Unreviewed, rolling out r153518.
http://trac.webkit.org/changeset/153518
https://bugs.webkit.org/show_bug.cgi?id=119386

The Jhbuild dep bump of GTK+ is not actually required by
layout testing, is causing pango dep problems (Requested by
zdobersek on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-08-01

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself as a committer.
calvaris@igalia.com [Thu, 1 Aug 2013 09:13:52 +0000 (09:13 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself as a committer.
ljaehun.lim@samsung.com [Thu, 1 Aug 2013 07:07:22 +0000 (07:07 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself as a committer.
jinwoo7.song@samsung.com [Thu, 1 Aug 2013 07:02:01 +0000 (07:02 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself as a committer.
berto@igalia.com [Thu, 1 Aug 2013 05:55:57 +0000 (05:55 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Unreviewed gardening
seokju@webkit.org [Thu, 1 Aug 2013 05:23:59 +0000 (05:23 +0000)]
[GTK] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=119283

Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Remove duplicated entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself as a committer.
seokju@webkit.org [Thu, 1 Aug 2013 04:41:40 +0000 (04:41 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip media/track/track-language-preference.html and media/track/track-prefer-captions...
simon.fraser@apple.com [Thu, 1 Aug 2013 04:25:23 +0000 (04:25 +0000)]
Skip media/track/track-language-preference.html and media/track/track-prefer-captions.html
rather than just marking them as [ Pass Fail ] since they timeout so often and slow
everything down.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClobbering window.console is not cool because it makes debugging tests
simon.fraser@apple.com [Thu, 1 Aug 2013 04:06:56 +0000 (04:06 +0000)]
Clobbering window.console is not cool because it makes debugging tests
harder.

* media/video-test.js:
(logConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agor153462 erroneously unskipped http/tests/multipart/invalid-image-data-standalone...
simon.fraser@apple.com [Thu, 1 Aug 2013 03:43:18 +0000 (03:43 +0000)]
r153462 erroneously unskipped http/tests/multipart/invalid-image-data-standalone.html
so put it back.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFINALize StyleSheet subclasses.
akling@apple.com [Thu, 1 Aug 2013 03:42:17 +0000 (03:42 +0000)]
FINALize StyleSheet subclasses.
<http://webkit.org/b/119370>

Reviewed by Anders Carlsson.

CSSStyleSheet and XSLStyleSheet have no further subclasses so make them final.

* css/CSSStyleSheet.h:
* xml/XSLStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocompositing/patterns/direct-pattern-compositing tests suffer
simon.fraser@apple.com [Thu, 1 Aug 2013 03:34:59 +0000 (03:34 +0000)]
compositing/patterns/direct-pattern-compositing tests suffer
from colorspace issues that cause image failures on some machines.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomedia/video-controls-captions-trackmenu.html either crashes,
simon.fraser@apple.com [Thu, 1 Aug 2013 03:30:35 +0000 (03:30 +0000)]
media/video-controls-captions-trackmenu.html either crashes,
fails or passes.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGardening:
simon.fraser@apple.com [Thu, 1 Aug 2013 03:17:21 +0000 (03:17 +0000)]
Gardening:

webkit.org/b/119374 fast/workers/termination-early.html [ Pass Crash ]
webkit.org/b/119375 fast/workers/worker-call.html [ Failure ]

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Page scrolls when width equals device width and initial scale is greater...
zhajiang@rim.com [Thu, 1 Aug 2013 02:20:22 +0000 (02:20 +0000)]
[BlackBerry] Page scrolls when width equals device width and initial scale is greater than 0.92
https://bugs.webkit.org/show_bug.cgi?id=119365

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-07-31
Reviewed by Rob Buis.
Internally reviewed by Gen Mak and Konrad Piascik.

JIRA 445423
layoutSize (deviceScreenSize/devicePixelRatio) is FloatSize as devicePixelRatio
is float. We have to round that to IntSize as ScrollView needs IntSize
fixedLayoutSize. Based on conversion result, zoomToFitWidthScale will
hardly equal to zoomToFitHeightScale in this case. And unfortunately
zoomToFitHeightScale is a little bit greater than zoomToFitWidthScale
in this case so that we have to pick up zoomToFitHeightScale which makes
the page scollable horizontally.
The way to fix that is to define an accurate contentsSize area which
potentially has float layoutSize rounding error and can cause upexpected
scroll based on the ideal contentsSize area first, and then don't scroll
only if the scale is zoomToFitScale as "contentsSize > visibleViewportSize"
still works well if the scale is larger than zoomToFitScale.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hasFloatLayoutSizeRoundingError):
* Api/WebPage_p.h:
* WebKitSupport/WebKitThreadViewportAccessor.cpp:
(BlackBerry::WebKit::WebKitThreadViewportAccessor::cannotScrollIfHasFloatLayoutSizeRoundingError):
* WebKitSupport/WebKitThreadViewportAccessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce toSVGFontFaceElement, and use it
gyuyoung.kim@samsung.com [Thu, 1 Aug 2013 02:17:16 +0000 (02:17 +0000)]
Introduce toSVGFontFaceElement, and use it
https://bugs.webkit.org/show_bug.cgi?id=119330

Reviewed by Andreas Kling.

As a step to change static_cast with toSVGXXX, static_cast<SVGFontFaceElement*> can
be changed with toSVGFontFaceElement().

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155082

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* svg/SVGFontFaceElement.h:
(WebCore::toSVGFontFaceElement):
* svg/SVGFontFaceFormatElement.cpp:
(WebCore::SVGFontFaceFormatElement::childrenChanged):
* svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::childrenChanged):
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::childrenChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce toSVGSMILElement, and use it
gyuyoung.kim@samsung.com [Thu, 1 Aug 2013 01:34:57 +0000 (01:34 +0000)]
Introduce toSVGSMILElement, and use it
https://bugs.webkit.org/show_bug.cgi?id=119260

Reviewed by Darin Adler.

As a step to change static_cast with toSVGXXX, static_cast<SVGSMILElement*> can
be changed with toSVGSMILElement().

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155048

* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
* svg/animation/SVGSMILElement.h:
(WebCore::toSVGSMILElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore cleanup in PropertySlot
barraclough@apple.com [Thu, 1 Aug 2013 01:09:25 +0000 (01:09 +0000)]
More cleanup in PropertySlot
https://bugs.webkit.org/show_bug.cgi?id=119359

Reviewed by Geoff Garen.

m_slotBase is overloaded to store the (receiver) thisValue and the object that contains the property,
This is confusing, and means that slotBase cannot be typed correctly (can only be a JSObject).

* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
    - No need to ASSERT slotBase is an object.
* jit/JITStubs.cpp:
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
    - No need to ASSERT slotBase is an object.
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::fillGetterPropertySlot):
    - Pass an object through to setGetterSlot.
* runtime/JSObject.h:
(JSC::PropertySlot::getValue):
    - Moved from PropertySlot (need to know anout JSObject).
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
    - update per member name changes
* runtime/PropertySlot.h:
(JSC::PropertySlot::PropertySlot):
    - Argument to constructor set to 'thisValue'.
(JSC::PropertySlot::slotBase):
    - This returns a JSObject*.
(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setCustom):
(JSC::PropertySlot::setCacheableCustom):
(JSC::PropertySlot::setCustomIndex):
(JSC::PropertySlot::setGetterSlot):
(JSC::PropertySlot::setCacheableGetterSlot):
    - slotBase is a JSObject*, make setGetterSlot set slotBase for consistency.
* runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayEntry::get):
    - Pass an object through to setGetterSlot.
* runtime/SparseArrayValueMap.h:
    - Pass an object through to setGetterSlot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClobbering window.console is not cool
simon.fraser@apple.com [Thu, 1 Aug 2013 01:08:47 +0000 (01:08 +0000)]
Clobbering window.console is not cool
https://bugs.webkit.org/show_bug.cgi?id=119364

Reviewed by Tim Horton.

full-screen-test.js overrides window.console, which is hella
confusing if you're trying to use console.log to debug a fullscreen test.

* fullscreen/full-screen-test.js:
(logConsole):
* fullscreen/resources/not-allowed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGardening: changing expectation for fast/forms/color/input-color-onchange-event.html
mark.lam@apple.com [Thu, 1 Aug 2013 00:57:36 +0000 (00:57 +0000)]
Gardening: changing expectation for fast/forms/color/input-color-onchange-event.html
to "Crash Pass" instead of "Skip".

Not reviewed.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReuse of XMLHttpRequests causes character corruption in response text
rniwa@webkit.org [Thu, 1 Aug 2013 00:51:39 +0000 (00:51 +0000)]
Reuse of XMLHttpRequests causes character corruption in response text
https://bugs.webkit.org/show_bug.cgi?id=119358

Reviewed by Anders Carlsson.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/6496e7bb9a0b46bc79032b86d5993b25f127a4cb

Test: http/tests/xmlhttprequest/reopen-encoding.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::didFinishLoading):

LayoutTests:

* http/tests/xmlhttprequest/reopen-encoding-expected.txt: Added.
* http/tests/xmlhttprequest/reopen-encoding.html: Added.
* http/tests/xmlhttprequest/resources/get-utf-8.cgi: Added.
* http/tests/xmlhttprequest/resources/get-windows-1251.cgi: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBot greening.
mark.lam@apple.com [Thu, 1 Aug 2013 00:28:05 +0000 (00:28 +0000)]
Bot greening.

Not reviewed.

* TestExpectations:
- Skipping fast/forms/color/input-color-onchange-event.html which will
  crash with a failed assertion on debug builds.
  This should be un-skipped when https://bugs.webkit.org/show_bug.cgi?id=119094
  is fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake ActiveDOMObject overrides private
ap@apple.com [Thu, 1 Aug 2013 00:21:33 +0000 (00:21 +0000)]
Make ActiveDOMObject overrides private
https://bugs.webkit.org/show_bug.cgi?id=119352

Reviewed by Sam Weinig.

There is no need to call these through derived classes. And it's quite harmful for
anyone except for ScriptExecutionContext to call suspend/resume in particular -
ScriptExecutionContext won't know, and it will try to manage the state on its own.

* Modules/filesystem/DOMFileSystem.h:
* Modules/filesystem/FileWriter.h:
* Modules/geolocation/Geolocation.h:
* Modules/indexeddb/IDBDatabase.h:
* Modules/indexeddb/IDBRequest.h:
* Modules/indexeddb/IDBTransaction.h:
* Modules/mediasource/MediaSource.h:
* Modules/notifications/Notification.h:
* Modules/notifications/NotificationCenter.h:
* Modules/websockets/WebSocket.h:
* fileapi/FileReader.h:
* html/HTMLMediaElement.h:
* html/canvas/WebGLRenderingContext.h:
* page/DOMTimer.h:
* page/EventSource.h:
* page/SuspendableTimer.h:
* workers/AbstractWorker.h:
* xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoW3C test import script prefixes some properties that it shouldn't
bjonesbe@adobe.com [Thu, 1 Aug 2013 00:10:20 +0000 (00:10 +0000)]
W3C test import script prefixes some properties that it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=119357

Reviewed by Dirk Pranke.

Some prefixed properties also have unprefixed implemetations, but when
the implementations aren't identical, they aren't declared in
CSSPropertyNames.in on the same line. This fixes the import script so
that it catches all instances of prefixed properties that have an
unprefixed variant, and does not add the prefix in those cases.

* Scripts/webkitpy/w3c/test_converter.py:
(W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
the properties on every line and record if they are prefixed or not.
Use this information to only return prefixed properties that do not
have any unprefixed variant. The prefixed property list has also
changed to not include the '-webkit-' prefix, making it much easier to
do the comparison, and removing the need to remove the prefix later.
(W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
longer needs to remove the '-webkit-' prefix, but needs to add it in
the case where a property that needs a prefix is found.
* Scripts/webkitpy/w3c/test_converter_unittest.py:
(W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
for '-webkit-' prefix, as it is no longer included in the properties
in the prefixed property list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove didFinishLoad order quirk
timothy_horton@apple.com [Thu, 1 Aug 2013 00:06:51 +0000 (00:06 +0000)]
Remove didFinishLoad order quirk
https://bugs.webkit.org/show_bug.cgi?id=119354
<rdar://problem/11510686>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Remove the quirk.

* page/Settings.in:
Remove the setting controlling the quirk.

Source/WebKit/mac:

* Misc/WebKitVersionChecks.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Don't set the now-removed preference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace CRASH() on overflow with Checked<>
kseo@webkit.org [Thu, 1 Aug 2013 00:03:10 +0000 (00:03 +0000)]
Replace CRASH() on overflow with Checked<>
https://bugs.webkit.org/show_bug.cgi?id=119327

Reviewed by Oliver Hunt.

Use a checked type that allows us to automate bound checks. We use a
non-recording Checked<> to keep the behavior.

No behavior change, no new tests needed.

* dom/Text.cpp:
(WebCore::Text::wholeText):
* platform/audio/AudioArray.h:
(WebCore::AudioArray::allocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReduce JSC API static value setter/getter overhead.
commit-queue@webkit.org [Wed, 31 Jul 2013 23:57:23 +0000 (23:57 +0000)]
Reduce JSC API static value setter/getter overhead.
https://bugs.webkit.org/show_bug.cgi?id=119277

Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-07-31
Reviewed by Geoffrey Garen.

Add property name to the static value entry, so that OpaqueJSString::create() doesn't
need to get called every time when set or get the static value.

* API/JSCallbackObjectFunctions.h:
(JSC::::put):
(JSC::::putByIndex):
(JSC::::getStaticValue):
* API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* API/JSClassRef.h:
(StaticValueEntry::StaticValueEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse emptyString instead of String("")
kseo@webkit.org [Wed, 31 Jul 2013 23:54:09 +0000 (23:54 +0000)]
Use emptyString instead of String("")
https://bugs.webkit.org/show_bug.cgi?id=119335

Reviewed by Darin Adler.

Use emptyString() instead of String("") because it is better style and
faster. This is a followup to r116908, removing all occurrences of
String("") from WebKit.

Source/JavaScriptCore:

* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

Source/WebCore:

No behavior change, no new tests needed.

* platform/graphics/blackberry/LayerAnimation.h:
(WebCore::LayerAnimation::name):
* platform/mac/PlatformEventFactoryMac.mm:
(WebCore::textFromEvent):
(WebCore::unmodifiedTextFromEvent):
(WebCore::keyIdentifierForKeyEvent):

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::userAgent):

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptPrompt):

Source/WebKit2:

* Shared/mac/WebEventFactory.mm:
(WebKit::textFromEvent):
(WebKit::unmodifiedTextFromEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate location of w3c shapes tests to reflect new import location
bjonesbe@adobe.com [Wed, 31 Jul 2013 23:21:59 +0000 (23:21 +0000)]
Update location of w3c shapes tests to reflect new import location
https://bugs.webkit.org/show_bug.cgi?id=118156

Reviewed by Dirk Pranke.

Partial imports should not be imported to the same place as the full
import, so this adds an option to allow importing to a different
location than the default. In doing that, I found that imports from
contributor directories didn't seem to be working correctly, so I
updated the import to be smarter about both contributor directories
and the test status directories. It should now be more likely that the
script guesses the root directory properly.

* Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
    script not working with the full set of contributors, as that is
    no longer true, and I didn't see a good way to keep that behavior.
    Also update documentation to properly explain what happens when a
    contributor dir is imported.
(main): Attempt to find the proper repo dir by looking at the
    directory above the "test status" in the given path, this is still
    not exactly right, but is less error prone than just trimming.
(parse_args): Add -d option to set the import directory.
(TestImporter.__init__): Stop appending the subdirs to the
    destination_directory because it was making things more complex
    and isn't really needed.
(TestImporter.update_test_status): Remove hardcoded strings and use
    the TEST_STATUS constants instead.
* Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
    support for new option.
(TestImporterTest.test_import_dir_with_no_tests): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Winlauncher shouldn't look for Safari Install Directory
bfulgham@apple.com [Wed, 31 Jul 2013 23:08:00 +0000 (23:08 +0000)]
[Windows] Winlauncher shouldn't look for Safari Install Directory
https://bugs.webkit.org/show_bug.cgi?id=119351

Reviewed by Darin Adler.

* win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
the Safari install location. Instead, use the proper support
library path for the build architecture.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert SVG test from r153433 to a reftest
rwlbuis@webkit.org [Wed, 31 Jul 2013 21:09:52 +0000 (21:09 +0000)]
Convert SVG test from r153433 to a reftest
https://bugs.webkit.org/show_bug.cgi?id=119346

Reviewed by Philip Rogers.

Reftest taken from https://chromium.googlesource.com/chromium/blink/+/ac10e305a870c8fd500b42e90075aee3aa48da8d.

* platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt: Removed.
* svg/animations/attributeNameAndAttributeTypeMismatch-expected.html: Added.
* svg/animations/attributeNameAndAttributeTypeMismatch.html: Added.
* svg/animations/attributeNameAndAttributeTypeMissmatch.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpload images for a potential blog post
benjamin@webkit.org [Wed, 31 Jul 2013 21:04:38 +0000 (21:04 +0000)]
Upload images for a potential blog post

* blog-files/size-matters: Added.
* blog-files/size-matters/JavaScript-growth.png: Added.
* blog-files/size-matters/WebCore-growth-baseline.png: Added.
* blog-files/size-matters/WebCore-growth.png: Added.
* blog-files/size-matters/WebKit-growth.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<input type=color> Mac UI behaviour
commit-queue@webkit.org [Wed, 31 Jul 2013 20:47:46 +0000 (20:47 +0000)]
<input type=color> Mac UI behaviour
<rdar://problem/10269922> and https://bugs.webkit.org/show_bug.cgi?id=61276

Source/JavaScriptCore:

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

* Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.

Source/WebCore:

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

This patch turns on INPUT_TYPE_COLOR and implements it using the native
Mac color panel.

No new tests added.

Currently, there are no automated ways to test the types of changes made in this patch. (i.e. checking
which color is being displayed in the color panel, checking which color element is currently
associated to the color panel, checking the state of color elements after directing away and
being directed back to its page, etc.)

* Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

* html/ColorInputType.cpp:
(WebCore::ColorInputType::handleDOMActivateEvent): Reattaches the color picker if
  a color picker has already been shown for an element
(WebCore::ColorInputType::shouldResetOnDocumentActivation): Always returns true, needed to
  detach the color picker when caching a page.
* html/ColorInputType.h:

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::documentDidResumeFromPageCache): For <input type='color'>,
  don't reset the element.
(WebCore::HTMLInputElement::documentWillSuspendForPageCache): For <input type='color'>, call detach().
* html/HTMLInputElement.h:

* platform/ColorChooser.h:
(WebCore::ColorChooser::reattachColorChooser): Added definition.

Source/WebKit/mac:

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

* Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createColorPicker): Added stub implementation.

Source/WebKit2:

Implemented <input type='color'> on Mac using the native color picker.

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

Code for WebColorPickerMac is derived from Chromium's color_chooser_mac.mm:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/cocoa/color_chooser_mac.mm

* Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createColorPicker): Replaced stub implementation
  and return a WebColorPickerMac object.

* UIProcess/WebColorPicker.cpp:
(WebKit::WebColorPicker::invalidate): Updated to call endChooser().
(WebKit::WebColorPicker::showColorPicker): Added stub implementation.
* UIProcess/WebColorPicker.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Removed invalidation of removed color picker objects.
(WebKit::WebPageProxy::showColorPicker): Updated so that it works for
  multiple <input type='color'> elements on a page.
(WebKit::WebPageProxy::didEndColorPicker): Removed cleanup of removed color picker objects.
(WebKit::WebPageProxy::resetStateAfterProcessExited): Removed cleanup of removed color picker objects.

* UIProcess/mac/WebColorPickerMac.h: Added.
* UIProcess/mac/WebColorPickerMac.mm: Added.
(WebKit::WebColorPickerMac::create):
(WebKit::WebColorPickerMac::~WebColorPickerMac):
(WebKit::WebColorPickerMac::WebColorPickerMac):
(WebKit::WebColorPickerMac::endPicker):
(WebKit::WebColorPickerMac::setSelectedColor):
(WebKit::WebColorPickerMac::didChooseColor):
(WebKit::WebColorPickerMac::showColorPicker):
WebColorPickerMac contains a reference to a WKColorPanelMac object
  and is responsible for maintaining the color picker UI.

(-[WKColorPanelMac setAndShowPicker:withColor:]):
(-[WKColorPanelMac invalidate]):
(-[WKColorPanelMac windowWillClose:]):
(-[WKColorPanelMac didChooseColor:]):
(-[WKColorPanelMac setColor:]):
WKColorPanelMac is a wrapper for a NSColorPanel object and
  is responsible for the color picker UI.

* WebKit2.xcodeproj/project.pbxproj:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createColorChooser): Updated to always create a
  WebColorChooser object.

* WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::reattachColorChooser): Sets the page's
  active color chooser to the current object and pings the UIProcess
  to show the color picker.
(WebKit::WebColorChooser::setSelectedColor): Only sets the color in the
  color picker if the WebColorChooser object is the active color element.
* WebProcess/WebCoreSupport/WebColorChooser.h:

Source/WTF:

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

* wtf/FeatureDefines.h: Enabled INPUT_TYPE_COLOR on Mac port.

LayoutTests:

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

Updated tests to reflect <input type='color'> being implemented with a native color picker.

* fast/forms/color/input-color-onchange-event-expected.txt:

* platform/mac/TestExpectations: Enabled fast/form/color tests on Mac.

* platform/mac/accessibility/color-well-expected.txt:
* platform/mac/accessibility/role-subrole-roledescription-expected.txt:
* platform/mac/accessibility/role-subrole-roledescription.html:

* platform/mac/fast/forms/color/input-appearance-color-expected.txt: Updated test expectations
on Mac to reflect the fact that the list attribute for <input type='color'> is not yet supported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG doesn't account for inlining of functions with switch statements that haven't...
mhahnenberg@apple.com [Wed, 31 Jul 2013 20:24:23 +0000 (20:24 +0000)]
DFG doesn't account for inlining of functions with switch statements that haven't been executed by the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=119349

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Prior to this patch, the baseline JIT was responsible for resizing the ctiOffsets Vector for
SimpleJumpTables to be equal to the size of the branchOffsets Vector. The DFG implicitly relied
on code it compiled with any switch statements to have been run in the baseline JIT first.
However, if the DFG chooses to inline a function that has never been compiled by the baseline
JIT then this resizing never happens and we crash at link time in the DFG.

We can fix this by also doing the resize in the DFG to catch this case.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):

LayoutTests:

* fast/js/dfg-inline-switch-imm-expected.txt: Added.
* fast/js/dfg-inline-switch-imm.html: Added.
* fast/js/script-tests/dfg-inline-switch-imm.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative Windows build fix.
barraclough@apple.com [Wed, 31 Jul 2013 19:32:22 +0000 (19:32 +0000)]
Speculative Windows build fix.

Reviewed by NOBODY

* runtime/JSString.cpp:
(JSC::JSRopeString::getIndexSlowCase):
* runtime/JSString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderEmbeddedObject::isReplacementObscured is wrong if an obscuring element has...
timothy_horton@apple.com [Wed, 31 Jul 2013 19:27:44 +0000 (19:27 +0000)]
RenderEmbeddedObject::isReplacementObscured is wrong if an obscuring element has pointer-events: none set
https://bugs.webkit.org/show_bug.cgi?id=119348

Reviewed by Dean Jackson.

Change the expected outcome of the test to want a visually-obscured
but clickable embed (because the obscuring element has pointer-events: none)
to be considered obscured.

Also, adjust the test so that it runs all of the subtests even if
some of them fail.

* plugins/unavailable-plugin-indicator-obscurity-expected.txt:
* plugins/unavailable-plugin-indicator-obscurity.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate scripts to reference contributors.json instead of committers.py in messaging
bjonesbe@adobe.com [Wed, 31 Jul 2013 19:26:22 +0000 (19:26 +0000)]
Update scripts to reference contributors.json instead of committers.py in messaging
https://bugs.webkit.org/show_bug.cgi?id=119342

Reviewed by Ryosuke Niwa.

Change the scripts to point people to contributors.json instead of
committers.py since the latter no longer contains the list of
contributors.

* Scripts/webkitpy/common/config/committervalidator.py:
(CommitterValidator._contributors_json_path):
(CommitterValidator._flag_permission_rejection_message):
* Scripts/webkitpy/common/config/committervalidator_unittest.py:
(CommitterValidatorTest.test_flag_permission_rejection_message):
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._commit_queue_flag):
* Scripts/webkitpy/common/watchlist/watchlistparser.py:
(WatchListParser._validate):
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
(WatchListParserTest.test_cc_rule_with_invalid_email):
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/steps/validatereviewer.py:
(ValidateReviewer.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Re-enable WinEWS tests following r153527.
roger_fong@apple.com [Wed, 31 Jul 2013 19:22:49 +0000 (19:22 +0000)]
Unreviewed. Re-enable WinEWS tests following r153527.

* Scripts/webkitpy/common/config/ews.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. AppleWin port.
roger_fong@apple.com [Wed, 31 Jul 2013 19:20:43 +0000 (19:20 +0000)]
Unreviewed gardening. AppleWin port.

* platform/win/editing/selection/move-left-right-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome cleanup in JSValue::get
barraclough@apple.com [Wed, 31 Jul 2013 19:03:05 +0000 (19:03 +0000)]
Some cleanup in JSValue::get
https://bugs.webkit.org/show_bug.cgi?id=119343

Reviewed by Geoff Garen.

Source/JavaScriptCore:

JSValue::get is implemented to:
    1) Check if the value is a cell – if not, synthesize a prototype to search,
    2) call getOwnPropertySlot on the cell,
    3) if this returns false, cast to JSObject to get the prototype, and walk the prototype chain.
By all rights this should crash when passed a string and accessing a property that does not exist, because
the string is a cell, getOwnPropertySlot should return false, and the cast to JSObject should be unsafe.
To work around this, JSString::getOwnPropertySlot actually implements 'get' functionality - searching the
prototype chain, and faking out a return value of undefined if no property is found.

This is a huge hazard, since fixing JSString::getOwnPropertySlot or calling getOwnPropertySlot on cells
from elsewhere would introduce bugs. Fortunately it is only ever called in this one place.

The fix here is to move getOwnPropertySlot onto JSObjecte and end this madness - cells don't have property
slots anyway.

Interesting changes are in JSCJSValueInlines.h, JSString.cpp - the rest is pretty much all JSCell -> JSObject.

Source/WebCore:

* WebCore.exp.in:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::getOwnPropertySlot):
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
* bridge/runtime_object.h:
    - getOwnPropertySlot, JSCell -> JSObject

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertySlot):
* WebProcess/Plugins/Netscape/JSNPObject.h:
    - getOwnPropertySlot, JSCell -> JSObject

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago REGRESSION (r153406): DOM intervals are not properly restarted when resumed
ap@apple.com [Wed, 31 Jul 2013 18:48:50 +0000 (18:48 +0000)]
    REGRESSION (r153406): DOM intervals are not properly restarted when resumed
        https://bugs.webkit.org/show_bug.cgi?id=119345

        Reviewed by Sam Weinig.

        * page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Call base class
        version of repeatInterval(), not our version that will just return the current value
        of m_savedRepeatInterval in this situation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid calling nextRenderer() in some cases
rniwa@webkit.org [Wed, 31 Jul 2013 18:44:21 +0000 (18:44 +0000)]
Avoid calling nextRenderer() in some cases
https://bugs.webkit.org/show_bug.cgi?id=119313

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/3207cfda52082f4fd6a04c7819c18a980de58beb.

* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert most callers of setInlineStyleProperty passing strings to enums or doubles...
rniwa@webkit.org [Wed, 31 Jul 2013 18:41:08 +0000 (18:41 +0000)]
Convert most callers of setInlineStyleProperty passing strings to enums or doubles instead
https://bugs.webkit.org/show_bug.cgi?id=119304

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/8157dd9381716759f183fabbfed29c52962be746

* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
* html/ImageDocument.cpp:
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setFontSize):
* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
(WebCore::TextTrackCueGeneric::setFontSize):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] Stop using internals in shape-outside tests
bjonesbe@adobe.com [Wed, 31 Jul 2013 18:18:37 +0000 (18:18 +0000)]
[CSS Shapes] Stop using internals in shape-outside tests
https://bugs.webkit.org/show_bug.cgi?id=119229

Reviewed by Alexandru Chiculita.

We no longer need to use window.internals for shape-outside, since it
is enabled by default on ports where it is compiled in. To make the
w3c spec test cleaner, that reference has been removed from all of the
tests.

* csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html:
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html:
* csswg/submitted/shapes/shape-outside/w3c-import.log:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] JavaScript crash.
msaboff@apple.com [Wed, 31 Jul 2013 18:03:47 +0000 (18:03 +0000)]
[Win] JavaScript crash.
https://bugs.webkit.org/show_bug.cgi?id=119339

Reviewed by Mark Hahnenberg.

* jit/JITStubsX86.h: Implement ctiVMThrowTrampoline and
ctiVMThrowTrampolineSlowpath the same way as the gcc x86 version does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTest assignment to indexed window properties
rniwa@webkit.org [Wed, 31 Jul 2013 17:47:50 +0000 (17:47 +0000)]
Test assignment to indexed window properties
https://bugs.webkit.org/show_bug.cgi?id=119307

Reviewed by Geoffrey Garen.

Merge https://chromium.googlesource.com/chromium/blink/+/bdeca10fa79477f669cab1e5b081a480e743fd3f

* http/tests/security/xss-DENIED-window-index-assign-expected.txt: Added.
* http/tests/security/xss-DENIED-window-index-assign.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a test to ensure SelectElement removes an option when null is assigned by indexed...
rniwa@webkit.org [Wed, 31 Jul 2013 16:52:12 +0000 (16:52 +0000)]
Add a test to ensure SelectElement removes an option when null is assigned by indexed setter
https://bugs.webkit.org/show_bug.cgi?id=119311

Reviewed by Alexey Proskuryakov.

Merge a test in https://chromium.googlesource.com/chromium/blink/+/da5c8d908b87f75c5ba3d1457c2353642e999963
even though the regression never existed in WebKit.

* fast/forms/select/select-assign-null-expected.txt: Added.
* fast/forms/select/select-assign-null.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: Adding myself to the committers' list.
bjonesbe@adobe.com [Wed, 31 Jul 2013 16:24:05 +0000 (16:24 +0000)]
Unreviewed: Adding myself to the committers' list.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Coordinated Graphics] Use m_ prefix only for member variable
commit-queue@webkit.org [Wed, 31 Jul 2013 16:08:00 +0000 (16:08 +0000)]
[Coordinated Graphics] Use m_ prefix only for member variable
https://bugs.webkit.org/show_bug.cgi?id=119250

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-31
Reviewed by Noam Rosenthal.

WebKit coding style suggests to use m_ prefix only for data members.
This patch also removes unnecessary copy by passing const-reference
parameter values.

* platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:
(WebCore::CoordinatedCustomFilterProgram::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Images are down-scaled badly
allan.jensen@digia.com [Wed, 31 Jul 2013 14:39:38 +0000 (14:39 +0000)]
[Qt] Images are down-scaled badly
https://bugs.webkit.org/show_bug.cgi?id=119263

Reviewed by Jocelyn Turcotte.

QPainter only does bilinear filtering, which means it will downscaling beyond
0.5x will start skipping pixel and start to degrade the end result. Scaling in
QImage and QPixmap however uses a better but much more expensive sampling that
counts all pixels.

To get the high quality downscaling we must therefore prescale the images before
painting them. To avoid a performance impact on repeated paints the prescaled
image are saved in the QPixmapCache.

* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Unreviewed gardening. Remove flaky tests from TestExpectations.
simon.pena@samsung.com [Wed, 31 Jul 2013 14:35:07 +0000 (14:35 +0000)]
[GTK] Unreviewed gardening. Remove flaky tests from TestExpectations.

* platform/gtk/TestExpectations: Remove tests no longer flaky after
webkit.org/b/100688 was fixed in r140166.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build WebKit with C++11
allan.jensen@digia.com [Wed, 31 Jul 2013 13:09:38 +0000 (13:09 +0000)]
[Qt] Build WebKit with C++11
https://bugs.webkit.org/show_bug.cgi?id=119337

Reviewed by Csaba Osztrogonác.

Source/WebKit2:

We no longer need to enable C++11 specifically for WebKit2.

* WebKit2.pri:

Tools:

Enable building with C++11.

* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/unix/default_post.prf:
* qmake/mkspecs/features/unix/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] ASSERTS trigger in release builds
allan.jensen@digia.com [Wed, 31 Jul 2013 12:49:46 +0000 (12:49 +0000)]
[Qt] ASSERTS trigger in release builds
https://bugs.webkit.org/show_bug.cgi?id=119336

Reviewed by Jocelyn Turcotte.

Ensure the qmake also defaults to release if no configuration is known.

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[texmap][GStreamer][GTK] composited video shows tearing
zandobersek@gmail.com [Wed, 31 Jul 2013 12:42:12 +0000 (12:42 +0000)]
[texmap][GStreamer][GTK] composited video shows tearing
https://bugs.webkit.org/show_bug.cgi?id=118253

Reviewed by Martin Robinson.

* gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK1] navigator.plugins shows too few entries.
michael.bruning@digia.com [Wed, 31 Jul 2013 12:12:10 +0000 (12:12 +0000)]
[Qt][WK1] navigator.plugins shows too few entries.
https://bugs.webkit.org/show_bug.cgi?id=119332

Reviewed by Jocelyn Turcotte.

Based on input by Choon Sik Cho.

PlatformStrategiesQt::getPluginInfo was using the
WTF::Vector::resize method wrongly.

This patch removes the call to Vector::resize as
Vector::append will take care of increasing capacity
if needed.

* WebCoreSupport/PlatformStrategiesQt.cpp:
(PlatformStrategiesQt::getPluginInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add interface API for origin whitelisting
commit-queue@webkit.org [Wed, 31 Jul 2013 11:56:06 +0000 (11:56 +0000)]
[Qt] Add interface API for origin whitelisting
https://bugs.webkit.org/show_bug.cgi?id=117823

Patch by Deepjyoti Saha <deesaha@cisco.com> on 2013-07-31
Reviewed by Jocelyn Turcotte.

Adding interface APIs in QWebSecurityOrigin to add and remove whiteList entires.

Re-used most of the test cases written by Carol Szabo  <carol.szabo@nokia.com>
for https://bugs.webkit.org/show_bug.cgi?id=31875 and added the same.

* Api/qwebsecurityorigin.cpp:
(QWebSecurityOrigin::addAccessWhitelistEntry):
(QWebSecurityOrigin::removeAccessWhitelistEntry):
* Api/qwebsecurityorigin.h:
* tests/qwebsecurityorigin: Added.
* tests/qwebsecurityorigin/qwebsecurityorigin.pro: Added.
* tests/qwebsecurityorigin/resources: Added.
* tests/qwebsecurityorigin/resources/test.html: Added.
* tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp: Added.
(tst_QWebSecurityOrigin::tst_QWebSecurityOrigin):
(tst_QWebSecurityOrigin::~tst_QWebSecurityOrigin):
(tst_QWebSecurityOrigin::init):
(tst_QWebSecurityOrigin::cleanup):
(tst_QWebSecurityOrigin::whiteList_data):
(tst_QWebSecurityOrigin::whiteList):
* tests/qwebsecurityorigin/tst_qwebsecurityorigin.qrc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove guessesVector param from isUngrammatical
g.czajkowski@samsung.com [Wed, 31 Jul 2013 09:44:35 +0000 (09:44 +0000)]
Remove guessesVector param from isUngrammatical
https://bugs.webkit.org/show_bug.cgi?id=119241

Reviewed by Ryosuke Niwa.

TextCheckingHelper::isUngrammatical(Vector<String>& guessesVector) doesn't return
guesses for ungrammatical phrases through its parameter.
Editor::isSelectionUngrammatical() uses it to check whether the selection
is ungrammatical.

r71009 showed that isUngrammatical(Vector<String>& guessesVector) had not supported
grammar guesses.

The grammar guesses can be retrieved by guessesForMisspelledOrUngrammaticalRange
when UNIFIED_TEXT_CHECKING is on.

No new tests, this is dead code due to no WebKit port implements grammar using
legacy text checker.

* WebCore.exp.in: Removed __ZN7WebCore6Editor32guessesForUngrammaticalSelectionEv.
* editing/Editor.cpp:
(WebCore::Editor::isSelectionUngrammatical):
(WebCore::Editor::guessesForMisspelledOrUngrammatical):
* editing/Editor.h: Removed guessesForUngrammaticalSelection. Dead code.
* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::isUngrammatical):
* editing/TextCheckingHelper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShrink Vectors with inline capacity.
akling@apple.com [Wed, 31 Jul 2013 08:12:32 +0000 (08:12 +0000)]
Shrink Vectors with inline capacity.
<http://webkit.org/b/119295>
<rdar://problem/14598360>

Reviewed by Anders Carlsson.

Pack Vector::m_size next to VectorBufferBase::m_capacity so there's no space wasted
on padding when sizeof(T) >= 8. Since m_size is not conceptually part of the buffer,
I just using'ed it into Vector.

* wtf/SizeLimits.cpp:
* wtf/Vector.h:
(WTF::VectorBufferBase::VectorBufferBase):
(WTF::VectorBuffer::VectorBuffer):
(WTF::Vector::Vector):
(WTF::::Vector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnnecessary const_cast<TextCheckingHelper*>(this)->findFirstBadGrammar
g.czajkowski@samsung.com [Wed, 31 Jul 2013 08:06:54 +0000 (08:06 +0000)]
Unnecessary const_cast<TextCheckingHelper*>(this)->findFirstBadGrammar
https://bugs.webkit.org/show_bug.cgi?id=119244

Reviewed by Ryosuke Niwa.

Added missing const modifier to findFirstBadGrammar (and findFirstGrammarDetail
respectively) to call it in 'isUngrammatical() const' without const casting.

No new tests, no behavior change.

* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
Added const.

(WebCore::TextCheckingHelper::isUngrammatical):
Now const_cast can be removed.

* editing/TextCheckingHelper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofindFirstGrammarDetail doesn't need to be exposed.
g.czajkowski@samsung.com [Wed, 31 Jul 2013 07:23:41 +0000 (07:23 +0000)]
findFirstGrammarDetail doesn't need to be exposed.
https://bugs.webkit.org/show_bug.cgi?id=119249

Reviewed by Darin Adler.

Make TextCheckingHelper::findFirstGrammarDetail private.
Remove badGrammarPhraseLength param. It's not used any longer.

No new tests, no behavior change.

* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
* editing/TextCheckingHelper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDHTML drag can result in a null-deref under WebDragClient::startDrag
timothy_horton@apple.com [Wed, 31 Jul 2013 05:57:28 +0000 (05:57 +0000)]
DHTML drag can result in a null-deref under WebDragClient::startDrag
https://bugs.webkit.org/show_bug.cgi?id=119297
<rdar://problem/14213012>

Reviewed by Simon Fraser.

Test: fast/events/setDragImage-in-document-element-crash.html

* page/mac/FrameSnapshottingMac.mm:
(WebCore::snapshotDragImage):
We shouldn't waste time painting an empty image, nor should we return
an image with no size.

Add a test that ensures that using a zero-size in-document non-<img>
element for setDragImage() doesn't crash.

* fast/events/setDragImage-in-document-element-crash-expected.txt: Added.
* fast/events/setDragImage-in-document-element-crash.html: Added.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
ShareableBitmap::createShareable can return null, but shouldn't dereference that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDotted borders render w/ artifacts and sometimes as solid lines
commit-queue@webkit.org [Wed, 31 Jul 2013 04:59:52 +0000 (04:59 +0000)]
Dotted borders render w/ artifacts and sometimes as solid lines
https://bugs.webkit.org/show_bug.cgi?id=3964

Patch by Pravin D <pravind@samsung.com> on 2013-07-30
Reviewed by Elliott Sprehn.

Source/WebCore:

While drawing the dotted border, the common borders are drawn by the cells sharing them. The dotted borders
become(tend) solid when the starting and the end points of the border drawn by the two cells don't match. This
fixes the same.

Test: fast/table/border-collapsing/dotted-collapsed-border.html

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::alignLeftRightBorderPaintRect):
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect):
 Helper function to decide if border's start point requires any adjustment.

(WebCore::RenderTableCell::paintCollapsedBorders):
Added logic to handle dotted borders so that they do not become solid.

* rendering/RenderTableCell.h:
 Helper function declarations.

LayoutTests:

* fast/table/border-collapsing/dotted-collapsed-border-expected.txt: Added.
* fast/table/border-collapsing/dotted-collapsed-border.html: Added.
* platform/qt/fast/table/border-collapsing/dotted-collapsed-border-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGmail reply email - Bold and Italic style get stuck
commit-queue@webkit.org [Wed, 31 Jul 2013 04:55:02 +0000 (04:55 +0000)]
Gmail reply email - Bold and Italic style  get stuck
https://bugs.webkit.org/show_bug.cgi?id=118185

Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-07-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

When bold/italic style is applied to a content with mixed editability,
style is applied appropriately for the first time.
But after this, style toggling does not work any more. Same behavior
can be observed when the content on which style is applied contains
text node without renderer (Ex: text node corresponding to tab/space etc)

When bold/italic style is applied on a selection, we actually apply the
style only for text nodes that have renderers and also are contenteditable.
Similarly during style toggling, to check whether a style has been already
applied on a selection

Tests: editing/style/toggle-style-bold-italic-mixed-editability.html
       editing/style/toggle-style-bold-italic.html

* editing/EditingStyle.cpp:
(WebCore::EditingStyle::triStateOfStyle):
A particular selection on which style is applied may contain text nodes
without renderers(text nodes corresponding to tab/space) or text nodes
that are not contenteditable. We do not apply style to such text nodes.
Hence, even during style toggling we should not consider the styles
present in such nodes.

LayoutTests:

Layout tests added to test bold/italic style toggling on a content
with mixed editability.

* editing/editing.js:
(runDumpAsTextEditingTest): Replaced markupResultList with
elementsForDumpingMarkupList to store all markup data to be logged
at the end of test.
(debugForDumpAsText): Changed to use elementsForDumpingMarkupList.
(startNewMarkupGroup): Added utility function to hold intermediate
data by separating <ol>.
* editing/style/toggle-style-bold-italic-expected.txt: Added.
* editing/style/toggle-style-bold-italic-mixed-editability-expected.txt: Added.
* editing/style/toggle-style-bold-italic-mixed-editability.html: Added.
* editing/style/toggle-style-bold-italic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoXMLSerializer should reset default namespace when necessary
rwlbuis@webkit.org [Wed, 31 Jul 2013 01:59:00 +0000 (01:59 +0000)]
XMLSerializer should reset default namespace when necessary
https://bugs.webkit.org/show_bug.cgi?id=16739
XMLSerializer's handling of namespaces seems to be pretty broken
https://bugs.webkit.org/show_bug.cgi?id=106531

Reviewed by Ryosuke Niwa.

Source/WebCore:

Write out empty default namespace declaration if the element is not in any namespace, as
described in http://www.whatwg.org/specs/web-apps/current-work/multipage/the-xhtml-syntax.html#xml-fragment-serialization-algorithm.

Tests: fast/dom/XMLSerializer-element-empty-namespace.html
       fast/dom/XMLSerializer-element-empty-namespace2.html

* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::appendOpenTag):
* editing/MarkupAccumulator.h:

LayoutTests:

Add tests based on the testcases of both bugs.

* fast/dom/XMLSerializer-element-empty-namespace-expected.txt: Added.
* fast/dom/XMLSerializer-element-empty-namespace.html: Added.
* fast/dom/XMLSerializer-element-empty-namespace2-expected.txt: Added.
* fast/dom/XMLSerializer-element-empty-namespace2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't post accessibility notification on object in detached document.
cfleizach@apple.com [Wed, 31 Jul 2013 01:50:16 +0000 (01:50 +0000)]
Don't post accessibility notification on object in detached document.
https://bugs.webkit.org/show_bug.cgi?id=119286

Reviewed by Ryosuke Niwa.

Merge https://chromium.googlesource.com/chromium/blink/+/ef9fc9e70202dcf33e5cf2f0f0a2135945ffe17e%5E%21/#F0

Don't post accessibility notification on object in detached document.

This can happen if an accessibility notification is queued on a node,
then that node is reparented to a different document that's not attached
anywhere before the accessibility notification is fired.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename <input type='color'> functions in WebPageProxy, WebColorPicker
commit-queue@webkit.org [Wed, 31 Jul 2013 00:58:27 +0000 (00:58 +0000)]
Rename <input type='color'> functions in WebPageProxy, WebColorPicker
<rdar://problem/14549771> and https://bugs.webkit.org/show_bug.cgi?id=119097

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-30
Reviewed by Tim Horton.

In bug 119025, WebColorChooserProxy was renamed WebColorPicker. This patch makes the UIProcess consistent
by renaming UIProcess INPUT_TYPE_COLOR functions from ...colorChooser to ...colorPicker.

* UIProcess/WebColorPicker.cpp:
(WebKit::WebColorPicker::endPicker):
* UIProcess/WebColorPicker.h:
* UIProcess/WebColorPickerResultListenerProxy.cpp:
(WebKit::WebColorPickerResultListenerProxy::setColor):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::setColorPickerColor):
(WebKit::WebPageProxy::endColorPicker):
(WebKit::WebPageProxy::didEndColorPicker):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/WebColorPickerQt.cpp:
(WebKit::WebColorPickerQt::createItem):
(WebKit::WebColorPickerQt::notifyColorSelected):
(WebKit::WebColorPickerQt::endPicker):
* UIProcess/qt/WebColorPickerQt.h:
* WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::setSelectedColor):
(WebKit::WebColorChooser::endChooser):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didEndColorPicker):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153504 268f45cc-cd09-0410-ab3c-d52691b4dbfc