WebKit-https.git
6 years agoMake CachedSVGDocumentReference independent of FilterOperation
krit@webkit.org [Thu, 22 Nov 2012 00:28:05 +0000 (00:28 +0000)]
Make CachedSVGDocumentReference independent of FilterOperation
https://bugs.webkit.org/show_bug.cgi?id=102967

Reviewed by Antti Koivisto.

Make CachedSVGDocumentReference independent of FilterOperation to reuse the code for clip-path and masking.

No new tests, refactoring.

* GNUmakefile.list.am: Move CachedSVGDocumentReference to it's proper location and it to the projects.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createFilterOperations):
* loader/cache/CachedSVGDocumentReference.h: Renamed from Source/WebCore/css/CachedSVGDocumentReference.h.
(WebCore):
(CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::document):
* platform/graphics/filters/FilterOperation.h: Rename data() and setData() to
    cachedSVGDocumentReference() and its setter. Adapt other classes.
(WebCore::FilterOperation::ReferenceFilterOperation::cachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(ReferenceFilterOperation):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):
* rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJavaScript fails to concatenate large strings
dbates@webkit.org [Thu, 22 Nov 2012 00:25:51 +0000 (00:25 +0000)]
JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Fixes an issue where we inadvertently didn't check the length of
a JavaScript string for overflow.

* runtime/Operations.h:
(JSC::jsString):
(JSC::jsStringFromArguments):

LayoutTests:

Add tests to ensure that we handle concatenating large strings.

* fast/js/concat-large-strings-crash-expected.txt: Added.
* fast/js/concat-large-strings-crash.html: Added.
* fast/js/concat-large-strings-crash2-expected.txt: Added.
* fast/js/concat-large-strings-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp
commit-queue@webkit.org [Thu, 22 Nov 2012 00:20:42 +0000 (00:20 +0000)]
[EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=102773

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

PageViewportControllerClientEfl.cpp doesn't need to include ewk_view_private.h.

* UIProcess/efl/PageViewportControllerClientEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the concept of initiatorDocument from CachedResourceRequest
simonjam@chromium.org [Thu, 22 Nov 2012 00:18:35 +0000 (00:18 +0000)]
Remove the concept of initiatorDocument from CachedResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=102855

Reviewed by Sam Weinig.

It turns out this isn't necessary for the new implementation of Resource Timing. Instead,
we can get at it from the CachedResourceLoader. I don't think anyone else needed it either.

No new tests. This was never used.

* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::load):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::cachedShader):
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::PreloadTask::preload):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setInitiator):
* loader/cache/CachedResourceRequest.h:
(CachedResourceRequest):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd fast/events/context-nodrag.html to Chromium Mac TestExpectations
fsamuel@chromium.org [Thu, 22 Nov 2012 00:16:09 +0000 (00:16 +0000)]
Add fast/events/context-nodrag.html to Chromium Mac TestExpectations

No review.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Resource Timing] Create W3C-style test suite
simonjam@chromium.org [Thu, 22 Nov 2012 00:13:31 +0000 (00:13 +0000)]
[Resource Timing] Create W3C-style test suite
https://bugs.webkit.org/show_bug.cgi?id=84883

Reviewed by Tony Gentilcore.

The tests are designed to be upstreamed. Eventually, the local ones will be replaced by the official upstream versions.

* http/tests/w3c/webperf/resources/Ahem.ttf: Added.
* http/tests/w3c/webperf/resources/all_resource_types.htm: Added.
* http/tests/w3c/webperf/resources/blank_image.png: Added.
* http/tests/w3c/webperf/resources/empty_script.js: Added.
* http/tests/w3c/webperf/resources/generate_resource.php: Added.
* http/tests/w3c/webperf/resources/gray_bg.css: Added.
(body):
* http/tests/w3c/webperf/resources/green_frame.htm: Added.
* http/tests/w3c/webperf/resources/inject_resource_test.html: Added.
* http/tests/w3c/webperf/resources/nested.css: Added.
(@font-face):
(ol):
* http/tests/w3c/webperf/resources/webperftestharness.js:
(test_greater_or_equals):
(test_fail):
(test_resource_entries):
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting.html: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types-expected.txt: Added.
* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html: Added.
* platform/chromium/TestExpectations: Skip these new tests until the flag is flipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPosition in QWebHitTestResult does not match documentation
allan.jensen@digia.com [Thu, 22 Nov 2012 00:03:08 +0000 (00:03 +0000)]
Position in QWebHitTestResult does not match documentation
https://bugs.webkit.org/show_bug.cgi?id=102909

Reviewed by Simon Hausmann.

Correct documentation and simplify using the new innerNodeFrame method.

* Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd fast/events/context-nodrag.html to Mac TestExpectations
fsamuel@chromium.org [Thu, 22 Nov 2012 00:02:50 +0000 (00:02 +0000)]
Add fast/events/context-nodrag.html to Mac TestExpectations

No review.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r135437.
commit-queue@webkit.org [Thu, 22 Nov 2012 00:02:23 +0000 (00:02 +0000)]
Unreviewed, rolling out r135437.
http://trac.webkit.org/changeset/135437
https://bugs.webkit.org/show_bug.cgi?id=102986

This patch causes crash to some layout tests (Requested by
jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::createRendererIfNeeded):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Drop Synchronous Mouse Events
commit-queue@webkit.org [Thu, 22 Nov 2012 00:00:07 +0000 (00:00 +0000)]
[BlackBerry] Drop Synchronous Mouse Events
https://bugs.webkit.org/show_bug.cgi?id=102980

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-21
Reviewed by Rob Buis.

Reviewed Internally by George Staikos, Mike Lattanzio and Mike Fenton.
Get rid of unneeded methods and simplify code.
Send click if getting context over an empty text field
so that it will be focused and have a caret.
PR #242781

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPage::touchEventCancel):
* Api/WebPage.h:
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
(BlackBerry::WebKit::TouchEventHandler::doFatFingers):
(BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
* WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStyle sharing: Compare class lists via SpaceSplitString instead of string comparison.
akling@apple.com [Wed, 21 Nov 2012 23:32:52 +0000 (23:32 +0000)]
Style sharing: Compare class lists via SpaceSplitString instead of string comparison.
<http://webkit.org/b/102982>

Reviewed by Antti Koivisto.

Add an operator!= to SpaceSplitString and use that check if two elements are eligible
for style sharing instead of comparing the fastGetAttribute(classAttr) return values.
This works because SpaceSplitString maps equal strings to the same data internally.

* css/StyleResolver.cpp:
(WebCore::haveIdenticalStyleAffectingAttributes):
* dom/SpaceSplitString.h:
(WebCore::SpaceSplitString::operator!=):
(SpaceSplitString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMulti-frame CUR file test hangs on mac port
commit-queue@webkit.org [Wed, 21 Nov 2012 23:30:34 +0000 (23:30 +0000)]
Multi-frame CUR file test hangs on mac port
https://bugs.webkit.org/show_bug.cgi?id=101811

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-21
Reviewed by Alexey Proskuryakov.

Fix tests to not hang on unexpected image load failure.
Expect multi-frame CUR files to fail to load on Mac.

* fast/events/mouse-cursor.html:
* fast/events/mouse-cursor-multiframecur.html:
* platform/mac/TestExpectations:
* platform/mac/fast/events/mouse-cursor-multiframecur-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics: refactor changing children code in CoordinatedGraphicsLayer.
commit-queue@webkit.org [Wed, 21 Nov 2012 23:21:41 +0000 (23:21 +0000)]
Coordinated Graphics: refactor changing children code in CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102896

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

When changing children, we don't need to sync a layer state because
there is no more need to send the parent ID every time the layer tree
hierarchy changes. So this patch removes didChangeLayerState() in
methods which change children.

In addition, purgeBackingStores() does not need to call didChangeChildren()
because purgeBackingStores() does not change children.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::removeFromParent):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse m_webView->size() for viewport update
commit-queue@webkit.org [Wed, 21 Nov 2012 23:09:25 +0000 (23:09 +0000)]
Use m_webView->size() for viewport update
https://bugs.webkit.org/show_bug.cgi?id=102764

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
Reviewed by Adam Barth.

m_webView->client()->windowRect() returns the outer rect of the browser
window, which includes the decorations such as the title bar.
We should use the size of the WebView for layout and rendering purpose.

Existing tests are updated to work without windowRect().

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
kpiascik@rim.com [Wed, 21 Nov 2012 23:01:23 +0000 (23:01 +0000)]
[BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
https://bugs.webkit.org/show_bug.cgi?id=102978

Reviewed by Rob Buis.

Internal PR 200848
We prevent screen from going dim when the front-end is connected and return to normal when
the front-end disconnects.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::enableWebInspector):
(BlackBerry::WebKit::WebPage::disableWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r135338, r135359, and r135378.
commit-queue@webkit.org [Wed, 21 Nov 2012 22:53:40 +0000 (22:53 +0000)]
Unreviewed, rolling out r135338, r135359, and r135378.
http://trac.webkit.org/changeset/135338
http://trac.webkit.org/changeset/135359
http://trac.webkit.org/changeset/135378
https://bugs.webkit.org/show_bug.cgi?id=102981

Likely caused a 10% regression in
dromaeo_domcoreattr/dom_attr_getAttribute (Requested by abarth
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateEventConstructorCallback):
(ConvertToV8Parameter):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
* bindings/v8/V8BindingMacros.h:
* bindings/v8/V8StringResource.h:
(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::V8Parameter::prepareBase):
(WebCore::V8Parameter::object):
(WebCore::::prepare):
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* bindings/v8/custom/V8IntentCustom.cpp:
(WebCore::V8Intent::constructorCallbackCustom):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getExtensionCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInvalidate non-composited content host when page scale factor changes
commit-queue@webkit.org [Wed, 21 Nov 2012 22:42:28 +0000 (22:42 +0000)]
Invalidate non-composited content host when page scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=100718

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
Reviewed by Adam Barth.

During a scale change, non-composited content layer doesn't get invalidated
automatically by the transformation change on RenderView. Need to force
update non-composited contents ourself.

Source/WebCore:

Test: compositing/repaint/page-scale-repaint.html

* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):

LayoutTests:

* compositing/repaint/page-scale-repaint-expected.png: Added.
* compositing/repaint/page-scale-repaint-expected.txt: Added.
* compositing/repaint/page-scale-repaint.html: Added.
* compositing/repaint/resources/grid.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoYet another EFL & GTK+ build fix after r135429.
rniwa@webkit.org [Wed, 21 Nov 2012 22:40:14 +0000 (22:40 +0000)]
Yet another EFL & GTK+ build fix after r135429.

* html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNode::createRenderer should never return null
commit-queue@webkit.org [Wed, 21 Nov 2012 22:36:02 +0000 (22:36 +0000)]
Node::createRenderer should never return null
https://bugs.webkit.org/show_bug.cgi?id=102975

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-21
Reviewed by Ojan Vafai.

Node::createRenderer should never return null, instead Node::rendererIsNeeded
should return false if a node doesn't wish to have a renderer. This method
never actually returns null right now, but the code makes it look like it
could.

No new tests, just refactoring.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::createRendererIfNeeded):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClear MousePressed state on context menu to avoid initiating a drag
fsamuel@chromium.org [Wed, 21 Nov 2012 22:34:01 +0000 (22:34 +0000)]
Clear MousePressed state on context menu to avoid initiating a drag
https://bugs.webkit.org/show_bug.cgi?id=101786

Reviewed by Ojan Vafai.

Source/WebCore:

If a user initiates a drag via left mouse down, brings up the context menu,
and then cancels the context menu while keeping the left mouse button down,
then the drag operation will continue. This does not match the platform
conventions on Windows, Linux or Mac .

This change cancels the drag if the context menu is about to be displayed.

Test: fast/events/context-nodrag.html

* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):

Tools:

* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::contextClick):
Only send a MouseUp on Windows. Keep the current mouse pressed state when
calling up a context menu.

LayoutTests:

If a user initiates a drag via left mouse down, brings up the context menu,
and then cancels the context menu while keeping the left mouse button down,
then the drag operation will continue. This does not match the platform
conventions on Windows, Linux or Mac .

This change cancels the drag if the context menu is about to be displayed.

* fast/events/context-nodrag.html: Added.
* fast/events/context-nodrag-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse MIMETypeRegistryWin for WinCE port too
paroga@webkit.org [Wed, 21 Nov 2012 22:31:40 +0000 (22:31 +0000)]
Use MIMETypeRegistryWin for WinCE port too
https://bugs.webkit.org/show_bug.cgi?id=102977

Reviewed by Laszlo Gombos.

r135217 made MIMETypeRegistryWin compile on WinCE too,
which allows us to get rid of MIMETypeRegistryWinCE.

* PlatformWinCE.cmake:
* WebCore.gypi:
* platform/wince/MIMETypeRegistryWinCE.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r135212): Fix crash due to an infinite rect.
commit-queue@webkit.org [Wed, 21 Nov 2012 22:24:56 +0000 (22:24 +0000)]
REGRESSION(r135212): Fix crash due to an infinite rect.
https://bugs.webkit.org/show_bug.cgi?id=102891

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

Source/WebKit2:

When CoordinatedGraphicsLayer has a 3D transform, tiledBackingStoreVisibleRect()
can calculate an infinite rect. However, TiledBackingStore cannot handle the
infinite rect. This patch clamps the infinite rect to avoid crash in
TiledBackingStore.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::clampToContentsRectIfRectIsInfinite):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):

LayoutTests:

fast/multicol/span/positioned-child-not-removed-crash.html now passes on
EFL.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
commit-queue@webkit.org [Wed, 21 Nov 2012 22:24:07 +0000 (22:24 +0000)]
[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Added a bunch of assertions to ensure the problems with IndexedDB
contexts cannot reemerge.

No new tests. No change in functionality.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore):
(WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unnecessary ternaries in createRendererIfNeeded
commit-queue@webkit.org [Wed, 21 Nov 2012 22:21:40 +0000 (22:21 +0000)]
Remove unnecessary ternaries in createRendererIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=102974

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-21
Reviewed by Ojan Vafai.

parentRenderer, nextRenderer and previousRenderer all handle flow
threads automatically so there's no reason to duplicate the check in
createRendererIfNeeded.

Note that while these methods first check the node for a renderer and
then delegate to the flow thread the node never has a renderer when
calling createRendererIfNeeded per the assertion at the top so this
change is equivalent.

No new tests, just refactoring.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::createRendererIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEFL and GTK+ build fix after r135429.
rniwa@webkit.org [Wed, 21 Nov 2012 22:02:56 +0000 (22:02 +0000)]
EFL and GTK+ build fix after r135429.

* dom/Element.cpp:
(WebCore::ElementRareData::ensureCachedHTMLCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Updated chromium test expectations to resolve lint failures.
jianli@chromium.org [Wed, 21 Nov 2012 21:52:18 +0000 (21:52 +0000)]
Unreviewed. Updated chromium test expectations to resolve lint failures.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTMLCollection should use the same storage as DynamicNodeList
rniwa@webkit.org [Wed, 21 Nov 2012 21:38:24 +0000 (21:38 +0000)]
HTMLCollection should use the same storage as DynamicNodeList
https://bugs.webkit.org/show_bug.cgi?id=102886

Reviewed by Antti Koivisto.

This patch removes ElementRareData::m_collection. HTMLCollections are now held by
NodeListNodeData in NodeRareData like DynamicNodeLists. This simplifies several
Element and Node functions where we used to call into both ElementRareData and
NodeRareData to invalidate caches.

This is a refactoring and there should be no behavioral change.

* dom/DynamicNodeList.h:
* dom/Element.cpp:
(WebCore::ElementRareData::ensureCachedHTMLCollection):
* dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::removeCachedHTMLCollection):
* dom/Node.cpp:
(WebCore::Node::invalidateNodeListCachesInAncestors):
* dom/NodeRareData.h:
(NodeListsNodeData):
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::cacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::adoptTreeScope):
(WebCore::NodeListsNodeData::namedNodeListKey):
* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
* html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::create):
* html/HTMLFormControlsCollection.h:
(HTMLFormControlsCollection):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::create):
* html/HTMLOptionsCollection.h:
(HTMLOptionsCollection::create):
* html/HTMLPropertiesCollection.h:
(HTMLPropertiesCollection::create):
* html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::create):
* html/HTMLTableRowsCollection.h:
(HTMLTableRowsCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate incorrect assertion in ImmutableElementAttributeData(MutableElementAttributeData).
akling@apple.com [Wed, 21 Nov 2012 21:29:40 +0000 (21:29 +0000)]
Update incorrect assertion in ImmutableElementAttributeData(MutableElementAttributeData).
<http://webkit.org/b/102972>

Reviewed by Antti Koivisto.

Manipulation by editing code may cause an element to have mutable inline style, and this is fine.

Change the assertion to confirm that the inline style doesn't have a CSSOM wrapper attached,
which is where real problems would happen.

Fixes an assertion on editing/undo/replace-by-span-then-remove.html

* dom/ElementAttributeData.cpp:
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Don't add empty rects to the tap highlight region.
kpiascik@rim.com [Wed, 21 Nov 2012 20:37:10 +0000 (20:37 +0000)]
[BlackBerry] Don't add empty rects to the tap highlight region.
https://bugs.webkit.org/show_bug.cgi?id=102966

Reviewed by George Staikos.

Internal PR 246960
Tap highlight is way too large sometimes.
When we add an empty rect it inflates by 2 and causes the tap region to extend to the origin.

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove $outputDir and $outputHeadersDir from global variables of code generators
haraken@chromium.org [Wed, 21 Nov 2012 20:29:21 +0000 (20:29 +0000)]
Remove $outputDir and $outputHeadersDir from global variables of code generators
https://bugs.webkit.org/show_bug.cgi?id=102492

Reviewed by Adam Barth.

$outputDir and $outputHeadersDir are used in WriteData() only.
We don't need to use global variables for them.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
(FileNamePrefix):
* bindings/scripts/CodeGeneratorCPP.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorGObject.pm:
(new):
(WriteData):
(GenerateInterface):
* bindings/scripts/CodeGeneratorJS.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorObjC.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorV8.pm:
(new):
(GenerateInterface):
(WriteData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WTF/wtf/Assertions.cpp: fix build on a uClibc system
commit-queue@webkit.org [Wed, 21 Nov 2012 20:24:18 +0000 (20:24 +0000)]
Source/WTF/wtf/Assertions.cpp: fix build on a uClibc system
https://bugs.webkit.org/show_bug.cgi?id=102946

Patch by Anthony G. Basile <blueness@gentoo.org> on 2012-11-21
Reviewed by Tony Chang.

Webkit-Gtk fails to build on a uClibc system because
Assertions.cpp assumes that all Linux systems have execinfo.h
and provide backtrace(). This is not necessarily the case for
uClibc which can be configured without these.  This patch
refines the check for OS(LINUX) to prevent this breakage.
Originally reported at https://bugs.gentoo.org/441674

* wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove IDBDatabaseException
jsbell@chromium.org [Wed, 21 Nov 2012 20:13:39 +0000 (20:13 +0000)]
Remove IDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=102514

Reviewed by Adam Barth.

Source/WebCore:

After the WebKit implementation landed, the IndexedDB spec changed from defining new
exception codes with constants hanging off an interface to using DOM4-styled named
DOMExceptions. Remove the IDBDatabaseException interface and set codes for IDB-specific
exceptions to 0. (The .idl file is retained pending general ExceptionCode cleanup.)

Also remove IDBRequest.errorCode which was used for reporting asynchronous errors;
IDBRequest.error - a DOMError - should be used instead.

No new tests - covered by plenty of existing tests which have been updated.

* Modules/indexeddb/DOMWindowIndexedDatabase.idl: Don't expose the interface.
* Modules/indexeddb/IDBCursor.idl: Remove reference to IDBDatabaseException.
* Modules/indexeddb/IDBDatabase.idl: Ditto.
* Modules/indexeddb/IDBDatabaseException.cpp:
(IDBDatabaseExceptionNameDescription): Use either a DOMException code or 0.
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getLegacyErrorCode):
* Modules/indexeddb/IDBFactory.idl: Remove reference to IDBDatabaseException.
* Modules/indexeddb/IDBIndex.idl: Ditto.
* Modules/indexeddb/IDBKeyRange.idl: Ditto.
* Modules/indexeddb/IDBObjectStore.idl: Ditto.
* Modules/indexeddb/IDBRequest.idl: Ditto.
* Modules/indexeddb/IDBTransaction.idl: Ditto.
* Modules/indexeddb/WorkerContextIndexedDatabase.idl: Don't expose the interface.
* bindings/v8/IDBBindingUtilities.cpp: Remove unneeded #include.

LayoutTests:

Remove references to IDBDatabaseException - DOMExceptions should be thrown with code 0 and
a name. Remove references to IDBRequest.errorCode - IDBRequest.error is the new hawtness,
and already tested for. Ensure those objects/properties are gone in removed.html

* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/constants.html: Removed.
* storage/indexeddb/constants-expected.txt: Removed.
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/cursor-continue-dir-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/exceptions-expected.txt:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/get-keyrange-expected.txt:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/mozilla/add-twice-failure-expected.txt:
* storage/indexeddb/mozilla/bad-keypath-expected.txt:
* storage/indexeddb/mozilla/clear-expected.txt:
* storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
* storage/indexeddb/mozilla/readonly-transactions-expected.txt:
* storage/indexeddb/mozilla/resources/add-twice-failure.js:
* storage/indexeddb/mozilla/resources/bad-keypath.js:
* storage/indexeddb/mozilla/resources/clear.js:
* storage/indexeddb/mozilla/resources/indexes.js: Elide obsolete comment.
* storage/indexeddb/mozilla/resources/key-requirements-delete-null-key.js:
* storage/indexeddb/mozilla/resources/key-requirements-inline-and-passed.js:
* storage/indexeddb/mozilla/resources/key-requirements-put-no-key.js:
* storage/indexeddb/mozilla/resources/key-requirements-put-null-key.js:
* storage/indexeddb/mozilla/resources/readonly-transactions.js:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/removed-expected.txt:
* storage/indexeddb/resources/basics.js:
* storage/indexeddb/resources/constants.js: Removed.
* storage/indexeddb/resources/create-and-remove-object-store.js:
* storage/indexeddb/resources/cursor-continue-dir.js:
* storage/indexeddb/resources/cursor-continue.js:
* storage/indexeddb/resources/cursor-update.js:
* storage/indexeddb/resources/deleteIndex.js:
* storage/indexeddb/resources/exceptions.js:
* storage/indexeddb/resources/factory-cmp.js:
* storage/indexeddb/resources/get-keyrange.js:
* storage/indexeddb/resources/index-basics.js:
* storage/indexeddb/resources/index-count.js:
* storage/indexeddb/resources/index-unique.js:
* storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:
* storage/indexeddb/resources/invalid-keys.js:
* storage/indexeddb/resources/key-generator.js:
* storage/indexeddb/resources/key-type-array.js:
* storage/indexeddb/resources/keypath-edges.js:
* storage/indexeddb/resources/keyrange.js:
* storage/indexeddb/resources/objectstore-autoincrement.js:
* storage/indexeddb/resources/objectstore-basics.js:
* storage/indexeddb/resources/objectstore-count.js:
* storage/indexeddb/resources/open-cursor.js:
* storage/indexeddb/resources/readonly.js:
* storage/indexeddb/resources/removed.js:
* storage/indexeddb/resources/shared.js:
* storage/indexeddb/resources/transaction-abort.js:
* storage/indexeddb/resources/transaction-active-flag.js:
* storage/indexeddb/resources/transaction-basics.js:
* storage/indexeddb/resources/transaction-complete-workers.js:
* storage/indexeddb/resources/transaction-error.js:
* storage/indexeddb/resources/transaction-read-only.js:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-active-flag-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-complete-workers-expected.txt:
* storage/indexeddb/transaction-error-expected.txt:
* storage/indexeddb/transaction-read-only-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Fix indenting in RenderThemeChromiumSkia.h.
wjmaclean@chromium.org [Wed, 21 Nov 2012 20:10:25 +0000 (20:10 +0000)]
[chromium] Fix indenting in RenderThemeChromiumSkia.h.
https://bugs.webkit.org/show_bug.cgi?id=102965

Reviewed by Adam Barth.

Much of RenderThemeChromiumSkia.h was indented too far, making the
file confusing to read. This CL removes the extra indents.

* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds...
mifenton@rim.com [Wed, 21 Nov 2012 19:52:47 +0000 (19:52 +0000)]
[BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds check
https://bugs.webkit.org/show_bug.cgi?id=102962

Reviewed by Rob Buis.

PR 247270.

Switch from using VisiblePosition to determine if we are in a node
to a comparison of the field bounds.  This fixes the case where
there is no node before the target node to match.

Reviewed Internally by Gen Mak.

* WebKitSupport/DOMSupport.cpp:
* WebKitSupport/DOMSupport.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake it possible for elements with different tag names to share attribute data.
akling@apple.com [Wed, 21 Nov 2012 19:05:17 +0000 (19:05 +0000)]
Make it possible for elements with different tag names to share attribute data.
<http://webkit.org/b/102845>

Reviewed by Antti Koivisto.

Allow all elements to share ElementAttributeData with one another. This means that the elements
in this hypothetical markup will all point to the same attribute data:

    <div class="foo">
        <span class="foo">
            <hr class="foo"/>
        </span>
    </div>

This optimization happens at the expense of an old one. We no longer share attribute data
between elements that have presentation attributes, since they map to different CSS properties
depending on what tag they're attached to. These are mostly used in ye olde web 1.0 content
though, and we should prefer optimizing in favor of modern markup. The global cache for
presentation attribute style in StyledElement.cpp still prevents redundant parsing.

On the upside, excluding elements with presentation attributes from the data cache means that
we can move one pointer (m_presentationAttributeStyle) from ImmutableElementAttributeData
to MutableElementAttributeData.

800kB progression on Membuster3.

* dom/Document.h:
* dom/Document.cpp:
(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheKey):
(WebCore::Document::cachedImmutableAttributeData):
* dom/Element.cpp:
(WebCore::Element::parserSetAttributes):

    Don't use the element's tag name in the key for the immutable attribute data cache.

(WebCore::Element::cloneAttributesFromElement):

    Prevent cloneNode() from converting mutable attribute data to immutable if it has
    presentation attributes.

* dom/ElementAttributeData.cpp:
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):

    Add an assertion that mutable-to-immutable conversion never happens with presentation
    attribute style present.

(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/ElementAttributeData.h:
(ElementAttributeData):
(MutableElementAttributeData):
(WebCore::ElementAttributeData::presentationAttributeStyle):
(WebCore):
(WebCore::ElementAttributeData::setPresentationAttributeStyle):

    Move the RefPtr<StylePropertySet> that holds presentation attribute-derived style
    from the common ElementAttributeData base class to MutableElementAttributeData.

* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):

    Always dirty the presentation attribute style when a presentation attribute changes.

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

    Force promotion to mutable attribute data when it turns out that we need to hang a
    StylePropertySet with the presentation attribute style off of it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoupdate expectations in advance of skia deps roll
reed@google.com [Wed, 21 Nov 2012 18:54:26 +0000 (18:54 +0000)]
update expectations in advance of skia deps roll
https://bugs.webkit.org/show_bug.cgi?id=102964

Reviewed by NOBODY. expectations change only.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace NodeRendererFactory class with a function
antti@apple.com [Wed, 21 Nov 2012 18:53:09 +0000 (18:53 +0000)]
Replace NodeRendererFactory class with a function
https://bugs.webkit.org/show_bug.cgi?id=102950

Reviewed by Andreas Kling.

Simplify the code by turning NodeRendererFactory single-use class into function of NodeRenderingContext.

* dom/Node.cpp:
(WebCore::Node::createRendererIfNeeded):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererIfNeeded):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
(WebCore::NodeRenderingContext::style):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Change default tap highlight color for Chromium Windows & Linux.
wjmaclean@chromium.org [Wed, 21 Nov 2012 18:52:19 +0000 (18:52 +0000)]
[chromium] Change default tap highlight color for Chromium Windows & Linux.
https://bugs.webkit.org/show_bug.cgi?id=102939

Reviewed by Adam Barth.

Change default tap highlight colour on Chromium Win/Linux to be 18% black.

* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia): Override platformTapHighlightColor() to change default highlight colour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] webkit_unit_tests should depend on forwarder2 for Android
peter@chromium.org [Wed, 21 Nov 2012 18:43:21 +0000 (18:43 +0000)]
[Chromium] webkit_unit_tests should depend on forwarder2 for Android
https://bugs.webkit.org/show_bug.cgi?id=102934

Reviewed by Tony Chang.

Running webkit_unit_tests and TestWebKitAPI in the WebKit tree will defer
to the test runner used by Chromium, which in turn relies on forwarder2.
forwarder2 will eventually be required by layout tests as well.

* WebKitUnitTests.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRelayout the slider track when a data list is set
tony@chromium.org [Wed, 21 Nov 2012 18:21:19 +0000 (18:21 +0000)]
Relayout the slider track when a data list is set
https://bugs.webkit.org/show_bug.cgi?id=102851

Reviewed by Ojan Vafai.

Previously, we would relayout the <input>.  Once we fix bug 102352, this
causes the slider track to not relayout.  It should relayout because it
draws the data list tick marks and needs to provide space for them.

No new tests, not testable until bug 102352 is fixed. Specifically,
fast/forms/datalist/update-range-with-datalist.html reveals the bug.

* html/RangeInputType.cpp:
(WebCore::RangeInputType::listAttributeTargetChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r135409.
commit-queue@webkit.org [Wed, 21 Nov 2012 18:20:16 +0000 (18:20 +0000)]
Unreviewed, rolling out r135409.
http://trac.webkit.org/changeset/135409
https://bugs.webkit.org/show_bug.cgi?id=102959

This patch causes compiling error to Chromium build (Requested
by jianli_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

* tests/IDBRequestTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Add flag to enable/disable touch adjustment at runtime.
commit-queue@webkit.org [Wed, 21 Nov 2012 18:09:22 +0000 (18:09 +0000)]
[chromium] Add flag to enable/disable touch adjustment at runtime.
https://bugs.webkit.org/show_bug.cgi?id=102534

Patch by Kevin Ellis <kevers@chromium.org> on 2012-11-21
Reviewed by Antonio Gomes.

Source/WebCore:

Add setting for enabling or disabling touch adjustment.  Note that for
touch adjustment to apply, the compile flag must also be enabled.  A
compile only option is insufficient as it does not allow developers to
quickly test the impact of touch adjustemnt without recompiling.  Nor
does it allow end users to disable touch adjustemnt if they find that
touch adjustment is not working well for a particular site.

No new tests required.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent): Move enable check to adjustGesturePosition.
(WebCore::EventHandler::handleGestureTap): Move enable check to adjustGesturePosition.
(WebCore::EventHandler::shouldApplyTouchAdjustment): Checks if touch adjustment is enabled.
(WebCore):
(WebCore::EventHandler::adjustGesturePosition): Add check for enabling of touch adjustment.
(WebCore::EventHandler::sendContextMenuEventForGesture): Move enable check to adjustGesturePosition.
* page/EventHandler.h:
(EventHandler):
* page/Settings.in:

Source/WebKit/chromium:

Add setting for enabling or disabling touch adjustment.
For touch adjustemnt to apply, the compile option must
also be enabled.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setEnableTouchAdjustment):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, build fix after r135410.
philn@webkit.org [Wed, 21 Nov 2012 17:58:08 +0000 (17:58 +0000)]
Unreviewed, build fix after r135410.

* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::addCue): Prevent unused parameter error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Ctrl+A closes breakpoint condition editor
commit-queue@webkit.org [Wed, 21 Nov 2012 17:34:21 +0000 (17:34 +0000)]
Web Inspector: Ctrl+A closes breakpoint condition editor
https://bugs.webkit.org/show_bug.cgi?id=102906

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-11-21
Reviewed by Pavel Feldman.

Check if e.target has no ancestors with className
"webkit-line-decorations" in DefaultTextEditor._handleKeyDown

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._handleKeyDown): Add check

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid creating degenerate cubics at corners of rounded rects.
commit-queue@webkit.org [Wed, 21 Nov 2012 17:28:05 +0000 (17:28 +0000)]
Avoid creating degenerate cubics at corners of rounded rects.
https://bugs.webkit.org/show_bug.cgi?id=102945

Patch by Tom Hudson <tomhudson@chromium.org> on 2012-11-21
Reviewed by Stephen White.

Covered by existing layout tests.

* platform/graphics/Path.cpp:
(Path::addBeziersForRoundedRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIn-band text tracks infrastructure
eric.carlson@apple.com [Wed, 21 Nov 2012 17:18:00 +0000 (17:18 +0000)]
In-band text tracks infrastructure
https://bugs.webkit.org/show_bug.cgi?id=102830

Reviewed by Philippe Normand.

Add the infrastructure necessary to allow a port-specific media engine to expose in-band text
tracks.

No new tests, this patch only adds plumbing. Existing tests verify that these changes don't
break existing functionality.

* CMakeLists.txt: Add new project files.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState): Call processInbandTextTracks when readyState reaches
    HAVE_METADATA
(WebCore::HTMLMediaElement::processInbandTextTracks): Fetch the in-band text tracks from the
    media player and processes them.
* html/HTMLMediaElement.h:

* html/track/InbandTextTrack.cpp: Added.
* html/track/InbandTextTrack.h: Added.
* html/track/InbandTextTrackPrivate.h: Added.

* html/track/TextTrack.h:
(TextTrack):
(WebCore::TextTrack::clearClient): Remove virtual, it is unnecessary
(WebCore::TextTrack::mode): Make virtual so derived classes can override.
(WebCore::TextTrack::setMode): Ditto.

* html/track/TextTrackList.cpp:
(TextTrackList::length): Update to deal with in-band tracks.
(TextTrackList::getTrackIndex): Ditto.
(TextTrackList::getTrackIndexRelativeToRenderedTracks): Ditto.
(TextTrackList::item): Ditto.
(TextTrackList::invalidateTrackIndexesAfterTrack): New, invalidate the cached track indexes of
    all tracks after another.
(TextTrackList::append): Update to deal with in-band tracks.
(TextTrackList::remove): Update to deal with in-band tracks.
(TextTrackList::scheduleAddTrackEvent): Remove typo.
* html/track/TextTrackList.h:

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::getTextTracks): New, pass through to the media engine.
(WebCore::MediaPlayer::setTextTrackClient):
* platform/graphics/MediaPlayer.h:

* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setPreload): Cleanup.
(WebCore::MediaPlayerPrivateInterface::sourceEndOfStream): Ditto.
(WebCore::MediaPlayerPrivateInterface::getTextTracks): New client method.
(WebCore::MediaPlayerPrivateInterface::setTextTrackClient): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDBRequestTest needs a v8 context
commit-queue@webkit.org [Wed, 21 Nov 2012 17:17:07 +0000 (17:17 +0000)]
IDBRequestTest needs a v8 context
https://bugs.webkit.org/show_bug.cgi?id=102941

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Jochen Eisinger.

Added v8 context to IDBRequestTest tests.

* tests/IDBRequestTest.cpp:
(IDBRequestTest):
(WebKit::IDBRequestTest::IDBRequestTest):
(WebKit::IDBRequestTest::context):
(WebKit::IDBRequestTest::scriptExecutionContext):
(WebKit):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] gardening: fast/writing-mode/japanese-ruby-* are flaky
commit-queue@webkit.org [Wed, 21 Nov 2012 16:01:17 +0000 (16:01 +0000)]
[EFL][WK2] gardening: fast/writing-mode/japanese-ruby-* are flaky
https://bugs.webkit.org/show_bug.cgi?id=102921

Unreviewed gardening: several tests fail if run after any test that
changes font family mappings. Mark them flaky.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [Qt] MinGW: Explicitly add OpenGL library dependencies
commit-queue@webkit.org [Wed, 21 Nov 2012 15:58:55 +0000 (15:58 +0000)]
Source/WebCore: [Qt] MinGW: Explicitly add OpenGL library dependencies
https://bugs.webkit.org/show_bug.cgi?id=102924

Patch by Kai Koehne <kai.koehne@digia.com> on 2012-11-21
Reviewed by Simon Hausmann.

Adding the dependencies to WebKit1 is too late, because linking will have already failed. Also make sure that
the we link against OpenGLES1 e.g. for Angle.

* WebCore.pri:

Source/WebKit: [Qt] MinGW: Don't add OpenGL library dependencies here
https://bugs.webkit.org/show_bug.cgi?id=102924

Patch by Kai Koehne <kai.koehne@digia.com> on 2012-11-21
Reviewed by Simon Hausmann.

As the comment suggests the dependency is already for WebCore, so add it there instead.

* WebKit1.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Wed, 21 Nov 2012 15:55:22 +0000 (15:55 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Disambiguate innerNodeFramePoint and mainFramePoint
allan.jensen@digia.com [Wed, 21 Nov 2012 15:45:42 +0000 (15:45 +0000)]
Source/WebCore: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Splits the point() method in HitTestResult into two, innerNodeFramePoint and mainFramePoint().
To do this HitTestResult no longer inherits publically from HitTestLocation, which should also
help to later separate the two classes completely.

Many of the call-sites of hitTestResultAtPoint confuses which coordinates the point is in.
These have not have been fixed in this patch, and they should be audited by the individual ports.

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
* page/EventHandler.cpp:
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
    Set and maintain pointInMainFrame on the HitTestResult.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
    Construct pointInMainFrame as a copy of pointInInnerNodeFrame. This is correct
    for all hit-tests outside of the recursion in EventHandler::hitTestResultAtPoint.
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::innerNodeFrame):
(WebCore::HitTestResult::append):
* rendering/HitTestResult.h:
(WebCore::HitTestLocation::point):
(HitTestResult):
    Inherits protected now from HitTestLocation to avoid exposing the ambiguous
    point() and roundedPoint() methods.
    HitTestResult will be split completely from HitTestLocation in a later patch.
(WebCore::HitTestResult::isRectBasedTest):
(WebCore::HitTestResult::pointInMainFrame):
(WebCore::HitTestResult::roundedPointInMainFrame):
(WebCore::HitTestResult::setPointInMainFrame):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(WebCore::HitTestResult::roundedPointInInnerNodeFrame):
(WebCore::HitTestResult::localPoint):
(WebCore::HitTestResult::setLocalPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):

Source/WebKit/chromium: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::mouseDidMoveOverElement):
* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::characterIndexForPoint):

Source/WebKit/efl: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):

Source/WebKit/gtk: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switched to using point in innerNodeFrame. While the use here seems wrong it has been
left functionally unchanged to be fixed by a later patch.

* webkit/webkithittestresult.cpp:
(WebKit::kit):

Source/WebKit/mac: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switch to using HitTestResult::innerNodeFrame and HitTestResult::innerNodeFramePoint.

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::showContextMenu):

Source/WebKit/qt: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

* Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
* Api/qwebpage.cpp:
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):

Source/WebKit/win: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

* WebView.cpp:
(WebView::handleContextMenuEvent):

Source/WebKit2: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switch to using HitTestResult::innerNodeFrame and HitTestResult::innerNodeFramePoint.

* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::characterIndexForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Qt/Windows build fix.
hausmann@webkit.org [Wed, 21 Nov 2012 15:30:56 +0000 (15:30 +0000)]
Unreviewed Qt/Windows build fix.
https://bugs.webkit.org/show_bug.cgi?id=102787

Remove inclusion of QtQml, which drags in QtNetwork, which drags in qnetworksession.h, which
defines a member function called "interface". Since windows headers also define a pre-processor
macro called "interface", it has to do that. However we have now a dependency between combaseapi.h,
which #defines interface and is included earlier (before qnetworksession.h) and shlwapi.h, which _needs_
the interface macro and is included afterwards. Since this module-wide QtQml inclusion is unnecessary
and just slows down the build, this patch removes it.

* UIProcess/API/qt/qwebkittest_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Link highlight should display for at least 100ms, and fadeout on GestureTa...
wjmaclean@chromium.org [Wed, 21 Nov 2012 15:30:51 +0000 (15:30 +0000)]
[chromium] Link highlight should display for at least 100ms, and fadeout on GestureTap/Longpress.
https://bugs.webkit.org/show_bug.cgi?id=102823

Reviewed by Adrienne Walker.

Link highlights sometimes disappear so quickly they barely display. Modify
so that the highlight is displayed for minimum 100ms before fading out, and
also fadeout (as opposed to abrupt clear) on GestureTap and GestureLongPress.

* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimationIfNeeded): Check if min duration achieved, if not add time to fadeout animation.
* src/LinkHighlight.h:
(LinkHighlight):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent): Fadeout instead of clear on GestureTap and GestureLongPress.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Reverted expectation changes from r135380 and marked css3/filters/effect...
yurys@chromium.org [Wed, 21 Nov 2012 15:17:19 +0000 (15:17 +0000)]
Unreviewed. Reverted expectation changes from r135380 and marked css3/filters/effect-reference-ordering-hw.html as crashing
https://bugs.webkit.org/show_bug.cgi?id=102898

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics: refactor LayerTreeRenderer::syncRemoteContent().
commit-queue@webkit.org [Wed, 21 Nov 2012 15:11:45 +0000 (15:11 +0000)]
Coordinated Graphics: refactor LayerTreeRenderer::syncRemoteContent().
https://bugs.webkit.org/show_bug.cgi?id=102900

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

Currently, QQuickWebPage::updatePaintNode() calls
LayerTreeRenderer::syncRemoteContent() with locking the main thread.
syncRemoteContent() is heavy, so we should not call syncRemoteContent() in
updatePaintNode(). Calling syncRemoteContent() in the painting thread is
thread-safe because syncRemoteContent() does not access any data
structures, which the main thread use.

After this patch, syncRemoteContent() is used only internally, so
syncRemoteContent() becomes private.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::updatePaintNode):
* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::paint):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit::LayerTreeRenderer::ensureRootLayer):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Gardening: svg/foreignObject/viewport-foreignobject-crash.html is flaky
commit-queue@webkit.org [Wed, 21 Nov 2012 15:10:25 +0000 (15:10 +0000)]
[EFL] Gardening: svg/foreignObject/viewport-foreignobject-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=102931

Unreviewed gardening.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Viewport meta tag broken after r134801
abecsi@webkit.org [Wed, 21 Nov 2012 15:08:02 +0000 (15:08 +0000)]
[WK2] Viewport meta tag broken after r134801
https://bugs.webkit.org/show_bug.cgi?id=102801

Reviewed by Kenneth Rohde Christiansen.

If the initial-scale attribute is not explicitly specified it is left -1 by the
viewport meta algorithm and if the content is not scalable the min and max scales
are restricted by restrictScaleFactorToInitialScaleIfNotUserScalable() which resulted
in negative scales on the UI side.
Make sure that the minimum scale to fit the viewport is calculated before restricting
the scales and use this scale as the initial scale if no explicit initial scale was set.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::updateMinimumScaleToFit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
commit-queue@webkit.org [Wed, 21 Nov 2012 15:07:55 +0000 (15:07 +0000)]
[EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
https://bugs.webkit.org/show_bug.cgi?id=102895

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

Change the link order so it wont override the new operator on gtest.
Looks like it was crashing because an allocator mismatch (using libc's
new and later fastMalloc delete. Thanks to Kangil Han for hinting on
the fastMalloc issue.

* TestWebKitAPI/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Now that offending patch has been rolled out reenable IDBRequestTest...
yurys@chromium.org [Wed, 21 Nov 2012 14:46:44 +0000 (14:46 +0000)]
Unreviewed. Now that offending patch has been rolled out reenable IDBRequestTest.EventsAfterStopping
https://bugs.webkit.org/show_bug.cgi?id=102929

* tests/IDBRequestTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r135383.
yurys@chromium.org [Wed, 21 Nov 2012 14:40:23 +0000 (14:40 +0000)]
Unreviewed, rolling out r135383.
http://trac.webkit.org/changeset/135383
https://bugs.webkit.org/show_bug.cgi?id=102935

IDBRequestTest.* unit tests are failing (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening, unskip a now passing test.
ossy@webkit.org [Wed, 21 Nov 2012 14:27:33 +0000 (14:27 +0000)]
Unreviewed gardening, unskip a now passing test.

* platform/mac-wk2/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Support Context Menu
gyuyoung.kim@samsung.com [Wed, 21 Nov 2012 14:24:54 +0000 (14:24 +0000)]
[EFL][WK2] Support Context Menu
https://bugs.webkit.org/show_bug.cgi?id=96200

Reviewed by Laszlo Gombos.

Source/WebCore:

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
EFL port also doesn't hide unavailable menus as gtk port.

Source/WebKit2:

This patch supports WK2 EFL's context menu as WK1 implementation because we can't use elementary in inside WebKit.
Only basic functionalities of context menu are supported. Beside this implementation follows GTK's implementation.
For example, ewk_context_menu_new, ewk_context_menu_item_append, ewk_context_menu_item_remove are supported.

In addition, ewk_defines.h file is added in order to support cross inclusion as GTK port.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::showContextMenu):
(EwkViewImpl::hideContextMenu):
* UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
* UIProcess/API/efl/ewk_context_menu.cpp: Added.
(EwkContextMenu::EwkContextMenu):
(EwkContextMenu::~EwkContextMenu):
(EwkContextMenu::hide):
(Ewk_Context_Menu::appendItem):
(Ewk_Context_Menu::removeItem):
(EwkContextMenu::contextMenuItemSelected):
(ewk_context_menu_new):
(ewk_context_menu_new_with_items):
(ewk_context_menu_item_append):
(ewk_context_menu_item_remove):
(ewk_context_menu_hide):
(ewk_context_menu_items_get):
(ewk_context_menu_item_select):
* UIProcess/API/efl/ewk_context_menu.h: Added.
* UIProcess/API/efl/ewk_context_menu_item.cpp: Added.
(EwkContextMenuItem::EwkContextMenuItem):
(ewk_context_menu_item_new):
(ewk_context_menu_item_new_with_submenu):
(ewk_context_menu_item_type_get):
(ewk_context_menu_item_type_set):
(ewk_context_menu_item_action_get):
(ewk_context_menu_item_action_set):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_title_set):
(ewk_context_menu_item_checked_get):
(ewk_context_menu_item_checked_set):
(ewk_context_menu_item_enabled_get):
(ewk_context_menu_item_enabled_set):
* UIProcess/API/efl/ewk_context_menu_item.h: Added.
* UIProcess/API/efl/ewk_context_menu_item_private.h: Added.
(EwkContextMenuItem):
(EwkContextMenuItem::create):
(EwkContextMenuItem::action):
(EwkContextMenuItem::setAction):
(EwkContextMenuItem::title):
(EwkContextMenuItem::setTitle):
(EwkContextMenuItem::type):
(EwkContextMenuItem::setType):
(EwkContextMenuItem::checked):
(EwkContextMenuItem::setChecked):
(EwkContextMenuItem::enabled):
(EwkContextMenuItem::setEnabled):
* UIProcess/API/efl/ewk_context_menu_private.h: Added.
(WebKit):
(EwkContextMenu):
(EwkContextMenu::create):
(EwkContextMenu::items):
* UIProcess/API/efl/ewk_defines.h: Added.
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_context_menu.cpp: Added.
(checkBasicContextMenuItem):
(showContextMenu):
(TEST_F):
* UIProcess/efl/ContextMenuClientEfl.cpp: Added.
(toContextClientEfl):
(ContextMenuClientEfl::ContextMenuClientEfl):
(ContextMenuClientEfl::getContextMenuFromProposedMenu):
* UIProcess/efl/ContextMenuClientEfl.h: Added.
(WebKit):
(ContextMenuClientEfl):
(WebKit::ContextMenuClientEfl::create):
* UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::createContextMenuProxy):
* UIProcess/efl/WebContextMenuProxyEfl.cpp: Added.
(WebKit):
(WebKit::WebContextMenuProxyEfl::WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::~WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::showContextMenu):
(WebKit::WebContextMenuProxyEfl::hideContextMenu):
(WebKit::WebContextMenuProxyEfl::contextMenuItemSelected):
* UIProcess/efl/WebContextMenuProxyEfl.h: Added.
(WebKit):
(WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed Mac build fix after http://trac.webkit.org/changeset/135390.
fmalita@chromium.org [Wed, 21 Nov 2012 14:03:58 +0000 (14:03 +0000)]
[Chromium] Unreviewed Mac build fix after trac.webkit.org/changeset/135390.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::drawInnerPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Gardening: css3/device-adapt/opera/constrain-006 and -007 fail
commit-queue@webkit.org [Wed, 21 Nov 2012 13:53:23 +0000 (13:53 +0000)]
[EFL][WK2] Gardening: css3/device-adapt/opera/constrain-006 and -007 fail
https://bugs.webkit.org/show_bug.cgi?id=102923

Unreviewed gardening: these two still fail after using fixed layout in WTR.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Disable failing test.
yurys@chromium.org [Wed, 21 Nov 2012 13:45:21 +0000 (13:45 +0000)]
Unreviewed. Disable failing test.
https://bugs.webkit.org/show_bug.cgi?id=102929

* tests/IDBRequestTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Skia] Encapsulate access to PlatformContextSkia's SkCanvas
fmalita@chromium.org [Wed, 21 Nov 2012 13:42:19 +0000 (13:42 +0000)]
[Skia] Encapsulate access to PlatformContextSkia's SkCanvas
https://bugs.webkit.org/show_bug.cgi?id=102694

Reviewed by Stephen White.

Source/WebCore:

Add SkCanvas-equivalent methods to PlatformContextSkia, and refactor direct canvas call
sites to use these wrappers instead. This reduces the number of canvas() users from 90+
to 22 (mostly theme/ui code).

No new tests: refactoring only.

* platform/chromium/PlatformThemeChromiumLinux.cpp:
(WebCore::PlatformThemeChromiumLinux::paintArrowButton):
* platform/graphics/chromium/FontChromiumWin.cpp:
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::computeLayerSize):
(WebCore::TransparencyWin::compositeOpaqueComposite):
(WebCore::TransparencyWin::compositeTextComposite):
(WebCore::TransparencyWin::makeLayerOpaque):
* platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::platformApplySkia):
* platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::FEColorMatrix::platformApplySkia):
* platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
(WebCore::FEComponentTransfer::platformApplySkia):
* platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::platformApplySkia):
* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::drawOuterPath):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap):
(WebCore::hasNon90rotation):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::save):
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
(WebCore::PlatformContextSkia::restore):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::layerBitmap):
(WebCore):
(WebCore::PlatformContextSkia::readPixels):
(WebCore::PlatformContextSkia::writePixels):
(WebCore::PlatformContextSkia::isDrawingToLayer):
(WebCore::PlatformContextSkia::isVector):
(WebCore::PlatformContextSkia::clipPath):
(WebCore::PlatformContextSkia::clipRect):
(WebCore::PlatformContextSkia::getClipBounds):
(WebCore::PlatformContextSkia::setMatrix):
(WebCore::PlatformContextSkia::getTotalMatrix):
(WebCore::PlatformContextSkia::concat):
(WebCore::PlatformContextSkia::rotate):
(WebCore::PlatformContextSkia::scale):
(WebCore::PlatformContextSkia::translate):
(WebCore::PlatformContextSkia::drawBitmap):
(WebCore::PlatformContextSkia::drawBitmapRect):
(WebCore::PlatformContextSkia::drawOval):
(WebCore::PlatformContextSkia::drawPath):
(WebCore::PlatformContextSkia::drawPoints):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::drawIRect):
(WebCore::PlatformContextSkia::drawPosText):
(WebCore::PlatformContextSkia::drawPosTextH):
(WebCore::PlatformContextSkia::drawTextOnPath):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::skiaDrawText):
(WebCore::paintSkiaText):
* platform/graphics/skia/SkiaUtils.cpp:
(WebCore::ClipRectToCanvas):
* platform/graphics/skia/SkiaUtils.h:
(WebCore):

Source/WebKit/chromium:

Use PlatformContextSkia's wrapper methods instead of accessing the canvas directly.

* tests/TransparencyWinTest.cpp:
(WebCore::getPixelAt):
(WebCore::clearTopLayerAlphaChannel):
(WebCore::clearTopLayerAlphaPixel):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening, unskip s now passing test.
ossy@webkit.org [Wed, 21 Nov 2012 13:32:40 +0000 (13:32 +0000)]
[Qt] Unreviewed gardening, unskip s now passing test.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReset the slider thumb location before every layout of the slider container
carlosgc@webkit.org [Wed, 21 Nov 2012 13:24:40 +0000 (13:24 +0000)]
Reset the slider thumb location before every layout of the slider container
https://bugs.webkit.org/show_bug.cgi?id=102817

Reviewed by Tony Chang.

The location of the slider thumb is set by the slider container
assuming the slider thumb has been laid out. When this happens,
the location of the slider thumb is reset during the layout
ignoring any previous location set. If the slider thumb is not
laid out, the previous value is added to the new one by the slider
container.

* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout): Reset the location of
the slider thumb before calling RenderFlexibleBox::layout().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r135340.
haraken@chromium.org [Wed, 21 Nov 2012 13:00:55 +0000 (13:00 +0000)]
Unreviewed, rolling out r135340.
http://trac.webkit.org/changeset/135340
https://bugs.webkit.org/show_bug.cgi?id=102492

It broke Safari's internal build

Source/WebCore:

* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
(FileNamePrefix):
* bindings/scripts/CodeGeneratorCPP.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorGObject.pm:
(new):
(WriteData):
(GenerateInterface):
* bindings/scripts/CodeGeneratorJS.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorObjC.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorV8.pm:
(new):
(GenerateInterface):
(WriteData):

Tools:

* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(new):
(GenerateModule):
(GenerateInterface):
(finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: reparenting view does not detach from the previous parent.
pfeldman@chromium.org [Wed, 21 Nov 2012 12:37:04 +0000 (12:37 +0000)]
Web Inspector: reparenting view does not detach from the previous parent.
https://bugs.webkit.org/show_bug.cgi?id=102902

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/View.js:
(WebInspector.View.prototype.show):

LayoutTests:

* inspector/view-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Wed, 21 Nov 2012 12:30:47 +0000 (12:30 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests.

* platform/qt-5.0/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHttpReques...
loislo@chromium.org [Wed, 21 Nov 2012 12:26:55 +0000 (12:26 +0000)]
Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHttpRequest, Prerenderer, HTMLMediaElement and DOMTimer.
https://bugs.webkit.org/show_bug.cgi?id=102818

Reviewed by Vsevolod Vlasov.

Our test bot counts pointers which don't match with objects allocated by tcmalloc.
This counter becomes nonzero after instrumenting ActiveDOMObject class.
It happens because it is the base class for many other classes (~30).
And almost all these classes use multiple inheritance.

* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/DocumentEventQueue.cpp:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::reportMemoryUsage):
(WebCore):
* html/HTMLMediaElement.h:
* loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
(WebCore):
* loader/Prerenderer.h:
(Prerenderer):
* page/DOMTimer.cpp:
(WebCore::DOMTimer::reportMemoryUsage):
(WebCore):
* page/DOMTimer.h:
(DOMTimer):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):
(WebCore):
* xml/XMLHttpRequest.h:
(XMLHttpRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
commit-queue@webkit.org [Wed, 21 Nov 2012 12:24:24 +0000 (12:24 +0000)]
[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Added a bunch of assertions to ensure the problems with IndexedDB
contexts cannot reemerge.

No new tests. No change in functionality.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore):
(WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening, unskip a now passing test, update an expected file.
ossy@webkit.org [Wed, 21 Nov 2012 12:19:57 +0000 (12:19 +0000)]
[Qt] Unreviewed gardening, unskip a now passing test, update an expected file.

* platform/qt-5.0/TestExpectations:
* platform/qt-5.0/editing/selection/click-left-of-rtl-wrapping-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Wed, 21 Nov 2012 12:04:39 +0000 (12:04 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Mark css3/filters/effect-reference-ordering-hw.html as crashing after...
yurys@chromium.org [Wed, 21 Nov 2012 11:57:31 +0000 (11:57 +0000)]
Unreviewed. Mark css3/filters/effect-reference-ordering-hw.html as crashing after crrev.com/168998

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebMediaStreamComponent: Add assignment and copy operators
commit-queue@webkit.org [Wed, 21 Nov 2012 11:48:29 +0000 (11:48 +0000)]
WebMediaStreamComponent: Add assignment and copy operators
https://bugs.webkit.org/show_bug.cgi?id=102915

Patch by Harald Alvestrand <hta@google.com> on 2012-11-21
Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebMediaStreamComponent.h:
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::operator=):
(WebMediaStreamComponent):

Source/WebCore:

Tests that use this functionality are being submitted to Chrome.

* platform/chromium/support/WebMediaStreamComponent.cpp:
(WebKit::WebMediaStreamComponent::assign):
(WebKit):
* platform/chromium/support/WebMediaStreamDescriptor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
haraken@chromium.org [Wed, 21 Nov 2012 11:43:12 +0000 (11:43 +0000)]
[V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
https://bugs.webkit.org/show_bug.cgi?id=102917

Reviewed by Adam Barth.

Now EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
are equivalent. We can remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK().
To make a code generate change smaller, this patch also renames
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK_VOID() to EXCEPTION_BLOCK_VOID().
I will rename these macros in a follow-up patch.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateEventConstructorCallback):
(ConvertToV8Parameter):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
* bindings/v8/V8BindingMacros.h:
* bindings/v8/V8StringResource.h:
(V8Parameter):
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* bindings/v8/custom/V8IntentCustom.cpp:
(WebCore::V8Intent::constructorCallbackCustom):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getExtensionCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Move V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer
haraken@chromium.org [Wed, 21 Nov 2012 11:25:18 +0000 (11:25 +0000)]
[V8] Move V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer
https://bugs.webkit.org/show_bug.cgi?id=102899

Reviewed by Adam Barth.

This is an incremental step to kill WorkerContextExecutionProxy.
As commented by abarth in bug 97066, we move
V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer.
This patch renames initializeV8IfNeeded() to initializeMainThreadIfNeeded()
because we will add initializeWorkerIfNeeded() in a follow-up patch.

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
* bindings/v8/V8Initializer.cpp: Added.
(WebCore):
(WebCore::findFrame):
(WebCore::reportFatalError):
(WebCore::reportUncaughtException):
(WebCore::reportUnsafeJavaScriptAccess):
(WebCore::V8Initializer::initializeMainThreadIfNeeded):
* bindings/v8/V8Initializer.h: Added.
(WebCore):
(V8Initializer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening, unskip a now passing test.
ossy@webkit.org [Wed, 21 Nov 2012 11:23:12 +0000 (11:23 +0000)]
[Qt] Unreviewed gardening, unskip a now passing test.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
gyuyoung.kim@samsung.com [Wed, 21 Nov 2012 11:14:34 +0000 (11:14 +0000)]
[EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
https://bugs.webkit.org/show_bug.cgi?id=101526

.:

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-21
Reviewed by Kenneth Rohde Christiansen.

Separate out ENABLE_WEBGL. It is not ready to be enabled by default.

* Source/cmake/OptionsEfl.cmake:

Tools:

Reviewed by Kenneth Rohde Christiansen.

Turn on WTF_USE_TILED_BACKING_STORE for EFL port.

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTurn -webkit-text-emphasis into a shorthand property
apavlov@chromium.org [Wed, 21 Nov 2012 11:00:55 +0000 (11:00 +0000)]
Turn -webkit-text-emphasis into a shorthand property
https://bugs.webkit.org/show_bug.cgi?id=102879

Reviewed by Antti Koivisto.

Source/WebCore:

-webkit-text-emphasis value is no longer empty.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue): Reconstruct the -webkit-text-emphasis value based on the longhands.

LayoutTests:

Update expected results.

* fast/css/parsing-text-emphasis-expected.txt:
* fast/css/parsing-text-emphasis.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
commit-queue@webkit.org [Wed, 21 Nov 2012 10:55:41 +0000 (10:55 +0000)]
[EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
https://bugs.webkit.org/show_bug.cgi?id=102867

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.

ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.

Source/WebKit2:

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_encoding_custom_get):
(ewk_view_encoding_custom_set):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

Tools:

* MiniBrowser/efl/main.c:
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Wed, 21 Nov 2012 10:50:08 +0000 (10:50 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Build fix.
haraken@chromium.org [Wed, 21 Nov 2012 10:36:18 +0000 (10:36 +0000)]
Unreviewed. Build fix.

* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallbackCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp
haraken@chromium.org [Wed, 21 Nov 2012 10:24:11 +0000 (10:24 +0000)]
[V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp
https://bugs.webkit.org/show_bug.cgi?id=102881

Reviewed by Adam Barth.

Writing constructorCallback()s in *Custom.cpp is a convention of
custom bindings of JSC and V8. We can rename v8/custom/*Constructor.cpp
to v8/custom/*Custom.cpp.

No tests. No change in behavior.

* UseV8.cmake: This file is already out of sync.
* WebCore.gypi:
* bindings/v8/custom/V8IntentCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp.
(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):
* bindings/v8/custom/V8MessageChannelCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelConstructor.cpp.
(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):
* bindings/v8/custom/V8WebKitPointCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp.
(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Inspector does not callback IDB methods in context
commit-queue@webkit.org [Wed, 21 Nov 2012 10:19:43 +0000 (10:19 +0000)]
[V8] Inspector does not callback IDB methods in context
https://bugs.webkit.org/show_bug.cgi?id=101725

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Inserted v8 context before calling out to IDB.

No new tests.

* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(134048): TiledBackingStore must create tiles when the contents rect is...
commit-queue@webkit.org [Wed, 21 Nov 2012 10:17:59 +0000 (10:17 +0000)]
REGRESSION(134048): TiledBackingStore must create tiles when the contents rect is changed.
https://bugs.webkit.org/show_bug.cgi?id=102035

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Kenneth Rohde Christiansen.

Before r134048, the visibleRect contained information of both the viewport and
the contents rect. Now the visible rect is related to only the viewport. So
TiledBackingStore::coverWithTilesIfNeeded() early returns even if the contents
rect is changed, because changing the contents rect is independent on changing
both a trajectory vector and the visible rect.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: remove setVersion from inspector tests
dgrogan@chromium.org [Wed, 21 Nov 2012 10:12:18 +0000 (10:12 +0000)]
IndexedDB: remove setVersion from inspector tests
https://bugs.webkit.org/show_bug.cgi?id=102850

Reviewed by Vsevolod Vlasov.

setVersion was contained so the conversion to upgradeneeded was
straightforward.

* http/tests/inspector/indexeddb/database-data-expected.txt:
* http/tests/inspector/indexeddb/database-structure-expected.txt:
* http/tests/inspector/indexeddb/indexeddb-test.js:
(.request.onsuccess.onSuccess.request.onupgradeneeded):
(.request.onsuccess.onSuccess.request.onsuccess):
(.request.onsuccess):
(doWithVersionTransaction):
* http/tests/inspector/indexeddb/resources-panel-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r135307.
commit-queue@webkit.org [Wed, 21 Nov 2012 09:56:57 +0000 (09:56 +0000)]
Unreviewed, rolling out r135307.
http://trac.webkit.org/changeset/135307
https://bugs.webkit.org/show_bug.cgi?id=102905

Jussi said this doesn't definitively fix things, so revert for
now. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

* animations/resources/stop-animation-on-suspend-subframe.html:
* animations/stop-animation-on-suspend.html:
* platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-arm/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Request preview tuning: enable json preview for text/html XHRs
vsevik@chromium.org [Wed, 21 Nov 2012 09:39:51 +0000 (09:39 +0000)]
Web Inspector: Request preview tuning: enable json preview for text/html XHRs
https://bugs.webkit.org/show_bug.cgi?id=102892

Reviewed by Alexander Pavlov.

* inspector/front-end/RequestPreviewView.js:
(WebInspector.RequestPreviewView.prototype._jsonView):
(WebInspector.RequestPreviewView.prototype._htmlView):
(WebInspector.RequestPreviewView.prototype._createPreviewView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Remove manually written v8::TryCatches in custom bindings
haraken@chromium.org [Wed, 21 Nov 2012 09:38:27 +0000 (09:38 +0000)]
[V8] Remove manually written v8::TryCatches in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=102883

Reviewed by Adam Barth.

We can replace them with the EXCEPTION_BLOCK() macro or its friends.

No new tests. This patch shouldn't change any behavior.

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r135358.
haraken@chromium.org [Wed, 21 Nov 2012 09:26:05 +0000 (09:26 +0000)]
Unreviewed, rolling out r135358.
http://trac.webkit.org/changeset/135358
https://bugs.webkit.org/show_bug.cgi?id=102881

It broke Chromium/Linux build

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementCustom.cpp.
(WebCore):
(WebCore::v8HTMLImageElementConstructorCallback):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLImageElementConstructor.h: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementCustom.h.
(WebCore):
(V8HTMLImageElementConstructor):
* bindings/v8/custom/V8IntentConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp.
(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):
* bindings/v8/custom/V8MessageChannelConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp.
(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):
* bindings/v8/custom/V8WebKitPointConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp.
(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnused parameters on ScrollingCoordinator.cpp
commit-queue@webkit.org [Wed, 21 Nov 2012 09:09:43 +0000 (09:09 +0000)]
Unused parameters on ScrollingCoordinator.cpp
https://bugs.webkit.org/show_bug.cgi?id=102884

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-21
Reviewed by Kentaro Hara.

Because the 'scrollingLayerPositionAction' parameter is not used when !USE(ACCELERATED_COMPOSITING),
use UNUSED_PARAM macro to fix build warning -Wunused-parameter

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Replace V8Parameter::prepare() with V8Parameter::operator=()
haraken@chromium.org [Wed, 21 Nov 2012 09:08:02 +0000 (09:08 +0000)]
[V8] Replace V8Parameter::prepare() with V8Parameter::operator=()
https://bugs.webkit.org/show_bug.cgi?id=102870

Reviewed by Adam Barth.

This is an incremental step for V8Parameter refactoring.
By replacing V8Parameter::prepare() with V8Parameter::operator=(),
we can make EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
equivalent (except for a return value).

Tests: fast/workers/worker-constructor.html
       storage/websql/sql-error-codes.html
       inspector/console/alert-toString-exception.html
       http/tests/websocket/tests/hybi/send-throw.html

* bindings/v8/V8BindingMacros.h:
* bindings/v8/V8StringResource.h:
(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp
haraken@chromium.org [Wed, 21 Nov 2012 09:06:58 +0000 (09:06 +0000)]
[V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp
https://bugs.webkit.org/show_bug.cgi?id=102881

Reviewed by Adam Barth.

Writing constructorCallback()s in *Custom.cpp is a convention of
custom bindings of JSC and V8. We can rename v8/custom/*Constructor.cpp
to v8/custom/*Custom.cpp.

No tests. No change in behavior.

* UseV8.cmake: This file is already out of sync.
* WebCore.gypi:
* bindings/v8/custom/V8HTMLImageElementCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp.
(WebCore):
(WebCore::v8HTMLImageElementConstructorCallback):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLImageElementCustom.h: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.h.
(WebCore):
(V8HTMLImageElementConstructor):
* bindings/v8/custom/V8IntentCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp.
(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):
* bindings/v8/custom/V8MessageChannelCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelConstructor.cpp.
(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):
* bindings/v8/custom/V8WebKitPointCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp.
(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Canvas] throttle wait icon in the ui
commit-queue@webkit.org [Wed, 21 Nov 2012 09:04:28 +0000 (09:04 +0000)]
Web Inspector: [Canvas] throttle wait icon in the ui
https://bugs.webkit.org/show_bug.cgi?id=102685

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-21
Reviewed by Vsevolod Vlasov.

Do not show the wait icon for small operations during the replay to reduce flickering.

* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Updated test expectations.
yurys@chromium.org [Wed, 21 Nov 2012 08:51:09 +0000 (08:51 +0000)]
Unreviewed. Updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable datalist UI for input types datetime and datetime-local
commit-queue@webkit.org [Wed, 21 Nov 2012 08:23:54 +0000 (08:23 +0000)]
Enable datalist UI for input types datetime and datetime-local
https://bugs.webkit.org/show_bug.cgi?id=102882

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-21
Reviewed by Kent Tamura.

Source/WebCore:

Enabling datalist UI for input types datetime and datetime-local.

No new tests yet. Tests will be added later in Bug 102888.

* platform/text/PlatformLocale.cpp:
(WebCore::Locale::formatDateTime): Support datetime and datetime-local types.
* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Add datetime and datetimelocal to the list.

LayoutTests:

Removed expectation of failure.

* platform/chromium/fast/forms/datalist/input-list-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp
haraken@chromium.org [Wed, 21 Nov 2012 06:50:18 +0000 (06:50 +0000)]
[V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp
https://bugs.webkit.org/show_bug.cgi?id=102876

Reviewed by Sam Weinig.

It doesn't make sense to have one custom cpp file for
XXX::constructorCallback() only. We can move XXX::constructorCallback()
in v8/custom/V8XXXConstructor.cpp to v8/custom/V8XXXCustom.cpp
and thus remove v8/custom/V8XXXConstructor.cpp.

Note: Some XXX::constructorCallback()s are already written in
v8/custom/V8XXXCustom.cpp. JSC already has almost all
XXX::constructorCallback()s in js/JSXXXCustom.cpp.

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Removed.
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCallbackCustom):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135354 268f45cc-cd09-0410-ab3c-d52691b4dbfc