WebKit-https.git
7 years agoRadioNodeList support in HTMLFormElement::elements
commit-queue@webkit.org [Tue, 24 Apr 2012 08:11:32 +0000 (08:11 +0000)]
RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854

Source/WebCore:

Implement RadioNodeList support spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#radionodelist

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-04-24
Reviewed by Ryosuke Niwa.

Test: fast/forms/form-collection-radio-node-list.html

* CMakeLists.txt:
Added entries for new files.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Added code to include Node.h and JSNode.h in JSRadioNodeElement.cpp.
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.
* html/CollectionType.h:
Added new FormControls type.
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
Handle FormControls collection type.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
Contruct collection of FormControls type.
* html/RadioNodeList.cpp: Added.
(WebCore):
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::~RadioNodeList):
(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value):
(WebCore::RadioNodeList::setValue):
(WebCore::RadioNodeList::nodeMatches):
* html/RadioNodeList.h: Added.
(WebCore):
(RadioNodeList):
(WebCore::RadioNodeList::create):
RadioNodeList implementation.
* html/RadioNodeList.idl: Added.
Idl for generating RadioNodeList JS/V8 bindings.

LayoutTests:

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-04-24
Reviewed by Ryosuke Niwa.

* fast/forms/form-collection-radio-node-list-expected.txt: Added.
* fast/forms/form-collection-radio-node-list.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Tue, 24 Apr 2012 08:02:28 +0000 (08:02 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement the field cache of ObjcClass in WebKit types
commit-queue@webkit.org [Tue, 24 Apr 2012 07:48:20 +0000 (07:48 +0000)]
Implement the field cache of ObjcClass in WebKit types
https://bugs.webkit.org/show_bug.cgi?id=84667

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-24
Reviewed by Geoffrey Garen.

Every time we get a field through the Objective-C bridge, we waste some time converting
the incoming string to an CFString.

This patch implement the field cache based on WTF types so that we can return directly
in case of a positive match.

When we do not have a match on the Identifier, we allocate the memory and find the valid field
as before.

* bridge/objc/objc_class.h:
(ObjcClass):
* bridge/objc/objc_class.mm:
(JSC::Bindings::deleteMethod):
(Bindings):
(JSC::Bindings::ObjcClass::ObjcClass):
(JSC::Bindings::ObjcClass::fieldNamed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r114957.
philn@webkit.org [Tue, 24 Apr 2012 07:47:13 +0000 (07:47 +0000)]
Unreviewed, GTK rebaseline after r114957.

* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-volume-slider-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncremental rendering should be unsuppressed after the load event or a configurable...
aestes@apple.com [Tue, 24 Apr 2012 07:43:40 +0000 (07:43 +0000)]
Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first.
https://bugs.webkit.org/show_bug.cgi?id=84583

Source/WebCore:

Reviewed by Anders Carlsson.

In high-latency situations, having incremental rendering suppression
enabled makes for a worse experience due to the excessively long time
it takes for the load event to fire. So that clients that opt in to
incremental rendering suppression can mitigate this, add a configurable
timeout in which rendering is re-enabled if the load event has yet to
fire.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setReadyState): When the document transitions to
the loading state, start a timer; when it transitions to the completed
state, allow visual updates.
(WebCore::Document::setVisualUpdatesAllowed): If visual updates are
allowed, force a repaint. Otherwise, set a flag that suppresses
rendering.
(WebCore::Document::visualUpdatesSuppressionTimerFired): When the timer
fires, allow visual updates.
(WebCore::Document::implicitClose): Remove code that is now called in
setVisualUpdatesAllowed().
* dom/Document.h:
(WebCore::Document::visualUpdatesAllowed):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setIncrementalRenderingSuppressionTimeoutInSeconds):
(WebCore::Settings::incrementalRenderingSuppressionTimeoutInSeconds):

Source/WebKit/mac:

Add a private WebPreference for setting the incremental rendering suppression timeout.

Reviewed by Anders Carlsson.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences setIncrementalRenderingSuppressionTimeoutInSeconds:]):
(-[WebPreferences incrementalRenderingSuppressionTimeoutInSeconds]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix incorrect test results for <datalist>
tkent@chromium.org [Tue, 24 Apr 2012 06:19:24 +0000 (06:19 +0000)]
Unreviewed. Fix incorrect test results for <datalist>

* fast/forms/datalist/datalist-expected.txt: Remove fallback content.
* fast/forms/datalist/datalist-nonoption-child-expected.txt: ditto.
* platform/chromium-linux/fast/forms/datalist/input-list-expected.png: Removed.
* platform/chromium-mac/fast/forms/datalist/input-list-expected.png: Removed.
* platform/chromium-mac/fast/forms/datalist/input-list-expected.txt: Removed.
* platform/chromium-win/fast/forms/datalist/input-list-expected.png: Removed.
* platform/chromium-win/fast/forms/datalist/input-list-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Image masks are considered opaque incorrectly
danakj@chromium.org [Tue, 24 Apr 2012 06:12:41 +0000 (06:12 +0000)]
[chromium] Image masks are considered opaque incorrectly
https://bugs.webkit.org/show_bug.cgi?id=84275

Reviewed by Adrienne Walker.

Source/WebCore:

Match the behaviour of SkCanvas layers more closely while tracking
opaque paints. SkCanvas layers actually act as a separate device
(ie. pixels) and when the layer is popped off, the pixels are copied
down to the layer below.

While we can use the total clip to decide what pixels the the
drawing operation will affect in the final device, the blending
down through layers needs to consider each layer carefully.

In this case the image mask is drawn into a layer which is copied
down using the DestinationIn operation. Since the layer contains
non-opaque pixels, the DestinationIn copy can destroy opaque
areas in the next layer. We add OpaqueRegionSkia::FillByCopy to
distinguish the case where we are copying a block of pixels, and the
alpha values are essentially unknown.

Unit test: PlatformContextSkiaTest.trackImageMask
           PlatformContextSkiaTest.trackImageMaskWithOpaqueRect

* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::applyOpaqueRegionFromLayer):
(WebCore::OpaqueRegionSkia::pushCanvasLayer):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
(WebCore::OpaqueRegionSkia::markAllAsNonOpaque):
* platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
(CanvasLayerState):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::restoreLayer):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShow the format indicator in a date field
tkent@chromium.org [Tue, 24 Apr 2012 05:57:33 +0000 (05:57 +0000)]
Show the format indicator in a date field
https://bugs.webkit.org/show_bug.cgi?id=83872

Reviewed by Hajime Morita.

Source/WebCore:

Enable the fixed placeholder feature for the date type, and show
the editable date format as the fixed placeholder.
The format string is created by the following steps.
1. Obtain a pattern string from ICU
  http://icu-project.org/apiref/icu4c/classSimpleDateFormat.html#details
2. Replace a sequence of 'y', 'Y', 'M', or 'd' in the pattern with
  a natural language string such as "year", "month", or "day".

Test: fast/forms/date/date-fixed-placeholder.html

* html/DateInputType.cpp:
(WebCore::DateInputType::supportsPlaceholder): Added. Returns true.
(WebCore::DateInputType::usesFixedPlaceholder): Added. Returns true.
(WebCore::DateInputType::fixedPlaceholder):
Added. Calls localizedDateFormatText() provided by LocalizedDate.h.
* html/DateInputType.h:
(DateInputType): Add declarations of new override functions.
* platform/LocalizedStrings.h:
(WebCore): Add dateFormat{Year,Month,DayInMonth}Text()
* platform/text/ICULocale.cpp:
(WebCore::isICUYearSymbol): A function to improve redability.
(WebCore::isICUMonthSymbol): ditto.
(WebCore::isICUDayInMonthSymbol): ditto.
(WebCore::localizeFormat): Step 2 of the above description.
(WebCore::ICULocale::initializeLocalizedDateFormatText):
Step 1 of the above description.
(WebCore::ICULocale::localizedDateFormatText):
* platform/text/ICULocale.h:
(ICULocale): Add new functions and a data member.
* platform/text/LocalizedDate.h:
(WebCore): Add localizedDateFormatText().
* platform/text/LocalizedDateICU.cpp:
(WebCore::localizedDateFormatText):
Just call ICULocale::localizedDateFormatText().

Source/WebKit/chromium:

* src/LocalizedStrings.cpp:
(WebCore::dateFormatYearText): Added a stub.
(WebCore::dateFormatMonthText): ditto.
(WebCore::dateFormatDayInMonthText): ditto.

LayoutTests:

* fast/forms/date/date-fixed-placeholder-expected.txt: Added.
* fast/forms/date/date-fixed-placeholder.html: Added.
* platform/chromium/test_expectations.txt:
Mark date-appearance.html FAIL because of render dump change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGetting baselines for new test landed in http://trac.webkit.org/changeset/114973
dimich@chromium.org [Tue, 24 Apr 2012 05:34:04 +0000 (05:34 +0000)]
Getting baselines for new test landed in trac.webkit.org/changeset/114973
Not reviewed.

* platform/chromium-linux-x86/fast/html/details-marker-style-expected.txt: Added.
* platform/chromium-linux/fast/html/details-marker-style-expected.png: Added.
* platform/chromium-linux/fast/html/details-marker-style-expected.txt: Added.
* platform/chromium-mac-leopard/fast/html/details-marker-style-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/html/details-marker-style-expected.txt: Added.
* platform/chromium-mac/fast/html/details-marker-style-expected.png: Added.
* platform/chromium-mac/fast/html/details-marker-style-expected.txt: Added.
* platform/chromium-win-vista/fast/html/details-marker-style-expected.txt: Added.
* platform/chromium-win-xp/fast/html/details-marker-style-expected.txt: Added.
* platform/chromium-win/fast/html/details-marker-style-expected.png: Added.
* platform/chromium-win/fast/html/details-marker-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to v8Array()
haraken@chromium.org [Tue, 24 Apr 2012 05:12:14 +0000 (05:12 +0000)]
[V8] Pass Isolate to v8Array()
https://bugs.webkit.org/show_bug.cgi?id=84295

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to v8Array().

(GenerateNormalAttrGetter):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::sequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
* bindings/v8/V8Binding.h:
(WebCore::v8Array):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to GetNamedProperty()
haraken@chromium.org [Tue, 24 Apr 2012 05:07:55 +0000 (05:07 +0000)]
[V8] Pass Isolate to GetNamedProperty()
https://bugs.webkit.org/show_bug.cgi?id=84277

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to GetNamedProperty().

(GenerateHeader):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getter):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test platform/chromium/compositing/filters/background-filter-blur-outsets...
danakj@chromium.org [Tue, 24 Apr 2012 04:27:28 +0000 (04:27 +0000)]
Layout Test platform/chromium/compositing/filters/background-filter-blur-outsets.html is failing
https://bugs.webkit.org/show_bug.cgi?id=84072

Reviewed by Adrienne Walker.

Use onload and layoutTestController.display() to ensure the page is
loaded and compositor is ready before setting the background blur.

Also, smaller blur for faster test bots.

* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt:
* platform/chromium/compositing/filters/background-filter-blur-off-axis.html:
* platform/chromium/compositing/filters/background-filter-blur-outsets.html:
* platform/chromium/compositing/filters/background-filter-blur.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] DomStorage event handling mods.
michaeln@google.com [Tue, 24 Apr 2012 04:19:50 +0000 (04:19 +0000)]
[chromium] DomStorage event handling mods.
https://bugs.webkit.org/show_bug.cgi?id=84387

Source/WebCore:

Add a few simple inline getters to allow the source Document of a storage
event to be identified given a pointer to the source StorageArea so those
Documents can be excluded by the event dispatching logic.

Reviewed by Dimitri Glazkov.

No new tests. No new functionality or change in behavior.

* page/DOMWindow.h:
(WebCore::DOMWindow::optionalSessionStorage): simple inline getter to avoid construction where possible
(WebCore::DOMWindow::optionalLocalStorage): ditto
* storage/Storage.h:
(WebCore::Storage::area): simple inline getter

Source/WebKit/chromium:

Events are currently handled inconsistently. The dispatch of some events are
initiated from within webkit/webcore, the dispatch of other events are initiated
from the outside via the WebKit::WebStorageEventDispatcher interface. The existing
WebStorageEventDispatcher is not expressive enough to handle initiation all
events from the outside. There's a chunk of nearly replicated code in there
that shouldn't be. The existing code has several FIXMEs related to making
this better.

The current state of things in webkit/webcore is also blocking development of some
overall performance improvements to chromium's implemention of this feature (getting
rid of sync ipcs for each access and adding a renderer-side caching layer).

To facilitate the perf improvements, this patch adds WebKit API to allow all
DomStorage events to be initiated from the outside. This is needed because
there will be an async latency between setting an item and receiving the
'oldValue' from the main browser process which is required to raise the
mutation event.

This is the first of a multi-sided sequence of patches to make this transition.
wkpatch 1: add the new wider WebKit API and impl
crpatch 2: start using the new wider WebKit API
wkpatch 3: cleanup, delete the old WebKit API and impl
xxxxxxx 4/5: cleanup, remove extra params from new API whose only purpose was to allow the transition

Reviewed by Dimitri Glazkov.

* public/WebStorageEventDispatcher.h: Add new API to dispatch events.
* public/WebStorageNamespace.h: Add new API to test for namespace equality.
* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent): implementation of the new API
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):  implementation of the new API
(WebCore::StorageAreaProxy::IsEventSource): a helper method
(WebCore::StorageAreaProxy::FindPageWithSessionStorageNamespace): a helper method
* src/StorageAreaProxy.h:
* src/StorageEventDispatcherImpl.cpp: added a FIXME comment to delete soon
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespaceProxy::IsSameNamespace): plumbing to call the new API
* src/StorageNamespaceProxy.h:
* src/WebStorageEventDispatcherImpl.cpp:
(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): plumbing to call the new impl
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): plumbing to call the new impl
* src/WebStorageEventDispatcherImpl.h: added a FIXME comment to delete soon

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange ImageData to reference Uint8ClampedArray rather than CanvasPixelArray
kbr@google.com [Tue, 24 Apr 2012 03:43:31 +0000 (03:43 +0000)]
Change ImageData to reference Uint8ClampedArray rather than CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=73011

Reviewed by Oliver Hunt.

Source/WebCore:

Changed ImageData to contain Uint8ClampedArray instead of ByteArray
per current HTML5 spec.

In order to avoid introducing large data copies, it was necessary to
switch a few other places in WebKit to use Uint8ClampedArray at the
same time, most notably the FilterEffect implementation, portions of
ImageBuffer, and a couple of places in the image encoders.

Note that the change in method name from "get" to "item" occurred
because JSC's autogenerated indexed getters reference a method
called "item". If desired, a convenience method could be
introduced to avoid the renamings in the FilterEffect classes.

With these changes, ByteArray and some custom code in JavaScriptCore
actually become unreferenced, and can be deleted. This deletion will
be done separately in Bug 83655, to keep the size of this patch
manageable.

Test: fast/canvas/imagedata-contains-uint8clampedarray.html

* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapToImageDataMethod::invoke):
* html/ImageData.cpp:
(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):
* html/ImageData.h:
(ImageData):
(WebCore::ImageData::data):
* html/ImageData.idl:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
(WebCore::CanvasRenderingContext2D::putImageData):
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::extractImageData):
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::genericConvertToLuminanceMask):
* platform/graphics/ImageBuffer.h:
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurShadowBuffer):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
* platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):
* platform/graphics/cg/ImageBufferDataCG.h:
(ImageBufferData):
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::platformApplySoftware):
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::effectType):
(WebCore::FEColorMatrix::platformApplySoftware):
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::platformApplySoftware):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformArithmeticSoftware):
(WebCore::FEComposite::platformApplySoftware):
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::setDestinationPixels):
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::platformApplySoftware):
* platform/graphics/filters/FEConvolveMatrix.h:
(PaintingData):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::bindProgramAndBuffers):
* platform/graphics/filters/FECustomFilter.h:
(JSC):
(FECustomFilter):
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::platformApplySoftware):
* platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::platformApplySoftware):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::boxBlur):
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):
(WebCore::FEGaussianBlur::platformApplySoftware):
* platform/graphics/filters/FEGaussianBlur.h:
(PlatformApplyParameters):
(FEGaussianBlur):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::LightingData::topLeft):
(WebCore::FELighting::LightingData::topRow):
(WebCore::FELighting::LightingData::topRight):
(WebCore::FELighting::LightingData::leftColumn):
(WebCore::FELighting::LightingData::interior):
(WebCore::FELighting::LightingData::rightColumn):
(WebCore::FELighting::LightingData::bottomLeft):
(WebCore::FELighting::LightingData::bottomRow):
(WebCore::FELighting::LightingData::bottomRight):
(WebCore::FELighting::inlineSetPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::platformApplySoftware):
* platform/graphics/filters/FELighting.h:
(LightingData):
(FELighting):
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApplySoftware):
* platform/graphics/filters/FEMorphology.h:
(PaintingData):
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegion):
(WebCore::FETurbulence::platformApplySoftware):
* platform/graphics/filters/FETurbulence.h:
(FillRegionParameters):
(FETurbulence):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::forceValidPreMultipliedPixels):
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
(WebCore::FilterEffect::copyImageBytes):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
* platform/graphics/filters/FilterEffect.h:
(FilterEffect):
* platform/graphics/filters/arm/FEGaussianBlurNEON.h:
(WebCore::FEGaussianBlur::platformApplyNeon):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
* platform/graphics/texmap/TextureMapperGL.cpp:
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::JPEGImageEncoder::encode):
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::PNGImageEncoder::encode):
* platform/image-encoders/skia/WEBPImageEncoder.cpp:
(WebCore::WEBPImageEncoder::encode):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas):

Source/WTF:

* wtf/ArrayBuffer.h:
(ArrayBuffer):
(WTF::ArrayBuffer::create):
(WTF::ArrayBuffer::createUninitialized):
(WTF):
(WTF::ArrayBufferContents::tryAllocate):
* wtf/TypedArrayBase.h:
(WTF::TypedArrayBase::createUninitialized):
(TypedArrayBase):
* wtf/Uint8ClampedArray.h:
(Uint8ClampedArray):
(WTF::Uint8ClampedArray::createUninitialized):
(WTF):
(WTF::Uint8ClampedArray::zeroFill):

LayoutTests:

* fast/canvas/imagedata-contains-uint8clampedarray-expected.txt: Added.
* fast/canvas/imagedata-contains-uint8clampedarray.html: Added.
* fast/dom/Window/script-tests/postmessage-clone.js:
* fast/dom/Window/window-postmessage-clone-expected.txt:
* platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt:
* platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove deleted files from WebCore.gypi and fix typo
commit-queue@webkit.org [Tue, 24 Apr 2012 03:39:32 +0000 (03:39 +0000)]
[chromium] Remove deleted files from WebCore.gypi and fix typo
https://bugs.webkit.org/show_bug.cgi?id=84651

Patch by Ryan Sleevi <rsleevi@chromium.org> on 2012-04-23
Reviewed by Ryosuke Niwa.

No new tests. No behavior change.

* WebCore.gypi:
Remove references to PlatformMouseEventQt.cpp and WheelEventQt.cpp. Add a missing comma.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix wrong paths of js-test-*.js.
tkent@chromium.org [Tue, 24 Apr 2012 03:29:00 +0000 (03:29 +0000)]
Unreviewed, fix wrong paths of js-test-*.js.
https://bugs.webkit.org/show_bug.cgi?id=82871

* fast/forms/datalist/input-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Fix issue with trying to access a constructor in a frame that has been removed
arv@chromium.org [Tue, 24 Apr 2012 03:21:48 +0000 (03:21 +0000)]
[V8] Fix issue with trying to access a constructor in a frame that has been removed
https://bugs.webkit.org/show_bug.cgi?id=84640

Reviewed by Kentaro Hara.

Source/WebCore:

This regressed in r113250. Now we do what we did before and return undefined if the frame
does not have a context.

Test: fast/dom/constructor-in-removed-frame.html

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::constructorForType):

LayoutTests:

* fast/dom/constructor-in-removed-frame-expected.txt: Added.
* fast/dom/constructor-in-removed-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOscillator::setWaveTable() should not reset oscillator phase
crogers@google.com [Tue, 24 Apr 2012 03:19:36 +0000 (03:19 +0000)]
Oscillator::setWaveTable() should not reset oscillator phase
https://bugs.webkit.org/show_bug.cgi?id=84647

Reviewed by Kenneth Russell.

* Modules/webaudio/Oscillator.cpp:
(WebCore::Oscillator::setWaveTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when the page with a calendar picker is scrolled
tkent@chromium.org [Tue, 24 Apr 2012 03:15:08 +0000 (03:15 +0000)]
Crash when the page with a calendar picker is scrolled
https://bugs.webkit.org/show_bug.cgi?id=84287

Reviewed by Hajime Morita.

Use the same ownership model as WebPopupMenuImpl's.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close):
Clear m_widgetClient to avoid furthur access to it. deref instead of delete.
(WebKit::WebPagePopupImpl::closePopup):
Do not call closeWidgetSoon() if close() was already called.
(WebKit::WebPagePopup::create):
Add a reference. Add explanation of the ownership.
* src/WebPagePopupImpl.h:
(WebPagePopupImpl): Make this RefCounted.  Make the destuctor public.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl): No need to clear m_pagePopup explicitly.
(WebKit::WebViewImpl::openPagePopup): Need to use .get() because m_pagePopup is a RefPtr.
(WebKit::WebViewImpl::closePagePopup): ditto.
(WebKit::WebViewImpl::hidePopups): ditto.
* src/WebViewImpl.h: Make m_pagePopup a RefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Refactoring] Remove V8Proxy::throwSyntaxError()
haraken@chromium.org [Tue, 24 Apr 2012 02:11:07 +0000 (02:11 +0000)]
[V8][Refactoring] Remove V8Proxy::throwSyntaxError()
https://bugs.webkit.org/show_bug.cgi?id=84627

Reviewed by Nate Chapin.

This patch removes V8Proxy::throwSyntaxError()
since it is no longer used.

No tests. No change in behavior.

* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable parallel GC for BlackBerry.
staikos@webkit.org [Tue, 24 Apr 2012 02:07:52 +0000 (02:07 +0000)]
Enable parallel GC for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=84633

Reviewed by Antonio Gomes.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Build failure when DEBUG_FAT_FINGER is enabled
charles.wei@torchmobile.com.cn [Tue, 24 Apr 2012 02:01:05 +0000 (02:01 +0000)]
[BlackBerry] Build failure when DEBUG_FAT_FINGER is enabled
https://bugs.webkit.org/show_bug.cgi?id=84563

Reviewed by Antonio Gomes.

Fat Finger log code uses obsolete IntRect::toString() for logging,
which was first implemented interally and removed later.

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Use TextureLayerChromium for WebGL content instead of a dedicated layer...
jamesr@google.com [Tue, 24 Apr 2012 02:00:47 +0000 (02:00 +0000)]
[chromium] Use TextureLayerChromium for WebGL content instead of a dedicated layer type
https://bugs.webkit.org/show_bug.cgi?id=84311

Reviewed by Adrienne Walker.

Source/Platform:

Remove some unused getters.

* chromium/public/WebExternalTextureLayer.h:
(WebExternalTextureLayer):

Source/WebCore:

WebGL content's interface with the compositor can be expressed in terms of two basic operations:
1.) Do some stuff
2.) Provide a texture ID for the compositor to use

This implements (1) in DrawingBufferChromium and uses the already-existing TextureLayerChromium to handle (2).
This cuts down the compositor interface significantly and allows for more code reuse in exchange for more code
in TextureLayerChromium to handle the features WebGL needs.

* WebCore.gypi:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::~DrawingBuffer):
(DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(WebCore):
(WebCore::DrawingBuffer::platformLayer):
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/TextureLayerChromium.h:
(TextureLayerChromiumClient):
(WebCore::TextureLayerChromiumClient::~TextureLayerChromiumClient):
(WebCore):
(TextureLayerChromium):
(WebCore::TextureLayerChromium::clearClient):
* platform/graphics/chromium/WebGLLayerChromium.cpp: Removed.
* platform/graphics/chromium/WebGLLayerChromium.h: Removed.
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore):
(WebCore::DrawingBuffer::graphicsContext3D):
(DrawingBuffer):

Source/WebKit/chromium:

* WebKit.gypi:
* src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::create):
* src/WebLayer.cpp:
* tests/WebGLLayerChromiumTest.cpp: Removed.
* tests/WebLayerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd notice about running xcode-select before using Xcode 4.3.2 command line tools
dbates@webkit.org [Tue, 24 Apr 2012 01:50:35 +0000 (01:50 +0000)]
Add notice about running xcode-select before using Xcode 4.3.2 command line tools

Rubber-stamped by Eric Seidel.

Before you can use the Xcode 4.3.2 command line tools, you must either run
sudo xcode-select -switch /Applications/Xcode.app or set the environment variable
DEVELOPER_DIR to point to the Xcode developer tools directory.

* building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: remove IDB(Index|ObjectStore)BackendImpl::get/getKey for IDBKey
commit-queue@webkit.org [Tue, 24 Apr 2012 01:50:07 +0000 (01:50 +0000)]
IndexedDB: remove IDB(Index|ObjectStore)BackendImpl::get/getKey for IDBKey
https://bugs.webkit.org/show_bug.cgi?id=84285

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-23
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests required, this code is no longer called.

This is old code supporting IDBKey-based lookup, supplanted by
IDBKeyRange. Now that chromium IPC/proxy code has landed,
these functions can be removed.

* Modules/indexeddb/IDBIndexBackendInterface.h:
(IDBIndexBackendInterface):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
(IDBObjectStoreBackendInterface):

Source/WebKit/chromium:

This is old code supporting IDBKey-based lookup, supplanted by
IDBKeyRange. Now that chromium IPC/proxy code has landed,
these functions can be removed.

* public/WebIDBIndex.h:
* public/WebIDBObjectStore.h:
* src/IDBIndexBackendProxy.cpp:
* src/IDBIndexBackendProxy.h:
(IDBIndexBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBIndexImpl.cpp:
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(113604): [Soup] Some pages that use synchronous XMLHttpRequests freeze...
mrobinson@webkit.org [Tue, 24 Apr 2012 01:33:00 +0000 (01:33 +0000)]
REGRESSION(113604): [Soup] Some pages that use synchronous XMLHttpRequests freeze the browser
https://bugs.webkit.org/show_bug.cgi?id=84560

Reviewed by Xan Lopez.

When kicking off a synchronous XMLHttpRequest, add one to the connection
limit. This ensures that when a page starts a synchronous request, while
already at the connection limit the request will not deadlock.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Accept a new SoupSession
argument so that we can get the correct SoupSession for the networking context. Bump
the connection limit.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Decrement the connection limit.
(WebCore::WebCoreSynchronousLoader::adjustMaxConnections): Added this helper.
(WebCoreSynchronousLoader): Added a new SoupSession member.
(WebCore::sessionFromContext): Added this helper.
(WebCore::ResourceHandleInternal::soupSession): Use the new sessionFromContext helper.
(WebCore::ResourceHandle::loadResourceSynchronously): Pass the SoupSession from the NetworkingContext
to the synchronous loader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExplicitly mention Xcode version 4.3.2 in Mac debug instructions
dbates@webkit.org [Tue, 24 Apr 2012 01:27:39 +0000 (01:27 +0000)]
Explicitly mention Xcode version 4.3.2 in Mac debug instructions

Rubber-stamped by Eric Seidel.

The build location instructions at the top of page building/{debug-mac-uiprocess.html, debug.html}
are specific to Xcode 4.3.2.

* building/debug-mac-uiprocess.html: Substitute "Xcode 4.3.2" for "Xcode 4".
* building/debug.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r114965.
jer.noble@apple.com [Tue, 24 Apr 2012 01:25:43 +0000 (01:25 +0000)]
Unreviewed, rolling out r114965.
http://trac.webkit.org/changeset/114965
https://bugs.webkit.org/show_bug.cgi?id=84665

Four new resource load delegate test failures (Requested by
jernoble on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-23

Source/WebCore:

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
(WebCore::SubresourceLoader::releaseResources):

LayoutTests:

* http/tests/cache/cancel-during-failure-crash-expected.txt: Removed.
* http/tests/cache/cancel-during-failure-crash.html: Removed.
* platform/chromium-mac/security/block-test-expected.txt:
* platform/chromium-win/security/block-test-expected.txt:
* platform/gtk/security/block-test-expected.txt:
* platform/mac/security/block-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=84649
bdakin@apple.com [Tue, 24 Apr 2012 01:12:18 +0000 (01:12 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=84649
RenderMathMLOperator currently ignores font families, fails
to use Stix

Reviewed by Dan Bernstein.

This patch makes RenderMathMLOperator honor the font-family
list. This means that by default, Stix glyphs will now be
used for operators just like for other MathML content.
Unfortunately, just doing that resulted in a bug because of
the fragile hardcoded glyph sizes. The Stix vertical bar
glyph is much smaller than the code assumed any glyphs would
be. That code should be re-written, but in the meantime, I
put a fix in place to try to make it work for small glyphs.

These new functions should be used instead of accessing
gGlyphHeight or gGlyphLineHeight directly. If the glyph is
smaller than the expected hardcoded value, then the actual
glyph height is used, and a new line height based on the
glyph height is used.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::lineHeightForCharacter):

Use the style's FontDescription to honor the font family
list and the style's FontSelector to honor @font-face.
Also use glyphHeightForCharacter() instead of gGlyphHeight.
And now that createGlyph() takes a lineHeight, use
lineHeightForCharacter() to determine the right value.
(WebCore::RenderMathMLOperator::updateFromElement):

size was an ambiguous variable name, so I renamed it to the
more accurate maxHeightForRenderer. This function also now
takes a lineHeight instead of using gGlyphLineHeight. And
again, use the style's FontDescription and FontSelector.
(WebCore::RenderMathMLOperator::createStackableStyle):

Re-name size to maxHeightForRenderer, and take lineHeight as
a parameter.
(WebCore::RenderMathMLOperator::createGlyph):
* rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=84649
RenderMathMLOperator currently ignores font families, fails to use Stix

Reviewed by Dan Bernstein.

 Metrics are slightly different now that Stix glyphs are being used for operators.
* platform/mac/mathml/presentation/fenced-expected.txt:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReturn value from executed script in Chromium.
commit-queue@webkit.org [Tue, 24 Apr 2012 01:10:25 +0000 (01:10 +0000)]
Return value from executed script in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=79851

Patch by Eriq Augustine <eaugusti@chromium.org> on 2012-04-23
Reviewed by Adam Barth.

Source/WebCore:

Providing a varaiant of evaluateScriptInIsolatedWorld that
returns the value of the evaluated script.

Test: platform/chromium/http/tests/misc/execute-and-return-value.html

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluateInIsolatedWorld):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
* bindings/v8/V8Proxy.h:
(V8Proxy):

Source/WebKit/chromium:

Providing a variant of evaluateScriptInIsolatedWorld that
returns the value of the evaluated script.

* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeScriptInIsolatedWorldAndReturnValues):
(WebKit):
* src/WebFrameImpl.h:
(WebKit):
(WebFrameImpl):

Tools:

Adding a function to LayoutTestController that evaluates a script in
an isolated wold an returns the result of the evaluation.

* DumpRenderTree/LayoutTestController.cpp:
(evaluateScriptInIsolatedWorldAndReturnValue):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setXSSAuditorEnabled):
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):

LayoutTests:

Testing executing a script and getting the result of that script.

* platform/chromium/http/tests/misc/execute-and-return-value-expected.txt: Added.
* platform/chromium/http/tests/misc/execute-and-return-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderDetailsMarker should draw the triangle inside the content box
tkent@chromium.org [Tue, 24 Apr 2012 00:57:30 +0000 (00:57 +0000)]
RenderDetailsMarker should draw the triangle inside the content box
https://bugs.webkit.org/show_bug.cgi?id=84557

Reviewed by Hajime Morita.

Source/WebCore:

RenderDetailsMarker didn't support cases in which a marker has
borders and/or padings, or non-square size.

Test: fast/html/details-marker-style.html

* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::getPath):
Scale by contentWidth() and contentHeight().
(WebCore::RenderDetailsMarker::paint):
Move the trianle origin by the ammount of left/top borders and paddings.

LayoutTests:

* fast/html/details-marker-style.html: Added.
* platform/mac-snowleopard/fast/html/details-marker-style-expected.png: Added.
* platform/mac-snowleopard/fast/html/details-marker-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to toV8() (Part6)
haraken@chromium.org [Tue, 24 Apr 2012 00:52:26 +0000 (00:52 +0000)]
[V8] Pass Isolate to toV8() (Part6)
https://bugs.webkit.org/show_bug.cgi?id=84273

Reviewed by Nate Chapin.

The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8()s, I'll make the change
step by step. This patch passes Isolate to toV8() in
several custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::V8StyleSheetList::namedPropertyGetter):
* bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::transformToFragmentCallback):
(WebCore::V8XSLTProcessor::transformToDocumentCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove the content of LocalizedCalendarICU.cpp and LocalizedDateICU.cpp to ICULocale...
tkent@chromium.org [Tue, 24 Apr 2012 00:47:22 +0000 (00:47 +0000)]
Move the content of LocalizedCalendarICU.cpp and LocalizedDateICU.cpp to ICULocale.cpp.
https://bugs.webkit.org/show_bug.cgi?id=84568

Reviewed by Hajime Morita.

Move it to ICULocal.cpp because we want to share UDateFormat
object in LocalizedDate functions and LocalizedCalendar functions,
and it becomes easier to cache the UDateFormat object, and making
unit tests for these functions easier.

No new tests because of no bahevior changes.

* platform/text/ICULocale.cpp:
(WebCore::ICULocale::ICULocale): Initialize new members.
(WebCore::ICULocale::~ICULocale): Delete m_shortDateFormat.
(WebCore::ICULocale::initializeShortDateFormat):
Moved from creteShortDateFormatter of LocalizedDateICU.cpp.
(WebCore::ICULocale::parseLocalizedDate):
Moved from LocalizedDate.cpp, use m_shortDateFormat.
(WebCore::ICULocale::formatLocalizedDate): ditto.
(WebCore::ICULocale::createLabelVector):
Moved from LocalizedCalendarICU.cpp, use m_shortDateFormat.
(WebCore::createFallbackMonthLabels): Moved from LocalizedCalendarICU.cpp.
(WebCore::createFallbackWeekDayShortLabels): ditto.
(WebCore::ICULocale::initializeCalendar):
lazy initialization of m_monthLabels, m_weekDayShortLabels, and m_firstDayOfWeek.
(WebCore::ICULocale::monthLabels):
(WebCore::ICULocale::weekDayShortLabels):
(WebCore::ICULocale::firstDayOfWeek):
* platform/text/ICULocale.h:
(ICULocale): Add declarations.
* platform/text/LocalizedCalendarICU.cpp:
(WebCore::monthLabels): Use ICULocale::currentLocale().
(WebCore::weekDayShortLabels): ditto.
(WebCore::firstDayOfWeek): ditto.
* platform/text/LocalizedDateICU.cpp:
(WebCore::parseLocalizedDate): ditto.
(WebCore::formatLocalizedDate): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove AudioDestinationChromium FIFO class to its own class.
commit-queue@webkit.org [Tue, 24 Apr 2012 00:39:20 +0000 (00:39 +0000)]
Move AudioDestinationChromium FIFO class to its own class.
https://bugs.webkit.org/show_bug.cgi?id=84058

Patch by Raymond Toy <rtoy@google.com> on 2012-04-23
Reviewed by Chris Rogers.

Source/WebCore:

Current tests cover the changes.

* WebCore.gypi: Update with new files.
* platform/audio/AudioPullFIFO.cpp: Copied from Source/WebKit/chromium/src/AudioDestinationChromium.cpp.
(WebCore): Renamed old class the AudioPullFIFO.
(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::consume):
(WebCore::AudioPullFIFO::findWrapLengths):
(WebCore::AudioPullFIFO::fillBuffer):
* platform/audio/AudioPullFIFO.h: Added.
(WebCore):
(AudioPullFIFO):
(WebCore::AudioPullFIFO::updateIndex):

Source/WebKit/chromium:

Remove private FIFO class and use new AudioPullFIFO class.
* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
* src/AudioDestinationChromium.h:
(AudioDestinationChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG OSR exit should ensure that all variables have been initialized
fpizlo@apple.com [Tue, 24 Apr 2012 00:36:46 +0000 (00:36 +0000)]
DFG OSR exit should ensure that all variables have been initialized
https://bugs.webkit.org/show_bug.cgi?id=84653
<rdar://problem/11258183>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Initialize all uncaptured dead variables to undefined on OSR exit.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:

LayoutTests:

Reviewed by Gavin Barraclough.

* fast/js/dfg-dead-variable-on-exit-expected.txt: Added.
* fast/js/dfg-dead-variable-on-exit.html: Added.
* fast/js/script-tests/dfg-dead-variable-on-exit.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, test expectations update.
zmo@google.com [Tue, 24 Apr 2012 00:19:25 +0000 (00:19 +0000)]
Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: REGRESSION (r100311): YummySoup app crashes when trying to print
japhet@chromium.org [Tue, 24 Apr 2012 00:14:05 +0000 (00:14 +0000)]
Source/WebCore: REGRESSION (r100311): YummySoup app crashes when trying to print
https://bugs.webkit.org/show_bug.cgi?id=83918

Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/cancel-during-failure-crash.html

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel): Now that we might enter the function if we're already Finishing,
    some cleanup needs to be done in the Initialized state only.
(WebCore::SubresourceLoader::releaseResources): Move requesting counting decrement and laodDone() to
    the finishing functions.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83918.

Reviewed by Alexey Proskuryakov.

* http/tests/cache/cancel-during-failure-crash-expected.txt: Added.
* http/tests/cache/cancel-during-failure-crash.html: Added.
* platform/chromium-mac/security/block-test-expected.txt:
* platform/chromium-win/security/block-test-expected.txt:
* platform/gtk/security/block-test-expected.txt:
* platform/mac/security/block-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Split LayoutTests/ChangeLog.
haraken@chromium.org [Mon, 23 Apr 2012 23:57:40 +0000 (23:57 +0000)]
Unreviewed. Split LayoutTests/ChangeLog.

* ChangeLog-2012-04-23: Copied from LayoutTests/ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Visualize accelerated compositor rects.
shawnsingh@chromium.org [Mon, 23 Apr 2012 23:52:01 +0000 (23:52 +0000)]
[chromium] Visualize accelerated compositor rects.
https://bugs.webkit.org/show_bug.cgi?id=79400

Reviewed by Adrienne Walker.

No tests, all the code added is only debugging code.

This patch adds support for visualizing three different types of
rects on the chromium heads-up display:
1. updateRects that indicate what was painted/uploaded to a resource
2. propertyChangedRects that indicate layers that has property changes
3. surfaceDamageRects that are the accumulation of updateRects and
   propertyChangedRects, indicating what pixels on the screen have
   actually changed.  (Surface damage also accounts for newly exposed
   areas but that is not explicitly visualized.)

In addition to adding support for visualizing this, the
CCHeadsUpDisplay was significantly refactored, separating the FPS
Counter functionality into a different class, so that the heads-up
display is all about visualizing annotations, and those
annotations (frame rate, debug rects) are logged separately.

* WebCore.gypi:
* platform/graphics/chromium/cc/CCDebugRectHistory.cpp: Added.
(WebCore):
(WebCore::CCDebugRectHistory::CCDebugRectHistory):
(WebCore::CCDebugRectHistory::enabled):
(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):
(WebCore::CCDebugRectHistory::savePaintRects):
(WebCore::CCDebugRectHistory::savePropertyChangedRects):
(WebCore::CCDebugRectHistory::saveSurfaceDamageRects):
* platform/graphics/chromium/cc/CCDebugRectHistory.h: Added.
(WebCore):
(WebCore::CCDebugRect::CCDebugRect):
(CCDebugRect):
(CCDebugRectHistory):
(WebCore::CCDebugRectHistory::create):
(WebCore::CCDebugRectHistory::debugRects):
* platform/graphics/chromium/cc/CCFrameRateCounter.cpp: Added.
(WebCore):
(WebCore::safeMod):
(WebCore::CCFrameRateCounter::frameIndex):
(WebCore::CCFrameRateCounter::CCFrameRateCounter):
(WebCore::CCFrameRateCounter::markBeginningOfFrame):
(WebCore::CCFrameRateCounter::markEndOfFrame):
(WebCore::CCFrameRateCounter::isBadFrameInterval):
(WebCore::CCFrameRateCounter::isBadFrame):
(WebCore::CCFrameRateCounter::getAverageFPSAndStandardDeviation):
(WebCore::CCFrameRateCounter::timeStampOfRecentFrame):
* platform/graphics/chromium/cc/CCFrameRateCounter.h: Added.
(WebCore):
(CCFrameRateCounter):
(WebCore::CCFrameRateCounter::create):
(WebCore::CCFrameRateCounter::currentFrameNumber):
(WebCore::CCFrameRateCounter::timeStampHistorySize):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showDebugRects):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawDebugRects):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
(CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(WebCore::CCLayerTreeHostImpl::fpsCounter):
(WebCore::CCLayerTreeHostImpl::debugRectHistory):
(CCLayerTreeHostImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCut dependency on RenderLayer::scrollRectToVisible outside rendering
jchaffraix@webkit.org [Mon, 23 Apr 2012 23:49:34 +0000 (23:49 +0000)]
Cut dependency on RenderLayer::scrollRectToVisible outside rendering
https://bugs.webkit.org/show_bug.cgi?id=84607

Reviewed by Simon Fraser.

Source/WebCore:

Layering fix only, there should be no change behavior.

Because we don't have an accessor on RenderObject, a lot of the code needs
to know about RenderLayer. This is not necessary and exposes RenderLayer to
objects that shouldn't know about it.

This patch adds a RenderObject::scrollRectToVisible with the ad-hoc explanation
as to why it isn't on RenderBox (scrolling is a RenderBox concept).

* WebCore.exp.in:
* WebCore.order:
Updated to expose the new method.

* dom/Element.cpp:
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::updateFocusAppearance):
* editing/Editor.cpp:
(WebCore::Editor::findStringAndScrollToVisible):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::revealSelection):
* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
Updated those call sites to use the new function.

* rendering/RenderLayer.h:
Removed ScrollBehavior.h #include and default argument values
as we are always called through RenderObject now.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::scrollRectToVisible):
* rendering/RenderObject.h:
Added a new function that just forwards to the enclosing layer
if any. We return whether we actually tried to scroll to match
some call sites expectations.

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _scrollDOMRangeToVisible:]):
Updated to use RenderObject::scrollRectToVisible and not depend on RenderLayer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoframebuffer binding should not be changed after canvas resize or compositing
zmo@google.com [Mon, 23 Apr 2012 23:22:03 +0000 (23:22 +0000)]
framebuffer binding should not be changed after canvas resize or compositing
https://bugs.webkit.org/show_bug.cgi?id=84609

Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html

* html/canvas/WebGLRenderingContext.cpp: set framebuffer binding to DrawingBuffer.
(WebCore):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::loseContextImpl):
* platform/graphics/cairo/DrawingBufferCairo.cpp: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/chromium/DrawingBufferChromium.cpp: Ditto.
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/chromium/WebGLLayerChromium.cpp: Recover framebuffer binding after update().
(WebCore::WebGLLayerChromium::update):
* platform/graphics/gpu/DrawingBuffer.cpp: Add a function to restore framebuffer binding.
(WebCore::DrawingBuffer::restoreFramebufferBinding):
(WebCore):
* platform/graphics/gpu/DrawingBuffer.h: Ditto.
(WebCore::DrawingBuffer::setTexture2DBinding):
(DrawingBuffer):
(WebCore::DrawingBuffer::setFramebufferBinding):
* platform/graphics/gpu/mac/DrawingBufferMac.mm: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):

LayoutTests:

* fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize-expected.txt: Added.
* fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html: Added.
* fast/canvas/webgl/resources/webgl-test-utils.js: Sync with khronos side (partial)
(WebGLTestUtils.):
(WebGLTestUtils):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests fail intermittently with an exception
dpranke@chromium.org [Mon, 23 Apr 2012 23:13:13 +0000 (23:13 +0000)]
run-perf-tests fail intermittently with an exception
https://bugs.webkit.org/show_bug.cgi?id=83532

Reviewed by Ryosuke Niwa.

This bulletproofs port.get_option('child_processes')
against the case where the option wasn't set.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_get_crash_log):
(test_get_crash_log.fake_time_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCall instruction for the baseline JIT stores origin info in wrong callframe
oliver@apple.com [Mon, 23 Apr 2012 23:07:45 +0000 (23:07 +0000)]
Call instruction for the baseline JIT stores origin info in wrong callframe
https://bugs.webkit.org/show_bug.cgi?id=84645

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

The baseline JIT was updating the wrong callframe when making a call.  If the
call failed during dispatch (unable to perform codegen, calling a non-object)
we would attempt to use this information, but it would be completely wrong.

* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):

LayoutTests:

Directly force LLInt, Baseline, and DFG JITs to handle the path where
a call fails during dispatch.

* fast/js/script-tests/stack-trace.js:
(callNonCallable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] WebProcess should empty cache on a background thread/block.
kling@webkit.org [Mon, 23 Apr 2012 22:52:13 +0000 (22:52 +0000)]
[Mac] WebProcess should empty cache on a background thread/block.
<http://webkit.org/b/84619>
<rdar://problem/10668689>

Reviewed by Anders Carlsson.

Move the removeAllCachedResponses call to a dispatch queue and wait for it on exit.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/WebProcess.h:
(WebProcess):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::WebProcess::platformTerminate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify volume slider rendering
commit-queue@webkit.org [Mon, 23 Apr 2012 22:41:01 +0000 (22:41 +0000)]
Simplify volume slider rendering
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-23
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-controls-rendering-toggle-display-none.html

* css/mediaControlsChromium.css: Update controls css for Chromium.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
* css/mediaControlsGtk.css: Update controls css for GTK.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
* css/mediaControlsQuickTime.css: Update controls css for Safari.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
* html/shadow/MediaControlElements.cpp: Removed particular renderer.
(WebCore):
* html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement): Remoed particular renderer.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::create): Added a div element as a container. Removed extra unused mute button.
* html/shadow/MediaControlRootElementChromium.cpp: Added an extra div
element as a container for the mute button and the volume slider to
easily position them relative to each other.
(WebCore::MediaControlRootElementChromium::create):

LayoutTests:

Added new TEXT baselines for Mac.
Baselines for GTK and Chromium need to be re-generated as well.

* media/video-controls-rendering-toggle-display-none-expected.txt: Added.
* media/video-controls-rendering-toggle-display-none.html: Added.
* platform/chromium/test_expectations.txt: Updated test expectations
* platform/gtk/test_expectations.txt: Updated test expectations.
Commented out a duplicate test marked as CRASH because otherwise cq complains.
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Updated.
* platform/mac/media/audio-controls-rendering-expected.txt: Updated.
* platform/mac/media/audio-repaint-expected.txt: Updated.
* platform/mac/media/controls-after-reload-expected.txt: Updated.
* platform/mac/media/controls-strict-expected.txt: Updated.
* platform/mac/media/media-controls-clone-expected.txt: Updated.
* platform/mac/media/video-controls-rendering-expected.txt: Updated.
* platform/mac/media/video-display-toggle-expected.txt: Updated.
* platform/mac/media/video-no-audio-expected.txt: Updated.
* platform/mac/media/video-playing-and-pause-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG must keep alive values that it will perform speculations on
fpizlo@apple.com [Mon, 23 Apr 2012 22:36:08 +0000 (22:36 +0000)]
DFG must keep alive values that it will perform speculations on
https://bugs.webkit.org/show_bug.cgi?id=84638
<rdar://problem/11258183>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

* dfg/DFGNodeType.h:
(DFG):

LayoutTests:

Rubber stamped by Oliver Hunt.

* fast/js/dfg-dead-speculation-expected.txt: Added.
* fast/js/dfg-dead-speculation.html: Added.
* fast/js/script-tests/dfg-dead-speculation.js: Added.
(foo):
(.thingy.f.valueOf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add desktop zooming support for QQuickWebView
kbalazs@webkit.org [Mon, 23 Apr 2012 22:33:10 +0000 (22:33 +0000)]
[Qt] Add desktop zooming support for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=82337

Unreviewed typo fix after r114900.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow): Fix the mistyped
value of a zoom level.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix non-LLInt builds by temporarily removing an over-enthusiastic assertion
oliver@apple.com [Mon, 23 Apr 2012 22:07:55 +0000 (22:07 +0000)]
Fix non-LLInt builds by temporarily removing an over-enthusiastic assertion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium-android] Get rid of the trick that replaces system fallback font with DejaV...
commit-queue@webkit.org [Mon, 23 Apr 2012 21:59:17 +0000 (21:59 +0000)]
[chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
https://bugs.webkit.org/show_bug.cgi?id=84580

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-04-23
Reviewed by Ojan Vafai.

Android's first fallback font is changed to DroidSansArabic.ttf in JB.
Take the opportunity to get rid of the trick.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._push_fonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r109981.
commit-queue@webkit.org [Mon, 23 Apr 2012 21:58:43 +0000 (21:58 +0000)]
Unreviewed, rolling out r109981.
http://trac.webkit.org/changeset/109981
https://bugs.webkit.org/show_bug.cgi?id=84630

Broke Twitter map buddy icon (see
https://bugs.webkit.org/show_bug.cgi?id=84558) (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-23

Source/WebCore:

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

* compositing/layer-creation/overlap-empty-layer-expected.txt: Removed.
* compositing/layer-creation/overlap-empty-layer.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium roll 133422:133506.
dimich@chromium.org [Mon, 23 Apr 2012 20:32:33 +0000 (20:32 +0000)]
Chromium roll 133422:133506.
Not reviewed.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in RenderInline::clippedOverflowRectForRepaint for PrintPreview
eae@chromium.org [Mon, 23 Apr 2012 20:17:31 +0000 (20:17 +0000)]
Crash in RenderInline::clippedOverflowRectForRepaint for PrintPreview
https://bugs.webkit.org/show_bug.cgi?id=84300

Reviewed by Simon Fraser.

No new tests, have not been able to come up with a reliable reduction.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
Add NULL check for containingBlock() as it can return NULL when detached
from the tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r114929.
jer.noble@apple.com [Mon, 23 Apr 2012 20:12:20 +0000 (20:12 +0000)]
Unreviewed, rolling out r114929.
http://trac.webkit.org/changeset/114929
https://bugs.webkit.org/show_bug.cgi?id=84623

Broke 35 canvas/webgl tests (Requested by jernoble on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-23

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::loseContextImpl):
* platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::update):
* platform/graphics/gpu/DrawingBuffer.cpp:
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::setTexture2DBinding):
(DrawingBuffer):
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):

LayoutTests:

* fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize-expected.txt: Removed.
* fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html: Removed.
* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate around in V8Collection.h
haraken@chromium.org [Mon, 23 Apr 2012 20:06:11 +0000 (20:06 +0000)]
[V8] Pass Isolate around in V8Collection.h
https://bugs.webkit.org/show_bug.cgi?id=84299

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate around in V8Collection.h.

No tests. No change in behavior.

* bindings/v8/V8Collection.h:
(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotest-webkitpy is failing
dpranke@chromium.org [Mon, 23 Apr 2012 19:49:02 +0000 (19:49 +0000)]
test-webkitpy is failing
https://bugs.webkit.org/show_bug.cgi?id=84617

Reviewed by Eric Seidel.

* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
(HttpLockTestWithRealFileSystem.clean_all_lockfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to toV8() (Part5)
haraken@chromium.org [Mon, 23 Apr 2012 19:38:45 +0000 (19:38 +0000)]
[V8] Pass Isolate to toV8() (Part5)
https://bugs.webkit.org/show_bug.cgi?id=84271

Reviewed by Nate Chapin.

The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8(), I'll make the change
step by step. This patch passes Isolate to toV8()
in several custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):
(WebCore::toV8):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
* bindings/v8/custom/V8PerformanceCustom.cpp:
(WebCore::V8Performance::memoryAccessorGetter):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoframebuffer binding should not be changed after canvas resize or compositing
zmo@google.com [Mon, 23 Apr 2012 19:31:22 +0000 (19:31 +0000)]
framebuffer binding should not be changed after canvas resize or compositing
https://bugs.webkit.org/show_bug.cgi?id=84609

Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html

* html/canvas/WebGLRenderingContext.cpp: set framebuffer binding to DrawingBuffer.
(WebCore):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::loseContextImpl):
* platform/graphics/cairo/DrawingBufferCairo.cpp: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/chromium/DrawingBufferChromium.cpp: Ditto.
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/chromium/WebGLLayerChromium.cpp: Recover framebuffer binding after update().
(WebCore::WebGLLayerChromium::update):
* platform/graphics/gpu/DrawingBuffer.cpp: Add a function to restore framebuffer binding.
(WebCore::DrawingBuffer::restoreFramebufferBinding):
(WebCore):
* platform/graphics/gpu/DrawingBuffer.h: Ditto.
(WebCore::DrawingBuffer::setTexture2DBinding):
(DrawingBuffer):
(WebCore::DrawingBuffer::setFramebufferBinding):
* platform/graphics/gpu/mac/DrawingBufferMac.mm: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):

LayoutTests:

* fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize-expected.txt: Added.
* fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html: Added.
* fast/canvas/webgl/resources/webgl-test-utils.js: Sync with khronos side (partial)
(WebGLTestUtils.):
(WebGLTestUtils):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSplit up flakiness_dashboard.html into multiple files. This is a step in the direction
ojan@chromium.org [Mon, 23 Apr 2012 19:24:44 +0000 (19:24 +0000)]
Split up flakiness_dashboard.html into multiple files. This is a step in the direction
of making the code more maintainable (e.g. being able to use qunit for testing).

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
* TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to toV8() (Part4)
haraken@chromium.org [Mon, 23 Apr 2012 19:07:14 +0000 (19:07 +0000)]
[V8] Pass Isolate to toV8() (Part4)
https://bugs.webkit.org/show_bug.cgi?id=84269

Reviewed by Nate Chapin.

The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8()s, I'll make the change
step by step. This patch passes Isolate to toV8() in
several custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::allAccessorGetter):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
(WebCore::V8HTMLLinkElement::sizesAccessorGetter):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
* bindings/v8/custom/V8HTMLOutputElementCustom.cpp:
(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::indexedPropertyGetter):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up subpixel unit handling in hit testing code
eae@chromium.org [Mon, 23 Apr 2012 18:59:59 +0000 (18:59 +0000)]
Clean up subpixel unit handling in hit testing code
https://bugs.webkit.org/show_bug.cgi?id=84496

Reviewed by Eric Seidel.

Fix use of IntRect and LayoutRect in hit testing code in preparation for
subpixel layout.

No new tests, no change in functionality.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::rectForPoint):
Revert rectForPoint to IntRect as all call sites converted it to an
IntRect anyway to compare it with an IntPoint or another IntRect.

* rendering/HitTestingTransformState.cpp:
(WebCore::HitTestingTransformState::boundsOfMappedQuad):
* rendering/HitTestingTransformState.h:
Convert boundsOfMappedQuad to LayoutRect as the TransformationMatrix now
has subpixel precision.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to toV8() (Part3)
haraken@chromium.org [Mon, 23 Apr 2012 18:47:43 +0000 (18:47 +0000)]
[V8] Pass Isolate to toV8() (Part3)
https://bugs.webkit.org/show_bug.cgi?id=84261

Reviewed by Nate Chapin.

The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8(), I'll make the change
step by step. This patch passes Isolate to toV8()
in several custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::V8Document::createTouchListCallback):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore):
* bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to toV8() (Part2)
haraken@chromium.org [Mon, 23 Apr 2012 18:42:51 +0000 (18:42 +0000)]
[V8] Pass Isolate to toV8() (Part2)
https://bugs.webkit.org/show_bug.cgi?id=84259

Reviewed by Nate Chapin.

The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8(), I'll make the change
step by step. This patch passes Isolate to toV8() in
several custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::memoryAccessorGetter):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r114914.
dimich@chromium.org [Mon, 23 Apr 2012 18:34:58 +0000 (18:34 +0000)]
Unreviewed, rolling out r114914.
http://trac.webkit.org/changeset/114914
https://bugs.webkit.org/show_bug.cgi?id=84615

Causing infinite hangs on some tests involving HashMaps with
integer keys (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-23

* wtf/HashTable.h:
(WTF::HashTable::isEmptyBucket):
* wtf/HashTraits.h:
* wtf/text/StringHash.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Refactoring] Remove V8Proxy::toV8()
haraken@chromium.org [Mon, 23 Apr 2012 18:33:01 +0000 (18:33 +0000)]
[V8][Refactoring] Remove V8Proxy::toV8()
https://bugs.webkit.org/show_bug.cgi?id=84257

Reviewed by Nate Chapin.

Some constructorCallback()s are using V8Proxy::toV8(),
other constructorCallback()s are directly using setJSWrapperForXXX()
(XXX can be DOMObject, ActiveDOMObject, Node or ActiveNode).
We should unify them.

Considering the fact that V8Proxy::toV8() just supports
XXX=DOMObject and thus is not flexible, replacing V8Proxy::toV8()
with setJSWrapperForDOMObject() would make sense.

No tests. No change in behavior.

* bindings/v8/V8Proxy.h: Removed toV8().

* bindings/scripts/CodeGeneratorV8.pm: Replaced toV8() with setJSWrapperForDOMObject().
(GenerateEventConstructorCallback):
* bindings/v8/custom/V8ArrayBufferCustom.cpp: Ditto.
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h: Ditto.
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Ditto.
(WebCore::V8DOMFormData::constructorCallback):
* bindings/v8/custom/V8DataViewCustom.cpp: Ditto.
(WebCore::V8DataView::constructorCallback):
* bindings/v8/custom/V8MessageChannelConstructor.cpp: Ditto.
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8WebKitPointConstructor.cpp: Ditto.
(WebCore::V8WebKitPoint::constructorCallback):

* bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.
(WebCore::V8TestEventConstructor::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Not reviewed, rebaseline of button images after
dimich@chromium.org [Mon, 23 Apr 2012 18:21:48 +0000 (18:21 +0000)]
[Chromium] Not reviewed, rebaseline of button images after
Chromium change http://codereview.chromium.org/10107019/

* platform/chromium-linux/css3/selectors3/html/css3-modsel-161-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-19b-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-64-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-161-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-64-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-161-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-19b-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-64-expected.png:
* platform/chromium-linux/editing/pasteboard/4641033-expected.png:
* platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
* platform/chromium-linux/editing/pasteboard/4944770-2-expected.png:
* platform/chromium-linux/editing/selection/3690703-2-expected.png:
* platform/chromium-linux/editing/selection/3690703-expected.png:
* platform/chromium-linux/editing/selection/3690719-expected.png:
* platform/chromium-linux/editing/selection/4397952-expected.png:
* platform/chromium-linux/editing/selection/5240265-expected.png:
* platform/chromium-linux/editing/selection/caret-before-select-expected.png:
* platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png:
* platform/chromium-linux/editing/selection/select-box-expected.png:
* platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/chromium-linux/editing/selection/selection-button-text-expected.png:
* platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
* platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
* platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.png:
* platform/chromium-linux/fast/css/continuationCrash-expected.png:
* platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.png:
* platform/chromium-linux/fast/css/rtl-ordering-expected.png:
* platform/chromium-linux/fast/css/square-button-appearance-expected.png:
* platform/chromium-linux/fast/css/text-transform-select-expected.png:
* platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
* platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
* platform/chromium-linux/fast/forms/001-expected.png:
* platform/chromium-linux/fast/forms/003-expected.png:
* platform/chromium-linux/fast/forms/004-expected.png:
* platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png:
* platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png:
* platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png:
* platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png:
* platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png:
* platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png:
* platform/chromium-linux/fast/forms/basic-buttons-expected.png:
* platform/chromium-linux/fast/forms/basic-selects-expected.png:
* platform/chromium-linux/fast/forms/blankbuttons-expected.png:
* platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
* platform/chromium-linux/fast/forms/button-align-expected.png:
* platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.png:
* platform/chromium-linux/fast/forms/button-generated-content-expected.png:
* platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
* platform/chromium-linux/fast/forms/button-positioned-expected.png:
* platform/chromium-linux/fast/forms/button-sizes-expected.png:
* platform/chromium-linux/fast/forms/button-style-color-expected.png:
* platform/chromium-linux/fast/forms/button-table-styles-expected.png:
* platform/chromium-linux/fast/forms/button-text-transform-expected.png:
* platform/chromium-linux/fast/forms/button-white-space-expected.png:
* platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
* platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
* platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
* platform/chromium-linux/fast/forms/file/file-input-direction-expected.png:
* platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
* platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png:
* platform/chromium-linux/fast/forms/file/input-file-re-render-expected.png:
* platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
* platform/chromium-linux/fast/forms/formmove3-expected.png:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
* platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
* platform/chromium-linux/fast/forms/input-value-expected.png:
* platform/chromium-linux/fast/forms/menulist-deselect-update-expected.png:
* platform/chromium-linux/fast/forms/menulist-no-overflow-expected.png:
* platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
* platform/chromium-linux/fast/forms/menulist-separator-painting-expected.png:
* platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
* platform/chromium-linux/fast/forms/menulist-width-change-expected.png:
* platform/chromium-linux/fast/forms/option-script-expected.png:
* platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
* platform/chromium-linux/fast/forms/option-text-clip-expected.png:
* platform/chromium-linux/fast/forms/select-align-expected.png:
* platform/chromium-linux/fast/forms/select-baseline-expected.png:
* platform/chromium-linux/fast/forms/select-change-listbox-to-popup-expected.png:
* platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png:
* platform/chromium-linux/fast/forms/select-disabled-appearance-expected.png:
* platform/chromium-linux/fast/forms/select-initial-position-expected.png:
* platform/chromium-linux/fast/forms/select-selected-expected.png:
* platform/chromium-linux/fast/forms/select-size-expected.png:
* platform/chromium-linux/fast/forms/select-style-expected.png:
* platform/chromium-linux/fast/forms/select-visual-hebrew-expected.png:
* platform/chromium-linux/fast/forms/select-writing-direction-natural-expected.png:
* platform/chromium-linux/fast/forms/selectlist-minsize-expected.png:
* platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png:
* platform/chromium-linux/fast/forms/targeted-frame-submission-expected.png:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
* platform/chromium-linux/fast/html/details-replace-text-expected.png:
* platform/chromium-linux/fast/html/keygen-expected.png:
* platform/chromium-linux/fast/invalid/014-expected.png:
* platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
* platform/chromium-linux/fast/overflow/scrollRevealButton-expected.png:
* platform/chromium-linux/fast/parser/document-write-option-expected.png:
* platform/chromium-linux/fast/repaint/control-clip-expected.png:
* platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-linux/fast/replaced/three-selects-break-expected.png:
* platform/chromium-linux/fast/replaced/width100percent-button-expected.png:
* platform/chromium-linux/fast/selectors/064-expected.png:
* platform/chromium-linux/fast/table/append-cells2-expected.png:
* platform/chromium-linux/fast/table/remove-td-display-none-expected.png:
* platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
* platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
* platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
* platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-linux/fullscreen/full-screen-iframe-zIndex-expected.png:
* platform/chromium-linux/fullscreen/full-screen-remove-ancestor-after-expected.png:
* platform/chromium-linux/fullscreen/full-screen-zIndex-after-expected.png:
* platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
* platform/chromium-linux/tables/mozilla/core/margins-expected.png:
* platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
* platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
* platform/chromium-mac-leopard/fast/forms/box-shadow-override-expected.txt: Removed.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug26178-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.txt: Removed.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to toV8() (Part1)
haraken@chromium.org [Mon, 23 Apr 2012 18:18:20 +0000 (18:18 +0000)]
[V8] Pass Isolate to toV8() (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84250

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch makes a change in CodeGeneratorV8.pm so that the
generated code passes Isolate to toV8().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(NativeToJSValue):

* bindings/scripts/test/V8/V8Float64Array.cpp: Updated run-bindings-tests results.
(WebCore::Float64ArrayV8Internal::fooCallback):
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::mutablePointAttrGetter):
(WebCore::TestObjV8Internal::immutablePointAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add an optional Isolate argument to setDOMException() and throwError()
haraken@chromium.org [Mon, 23 Apr 2012 17:47:54 +0000 (17:47 +0000)]
[V8] Add an optional Isolate argument to setDOMException() and throwError()
https://bugs.webkit.org/show_bug.cgi?id=84310

Reviewed by Nate Chapin.

The objective is to pass Isolate to setDOMException()
and throwError(). This patch adds an optional Isolate argument
to setDOMException() and throwError(). I'll pass the Isolate
to these methods in the following patches.

No tests. No change in behavior.

* bindings/v8/V8Proxy.cpp:
(WebCore):
(WebCore::V8Proxy::setDOMException):
(WebCore::V8Proxy::throwError):
* bindings/v8/V8Proxy.h:
(V8Proxy):
(WebCore):
(WebCore::throwError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocss3/zoom-coords.xml failing after http://trac.webkit.org/changeset/114811
jer.noble@apple.com [Mon, 23 Apr 2012 17:42:19 +0000 (17:42 +0000)]
css3/zoom-coords.xml failing after trac.webkit.org/changeset/114811
https://bugs.webkit.org/show_bug.cgi?id=84612

Unreviewed partial rollout of r114811.

* css3/zoom-coords-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Convert touch-point area.
commit-queue@webkit.org [Mon, 23 Apr 2012 17:36:57 +0000 (17:36 +0000)]
[Qt][WK2] Convert touch-point area.
https://bugs.webkit.org/show_bug.cgi?id=84434

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Missed WebKit2 conversion in commit r106470.

* Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):

Tools:

Add feature to set touch-point radius for emitted touch-events.

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::addTouchPoint):
(EventSender::updateTouchPoint):
(EventSender::setTouchPointRadius):
(EventSender::clearTouchPoints):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender):

LayoutTests:

Expand the basic touch test, to check touch-point radius, if feature
is available in EventSender.

* fast/events/touch/script-tests/basic-single-touch-events.js:
(verifyTouchPoint):
(verifyTouch):
(singleTouchSequence):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Properly ignore unsupported animation directions.
commit-queue@webkit.org [Mon, 23 Apr 2012 17:28:42 +0000 (17:28 +0000)]
[chromium] Properly ignore unsupported animation directions.
https://bugs.webkit.org/show_bug.cgi?id=84599

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-23
Reviewed by Adrienne Walker.

Source/WebCore:

Tested in CCLayerAnimationControllerTest.ignoreUnsupportedAnimationDirections.

* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

Source/WebKit/chromium:

* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIterating a HashMap<String, X> involves a string equality comparison to check for...
darin@apple.com [Mon, 23 Apr 2012 17:26:18 +0000 (17:26 +0000)]
Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524

Reviewed by Antti Koivisto.

Added a new algorithm for checking for empty buckets that can be specialized.
Specialized it for String. We may later want to do the same thing for KURL.
It's not important to do it for AtomicString, since AtomicString's == function
is already a simple pointer equality compare.

* wtf/HashTable.h:
(WTF::HashTable::isEmptyBucket): Call the new isHashTraitsEmptyValue function, which
will do something more efficient for String.

* wtf/HashTraits.h: Added hasIsEmptyValueFunction to hash traits, with a default value
of false. This allows us to continue to get automatic comparison with the appropriate
emptyValue result for all existing traits, but supply a custom isEmptyValue function
for HashTraits<String>. Putting an isEmptyValue function into the traits would require
overriding it in every class that has a custom value for emptyValue. Specialized
HashTraits for String to add hasIsEmptyValueFunction and declare, but not define, the
isEmptyValue function.
(WTF::isHashTraitsEmptyValue): Added a function that uses the HashTraitsEmptyValueChecker
struct to use either == combined with the emptyValue function or the isEmptyValue function.
(PairHashTraits): Define hasIsEmptyValueFunction and isEmptyValue.

* wtf/text/StringHash.h: Removed unneeded includes and sorted the using statements at
the bottom of the file.
(WTF::HashTraits<String>::isEmptyValue): Define this function here, since here we have
included the WTFString.h header; the HashTraits.h header compiles without WTFString.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
pierre.rossi@gmail.com [Mon, 23 Apr 2012 16:58:25 +0000 (16:58 +0000)]
[Qt] Unreviewed gardening.

Unskip the tests skipped in r114905.

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Performance][V8] Skip Isolate look-up to find StringCache
haraken@chromium.org [Mon, 23 Apr 2012 16:55:13 +0000 (16:55 +0000)]
[Performance][V8] Skip Isolate look-up to find StringCache
https://bugs.webkit.org/show_bug.cgi?id=84103

Reviewed by Nate Chapin.

This patch improves the performance of a lot of DOM attribute
getters that return a string.

- Improves the performance of Dromaeo/dom-attr.html(element.property)
  by 27.7%.
- Improves the performance of Dromaeo/dom-attr.html(getAttribute)
  by 10.6%.
- Improves the performance of div.id, div.className,
  div.nodeName, text.nodeValue, text.textContent by 12% -- 21%.

The followings are the test results in my Linux desktop.

Performance test: Dromaeo/dom-attr.html
Total:                     674.64runs/s ->  707.03runs/s (+ 4.8%)
getAttribute:             1537.60runs/s -> 1700.20runs/s (+10.6%)
element.property:         1389.00runs/s -> 1774.20runs/s (+27.7%)
setAttribute:              538.88runs/s ->  548.87runs/s (+ 1.9%)
element.property = value:  644.07runs/s ->  656.67runs/s (+ 2.0%)
element.expando = value:   219.76runs/s ->  207.14runs/s (- 6.8%)
element.expando:           578.77runs/s ->  554.67runs/s (- 4.2%)

Performance test: https://bugs.webkit.org/attachment.cgi?id=137440
div.id:           30.70ns -> 26.70ns (+15%)
div.className:    31.10ns -> 26.40ns (+18%)
div.nodeName:     37.70ns -> 33.00ns (+14%)
text.nodeValue:   31.40ns -> 25.90ns (+21%)
text.textContent: 51.50ns -> 45.90ns (+12%)

Previously V8 bindings need to look up an Isolate to find
an Isolate-local StringCache. This patch skips the look-up
by getting the Isolate from AccessorInfo.GetIsolate()
or Arguments.GetIsolate().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
* bindings/v8/V8Binding.h:
(WebCore::v8ExternalString): Make 'isolate' an optional argument.
Ideally we want to make 'isolate' a non-optional argument,
but it is difficult to rewrite all v8ExternalString() callers
at a breath. We can rewrite them incrementally.
(WebCore::v8String): Ditto.
(WebCore::v8StringOrNull): Ditto.
(WebCore::v8StringOrUndefined): Ditto.
(WebCore::v8StringOrFalse): Ditto.

* bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add an optional Isolate argument to wrap()
haraken@chromium.org [Mon, 23 Apr 2012 16:50:53 +0000 (16:50 +0000)]
[V8] Add an optional Isolate argument to wrap()
https://bugs.webkit.org/show_bug.cgi?id=84202

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to wrap().
After rewriting all wrap() callers so that they pass Isolate
to wrap(), I'll make the Isolate argument non-optional.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateHeader):
* bindings/v8/custom/V8DocumentCustom.cpp: Ditto.
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp: Ditto.
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.
(WebCore::toV8):
* dom/make_names.pl: Ditto.
(printWrapperFactoryCppFile):

* bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to toV8Slow()
haraken@chromium.org [Mon, 23 Apr 2012 16:46:04 +0000 (16:46 +0000)]
[V8] Pass Isolate to toV8Slow()
https://bugs.webkit.org/show_bug.cgi?id=84173

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to toV8Slow().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r114855): fast/js/global-constructors.html, fast/dom/Window/window-proper...
jer.noble@apple.com [Mon, 23 Apr 2012 16:44:36 +0000 (16:44 +0000)]
REGRESSION (r114855): fast/js/global-constructors.html, fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html failing.
https://bugs.webkit.org/show_bug.cgi?id=84604

Unreviewed gardening; add new expected failing tests to test_expectations.txt.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r114899
pierre.rossi@gmail.com [Mon, 23 Apr 2012 16:30:26 +0000 (16:30 +0000)]
[Qt] Unreviewed gardening after r114899

* platform/qt-5.0/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Added.
* platform/qt-5.0/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Added.
* platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
* platform/qt-5.0/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Added.
* platform/qt-5.0/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Added.
* platform/qt-5.0/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Added.
* platform/qt-5.0/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c414-flt-02-c-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c414-flt-03-c-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c414-flt-04-c-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5525-fltblck-01-d-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: Added.
* platform/qt-5.0/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t090501-c414-flt-01-b-expected.txt: Added.
* platform/qt-5.0/css2.1/t090501-c414-flt-03-b-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt: Added.
* platform/qt-5.0/css2.1/t1202-counter-03-b-expected.txt: Added.
* platform/qt-5.0/css2.1/t1202-counter-04-b-expected.txt: Added.
* platform/qt-5.0/css2.1/t1202-counters-03-b-expected.txt: Added.
* platform/qt-5.0/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Added.
* platform/qt-5.0/editing/deleting/5144139-2-expected.txt: Added.
* platform/qt-5.0/editing/selection/click-left-of-rtl-wrapping-text-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
* platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/qt-5.0/fast/borders/bidi-002-expected.txt: Added.
* platform/qt-5.0/fast/borders/bidi-009a-expected.txt: Added.
* platform/qt-5.0/fast/borders/bidi-012-expected.txt: Added.
* platform/qt-5.0/fast/css/beforeSelectorOnCodeElement-expected.txt: Added.
* platform/qt-5.0/fast/forms/listbox-bidi-align-expected.txt: Added.
* platform/qt-5.0/fast/forms/search-rtl-expected.txt: Added.
* platform/qt-5.0/fast/repaint/continuation-after-outline-expected.txt: Added.
* platform/qt-5.0/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
* platform/qt-5.0/fast/text/backslash-to-yen-sign-expected.txt: Added.
* platform/qt-5.0/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
* platform/qt-5.0/fast/text/soft-hyphen-3-expected.txt: Added.
* platform/qt-5.0/fast/text/softHyphen-expected.txt: Added.
* platform/qt-5.0/fast/writing-mode/fallback-orientation-expected.txt: Added.
* platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
* platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
* platform/qt-5.0/svg/hixie/intrinsic/003-expected.txt: Added.
* platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add an optional Isolate argument to toV8().
haraken@chromium.org [Mon, 23 Apr 2012 16:20:06 +0000 (16:20 +0000)]
[V8] Add an optional Isolate argument to toV8().
https://bugs.webkit.org/show_bug.cgi?id=84161

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to toV8().
After rewriting all toV8() callers so that they pass Isolate,
I will make the Isolate argument non-optional.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
Modified as described above.
(GenerateHeader):
(NativeToJSValue):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):

* bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(WebCore):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElement...
commit-queue@webkit.org [Mon, 23 Apr 2012 16:10:37 +0000 (16:10 +0000)]
[EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
https://bugs.webkit.org/show_bug.cgi?id=84425

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-23
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add a helper function to DumpRenderTreeSupportEfl, returning
whether or not an element does perform autocompletion.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Use the new helper in DumpRenderTreeSupportEfl to properly
test whether an element performs autocompletion.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::elementDoesAutoCompleteForElementWithId):

LayoutTests:

Unskip the newly-passing test now that EFL's LayoutTestController
implements elementDoesAutoCompleteForElementWithId().

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new failing tests. (less tests == less problem)
ossy@webkit.org [Mon, 23 Apr 2012 16:08:09 +0000 (16:08 +0000)]
[Qt] Unreviewed gardening, skip new failing tests. (less tests == less problem)

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskip passing web storage tests
commit-queue@webkit.org [Mon, 23 Apr 2012 16:04:23 +0000 (16:04 +0000)]
[EFL] Unskip passing web storage tests
https://bugs.webkit.org/show_bug.cgi?id=84342

Unreviewed gardening.

Unskiped the passing tests and moved the remainig ones to
tests_expectations.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-23

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomaster.cfg cleanup, remove dead codes after r92792.
ossy@webkit.org [Mon, 23 Apr 2012 15:34:36 +0000 (15:34 +0000)]
cfg cleanup, remove dead codes after r92792.
https://bugs.webkit.org/show_bug.cgi?id=84433

Relanding r114881 after typo fix in UploadBuiltProduct.

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Fix build break when non-cross platform CONTEXT_MENUS are enabled.
commit-queue@webkit.org [Mon, 23 Apr 2012 15:05:37 +0000 (15:05 +0000)]
[EFL][WK2] Fix build break when non-cross platform CONTEXT_MENUS are enabled.
https://bugs.webkit.org/show_bug.cgi?id=84136

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-04-23
Reviewed by Andreas Kling.

There was a mismatch between contextMenuItemVector declaration and definition.
Fixed by changing PlatformMenuDescription for EFL port by adding a const modifier.

No new tests required.

* platform/PlatformMenuDescription.h:
(WebCore): Added const modifier to PlatformMenuDescription definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Need to support requestAnimationFrame
commit-queue@webkit.org [Mon, 23 Apr 2012 15:05:17 +0000 (15:05 +0000)]
[EFL][DRT] Need to support requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=84585

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-23
Reviewed by Martin Robinson.

Tools:

Making requestAnimationFrame() support a default on the EFL build.

* Scripts/build-webkit:

LayoutTests:

Unskipping cases related to requestAnimationFrame().
Moving leftover cases to test_expectations.txt for separate
analysis.

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add desktop zooming support for QQuickWebView
kbalazs@webkit.org [Mon, 23 Apr 2012 14:56:40 +0000 (14:56 +0000)]
[Qt] Add desktop zooming support for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=82337

Reviewed by Simon Hausmann.

Source/WebKit2:

Add private C++ API for programmatic zooming.
This is important on desktop where we don't
have any way to zoom currently.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::zoomFactor):
(QQuickWebViewLegacyPrivate::setZoomFactor):
(QQuickWebView::zoomFactor):
(QQuickWebView::setZoomFactor):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::zoomFactor):
(QQuickWebViewPrivate::setZoomFactor):
(QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate):

Tools:

Add zooming support for MiniBrowser to
test the new API.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::keyPressEvent):
(BrowserWindow::wheelEvent):
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Ensure zero-width space effectively accounts for a width of zero.
pierre.rossi@gmail.com [Mon, 23 Apr 2012 14:55:31 +0000 (14:55 +0000)]
[Qt] Ensure zero-width space effectively accounts for a width of zero.
https://bugs.webkit.org/show_bug.cgi?id=84595

Reviewed by Simon Hausmann.

The logic so far relies on FontCache::getFontDataForCharacters to
return a valid fontData in the case where the fonts specified don't
have a glyph for the zero-width space character.
QTextLayout::glyphRuns simply ignores characters that don't render in
the glyph runs it returns, so we need to ensure that the subsequent
call to platformWidthForGlyph doesn't lead to a non-zero width.

Covered by tests containing control characters such as
a soft-hyphen like it's the case in:
svg/as-image/img-preserveAspectRatio-support-1.html

* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] When prepareToDraw fails due to animation checkerboard, we need to call...
commit-queue@webkit.org [Mon, 23 Apr 2012 14:53:10 +0000 (14:53 +0000)]
[chromium] When prepareToDraw fails due to animation checkerboard, we need to call setNeedsCommit
https://bugs.webkit.org/show_bug.cgi?id=84520

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-23
Reviewed by Adrienne Walker.

Source/WebCore:

Tested in CCLayerTreeHostImplTest.prepareToDrawFailsWhenAnimationUsesCheckerboard

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Move non-api classes to WebKit namespace at WebKit2/UiProcess/qt
commit-queue@webkit.org [Mon, 23 Apr 2012 14:43:41 +0000 (14:43 +0000)]
[Qt][WK2] Move non-api classes to WebKit namespace at WebKit2/UiProcess/qt
https://bugs.webkit.org/show_bug.cgi?id=84528

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-23
Reviewed by Simon Hausmann.

Fix namespace usage in non-api classes for Qt.

* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/API/qt/qquickwebpage_p.h:
(WebKit):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(WebKit):
(QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
* UIProcess/API/qt/qquickwebview_p_p.h:
(WebKit):
(QQuickWebViewPrivate::viewportInteractionEngine):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::viewportInteractionEngine):
(QQuickWebViewFlickablePrivate):
* UIProcess/API/qt/qwebdownloaditem_p.h:
(WebKit):
* UIProcess/API/qt/qwebviewportinfo.cpp:
* UIProcess/qt/LayerBackingStore.cpp:
* UIProcess/qt/LayerBackingStore.h:
(WebKit):
* UIProcess/qt/QtDialogRunner.cpp:
(WebKit):
* UIProcess/qt/QtDialogRunner.h:
(WebKit):
* UIProcess/qt/QtDownloadManager.cpp:
* UIProcess/qt/QtDownloadManager.h:
(WebKit):
* UIProcess/qt/QtGestureRecognizer.cpp:
* UIProcess/qt/QtGestureRecognizer.h:
(WebKit):
* UIProcess/qt/QtPageClient.cpp:
(WebKit):
* UIProcess/qt/QtPageClient.h:
(WebKit):
(QtPageClient):
* UIProcess/qt/QtPanGestureRecognizer.cpp:
* UIProcess/qt/QtPanGestureRecognizer.h:
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
* UIProcess/qt/QtPinchGestureRecognizer.h:
* UIProcess/qt/QtTapGestureRecognizer.h:
(WebKit):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebContext.cpp:
* UIProcess/qt/QtWebContext.h:
* UIProcess/qt/QtWebError.cpp:
(WebKit):
* UIProcess/qt/QtWebError.h:
(WebKit):
* UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit):
* UIProcess/qt/QtWebIconDatabaseClient.h:
(WTF):
(WebKit):
(QtWebIconDatabaseClient):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit):
* UIProcess/qt/QtWebPageEventHandler.h:
(WebCore):
(WebKit):
* UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit):
* UIProcess/qt/QtWebPageLoadClient.h:
(WebKit):
* UIProcess/qt/QtWebPagePolicyClient.cpp:
(WebKit):
* UIProcess/qt/QtWebPagePolicyClient.h:
(WebKit):
* UIProcess/qt/QtWebPageSGNode.cpp:
* UIProcess/qt/QtWebPageSGNode.h:
(WebKit):
* UIProcess/qt/QtWebPageUIClient.cpp:
* UIProcess/qt/QtWebPageUIClient.h:
(WebKit):
* UIProcess/qt/QtWebUndoController.cpp:
(WebKit):
* UIProcess/qt/QtWebUndoController.h:
(WebKit):
* UIProcess/qt/WebContextMenuProxyQt.cpp:
* UIProcess/qt/WebContextQt.cpp:
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
* UIProcess/qt/WebGeolocationProviderQt.cpp:
(WebKit):
* UIProcess/qt/WebGeolocationProviderQt.h:
(WebKit):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit):
* UIProcess/qt/WebPopupMenuProxyQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 14:35:13 +0000 (14:35 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84596

Mark media/encrypted-media/encrypted-media-events.html as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify CSSParser::parseFont.
alexis.menard@openbossa.org [Mon, 23 Apr 2012 14:26:55 +0000 (14:26 +0000)]
Simplify CSSParser::parseFont.
https://bugs.webkit.org/show_bug.cgi?id=78698

Reviewed by Antti Koivisto.

Source/WebCore:

Simplify parseFont by sharing the code we have for
the longhands of the font property.

No new tests : Extend the existing font shorthand test and modify expected files
as now the order of the longhands added in the property list of the style
has changed. It's very unlikely that some code is relying on this order though. It will
also match the way the spec order them http://www.w3.org/TR/css3-fonts/#font-prop
even though the order is arbitrary for some values.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseLineHeight):
(WebCore):
(WebCore::CSSParser::parseFontSize):
(WebCore::CSSParser::parseFontWeight):  Fix a bug discovered while using parseFontWeight from
the parseFont (case font: 0/0, Arial, sans-serif; in a layout test), we should return true only
when we add something in the property list.
* css/CSSParser.h:

LayoutTests:

Added new incorrect values to improve the test coverage of the font shorthand property.

The patch changed the order the longhands are added to the list
of properties for the style so the expected files need to be updated.

* fast/css/font-shorthand-expected.txt:
* fast/css/font-shorthand.html:
* fast/inspector-support/style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: improve the way heap snapshot diff is calculated
yurys@chromium.org [Mon, 23 Apr 2012 13:48:57 +0000 (13:48 +0000)]
Web Inspector: improve the way heap snapshot diff is calculated
https://bugs.webkit.org/show_bug.cgi?id=84590

Diff calculation now consists of the following steps:
1. Collect data about nodes in the base heap snapshot
2. Pass it to the second snapshot.
3. Calculate delta for each class.

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshot.prototype.calculateSnapshotDiff):
(WebInspector.HeapSnapshot.prototype._calculateDiffForClass):
(WebInspector.HeapSnapshot.prototype.createAddedNodesProvider):
(WebInspector.HeapSnapshot.prototype.createDeletedNodesProvider):
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren.aggregatesForDiffReceived.didCalculateSnapshotDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotIteratorsTuple):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshotProxy.prototype.calculateSnapshotDiff):
(WebInspector.HeapSnapshotProxy.prototype.createAddedNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createDeletedNodesProvider):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 13:39:24 +0000 (13:39 +0000)]
[Chromium] Unreviewed test expectations update.
http://webkit.org/b/72402

Unmark compositing/layer-creation/overflow-scroll-overlap.html as failing

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Rename and extract UISourceCodeImpl into JavaScriptSource
pfeldman@chromium.org [Mon, 23 Apr 2012 13:26:20 +0000 (13:26 +0000)]
Web Inspector: Rename and extract UISourceCodeImpl into JavaScriptSource
https://bugs.webkit.org/show_bug.cgi?id=84587

Reviewed by Yury Semikhatsky.

Source/WebCore:

No changes other than extraction here. This is the first step in the Resource
hierarchy refactoring described in bug 84586.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.addScript):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/JavaScriptSource.js: Added.
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.breakpoints):
(WebInspector.JavaScriptSource.prototype.breakpointAdded):
(WebInspector.JavaScriptSource.prototype.breakpointRemoved):
(WebInspector.JavaScriptSource.prototype.consoleMessages):
(WebInspector.JavaScriptSource.prototype.consoleMessageAdded):
(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium roll from r133348 to r133422.
mnaganov@chromium.org [Mon, 23 Apr 2012 13:15:09 +0000 (13:15 +0000)]
Chromium roll from r133348 to r133422.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove ReferrerPolicy out of SecurityPolicy class into its own header in platform.
gavinp@chromium.org [Mon, 23 Apr 2012 12:53:24 +0000 (12:53 +0000)]
Move ReferrerPolicy out of SecurityPolicy class into its own header in platform.
https://bugs.webkit.org/show_bug.cgi?id=84516

Source/WebCore:

Reviewed by Adam Barth.

No change in behaviour; same enum, different class.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::processReferrerPolicy):
* dom/Document.h:
(WebCore::Document::referrerPolicy):
(Document):
* page/SecurityPolicy.h:
* platform/ReferrerPolicy.h: Added.
(WebCore):

Source/WebKit/chromium:

Reviewed by Adam Barth.

No change in behaviour; same enum, different class.

* src/AssertMatchingEnums.cpp:
* src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::generateReferrerHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 12:37:50 +0000 (12:37 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=70765

Unmark fast/forms/listbox-clip.html on Windows

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 12:15:43 +0000 (12:15 +0000)]
[Chromium] Unreviewed test expectations update.
http://crbug.com/23494

Unmark css2.1/t1503-c522-font-family-00-b.html on Leopard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJS binding code generator doesn't handle "attribute unsigned long[]" well
commit-queue@webkit.org [Mon, 23 Apr 2012 11:34:27 +0000 (11:34 +0000)]
JS binding code generator doesn't handle "attribute unsigned long[]" well
https://bugs.webkit.org/show_bug.cgi?id=84540

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-23
Reviewed by Kentaro Hara.

Codegenerator should handle spaces with the sequence<> to support
numeric types like "unsigned long", "int" .. etc. and primitive types
like "boolean", "Date" etc.

Tests: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGenerator.pm:
(SkipIncludeHeader): Rename AvoidInclusionOfType to SkipIncludeHeader.
(GetArrayType):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorObjC.pm:
(AddIncludesForType):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
(GetHeaderClassInclude):
(GenerateNormalAttrGetter):
(NativeToJSValue):
* bindings/scripts/IDLStructure.pm:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjIntSequenceAttr):
(WebCore::jsTestObjShortSequenceAttr):
(WebCore::jsTestObjLongSequenceAttr):
(WebCore::jsTestObjLongLongSequenceAttr):
(WebCore::jsTestObjUnsignedIntSequenceAttr):
(WebCore::jsTestObjUnsignedShortSequenceAttr):
(WebCore::jsTestObjUnsignedLongSequenceAttr):
(WebCore::jsTestObjUnsignedLongLongSequenceAttr):
(WebCore::jsTestObjFloatSequenceAttr):
(WebCore::jsTestObjDoubleSequenceAttr):
(WebCore::jsTestObjBooleanSequenceAttr):
(WebCore::jsTestObjVoidSequenceAttr):
(WebCore::jsTestObjDateSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjIntSequenceAttr):
(WebCore::setJSTestObjShortSequenceAttr):
(WebCore::setJSTestObjLongSequenceAttr):
(WebCore::setJSTestObjLongLongSequenceAttr):
(WebCore::setJSTestObjUnsignedIntSequenceAttr):
(WebCore::setJSTestObjUnsignedShortSequenceAttr):
(WebCore::setJSTestObjUnsignedLongSequenceAttr):
(WebCore::setJSTestObjUnsignedLongLongSequenceAttr):
(WebCore::setJSTestObjFloatSequenceAttr):
(WebCore::setJSTestObjDoubleSequenceAttr):
(WebCore::setJSTestObjBooleanSequenceAttr):
(WebCore::setJSTestObjVoidSequenceAttr):
(WebCore::setJSTestObjDateSequenceAttr):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::intSequenceAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::intSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrSetter):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rolling out r114881, because it broke upload buildstep.
ossy@webkit.org [Mon, 23 Apr 2012 10:50:20 +0000 (10:50 +0000)]
Unreviewed rolling out r114881, because it broke upload buildstep.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ConfigureBuild.__init__):
(ConfigureBuild.start):
(CompileWebKit.start):
(UploadBuiltProduct):
(UploadBuiltProduct.determineExtraFeatures):
(Factory.__init__):
(BuildFactory.__init__):
(TestFactory.__init__):
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed assertion fix for Chromium bots.
kling@webkit.org [Mon, 23 Apr 2012 10:44:27 +0000 (10:44 +0000)]
Unreviewed assertion fix for Chromium bots.

Skip unnecessary Attr::attachToElement() after constructing an Attr using the
constructor that attaches to an Element.

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureAttr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114885 268f45cc-cd09-0410-ab3c-d52691b4dbfc